commit-bot@chromium.org [Thu, 17 Apr 2014 21:31:32 +0000 (21:31 +0000)]
Revert of Roll ANGLE. (https://codereview.chromium.org/
237173002/)
Reason for revert:
http://skbug.com/2437
Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
R=bsalomon@chromium.org, geofflang@chromium.org
TBR=bsalomon@chromium.org, geofflang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2272
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
238863006
git-svn-id: http://skia.googlecode.com/svn/trunk@14248
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 21:09:49 +0000 (21:09 +0000)]
Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/
207683004/)
Reason for revert:
Causing memory leaks in Chromium.
Original issue's description:
> Extract most of the mutable state of SkShader into a separate Context object.
>
> SkShader currently stores some state during draw calls via setContext(...).
> Move that mutable state into a separate SkShader::Context class that is
> constructed on demand for the duration of the draw.
>
> Calls to setContext() are replaced with createContext() which returns a context
> corresponding to the shader object or NULL if the parameters to createContext
> are invalid.
>
> TEST=out/Debug/dm
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14216
R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
241283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14247
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 17 Apr 2014 21:09:00 +0000 (21:09 +0000)]
Revert r14218.
git-svn-id: http://skia.googlecode.com/svn/trunk@14246
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 21:02:29 +0000 (21:02 +0000)]
Revert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/
240303003/)
Reason for revert:
This and https://codereview.chromium.org/
207683004 are causing memory leaks.
Original issue's description:
> Fix memory leak in SkGradientShader.
>
> Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap.
> Rename methods returning a "pre-reffed" object to indicate obligations.
>
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14223
R=reed@google.com, scroggo@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
241603002
git-svn-id: http://skia.googlecode.com/svn/trunk@14245
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 19:41:06 +0000 (19:41 +0000)]
SkiaSampleRenderer - handle case where compiler won't cast jint to void*.
R=djsollen@google.com, scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
239703016
git-svn-id: http://skia.googlecode.com/svn/trunk@14244
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 18:29:06 +0000 (18:29 +0000)]
Roll ANGLE.
BUG=skia:2272
R=bsalomon@chromium.org, bsalomon@google.com
Author: geofflang@chromium.org
Review URL: https://codereview.chromium.org/
237173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14243
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 17:28:20 +0000 (17:28 +0000)]
Ashmem functions compile when size_t != __u32
R=djsollen@google.com, scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
241123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14242
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 16:46:07 +0000 (16:46 +0000)]
add some asserts for mipmaps, and cleanup fFilterLevel if mipping failed
BUG=skia:
R=scroggo@google.com, humper@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
240633003
git-svn-id: http://skia.googlecode.com/svn/trunk@14241
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 Apr 2014 16:14:26 +0000 (16:14 +0000)]
fix expected size in 32bit builds
BUG=skia:
Review URL: https://codereview.chromium.org/
240283012
git-svn-id: http://skia.googlecode.com/svn/trunk@14240
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 16:11:58 +0000 (16:11 +0000)]
allow gyp_skia to be run from any directory.
R=epoger@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
240383003
git-svn-id: http://skia.googlecode.com/svn/trunk@14239
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 15:19:32 +0000 (15:19 +0000)]
Orphan ProcXfermode, with an eye towards removing it
BUG=skia:
R=scroggo@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
240533003
git-svn-id: http://skia.googlecode.com/svn/trunk@14238
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 15:18:21 +0000 (15:18 +0000)]
remove unused tests to fix new clang build
R=mtklein@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
241043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14237
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 13:57:31 +0000 (13:57 +0000)]
Revert of Add flipped gradient branch to two point conical gradient (https://codereview.chromium.org/
227623004/)
Reason for revert:
Breaking all CompareGMs
Original issue's description:
> Add flipped gradient branch to two point conical gradient
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14235
R=bsalomon@google.com, mtklein@google.com
TBR=bsalomon@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
239993006
git-svn-id: http://skia.googlecode.com/svn/trunk@14236
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Apr 2014 13:28:06 +0000 (13:28 +0000)]
Add flipped gradient branch to two point conical gradient
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
227623004
git-svn-id: http://skia.googlecode.com/svn/trunk@14235
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 17 Apr 2014 03:05:10 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14234
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 23:06:29 +0000 (23:06 +0000)]
More flags needed to build Android framework.
R=djsollen@google.com
TBR=djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
240563005
git-svn-id: http://skia.googlecode.com/svn/trunk@14233
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 22:10:52 +0000 (22:10 +0000)]
Don't unset gFCSafeToUse when it's still safe to use.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
240513003
git-svn-id: http://skia.googlecode.com/svn/trunk@14232
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 22:10:48 +0000 (22:10 +0000)]
install_dependencides tool for posix-type systems
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
239303010
git-svn-id: http://skia.googlecode.com/svn/trunk@14231
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 22:08:32 +0000 (22:08 +0000)]
Support picture recording in Android framework.
Fixes master-skia build.
R=djsollen@google.com
TBR=djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
240093007
git-svn-id: http://skia.googlecode.com/svn/trunk@14230
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 20:48:10 +0000 (20:48 +0000)]
always store bitfields along with dirty in FlatteningTraits
This allows us to simplify lots of setters in SkPaint, which in the non-android case, could now be just assignments (and therefore inlineable).
R=mtklein@google.com, robertphillips@google.com, tomhudson@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
240273004
git-svn-id: http://skia.googlecode.com/svn/trunk@14229
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 20:31:54 +0000 (20:31 +0000)]
Roll ANGLE.
Contains small changes to ANGLE to pass skia tests.
BUG=skia:2272
R=bsalomon@google.com
Author: geofflang@chromium.org
Review URL: https://codereview.chromium.org/
235923020
git-svn-id: http://skia.googlecode.com/svn/trunk@14228
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 19:21:00 +0000 (19:21 +0000)]
This is an short replacement for gclient.
Makes use of our current DEPS file to allow for a smooth transition.
BUG=skia:291
NOTRY=true
R=borenet@google.com, tfarina@chromium.org, epoger@google.com, mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
191133005
git-svn-id: http://skia.googlecode.com/svn/trunk@14227
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Apr 2014 17:10:12 +0000 (17:10 +0000)]
Reverting r14225 (Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling - https://codereview.chromium.org/
237673017/) due to compiler complaints
git-svn-id: http://skia.googlecode.com/svn/trunk@14226
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Apr 2014 17:00:05 +0000 (17:00 +0000)]
Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling
https://codereview.chromium.org/
237673017/
git-svn-id: http://skia.googlecode.com/svn/trunk@14225
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 16:24:08 +0000 (16:24 +0000)]
read/write function_ptrs as just void*, and not as 'array of bytes'
BUG=skia:
R=mtklein@google.com, bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
240013005
git-svn-id: http://skia.googlecode.com/svn/trunk@14224
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 16:17:39 +0000 (16:17 +0000)]
Fix memory leak in SkGradientShader.
Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap.
Rename methods returning a "pre-reffed" object to indicate obligations.
BUG=skia:1976
R=reed@google.com, scroggo@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
240303003
git-svn-id: http://skia.googlecode.com/svn/trunk@14223
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 16:07:37 +0000 (16:07 +0000)]
Double assignment in GrGpuGL::configToGLFormats()
Remove the first one.
R=hcm@google.com, bsalomon@google.com
BUG=skia:2427
Author: siglesias@igalia.com
Review URL: https://codereview.chromium.org/
240123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14222
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 16:02:10 +0000 (16:02 +0000)]
Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API
This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag
from the public API (more work needs to be done in Blink & Chrome). In the new world the only way
to set this flag (and thus instantiate an SkPicture-derived
class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using
factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and
do away with the SkPicture-derived classes.
BUG=skia:2315
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
239703006
git-svn-id: http://skia.googlecode.com/svn/trunk@14221
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 14:33:27 +0000 (14:33 +0000)]
glDiscardFramebuffer() in GrGpuGL::discard uses invalid GLenum
According to the spec:
"If a framebuffer object is bound to <target>, then <attachments> may
contain COLOR_ATTACHMENT0, DEPTH_ATTACHMENT, and/or
STENCIL_ATTACHMENT. If the framebuffer object is not complete,
DiscardFramebufferEXT may be ignored.
If the default framebuffer is bound to <target>,
then <attachment> may contain COLOR, identifying the color buffer;
DEPTH, identifying the depth buffer; or STENCIL, identifying the
stencil buffer."
Do the same as in glInvalidateFramebuffer() case.
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
R=bsalomon@google.com
BUG=skia:2411
Author: siglesias@igalia.com
Review URL: https://codereview.chromium.org/
236193007
git-svn-id: http://skia.googlecode.com/svn/trunk@14220
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Apr 2014 13:48:52 +0000 (13:48 +0000)]
Update baselines for bug 2404.
BUG=skia:2404
Review URL: https://codereview.chromium.org/
240303002
git-svn-id: http://skia.googlecode.com/svn/trunk@14219
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Apr 2014 13:44:43 +0000 (13:44 +0000)]
fix #if SK_DEBUG -- should be #ifdef SK_DEBUG
git-svn-id: http://skia.googlecode.com/svn/trunk@14218
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 12:58:02 +0000 (12:58 +0000)]
remove legacy filter-flags, and store FilterLevel directly
BUG=skia:
R=robertphillips@google.com, humper@google.com, jvanverth@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
239393002
git-svn-id: http://skia.googlecode.com/svn/trunk@14217
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Apr 2014 10:16:39 +0000 (10:16 +0000)]
Extract most of the mutable state of SkShader into a separate Context object.
SkShader currently stores some state during draw calls via setContext(...).
Move that mutable state into a separate SkShader::Context class that is
constructed on demand for the duration of the draw.
Calls to setContext() are replaced with createContext() which returns a context
corresponding to the shader object or NULL if the parameters to createContext
are invalid.
TEST=out/Debug/dm
BUG=skia:1976
R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
207683004
git-svn-id: http://skia.googlecode.com/svn/trunk@14216
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 16 Apr 2014 03:04:01 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14215
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 23:00:57 +0000 (23:00 +0000)]
Fix bug in SampleApp's Tiling View
SampleApp was crashing when invoked as "SampleApp --slide Tiling" due to r14171 (split SkPictureRecorder out of SkPicture - https://codereview.chromium.org/
214953003/)
R=bungeman@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
239353006
git-svn-id: http://skia.googlecode.com/svn/trunk@14214
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Apr 2014 21:43:57 +0000 (21:43 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)
git-svn-id: http://skia.googlecode.com/svn/trunk@14213
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 21:37:12 +0000 (21:37 +0000)]
Fix generation of Android SampleApp APK now that we default to using gyp's ninja generator.
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
235783003
git-svn-id: http://skia.googlecode.com/svn/trunk@14212
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 21:11:09 +0000 (21:11 +0000)]
Pull ANGLE's new repository to third_party/external/angle2.
BUG=skia:2272
R=bsalomon@chromium.org, bsalomon@google.com
Author: geofflang@chromium.org
Review URL: https://codereview.chromium.org/
239593002
git-svn-id: http://skia.googlecode.com/svn/trunk@14211
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 20:29:38 +0000 (20:29 +0000)]
arm64_download script - fix error starting vm twice.
R=epoger@google.com
TBR=epoger@google.com
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
239653003
git-svn-id: http://skia.googlecode.com/svn/trunk@14210
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 20:05:24 +0000 (20:05 +0000)]
arm64_download script waits for VM to boot before finishing.
It may take an unknown amount of time to boot.
Also, add `set -e` to the script to simplify error handling.
BUG=skia:2425
NOTRY=true
R=epoger@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
239243005
git-svn-id: http://skia.googlecode.com/svn/trunk@14209
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Apr 2014 19:39:52 +0000 (19:39 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)
git-svn-id: http://skia.googlecode.com/svn/trunk@14208
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 18:50:12 +0000 (18:50 +0000)]
Revert of rebaseline_server: multithreaded loading/diffing of images (https://codereview.chromium.org/
235923002/)
Reason for revert:
Caused https://code.google.com/p/skia/issues/detail?id=2423 ('"Deadline exceeded" error when connecting to live rebaseline_server'). Reverting until I can figure it out.
Original issue's description:
> rebaseline_server: multithreaded loading/diffing of images
>
> BUG=skia:2414
> NOTRY=True
>
> Committed: http://code.google.com/p/skia/source/detail?r=14184
R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2414
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
239623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14207
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Apr 2014 18:35:49 +0000 (18:35 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)
git-svn-id: http://skia.googlecode.com/svn/trunk@14206
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Apr 2014 18:24:58 +0000 (18:24 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)
git-svn-id: http://skia.googlecode.com/svn/trunk@14205
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 18:00:57 +0000 (18:00 +0000)]
initialize bounds in this test
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
238353007
git-svn-id: http://skia.googlecode.com/svn/trunk@14204
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 17:53:21 +0000 (17:53 +0000)]
Fix artifacts in distance field rendering due to bilerp
Because we were using the full distance field glyph rect, there were cases
when a neighboring texel might be set to full value (e.g. we might copy the
glyph over old data after a purge). This was giving artifacts, and insetting
the rect by 1 solves the problem. In doing this, I discovered that removing the
extra 1 texel pad around the glyph meant to handle bilerp, and insetting by 2,
works just as well and saves space in the glyph atlas.
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
239333002
git-svn-id: http://skia.googlecode.com/svn/trunk@14203
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Apr 2014 16:08:29 +0000 (16:08 +0000)]
Add cast for warning as error on Windows from r14201.
git-svn-id: http://skia.googlecode.com/svn/trunk@14202
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Apr 2014 15:52:07 +0000 (15:52 +0000)]
Fix size of rotated text with FreeType.
This generalizes and shares the solution found for a similar issue with
GDI. The issue is that the text size is applied early, and the rest of
the transformation late. This allows us to isolate and independently
control the text size from the rest of the transformation.
R=reed@google.com
Review URL: https://codereview.chromium.org/
213153006
git-svn-id: http://skia.googlecode.com/svn/trunk@14201
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 15:48:36 +0000 (15:48 +0000)]
Make sure SkDrawLooper objects can only be allocated on the heap.
Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public.
Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is
used to create new objects.
Provide factory method for creating SkBlurDrawLooper.
BUG=2141
R=scroggo@google.com, reed@google.com, djsollen@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
232913003
git-svn-id: http://skia.googlecode.com/svn/trunk@14200
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 15:37:51 +0000 (15:37 +0000)]
Add GL_CHROMIUM_map_sub functions to GrGLInterface and bit to GrGLCaps.
BUG=skia:2402
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
231773003
git-svn-id: http://skia.googlecode.com/svn/trunk@14199
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 15:26:50 +0000 (15:26 +0000)]
ignore Test-Linux-Bare-NoGPU-Arm8_64 GM failures
(SkipBuildbotRuns)
BUG=skia:2422
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com
TBR=halcanary
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
239323002
git-svn-id: http://skia.googlecode.com/svn/trunk@14198
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 14:27:14 +0000 (14:27 +0000)]
SkRecord bug fixes
Optional arguments to SkCanvas calls leaked refs (but not memory) because we
didn't destruct the optional objects (really, just SkPaint: other optional args
are all POD). This adds Optional and PODArray, where Optional makes sure to
call the destructor.
I overlooked that SkPictureRecord really does call paint.computeFastBounds().
Do the same in SkRecordDraw.
BUG=skia:2378
R=reed@google.com, mtklein@google.com, tomhudson@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
235983015
git-svn-id: http://skia.googlecode.com/svn/trunk@14197
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 15 Apr 2014 03:04:18 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14196
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Apr 2014 00:43:51 +0000 (00:43 +0000)]
More sanitizing input.
Also fix issue with parsing time on MySQL.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
235953008
git-svn-id: http://skia.googlecode.com/svn/trunk@14195
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 14 Apr 2014 22:28:00 +0000 (22:28 +0000)]
Update pathops gms for r14183.
git-svn-id: http://skia.googlecode.com/svn/trunk@14194
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 22:05:07 +0000 (22:05 +0000)]
Move distance field generation to the glyph cache.
Distance fields are currently created in GrTextStrike, which is the wrong place. This moves that to the glyph cache where it belongs.
As part of my testing, I found that when we fall back to paths in the GrDistanceFieldTextContext it was not scaling them properly, so that's fixed in here too.
R=robertphillips@google.com, reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
227593010
git-svn-id: http://skia.googlecode.com/svn/trunk@14193
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 20:35:12 +0000 (20:35 +0000)]
SkRecordDraw: use SkCanvas::quickRejectY for text draws
PS 1) factor apart into canSkip, draw, updateClip
PS 2) use quickRejectY for text
BUG=skia:2378
R=fmalita@chromium.org, reed@google.com, mtklein@google.com, tomhudson@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
233493004
git-svn-id: http://skia.googlecode.com/svn/trunk@14192
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 20:33:05 +0000 (20:33 +0000)]
SkRecord: turn on cull annotation pass in public API.
Also, switch Skia internal tools over to use the public headers where
possible. Where it's not, the tools -Isrc/record explicitly now, and
if it's not obvious, note why they don't use SkRecording.h.
BUG=skia:2378
R=reed@google.com, mtklein@google.com, fmalita@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
231853006
git-svn-id: http://skia.googlecode.com/svn/trunk@14191
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 20:12:08 +0000 (20:12 +0000)]
Add /recent, a page that displays the last 20 tries.
Also broke out CSS as a separate file and added a title bar across both pages to easily navigate between Home and Recent.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
236193011
git-svn-id: http://skia.googlecode.com/svn/trunk@14190
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 19:49:53 +0000 (19:49 +0000)]
change #if SK_DEBUG to #ifdef SK_DEBUG
fix broken build
change #if DEBUG to #ifdef DEBUG (fixes canary)
NOTRY=true
R=reed@google.com
TBR=reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
237573002
git-svn-id: http://skia.googlecode.com/svn/trunk@14189
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 18:56:43 +0000 (18:56 +0000)]
rebaseline pathopsinverse GMs
to account for https://skia.googlesource.com/skia.git/+/
4431e7757cfcb8cfa99535eed0e9f156dabf95c2
NOTRY=True
R=caryclark@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
233253006
git-svn-id: http://skia.googlecode.com/svn/trunk@14188
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 18:53:10 +0000 (18:53 +0000)]
Now with permalinks.
Once we get a response from our XHR request update the URL to a permalink to that code.
This CL comes after https://codereview.chromium.org/
235373002/
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
235323006
git-svn-id: http://skia.googlecode.com/svn/trunk@14187
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 18:33:03 +0000 (18:33 +0000)]
fix broken build
change 'char' to 'int8_t'
BUG=skia:
NOTRY=true
TBR=reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
237263004
git-svn-id: http://skia.googlecode.com/svn/trunk@14186
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 14 Apr 2014 18:27:18 +0000 (18:27 +0000)]
Revert "Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/
120633004/)"
This reverts commit
e9d2798fd37e2fb33b545d142a5baa21a4b747fe.
BUG=skia:
Review URL: https://codereview.chromium.org/
236303008
git-svn-id: http://skia.googlecode.com/svn/trunk@14185
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 18:15:29 +0000 (18:15 +0000)]
rebaseline_server: multithreaded loading/diffing of images
BUG=skia:2414
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
235923002
git-svn-id: http://skia.googlecode.com/svn/trunk@14184
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 17:08:59 +0000 (17:08 +0000)]
Mike R: please sanity check SkPostConfig.h
Mike K: please sanity check Test.cpp and skia_test.cpp
Feel free to look at the rest, but I don't expect any in depth review of path ops innards.
Path Ops first iteration used QuickSort to order segments radiating from an intersection to compute the winding rule.
This revision uses a circular sort instead. Breaking out the circular sort into its own long-lived structure (SkOpAngle) allows doing less work and provides a home for caching additional sorting data.
The circle sort is more stable than the former sort, has a robust ordering and fewer exceptions. It finds unsortable ordering less often. It is less reliant on the initial curve tangent, using convex hulls instead whenever it can.
Additional debug validation makes sure that the computed structures are self-consistent. A new visualization tool helps verify that the angle ordering is correct.
The 70+M tests pass with this change on Windows, Mac, Linux 32 and Linux 64 in debug and release.
R=mtklein@google.com, reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
131103009
git-svn-id: http://skia.googlecode.com/svn/trunk@14183
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 16:02:31 +0000 (16:02 +0000)]
Add conical special cases to GradientBench
BUG=skia:
R=reed@google.com, bsalomon@google.com, robertphillips@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
234603006
git-svn-id: http://skia.googlecode.com/svn/trunk@14182
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 14 Apr 2014 15:51:48 +0000 (15:51 +0000)]
Allow clients to specify an external SkImageFilter cache.
This change allows external callers to substitute their own
SkImageFilter cache for the default intra-frame cache in Skia. This
allows the caller to perform inter-frame caching for example, by the
maintaining a persistent cache between frames and doing custom
invalidation.
R=reed@google.com
Review URL: https://codereview.chromium.org/
225903010
git-svn-id: http://skia.googlecode.com/svn/trunk@14181
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 15:45:58 +0000 (15:45 +0000)]
Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/
120633004/)
Reason for revert:
Broke build.
Original issue's description:
> use templates instead of macros to build blitters
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14178
R=mtklein@google.com, reed@google.com
TBR=mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
236593006
git-svn-id: http://skia.googlecode.com/svn/trunk@14180
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:50 +0000 (15:02 +0000)]
Remove currently unused code
This code is currently unused and is contrary to the way in which we seem to be moving towards accomplishing this (i.e., device-specific optimization passes).
This is a partial revert of r13704 (First version of bitmap use tracking in SkPictureRecord - https://codereview.chromium.org/
187833003/)
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
237013002
git-svn-id: http://skia.googlecode.com/svn/trunk@14179
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:35 +0000 (15:02 +0000)]
use templates instead of macros to build blitters
BUG=
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
120633004
git-svn-id: http://skia.googlecode.com/svn/trunk@14178
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:19 +0000 (15:02 +0000)]
resize canvas for GM + typo
This change resized the canvas for some GM cases. It is better to show the visual difference in viewer.html for these cases after the CL applied.
BUG=skia:2375
R=reed@google.com, djsollen@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
221953002
git-svn-id: http://skia.googlecode.com/svn/trunk@14177
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 14:54:22 +0000 (14:54 +0000)]
Xfermode: SSE2 implementation of a number of simple transfer modes
These modes share some common code and not very complex, so group them
together. This CL yields about 50% performance improvement on desktop
i7-3770. Here are the data:
before:
Xfermode_Screen 8888: cmsecs = 30.25 565: cmsecs = 46.81
Xfermode_Modulate 8888: cmsecs = 22.48 565: cmsecs = 40.06
Xfermode_Plus 8888: cmsecs = 21.04 565: cmsecs = 37.51
Xfermode_Xor 8888: cmsecs = 37.18 565: cmsecs = 52.53
Xfermode_DstATop 8888: cmsecs = 28.97 565: cmsecs = 46.42
Xfermode_SrcATop 8888: cmsecs = 29.74 565: cmsecs = 46.25
Xfermode_DstOut 8888: cmsecs = 5.34 565: cmsecs = 24.53
Xfermode_SrcOut 8888: cmsecs = 12.25 565: cmsecs = 24.39
Xfermode_DstIn 8888: cmsecs = 5.30 565: cmsecs = 24.50
Xfermode_SrcIn 8888: cmsecs = 12.05 565: cmsecs = 25.40
Xfermode_DstOver 8888: cmsecs = 12.45 565: cmsecs = 0.15
Xfermode_SrcOver 8888: cmsecs = 2.68 565: cmsecs = 4.42
after:
Xfermode_Screen 8888: cmsecs = 13.68 565: cmsecs = 21.73
Xfermode_Modulate 8888: cmsecs = 13.25 565: cmsecs = 20.97
Xfermode_Plus 8888: cmsecs = 9.77 565: cmsecs = 16.71
Xfermode_Xor 8888: cmsecs = 17.64 565: cmsecs = 25.62
Xfermode_DstATop 8888: cmsecs = 15.99 565: cmsecs = 23.74
Xfermode_SrcATop 8888: cmsecs = 15.69 565: cmsecs = 23.40
Xfermode_DstOut 8888: cmsecs = 4.77 565: cmsecs = 11.85
Xfermode_SrcOut 8888: cmsecs = 4.98 565: cmsecs = 11.84
Xfermode_DstIn 8888: cmsecs = 4.68 565: cmsecs = 11.72
Xfermode_SrcIn 8888: cmsecs = 4.93 565: cmsecs = 11.79
Xfermode_DstOver 8888: cmsecs = 5.04 565: cmsecs = 0.15
Xfermode_SrcOver 8888: cmsecs = 2.69 565: cmsecs = 4.42
BUG=skia:
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
232793002
git-svn-id: http://skia.googlecode.com/svn/trunk@14176
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 14:54:07 +0000 (14:54 +0000)]
Add design for sql storage, implementation of db that stores the data, not retrieving yet.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
235373002
git-svn-id: http://skia.googlecode.com/svn/trunk@14175
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 14:53:58 +0000 (14:53 +0000)]
More removal of duplicate framework defines.
BUG=skia:1975
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
228343003
git-svn-id: http://skia.googlecode.com/svn/trunk@14174
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 14 Apr 2014 14:53:53 +0000 (14:53 +0000)]
Remove duplicate skia_android_framework defines.
BUG=skia:1975
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
225283022
git-svn-id: http://skia.googlecode.com/svn/trunk@14173
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Mon, 14 Apr 2014 03:04:57 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14172
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 13 Apr 2014 19:09:42 +0000 (19:09 +0000)]
split SkPictureRecorder out of SkPicture
https://codereview.chromium.org/
214953003/
git-svn-id: http://skia.googlecode.com/svn/trunk@14171
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 13 Apr 2014 18:01:01 +0000 (18:01 +0000)]
Adding image-surface to ignored-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@14170
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 12 Apr 2014 13:35:46 +0000 (13:35 +0000)]
bench rebase test
e93a4c0
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
235913004
git-svn-id: http://skia.googlecode.com/svn/trunk@14169
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 12 Apr 2014 03:05:59 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14168
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 21:45:41 +0000 (21:45 +0000)]
rebaseline_server: fix sorting by perceptual diff column
(SkipBuildbotRuns)
BUG=skia:2410
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
235993002
git-svn-id: http://skia.googlecode.com/svn/trunk@14167
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 20:30:58 +0000 (20:30 +0000)]
bench rebase test
28fcae2
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
235283005
git-svn-id: http://skia.googlecode.com/svn/trunk@14166
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 19:54:16 +0000 (19:54 +0000)]
Further adjust bench expectations calculation.
BUG=skia:2225
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
235693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14165
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 19:07:40 +0000 (19:07 +0000)]
bench rebase test
1f75ab9
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
235483004
git-svn-id: http://skia.googlecode.com/svn/trunk@14164
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 19:06:46 +0000 (19:06 +0000)]
use the correct rowBytes so Debug build doesn't assert
BUG=skia:2378
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
235453002
git-svn-id: http://skia.googlecode.com/svn/trunk@14163
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 19:05:22 +0000 (19:05 +0000)]
remove dead code from SkPicturePlayback
This is from an earlier iteration of the pull-forward task before we switched to doing the majority of the work in SkGpuDevice.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
235473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14162
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 19:00:28 +0000 (19:00 +0000)]
R=robertphillips@google.com
TBR=robertphillips@google.com
BUG=skia:
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
235603002
git-svn-id: http://skia.googlecode.com/svn/trunk@14161
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 18:57:00 +0000 (18:57 +0000)]
Implement intra-frame cacheing in image filters.
When image filters are processed within Skia, they simply do
a blind recursion. This has the side-effect of turning the
DAG into a tree. I.e., nodes visited more than once during
the traversal will be processed more than once.
This change implements a very simple cacheing scheme: a
cache is created before traversing the DAG, and handed
into the processing traversal. Before recursing into a child
in SkImageFilter::filterImage(), the cache is checked for a
hit, and early-out is performed. Otherwise, the node is
processed, and its result bitmap and location (offset) are
cached, but only if it contains two or more children and
thus will be visited again during the traversal.
Currently, the child count is approximated with the
refcount. This is good enough in most cases (and exactly
correct for the Chrome use case). We could add an exact
child count to the image filter, but this will require
violating the immutability of image filters slightly in
order to bump the child count as nodes are connected. I
leave it up to the reviewer to decide which is better.
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
230653005
git-svn-id: http://skia.googlecode.com/svn/trunk@14160
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 18:34:35 +0000 (18:34 +0000)]
remove picture-backed surfaces
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
233943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14159
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 18:33:31 +0000 (18:33 +0000)]
Mark our territory with (C).
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
235253002
git-svn-id: http://skia.googlecode.com/svn/trunk@14158
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 11 Apr 2014 18:22:44 +0000 (18:22 +0000)]
Update Android expectations to reflect the new default gamma for fonts.
see https://code.google.com/p/skia/source/detail?r=14148 for the responsible CL.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
228323006
git-svn-id: http://skia.googlecode.com/svn/trunk@14157
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 17:15:40 +0000 (17:15 +0000)]
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/
234243002/)
Reason for revert:
Want to reland the original CL.
Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/
227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144
R=reed@google.com, bensong@google.com
TBR=bensong@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
235523003
git-svn-id: http://skia.googlecode.com/svn/trunk@14156
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 16:13:54 +0000 (16:13 +0000)]
use SkIntToScalar, fix windows build
NOTRY=true
NOTREECHECKS=true
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
234913004
git-svn-id: http://skia.googlecode.com/svn/trunk@14155
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 15:54:14 +0000 (15:54 +0000)]
Update bench to be able to preprocess skps
This allows benchmarking of optimization improvements and plumbs in the purging API. The purging is necessary so we don't magically get faster because the saveLayers are always pre-generated.
R=jvanverth@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
233663002
git-svn-id: http://skia.googlecode.com/svn/trunk@14154
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 15:54:06 +0000 (15:54 +0000)]
remove guard for getTotalClip
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
235093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14153
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 15:53:47 +0000 (15:53 +0000)]
Rename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased)
This is mainly a renaming CL but it does add a ref-counted ptr to the backing GrTexture for non-atlased layers (the only kind working right now)
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
233703003
git-svn-id: http://skia.googlecode.com/svn/trunk@14152
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 15:53:39 +0000 (15:53 +0000)]
Add bench_playback, for quick profiling of SKR playback.
It is not completely fair to compare --skr and --noskr numbers. SKR looks
unfairly good because some optimizations are baked into our SKPs at record
time. But, at least, by using a kWriteOnly_Mode SkRecorder, we prevent
SkPicturePlayback from compounding that unfairness. SkRecordDraw must handle
its own playback-time optimizations (quickrejects) on its own.
This code should look suspiciously similar to bench_record.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
233833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14151
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 14:49:50 +0000 (14:49 +0000)]
add some .gitignores related to gm and tools
NOTREECHECKS=True
NOTRY=True
R=scroggo@google.com
TBR=scroggo
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
234603004
git-svn-id: http://skia.googlecode.com/svn/trunk@14150
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 11 Apr 2014 13:47:30 +0000 (13:47 +0000)]
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/
227433009/)
Reason for revert:
Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now.
Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117
R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
234833003
git-svn-id: http://skia.googlecode.com/svn/trunk@14149
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log