tfarina@chromium.org [Mon, 1 Oct 2012 16:39:06 +0000 (16:39 +0000)]
Add moc generated files to .gitignore.
So that git status is clean again.
R=tomhudson@google.com
Review URL: https://codereview.appspot.com/6591045
git-svn-id: http://skia.googlecode.com/svn/trunk@5750
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Mon, 1 Oct 2012 16:14:21 +0000 (16:14 +0000)]
views: Fix a typo in SkEvent.h
WndProc is not implemented by unix/linux and does not even compile fixing the
typoe, so just remove these function declarations.
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6561062
git-svn-id: http://skia.googlecode.com/svn/trunk@5749
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 1 Oct 2012 15:39:22 +0000 (15:39 +0000)]
Change the ios sample app name.
Review URL: https://codereview.appspot.com/6597053
git-svn-id: http://skia.googlecode.com/svn/trunk@5748
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@google.com [Mon, 1 Oct 2012 15:27:14 +0000 (15:27 +0000)]
Adding virtual method to SkDeferredCanvas::NotificationClient for signaling when commands are skipped due to the skip on clear optimization.
TEST=DeferredCanvas unit test
BUG=http://code.google.com/p/chromium/issues/detail?id=116840
Review URL: https://codereview.appspot.com/6590050
git-svn-id: http://skia.googlecode.com/svn/trunk@5747
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 1 Oct 2012 14:58:57 +0000 (14:58 +0000)]
re-land removal of setBitmapDevice
git-svn-id: http://skia.googlecode.com/svn/trunk@5746
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 1 Oct 2012 14:32:51 +0000 (14:32 +0000)]
Fixed bug in drawing of large bitmaps
https://codereview.appspot.com/6595047/
git-svn-id: http://skia.googlecode.com/svn/trunk@5745
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 30 Sep 2012 21:05:15 +0000 (21:05 +0000)]
Rolling back r5732 due to Chrome Mac compiler issues
git-svn-id: http://skia.googlecode.com/svn/trunk@5744
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Sun, 30 Sep 2012 11:30:01 +0000 (11:30 +0000)]
samplecode: Avoid temporary variables of SkString type.
Just like most of the other samples, just pass the name of the sample directly.
R=epoger@google.com
Review URL: https://codereview.appspot.com/6572047
git-svn-id: http://skia.googlecode.com/svn/trunk@5743
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Sat, 29 Sep 2012 13:17:16 +0000 (13:17 +0000)]
debugger: Remove obsolete TODO comment.
std::string usage was already replaced by SkString.
R=chudy@google.com, tomhudson@google.com
Review URL: https://codereview.appspot.com/6596043
git-svn-id: http://skia.googlecode.com/svn/trunk@5738
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Sat, 29 Sep 2012 12:40:30 +0000 (12:40 +0000)]
samplecode: Remove duplicated include of SkWindow.h from SampleApp.h
R=epoger@google.com
Review URL: https://codereview.appspot.com/6566051
git-svn-id: http://skia.googlecode.com/svn/trunk@5737
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 29 Sep 2012 02:01:02 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5735
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 28 Sep 2012 21:40:15 +0000 (21:40 +0000)]
Don't allow previous render target to be deleted in GrGpu::clear
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6584043
git-svn-id: http://skia.googlecode.com/svn/trunk@5734
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 28 Sep 2012 20:59:03 +0000 (20:59 +0000)]
remove setBitmapDevice -- no longer called, and is a necessary step on our way
to removing setDevice (and hopefully getDevice after that).
git-svn-id: http://skia.googlecode.com/svn/trunk@5732
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 28 Sep 2012 19:48:09 +0000 (19:48 +0000)]
in an effort to excise callers of setBitmapDevice, I think we can eliminate
the SkCanvas parameter altogether, and just put a temp one on the stack.
Review URL: https://codereview.appspot.com/6571071
git-svn-id: http://skia.googlecode.com/svn/trunk@5730
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 28 Sep 2012 19:24:13 +0000 (19:24 +0000)]
No hinting with CG should prevent outline dilation.
https://codereview.appspot.com/6568065/
Will require some rebaselines on mac.
git-svn-id: http://skia.googlecode.com/svn/trunk@5728
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 28 Sep 2012 19:09:23 +0000 (19:09 +0000)]
remove call to setBitmapDevice (DEPRECATED)
git-svn-id: http://skia.googlecode.com/svn/trunk@5727
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 28 Sep 2012 18:33:11 +0000 (18:33 +0000)]
Disable thumb on IOS. This removes one of XCodes complaints about the generated projects.
R=caryclark@google.com
Review URL: https://codereview.appspot.com/6561072
git-svn-id: http://skia.googlecode.com/svn/trunk@5726
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 28 Sep 2012 18:06:49 +0000 (18:06 +0000)]
Update Ganesh to support fractional rects in drawBitmapRect
https://codereview.appspot.com/6561070/
git-svn-id: http://skia.googlecode.com/svn/trunk@5724
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 28 Sep 2012 17:24:44 +0000 (17:24 +0000)]
Added additional case to GM:drawbitmapmatrix
https://codereview.appspot.com/6573067/
This require re-baselining of all drawbitmapmatrix images!
git-svn-id: http://skia.googlecode.com/svn/trunk@5723
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 28 Sep 2012 16:56:28 +0000 (16:56 +0000)]
Make gpu work in iOS SampleApp.
This includes updates to the GrGLInterface and changes to the DeviceManager subclass used on iOS.
Review URL: https://codereview.appspot.com/6582043
git-svn-id: http://skia.googlecode.com/svn/trunk@5722
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 28 Sep 2012 02:01:16 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5721
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 27 Sep 2012 21:57:45 +0000 (21:57 +0000)]
Fix recursive GPU processing for SkImageFilter. Plumb through the
SkImageFilter::Proxy parameter to the GPU recursion path. Extract
DeviceImageFilterProxy from SkCanvas.cpp into its own .h, and rename it.
https://codereview.appspot.com/6575059/
git-svn-id: http://skia.googlecode.com/svn/trunk@5720
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Sep 2012 21:22:56 +0000 (21:22 +0000)]
fix win-only change (canvas -> rasterCanvas)
git-svn-id: http://skia.googlecode.com/svn/trunk@5719
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Sep 2012 21:09:30 +0000 (21:09 +0000)]
doh(2) fix the other typo
git-svn-id: http://skia.googlecode.com/svn/trunk@5718
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Sep 2012 21:03:49 +0000 (21:03 +0000)]
doh, fix typo
git-svn-id: http://skia.googlecode.com/svn/trunk@5717
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Sep 2012 20:58:01 +0000 (20:58 +0000)]
eliminate (unused) extra param to update(), and thereby remove (bad bad bad) setBitmapDevice call.
git-svn-id: http://skia.googlecode.com/svn/trunk@5716
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Sep 2012 20:31:31 +0000 (20:31 +0000)]
remove call to setBitmapDevice (deprecated).
Review URL: https://codereview.appspot.com/6569070
git-svn-id: http://skia.googlecode.com/svn/trunk@5715
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 27 Sep 2012 18:37:16 +0000 (18:37 +0000)]
force rebuild
git-svn-id: http://skia.googlecode.com/svn/trunk@5714
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 27 Sep 2012 16:04:54 +0000 (16:04 +0000)]
Make SampleApp work on iPhone/iOS simulator.
Several parts to this:
1) The DeviceManager subclass for iOS was rewritten because the base class
changed.
2) Two old samples that rely on hardcoded paths to images are deleted. They hit
assertions in SkImageRef. No one has the required images to run these anyway.
3) argv must be non-NULL.
4) The UI delegate must not be loaded from the NIB for viewDidLoad ordering
reasons. So I removed an IBOutlet link from the window to the splitview
controller in the iPad's NIB file. The split view is attached by the AppDelegate
programmatically.
This doesn't make GPU work. That will come in a later change.
Review URL: https://codereview.appspot.com/6561056/
git-svn-id: http://skia.googlecode.com/svn/trunk@5712
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Sep 2012 15:46:45 +0000 (15:46 +0000)]
allow chrome to use old drawBitmapRect beahvior for now, using SK_SUPPORT_INT_SRCRECT_DRAWBITMAPRECT
git-svn-id: http://skia.googlecode.com/svn/trunk@5710
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 27 Sep 2012 13:44:57 +0000 (13:44 +0000)]
Remove deprecated SkOSWindow_wxwidgets.h
It seems we never really supported WxWidgets.
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6569062
git-svn-id: http://skia.googlecode.com/svn/trunk@5708
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Thu, 27 Sep 2012 13:34:34 +0000 (13:34 +0000)]
Generate debugger MOCs on the fly
Added gyp rules to generate Qt MOC files at build time, and removed the pre-packaged versions.
Tested on Mac with Qt 4.6.4 & 4.8.3, and on Linux with Qt 4.8.1.
R=caryclark@google.com,robertphillips@google.com,djsollen@google.com
BUG=
Review URL: https://codereview.appspot.com/6561054
git-svn-id: http://skia.googlecode.com/svn/trunk@5707
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Thu, 27 Sep 2012 13:09:58 +0000 (13:09 +0000)]
Pinspect and bench_pictures are crashing when invoked with no arguments.
R=reed@google.com,scroggo@google.com
BUG=
Review URL: https://codereview.appspot.com/6575052
git-svn-id: http://skia.googlecode.com/svn/trunk@5706
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 27 Sep 2012 02:01:04 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5705
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 26 Sep 2012 19:16:54 +0000 (19:16 +0000)]
Load more fonts on Linux.
https://codereview.appspot.com/6569061/
git-svn-id: http://skia.googlecode.com/svn/trunk@5704
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 26 Sep 2012 18:43:02 +0000 (18:43 +0000)]
samplecode: Remove executable bit from SampleTextureDomain.cpp
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6570056
git-svn-id: http://skia.googlecode.com/svn/trunk@5703
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Wed, 26 Sep 2012 18:32:58 +0000 (18:32 +0000)]
Fix Xcode 4.x debugger build
Adding a mac_framework_dirs entry to help Xcode find the Qt frameworks.
R=djsollen@google.com
BUG=
Review URL: https://codereview.appspot.com/6564056
git-svn-id: http://skia.googlecode.com/svn/trunk@5702
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 26 Sep 2012 18:04:51 +0000 (18:04 +0000)]
Added Qt 4.8.3 moc files for the debugger
http://codereview.appspot.com/6570055/
git-svn-id: http://skia.googlecode.com/svn/trunk@5701
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 26 Sep 2012 17:58:27 +0000 (17:58 +0000)]
remove precompiled header option for ios
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@5700
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 26 Sep 2012 17:28:25 +0000 (17:28 +0000)]
Remove memcpy/memcmp from GrDrawState. Hopefully, this fixes Issue 912 without regressing performance.
Review URL: https://codereview.appspot.com/6571059
git-svn-id: http://skia.googlecode.com/svn/trunk@5697
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 26 Sep 2012 16:25:22 +0000 (16:25 +0000)]
Fix update-doxygen (again)
Bash trickery to find the script directory did not work, but we can just use
"trunk/tools" since trunk gets checked out into $DOXYGEN_TEMPDIR.
Review URL: https://codereview.appspot.com/6573055
git-svn-id: http://skia.googlecode.com/svn/trunk@5696
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 26 Sep 2012 16:09:43 +0000 (16:09 +0000)]
Fix update-doxygen, which fails when skia-autogen is reset
static_footer.txt was removed from skia/docs in r2837, but update-doxygen.sh
requires it to exist in skia-autogen. If skia-autogen is cleared (frequently),
then static_footer.txt can't be found. Add it back to trunk/tools and manually
copy it if needed.
Review URL: https://codereview.appspot.com/6568054
git-svn-id: http://skia.googlecode.com/svn/trunk@5694
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 26 Sep 2012 15:48:43 +0000 (15:48 +0000)]
move the xcode setup for SYMROOT to the outermost level
Review URL: https://codereview.appspot.com/6576050
git-svn-id: http://skia.googlecode.com/svn/trunk@5693
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 26 Sep 2012 15:41:42 +0000 (15:41 +0000)]
gm: Include system_preferences.h in mac file.
This fixes the FIXME in there.
R=epoger@google.com
Review URL: https://codereview.appspot.com/6576049
git-svn-id: http://skia.googlecode.com/svn/trunk@5692
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 26 Sep 2012 15:28:04 +0000 (15:28 +0000)]
Disable memory intensive drawBitmapRectToRect tests on Android
http://codereview.appspot.com/6567052/
git-svn-id: http://skia.googlecode.com/svn/trunk@5691
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 26 Sep 2012 13:44:13 +0000 (13:44 +0000)]
remove uses of setBitmapDevice (DEPRECATED)
git-svn-id: http://skia.googlecode.com/svn/trunk@5689
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 26 Sep 2012 13:10:19 +0000 (13:10 +0000)]
Added more drawBitmapRectToRect tests
http://codereview.appspot.com/6564053/
git-svn-id: http://skia.googlecode.com/svn/trunk@5688
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 26 Sep 2012 13:08:56 +0000 (13:08 +0000)]
Suppress some warnings on linux.
R=reed@google.com
Review URL: https://codereview.appspot.com/6572046
git-svn-id: http://skia.googlecode.com/svn/trunk@5687
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 26 Sep 2012 13:02:37 +0000 (13:02 +0000)]
add simple ios app
update ios flavor of sample app
fix utils.gyp for ios
git-svn-id: http://skia.googlecode.com/svn/trunk@5686
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 26 Sep 2012 13:00:03 +0000 (13:00 +0000)]
shape ops -- update gyp projects
goodbye cruel world (updating to OS X 10.8)
git-svn-id: http://skia.googlecode.com/svn/trunk@5685
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 26 Sep 2012 03:10:09 +0000 (03:10 +0000)]
re-land 5681, but just the gyp file I wanted
git-svn-id: http://skia.googlecode.com/svn/trunk@5683
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 26 Sep 2012 03:08:16 +0000 (03:08 +0000)]
revert 5681
git-svn-id: http://skia.googlecode.com/svn/trunk@5682
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 26 Sep 2012 03:06:55 +0000 (03:06 +0000)]
remove SampleXfermodes.cpp (obsolete, as we have it as a GM)
git-svn-id: http://skia.googlecode.com/svn/trunk@5681
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 26 Sep 2012 02:45:10 +0000 (02:45 +0000)]
SkCanvas::setDevice() must die, and so we begin by removing our own
references to setBitmapDevice() (gotta walk before we can run)
git-svn-id: http://skia.googlecode.com/svn/trunk@5680
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 26 Sep 2012 02:24:45 +0000 (02:24 +0000)]
add getMetaData() to SkCanvas (as part of our master plan to remove
subclasses of SkCanvas and SkDevice from our clients.
git-svn-id: http://skia.googlecode.com/svn/trunk@5679
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 26 Sep 2012 02:01:18 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5678
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 25 Sep 2012 20:38:28 +0000 (20:38 +0000)]
Vertical metrics for FreeType.
https://codereview.appspot.com/6554064/
git-svn-id: http://skia.googlecode.com/svn/trunk@5677
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Tue, 25 Sep 2012 20:16:46 +0000 (20:16 +0000)]
Remove unused includes from skhello tool.
R=epoger@google.com
Review URL: https://codereview.appspot.com/6546063
git-svn-id: http://skia.googlecode.com/svn/trunk@5676
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 25 Sep 2012 19:55:07 +0000 (19:55 +0000)]
Fix some linux build warnings
Review URL: https://codereview.appspot.com/6571050
git-svn-id: http://skia.googlecode.com/svn/trunk@5675
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 25 Sep 2012 19:14:14 +0000 (19:14 +0000)]
Disable warning emitted in libjpg build
Review URL: https://codereview.appspot.com/6573047
git-svn-id: http://skia.googlecode.com/svn/trunk@5673
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 25 Sep 2012 18:53:17 +0000 (18:53 +0000)]
Remove GrTLList.h
https://codereview.appspot.com/6577043/
git-svn-id: http://skia.googlecode.com/svn/trunk@5670
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 25 Sep 2012 18:24:41 +0000 (18:24 +0000)]
Remove SkListWidget.cpp, which has not been compiled for 18 months
(Our very first gyp file from https://code.google.com/p/skia/source/detail?spec=svn955&r=955 already had it turned off)
Review URL: https://codereview.appspot.com/6566049
git-svn-id: http://skia.googlecode.com/svn/trunk@5668
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 25 Sep 2012 17:48:30 +0000 (17:48 +0000)]
Delete SkListView.cpp, which has been #ifdef'ed out for 4+ years
Review URL: https://codereview.appspot.com/6550062
git-svn-id: http://skia.googlecode.com/svn/trunk@5667
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 25 Sep 2012 17:36:36 +0000 (17:36 +0000)]
Fix a warning in PictureBenchmark.
Forgot to change from false to NULL. False does the right thing,
but gives a warning. Fix the warning.
Review URL: https://codereview.appspot.com/6570049
git-svn-id: http://skia.googlecode.com/svn/trunk@5666
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Sep 2012 15:37:50 +0000 (15:37 +0000)]
Reimplement drawBitmapRectToRect to correctly handle fraction srcRect.
The prev impl relied on drawBitmap "deducing" the destination rect by applying
the computed matrix to the bitmap's bounds. This cannot be done if the srcRect
is fractional, and therefore not representable w/ a bitmap.
The new impl computes the same matrix, but calls down to the device via drawRect
+ a bitmap_shader. This allows us to specfiy the dstRect explicitly.
The possible down-side is that we now rely on the device subclass to efficiently
handle draRect+shader, instead of calling its drawBitmap entry-point.
To give the device the chance to handle this differently, I now call through to
a new device virtual: drawBitmapRect. The default impl is to create the shader
and call drawRect, but a subclass can intercept that.
For now, the GPU override of drawBitmapRect is mimicing the old behavior (by
rounding the srcRect to an iRect). This preserves its ability to call drawBitmap
which handles very-large textures, but shows some gittering/imprecision, due to
the rounding. ... this is the same GPU behavior we have before this CL.
Review URL: https://codereview.appspot.com/6542065
git-svn-id: http://skia.googlecode.com/svn/trunk@5663
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 25 Sep 2012 14:32:42 +0000 (14:32 +0000)]
This patch adds support for optional processing of the alpha channel in
the matrix convolution filter. Test cases are added to the GM and the
bench.
NOTE: This will require rebaselining the matrixconvolution GM, so it will
likely turn the bots red until that is done.
https://codereview.appspot.com/6547049/
git-svn-id: http://skia.googlecode.com/svn/trunk@5661
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 25 Sep 2012 02:01:21 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5656
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 25 Sep 2012 00:39:51 +0000 (00:39 +0000)]
"fix" chrome build
git-svn-id: http://skia.googlecode.com/svn/trunk@5655
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 21:38:38 +0000 (21:38 +0000)]
fix mac builds
comment out 64 bit / mac error check
git-svn-id: http://skia.googlecode.com/svn/trunk@5654
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 24 Sep 2012 21:27:14 +0000 (21:27 +0000)]
Build fix. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5653
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 20:08:43 +0000 (20:08 +0000)]
unbreak the build part ii
allow android in debugger.gyp
git-svn-id: http://skia.googlecode.com/svn/trunk@5651
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 19:41:43 +0000 (19:41 +0000)]
unbreak the build
move define of skia_arch_type to front
git-svn-id: http://skia.googlecode.com/svn/trunk@5650
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 19:33:57 +0000 (19:33 +0000)]
iOS support work in progress
include/core/SkTypes.h
- address unsigned warning
include/core/SkInstCnt.h
src/core/SkInstCnt.cpp
gyp/common.gypi
- always define SK_ENABLE_INST_COUNT for debug builds
src/views/mac/SkNSView.mm
- only call glClear if there is a GL context
src/ports/SkImageDecoder_CG.cpp
- fix iOS hack by using proper include
gyp/opts.gyp
- exclude more ARM files from iOS for now (see issue 900)
gyp/common_conditions.gypi
- add release, more ios specific common settings
gyp/bench.gyp
- add iOS condition
gyp/SampleApp.gyp
- remove precompiled header, hardcoded SDK path
- add more frameworks
gyp/debugger.gyp
- fix syntax error
- add iOS/Android condition
gyp/core.gyp
- remove hardcoded SDK path, add more frameworks
gyp/common_variables.gypi
- add ios SDK path
- add ios SDK version
gyp/iOSSampleApp.gyp
- remove obsolete project
gyp/zlib.gyp
- add ios library path
Review URL: https://codereview.appspot.com/6551070
git-svn-id: http://skia.googlecode.com/svn/trunk@5649
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 24 Sep 2012 19:33:59 +0000 (19:33 +0000)]
Fix for GrTextureStripAtlas memory leak
https://codereview.appspot.com/6549050/
git-svn-id: http://skia.googlecode.com/svn/trunk@5648
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 24 Sep 2012 14:20:00 +0000 (14:20 +0000)]
Addressed xcode analysis complaints
http://codereview.appspot.com/6558048/
git-svn-id: http://skia.googlecode.com/svn/trunk@5646
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 24 Sep 2012 13:16:52 +0000 (13:16 +0000)]
Whitespace change to trigger rebuild after tweaking Windows build slaves
git-svn-id: http://skia.googlecode.com/svn/trunk@5645
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 21 Sep 2012 19:12:32 +0000 (19:12 +0000)]
When recording a GM to a picture, pass the GM's size to beginRecording.
Review URL: https://codereview.appspot.com/6552047
git-svn-id: http://skia.googlecode.com/svn/trunk@5644
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 21 Sep 2012 17:54:46 +0000 (17:54 +0000)]
Make flattenables no longer depend on global static initializers.
Instead, force all builds to call InitializeFlattenables.
Remove the make_debugger script, which was created to force
rebuilding without global static initializers so that all flattenables
would be linked. It is no longer necessary since all flattenables
will be linked thanks to InitializeFlattenables, which now can (and
must) be called when global static initializers are turned on.
BUG=https://code.google.com/p/skia/issues/detail?id=903
BUG=https://code.google.com/p/skia/issues/detail?id=902
Review URL: https://codereview.appspot.com/6548044
git-svn-id: http://skia.googlecode.com/svn/trunk@5642
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 21 Sep 2012 17:50:50 +0000 (17:50 +0000)]
[PDF] Fix name generation - / needs to be escaped.
BUG=chromium 148422
Review URL: https://codereview.appspot.com/6542044
git-svn-id: http://skia.googlecode.com/svn/trunk@5641
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Sep 2012 17:38:06 +0000 (17:38 +0000)]
check for very large blurs, and don't try to cache the result in fontcache
http://code.google.com/p/chromium/issues/detail?id=138208
git-svn-id: http://skia.googlecode.com/svn/trunk@5640
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Sep 2012 12:15:13 +0000 (12:15 +0000)]
disable experiemental hack to try to speedup floor
git-svn-id: http://skia.googlecode.com/svn/trunk@5636
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 21 Sep 2012 02:01:01 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5635
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 20 Sep 2012 22:10:33 +0000 (22:10 +0000)]
Adding hasPendingCommands API method to SkDeferredCanvas
BUG=http://code.google.com/p/chromium/issues/detail?id=146178
Review URL: https://codereview.appspot.com/6550050
git-svn-id: http://skia.googlecode.com/svn/trunk@5632
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 20 Sep 2012 22:05:27 +0000 (22:05 +0000)]
Whitespace change to trigger a bot cycle after r5630
git-svn-id: http://skia.googlecode.com/svn/trunk@5631
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 20 Sep 2012 20:42:44 +0000 (20:42 +0000)]
Fixing how deferred canvas purges itself when a clear is recoreded.
This fixes performance because the old code was not reconstructing the clip
state correctly. This was causing a major performance degradation in the
Galactic IE testdrive demo. This fix also enbles the purge
on clear optimization when there is saved state on the matrix/clip stack.
The approach taken to solve the problem consists in purging by running the
playback silently. The previous approach was tearing down and
restarting the gpipe, which required reconstructing state, which is fragile
and hard to do correctly, and has the side effect of clearing the bitmap heap
and the flattened dictionary.
Note: This CL is expected to slightly degrade performance of the
deferred_canvas_record bench, which uses the skip on clear optimization.
This is because a silent playback takes more time that just destroying
the SkGPipe. Correctness trumps performance.
BUG=http://code.google.com/p/chromium/issues/detail?id=146178
Review URL: https://codereview.appspot.com/6531048
git-svn-id: http://skia.googlecode.com/svn/trunk@5627
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 20 Sep 2012 19:35:43 +0000 (19:35 +0000)]
Adding a silent playback option to SkGPipeRead
Testing state consistency after silent playback in CanvasTest indirectly
through SkDeferredCanvas.
BUG=http://code.google.com/p/chromium/issues/detail?id=146178
TEST=CanvasTest unit test, and bench with --mode deferredSilent
Review URL: https://codereview.appspot.com/6542047
git-svn-id: http://skia.googlecode.com/svn/trunk@5619
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 20 Sep 2012 19:09:17 +0000 (19:09 +0000)]
Got debugger compiling again after SkCanvas API change
http://codereview.appspot.com/6543047/
git-svn-id: http://skia.googlecode.com/svn/trunk@5616
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Sep 2012 19:05:33 +0000 (19:05 +0000)]
Prevent LinearRegression from dividing by zero so the GenerateBenchGraphs step doesn't blow up if the data is all zeroes.
http://codereview.appspot.com/6546049/
git-svn-id: http://skia.googlecode.com/svn/trunk@5615
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 20 Sep 2012 18:54:04 +0000 (18:54 +0000)]
Remove automatic resizing in *_pictures
Review URL: https://codereview.appspot.com/6554045
git-svn-id: http://skia.googlecode.com/svn/trunk@5614
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 20 Sep 2012 18:52:10 +0000 (18:52 +0000)]
Update bench_expectations
We only have three runs since the regression was fixed in r5605:
153.68, 154.09, 153.71
These bounds seem reasonable to me.
Review URL: https://codereview.appspot.com/6541049
git-svn-id: http://skia.googlecode.com/svn/trunk@5613
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Sep 2012 18:19:26 +0000 (18:19 +0000)]
remove use of SkRefPtr in public header (SkPDFDocument.h)
Review URL: https://codereview.appspot.com/6546048
git-svn-id: http://skia.googlecode.com/svn/trunk@5612
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Sep 2012 18:04:12 +0000 (18:04 +0000)]
remove unused parameter (that also slowed us down) to SkAutoTDelete
git-svn-id: http://skia.googlecode.com/svn/trunk@5611
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Sep 2012 17:59:49 +0000 (17:59 +0000)]
Fix premul alpha problems w/matrix convolution filter, and re-enable the bench.
http://codereview.appspot.com/6541043/
git-svn-id: http://skia.googlecode.com/svn/trunk@5610
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Sep 2012 17:52:20 +0000 (17:52 +0000)]
remove all SkRefPtr from SkPDFDevice.h
Review URL: https://codereview.appspot.com/6542049
git-svn-id: http://skia.googlecode.com/svn/trunk@5609
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Sep 2012 16:10:02 +0000 (16:10 +0000)]
Pull SDKROOT into a gyp variable, so it can be locally overridden. This
allows building on Lion or Mountain Lion using XCode 4.4.
http://codereview.appspot.com/6553044/
git-svn-id: http://skia.googlecode.com/svn/trunk@5607
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 20 Sep 2012 15:45:41 +0000 (15:45 +0000)]
first cut at making iOS work
Replace __arm__ with SK_CPU_ARM
add support for iOS simulator and device
fix const warning in iOSSampleApp
update gyp files
https://code.google.com/p/skia/issues/detail?id=900
tracks fixing missing arm assembly
Review URL: https://codereview.appspot.com/6552045
git-svn-id: http://skia.googlecode.com/svn/trunk@5606
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 20 Sep 2012 15:37:30 +0000 (15:37 +0000)]
Fix GrTextureAccess::operator ==
compare the textures, correctly intepret memcmp result, don't compare last byte of swizzle array which must be 0.
BUG=895
Review URL: https://codereview.appspot.com/6542048
git-svn-id: http://skia.googlecode.com/svn/trunk@5605
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 20 Sep 2012 14:54:21 +0000 (14:54 +0000)]
In render_pictures tiled rendering, draw a separate PNG for each tile.
Since the passed in picture may represent an image which is too large
to be represented on the GPU, never create such a large canvas. Instead,
after drawing to each tile, create a file showing just that tile.
Review URL: https://codereview.appspot.com/6532056
git-svn-id: http://skia.googlecode.com/svn/trunk@5603
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 20 Sep 2012 14:42:33 +0000 (14:42 +0000)]
In bench_pictures, use a pool of tiles for multicore drawing.
Also includes some code cleanup and code sharing.
Allow setting the number of threads on the command line.
Rename ThreadSafePipeController::playback to ::draw, to be the same
as SkPicture so DrawTileToCanvas can take a template parameter.
Disallow multithreading with GPU turned on.
Display help information with improper tiled arguments.
BUG=https://code.google.com/p/skia/issues/detail?id=871
Review URL: https://codereview.appspot.com/6536050
git-svn-id: http://skia.googlecode.com/svn/trunk@5602
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Sep 2012 22:50:21 +0000 (22:50 +0000)]
Yet another speculative Android fix. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5600
2bbb7eff-a529-9590-31e7-
b0007b416f81