profile/ivi/webkit-efl.git
12 years agoUnreviewed. Restore test that was removed during migration from LayoutTests folder.
loislo@chromium.org [Tue, 10 Jan 2012 16:31:28 +0000 (16:31 +0000)]
Unreviewed. Restore test that was removed during migration from LayoutTests folder.

* inspector/first-open-resources.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRebaseline fast/text/unicode-variation-selector.html following r104545.
jknotten@chromium.org [Tue, 10 Jan 2012 16:23:54 +0000 (16:23 +0000)]
Rebaseline fast/text/unicode-variation-selector.html following r104545.

* platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
peter@chromium.org [Tue, 10 Jan 2012 16:03:44 +0000 (16:03 +0000)]
[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
metrics for Android in FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=75702

Reviewed by Stephen White.

Since Skia for Android doesn't implement advanced type metric routines,
use an alternative method to calculate the number of font units for an
em size. This will be exercized by existing layout tests, as it's being
used by the ComplexTextController.

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, inspector style fix.
vsevik@chromium.org [Tue, 10 Jan 2012 15:59:16 +0000 (15:59 +0000)]
Unreviewed, inspector style fix.

Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609

* inspector/front-end/elementsPanel.css:
(#elements-content):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix style errors in CSSParser.cpp
zherczeg@webkit.org [Tue, 10 Jan 2012 15:58:31 +0000 (15:58 +0000)]
Fix style errors in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=75854

Reviewed by Nikolas Zimmermann.

Minor style fixes.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::filterInfoForName):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
jchaffraix@webkit.org [Tue, 10 Jan 2012 15:48:40 +0000 (15:48 +0000)]
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/layers/scroll-with-transform-composited-layer.html
       fast/layers/scroll-with-transform-layer.html

The regression came from a previous optimization that was wrongly kept after r93614.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.

LayoutTests:

Added 2 tests for scrolling inside a transformed layer (either composited
or not). Unfortunately due to some platform-specifics differences, they are
not ref-tests.

* fast/layers/scroll-with-transform-composited-layer-expected.txt: Added.
* fast/layers/scroll-with-transform-composited-layer.html: Added.
* fast/layers/scroll-with-transform-layer-expected.txt: Added.
* fast/layers/scroll-with-transform-layer.html: Added.
* platform/mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
peter@chromium.org [Tue, 10 Jan 2012 15:47:26 +0000 (15:47 +0000)]
[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
https://bugs.webkit.org/show_bug.cgi?id=75957

Reviewed by Tony Gentilcore.

Revision 104502 broke Chromium compilation for platforms which disable
the Web Audio API. All references to m_audioSourceProvider should be
guarded with the ENABLE(WEB_AUDIO) conditional.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out an accidental commit r104569.
ossy@webkit.org [Tue, 10 Jan 2012 15:35:59 +0000 (15:35 +0000)]
Unreviewed, rolling out an accidental commit r104569.

* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
* Shared/EditorState.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] fast/events/dont-loose-last-event test fails on WK1
commit-queue@webkit.org [Tue, 10 Jan 2012 15:32:31 +0000 (15:32 +0000)]
[Qt] fast/events/dont-loose-last-event test fails on WK1
https://bugs.webkit.org/show_bug.cgi?id=73894

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-01-10
Reviewed by Simon Hausmann.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.
This commit also removes not working DRT code to handle drag and drop,
for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Remove fast/events/dont-loose-last-event from qt-wk1 skip list.

* platform/qt-wk1/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Chrome/Mac build.
senorblanco@chromium.org [Tue, 10 Jan 2012 15:32:17 +0000 (15:32 +0000)]
Fix Chrome/Mac build.

Build fix; unreviewed.

* platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::luminanceToAlphaMatrix):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed potential Mac WK2 build fix.
kenneth@webkit.org [Tue, 10 Jan 2012 15:25:20 +0000 (15:25 +0000)]
Unreviewed potential Mac WK2 build fix.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithGestureEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWIP
kenneth@webkit.org [Tue, 10 Jan 2012 15:20:10 +0000 (15:20 +0000)]
WIP

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
commit-queue@webkit.org [Tue, 10 Jan 2012 15:17:50 +0000 (15:17 +0000)]
[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=75837

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

Changed graphicContext raw pointer to OwnPtr smart pointer.
Renamed cr to cairo and made it a RefPtr.

* ewk/ewk_view.cpp:
(ewk_view_paint_context_new): Adjust to auto pointers use.
(ewk_view_paint_context_free): Removed explicit raw pointers delete.
Adjust to auto pointers use:
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Add font-related API tests for QWebPreferences
commit-queue@webkit.org [Tue, 10 Jan 2012 15:14:05 +0000 (15:14 +0000)]
[Qt][WK2] Add font-related API tests for QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=75739

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-10
Reviewed by Zoltan Herczeg.

* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
senorblanco@chromium.org [Tue, 10 Jan 2012 15:01:07 +0000 (15:01 +0000)]
Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
compiling with USE(SKIA).  This change will also switch the software
implementation of FEGaussianBlur to the skia implementation (ie.,
it removes the acceleration check).
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will
need a rebaseline).

* WebCore.gypi:
Add FEColorMatrixSkia.cpp to the build.
* platform/graphics/filters/FEColorMatrix.h:
Add platformApplySkia().
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Remove skia-specific code from FEGaussianBlur::platformApplySoftware().
* platform/graphics/filters/FEGaussianBlur.h:
Make platformApplySkia() virtual, and put it behind #if USE(SKIA).
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
Call out to platformApplySkia(), or fall back to
platformApplySoftware().
* platform/graphics/filters/FilterEffect.h:
Add platformApplySkia().
* platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added.
(WebCore::saturateMatrix):
(WebCore::hueRotateMatrix):
(WebCore::luminanceToAlphaMatrix):
(WebCore::FEColorMatrix::platformApplySkia):
Process color matrix effect, by calling out to generic matrix
version of SkColorMatrixFilter.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:
(WebCore::FEGaussianBlur::platformApplySkia):
Change the signature of FEGaussianBlur::platformApplySkia to be an
override of the new FilterEffect base class version.

LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines.
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix failing WK2 layout tests after r104557
hausmann@webkit.org [Tue, 10 Jan 2012 14:18:38 +0000 (14:18 +0000)]
[Qt] Fix failing WK2 layout tests after r104557

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Add missing break to not
handle mouseDown as gesture event.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed buildfix.
kenneth@webkit.org [Tue, 10 Jan 2012 14:13:44 +0000 (14:13 +0000)]
Unreviewed buildfix.

* UIProcess/WebPageProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
pfeldman@chromium.org [Tue, 10 Jan 2012 13:49:04 +0000 (13:49 +0000)]
Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Add getter for Ewk_JS_Object::view.
kubo@profusion.mobi [Tue, 10 Jan 2012 13:46:54 +0000 (13:46 +0000)]
[EFL] Add getter for Ewk_JS_Object::view.
https://bugs.webkit.org/show_bug.cgi?id=75868

Reviewed by Andreas Kling.

So far the view associated with a given JS object was a private
property only accessible to ewk itself. This does not make much sense,
as one often needs to know which view a certain method was invoked
from, for example.

* ewk/ewk_js.cpp:
(ewk_js_object_view_get):
* ewk/ewk_js.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed gardening.
ossy@webkit.org [Tue, 10 Jan 2012 13:44:50 +0000 (13:44 +0000)]
Unreviewed gardening.

* platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
* platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently.
* platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Enable CSS_FILTERS in Qt build
ossy@webkit.org [Tue, 10 Jan 2012 13:44:02 +0000 (13:44 +0000)]
[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

* Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

* qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Platform specific expected results tweaked by Csaba Osztrogonác.

* platform/qt/Skipped: Unskip filter tests that work.
* platform/qt/css3/filters/*: Added Qt specific results.
* platform/qt/fast/dom/Window/window-properties.html: Updated.
* platform/qt/fast/dom/Window/window-property-descriptors.html: Updated.
* platform/qt/fast/dom/prototype-inheritance-2.html: Updated.
* platform/qt/fast/js/global-constructors.html: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed -Werror build fix.
hausmann@webkit.org [Tue, 10 Jan 2012 13:36:26 +0000 (13:36 +0000)]
[Qt] Unreviewed -Werror build fix.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
declaration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Remove dependency to uitools
hausmann@webkit.org [Tue, 10 Jan 2012 13:34:08 +0000 (13:34 +0000)]
[Qt] Remove dependency to uitools
https://bugs.webkit.org/show_bug.cgi?id=75952

Reviewed by Tor Arne Vestbø.

QUiLoader is used for creating QLabel/QProgressBar widgets for
a layout test, to verify some widget embedding feature. Unfortunately
in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
depends on qttools. Since we don't really _need_ QUiLoader for our tests,
let's break the circular dependency.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::createPlugin):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/webpage.cpp:
(WebPage::createPlugin):
* qmake/mkspecs/features/minimal_qt.prf:
* qmake/mkspecs/features/uitools.prf: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement the input panel request/close handling
kenneth@webkit.org [Tue, 10 Jan 2012 13:25:27 +0000 (13:25 +0000)]
Implement the input panel request/close handling

Reviewed by Simon Hausmann.

With the current patch we only request the input panel as a
response to a user tap. Close requests, on the other hand,
is always respected.

As multiple show/hide requests can happen while processing
the tap gesture, input panel visibility changes are postponed
until the tap gesture ends.

The input panel will become visible if the WebCore editor is
in canEdit mode and thus work for content-editable, meaning
that it won't close the input panel if you click on a link
(eg. editCommand) while in content-editable mode.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::didReceiveEvent):

    Add a new doneWithGestureEvent method to the PageClient
    as well as add a updateTextInputState similar to that of mac.

* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::updateTextInputState):
(QtPageClient::doneWithGestureEvent):

    Propagate the new events to the Qt EventHandler.

* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleSingleTapEvent):
(setInputPanelVisible):
(QtWebPageEventHandler::updateTextInputState):
(QtWebPageEventHandler::doneWithGestureEvent):

    Handle postponing of the input method visibility change
    and the actual showing/hiding.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserAppli...
commit-queue@webkit.org [Tue, 10 Jan 2012 13:24:58 +0000 (13:24 +0000)]
[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
https://bugs.webkit.org/show_bug.cgi?id=75894

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-10
Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication::windowOptions):
* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, chromium test expectations update.
vsevik@chromium.org [Tue, 10 Jan 2012 13:06:32 +0000 (13:06 +0000)]
Unreviewed, chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: typo: NetworkAgent.canClearBrowserCache -> NetworkAgent.canClearBrowse...
pfeldman@chromium.org [Tue, 10 Jan 2012 13:00:47 +0000 (13:00 +0000)]
Web Inspector: typo: NetworkAgent.canClearBrowserCache -> NetworkAgent.canClearBrowserCookies.
https://bugs.webkit.org/show_bug.cgi?id=75949

Reviewed by Andreas Kling.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: restore front-end compilation
pfeldman@chromium.org [Tue, 10 Jan 2012 12:57:00 +0000 (12:57 +0000)]
Web Inspector: restore front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=75625

Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Yury Semikhatsky.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
* inspector/front-end/TabbedPane.js:
* inspector/front-end/externs.js:
(WebInspector.isCompactMode):
* inspector/front-end/treeoutline.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd NULL checks to setting access obtained on frame and document.
commit-queue@webkit.org [Tue, 10 Jan 2012 12:19:42 +0000 (12:19 +0000)]
Add NULL checks to setting access obtained on frame and document.
https://bugs.webkit.org/show_bug.cgi?id=72002

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.

Adds NULL checks to setting object where it's required.
Generally WebCore checks NULL which may be returned from setting object obtained
on frame or document but in some cases these are skipped. These checks are not
needed to setting's access on page object.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
* page/DragController.cpp:
(WebCore::DragController::draggableNode):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::flattenFrameSet):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
* rendering/RenderText.cpp:
(WebCore::SecureTextTimer::restartWithNewText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] DRT crashes with Qt 5
hausmann@webkit.org [Tue, 10 Jan 2012 12:11:42 +0000 (12:11 +0000)]
[Qt] DRT crashes with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=75951

Reviewed by Ossy.

* DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
Qt relies on font-config to define the default font family.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMatched declaration cache should support mapped attribute declarations.
kling@webkit.org [Tue, 10 Jan 2012 11:35:32 +0000 (11:35 +0000)]
Matched declaration cache should support mapped attribute declarations.
<http://webkit.org/b/75948>

Reviewed by Antti Koivisto.

Support caching of matches that include mapped attribute declarations.
To make this possible, let the cache hold references to the matched style declarations.
Otherwise, declarations are assumed to survive until ~CSSStyleSelector, which may not
be the case for CSSMappedAttributeDeclaration.

To avoid hoarding of stale CSSMappedAttributeDeclarations in the cache, do a sweep for
every 100 additions and garbage collect any entries containing a declaration that is
only referenced by the cache.

This increases cache hit rate by up to ~10% on the Alexa top sites.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedDeclarationCache):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
* css/CSSStyleSelector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][WK2] Remove codes to move and resize the clip.
commit-queue@webkit.org [Tue, 10 Jan 2012 11:33:37 +0000 (11:33 +0000)]
[EFL][WK2] Remove codes to move and resize the clip.
https://bugs.webkit.org/show_bug.cgi?id=75428

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.

Remove codes to move and resize the clip because clip is not used now.
We have to show whole area of evas_object_image so we don't have to
clip any area.
In the WebKit1 Efl, the clip is used to clip the area to show during
weak zoom, so we can use codes to manipulate the clip when we want to
implement weak zoom for WebKit2 Efl.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] REGRESSION(r100130): Clean build feature is broken.
ossy@webkit.org [Tue, 10 Jan 2012 11:30:21 +0000 (11:30 +0000)]
[Qt] REGRESSION(r100130): Clean build feature is broken.
https://bugs.webkit.org/show_bug.cgi?id=75863

Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(buildQMakeProject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd initial test_expectations.txt for EFL port.
gyuyoung.kim@samsung.com [Tue, 10 Jan 2012 11:20:15 +0000 (11:20 +0000)]
Add initial test_expectations.txt for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=75940

Reviewed by Andreas Kling.

This file only has skip list for now. But, EFL patches will update
this file from now on.

* platform/efl/test_expectations.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
zeno.albisser@nokia.com [Tue, 10 Jan 2012 11:06:52 +0000 (11:06 +0000)]
[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=75885

In QML events are propagated through parents. But since the
WebView may consume key events, a shortcut might never reach
the top QtQuickItem.
Therefore an application wide event handling function in C++
needs to take care of shortcuts for MiniBrowser.

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::reload):
(BrowserWindow::focusAddressBar):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoComplex path should be used when UVS exists in text run
bashi@chromium.org [Tue, 10 Jan 2012 10:46:31 +0000 (10:46 +0000)]
Complex path should be used when UVS exists in text run
https://bugs.webkit.org/show_bug.cgi?id=75289

Source/WebCore:

Uses complex path when a text run contains UVS. The range from U+180B to U+180D already uses complex path.
Removes unnecessary functions that were added by r102915.

Reviewed by Dan Bernstein.

No new tests. fast/text/unicode-variation-selector.html should take care of this change.

* platform/graphics/Font.cpp:
(WebCore::Font::codePath): Use Complex path when the text run contains UVS.
* platform/graphics/SimpleFontData.h: Removed updateGlyphWithVariationSelector().
* platform/graphics/SurrogatePairAwareTextIterator.cpp: Removed unnecessary static functions.
* platform/graphics/SurrogatePairAwareTextIterator.h: Removed hasTrailingVariationSelector().
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): Removed UVS detection code.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed updateGlyphWithVariationSelector().
* platform/graphics/freetype/SimpleFontDataFreeType.cpp: Ditto.
* platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Ditto.
* platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
* platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
* platform/graphics/qt/SimpleFontDataQt.cpp: Ditto.
* platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
* platform/graphics/wince/SimpleFontDataWinCE.cpp: Ditto.
* platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.

LayoutTests:

Reviewed by Dan Bernstein.

* platform/chromium/test_expectations.txt: Updates expectation for fast/text/unicode-variation-selector.html. Need rebaselines.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd --efl alias for --platform=efl to run-webkit-test
gyuyoung.kim@samsung.com [Tue, 10 Jan 2012 10:34:46 +0000 (10:34 +0000)]
Add --efl alias for --platform=efl to run-webkit-test
https://bugs.webkit.org/show_bug.cgi?id=75937

Reviewed by Andreas Kling.

* Scripts/run-webkit-tests: Add --efl alias.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
(parse_args):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoblock mask overlay test for CSS3 calc
mikelawther@chromium.org [Tue, 10 Jan 2012 10:21:29 +0000 (10:21 +0000)]
block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896

Reviewed by Ryosuke Niwa.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
* css3/calc/block-mask-overlay-image-outset.html: Added.
* css3/calc/resources/mask.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
bashi@chromium.org [Tue, 10 Jan 2012 10:13:02 +0000 (10:13 +0000)]
WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
https://bugs.webkit.org/show_bug.cgi?id=73419

Source/WebCore:

Holds the CachedFont handle in CSSFontFaceSrcValue so that avoiding re-validation during style recalculation.

Reviewed by Dan Bernstein.

Test: http/tests/css/font-face-src-loading.html

* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont): Added.
* css/CSSFontFaceSrcValue.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Gets the CachedFont from CSSFontFaceSrcValue object. The object will request the resource if it doesn't exist.

LayoutTests:

Reviewed by Dan Bernstein.

Adds a test that ensures re-fetching WebFonts doesn't occur after style recalculation.

* http/tests/css/font-face-src-loading-expected.txt: Added.
* http/tests/css/font-face-src-loading.html: Added.
* http/tests/css/resources/webfont-request.php: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: introduce experimental setting that makes source files always editable
pfeldman@chromium.org [Tue, 10 Jan 2012 09:58:33 +0000 (09:58 +0000)]
Web Inspector: introduce experimental setting that makes source files always editable
https://bugs.webkit.org/show_bug.cgi?id=75626

Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Timothy Hatcher.

* English.lproj/localizedStrings.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onselect):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype.setReadOnly):
* inspector/front-end/inspector.js:
(WebInspector.loaded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll Chromium DEPS from 116979 to 117006.
rniwa@webkit.org [Tue, 10 Jan 2012 09:08:57 +0000 (09:08 +0000)]
Roll Chromium DEPS from 116979 to 117006.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed test fix after r103683.
loislo@chromium.org [Tue, 10 Jan 2012 09:08:06 +0000 (09:08 +0000)]
Unreviewed test fix after r103683.

* inspector/first-open-scripts.html:
* inspector/show-panel.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r104507.
commit-queue@webkit.org [Tue, 10 Jan 2012 05:42:38 +0000 (05:42 +0000)]
Unreviewed, rolling out r104507.
http://trac.webkit.org/changeset/104507
https://bugs.webkit.org/show_bug.cgi?id=75936

Broke webkit_unit_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
* platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
* platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerIteratorTest.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTouch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.
rniwa@webkit.org [Tue, 10 Jan 2012 05:39:34 +0000 (05:39 +0000)]
Touch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.

* public/WebView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.
dimich@chromium.org [Tue, 10 Jan 2012 04:44:03 +0000 (04:44 +0000)]
[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.

* platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed update for test_expectations.txt.
dimich@chromium.org [Tue, 10 Jan 2012 04:12:53 +0000 (04:12 +0000)]
[Chromium] Unreviewed update for test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll Chromium DEPS from 116459 to 116979.
rniwa@webkit.org [Tue, 10 Jan 2012 04:10:46 +0000 (04:10 +0000)]
Roll Chromium DEPS from 116459 to 116979.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Rebaseline a lot of tests with input controls after r104494
dimich@chromium.org [Tue, 10 Jan 2012 03:00:26 +0000 (03:00 +0000)]
[Chromium] Rebaseline a lot of tests with input controls after r104494
https://bugs.webkit.org/show_bug.cgi?id=75924

Unreviewed.

* platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
* platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-leopard/fast/css/line-height-expected.png:
* platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
* platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
* platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
* platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
* platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
* platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
* platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-leopard/fast/table/003-expected.png:
* platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/032-expected.png: Renamed from LayoutTests/platform/chromium/fast/block/float/032-expected.png.
* platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
* platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
* platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/basic-inputs-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-disabled-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-height-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/validation-message-appearance-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
* platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt.
* platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-snowleopard/fast/table/003-expected.png:
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Renamed from LayoutTests/platform/chromium/fast/table/colspanMinWidth-expected.png.
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
* platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png.
* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium/fast/forms/minWidthPercent-expected.png: Removed.
* platform/chromium/fast/replaced/width100percent-textfield-expected.png: Removed.
* platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Removed.
* platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
* platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2012-01-09 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 10 Jan 2012 02:40:36 +0000 (02:40 +0000)]
2012-01-09  Rob Buis  <rbuis@rim.com>

        Upstream change to disable input[color] css rules for BlackBerry port
        https://bugs.webkit.org/show_bug.cgi?id=75719

        Reviewed by Antonio Gomes.

        Do not enable default css color rules for input["color"] for BlackBerry port.

        * CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Implement navigator.startActivity; add IntentRequest object for manag...
commit-queue@webkit.org [Tue, 10 Jan 2012 02:29:38 +0000 (02:29 +0000)]
Source/WebCore: Implement navigator.startActivity; add IntentRequest object for managing web intents callbacks.
Web content will invoke navigator.startActivity to launch a new Web
Intents call. Each such call will map to an IntentRequest broker
object which is used by client code to correlate any return data to
the (optional) callbacks supplied by web content calls.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

Test: webintents/web-intents-api.html

* Modules/intents/Intent.cpp: Added.
(WebCore::Intent::identifier):
(WebCore::Intent::setIdentifier):
* Modules/intents/Intent.h: Added.
* Modules/intents/Intent.idl: Added.
* Modules/intents/IntentResultCallback.h: Added.
(WebCore::IntentResultCallback::~IntentResultCallback):
* Modules/intents/IntentResultCallback.idl: Added.
* Modules/intents/IntentsRequest.cpp: Added.
* Modules/intents/IntentsRequest.h: Added.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeTypeForCallbacks):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchIntent):

LayoutTests: Implement navigator.startActivity; add IntentsController for managing web intents callbacks.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

* webintents/web-intents-api-expected.txt: Added.
* webintents/web-intents-api.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
mitz@apple.com [Tue, 10 Jan 2012 02:14:33 +0000 (02:14 +0000)]
-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
https://bugs.webkit.org/show_bug.cgi?id=75920

Reviewed by Darin Adler.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm

* page/mac/FrameMac.mm:
(WebCore::Frame::rangeImage): Removed the requirement that the start and end positions used
for setting the selection in the render tree be candidates.

Tools:

* TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST): Added a test for a range in a
-webkit-user-select: none; block.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Refactoring] Moving between TreeScopes should be done by its own class.
morrita@google.com [Tue, 10 Jan 2012 02:11:30 +0000 (02:11 +0000)]
[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp: Followed the renaming.
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
* dom/DOMAllInOne.cpp:
* dom/Document.cpp: Followed te renaming.
(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):
* dom/Element.cpp: Followed te renaming.
(WebCore::Element::removeShadowRoot):
* dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):
* dom/Node.h:
* dom/TreeScope.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()
* dom/TreeScopeAdopter.cpp: Added.
(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
* dom/TreeScopeAdopter.h: Added.
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoError handling : in ISO8601 timezone
barraclough@apple.com [Tue, 10 Jan 2012 02:03:22 +0000 (02:03 +0000)]
Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
    - need to increment the string position.

LayoutTests:

* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
    - added test cases.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorun-bindings-tests should exercise all the IDL attributes we use
abarth@webkit.org [Tue, 10 Jan 2012 01:56:56 +0000 (01:56 +0000)]
run-bindings-tests should exercise all the IDL attributes we use
https://bugs.webkit.org/show_bug.cgi?id=75900

Reviewed by Eric Seidel.

I just grepped through the code generator script for IDL attributes and
wrote tests for them.

* bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Added.
* bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Added.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetterPrivate.h: Added.
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Added.
* bindings/scripts/test/JS/JSTestActiveDOMObject.h: Added.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp: Added.
* bindings/scripts/test/JS/JSTestEventTarget.h: Added.
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/JS/JSTestOverridingNameGetter.h: Added.
* bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Added.
* bindings/scripts/test/ObjC/DOMTestEventTarget.h: Added.
* bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Added.
* bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Added.
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.h: Added.
* bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.mm: Added.
* bindings/scripts/test/ObjC/DOMTestOverridingNameGetterInternal.h: Added.
* bindings/scripts/test/TestDomainSecurity.idl: Added.
* bindings/scripts/test/TestEventConstructor.idl:
* bindings/scripts/test/TestEventTarget.idl: Added.
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestOverridingNameGetter.idl: Added.
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Added.
* bindings/scripts/test/V8/V8TestActiveDOMObject.h: Added.
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
* bindings/scripts/test/V8/V8TestEventTarget.cpp: Added.
* bindings/scripts/test/V8/V8TestEventTarget.h: Added.
* bindings/scripts/test/V8/V8TestInterface.h:
* bindings/scripts/test/V8/V8TestObj.cpp:
* bindings/scripts/test/V8/V8TestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/V8/V8TestOverridingNameGetter.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agobackground position parsing test for CSS3 calc
mikelawther@chromium.org [Tue, 10 Jan 2012 01:54:08 +0000 (01:54 +0000)]
background position parsing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75823

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/background-position-parsing-expected-mismatch.html: Added.
* css3/calc/background-position-parsing.html: Added.
* css3/calc/resources/diamond.png: Added.
* css3/calc/resources/ring.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing...
dpranke@chromium.org [Tue, 10 Jan 2012 01:32:54 +0000 (01:32 +0000)]
webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
https://bugs.webkit.org/show_bug.cgi?id=75884

Reviewed by Ryosuke Niwa.

Fix regression introduced (revealed?) in r104340. Chromium file
url syntax is different on win32 and the test results weren't
expecting that.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltest__fails):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
(TestRebaseliner.make_rebaseliner):
(TestRebaseliner.test_one_platform):
(TestRebaseliner.test_all_platforms):
(TestRebaseliner.test_png_file_with_comment):
(TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
(TestRebaseliner.test_png_file_with_comment_as_duplicate):
(TestRealMain.test_all_platforms):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttp/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
noel.gordon@gmail.com [Tue, 10 Jan 2012 01:24:13 +0000 (01:24 +0000)]
http/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
https://bugs.webkit.org/show_bug.cgi?id=75186

Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add documentation to updater classes
nduca@chromium.org [Tue, 10 Jan 2012 01:21:14 +0000 (01:21 +0000)]
[chromium] Add documentation to updater classes
https://bugs.webkit.org/show_bug.cgi?id=75866

Reviewed by James Robinson.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/CanvasLayerTextureUpdater.h:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNew pixel test results with r104351.
jonlee@apple.com [Tue, 10 Jan 2012 01:14:16 +0000 (01:14 +0000)]
New pixel test results with r104351.

Unreviewed.

Moved from mac to mac-snowleopard:

* platform/mac-snowleopard/fast/block/margin-collapse/103

New pixel test results:

* platform/mac/fast/block/margin-collapse/103-expected.png:
* platform/mac/fast/table/003-expected.png:
* platform/mac/tables/mozilla/bugs/bug194024-expected.png:
* platform/mac/tables/mozilla/bugs/bug30692-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoimg size test for CSS3 calc
mikelawther@chromium.org [Tue, 10 Jan 2012 01:12:34 +0000 (01:12 +0000)]
img size test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75893

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/img-size-expected-mismatch.html: Added.
* css3/calc/img-size.html: Added.
* css3/calc/resources/colorsquare.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove unused variable from CodeGeneratorV8
abarth@webkit.org [Tue, 10 Jan 2012 00:42:31 +0000 (00:42 +0000)]
Remove unused variable from CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=75895

Reviewed by Eric Seidel.

Unused variables aren't worth keeping around.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore...
mrowe@apple.com [Tue, 10 Jan 2012 00:41:32 +0000 (00:41 +0000)]
JavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore framework target <webkit.org/b/75907> / <rdar://problem/10659862>

We'd like for it to be possible to build jsc without building JavaScriptCore.framework and the explicit
dependencies prevent this.

Reviewed by Dan Bernstein.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTemporary fix for pixel result diffs from focus ring (darker color on WK2).
jonlee@apple.com [Tue, 10 Jan 2012 00:39:58 +0000 (00:39 +0000)]
Temporary fix for pixel result diffs from focus ring (darker color on WK2).
These results should be removed once the cause is found-- filed as bug:
https://bugs.webkit.org/show_bug.cgi?id=75909

Unreviewed.

* platform/mac-wk2/fast/forms/plaintext-mode-2-expected.png: Added.
* platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSome gardening with fix for r104351.
jonlee@apple.com [Tue, 10 Jan 2012 00:33:10 +0000 (00:33 +0000)]
Some gardening with fix for r104351.

Moving pixel test results from mac to mac-snowleopard (because of theme changes):

* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label01
* platform/mac-snowleopard/fast/forms/button-cannot-be-nested
* platform/mac-snowleopard/fast/forms/button-inner-block-reuse
* platform/mac-snowleopard/fast/forms/control-clip-overflow
* platform/mac-snowleopard/fast/forms/file/input-file-re-render
* platform/mac-snowleopard/fast/forms/formmove
* platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur
* platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed
* platform/mac-snowleopard/fast/forms/listbox-scrollbar-incremental-load
* platform/mac-snowleopard/fast/forms/menulist-width-change
* platform/mac-snowleopard/fast/forms/option-text-clip
* platform/mac-snowleopard/fast/forms/plaintext-mode-2
* platform/mac-snowleopard/fast/forms/range/slider-thumb-shared-style
* platform/mac-snowleopard/fast/forms/search-vertical-alignment
* platform/mac-snowleopard/fast/forms/select-change-listbox-to-popup
* platform/mac-snowleopard/fast/forms/select-item-background-clip
* platform/mac-snowleopard/fast/forms/select-selected
* platform/mac-snowleopard/fast/forms/select-size
* platform/mac-snowleopard/fast/forms/select-visual-hebrew
* platform/mac-snowleopard/fast/forms/textarea-scrollbar
* platform/mac-snowleopard/fast/forms/textarea-scrolled

New pixel test results:

* platform/mac/fast/forms/001-expected.png:
* platform/mac/fast/forms/006-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label01-expected.png:
* platform/mac/fast/forms/basic-buttons-expected.png:
* platform/mac/fast/forms/basic-inputs-expected.png:
* platform/mac/fast/forms/basic-selects-expected.png:
* platform/mac/fast/forms/basic-textareas-expected.png:
* platform/mac/fast/forms/basic-textareas-quirks-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/button-align-expected.png:
* platform/mac/fast/forms/button-cannot-be-nested-expected.png:
* platform/mac/fast/forms/button-default-title-expected.png:
* platform/mac/fast/forms/button-generated-content-expected.png:
* platform/mac/fast/forms/button-inner-block-reuse-expected.png:
* platform/mac/fast/forms/button-sizes-expected.png:
* platform/mac/fast/forms/button-style-color-expected.png:
* platform/mac/fast/forms/button-table-styles-expected.png:
* platform/mac/fast/forms/button-text-transform-expected.png:
* platform/mac/fast/forms/button-white-space-expected.png:
* platform/mac/fast/forms/control-clip-overflow-expected.png:
* platform/mac/fast/forms/control-restrict-line-height-expected.png:
* platform/mac/fast/forms/disabled-select-change-index-expected.png:
* platform/mac/fast/forms/fieldset-align-expected.png:
* platform/mac/fast/forms/file/file-input-direction-expected.png:
* platform/mac/fast/forms/file/input-file-re-render-expected.png:
* platform/mac/fast/forms/floating-textfield-relayout-expected.png:
* platform/mac/fast/forms/form-element-geometry-expected.png:
* platform/mac/fast/forms/form-hides-table-expected.png:
* platform/mac/fast/forms/formmove-expected.png:
* platform/mac/fast/forms/input-align-expected.png:
* platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-appearance-width-expected.png:
* platform/mac/fast/forms/input-baseline-expected.png:
* platform/mac/fast/forms/input-button-sizes-expected.png:
* platform/mac/fast/forms/input-table-expected.png:
* platform/mac/fast/forms/input-text-click-outside-expected.png:
* platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/mac/fast/forms/input-value-expected.png:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/mac/fast/forms/listbox-bidi-align-expected.png:
* platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
* platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
* platform/mac/fast/forms/menulist-width-change-expected.png:
* platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/mac/fast/forms/option-strip-whitespace-expected.png:
* platform/mac/fast/forms/option-text-clip-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
* platform/mac/fast/forms/plaintext-mode-2-expected.png:
* platform/mac/fast/forms/radio_checked_dynamic-expected.png:
* platform/mac/fast/forms/range/input-appearance-range-expected.png:
* platform/mac/fast/forms/range/slider-padding-expected.png:
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png:
* platform/mac/fast/forms/search-vertical-alignment-expected.png:
* platform/mac/fast/forms/select-align-expected.png:
* platform/mac/fast/forms/select-change-listbox-size-expected.png:
* platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
* platform/mac/fast/forms/select-initial-position-expected.png:
* platform/mac/fast/forms/select-item-background-clip-expected.png:
* platform/mac/fast/forms/select-selected-expected.png:
* platform/mac/fast/forms/select-size-expected.png:
* platform/mac/fast/forms/select-style-expected.png:
* platform/mac/fast/forms/select-visual-hebrew-expected.png:
* platform/mac/fast/forms/select-writing-direction-natural-expected.png:
* platform/mac/fast/forms/textAreaLineHeight-expected.png:
* platform/mac/fast/forms/textarea-align-expected.png:
* platform/mac/fast/forms/textarea-scrollbar-expected.png:
* platform/mac/fast/forms/textarea-scrolled-type-expected.png:
* platform/mac/fast/forms/textarea-width-expected.png:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Create iterators for the RenderSurface-Layer tree
commit-queue@webkit.org [Tue, 10 Jan 2012 00:31:55 +0000 (00:31 +0000)]
[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-09
Reviewed by James Robinson.

Source/WebCore:

New unit tests: CCLayerIteratorTest.cpp

* WebCore.gypi:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
* platform/graphics/chromium/cc/CCLayerIterator.h: Added.
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
* platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerIteratorTest.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Throw exception if IDBCursor.continue() called with lower key than current
commit-queue@webkit.org [Tue, 10 Jan 2012 00:13:12 +0000 (00:13 +0000)]
IndexedDB: Throw exception if IDBCursor.continue() called with lower key than current
https://bugs.webkit.org/show_bug.cgi?id=74213

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

Source/WebCore:

* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunction):

LayoutTests:

* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingO...
wjmaclean@chromium.org [Tue, 10 Jan 2012 00:12:18 +0000 (00:12 +0000)]
[Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
https://bugs.webkit.org/show_bug.cgi?id=75783

Updated unit test to reflect desired behaviour now that tile/quad culling
is implemented.

Reviewed by James Robinson.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTests for nested flexboxes
ojan@chromium.org [Tue, 10 Jan 2012 00:03:12 +0000 (00:03 +0000)]
Tests for nested flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70776

Reviewed by Tony Chang.

* css3/flexbox/orthogonal-flex-directions-expected.txt: Added.
* css3/flexbox/orthogonal-flex-directions.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix potential issue in WebMediaPlayerClientImpl
crogers@google.com [Mon, 9 Jan 2012 23:56:49 +0000 (23:56 +0000)]
Fix potential issue in WebMediaPlayerClientImpl
https://bugs.webkit.org/show_bug.cgi?id=75899

Reviewed by Kenneth Russell.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium win] Creating lots of temporary canvas contexts will crash.
commit-queue@webkit.org [Mon, 9 Jan 2012 23:53:36 +0000 (23:53 +0000)]
[chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text.  Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* platform/graphics/ImageBuffer.h:
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
dpranke@chromium.org [Mon, 9 Jan 2012 23:14:09 +0000 (23:14 +0000)]
Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.

Unreviewed, build fix.

test-webkitpy had a built-in self-test routine to verify that
deleting the .pyc files worked correctly. When I removed the
python24 directory in r104482, I broke the self-test.

I have deleted the self-test for now. Since I am reworking
test-webkitpy I will make sure the new version is adequately
tested.

* Scripts/test-webkitpy:
(configure_logging):
(_clean_pyc_files):
(_clean_packages):
(init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=75860
abarth@webkit.org [Mon, 9 Jan 2012 23:13:00 +0000 (23:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Dimitri Glazkov.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintTextField):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=75692
barraclough@apple.com [Mon, 9 Jan 2012 22:43:24 +0000 (22:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75692
Roll out possibly bad new test case.

Rubber stamped by Sam Weinig.

* fast/js/date-constructor-expected.txt:
* fast/js/script-tests/date-constructor.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLog is a little to verbose for blackberry port
commit-queue@webkit.org [Mon, 9 Jan 2012 22:06:18 +0000 (22:06 +0000)]
Log is a little to verbose for blackberry port
https://bugs.webkit.org/show_bug.cgi?id=75728

The BlackBerry::Platform::Log* functions take care of the call to vfprintf
which is resulting in unintentional noise in our logs.  Add a conditional
directive to fix.

Change to using BlackBerry::Platform::logStreamV which does not insert
threading info and newlines unlike BlackBerry::Platform::log.

Finally, add log locking and unlocking which the BlackBerry platform
uses to ensure that N threads do not trample on each other's logs.

Patch by Adam Treat <atreat@rim.com> on 2012-01-09
Reviewed by Rob Buis.

* wtf/Assertions.cpp:
(WTFLogLocker::WTFReportAssertionFailure):
(WTFLogLocker::WTFReportAssertionFailureWithMessage):
(WTFLogLocker::WTFReportArgumentAssertionFailure):
(WTFLogLocker::WTFReportFatalError):
(WTFLogLocker::WTFReportError):
(WTFLogLocker::WTFLog):
(WTFLogLocker::WTFLogVerbose):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCompilation error on build-webkit --debug --no-3d-canvas on mac.
commit-queue@webkit.org [Mon, 9 Jan 2012 22:02:29 +0000 (22:02 +0000)]
Compilation error on build-webkit --debug --no-3d-canvas on mac.
https://bugs.webkit.org/show_bug.cgi?id=75878

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-09
Reviewed by Alexey Proskuryakov.

* html/canvas/WebGLContextEvent.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Rebaseline media/media-document-audio-repaint.html for gpu tests.
dimich@chromium.org [Mon, 9 Jan 2012 22:00:10 +0000 (22:00 +0000)]
[Chromium] Rebaseline media/media-document-audio-repaint.html for gpu tests.
https://bugs.webkit.org/show_bug.cgi?id=75888

Unreviewed.

* platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
* platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Removed.
* platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/media-document-audio-repaint-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=75789
barraclough@apple.com [Mon, 9 Jan 2012 21:56:46 +0000 (21:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75789
defineOwnProperty not implemented for Array objects

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Implements support for getter/setter & non-default attribute properties on arrays,
by forcing them into a dictionary-like 'SparseMode'. This fixes ~300 test-262
test failures.

* JavaScriptCore.exp:
    - Updated exports.
* dfg/DFGOperations.cpp:
    - JSArray::pop now requires an exec state.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
    - JSArray::pop now requires an exec state.
* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::add):
    - Add a potentially empty entry into the map.
(JSC::SparseArrayValueMap::put):
    - Changed to call setter.
(JSC::SparseArrayEntry::get):
    - calls getters.
(JSC::SparseArrayEntry::getNonSparseMode):
    - does not call getters.
(JSC::JSArray::enterSparseMode):
    - Convert into 'SparseMode' - removes the vectors, don't allow it to be recreated.
(JSC::JSArray::putDescriptor):
    - Create a numeric property based on a descriptor.
(JSC::sameValue):
    - See ES5.1 9.12.
(JSC::reject):
    - Helper for the [[DefineOwnProperty]] algorithm.
(JSC::JSArray::defineOwnNumericProperty):
    - Define an indexed property on an array object.
(JSC::JSArray::setLengthWritable):
    - Marks the length read-only, enters SparseMode as necessary.
(JSC::JSArray::defineOwnProperty):
    - Defines either an indexed property or 'length' on an array object.
(JSC::JSArray::getOwnPropertySlotByIndex):
    - Updated to correctly handle accessor descriptors & attributes.
(JSC::JSArray::getOwnPropertyDescriptor):
    - Updated to correctly handle accessor descriptors & attributes.
(JSC::JSArray::put):
    - Pass strict mode flag to setLength.
(JSC::JSArray::putByIndex):
    - putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.
(JSC::JSArray::putByIndexBeyondVectorLength):
    - Pass exec to SparseArrayValueMap::put.
(JSC::JSArray::deletePropertyByIndex):
    - Do not allow deletion of non-configurable properties.
(JSC::compareKeysForQSort):
    - used in implementation of getOwnPropertyNames.
(JSC::JSArray::getOwnPropertyNames):
    - Properties in the sparse map should be iterated in order.
(JSC::JSArray::setLength):
    - Updated to take a 'shouldThrow' flag, return a result indicating error.
(JSC::JSArray::pop):
    - pop should throw an error if length is not writable, even if the array is empty.
(JSC::JSArray::push):
    - putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.
(JSC::JSArray::sort):
    - Changed 'get' to 'getNonSparseMode' (can't be getters to call).
(JSC::JSArray::compactForSorting):
    - Changed 'get' to 'getNonSparseMode' (can't be getters to call).
* runtime/JSArray.h:
(JSC::SparseArrayValueMap::lengthIsReadOnly):
    - Check if the length is read only.
(JSC::SparseArrayValueMap::setLengthIsReadOnly):
    - Mark the length as read only.
(JSC::SparseArrayValueMap::find):
    - Moved into header.
(JSC::JSArray::isLengthWritable):
    - Wraps SparseArrayValueMap::lengthIsReadOnly.
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
    - Should be returning the result of putDescriptor.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesOverridingCurrent):
    - Added attributesOverridingCurrent - this should probably be merged with attributesWithOverride.
* runtime/PropertyDescriptor.h:
    - Added attributesOverridingCurrent.

LayoutTests:

* fast/js/array-defineOwnProperty-expected.txt: Added.
* fast/js/array-defineOwnProperty.html: Added.
* fast/js/script-tests/array-defineOwnProperty.js: Added.
    - Added tests for array properties with accessors & non-defulat attributes.
* fast/js/mozilla/strict/15.4.4.6-expected.txt:
* fast/js/mozilla/strict/8.12.5-expected.txt:
* ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
* ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
    - Check in passing results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTreat code="" attribute in embed tags similarly to applet tags.
tsepez@chromium.org [Mon, 9 Jan 2012 21:32:26 +0000 (21:32 +0000)]
Treat code="" attribute in embed tags similarly to applet tags.
https://bugs.webkit.org/show_bug.cgi?id=75871

Reviewed by Daniel Bates.

Source/WebCore:

Tests: http/tests/security/xssAuditor/embed-tag-code-attribute-2.html
       http/tests/security/xssAuditor/embed-tag-code-attribute.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterEmbedToken):

LayoutTests:

* http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt: Added.
* http/tests/security/xssAuditor/embed-tag-code-attribute-2.html: Added.
* http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt: Added.
* http/tests/security/xssAuditor/embed-tag-code-attribute.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] remove all references to the legacy accelerated 2d Canvas
commit-queue@webkit.org [Mon, 9 Jan 2012 21:25:25 +0000 (21:25 +0000)]
[Chromium] remove all references to the legacy accelerated 2d Canvas
implementation
https://bugs.webkit.org/show_bug.cgi?id=75108

Purging an old settings flag that is no longer referenced

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Darin Fisher.

Source/WebCore:

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:

Tools:

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAccelerated2dCanvasEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoConvert Cygwin paths to Windows paths before passing them to DRT
aroben@apple.com [Mon, 9 Jan 2012 21:16:17 +0000 (21:16 +0000)]
Convert Cygwin paths to Windows paths before passing them to DRT

Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
NRWT

I couldn't find a way to test this because I couldn't figure out how to override the
cygpath function as it is used by WebKitDriver.

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
Windows-style path before passing it to DRT.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: revamp version checking
dpranke@chromium.org [Mon, 9 Jan 2012 21:10:47 +0000 (21:10 +0000)]
webkitpy: revamp version checking
https://bugs.webkit.org/show_bug.cgi?id=75765

Reviewed by Adam Barth.

The version-checking code in webkitpy/python24/versioning seems really
awkward and overdesigned, especially since we don't support python 2.4
any more.

In addition, I am tired of getting warnings about Python 2.6 being "a
newer release than what is supported" :).

I'm taking a page from the depot_tools python code and just creating a
new webkitpy.common.version_check module that will print a message on
stderr and call sys.exit() if we're running an unsupported version.

* Scripts/check-webkit-style:
* Scripts/new-run-webkit-httpd:
* Scripts/new-run-webkit-tests:
* Scripts/rebaseline-chromium-webkit-tests:
* Scripts/test-webkitpy:
(configure_logging):
(init):
* Scripts/webkit-patch:
(main):
* Scripts/webkitpy/common/system/executive.py:
(Executive._child_process_encoding):
(Executive._should_encode_child_process_arguments):
* Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/python24/__init__.py: Removed.
* Scripts/webkitpy/python24/versioning.py: Removed.
* Scripts/webkitpy/python24/versioning_unittest.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Make WebIDBDatabase::close() idempotent
commit-queue@webkit.org [Mon, 9 Jan 2012 21:08:32 +0000 (21:08 +0000)]
IndexedDB: Make WebIDBDatabase::close() idempotent
https://bugs.webkit.org/show_bug.cgi?id=75751

Source/WebKit/chromium:

Allow Chromium's back-end to safely trigger the cleanup that occurs
when a database connection is closed, without tracking whether or not
the connection was previous closed by script.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::close):

LayoutTests:

Verify that calling IDBDatabase.close() twice from script is harmless.
Note that the tests pass without the related code change in the bug,
which is just for non-script use by the chromium port.

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.

* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-basics.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoremove reference to cg-specific test
commit-queue@webkit.org [Mon, 9 Jan 2012 20:58:20 +0000 (20:58 +0000)]
remove reference to cg-specific test
https://bugs.webkit.org/show_bug.cgi?id=75881

Patch by Elliot Poger <epoger@google.com> on 2012-01-09
Reviewed by Ojan Vafai.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track...
eric.carlson@apple.com [Mon, 9 Jan 2012 20:53:52 +0000 (20:53 +0000)]
Source/WebCore: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html
intermittently time out, media/track/track-cues-seeking and  fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

No new tests, covered by existing tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_ignoreTrackDisplayUpdate.

LayoutTests: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html intermittently time out, media/track/track-cues-seeking and  fails
https://bugs.webkit.org/show_bug.cgi?id=75817

Unreviewed, fix a problem introduced in r104327.

Re-enable <track> tests disabled after r104327.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove Chromium Mac CG from the flakiness dashboard
abarth@webkit.org [Mon, 9 Jan 2012 20:38:52 +0000 (20:38 +0000)]
Remove Chromium Mac CG from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=75873

Reviewed by Ojan Vafai.

This configuration no longer exists.

* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testOverrideJustBuildType):
(testPlatformAndBuildType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd normalize attribute to ConvolverNode to disable normalization.
commit-queue@webkit.org [Mon, 9 Jan 2012 20:22:41 +0000 (20:22 +0000)]
Add normalize attribute to ConvolverNode to disable normalization.
https://bugs.webkit.org/show_bug.cgi?id=75126

Patch by Raymond Toy <rtoy@google.com> on 2012-01-09
Reviewed by Kenneth Russell.

Tests added in convolution-mono-mono.html.

* platform/audio/Reverb.cpp:
(WebCore::Reverb::Reverb): Add extra arg to indicate whether
normalization is enabled or not, and do it.
* platform/audio/Reverb.h: Update declaration.
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode): Initialize attribute (to
true).
(WebCore::ConvolverNode::setBuffer): Call Reverb with
normalization argument.
* webaudio/ConvolverNode.h:
(WebCore::ConvolverNode::normalize): New method to return
normalization.
(WebCore::ConvolverNode::setNormalize):  New method to set
normalization.
* webaudio/ConvolverNode.idl: Add normalize attribute.
* LayoutTests/webaudio/convolution-mono-mono.html:
* LayoutTests/webaudio/convolution-mono-mono-expected.txt:
* LayoutTests/webaudio/resources/convolution-testing.js:
Test for convolution.  Tests only work when normalization is
disabled.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GStreamer] webkitwebsrc: pad template is leaked
commit-queue@webkit.org [Mon, 9 Jan 2012 20:17:09 +0000 (20:17 +0000)]
[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224

Patch by Judy Hao <judy.liqiong-hao@nokia.com> on 2012-01-09
Reviewed by Philippe Normand.

Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.

Fixing memory leaks. So, no new test case is introduced.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAvoid unnecessary TextureManager::reduceMemoryToLimit().
wangxianzhu@chromium.org [Mon, 9 Jan 2012 20:15:33 +0000 (20:15 +0000)]
Avoid unnecessary TextureManager::reduceMemoryToLimit().
https://bugs.webkit.org/show_bug.cgi?id=75632

Source/WebCore:

Unnecessary TextureManager::reduceMemoryToLimit() will cause some tile
textures that are required soon to be unnecessarily removed/replaced,
and degrade performance, sometimes significantly.

For example, CCLayerTreeHost::setViewport will be called during
scrolling. The original code would call TextureManager::reduceMemoryToLimit(),
causing some textures unnecessarily discarded and then recreated
repeatedly during scrolling.

It's also unnecessary to call TextureManager::reduceMemoryToLimit()
from TextureManager::setPreferredMemoryLimitBytes() because the limit
is not a hard limit. The callers should call reduceMemoryToLimit()
explicitly if it wants it when setting the preferred memory limit.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finishDrawingFrame): Call reduceMemoryToLimit() explicitly
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::setPreferredMemoryLimitBytes): Removed call to reduceMemoryToLimit().
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize): Changed name from setViewport(). Check change of viewportSize.
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setViewportSize): Changed name from setViewport()
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Main part of the change is in Source/WebCore.

Reviewed by James Robinson.

Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*

* WebKit.gypi:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setViewportSize):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::CCLayerTreeHostTestSetViewportSize):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::afterTest):
(WTF::TEST_F):
* tests/TextureManagerTest.cpp: Added.
(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeTextureAllocator::deleteTexture):
(WTF::texturesMemorySize):
(WTF::createTextureManager):
(WTF::requestTexture):
(WTF::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThere is no support for fastcall in Solaris Studio.
commit-queue@webkit.org [Mon, 9 Jan 2012 20:02:11 +0000 (20:02 +0000)]
There is no support for fastcall in Solaris Studio.
Fixes build on Solaris.
https://bugs.webkit.org/show_bug.cgi?id=75736

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

* jit/JITStubs.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] JPEG RGB swizzling order should match platform pixel format
commit-queue@webkit.org [Mon, 9 Jan 2012 19:46:30 +0000 (19:46 +0000)]
[Chromium] JPEG RGB swizzling order should match platform pixel format
https://bugs.webkit.org/show_bug.cgi?id=75861

Choose between JCS_EXT_BGRX and JCS_EXT_RGBX channel swizzling
based on the configured Skia 32-bit pixel format.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-09
Reviewed by Kenneth Russell.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(rgbOutputColorSpace):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build failure on Solaris
commit-queue@webkit.org [Mon, 9 Jan 2012 19:44:38 +0000 (19:44 +0000)]
Fix build failure on Solaris
https://bugs.webkit.org/show_bug.cgi?id=75733

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.

* wtf/ByteArray.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogetComputedStyle for border-radius is not implemented.
alexis.menard@openbossa.org [Mon, 9 Jan 2012 19:26:54 +0000 (19:26 +0000)]
getComputedStyle for border-radius is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75630

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-radius shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

* fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CMake] Clean up some cruft from WTF's CMakeLists.txt
kubo@profusion.mobi [Mon, 9 Jan 2012 19:17:11 +0000 (19:17 +0000)]
[CMake] Clean up some cruft from WTF's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420

Reviewed by Daniel Bates.

* wtf/CMakeLists.txt: Remove the unused WTF_PORT_FLAGS variable; add
all needed paths to WTF_INCLUDE_DIRECTORIES in a single place.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove expected results for Chromium Mac CG. This configuration is no longer supported.
abarth@webkit.org [Mon, 9 Jan 2012 19:16:06 +0000 (19:16 +0000)]
Remove expected results for Chromium Mac CG.  This configuration is no longer supported.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove expected results for Chromium Mac CG. This configuration is no longer supported.
abarth@webkit.org [Mon, 9 Jan 2012 19:15:46 +0000 (19:15 +0000)]
Remove expected results for Chromium Mac CG.  This configuration is no longer supported.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove expected results for Chromium Mac CG. This configuration is no longer supported.
abarth@webkit.org [Mon, 9 Jan 2012 19:15:22 +0000 (19:15 +0000)]
Remove expected results for Chromium Mac CG.  This configuration is no longer supported.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove expected results for Chromium Mac CG. This configuration is no longer supported.
abarth@webkit.org [Mon, 9 Jan 2012 19:15:04 +0000 (19:15 +0000)]
Remove expected results for Chromium Mac CG.  This configuration is no longer supported.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrint an error message when NRWT can't run Apache
aroben@apple.com [Mon, 9 Jan 2012 18:38:49 +0000 (18:38 +0000)]
Print an error message when NRWT can't run Apache

Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.check_httpd): Print an error message when Apache returns an error code instead of
failing silently.

* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
run Apache.
(PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
fails.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Update test expectations.
jknotten@chromium.org [Mon, 9 Jan 2012 15:34:02 +0000 (15:34 +0000)]
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75856

media/track/track-webvtt-tc026-voice.html is crashing on Chromium
Debug Mac after http://trac.webkit.org/changeset/104327/

Tracking in bug 75817.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Gtk][ARM] Cross compiler buildbot is failing after r103040
rgabor@webkit.org [Mon, 9 Jan 2012 15:32:16 +0000 (15:32 +0000)]
[Gtk][ARM] Cross compiler buildbot is failing after r103040
https://bugs.webkit.org/show_bug.cgi?id=75846

Reviewed by Philippe Normand.

* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104461 268f45cc-cd09-0410-ab3c-d52691b4dbfc