Ossama Othman [Tue, 11 Aug 2015 21:45:45 +0000 (14:45 -0700)]
[android] Addressed some minor SonarQube issues.
SonarQube flagged overly long lines, tabs in source code and lack of
braces in if-conditional blocks. Fix some of those issues.
Change-Id: I7ac79dda519cbec220118d4a9e283d7ba64d626c
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2177
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Erich Keane [Tue, 11 Aug 2015 18:40:19 +0000 (11:40 -0700)]
Worked Around GCC 4.6.3's Bool issue
GCC 4.6.3 converted bools improperly, I believe this to be a bug in the
compiler, however this work around forces the conversion to happen correctly.
Signed-off-by: Erich Keane <erich.keane@intel.com>
Change-Id: I30bbe9807593075a2518018f268d6e14a8dfa47a
Reviewed-on: https://gerrit.iotivity.org/gerrit/2170
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Tue, 11 Aug 2015 02:29:14 +0000 (11:29 +0900)]
replaced char* with uint8_t in EDR
i have updated EDR code
since EDR is not built after Change 2034.
Change-Id: I8e23fdf88b6da6055127488b33a52c1206ee770d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2165
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Tue, 11 Aug 2015 05:59:01 +0000 (11:29 +0530)]
Add unittests for ConstructResourceTest for invalid uri value
Added a test case for ConstructResourceTest to simulate the scenario
of Resource creation with uri having just "/" as its value.
Change-Id: Ifdc128fc505a862ff4dedcbeff60896c25e1d029
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Mon, 10 Aug 2015 09:12:18 +0000 (14:42 +0530)]
csdk : Refactoring ocpayload.c file
Introduced a static function OCRepPayloadSetProp() and pushed the generic code
for all datatypes.
Change-Id: I787274c91e80c52d61563944d1284aa7c24e10a8
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2152
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Mon, 3 Aug 2015 11:42:50 +0000 (17:12 +0530)]
soft-sensor-manager: Fix cppcheck errors
This patch fixes the errors reported by cppcheck tool for
'(error) Mismatching allocation and deallocation: avg'.
Replaced delete with delete[] wherever the memory is allocated
using new [].
Change-Id: Ic32755347ad24aeb2a1c57341249038fd511073a
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2067
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ossama Othman [Wed, 29 Jul 2015 23:03:14 +0000 (16:03 -0700)]
Clean up some SonarQube warnings in `service' directory.
Clean up trailing whitespace from most text files to address SonarQube
warnings. As a side effect of this clean-up, several files that
should not have been executable had their executable permission bit
removed.
Change-Id: Ib3c56cd426bf868a8aed47d7d68038106e13c5c0
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1981
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ossama Othman [Fri, 31 Jul 2015 23:12:40 +0000 (16:12 -0700)]
Corrected pointer arithmetic on void* variables.
Octet arrays were represented by void* and char* typed variables in
several areas of the CA layer. Use uint8_t* where appropriate to
address undefined pointer arithemetic on pointers to void. Code that
treated the octet arrays as strings (e.g. performed strcpy() on them)
was corrected as well. This addresses several major issues flagged by
SonarQube.
Change-Id: I8d5c57eafa0b0e394e0ee202df1bb7b67c7a59b1
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2034
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
John Light [Wed, 29 Jul 2015 22:33:15 +0000 (15:33 -0700)]
Fix parsing error in IP addresses in resourceURIs
Change-Id: Ia08ce526ffa759a5749a90d0d31ff5dbca60b072
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2120
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
John Light [Thu, 30 Jul 2015 22:14:07 +0000 (15:14 -0700)]
Avoid Segv by testing address field before using it.
sIssue reported off dev list by Gabriel Schulhof.
Change-Id: Ifa529da59fb784fd5cdef6ca333635cf99ed1f59
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2160
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakari Poussa [Mon, 10 Aug 2015 09:48:19 +0000 (12:48 +0300)]
Set socklen explicitly to make OSX happy when sending data
Change-Id: I57e6360bcd2fe26ff2b0cc6cce82011519e84485
Signed-off-by: Sakari Poussa <sakari.poussa@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2153
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Mon, 10 Aug 2015 10:10:24 +0000 (15:40 +0530)]
Add unittests for ConstructResourceTest for invalid host values
Added a test case for ConstructResourceTest to simulate the scenario of
Resource creation with host
* not having the ip or device address and
* not having the "coap://" protocol prefix.
Change-Id: Ic3f1b250950ad2c3a251a56a85e7356c06ac34fb
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2154
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Wed, 5 Aug 2015 06:49:47 +0000 (15:49 +0900)]
Removing build warnings
Aimed to remove build warnings in android sample and ipadapter
Also did minor fixes in other places
Change-Id: I7aa4bf46c1d494d42da89f9264f4e66dc622b815
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2112
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Fri, 7 Aug 2015 02:26:29 +0000 (11:26 +0900)]
fixed the crash for payload, when empty string is used.
Change-Id: Ide824e447dec95cd56a32a21d290044a1571b7f7
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2131
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Sat, 8 Aug 2015 00:23:56 +0000 (17:23 -0700)]
Fixed a bug by correctly invoking CAConvertAddrToName API
Recently, DTLS code in CA layer was updated to use
CAConvertAddrtoName() API instead of inet_ntoa. The API was
wrongly invoked by passing invalid arguments. This caused
failure in security samples.
Change-Id: I33a3981ca1c2ed0635b8def5106282349df611ee
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Ossama Othman [Fri, 7 Aug 2015 19:05:14 +0000 (12:05 -0700)]
Fixed Linux BLE peripheral content type mismatch.
A pointer to an incorrect context object was passed to the GATT
service registration function. Pass a pointer to the correct one
(CAPeripheralContext*) instead. Addresses an "incompatible pointer
type warning".
Change-Id: I3a256ac278a28659bcc2352955a0172eebdc1c90
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2143
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Fri, 7 Aug 2015 18:49:47 +0000 (11:49 -0700)]
Fixed seg fault when filtering Linux BLE devices.
The loop used to filter Linux BLE devices by UUID iterated through a
zero-terminated array, and used the zero terminator as the stopping
condition. However, it neglected to dereference the iterator to check
for the zero terminator, and incorrectly checked the iterator itself.
That resulted in the loop body dereferencing and using the last
element, the zero terminator, in a strcasecmp() call, and ultimately
seg faulting.
Rather than depend on the zero-terminator, obtain the length of the
array and use it to determine the end iterator beforehand.
Change-Id: Idecee74d19ebe01a812ecf17365f39be9ae1f7fe
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2142
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Caiwen Zhang [Thu, 6 Aug 2015 06:46:03 +0000 (14:46 +0800)]
Make sure the object files are put in default output directory
Currently the object files may be not in the default output directory,
if Arduino SDK is installed in the subdirctory of IoTivity project.
Change-Id: I3fb2f6af46e041418fdaedf5ebf93a3d13e21578
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2125
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Minji Park [Fri, 7 Aug 2015 02:25:49 +0000 (11:25 +0900)]
resource-manipulation: modify container tests to get config path information
add logic to get app execution path to container-test
to set config file path when initializing container.
Change-Id: I4edc64caccfd6ce4c7c614673be53c139bbd2516
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2132
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Gabriel Schulhof [Thu, 6 Aug 2015 15:42:56 +0000 (18:42 +0300)]
ocpayload.h: Factor out logging
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Change-Id: I35b7dac9a7877723da5ba3478193a3e8c78a78ed
Reviewed-on: https://gerrit.iotivity.org/gerrit/2128
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Ravi Nanjundappa [Thu, 6 Aug 2015 13:28:58 +0000 (18:58 +0530)]
Doxygen comments correction in OCPlatform.h
Correcting the proper argument names in doxygen comments of OCPlatform.h file
Change-Id: I36b528405a131a6971ce01d9b18d7ffc5f6fff2a
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2126
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Ravi Nanjundappa [Wed, 5 Aug 2015 09:42:17 +0000 (15:12 +0530)]
Add Doxygen comments for OCApi
Add relevant doxygen comments for OCApi.h file.
Change-Id: Ic58af7eb33eed0253b96fcc9e1203f6b8b9d3c57
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2116
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
jihwan.seo [Wed, 5 Aug 2015 02:16:14 +0000 (11:16 +0900)]
removed warning for Android EDR
- there was a few warning message in EDR
- also removed unused method in BLE
Change-Id: Ie9f181f8771d01696d47f9e876baac4a3a538773
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2111
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
John Light [Thu, 30 Jul 2015 05:10:51 +0000 (22:10 -0700)]
Set socklen explicitly to make IOS happy
Change-Id: I61a30d0c81c0607d127277b53fa0bef7240e0551
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2127
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Sakari Poussa <sakari.poussa@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Wed, 5 Aug 2015 16:36:21 +0000 (09:36 -0700)]
Use CAConvertAddrToName helper method instead of inet_ntoa
Use CAConvertAddrToName to provide protocol-independent translation
for DTLS.
Change-Id: If9e80aba1151ecbdb9af4cfa204ec88dc6f94001
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2121
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
sonu1.yadav [Wed, 5 Aug 2015 10:47:33 +0000 (16:17 +0530)]
Added significance of sequenceNumber in observe callback
Change-Id: I40a9266d0cffcb09925b9dba06c60c39437e7482
Signed-off-by: sonu1.yadav <sonu1.yadav@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2117
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Wed, 5 Aug 2015 08:44:43 +0000 (17:44 +0900)]
fixed build warnings in CA common logic
modified build warnings in CA common files
Change-Id: If7ba87b32a971d6e8e921f92081051d7959d8380
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2114
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Tue, 4 Aug 2015 18:50:07 +0000 (11:50 -0700)]
Cleaning up more warnings.
These fixes clear a bit over 200 more of the basic warnings
seen. A few signed/unsigned issues that might require thought
were left for later.
Change-Id: Ie04411927cef8a73f17f16e329f6546229c2c3d1
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2109
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Mon, 3 Aug 2015 18:40:57 +0000 (11:40 -0700)]
Fixed the checked_guard/nil_guard to pass by reference
This fix should allow checked_guard to properly pass by
reference rather than pulling everything out to a copy. This
should ensure that out parameters are possible in the C++ stack,
though still extremely discouraged.
Change-Id: Ide35e9eb7adbdd532f375f341286387a641e8436
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2087
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
John Light [Wed, 29 Jul 2015 19:55:38 +0000 (12:55 -0700)]
Eliminate warnings from caadapternetdtls.c
Change-Id: I1ec6bda440ecb435586c872f4c63791c1b80d22a
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2108
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Yu-Hsin Hung [Tue, 4 Aug 2015 02:50:59 +0000 (02:50 +0000)]
Fix Android EDR memory leak
Android applications with EDR adpater always get crashed after
running for few minutes. The exception says that the JNI local reference
table is overflow, due to some memory not released by GC.
Change-Id: Ie274d7b28ab9f187728f04aa0dceaa4ebcb61240
Signed-off-by: Yu-Hsin Hung <hungys@hotmail.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Wed, 5 Aug 2015 10:26:02 +0000 (15:56 +0530)]
Add unittest for ConstructResourceTest
Added a test case for ConstructResourceTest to simulate the
scenario of Resource creation with host not having port number.
Change-Id: Ia9ffa317956b8c73dca16a0701c9fd28c8cbaed1
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2115
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Fri, 31 Jul 2015 02:30:06 +0000 (11:30 +0900)]
modified some flag to set Blockwise tranfer
- unnecessary parameter was removed (payload, payloadSize)
- to add some flag related to enable BWT as per platform
Change-Id: I1606732073ba519a7655c430e0ef8bdc31a004d0
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2014
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwanseo [Tue, 4 Aug 2015 05:41:32 +0000 (14:41 +0900)]
modified CA comment for doxygen.
Fixed All files with out of date or
incorrect doxygen comments in CA
Change-Id: I99345cb693bb292e787e717f49cf4cc914caf534
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2057
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
jihwan.seo [Tue, 4 Aug 2015 11:46:23 +0000 (20:46 +0900)]
removed warning from scons build for Android EDR
Change-Id: Ic54b6cbdd7582c6c2ff7ef0074cf56e58d5e400e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2105
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
hyuna0213.jo [Tue, 4 Aug 2015 10:22:04 +0000 (19:22 +0900)]
fixed build warnings in CA linux sample application
fixed build warnings raised by the -Wextra flag.
Change-Id: Id12844fa8fb28a60df58036c5ad1ffc91a3b28c8
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2104
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
jihwan.seo [Tue, 4 Aug 2015 05:39:16 +0000 (14:39 +0900)]
removed warning in Android BLE
- to add NULL checker for parameter.
- to remove unnecessary code.
Change-Id: I197e8339d2757bfa750d171ad74e6064bff2d5e5
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2100
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
John Light [Tue, 28 Jul 2015 19:47:05 +0000 (12:47 -0700)]
Allow endpoint adapter type to filter discovery adapters
Change-Id: I1424b906ac4084180d6982623911accdf993237f
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2009
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Mon, 3 Aug 2015 04:12:10 +0000 (13:12 +0900)]
[JIRA IOT-659] fix the bug related to CACreateEndpoint
CACreateEndpoint is returning CA_STATUS_OK without CAInitialize.
so I add the CA status check logic before calling CACreateEndpoint().
Change-Id: Icd0177efbf60dee2930fce1fddbcb401d4e4a549
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2047
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jay Sharma [Tue, 4 Aug 2015 07:00:25 +0000 (12:30 +0530)]
[Resource Encapsulation] Fixed Sample APP issue
Change-Id: I1a90ec626f29b195ae1f4dde2d46b72fbc991133
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2101
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
hyuna0213.jo [Mon, 3 Aug 2015 06:54:35 +0000 (15:54 +0900)]
resolved the bug related to the address parsing
If user is enter the address for the unicast message,
we are parsing the input value in get_address_set() function.
I modified the get_address_set() function, because there are bugs
in this process. currently linux sample app code is not working.
Change-Id: Id0d0cfbabd2b91c4c18ec0ed28593495a2e2a75e
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2055
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Mon, 3 Aug 2015 03:12:56 +0000 (12:12 +0900)]
Fixed to handle CoAP uri
RESET message/ACK message with EMPTY is not working.
if uri is not included in PDU,
to copy is not need.
Change-Id: Ib4cd70fe19c90dc81d16876915f12bdb41727926
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2046
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Tue, 4 Aug 2015 00:52:51 +0000 (17:52 -0700)]
Fix double free or corruption
Change-Id: I8fc6acf872d758d1a7a9b3157b83555d9d1fbec6
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2092
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Markus Jung [Tue, 4 Aug 2015 01:37:51 +0000 (10:37 +0900)]
Excluded hard-coded and platform specific code and debug statements with cout
Change-Id: I50bd7615b8733208776908c4c1040f558df42a89
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2094
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Minji Park [Tue, 4 Aug 2015 01:18:59 +0000 (10:18 +0900)]
initialize uninitialized variable of soft sensor manager
initialize uninitialized variable of soft sensor manager
to prevent potential problem
Change-Id: Ib929923710162afc96b370f67332b18e19adbd66
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2093
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
coderhyme [Mon, 3 Aug 2015 17:03:36 +0000 (02:03 +0900)]
Fix a bug of discoverResource of RCSDiscoveryManager
Discovery with an empty uri should be allowed.
Change-Id: I38700ce30a24b56310966bc3265bf977f2b546d2
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2084
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tim Kourt [Mon, 3 Aug 2015 21:51:10 +0000 (14:51 -0700)]
Added Android permissions into example apps.
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Change-Id: I0921237844b9b29853fbd46643ffe17b1fe3438b
Reviewed-on: https://gerrit.iotivity.org/gerrit/2089
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Mandeep Shetty [Mon, 3 Aug 2015 17:27:46 +0000 (10:27 -0700)]
Fix segfault on presence payload destroy.
Two pointers pointd to the same memory location and both pointers were
free'd. One was free'd explicitly and the other was free'd as part of
freeing a struct in OCPresencePayloadDestroy.
Change-Id: Ieb3517ffeb4ab0abc4e6e7ff2b6b3b44a82264bf
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2086
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Fri, 31 Jul 2015 05:13:18 +0000 (14:13 +0900)]
updated CA Android Sample APP
- to add payloadSize in CAInfo_t type in CA Sample.
- to update address and port number automatically.
Change-Id: I0080d4572797539d1a74150edc7b3bd5dafba76e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2016
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
John Light [Fri, 24 Jul 2015 19:49:22 +0000 (12:49 -0700)]
Allow unicast discovery of Resources and Devices
Response to JIRA IOT-646
Change-Id: I14dea66de0628897b109c2340bf69caa9e40c5a0
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1898
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rami Jung <rami.jung@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
coderhyme [Mon, 3 Aug 2015 13:23:07 +0000 (22:23 +0900)]
Update comments for doxygen of RCSRequest and RCSResponse
Now these have more appropriate descriptions.
Change-Id: Ibd1554ae8a5477b219a8f4e606c1b9d48c03712e
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2075
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Heewon Park [Mon, 3 Aug 2015 14:00:48 +0000 (23:00 +0900)]
Modify Sconscript for auto Unittest when scons-build.
add unittest execute option(TEST) into the SConscript file(common/serverbuilder/client).
Change-Id: I9196775765590af0074d020e066e9cd66b213815
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2072
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>
Minji Park [Mon, 3 Aug 2015 11:35:54 +0000 (20:35 +0900)]
resource-encapsulation: fix prevent issue for container
- fix prevent issues
- modify unit test SConscript for executing unit test with TEST=1 option
Change-Id: I226bd2cdfb1f040d209bb5e35e08b812be456793
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2070
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: Madan Lanka <lanka.madan@samsung.com>
doil.kwon [Mon, 3 Aug 2015 11:25:52 +0000 (20:25 +0900)]
[Resource Encapsulation]Add UnitTest Execute Option(TEST) into the SConscript.
Change-Id: Iffc6c67391af5b8a0fd9e34334543e4cefafdbcc
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2065
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
doil.kwon [Mon, 3 Aug 2015 06:03:19 +0000 (15:03 +0900)]
[Resource Encapsulation] Resolved build warning.
- Modify unused parameter.
- Removed 'const' return type which is not required
- Removed meaningless prameter naming.
Change-Id: I4ff3d86ca7586f98893a486bd059e631d77d7fc9
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2054
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Heewon Park [Mon, 3 Aug 2015 12:19:02 +0000 (21:19 +0900)]
Refactoring sample applications in resource-encapsulation.
modify SampleResource Client & Server for better structures.
Change-Id: Ic42533ed6ae9555a22e471ff522bf56f765378f6
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2066
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
coderhyme [Mon, 3 Aug 2015 10:41:28 +0000 (19:41 +0900)]
Refactoring for ExpiryTimer
Its unittest is also added.
Change-Id: Iecc9c841221220330372bb11807d239b36225be1
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2064
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
jyong2.kim [Mon, 3 Aug 2015 08:38:22 +0000 (17:38 +0900)]
[Service]Fix build warning of Notification manager.
Remove unused parameters.
Change-Id: Id042dade72177d114c7e74b2dd9710fc182abed3
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2058
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
coderhyme [Mon, 3 Aug 2015 09:40:03 +0000 (18:40 +0900)]
Fix deadlock issue from RCSResourceObject
It was happend when autoNotify is triggered by setAttribute
Change-Id: Ib4901839c524ff54d0ff2366914a5f9201849016
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2061
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Markus Jung [Mon, 3 Aug 2015 09:36:18 +0000 (18:36 +0900)]
Gcc fix for SoftSensorResource, ResourceClientTest
Added algorithm header file and conditionvariable header file
Change-Id: I4db4ad7d9079973925ecbcd558ffe3ded1f581d4
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2060
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Mon, 3 Aug 2015 04:57:55 +0000 (13:57 +0900)]
Update Android PPM sample application for latest base code.
- Modify findResource api(connectivity type)
Change-Id: I78a79144d02e7089220b6927037a0e2b6b8b4bae
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2048
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Mon, 3 Aug 2015 02:30:40 +0000 (11:30 +0900)]
File formatting for PPM source code
Applied source code formatting for PPM code
Change-Id: I4c71da133477820388c2c17bb6c1bc4cf3ca4af0
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2045
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Markus Jung [Mon, 3 Aug 2015 00:51:31 +0000 (09:51 +0900)]
resource-encapsulation: update container bundle resource
- update soft sensor resource to get input data
- modify soft sensor bundle example and configuration file
Change-Id: I9deb7669db33b8464d135a7133184067966fe84b
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2021
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Mon, 3 Aug 2015 02:20:39 +0000 (11:20 +0900)]
Modify resourceCache Unittest code
- modify DataCache handler type which is low pointer to shared_ptr on the dataCache for updated DataCache code
- add unittest execute option(TEST) into the SConscript file
- remove useless comments
- set code format
Change-Id: I69d22561d0d028b624c5f836e9b8bdd1cdaa44e6
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
coderhyme [Sat, 1 Aug 2015 05:10:11 +0000 (14:10 +0900)]
Refactoring for RemoteResourceObject
Refine code of RCSRemoteResourceObject, RCSDiscoveryManager and the unittests for them.
Also add new logger macro for scope logging.
Public exception classes are now located in RCSException header.
Change-Id: I20862491e05c21e2a0a5f608a9c615ebd734ed56
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2038
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Sat, 1 Aug 2015 06:08:27 +0000 (15:08 +0900)]
Modify PPM linux Sample Application&plugins SConscript for convenience of verify
- use copy factory to copy configuration files to proper output direcotry
Change-Id: I6fb408b0f4691ed502de4af63a9d1172c08815b7
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2039
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Rami Jung [Sun, 2 Aug 2015 07:10:58 +0000 (16:10 +0900)]
[Resource-Encapsulation] improving unittest
- adding more functions
- modification for existing functions
Change-Id: I898221305bac3c2e2779ecca9f836a8fac57f627
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2041
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jon A. Cruz [Fri, 31 Jul 2015 06:20:03 +0000 (23:20 -0700)]
Fix issues revealed by -Wextra flag.
Fix assorted warnings raised by the -Wextra flag, including
a few significant items. Reduced local build warnings from
over 9200 warnings to about 650.
At least one unicast send routine would drop all errors due
to type issues.
Change-Id: I9d8c90f83ccc89d9fba809f303ccf42b96c0eb82
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2018
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Fri, 24 Jul 2015 03:50:29 +0000 (12:50 +0900)]
removed fragmentation logic in EDR adapter.
I have removed unnecessary logic called fragmentation
in EDR adapter.
it doesn't need anymore,
because Blockwise-transfer was enabled.
Change-Id: I18a3c73b10cf9ad078558263f6661edad36f9397
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1864
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 22 Jul 2015 12:38:15 +0000 (21:38 +0900)]
updated the code related to descriptor of BLE in android
As there are some issue in BLE core as per platform,
I have modified the code of android to support
BLE for Tizen(2.3/2.4) to Android and
Android to Arduino, Android to Android.
- Tizen 2.4 is not support to get
PROPERTY_NOTIFY through descriptor.
- Arduino have to use Descriptor for PROPERTY_NOTIFY
Change-Id: I4c552b2ee3cb3cf7d5eb17d2e5b2cceda84eb4f2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1813
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 31 Jul 2015 23:14:41 +0000 (16:14 -0700)]
Removed C++11 specific code from the CSDK, added platform_features
The CSDK provides some nice-to-have Constructors when compiling
some POD types. The code erronously used C++11's 'default' keyword,
which isn't available on older compilers. Since C++11/0x is not a
requirement for the CSDK, this disables the constructors in the case
where C++11/0x is not enabled.
In order to do this, it adds a platform_features.h, which should be used
to selectively compile things based on features (rather than based on
the platform name itself)
Change-Id: Ie8b9a5e9b5d6424fd8a1f37cfdbd587f665c2638
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2036
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Erich Keane [Fri, 31 Jul 2015 22:55:45 +0000 (15:55 -0700)]
Fixed a few SonarQube identified issues
JniListenerManager tried to modify its list inside of a for-loop,
which causes undefined behavior. 2 spots where there was un-initialized
variables.
Change-Id: I5da2cd39cef1dadcd05c743d8fc5e0db0a8f2679
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2033
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Jaehong Jo [Fri, 31 Jul 2015 06:10:49 +0000 (15:10 +0900)]
Fixed Android EDR Crash issue.
Prevent global variable memory leak.
Change-Id: I08b75fcfb4a4ed5554e96e9d1a8772f072e7b8b8
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2017
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Ossama Othman [Fri, 31 Jul 2015 21:46:51 +0000 (14:46 -0700)]
Removed vestigial automatic download of BlueZ.
The IoTivity Linux BLE transport no longer relies on headers found in
the BlueZ source distribution, such as <bluetooth/hci.h>, since it no
longer uses the kernel Bluetooth management API for LE advertising
related tasks. LE advertising operations are now handled entirely
through BlueZ D-Bus API method calls.
Change-Id: I64ef5faac2fdac7aa15e2091b9a3bf44b786e1e5
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2031
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Wed, 29 Jul 2015 21:53:00 +0000 (14:53 -0700)]
Fixed a large amount of memory leaks/ Null pointer dereferences
This fix goes through nearly 200 issues discovered by Klocwork
and fixes a variety of null pointer dereferences and memory leaks.
Change-Id: Ic6c741872b5fb5a9e432636552dab815c4f1f96c
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1979
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
jnashok [Fri, 24 Jul 2015 07:41:21 +0000 (16:41 +0900)]
[Jira IOT-604] Fix error handling from message handler
This is a specific case where error hadling is not handled
Fixed the error in the send thread
Change-Id: I3f4d1983d379550ee6e72d95b9341da847fce47a
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
YounghyunJoo [Fri, 31 Jul 2015 11:12:46 +0000 (20:12 +0900)]
Modify PPM Sample Application & Plugins for updated base code
- Change CA connectivity type(CA_DEAFULT)
- Fix some errors on plugins
Change-Id: Idcb2d2dfb77f1c9e98686161e6989d6b96367ac4
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2022
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Fri, 31 Jul 2015 12:05:15 +0000 (21:05 +0900)]
[Resource encapsulation]Add check logic about whether cached resource exists or not.
Throw exception when getCachedData() is requested for non-cached resource.
Add interface for checking cached resource existence.
Mutex for attributes is moved into the class member variable.
Change-Id: I25a163bf6900dd23f14158f28808873059798845
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2024
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Fri, 31 Jul 2015 04:26:24 +0000 (13:26 +0900)]
[Resource Encapsulation]Clean up code on ResourceCache.
fix typing error.
Change-Id: I081f149e6fa38890afc8982655f0bdfcf1caac58
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2015
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>
YounghyunJoo [Fri, 31 Jul 2015 10:14:38 +0000 (19:14 +0900)]
Modify resourceCache codes to synchronize the cacheDataList and to avoid retransmission
- add std::mutex for synchronization of cacheDataList valuable
- add lastSequenceNum valuable to avoid retransmission
Change-Id: I19cc85084d916b91f359ca116e1b3ef69db2150b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2019
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>
Rami Jung [Thu, 30 Jul 2015 04:09:51 +0000 (13:09 +0900)]
[Resource-Encapsulation] compaction by reusing the definition of 'constexpr char KEY[]'
Change-Id: Ibfd7ad1cbf82652c6e30c584be5e0a920b44a228
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1985
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Ossama Othman [Mon, 27 Apr 2015 21:36:19 +0000 (14:36 -0700)]
Implemented Linux BLE transport.
This is an implementation of the proposed OIC Bluetooth Low Energy
transport for Linux.
Change-Id: Id105a1d7a86c59d41900c6e4b0fc1b0a60b97c75
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1125
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
doil.kwon [Thu, 30 Jul 2015 10:43:19 +0000 (19:43 +0900)]
Update 'resource broker' unit test code.
1. whether is called timeoutCB correctly or not when is occurred timeover about 'subscribe' request.
2. whether is called subscribeCB correctly or not when is request 'subscribe'.
3. whether is called timeoutCB correctly or not when is occurred timeover about 'get' request.
and, modify some bug.
this bug is not occurred problem at previous version.but correct this point in order to upgrade our unitTest'
performance.
add license comment and delete white space.
add api for 'device presence' in order to get device_state' value.
Change-Id: Ib265c6d529f84610cf134808bc5581377340bec6
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1987
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Mandeep Shetty [Thu, 30 Jul 2015 22:53:47 +0000 (15:53 -0700)]
Fixed arduino server sending notifications after deregister.
This fixes IOT-627.
Arduino server continuted to send observe notifications even after
client deregisters. This happened because a bool variable tracking if
light was under observation was not set to false.
Change-Id: Ic1f00915632251a9be8772ca3cc4b71373dc3b18
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2011
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 30 Jul 2015 18:47:40 +0000 (11:47 -0700)]
Fixed unprocessed timed-out messages in the stack.
The portion of messages in the retransmission queue did not have the
resourceUri. As a result timed-out messages when reported back to the RI
layer did not have the resource uri which failed a check on entry into
the RI layer.
This caused the server to not de-register observers and it continued to
send observation notifications to a client that is not reachable.
Removed the check for the resource uri to fix the issue.
Added check for presence of uri before comparing it with the presence
uri so presence responses can be handled separately.
This also fixes IOT-622.
Change-Id: Ie3873d02f4163b81094ca1983e79315b85ff4751
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1995
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 30 Jul 2015 18:57:01 +0000 (11:57 -0700)]
Added null checks post cbor processing.
This allows requests with null parameters to still operate.
This fixes IOT-632.
Change-Id: I6b7b1a48e1d50d34268e1f0fface38b5fd59cb02
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1993
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwanseo [Wed, 29 Jul 2015 04:33:22 +0000 (13:33 +0900)]
updated the logic to combining block1 and block2 option
- fixed IOT-637 issue
Both the request and response may be large enough to
require the use of blockwise-transfer.
In this case, we should use the block1 and block2 option together.
- fixed IOT-635 issue
if a lot of ports is enable in IP adapter.
Token of CoAP can be used as blockID of BlockData set
since all messages have same Token in multicast
so Token + port have to be used.
- fixed klocworks data leak issue
in CAAddBlockSizeOption, option is created, but the actual option
doesn't have anything done with it.
Change-Id: I82808856c76cfd343c71460e303744b002d9a745
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tim Kourt [Thu, 30 Jul 2015 16:22:31 +0000 (09:22 -0700)]
Fixed a merge of OcConnectivityType and OcConnectivityFlags
throughout the android stack
A small Android API change was introduced as part of the merge: all discovery
calls now take a Set of OcConnectivtyTypes instead of a single enum.
In addition, it fixes a setHeaderOptions bug.
Change-Id: Ib269e39a0168055b4a1f46353cbd620fbff1dbad
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1992
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Wed, 29 Jul 2015 20:21:26 +0000 (13:21 -0700)]
Adding -Wextra to builds using -Wall in order to catch problems that
were being missed.
Change-Id: I4bf0ae091aa2c3da255a9c07b2290f32abf2d0f0
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1978
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Wed, 29 Jul 2015 11:15:03 +0000 (16:45 +0530)]
[ARDUINO] Fixed send data failure in IP adapter
Change-Id: I8f3cbd6414fca8f92e22f5d3d7ce8c3eebcb4b71
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Thu, 30 Jul 2015 00:48:37 +0000 (17:48 -0700)]
Corrected a criticial OICRealloc() bug and a few misc issues.
- Fixed a problem wither OICRealloc() where it was returning the
old pointer instead of the sometimes-different new one.
- Removed some code duplication in #if/#else blocks.
- Fixed split declarations and later assignment. This step was the
one that made the OICRealloc() bug immediately visible.
- Updated OICFree() counting to match that in OICMalloc(), except
for the case of failed mallocs.
Change-Id: Ibdf8949d57e72821f0fea9e5c8ca607503ff14dc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1982
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
John Light [Tue, 28 Jul 2015 06:54:43 +0000 (23:54 -0700)]
Fix broken macros in octypes.h
Eliminate 16-bit definition of OCConnectivityType.
Repair macros used to build OCConnectivityType.
Change-Id: Ia1ff69f6bdab5d8d728cb33ea633a4ba9c3912d7
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1977
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Thu, 30 Jul 2015 14:21:24 +0000 (07:21 -0700)]
Copy all items of CBOR string array
CBOR String array is coping only the first item.
Fix OCREP_PROP_STRING for string array to copy all items by
calling cbor_value_advance.
Change-Id: I1ea80e94cf21f746188af81dd946c474d8b00ba4
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1990
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
doil.kwon [Thu, 30 Jul 2015 05:36:17 +0000 (14:36 +0900)]
Update Log message for "resource Broker".
it will be shown when is called its related function.
and can be shown more detail(ex: the moment when is found item).
modify log message existing previously.
all log message will be shown before its related action' excution.
also delete white space.
Change-Id: Ibaf2c611ce17bb4635ebd6c68f530d5cc8a40b37
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1983
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
jnashok [Wed, 29 Jul 2015 10:56:11 +0000 (19:56 +0900)]
updating build instructions for casample
this helps in fixing some build problems
Change-Id: I4f424cfa8c4af6304d7da55c7b2947f3dfdbfebc
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1973
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Wed, 29 Jul 2015 22:22:51 +0000 (15:22 -0700)]
Clean up some SonarQube warnings (trailing whitespace, etc).
Clean up trailing whitespace and removed Windows line endings from
most text files to address SonarQube warnings. As a side effect of
this clean-up, several files that should not have been executable had
their executable permission bit removed.
Change-Id: Ie388df6e383219cdebfb56ba8fa86cacf2ca3e46
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1980
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jyong2.kim [Wed, 29 Jul 2015 10:52:48 +0000 (19:52 +0900)]
Fix invalid memory access on resource cache module.
invalidate callback in deleted instance.
Change-Id: Ica3028700935c0cef062719a43affc5f4754a336
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1972
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
koushik.girijala [Fri, 17 Jul 2015 11:52:43 +0000 (17:22 +0530)]
RI Sample for Tizen
working RI Sample for Tizen
Change-Id: Idba74286734d2159b128ddde55cc588bbb19cbea
Signed-off-by: vimala.v <vimala.v@samsung.com>
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1719
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
YounghyunJoo [Wed, 29 Jul 2015 10:01:56 +0000 (19:01 +0900)]
Modify resourceCache unittest buildscript to fix gcc bug
- on gcc-4.6 in linux 64bit environment, gcc bug is occurred.
To fix it, remove the '-Wnoexcept' option in the SConscript file
- additionally, remove constructor, destructor on the unittest class
to prevent build error(noexcept tag) on gcc-4.8
Change-Id: I411ca979e607cdfe33ea50f9fe32b88b434320ed
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1970
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Wed, 29 Jul 2015 01:18:39 +0000 (10:18 +0900)]
Modify DataCache code files to support thread synchronization
- add thread synchronization for the subscriberList
- modify notifyObservers()'s parameter to const variable
Change-Id: I13e18a56be2ec2f6e7e4c0eadc371161dc6b5f3b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
projects / contrib / iotivity.git / log