platform/core/csapi/xsf.git
5 years agoImplement CollectionView grouping on iOS (#6590)
E.Z. Hart [Tue, 2 Jul 2019 21:34:45 +0000 (15:34 -0600)]
Implement CollectionView grouping on iOS (#6590)

* Implement CollectionView grouping for iOS

* Add grouping UI tests

* Fix invalidcast when source is not INotifyCollectionChanged

* Remove old TODO comments

* Apply suggestions from code review

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* IsGroupingEnabled -> IsGrouped

* Update empty source workaround

* Fix incorrect group counting for empty collections

* Iron out all section counts; remove unsavory empty view workaround;

* Fix crash when filter is null

* Handle sections for add/remove to/from empty sources; check for empty sources when handling sections;

* Prevent random test failures for test 5793

* Remove now-unnecessary size check on transition from empty to non-empty source

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/CollectionViewGrouping.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
5 years agoMerge branch '4.1.0'
ShaneN [Sun, 30 Jun 2019 16:02:55 +0000 (10:02 -0600)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
ShaneN [Sun, 30 Jun 2019 16:02:26 +0000 (10:02 -0600)]
Merge branch '4.0.0' into 4.1.0

5 years agorequest layout of measure changes force layout if it doesn't (#6704)
Shane Neuville [Sun, 30 Jun 2019 16:00:34 +0000 (10:00 -0600)]
request layout of measure changes force layout if it doesn't (#6704)

5 years agofix NRE in InvokeOnMainThreadAsync (#6708)
campersau [Sun, 30 Jun 2019 08:25:53 +0000 (10:25 +0200)]
fix NRE in InvokeOnMainThreadAsync (#6708)

5 years agoMerge branch '4.1.0'
Rui Marinho [Sat, 29 Jun 2019 14:19:17 +0000 (15:19 +0100)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Sat, 29 Jun 2019 14:18:41 +0000 (15:18 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoSplit up Issue4597 into separate testable chunks (#6654)
Shane Neuville [Sat, 29 Jun 2019 13:53:38 +0000 (07:53 -0600)]
Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

5 years agoUpdate README.md
Samantha Houts [Fri, 28 Jun 2019 18:21:03 +0000 (11:21 -0700)]
Update README.md

5 years agoUpdate README.md
Samantha Houts [Fri, 28 Jun 2019 18:11:56 +0000 (11:11 -0700)]
Update README.md

5 years ago[Android] Fix various issues in object dispose methods. (#6467)
Kevin Petit [Fri, 28 Jun 2019 10:53:49 +0000 (12:53 +0200)]
[Android] Fix various issues in object dispose methods. (#6467)

* Android - Fix various issues in object dispose methods.

* Tear down old element before disposing the ItemViewAdapter.

* More fixes.

* NavigationPageRenderer - Reorder ResetToolbar and remove view before dispose
ShellSectionRenderer - Call base.Destroy last + Remove and destroy _scrollview

* Remove obsolete code.

* Fix build.

5 years ago[Shell] MenuItem font image fix (#6628) fixes #6559
Felipe Momm [Fri, 28 Jun 2019 10:52:59 +0000 (07:52 -0300)]
[Shell] MenuItem font image fix (#6628) fixes #6559

* [Shell] FontImageSource not working with MenuItem

* [Shell] Adds missing Binding (FlyoutIcon) for ShellItem

* Revert changes and adjust to change the binding instead

* Replace magic strings for nameof

5 years agoreturn empty dictionary instead of null (#6675) fixes #6614
Shane Neuville [Fri, 28 Jun 2019 10:17:11 +0000 (04:17 -0600)]
return empty dictionary instead of null (#6675) fixes #6614

* return empty dictionary instead of null

* add warning if Element is being reparented

* fix warning message

* only fire warning if parent has inner children

5 years agoAdds FontImage Markup Extension for FontImageSource (#6398)
Andrew Hoefling [Fri, 28 Jun 2019 00:23:32 +0000 (20:23 -0400)]
Adds FontImage Markup Extension for FontImageSource (#6398)

* Added FontImage markup extension which simplifies usage of FontImageSource into any ImageSource

* Added unit tests to cover TabBar which is used in Shell

* Cleaned up xaml for test code

* Removed class references from unit test project which were added by mistake

* Removed FontImageExtension from markup parser

* Added ContentProperty to markup extension

* Added Size to FontImageExtension

* Updated unit tests for new properties

* added unit tests to certify each property was set correctly by the markup extension

* Added content property test to certify that Glyph is being set correctly

* Flipped order in unit tests of expected and actual

* Updated default value for Size to use the FontImageSource default's value. This will keep it in sync if that value ever changes

fixes #6376

5 years agoValidate style target at runtime (#6677)
Andrei Nitescu [Fri, 28 Jun 2019 00:19:47 +0000 (03:19 +0300)]
Validate style target at runtime (#6677)

* Check Style target type at runtime #6268

* Use IsAssignableFrom internal version
fixes #6268
fixes #6535

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 27 Jun 2019 23:50:21 +0000 (16:50 -0700)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Thu, 27 Jun 2019 23:49:07 +0000 (16:49 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agomake ShouldChangeText virtual (#6634)
adrianknight89 [Thu, 27 Jun 2019 23:37:25 +0000 (18:37 -0500)]
make ShouldChangeText virtual (#6634)

5 years ago[iOS] Provide a base CarouselViewRenderer (#6686)
Rui Marinho [Thu, 27 Jun 2019 23:34:52 +0000 (00:34 +0100)]
[iOS] Provide a base CarouselViewRenderer (#6686)

* [iOS] Don't provide a CarouselViewRenderer

* [iOS] Fix CarouselViewRenderer

* Update CarouselViewRenderer.cs

5 years agoUpdate nightly feed (#6411)
Rui Marinho [Thu, 27 Jun 2019 21:03:19 +0000 (22:03 +0100)]
Update nightly feed (#6411)

* Update README.md

* [Docs]Update to aka.ms link

* Update README.md

5 years ago[Bugfix] Catching ReflectionTypeLoadException in the VisualTypeConverter (#6646)
Sergej Derjabkin [Thu, 27 Jun 2019 18:46:33 +0000 (21:46 +0300)]
[Bugfix] Catching ReflectionTypeLoadException in the VisualTypeConverter (#6646)

* - Bugfix: Catching ReflectionTypeLoadException in the VisualTypeConverter

* - Fixed formatting

* - Removed empty line

5 years agoButton Layout gallery page: don't set initial Padding (#6599) fixes #6469
Andrei Nitescu [Thu, 27 Jun 2019 10:42:42 +0000 (13:42 +0300)]
Button Layout gallery page: don't set initial Padding (#6599) fixes #6469

5 years agotry to generate more unique names (#6669)
Stephane Delcroix [Thu, 27 Jun 2019 09:30:11 +0000 (11:30 +0200)]
try to generate more unique names (#6669)

- fixes #6668

5 years ago[Tizen] Added support AutomationProperties (#6080)
Kangho Hur [Wed, 26 Jun 2019 16:10:09 +0000 (01:10 +0900)]
[Tizen] Added support AutomationProperties (#6080)

5 years agoFix flaky tests. (#6510)
Kevin Petit [Wed, 26 Jun 2019 15:57:36 +0000 (17:57 +0200)]
Fix flaky tests. (#6510)

Found issues on some tests when running on my local machine.
The test Bugzilla 31333 dont wait the input to take focus (so on a fast machine it fail).
The test Issue1733 use the current culture to parse number which can fail (and indeed fail on my machine).

5 years agowait for animation to complete (#6652)
Shane Neuville [Wed, 26 Jun 2019 15:57:26 +0000 (09:57 -0600)]
wait for animation to complete (#6652)

5 years ago[Tizen] Add Checkbox (#6526) fixes #1728
Kangho Hur [Wed, 26 Jun 2019 15:52:22 +0000 (00:52 +0900)]
[Tizen] Add Checkbox (#6526) fixes #1728

5 years ago[UWP] CollectionView SelectionMode (#6629) fixes #3172 fixes #6489 fixes #5844 fixes...
humhei [Wed, 26 Jun 2019 15:37:08 +0000 (23:37 +0800)]
[UWP] CollectionView SelectionMode (#6629) fixes #3172 fixes #6489 fixes #5844 fixes #5625

* UWP CollectionView SelectionMode

* Null check

* SelectItems get property

* ItemTemplatePair type check

* Avoid mutually trigger OnSelectionChange

* Extended -> Multiple + Avoid creating new SelectedItems

5 years ago[X] resolve event handlers in base generic types (#6194)
Stephane Delcroix [Wed, 26 Jun 2019 12:35:54 +0000 (14:35 +0200)]
[X] resolve event handlers in base generic types (#6194)

* [XamlC] fix Debug harness generation code

* [X] resolve event handlers in base generic types

- fixes #6176

5 years agoIssue1733 change Query to WaitForElement (#6588)
Shane Neuville [Wed, 26 Jun 2019 04:52:09 +0000 (22:52 -0600)]
Issue1733 change Query to WaitForElement (#6588)

- rename test

5 years ago[Shell] Fail when trying to add a duplicated route (#6613)
Felipe Momm [Tue, 25 Jun 2019 23:05:03 +0000 (20:05 -0300)]
[Shell] Fail when trying to add a duplicated route (#6613)

5 years agoBackport41 (#6651)
Stephane Delcroix [Tue, 25 Jun 2019 22:20:55 +0000 (00:20 +0200)]
Backport41 (#6651)

* use a BP for QueryAttributes (#6569)

* use a BP for QueryAttributes

* Update Xamarin.Forms.Core/Shell/ShellContent.cs

* Allow tracking of StyleSheets (#6502)

* remove excess code and clean up sandbox (#6503)

* Allow tracking of StyleSheets

*  ¯\_(ツ)_/¯

5 years agoDon't reset implicit style (#6641) (#6641)
Andrei Nitescu [Tue, 25 Jun 2019 18:45:50 +0000 (21:45 +0300)]
Don't reset implicit style (#6641) (#6641)

fixes #6635

5 years agoMerge branch '4.1.0'
Samantha Houts [Mon, 24 Jun 2019 23:38:27 +0000 (16:38 -0700)]
Merge branch '4.1.0'

5 years agoFix compiler warnings in WPF platform project (#6616)
Eilon Lipton [Mon, 24 Jun 2019 22:10:17 +0000 (15:10 -0700)]
Fix compiler warnings in WPF platform project (#6616)

5 years agoUndo broken change in un-watching empty view observer;
E.Z. Hart [Mon, 24 Jun 2019 19:47:46 +0000 (13:47 -0600)]
Undo broken change in un-watching empty view observer;
This may cause a small leak in some corner cases, but that leak is fixed by

5 years agoClean up Platform on PlatformRenderer disposal: fixes #4671 (#6636)
E.Z. Hart [Mon, 24 Jun 2019 19:01:57 +0000 (13:01 -0600)]
Clean up Platform on PlatformRenderer disposal: fixes #4671 (#6636)

5 years agoMerge branch '4.1.0'
Samantha Houts [Fri, 21 Jun 2019 00:39:25 +0000 (17:39 -0700)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Fri, 21 Jun 2019 00:10:59 +0000 (17:10 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agoUpdate ItemsViewLayout.cs (#6583)
E.Z. Hart [Thu, 20 Jun 2019 17:48:36 +0000 (11:48 -0600)]
Update ItemsViewLayout.cs (#6583)

Unsubscribe from PropertyChanged during Dispose() on ItemsViewLayout (iOS).

5 years agoUpdate ItemsViewLayout.cs (#6583)
Elias Puurunen [Thu, 20 Jun 2019 17:46:19 +0000 (13:46 -0400)]
Update ItemsViewLayout.cs (#6583)

Unsubscribe from PropertyChanged during Dispose() on ItemsViewLayout (iOS).

5 years ago[XamlC] Do not try to set a value to bound source property if unavailable (#6564)
Akihiko Odaki [Thu, 20 Jun 2019 09:37:42 +0000 (18:37 +0900)]
[XamlC] Do not try to set a value to bound source property if unavailable (#6564)

5 years ago[Android] Change elevation to use float.minvalue instead of negative infinity (#6560)
Shane Neuville [Thu, 20 Jun 2019 02:54:07 +0000 (20:54 -0600)]
[Android] Change elevation to use float.minvalue instead of negative infinity (#6560)

* change negative infinity to float.minvalue

* api 19 fixes

5 years agoImplement ItemSizingStrategy.MeasureFirstItem on Android (#6422)
E.Z. Hart [Thu, 20 Jun 2019 02:28:43 +0000 (20:28 -0600)]
Implement ItemSizingStrategy.MeasureFirstItem on Android (#6422)

* Implement ItemSizingStrategy.MeasureFirstItem on Android

* Remove unnecessary method

5 years ago[UWP] fixes hangs ListView when using Narrator (#6431)
Pavel Yakovlev [Thu, 20 Jun 2019 02:27:53 +0000 (19:27 -0700)]
[UWP] fixes hangs ListView when using Narrator (#6431)

fixes #5340

5 years ago[Android] Dispose the collection view item adapter (#6525)
Kevin Petit [Thu, 20 Jun 2019 02:27:25 +0000 (04:27 +0200)]
[Android] Dispose the collection view item adapter (#6525)

* [Android] Dispose the collection view adapter.

* More complete fix.

5 years ago[Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)
Gerald Versluis [Thu, 20 Jun 2019 02:27:04 +0000 (04:27 +0200)]
[Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)

* Update NavigationPageRenderer.cs

* Add reproduction for #2577

* Update NavigationPageRenderer.cs

* Taking into account MasterDetailPage and GetHasBackButton correctly

* Update NavigationPageRenderer.cs
fixes #2577

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 20 Jun 2019 02:25:10 +0000 (19:25 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agodon't setup webview if running as designer (#6592)
Shane Neuville [Wed, 19 Jun 2019 23:52:31 +0000 (17:52 -0600)]
don't setup webview if running as designer (#6592)

5 years agoAdded missing named sizes (#6591)
Gerald Versluis [Wed, 19 Jun 2019 23:40:59 +0000 (01:40 +0200)]
Added missing named sizes (#6591)

fixes #6517

5 years agoMake ShellTabLayoutAppearanceTracker public (#6530)
Gerald Versluis [Wed, 19 Jun 2019 23:30:33 +0000 (01:30 +0200)]
Make ShellTabLayoutAppearanceTracker public (#6530)

fixes #6529

5 years ago[Android] Fixes loading image from uri (#6394)
Pavel Yakovlev [Wed, 19 Jun 2019 23:26:41 +0000 (16:26 -0700)]
[Android] Fixes loading image from uri (#6394)

* [Android] Fixes loading image form uri

* - modified Issue4597 test

* nested function is removed

* moved redundant code

* Update Xamarin.Forms.Platform.Android/Extensions/ImageViewExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6313

5 years ago[Android] Fixes layout in AppCompat ButtonRenderer (#6329)
Pavel Yakovlev [Wed, 19 Jun 2019 23:24:51 +0000 (16:24 -0700)]
[Android] Fixes layout in AppCompat ButtonRenderer (#6329)

* [Android] Fixes layout in AppCompact ButtonRenderer

* - fixes button alignment when fast changing padding
- fixes material button alignment

* refactoring

* forceLayout

* generalize force layout

* if APP check on ui test
fixes #6282

5 years ago[Android] fix accessibility of Picker (#5125)
Pavel Yakovlev [Wed, 19 Jun 2019 23:23:00 +0000 (16:23 -0700)]
[Android] fix accessibility of Picker (#5125)

* [Android] fix accessibility of Picker

* fix NRE

* fixes read selected item with accessibility

* refactoring test

* added dispose of accessibility delegate

* fix build uitest

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
5 years ago[Android] Add disposed check to MasterDetailPageRenderer (#6354)
Samantha Houts [Wed, 19 Jun 2019 22:55:59 +0000 (15:55 -0700)]
[Android] Add disposed check to MasterDetailPageRenderer (#6354)

* [Android] Add disposed check to MasterDetailPageRenderer

Co-Authored-By: Felipe Silveira <transis2@users.noreply.github.com>
* Fix dispose pattern

a la #6305

* apply same set of changes to NavigationPageRenderer

fixes #3489
closes #4586

5 years ago[Android] hide keyboard after tapping on pickers (#6284)
Pavel Yakovlev [Wed, 19 Jun 2019 22:54:00 +0000 (15:54 -0700)]
[Android] hide keyboard after tapping on pickers (#6284)

fixes #6235

5 years agoMerge branch '4.1.0'
Rui Marinho [Wed, 19 Jun 2019 22:49:46 +0000 (23:49 +0100)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Wed, 19 Jun 2019 22:49:12 +0000 (23:49 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 19 Jun 2019 22:48:36 +0000 (23:48 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoEntryRenderer.cs [macOS] updated (#6566)
nor0x [Wed, 19 Jun 2019 21:15:58 +0000 (23:15 +0200)]
EntryRenderer.cs [macOS] updated (#6566)

checks if NSWindow is disposed before invoking FocusChanged events to fix #4268
fixes #4268

5 years agoDynamic view gallery support all Enum properties (#6434)
Pavel Yakovlev [Wed, 19 Jun 2019 18:45:54 +0000 (11:45 -0700)]
Dynamic view gallery support all Enum properties (#6434)

5 years ago[UITests] Wait a little bit longer for go to test button to appear (#6570)
Shane Neuville [Wed, 19 Jun 2019 17:21:08 +0000 (11:21 -0600)]
[UITests] Wait a little bit longer for go to test button to appear (#6570)

5 years ago[Android] Fixed applying effects to Frames (#6412)
Andrei [Wed, 19 Jun 2019 16:59:32 +0000 (19:59 +0300)]
[Android] Fixed applying effects to Frames (#6412)

* [Android] Fixed effects applying to Frame

fixes https://github.com/xamarin/Xamarin.Forms/issues/3548

* Added ui test case

* added UITest

* fixed test case's affected platform

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
5 years agoSet ExceptionHandler on HydrationContext in ApplyPropertiesVisitor.SetTemplate()...
Tim Barham [Wed, 19 Jun 2019 08:31:30 +0000 (18:31 +1000)]
Set ExceptionHandler on HydrationContext in ApplyPropertiesVisitor.SetTemplate() (#6573)

5 years agouse a BP for QueryAttributes (#6569)
Stephane Delcroix [Wed, 19 Jun 2019 08:12:22 +0000 (10:12 +0200)]
use a BP for QueryAttributes (#6569)

* use a BP for QueryAttributes

* Update Xamarin.Forms.Core/Shell/ShellContent.cs

5 years agomerge 4.1.0 into master
ShaneN [Tue, 18 Jun 2019 16:49:34 +0000 (10:49 -0600)]
merge 4.1.0 into master

5 years agoMerge 4.0.0 into 4.1.0
ShaneN [Tue, 18 Jun 2019 16:42:55 +0000 (10:42 -0600)]
Merge 4.0.0 into 4.1.0

5 years ago[Build] Don't push NuGet packages from build
Rui Marinho [Tue, 18 Jun 2019 12:01:26 +0000 (13:01 +0100)]
[Build] Don't push NuGet packages from build

5 years agowait for test to finish so it doesn't break later tests (#6562)
Shane Neuville [Tue, 18 Jun 2019 10:21:30 +0000 (04:21 -0600)]
wait for test to finish so it doesn't break later tests (#6562)

5 years ago[Android] Fix context actions icon so that it loads (#6437) fixes #6258
Shane Neuville [Tue, 18 Jun 2019 10:20:37 +0000 (04:20 -0600)]
[Android] Fix context actions icon so that it loads (#6437) fixes #6258

* fix icon load loading and setting accessibility on menuitem

* instructions

* clean up

* Update Xamarin.Forms.Platform.Android/Extensions/AccessibilityExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.Android/ResourceManager.cs

* Update Xamarin.Forms.Platform.Android/CellAdapter.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Fix load TitleIcon on non app compact

* apply valid check one more place

* automate titleicon fixes

* fix ui tests and removed _isdisposed

* toolbaritem ui test tweaks

* toolbar tweaks

* ios toolbaritem tweak

* update menuitem to read like other platforms

* retain automationid if content desc not set

5 years agoAdd Intellisense for vertical/horizontal list options in CollectionView (#6537)
E.Z. Hart [Tue, 18 Jun 2019 09:20:02 +0000 (03:20 -0600)]
Add Intellisense for vertical/horizontal list options in CollectionView (#6537)

5 years ago[GTK] Fix NullReferenceException in NavigationPageRenderer (#6462)
mfkl [Tue, 18 Jun 2019 03:05:08 +0000 (05:05 +0200)]
[GTK] Fix NullReferenceException in NavigationPageRenderer (#6462)

BackgroundImageSource is null by default

5 years agoFix occasional disappearing content in CV items on UWP (#6465)
E.Z. Hart [Mon, 17 Jun 2019 22:46:18 +0000 (16:46 -0600)]
Fix occasional disappearing content in CV items on UWP (#6465)

fixes #4658

5 years ago[iOS] Fix missing partial columns in horizontal grid layout (#6241)
E.Z. Hart [Mon, 17 Jun 2019 21:07:32 +0000 (15:07 -0600)]
[iOS] Fix missing partial columns in horizontal grid layout (#6241)

* Create repro

* Work around UICollectionViewFlowLayout bug to display partial columns; fixes #6077
Fix content inset behaviors when dealing with safe area on newer iOS versions

* Add check for case where there is only a single partial column

* Works better if I don't forget the return statement

* Split up tests to make it easier to determine what failed

* Fix bounds exception when changing to a smaller ItemsSource

* Add preserve attributes so the linker won't ruin my UI test

* Fix missing using after rebase

5 years agoFix for layouts in a cell to expand on resize (WPF) Issue #5682 (#6179)
jaytilly [Mon, 17 Jun 2019 11:47:26 +0000 (04:47 -0700)]
Fix for layouts in a cell to expand on resize (WPF) Issue #5682 (#6179)

* Added fix for grids in a cell to expand on resize

* Added check for expand before expanding grid

* Removed unused using

* Made the resize fix more generic

* Removed generic constraint on type check for layout controls on resize for children of cell control

5 years ago[Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150...
Pavel Yakovlev [Mon, 17 Jun 2019 11:43:11 +0000 (04:43 -0700)]
[Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150 fixes #6447

* [Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame
- fixes float values in Dynamic ViewGallery

* added on-screen instructions for test

* added API check

* added SetClipToOutline to ViewExtensions

* added button to toggle IsClippedToBounds

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Mon, 17 Jun 2019 11:15:59 +0000 (12:15 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoAdded Parameter attribute to constructor parameters (#6516)
Gerald Versluis [Mon, 17 Jun 2019 08:41:24 +0000 (10:41 +0200)]
Added Parameter attribute to constructor parameters (#6516)

5 years ago[ios] change checkbox to use default constructor (#6512)
Shane Neuville [Fri, 14 Jun 2019 19:07:17 +0000 (13:07 -0600)]
[ios] change checkbox to use default constructor (#6512)

5 years agoAllow tracking of StyleSheets (#6502)
Stephane Delcroix [Fri, 14 Jun 2019 16:51:43 +0000 (18:51 +0200)]
Allow tracking of StyleSheets (#6502)

* remove excess code and clean up sandbox (#6503)

* Allow tracking of StyleSheets

*  ¯\_(ツ)_/¯

5 years agoadd checkbox style to nuspec (#6504)
Shane Neuville [Thu, 13 Jun 2019 20:29:39 +0000 (14:29 -0600)]
add checkbox style to nuspec (#6504)

fixes #6501

5 years ago[Shell] Allow to set background image for flyout item. (#6116)
Pavel Yakovlev [Thu, 13 Jun 2019 20:12:52 +0000 (13:12 -0700)]
[Shell] Allow to set background image for flyout item. (#6116)

* [Android, iOS] Allow to set background image for flyout item.

* refactoring

fixes #4410

5 years ago[iOS] adds a flag to ios if user needs to disable accessibility sizing for named...
Shane Neuville [Thu, 13 Jun 2019 19:59:01 +0000 (13:59 -0600)]
[iOS] adds a flag to ios if user needs to disable accessibility sizing for named font sizes (#6345)

* adds a flag to ios if user needs to disable accessibility sizing for named font sizes

* move setting to platform specific

* move to mobile if defs

* move comment back

* move comment back

* invert and delete

5 years ago[Android] Retrieve PackageName from the correct Platform instance (#6420)
Shane Neuville [Thu, 13 Jun 2019 19:57:30 +0000 (13:57 -0600)]
[Android] Retrieve PackageName from the correct Platform instance (#6420)

* Fix getting packagename and pass context into RM
- fixes #6327

* spacing

5 years agoResolve fallback type before trying to make constructed generic type (#6511)
Tim Barham [Thu, 13 Jun 2019 18:21:55 +0000 (04:21 +1000)]
Resolve fallback type before trying to make constructed generic type (#6511)

* Resolve fallback type before trying to make constructed generic type

The FallbackTypeResolver hander in the Forms previewer does not have access to the x:TypeArguments attribute, so if it constructs a proxy generic type from metadata it can't construct it. So the previewer has to create an unconstructed generic type, and Forms will need to construct it.

So we need to move the code that constructs the generic type after the call to FallbackTypeResolver.

(cherry picked from commit 5acfea4f457453856a8905002f4d35c8e9aad106)

* Fix error building DesignTimeLoaderTests in 4.1

5 years ago[Android, iOS] Item Spacing for CollectionView (#6478) fixes #4681
E.Z. Hart [Thu, 13 Jun 2019 18:17:10 +0000 (12:17 -0600)]
[Android, iOS] Item Spacing for CollectionView (#6478) fixes #4681

* First pass at item spacing for CollectionView ListItemsLayout on Android

* Handle GridItemsLayout spacing on Android

* Change spacings from int -> double
Implement spacing on iOS

* Remove old TODO comment

5 years ago[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes ...
Rui Marinho [Thu, 13 Jun 2019 13:21:09 +0000 (14:21 +0100)]
[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes #6368 fixes #6328

* [Controls] Add repo for issue #6368 and #6328

* [iOS] Protect against no Element from CustomRenderers bad usage

* [Controls] Drop private on sample code

5 years agoremove excess code and clean up sandbox (#6503)
Shane Neuville [Wed, 12 Jun 2019 23:42:25 +0000 (17:42 -0600)]
remove excess code and clean up sandbox (#6503)

5 years ago[UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)
Pavel Yakovlev [Wed, 12 Jun 2019 23:41:46 +0000 (16:41 -0700)]
[UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)

* [UWP] Fixes IndexOutOfRangeException on TabbedPage

* add tab page category

* fix update colors

* optimization

5 years agoUpdate ScrollViewRenderer.cs (#6151)
Sivakumar [Tue, 11 Jun 2019 19:25:04 +0000 (00:55 +0530)]
Update ScrollViewRenderer.cs (#6151)

5 years agoMerge branch '4.1.0'
Rui Marinho [Tue, 11 Jun 2019 09:10:54 +0000 (10:10 +0100)]
Merge branch '4.1.0'

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Tue, 11 Jun 2019 09:09:30 +0000 (10:09 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 11 Jun 2019 09:08:29 +0000 (10:08 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[XamlC] Correctly load addresses of values in more compiled binding paths (#6423)
Akihiko Odaki [Sat, 8 Jun 2019 08:55:53 +0000 (17:55 +0900)]
[XamlC] Correctly load addresses of values in more compiled binding paths (#6423)

This is a follow-up of commit 12f5b702ef4c8bcbd343b6272555ba9f01b36438.

5 years ago[Tizen] Support to TabbedPage.BarTextColor, SelctedTabColor, UnselectedTabColor ...
Kangho Hur [Sat, 8 Jun 2019 01:12:40 +0000 (10:12 +0900)]
[Tizen] Support to TabbedPage.BarTextColor, SelctedTabColor, UnselectedTabColor (#6183)

fixes #3478

5 years ago[UWP] fixes ListView displays null values black (#6211)
Pavel Yakovlev [Sat, 8 Jun 2019 01:11:42 +0000 (18:11 -0700)]
[UWP] fixes ListView displays null values black (#6211)

fixes #6154
fixes #6233

5 years ago[Build] Add nightly tag to azdo (#6433)
Rui Marinho [Thu, 6 Jun 2019 15:16:22 +0000 (16:16 +0100)]
[Build] Add nightly tag to azdo (#6433)

5 years ago[Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes...
Pavel Yakovlev [Thu, 6 Jun 2019 13:55:17 +0000 (06:55 -0700)]
[Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes #5268

* [Android] fixes ListView pull-to-refresh gesture in non-data areas

* refactoring

* addressing comments

5 years ago[Build] Fix nightly package naming (#6429)
Rui Marinho [Thu, 6 Jun 2019 13:24:00 +0000 (14:24 +0100)]
[Build] Fix nightly package naming (#6429)

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 6 Jun 2019 04:16:23 +0000 (21:16 -0700)]
Merge branch '4.1.0'