Jez Ng [Wed, 31 Mar 2021 19:48:14 +0000 (15:48 -0400)]
[lld-macho][nfc] Test that -ObjC will import bitcode with category sections
The functionality was originally added in {D95265}, but the test in that
diff only checked if `-ObjC` would cause bitcode containing ObjC class
symbols to be loaded. It neglected to test for bitcode containing
categories but no class symbols.
This diff also changes the lto-archive.ll test to use `-why_load`
instead of inspecting the output binary's symbol table. This is
motivated by the stacked diff {D99105}, which will hide irrelevant
bitcode symbols.
Reviewed By: #lld-macho, oontvoo
Differential Revision: https://reviews.llvm.org/D99215
Alexey Bataev [Wed, 31 Mar 2021 19:35:38 +0000 (12:35 -0700)]
[SLP]Update test checks, NFC
Craig Topper [Wed, 31 Mar 2021 19:25:42 +0000 (12:25 -0700)]
[SelectionDAG] Remove unneeded vector resize from the end of FoldConstantArithmetic. NFC
There's an assert right before that makes sure the size already matches.
Earlier in this function's life, scalars and vectors shared more
code.
Andrew Young [Mon, 29 Mar 2021 02:25:32 +0000 (19:25 -0700)]
[mlir][cse] do not replace operands in previously simplified operations
If an operation has been inserted as a key in to the known values
hashtable, then it can not be modified in a way which changes its hash.
This change avoids modifying the operands of any previously recorded
operation, which prevents their hash from changing.
In an SSACFG region, it is impossible to visit an operation before
visiting its operands, so this is not a problem. This situation can only
happen in regions without strict dominance, such as graph regions.
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D99486
George Mitenkov [Wed, 31 Mar 2021 18:46:28 +0000 (21:46 +0300)]
[ConstantFolding] Fixing addo/subo with undef
When folding addo/subo with undef, the current
convention is to use { -1, false } for addo and
{ 0, false } for subo. This was fixed for InstSimplify in
https://reviews.llvm.org/rGf094d65beaa492e845b03561eddd75b5be653a01,
but not in ConstantFolding.
Reviewed By: nikic, lebedev.ri
Differential Revision: https://reviews.llvm.org/D99564
Alexey Bataev [Wed, 31 Mar 2021 18:21:54 +0000 (11:21 -0700)]
[SLP]Add a test for the bug in `getVectorElementSize()`, NFC.
peter klausler [Wed, 31 Mar 2021 16:12:28 +0000 (09:12 -0700)]
[flang] Refine checks for pointer initialization targets
f18 was emitting a bogus error message about the lack of a TARGET
attribute when a pointer was initialized with a component of a
variable that was a legitimate TARGET.
Differential Revision: https://reviews.llvm.org/D99665
Huihui Zhang [Wed, 31 Mar 2021 17:58:36 +0000 (10:58 -0700)]
[LoopVectorize] Use SetVector to track uniform uses to prevent non-determinism.
Use SetVector instead of SmallPtrSet to track values with uniform use. Doing this
can help avoid non-determinism caused by iterating over unordered containers.
This bug was found with reverse iteration turning on,
--extra-llvm-cmake-variables="-DLLVM_REVERSE_ITERATION=ON".
Failing LLVM test consecutive-ptr-uniforms.ll .
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D99549
Suraj Sudhir [Wed, 31 Mar 2021 17:48:21 +0000 (10:48 -0700)]
Move non-spec TOSA operators into TosaUtilOps.td
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D99628
Petr Hosek [Tue, 22 Sep 2020 08:01:16 +0000 (01:01 -0700)]
[Driver] Move detectLibcxxIncludePath to ToolChain
This helper method is useful even outside of Gnu toolchains, so move
it to ToolChain so it can be reused in other toolchains such as Fuchsia.
Differential Revision: https://reviews.llvm.org/D88452
Thomas Lively [Wed, 31 Mar 2021 17:46:17 +0000 (10:46 -0700)]
[WebAssembly] Implement i64x2 comparisons
Removes the prototype builtin and intrinsic for i64x2.eq and implements that
instruction as well as the other i64x2 comparison instructions in the final SIMD
spec. Unsigned comparisons were not included in the final spec, so they still
need to be scalarized via a custom lowering.
Differential Revision: https://reviews.llvm.org/D99623
Juneyoung Lee [Wed, 31 Mar 2021 17:01:17 +0000 (02:01 +0900)]
[ValueTracking] Add with.overflow intrinsics to poison analysis functions
This is a patch teaching ValueTracking that `s/u*.with.overflow` intrinsics do not
create undef/poison and they propagate poison.
I couldn't write a nice example like the one with ctpop; ValueTrackingTest.cpp were simply updated
to check these instead.
This patch helps reducing regression while fixing https://llvm.org/pr49688 .
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D99671
Philip Reames [Wed, 31 Mar 2021 17:29:21 +0000 (10:29 -0700)]
[SCEV] Handle unreachable binop when matching shift recurrence
This fixes an issue introduced with my change d4648e, and reported in pr49768.
The root problem is that dominance collapses in unreachable code, and that LoopInfo explicitly only models reachable code. Since the recurrence matcher doesn't filter by reachability (and can't easily because not all consumers have domtree), we need to bailout before assuming that finding a recurrence implies we found a loop.
Craig Topper [Wed, 31 Mar 2021 16:49:16 +0000 (09:49 -0700)]
[X86] Improve SMULO/UMULO codegen for vXi8 vectors.
The default expansion creates a MUL and either a MULHS/MULHU. Each
of those separately expand to sequences that use one or more
PMULLW instructions as well as additional instructions to
extend the types to vXi16. The MULHS/MULHU expansion computes the
whole 16-bit product, but only keeps the high part.
We can improve the lowering of SMULO/UMULO for some cases by using the MULHS/MULHU
expansion, but keep both the high and low parts. And we can use
those parts to calculate the overflow.
For AVX512 we might have vXi1 overflow outputs. We can improve those by using
vpcmpeqw to produce a k register if AVX512BW is enabled. This is a little better
than truncating the high result to use vpcmpeqb. If we don't have avx512bw we
can extend up to v16i32 to use vpcmpeqd to produce a k register.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D97624
Shimin Cui [Wed, 31 Mar 2021 16:36:49 +0000 (12:36 -0400)]
[PowerPC] [MLICM] Enable hoisting of caller preserved registers on AIX
On ppc64 linux , MachineLICM will hoist caller preserved registers, including TOC loads of the global variable address, out of loops. This is to enable this on AIX for both ppc64 and ppc32.
Differential Revision: https://reviews.llvm.org/D99076
Craig Topper [Wed, 31 Mar 2021 16:41:02 +0000 (09:41 -0700)]
[X86] Improve optimizeCompareInstr for signed comparisons after BMI/TBM instructions
We previously couldn't optimize out a TEST if the branch/setcc/cmov
used the overflow flag. This patches allows the TEST to be removed
if the flag producing instruction is known to clear the OF flag.
Thats what the TEST instruction would have done so that should be
equivalent.
Need to add test cases. I'll try to get back to this if I have bandwidth.
Fixes PR48768.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D94856
Wael Yehia [Wed, 31 Mar 2021 16:42:12 +0000 (16:42 +0000)]
[LTO][Legacy] Decouple option parsing from LTOCodeGenerator
in this patch we add a new libLTO API to specify debug options independent of an lto_code_gen_t.
This allows clients to pass codegen flags (through libLTO) which otherwise today are ignored.
Reviewed By: steven_wu
Differential Revision: https://reviews.llvm.org/D92611
Craig Topper [Wed, 31 Mar 2021 16:27:22 +0000 (09:27 -0700)]
[RISCV] Add RISCVISD opcodes for CLZW and CTZW.
Our CLZW isel pattern is quite easily broken by surrounding code
preventing it from matching sometimes. This usually results in
failing to remove the and X, 0xffffffff inserted by type
legalization. The add with -32 that type legalization also inserts
will often gets combined into other add/sub nodes. That doesn't
usually result in extra code when we don't use clzw.
CTTZ seems to be less fragile, but I wanted to keep it consistent
with CTLZ.
Reviewed By: asb, HsiangKai
Differential Revision: https://reviews.llvm.org/D99317
Jay Foad [Wed, 31 Mar 2021 15:54:21 +0000 (16:54 +0100)]
[AMDGPU] Add some image tests with enable-prt-strict-null disabled. NFC.
Jay Foad [Wed, 31 Mar 2021 15:51:16 +0000 (16:51 +0100)]
[AMDGPU] Use a common check prefix for some image tests. NFC.
Craig Topper [Wed, 31 Mar 2021 16:22:38 +0000 (09:22 -0700)]
[RISCV] Add isel patterns to select vsub_vx intrinsic to vadd.vi if it uses a small enough immediate
Also modify the simm5_plus1 check because Imm-1 is UB if Imm happens
to be INT64_MIN. I don't think the compiler would optimize based on that in this
usage, but it could fail UBSan or -ftrapv.
Reviewed By: HsiangKai, frasercrmck
Differential Revision: https://reviews.llvm.org/D99637
Arthur Eubanks [Tue, 30 Mar 2021 16:30:05 +0000 (09:30 -0700)]
[llvm-jitlink] Fix -Wunused-function on Windows
Reviewed By: sgraenitz
Differential Revision: https://reviews.llvm.org/D99604
Heejin Ahn [Wed, 31 Mar 2021 09:32:51 +0000 (02:32 -0700)]
[WebAssembly] Raname a test and fix comments
D99627 fixed a decoding bug, not an encoding bug. This renames the test
to correct it and fix comments.
Reviewed By: dschuff
Differential Revision: https://reviews.llvm.org/D99644
Sanjay Patel [Wed, 31 Mar 2021 15:26:22 +0000 (11:26 -0400)]
[InstCombine] fold abs(srem X, 2)
This is a missing optimization based on an example in:
https://llvm.org/PR49763
As noted there and the test here, we could add a more
general fold if that is shown useful.
https://alive2.llvm.org/ce/z/xEHdTv
https://alive2.llvm.org/ce/z/97dcY5
Sanjay Patel [Wed, 31 Mar 2021 13:29:49 +0000 (09:29 -0400)]
[InstCombine] add tests for srem+abs; NFC
Bradley Smith [Wed, 24 Mar 2021 11:16:20 +0000 (11:16 +0000)]
[AArch64][SVE] Add tests for UREM/SREM using fixed SVE types
Differential Revision: https://reviews.llvm.org/D99265
Timm Bäder [Wed, 3 Mar 2021 09:45:07 +0000 (10:45 +0100)]
[clang][parser] Allow GNU-style attributes in explicit template...
... instantiations
They are currently not being diagnosed because ProhibitAttributes() does
not handle attribute lists with an invalid source range. But once it
does, we need to allow GNU attributes in this place.
Additionally, start optionally diagnosing empty attr lists in
ProhibitCXX11Attributes(), since ProhibitAttribute() does it.
Differential Revision: https://reviews.llvm.org/D97362
Arthur O'Dwyer [Wed, 31 Mar 2021 14:18:51 +0000 (10:18 -0400)]
[libc++] Mark convert_copy.pass.cpp as UNSUPPORTED on clang-13 (i.e. trunk).
Because the constexpr-time codepath triggers a Clang bug. It seems
that Clang compiles it okay in release mode, but when Clang itself
is compiled in debug mode (with assertions turned on), this input
triggers an assertion failure in Clang itself. See comments on D96385
and Clang bug report https://bugs.llvm.org/show_bug.cgi?id=45879
This commit should get the debug-mode buildbots back to green.
Luís Marques [Wed, 31 Mar 2021 14:18:02 +0000 (15:18 +0100)]
[RISCV] Add XFAIL riscv32 for known issue with the old pass manager
See D80668, rG7b4832648a63 and https://bugs.llvm.org/show_bug.cgi?id=46117
for details of the issue.
Differential Revision: https://reviews.llvm.org/D99108
Sander de Smalen [Tue, 23 Feb 2021 17:10:12 +0000 (17:10 +0000)]
[SVE] Fix LoopVectorizer test scalalable-call.ll
This marks FSIN and other operations to EXPAND for scalable
vectors, so that they are not assumed to be legal by the cost-model.
Depends on D97470
Reviewed By: dmgreen, paulwalker-arm
Differential Revision: https://reviews.llvm.org/D97471
Sander de Smalen [Mon, 25 Jan 2021 13:59:37 +0000 (13:59 +0000)]
[CostModel] Align the cost model for intrinsics for scalable/fixed-width vectors.
Let getIntrinsicInstrCost call getTypeBasedIntrinsicInstrCost for scalable vectors,
similar to how this is done for fixed-width vectors, instead of falling back
on BaseT::getIntrinsicInstrCost().
If the intrinsic cannot be costed (or is not overloaded by the target),
it will return InstructionCost::getInvalid() instead.
Depends on D97469
Reviewed By: david-arm
Differential Revision: https://reviews.llvm.org/D97470
Anton Bikineev [Sat, 27 Mar 2021 16:27:21 +0000 (16:27 +0000)]
[C++2b] Support size_t literals
This adds support for C++2b's z/uz suffixes for size_t literals (P0330).
Joerg Sonnenberger [Thu, 18 Feb 2021 14:15:53 +0000 (15:15 +0100)]
[libc++] Avoid <climits> dependency in <thread>
The standard guarantees sleep durations of 2^63-1 nanoseconds to work.
Instead of depending on INT64_MAX or ULONGLONG_MAX to exist via the
header pollution, fold the constant directly. That has the additional
positive side effect that it avoids long double arithmetic bugs in GCC.
Differential Revision: https://reviews.llvm.org/D99516
Balázs Kéri [Wed, 31 Mar 2021 13:28:53 +0000 (15:28 +0200)]
Revert "[clang][Checkers] Extend PthreadLockChecker state dump (NFC)."
This reverts commit
49c0ab6d7611050ae902f6369fc878e17da453ad.
Test failures showed up because non-deterministic output.
Sander de Smalen [Fri, 22 Jan 2021 17:14:44 +0000 (17:14 +0000)]
NFC: Change getIntrinsicInstrCost to return InstructionCost
This patch migrates the TTI cost interfaces to return an InstructionCost.
See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html
Depends on D97468
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D97469
Sander de Smalen [Fri, 22 Jan 2021 17:34:10 +0000 (17:34 +0000)]
NFC: Change getTypeBasedIntrinsicCost to return InstructionCost
This patch migrates the TTI cost interfaces to return an InstructionCost.
See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html
Depends on D97466
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D97468
Max Kazantsev [Wed, 31 Mar 2021 11:20:19 +0000 (18:20 +0700)]
[Test] Auto-update test checks
Muhammad Omair Javaid [Wed, 31 Mar 2021 12:10:03 +0000 (17:10 +0500)]
Revert "[LLDB] Arm64/Linux Add MTE and Pointer Authentication registers"
This reverts commit
1164b4e2957290e814c3dd781a68e504dd39148e.
Reason: LLDB AArch64 Linux buildbot failure
Muhammad Omair Javaid [Wed, 31 Mar 2021 12:08:07 +0000 (17:08 +0500)]
Revert "[LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset"
This reverts commit
9ab677180091a690cd99d4ac55d5fb9e1149b1ec.
Reason: LLDB AArch64/Linux buildbot failure.
Liqiang Tao [Wed, 31 Mar 2021 11:52:58 +0000 (19:52 +0800)]
[InlineCost] Remove TODO comment that consider other forms of savings in the cost-benefit analysis
Attempts to compute savings more accurately cannot impact the set of critically important call sites.
Reviewed By: kazu
Differential Revision: https://reviews.llvm.org/D98577
Roman Lebedev [Wed, 31 Mar 2021 11:14:13 +0000 (14:14 +0300)]
[X86] AMD Zen 3 has macro fusion
This is an improvement over Zen 2, where only branch fusion is supported,
as per Agner, 21.4 Instruction fusion.
AMD SOG 17h has no mention of fusion.
AMD SOG 19h, 2.9.3 Branch Fusion
The following flag writing instructions support branch fusion
with their reg/reg, reg/imm and reg/mem forms
* CMP
* TEST
* SUB
* ADD
* INC (no fusion with branches dependent on CF)
* DEC (no fusion with branches dependent on CF)
* OR
* AND
* XOR
Agner, 22.4 Instruction fusion
<...> This applies to CMP, TEST, ADD, SUB, AND, OR, XOR, INC, DEC and
all conditional jumps, except if the arithmetic or logic instruction has a rip-relative address or
both an address displacement and an immediate operand.
Balazs Benics [Wed, 31 Mar 2021 10:47:37 +0000 (12:47 +0200)]
[ASTImporter][NFC] Fix duplicated symbols in "Improve test coverage"
D99576 introduced a duplicate symbol, now im removing it.
Differential Revision: https://reviews.llvm.org/D99576
Fraser Cormack [Tue, 30 Mar 2021 13:49:25 +0000 (14:49 +0100)]
[RISCV] Add support for the stepvector intrinsic
This adds almost everything required for supporting the new stepvector
intrinsic on RVV. It is lowered to the existing VID_VL SDNode.
The only exception is a limitation that RV32 cannot yet lower the
intrinsic on i64 vectors. This is because the step operand is
(currently) required to be at least as large as the vector element type.
I will look into patching that out and loosening the requirement to only
an integer pointer type.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D99594
Muhammad Omair Javaid [Wed, 31 Mar 2021 09:36:38 +0000 (14:36 +0500)]
Revert "[LLDB] Skip TestVSCode_disconnect.test_launch arm/linux"
This reverts commit
73cf85e527f69c495daece7c74743b9073d4717c.
Jay Foad [Mon, 1 Mar 2021 17:24:57 +0000 (17:24 +0000)]
[AMDGPU][GlobalISel] Add support for global atomicrmw fadd
This includes gfx908 which only has a no-return version of the
global_atomic_add_f32 instruction, using the same hack that was
previously implemented for selecting from the
llvm.amdgcn.global.atomic.fadd intrinsic.
Differential Revision: https://reviews.llvm.org/D97767
Balazs Benics [Wed, 31 Mar 2021 10:10:23 +0000 (12:10 +0200)]
[ASTImporter][NFC] Improve test coverage
All three cases were imported correctly.
For BlockDecls, correctly means that we don't support importing them, thus an
error is the expected behaviour.
- BlockDecls were not yet covered. I know that they are not imported but the
test at least documents it.
- Default values for ParmVarDecls were also uncovered.
- Importing bitfield FieldDecls were imported correctly.
Reviewed By: martong, shafik
Differential Revision: https://reviews.llvm.org/D99576
Florian Hahn [Wed, 31 Mar 2021 08:38:12 +0000 (09:38 +0100)]
[AArch64] Avoid SCALAR_TO_VECTOR for single FP constant vector.
Currently the code only checks for integer constants (ConstantSDNode)
and triggers an infinite cycle for single-element floating point
vector constants. We need to check for both FP and integer constants.
Reviewed By: t.p.northover
Differential Revision: https://reviews.llvm.org/D99384
Sander de Smalen [Wed, 20 Jan 2021 17:17:23 +0000 (17:17 +0000)]
NFC: Change getUserCost to return InstructionCost
This patch migrates the TTI cost interfaces to return an InstructionCost.
See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html
Depends on D97382
Reviewed By: ctetreau, paulwalker-arm
Differential Revision: https://reviews.llvm.org/D97466
Balázs Kéri [Wed, 31 Mar 2021 08:36:06 +0000 (10:36 +0200)]
[clang][Checkers] Extend PthreadLockChecker state dump (NFC).
Add printing of map 'DestroyRetVal'.
Reviewed By: steakhal
Differential Revision: https://reviews.llvm.org/D98502
Matthias Springer [Wed, 31 Mar 2021 05:59:30 +0000 (14:59 +0900)]
[mlir] Change vector.transfer_read/write "masked" attribute to "in_bounds".
This is in preparation for adding a new "mask" operand. The existing "masked" attribute was used to specify dimensions that may be out-of-bounds. Such transfers can be lowered to masked load/stores. The new "in_bounds" attribute is used to specify dimensions that are guaranteed to be within bounds. (Semantics is inverted.)
Differential Revision: https://reviews.llvm.org/D99639
Sven van Haastregt [Wed, 31 Mar 2021 08:54:18 +0000 (09:54 +0100)]
[OpenCL] Limit popcount to OpenCL 1.2 and above
s6.15.3 of the OpenCL C Specification v3.0.6 states that OpenCL 1.2 or
newer is required.
Alex Richardson [Wed, 31 Mar 2021 08:24:03 +0000 (09:24 +0100)]
[TableGen] Emit more helpful error messages on empty type set
I have seen this error quite frequently in our out-of-tree CHERI backends
and the lack of location information sometimes makes it quite difficult
to track down the actual source of the error.
This patch changes the llvm_unreachable() to a PrintFatalError() so that
tablegen prints a stack of source locations.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D99468
Alex Richardson [Wed, 31 Mar 2021 08:17:39 +0000 (09:17 +0100)]
[asan] Remove FreeBSD XFAIL from asan-sigbus.cpp test
This test passes for me on FreeBSD 12.2 and was probably fixed by
https://svnweb.freebsd.org/base?view=revision&revision=352807.
Reviewed By: emaste
Differential Revision: https://reviews.llvm.org/D98281
Alex Richardson [Wed, 31 Mar 2021 08:15:22 +0000 (09:15 +0100)]
[WebAssembly] Fix incorrect DW_TAG_pointer_type size in test
It should be 64 bits not 32 for wasm64-unknown-unknown. I noticed this
because this test was failing in our CHERI fork of LLVM due to a larger
.debug_abbrev section size. It turns out this happens because we add
DW_AT_byte_size for non-default pointer sizes to allow debugging our
hybrid compilation mode where we can have two different kinds of pointers.
Reviewed By: aardappel
Differential Revision: https://reviews.llvm.org/D99410
Nicolas Vasilache [Tue, 30 Mar 2021 11:41:41 +0000 (11:41 +0000)]
[mlir][Linalg][Python] Create the body of builtin named Linalg ops
This revision adds support to properly add the body of registered
builtin named linalg ops.
At this time, indexing_map and iterator_type support is still
missing so the op is not executable yet.
Differential Revision: https://reviews.llvm.org/D99578
Alexander Belyaev [Wed, 31 Mar 2021 07:34:03 +0000 (09:34 +0200)]
Revert "Revert "[mlir] Introduce CloneOp and adapt test cases in BufferDeallocation.""
This reverts commit
883912abe669ef246ada0adc9cf1c9748b742400.
Craig Topper [Wed, 31 Mar 2021 05:47:25 +0000 (22:47 -0700)]
[X86] Add test cases for PR48768 and D94856. NFC
This covers the BMI and TBM instructions. More tests will be
needed for other instructions.
Craig Topper [Wed, 31 Mar 2021 05:45:58 +0000 (22:45 -0700)]
[X86] Regenerate test to add missing @PLT
Martin Storsjö [Wed, 24 Mar 2021 07:31:54 +0000 (09:31 +0200)]
[libcxx] [test] Don't add dirs from the LIB env var to PATH
The directories in LIB normally only contain import libraries or
static libraries, no runtime DLLs that would need to be found
while running tests.
This code stems from
1cd196e7b46e49d170a4b4013879a577dee59cb2,
which (among other things) tried to do this:
> * [Test] Fix handling of library runtime search paths by correctly adding them
> to the PATH variable when running the tests.
It's unclear to me exactly what this fixed (or tried to) at the time,
as the LIB var doesn't normally point to runtime libs.
Differential Revision: https://reviews.llvm.org/D99241
Martin Storsjö [Sat, 20 Mar 2021 22:25:57 +0000 (00:25 +0200)]
[libcxx] [test] Fix tests of <cuchar> that unexpectedly succeed on windows
The tests expect that the <cuchar> include should fail. When libc++
is built on top of the MSVC runtime, the header does exist provided
by MSVC. Therefore, just mark the test as unsupported on windows,
to avoid tests that unexpectedly succeed.
Differential Revision: https://reviews.llvm.org/D99096
Jim Lin [Wed, 31 Mar 2021 05:11:41 +0000 (13:11 +0800)]
[RISCV] Refine pre-define macro tests
1. Undefined macro test for rv32i and rv64i.
a. Reorder it with canonical order.
b. Add missing undefined macro check.
c. Append defined value to `__riscv_a`, `__riscv_f` and `__riscv_c` to distinguish with
`__riscv_arch_test`, `__riscv_cmodel_medlow` and `__riscv_float_abi_soft`. They have the same prefix.
2. Move abi macro test below f and d.
3. Unify coding style for newline.
Reviewed By: HsiangKai
Differential Revision: https://reviews.llvm.org/D99631
Lang Hames [Wed, 31 Mar 2021 05:56:41 +0000 (22:56 -0700)]
[JITLink] Delete copy and move constructors for jitlink::Section.
Sections are not movable or copyable.
Stella Laurenzo [Wed, 31 Mar 2021 05:19:10 +0000 (22:19 -0700)]
[mlir] Add C and python API for is_registered_operation.
* Suggested to be broken out of D99578
Differential Revision: https://reviews.llvm.org/D99638
Nathan Chancellor [Wed, 31 Mar 2021 04:08:18 +0000 (21:08 -0700)]
libc: Default LIBC_INSTALL_PREFIX to ${CMAKE_INSTALL_PREFIX}
b22f448c21e718a3b6 added a rule to install libllvmlibc.a to
${LIBC_INSTALL_PREFIX}/${LIBC_INSTALL_LIBRARY_DIR}, which will be /lib
by default, which is disruptive to builds that stay within a user's
/home holder:
$ ninja install
...
-- Installing: /lib/libllvmlibc.a
CMake Error at projects/libc/lib/cmake_install.cmake:54 (file):
file INSTALL cannot copy file
"/home/nathan/cbl/github/tc-build/build/llvm/stage1/projects/libc/lib/libllvmlibc.a"
to "/lib/libllvmlibc.a": Permission denied.
Call Stack (most recent call first):
projects/libc/cmake_install.cmake:51 (include)
projects/cmake_install.cmake:47 (include)
cmake_install.cmake:76 (include)
...
Change LIBC_INSTALL_PREFIX's default value to ${CMAKE_INSTALL_PREFIX} so
that 'ninja install' does not attempt to install anything outside of the
user's requested installation location.
Differential Revision: https://reviews.llvm.org/D99636
Reviewed By: sivachandra
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Lang Hames [Wed, 31 Mar 2021 03:56:03 +0000 (20:56 -0700)]
[JITLink] Switch from StringRef to ArrayRef<char>, add some generic x86-64 utils
Adds utilities for creating anonymous pointers and jump stubs to x86_64.h. These
are used by the GOT and Stubs builder, but may also be used by pass writers who
want to create pointer stubs for indirection.
This patch also switches the underlying type for LinkGraph content from
StringRef to ArrayRef<char>. This avoids any confusion when working with buffers
that contain null bytes in the middle like, for example, a newly added null
pointer content array. ;)
Chuanqi Xu [Wed, 31 Mar 2021 02:34:55 +0000 (10:34 +0800)]
[Coroutine] [Debug] Insert dbg.declare to entry.resume to print alloca in the coroutine frame under O2
Summary: Try to insert dbg.declare to entry.resume basic block in resume
function. In this way, we could print alloca such as __promise in
gdb/lldb under O2, which would be beneficial to debug coroutine program.
Test Plan: check-llvm
Reviewed by: aprantl
Differential Revision: https://reviews.llvm.org/D96938
Zhiwei Chen [Wed, 31 Mar 2021 02:32:29 +0000 (19:32 -0700)]
[Utils][Emacs] Improve syntax highlight
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D99404
Fangrui Song [Wed, 31 Mar 2021 02:27:10 +0000 (19:27 -0700)]
[SimpleLoopUnswitch] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after
431a40e1e28f181e87dd247b91a5e6872dd64ab4
Craig Topper [Wed, 31 Mar 2021 02:00:28 +0000 (19:00 -0700)]
[RISCV] simm12_plus1 should not inherit from Operand. NFC
We only use this in Pat patterns, so it just needs to be an
ImmLeaf. If we did need it as an instruction operand, the
ParserMatchClass, EncoderMethod, and DecoderMethod were probably wrong.
Yang Fan [Wed, 31 Mar 2021 01:56:31 +0000 (09:56 +0800)]
[GlobalISel] Fix Wint-in-bool-context warning (NFC)
GCC warning:
```
/llvm-project/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp: In member function ‘bool llvm::CombinerHelper::matchFunnelShiftToRotate(llvm::MachineInstr&)’:
/llvm-project/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3882:35: warning: ?: using integer constants in boolean context, the expression will always evaluate to ‘true’ [-Wint-in-bool-context]
3882 | Opc == TargetOpcode::G_FSHL ? TargetOpcode::G_ROTL : TargetOpcode::G_ROTR;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Craig Topper [Wed, 31 Mar 2021 01:54:07 +0000 (18:54 -0700)]
[RISCV] Remove some unused ImmLeafs. NFC
These got left behind when we switched RV32 to use selectImm to
match RV64.
Juneyoung Lee [Wed, 31 Mar 2021 01:34:46 +0000 (10:34 +0900)]
[LoopUnswitch] Assert that branch condition is either and/or but not both
as suggested at https://reviews.llvm.org/rG5bb38e84d3d0#986321
Ta-Wei Tu [Wed, 31 Mar 2021 01:05:24 +0000 (09:05 +0800)]
[clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct
This fixes https://bugs.llvm.org/show_bug.cgi?id=49534, where the call to the constructor
of the anonymous union is checked and triggers assertion failure when trying to retrieve
the alignment of the `this` argument (which is a union with virtual function).
The extra check for alignment was introduced in D97187.
Reviewed By: tmatheson
Differential Revision: https://reviews.llvm.org/D98548
Walter Erquinigo [Wed, 31 Mar 2021 00:53:57 +0000 (17:53 -0700)]
Fix errors in
0b69756110db444282c40ea16929186b2910c3b1
Errors found in
https://lab.llvm.org/buildbot/#/builders/68/builds/9681/steps/6/logs/stdio
Lang Hames [Wed, 31 Mar 2021 00:53:59 +0000 (17:53 -0700)]
[JITLink] Add a setProtectionFlags method to jitlink::Section.
This allows clients to modify the memory protection settings on sections via
jitlink passes. This can be used to, for example, override the default settings
on text pages and make them Read/Write/Executable under the JIT.
Richard Smith [Wed, 31 Mar 2021 00:47:47 +0000 (17:47 -0700)]
Fix test expectations for %diff documentation.
Craig Topper [Tue, 30 Mar 2021 23:43:12 +0000 (16:43 -0700)]
[StructLayout] Use TrailingObjects to allocate space for MemberOffsets.
MemberOffsets are stored at the end of StructLayout. The class
contains a single entry array to mark the start of the member
offsets. getStructLayout calculates the additional space needed
for additional elements before allocating memory.
This patch converts this to use TrailingObjects. This simplifies
the size computation in getStructLayout and gets rid of the
single entry array.
This is prep work, but to use TypeSize instead of uint64_t for
D98169. The single entry array doesn't work with TypeSize because
TypeSize doesn't have a default constructor. We thought this
change was an improvement by itself so we've separated it out.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D99608
Nico Weber [Wed, 31 Mar 2021 00:30:36 +0000 (20:30 -0400)]
Reland "[gn build] port 48e4b0f (__config_site)"
This reverts commit
13aff21f0da7007c42d407b4ec5c1f6b24cb6831,
since the CMake part relanded in
c06a8f9caa51c7ea7.
The GN part is a bit simpler than last time due to the
prior simplifications in
acea470c167fc40.
Walter Erquinigo [Mon, 9 Nov 2020 21:36:26 +0000 (13:36 -0800)]
[trace][intel-pt] Implement trace start and trace stop
This implements the interactive trace start and stop methods.
This diff ended up being much larger than I anticipated because, by doing it, I found that I had implemented in the beginning many things in a non optimal way. In any case, the code is much better now.
There's a lot of boilerplate code due to the gdb-remote protocol, but the main changes are:
- New tracing packets: jLLDBTraceStop, jLLDBTraceStart, jLLDBTraceGetBinaryData. The gdb-remote packet definitions are quite comprehensive.
- Implementation of the "process trace start|stop" and "thread trace start|stop" commands.
- Implementaiton of an API in Trace.h to interact with live traces.
- Created an IntelPTDecoder for live threads, that use the debugger's stop id as checkpoint for its internal cache.
- Added a functionality to stop the process in case "process tracing" is enabled and a new thread can't traced.
- Added tests
I have some ideas to unify the code paths for post mortem and live threads, but I'll do that in another diff.
Differential Revision: https://reviews.llvm.org/D91679
Richard Smith [Wed, 31 Mar 2021 00:21:31 +0000 (17:21 -0700)]
[www] List both the regular and expanded form of %diff in the
diagnostics reference.
In passing, properly validate and diagnose errors in %diff format
specifiers.
Muhammad Omair Javaid [Tue, 30 Mar 2021 10:39:38 +0000 (15:39 +0500)]
[LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset
This patch adds a test case to test AArch64 dynamic register sets.
This tests for the availability of certain register sets and query
their registers accordingly.
Reviewed By: labath, DavidSpickett
Differential Revision: https://reviews.llvm.org/D96463
Muhammad Omair Javaid [Tue, 30 Mar 2021 10:39:38 +0000 (15:39 +0500)]
[LLDB] Arm64/Linux Add MTE and Pointer Authentication registers
This patch adds two new dynamic register sets for AArch64 MTE and
Pointer Authentication features. These register sets are dynamic and
will only be available if underlying hardware support either of these
features. LLDB will pull in Aux vector information and create register
infos based on that information.
A follow up patch will add a test case to test these feature registers.
Reviewed By: labath, DavidSpickett
Differential Revision: https://reviews.llvm.org/D96460
Muhammad Omair Javaid [Tue, 30 Mar 2021 10:39:32 +0000 (15:39 +0500)]
[LLDB] Add support for Arm64/Linux dynamic register sets
This is patch adds support for adding dynamic register sets for
AArch64 dynamic features in LLDB. AArch64 has optional features like
SVE, Pointer Authentication and MTE which means LLDB needs to decide
at run time which registers it needs to pull in for the current
executable based on underlying support for a certain feature.
This patch makes necessary adjustments to make way for dynamic
register infos and dynamic register sets.
Reviewed By: labath
Differential Revision: https://reviews.llvm.org/D96458
Heejin Ahn [Tue, 30 Mar 2021 19:57:20 +0000 (12:57 -0700)]
[WebAssembly] Encode numbers in ULEB128 in event section
The number of events and the type index should be encoded in ULEB128,
but they were incorrctly encoded in LEB128. The smallest number with
which its LEB128 and ULEB128 encodings are different is 64.
There's no way we can generate 64 events in the C++ toolchain
implementation so we can't test that, but the attached test tests when
the type index is 64.
Reviewed By: dschuff
Differential Revision: https://reviews.llvm.org/D99627
Richard Smith [Tue, 30 Mar 2021 23:17:32 +0000 (16:17 -0700)]
Delete checked-in generated copy of diagnostic reference.
The documentation build rule will generate an up-to-date version of this
if it's not checked in.
Richard Smith [Tue, 30 Mar 2021 23:17:09 +0000 (16:17 -0700)]
[www] Fix build of attribute documentation.
Richard Smith [Tue, 30 Mar 2021 23:10:32 +0000 (16:10 -0700)]
Fix pluralization error in diagnostic, and move C++ testcase to proper
directory.
Zequan Wu [Tue, 30 Mar 2021 18:02:27 +0000 (11:02 -0700)]
[lld-link] Enable addrsig table in COFF lto
This allow safe-icf mode to work when linking with LTO.
Differential Revision: https://reviews.llvm.org/D99613
Richard Smith [Tue, 30 Mar 2021 22:20:33 +0000 (15:20 -0700)]
[www] Color Clang 11 and Clang 12 features as green and not yellow, and
Clang 13 features as yellow not green.
Mehdi Amini [Tue, 30 Mar 2021 21:11:02 +0000 (21:11 +0000)]
Fix deletion of operations through the rewriter in a pattern matching a consumer operation
This allows for the conversion to match `A(B()) -> C()` with a pattern matching
`A` and marking `B` for deletion.
Also add better assertions when an operation is erased while still having uses.
Differential Revision: https://reviews.llvm.org/D99442
Greg McGary [Tue, 30 Mar 2021 00:19:29 +0000 (17:19 -0700)]
[lld-macho][NFC] Drop unnecessary macho:: namespace prefix on unambiguous references to Symbol
Within `lld/macho/`, only `InputFiles.cpp` and `Symbols.h` require the `macho::` namespace qualifier to disambiguate references to `class Symbol`.
Add braces to outer `for` of a 5-level single-line `if`/`for` nest.
Differential Revision: https://reviews.llvm.org/D99555
Wei Mi [Mon, 29 Mar 2021 22:04:28 +0000 (15:04 -0700)]
[ThinLTO] During module importing, close one source module before open
another one for distributed mode.
Currently during module importing, ThinLTO opens all the source modules,
collect functions to be imported and append them to the destination module,
then leave all the modules open through out the lto backend pipeline. This
patch refactors it in the way that one source module will be closed before
another source module is opened. All the source modules will be closed after
importing phase is done. It will save some amount of memory when there are
many source modules to be imported.
Note that this patch only changes the distributed thinlto mode. For in
process thinlto mode, one source module is shared acorss different thinlto
backend threads so it is not changed in this patch.
Differential Revision: https://reviews.llvm.org/D99554
Jon Roelofs [Tue, 30 Mar 2021 21:29:35 +0000 (14:29 -0700)]
[docs] Fix up dead clang-format links after monorepo move. NFC
Mike Rice [Tue, 23 Mar 2021 01:13:29 +0000 (18:13 -0700)]
[OPENMP51]Initial support for the dispatch directive.
Added basic parsing/sema/serialization support for dispatch directive.
Differential Revision: https://reviews.llvm.org/D99537
Louis Dionne [Fri, 26 Jun 2020 16:08:59 +0000 (12:08 -0400)]
[libc++] Include <__config_site> from <__config>
Prior to this patch, we would generate a fancy <__config> header by
concatenating <__config_site> and <__config>. This complexifies the
build system and also increases the difference between what's tested
and what's actually installed.
This patch removes that complexity and instead simply installs <__config_site>
alongside the libc++ headers. <__config_site> is then included by <__config>,
which is much simpler. Doing this also opens the door to having different
<__config_site> headers depending on the target, which was impossible before.
It does change the workflow for testing header-only changes to libc++.
Previously, we would run `lit` against the headers in libcxx/include.
After this patch, we run it against a fake installation root of the
headers (containing a proper <__config_site> header). This makes use
closer to testing what we actually install, which is good, however it
does mean that we have to update that root before testing header changes.
Thus, we now need to run `ninja check-cxx-deps` before running `lit` by
hand.
Differential Revision: https://reviews.llvm.org/D97572
David Green [Tue, 30 Mar 2021 20:45:26 +0000 (21:45 +0100)]
[ARM] Add FeatureHasNoBranchPredictor for Thumb1 cores
Mark v6m/v8m-baseline cores as having no branch predictors. This should
not alter very much on its own, but is more correct as the cores do not
have branch predictors and can help in the future.
Alexey Bataev [Tue, 30 Mar 2021 19:53:25 +0000 (12:53 -0700)]
[OPENMP]Fix PR48607: Crash during clang openmp codegen for firstprivate() of `float _Complex`.
Need to cast the argument for the debug wrapper function call to the
corresponding parameter type to avoid crash.
Differential Revision: https://reviews.llvm.org/D99617
Luís Marques [Tue, 30 Mar 2021 20:19:05 +0000 (21:19 +0100)]
[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests
On 64-bit systems with small VMAs (e.g. 39-bit) we can't use
SizeClassAllocator64 parameterized with size class maps containing a large
number of classes, as that will make the allocator region size too small
(< 2^32). Several tests were already disabled for Android because of this.
This patch provides the correct allocator configuration for RISC-V
(riscv64), generalizes the gating condition for tests that can't be enabled
for small VMA systems, and tweaks the tests that can be made compatible with
those systems to enable them.
I think the previous gating on Android should instead be AArch64+Android, so
the patch reflects that.
Differential Revision: https://reviews.llvm.org/D97234
David Blaikie [Tue, 30 Mar 2021 01:04:02 +0000 (18:04 -0700)]
Conditionalize the JIT test dependency
Matheus Izvekov [Mon, 8 Mar 2021 00:09:13 +0000 (01:09 +0100)]
[clang] Use decltype((E)) for compound requirement type constraint
See PR45088.
Compound requirement type constraints were using decltype(E) instead of
decltype((E)), as per `[expr.prim.req]p1.3.3`.
Since neither instantiation nor type dependence should matter for
the constraints, this uses an approach where a `decltype` type is not built,
and just the canonical type of the expression after template instantiation
is used on the requirement.
Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Reviewed By: rsmith
Differential Revision: https://reviews.llvm.org/D98160