jvanverth@google.com [Fri, 14 Feb 2014 16:39:10 +0000 (16:39 +0000)]
Remove deprecation of SkBaseDevice::config() so compile can proceed.
TBR:reed@google.com
Review URL: https://codereview.chromium.org/
163773004
git-svn-id: http://skia.googlecode.com/svn/trunk@13455
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Feb 2014 15:23:15 +0000 (15:23 +0000)]
Revert "Revert of have DeferredDevice inherit from SkBaseDevice (https://codereview.chromium.org/
165393006/)"
removed assert from lockPixels(), since that is called during setDevice()
This reverts commit
20bfc5337fa17cff52fb96b13af674c181e2c5a9.
BUG=skia:
Review URL: https://codereview.chromium.org/
167003002
git-svn-id: http://skia.googlecode.com/svn/trunk@13454
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 14 Feb 2014 15:18:36 +0000 (15:18 +0000)]
Revert of have DeferredDevice inherit from SkBaseDevice (https://codereview.chromium.org/
165393006/)
Reason for revert:
broke tests
Original issue's description:
> have DeferredDevice inherit from SkBaseDevice
>
> mirror of
165813003
>
> BUG=skia:
>
> Committed: https://code.google.com/p/skia/source/detail?r=13452
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
163183011
git-svn-id: http://skia.googlecode.com/svn/trunk@13453
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Feb 2014 14:41:28 +0000 (14:41 +0000)]
have DeferredDevice inherit from SkBaseDevice
mirror of
165813003
BUG=skia:
Review URL: https://codereview.chromium.org/
165393006
git-svn-id: http://skia.googlecode.com/svn/trunk@13452
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 14 Feb 2014 14:29:22 +0000 (14:29 +0000)]
Rebaselines for https://codereview.chromium.org/
156113005/
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, halcanary@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
166403004
git-svn-id: http://skia.googlecode.com/svn/trunk@13451
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 14 Feb 2014 14:26:01 +0000 (14:26 +0000)]
Adjust allowed error from 0.5 to 2.5.
BUG=skia:2169
NOTRY=true
R=jvanverth@google.com
TBR=jvanverth@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
166233003
git-svn-id: http://skia.googlecode.com/svn/trunk@13450
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 14 Feb 2014 14:08:05 +0000 (14:08 +0000)]
Fix valgrind suppressions (again)
https://codereview.chromium.org/
166193003/
git-svn-id: http://skia.googlecode.com/svn/trunk@13449
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 14 Feb 2014 10:06:42 +0000 (10:06 +0000)]
Builder class for SkLayerDrawLooper.
SkLayerDrawLooper provides methods like addLayer() to build up a linked list
of layers. Working towards making this class immutable, this patch introduces
the SkLayerDrawLooperBuilder class which is used to accumulate all the layers
first. Once all layers are in place, it creates a new SkLayerDrawLooper object
and hands over the list of layers to that object.
For now we keep the addLayer methods in SkLayerDrawLooper so we don't break
Chrome and Blink when this is landed. Once we've updated all users, we can
remove the methods.
BUG=skia:2141
R=reed@google.com, scroggo@google.com, mtklein@google.com, reed@chromium.org
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
133813005
git-svn-id: http://skia.googlecode.com/svn/trunk@13448
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 14 Feb 2014 03:02:05 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13447
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 14 Feb 2014 00:03:38 +0000 (00:03 +0000)]
Defer deletion of our shaders until after linking the gl program to work around an Android emulator bug
R=bsalomon@google.com, brian@thesalomons.net, bsalomon
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/
164973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13446
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 22:52:51 +0000 (22:52 +0000)]
Small adjustments of two bench ranges.
BUG=skia:2169
NOTRY=true
R=jvanverth@google.com
TBR=jvanverth@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
164843004
git-svn-id: http://skia.googlecode.com/svn/trunk@13445
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 22:31:48 +0000 (22:31 +0000)]
fix debugging script for the SampleApp
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
164773002
git-svn-id: http://skia.googlecode.com/svn/trunk@13444
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 22:30:38 +0000 (22:30 +0000)]
ensure that opaque-only colortypes always report opaque-alphatype
BUG=skia:
R=scroggo@google.com, djsollen@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
164233006
git-svn-id: http://skia.googlecode.com/svn/trunk@13443
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 22:00:04 +0000 (22:00 +0000)]
replace setConfig+allocPixels with alloc-or-install-pixels
BUG=skia:
R=scroggo@google.com, halcanary@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
164203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13442
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 21:02:38 +0000 (21:02 +0000)]
Adding list of Skia's CQ committers
BUG=skia:2170
NOTRY=true
R=mtklein@google.com, hcm@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
163693003
git-svn-id: http://skia.googlecode.com/svn/trunk@13441
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 20:40:56 +0000 (20:40 +0000)]
Use a bench alert algorithm with wider ranges. TBR=jvanverth NOTRY=true
BUG=skia:2169
R=jvanverth@google.com, bsalomon@google.com, robertphillips@google.com
TBR=jvanverth@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
164553002
git-svn-id: http://skia.googlecode.com/svn/trunk@13440
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 18:46:13 +0000 (18:46 +0000)]
Fixed clusterfuzz found crash
BUG=343461
R=senorblanco@google.com, senorblanco@chromium.org, reed@chromium.org, reed@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
162943003
git-svn-id: http://skia.googlecode.com/svn/trunk@13439
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 18:37:35 +0000 (18:37 +0000)]
ARM Skia NEON patches - 27 - S32A_D565_Blend
BlitRow565: new intrinsics version of S32A_D565_Blend
This new version is basically a rewrite of the existing code with
a few speed and accuracy improvements. There is a switch to enable
pixel perfect results at the cost of a (quite big) decrease of
performances (disabled in this patch).
Here are the benchmark results (speedup vs. existing code):
+-------+------------+------------+
| count | Cortex -A9 | Cortex-A15 |
+-------+------------+------------+
| 1 | +103.6% | +12% |
+-------+------------+------------+
| 2 | +3.6% | +21.6% |
+-------+------------+------------+
| 4 | +0.8% | -0.8% |
+-------+------------+------------+
| 8 | +3.9% | -1% |
+-------+------------+------------+
| 16 | +14.7% | +5.7% |
+-------+------------+------------+
| 64 | +18.1% | +13.2% |
+-------+------------+------------+
| 256 | +16.3% | +27.4% |
+-------+------------+------------+
| 1024 | +78.2% | +17.4% |
+-------+------------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, halcanary@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
156113005
git-svn-id: http://skia.googlecode.com/svn/trunk@13438
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 18:36:36 +0000 (18:36 +0000)]
Gyp flag to disable inlining.
To turn off all inlining, rebuild after running the command
$ GYP_DEFINES=skia_disable_inlining=1 ./gyp_skia
Provides an initial value in one GM to avoid an uninitialized variable warning.
BUG=skia:2126
R=scroggo@google.com, mtklein@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
163363004
git-svn-id: http://skia.googlecode.com/svn/trunk@13437
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 18:35:54 +0000 (18:35 +0000)]
SkWriter32: throw in the SkTDArray towel.
I think it's looking more clear we don't have a clean way to use SkTDArray in
SkWriter32. We can't give SkWriter32 meaningful control over SkTDArray's
reallocation without making moot SkTDArray's raison d'etre.
Let's just use an SkAutoTMalloc<uint8_t> instead. It wants SkWriter32 to
control it. Also, it's lower overhead: SkAutoTMalloc<uint8_t> is just a smart
poiter: no size or capacity stored.
BUG=skia:
R=reed@google.com, iancottrell@google.com, reed@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
163983002
git-svn-id: http://skia.googlecode.com/svn/trunk@13436
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 13 Feb 2014 18:34:56 +0000 (18:34 +0000)]
Another try at updating expectations
BUG=skia:
Review URL: https://codereview.chromium.org/
163593004
git-svn-id: http://skia.googlecode.com/svn/trunk@13435
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 17:17:05 +0000 (17:17 +0000)]
rebaseline_server: create ImagePairSet-- holds a number of ImagePairs to examine
See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context
BUG=skia:1919
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
139343018
git-svn-id: http://skia.googlecode.com/svn/trunk@13434
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 17:16:56 +0000 (17:16 +0000)]
Bench rebaseline to use narrower ranges. This also tests the new range calculation algorithm.
BUG=skia:2163
R=robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
161563002
git-svn-id: http://skia.googlecode.com/svn/trunk@13433
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 17:14:46 +0000 (17:14 +0000)]
add peekPixels to SkCanvas and SkSurface
fix reference to SkBaseDevice, which was only a problem in no-gpu build
This reverts commit
4fa44a6bf73891b21917fb90d02beef9143bffa3.
R=reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
163603003
git-svn-id: http://skia.googlecode.com/svn/trunk@13432
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 16:00:58 +0000 (16:00 +0000)]
Add conicTo().
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
161223002
git-svn-id: http://skia.googlecode.com/svn/trunk@13431
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 16:00:51 +0000 (16:00 +0000)]
Add unit test for unbalanced save and restores in pictures.
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
150653010
git-svn-id: http://skia.googlecode.com/svn/trunk@13430
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 15:30:06 +0000 (15:30 +0000)]
Update directions and lib paths for ninja.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
161163003
git-svn-id: http://skia.googlecode.com/svn/trunk@13429
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Feb 2014 15:29:03 +0000 (15:29 +0000)]
Revert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org/
161733002/)
Reason for revert:
compile issues with gm/xfermodes3
Original issue's description:
> add peekPixels to SkCanvas and SkSurface
>
> clone of https://codereview.chromium.org/
159723006/
>
> Committed: https://code.google.com/p/skia/source/detail?r=13427
R=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
163823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13428
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Thu, 13 Feb 2014 15:11:11 +0000 (15:11 +0000)]
add peekPixels to SkCanvas and SkSurface
clone of https://codereview.chromium.org/
159723006/
Review URL: https://codereview.chromium.org/
161733002
git-svn-id: http://skia.googlecode.com/svn/trunk@13427
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Thu, 13 Feb 2014 14:41:43 +0000 (14:41 +0000)]
replace setConfig+allocPixels with single call
BUG=skia:
Review URL: https://codereview.chromium.org/
162643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13426
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 13 Feb 2014 14:24:59 +0000 (14:24 +0000)]
Updated GM expectations for Win7-ShuttleA-HD2000
BUG=skia:2167
Review URL: https://codereview.chromium.org/
163643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13425
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 13 Feb 2014 03:01:57 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13424
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Feb 2014 23:22:15 +0000 (23:22 +0000)]
Just a bit of cleanup. This doesn't alter the matrix/clip stack manager's behavior or its memory consumption.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
161143002
git-svn-id: http://skia.googlecode.com/svn/trunk@13423
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Feb 2014 18:33:56 +0000 (18:33 +0000)]
Empty expectations for bots affected by GM perspective switch
BUG=skia:2146
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
149123009
git-svn-id: http://skia.googlecode.com/svn/trunk@13422
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Feb 2014 17:44:30 +0000 (17:44 +0000)]
Revert of r13379 (Move fLastMoveToIndex from SkPath to SkPathRef - https://codereview.chromium.org/
146913002/) due to image quality regression in Chromium. See crbug.com/343123 (Regression - UI issue observed for any "Notification infobars" in Chrome browser)
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
137863006
git-svn-id: http://skia.googlecode.com/svn/trunk@13421
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Feb 2014 15:48:04 +0000 (15:48 +0000)]
This CL doesn't radically change the behavior of the matrix\clip stack reducer. It just cleans up the matrix handling a bit.
R=bsalomon@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
151033004
git-svn-id: http://skia.googlecode.com/svn/trunk@13420
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 12 Feb 2014 13:21:55 +0000 (13:21 +0000)]
remove width>=0 asserts, as clients rely on this (at least for testing)
git-svn-id: http://skia.googlecode.com/svn/trunk@13419
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 12 Feb 2014 03:02:04 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13418
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 12 Feb 2014 01:28:30 +0000 (01:28 +0000)]
remove unused deviceconfig from SkShader
git-svn-id: http://skia.googlecode.com/svn/trunk@13417
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 22:38:51 +0000 (22:38 +0000)]
Templetized SkWriter32 readTAt() & overwriteTAt()
Convert SkWriter32::{read,write}32At() to ::{read,overwrite}TAt<>() to allow
peeking/updating arbitrary records.
BUG=skia:
R=mtklein@google.com, reed@google.com, robertphillips@google.com, iancottrell@chromium.org
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
130913018
git-svn-id: http://skia.googlecode.com/svn/trunk@13416
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 21:16:29 +0000 (21:16 +0000)]
Adding new 'extend' mode to SkPath::addPath
BUG=261727
R=reed@google.com, caryclark@google.com, schenney@chromium.org, robertphillips@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
151353006
git-svn-id: http://skia.googlecode.com/svn/trunk@13415
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 20:27:05 +0000 (20:27 +0000)]
Update Mac 10.6 bench expectation for tabl_worldjournal.
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
141133009
git-svn-id: http://skia.googlecode.com/svn/trunk@13414
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 18:24:25 +0000 (18:24 +0000)]
Add dev bounds to bmp txt context, use bounds to ignore clips
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
144283004
git-svn-id: http://skia.googlecode.com/svn/trunk@13413
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 18:22:04 +0000 (18:22 +0000)]
Reland SkWriter32 growth change with build fixes.
- SkSWriter32 resets itself with its stack block;
- Track the full capacity of fInternal (which may be >size after a reset).
BUG=skia:2125
R=reed@google.com, iancottrell@chromium.org, iancottrell@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
158953003
git-svn-id: http://skia.googlecode.com/svn/trunk@13412
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 18:21:45 +0000 (18:21 +0000)]
SkBitmap now really stores SkImageInfo -- config is just a ruse
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
159653004
git-svn-id: http://skia.googlecode.com/svn/trunk@13411
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 18:21:26 +0000 (18:21 +0000)]
Add the perceptual difference metric to the rebaseline server
* Finds the location of the skpdiff binary.
* Calculates the perceptual difference percentage using the skpdiff binary (treats -1 as 0% perceptual similarity).
* Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
BUG=skia:2019
NOTRY=true
Committed: http://code.google.com/p/skia/source/detail?r=13398
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
147453003
git-svn-id: http://skia.googlecode.com/svn/trunk@13410
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 11 Feb 2014 16:30:21 +0000 (16:30 +0000)]
Revert of r13384 (Stateful PathRenderer implementation)
https://codereview.chromium.org/
142543007/
git-svn-id: http://skia.googlecode.com/svn/trunk@13409
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 11 Feb 2014 16:29:39 +0000 (16:29 +0000)]
bugfix for typo in skpdiff tool
Review URL: https://codereview.chromium.org/
154263008
git-svn-id: http://skia.googlecode.com/svn/trunk@13408
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 11 Feb 2014 16:22:58 +0000 (16:22 +0000)]
Return -1 in error condition instead of removing diff result.
BUG=skia:2160
R=epoger@google.com
Review URL: https://codereview.chromium.org/
145123013
git-svn-id: http://skia.googlecode.com/svn/trunk@13407
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 15:56:57 +0000 (15:56 +0000)]
Revert of Change growth function for SkWriter32 (https://codereview.chromium.org/
150663014/)
Reason for revert:
See https://codereview.chromium.org/
152703007/.
Original issue's description:
> Change growth function for SkWriter32
>
> Add setCountExact to SkTDArray to allow external control of array growth.
> Use it to allow SkWriter to control the buffer growth pattern.
> Change buffer growth pattern to 1.5n+4096
>
> BUG=skia:2125
>
> Committed: http://code.google.com/p/skia/source/detail?r=13401
R=tomhudson@google.com, reed@google.com, iancottrell@google.com
TBR=iancottrell@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2125
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
132313013
git-svn-id: http://skia.googlecode.com/svn/trunk@13406
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 11 Feb 2014 15:51:36 +0000 (15:51 +0000)]
clang complaint fix
git-svn-id: http://skia.googlecode.com/svn/trunk@13405
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 11 Feb 2014 15:40:54 +0000 (15:40 +0000)]
Fix build
https://codereview.chromium.org/
159813002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13404
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 11 Feb 2014 15:23:21 +0000 (15:23 +0000)]
Fix valgrind suppressions
https://codereview.chromium.org/
158493004/
git-svn-id: http://skia.googlecode.com/svn/trunk@13403
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 11 Feb 2014 15:10:40 +0000 (15:10 +0000)]
Collapse matrix & clip stack in PictureRecord
https://codereview.chromium.org/
137093004/
git-svn-id: http://skia.googlecode.com/svn/trunk@13402
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 15:07:26 +0000 (15:07 +0000)]
Change growth function for SkWriter32
Add setCountExact to SkTDArray to allow external control of array growth.
Use it to allow SkWriter to control the buffer growth pattern.
Change buffer growth pattern to 1.5n+4096
BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
150663014
git-svn-id: http://skia.googlecode.com/svn/trunk@13401
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 13:57:15 +0000 (13:57 +0000)]
Whitespace change to test bugdroid links.
(SkipBuildbotRuns)
BUG=skia:2139
TBR=
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
142393004
git-svn-id: http://skia.googlecode.com/svn/trunk@13400
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 13:30:33 +0000 (13:30 +0000)]
Revert of Add the perceptual difference metric to the rebaseline server (https://codereview.chromium.org/
147453003/)
Reason for revert:
Caused failure in RunGmSelfTests:
http://108.170.219.160:10117/builders/Housekeeper-PerCommit/builds/154/steps/RunGmSelfTests/logs/stdio
Filed:
https://code.google.com/p/skia/issues/detail?id=2160
Original issue's description:
> Add the perceptual difference metric to the rebaseline server
>
> * Finds the location of the skpdiff binary.
> * Calculates the perceptual difference percentage using the skpdiff binary.
> * Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
>
> BUG=skia:2019
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=13398
R=epoger@google.com
TBR=epoger@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2019
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
131453017
git-svn-id: http://skia.googlecode.com/svn/trunk@13399
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 12:33:58 +0000 (12:33 +0000)]
Add the perceptual difference metric to the rebaseline server
* Finds the location of the skpdiff binary.
* Calculates the perceptual difference percentage using the skpdiff binary.
* Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
BUG=skia:2019
NOTRY=true
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
147453003
git-svn-id: http://skia.googlecode.com/svn/trunk@13398
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 11:18:12 +0000 (11:18 +0000)]
Fix broken debug build
BUG=skia:
R=tomhudson@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
143223005
git-svn-id: http://skia.googlecode.com/svn/trunk@13397
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 10:17:02 +0000 (10:17 +0000)]
Cleaner external buffer handling in SkWriter32
This unifies the internal and external buffer handling so that the difference only has to be noticed when growing.
Removing the branches from the common read and write cases gives a significant speedup.
BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
156683004
git-svn-id: http://skia.googlecode.com/svn/trunk@13396
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 11 Feb 2014 03:24:02 +0000 (03:24 +0000)]
Revert "SkBitmap now really stores SkImageInfo -- config is just a ruse"
BUG=skia:
Review URL: https://codereview.chromium.org/
147733004
git-svn-id: http://skia.googlecode.com/svn/trunk@13395
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 11 Feb 2014 03:10:54 +0000 (03:10 +0000)]
fix test for empty config
handle empty setconfig
BUG=skia:
Review URL: https://codereview.chromium.org/
159533002
git-svn-id: http://skia.googlecode.com/svn/trunk@13394
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 11 Feb 2014 03:02:13 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13393
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 11 Feb 2014 02:40:11 +0000 (02:40 +0000)]
fix warnings
BUG=skia:
Review URL: https://codereview.chromium.org/
153003005
git-svn-id: http://skia.googlecode.com/svn/trunk@13392
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 11 Feb 2014 02:20:17 +0000 (02:20 +0000)]
SkBitmap now really stores SkImageInfo -- config is just a ruse
(edited) clone of https://codereview.chromium.org/
159173004/
Review URL: https://codereview.chromium.org/
159463003
git-svn-id: http://skia.googlecode.com/svn/trunk@13391
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Feb 2014 01:38:30 +0000 (01:38 +0000)]
fix minor error between kStroke_PathAsRect and kFill_PathAsRect in SkPath::asRect
R=caryclark@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
138703008
git-svn-id: http://skia.googlecode.com/svn/trunk@13390
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 22:46:08 +0000 (22:46 +0000)]
Use SkToBool to fix a warning.
NOTRY=true
TBR=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
159333002
git-svn-id: http://skia.googlecode.com/svn/trunk@13389
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 22:03:21 +0000 (22:03 +0000)]
Allow buffered stream to work with an offset.
If the stream being buffered is buffered from somewhere other than
the start, the SkFrontBufferedStream needs to take that into account
when reporting its length.
R=djsollen@google.com, bungeman@google.com, reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
157103002
git-svn-id: http://skia.googlecode.com/svn/trunk@13388
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 19:58:49 +0000 (19:58 +0000)]
SkOnce in is_lcd_supported instead of hand rolled double-checked locking.
BUG=skia:
R=bungeman@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
155963003
git-svn-id: http://skia.googlecode.com/svn/trunk@13387
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 18:29:10 +0000 (18:29 +0000)]
SkPictureRecord: silently do nothing for non-drawable SkBitmaps.
BUG=skia:2135
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
154083004
git-svn-id: http://skia.googlecode.com/svn/trunk@13386
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 18:19:30 +0000 (18:19 +0000)]
rebaseline_server: add ImagePair class, a step towards new intermediate JSON schema
See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context
BUG=skia:1919
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
157593006
git-svn-id: http://skia.googlecode.com/svn/trunk@13385
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 10 Feb 2014 16:46:23 +0000 (16:46 +0000)]
Stateful PathRenderer implementation
https://codereview.chromium.org/
23926019/
git-svn-id: http://skia.googlecode.com/svn/trunk@13384
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 16:39:40 +0000 (16:39 +0000)]
DM: catch -r foo -w foo.
BUG=skia:
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
152223003
git-svn-id: http://skia.googlecode.com/svn/trunk@13383
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Feb 2014 15:43:29 +0000 (15:43 +0000)]
remove SK_SUPPORT_LEGACY_ONLOCKPIXELS completely
BUG=skia:
Review URL: https://codereview.chromium.org/
158893005
git-svn-id: http://skia.googlecode.com/svn/trunk@13382
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Feb 2014 15:01:05 +0000 (15:01 +0000)]
Split opts_check_arm.cpp into per-class files
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
157863003
git-svn-id: http://skia.googlecode.com/svn/trunk@13381
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 10 Feb 2014 14:58:45 +0000 (14:58 +0000)]
New Xoom baselines for imagefilter tests.
(The Xoom bots were asleep when I did the first round.)
BUG=skia:2150
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
153883005
git-svn-id: http://skia.googlecode.com/svn/trunk@13380
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 10 Feb 2014 13:51:32 +0000 (13:51 +0000)]
Move fLastMoveToIndex from SkPath to SkPathRef
https://codereview.chromium.org/
146913002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13379
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Sun, 9 Feb 2014 13:28:11 +0000 (13:28 +0000)]
Mark imagefiltersbase_gpu as ignore-failure on IntelRhb release. The color of one of the lines around test cases changes subtly between runs.
BUG=skia:2005
BUG=skia:2085
BUG=skia:2120
Review URL: https://codereview.chromium.org/
139443005
git-svn-id: http://skia.googlecode.com/svn/trunk@13378
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Sun, 9 Feb 2014 04:46:47 +0000 (04:46 +0000)]
Rebase files after recent GPU clipping changes
BUG=skia:2051
Review URL: https://codereview.chromium.org/
158443002
git-svn-id: http://skia.googlecode.com/svn/trunk@13377
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 9 Feb 2014 03:02:01 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13376
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 8 Feb 2014 19:31:05 +0000 (19:31 +0000)]
Specialize GrConvexPolyEffect for AA rects, use for AA clip rects.
BUG=skia:2051
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
140093004
git-svn-id: http://skia.googlecode.com/svn/trunk@13375
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Sat, 8 Feb 2014 04:52:01 +0000 (04:52 +0000)]
Rebaselines from gpu convex poly clip changes.
BUG=skia:2051
BUG=skia:2120
Review URL: https://codereview.chromium.org/
153163004
git-svn-id: http://skia.googlecode.com/svn/trunk@13374
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 22:39:01 +0000 (22:39 +0000)]
Add workaround for Xoom crashing after discard removed from shader.
R=robertphillips@google.com
TBR=robertphillips@google.com
BUG=skia:2149
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
133703016
git-svn-id: http://skia.googlecode.com/svn/trunk@13373
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 7 Feb 2014 21:21:14 +0000 (21:21 +0000)]
More bench rebaselines for new SKPs.
Review URL: https://codereview.chromium.org/
130633009
git-svn-id: http://skia.googlecode.com/svn/trunk@13372
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 21:13:11 +0000 (21:13 +0000)]
Make GMs aware of what tool they're being run in.
Add a saveLayer set of draws to convex_poly_clip and fix GPU bug where polygon clips don't account for the translation between clip and device space.
BUG=skia:2051
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
148283017
git-svn-id: http://skia.googlecode.com/svn/trunk@13371
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 7 Feb 2014 21:13:03 +0000 (21:13 +0000)]
Rebase canvas-state on N7
Review URL: https://codereview.chromium.org/
156533004
git-svn-id: http://skia.googlecode.com/svn/trunk@13370
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 19:39:57 +0000 (19:39 +0000)]
Drawing fake bold text, line and normal text made normal text bolder on PDF.
When PDF uses fake bold text, it uses stroke and fill for the
text. After that, line is drawn. It creates new ContextEntry which
GraphicStateEntry has 0 fTextScaleX. Since fTextScaleX is 0,
GraphicStackState::updateDrawingState() doesn't update text fill mode or
the PDF page. When the normal text is drawn, it reuse the line's
ContextEntry because GraphicStateEntry::compareInitialState() returns
true. However, since the reused GraphicsStateEntry's fTextScaleX is 0,
the text fill mode is not updated to fill, and the text is drawn in
stroke and fill mode.
When the fTextScaleX is changed, we should not reuse GraphicStateEntry
even if ether of fTextScaleX is 0.
BUG=skia:2132
R=reed@google.com, vandebo@chromium.org, bungeman@google.com
Author: yuki.sekiguchi@access-company.com
Review URL: https://codereview.chromium.org/
137923005
git-svn-id: http://skia.googlecode.com/svn/trunk@13369
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 7 Feb 2014 18:43:40 +0000 (18:43 +0000)]
Fix garbled Nexus7 bench expectations entry.
Review URL: https://codereview.chromium.org/
136953009
git-svn-id: http://skia.googlecode.com/svn/trunk@13368
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 18:41:49 +0000 (18:41 +0000)]
Create a common utility for finding and running binaries in out/
NOTRY=true
BUG=skia:2019
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
156173005
git-svn-id: http://skia.googlecode.com/svn/trunk@13367
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 18:21:59 +0000 (18:21 +0000)]
rebaseline_server: properly handle unexpected GETs
BUG=skia:2147
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
157773002
git-svn-id: http://skia.googlecode.com/svn/trunk@13366
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 7 Feb 2014 17:14:01 +0000 (17:14 +0000)]
Bench rebaseline for the new SKPs
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
156733003
git-svn-id: http://skia.googlecode.com/svn/trunk@13365
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Feb 2014 16:23:27 +0000 (16:23 +0000)]
remove unneeded SK_SUPPORT_LEGACY_NEWRENDERTARGETDIRECT
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
141063004
git-svn-id: http://skia.googlecode.com/svn/trunk@13364
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Feb 2014 16:09:26 +0000 (16:09 +0000)]
remove unneeded SK_SUPPORT_LEGACY_CANVAS_CREATECOMPATIBLEDEVICE
git-svn-id: http://skia.googlecode.com/svn/trunk@13363
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Feb 2014 16:02:41 +0000 (16:02 +0000)]
remove legacy LightingColorFilter impl
TBR:djsollen
Review URL: https://codereview.chromium.org/
151353005
git-svn-id: http://skia.googlecode.com/svn/trunk@13362
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 14:04:48 +0000 (14:04 +0000)]
Set scissor to clip bounding box when using GrConvexPolyEffect
BUG=skia:2051
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
156843005
git-svn-id: http://skia.googlecode.com/svn/trunk@13361
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 13:55:57 +0000 (13:55 +0000)]
Fix android build issues with atomics
Uses inline methods for sk_atomic_inc/add/dec instead of #define.
Since those methods are declared as static in SkThread.h, they need
a definition or else the compiler generates an error. Also corrects
a typo.
BUG=skia:
R=djsollen@google.com, bungeman@google.com, bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
148113010
git-svn-id: http://skia.googlecode.com/svn/trunk@13360
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 13:29:21 +0000 (13:29 +0000)]
Whitespace change to test Bugdroid II
(SkipBuildbotRuns)
TBR=
NOTRY=true
BUG=skia:2139
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
144713009
git-svn-id: http://skia.googlecode.com/svn/trunk@13359
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 13:27:59 +0000 (13:27 +0000)]
Whitespace change to test Bugdroid
(SkipBuildbotRuns)
TBR=
NOTRY=true
BUG=2139
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
157393003
git-svn-id: http://skia.googlecode.com/svn/trunk@13358
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Feb 2014 12:20:04 +0000 (12:20 +0000)]
Revert of Revert "Serialization of SkPictureImageFilter" (https://codereview.chromium.org/
153583007/)
Reason for revert:
New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22
Original issue's description:
> Revert "Serialization of SkPictureImageFilter"
>
> This reverts commit
227321b30106e57942929eb96fa5bc22544f6c9e.
>
> Revert "Sanitizing source files in Housekeeper-Nightly"
>
> This reverts commit
baf28584b7636c01355f8d8d972e06aa7fb66d77.
>
> TBR=robertphillips@google.com,sugoi@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13356
R=robertphillips@google.com, sugoi@google.com, fmalita@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, fmalita@google.com, robertphillips@google.com, sugoi@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
143163005
git-svn-id: http://skia.googlecode.com/svn/trunk@13357
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 7 Feb 2014 05:55:39 +0000 (05:55 +0000)]
Revert "Serialization of SkPictureImageFilter"
This reverts commit
227321b30106e57942929eb96fa5bc22544f6c9e.
Revert "Sanitizing source files in Housekeeper-Nightly"
This reverts commit
baf28584b7636c01355f8d8d972e06aa7fb66d77.
TBR=robertphillips@google.com,sugoi@google.com
Review URL: https://codereview.chromium.org/
153583007
git-svn-id: http://skia.googlecode.com/svn/trunk@13356
2bbb7eff-a529-9590-31e7-
b0007b416f81