profile/ivi/qtbase.git
12 years agodon't rely on $PATH for finding rcc
Oswald Buddenhagen [Thu, 23 Feb 2012 13:46:08 +0000 (14:46 +0100)]
don't rely on $PATH for finding rcc

Change-Id: I7e6ffad6d84cca0b548920b3e620375fb5e314e9
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agoremove over-uses of $$list()
Oswald Buddenhagen [Tue, 21 Feb 2012 20:41:28 +0000 (21:41 +0100)]
remove over-uses of $$list()

not sure why anyone would do *that* ...

Change-Id: Id91e9e8bd602a9d9275ade2ca86aaa4f4698ff72
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agoavoid using infile() needlessly
Oswald Buddenhagen [Tue, 21 Feb 2012 20:30:57 +0000 (21:30 +0100)]
avoid using infile() needlessly

it's rather pointless to first query the variable's presence in the
file. instead, just fetch it and see what is in there.

for this to work cleanly we defer the concatenation of the filename.

Change-Id: I322db8ae897272fae049074d8b7676787286aedd
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agoFix tst_qmenu.
Debao Zhang [Fri, 24 Feb 2012 21:46:33 +0000 (13:46 -0800)]
Fix tst_qmenu.

Clear away Q_WS_WIN/Q_WS_X11 from QMenu. Using the hint returned by the
QPlatformTheme.

Task-number: QTBUG-24325
Change-Id: Iaa4da26c74273d7cfc1fbec6519c52d09e10f7bb
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoQClipboard: Fix autotest fails
Debao Zhang [Fri, 24 Feb 2012 18:51:18 +0000 (10:51 -0800)]
QClipboard: Fix autotest fails

tst_qclipboard.cpp still has Q_WS_WIN which must be clear away. After
clean up, auto test will fail under windows: When setMimeData() is
called, dataChanged() signal will be emited twice.

The solution for QTBUG-24184 has partially solved the problem, but it
still there. Make sure emitChanged() only called by QPlatformClipboard
will give our more control for this.

Task-number: QTBUG-24484
Change-Id: I23566c6d3b32828b6865234c311af3635fe9e299
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agodon't generate bogus TARGETs
Oswald Buddenhagen [Fri, 24 Feb 2012 08:10:52 +0000 (09:10 +0100)]
don't generate bogus TARGETs

Change-Id: Ia99cd8862157e5630506d02b3c7e9b35d4bc3302
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agobump version of QMAKE_TARGET_PRODUCT
Oswald Buddenhagen [Fri, 24 Feb 2012 18:08:13 +0000 (19:08 +0100)]
bump version of QMAKE_TARGET_PRODUCT

... whatever that may be good for

Change-Id: I06695a06aae52386236a7a31fe7865cc8389d3b9
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agoFix QThreadstorage test.
Friedemann Kleint [Mon, 27 Feb 2012 10:09:27 +0000 (11:09 +0100)]
Fix QThreadstorage test.

- Create subdirectories containing profiles to avoid
  problems with -fast.
- Use QFINDTESTDATA to locate binary.
- Make it a console application, no Mac-bundle.
- Add error messages to the test, give it a longer time-out
  and ensure sub-process is killed if it hangs.

Change-Id: Ibc177b786c4bc8fdbc068a8c45f4801a41c9f660
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
12 years agoFix icon loading in style sheets.
Friedemann Kleint [Mon, 27 Feb 2012 11:38:04 +0000 (12:38 +0100)]
Fix icon loading in style sheets.

QIcon was moved to QtWidgets, while the parser is still in QtGui.
Introduce a QCss::IconValue struct that contains the icon data
and convert to QIcon in widgets.

Change-Id: I09ac8a12a4b02bdca91ee2e8fcc28c86b5a001e7
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoQtTest: add missing \since 5.0 to the new macros
David Faure [Fri, 24 Feb 2012 14:17:23 +0000 (15:17 +0100)]
QtTest: add missing \since 5.0 to the new macros

Change-Id: I8f7060c41df1e0bf1a8c35930400a31a4239a3d6
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoFix inconsistent auto test executable names
David Faure [Sun, 26 Feb 2012 09:51:52 +0000 (10:51 +0100)]
Fix inconsistent auto test executable names

Change-Id: I3b6b5b37e32be25d1b9933395c43f6d5aa5b8810
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoQRegExp: fix crash
Giuseppe D'Angelo [Sun, 26 Feb 2012 01:45:53 +0000 (01:45 +0000)]
QRegExp: fix crash

Fixes a crash when invoking various QRegExp methods on an object
*before* doing any match. For instance fixes:
  QRegExp re;
  re.matchedLength(); // crash

Task-number: QTBUG-23352
Change-Id: I9c239ff790a139c7820ef1aeced89d31320ae6b0
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoremove library version matching from qt.conf
Oswald Buddenhagen [Fri, 24 Feb 2012 21:12:18 +0000 (22:12 +0100)]
remove library version matching from qt.conf

this feature was introduced in feb 2005 by Sam with this comment:
> I have implemented a versioning into the keys and do environment
> expansion there as well, these aren't immediately usefull but Marius
> and I agreed that distributors will probably want such features at
> times. The versioning fallbacks will be usefull to us over time no
> doubt.

imo the versioning is a contestant for the most useless feature ever:
- (linux) distributors couldn't care less - they simply configure qtcore
  correctly. additionally, the packaging policies state that no config
  files should live in the binary dir at all, so no qt.conf for them.
- ISVs don't care, because they ship their software with a particular qt
  version anyway.
- SDK distributors don't care, because it doesn't solve any real problem
  for them: a) they will isolate the (qmake) versions and b) a
  distinction based on version number (as opposed to build
  configuration) is utterly useless in the first place.

i left in the variable expansion, as it could at least theoretically be
useful for creating relocatable packages. debatable - the file it easy
enough to modify at installation time.

Change-Id: Ida8a50b16d55d8d8613d1a98a51df56753f6a6e3
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoUse new plugin system in qtbase.
Friedemann Kleint [Thu, 23 Feb 2012 11:26:10 +0000 (12:26 +0100)]
Use new plugin system in qtbase.

- AccessibleWidgets
- Windows printer support
- Examples

Change-Id: Icc162bd7fc284b3c76d9966210f983728085c743
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoSimplify QMetaTypeSwitcher.
Jędrzej Nowacki [Fri, 24 Feb 2012 13:27:01 +0000 (14:27 +0100)]
Simplify QMetaTypeSwitcher.

We do not need to distinguish between different types in the switcher.

Before this patch it was not possible to overload
DelegateObject::delegate with a pointer type. Now it is fixed.

Change-Id: Icd73a53e73e5e66b1b6f6407ba4e0f79e584d930
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoOptimize space for the QEventLoopQuitLocker.
Stephen Kelly [Thu, 23 Feb 2012 11:59:21 +0000 (12:59 +0100)]
Optimize space for the QEventLoopQuitLocker.

Use a union and a type enum instead of three pointers.

Change-Id: I02b11733a4f2e95099064fa9325497d4e04ac615
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoReduce QtCore lib binary size by around ~3KB, by removing template code
Jędrzej Nowacki [Fri, 10 Feb 2012 08:14:41 +0000 (09:14 +0100)]
Reduce QtCore lib binary size by around ~3KB, by removing template code

Reusing a template is much better then creating a new one, even if it
should inline the same code.

For some reason replacing T* by void* force gcc to remove a few bytes
per template instantiation too, it is not really significant, but it
alows us to simplify the code.

Benchmarks don't show any regressions.

Change-Id: I4fdf1e4dc311b23021eb5758605602937d05b183
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoFix selftests while using QStringBuilder
Olivier Goffart [Sat, 25 Feb 2012 16:54:00 +0000 (17:54 +0100)]
Fix selftests while using QStringBuilder

Change-Id: I6dcd830b96023765447c9683fd95209d4312fb1b
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoRemove deprecated usage of QKeySequence from qguivariant
Olivier Goffart [Sat, 25 Feb 2012 10:42:57 +0000 (11:42 +0100)]
Remove deprecated usage of QKeySequence from qguivariant

The implicit conversion operators are deprecated.

Change-Id: I0e94c0671413da1ab58c6c7b8bb31614e2696409
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoRemove usage of deprecated QAbstractItemModel::setRoleNames
Olivier Goffart [Sat, 25 Feb 2012 20:27:03 +0000 (21:27 +0100)]
Remove usage of deprecated QAbstractItemModel::setRoleNames

Change-Id: If41bf0d6d50969156269c67a15e006d38edc8e1f
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoDon't use deprecated QAbstractItemModel::reset()
Olivier Goffart [Sun, 26 Feb 2012 09:54:07 +0000 (10:54 +0100)]
Don't use deprecated QAbstractItemModel::reset()

Change-Id: Idf9971668a372a12ba319d954c35e157d8a08bd1
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoCleanup usage of QVariant::Type.
Jędrzej Nowacki [Fri, 10 Feb 2012 11:21:25 +0000 (12:21 +0100)]
Cleanup usage of QVariant::Type.

QVariant::Type is marked as obsolete. It is not possible to get rid of
it completely, in a source compatible way, but at least we can remove it
safely from a method arguments list.

Change-Id: I26b58099bfa6d32f3a583a8ae0047f0bb36bcd0d
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRemove more support for unsupported GCC versions.
Stephen Kelly [Wed, 22 Feb 2012 13:49:13 +0000 (14:49 +0100)]
Remove more support for unsupported GCC versions.

Change-Id: I827c9f982a7d7d20913b99c8fdaf98437a0a73db
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoSkip unstable qlineedit autotest on Ubuntu 11.10.
Toby Tomkins [Mon, 27 Feb 2012 03:26:56 +0000 (13:26 +1000)]
Skip unstable qlineedit autotest on Ubuntu 11.10.

Task-number: QTBUG-24518

Change-Id: Ia271a820613c1f8a885779eddd20e261716afc6d
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoqfiledialog2: Skip test that is passing on CI and failing otherwise.
Toby Tomkins [Fri, 24 Feb 2012 07:16:32 +0000 (17:16 +1000)]
qfiledialog2: Skip test that is passing on CI and failing otherwise.

Task-number: QTBUG-23602

Change-Id: Id5dfb85956048c60849d865161212b0764e8f250
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoChanged qnetworkreply unittest to return correct code
Kurt Korbatits [Tue, 21 Feb 2012 03:54:11 +0000 (13:54 +1000)]
Changed qnetworkreply unittest to return correct code

- Changed waitForFinished() to return correct return code

Change-Id: Ic6b0dfa195254783a2106011c4a108d907d73557
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoQFlags<>: let the compiler generate copy ctor/op=
Marc Mutz [Fri, 24 Feb 2012 16:33:25 +0000 (17:33 +0100)]
QFlags<>: let the compiler generate copy ctor/op=

The user-defined copy constructor and
copy-assignment operators were 100% equivalent
to the ones the compiler would generate, so
let the compiler generate them (so we reap
move constructors, too, even though they're
not needed on this class).

Change-Id: Iecdd579fa5a819d083ec9b2f25734ddba85515e6
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoremove fallback re-initialization of TARGET after parsing project
Oswald Buddenhagen [Thu, 2 Feb 2012 17:11:16 +0000 (18:11 +0100)]
remove fallback re-initialization of TARGET after parsing project

we already initialize it before parsing a project. if a project is daft
enough to clear TARGET, it does not deserve differently than breaking.

Change-Id: I6c727bc27d72a00e84b676ae3c169024bdb2d929
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agoRemoveRef should not remove the const
Olivier Goffart [Sat, 25 Feb 2012 09:39:34 +0000 (10:39 +0100)]
RemoveRef should not remove the const

This does not fix anything, because AreArgumentsCompatible already
do all the type checks.
But it make RemoveRef consistant with std::remove_reference

Change-Id: Ic42c872356172d7f5ea10de050254b5d10e50a6e
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQFixed: make constexpr
Marc Mutz [Wed, 22 Feb 2012 14:27:40 +0000 (15:27 +0100)]
QFixed: make constexpr

Make most QFixed{,Size,Point} members constexpr.
See f3141c58badbd2da9eb42021e9704742c3e52a9b for rationale.

Change-Id: I0b44f59bb768e1f79c57e1c9a0dc67afb515e03f
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoQFixed{,Size}: reformulate some functions in a constexpr-friendly way
Marc Mutz [Wed, 22 Feb 2012 14:18:27 +0000 (15:18 +0100)]
QFixed{,Size}: reformulate some functions in a constexpr-friendly way

The main change is the addition of a new constructor
that passes its argument into 'val' verbatim. In order
to disambiguate it from the existing QFixed(int)
constructor, it takes a second 'int' argument. This
is too ugly for public API, so it's private, and only
used by static QFixed fromFixed(int), which is the
existing named constructor with the same semantics.

The rest of the changes simply reformulate their
operations in terms of fromFixed().

This makes them ready to be constexpr'ed.

Change-Id: I2a3813d62bd4124064755de6b00526a60fc82c1d
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agouic: remove unused QRegExp #includes
Giuseppe D'Angelo [Sun, 26 Feb 2012 03:11:19 +0000 (03:11 +0000)]
uic: remove unused QRegExp #includes

QRegExp is not used, so they're unnecessary.

Change-Id: I3480bcbe013a0bf15e2ee4fa30862fe035820eea
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQPrinterInfo: remove unused variable
Marc Mutz [Tue, 21 Feb 2012 12:41:53 +0000 (13:41 +0100)]
QPrinterInfo: remove unused variable

Change-Id: I1a3db07e7fe25066a6b13ca41854566ccb1298df
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoRemove usage of deprecated QRect::unite
Olivier Goffart [Sun, 26 Feb 2012 10:00:44 +0000 (11:00 +0100)]
Remove usage of deprecated QRect::unite

Change-Id: I1920da995fde6ff2a8b2e3facddeee6e3c17b44c
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoFix doc according to current method signature
ABBAPOH [Sun, 26 Feb 2012 07:48:53 +0000 (11:48 +0400)]
Fix doc according to current method signature

Change-Id: I23d0f7a88f4c092c1e7cd2742fdf6e6f68ad485a
Reviewed-by: David Faure <faure@kde.org>
12 years agoFix compilation of examples with QStringBuilder
Olivier Goffart [Sat, 25 Feb 2012 18:23:06 +0000 (19:23 +0100)]
Fix compilation of examples with QStringBuilder

In sub-attack an interview, one can't make two implicit conversions at
once, so explicitly convert to the right type.

The change in the torrent example is required because of
https://codereview.qt-project.org/16168 (commit 9491272)
But in that case, using a QByteArray is better anyway.

Change-Id: Ieed22ac7f0d700d5ba5d1e70af3db4dd6c139c8f
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoQSslError: fix wrong #endif placement
Marc Mutz [Fri, 24 Feb 2012 18:19:32 +0000 (19:19 +0100)]
QSslError: fix wrong #endif placement

This would break a namespaced Qt when QT_NO_DEBUG_STREAM
was in effect. Unlikely to hit, but nevertheless fixworthy.

Change-Id: Ie2a4cf4334a6a610c84233ab1ca89b928386c91a
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoFix MinGW configure bootstrap
Jonathan Liu [Fri, 24 Feb 2012 11:36:59 +0000 (22:36 +1100)]
Fix MinGW configure bootstrap

Makefile.mingw was using the test command which requires sh.exe. This
adds support for bootstrap using cmd.exe instead.

Change-Id: Ieb67843170d2745ce119cc8feaa5433aa82fd7d7
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoprocess variable assignments with tabs as well
Oswald Buddenhagen [Sat, 25 Feb 2012 12:48:49 +0000 (13:48 +0100)]
process variable assignments with tabs as well

Change-Id: If3caa4094aa9d8caefc9829bfea44426d59477d1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoconfigure - fix detection of MSVC compiler in x64
Shane Kearns [Fri, 24 Feb 2012 14:56:44 +0000 (14:56 +0000)]
configure - fix detection of MSVC compiler in x64

x86 processes get redirected to the 32 bit area of the registry,
while 64 bit processes access the registry in raw form.
Added the registry paths for 64 bit processes to see the 32 bit
registry keys for MS visual studio. (Wow6432Node)

This problem was revealed when we stopped including configure.exe
as a binary checkin to git. Running configure in an x64 compiler
environment results in creating an x64 configure.exe

Change-Id: I5e3e51ddbf20ccc65abf1833bf23ee5670bd973e
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoFix a crash in QSystemLocalePrivate::uiLanguages().
Friedemann Kleint [Fri, 24 Feb 2012 14:18:15 +0000 (15:18 +0100)]
Fix a crash in QSystemLocalePrivate::uiLanguages().

Use the correct calling convention. Discovered by the mimetype
test in Qt 5.

Change-Id: I79b97325dd69466885a64c238935107bf14e9a0d
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
(cherry picked from commit bc6e35d94325f4b18caec7ce0824c5beab95cdd7)
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix compilation without QT_DEPRECATED_SINCE
Olivier Goffart [Sat, 25 Feb 2012 10:07:52 +0000 (11:07 +0100)]
Fix compilation without QT_DEPRECATED_SINCE

QAbstractItemModel::reset() is deprecated

Change-Id: I2d9aa9fade1660df14945ca11123341fce504050
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoImplement isSharing() and isValid() methods for QCocoaGLContext
Teemu Katajisto [Thu, 23 Feb 2012 14:50:29 +0000 (16:50 +0200)]
Implement isSharing() and isValid() methods for QCocoaGLContext

Shared resources may have been used when initializing NSOpenGLContext
but QCocoaGLContext did not implement isSharing(). This caused
default implementation to return false always and therefore shared
resource test case failed.

Implemented also another missing method, isValid().

Task-number: QTBUG-23061

Change-Id: Ia912450035b584ea90a02a7d88d6ae531c3cbadf
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoQFutureWatcher: Make constructors explicit
Marc Mutz [Mon, 20 Feb 2012 14:16:25 +0000 (15:16 +0100)]
QFutureWatcher: Make constructors explicit

Change-Id: I363665725869993b10985004c1c6441ded435dbc
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoFix to exit of adopted thread watcher in Windows
jian liang [Sat, 18 Feb 2012 00:43:29 +0000 (08:43 +0800)]
Fix to exit of adopted thread watcher in Windows

Don't register the thread handle and QThread object pointer to watch list
for adopted thread watcher thread in Windows. Otherwise the watcher thread
will never exit and can't clean up its own QThreadData and QAdoptedThread
object.

Task-number: QTBUG-23961

Change-Id: Ia84326cf3cfd978d2b003ccc1bb6861db950e899
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agocompile fix: parse under C++11
Marc Mutz [Thu, 23 Feb 2012 11:24:49 +0000 (12:24 +0100)]
compile fix: parse under C++11

See d94ab97b7741de7c73d4d203b9cca7bd150d581f for details.

Change-Id: Ifc015be6575bd8f469f257d71fbbf79e07226729
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
12 years agoexamples: compile w/o opengl
Marc Mutz [Thu, 23 Feb 2012 06:26:29 +0000 (07:26 +0100)]
examples: compile w/o opengl

Fixes remnants of an automated QtGui -> QtWidgets port.

Change-Id: I31f63bdd6ae71aee8e70b20e24def30e0eafb725
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoUse new plugin system for SQL drivers.
Friedemann Kleint [Thu, 23 Feb 2012 14:18:35 +0000 (15:18 +0100)]
Use new plugin system for SQL drivers.

Change-Id: I1d4db9ecc7e1cbca66674d13748070f4b19d5b8c
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoUse new plugin system for network bearer plugins.
Friedemann Kleint [Thu, 23 Feb 2012 12:13:29 +0000 (13:13 +0100)]
Use new plugin system for network bearer plugins.

Change-Id: Ic4a28d379033518f75d0e3e449ddf012109ed9ea
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agorcc: micro-optimization
Marc Mutz [Wed, 22 Feb 2012 15:40:58 +0000 (16:40 +0100)]
rcc: micro-optimization

Declare a char array instead of a pointer variable.

Change-Id: I2beff815d05b6dc9c35bb0a55d7294189afbf17e
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoFix tst_qlineedit.
Friedemann Kleint [Thu, 23 Feb 2012 16:27:47 +0000 (17:27 +0100)]
Fix tst_qlineedit.

- Fix key handling in QWidgetLineControl according to
  the keyboard scheme returned by the QPlatformTheme,
  remove #ifdefs.
- Do the same in the test.

Task-number: QTBUG-21402

Change-Id: I36d836584e7122309061af72819a4147cadd0a74
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoAdd TARGET_VERSION_EXT to pkgConfiglibName
Hib Eris [Thu, 9 Feb 2012 09:03:15 +0000 (10:03 +0100)]
Add TARGET_VERSION_EXT to pkgConfiglibName

The libName that is used in pkgConfig files should include the
TARGET_VERSION_EXT.

This is needed because in Win32MakefileGenerator::fixTargetExt(),
the TARGET_VERSION_EXT is added to the library name.

In Win32MakefileGenerator::processVars(), if TARGET_VERSION_EXT is empty,
it is set to VER_MAJ.

On platforms != Windows, TARGET_VERSION_EXT does not seem to be used.

We probably got away with this so far because pkgconfig files generation
for win32 was just added in 4.8 and nobody uses them yet, and because on
platforms != windows the TARGET_VERSION_EXT is not used.

Change-Id: I56f239e389f0ef926030e4c2376cadd92c4f673c
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoqmimetypeparser: more optimized definition of string constants
David Faure [Thu, 23 Feb 2012 17:56:12 +0000 (18:56 +0100)]
qmimetypeparser: more optimized definition of string constants

Change-Id: I0cbc0fef63814ab037bea66ab35b3aa8b6ec800c
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoRemove unused toolTip member variable (qt3 leftover)
David Faure [Tue, 21 Feb 2012 10:21:06 +0000 (11:21 +0100)]
Remove unused toolTip member variable (qt3 leftover)

Change-Id: Ia68fb00afb81a0f521f9fbc3f0dbfc7e43075bbe
Reviewed-by: laurent montel <laurent.montel@kdab.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoQHeaderView - fix setOffsetToSectionPosition a bit
Thorbjørn Lund Martsum [Sun, 12 Feb 2012 20:11:04 +0000 (21:11 +0100)]
QHeaderView - fix setOffsetToSectionPosition a bit

It might be silly to have sections with size 0 without using hideSection.
Nevertheless we should still use the principle of least surprise.

It does not make sense that hiding a row 'far' away should affect
the semantics of setOffsetToSectionPosition on lower indexes.

Change-Id: Iaf847eba2ea4d28fc7bcfe3a27d62f432f6f61e0
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoQWheelEvent high-resolution delta support.
Morten Johan Sorvig [Mon, 9 Jan 2012 10:25:40 +0000 (11:25 +0100)]
QWheelEvent high-resolution delta support.

Support pixel-based deltas as well as sending
dx and dy values in the same event. Keep source and
behavior compatibility with Qt 4.

New API:
QPoint pixelDelta() const
QPoint angleDelta() const

Deprecate delta() and orientation().

Both pixel-based deltas and combined updates are
necessary for smooth trackpad-based scrolling on
OS X.

Qt 4 compatible behavior is achieved by sending an
extra wheel event in cases where the initial event
has a combined dx and dy update. This extra event
sends dx in delta() and orientation(), with pixelDelta()
and angleDelta() set to null.

Modify the Cocoa implementation to provide pixel
deltas. It is expected that not all platforms can
provide these. Angle deltas will always be available.

Change-Id: I20c10f0df338ddcd6a3f7a4d40949ed5ae3b4795
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoQHeaderView - change not needed if to Q_ASSERT
Thorbjørn Lund Martsum [Thu, 23 Feb 2012 08:56:12 +0000 (09:56 +0100)]
QHeaderView - change not needed if to Q_ASSERT

This removes an if that should always be false. If it isn't
false we had more logical indexes than sections.

Unless visualIndices and logicalIndices are both 0-sized
(meaning that visual and logical indexes are the same)
then they better have exactly as many indexes as sectionCount.
Otherwise there must be inconsistent data - some logicalindex
would refer to non-existing visual sections or some
visualindeces wouldn't be hit by logicalIndices.

Change-Id: I2dc92f40895438d912bba20612131baf63df4fbe
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoQMimeMagicRule: declare as Q_MOVABLE_TYPE
Marc Mutz [Fri, 24 Feb 2012 12:21:26 +0000 (13:21 +0100)]
QMimeMagicRule: declare as Q_MOVABLE_TYPE

Change-Id: I3725696e7369eb59eeb08095ffe0b8aa7537b4f3
Reviewed-by: David Faure <faure@kde.org>
12 years agoMinor fixes for RelationFlag.
Jan-Arve Saether [Mon, 20 Feb 2012 14:00:47 +0000 (15:00 +0100)]
Minor fixes for RelationFlag.

* Document AllRelations
* Assigned new values (starting from 1) for the remaining members of
  the enum.

Change-Id: I55ec197f24ff7d43ff3c0d101edd33b9615f9287
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoRemove unused QT_NO_QWS_SHARE_FONTS
Stephen Kelly [Wed, 22 Feb 2012 23:48:54 +0000 (00:48 +0100)]
Remove unused QT_NO_QWS_SHARE_FONTS

Change-Id: I47e8111d6caffd9b45096e52695acaa55945c612
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoRemove QT_NO_QWS_MULTIPROCESS
Stephen Kelly [Wed, 22 Feb 2012 23:47:54 +0000 (00:47 +0100)]
Remove QT_NO_QWS_MULTIPROCESS

Change-Id: I1d6731dc5268919d0c36d5d27285321742be708f
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoRemove unused define QT_NO_COP.
Stephen Kelly [Wed, 22 Feb 2012 23:45:22 +0000 (00:45 +0100)]
Remove unused define QT_NO_COP.

It used to relate to QCop and QWS, which are no more.

Change-Id: Ie70c64a3a6ef60664009108b79eed7f33ea59f32
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoFix the library names on MinGW.
Stephen Kelly [Thu, 23 Feb 2012 17:25:28 +0000 (18:25 +0100)]
Fix the library names on MinGW.

Change-Id: I6c2008a0e7a07ca0603b8aa9362d31fa4ef7310a
Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoFix Windows -no-freetype build
Jonathan Liu [Fri, 24 Feb 2012 12:03:49 +0000 (23:03 +1100)]
Fix Windows -no-freetype build

The localizedName and getEnglishName functions were defined in
qwindowsfontdatabase_ft.cpp but used in qwindowsfontdatabase.cpp.
However if -no-freetype is specified during configure then
qwindowsfontdatabase_ft.cpp is not compiled which results in an
undefined reference. To resolve this, the functions are moved to
qwindowsfontdatabase.cpp which is always compiled whether -no-freetype
is specified or not.

Change-Id: I085d84cecb29065ba5e6495b52eef7a678947bdc
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
12 years agoCreate target pkgconfig dir in qmake generated Windows Makefiles
Hib Eris [Tue, 7 Feb 2012 14:28:55 +0000 (15:28 +0100)]
Create target pkgconfig dir in qmake generated Windows Makefiles

Change-Id: Icea70987ee3c6040ca3ba278a578849cb74156f4
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoAdd UDev helper class for evdev plugins
Johannes Zellner [Tue, 14 Feb 2012 12:09:46 +0000 (13:09 +0100)]
Add UDev helper class for evdev plugins

Adopt evdevkeyboard plugin to use new UDev helper

Change-Id: Ie914c77dde9a28a8cf7f7cd972acd963c13bc698
Reviewed-by: Laszlo Agocs <laszlo.p.agocs@nokia.com>
12 years agoUse "OpenGL" instead of just "GL" in documentation.
Samuel Rødal [Tue, 21 Feb 2012 12:24:39 +0000 (13:24 +0100)]
Use "OpenGL" instead of just "GL" in documentation.

Change-Id: I81a0beebc0241b9699ce321174e13a93e76e45e8
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoXCB No longer lists ThreadedOpenGL capability
Alan Alpert [Fri, 24 Feb 2012 08:30:40 +0000 (18:30 +1000)]
XCB No longer lists ThreadedOpenGL capability

Even with the more recent libxcb, it's a bit flaky. Just don't list
having this capability until it is more stable.

Change-Id: I1c2b39d757803fc23295944bc9a00e39ff4e1bbf
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoClean up some Q_WS_WIN
Debao Zhang [Wed, 22 Feb 2012 19:41:28 +0000 (11:41 -0800)]
Clean up some Q_WS_WIN

Q_WS_WIN does not exist any more.

Change-Id: Icb7f542cfcd4d21e994f246ff665583cb6b57610
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoCodeCoverage: Skip headersclean test.
Caroline Chao [Thu, 23 Feb 2012 09:41:50 +0000 (10:41 +0100)]
CodeCoverage: Skip headersclean test.

The code coverage tool adds #line when instrumenting the code using the gcc
syntax.

Since tst_headersclean now uses the -pedantic-errors flag (qtbase commit
7e970eb58c71dc089815), it causes a fatal error when the code is
instrumented with the coverage tool.

Change-Id: Icb1888d1c1f0a982c0c56aa168e70a76a246a18c
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoclean up qmake-generated projects
Oswald Buddenhagen [Tue, 21 Feb 2012 15:09:30 +0000 (16:09 +0100)]
clean up qmake-generated projects

remove "header" and assignmets which are defaults or bogus,
reorder some assignments.

Change-Id: I67403872168c890ca3b696753ceb01c605d19be7
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoReverted part of "Refactor input context tests"
Pekka Vuorela [Thu, 23 Feb 2012 13:49:11 +0000 (15:49 +0200)]
Reverted part of "Refactor input context tests"

This commit reverts partly 7401832a7d45de99562b94340375393a39267f41

There is something wrong with DummyWindow/XCB/Metacity, Metacity
crashes quite often when QWindow is activated.

Change-Id: I611af2678814f41c941cb697054135f561a77878
Reviewed-by: Joona Petrell <joona.t.petrell@nokia.com>
12 years agoAdd the QtMain windows library to the CMake files.
Stephen Kelly [Thu, 23 Feb 2012 16:05:41 +0000 (17:05 +0100)]
Add the QtMain windows library to the CMake files.

Change-Id: Iff8b9bdd4b069721103e1cd5854e56b6116d7549
Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoQSqlTableModel: rename parameter to avoid name clash with method
Mark Brand [Wed, 15 Feb 2012 00:31:07 +0000 (01:31 +0100)]
QSqlTableModel: rename parameter to avoid name clash with method

Change-Id: Ib8fa6b0ca71ffdd9f1f8416c448b5c830988ed08
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoQSqlTableModel: avoid extra QMap lookup
Mark Brand [Wed, 15 Feb 2012 09:22:15 +0000 (10:22 +0100)]
QSqlTableModel: avoid extra QMap lookup

The consensus on #qt-labs seems to be that there is little or no
point in checking with contains() before using value(), even if
the map does not contain the key in most cases.

Change-Id: I34740a91d5c3af65e20937a5ae3b4bab32406440
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agofix style
Mark Brand [Wed, 15 Feb 2012 14:05:28 +0000 (15:05 +0100)]
fix style

Change-Id: I8ad0b4d15484662be7b38daa797a688727377c88
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoQSqlTableModel: document edit strategy behavior
Mark Brand [Thu, 16 Feb 2012 13:21:07 +0000 (14:21 +0100)]
QSqlTableModel: document edit strategy behavior

Change-Id: Ib674288e950837aa343cf1206ed081386b1fff0d
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoimprove documentation language style
Mark Brand [Mon, 20 Feb 2012 21:17:11 +0000 (22:17 +0100)]
improve documentation language style

Change-Id: Ic7daa90fff764578bd8122986a73c2ea6280e784
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoFixed resolution of QMAKESPEC on Windows.
Rohan McGovern [Thu, 23 Feb 2012 00:43:25 +0000 (10:43 +1000)]
Fixed resolution of QMAKESPEC on Windows.

base_vars["QMAKESPEC_ORIGINAL"] is not guaranteed to be set the first
time resolveSpec is called, since an include() can wipe it out.  Change
it so that resolveSpec is called repeatedly until some
QMAKESPEC_ORIGINAL is set.

The code which attempted to remove all of the path up to the last / was
incorrect and must have been dead code (or its wrongness didn't matter)
until now.

Change-Id: I2b31ae10fc284ac7293c3cd95e5a2fd503ca7ab0
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
12 years agoAdded documentation for QOpenGLContext and QOpenGLContextGroup.
Samuel Rødal [Tue, 21 Feb 2012 11:46:44 +0000 (12:46 +0100)]
Added documentation for QOpenGLContext and QOpenGLContextGroup.

Change-Id: I00e3e3b3fd37b27b31d4705de3c8c34be9211707
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoBump the moc output revision
Kent Hansen [Thu, 23 Feb 2012 12:52:16 +0000 (13:52 +0100)]
Bump the moc output revision

Commit aee1f6cc413f56bf4962324799ee3887c3dd037f changed the values of
some built-in meta-type ids. Since the ids of built-in types are
directly encoded -- not as the symbolic QMetaType::Type name, but as
a raw integer -- in the flags for meta-properties, the moc output
prior to that change is incompatible with the current output.

Change-Id: I970484825137a4f19c80726cfe2024e741e3e879
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoRevert "Escape project file name in makefile rebuild rules."
Andreas Hartmetz [Thu, 23 Feb 2012 14:05:39 +0000 (15:05 +0100)]
Revert "Escape project file name in makefile rebuild rules."

It was the result of miscoordination between Andreas Holzammer and me,
duplicating the functional change of commit
ea2c9f764fed654a57972223449f41e208e05863.
This reverts commit 8b7a9b4898c85e81d87cf642ec59ce85e917ee35.

Change-Id: I9a47746c1c12ca00b2dc5c5d50e99f9bf990e3f7
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoUse new plugin system in plugin autotest.
Friedemann Kleint [Thu, 23 Feb 2012 12:51:12 +0000 (13:51 +0100)]
Use new plugin system in plugin autotest.

Fix up test use QFINDTESTDATA for shadow builds.

Change-Id: I64731baa44f446ce360631ed6a638cea098d78a0
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoQSslSocket::verify certificates when on-demand loading is used
Martin Petersson [Tue, 21 Feb 2012 14:28:18 +0000 (15:28 +0100)]
QSslSocket::verify certificates when on-demand loading is used

Task-number: QTBUG-24350
Change-Id: I5a328efe6606f5d438bb4787a5c02a425ce42aca
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoQWindowsPipeWriter could terminate the process to early
Martin Petersson [Thu, 23 Feb 2012 12:18:47 +0000 (13:18 +0100)]
QWindowsPipeWriter could terminate the process to early

When the QWindowsPipeWriter is deleted it will wait
for the thread to exit. This wait was set to 100 ms
which will not always be enough time for the thread
to exit, in that case the thread will be terminated.
This will increase the timeout to 30 seconds that
should be more then enough time for the thread to exit
by itself.

Task-number: QTBUG-4425
Change-Id: I9b1910c0213376c622c091be050df2a1c4c6b190
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoQTextEngine - treat a fullstop (0x2E) as the same script as the preceeding text when...
John Tapsell [Wed, 8 Feb 2012 10:12:16 +0000 (10:12 +0000)]
QTextEngine - treat a fullstop (0x2E) as the same script as the preceeding text when dividing up strings

Many languages use a fullstop to indicate an abbreviation, making the
fullstop part of the word.  For languages like thai, it is required to
pass the fullstop along for correct word breaking.

Change-Id: I5ad0ddbc66ea96e08913446dad8fd3c5d5dd0905
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
12 years agoHarfbuzz-thai: Hide ZWJ and ZWNJ characters and show Inherited characters
John Tapsell [Wed, 8 Feb 2012 10:12:13 +0000 (10:12 +0000)]
Harfbuzz-thai: Hide ZWJ and ZWNJ characters and show Inherited characters

Thai is not supposed to have ZWJ and ZWNJ characters or any other of the
Inherited Unicode Scripts
(http://www.verisigninc.com/assets/idn-inherited-unicode-script.pdf)
- they don't have a mapping to the thai encoding tis620 which libthai
requires.  However it is an unfortunate fact that there are many websites
etc that liberally place these ZWJ and ZWNJ characters throughout thai text
to force word boundaries, so we must also deal with them.

We deal with all Inherited characters by mapping them to the invalid code ~0
in tis620 encoding, following what libthai does internally in its own tis620
encoding functions, and then replacing this character with the original
unicode and setting dontPrint to true to hide the ZWJ and ZWNJ
characters.

Includes a unit test to check the behaviour.

Change-Id: I1ee8388b650cb5fc61bcb265efb9843c73f327ac
Reviewed-by: Adrian Yanes <ext-adrian.yanes@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
12 years agoRequire compiler support for deprecated constructors.
Stephen Kelly [Wed, 22 Feb 2012 13:25:33 +0000 (14:25 +0100)]
Require compiler support for deprecated constructors.

Change-Id: I1d4cdcbbddb7895e6529e4f6b5295312e9a3a0e6
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRemove QT_ASCII_CAST_WARN_CONSTRUCTOR
Stephen Kelly [Wed, 22 Feb 2012 23:22:59 +0000 (00:22 +0100)]
Remove QT_ASCII_CAST_WARN_CONSTRUCTOR

GCC version < 3 which it was created for is not supported anymore.

Change-Id: I0b4df4c99600cacbaafbf0bc4270cd4978600956
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRename QMetaTypeSwitcher::UnknownType to NotBuiltinType.
Jędrzej Nowacki [Mon, 13 Feb 2012 12:06:40 +0000 (13:06 +0100)]
Rename QMetaTypeSwitcher::UnknownType to NotBuiltinType.

UnknownType suggest that a type is unknown to QMetaType, but
QMetaTypeSwitcher is not checking for custom types.

Change-Id: I6b8b692e0f20bed286c713672b35fb15757d389e
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoUse -fPIE on QNX
Sean Harmer [Thu, 23 Feb 2012 12:42:17 +0000 (12:42 +0000)]
Use -fPIE on QNX

Change-Id: Iec065f528f5edd848be580807a607488dc2e401f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoFix fontconfig.pri file to allow QPA plugins to build
Sean Harmer [Thu, 23 Feb 2012 11:41:47 +0000 (11:41 +0000)]
Fix fontconfig.pri file to allow QPA plugins to build

Change-Id: I5ebcffb7153f4216d69921d4818051e6b3d14d8a
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
12 years agoAdd the quitlock feature to QThread.
Stephen Kelly [Wed, 8 Feb 2012 14:55:29 +0000 (15:55 +0100)]
Add the quitlock feature to QThread.

Change-Id: Ib44ee9739499ba4c5f0fecbef3976251ea22836d
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoAdd WindowDoesNotAcceptFocus flag and use it in xcb
Jan Arne Petersen [Fri, 2 Dec 2011 14:20:04 +0000 (15:20 +0100)]
Add WindowDoesNotAcceptFocus flag and use it in xcb

Add window flag to support windows which should not get the input
focus.

Sets the input field in the WM_HINTS structure of the window to false
if the WindowDoesNotAcceptFocus flag is set on a window in xcb.

Change-Id: Ifbc10695b83484c17dca0eb13ea826d74f174833
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agocompile fix: missing #include <unistd.h>s
Marc Mutz [Thu, 23 Feb 2012 11:23:25 +0000 (12:23 +0100)]
compile fix: missing #include <unistd.h>s

Change-Id: I3bd34f67033fb921c49da97419c107811d8da6ff
Reviewed-by: David Faure <faure@kde.org>
12 years agoFleshed out the QWindow documentation to be less sparse.
Samuel Rødal [Tue, 21 Feb 2012 09:44:33 +0000 (10:44 +0100)]
Fleshed out the QWindow documentation to be less sparse.

Change-Id: Ia3873687a2c3e0dd85c56e4f9e34d2e194e2ff50
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoAdded documentation for QSurfaceFormat.
Samuel Rødal [Tue, 21 Feb 2012 12:40:57 +0000 (13:40 +0100)]
Added documentation for QSurfaceFormat.

Change-Id: I3b42b09e6e42092c098e4fc20c5ba7dd7e354116
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoUpdate tst_QTextEdit::fullWidthSelection
Eskil Abrahamsen Blomfeldt [Thu, 23 Feb 2012 09:13:41 +0000 (10:13 +0100)]
Update tst_QTextEdit::fullWidthSelection

Since we would add 1 to the height of script lines in the layout before
and there was no compensation for this in the box font engine, which is
used by this test, the selection rect in the test images was one pixel too
high. Now that the +1 has been removed from the height, the images have to
be updated.

Change-Id: Ic9ea0ace6b61be496846c7f757ae309756cd9f5f
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoHandle theme change in QApplication/QGuiApplication.
Friedemann Kleint [Tue, 21 Feb 2012 13:45:07 +0000 (14:45 +0100)]
Handle theme change in QApplication/QGuiApplication.

Re-initialize palette and fonts.

Change-Id: Ib312747886a31e8370f8d99536d52cbcf8afe8a4
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoFix conflict between QMainWindow::restoreState() and QWidget::setStylesheet()
Debao Zhang [Sat, 24 Dec 2011 16:47:41 +0000 (00:47 +0800)]
Fix conflict between QMainWindow::restoreState() and QWidget::setStylesheet()

If QMainWindow::restoreState() then QWidget::setStylesheet() were called
before the QMainWindow is shown, the size of QDockWidget can not be
restored.

QWidget::setStylesheet() will generate QEvent::StyleChange event, which will
cause the function QDockAreaLayout::fitLayout() to be called before the layout
of MainWindow is activated. Although the state info has been stored in
a QMainWindowLayoutState variable by QMainWindow::restoreState(), but
QMainWindowLayout::setGeometry() still isn't called at present. So
QDockAreaLayout::fitLayout() will force the size of dockwidgets
and centralwidget to be calculated using the wrong geometry, which will
break the state restored by QMainWindow::restoreState().

This is a side effect of 692e9103ebb85b90e79377206d5d03b704d43d42.

Task-number: QTBUG-15080

Change-Id: I8cda6a529d178f7467a59b780db80df0a44d4769
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>