platform/upstream/freerdp.git
5 years agoMerge pull request #5628 from akallabeth/handle_fix
Martin Fleisz [Wed, 2 Oct 2019 07:18:50 +0000 (09:18 +0200)]
Merge pull request #5628 from akallabeth/handle_fix

Fix WINPR_EVENT and WINPR_TIMER structs.

5 years agoFix WINPR_EVENT and WINPR_TIMER structs.
akallabeth [Tue, 1 Oct 2019 19:03:03 +0000 (21:03 +0200)]
Fix WINPR_EVENT and WINPR_TIMER structs.

Both structs must have the same base members so that the event
handle can be extracted at the same offset.

5 years agoMerge pull request #5596 from akallabeth/wlog_cache_ptr
Martin Fleisz [Tue, 1 Oct 2019 13:57:17 +0000 (15:57 +0200)]
Merge pull request #5596 from akallabeth/wlog_cache_ptr

Speedup for WLog_* macros, cache the log pointer

5 years agocommon: Fix handling of redirectdrives setting
Martin Fleisz [Tue, 1 Oct 2019 13:38:31 +0000 (15:38 +0200)]
common: Fix handling of redirectdrives setting

5 years agordpdr: Fix error code reporting for create PDUs
Martin Fleisz [Tue, 1 Oct 2019 12:04:10 +0000 (14:04 +0200)]
rdpdr: Fix error code reporting for create PDUs

5 years agowlog: Fix uninitialized type in wLogMessage
Martin Fleisz [Tue, 1 Oct 2019 10:14:45 +0000 (12:14 +0200)]
wlog: Fix uninitialized type in wLogMessage

5 years agoMerge pull request #5623 from akallabeth/gateway_error_string
Martin Fleisz [Tue, 1 Oct 2019 09:41:01 +0000 (11:41 +0200)]
Merge pull request #5623 from akallabeth/gateway_error_string

Map gateway errors in freerdp_get_last_error_name

5 years agoMerge pull request #5616 from akallabeth/drive_prefer_absolute_path
Martin Fleisz [Tue, 1 Oct 2019 09:40:38 +0000 (11:40 +0200)]
Merge pull request #5616 from akallabeth/drive_prefer_absolute_path

Fix #5603: Prefer absolute path for /drive: syntax.

5 years agoMap gateway errors in freerdp_get_last_error_name
Armin Novak [Tue, 1 Oct 2019 07:47:26 +0000 (09:47 +0200)]
Map gateway errors in freerdp_get_last_error_name

5 years agoserver: proxy: register input and update callbacks in post connect
kubistika [Wed, 25 Sep 2019 13:10:04 +0000 (16:10 +0300)]
server: proxy: register input and update callbacks in post connect

To avoid a race in which the server received an input event before
proxy's client is initialized, we now only register input and update
callbacks after client is initialized and safe to use.

5 years agoserver: proxy: refactor pf_context_create_client_context
kubistika [Wed, 25 Sep 2019 13:09:36 +0000 (16:09 +0300)]
server: proxy: refactor pf_context_create_client_context

5 years agoserver: proxy: support auto reconnect
kubistika [Wed, 25 Sep 2019 13:09:15 +0000 (16:09 +0300)]
server: proxy: support auto reconnect

5 years agoserver: proxy: separate client and server security settings
kubistika [Wed, 18 Sep 2019 13:08:25 +0000 (16:08 +0300)]
server: proxy: separate client and server security settings

5 years agoMerge pull request #5621 from akallabeth/santize_rdp_file_strings
Martin Fleisz [Fri, 27 Sep 2019 07:28:20 +0000 (09:28 +0200)]
Merge pull request #5621 from akallabeth/santize_rdp_file_strings

Trim all RDP file string options except passwords.

5 years agoTrim all RDP file string options except passwords.
Armin Novak [Thu, 26 Sep 2019 14:58:41 +0000 (16:58 +0200)]
Trim all RDP file string options except passwords.

5 years agoFix #5603: Prefer absolute path for /drive: syntax.
Armin Novak [Tue, 24 Sep 2019 13:44:34 +0000 (15:44 +0200)]
Fix #5603: Prefer absolute path for /drive: syntax.

5 years agoMerge pull request #5614 from akallabeth/better_gateway_error
Martin Fleisz [Tue, 24 Sep 2019 14:28:17 +0000 (16:28 +0200)]
Merge pull request #5614 from akallabeth/better_gateway_error

Better gateway error reporting

5 years agoMerge pull request #5615 from akallabeth/rdp_relaxed_parse
Martin Fleisz [Tue, 24 Sep 2019 14:27:54 +0000 (16:27 +0200)]
Merge pull request #5615 from akallabeth/rdp_relaxed_parse

Added option to parse RDP files relaxed.

5 years agoAdded option to parse RDP files relaxed.
Armin Novak [Tue, 24 Sep 2019 08:01:08 +0000 (10:01 +0200)]
Added option to parse RDP files relaxed.

5 years agoFix #5612: proper return values.
Armin Novak [Tue, 24 Sep 2019 07:45:35 +0000 (09:45 +0200)]
Fix #5612: proper return values.

5 years agoSetting freerdp_last_error in gateway error response.
Armin Novak [Mon, 23 Sep 2019 09:26:55 +0000 (11:26 +0200)]
Setting freerdp_last_error in gateway error response.

5 years agoBetter log message for resetting last error state.
Armin Novak [Mon, 23 Sep 2019 09:22:45 +0000 (11:22 +0200)]
Better log message for resetting last error state.

5 years agoMerge pull request #5610 from akallabeth/centos_fix
Martin Fleisz [Mon, 23 Sep 2019 08:31:51 +0000 (10:31 +0200)]
Merge pull request #5610 from akallabeth/centos_fix

Centos fix

5 years agoMerge pull request #5609 from akallabeth/printer_default_backend
Martin Fleisz [Mon, 23 Sep 2019 07:04:23 +0000 (09:04 +0200)]
Merge pull request #5609 from akallabeth/printer_default_backend

Fix #5606: Fall back to loading default printer backend.

5 years agoFix ##5593: duplicated typedef.
akallabeth [Sun, 22 Sep 2019 14:42:31 +0000 (16:42 +0200)]
Fix ##5593: duplicated typedef.

5 years agoFix #5593: Do not use diagnostics pragma inside functions
akallabeth [Sun, 22 Sep 2019 14:37:52 +0000 (16:37 +0200)]
Fix #5593: Do not use diagnostics pragma inside functions

5 years agoFix #5606: Fall back to loading default printer backend.
akallabeth [Sun, 22 Sep 2019 14:22:41 +0000 (16:22 +0200)]
Fix #5606: Fall back to loading default printer backend.

5 years agoMerge pull request #5578 from kubistika/proxy/refactor
Bernhard Miklautz [Thu, 19 Sep 2019 08:55:08 +0000 (10:55 +0200)]
Merge pull request #5578 from kubistika/proxy/refactor

sever: proxy: code refactor

5 years agoMerge pull request #5595 from volth/patch-3
David Fort [Tue, 17 Sep 2019 05:34:40 +0000 (07:34 +0200)]
Merge pull request #5595 from volth/patch-3

avoid blurry filter when scaling factor is 2x, 3x, etc

5 years agoSpeedup for WLog_* macros, cache the log pointer
Armin Novak [Sun, 15 Sep 2019 07:59:31 +0000 (09:59 +0200)]
Speedup for WLog_* macros, cache the log pointer

WLog_Get(tag) is quite expensive if called repeatedly.
With this patch the pointer is cached on first call.

5 years agoavoid blurry filter when scaling factor is 2x, 3x, etc
volth [Sat, 14 Sep 2019 17:57:45 +0000 (17:57 +0000)]
avoid blurry filter when scaling factor is 2x, 3x, etc

5 years agoMerge pull request #5591 from akallabeth/mac_hotplug_fix
Martin Fleisz [Thu, 12 Sep 2019 12:46:06 +0000 (14:46 +0200)]
Merge pull request #5591 from akallabeth/mac_hotplug_fix

Use stat instead of lstat to iterate /Volumes

5 years agoUse stat instead of lstat to iterate /Volumes
Armin Novak [Thu, 12 Sep 2019 12:35:01 +0000 (14:35 +0200)]
Use stat instead of lstat to iterate /Volumes

Some entries are symbolic links, so follow them and check the link
target for being a directory.

5 years agoMerge pull request #5590 from akallabeth/hotplug_fix
Martin Fleisz [Thu, 12 Sep 2019 10:04:55 +0000 (12:04 +0200)]
Merge pull request #5590 from akallabeth/hotplug_fix

Hotplugging only for drive redirection.

5 years agoHotplugging only for drive redirection.
Armin Novak [Thu, 12 Sep 2019 08:51:55 +0000 (10:51 +0200)]
Hotplugging only for drive redirection.

5 years agoMerge pull request #5589 from akallabeth/strtol_error_check
Martin Fleisz [Wed, 11 Sep 2019 12:33:10 +0000 (14:33 +0200)]
Merge pull request #5589 from akallabeth/strtol_error_check

Tighter error checking for integer options in RDP file.

5 years agoMerge pull request #5582 from akallabeth/win_server_fixes
Martin Fleisz [Wed, 11 Sep 2019 12:29:50 +0000 (14:29 +0200)]
Merge pull request #5582 from akallabeth/win_server_fixes

Fix windows shadow server issues reported in #5577

5 years agoTighter error checking for integer options in RDP file.
Armin Novak [Wed, 11 Sep 2019 09:45:59 +0000 (11:45 +0200)]
Tighter error checking for integer options in RDP file.

5 years agoserver: proxy: config: fix mem leak
kubistika [Wed, 11 Sep 2019 11:14:43 +0000 (14:14 +0300)]
server: proxy: config: fix mem leak

5 years agoMerge pull request #5588 from akallabeth/last_error_reset
Martin Fleisz [Wed, 11 Sep 2019 08:55:49 +0000 (10:55 +0200)]
Merge pull request #5588 from akallabeth/last_error_reset

Reset last error state after a hostname was resolved successfully.

5 years agoReset last error state after a hostname was resolved successfully.
Armin Novak [Wed, 11 Sep 2019 08:43:17 +0000 (10:43 +0200)]
Reset last error state after a hostname was resolved successfully.

5 years agoMerge pull request #5587 from akallabeth/rdp_parser_case_insensitive
Martin Fleisz [Wed, 11 Sep 2019 08:37:08 +0000 (10:37 +0200)]
Merge pull request #5587 from akallabeth/rdp_parser_case_insensitive

Compare rdp file options case insensitive

5 years agoCompare rdp file options case insensitive
Armin Novak [Wed, 11 Sep 2019 08:23:17 +0000 (10:23 +0200)]
Compare rdp file options case insensitive

5 years agoMerge pull request #5583 from akallabeth/mac_bundle_paths
Martin Fleisz [Tue, 10 Sep 2019 10:31:11 +0000 (12:31 +0200)]
Merge pull request #5583 from akallabeth/mac_bundle_paths

mac os bundles should not put libraries/addins in a subfolder.

5 years agomac os bundles should not put libraries/addins in a subfolder.
Armin Novak [Tue, 10 Sep 2019 10:21:40 +0000 (12:21 +0200)]
mac os bundles should not put libraries/addins in a subfolder.

5 years agoAdd MOUSEEVENTF_HWHEEL define if not found in windows.h
Armin Novak [Tue, 10 Sep 2019 07:28:48 +0000 (09:28 +0200)]
Add MOUSEEVENTF_HWHEEL define if not found in windows.h

5 years agoFix windows shadow server issues reported in #5577
Armin Novak [Tue, 10 Sep 2019 06:52:37 +0000 (08:52 +0200)]
Fix windows shadow server issues reported in #5577

5 years agoserver: proxy: client: only try NLA if credentials available
kubistika [Tue, 10 Sep 2019 07:11:00 +0000 (10:11 +0300)]
server: proxy: client: only try NLA if credentials available

5 years agoserver: proxy: get rid of unnecessary casts
kubistika [Mon, 9 Sep 2019 08:25:09 +0000 (11:25 +0300)]
server: proxy: get rid of unnecessary casts

5 years agoserver: proxy: drop local unix socket listen option
kubistika [Sun, 8 Sep 2019 15:13:41 +0000 (18:13 +0300)]
server: proxy: drop local unix socket listen option

5 years agoserver: proxy: refactor
kubistika [Sun, 8 Sep 2019 15:10:50 +0000 (18:10 +0300)]
server: proxy: refactor

5 years agoserver: proxy: refactor usage of pf_context_copy_settings
kubistika [Sun, 8 Sep 2019 12:18:45 +0000 (15:18 +0300)]
server: proxy: refactor usage of pf_context_copy_settings

5 years agoserver: proxy: make sure module's pre connect only called once
kubistika [Sun, 8 Sep 2019 12:08:15 +0000 (15:08 +0300)]
server: proxy: make sure module's pre connect only called once

5 years agoserver: proxy: config: remove duplicate declaration of config macros
kubistika [Sun, 8 Sep 2019 12:06:22 +0000 (15:06 +0300)]
server: proxy: config: remove duplicate declaration of config macros

5 years agoMerge pull request #5569 from akallabeth/dynamic_printer_backend
Martin Fleisz [Fri, 6 Sep 2019 08:08:40 +0000 (10:08 +0200)]
Merge pull request #5569 from akallabeth/dynamic_printer_backend

Dynamic printer backend

5 years agoModified printer backend to allow dynamic backends.
Armin Novak [Wed, 4 Sep 2019 15:17:47 +0000 (17:17 +0200)]
Modified printer backend to allow dynamic backends.

5 years agoMerge pull request #5570 from akallabeth/autodetect_from_rdp_file
Martin Fleisz [Thu, 5 Sep 2019 10:36:48 +0000 (12:36 +0200)]
Merge pull request #5570 from akallabeth/autodetect_from_rdp_file

Set default connection type to autodetect for RDP files.

5 years agoSet default connection type to autodetect for RDP files.
Armin Novak [Thu, 5 Sep 2019 10:20:40 +0000 (12:20 +0200)]
Set default connection type to autodetect for RDP files.

5 years agofreerdp_channels_load_static_addin_entry pszSubsystem empty string returns the defaul...
Armin Novak [Wed, 4 Sep 2019 15:15:51 +0000 (17:15 +0200)]
freerdp_channels_load_static_addin_entry pszSubsystem empty string returns the default backend.

5 years agoNames of services are now const.
Armin Novak [Wed, 4 Sep 2019 13:48:34 +0000 (15:48 +0200)]
Names of services are now const.

5 years agoGetter for state to string
Armin Novak [Wed, 4 Sep 2019 13:46:47 +0000 (15:46 +0200)]
Getter for state to string

5 years agoMerge pull request #5567 from akallabeth/win_clear_sound
Martin Fleisz [Wed, 4 Sep 2019 06:58:24 +0000 (08:58 +0200)]
Merge pull request #5567 from akallabeth/win_clear_sound

Win clear sound

5 years agoFix some warnings on mac os
Armin Novak [Tue, 3 Sep 2019 11:47:13 +0000 (13:47 +0200)]
Fix some warnings on mac os

5 years agoRefactored winmm backend
Armin Novak [Tue, 3 Sep 2019 13:10:06 +0000 (15:10 +0200)]
Refactored winmm backend

Using CALLBACK_FUNCTION again, but protect with semaphore to avoid closing
the device while there are still buffers to be played.

5 years agoOnly close local audio device if rdpsnd thread closes or output format changes.
Armin Novak [Tue, 3 Sep 2019 12:50:05 +0000 (14:50 +0200)]
Only close local audio device if rdpsnd thread closes or output format changes.

Windows 7 and other older systems send one close PDU after another.
This distorts audio during setup and teardown of local sound devices.

5 years agoFixed limit check for wave confirm pdu timestamp.
Armin Novak [Tue, 3 Sep 2019 11:48:30 +0000 (13:48 +0200)]
Fixed limit check for wave confirm pdu timestamp.

5 years agoSet default build windows version to windows 7
Armin Novak [Fri, 30 Aug 2019 08:57:34 +0000 (10:57 +0200)]
Set default build windows version to windows 7

5 years agoFix various compiler warnings for wfreerdp.
Armin Novak [Fri, 30 Aug 2019 07:12:51 +0000 (09:12 +0200)]
Fix various compiler warnings for wfreerdp.

5 years agocommon: Fix nullptr checking in settings_set_string function
Martin Fleisz [Tue, 3 Sep 2019 09:43:18 +0000 (11:43 +0200)]
common: Fix nullptr checking in settings_set_string function

5 years agoMerge pull request #5563 from akallabeth/scanbuild_fixes
Martin Fleisz [Tue, 3 Sep 2019 08:57:24 +0000 (10:57 +0200)]
Merge pull request #5563 from akallabeth/scanbuild_fixes

Scanbuild fixes

5 years agoserver: proxy: only wait for server dynvc when needed
kubistika [Wed, 28 Aug 2019 15:25:23 +0000 (18:25 +0300)]
server: proxy: only wait for server dynvc when needed

5 years agoFixed missing NULL check.
Armin Novak [Tue, 3 Sep 2019 06:56:59 +0000 (08:56 +0200)]
Fixed missing NULL check.

5 years agoFixed memory leak in error branch
Armin Novak [Tue, 3 Sep 2019 06:56:36 +0000 (08:56 +0200)]
Fixed memory leak in error branch

5 years agoConverted BitStream_* defines to inline functions
Armin Novak [Tue, 3 Sep 2019 06:55:59 +0000 (08:55 +0200)]
Converted BitStream_* defines to inline functions

5 years agoFixed uninitialized variable warning.
Armin Novak [Tue, 3 Sep 2019 06:55:29 +0000 (08:55 +0200)]
Fixed uninitialized variable warning.

5 years agoMerge pull request #5562 from akallabeth/rail_langbar_check
Martin Fleisz [Tue, 3 Sep 2019 06:21:09 +0000 (08:21 +0200)]
Merge pull request #5562 from akallabeth/rail_langbar_check

Fix issue reported in #5560: language bar might not be supported by server

5 years agoFix issue reported in #5560: language bar might not be supported by server.
Armin Novak [Tue, 3 Sep 2019 06:07:45 +0000 (08:07 +0200)]
Fix issue reported in #5560: language bar might not be supported by server.

5 years agoMerge pull request #5561 from akallabeth/winmm_play_fix
Martin Fleisz [Mon, 2 Sep 2019 13:23:33 +0000 (15:23 +0200)]
Merge pull request #5561 from akallabeth/winmm_play_fix

Winmm play fix

5 years agoAdded deprecation macro.
Armin Novak [Mon, 2 Sep 2019 13:58:16 +0000 (15:58 +0200)]
Added deprecation macro.

5 years agoUse GetTickCount64 instead of GetTickCountPrecise.
Armin Novak [Mon, 2 Sep 2019 13:44:52 +0000 (15:44 +0200)]
Use GetTickCount64 instead of GetTickCountPrecise.

5 years agoDo not use named events, they are global!
Armin Novak [Mon, 2 Sep 2019 13:28:31 +0000 (15:28 +0200)]
Do not use named events, they are global!

5 years agoUse CALLBACK_EVENT for waveOutOpen to play synchronously.
Armin Novak [Mon, 2 Sep 2019 13:00:09 +0000 (15:00 +0200)]
Use CALLBACK_EVENT for waveOutOpen to play synchronously.

5 years agoMerge pull request #5547 from akallabeth/color_convert_fix
Martin Fleisz [Mon, 2 Sep 2019 12:34:59 +0000 (14:34 +0200)]
Merge pull request #5547 from akallabeth/color_convert_fix

Fix #5543: 16 bit color to 32bit color conversion.

5 years agoMerge pull request #5558 from akallabeth/drive_hotplug_name
Martin Fleisz [Fri, 30 Aug 2019 12:06:18 +0000 (14:06 +0200)]
Merge pull request #5558 from akallabeth/drive_hotplug_name

Allow /drive:<name>,* syntax.:wq

5 years agoAllow /drive:<name>,* syntax.:wq
Armin Novak [Fri, 30 Aug 2019 11:50:33 +0000 (13:50 +0200)]
Allow /drive:<name>,* syntax.:wq

5 years agoMerge pull request #5541 from akallabeth/rdp_file_full_drivestoredirect_parsing
Martin Fleisz [Fri, 30 Aug 2019 09:29:06 +0000 (11:29 +0200)]
Merge pull request #5541 from akallabeth/rdp_file_full_drivestoredirect_parsing

Rdp file full drivestoredirect parsing

5 years agoMerge pull request #5555 from akallabeth/audin_load_fix
Martin Fleisz [Fri, 30 Aug 2019 06:33:40 +0000 (08:33 +0200)]
Merge pull request #5555 from akallabeth/audin_load_fix

Fix #5554: audin is a dynamic channel

5 years agoFix #5554: audin is a dynamic channel
Armin Novak [Thu, 29 Aug 2019 16:46:49 +0000 (18:46 +0200)]
Fix #5554: audin is a dynamic channel

5 years agoSanitize drive redirection names.
Armin Novak [Fri, 23 Aug 2019 10:44:44 +0000 (12:44 +0200)]
Sanitize drive redirection names.

5 years agoserver: proxy: rdpsnd support
kubistika [Tue, 13 Aug 2019 10:53:36 +0000 (13:53 +0300)]
server: proxy: rdpsnd support

5 years agordpsnd: subsystems: Add proxy subsystem
kubistika [Tue, 13 Aug 2019 08:27:46 +0000 (11:27 +0300)]
rdpsnd: subsystems: Add proxy subsystem

5 years agordpsnd: client: add rdpContext getter
kubistika [Mon, 26 Aug 2019 13:53:00 +0000 (16:53 +0300)]
rdpsnd: client: add rdpContext getter

5 years agoserver: proxy: fix nla fallback (introuduced in #5522)
kubistika [Wed, 28 Aug 2019 14:50:28 +0000 (17:50 +0300)]
server: proxy: fix nla fallback (introuduced in #5522)

5 years agoMerge pull request #5549 from akallabeth/prompt_for_credentials_fix
David Fort [Wed, 28 Aug 2019 13:10:32 +0000 (15:10 +0200)]
Merge pull request #5549 from akallabeth/prompt_for_credentials_fix

Read and write RDP file 'prompt for credentials'

5 years agoRead and write RDP file 'prompt for credentials'
Armin Novak [Tue, 27 Aug 2019 10:24:28 +0000 (12:24 +0200)]
Read and write RDP file 'prompt for credentials'

5 years agoAdded color conversion correctness check to interleaved codec test.
Armin Novak [Mon, 26 Aug 2019 08:54:43 +0000 (10:54 +0200)]
Added color conversion correctness check to interleaved codec test.

5 years agoFix #5543: 16 bit color to 32bit color conversion.
Armin Novak [Mon, 26 Aug 2019 07:38:00 +0000 (09:38 +0200)]
Fix #5543: 16 bit color to 32bit color conversion.

When converting 16 bit color (5 or 6 bit per color) to 32bit
(8 bit per color) add a value dependent correction factor so that
value 0 -> 0 and 31 -> 255.

5 years agokeyboard: don't catch Ctrl+Alt-C if encomsp is not activated
David Fort [Thu, 22 Aug 2019 20:17:35 +0000 (22:17 +0200)]
keyboard: don't catch Ctrl+Alt-C if encomsp is not activated

5 years agoUnified DriveStoreRedirect parsing.
Armin Novak [Fri, 23 Aug 2019 09:47:31 +0000 (11:47 +0200)]
Unified DriveStoreRedirect parsing.

5 years agoserver: proxy: disp: fix copyright
kubistika [Mon, 19 Aug 2019 13:07:12 +0000 (16:07 +0300)]
server: proxy: disp: fix copyright