Daniel Zaoui [Mon, 29 Jun 2015 13:31:50 +0000 (16:31 +0300)]
Set file permissions back to 644
Few files permissions have been modified by mistake in the past patches.
Lukasz Stanislawski [Mon, 29 Jun 2015 10:55:21 +0000 (12:55 +0200)]
atspi: add org.a11y.atspi.Application interface to root object
Lukasz Stanislawski [Mon, 29 Jun 2015 09:39:16 +0000 (11:39 +0200)]
atspi: add missing header
Lukasz Stanislawski [Mon, 8 Jun 2015 13:40:28 +0000 (15:40 +0200)]
atspi: refactor atspi_bridge to eo object
This will allow to reuse eo events infrastructure
in next patches.
Avi Levin [Thu, 30 Apr 2015 11:18:41 +0000 (14:18 +0300)]
elm_flip: porting evas smart callbacks to eo
Avi Levin [Wed, 29 Apr 2015 14:45:24 +0000 (17:45 +0300)]
elm_photo: porting evas smart callbacks to eo
Avi Levin [Wed, 29 Apr 2015 11:30:15 +0000 (14:30 +0300)]
elm_dayselector: porting evas smart callbacks to eo
Avi Levin [Tue, 28 Apr 2015 16:37:09 +0000 (19:37 +0300)]
elc_player: porting evas smart callbacks to eo
Avi Levin [Tue, 28 Apr 2015 13:41:29 +0000 (16:41 +0300)]
elc_popup: porting evas smart callbacks to eo
Avi Levin [Tue, 28 Apr 2015 11:26:17 +0000 (14:26 +0300)]
elm_box: porting evas smart callbacks to eo
Replacing calls of evas_object_smart_callback_add/del/call
with eo_callback_add/del/call.
This will reduce the use of legacy events and callbacks lists in
smart_object which in turn will improve performance and reduce memory
use.
Amitesh Singh [Mon, 29 Jun 2015 05:45:26 +0000 (11:15 +0530)]
slider: call elm_widget_theme_get instead of elm_object_theme_get.
This reduces one function call and make code more consistent
between widgets.
Amitesh Singh [Mon, 29 Jun 2015 05:27:40 +0000 (10:57 +0530)]
Revert "theme: return false if elm_object_style_set() failed to set requested style."
This reverts commit
76004dfbec84664e253babc5bf576398a5901395.
We need to change other code also to accommodate this change.
_elm_theme_set should return an enum which tells what failed.
enum {
THEME_APPLY_FAILED,
THEME_DEFAULT_SUCCESS.
THEME_APPLY_SUCCESS
};
Based on that, we decide what needs to be done.
The above code will break the layout theme if incorrect theme are passed.
It should be backported to Elm 1.14.
@fix
Tom Hacohen [Fri, 26 Jun 2015 14:44:40 +0000 (15:44 +0100)]
Wayland cnp: Fix const qualifier discarding following eolian const fixes.
Vitor Sousa [Fri, 26 Jun 2015 14:36:43 +0000 (15:36 +0100)]
Replace C names by Eolian namespaced names in .eo files
Reviewers: tasn, felipealmeida, raster, cedric
Differential Revision: https://phab.enlightenment.org/D2750
jiin.moon [Fri, 26 Jun 2015 04:54:47 +0000 (13:54 +0900)]
elm_config: Add feature to control transition scale for edje
Summary:
If the transition scale flag is enable in edje,
this value affect the transition scale for edje.
@feature
Test Plan: test elementary_config with enventor tool
Reviewers: raster, Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2288
Daniel Juyung Seo [Fri, 19 Jun 2015 05:06:16 +0000 (14:06 +0900)]
test_focus_policy: Enhance object focus policy test.
- Add more descriptions in the test.
- Set the focus to the first button automatically.
Daniel Juyung Seo [Fri, 19 Jun 2015 04:01:46 +0000 (13:01 +0900)]
layout: Add more description for layout's internal smart data members.
Daniel Juyung Seo [Mon, 8 Jun 2015 17:44:29 +0000 (02:44 +0900)]
elm: Add missing const for getters.
Daniel Juyung Seo [Mon, 8 Jun 2015 16:18:48 +0000 (01:18 +0900)]
interface_scrollable: Add more description to animators.
It is surprising that there is no such a comment on a scrollerable
interface considering the complexity of scroller.
Daniel Juyung Seo [Mon, 8 Jun 2015 15:43:19 +0000 (00:43 +0900)]
elm: Remove shadow variable declarations.
Daniel Juyung Seo [Fri, 26 Jun 2015 01:12:25 +0000 (10:12 +0900)]
edje_externals: Fix wrong free.
_signal is used after free. _signal will be freed soon any way.
This was introduced in 3da3082.
This fixes coverity CID 1308263.
Daniel Juyung Seo [Fri, 26 Jun 2015 01:08:08 +0000 (10:08 +0900)]
test_win_keygrab: Fix buffer not null terminated error.
This fixes coverity CID 1308264.
Chris Michael [Thu, 25 Jun 2015 17:33:57 +0000 (13:33 -0400)]
elementary: Add rudimentary support for Elm Wayland apps to set border icon
Summary: This is a patch to fix T2453 where elm apps in weston/E did
not display the icon on the border. This is just preliminary support
because it only tries to find the efreet desktop file based on
_elm_appname. This support Could be extended to allow efreet to search
based on window title, etc, etc.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
SangHyeon Lee [Thu, 25 Jun 2015 14:44:41 +0000 (16:44 +0200)]
elm_interface_scrollable: fix wrong mirrored calculation
Summary:
This Patch is regarding D2553, but funtionally independent patch.
D2557 is also related with this patch, so to test working fine,
need to install those all three patches.
1. _elm_interface_scrollable_content_region_show store wx
into scroll_interface_data without coverting mirrored_x.
fix to store wx to mirror-converted x if is_mirrored.
2. _elm_scroll_x_mirrored_get return mirroed_x after compare zero not minx.
so current mirrored_x couldn't be less then 0.
fix to check min not 0 for set return value.
3. _elm_scroll_x_mirrored_get calculation need to consider start position of scroller.
some scroller(e.g. gengrid) start from non-zero position, so calculation need to change
like below.
ret = (cw - (x + w - min));
@fix
Test Plan: You can test this after merge D2553 patch and D2557 and test gengrid2.
Reviewers: raster, Hermet, seoz, jaehwan, tanwar.umesh07, cedric
Subscribers: tanwar.umesh07, Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2558
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Prince Kr Dubey [Thu, 25 Jun 2015 14:38:28 +0000 (16:38 +0200)]
elm_gengrid: fix an overlap issue of item and group item on focus.
Summary: Issue: Gengrid item comes over group item on click.
Test Plan:
Run elementary test.
Open GenGrid Group. Click on any item which slightly overlap with group item.
Item comes over group item.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh
Differential Revision: https://phab.enlightenment.org/D2589
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
SangHyeon Lee [Thu, 25 Jun 2015 14:35:44 +0000 (16:35 +0200)]
elm_gengrid: fix the bug that gengrid item index(position) is updated wrong value in item_update
Summary:
elm_gengrid_item_update perform item_unrealize/item_realize/item_place itself.
But when gengrid items are added and not calculated yet,
caller want to get item's index after execute elm_gengrid_item_update,
return value is wrong because item_place update it's position in not-updated item's x and y.
to prevent this,
if item position is already updated,
do not updates position in item place.
additionally,
I fixed gengrid item prepend wrong posiiton update.
gengrid item position start from 1 not 0, so item_position_update also must be started from 1.
@fix
Test Plan:
To test this scenario,
need to fix src/bin/test_gengrid.c first.
1. add below codes in bottom of _after_bt_clicked(line 703).
```
Elm_Object_Item *it = elm_gengrid_item_next_get(id->item);
printf("before update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
elm_gengrid_item_update(it);
printf("after update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
```
2. execute elementary_test and go to gengrid2 test.
3. add 3 items and select 2nd item then add new item by insert after.
4. you can see index is changed wrong value after item_update executed.
after add fallback code in item_update,
index is returned same value even after item_update execusion.
Reviewers: raster, Hermet, seoz, jaehwan
Subscribers: anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2616
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Thu, 25 Jun 2015 14:33:57 +0000 (16:33 +0200)]
elm_list & elm_genlist & elm_gengrid: fix the behavior of using the mouse.
Summary:
Elementary widgets have different behavior of using the mouse, they need to be unified.
- swipe : without checking on hold, just checking drag state.
- longpress : after longpress, _item_unhighlight(), _item_unselect() are called.
- select : when the mouse pointer leaves item area, _item_unhighlight(), _item_unselect() are called.
First, apply this commit https://phab.enlightenment.org/D2550
Test Plan: elementary_test -> list
Reviewers: seoz, Hermet, CHAN, woohyun, kimcinoo, jaehwan, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2622
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Thu, 25 Jun 2015 14:31:36 +0000 (16:31 +0200)]
gengrid: add unhighlight callback
Summary:
item_unselect check it->select status, so when item highlighted but not selected,
item highlight is remaining even after unselect_cb is called.
And item_select and item_highlight are separated, but item_unselect and item_unhighlight are mixed.
so divide them, too.
This patch will solve upon problem.
Reviewers: seoz, woohyun, Hermet, CHAN, raster, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2653
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
SangHyeon Lee [Thu, 25 Jun 2015 14:28:07 +0000 (16:28 +0200)]
gengrid: add item cache in gengrid for efficient realize/unrealize operation.
Summary:
gengrid realize/unrealize items each smart calculation if their posiiton is updated.
This concept will be occurred useless view object creation and deletion.
So instead of delete items in unrealize function, push item cache into cache list,
and pop item cache from cache list in realize function to reuse item view object
more efficiently.
the cache concept is already implemented in genlist widget and this patch is improved
item cache of genlist cache.
@feature
```
NOTICE: This patch is written under the D2561 Patch which add elm_gengrid_item_fields_update.
So it must submitted after D2561.
```
Test Plan:
I've tested below three cases,
1. tested ith this patch in elementary_test and checked all gengrid features are working properly.
2. tested with changing CACHE_MAX to another value which is set 40 in default
and checked all gengrid features are working properly.
3. tested with set it->item->nocache true, and checked cache is never generated
and checked all gengrid features are working properly.
Reviewers: raster, Hermet, seoz, jaehwan, singh.amitesh
Subscribers: eagleeye, singh.amitesh, Jaehyun
Differential Revision: https://phab.enlightenment.org/D2641
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
godly.talias [Thu, 25 Jun 2015 14:27:09 +0000 (16:27 +0200)]
elm_spinner: add feature in spinner to change values while dragging relative to the speed of dragging
Summary:
Currently the values in spinner change while dragging only based on
the amount of pixels dragged, this patch will enable Spinner to change value
based on the speed of dragging so that it will be more user friendly. This
will help users to alter drag values by big amounts if dragged in a good speed.
Test Plan: test_spinner.c in elementary_test
Reviewers: raster, prince.dubey, shilpasingh, cedric
Reviewed By: cedric
Subscribers: poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2659
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Amitesh Singh [Thu, 25 Jun 2015 14:15:06 +0000 (16:15 +0200)]
genlist/list/win: Revert focus highlight animation when looping is enable
Summary:
-
Revert "focus: Added internal widget APIs of focus highlight object of elm window."
This reverts commit
3f98d71830163a154762f2d16301d720c781b7c5.
- Revert "List: Focus highlight when loop is enable"
This reverts commit
57ad32a900e71f83441bf7246671b8f16a8ec909.
- Revert "genlist: Focus highlight when loop is enable"
This reverts commit
91282a22cba66ee5e7799018d3abe8957fb1b1fa.
Reviewers: seoz, raster, jpeg, SanghyeonLee
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D2725
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Thu, 25 Jun 2015 14:13:56 +0000 (16:13 +0200)]
calendar: show days of prev/next month.
Summary:
Show days of previous and next month on the blank area of calendar.
@feature
Test Plan: See calendar widget on elementary_test.
Reviewers: raster, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2728
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vitalii Vorobiov [Thu, 25 Jun 2015 14:11:37 +0000 (16:11 +0200)]
elm_colorselector: pixel-picker accuracy fix
Summary:
Looking at the base array of pixels,
the real middle of taken picture
is actually number 8 from array of 17 pixels (which starts from 0).
@fix
Reviewers: reutskiy.v.v, raster, NikaWhite, cedric
Reviewed By: NikaWhite, cedric
Differential Revision: https://phab.enlightenment.org/D2749
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vaibhav Gupta [Thu, 25 Jun 2015 13:54:39 +0000 (15:54 +0200)]
focus: fix typo in API Documentation.
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: raster, Hermet, cedric
Reviewed By: cedric
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2767
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Daniel Kolesa [Thu, 25 Jun 2015 11:21:00 +0000 (12:21 +0100)]
elm: constify Eolian methods correctly because of recent Eolian changes
Thiep Ha [Thu, 25 Jun 2015 05:54:36 +0000 (08:54 +0300)]
cnp: remove loss callback when object is deleted
Summary:
SEG_FAULT happens when the object which has selection is deleted,
and new selection is done at another object.
Reason: loss_cb is not removed when the object which has selection is deleted.
When new selection is set for new object, the loss_cb is called for deleted
object. As result, SEG_FAULT happens.
Test Plan:
Run elementary test, open Entry, do selection,
close Entry window, open Entry one more time, do selection.
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2763
Jaehwan Kim [Thu, 25 Jun 2015 05:04:23 +0000 (14:04 +0900)]
config: read flush.cfg when elm_config_all_flush is called.
When elm_config_all_flush is called, another processes should get
the config of current process instead of saved base.cfg.
so current process save the config to flush.cfg and another processes
read it when it is changed.
@fix
Umesh Tanwar [Thu, 25 Jun 2015 04:47:17 +0000 (13:47 +0900)]
Scroller : Remove white-spaces in header file.
Summary: Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: cedric, raster, seoz, Hermet
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2741
Umesh Tanwar [Thu, 25 Jun 2015 04:44:46 +0000 (13:44 +0900)]
Scroller: Remove white-spaces in scroller.edc file
Summary: Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: cedric, raster, seoz
Differential Revision: https://phab.enlightenment.org/D2744
Umesh Tanwar [Thu, 25 Jun 2015 04:24:21 +0000 (13:24 +0900)]
Genlist: Test case added in Genlist Focus example.
Summary:
Added test case to enable/disable mouse wheel. Mouse Wheel is
used to scroll the genlist up/down.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan: elementary_test -> Genlist Focus -> Wheel Disabled
Reviewers: raster, Hermet, cedric
Subscribers: sachin.dev, singh.amitesh, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2757
Daniel Zaoui [Tue, 23 Jun 2015 15:11:05 +0000 (18:11 +0300)]
X11/CnP: remove X11 invocations from elm_entry
Code specific to X11 should not be part of elm_entry and can be easily
replaced with elm_cnp APIs.
@fix T2183
Daniel Zaoui [Tue, 23 Jun 2015 14:58:48 +0000 (17:58 +0300)]
CnP: improve loss callback
- Reset loss cb after invocation as it is no more needed
- When selection is set, previous owner loss cb is invoked only
if the new owner and the previous one are different.
Jaehwan Kim [Tue, 23 Jun 2015 13:56:17 +0000 (22:56 +0900)]
config: fix the flush file path.
@fix
Daniel Zaoui [Tue, 23 Jun 2015 12:58:45 +0000 (15:58 +0300)]
DnD: remove text/uri handling
This type is not a standard type and can be handled as a text/uri-list
of one uri.
@fix
Daniel Zaoui [Tue, 23 Jun 2015 12:57:02 +0000 (15:57 +0300)]
DnD: remove from elm_cnp code specific to elm_entry
The tag insertion has to be done only from elm_entry callback. elm_cnp
is not supposed to know what will be done with the data.
Daniel Zaoui [Tue, 23 Jun 2015 12:55:28 +0000 (15:55 +0300)]
Tests/DnD: fix uri parsing
When no \n is present at the end of the uris list, the function doesn't
return the uri.
woochan lee [Mon, 22 Jun 2015 23:30:21 +0000 (08:30 +0900)]
widget: Add a case that elm_layout is an item view object.
Summary:
The internal API "_elm_widget_item_highlight_in_theme()" look like for list item highlight.
but it can use in another widget which has item view as elm_layout.
In that case, ERR log will be printed.
Reviewers: singh.amitesh, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2736
ChunEon Park [Mon, 22 Jun 2015 12:41:14 +0000 (21:41 +0900)]
list: --printf
Cedric BAIL [Mon, 22 Jun 2015 10:30:11 +0000 (12:30 +0200)]
examples: fix changes in Evas.Canvas3D namespace.
Amitesh Singh [Mon, 22 Jun 2015 10:02:55 +0000 (12:02 +0200)]
elm_genlist: code refractoring of _item_process
Summary:
When item_process is success, then we want to call _item_process_post.
Old code was confusing before.
Reviewers: raster, Hermet, SanghyeonLee
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2739
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Amitesh Singh [Mon, 22 Jun 2015 09:59:21 +0000 (11:59 +0200)]
elm_genlist: reset timer to NULL on cancel only.
Summary: @fix
Reviewers: raster, seoz, SanghyeonLee
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2730
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Umesh Tanwar [Mon, 22 Jun 2015 09:57:51 +0000 (11:57 +0200)]
elm_scroller: add wheel_disable_set API
Summary:
This API can be used by widgets like Genlist/Gengrid, which implements
Elm_Interface_Scrollable interface.Mouse wheel is used to scroll up and
down on widget.
@feature
Test Plan: elementary_test -> Scroller -> Wheel Disable
Reviewers: raster, Hermet, cedric, SanghyeonLee, singh.amitesh
Subscribers: JackDanielZ, herdsman, cedric, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2715
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sung-Taek Hong [Mon, 22 Jun 2015 09:55:52 +0000 (11:55 +0200)]
elm_colorselector: fix horiz/vertical padding to be affected by base_scale in edc
Summary:
elm_colorselector get its padding size from data in edc.
However, when calculating the padding size, it does not consider
base_scale of the style from where it gets padding size.
In this commit, the padding size from edc is divided by its
base_scale so that desirable size can be calculated.
@fix
Reviewers: Hermet, woohyun
Subscribers: woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2721
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Prince Kr Dubey [Mon, 22 Jun 2015 09:54:53 +0000 (11:54 +0200)]
elm_genlist: fix highlighted items overlap with group item during scrolling and focus when intersect.
Summary: Highlighted genlist item overlap with group item during scrolling and focus when itersect.
Test Plan:
Run elementary_test.
open Genlist Group.
select one item and try to cross the group item via scrolling.
Highlighted item comes over group item.
Reviewers: Hermet, raster, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh
Differential Revision: https://phab.enlightenment.org/D2640
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Prince Kr Dubey [Mon, 22 Jun 2015 09:51:20 +0000 (11:51 +0200)]
genlist: fix Issue "In Tree effect feature, items floates when number of item crosses item block size".
Summary: "In Tree effect feature, during expansion of tree, when total number of items crosses block count, items start floating".
Test Plan: Run elementary_test, open Genlist Tree, keep expanding items untill it crosses number of count 32 (Block count). Resize the window, floting items can be seen.
Reviewers: raster, cedric
Subscribers: shilpasingh, poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2627
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Minwoo, Lee [Mon, 22 Jun 2015 09:47:22 +0000 (11:47 +0200)]
elm_entry: modify to not allocate Eina_Rectangle
Summary: modify to not allocate Eina_Rectangle and use it directly on the stack with EINA_RECTANGLE_SET
Reviewers: raster, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2737
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Amitesh Singh [Mon, 22 Jun 2015 10:06:21 +0000 (19:06 +0900)]
genlist: fix resize of items when added after elm_genlist_clear().
Summary:
This fixes following issue.
1. Add genlist items
2. Clear genlist by elm_genlist_clear()
3. Append items.
Genlist items are shrinked. This patch fixes that issue.
@fix
Partially resolves: T2367
Reviewers: Hermet, raster, cedric, raoulh, SanghyeonLee
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2733
Carsten Haitzler (Rasterman) [Mon, 22 Jun 2015 07:49:13 +0000 (16:49 +0900)]
update po's
Daniel Zaoui [Fri, 19 Jun 2015 11:18:18 +0000 (14:18 +0300)]
DnD: fix usage of TARGETS
- TARGETS notifier is specific to CnP and should not be called for DnD
- On DnD (when drag starts) and on CnP, it doesn't make sense that the TARGETS
type are sent to the potential target. Only basic types should be sent.
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2015 11:12:04 +0000 (20:12 +0900)]
elm confiug - remove now useless x11 property handling - donr by files
follow on from
b1c5de0b9aa67b9d5cc4722e9462830beb3af37b,
aa7f859da10ce007a7b945a8703e70161c96146d
Andrii Kroitor [Wed, 17 Jun 2015 13:18:02 +0000 (15:18 +0200)]
colorselector: fix missing style warning
Test Plan:
1. open "elementary_test colorselector"
2. click "all" button
Reviewers: cedric, seoz, Hermet, raster
Differential Revision: https://phab.enlightenment.org/D2635
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
SangHyeon Lee [Wed, 17 Jun 2015 13:14:47 +0000 (15:14 +0200)]
gengrid: remove duplicated focus state recovering.
Summary:
gengrid focus state recovering in item_realize is duplicated.
remove unnecessary lines.
you can find same signal emit codes under line 1018.
Test Plan: test elemetary test gengrid focus highight show correctly after code merged.
Reviewers: raster, Hermet, seoz, jaehwan, cedric
Reviewed By: cedric
Subscribers: singh.amitesh, eagleeye
Differential Revision: https://phab.enlightenment.org/D2656
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Wed, 17 Jun 2015 13:09:13 +0000 (15:09 +0200)]
colorselector: add safety check for NULL pointer from ecore_x_image_new().
Summary:
ecore_x_image_new() API can return NULL.
@fix
Reviewers: raster, woohyun, Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2667
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shinwoo Kim [Wed, 17 Jun 2015 13:06:01 +0000 (15:06 +0200)]
notify: fix prevent issue, dereference null return value
Summary: Fix prevent issue: Dereference null return value
Test Plan: Use static analysis tool such as prevent
Reviewers: raster, woohyun, jaehwan, Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2669
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Wed, 17 Jun 2015 13:02:48 +0000 (15:02 +0200)]
dayselector : add safety check for NULL pointer from _item_find()
Summary:
It could make crash when _item_find() is failed.
CID - 404129
CID - 402467
CID - 398714
CID - 390012
@fix
Reviewers: raster, thiepha, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2683
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Marcel Hollerbach [Wed, 17 Jun 2015 12:53:37 +0000 (14:53 +0200)]
elm_icon_external: cleanup ERR msg in error case
Summary:
Setting the group without checking it exists causes a errormessage, this
is pretty annoying for people which want to set a standart icon. And
give a better errormessage if the standart setting failed.
Reviewers: raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2686
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Wed, 17 Jun 2015 12:49:40 +0000 (14:49 +0200)]
atspi_bridge: fix memory leak issue
Summary:
Call eldbus_message_unref to free Eldbus_Message structure.
And delete unused Eldbus_Message variable.
CID-386474
CID-391869
CID-394549
Reviewers: raster, woohyun, CHAN, Hermet, seoz, lukasz.stanislawski, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2690
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vaibhav Gupta [Wed, 17 Jun 2015 12:46:22 +0000 (14:46 +0200)]
test_gengrid: remove EINA_UNUSED for a used argument
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: raster, Hermet, cedric
Reviewed By: cedric
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2670
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Anand [Wed, 17 Jun 2015 12:32:03 +0000 (14:32 +0200)]
elm_gen_common: fix typo in Struct variable documentation
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2634
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Minwoo, Lee [Wed, 17 Jun 2015 12:25:29 +0000 (14:25 +0200)]
edje_externals: add safety check for NULL pointer
Summary: Dereferencing null pointers in external_signal()
Reviewers: bdilly, raster, woohyun, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2688
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
taehyub [Wed, 17 Jun 2015 12:19:31 +0000 (14:19 +0200)]
app_server: add null check for dbus_state_set/elm_app_server_views_eet_new
Reviewers: Hermet, woohyun, raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2705
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vitor Sousa [Wed, 17 Jun 2015 09:17:19 +0000 (10:17 +0100)]
elm_image: Solve clash on the meaning of "animated"
Summary:
Both Elm_Image and its base interface Efl.Image have a property named
"animated".
The meaning for Efl.Image is whether or not the image has animation.
On the other hand, Elm_Image use it to set whether an image, which supports
animation, is to animate itself or not.
Thus Elm_Image have another property (animated_available) to tell whether the
image have animation or not, making it even more confusing.
Renamed the "animated" property of Elm_Image to "animated_enable" to make
the intended meaning clearer.
Also replaced the "animated_available" property with the "animated" property
from the Efl.Image interface, since both refers to the same thing, in order
to reduce the API.
Added implementations of the legacy methods for backward compatibility.
Address the issue:
- Elm image and the image interface clash because of the meaning of "animated".
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/
Reviewers: felipealmeida, tasn
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2354
Jaehwan Kim [Wed, 17 Jun 2015 08:51:40 +0000 (17:51 +0900)]
config: fix comment
Jaehwan Kim [Wed, 17 Jun 2015 08:37:01 +0000 (17:37 +0900)]
config: make a config directory, if it is not.
create the config directory to register flush file to eio_monitor.
Carsten Haitzler (Rasterman) [Wed, 17 Jun 2015 07:54:08 +0000 (16:54 +0900)]
fix more elm config file pointer access
again - follow up from changes to config code to fix seg
Carsten Haitzler (Rasterman) [Wed, 17 Jun 2015 07:37:56 +0000 (16:37 +0900)]
elm config files - don't write to file if file handle is null
fixes seg with new file only config for elm
ChunEon Park [Wed, 17 Jun 2015 04:54:42 +0000 (13:54 +0900)]
win: fix bug about engine value.
When application does not have any value of engine,
this app should be launched with elm_config's value.
Signed-Off-By: Wonsik Jung <sidein@samsung.com>
Mike Blumenkrantz [Tue, 16 Jun 2015 21:01:02 +0000 (17:01 -0400)]
win: do not use deferred ecore evas deletion for FAKE wins
these ees will be deleted externally anyway
@fix
Mike Blumenkrantz [Tue, 16 Jun 2015 21:00:44 +0000 (17:00 -0400)]
win: only trigger del trap if win type is not FAKE
@fix
Mike Blumenkrantz [Tue, 16 Jun 2015 20:28:59 +0000 (16:28 -0400)]
theme: migrate all e users of darken_rounded_square to new darken_square image
nearly everything in e is square except for this, which was a holdover from the
b&w theme. the new image looks more coherent with the rest of the square look
image created by me, licensing to match rest of theme images
@feature
Mike Blumenkrantz [Tue, 16 Jun 2015 20:28:27 +0000 (16:28 -0400)]
notification: set fixed on app icon to eliminate edje calc error
Thiep Ha [Tue, 16 Jun 2015 13:41:55 +0000 (14:41 +0100)]
entry: emit changed,user signal when text is pasted or dropped
Summary:
When text is pasted or dropped into entry, the "changed,user" signal
should be emitted, not "changed" signal.
Currently, the "changed" signal is emitted.
This patch fixes this issue.
@fix
Reviewers: herdsman, tasn
Subscribers: tasn
Differential Revision: https://phab.enlightenment.org/D2710
Jaehwan Kim [Tue, 16 Jun 2015 04:52:23 +0000 (13:52 +0900)]
elm_config: remove X dependency.
Summary:
In wayland, elm_config_all_flush doesn't work.
It has X dependency totally.
It uses ecore_file_monitor instead of X property.
Reviewers: Hermet, devilhorns, raster, cedric
Differential Revision: https://phab.enlightenment.org/D2502
Mike Blumenkrantz [Mon, 15 Jun 2015 17:49:18 +0000 (13:49 -0400)]
comp effects: add tooltip visibility effect
Mike Blumenkrantz [Mon, 15 Jun 2015 17:48:48 +0000 (13:48 -0400)]
comp effects: increase size of vertical visibility effect to include shadows
Ji-Youn Park [Mon, 15 Jun 2015 13:38:12 +0000 (22:38 +0900)]
elm_flip: small error handle fix
if we cannot create slice, we had better stop to change slice
Jaehyun Cho [Mon, 15 Jun 2015 06:51:02 +0000 (15:51 +0900)]
index: Add NULL check for malloc memory allocation.
Jaehyun Cho [Mon, 15 Jun 2015 06:39:02 +0000 (15:39 +0900)]
layout: Add NULL check for calloc memory allocation.
Jaehyun Cho [Mon, 15 Jun 2015 06:35:31 +0000 (15:35 +0900)]
layout: Fix to pass correct argument for edje_object_part_unswallow.
Jaehyun Cho [Mon, 15 Jun 2015 05:56:42 +0000 (14:56 +0900)]
layout: Add NULL check for ELM_NEW memory allocation.
Youngbok Shin [Mon, 15 Jun 2015 05:17:32 +0000 (08:17 +0300)]
clock: Add safety check for NULL pointer from localtime() func.
Summary:
localtime() can return NULL when there is an error.
@fix
Reviewers: raster, woohyun, Hermet, JackDanielZ
Subscribers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2666
Youngbok Shin [Mon, 15 Jun 2015 05:08:34 +0000 (08:08 +0300)]
cnp: Add safety check for NULL pointer from malloc().
Summary:
It could make crash when malloc is failed.
@fix
Reviewers: raster, woohyun, Hermet, JackDanielZ, thiepha
Subscribers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2671
Youngbok Shin [Mon, 15 Jun 2015 05:05:02 +0000 (08:05 +0300)]
cnp: Fix memory leak issue.
Summary: Call efreet_uri_free() API to free Efreet_Uri structure.
Test Plan: None.
Reviewers: raster, cedric, woohyun, Hermet, thiepha, JackDanielZ
Subscribers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2655
ChunEon Park [Mon, 15 Jun 2015 04:58:02 +0000 (13:58 +0900)]
calendar: + null check.
ChunEon Park [Mon, 15 Jun 2015 04:39:14 +0000 (13:39 +0900)]
clendar: + null check
gmtime can return NULL vaule.
if so strftime will cause crash.
this patch just prevent that potential situation.
Hosang Kim [Wed, 3 Jun 2015 13:08:38 +0000 (22:08 +0900)]
elm_interface_scrollable : Fix logic about setting EVAS_EVENT_FLAG_ON_HOLD
Summary: Even if scroller is not scrolled, EVAS_EVENT_FLAG_ON_HOLD is set. So clicked event is canceled in Edje.
Test Plan:
On the button in the vertical scroller, click button and move mouse horizontal.
Mouse up on the button, so now button is not clicked
Reviewers: Hermet, CHAN, seoz, jaehwan, woohyun, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2550
Daniel Zaoui [Sun, 14 Jun 2015 08:14:02 +0000 (11:14 +0300)]
DnD: fix memory leak
Daniel Zaoui [Sun, 14 Jun 2015 08:12:36 +0000 (11:12 +0300)]
DnD/X11: Fix invalid access to memory
It seems X doesn't send the data with the termination.
Daniel Zaoui [Sun, 14 Jun 2015 06:53:45 +0000 (09:53 +0300)]
DnD/X11: rename notifiers
As the notify functions don't notify anymore, they have to be renamed to
reflect their real job, i.e data preparers before calling user
functions.
Daniel Zaoui [Sat, 13 Jun 2015 17:33:14 +0000 (20:33 +0300)]
DnD/X11: refactor the notifiers
Each data notifier was preparing data and then invoking the user callbacks
for DnD or selection protocols.
Most of the notifiers code was handling the user callbacks invocation
and was the same for all of them.
This patch simplifies the notifiers by moving the user callbacks
invocation into a common place for all the types, i.e into the notify
dispatcher.
The notifiers prototype has been changed to suit the code modifications.