SeungSeop Park [Tue, 1 Dec 2015 07:57:18 +0000 (16:57 +0900)]
fixup! Make build_tv.sh script usable again.
Symbolic link src/packaging which points to src/tizen_src/packaging
is generated during the build, which yields dirty status when 'git status'.
Patch removes 'src/packaging' symlink after the rpm build is done.
Reviewed by: a1.gomes, msu.koo
Change-Id: If1d2cff7f4ca62415fb6deba5bea051302053606
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
suneel [Tue, 17 Nov 2015 10:08:49 +0000 (15:38 +0530)]
Implement device display info and get device scale factor.
This patch implements basic display functionalities like display
resolution size, dip scale and rotation degrees.
Obtains the device scale factor (dsf) using device display info. The
display info computes this factor from dpi.
Reference gerrit IDs:
http://165.213.202.130/gerrit/#/c/83364/
http://165.213.202.130/gerrit/#/c/83651/
http://165.213.202.130/gerrit/#/c/85226/
http://165.213.202.130/gerrit/#/c/85236/
http://165.213.202.130/gerrit/#/c/85700/
http://165.213.202.130/gerrit/#/c/87076/
Together with: I8f6dbee2545283c3002591e4965f5c2f677fc6c9
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14881
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14877
Reviewed by: a1.gomes, prashant.n, sns.park
Change-Id: I22014fabf1e2ce2160be75dec4e8bdb8ecd76545
Signed-off-by: suneel <suneel.kota@samsung.com>
Jongsoo Yoon [Thu, 3 Dec 2015 07:16:06 +0000 (16:16 +0900)]
Enable ccache on gbs build system.
In order to enable ccache build option,
we should change it's PATH value to /var/lib/build/ccache/bin.
Because ccache path is moved to there in latest gbs build system.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15086
Change-Id: Icd70453aa96a85553a9e949aad3ee3d2d0128688
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Jongsoo Yoon [Fri, 4 Dec 2015 01:22:19 +0000 (10:22 +0900)]
Changed the IP of mirror server in Tizen 3.0 Profile.
This patch is only valid in HQ.
Before : http://10.252.81.117/snapshots
After : http://10.113.63.117/snapshots
Change-Id: Ic77bb2e9014cc532b7d5c50aac95a8f5ab7c9808
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
DongJun Kim [Wed, 2 Dec 2015 00:43:44 +0000 (09:43 +0900)]
Re-implement didCreateScriptContext to RenderFrameObserverEfl.
DidCreateScriptContext and WillReleaseScriptContext are moved
to ContentRendererClient by (1),(2) in opensource.
DidCreateScriptContext and WillReleaseScriptContext are called
when calling open/close window by javascript.
Those functions must be called together.
In case of m47 chromium-efl, we do not call DidCreateScriptContext.
For this reason, renderer process is crashed when
javascript context is released from injected_bundle.
This patch has 2 modifications as below.
- Remove |WillReleaseScriptContext| from ContentRendererClientEfl.
- Move |didCreateScriptContext| to RenderFrameObserverEfl.
(1) https://codereview.chromium.org/
1040403003
(2) https://codereview.chromium.org/
185713008
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15036
Reviewed by: a.renevier, a1.gomes, djmix.kim, g.czajkowski, msu.koo
Change-Id: I008937710d08472a6cfb77a51b1cbf01ffacc221
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
Grzegorz Czajkowski [Tue, 1 Dec 2015 10:22:55 +0000 (11:22 +0100)]
Do not pass kMobileFlags for all TIZEN builds using ubrowser
kMobileFlags are defined in ubrowser/main.cc and are passed to chromium in case
ubrowser is launching with mobile param.
However, as |!desktop_ui| is also true for all TIZEN builds those flags are
unexpectedly set for them. As for OS_TIZEN_MOBILE they are just duplicated and
do not bring side effects whereas for OS_TIZEN_TV they are not expected.
This patch passes kMobileFlags in case "ubrowser --mobile" only.
Additionally, this patch gets rid of custom EFL command line
"use-mobile-viewport-style" as it can not be propagated to Renderer by default.
For OS_TIZEN_MOBILE |UseMobileViewportStyle| is set by default on src/ side [1].
This patch introduces a new EFL command line:
"ewk-enable-mobile-features-for-desktop" in order to turn on a bunch of
settings for which there is no command line switches. This allows desktop
"ubrowser --mobile" to have similar set of features that mobile build has.
Secondly, we stop abusing |UseMobileViewportStyle| in |ApplyCustomSettings|.
[1] http://165.213.202.130/gerrit/#/c/97109/1
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14816
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15031
Reviewed by: a1.gomes, sns.park
Change-Id: I7dd9f693f53abab0916e6113bbc15bfe635a3159
Signed-off-by: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Marcin Niesluchowski [Mon, 17 Aug 2015 11:48:41 +0000 (13:48 +0200)]
Implement ewk_favicon_database_icon_get()
Implement ewk_favicon_database_icon_get() by calling
EwkFaviconDatabase::GetIcon() (also added by this patch).
EwkFaviconDatabase holds an instance of EWebContext, needed
in the call chain.
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85278/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14809
Reviewed by: d.waslicki, g.czajkowski, msu.koo
Change-Id: I64ee94547570758a45d9d4aa6c0c8556c8c8f258
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
k2.nagaraju [Fri, 16 Oct 2015 08:00:27 +0000 (13:30 +0530)]
[MM][MSE] seek offset not synced to actual browser seek time
CAPI player_set_position as to be called with actual browser seek time
not with user seeked time. Otherwise CAPI will wait for
(|actual_browser_seek_time| - |seek_offset_|) milliseconds buffer.
Original Patch: http://suprem.sec.samsung.net/gerrit/#/c/53159/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14835
Reviewed by: msu.koo, sm.venugopal, sns.park
Change-Id: I878697fdc98f259a02b9849bc47955464aec2799
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
Lukasz Bialek [Tue, 27 Oct 2015 13:15:20 +0000 (14:15 +0100)]
Add support for Copy/Paste operations for Image element
Although Clipboard operations for text and markups work well,
when image is long-pressed, copied (Copy Image) and pasted - nothing
happens.
This patch introduces copy/paste support of images. This allows
for pasting images to richly editable field and text fields
(URL otherwise).
This patch is a tizen_src part of the implementation (Webkit is here
http://165.213.202.130/gerrit/#/c/95868/), which uses image markup to
generate all necessary clipboard data.
You can check it by selecting "copy image" on html5 "badge" image
and then pasting it into editable area on the following adress:
http://html5demos.com/contenteditable
Original author: Lukasz Bialek <l.bialek@samsung.com>
Based on patch: http://165.213.202.130/gerrit/#/c/92243/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14453
Together with: I11136d8352014f1acca144a0c4416c3bcf432e0c
Reviewed by: a1.gomes, djmix.kim, g.czajkowski
Change-Id: I11126d8352044f1acca044a0c4416e3bcf412e0c
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
Sanghyup Lee [Wed, 2 Dec 2015 22:25:58 +0000 (07:25 +0900)]
Fixed wrong behaviors with HW back button.
1. If IME is shown, context menu and handlers shouldn't be hidden by H/W back
key. Currently context menu and handlers are cleared regardless of IME state
becuase |SelectionControllerEfl::HideHandleAndContextMenu()| is called in
|RWHVEfl::ImeCompositionRangeChanged| which is called when IME is shown or
hidden. This patch removes it.
2. HW back key deletes selected text. |IMContextEfl::OnPreeditChanged| isn't
returned propery when buffer is empty.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15025
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15060
Reviewed by: a1.gomes, djmix.kim, g.czajkowski
Change-Id: If85f59f0121cf36159e4b5d0ea9adda6a9df78d6
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Marcin Niesluchowski [Mon, 17 Aug 2015 11:47:49 +0000 (13:47 +0200)]
Make EwkFaviconDatabase per EWebContext
EwkFaviconDatabase implementation is unsafe and does not allow
ewk_favicon_database_* api implementation.
Associate EwkFaviconDatabase with EWebContext class.
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85277/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14805
Reviewed by: a.renevier, d.waslicki, g.czajkowski
Change-Id: I2df25d877bd958a8f3a8a3f3298069c2f4e62557
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
Aron Kim [Mon, 2 Nov 2015 11:04:24 +0000 (20:04 +0900)]
Change evas gl option to option bits.
[Problem] efl version >= 1.13.2 deprecates mem optimize
environment flags.
[Solution] Add efl mem optimize flags to option bit.
Environment variables for evas surface are not supported
from efl 1.13.2. Environment variables are supported only
for evas engine. With mem optimize option for evas surface,
intermediate buffers created by evas are generated on demand.
16MB 3D memory is reduced.
Original commit: http://165.213.202.130/gerrit/#/c/77299/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14879
Reviewed by: a1.gomes, d.waslicki, dhyuna.ko, hyuki.kim, prashant.n, sns.park
Change-Id: I1c5ca9dfdd1ee8c4cc7cf27f14831112b8d26c1d
Signed-off-by: Aron Kim <aron.kim@samsung.com>
Grzegorz Czajkowski [Mon, 23 Nov 2015 14:53:35 +0000 (15:53 +0100)]
Reimplement range and page scale functionality
minimumPageScaleFactor and maximumPageScaleFactor were removed from
blink::WebView by upstream. Those values were cached by
RenderViewObserverEfl::DidUpdateLayout() to:
1. Prevent user from setting a new scale which is out of the limits.
We don't need to worry about this. Blink will do that for us.
2. Get current scale limits.
Currently it's error prone. For different page (based on their
content width and auto fit calculated scale), call to
ewk_view_scale_range_get() may return different values.
If such functionality is really needed, it should be implemented
using smart callbacks.
Now, ewk_view_scale_range_get() returns default values from
content::WebPreferences.
This commit mostly gets rid of caching scale limits as they are
useless now.
Restore RenderViewObserverEfl::DidChangePageScaleFactor and cache
page scale once it was validated and successfully set by Blink.
This gives us a correct value on Browser side which is currently
using by engine.
Additionally, implemented ubrowser's slider range by using
ewk_view_scale_range_get().
Since the page scale is set asynchronously this patch fixes
utc_blink_ewk_view_scale_get_func.cpp as well.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12080
Reviewed by: a.renevier, a1.gomes, djmix.kim
Change-Id: I62668f2f0f17a59844022dc0df273576b8dfa4f5
Signed-off-by: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Grzegorz Czajkowski [Fri, 27 Nov 2015 10:58:20 +0000 (19:58 +0900)]
Revert "Removal of appending mobile specific flags to TV"
This reverts commit
c5c83cabfe40a882b1fcf6765243506640e0f414.
kUseMobileViewportStyle is not being passed to Renderer for Note4 resulting in
not collecting view port style which defines layout width (980px) for desktop
sites. Without it, desktop sites (google.com/wikipedia.org) have wrong layout.
Secondly, we shouldn't propagate deskotop's mobile flags to TIZEN builds at all.
Not just subset of them. If they are specific for some target they should be
controlled within command_line_efl.cc.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14816
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15031
Reviewed by: a1.gomes, sns.park
Change-Id: If383ae25aea687899949318e55798f5a60aa88bc
Signed-off-by: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Arnaud Renevier [Mon, 23 Nov 2015 20:15:19 +0000 (12:15 -0800)]
fixes crash in utc_blink_ewk_view_javascript_confirm_reply_func test
When calling ewk_view_javascript_confirm_reply, the close dialog
callback is executed. But if returning false from
ewk_view_javascript_confirm_callback_set, the close dialog callback is
also executed.
So, we need to return EINA_TRUE from confirmCallback; otherwise, the
close dialog callback is executed twice, which leads to a crash.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6980
Reviewed by: a1.gomes, g.czajkowski
Change-Id: I7a7300161a52e5180ae52f82301d478d203a2cdd
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
venu.musham [Thu, 26 Nov 2015 11:41:16 +0000 (17:11 +0530)]
Fix issue in context creation for ewkunittests.
[Problem]
ewkunittests fails with error:
"evgl_api_ext_init() glGetString returned NULL!"
[Solution]
Save and Restore GLContext after using surfaceless extension.
Implemented in commit[1], enable in commit[2] for desktop.
commit[1]: http://165.213.202.130/gerrit/#/c/93813/
commit[2]: http://165.213.202.130/gerrit/#/c/96506/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14682
Reviewed by: a1.gomes, sns.park
Change-Id: I67b886b83be8d1af4a3f32cbfff392b3634f3cf1
Signed-off-by: venu.musham <venu.musham@samsung.com>
msu.koo [Thu, 26 Nov 2015 11:20:30 +0000 (20:20 +0900)]
[MM][WebRTC] Fix crash on WebRTC connection with S/W codec
Since M43, GetSupportedProfiles also reflected to VideoDecoder.
This patch is to let gpu_info_collector_efl also collect
decoder accelerator informations.
Also let TizenVideoDecodeAccelerator report supported profiles
which required by GpuVideoDecodeAccelerator.
Bug: http://165.213.149.170/jira/browse/TSAM-594
Reviewed by: sm.venugopal, sns.park
Change-Id: I0df6fdaaa1f7405d095f85a7617e0fe0ca6a7ebb
Signed-off-by: msu.koo <msu.koo@samsung.com>
Antonio Gomes [Tue, 1 Dec 2015 21:16:17 +0000 (17:16 -0400)]
Exit selection mode upon BACK HW press
Hiding selection handles in no enough in order
to exit selection mode upon BACK HW button.
On renderer side, selection will still be active, and
the selection highlight will be still drawn.
Patch fixes this by requesting a "unselecting" text
on the renderer side.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15083
Reviewed by: a.renevier, djmix.kim
Change-Id: I430c9338f9895ee90a2ce8dc117b170af6c93221
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Piotr Krysiewicz [Mon, 23 Nov 2015 13:49:05 +0000 (14:49 +0100)]
Change class members names according to chromium-efl coding style
Several _Ewk_Policy_Decision class members names are typed in camel case style
instead of using underscores
Reviewed by: a1.gomes, d.waslicki, djmix.kim
Change-Id: I19b7541d90aacddd3a863692db8fb4fd7cfdf25a
Signed-off-by: Piotr Krysiewicz <p.krysiewicz@samsung.com>
Lukasz Bialek [Wed, 18 Nov 2015 09:48:53 +0000 (10:48 +0100)]
Add HW Back Key support for select lists and date/color pickers
Previously, select lists and data/color pickers did not react to HW
Back Key for platforms other than MOBILE. This patch adds necessary
callback and introduces expected action for ESC key on TV and
Desktop platforms.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14840
Reviewed by: a1.gomes, d.waslicki, djmix.kim, msu.koo
Change-Id: I2d11d5a8a87cb62a003c2c36cf04803b55a765ff
Signed-off-by: Lukasz Bialek <l.bialek@samsung.com>
Arnaud Renevier [Mon, 23 Nov 2015 19:06:54 +0000 (11:06 -0800)]
fixup! Remove an erroneous scroll callback calls from ScrollDetector::OnChangeScrollOffset.
utc_blink_ewk_view_scroll_by_func.cpp was deleted, but not removed from
ewk-tests.gypi
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13283
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14702
Reviewed by: a.renevier, a1.gomes, djmix.kim, sns.park
Change-Id: If83d681759576017a31e84752e9b70b76a833779
Dongwoo Joshua Im [Fri, 27 Nov 2015 07:15:42 +0000 (16:15 +0900)]
Add g.czajkowski into S_TRUNK_OWNERS file
Change-Id: I9c5cd01fdb7ff7f702806606e7e7bf6f76bfb967
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
k2.nagaraju [Thu, 26 Nov 2015 13:47:19 +0000 (19:17 +0530)]
fixup! [MM][MSE][CAPI] Implement MSE with CAPI port.
CAPI returning internal errors through error callback function.
Updated error handling code to handle CAPI errors.
CAPI player state is updated based on buffer status callback.
Shared memory is wrapped to mediapacket. So, memcpy of input buffer is
reduced.
It fixs minor style violations, which is applied in beta/m42_2311_t.
Reference: http://165.213.202.130/gerrit/#/c/95263/
Reviewed by: msu.koo, sm.venugopal, sns.park
Change-Id: I9a44300f4ca76fe26e44f3f5a85edd0087cc5fb1
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
Wojciech Bielawski [Fri, 27 Nov 2015 10:54:58 +0000 (11:54 +0100)]
Implement ewk_context_favicon_database_directory_set()
There is no implementation of ewk_context_favicon_database_directory_set()
api. This patch adds missing implementation. It will set directory path
to argument passed and filename to default one.
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85276/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14792
Reviewed by: a.renevier, d.waslicki, djmix.kim, msu.koo, sns.park
Change-Id: Ic525ba7e0c9e39e8e91ab480cc5852f5d530a363
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
Tomasz Czekala [Mon, 30 Nov 2015 10:30:18 +0000 (11:30 +0100)]
Add private browsing, incognito, exit and fix style in ubrowser
Added private browsing, new incognito window and exit options and made
pointers style consistent.
This patch is based on the following patch
http://165.213.202.130/gerrit/#/c/87196/
made by Daniel Waślicki
Reviewed by: a.renevier, a1.gomes, d.waslicki, djmix.kim, g.czajkowski
Change-Id: I57904917670bb8f20b8426cdf0d9fda603c9c797
Signed-off-by: Tomasz Czekala <t.czekala@samsung.com>
Wojciech Bielawski [Fri, 27 Nov 2015 10:59:05 +0000 (11:59 +0100)]
Change favicon database's default path
Different users may have problem accessing default database path due to
lack of sufficient rights as current default database's path is same for
whole system regardless of security context.
Put default database path in user home directory making it user dependent.
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85272/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14799
Reviewed by: a.renevier, a1.gomes, d.waslicki, m.roj, sns.park
Change-Id: Ie218d37b238575c65827871fbfe6a23da8ea4d4a
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
Antonio Gomes [Thu, 26 Nov 2015 19:18:59 +0000 (15:18 -0400)]
Fix utc_blink_cb_popup_blocked
Patch executes Javascript strings with non-null user callbacks
with FRH::ExecuteJavaScriptWithUserGestureForTests rather than
FRH::ExecuteJavaScriptForTests.
Former allows window opening.
Patch also fixes the test utc_blink_cb_popup_blocked itself. First part
of the test relies on the popup opening setting being disabled, so
patch ensures it by explicitly set it to FALSE. Second part of the test,
it assumes that popup opening is enabled, so we set it explicitly to
TRUE. Last, after executing the tests, patch sets the setting value to
its original status (see changes in PostSetUp and PreTearDown).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13056
Reviewed by: a.renevier, djmix.kim
Change-Id: I2c2218406901735007435251e0549570b9d031bf
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 26 Nov 2015 16:33:28 +0000 (12:33 -0400)]
fixup! [M47_2526] Chromium upversion to m47_2526 branch
Debug builds of ubrowser assert at startup with the
following backtrace:
#0 0x7f0b4052cfe9 base::debug::StackTrace::StackTrace()
#1 0x7f0b4056e8e3 logging::LogMessage::~LogMessage()
#2 0x7f0b4051c7c3 base::AtExitManager::RegisterTask()
#3 0x7f0b41507f77 ui::DeviceDataManager::CreateInstance()
#4 0x7f0b40502f0b ui::OzonePlatform::InitializeForUI()
#5 0x7f0b3ff5c934 EwkGlobalData::GetInstance()
#6 0x7f0b3ff29390 EWebContext::EWebContext()
#7 0x7f0b3ff29217 EWebContext::EWebContext()
#8 0x7f0b3ffd5013 Ewk_Context::Ewk_Context()
#9 0x7f0b3ffd4e55 Ewk_Context::Create()
#10 0x7f0b3ffd4cb6 Ewk_Context::DefaultContext()
#11 0x7f0b3ffdf188 ewk_context_default_get
#12 0x000000407e04 Browser::Browser()
#13 0x00000040c61b app_create()
#14 0x00000040c935 main
#15 0x7f0b3d874ec5 __libc_start_main
#16 0x000000407b19 <unknown>
This happens because OzonePlatform::InitializeForUI
needs to be called prior to BrowserMainRunner::Initialize (ok)
but past ContentMainRunner::Initialize (not ok).
ContentMainRunner::Initialize initializes exit_maneger at line 525.
Note that for ports like AURA, OzonePlatform::InitializeForUI
is called as part of BrowserMainRunner::Initialize itself with
the following (pseudo) backtrace:
-BrowserMainRunner::Initialize
-BrowserMainLoop::InitializeToolkit
-aura::Env::CreateInstance
-aura::Env::Init
-ui::OzonePlatform::InitializeForUI();
For EFL, it has to be called manually, to we place the call point
prior to calling BrowserMainRunner::Initialize.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14494
Reviewed by: a.renevier, sns.park
Change-Id: I68146a820e44fc21df0716ad7c6e90290616096d
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 26 Nov 2015 15:52:52 +0000 (11:52 -0400)]
Implement ::OnFirstUserGestureObserved and ::HideRequestAutocompleteDialog
Patch implements AutofillClientEfl's OnFirstUserGestureObserved
and HideRequestAutocompleteDialog methods by minic'ing
chrome's implementation.
First method is based on the follow comment in WebViewImpl.cpp:
"On the first input event since page load, |notifier| instructs the
autofill client to unblock values of password input fields of any forms
on the page. There is a single input event, GestureTap, which can both
be the first event after page load, and cause a form submission. In that
case, the form submission happens before the autofill client is told
to unblock the password values, and so the password values are not
submitted. To avoid that, GestureTap is handled explicitly".
Second hides an autocomplete dialog when requested. This happens on
page loads while the autocomplete is shown, etc.
As a consequence of these two methods not being unimplemented,
EWK unit tests are much less verbose too.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14553
Reviewed by: a.renevier, djmix.kim, g.czajkowski, sns.park
Change-Id: I43e3b577435e240b52e67e1ef44112042b38f76a
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Thu, 26 Nov 2015 00:09:39 +0000 (20:09 -0400)]
fixup! Implement ewk_settings_auto_fitting_set
chromium-efl has a mechanism to inform the embedding
app about a blocked window opening. It is the "popup,blocked"
smart signal.
In [1], we removed the EWK specific preference that used to
control window opening by javascript, in favor of chromium's
WebPreferences::javascript_can_open_windows_automatically.
Problem is that this changed the way chromium-efl blocks popups.
When javascript_can_open_windows_automatically is set, it gets
bubbled down to Blink, and popup blocking happens in Blink level
(see third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp,
LocalDOMWindow::open() method).
This makes it impossible to inform the embedding app about a blocked
popup.
Additionally, [1] also started to cache a RenderView instance
(see ContentRendererClientEfl::RenderViewCreated) in order to
query for javascript_can_open_windows_automatically.
This is crash-prone because it caches the latest RenderView
instance created. If the for instance window associated to the
RenderView gets closed, ContentRendererClientEfl will hold a dangling
pointer, and crash upon accessing it.
Patch fixes this by reimplementing the way we control window
opening by javascript. Now
WebPreferences::javascript_can_open_windows_automatically (the chromium
preference) is always ON, so new window creation request messages
always reach the browser process. From there, we can control it
according to the EWK specific setting, and emit the
"popup,blocked" smart signal if needed.
The following EWK unit test were crashing due to this:
- utc_blink_ewk_settings_scripts_can_open_windows_set
Tests were also changed based on the default value of
javascript_can_open_windows_automatically_ewk, which is true.
[1] http://165.213.202.130/gerrit/#/c/92971/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14640
Reviewed by: a.renevier, djmix.kim, g.czajkowski
Change-Id: I3c5e45961265d78c0832387586c4f2aa103f398a
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
umeshk.patel [Wed, 14 Oct 2015 09:51:40 +0000 (15:21 +0530)]
fixup! [MM][MSE][CAPI] Implement MSE with CAPI port.
Previously, Updating the seeking states was fulfilled asynchronously,
but this delayed state update can harm the state handling of seeking.
This patch is to fix updating the seeking state synchronously.
Original patch: http://suprem.sec.samsung.net/gerrit/#/c/52013/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14835
Reviewed by: sm.venugopal, sns.park
Change-Id: I48187edfdd162e772820eb77ab12fbffc7271b2b
Signed-off-by: umeshk.patel <umeshk.patel@samsung.com>
sm.venugopal [Mon, 12 Oct 2015 16:51:15 +0000 (22:21 +0530)]
[MM][ME] HTMLMediaElement error should be set properly.
Proper error should be raised based on the error returned by CAPI
player.
Original Patch: http://suprem.sec.samsung.net/gerrit/#/c/51693/
Bug: http://168.219.209.56/jira/browse/TNEF-6215
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14835
Reviewed by: msu.koo, sm.venugopal, sns.park
Change-Id: I6d3ebefb03fd83f566f19657adced9989a5bb31f
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Grzegorz Ludwikowski [Fri, 20 Nov 2015 15:07:18 +0000 (16:07 +0100)]
Fix memset on std::vector error in ubrowser initialization
In file ewk/ubrowser/main.cc in function main there was memset function
used on an AppData struct, which contains a std::vector member. Memset
on a std::vector can destroy its private data and lead to unexpected
behavior.
Fixed by removing memset and zeroing other members of AppData struct
in its constructor.
This error was reported by cppcheck static analysis tool.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15002
Reviewed by: a.renevier, a1.gomes, d.waslicki, sns.park
Change-Id: Ibaa89e4fa97e88f094f94beaac3318122c61b16b
Signed-off-by: Grzegorz Ludwikowski <g.ludwikowsk@samsung.com>
Grzegorz Ludwikowski [Mon, 23 Nov 2015 13:34:08 +0000 (14:34 +0100)]
Fix uninitialized variable use in SelectionControllerEfl
In file chromium_impl/content/browser/selection/selection_controller_efl.cc
in member function SelectionControllerEfl::ShowContextMenu() variables
blinkX and blinkY are intialized conditionally depending on the result
of web_contents_.GetRenderWidgetHostView(). Later the variables are used
anyway, even if uninitialized. This causes garbage values to be passed
to WebContentsViewEfl::ShowContextMenu member function with no
indication of failure.
Fixed by conditionally calling WebContentsViewEfl::ShowContextMenu
only if web_contents_.GetRenderWidgetHostView() succeeds.
This error was reported by cppcheck static analysis tool.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15001
Reviewed by: a1.gomes, d.waslicki, sns.park
Change-Id: I36ca59bf56d5c9737a03b92a662c8b074797f7f9
Signed-off-by: Grzegorz Ludwikowski <g.ludwikowsk@samsung.com>
p.pajak [Sat, 21 Nov 2015 14:40:18 +0000 (15:40 +0100)]
Enable "Copy link address" context menu option for Wayland
This features was disabled on Tizen 3.0 because Copy/Paste was
not implemented for Wayland. However, after
http://165.213.202.130/gerrit/#/c/91062/ was merged, these
guards can be removed now.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14650
Reviewed by: a.renevier, djmix.kim
Change-Id: I9a291cdbe10c36f2e88a4fb7d43bda5a1394d58e
Signed-off-by: p.pajak <p.pajak@samsung.com>
Grzegorz Czajkowski [Tue, 24 Nov 2015 13:05:12 +0000 (14:05 +0100)]
Define scale limits for "ubrowser --mobile"
OS_TIZEN_MOBILE and ANDROID builds set minimum scale to 0.25
to make auto fitting work [1]. The same should have been done
for ubrowser --mobile.
[1] http://165.213.202.130/gerrit/#/c/95666/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14929
Reviewed by: a1.gomes, djmix.kim
Change-Id: I0f0da8797c5508bb5b3f8f1fa2ce34f23193d39d
Signed-off-by: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Antonio Gomes [Tue, 24 Nov 2015 17:34:41 +0000 (13:34 -0400)]
Fix utc_blink_cb_magnifier_hide.cpp unittest
The test in case (see title) flips selection mode on and off
by calling EWebView::HandleTextSelection{Down,Up}, which bubbles
down to SelectionControllerEfl::TextSelection{Down,Up} respectively.
When SelectionControlleEfl::TextSelectionDown is executed it
needs to "emulate" a long press event, so that the selection
machinary works. Also, when ::TextSelectionUp is called, it relies
on ::long_mouse_press_ being true.
Bug http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13056
Reviewed by: a.renevier, djmix.kim
Change-Id: I76353ba95047ae654826c97936b0369d8f809e7d
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Marcin Niesluchowski [Tue, 17 Nov 2015 11:23:18 +0000 (12:23 +0100)]
Change type of path member of FaviconDatabasePrivate class
path member of FaviconDatabasePrivate type changed from
std::string to base::FilePath making it less error-prone.
Proper checks has been added for that type.
Original beta/m42_2311_t patches:
- http://165.213.202.130/gerrit/#/c/85274/
- http://165.213.202.130/gerrit/#/c/85275/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14785
Reviewed by: d.waslicki, m.roj, msu.koo
Change-Id: Iec556b76f6eaade557b07d55fc42651c3f0d7f93
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
Antonio Gomes [Mon, 23 Nov 2015 20:33:54 +0000 (16:33 -0400)]
fixup! Disambiguate ShowContextMenu implementation.
In case one right clicks with say a bluetooth mouse or on
on desktop builds, context menu should be shown right way.
Patch fixes the broken assuption that
WebContentsViewDelegateEwk::ShowContextMenu should always enter
selection mode. This is only valid in case of touch-based event
source, i.e. on Mobile or ubrowser --mobile.
Patch also fixes utc_blink_cb_contextmenu_allowed.cpp.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14304
Reviewed by: a.renevier, a1.gomes, djmix.kim
Change-Id: Ib409bb5d9ec2492cf622c43eddd710eebb4aabfc
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Youngsoo Choi [Sat, 12 Sep 2015 02:47:50 +0000 (11:47 +0900)]
Enable ContentSecurityPolicy
This patch removes flags of 'EWK_BRINGUP' related to content security policy
and matches enumeration value against the one from Blink.
Reference: http://165.213.202.130/gerrit/#/c/87100/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14791
Reviewed by: a1.gomes, jh11.kwon, sns.park
Change-Id: I620a57118d0ac26416094b0db4d7c6c8aeef53ad
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Piotr Krysiewicz [Wed, 18 Nov 2015 14:51:26 +0000 (15:51 +0100)]
Set 'Policy Decision' to 'Download' when resource mime type is not supported
In webkit2-efl we set Policy Decision to DOWNLOAD when response mime type
is not supported whereas in chromium-efl we do not do that. This causes,
among others, the EWK API ewk_policy_decision_type_get always returns
EWK_POLICY_DECISION_USE. This incorrect behaviour was noticed by browser team
when porting a reference browser form Tizen 2.4 to Tizen 3.0.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14844
Reviewed by: a.renevier, a1.gomes, d.waslicki, sns.park
Change-Id: I90c2d6a5ce82a102f19f25fc32ac038137f98b40
Signed-off-by: Piotr Krysiewicz <p.krysiewicz@samsung.com>
Marcin Kędzierski [Wed, 9 Sep 2015 13:27:12 +0000 (15:27 +0200)]
Change session cookie mode
Using RESTORED_SESSION_COOKIES mode suits better WRT cases.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14212
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/86852/
Reviewed by: a.renevier, a1.gomes, d.waslicki, m.roj, sns.park
Change-Id: I1182100761c23b802e91921a4e4125d64b57fbec
Signed-off-by: Marcin Kędzierski <m.kedzierski@samsung.com>
venu.musham [Fri, 13 Nov 2015 14:51:24 +0000 (20:21 +0530)]
Initialize ScopedRestoreNonOwnedEGLContext instance.
ScopedRestoreNonOwnedEGLContext initialization was commented
during M47 bringup task, there was crash due to uninitialized
shared glcontext.
Since the initialization is fixed in commit[1], this patch brings
back the commented code in M47 bringup.
[1] http://165.213.202.130/gerrit/#/c/94641/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14682
Reviewed by: a1.gomes, sns.park
Change-Id: Iba00908a964398b73184180f4f2903551c1ada53
Signed-off-by: venu.musham <venu.musham@samsung.com>
Wojciech Bielawski [Wed, 18 Nov 2015 09:27:07 +0000 (10:27 +0100)]
[EWK] "title,changed" callback invoked on back and forward actions
Chromium by default doesn't inform view delegates when a page is
reloaded as a result of back and forward actions (the title doesn't
change indeed). This patch modifies this behaviour to fulfill EWK API
requirements.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14206
Together with: I0c6d2110836b6122e51311e3b6f3cb56dcf3dd79
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/85470/
Reviewed by: a.renevier, a1.gomes, djmix.kim, j.majnert, sns.park
Change-Id: I039d6ea43939c38ad1550f78475b20a12a8c5b08
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Sanghyup Lee [Tue, 24 Nov 2015 05:04:31 +0000 (14:04 +0900)]
fixup! Fix ewk_view_visibility_set.
Remove unused functions after [1].
[1] http://165.213.202.130/gerrit/#/c/94980/
Reviewed by: a1.gomes, djmix.kim, sns.park
Change-Id: I36f5ddc09f9c305893fb9ffb702a3b92e8af503f
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Daniel Waślicki [Wed, 16 Sep 2015 10:47:15 +0000 (12:47 +0200)]
Clear contexts on EWebView exit
When user turns on a private browsing mode, we create a new context
and save an old one. If user wants to close a browser under these
circumstance (with private browsing turned on) we have two contexts open
where the default one is unused (default context should be removed
as the last one). In order to work properly we need to delete a temporarily
created context for a private browsing purpose and bring back the default
one.
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/87523/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13557
Reviewed by: a1.gomes, djmix.kim
Change-Id: I6dd1391f9bbbb800f9149a94bf296a4ae7642a22
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Arnaud Renevier [Tue, 24 Nov 2015 00:37:19 +0000 (16:37 -0800)]
Fixes utc_blink_ewk_view_orientation_send_func unittest
In order to fix utc_blink_ewk_view_orientation_send, we need to use the
new screen orientation API instead of window orientation.
Also, an orientation of -90 is transformed into a 270 orientation
by ewk. So, we need to take that into account
In addition, in order to make the test more thorough, we add a test to
check that an invalid orientation value isn't propagated.
Lastly, we remove the files orientation_test1.html,
orientation_test2.html and orientation_test3.html which were unused.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6980
Reviewed by: a1.gomes, djmix.kim
Change-Id: Iae76f08151a753272877d9839c3660842f0b161b
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
p.pajak [Tue, 10 Nov 2015 13:26:39 +0000 (14:26 +0100)]
Implement "Copy link text" context menu option
According to Tizen3.0_mobile_Web_Browser_Browser_UI_Guideline, there should
be a "Copy link address" option when user opens the context menu for a link
by doing a long press. This patch implements this option.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14650
Reviewed by: a.renevier, a1.gomes, djmix.kim, sns.park
Change-Id: I2d51d5a8a87cb32a003c2c33cf04803b55a795ff
Signed-off-by: p.pajak <p.pajak@samsung.com>
Marcin Niesluchowski [Wed, 12 Aug 2015 12:00:59 +0000 (14:00 +0200)]
Remove FaviconService class
FaviconService class is unnecessary proxy of FaviconDatabase singleton
object due to bad implementation.
Remove FaviconService class and use FaviconDatabase api directly. Following
public member functions of FaviconDatabase have been changed to open
database if not opened:
* GetFaviconURLForPageURL
* GetBitmapForPageURL
* GetBitmapForFaviconURL
* SetFaviconURLForPageURL
* SetBitmapForFaviconURL
* ExistsForPageURL
* ExistsForFaviconURL
* Clear
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85273/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14820
Reviewed by: a.renevier, a1.gomes, d.waslicki, sns.park
Change-Id: I49a8eb761a26caa16d526fa377713ed6cbf22f68
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
Arnaud Renevier [Mon, 23 Nov 2015 23:06:20 +0000 (15:06 -0800)]
Use ExecuteJavaScriptForTests instead of ExecuteJavaScript
This ensures that Javascript can be executed (and also, fixes a crash in
unittest utc_blink_ewk_view_script_execute_func.cpp)
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14494
Reviewed by: a1.gomes, sns.park
Change-Id: Ifcdefbacbf796d0eac9455aa1d6f67c017e7058b
Andrzej Badowski [Fri, 13 Nov 2015 16:17:49 +0000 (17:17 +0100)]
Fill in missing copyrights.
Fill in missing parts of the copyrights in the headers of source files.
Original beta/m42 patch: http://165.213.202.130/gerrit/#/c/94645/
Reviewed by: a.renevier, a1.gomes, djmix.kim, j.majnert
Change-Id: Id7360aee2df3a66740818c37bfc10aec99108339
Signed-off-by: Andrzej Badowski <a.badowski@samsung.com>
sm.venugopal [Wed, 18 Nov 2015 16:22:21 +0000 (21:52 +0530)]
[MM] Utilize |WebMediaPlayerParams| while creating media engine instance
|WebMediaPlayerParams| is passed on as argument to be in sync with
upstream code.
Together with: I6e6e327c9a0ba04986f157582321de5ad01e32aa
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14649
Reviewed by: a1.gomes, sns.park
Change-Id: I6d93e70974f2ffa9f45925cbd3ddde1bcc4a1706
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Pawel Forysiuk [Thu, 30 Jul 2015 14:11:29 +0000 (16:11 +0200)]
Re-enable option for message pump optimization
It was disabled by [1] because of regression in touch/click behaviour
in WCS test pages like gesture.html and select_picker_test.html.
1. Fix the implementation of timer delay code. The code previously tried to
micro-manage timer delays. The intention of those delays was to make code
more robust. Unfortunately it would lead to perpetually postponing one task
instead of spawning new ones. Drop the code adding arbitrary delays.
2. Make "limit-memory-allocation-in-schedule-delayed-work" flag be enabled
by default again.
[1] http://165.213.202.130/gerrit/#/c/83920/
Original beta/m42 patch: http://165.213.202.130/gerrit/#/c/84369/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14786
Reviewed by: a1.gomes, msu.koo, sns.park
Change-Id: I1be8b12e84d6a1678e6ab070cf79868076bae5c4
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
p.niemirski [Mon, 10 Aug 2015 07:55:06 +0000 (09:55 +0200)]
'Save image' and 'Save link' doesn't work on context menu
[Problem] Nothing happened after invoke 'Save image' and 'Save link'
commands from context menu. No message, no file is saved.
[Cause] Paths for downloads were set wrong on Tizen v3.0.
[Solution] Set proper paths for given platform.
From now on, 'libtzplatform-config' library will be used to get
proper patch on Tizen v3.0.
Original beta/m42 patch: http://165.213.202.130/gerrit/#/c/84031/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13984
Reviewed by: a.renevier, a1.gomes, sns.park
Change-Id: I00f9fcaff8e2f0786e9913a92d25e871f91a590b
Signed-off-by: p.niemirski <p.niemirski@samsung.com>
ByungJun Kim [Tue, 17 Nov 2015 02:36:05 +0000 (11:36 +0900)]
Show or hide the elm_naviframe when is called ewk_view_visibility_set()
If ewk_view_visibility_set() is called, white screen is shown in mobile.
Since background of elm_naviframe is white, white screen is appear.
When ewk_view_visiblity_set() is called,
elm_naviframe needs shown or hidden.
This patch brought in M42 (http://165.213.202.130/gerrit/#/c/88300/).
Reviewed by: a1.gomes, djmix.kim, msu.koo
Change-Id: I2ae719a8d563c7732a9ba3769e22f1780e8613fb
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Youngsoo Choi [Mon, 17 Aug 2015 10:19:35 +0000 (19:19 +0900)]
Fix path of system folder in spec file
[issue]
The folder '%TZ_SYS_RO_ICONS' and '%TZ_SYS_RO_PACKAGE' have been created
on root path like below.
>> root@localhost:/# ls /
>> %TZ_SYS_RO_ICONS boot home media proc sbin tmp
>> %TZ_SYS_RO_PACKAGE dev lib mnt root srv usr
>> bin etc lost+found opt run sys var
[resolve]
To make the '%TZ_SYS_' definitions properly work,
a package 'libtzplatform-config' needs to be installed.
The package provides the definitions via following file.
>> /PATH/TO/BUILD-ROOTS/scratch.armv7l.0/etc/tizen-platform.conf
Note that the definitions are only valid from tizen v3.0,
supporting multi-user mode.
Also, unused definition '_dbusservicedir' and '_systemduserservicedir' are removed.
original patch: http://165.213.202.130/gerrit/#/c/85251/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14788
Reviewed by: sns.park
Change-Id: Ia8e0dece9d4a7031c35447bfa4c19165436ae406
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Grzegorz Czajkowski [Fri, 20 Nov 2015 13:33:39 +0000 (14:33 +0100)]
Pass "enable-viewport" flag for "ubrowser --mobile"
Mobile build by default turns on WebPreferences::viewport_meta_enabled
This results in setting WebPreferences::viewport_enabled as well:
RenderViewHostImpl::ComputeWebkitPrefs() {
...
prefs.viewport_enabled =
command_line.HasSwitch(switches::kEnableViewport) ||
prefs.viewport_meta_enabled;
}
Since viewport_meta_enabled(true) is set on Renderer side via
ApplyCustomSettings() for ubrowser --mobile, earlier call to
ComputeWebkitPrefs() always sets viewport_enabled to false.
This patch passes "enable-viewport" flag (switches::kEnableViewport)
for ubrowser to make it similar to mobile builds.
This results in different path code while determining layout size
(settings->viewportEnabled() is widely checked on Blink side),
also disabling zooming after tap and showing disambiguation popup for
mobile sites.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14921
Reviewed by: a1.gomes, sns.park
Change-Id: I3be1b4381c627c485e0db5254b4d796c5cd454e1
Signed-off-by: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Marcin Niesluchowski [Wed, 12 Aug 2015 10:32:27 +0000 (12:32 +0200)]
Enable ewk_context_favicon_database_get() also for mobile
ewk_context_favicon_database_get() for mobile profile is not implemented.
Api exists but is defined only for tv profile.
Remove tv profile ifdefs making it work regardless build profile.
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85271/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14784
Reviewed by: sns.park
Change-Id: Ie3931c5ca7a523162556882d36b654758034d32b
Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
ByungJun Kim [Wed, 16 Sep 2015 07:58:51 +0000 (16:58 +0900)]
Fixing wrong evas_object hierarchy in eweb_view.
Previously, using |evas_object_below_get| to get the parent webview
cause warning and required addition of some defensive codes.
To prevent from warning, we should use evas_object_above_get() as
evas_object_below_get() has been misused.
This patch refactored to get the parent webView
from "evas_object_above_get", which is guided by
(https://docs.enlightenment.org/stable/efl/group__Evas__Font__Group.html)
Before the fix, evas_object_ isn't part of the EFL/Elementary layout
tree. So we needed to get value of width and height from ecore_evas.
With this patch, evas_object_ is part of the elementary layout tree.
This defensive code is no longer needed.
Original m42 patch:
- http://165.213.202.130/gerrit/#/c/87501/ .
Change-Id: I677dbde037b798773552de8473a62fdbb8b344ed
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Antonio Gomes [Thu, 19 Nov 2015 22:57:06 +0000 (18:57 -0400)]
Long press on empty fields should show context menu if needed
If one long-presses an empty input field, we enter selection mode:
magnifier is show, etc.
This is a bad UX, and does not match other mobile browsers.
Patch changes that to show context menu right way, with clipboard
options if applicable. This matches other mobile browsers: firefox
mobile, chrome and s-browser.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14910
Change-Id: I002f57a1224431a915740d87e7694db358153493
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
sihoons.yang [Wed, 18 Nov 2015 13:55:47 +0000 (22:55 +0900)]
Implement TitleWasSet() for EWK
On Chromium Upstream, NOTIFICATION_WEB_CONTENTS_DISCONNECTED
and NotificationService was deprecated([1], [2]) and reflected
to ours([3]). Because of this ewk_back_forward_list_item_title_get()
has a problem that return empty.
In this patch, TitleWasSet() is introduced to enable
|ewk_back_forward_list_item_title_get()| from Chromium's guideline([2]).
[1] http://code.google.com/p/chromium/issues/detail?id=170921
[2] https://codereview.chromium.org/
1242953004/patch/1/10004
[3] http://165.213.202.130/gerrit/#/c/92076
Change-Id: I44b4fe8a05f219b3efc7217eb242643c9b61876a
Signed-off-by: sihoons.yang <sihoons.yang@samsung.com>
Antonio Gomes [Thu, 19 Nov 2015 22:55:37 +0000 (18:55 -0400)]
Do not zoom-to-focused-element when long pressing.
zoom-to-focused element should happen on tap.
Long press should not trigger it, as it gives us a bad experience.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14911
Change-Id: I2d20a6ba247330b7a92781042dffc0c205624edd
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
p.pajak [Tue, 10 Nov 2015 08:53:54 +0000 (09:53 +0100)]
Implement "Share link" context menu option for Tizen OS
According to Tizen3.0_mobile_Web_Browser_Browser_UI_Guideline, there should
be a "Share link" option when user opens the context menu for a link
by doing a long press. This patch implements this option for Tizen OS.
Note that the share option requires a share-panel application
which is currently absent on Tizen 3.0
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14650
Change-Id: I51e9a460a2fcb57d298f3521dfe40bcd1a4433a6
Signed-off-by: p.pajak <p.pajak@samsung.com>
ByungJun Kim [Thu, 3 Sep 2015 01:10:19 +0000 (10:10 +0900)]
Close javascript popup when EWebView is deleted.
If EWebView is deleted, it calls destructor of JavaScriptModalDialogEfl
but destructor does nothing.
Destructor needs to close JS popup.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14764
Change-Id: Ib66e6afd43a2665e07ba7588f5bbeeb63f73b187
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
Lukasz Bialek [Sat, 19 Sep 2015 09:42:45 +0000 (11:42 +0200)]
Add popup callbacks for closing with Esc key
[Issue] http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14099
[Problem] Popups are not closed when Esc button is pressed
[Cause] Only Mobile branch supports callbacks for HW back button
[Solution] Add callbacks for Esc button and connect them with
existing popup-closing code
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/87930/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14765
Change-Id: Ic7656ee4a034b95aa5ee71ac85c79711e57d15e7
Signed-off-by: Lukasz Bialek <l.bialek@samsung.com>
Wojciech Bielawski [Mon, 16 Nov 2015 15:10:43 +0000 (16:10 +0100)]
Refactored context menu controller
1. Fill _context_menu_listdata when is_text_selection_ is true
2. Prohibit out of array boundary indexing
3. removed redundant variable _appended_item_size
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/85782/
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Change-Id: Ic53167c11ea06f73e589c3af399f3e431b53b530
Sanghyup Lee [Fri, 20 Nov 2015 01:20:29 +0000 (10:20 +0900)]
Remove an erroneous scroll callback calls from ScrollDetector::OnChangeScrollOffset.
This fixes a scrolling issue/crash.
Since renderer process perform all scrolling operation,
we don't have to handle this events on browser side.
Furthermore browser process handles this event using
ScrollDetector object which emits EFL's smart callbacks,
but there are no events registered on this callback.
Original M42 patch: http://165.213.202.130/gerrit/#/c/82644/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13283
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14702
Change-Id: Id6fcf4120a0d396a3dbbbd6fb5c378666b0671b5
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Wojciech Bielawski [Tue, 25 Aug 2015 14:23:09 +0000 (16:23 +0200)]
Wrongly computed string length in database initialization.
Compute proper string length and only if string is not null.
Original beta/m42_2311_t patch:
- http://165.213.202.130/gerrit/#/c/85780/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14777
Change-Id: I06a19c2f6e413709d7dbf8f5097ab1ee499b28c4
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Marcin Kędzierski [Wed, 9 Sep 2015 13:14:00 +0000 (15:14 +0200)]
Deliver file_storage_type
In SetStoragePathOnIOThread we call SetCookieStoragePath without third
argument, file_storage. It should be set because value for this is
known.
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/86851/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14212
Reviewed by: a.renevier, d.waslicki, msu.koo
Change-Id: I249b12d17c44e8a66249a29d97db1b3b28c664ca
Signed-off-by: Marcin Kędzierski <m.kedzierski@samsung.com>
Marcin Kędzierski [Wed, 2 Sep 2015 09:44:46 +0000 (11:44 +0200)]
Flush Cookies before quiting
In Chromium cookies are stored in two situations. First periodically
every 30 seconds and when closing the browser. In chromium_efl the
second method doesn't work. This causes loosing cookies.
This patch adds storing cookies when closing the browser. When eweb_view
is being destroyed, DeleteSessionCookiesSync is called. This function
removes expired cookies and flushes other.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14212
This patch is based on patch from m40:
http://165.213.202.130/gerrit/#/c/77017
Reviewed by: a.renevier, d.waslicki, msu.koo
Change-Id: I14a8ddc4136a628467b4fe31d1f71fd4a4179d73
Signed-off-by: Marcin Kędzierski <m.kedzierski@samsung.com>
Marcin Kędzierski [Fri, 28 Aug 2015 07:44:07 +0000 (09:44 +0200)]
Delete resource context on IO thread
ewk_shutdown can't close application correctly. One of problems
is removing resources context on UI thread. It should be done on IO
thread because during deleting all resource requests they should be
cancelled and this works on IO thread. This patch moves deleting
resource context to IO thread.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14212
Original beta/m42 patch: http://165.213.202.130/gerrit/#/c/86086/
Signed-off-by: Marcin Kędzierski <m.kedzierski@samsung.com>
Reviewed by: a.renevier, d.waslicki, djmix.kim, msu.koo
Change-Id: I5504bfc6216ce4d3cc909920c7df1801cd728d1f
Dongwoo Joshua Im [Thu, 19 Nov 2015 08:17:47 +0000 (17:17 +0900)]
Add djmix.kim as an owner of chromium-efl
Change-Id: I50f1833bd5685117ea1479d2eba93535eeb2b0a2
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
Antonio Gomes [Mon, 3 Aug 2015 03:18:06 +0000 (23:18 -0400)]
Integrate chromedriver in a simpler way.
In patches [1] and [2], chromedriver was originally
integrated to chromium-efl by forking chrome/chrome_tests.gypi
and making the needed changes: ewk/efl_integration/chromedriver_efl.gypi.
After studying chromedriver build, it was found out that
chrome/chrome.gyp is its main entry point.
Given that chrome.gyp does far more than only warm-up
chromedriver builds, it is not feasible to simply
including it from chromium-efl side.
This patch relies on the s-chromium patch [3] in order to
simplify our chromedriver integration. Now, chromedriver_efl.gypi
(our fork) can be deleted, and we can simply build
'chromedriver' target, instead of 'chromedriver_efl'
Also, we can refer to 'chromedriver' everywhere instead
of 'chromedriver_efl'.
[1] http://165.213.202.130/gerrit/#/c/83743
[2] http://165.213.202.130/gerrit/#/c/83742
[3] http://165.213.202.130/gerrit/#/c/95036
Original beta/m42 patch:
- http://165.213.202.130/gerrit/#/c/85836/ reviewed by
Janusz Majnert, SeungSeop Park.
Together with: Id66b0fe16d6f94c7698dc056f3f1f71f4e536e5f
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14773
Reviewed by: a.renevier, a1.gomes, sns.park
Change-Id: I314e3853fb740848102026cbdeaa6881242ac8c0
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
DongJun Kim [Thu, 19 Nov 2015 07:11:56 +0000 (16:11 +0900)]
Add WillReleaseScriptContext on RenderFrameObserverEfl
|WillReleaseScriptContext| is not implemented
on |RenderFrameObserverEfl| in latest code.
For this reason, |DynamicPluginStopSession| is not called,
when |window.close| is executed by WRT.
This patch is for adding |WillReleaseScriptContext| on |RenderFrameObserverEfl|.
Original beta/m42 patch: http://165.213.202.130/gerrit/#/c/87472
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14771
Reviewed by: a.renevier, msu.koo
Change-Id: Ic1af7c7d99aba94bb0f7e7d7edfdb60114059549
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
Wojciech Bielawski [Thu, 19 Nov 2015 08:15:11 +0000 (09:15 +0100)]
Refactor ewk extensible api implementation
This patch is to refactor:
- remove Ewk_Extensible_API enum from API side since it's not used there
- fix out of array boundary traversal
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/85781/
Reviewed by: a.renevier, d.waslicki, j.majnert, msu.koo
Change-Id: I0e536316a3353d9acdd82bdb98980f87c715a001
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Sanghyup Lee [Thu, 5 Nov 2015 09:45:27 +0000 (18:45 +0900)]
Fix ewk_view_visibility_set.
Visibility state should be changed by ewk_view_visibility_set API.
It means RenderWidgetHostImpl::WasShown|WasHidden should be called.
This behavior overlap with |ewk_view_page_visibility_state_set|.
Therefore, this CL merge EWebView::WasShown|WasHidden and EWebView::Show|Hide.
Original M42 patch: http://165.213.202.130/gerrit/#/c/94374/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14892
Reviewed by: a1.gomes, djmix.kim, j.majnert, sns.park
Change-Id: Id475c52afd8f12f360e145cea3bd9573bf65cfd4
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
Tomasz Czekala [Wed, 18 Nov 2015 11:39:29 +0000 (12:39 +0100)]
Update WebContentsImplEfl::CreateNewWindow to m47 version
WebContentsImplEfl::CreateNewWindow and
WebContentsImplEfl::HandleNewWebContentsCreate are mainly a copy of
WebContentsImpl::CreateNewWindow with some code added, but it wasn't
updated to m47 version of this method. This patch updates it.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14494
Reviewed by: a.renevier, a1.gomes, d.waslicki, msu.koo, sns.park
Change-Id: I5f213e4be567b540c448676391f28943f65604fb
Signed-off-by: Tomasz Czekala <t.czekala@samsung.com>
Pawel Niemirski [Fri, 16 Oct 2015 14:51:52 +0000 (16:51 +0200)]
Create initial implementation of Wayland clipboard
[Issue#] http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12685
[Problem] Clipboard integration for Wayland is not implemented. This
causes internal clipboard implementation to crash.
[Cause] There is no proper support on Wayland side
[Solution] For now Wayland clipboard is simulated as simple
map. This fixes internal clipboard problems and
prevents crashes. However, inter-application actions
are not possible.
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/88493/ , reviewed by
DONGJUN KiM, arno renevier.
Original Author: Lukasz Bialek <l.bialek@samsung.com>
Reviewed by: a.renevier, d.waslicki, djmix.kim, msu.koo
Change-Id: I164f42d204c5864f066a1218c028f9e83fd0c830
Signed-off-by: Pawel Niemirski <p.niemirski@samsung.com>
Pawel Forysiuk [Mon, 16 Nov 2015 12:03:45 +0000 (13:03 +0100)]
Handle placeholder message for missing plugins being untranslated.
kPluginMissingMessage was initialised to untranslated string
because of dgettext call being unable to fetch translated version.
Call dgettext on the actual use instead.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14700
Reviewed by: a.renevier, a1.gomes, d.waslicki, djmix.kim, msu.koo
Change-Id: Ibeb451dd364c8e4678ad2b5c3d26f1e85bb483c7
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
p.pajak [Fri, 13 Nov 2015 16:17:03 +0000 (17:17 +0100)]
Implement "Open" context menu option for links
According to Tizen3.0_mobile_Web_Browser_Browser_UI_Guideline, there should
be an "Open" option, which opens a link in the current window, when user opens
the context menu by doing a long press on a link.
This patch implements this option.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14650
Reviewed by: a.renevier, d.waslicki, djmix.kim, msu.koo
Change-Id: I6a2d3b002e1f2892939cf30e4427928120b626d7
Signed-off-by: p.pajak <p.pajak@samsung.com>
Wojciech Bielawski [Tue, 25 Aug 2015 14:41:17 +0000 (16:41 +0200)]
Fix out of array boundary indexing in autofill popup
Corrected static array indexing. Operations on raw strings replaced
with STL's string operations.
Original beta/m42 patch:
http://165.213.202.130/gerrit/#/c/85783/
Reviewed by: a.renevier, a1.gomes, d.waslicki, j.majnert, msu.koo
Change-Id: I42dcd0b745fa6cadd69864f5b0d0c25130b2d71b
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
sm.venugopal [Tue, 17 Nov 2015 07:18:05 +0000 (12:48 +0530)]
[MM][CAPI] |player_prepare_async| returns error
|player_prepare_async| is already initiated and is taking time to complete
the task. In mean time wrong state is sent to WebCore which then initiates
PLAY. Since player prepare is not complete, state is IDLE and player prepare
is called again.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14692
Reference: http://suprem.sec.samsung.net/gerrit/#/c/55223/
Reviewed by: msu.koo, sm.venugopal, sns.park
Change-Id: Ia68d837ebfd2aa90c3cacdbcca48a9f9e621a4a5
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Tomasz Czekala [Fri, 13 Nov 2015 10:27:23 +0000 (11:27 +0100)]
Added Chromium authors copyright to web_contents_impl_efl.cc
In web_contents_impl_efl.cc we copied parts of CreateNewWindow and
HandleNewWebContentsCreate code from base class implementation, so we
need to add Chromium authors copyright to the file
Reviewed by: a1.gomes, msu.koo
Change-Id: Id88b5d51b923c5ef95832b12535745ba7648e5fe
Signed-off-by: Tomasz Czekala <t.czekala@samsung.com>
uzair.jaleel [Thu, 30 Jul 2015 12:23:33 +0000 (17:53 +0530)]
Removal of appending mobile specific flags to TV
command line flags specific to mobile like "use-mobile-user-agent" and
"use-mobile-viewport-style" are appended by default when we run ubrowser
on mobile and TV and also this results in duplication as these flags are
already present in command_line_efl.cc which is common to all apps like
mini_browser, efl_webview_app and ubrowser.
M42 patch: http://165.213.202.130/gerrit/#/c/84358/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14816
Reviewed by: a1.gomes, sns.park
Change-Id: I916e4f270c182087e18d6bb022a7727d0e8e9590
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
uzair.jaleel [Tue, 1 Sep 2015 06:03:16 +0000 (11:33 +0530)]
Deletion of shader and program objects after use.
Currently both shader objects and program objects are created for
each new instance of RWHV and never deleted. We need to detach and
delete our shader objects as soon as possible. That way the driver
can free up all the memory it is using to hold a copy of the shader
source and unlinked object code, which can be quite substantial.
M42 patch: http://165.213.202.130/gerrit/#/c/86240/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14812
Reviewed by: a1.gomes, sns.park, venu.musham
Change-Id: I2242557f7f5ab7db662af5f3c1c87a6e38087935
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
venu.musham [Wed, 7 Oct 2015 04:22:48 +0000 (09:52 +0530)]
Enable glFlush on tizen 3.0.
glFinish was used when glFlush gave blackscreen on tizen 3.0.
glFlush issue for FBO is fixed in DDK.
This commit enables glFlush again.
DDK Issue: http://168.219.209.56/jira/browse/TSAM-40
m42-commit: http://165.213.202.130/gerrit/#/c/89758/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14782
Reviewed by: a1.gomes, dhyuna.ko, siba.samal, sns.park
Change-Id: I84a6237ecf9b6d0457a3718bc12d391ae7e65adf
Signed-off-by: venu.musham <venu.musham@samsung.com>
k2.nagaraju [Wed, 21 Oct 2015 04:58:04 +0000 (10:28 +0530)]
[MM][MSE][CAPI] Implement MSE with CAPI port.
This CL uses CAPI player to play MSE videos.
Using CAPI es player for playing and
media_packet for rendering.
Bug: http://168.219.209.56/jira/browse/TSAM-308
Original M42 patch: http://165.213.202.130/gerrit/#/c/83824/
Reviewed by: sm.venugopal, sns.park
Change-Id: I010ba280ea355ce59b3826e16ba1fce76f56ec96
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
SeungSeop Park [Mon, 16 Nov 2015 04:03:17 +0000 (13:03 +0900)]
fixup! Add size optimization GCC options
In http://165.213.202.130/gerrit/#/c/75146/17, only arm 32 bit architecure
was considered. This patch is to do the same for arm 64 bit.
By this CL, the size of libchromium-ewk.so changes as follows.
- Before: 106M (73M if strip)
- After : 84M (47M if strip)
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: a1.gomes, msu.koo
Change-Id: I2be86adf2690b8ea8f0b2563a9513542a273d70b
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
ws29.jung [Wed, 18 Nov 2015 01:20:24 +0000 (10:20 +0900)]
[MM][M47] Fix segment fault with GetUserMedia
With Camera capture, new function(OnIncomingCapturedYuvData) is introduced
on M47 and replacing |OnIncomingCapturedVideoFrame| to new function resolve
the segmentation fault problem with GetUserMedia.
Also, using new function does not require allocate buffer on efl(client) side,
so allocating and deallocating functions are removed.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14494
Reviewed by: sm.venugopal, sns.park
Change-Id: I86a8ebdd67a177c27feb5193f2c5c45b43ec1041
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
jiyoonseol [Thu, 29 Oct 2015 10:56:06 +0000 (06:56 -0400)]
ASCII input is not inserted in prompt popups.
Call 'evas_obeject_focus_set' before the prompt popup is shown.
Digits and some special characters (ASCII code) are not inserted in
prompt popup.
ASCII code is inserted by EVAS_OBJECT_KEY_DOWN_CALLBACK.
(characters are inserted by ECORE_IMF.)
Because prompt popup is shown before it is focused,
EVAS_OBJECT_KEY_DOWN_CALLBACK is not delivered to prompt popup.
Bug: http://168.219.209.56/jira/browse/TSAM-447
Reviewed by: a1.gomes, d.waslicki, djmix.kim, sns.park
Change-Id: I08f632cc942526c284da802cdd5910640790d864
Signed-off-by: jiyoonseol <jiyoon.seol@samsung.com>
Antonio Gomes [Fri, 13 Nov 2015 05:49:11 +0000 (01:49 -0400)]
Apply hide/restore selection controls logic to zoom in/out.
When one scrolls around, handles and context menu get temporarily
hidden, and are shown again when the gesture finishes.
In order to match s-browser behavior, patch extends that logic
to zoom in/out gestures.
In summary, once user starts to pinch, controls are temporarily
hidden (similarly to scroll). They are restored when user lift
up his fingers.
Setter and getter methods are also renamed to SetControlsTemporarilyHidden
and AreControlsTemporarilyHidden.
These are the scenarios:
Scrolls
1) when user starts to scroll one ScrollBegin gets emitted.
2) when user stops to scroll one ScrollEnd gets emitted.
So, it is a simple 1:1.
Start pinch zoom
1) When user starts to pinch zoom, first ScrollBegin is emitted, and then
PinchBegin is emitted, so we call SetControlsTemporarilyHidden(true) twice.
The first call, sets hidden status to true, and actually hide the controls.
The second call early returns on line 102.
Stop pinch zoom
1) When user lift up both fingers at the same time, ScrollEnd and PinchEnd are
emitted, so we call SetControlsTemporarilyHidden(false) twice.
The first call checks there is no finger touching the screen. If no, then it sets
status to false, and request showing the controls again. The second call earl
returns in line 102.
2) When user lifts up only one finger, and keeps another down, only PinchEnd
is called. At this point, it calls SetControlsTemporarilyHidden(false), checks
that one finger is still down, and early returns in line 111 - scrolling is
happening now. When user lifts up the last finger, ScrollEnd is emitted,
and SetControlsTemporarilyHidden(false) is called. At this point, it confirms
that no fingers are down, sets the status to false, and request showing
of controls again.
Note that to make sure no finger is on screen, patch exposes
RWHVEfl::pointer_state's GetPointerCount method.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5007
Reviewed by: a.renevier, djmix.kim, sns.park
Change-Id: Ic627be821e9146d3c360463c4a4832d30ab68715
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
kriti.s [Mon, 3 Aug 2015 06:31:39 +0000 (12:01 +0530)]
Remove unused variable "ret" in RenderWidgetHostViewEfl::PaintToSurface()
M42 patch: http://165.213.202.130/gerrit/#/c/84456/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14810
Reviewed by: sns.park, venu.musham
Change-Id: I0c685811d22f2bcf7f44b53b42e7e5a37012219f
Signed-off-by: kriti.s <kriti.s@samsung.com>
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Hyemi [Fri, 30 Oct 2015 12:41:00 +0000 (21:41 +0900)]
[MM] Add gstreamer-fft library and FFTFrameGStreamer.cpp
Change implementation of FFTFrame to use GST FFT library
to remove dependency of FFmpeg library.
1. Add use_gstreamer_fft feature in supplement.gypi
2. Add FFTFrameGStreamer.cpp under chromium_impl
3. Add external dependencies for s-chromium branch
Together with: I4fed3adf4ff682852c922bc1d240e653efe9e722
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14620
Reviewed by: a1.gomes, sns.park
Change-Id: I40121101333fa735ded3bde9f813c036b8aa2c28
Signed-off-by: Hyemi Shin <hyemi.sin@samsung.com>
Antonio Gomes [Tue, 17 Nov 2015 17:37:07 +0000 (13:37 -0400)]
Alternative solution for enabling setAutoZoomFocusedNodeToLegibleScale on desktop.
Patch ties setAutoZoomFocusedNodeToLegibleScale up with a known
EFL/mobile specific runtime toggle: 'mobile-viewport-style'.
This allows setAutoZoomFocusedNodeToLegibleScale to get set when
ubrowser --mobile is called on desktop.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14586
Reviewed by: a.renevier, sns.park
Change-Id: Ib435118732ddbc439a7df13d0ed32223fad5c174
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Chandan Padhi [Wed, 26 Aug 2015 11:07:01 +0000 (16:37 +0530)]
Correction in Javascript console message logging.
Currently, the base/top level url is always logged in the console
message irrespective of the file from which the message actually
comes from, which is incorrect.
With this patch, the filename from where the message actually comes
is logged in the console.
This makes debugging JS errors relatively easier.
M42 patch: http://165.213.202.130/gerrit/#/c/85872/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14803
Reviewed by: a1.gomes, sns.park, venu.musham
Change-Id: I471a8381fbfee572943913dc2fafd3e38f8791c9
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Tomasz Czekala [Tue, 17 Nov 2015 16:31:10 +0000 (17:31 +0100)]
Change velocity tracker strategy to INT1
By using the default velocity tracker strategy (namely LSQ2) we have
been facing issues like scrolling sometimes happening on the
opposite direction of fingers movement. It is caused by poor touch
event's time (sometimes 2 events with different position have very
similar or the same time). LSQ2 strategy is sensitive to such errors.
Patch temporarily changes chromium-efl default velocity tracker
strategy to INT1, a more robust strategy. Once platform side start
to report more accurate event data, we can consider use LSQ2 again.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14807
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14680
Reviewed by: a1.gomes, msu.koo
Change-Id: Ide4f2f98ad0042cef92f8dcc5ea0250294c9079c
Signed-off-by: Tomasz Czekala <t.czekala@samsung.com>
puru [Mon, 16 Nov 2015 10:05:19 +0000 (15:35 +0530)]
[MM][MSE] Multiple DemuxerSeekDone calls
MediaSourceDelegateEfl calls DemuxerSeekDone multiple times,
hence seek offset is updated many times.
Cherry-pick(beta/m42): http://165.213.202.130/gerrit/#/c/93731/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14831
Reviewed by: sm.venugopal, sns.park
Change-Id: I664287631605b947fd983144116a54aac3a780f5
Signed-off-by: puru <puru.dharma@samsung.com>
Grzegorz Czajkowski [Fri, 6 Nov 2015 12:04:53 +0000 (13:04 +0100)]
Ewk_Settings are not preserved after domain change
By default, Chromium creates a renderer process for each
instance of a site the user visits [1]. This result in
creating a new instance of |content::WebPreferences|.
Those preferences are mostly determined on command switches:
WebPreferences RenderViewHostImpl::ComputeWebkitPrefs() {
WebPreferences prefs;
prefs.web_security_enabled =
!command_line.HasSwitch(switches::kDisableWebSecurity);
...
GetContentClient()->browser()->OverrideWebkitPrefs(this, &prefs);
return prefs;
}
After that, newly determined |prefs| are sent to renderer.
The problem is that |Ewk_Settings| has own instance of
|content::WebPreferences| which client (through ewk_settings* API)
is able to change. Once renderer gets changed, RVHImpl calls
ComputeWebkitPrefs() not including client changes at all.
In consequence, settings are not sync between Browser and Renderer.
This patch ensures creation of Ewk_Settings during EWebView
initializaion. First call to ContentBrowserClientEfl::OverrideWebkitPrefs
allows using default WebPreferences values which are computed
based on command line switches. Successive, override RHVImpl's prefs
in favour of Ewk_Settings.
Since Ewk_Setings has own store for EFL specific prefs [2]
there is a need to handle them separately when renderer (RenderView)
is created. What's crucial there, is to send the message to proper
|RVH| which is passed via RenderViewCreated. Using |RVH| from
EWebView/WebContents at that time would result in sending message
to outgoing process.
[1] https://www.chromium.org/developers/design-documents/process-models
[2] http://165.213.202.130/gerrit/#/c/92971/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=14661
Reviewed by: a1.gomes, d.waslicki, sns.park
Change-Id: I53f42080243ae6087c05435d586862c2022f7575
Signed-off-by: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Antonio Gomes [Mon, 16 Nov 2015 20:46:12 +0000 (16:46 -0400)]
Rename AutofillManagerDelegateEfl to AutofillClientEfl.
The fixes a broken nomeclature we carry over since chromium-efl
forked chrome's autofill implementation in [1].
[1] http://suprem.sec.samsung.net/gerrit/#/c/2335/
Original beta/m42 patch:
- http://165.213.202.130/gerrit/#/c/92066/ , reviewed by
Janusz Majnert, arno renevier.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9662
Reviewed by: sns.park
Change-Id: I689b9c007ed6f127f921f3f96021ad22c825f58d
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Fri, 13 Nov 2015 17:47:13 +0000 (13:47 -0400)]
Proper calculate the handle base
There two places where we set the "base" position for a handle:
::ShowHandleAndContextMenuIfRequired and ::HandleDragEndNotification.
If one looks close, will realize that they set the base position
using different heuristics:
(1) the former sets it to the CENTER point of the selection bound.
(2) the later sets it to BOTTOM_{LEFT,RIGHT} point of the selection bound.
In a comment on the code, (1) explains why it uses "CENTER":
"dragging one handle would cause movement of the other".
Although this is really the case if we stop using the center
point in favor of bottom_{left,right}, this fixes the problem on
the wrong place. Moreover, (1) actually causes a bug noticeable when
user performs text selection on pages with different font sizes, e.g.:
<head>
<style>
h1 { font-size: 850%; }
p { font-size: 100%; }
</style>
</head>
<body>
<h1>This is heading</h1>
<p>This is a paragraph.</p>
</body>
When user starts dragging a handle, we calculate the so named "diff_point",
which is an offset from the handle "base" point (set as described above) and
user's actual touch point. On a move, the current handle position is
subtracted by the "diff_point", and result is sent to the renderer as a
selection point.
If user is selecting a text whose font is big, the diff_point will be calculated
as the offset between the center point of the selection bound and the
touch point, which will be large. Then if users drags the handle to select
a content with a smaller font size.
the large "diff_point" value does not apply to the small size content, and
will cause the handle to be disconnected from the selection point.
Patch fixes this by always setting "base position" to the bottom_{left,right}
of the selection bound.
This is also what TouchHandle (used Aura/Android) does; in
ui/touch_selection/touch_handle.cc, see the logic that sets touch_drag_offset_.
Also, patch computes a new offset based on the line height that avoids
synthesizing a point on a line above (or below) the intended line.
See help function .ComputeLineOffsetFromBottom' which mimics its counterpart in
from ui/touch_selection/touch_selection_controller.cc.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14746
Reviewed by: a.renevier, sns.park
Change-Id: I4352958c279c00a4b7dc9e882d639cde0c91f11e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>