platform/upstream/libSkiaSharp.git
11 years agoChange the method for timing individual tiles in bench_pictures.
scroggo@google.com [Mon, 28 Jan 2013 20:40:24 +0000 (20:40 +0000)]
Change the method for timing individual tiles in bench_pictures.

When timing individual tiles in bench_pictures, keep a timer running
across all repeats, and then take the average. The former method of
timing each iteration separately runs into precision errors on some
platforms.

Running on my Mac Pro with OSX 10.8, the cmsecs for the new method
and the old method are roughly the same when checking the CPU time.
When checking the wall time, the old method often gives me 0ms,
while the new method gives me a larger value. I don't think this
can be entirely attributed to rounding though, since on occasion I
see the old method showing a short time period (.05 - .15ms) while
the new method shows .15ms higher (which is in range for the
difference I'm seeing for other tiles where the old method reports
0ms).

Some other changes:
PictureRenderer::resetState now takes a boolean parameter. If called
with false, it will only do a flush, while if called with true, it
will also call finish.

resetState is now called with true everywhere except in between
iterations of drawing the same tile (when timing individual tiles).

render_pictures_main no longer calls resetState directly, since it
already calls end, which calls resetState.

BUG=http://code.google.com/p/skia/issues/detail?id=1066

Review URL: https://codereview.appspot.com/7101060

git-svn-id: http://skia.googlecode.com/svn/trunk@7424 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove vertex layout definitions from GrDrawTarget to GrDrawState.
jvanverth@google.com [Mon, 28 Jan 2013 20:39:48 +0000 (20:39 +0000)]
Move vertex layout definitions from GrDrawTarget to GrDrawState.

This is the first step in revising vertex layouts so that the currently
installed GrEffects determine the current vertex layout.

https://codereview.appspot.com/7235051/

git-svn-id: http://skia.googlecode.com/svn/trunk@7423 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded toString to SkDrawLooper-derived classes
robertphillips@google.com [Mon, 28 Jan 2013 20:21:59 +0000 (20:21 +0000)]
Added toString to SkDrawLooper-derived classes

https://codereview.appspot.com/7195054/

git-svn-id: http://skia.googlecode.com/svn/trunk@7422 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 28 Jan 2013 19:25:51 +0000 (19:25 +0000)]
shape ops work in progress

good checkpoint: nearly all tests pass solidly here

git-svn-id: http://skia.googlecode.com/svn/trunk@7420 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd data() to all QString::toASCII Qt calls to help out Linux compiler
robertphillips@google.com [Mon, 28 Jan 2013 19:25:43 +0000 (19:25 +0000)]
Add data() to all QString::toASCII Qt calls to help out Linux compiler

https://codereview.appspot.com/7232052/

git-svn-id: http://skia.googlecode.com/svn/trunk@7419 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd command line options to debugger
robertphillips@google.com [Mon, 28 Jan 2013 17:43:26 +0000 (17:43 +0000)]
Add command line options to debugger

https://codereview.appspot.com/7221048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7418 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd (disabled) test for big dashing
reed@google.com [Mon, 28 Jan 2013 16:57:29 +0000 (16:57 +0000)]
add (disabled) test for big dashing

git-svn-id: http://skia.googlecode.com/svn/trunk@7417 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debug build. Unreviewed.
senorblanco@chromium.org [Mon, 28 Jan 2013 16:48:51 +0000 (16:48 +0000)]
Fix debug build.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7416 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build break after r7411 when GR_STATIC_RECT_VB is enabled.
bsalomon@google.com [Mon, 28 Jan 2013 16:46:55 +0000 (16:46 +0000)]
Fix build break after r7411 when GR_STATIC_RECT_VB is enabled.
Review URL: https://codereview.appspot.com/7220051

git-svn-id: http://skia.googlecode.com/svn/trunk@7415 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd an origin flag for backend (external) textures. Some textures in WebKit have...
senorblanco@chromium.org [Mon, 28 Jan 2013 16:42:38 +0000 (16:42 +0000)]
Add an origin flag for backend (external) textures.  Some textures in WebKit have a topdown orientation, and skia needs to be notified of this, so that they are not drawn upside-down.

Review URL: https://codereview.appspot.com/7200048

git-svn-id: http://skia.googlecode.com/svn/trunk@7414 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't...
bsalomon@google.com [Mon, 28 Jan 2013 15:35:28 +0000 (15:35 +0000)]
Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7228048

git-svn-id: http://skia.googlecode.com/svn/trunk@7413 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unnecessary ptr derefs int r7411 (deref result is not used).
bsalomon@google.com [Mon, 28 Jan 2013 14:31:19 +0000 (14:31 +0000)]
Remove unnecessary ptr derefs int r7411 (deref result is not used).

git-svn-id: http://skia.googlecode.com/svn/trunk@7412 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove getter of writable GrEffectStage from GrDrawState.
bsalomon@google.com [Mon, 28 Jan 2013 14:26:09 +0000 (14:26 +0000)]
Remove getter of writable GrEffectStage from GrDrawState.

Upcoming changes will require GrDrawState to know things about the set of installed effects. Thus all setting of effects must go through a GrDrawState function (setEffect()). This change accomplishes that.
Review URL: https://codereview.appspot.com/7214045

git-svn-id: http://skia.googlecode.com/svn/trunk@7411 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd missing parameter to overridden onFindClickHandler
mike@reedtribe.org [Mon, 28 Jan 2013 02:21:27 +0000 (02:21 +0000)]
add missing parameter to overridden onFindClickHandler

git-svn-id: http://skia.googlecode.com/svn/trunk@7410 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
rmistry@google.com [Sun, 27 Jan 2013 17:17:19 +0000 (17:17 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7409 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
rmistry@google.com [Sun, 27 Jan 2013 00:10:39 +0000 (00:10 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7408 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Sat, 26 Jan 2013 17:51:52 +0000 (17:51 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7407 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 26 Jan 2013 07:06:02 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTest for (SkipBuildbotRuns) II
rmistry@google.com [Fri, 25 Jan 2013 22:06:14 +0000 (22:06 +0000)]
Test for (SkipBuildbotRuns) II

git-svn-id: http://skia.googlecode.com/svn/trunk@7405 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTest for (SkipBuildbotRuns)
rmistry@google.com [Fri, 25 Jan 2013 21:41:12 +0000 (21:41 +0000)]
Test for (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7404 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoManually parse arguments in submit_try
borenet@google.com [Fri, 25 Jan 2013 20:55:35 +0000 (20:55 +0000)]
Manually parse arguments in submit_try

Argparse not supported with Python < 2.7.
Review URL: https://codereview.appspot.com/7206054

git-svn-id: http://skia.googlecode.com/svn/trunk@7403 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test (SkipBuildbotRuns)
rmistry@google.com [Fri, 25 Jan 2013 20:25:30 +0000 (20:25 +0000)]
Whitespace change to test (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7402 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Handle invalid glyph IDs on drawText methods.
vandebo@chromium.org [Fri, 25 Jan 2013 19:27:23 +0000 (19:27 +0000)]
[PDF] Handle invalid glyph IDs on drawText methods.

Review URL: https://codereview.appspot.com/7179053

git-svn-id: http://skia.googlecode.com/svn/trunk@7401 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix nextRangeU(0, MAX_UINT) div by zero.
bsalomon@google.com [Fri, 25 Jan 2013 19:19:20 +0000 (19:19 +0000)]
Fix nextRangeU(0, MAX_UINT) div by zero.

R=reed@google.com
Review URL: https://codereview.appspot.com/7201058

git-svn-id: http://skia.googlecode.com/svn/trunk@7400 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPresubmit should check that source files end in atleast one newline
rmistry@google.com [Fri, 25 Jan 2013 18:27:34 +0000 (18:27 +0000)]
Presubmit should check that source files end in atleast one newline
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLeave one and only one newline at the end of source files
rmistry@google.com [Fri, 25 Jan 2013 18:26:58 +0000 (18:26 +0000)]
Leave one and only one newline at the end of source files
Review URL: https://codereview.appspot.com/7216043

git-svn-id: http://skia.googlecode.com/svn/trunk@7398 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid O(n) stack space usage in qsort.
bungeman@google.com [Fri, 25 Jan 2013 18:25:17 +0000 (18:25 +0000)]
Avoid O(n) stack space usage in qsort.

git-svn-id: http://skia.googlecode.com/svn/trunk@7397 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreduce array size in debug builds for sortbench. This avoids a stack-overflow
reed@google.com [Fri, 25 Jan 2013 17:49:49 +0000 (17:49 +0000)]
reduce array size in debug builds for sortbench. This avoids a stack-overflow
due to (1) SkTQSort's bad behavior on repeated-keys, and (2) windows-debug doesn't
implement tail-recursion.

Not an issue, since we don't care about perf in our debug builds anyway.

git-svn-id: http://skia.googlecode.com/svn/trunk@7396 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove random from core to utils
bsalomon@google.com [Fri, 25 Jan 2013 17:49:03 +0000 (17:49 +0000)]
Move random from core to utils
Review URL: https://codereview.appspot.com/7193064

git-svn-id: http://skia.googlecode.com/svn/trunk@7395 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test (SkipBuildbotRuns) locally
rmistry@google.com [Fri, 25 Jan 2013 15:28:23 +0000 (15:28 +0000)]
Whitespace change to test (SkipBuildbotRuns) locally

git-svn-id: http://skia.googlecode.com/svn/trunk@7394 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly clear the part of the texture used by the device (duh!)
bsalomon@google.com [Fri, 25 Jan 2013 15:03:18 +0000 (15:03 +0000)]
Only clear the part of the texture used by the device (duh!)

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7205055

git-svn-id: http://skia.googlecode.com/svn/trunk@7393 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodoh: use *srcPtr instead of src (which is now obsolete) when we check for specialLine
reed@google.com [Fri, 25 Jan 2013 14:52:11 +0000 (14:52 +0000)]
doh: use *srcPtr instead of src (which is now obsolete) when we check for specialLine

git-svn-id: http://skia.googlecode.com/svn/trunk@7392 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHid large dashed line optimization behind compiler flag
robertphillips@google.com [Fri, 25 Jan 2013 14:47:48 +0000 (14:47 +0000)]
Hid large dashed line optimization behind compiler flag

https://codereview.appspot.com/7133078/

git-svn-id: http://skia.googlecode.com/svn/trunk@7391 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Fri, 25 Jan 2013 13:30:20 +0000 (13:30 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7390 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Fri, 25 Jan 2013 13:09:15 +0000 (13:09 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7388 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTriggering rebuilds after r7386
rmistry@google.com [Fri, 25 Jan 2013 12:16:34 +0000 (12:16 +0000)]
Triggering rebuilds after r7386

git-svn-id: http://skia.googlecode.com/svn/trunk@7387 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 25 Jan 2013 07:06:46 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7385 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Fri, 25 Jan 2013 04:54:41 +0000 (04:54 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7384 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove ConcaveToTriangles.
bungeman@google.com [Thu, 24 Jan 2013 22:31:01 +0000 (22:31 +0000)]
Remove ConcaveToTriangles.

git-svn-id: http://skia.googlecode.com/svn/trunk@7383 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBottom-up heapsort.
bungeman@google.com [Thu, 24 Jan 2013 22:18:56 +0000 (22:18 +0000)]
Bottom-up heapsort.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7382 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix missing-case-statement warning
reed@google.com [Thu, 24 Jan 2013 22:09:06 +0000 (22:09 +0000)]
fix missing-case-statement warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7381 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 24 Jan 2013 21:47:16 +0000 (21:47 +0000)]
shape ops work in progress

first 100,000 random cubic/cubic intersections working

git-svn-id: http://skia.googlecode.com/svn/trunk@7380 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModify submit_try to work on windows
borenet@google.com [Thu, 24 Jan 2013 21:38:51 +0000 (21:38 +0000)]
Modify submit_try to work on windows
Review URL: https://codereview.appspot.com/7199053

git-svn-id: http://skia.googlecode.com/svn/trunk@7379 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd optional cull-rect to patheffects, so they can do less work if their results
reed@google.com [Thu, 24 Jan 2013 21:03:11 +0000 (21:03 +0000)]
add optional cull-rect to patheffects, so they can do less work if their results
lie outside of the current clip-bounds (the cull rect).
Review URL: https://codereview.appspot.com/7206044

git-svn-id: http://skia.googlecode.com/svn/trunk@7378 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SampleApp ANGLE mode.
bsalomon@google.com [Thu, 24 Jan 2013 20:47:18 +0000 (20:47 +0000)]
Fix SampleApp ANGLE mode.
Review URL: https://codereview.appspot.com/7206052

git-svn-id: http://skia.googlecode.com/svn/trunk@7377 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix spelling error.
bsalomon@google.com [Thu, 24 Jan 2013 19:00:02 +0000 (19:00 +0000)]
Fix spelling error.

git-svn-id: http://skia.googlecode.com/svn/trunk@7376 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange giantdashline test to use 4 intervals, to explicitly avoid the asPoints
reed@google.com [Thu, 24 Jan 2013 18:43:32 +0000 (18:43 +0000)]
change giantdashline test to use 4 intervals, to explicitly avoid the asPoints
special case code (which we may test separately later).

git-svn-id: http://skia.googlecode.com/svn/trunk@7375 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodoh. drawRRect is not on SkDevice.... yet
reed@google.com [Thu, 24 Jan 2013 18:37:53 +0000 (18:37 +0000)]
doh. drawRRect is not on SkDevice.... yet

git-svn-id: http://skia.googlecode.com/svn/trunk@7374 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix logic bug introduced in r7346.
bsalomon@google.com [Thu, 24 Jan 2013 18:28:51 +0000 (18:28 +0000)]
Fix logic bug introduced in r7346.

git-svn-id: http://skia.googlecode.com/svn/trunk@7373 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooverride drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
reed@google.com [Thu, 24 Jan 2013 18:27:42 +0000 (18:27 +0000)]
override drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
and possibly crash trying to raster into an empty device.

http://code.google.com/p/skia/issues/detail?id=1086
Review URL: https://codereview.appspot.com/7193057

git-svn-id: http://skia.googlecode.com/svn/trunk@7372 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate to emphasis the culling aspect of the test (making the line much longer,
reed@google.com [Thu, 24 Jan 2013 17:33:21 +0000 (17:33 +0000)]
update to emphasis the culling aspect of the test (making the line much longer,
and adding hairline and non-hairline cases.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7371 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for giant dashed lines, to test future optimizations for culling
reed@google.com [Thu, 24 Jan 2013 17:17:28 +0000 (17:17 +0000)]
add bench for giant dashed lines, to test future optimizations for culling

git-svn-id: http://skia.googlecode.com/svn/trunk@7368 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH for clarity
reed@google.com [Thu, 24 Jan 2013 16:56:36 +0000 (16:56 +0000)]
use DEF_BENCH for clarity

git-svn-id: http://skia.googlecode.com/svn/trunk@7367 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove method calls on invalid "this" pointer.
bungeman@google.com [Thu, 24 Jan 2013 16:38:23 +0000 (16:38 +0000)]
Remove method calls on invalid "this" pointer.
https://codereview.appspot.com/7198050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7366 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe oval path bench tests used to draw a circle, but I changed them to an oval
jvanverth@google.com [Thu, 24 Jan 2013 15:45:35 +0000 (15:45 +0000)]
The oval path bench tests used to draw a circle, but I changed them to an oval
so that we could track performance changes for ovals. However, rendering the
stroked oval cases are now ~5ms slower since they're larger. This restores them
to something close to their original performance by slightly shrinking the
bounds. This will help determine what effect r7304 may have had.

git-svn-id: http://skia.googlecode.com/svn/trunk@7365 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix sort test.
bungeman@google.com [Thu, 24 Jan 2013 15:06:47 +0000 (15:06 +0000)]
Fix sort test.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7364 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Thu, 24 Jan 2013 15:01:22 +0000 (15:01 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7363 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake all GrContext members that return a texture also ref the texture for the caller.
bsalomon@google.com [Thu, 24 Jan 2013 14:46:47 +0000 (14:46 +0000)]
Make all GrContext members that return a texture also ref the texture for the caller.
Review URL: https://codereview.appspot.com/7198049

git-svn-id: http://skia.googlecode.com/svn/trunk@7362 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv
junov@chromium.org [Thu, 24 Jan 2013 14:38:23 +0000 (14:38 +0000)]
Move code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv

The purpose of this code move is to make it re-usable in order to implement
occlusion culling optimizations in SkPicture similar to what we have now
in SkDeferredCanvas.

BUG=https://code.google.com/p/chromium/issues/detail?id=164530
Review URL: https://codereview.appspot.com/7196046

git-svn-id: http://skia.googlecode.com/svn/trunk@7361 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 24 Jan 2013 07:06:13 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7357 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Thu, 24 Jan 2013 04:15:57 +0000 (04:15 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7356 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd deferred count to GrResource.
bsalomon@google.com [Wed, 23 Jan 2013 21:37:01 +0000 (21:37 +0000)]
Add deferred count to GrResource.

This will be used to determine whether a resource can either be deleted or reinserted in the cache when its ref count reaches zero.
Review URL: https://codereview.appspot.com/7202046

git-svn-id: http://skia.googlecode.com/svn/trunk@7355 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug introduced in r7348, deleting wrapped resources.
bsalomon@google.com [Wed, 23 Jan 2013 21:32:32 +0000 (21:32 +0000)]
Fix bug introduced in r7348, deleting wrapped resources.

git-svn-id: http://skia.googlecode.com/svn/trunk@7354 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace gcl_try with submit_try
borenet@google.com [Wed, 23 Jan 2013 20:54:29 +0000 (20:54 +0000)]
Replace gcl_try with submit_try

submit_try supports both git and svn and hooks directly into depot_tools rather
than calling it in a subprocess.
Review URL: https://codereview.appspot.com/7202044

git-svn-id: http://skia.googlecode.com/svn/trunk@7352 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanges per-tile bench values to use the average of repetitions from new bench log...
bensong@google.com [Wed, 23 Jan 2013 20:51:17 +0000 (20:51 +0000)]
Changes per-tile bench values to use the average of repetitions from new bench log output.
Corresponding logs change was done at https://codereview.appspot.com/7101060/ and this CL needs to be submitted together with that one for data consistency. Then we can turn on timePerTile.
Review URL: https://codereview.appspot.com/7193051

git-svn-id: http://skia.googlecode.com/svn/trunk@7351 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverse sense of convex-quad-fix compiler flag
robertphillips@google.com [Wed, 23 Jan 2013 20:45:26 +0000 (20:45 +0000)]
Reverse sense of convex-quad-fix compiler flag

https://codereview.appspot.com/7206045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7349 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrResource know whether 3D objects' lifetimes are managed by Skia or not.
bsalomon@google.com [Wed, 23 Jan 2013 20:25:22 +0000 (20:25 +0000)]
Make GrResource know whether 3D objects' lifetimes are managed by Skia or not.
Review URL: https://codereview.appspot.com/7201046

git-svn-id: http://skia.googlecode.com/svn/trunk@7348 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7341
edisonn@google.com [Wed, 23 Jan 2013 20:12:31 +0000 (20:12 +0000)]
Revert r7341

git-svn-id: http://skia.googlecode.com/svn/trunk@7347 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland r7342 with fixes.
bsalomon@google.com [Wed, 23 Jan 2013 19:53:46 +0000 (19:53 +0000)]
Reland r7342 with fixes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7346 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert 7342 to investigate failures.
bsalomon@google.com [Wed, 23 Jan 2013 19:09:06 +0000 (19:09 +0000)]
Revert 7342 to investigate failures.

git-svn-id: http://skia.googlecode.com/svn/trunk@7345 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate Android toolchain to NDK r8d with GCC 4.7
djsollen@google.com [Wed, 23 Jan 2013 18:56:38 +0000 (18:56 +0000)]
Update Android toolchain to NDK r8d with GCC 4.7

Review URL: https://codereview.appspot.com/7201045

git-svn-id: http://skia.googlecode.com/svn/trunk@7343 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer.
bsalomon@google.com [Wed, 23 Jan 2013 18:29:21 +0000 (18:29 +0000)]
Add GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer.

A future CL will do the unref'ing of GrResources when converting a GrDrawState to a DeferredState.
Review URL: https://codereview.appspot.com/7181049

git-svn-id: http://skia.googlecode.com/svn/trunk@7342 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf getAdvance fails, getAdvanceData should not assert, but ignored.
edisonn@google.com [Wed, 23 Jan 2013 16:08:15 +0000 (16:08 +0000)]
If getAdvance fails, getAdvanceData should  not assert, but ignored.
Review URL: https://codereview.appspot.com/7127056

git-svn-id: http://skia.googlecode.com/svn/trunk@7341 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd alias for MakeFromIRect (just Make)
reed@google.com [Wed, 23 Jan 2013 15:37:56 +0000 (15:37 +0000)]
add alias for MakeFromIRect (just Make)

git-svn-id: http://skia.googlecode.com/svn/trunk@7340 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse Skia style cast in SkDeviceProperties.
bungeman@google.com [Wed, 23 Jan 2013 15:31:43 +0000 (15:31 +0000)]
Use Skia style cast in SkDeviceProperties.
(Alternative to 7329.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7339 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd rand10 bench for sort, which makes 10% of the entries repeats
reed@google.com [Wed, 23 Jan 2013 14:52:12 +0000 (14:52 +0000)]
add rand10 bench for sort, which makes 10% of the entries repeats
reorder sort tests to make comparisons easier to read

git-svn-id: http://skia.googlecode.com/svn/trunk@7338 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisplay a warning prompt in presubmit if the tree status is in 'Caution'.
rmistry@google.com [Wed, 23 Jan 2013 14:35:58 +0000 (14:35 +0000)]
Display a warning prompt in presubmit if the tree status is in 'Caution'.

Example presubmit output:

Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnsure that streams written using SkFlattenableBuffer's can be read with readByteArra...
djsollen@google.com [Wed, 23 Jan 2013 13:40:40 +0000 (13:40 +0000)]
Ensure that streams written using SkFlattenableBuffer's can be read with readByteArray(...)

Review URL: https://codereview.appspot.com/7138063

git-svn-id: http://skia.googlecode.com/svn/trunk@7335 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 23 Jan 2013 07:06:17 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7332 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Wed, 23 Jan 2013 05:47:03 +0000 (05:47 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7331 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for sorting
mike@reedtribe.org [Wed, 23 Jan 2013 02:23:40 +0000 (02:23 +0000)]
add bench for sorting

git-svn-id: http://skia.googlecode.com/svn/trunk@7330 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSpeculative fix for cros_daisy compilation failure
robertphillips@google.com [Wed, 23 Jan 2013 01:46:26 +0000 (01:46 +0000)]
Speculative fix for cros_daisy compilation failure

include/core/SkDeviceProperties.h:82:51: error: narrowing conversion of '(((int)orientation) | ((int)layout))' from 'int' to 'uint8_t

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7329 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for oversight in r7325
robertphillips@google.com [Wed, 23 Jan 2013 00:36:02 +0000 (00:36 +0000)]
Fix for oversight in r7325

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7328 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove declaration of unimplemented function.
bsalomon@google.com [Tue, 22 Jan 2013 22:04:13 +0000 (22:04 +0000)]
Remove declaration of unimplemented function.

git-svn-id: http://skia.googlecode.com/svn/trunk@7327 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSwitch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.
bsalomon@google.com [Tue, 22 Jan 2013 20:35:13 +0000 (20:35 +0000)]
Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7188046

git-svn-id: http://skia.googlecode.com/svn/trunk@7326 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug in 1xN SkBitmapProcShader optimization
robertphillips@google.com [Tue, 22 Jan 2013 20:29:16 +0000 (20:29 +0000)]
Fix bug in 1xN SkBitmapProcShader optimization

https://codereview.appspot.com/7187047/

git-svn-id: http://skia.googlecode.com/svn/trunk@7325 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix r7321 build errors on non-windows compilers (using forward declared but not...
bsalomon@google.com [Tue, 22 Jan 2013 20:10:17 +0000 (20:10 +0000)]
Fix r7321  build errors on non-windows compilers (using forward declared but not defined class in templated function).

git-svn-id: http://skia.googlecode.com/svn/trunk@7324 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Android only code in SkDraw for 7317.
bungeman@google.com [Tue, 22 Jan 2013 20:00:01 +0000 (20:00 +0000)]
Fix Android only code in SkDraw for 7317.

git-svn-id: http://skia.googlecode.com/svn/trunk@7322 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLet them eat GrEffectRef.
bsalomon@google.com [Tue, 22 Jan 2013 19:55:59 +0000 (19:55 +0000)]
Let them eat GrEffectRef.

Changes the remaining existing code that operates on naked GrEffects to GrEffectRef.
Review URL: https://codereview.appspot.com/7124058

git-svn-id: http://skia.googlecode.com/svn/trunk@7321 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix VC++ warning and Android only code for 7317.
bungeman@google.com [Tue, 22 Jan 2013 19:49:33 +0000 (19:49 +0000)]
Fix VC++ warning and Android only code for 7317.

git-svn-id: http://skia.googlecode.com/svn/trunk@7319 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded multi-select deletion to debugger
robertphillips@google.com [Tue, 22 Jan 2013 19:38:46 +0000 (19:38 +0000)]
Added multi-select deletion to debugger

https://codereview.appspot.com/7190043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7318 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpose geometry and gamma on device.
bungeman@google.com [Tue, 22 Jan 2013 19:25:14 +0000 (19:25 +0000)]
Expose geometry and gamma on device.
https://codereview.appspot.com/6499101/

git-svn-id: http://skia.googlecode.com/svn/trunk@7317 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd wrapper for "gcl try"
borenet@google.com [Tue, 22 Jan 2013 18:23:56 +0000 (18:23 +0000)]
Add wrapper for "gcl try"

Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048

git-svn-id: http://skia.googlecode.com/svn/trunk@7315 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix saving modified skp from debugger
robertphillips@google.com [Tue, 22 Jan 2013 18:03:56 +0000 (18:03 +0000)]
Fix saving modified skp from debugger

https://codereview.appspot.com/7181048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7314 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimple Build fix. Unreviewed.
junov@chromium.org [Tue, 22 Jan 2013 18:01:26 +0000 (18:01 +0000)]
Simple Build fix. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7313 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing invalid text clipping on SkPicture playback
junov@chromium.org [Tue, 22 Jan 2013 17:50:47 +0000 (17:50 +0000)]
Fixing invalid text clipping on SkPicture playback

The bug was caused by an invalid assumption that a flattend object's
index is related to its array index in SkFlatDictionary::fData.
The data in SkFlatDictionary is sorted by flattened data content,
not by index number. Problem was solved by passing down the SkFlatData*
through addPaint, rather than the index value. The bug was causing
SkPictureRecord::addFontMetricsTopBottom to use cached font metrics
from the wrong SkPaint instance.

BUG=https://code.google.com/p/chromium/issues/detail?id=170964
Review URL: https://codereview.appspot.com/7178045

git-svn-id: http://skia.googlecode.com/svn/trunk@7312 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded toString to SkXfermode-derived classes (for debugger)
robertphillips@google.com [Tue, 22 Jan 2013 14:32:09 +0000 (14:32 +0000)]
Added toString to SkXfermode-derived classes (for debugger)

https://codereview.appspot.com/7139058/

git-svn-id: http://skia.googlecode.com/svn/trunk@7308 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter...
jvanverth@google.com [Tue, 22 Jan 2013 13:54:52 +0000 (13:54 +0000)]
Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.

git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GPU support for axis-aligned ovals:
jvanverth@google.com [Tue, 22 Jan 2013 13:34:01 +0000 (13:34 +0000)]
Add GPU support for axis-aligned ovals:
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test

Review URL: https://codereview.appspot.com/7137050

git-svn-id: http://skia.googlecode.com/svn/trunk@7304 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 22 Jan 2013 12:55:54 +0000 (12:55 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7303 2bbb7eff-a529-9590-31e7-b0007b416f81