Zbigniew Jędrzejewski-Szmek [Mon, 9 Mar 2015 20:04:42 +0000 (16:04 -0400)]
efivars: use more _cleanup_
Also rename r to buf, since r is customarily reserved for the return value.
Zbigniew Jędrzejewski-Szmek [Mon, 9 Mar 2015 19:57:56 +0000 (15:57 -0400)]
efivars: do binary and before converting to bool
I'm pretty sure that this is what was meant here.
Zbigniew Jędrzejewski-Szmek [Mon, 9 Mar 2015 19:55:24 +0000 (15:55 -0400)]
efivars: rename last remaining err to r
Zbigniew Jędrzejewski-Szmek [Mon, 9 Mar 2015 19:54:39 +0000 (15:54 -0400)]
efivars: modernization
Fix return value if unlink fails.
Zbigniew Jędrzejewski-Szmek [Mon, 9 Mar 2015 19:12:17 +0000 (15:12 -0400)]
boot/efi: do not assign variable twice
If the highlighted line did not move outside of the visible
region, it should not be necessary to update idx_last.
CID #1287137, #1287138.
Thomas Hindoe Paaboel Andersen [Mon, 9 Mar 2015 20:08:22 +0000 (21:08 +0100)]
machinectl: remove unused variables
Lennart Poettering [Mon, 9 Mar 2015 18:57:39 +0000 (19:57 +0100)]
fsck: modernize error handling
Lennart Poettering [Mon, 9 Mar 2015 18:50:37 +0000 (19:50 +0100)]
fsck: use _cleanup_close_pair_ where appropriate
Lennart Poettering [Mon, 9 Mar 2015 18:41:01 +0000 (19:41 +0100)]
fsckd: make sure we free the connection event source before we close the connection fd
Lennart Poettering [Mon, 9 Mar 2015 18:36:46 +0000 (19:36 +0100)]
fsckd: don't allow unbounded numbers of clients
Lennart Poettering [Mon, 9 Mar 2015 18:34:10 +0000 (19:34 +0100)]
fsckd: make sure unprivileged clients cannot play games with fsckd
Lennart Poettering [Mon, 9 Mar 2015 18:33:49 +0000 (19:33 +0100)]
fsckd: free client event source before we close its fd
Sylvain Plantefève [Mon, 9 Mar 2015 17:36:59 +0000 (18:36 +0100)]
po: update French translation
Add strings for importd, following
587fec427c80b6c34dcf1d7570f891fcb652a7c5
Lennart Poettering [Mon, 9 Mar 2015 18:23:36 +0000 (19:23 +0100)]
fsck: rename functions to reflect some object orientation
Let's clean up the function naming scheme and put the object they
operate on first in the name, the way OO programming usually does it.
Also, let's make sure can properly destroy half-initialized Manager
objects.
Lennart Poettering [Mon, 9 Mar 2015 17:58:05 +0000 (18:58 +0100)]
fsck: don't read invalid data
Lennart Poettering [Mon, 9 Mar 2015 17:57:58 +0000 (18:57 +0100)]
fsckd: internaly check if a client already was cancelled
Lennart Poettering [Mon, 9 Mar 2015 17:57:11 +0000 (18:57 +0100)]
fsck: simplify client destruction logic
Lennart Poettering [Mon, 9 Mar 2015 17:45:50 +0000 (18:45 +0100)]
fsckd: rework plymouth connection management
- the even source should not be freed before the fd for it is closed
- read() returns an ssize_t and we need to handle it as such
- properly handle errors from read()
- reuse on_plymouth_disconnect() whenever we disconnect from plymouth,
and rename it plymouth_disconnect hence()
Lennart Poettering [Mon, 9 Mar 2015 17:30:37 +0000 (18:30 +0100)]
fscd: fix error handling
Lennart Poettering [Mon, 9 Mar 2015 17:30:18 +0000 (18:30 +0100)]
fsck: no need for a temporary variable
Lennart Poettering [Mon, 9 Mar 2015 17:29:08 +0000 (18:29 +0100)]
fsckd: fix error handling when sending cancel request to fsck client
Lennart Poettering [Mon, 9 Mar 2015 17:21:34 +0000 (18:21 +0100)]
fsck: unify exit path for connect_plymouth()
Lennart Poettering [Mon, 9 Mar 2015 17:19:56 +0000 (18:19 +0100)]
fsck: use only a single exit code ternary operator
Lennart Poettering [Mon, 9 Mar 2015 17:19:23 +0000 (18:19 +0100)]
fsck: simplification
Lennart Poettering [Mon, 9 Mar 2015 17:16:54 +0000 (18:16 +0100)]
fsckd: the error code is actually returned in 'fd'
Also, we don't use {} for single-line if-blocks.
Lennart Poettering [Mon, 9 Mar 2015 17:16:36 +0000 (18:16 +0100)]
fsckd: simplify code a bit
Lennart Poettering [Mon, 9 Mar 2015 17:16:20 +0000 (18:16 +0100)]
fsckd: make use of safe_close()'s return value
Lennart Poettering [Mon, 9 Mar 2015 17:01:47 +0000 (18:01 +0100)]
man: document that ExecStartPre= is not the place to start long-running processes
Lennart Poettering [Mon, 9 Mar 2015 16:55:59 +0000 (17:55 +0100)]
build-sys: add one more Makefile symlink
Lennart Poettering [Mon, 9 Mar 2015 16:55:07 +0000 (17:55 +0100)]
importd: add API for exporting container/VM images
Also, expose it in machinectl.
Lennart Poettering [Sun, 8 Mar 2015 23:09:46 +0000 (00:09 +0100)]
udev: use inttypes.h types wherever appropriate
Lennart Poettering [Sun, 8 Mar 2015 23:07:44 +0000 (00:07 +0100)]
tree-wide: use _packed_ macro instead of raw gcc __attribute__
Tom Gundersen [Mon, 9 Mar 2015 15:16:23 +0000 (16:16 +0100)]
udevd: close race in udev settle
The udev-settle guarantees that udevd is no longer processing any of the
events casued by udev-trigger. The way this works is that it sends a
synchronous PING to udevd after udev-trigger has ran, and when that returns
it knows that udevd has started processing the events from udev-trigger.
udev-settle will then wait for the event queue to empty before returning.
However, there was a race here, as we would only update the /run state at
the beginning of the event loop, before reading out new events and before
processing the ping.
That means that if the first uevent arrived in the same event-loop iteration
as the PING, we would return the ping before updating the queue state in /run
(which would happen on the next iteration).
The race window here is tiny (as the /run state would probably get updated
before udev-settle got a chance to read /run), but still a possibility.
Fix the problem by updating the /run state as the last step before returning
the PING.
We must still update it at the beginning of the loop as well, otherwise we
risk being stuck in poll() with a stale state in /run.
Reported-by: Daniel Drake <drake@endlessm.com>
Michael Olbrich [Mon, 9 Mar 2015 11:27:25 +0000 (12:27 +0100)]
missing.h: add NDA_*
This is necessary to build with older kernel headers. NDA_VLAN was
introduced in v3.9 and NDA_PORT, NDA_VNI and NDA_IFINDEX in v3.10
Torstein Husebø [Mon, 9 Mar 2015 12:02:56 +0000 (13:02 +0100)]
Fix typos
Sergey Ptashnick [Sun, 8 Mar 2015 15:51:41 +0000 (18:51 +0300)]
po: update Russian translation - pluralize fsckd
Correctly pluralize strings for fsckd.
Zbigniew Jędrzejewski-Szmek [Sun, 8 Mar 2015 15:11:50 +0000 (11:11 -0400)]
sd-journal: return error when we cannot open a file
Lack of this caused journalctl not to display a hint about missing groups
properly when the user lacks permissions.
Zbigniew Jędrzejewski-Szmek [Sun, 8 Mar 2015 15:04:59 +0000 (11:04 -0400)]
journalctl: update hint now that we set ACL everywhere
Sergey Ptashnick [Sun, 8 Mar 2015 14:41:23 +0000 (17:41 +0300)]
po: update Russian translation - importd
Add strings for importd, by analogy with
1eb37584a8.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 20:05:50 +0000 (15:05 -0500)]
bus: fix leak in error path
CID #1271349.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 20:00:22 +0000 (15:00 -0500)]
systemctl: remove dead check
r could never be less than zero.
CID #1271350.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:36:14 +0000 (14:36 -0500)]
core/load-fragment: safe_close() protects errno
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:30:56 +0000 (14:30 -0500)]
libsystemd-terminal: use at most LOG_ERR for XKB errors
XKB errors aren't *that* important.
Coverity complained that the same action is taken in multiple
branches, which is semi-valid, so is fixed too (CID #1256582).
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:23:38 +0000 (14:23 -0500)]
login: fix copy-pasto in error path
CID #1256583.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:19:20 +0000 (14:19 -0500)]
nspawn: fix use-after-free and leak in error paths
CID #1257765.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:16:18 +0000 (14:16 -0500)]
core/dbus-manager: remove dead check
CID #1257766.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:09:50 +0000 (14:09 -0500)]
bus-util: remove stray errno assignment
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:06:35 +0000 (14:06 -0500)]
networkctl: avoid leak if a field was specified twice
The input data would have to be borked, so this is unlikely to happen,
but since we have a nice helper function to do it properly... why not?
CID #1261390.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 19:01:45 +0000 (14:01 -0500)]
machine: do not rely on asprintf setting arg on error
Strictly speaking, the output variable is undefined if asprintf fails.
We use the return value not the arg everywhere, and should we do here.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 18:54:32 +0000 (13:54 -0500)]
v4l_id: use standard option parsing loop
Not terribly important, but the loop wasn't an actual loop,
making coverity unhappy.
CID #1261725.
Zbigniew Jędrzejewski-Szmek [Sat, 7 Mar 2015 18:40:48 +0000 (13:40 -0500)]
shared/machine-pool: remove unnecessary check
CID #128739.
Ivan Shapovalov [Sat, 7 Mar 2015 15:11:32 +0000 (18:11 +0300)]
sysusers: do not reject users with already present /etc/shadow entries
This is needed to interoperate firstboot and sysusers. The former one is started
first, and it writes only /etc/shadow when it is told to set the root password.
It's better to relax checks here than to duplicate functionality in firstboot.
Ivan Shapovalov [Wed, 25 Feb 2015 23:46:24 +0000 (02:46 +0300)]
firstboot: set all spwd fields to -1 for consistency with sysusers
Ivan Shapovalov [Sat, 7 Mar 2015 13:44:52 +0000 (08:44 -0500)]
core: do not spawn jobs or touch other units during coldplugging
Because the order of coldplugging is not defined, we can reference a
not-yet-coldplugged unit and read its state while it has not yet been
set to a meaningful value.
This way, already active units may get started again.
We fix this by deferring such actions until all units have been at
least somehow coldplugged.
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=88401
Shawn Landden [Sat, 7 Mar 2015 09:43:32 +0000 (01:43 -0800)]
adjust for time spent in timedated even without dbus timestamp
it is trivial to fall back to our own timestamp
v2: use now()
v3: remove useless if ()
v4: add comment
Sylvain Plantefève [Fri, 6 Mar 2015 23:56:46 +0000 (00:56 +0100)]
po: update French translation
Jan Engelhardt [Tue, 24 Feb 2015 16:49:02 +0000 (17:49 +0100)]
vconsole: match on vtcon events, not fbcon ones
I observe that upon loading of framebuffer drivers, I do not get the
desired system font, but the kernel-level defaults (usually
lib/fonts/font_8x16.c, but your mileage may vary depending on kernel
config and boot options).
The fbcon driver may be loaded at a time way before the first
framebuffer device is active, such that the vconsole setup helper
runs too early.
The existing rule is non-fitting. The going live of the fbcon kernel
component does not indicate the proper time at which to load the
visuals, which really ought to be done when a new vtcon object comes
into existence. (The font table is a per-vtcon property.)
David Herrmann [Fri, 6 Mar 2015 13:37:09 +0000 (14:37 +0100)]
login: make hold-off timeout configurable
This introduces 'HoldoffTimeoutSec' to logind.conf to make
IGNORE_LID_SWITCH_{SUSPEND,STARTUP}_USEC configurable.
Background: If an external monitor is connected, or if the system is
docked, we want to ignore LID events. This is required to support setups
where a laptop is used with external peripherals while the LID is closed.
However, this requires us to probe all hot-plugged devices before reacting
to LID events. But with modern buses like USB, the standards do not impose
any timeout on the slots, so we have no chance to know whether a given
slot is used or not. Hence, after resume and startup, we have to wait a
fixed timeout to give the kernel a chance to probe devices. Our timeout
has always been generous enough to support even the slowest devices.
However, a lot of people didn't use these features and wanted to disable
the hold-off timer. Now we provide a knob to do that.
Peter Hutterer [Fri, 6 Mar 2015 01:02:04 +0000 (11:02 +1000)]
hwdb: add Lenovo W451 to TOUCHPAD_HAS_TRACKPOINT_BUTTONS list
Lennart Poettering [Thu, 5 Mar 2015 15:52:15 +0000 (16:52 +0100)]
machinectl: minor --help text improvements
Martin Pitt [Thu, 5 Mar 2015 13:58:56 +0000 (14:58 +0100)]
tmpfiles: Fix handling of duplicate lines
Commit
3f93da987 accidentally dropped the "return 0" after detection of a
duplicate line. Put it back, to get back the documented and intended "first
match wins" behaviour.
https://launchpad.net/bugs/1428540
Jonathon Gilbert [Thu, 5 Mar 2015 10:29:56 +0000 (20:29 +1000)]
hwdb: add Logitech G5 Laser Mouse
Jay Faulkner [Fri, 20 Feb 2015 21:59:47 +0000 (21:59 +0000)]
nspawn: Map all seccomp filters to capabilities
This change makes it so all seccomp filters are mapped
to the appropriate capability and are only added if that
capability was not requested when running the container.
This unbreaks the remaining use cases broken by the
addition of seccomp filters without respecting requested
capabilities.
Co-Authored-By: Clif Houck <me@clifhouck.com>
[zj: - adapt to our coding style, make struct anonymous]
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 13:33:15 +0000 (08:33 -0500)]
build-sys: generate CLEANFILES from EXTRA_DIST
Everything that is generated can be assumed to belong to CLEANFILES,
which means that the original file has to be in EXTRA_DIST. Simplify
the rules by generating as in $subject.
We have less lists to adjust manually, and 'make clean' actually
removes more stuff that before.
Hannes Reinecke [Wed, 4 Mar 2015 15:32:17 +0000 (16:32 +0100)]
Allow up to 4096 simultaneous connections
On large system we hit the limit on 512 simultaneous dbus
connections, resulting in tons of annoying messages:
Too many concurrent connections, refusing
This patch raises the limit to 4096.
Hannes Reinecke [Wed, 4 Mar 2015 15:32:16 +0000 (16:32 +0100)]
Remove the cap on epoll events
Currently the code will silently blank out events if there are more
then 512 epoll events, causing them never to be handled at all. This
patch removes the cap on the number of events for epoll_wait, thereby
avoiding this issue.
Zbigniew Jędrzejewski-Szmek [Thu, 5 Mar 2015 01:25:04 +0000 (20:25 -0500)]
hwdb: fix Dell XPS12 9Q33 key name
https://bugs.freedesktop.org/show_bug.cgi?id=84437
Mirco Tischler [Thu, 5 Mar 2015 00:22:01 +0000 (01:22 +0100)]
build-sys: fix check for efi-lds file
Using the DIR macro breaks caching and has no benefit as it only offers
performance improvements when AS_FOR is used with a single element list.
Also --with-lds-dir= was broken as we never set have_efi_lds in this case.
Fix this and check if PATH actually contains the efi-lds file.
John Paul Adrian Glaubitz [Wed, 4 Mar 2015 23:07:33 +0000 (00:07 +0100)]
Use correct uname identifiers in arch_map for SuperH architecture
https://bugs.freedesktop.org/show_bug.cgi?id=89421
Zachary Cook [Wed, 4 Mar 2015 23:43:20 +0000 (18:43 -0500)]
man: replace obsolete wiki link with man page
Lennart Poettering [Wed, 4 Mar 2015 23:56:08 +0000 (00:56 +0100)]
importd: add new bus calls for importing local tar and raw images
This also adds "machinectl import-raw" and "machinectl import-tar" to
wrap these new bus calls.
THe commands basically do for local files that "machinectl pull-raw" and
friends do for remote files.
Lennart Poettering [Wed, 4 Mar 2015 17:54:08 +0000 (18:54 +0100)]
pull: improve --help text
Lennart Poettering [Wed, 4 Mar 2015 17:53:37 +0000 (18:53 +0100)]
import: split out compression logic, so that we can share it with between import and pull calls
Lennart Poettering [Wed, 4 Mar 2015 16:07:12 +0000 (17:07 +0100)]
import: rename download code from "import" to "pull"
That way we can call the code for local container/VM imports "import"
without confusion.
Thomas Haller [Tue, 3 Mar 2015 20:06:29 +0000 (21:06 +0100)]
sd-dhcp6-client: delay setting the DUID and don't fail constructor
sd_dhcp6_client_new() tried to set the DUID based on the machine id.
If the host has no /etc/machine-id, the constructor would fail
making it impossible to create an sd_dhcp6_client instance.
Relax this and create a DUID only later as needed. This way a caller
caller can workaround a missing machine-id file and set a DUID of his
choosing via sd_dhcp6_client_set_duid().
Jan Janssen [Tue, 3 Mar 2015 18:49:48 +0000 (19:49 +0100)]
networkd: Make DHCP client ID creation configurable
Tom Gundersen [Wed, 4 Mar 2015 09:33:50 +0000 (10:33 +0100)]
networkd: netdev - inform when we take over an existing netdev
The crucial point here is that we will not change the settings of a netdev created by someone else
we simply use it as is and trust it was set up as intended.
This is confusing in the case of the pre-created netdev's (bond0 etc.), the solution should probably
be to simply make the kernel stop creating these devices as they are pretty useless.
Peter Hutterer [Wed, 4 Mar 2015 03:24:45 +0000 (13:24 +1000)]
hwdb: add pnpid for the T450s touchpad
https://bugs.freedesktop.org/show_bug.cgi?id=89411
Zbigniew Jędrzejewski-Szmek [Wed, 4 Mar 2015 00:07:28 +0000 (19:07 -0500)]
shared/util: assume ac when /sys/class/power_supply is missing
On s390 (at least) /sys/class/power_supply is not present. We should
treat this like if this directory was empty, and not an error.
Zbigniew Jędrzejewski-Szmek [Wed, 4 Mar 2015 00:10:21 +0000 (19:10 -0500)]
Do not advertise .d snippets over main config file
For daemons which have a main configuration file, there's
little reason for the administrator to use configuration snippets.
They are useful for packagers which need to override settings, but
we shouldn't advertise that as the main way of configuring those
services.
https://bugs.freedesktop.org/show_bug.cgi?id=89397
Ross Burton [Tue, 3 Mar 2015 11:37:52 +0000 (11:37 +0000)]
tmpfiles.d: only copy /etc/pam.d if PAM is present
If HAVE_PAM isn't set then don't attempt to copy /etc/pam.d from the
factory, as it doesn't get installed.
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 14:00:39 +0000 (09:00 -0500)]
README: mention ACLs more
They are now useful for any fs used for journal storage.
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 15:36:47 +0000 (10:36 -0500)]
Do not run sysv-generator-test when sysv compat is disabled
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 02:39:55 +0000 (21:39 -0500)]
build-sys: add fsckd.h to sources
Otherwise distribution tarfiles are not generated properly.
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 05:21:10 +0000 (00:21 -0500)]
build-sys: systemd.conf is generated, do not distribute
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 05:05:14 +0000 (00:05 -0500)]
bus-proxyd: avoid logging oom twice
Zbigniew Jędrzejewski-Szmek [Tue, 3 Mar 2015 05:02:31 +0000 (00:02 -0500)]
fsck: remove unnecessary check
gcc was complaining that progress_rc might be used uninitalized.
But it was actually always set, because the condition was always
satisfied. Remove the condition.
Hans-Peter Deifel [Mon, 2 Mar 2015 23:35:08 +0000 (00:35 +0100)]
tmpfiles: quietly ignore ACLs on unsupported filesystems
A warning is printed if ACLs cannot be retrieved for any reason other
than -ENOSYS. For -ENOSYS, debug log is printed.
Sergey Ptashnick [Sun, 1 Mar 2015 21:37:45 +0000 (00:37 +0300)]
po: update Russian translation
Add some forgotten strings for systemd, logind and machined.
Lennart Poettering [Mon, 2 Mar 2015 23:20:23 +0000 (00:20 +0100)]
update TODO
Lennart Poettering [Mon, 2 Mar 2015 23:13:12 +0000 (00:13 +0100)]
importd: automatically grow /var/lib/machines/ loopback filesystem during downloads
If /var/lib/machines is mounted as btrfs loopback file system in
/var/lib/machines.raw with this change we automatically grow the file
system as it fills up. After each 10M we write to it during imports, we
check the free disk space, and if the fill level grows beyond 66% we
increase the size of the file system to 3x the fill level (thus lowering
it to 33%).
Lennart Poettering [Mon, 2 Mar 2015 23:11:51 +0000 (00:11 +0100)]
man: fix typo
Lennart Poettering [Mon, 2 Mar 2015 19:55:38 +0000 (20:55 +0100)]
sd-daemon: replace VLA with alloca(), to make llvm happy
https://bugs.freedesktop.org/show_bug.cgi?id=89379
Lennart Poettering [Mon, 2 Mar 2015 19:25:32 +0000 (20:25 +0100)]
update TODO
Lennart Poettering [Mon, 2 Mar 2015 19:24:11 +0000 (20:24 +0100)]
import: add support for gpg2 for verifying imported images
gpg2 insists on created a trust db even if we tun off all trust db
support. Hence create a temporary home where the trust db is placed, and
remove it after use.
Lennart Poettering [Mon, 2 Mar 2015 18:35:50 +0000 (19:35 +0100)]
man: document that machinectl set-limit creates a btrfs loopback too
Lennart Poettering [Mon, 2 Mar 2015 18:21:04 +0000 (19:21 +0100)]
machined: also set up /var/lib/machines as btrfs, if "machinectl set-limit" is called
Cristian Rodríguez [Mon, 2 Mar 2015 00:13:10 +0000 (21:13 -0300)]
journal: fix Inappropriate ioctl for device on ext4
Logs constantly show
systemd-journald[395]: Failed to set file attributes: Inappropriate ioctl for device
This is because ext4 does not support FS_NOCOW_FL.
[zj: fold into one conditional as suggested on the ML and
fix (preexisting) r/errno confusion in error message.]
Zbigniew Jędrzejewski-Szmek [Mon, 2 Mar 2015 15:34:51 +0000 (10:34 -0500)]
journal-remote: fix saving of binary fields
Binary fields were not processed properly, and resulting journal files
were non-conforming, resulting in an error ("Invalid field.") when reading.
https://bugs.freedesktop.org/show_bug.cgi?id=89391
Zbigniew Jędrzejewski-Szmek [Mon, 2 Mar 2015 03:46:43 +0000 (22:46 -0500)]
build-sys: allow lto and FORTIFY_SOURCE with -O[sz]
https://bugs.freedesktop.org/show_bug.cgi?id=89382