Sejong Oh [Fri, 1 Apr 2016 23:09:00 +0000 (16:09 -0700)]
Fix singlinkgen test.
If the address of SingLink is stored at stack, GC.Collect() cannot collect
the object since the address variable is still alive at stack.
Commit migrated from https://github.com/dotnet/coreclr/commit/
030136228abccb8b6d4737f92358bec8a9a50c09
Brian Sullivan [Wed, 30 Mar 2016 21:54:40 +0000 (14:54 -0700)]
Merge pull request dotnet/coreclr#4003 from briansull/update-tests-lst
Update with 10 additional passing tests, and two moved to unstable
Commit migrated from https://github.com/dotnet/coreclr/commit/
531de762ff569f52049e35cb69032b9c3da22238
Jan Kotas [Wed, 30 Mar 2016 21:34:59 +0000 (14:34 -0700)]
Merge pull request dotnet/coreclr#4005 from dotnet/revert-3943-upstream-gawk-char-class
Revert "Fix bracket expression matches a character at gawk"
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef38b9d88463c427896457f7f03b3c2976c9b307
Jan Kotas [Wed, 30 Mar 2016 21:32:52 +0000 (14:32 -0700)]
Revert "Fix bracket expression matches a character at gawk"
Commit migrated from https://github.com/dotnet/coreclr/commit/
e65dcb5321a86f0d4e1cee92e2f36f8c84013904
Brian Sullivan [Wed, 30 Mar 2016 18:31:00 +0000 (11:31 -0700)]
Update with 10 additional pasing tests, and two moved to unstable
Commit migrated from https://github.com/dotnet/coreclr/commit/
575eecb4ae0415f2be2196a0435c79ff6365eff9
David Mason [Wed, 30 Mar 2016 20:15:29 +0000 (13:15 -0700)]
Merge pull request dotnet/coreclr#3955 from davmason/master
Fixing tracelogging on linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
d47a3984e4f3277337c710579407d3a5e1d94714
Kyungwoo Lee [Wed, 30 Mar 2016 18:01:52 +0000 (11:01 -0700)]
Merge pull request dotnet/coreclr#3996 from kyulee1/fixconv
ARM64: Fix conversion double to unsigned int
Commit migrated from https://github.com/dotnet/coreclr/commit/
831ce3c7db6b532420dcb778918a7554a6fc2965
Kyungwoo Lee [Wed, 30 Mar 2016 16:16:26 +0000 (09:16 -0700)]
ARM64: Fix conversion double to unsigned int
For ARM/ARM64, converting negative double to unsigned int is 0, which aligns with all native compilers.
I also removed the part of tests that depends on architecture specific values.
Since ARM64 tests were prepopulated, I just updated the tag so that we can update the tests later.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bbfdcebb6bed3ed646bb5e17028166bcc9404653
Sejong Oh [Wed, 30 Mar 2016 17:33:31 +0000 (10:33 -0700)]
Merge pull request dotnet/coreclr#3960 from sejongoh/check_runtime_to_pull_coredistools
Add architeture information to a script downloading coredistools
Commit migrated from https://github.com/dotnet/coreclr/commit/
debff19365d06a66fc3cd50342ded48518a25f01
Jan Kotas [Wed, 30 Mar 2016 17:26:28 +0000 (10:26 -0700)]
Merge pull request dotnet/coreclr#3983 from svick/getresourcestring-culture
Remove unused CultureInfo from GetResourceString
Commit migrated from https://github.com/dotnet/coreclr/commit/
918bb2e8bfb46d44291507d4b0d017f8aba5b0d8
Davis Goodin [Wed, 30 Mar 2016 16:10:54 +0000 (11:10 -0500)]
Merge pull request dotnet/coreclr#3994 from dagood/upgrade-cli
Apply dotnet cli upgrade also to tests\dir.props
Commit migrated from https://github.com/dotnet/coreclr/commit/
72f6c4e1d552474f80b1814288eeb79e09e5760f
Davis Goodin [Wed, 30 Mar 2016 16:07:30 +0000 (11:07 -0500)]
Apply dotnet cli upgrade also to tests\dir.props.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f9fc3284d2c864aff5b685548470813359a07d02
Stephen Toub [Wed, 30 Mar 2016 16:02:24 +0000 (12:02 -0400)]
Merge pull request dotnet/coreclr#3993 from dagood/upgrade-cli
Upgrade dotnet cli version
Commit migrated from https://github.com/dotnet/coreclr/commit/
a4bb869f1091f2514f5cd705a5e3548d0d28b62a
Davis Goodin [Wed, 30 Mar 2016 15:03:53 +0000 (10:03 -0500)]
Upgrade dotnet cli version.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e2aa428f40d85b84f7de4a13124dcd96ec600a1c
Jan Kotas [Wed, 30 Mar 2016 07:10:26 +0000 (00:10 -0700)]
Merge pull request dotnet/coreclr#3943 from leemgs/upstream-gawk-char-class
Fix bracket expression matches a character at gawk
Commit migrated from https://github.com/dotnet/coreclr/commit/
817fec1799d13c089b14ed168f8c691b00e4d5e9
Jan Kotas [Wed, 30 Mar 2016 07:08:35 +0000 (00:08 -0700)]
Merge pull request dotnet/coreclr#3984 from svick/patch-1
Removed obsolete comment from Environment.GetResourceString
Commit migrated from https://github.com/dotnet/coreclr/commit/
a88f97abc317021ac742a6409791b26fc98068c7
Jan Kotas [Wed, 30 Mar 2016 03:27:37 +0000 (20:27 -0700)]
Merge pull request dotnet/coreclr#3985 from myungjoo/trivialfix/macro1
Trivial fix: dangerous macro usage
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f5a98309136ec5693a87f5d5cb77c8f98012f90
MyungJoo Ham [Wed, 30 Mar 2016 02:43:48 +0000 (11:43 +0900)]
Trivial fix: dangerous macro usage
Add parenthesis to make the macro safe.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
a7405648da7544d0bd1a6728986ced8b0f189638
Petr Onderka [Wed, 30 Mar 2016 02:24:23 +0000 (04:24 +0200)]
Removed obsolete comment from Environment.GetResourceString
Fixes dotnet/coreclr#3979
Commit migrated from https://github.com/dotnet/coreclr/commit/
0e3c5de2f004916e6cb640fe83e2781a6029500d
Petr Onderka [Wed, 30 Mar 2016 02:08:50 +0000 (04:08 +0200)]
remove unused CultureInfo from GetResourceString
Commit migrated from https://github.com/dotnet/coreclr/commit/
6408f73fed3864806f921f0175928efb1dfccab8
Brian Sullivan [Wed, 30 Mar 2016 00:31:30 +0000 (17:31 -0700)]
Merge pull request dotnet/coreclr#3974 from briansull/update-tests-lst
Disabled 8 failing tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0638c5b6aecec87b3a8aac8c808152c86febe9d
Brian Sullivan [Tue, 29 Mar 2016 21:50:53 +0000 (14:50 -0700)]
Disabled 8 failing tests
Issues filed: 3968, 3969, 3970, 3971 and 3973
Commit migrated from https://github.com/dotnet/coreclr/commit/
176b2d6f5004b39a5ffe04ce99619c365122ef2b
Kyungwoo Lee [Tue, 29 Mar 2016 21:14:42 +0000 (14:14 -0700)]
Merge pull request dotnet/coreclr#3966 from kyulee1/fixframe2
ARM64: Fix Frame with compLocallocUsed
Commit migrated from https://github.com/dotnet/coreclr/commit/
e9426290b6525747a0cde96b7a4ebe89ec391dd0
Kyungwoo Lee [Fri, 25 Mar 2016 18:19:25 +0000 (11:19 -0700)]
ARM64: Fix Frame with compLocallocUsed
When compLocallocUsed is true, stack pointer is changed during the run.
So, JIT should restore stack pointer from frame pointer in the epilog.
Previously, we simpliy copied fp to sp, which is only valid for frameType
= 1.
This implements a right restoring process for other frameTypes (2 and 3).
For frameType = 3, I also simplified creating prolog sequence to support
this feature consistently.
Commit migrated from https://github.com/dotnet/coreclr/commit/
68c70fa6f7207ee4acfd7f6cf511e91d46bdcf53
Aditya Mandaleeka [Tue, 29 Mar 2016 18:59:33 +0000 (11:59 -0700)]
Merge pull request dotnet/coreclr#3963 from adityamandaleeka/statFileParse
Fix stat file parsing to handle executable names with spaces
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef8af95b971a79fa0714fbeb39653a7581b4373f
Brian Sullivan [Tue, 29 Mar 2016 18:07:42 +0000 (11:07 -0700)]
Merge pull request dotnet/coreclr#3959 from briansull/safe-refactor
Safe Refactor - Remove conditional definition and references to lvIsMultiRegArgOrRet
Commit migrated from https://github.com/dotnet/coreclr/commit/
2a55928860a74bad0dc1947631e5657d64ebbf35
Stephen Toub [Tue, 29 Mar 2016 16:38:00 +0000 (12:38 -0400)]
Merge pull request dotnet/coreclr#2182 from justinvp/keyedcollection_enumallocs
Avoid enumerator allocations inside KeyedCollection<TKey, TItem>
Commit migrated from https://github.com/dotnet/coreclr/commit/
04569c541137efcdb84848555cbf038074a955d5
Stephen Toub [Tue, 29 Mar 2016 14:25:56 +0000 (10:25 -0400)]
Merge pull request dotnet/coreclr#2178 from justinvp/keyedcollection_nullchecks
Remove unnecessary null checks from KeyedCollection<TKey,TItem>
Commit migrated from https://github.com/dotnet/coreclr/commit/
587cbb77129c31e93c5b5ccbe03bb6c41dc5821c
Aditya Mandaleeka [Tue, 29 Mar 2016 03:22:04 +0000 (20:22 -0700)]
Fix stat file parsing to handle executable names with spaces.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b66da08912d8b43c39f743e5a65515d3e74ec432
Sejong Oh [Mon, 28 Mar 2016 20:41:42 +0000 (13:41 -0700)]
Add architeture information to a script downloading coredistools
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7f5398362e05e2ce6921af781ea4af7f3f75837
Brian Sullivan [Fri, 25 Mar 2016 22:39:37 +0000 (15:39 -0700)]
Safe Refactor - Remove conditional definition and references to lvIsMultiRegArgOrRet
Commit migrated from https://github.com/dotnet/coreclr/commit/
344dba53965e61a971eea5cfcb3e8d4e5c688149
Jan Kotas [Mon, 28 Mar 2016 14:36:16 +0000 (07:36 -0700)]
Merge pull request dotnet/coreclr#3954 from leemgs/toolchain-name-unifyin-arm64
[Linux/ARM32/64] Unifying the redundant usages of cross-toolchain
Commit migrated from https://github.com/dotnet/coreclr/commit/
e25eb2cc4e9fd8ea56364aad99c3be9f16f671d8
Geunsik Lim [Mon, 28 Mar 2016 03:08:09 +0000 (12:08 +0900)]
[Linux/ARM32/64] Unifying the redundant usages of cross-toolchain
The name of toolchain name has been increasing gradually.
Let's unify the toolchain name of Linux/ARM{32|64} to prevent the
increase of the fragmentation, and to the manatainability.
Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Commit migrated from https://github.com/dotnet/coreclr/commit/
4eb537dcf4d9780f70b3a68b6f0d1d61cd9a836b
Jan Kotas [Sat, 26 Mar 2016 17:40:04 +0000 (10:40 -0700)]
Merge pull request dotnet/coreclr#3946 from leemgs/toolchain-name-unifying
[Linux/ARM32] Unifying the redundant usages of cross-toolchain
Commit migrated from https://github.com/dotnet/coreclr/commit/
48ce56b9fcd1b5edf5ca28f83d7b623b71e5c925
Joseph Tremoulet [Sat, 26 Mar 2016 16:24:14 +0000 (12:24 -0400)]
Merge pull request dotnet/coreclr#3902 from JosephTremoulet/ZeroExtend
Unsuppress same-reg zero-extending mov (x64)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8d34c2f299cfbd26783e2deb7e982bf611885d0a
Geunsik Lim [Sat, 26 Mar 2016 12:53:08 +0000 (21:53 +0900)]
[Linux/ARM32] Unifying the redundant usages of cross-toolchain
The name of toolchain name has been increasing gradually.
Let's unify the toolchain name of Linux/ARM32 to prevent the
increase of the fragmentation, and to the manatainability.
Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Commit migrated from https://github.com/dotnet/coreclr/commit/
12924be33d6d84a2e78e98291dfdd03cb621fc21
Geunsik Lim [Sat, 26 Mar 2016 10:04:31 +0000 (19:04 +0900)]
Fix: bracket expression matches a character at gawk
This is a trivial patch. However, It's must be modified by gawk.
Check it exactly as a plain character (e.g., space, alnum)
within the bracket expression at ./coreclr/generateversionscript.awk
Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ecdf767806842e9d09db879d4fdd98cef7b9810
Aditya Mandaleeka [Sat, 26 Mar 2016 07:00:55 +0000 (00:00 -0700)]
Merge pull request dotnet/coreclr#3896 from adityamandaleeka/configvalues4
Add new configuration mechanism for CoreCLR.
Commit migrated from https://github.com/dotnet/coreclr/commit/
775003a4c72f0acc37eab84628fcef541533ba4e
Jan Kotas [Sat, 26 Mar 2016 04:06:26 +0000 (21:06 -0700)]
Merge pull request dotnet/coreclr#3931 from Godin/fix-typos
Fix copy-paste typos
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f1aef23dac7f26b048e8910dab42d948c9b9c9c
Carol Eidt [Sat, 26 Mar 2016 01:22:46 +0000 (18:22 -0700)]
Merge pull request dotnet/coreclr#3920 from CarolEidt/ChangeLdObjToObj
1stClassStructs: Replace GT_LDOBJ with GT_OBJ
Commit migrated from https://github.com/dotnet/coreclr/commit/
9d8513352e858ad3b739626e062f0133698a7111
Jan Kotas [Sat, 26 Mar 2016 01:11:44 +0000 (18:11 -0700)]
Merge pull request dotnet/coreclr#3928 from manu-silicon/patch-3
Fix invalid path to genXplatLttng.py
Commit migrated from https://github.com/dotnet/coreclr/commit/
24cab6db08b1c7f0c297abefa7fa27bd88082505
Aditya Mandaleeka [Sat, 12 Mar 2016 02:39:27 +0000 (18:39 -0800)]
Add new configuration mechanism for CoreCLR.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1aa1b8ba64365f8b93a505d4f6165c6eaad84a7a
Brian Sullivan [Sat, 26 Mar 2016 00:34:50 +0000 (17:34 -0700)]
Merge pull request dotnet/coreclr#3934 from briansull/remove-lvaAdjustRefCnts
Remove empty phase lvaAdjustRefCnts
Commit migrated from https://github.com/dotnet/coreclr/commit/
1378dbbb0baffc737018503adb0310859a46eb0c
Carol Eidt [Thu, 24 Mar 2016 20:29:39 +0000 (13:29 -0700)]
1stClassStructs: Replace GT_LDOBJ with GT_OBJ
In preparation for using block nodes in assignments, change GT_LDOBJ to GT_OBJ.
Also, eliminate gtFldTreeList, which was only
being used in a transitory fashion for x87
codegen - instead create the nodes on the fly as needed for stack fp codegen.
Additional minor cleanup.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3789f42252a2faf577f90841fb944256c637b4f2
Andy Ayers [Fri, 25 Mar 2016 22:51:33 +0000 (15:51 -0700)]
Merge pull request dotnet/coreclr#3933 from AndyAyersMS/RefactorPolicy
Inliner: refactor policies to extract common legality portion
Commit migrated from https://github.com/dotnet/coreclr/commit/
117825e88bb1c21f626938a8b101fcd175015319
Andy Ayers [Fri, 25 Mar 2016 22:49:54 +0000 (15:49 -0700)]
Merge pull request dotnet/coreclr#3924 from AndyAyersMS/Fix-VSO-205323
Inliner: fix issue introduced by refactoring
Commit migrated from https://github.com/dotnet/coreclr/commit/
4042556fe08e0eaac0ea8379b7f8e12dec60e5eb
Brian Sullivan [Fri, 25 Mar 2016 22:22:46 +0000 (15:22 -0700)]
Remove empty phase lvaAdjustRefCnts
Commit migrated from https://github.com/dotnet/coreclr/commit/
46460db255be36aeb52cb1df9156b7b0b06e380c
Kyungwoo Lee [Fri, 25 Mar 2016 21:56:59 +0000 (14:56 -0700)]
Merge pull request dotnet/coreclr#3932 from kyulee1/arm64tool
Fix ARM64 lib toolchain
Commit migrated from https://github.com/dotnet/coreclr/commit/
12870d860aebfeff0bd92d3919c88b3ed7519359
Joseph Tremoulet [Thu, 24 Mar 2016 14:56:36 +0000 (10:56 -0400)]
Unsuppress same-reg zero-extending mov (x64)
Update CodeGen::genIntToIntCast to stop suppressing 32-bit same-register
`mov`s, and to stop assuming that 32-bit enregistered sources already have
the top half of their register clear. This latter assumption is usually
true, but is not guaranteed across function boundaries by the ABI. As it
happens, the runtime code that invokes custom attribute constructors can
pass garbage in the top half of such parameters; this change adds a
testcase that fails on that path without this fix.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e1c9e27795e49f05af417efe10c01c0774e28f32
Andy Ayers [Fri, 25 Mar 2016 18:56:25 +0000 (11:56 -0700)]
Inliner: refactor policies to extract common legality portion
Now that we have multiple policies, refactor their implementation
to extract common elements. In particular all the existing
policies have the same legality and ability constraints, so this
logic is extracted to a partial `LegalPolicy` superclass.
Adresses relevant feedback on dotnet/coreclr#3697, where the number of policies
increased from one to two.
No changes in behavior.
Commit migrated from https://github.com/dotnet/coreclr/commit/
da7c4410075f7211d077cb4e8c8ef368659dbb0c
David Mason [Fri, 25 Mar 2016 18:26:33 +0000 (11:26 -0700)]
Fixing tracelogging on linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
c23c38d36c0fabb9ee861643dade9b4f56ff1e61
Kyungwoo Lee [Fri, 25 Mar 2016 18:19:25 +0000 (11:19 -0700)]
Fix ARM64 lib toolchain
This fixes path for the right libs that are consistent with tools.
With this, crossgen.exe can run natively on arm64.
fix
Commit migrated from https://github.com/dotnet/coreclr/commit/
8690b1f42331f2e859f5314c2f6a6dca8dfbcd19
Evgeny Mandrikov [Fri, 25 Mar 2016 17:17:49 +0000 (18:17 +0100)]
Fix copy-paste typos
Commit migrated from https://github.com/dotnet/coreclr/commit/
eaa2cf6470a57e6ba35c4d9c94b488ae6afad94d
David Mason [Fri, 25 Mar 2016 17:14:26 +0000 (10:14 -0700)]
Merge pull request dotnet/coreclr#3907 from davmason/master
Fix spurious warning about parameter counts
Commit migrated from https://github.com/dotnet/coreclr/commit/
764c9b52cfb7f631cc30ed23e7072c6eb04e195f
Jan Kotas [Fri, 25 Mar 2016 16:55:49 +0000 (09:55 -0700)]
Merge pull request dotnet/coreclr#3930 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
aedfba00f7977b2c00022df74d1bbe03e73260c8
Andy Ayers [Fri, 25 Mar 2016 15:28:13 +0000 (08:28 -0700)]
Merge pull request dotnet/coreclr#3908 from AndyAyersMS/JitTimeData
Inliner: collect jit time data
Commit migrated from https://github.com/dotnet/coreclr/commit/
e316b5571a34181e08d7f912fab96795ad2ee035
Jan Kotas [Fri, 25 Mar 2016 14:28:56 +0000 (07:28 -0700)]
Fix build break on full framework
[tfs-changeset: 1589984]
Commit migrated from https://github.com/dotnet/coreclr/commit/
7b97c58fef96875e672ddc271ded8c11dc416c76
Emmanuel [Fri, 25 Mar 2016 06:29:08 +0000 (15:29 +0900)]
Fix invalid path to genXplatLttng.py
Commit migrated from https://github.com/dotnet/coreclr/commit/
bec80abd245604aedbf9b89d7e4393e49a8056cf
Jan Kotas [Fri, 25 Mar 2016 03:21:35 +0000 (20:21 -0700)]
Merge pull request dotnet/coreclr#3900 from jkotas/legacynetcf
Delete legacy netcf compat support (final part)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6357b20ea0542f674fc323be172cd44d122318d
Jan Kotas [Fri, 25 Mar 2016 03:21:10 +0000 (20:21 -0700)]
Merge pull request dotnet/coreclr#3921 from myungjoo/fix/3859
Fix dotnet/coreclr#3859 ARM/Unwind: explicitly mark the end of stack
Commit migrated from https://github.com/dotnet/coreclr/commit/
db22f6be2ec9dcce076a5cb0bab5c33a031c88c9
Jan Kotas [Fri, 25 Mar 2016 03:20:56 +0000 (20:20 -0700)]
Merge pull request dotnet/coreclr#3923 from myungjoo/doc/arm_0001
Update Linux Build Instruction
Commit migrated from https://github.com/dotnet/coreclr/commit/
58209afd48c6f0d2b7e9bc987b701f20480afb89
Jan Kotas [Fri, 25 Mar 2016 03:15:24 +0000 (20:15 -0700)]
Merge pull request dotnet/coreclr#3917 from jkotas/structinregs
Add explicit calling convention modifiers for x86
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c0639cff22b0dbb48f3f2b5046dee23f22d29b4
MyungJoo Ham [Fri, 25 Mar 2016 02:51:22 +0000 (11:51 +0900)]
Update Linux Build Instruction
For Linux/ARM, you need to update libunwind-arm
in order to avoid segmentation faults in libunwind-arm,
which is not included in major Linux distros, yet,
while it is already being addressed in upstreams.
This is realted with dotnet/coreclr#3898 Issue Comment
201098037:
https://github.com/dotnet/coreclr/issues/3898#issuecomment-
201098037
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
25d01ddcec5e4e4296aef8b5f576a1db7914aa5a
Stephen Toub [Fri, 25 Mar 2016 02:54:18 +0000 (22:54 -0400)]
Merge pull request dotnet/coreclr#3919 from stephentoub/specialcase_emptystring
Special-case hashcode of empty length string on Unix
Commit migrated from https://github.com/dotnet/coreclr/commit/
c20480dfc56a18dec823bb15015e90e9a8da55c0
Andy Ayers [Thu, 24 Mar 2016 21:20:46 +0000 (14:20 -0700)]
Inliner: fix issue introduced by refactoring
Refactoring done in dotnet/coreclr#3799 inadvertently modified logic in
`fgFindJumpTargets` so that stored-to arguments might not be marked as
such in the `lvaTable' when crossgenning a root method. This lead to
asserts in internal test cases.
This change restores the logic to its prior state, and adds a test
case that will trigger an assert if the assembly is crossgenned and
this fix is not applied.
Commit migrated from https://github.com/dotnet/coreclr/commit/
13ff9aef107018c26c8d255b20ced32a84be25cf
Andy Ayers [Tue, 22 Mar 2016 22:48:07 +0000 (15:48 -0700)]
Inliner: collect jit time data
This is an initial cut at collecting the time spent jitting a method
as part of observing the incremental impact of inlines.
It currently only measures the time after inlining has run, because there
are substantial interactions with the EE before this point and the time
spent in those calls is not always going to properly attribute to the
current method. We've had some good internal discussion on other
approaches to this and will likely revisit as time goes on. There was
already some timing support in place for SQM so I've generalized that
and shared it for this case too.
This also fixes an off-by-one issue with the method version which came
up when trying to back-correlate the inline data into the inline trees.
The data dumps now include root method data, and so we capture the IL
size and force inline state of the root method in the data dumps. This
allows us to investiage if observed inliner data is corrlated with the
current size of a method.
Data output is now also supported in RET builds. A custom build that
defines `INLINE_DATA` is required. Output is sent to stderr to work
around issues with crossgen.exe reopening stdout in a non-ascii mode.
Commit migrated from https://github.com/dotnet/coreclr/commit/
56c4dd36829af89be9cef1d537e2d1998e2beb26
MyungJoo Ham [Fri, 25 Mar 2016 01:12:37 +0000 (10:12 +0900)]
Fix ARM/Unwind: explicitly mark the end of stack
Libunwind-arm unw_step returns 0 with unchanged PC
if it hits the bottom of the stack.
Thus, seh-unwind.cpp::PAL_VirtualUnwind should
explicitly mark that it has reached the bottom
as it does with ARM64, FreeBSD, or APPLE for
ARM/Linux.
Fix dotnet/coreclr#3859
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
95cad43adb26410a31adaa8f30908f07876bb742
stephentoub [Thu, 24 Mar 2016 23:37:48 +0000 (19:37 -0400)]
Special-case hashcode of empty length string on Unix
This is special-cased in the Windows build, but not currently in the Unix build.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb223894cc95c4269829dde874cc9ec7f65d3bce
Sejong Oh [Thu, 24 Mar 2016 23:25:33 +0000 (16:25 -0700)]
Merge pull request dotnet/coreclr#3885 from sejongoh/test_env_script
Add --test-env option to tests/runtest.sh to set stress mode environm…
Commit migrated from https://github.com/dotnet/coreclr/commit/
edb66eb76eaa046913c0de0d5c7f917f2cfc8465
Jan Kotas [Thu, 24 Mar 2016 22:14:33 +0000 (15:14 -0700)]
Add explicit calling convention modifiers for x86
Commit migrated from https://github.com/dotnet/coreclr/commit/
905046b8928716e050ab2c9b3f57518e604d4791
Kyungwoo Lee [Thu, 24 Mar 2016 20:48:22 +0000 (13:48 -0700)]
Merge pull request dotnet/coreclr#3904 from kyulee1/NoMT
Remove static lib dependency on CrossGen
Commit migrated from https://github.com/dotnet/coreclr/commit/
e02c359a66219e4021ecb614cff87bb6a07bd68e
Kyungwoo Lee [Thu, 24 Mar 2016 19:18:16 +0000 (12:18 -0700)]
Merge pull request dotnet/coreclr#3905 from kyulee1/arm64cross
Enable CrossGen Compilation for ARM64
Commit migrated from https://github.com/dotnet/coreclr/commit/
5950613eff6684b20af4b49ee7a75e3951c3666e
tijoytom [Thu, 24 Mar 2016 18:23:22 +0000 (11:23 -0700)]
Merge pull request dotnet/coreclr#3814 from tijoytom/master
Marshal tests for various scenarios.
Commit migrated from https://github.com/dotnet/coreclr/commit/
64d8836e6ec00fe4cefb2b7e8a8059e53c7c45e2
Sejong OH [Wed, 23 Mar 2016 17:32:25 +0000 (10:32 -0700)]
Add --test-env option to tests/runtest.sh to set stress mode environment varibles just before tests run.
Commit migrated from https://github.com/dotnet/coreclr/commit/
de0c3c3d5162581b8bda84169d53c42ec31ddf82
David Mason [Thu, 24 Mar 2016 17:48:51 +0000 (10:48 -0700)]
Fix spurious warning about parameter counts
Commit migrated from https://github.com/dotnet/coreclr/commit/
b45dbec2efcdc9713ddf50d57d8df3564874b345
Kyungwoo Lee [Thu, 24 Mar 2016 17:51:36 +0000 (10:51 -0700)]
Enable CrossGen Compilation for ARM64
This simply removes the blocking code that prevents ARM64 crossgen
compilation. Otherwise, we got InvalidProgramExceptions for all methods.
I've validated this allows crossgen to compiles all mscorlib methods.
Toward the end, there is NYI assertion in Zap which is expected.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1a0a1c3542cc296035b8ef14e7520dfdb2ac5d93
Kyungwoo Lee [Thu, 24 Mar 2016 17:36:18 +0000 (10:36 -0700)]
Remove static lib dependency on CrossGen
The motivation is for enabling ARM64 which does not have correct static
lib with the current toolset.
But looking at other console apps (ilasm/ildasm/coreconsole/corerun) or
coreclr.dll, they also have dependency on msvcrt for Windows.
So, I've decided to make crossgen.exe with the same flavor.
This changes reduces the binary size -- 10M -> 9M (Debug). Release binary
is slightly smaller.
I've validated this by comparing .ni.dll for all FX assemblies that we use for
tests (under CORE_ROOT), which are identical before and after.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9bc133dfd67980e9496c93bb08de9a03c33e12e3
Jan Kotas [Thu, 24 Mar 2016 17:19:13 +0000 (10:19 -0700)]
Merge pull request dotnet/coreclr#3891 from JohnChen0/r2r
Fix generic struct delegate in ReadyToRun (dotnet/coreclr#3690)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6633c0fce8182129544fca6301c09e3a7f646e54
Bruce Forstall [Thu, 24 Mar 2016 16:24:38 +0000 (09:24 -0700)]
Merge pull request dotnet/coreclr#3682 from mikedn/emplace
Avoid Interval and RefPosition unnecessary initialization and copying
Commit migrated from https://github.com/dotnet/coreclr/commit/
2dafeec08a02c86fc016f9fd803835fa60332347
Brian Robbins [Thu, 24 Mar 2016 14:46:36 +0000 (07:46 -0700)]
Merge pull request dotnet/coreclr#3846 from brianrob/perftests
Add Performance Tests from the CLR Perf Lab
Commit migrated from https://github.com/dotnet/coreclr/commit/
efa8f178e631be51bdee5204da230544ebb91da3
Jan Kotas [Mon, 21 Mar 2016 16:06:54 +0000 (09:06 -0700)]
Delete legacy netcf compat support (final part)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e416f57c553a9b9e11a3a22b2ac9b68cef1cd4ce
Jan Kotas [Thu, 24 Mar 2016 14:25:54 +0000 (07:25 -0700)]
Merge pull request dotnet/coreclr#3899 from manu-silicon/patch-2
Fix typo causing an "unary operator expected"
Commit migrated from https://github.com/dotnet/coreclr/commit/
41dad10286dd73ffce954d80ff2acbb82785bf48
Jan Kotas [Thu, 24 Mar 2016 14:22:49 +0000 (07:22 -0700)]
Merge pull request dotnet/coreclr#3897 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
171fa20782aa6ba07321d614c069a9f65ad8de9b
Jan Kotas [Thu, 24 Mar 2016 14:22:32 +0000 (07:22 -0700)]
Merge pull request dotnet/coreclr#3901 from myungjoo/trivial/fix1
Trivial Fix: macro usage of __linux__.
Commit migrated from https://github.com/dotnet/coreclr/commit/
73e41cfae3bbc20f5690605f3683b6f200a73b30
MyungJoo Ham [Thu, 24 Mar 2016 08:36:17 +0000 (17:36 +0900)]
Fix: macro usage of __linux__.
Use #if define(__linux__) instead of if #if __linux__.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
25c4abd0caa0fea6584a8f61c0117d72b4d9873e
Emmanuel [Thu, 24 Mar 2016 06:35:03 +0000 (15:35 +0900)]
Fix typo causing an "unary operator expected"
The default initialization value for doCrossgen was mispelled causing a warning at
./tests/runtest.sh: line 351: [: ==: unary operator expected
Commit migrated from https://github.com/dotnet/coreclr/commit/
dca5a3887ed98d9b535447f6b1e11c9aeadb16c4
Jan Kotas [Thu, 24 Mar 2016 04:31:08 +0000 (21:31 -0700)]
Fix build break in full framework
[tfs-changeset: 1589425]
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1ba0313207731c5a8256420636c1d699f97b7cd
Jan Kotas [Thu, 24 Mar 2016 04:30:37 +0000 (21:30 -0700)]
Fix build break in nativeformatreader.h
[tfs-changeset: 1589424]
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1a834047f00d63ce74eab52c45b1fbe3b60bf62
Kyungwoo Lee [Thu, 24 Mar 2016 03:08:18 +0000 (20:08 -0700)]
Merge pull request dotnet/coreclr#3890 from kyulee1/removeryujitpack
Remove Old NuGet RyuJit Package from Build
Commit migrated from https://github.com/dotnet/coreclr/commit/
cec26a62bbdf9f72af120ac7ef6fa2e9903684fa
Jan Kotas [Thu, 24 Mar 2016 02:31:27 +0000 (19:31 -0700)]
Merge pull request dotnet/coreclr#3888 from jkotas/platform-assemblies
Remove special casing of platform assemblies
Commit migrated from https://github.com/dotnet/coreclr/commit/
15c0f394827c7c9902fe5f41dd62d9be16d14ce9
John Chen (JOCHEN7) [Wed, 23 Mar 2016 22:05:11 +0000 (15:05 -0700)]
Fix generic struct delegate in ReadyToRun (dotnet/coreclr#3690)
The following code pattern triggers a crash when compiled into Ready To Run:
struct S<T>
{
public void M() { ... }
}
class C { }
Then create a delegate using S<C>.M
The cause of the crash is calling S<C>.M normally reaches a shared generic
method S<__Canon>.M, but for delegate creation we need to use the actual
S<C>.M. Ready To Run generated code that attempts to create delegate using
S<__Canon>.M, which is not allowed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
70aee6c7c67744508dc9f855cf340967bcdf7809
Gaurav Khanna [Thu, 24 Mar 2016 00:20:38 +0000 (17:20 -0700)]
Merge pull request dotnet/coreclr#3880 from gkhanna79/R2RTestFX
Precompile FX assemblies for test run
Commit migrated from https://github.com/dotnet/coreclr/commit/
b01396d16e90106e8c4e19ddbecc967d54d2690b
Fadi Hanna [Thu, 24 Mar 2016 00:14:37 +0000 (17:14 -0700)]
Merge pull request dotnet/coreclr#3892 from fadimounir/FixBB
Fix build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
ddbe05329eb68d87d56f0868cfe396d6be63ec97
William Godbe [Wed, 23 Mar 2016 23:57:23 +0000 (16:57 -0700)]
Merge pull request dotnet/coreclr#3893 from wtgodbe/r2r_GCStress
Add per-commit runs & PR trigger phrases for Pri1 R2R GCStress 15 test runs for Windows, OSX, CentOS, and Ubuntu
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f92040db032421f525a36167bb334428efd07fc
Brian Sullivan [Wed, 23 Mar 2016 23:42:07 +0000 (16:42 -0700)]
Merge pull request dotnet/coreclr#3889 from briansull/update-tests-lst
Changed 22 UNSTABLE tests to EXPECTED_PASS
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d94776c5b735c2b2835980ae6e6201e984aeb18
wtgodbe [Wed, 23 Mar 2016 23:09:41 +0000 (16:09 -0700)]
Add per-commit runs & PR trigger phrases for Pri1 R2R GCStress 15 test runs for Windows, OSX, CentOS, and Ubuntu
Commit migrated from https://github.com/dotnet/coreclr/commit/
8d5c205ffa19d5bd6b07d6acf01cd37e72b0c00c
Jan Kotas [Wed, 23 Mar 2016 23:31:55 +0000 (16:31 -0700)]
Delete security transparency tests that are not valid on .NET Core
The security transparency rules are not enforced on .NET Core.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d3b8acd161bcd5890be78af5130526575264ccc
Fadi Hanna [Wed, 23 Mar 2016 22:58:49 +0000 (15:58 -0700)]
Fix build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b799e7f91a1afe3d1450e37bfdaeda3b736e56b
Tijoy Tom Kalathiparambil [Wed, 23 Mar 2016 22:26:18 +0000 (15:26 -0700)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Commit migrated from https://github.com/dotnet/coreclr/commit/
a6a6f68ef0662de898fdfa262c46d7f04e9c0717
Rahul Kumar [Wed, 23 Mar 2016 21:50:46 +0000 (14:50 -0700)]
Merge pull request dotnet/coreclr#3887 from rahku/master
Fix XunitWrapper log file generation
Commit migrated from https://github.com/dotnet/coreclr/commit/
79960124b1575e35a513df91f6ab34894733f3fb