profile/ivi/qtbase.git
12 years agotest: fixed failure of tst_qstylesheetstyle on qpa
Rohan McGovern [Thu, 18 Aug 2011 00:33:57 +0000 (10:33 +1000)]
test: fixed failure of tst_qstylesheetstyle on qpa

Wait for window shown on _all_ platforms, not just X11.

QEXPECT_FAIL a test which relies on QCursor::setPos, which is currently
unimplemented for qpa (QTBUG-20753).

Change-Id: I72412476afc7e52ccb6cab4306ff791b7e7d8d93
Reviewed-on: http://codereview.qt.nokia.com/3118
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed tst_qeventloop and removed CONFIG+=insignificant_test
Rohan McGovern [Tue, 2 Aug 2011 02:05:21 +0000 (12:05 +1000)]
test: fixed tst_qeventloop and removed CONFIG+=insignificant_test

Throwing C++ exceptions through the event loop doesn't work if the Glib
event loop is used, so conditionally skip that part of the test.

Change-Id: Ic27ebf4eb75bd1cf7c7e35f371f29bcfc0e1844a
Reviewed-on: http://codereview.qt.nokia.com/2471
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
12 years agotest: skipped unstable portion of tst_qcssparser on qpa
Rohan McGovern [Thu, 18 Aug 2011 04:14:41 +0000 (14:14 +1000)]
test: skipped unstable portion of tst_qcssparser on qpa

This test unstably fails because font lookup is somewhat broken for qpa.

Task-number: QTBUG-20986
Change-Id: Id4ebd35e979d8837d32b58e5ed9c1df3ac15827a
Reviewed-on: http://codereview.qt.nokia.com/3130
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qrawfont as expected failure on qpa
Rohan McGovern [Wed, 17 Aug 2011 23:24:09 +0000 (09:24 +1000)]
test: mark tst_qrawfont as expected failure on qpa

The necessary font handling code for qrawfont currently seems to be
unimplemented for all qpa backends.

Task-number: QTBUG-20976
Change-Id: I2b5c511936892e2754c0ee809b7a558f44d1d132
Reviewed-on: http://codereview.qt.nokia.com/3116
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed XPASS from tst_qstatictext on qpa
Rohan McGovern [Wed, 17 Aug 2011 23:40:55 +0000 (09:40 +1000)]
test: fixed XPASS from tst_qstatictext on qpa

These tests were written to compare two different methods of drawing
text, to ensure the result was the same.  However, if _both_ methods
turned out to be complete no-ops, the test would unexpectedly pass, as
it never verified that anything was painted.  Add additional
verification steps and QEXPECT_FAIL them on qpa for now.

Task-number: QTBUG-20977

Change-Id: I1ce1b7c2bcd683fc9eeaeb8d1483268e56f5cf08
Reviewed-on: http://codereview.qt.nokia.com/3117
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qsystemtrayicon as expected failure for qpa
Rohan McGovern [Thu, 18 Aug 2011 00:53:22 +0000 (10:53 +1000)]
test: mark tst_qsystemtrayicon as expected failure for qpa

QSystemTrayIcon is unimplemented for qpa.

Task-number: QTBUG-20978
Change-Id: I63703b96e3d4572bae722120774de1565d475414
Reviewed-on: http://codereview.qt.nokia.com/3119
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qtextlayout as insignificant for qpa, xcb
Rohan McGovern [Thu, 18 Aug 2011 01:07:42 +0000 (11:07 +1000)]
test: mark tst_qtextlayout as insignificant for qpa, xcb

This autotest segfaults in this configuration.

Task-number: QTBUG-20979
Change-Id: I7f038416d9333b690695f48e4ad01d52767f45cd
Reviewed-on: http://codereview.qt.nokia.com/3120
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotests: disabled failing qsharedmemory, qsystemsemaphore tests
Rohan McGovern [Thu, 18 Aug 2011 01:16:54 +0000 (11:16 +1000)]
tests: disabled failing qsharedmemory, qsystemsemaphore tests

The `lackey' helper app was disabled by
ccd5228a9380fbfa308a57365e4075f90010da00, but the tests which depend on
it weren't disabled - so, of course, they fail.

None of these tests will work until the circular dependency is fixed
(the tests are in qtbase and they depend on qtscript which depends on
qtbase).

Change-Id: I8e41b4182f5ea57a71ec810a30a21ba1c7217db3
Reviewed-on: http://codereview.qt.nokia.com/3122
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed failure of tst_qhostinfo
Rohan McGovern [Thu, 18 Aug 2011 02:53:08 +0000 (12:53 +1000)]
test: fixed failure of tst_qhostinfo

Doing an async exit of the test event loop is unsafe - it means that
a call to exitLoop may be left pending from one testfunction, causing
future testfunctions to fail.  This in fact was happening for the
multipleDifferentLookups testfunction, which was running the event loop
for two milliseconds at a time until a certain amount of lookups was
done.  It was common for the loop to timeout after the lookup had
completed but before the async exitLoop had been processed.

Make it simple, do a synchronous exitLoop.

Change-Id: I2ffe6989bddc091ddd42b218a75f7a8ff160cf53
Reviewed-on: http://codereview.qt.nokia.com/3124
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: marked tst_macgui as insignificant
Rohan McGovern [Thu, 18 Aug 2011 04:03:19 +0000 (14:03 +1000)]
test: marked tst_macgui as insignificant

This autotest sometimes passes and sometimes fails, making its result
insignificant for the purpose of detecting regressions.

Task-number: QTBUG-20984
Change-Id: I1454649384b60501be0bec238dfb18cfc85d5f54
Reviewed-on: http://codereview.qt.nokia.com/3129
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qcombobox as expected failure for qpa
Rohan McGovern [Thu, 18 Aug 2011 03:51:55 +0000 (13:51 +1000)]
test: mark tst_qcombobox as expected failure for qpa

This test fails on qpa because it uses QCursor::setPos, which is
unimplemented.

Task-number: QTBUG-20753
Change-Id: I8b77261e9ddfa8f57cebdbd83c93a367a8cf8bea
Reviewed-on: http://codereview.qt.nokia.com/3128
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotests: mark expected failures in qsslsocket_onDemandCertificates
Rohan McGovern [Thu, 18 Aug 2011 03:47:38 +0000 (13:47 +1000)]
tests: mark expected failures in qsslsocket_onDemandCertificates

Task-number: QTBUG-20983
Change-Id: I5db2a92352037721802c127f2b47b52a514e0bfc
Reviewed-on: http://codereview.qt.nokia.com/3127
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: marked tst_qhttpnetworkconnection as insignificant
Rohan McGovern [Thu, 18 Aug 2011 03:07:12 +0000 (13:07 +1000)]
test: marked tst_qhttpnetworkconnection as insignificant

This test crashes sometimes (but not always), making its result
insignificant for the purpose of detecting regressions.

Task-number: QTBUG-20981
Change-Id: I65e9c449ef342fad17be2364964774f229970aaa
Reviewed-on: http://codereview.qt.nokia.com/3125
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: marked tst_qsocketnotifier failures as expected
Rohan McGovern [Thu, 18 Aug 2011 03:26:41 +0000 (13:26 +1000)]
test: marked tst_qsocketnotifier failures as expected

Task-number: QTBUG-20982
Change-Id: Ie53ea9733dc357176ec829d3df971760c49afdbd
Reviewed-on: http://codereview.qt.nokia.com/3126
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agoStabilize autotests using QTest::qWaitForWindowShown on non-X11.
Rohan McGovern [Wed, 17 Aug 2011 05:40:46 +0000 (15:40 +1000)]
Stabilize autotests using QTest::qWaitForWindowShown on non-X11.

X11 is currently the only platform with a "real" implementation of
QTest::qWaitForWindowShown.  All others merely process events for some
fixed interval, and assume that this is sufficient for the window to be
placed.  In practice, the current interval is too short for slower
machines.

Change-Id: I956cd747d0b30577f5072a9a08da88dabc76906c
Reviewed-on: http://codereview.qt.nokia.com/3060
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agotest: mark tst_qwindowsurface as expected failure on qpa
Rohan McGovern [Thu, 18 Aug 2011 01:30:32 +0000 (11:30 +1000)]
test: mark tst_qwindowsurface as expected failure on qpa

This test fails on qpa because QPixmap::grabWindow is not implemented
for that platform.

Task-number: QTBUG-20863
Change-Id: I19afdac231922113c1b491dee27c2ea91e121b85
Reviewed-on: http://codereview.qt.nokia.com/3123
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed failure of tst_qgridlayout on small screens for non-QWS
Rohan McGovern [Wed, 17 Aug 2011 05:43:36 +0000 (15:43 +1000)]
test: fixed failure of tst_qgridlayout on small screens for non-QWS

This test will fail if the window manager doesn't give the widget the
geometry it requested.  The test was verifying this precondition, but
only on QWS.  It doesn't make sense to limit this check to QWS,
as  other platforms can have small screens too.

Change-Id: I3fec905c28ac2f85ebfd621f84f2269a673e318e
Reviewed-on: http://codereview.qt.nokia.com/3061
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark qlistview as insignificant for qpa, xcb
Rohan McGovern [Wed, 17 Aug 2011 06:12:56 +0000 (16:12 +1000)]
test: mark qlistview as insignificant for qpa, xcb

The test fails on some qpa, xcb configurations, but not others.
The difference between the passing and failing configurations is
unknown.

Task-number: QTBUG-20956
Change-Id: I0dc7c3e598ce1116ef5f2280d9285dda82f14f10
Reviewed-on: http://codereview.qt.nokia.com/3064
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agoWhen asking for relations, don't crash on children that don't return an interface.
Frederik Gladhorn [Wed, 18 May 2011 16:20:38 +0000 (18:20 +0200)]
When asking for relations, don't crash on children that don't return an interface.

Reviewed-by: Jan-Arve
(cherry picked from commit a816cb0d26ebcef54e9e61c72455509edf6c44b9)

Change-Id: I8fed57eb0dfd5b67dee440b19c0ad5b9d7b3ae2d
Reviewed-on: http://codereview.qt.nokia.com/3020
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoReport an error when the version header can't be written
Lincoln Ramsay [Tue, 9 Aug 2011 05:44:41 +0000 (15:44 +1000)]
Report an error when the version header can't be written

If sync.profile points to a location that does not exist in the
%modules section, the version header cannot be written.

Report the error clearly so this problem can be identified.

Change-Id: Ib681087f46362487ffb621221d33cf9b7e54df2f
Reviewed-on: http://codereview.qt.nokia.com/2761
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
12 years agotest: skip tst_QMenu::pushButtonPopulateOnAboutToShow() for picky WM
Rohan McGovern [Fri, 12 Aug 2011 04:00:38 +0000 (14:00 +1000)]
test: skip tst_QMenu::pushButtonPopulateOnAboutToShow() for picky WM

We are trying to test the case of having a widget right next to the edge
of the screen, but the window manager is likely to forbid this geometry
in many cases.  When this happens, we can't continue the test.

Change-Id: I6bce2263bdf444221c5303e83d70a254bbb9194c
Reviewed-on: http://codereview.qt.nokia.com/2892
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agoRemove more inconsistencies with invisible.
Frederik Gladhorn [Wed, 18 May 2011 19:46:26 +0000 (21:46 +0200)]
Remove more inconsistencies with invisible.

Visible status should not influence child count and
other properties.

Reviewed-by: Jan-Arve
(cherry picked from commit b6a6953d21a95c402e8a5010c1ea5131509eeea3)

Change-Id: I854349bfe48ab3d81bb9eee284965461b1e66aef
Reviewed-on: http://codereview.qt.nokia.com/3019
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoQAccessibleToolButton::text should return accessibleName if set.
Frederik Gladhorn [Thu, 5 May 2011 16:51:59 +0000 (18:51 +0200)]
QAccessibleToolButton::text should return accessibleName if set.

This was most likely a copy and paste error.

Reviewed-by: Denis Dzyubenko
(cherry picked from commit e29ef45e404dbe888c0848eb28317a10b2aff768)

Change-Id: I55dec5b9d101f9015f97cf453dc804d3cc22db8d
Reviewed-on: http://codereview.qt.nokia.com/3018
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoRemove stray semicolon.
Frederik Gladhorn [Thu, 5 May 2011 16:50:35 +0000 (18:50 +0200)]
Remove stray semicolon.

Reviewed-by: TrustMe
(cherry picked from commit f045367df74fbb5befeef81afa9102d0a6e59d54)

Change-Id: Idcdb0115606447d74a49f2dd1101ad0ad7745db0
Reviewed-on: http://codereview.qt.nokia.com/3017
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoChanging cursor position in all boundaries
José Millán Soto [Mon, 6 Jun 2011 13:03:09 +0000 (15:03 +0200)]
Changing cursor position in all boundaries

Merge-request: 1242
Reviewed-by: Harald Fernengel <harald.fernengel@nokia.com>
(cherry picked from commit 97c59df43d821e8e1784749e72f8ee7f90d46da2)

Change-Id: Iccb872281a443e57ff3e492911490a8d7495bbdc
Reviewed-on: http://codereview.qt.nokia.com/3004
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoConfigure: Set separate_debug_info for all modules
Kai Koehne [Mon, 15 Aug 2011 13:36:08 +0000 (15:36 +0200)]
Configure: Set separate_debug_info for all modules

separate_debug_info was previously stored in .qmake.cache, and
therefore only affected qtbase. Store it as a QT_CONFIG setting instead,
and add it to CONFIG for all Qt plugins and modules.

Change-Id: I940c8cb30f1c42c85f4d0342e6a482f20677ff04
Reviewed-on: http://codereview.qt.nokia.com/2975
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
12 years agoHTTP internals: send password even if no username is set
Robert Hogan [Mon, 15 Aug 2011 08:43:43 +0000 (10:43 +0200)]
HTTP internals: send password even if no username is set

Setting only a password (no username) for HTTP requests does not
result in the password being sent.
Only cancel authentication if neither a username nor a password is set.
Requiring a username was preventing user-less logins.

Merge-request: 1250
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Task-number: QTBUG-15566
(cherry picked from commit 6057909d2b73c2c3aa01a0e9216714ef07fb652f)

Change-Id: I23a52362e3e8cf114219accca2b548ceb9dccff7
Reviewed-on: http://codereview.qt.nokia.com/2940
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
12 years agoMake QThread::sleep/msleep/usleep public.
David Faure [Mon, 15 Aug 2011 11:43:45 +0000 (13:43 +0200)]
Make QThread::sleep/msleep/usleep public.

Merge-request: 43
Reviewed-by: olivier
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: Ic5e3ce8f49daf83665865f89fa9fd3488cc5b349
Reviewed-on: http://codereview.qt.nokia.com/2959
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoAdd flag for non-recursive lookup of child qobject(s)
David Faure [Mon, 15 Aug 2011 11:24:23 +0000 (13:24 +0200)]
Add flag for non-recursive lookup of child qobject(s)

Merge-request: 40
Reviewed-by: olivier
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: I1194ba0d8bba92ece3132171e230cece341ec127
Reviewed-on: http://codereview.qt.nokia.com/2957
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoFocusScope's focusItem must always be a descendent
Alan Alpert [Mon, 15 Aug 2011 03:44:44 +0000 (13:44 +1000)]
FocusScope's focusItem must always be a descendent

Task-number: QTBUG-20699
Reviewed-by: Michael Brasser
Change-Id: Iaaaabaabaabaabaabaaaaaffaaaeaaaaaaaacaaa
(cherry picked from commit 0ee51351894296df7328f206e444ece262692f3f)
Reviewed-on: http://codereview.qt.nokia.com/2931
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoDon't endless loop
Alan Alpert [Tue, 9 Aug 2011 04:23:50 +0000 (14:23 +1000)]
Don't endless loop

Task-number: QTBUG-20699
Reviewed-by: Michael Brasser
(cherry picked from commit ce36e8afa47e3625737208b5a912f9f191a59678)
Change-Id: Iaaaabadbabaaaeaaaaaaaaffaaaeaaaaaaaacaaa
Reviewed-on: http://codereview.qt.nokia.com/2757
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoDon't leak MouseEvents
Alan Alpert [Thu, 11 Aug 2011 06:59:06 +0000 (16:59 +1000)]
Don't leak MouseEvents

Based off merge request 1312

Reviewed-by: Michael Brasser
(cherry picked from commit 206c9ba930095efb6d569f6e61a9809f16361dd5)
Change-Id: Iaaaabadbadbadaaaaaaaaaffaaaeaaaaaaaacaaa
Reviewed-on: http://codereview.qt.nokia.com/2843
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
12 years agotest: fixed crash in tst_qmenubar::accel in qpa
Rohan McGovern [Fri, 12 Aug 2011 05:18:08 +0000 (15:18 +1000)]
test: fixed crash in tst_qmenubar::accel in qpa

Always verify that the application has an active window before
attempting to generate a key click.

This problem potentially affected all platforms, but is rare on non-qpa
Linux since QTest::qWaitForWindowShown would usually avoid the problem
on that platform.

Change-Id: I0c30be6228361faffa121c9c2d7a667f8351ebd6
Reviewed-on: http://codereview.qt.nokia.com/2896
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoSubmit ui4.cpp/h as generated by corresponding change in qttools.
Friedemann Kleint [Fri, 12 Aug 2011 09:37:32 +0000 (11:37 +0200)]
Submit ui4.cpp/h as generated by corresponding change in qttools.

Change: 6b02fc50ec6a5236f628b08ebeca50e62b22f362 (Remove QDom code).

Also introduces QStringLiteral.
Remove QtXml from uitools profile.

Done-with: Kai Koehne <kai.koehne@nokia.com>

Change-Id: I56ee88a5dc76041eeb3685a982f2e9c60bcebd13
Reviewed-on: http://codereview.qt.nokia.com/2907
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
13 years agoHandle EINTR gracefully in Wayland clipboard.
Laszlo Agocs [Wed, 10 Aug 2011 07:05:03 +0000 (10:05 +0300)]
Handle EINTR gracefully in Wayland clipboard.

Change-Id: Idd5082f02eb6708685421492afb8ad5b8546a5d6
Reviewed-on: http://codereview.qt.nokia.com/2810
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
13 years agotest: skip tst_QMenu::task258920_mouseBorder on qpa
Rohan McGovern [Fri, 12 Aug 2011 03:47:17 +0000 (13:47 +1000)]
test: skip tst_QMenu::task258920_mouseBorder on qpa

This test can't work because QCursor::setPos() isn't yet implemented
for qpa.

Task-number: QTBUG-20753
Change-Id: I2da8f920bd2d4706bbbcd983e11d2cc19055d2bf
Reviewed-on: http://codereview.qt.nokia.com/2891
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: skip some broken tests in tst_qpixmap for qpa
Rohan McGovern [Thu, 11 Aug 2011 23:58:45 +0000 (09:58 +1000)]
test: skip some broken tests in tst_qpixmap for qpa

These tests cannot be written properly for qpa, due to missing API.

Task-number: QTBUG-20864
Task-number: QTBUG-20863
Change-Id: I2b311833a6738b1830c1cd8be1f20293492bebda
Reviewed-on: http://codereview.qt.nokia.com/2877
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: skip tst_QPrinter::testNonExistentPrinter for qpa
Rohan McGovern [Thu, 11 Aug 2011 23:18:51 +0000 (09:18 +1000)]
test: skip tst_QPrinter::testNonExistentPrinter for qpa

Since the test is irrelevant for Q_WS_X11 and Q_WS_QWS, it's almost
certainly irrelevant for Q_WS_QPA too.

Change-Id: Icc563046baf4c2a5217b87dee150afc7f6fd034d
Reviewed-on: http://codereview.qt.nokia.com/2876
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoQXmlStream lives in QtCore
Lars Knoll [Thu, 11 Aug 2011 13:17:40 +0000 (15:17 +0200)]
QXmlStream lives in QtCore

We can finally remove the hack where a copy of QXmlStream
was compiled into QtXml on some platforms.

Change-Id: Ia164caa73dfb470ac86d1b4062031093b433d10c
Reviewed-on: http://codereview.qt.nokia.com/2869
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
13 years agoLet CONFIG+=no_default_target also disable `check' by default
Rohan McGovern [Thu, 11 Aug 2011 01:53:10 +0000 (11:53 +1000)]
Let CONFIG+=no_default_target also disable `check' by default

If the compilation of a subdir was explicitly disabled by default, then
the testing of that subdir should also be disabled by default.

Change-Id: I928e232393e89a7c27813b7a48864d4e0fb687f8
Reviewed-on: http://codereview.qt.nokia.com/2835
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoconfigure: fixed usage of rpath on mac
Rohan McGovern [Thu, 11 Aug 2011 03:14:14 +0000 (13:14 +1000)]
configure: fixed usage of rpath on mac

This logic should be used for all mac platforms.
Currently it is erroneously skipped for qpa on mac.

Change-Id: Ibc8e0bb38d4c08f48292639c614bc328c703b1bc
Reviewed-on: http://codereview.qt.nokia.com/2836
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoQLabel documentation: add warning about sanitizing input
Peter Hartmann [Tue, 2 Aug 2011 14:09:24 +0000 (16:09 +0200)]
QLabel documentation: add warning about sanitizing input

make users more aware of QLabel guessing the text format.

Reviewed-by: Gabriel de Dietrich <gabriel.dietrich-de@nokia.com>
(cherry picked from commit 31f7ecbdcdbafbac5bbfa693e4d060757244941b)

Change-Id: I681c7daf568a6107b01908fa85d2da2a7e4e228a
Reviewed-on: http://codereview.qt.nokia.com/2817
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
13 years agoDon't print the "Configuration tests:" header if there aren't any.
Michael Goddard [Wed, 27 Jul 2011 00:38:16 +0000 (10:38 +1000)]
Don't print the "Configuration tests:" header if there aren't any.

Change-Id: Ie7f0022348aba90e240f5b68e838430ec4e43ae9
Reviewed-on: http://codereview.qt.nokia.com/2228
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoconfigure: fixed debug-and-release default for qpa on mac
Rohan McGovern [Wed, 10 Aug 2011 01:49:46 +0000 (11:49 +1000)]
configure: fixed debug-and-release default for qpa on mac

debug/release is always supposed to default on for platforms where
debug/release affects linkage (i.e. mac and windows).  Previously, it
did not correctly default on for qpa mac builds.

Change-Id: I8d3c418f3fb787136ab120872fdd4d2ebf82c90e
Reviewed-on: http://codereview.qt.nokia.com/2796
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
13 years agotest: mark tst_qfontdatabase qpa failures as expected
Rohan McGovern [Fri, 5 Aug 2011 01:44:39 +0000 (11:44 +1000)]
test: mark tst_qfontdatabase qpa failures as expected

Task-number: QTBUG-20754
Change-Id: Ibb57e7724d453b390a8e37e62f6e5cf2691f48f8
Reviewed-on: http://codereview.qt.nokia.com/2654
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: only QEXPECT_FAIL tst_qgraphicstransform in release mode
Rohan McGovern [Mon, 8 Aug 2011 01:55:35 +0000 (11:55 +1000)]
test: only QEXPECT_FAIL tst_qgraphicstransform in release mode

The floating point problem which causes this test to fail is not
triggered if Qt is compiled in debug mode.  Enable QEXPECT_FAIL more
narrowly.

Task-number: QTBUG-20661
Change-Id: I25f3260b516cd4fda9d8b711aa1140cbda821412
Reviewed-on: http://codereview.qt.nokia.com/2719
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: mark tst_qftp as insignificant
Rohan McGovern [Wed, 10 Aug 2011 01:45:02 +0000 (11:45 +1000)]
test: mark tst_qftp as insignificant

As virtually all of our tests which use the live qt-test-server, this
test is inherently unstable.

Change-Id: I27fc07a28b8dd6cd4dd3cb6414389e3cf41d0318
Reviewed-on: http://codereview.qt.nokia.com/2795
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoRemove all non-const operator==
Harald Fernengel [Tue, 9 Aug 2011 09:30:03 +0000 (11:30 +0200)]
Remove all non-const operator==

We had to leave the non-const operator== for binary compatibility.
Remove them all, just leave the const version in there. 100% source
compatible.

Change-Id: Ib7a70fb441fe51d5164d9cbf495cbeda0f48fafe
Reviewed-on: http://codereview.qt.nokia.com/2773
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Robert Griebl <robert.griebl@nokia.com>
13 years agoSupport -qtnamespace and -qtlibinfix in qtbase examples
Liang Qi [Mon, 8 Aug 2011 14:27:02 +0000 (16:27 +0200)]
Support -qtnamespace and -qtlibinfix in qtbase examples

Task-number: QTBUG-19971
Change-Id: Ie20eb2fc133658dd34e1ec25a3b80c36f0f01aa3
Reviewed-on: http://codereview.qt.nokia.com/2754
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Liang Qi <liang.qi@nokia.com>
13 years agoChange mouse and wheel QPA events to use QPointF.
Laszlo Agocs [Mon, 8 Aug 2011 10:07:56 +0000 (13:07 +0300)]
Change mouse and wheel QPA events to use QPointF.

At least QMouseEvent already uses QPointF so there is no reason to
restrict handleMouseEvent to integer positions.

Change-Id: I9c72d2e0e99518b40a1898aec9ad2b3421a3e9e2
Reviewed-on: http://codereview.qt.nokia.com/2739
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agotest: mark tst_qgraphicswidget as insignificant on qpa, xcb
Rohan McGovern [Mon, 8 Aug 2011 03:06:28 +0000 (13:06 +1000)]
test: mark tst_qgraphicswidget as insignificant on qpa, xcb

This autotest is unstable.

Task-number: QTBUG-20778
Change-Id: If862a64d2be2f3f66ea8435b0412bfb401f9aceb
Reviewed-on: http://codereview.qt.nokia.com/2721
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotests: handle many expected crashing tests on qpa, xcb
Rohan McGovern [Mon, 8 Aug 2011 01:13:58 +0000 (11:13 +1000)]
tests: handle many expected crashing tests on qpa, xcb

Mark all of these autotests as `insignificant' until the underlying
crash bug is fixed.

Task-number: QTBUG-20756
Change-Id: I18fb7038dd86ef2e9a5f37c8f26d7fe76032754e
Reviewed-on: http://codereview.qt.nokia.com/2714
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed usage of QEXPECT_FAIL in tst_qglyphrun::initTestCase
Rohan McGovern [Mon, 8 Aug 2011 00:31:58 +0000 (10:31 +1000)]
test: fixed usage of QEXPECT_FAIL in tst_qglyphrun::initTestCase

The rest of this test gives unpredictable results if initTestCase fails.

Normally, a failure in initTestCase skips the rest of the test, but this
is not the case if QEXPECT_FAIL is used.  Adjust the test to ensure the
rest of it is still correctly skipped.

Change-Id: I8ba76161e788f10801029ef10693e9ac275a2897
Reviewed-on: http://codereview.qt.nokia.com/2713
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoadd qml related usage help message
Charles Yin [Mon, 8 Aug 2011 01:31:46 +0000 (11:31 +1000)]
add qml related usage help message

Change-Id: Ieabbca64793ba128746193786bac3d0213e8e746
Reviewed-on: http://codereview.qt.nokia.com/2716
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoFix fallbacksForFamily in QBasicUnixFontDatabase
Jiang Jiang [Fri, 5 Aug 2011 13:49:21 +0000 (15:49 +0200)]
Fix fallbacksForFamily in QBasicUnixFontDatabase

So that this function instead of the one in QPlatformFontDatabase
will be called.

Change-Id: Ifdb75ada27723c688e42067c7633b08391d66467
Reviewed-on: http://codereview.qt.nokia.com/2696
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
13 years agotest: mark tst_qgraphicseffect as insignificant for qpa
Rohan McGovern [Fri, 5 Aug 2011 05:21:01 +0000 (15:21 +1000)]
test: mark tst_qgraphicseffect as insignificant for qpa

This test unstably fails for qpa, xcb, so mark it as insignificant.

Task-number: QTBUG-20761
Change-Id: I0b4228c2803946ef87d7d11f4167017c2ffd0ad6
Reviewed-on: http://codereview.qt.nokia.com/2658
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: mark expected failures in tst_qglyphrun for qpa
Rohan McGovern [Fri, 5 Aug 2011 04:17:30 +0000 (14:17 +1000)]
test: mark expected failures in tst_qglyphrun for qpa

Task-number: QTBUG-20760
Change-Id: Id046abfc8dcce2c6d068e5febf8c2b8777b50f53
Reviewed-on: http://codereview.qt.nokia.com/2657
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: mark expected failures in tst_qfontmetrics for qpa
Rohan McGovern [Fri, 5 Aug 2011 04:12:16 +0000 (14:12 +1000)]
test: mark expected failures in tst_qfontmetrics for qpa

Task-number: QTBUG-20759
Change-Id: Idb9493f5bf4ce031d7800b2187bf7c15757eb963
Reviewed-on: http://codereview.qt.nokia.com/2656
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: blacklist crashing tst_qfontdialog for qpa, xcb
Rohan McGovern [Fri, 5 Aug 2011 01:56:45 +0000 (11:56 +1000)]
test: blacklist crashing tst_qfontdialog for qpa, xcb

Task-number: QTBUG-20756
Change-Id: I04b5ace4d357f756a3148597170b87a60b008cf5
Reviewed-on: http://codereview.qt.nokia.com/2655
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: fixed tst_qfont for qpa
Rohan McGovern [Fri, 5 Aug 2011 00:32:05 +0000 (10:32 +1000)]
test: fixed tst_qfont for qpa

Extend the QWS skip case to also cover QPA.

Change-Id: I2bb93b179a384cf4304284d4d550c0bf4b61f4ca
Reviewed-on: http://codereview.qt.nokia.com/2653
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: fixed tst_qabstractitemview for qpa
Rohan McGovern [Fri, 5 Aug 2011 00:30:55 +0000 (10:30 +1000)]
test: fixed tst_qabstractitemview for qpa

Test uses QCursor::setPos(), which is broken for QPA.

Task-number: QTBUG-20753
Change-Id: Ibeb1278f46dc5dec081c19ba25dd83cc8390aef3
Reviewed-on: http://codereview.qt.nokia.com/2652
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agoFix weight parsing in QBasicUnixFontDatabase
Jiang Jiang [Fri, 5 Aug 2011 08:59:34 +0000 (10:59 +0200)]
Fix weight parsing in QBasicUnixFontDatabase

First check the usWeightClass in OS/2 font table, then check
the weight byte in panose structure because Nokia Pure Text
fonts only have that set correctly.

Change-Id: Idce2626c8df17ce74ba78b317846cb42c3f1fe84
Reviewed-by: Jørgen Lind
Reviewed-on: http://codereview.qt.nokia.com/2682
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agosupport xcb-icccm 3.8
Oswald Buddenhagen [Wed, 3 Aug 2011 19:16:10 +0000 (21:16 +0200)]
support xcb-icccm 3.8

this is a rather crude hack, but whatever.

Change-Id: I3fa363572842b207202d4aac8526951c0e16bf5b
Reviewed-on: http://codereview.qt.nokia.com/2602
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agoUse more numerically robust algorithm to compute QBezier::pointAt().
Alan Alpert [Tue, 2 Aug 2011 01:26:24 +0000 (11:26 +1000)]
Use more numerically robust algorithm to compute QBezier::pointAt().

QBezier::pointAt() could potentially return values outside the bezier's
bounds, even when the bezier was a straight horizontal line. For
example, with y = 0.5, it would produce y=0.5 or y=0.49999999999999 for
different values of t, which when rounded cause jittering in a QML
PathView.

Task-number: QTBUG-17007
Task-number: QTBUG-18133
Cherry-pick-of: 8b66982ec7b4b5d2071931c288973dce73dc9875
Change-Id: I4ecac7b9085aaaaaaaaaaaaaaaaaaaaaa7d7b0bc
Reviewed-on: http://codereview.qt.nokia.com/2467
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
13 years agotest: fixed tst_qundostack and removed CONFIG+=insignificant_test
Sergio Ahumada [Thu, 4 Aug 2011 10:41:32 +0000 (12:41 +0200)]
test: fixed tst_qundostack and removed CONFIG+=insignificant_test

This test had an invalid circular dependency: the test is in qtbase, and
it depends on lrelease in qttools, which depends on qtbase.

Change the test to skip if lrelease is not available or not working.

Change-Id: I4696f4a178a6f8c0f2e76b5c4ae7f60c4f953334
Reviewed-on: http://codereview.qt.nokia.com/2619
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoAllow adding to @ignore_headers from sync.profile
Marius Storm-Olsen [Thu, 4 Aug 2011 20:54:50 +0000 (15:54 -0500)]
Allow adding to @ignore_headers from sync.profile

We need this to avoid syncing certain files in QtDeclarative on
Windows.

Change-Id: Ia9fc95262ac18bafc39efc038ea70a1b5d67cddd
Reviewed-on: http://codereview.qt.nokia.com/2641
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
13 years agoQSslCertificate: deprecate alternateSubjectNames()
Peter Hartmann [Wed, 3 Aug 2011 16:36:55 +0000 (18:36 +0200)]
QSslCertificate: deprecate alternateSubjectNames()

... and add a new method subjectAlternativeNames() instead. This was
a typo in the API.

Change-Id: Id8704c387c9ff8e1af2b9a524ff628f5c053a294
Reviewed-on: http://codereview.qt.nokia.com/2618
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
13 years agotest: fixed tst_qundogroup and removed CONFIG+=insignificant_test
Rohan McGovern [Tue, 2 Aug 2011 02:35:01 +0000 (12:35 +1000)]
test: fixed tst_qundogroup and removed CONFIG+=insignificant_test

This test had an invalid circular dependency: the test is in qtbase, and
it depends on lrelease in qttools, which depends on qtbase.

Change the test to skip if lrelease is not available or not working.

Change-Id: I964ddaf9485a2afed5a1bd4f88d9bdccadf1cfca
Reviewed-on: http://codereview.qt.nokia.com/2472
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoSupport QImage and others in Wayland clipboard.
Laszlo Agocs [Thu, 4 Aug 2011 10:01:04 +0000 (13:01 +0300)]
Support QImage and others in Wayland clipboard.

The wayland plugin's clipboard implementation lacked support for data
set via QMimeData::setImageData, QClipboard::setPixmap, etc. because
everything was treated as a QByteArray. A variant having an image
cannot however be converted to a byte array. Therefore, to make these
convenience functions to work, the image is now encoded via
QImageWriter before sending it. On the receiving side QMimeData is
capable of decoding images from byte arrays, so no problem there.
The patch also renames an internal QWaylandMimeData class to a more
suitable clipboard-specific name as the functionality is clipboard
specific.

Change-Id: I77e7df903b8dbe9731613fdbb9693b2a37b05d18
Reviewed-on: http://codereview.qt.nokia.com/2616
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
13 years agoFix the lifespan of the test CA cert used by the autotests.
Richard Moore [Tue, 2 Aug 2011 08:54:43 +0000 (10:54 +0200)]
Fix the lifespan of the test CA cert used by the autotests.

The test CA I used for the QSslCertificate autotests had a short
lifespan which meant that the tests now fail. See bug QTBUG-20582.
This change gives it a lifespan of 10 years matching the leaf
certificates.
In addition, remove the temporary QEXPECT_FAIL statements.

Change-Id: Ic1918e6e31f5cc755ec43d899663140ebe95a2a9
Merge-request: 37
Task-number: QTBUG-20582
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/2548
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoFix QString/QByteArray literals for MSVC2010 (compilation of tests).
Friedemann Kleint [Tue, 2 Aug 2011 13:58:48 +0000 (15:58 +0200)]
Fix QString/QByteArray literals for MSVC2010 (compilation of tests).

- Specify return type of QByteArrayLiteral/QStringLiteral lambdas.
- Define QT_UNICODE_LITERAL instead of QT_UNICODE_MARKER.

Change-Id: I8a53506887d2736b093798220b088f645f05e415
Reviewed-on: http://codereview.qt.nokia.com/2514
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
13 years agotest: mark tst_qtconcurrentfilter as insignificant on Linux
Rohan McGovern [Tue, 2 Aug 2011 06:41:47 +0000 (16:41 +1000)]
test: mark tst_qtconcurrentfilter as insignificant on Linux

This test fails pseudorandomly, which makes the result insignificant
for the purpose of detecting regressions.

Task-number: QTBUG-20688
Change-Id: I3274953841a553e35b4eb844702868f2f9ec0525
Reviewed-on: http://codereview.qt.nokia.com/2491
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: mark tst_qabstractnetworkcache as insignificant
Rohan McGovern [Tue, 2 Aug 2011 03:47:31 +0000 (13:47 +1000)]
test: mark tst_qabstractnetworkcache as insignificant

This test crashes pseudorandomly, which makes the result insignificant
for the purpose of detecting regressions.

Task-number: QTBUG-20686
Change-Id: I3079d935d46a4bcd2b119c2b9b452f0b69dccf21
Reviewed-on: http://codereview.qt.nokia.com/2479
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoMake failure messages from tst_QSslCertificate::verify much more useful
Rohan McGovern [Tue, 2 Aug 2011 07:06:34 +0000 (17:06 +1000)]
Make failure messages from tst_QSslCertificate::verify much more useful

Changes the failure message from the previously brief:

  '(errors.count() == 0)' returned FALSE.

To the vastly more useful:

  '(errors.count() == 0)' returned FALSE.
  (errors: [ "The certificate has expired" ])

Change-Id: I587cd8ddfd3c17e273220bc95691b3dc92390547
Reviewed-on: http://codereview.qt.nokia.com/2241
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
13 years agoEliminate reference to Trolltech.
Jason McDonald [Tue, 2 Aug 2011 04:20:34 +0000 (14:20 +1000)]
Eliminate reference to Trolltech.

Task-number: QTBUG-19653

Change-Id: If3c822dd59ccbdd03037068acfe902ed9688a874
Reviewed-on: http://codereview.qt.nokia.com/2482
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agotest: skip some tst_qtextscriptengine tests when fonts are missing
Rohan McGovern [Tue, 2 Aug 2011 01:35:01 +0000 (11:35 +1000)]
test: skip some tst_qtextscriptengine tests when fonts are missing

This autotest may fail depending on the version of fonts which are
installed on the system.  It has no way to verify if the correct fonts
are installed, and it's unclear from where the correct version of the
fonts may be obtained.

Therefore, disable the test by default unless the user has indicated
that they have a correct setup by setting QT_HAVE_TEST_FONTS=1.

Task-number: QTBUG-20682
Change-Id: I24174520f54af6a9b2c13c9c1347f46555bce3d4
Reviewed-on: http://codereview.qt.nokia.com/2469
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
13 years agoIntroduced a CONFIG option that enables declarative debug services
Thorbjørn Lindeijer [Mon, 18 Apr 2011 15:20:49 +0000 (17:20 +0200)]
Introduced a CONFIG option that enables declarative debug services

This replaces the need for applications to explicitly make a call to
enable the debug services, and rather does it in declarative.h when the
'declarative_debug' CONFIG option is used.

Done-with: Kai Koehne
Reviewed-by: Martin Jones
Reviewed-by: Michael Brasser
(cherry-picked from commit 5517cc588c39814530b8bfd957821f55be42acf2)

Change-Id: If180d2b826879d6d02c7be4d3075917815ccf349
Reviewed-on: http://codereview.qt.nokia.com/2435
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agotest: remove CONFIG+=insignificant_test for tst_qgraphicstransform
Rohan McGovern [Mon, 1 Aug 2011 04:38:36 +0000 (14:38 +1000)]
test: remove CONFIG+=insignificant_test for tst_qgraphicstransform

This autotest failure is stable, so it should be marked with
QEXPECT_FAIL, not CONFIG+=insignificant_test.

Note that the test row naming had to be changed, as the test previously
created many rows of testdata with the same name, making it impossible
to skip only the broken rows.

Task-number: QTBUG-20661
Change-Id: Ie38f5dddafe7686e30eaa8ff3445310935d2cd9a
Reviewed-on: http://codereview.qt.nokia.com/2419
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agotest: fixed failure of tst_qicon
Rohan McGovern [Mon, 1 Aug 2011 06:44:09 +0000 (16:44 +1000)]
test: fixed failure of tst_qicon

This test unconditionally assumed that SVG support was available.
This is an invalid circular dependency: the test is in qtbase and
depends on qtsvg, which depends on qtbase.

Change the test so that it uses SVG support only if available.

Change-Id: Ia63ce74abdecd4bcf7a4e0714b8cb7c488e17495
Reviewed-on: http://codereview.qt.nokia.com/2426
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: fixed crash of tst_qdialog and removed CONFIG+=insignificant_test
Rohan McGovern [Mon, 1 Aug 2011 23:13:38 +0000 (09:13 +1000)]
test: fixed crash of tst_qdialog and removed CONFIG+=insignificant_test

This test assumed that C++ exceptions could always be caught by the
event loop.  This is not the case when the Glib event loop is used.
Skip the relevant portion of the test in that case.

Change-Id: I6a6325c3590c810a5aba28ec98279581dcfaf55c
Reviewed-on: http://codereview.qt.nokia.com/2455
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: improved stability of tst_qiodevice on slow machines
Rohan McGovern [Mon, 1 Aug 2011 23:24:25 +0000 (09:24 +1000)]
test: improved stability of tst_qiodevice on slow machines

Increased network timeout from 5 to 30 seconds.

Change-Id: I4751dbfbb82c2091f1cec26150f06f913ffbe4c0
Reviewed-on: http://codereview.qt.nokia.com/2456
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed tst_qimagereader and removed CONFIG+=insignificant_test
Rohan McGovern [Mon, 1 Aug 2011 23:44:09 +0000 (09:44 +1000)]
test: fixed tst_qimagereader and removed CONFIG+=insignificant_test

This test assumed that Qt's available image formats could be determined
at compile time.  This was never correct since the image formats are
loaded from plugins at runtime; in Qt5 it became a real problem since
one image format (svg) was moved out of qtbase into a separate module,
turning this into a circular dependency: this test in qtbase depends on
qtsvg, which depends on qtbase.

Always check the image formats at runtime instead.

Change-Id: I5e770c5b11276c39910e34f232a2fea0a7abaa8c
Reviewed-on: http://codereview.qt.nokia.com/2457
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: improved stability of tst_qwaitcondition
Rohan McGovern [Tue, 2 Aug 2011 00:22:08 +0000 (10:22 +1000)]
test: improved stability of tst_qwaitcondition

Increased thread wait timeout from 3 to 10 milliseconds, for slower or
heavily loaded machines.  (There was a previous attempt to improve
stability of this test some time ago by increasing the timeout from 1
to 3 milliseconds.)

Note that this increases the runtime of the wakeOne test from ~5 to ~14
seconds.

Change-Id: Ib556d4c949a6989fe71c11f5dc10feb2ec45c512
Reviewed-on: http://codereview.qt.nokia.com/2458
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed tst_qmessagebox and removed CONFIG+=insignificant_test
Rohan McGovern [Tue, 2 Aug 2011 04:52:25 +0000 (14:52 +1000)]
test: fixed tst_qmessagebox and removed CONFIG+=insignificant_test

Removed some binary compatibility tests written specifically to test a
change introduced between Qt 4.1 and 4.2.  Qt 4 and 5 are not binary
compatible, the test no longer makes sense.

Change-Id: I3e8f9b6011105e504c20bedad51af8193b102552
Reviewed-on: http://codereview.qt.nokia.com/2464
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed spelling errors in tst_qtextscriptengine
Rohan McGovern [Tue, 2 Aug 2011 01:12:47 +0000 (11:12 +1000)]
test: fixed spelling errors in tst_qtextscriptengine

couln't -> couldn't

Change-Id: I37e86ecea74db1114fcfac93423388fae81df63d
Reviewed-on: http://codereview.qt.nokia.com/2465
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
13 years agotest: replace CONFIG+=insignificant_test with QEXPECT_FAIL for tst_qftp
Rohan McGovern [Tue, 2 Aug 2011 04:46:15 +0000 (14:46 +1000)]
test: replace CONFIG+=insignificant_test with QEXPECT_FAIL for tst_qftp

This autotest failure is entirely stable, so QEXPECT_FAIL should be used
instead of insignificant_test.

Task-number: QTBUG-20687
Change-Id: I0444e725b436fe93d30cbe54edc673594ca9b9fe
Reviewed-on: http://codereview.qt.nokia.com/2486
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed tst_qfilesystemmodel and removed insignificant_test
Rohan McGovern [Mon, 1 Aug 2011 04:21:56 +0000 (14:21 +1000)]
test: fixed tst_qfilesystemmodel and removed insignificant_test

tst_qfilesystemmodel::sort uses some internal API to affect the sorting
behavior.  This means that part of the test must be disabled when
private symbols aren't available.

Change-Id: I2e7b9d7a33cb3e7032bc5380c03fa29ecc84e12c
Reviewed-on: http://codereview.qt.nokia.com/2413
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoFixed tst_qprocess, tst_qtcpserver when crashing is slow
Rohan McGovern [Mon, 1 Aug 2011 00:17:51 +0000 (10:17 +1000)]
Fixed tst_qprocess, tst_qtcpserver when crashing is slow

These tests assumed that a crashing program will always exit within
five seconds.  This is not true in some situations.  On our test macs,
enabling crash dumps can easily cause a process to take longer than
five seconds to crash.

Increased the timeout to 30 seconds.

Change-Id: Ifca240ac8d3da1346f33110653ac47de6ba2ab81
Reviewed-on: http://codereview.qt.nokia.com/2407
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoFix tst_qgraphicsview::task255529_transformationAnchorMouseAndViewportMargins
Olivier Goffart [Fri, 29 Jul 2011 08:44:30 +0000 (10:44 +0200)]
Fix tst_qgraphicsview::task255529_transformationAnchorMouseAndViewportMargins

If we do not process the event, q->underMouse may return false in
QGraphicsViewPrivate::centerView (as the QEvent::Enter has not been
received yet.)

It was working before if by luck, the window appears under the cursor.

Change-Id: I9b4497683eae20915680297013a9c21fd6275f4b
Reviewed-on: http://codereview.qt.nokia.com/2385
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agoFix compilation with namespaced builds
Bradley T. Hughes [Fri, 29 Jul 2011 10:26:43 +0000 (12:26 +0200)]
Fix compilation with namespaced builds

Add QT_BEGIN_NAMESPACE and QT_END_NAMESPACE to src/corelib/tools/qfreelist.cpp

Change-Id: Ie01e74a3c2d9cd4de1f52a546d13398e1409c86b
Reviewed-on: http://codereview.qt.nokia.com/2390
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Olivier Goffart <olivier.goffart@nokia.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
13 years agoSwitch to use floating point pixelSize in QRawFont completely
Jiang Jiang [Thu, 21 Jul 2011 13:09:24 +0000 (15:09 +0200)]
Switch to use floating point pixelSize in QRawFont completely

Reviewed-by: Eskil
(cherry picked from commit 500f8a4368be85a0ae8b7c46012deb0ab0c844ad)

Change-Id: I6cfebcbb68697c9bf7a5634e98a09a26928467d7
Reviewed-on: http://codereview.qt.nokia.com/2386
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agoSimplify the mutexpool used in QObject.
Olivier Goffart [Tue, 26 Jul 2011 08:44:55 +0000 (10:44 +0200)]
Simplify the mutexpool used in QObject.

Since we now have QBasicMutex as a POD, we can simplify the mutexpool.
This remove the call the the Q_GLOBAL_STATIC and some others tests that
are taking CPU cycles when activating a signal.

The QMutexPool class itself can't be simplified because its mutex are
recursive mutexes, and the size is dynamic. also it is harder to get all
the mutexes initialized to 0.

Change-Id: Ie781655635907d2ad620eb189099cba14638414f
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/2171
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Olivier Goffart <olivier.goffart@nokia.com>
13 years agoQMutex is now just a pointer
Olivier Goffart [Sat, 2 Jul 2011 13:13:12 +0000 (15:13 +0200)]
QMutex is now just a pointer

And added a POD QBasicMutex. (QBasicMutex* can safely be
static_cast'ed to QMutex*)

The d pointer is not anymore always a QMutexPrivate.

If d == 0x0: the mutex is unlocked
If d == 0x1: the mutex is locked, uncontended

On linux:
if d == 0x3: the mutex is locked contended, waiting on a futex
If d is a pointer, it is a recursive mutex.

On non-linux platforms:
When a thread tries to lock a mutex for which d == 0x1, it will try to
assing it a QMutexPrivated (allocated from a freelist) in order to wait
for it.

Change-Id: Ie1431cd9402a576fdd9a693cfd747166eebf5622
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/2116
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Olivier Goffart <olivier.goffart@nokia.com>
13 years agoFix off-by-one error in binary search
Jiang Jiang [Thu, 28 Jul 2011 12:51:54 +0000 (14:51 +0200)]
Fix off-by-one error in binary search

This one-line change makes the binary search in QTextEngine::findItem
behave consistently with the linear search that it replaced in commit
acf678e57ed088f3e56a551cac6c7c3322005750. The new behavior seems to
cause crashes in kword (and perhaps other applications) by triggering a
logClusters assert, although I have been unable to create a unit test
that reproduces this.

Task-number: QTBUG-17209
Done-by: Dr. Robert Marmorstein <robert@narnia.homeunix.com>
Change-Id: I68b79f024e9836e1cc8b0f3514889120541eb2ea
Reviewed-on: http://codereview.qt.nokia.com/2343
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agoFlag meta objects generated by QtDBus
Aaron Kennedy [Fri, 29 Jul 2011 03:03:52 +0000 (13:03 +1000)]
Flag meta objects generated by QtDBus

QtDBus requires a QVariant argument to be passed to property reads and
writes.  For performance reasons QtDeclarative does not do this.  By
flagging the meta object as requiring this, QtDeclarative can do so only
required.

Task-number: QTBUG-15052

Change-Id: I032c946f079523f5f10217ed56642fb315265d9f
Reviewed-on: http://codereview.qt.nokia.com/2365
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoAdd notify signals for QIntvalidator, QDoubleValidator, QRegExpValidator
Charles Yin [Tue, 26 Jul 2011 03:46:54 +0000 (13:46 +1000)]
Add notify signals for QIntvalidator, QDoubleValidator, QRegExpValidator

Task-number:QTBUG-19956
Change-Id: I5ab5e4494189ece5b0eb1f63e73e49cb2c4e9656
Reviewed-by:Michael Brasser
Reviewed-on: http://codereview.qt.nokia.com/2147
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
13 years agoMake it possible to update a related table after an external update
Andy Shaw [Fri, 3 Jun 2011 06:17:40 +0000 (08:17 +0200)]
Make it possible to update a related table after an external update

When a table that is related to in a QSqlRelationalTableModel gets
updated in some way (e.g. a new row, or the data is changed) then the
related model could not be updated without recreating the
QSqlRelationalTableModel.

Now, to get around this, select() can be called on the related model to
get it to be updated.

Task-number: QTBUG-7885
Reviewed-by: Charles Yin
Reviewed-by: Michael Goddard
Change-Id: Ic589e840234f3a809bcb112a807a87afe0bc25ca
(cherry picked from commit 2c60a4f67f9fb02f3b711fe749b2f293a07b4e02)
Reviewed-on: http://codereview.qt.nokia.com/2224
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoAdded meta type info for Q[Explicitly]SharedDataPointer
Denis Dzyubenko [Mon, 25 Jul 2011 12:38:24 +0000 (14:38 +0200)]
Added meta type info for Q[Explicitly]SharedDataPointer

Change-Id: I1269630ae5154f7318e1c7ae9fa2014a15234bf4
Reviewed-on: http://codereview.qt.nokia.com/2110
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Olivier Goffart <olivier.goffart@nokia.com>
13 years agoGet rid of compiler warnings with MSVC
Olivier Goffart [Wed, 27 Jul 2011 17:01:15 +0000 (19:01 +0200)]
Get rid of compiler warnings with MSVC

Change-Id: Ibd027c502a5b8bcbfc6dae71c4f244f1080d4064
Reviewed-on: http://codereview.qt.nokia.com/2303
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
13 years agoEmit selectionChanged signals when input method alters selection.
Andrew den Exter [Mon, 25 Jul 2011 06:58:46 +0000 (16:58 +1000)]
Emit selectionChanged signals when input method alters selection.

Mark the selection as dirty if an input method event contains a
selection and emit selectionChanged() if it's not emitted by
finishChange().

Task-number: QTBUG-19731

Change-Id: Ief6f06f40071f64dae4db0ba365676c059a39c7e
Reviewed-on: http://codereview.qt.nokia.com/2081
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>