Ran Benita [Sat, 14 Dec 2019 11:45:35 +0000 (13:45 +0200)]
meson: remove redundant malloc scribbling
Turns out meson already sets this (at least MALLOC_PERTURB) on its own
for the `test` target.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 14 Dec 2019 11:44:33 +0000 (13:44 +0200)]
parser: fix the remaining pointer chasing
Fix the TODO added in 7c42945.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Peter Hutterer [Wed, 13 Nov 2019 03:42:11 +0000 (13:42 +1000)]
test: let rmlvo-to-kccgst take long options like rmlvo-to-keymap
The short options were left for backwards compatibility.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Wed, 13 Nov 2019 20:41:38 +0000 (22:41 +0200)]
parser: fix quadratic pointer chasing
In the AST, lists (e.g. the list of statements in a file) are kept in
singly-linked lists -- each AST node has a `next` pointer available for
this purpose.
Previously, a node was added to the list by starting from the head,
chasing to the last, and appending. So creating a list of length N would
take ~N^2/2 pointer dereferences.
Now, we always (temporarily) keep the last as well, so appending is O(1)
instead of O(N).
Given a keymap
xkb_keymap {
xkb_keycodes {
minimum = 8;
minimum = 8;
minimum = 8;
minimum = 8;
minimum = 8;
[... repeated N times ...]
};
xkb_types {};
xkb_compat {};
xkb_symbols {};
};
The compilation times are
N | Before | After
--------|----------|-------
10,000 | 0.407s | 0.006s
20,000 | 1.851s | 0.015s
30,000 | 5.737s | 0.021s
40,000 | 12.759s | 0.023s
50,000 | 21.489s | 0.035s
60,000 | 40.473s | 0.041s
70,000 | 53.336s | 0.039s
80,000 | 72.485s | 0.044s
90,000 | 94.703s | 0.048s
100,000 | 118.390s | 0.057s
Another option is to ditch the linked lists and use arrays instead. I
got it to work, but its more involved and allocation heavy so turns out
to be worse without further optimizations.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Wed, 13 Nov 2019 21:37:47 +0000 (23:37 +0200)]
parser: remove an unneeded check
Signed-off-by: Ran Benita <ran@unusedvar.com>
Peter Hutterer [Wed, 13 Nov 2019 23:52:21 +0000 (09:52 +1000)]
docs: update the include path documentation
Missing from
e23f1061b2b9c8d40ba7797a5ffbd6d474d604e0 and
3a91788d9254b4571ff883439931f497d8a0663f.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Tue, 12 Nov 2019 20:31:46 +0000 (22:31 +0200)]
compat: reject interpret modifier predicate with more than one value
Given
interpret ISO_Level3_Shift+AnyOf(all,extraneous) { ... };
Previously, extraneous (and further) was ignored. Now it's rejected.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Tue, 12 Nov 2019 20:09:19 +0000 (22:09 +0200)]
expr: fix log message on some unexpected expression types
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Tue, 12 Nov 2019 20:06:02 +0000 (22:06 +0200)]
Replace some tabs that sneaked in with spaces
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Tue, 12 Nov 2019 18:34:31 +0000 (20:34 +0200)]
parser: fix merge mode only applied to first vmod in a virtual_modifiers statement
Given
augment virtual_modifiers NumLock,Alt,LevelThree
Previously it was expanded (directly in the parser) to
augment virtual_modifiers NumLock;
virtual_modifiers Alt;
virtual_modifiers LevelThree;
Now it expands to
augment virtual_modifiers NumLock;
augment virtual_modifiers Alt;
augment virtual_modifiers LevelThree;
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Tue, 12 Nov 2019 18:04:13 +0000 (20:04 +0200)]
ast: use a separate expr struct for action list
Currently it's under UnaryExpr, which just doesn't make sense.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Tue, 12 Nov 2019 17:16:08 +0000 (19:16 +0200)]
ast-build: get rid of unhelpful macro
Straightforward code is better here.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 20:07:15 +0000 (22:07 +0200)]
atom: a string is greater than its prefix
Bug accidentally introduced in 9a92b46.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 19:25:01 +0000 (21:25 +0200)]
atom: combine atom_intern() and atom_lookup()
Use an "add" bool parameter instead. This simplifies the code a bit.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 11:47:16 +0000 (13:47 +0200)]
atom: correct iteration count in hash function
Fixup of ccab349 - unlike the commit message, hash a byte twice instead
of zero times, which is probably better. This is how it was before.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 11:12:02 +0000 (13:12 +0200)]
atom: describe how this odd data structure works
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 10:43:04 +0000 (12:43 +0200)]
atom: use a better hash function
FNV-1a instead of the djb2-like one from before.
Keep the unrolling since it seems quite beneficial, even though it loses
one byte if the length is odd...
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 09:49:25 +0000 (11:49 +0200)]
atom: style changes
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 09:39:17 +0000 (11:39 +0200)]
atom: remove handling of garbage input
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 9 Nov 2019 09:33:45 +0000 (11:33 +0200)]
atom: use explicit size for fingerprint
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 8 Nov 2019 22:20:45 +0000 (00:20 +0200)]
atom: replace an avoidable strlen
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 8 Nov 2019 22:05:59 +0000 (00:05 +0200)]
atom: remove redundant field
The field is redundant.
Due to alignment, this will only save memory on 32bit architectures.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 8 Nov 2019 20:40:13 +0000 (22:40 +0200)]
test/atom: increase iteration count and print random seed on failure
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 2 Nov 2019 11:31:44 +0000 (13:31 +0200)]
parser: get rid of "stealing" atoms
This requires (well, at least implemented by) casting away `const` which
is undefined behavior, and clang started to warn about it.
The micro optimization didn't save too many allocations, anyway.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Peter Hutterer [Tue, 5 Nov 2019 03:33:11 +0000 (13:33 +1000)]
test: remove a superfluous string-is-null check
A few lines above we check path_rel[0], so any null pointer will blow up
before we get here.
Found by coverity
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 5 Nov 2019 03:22:49 +0000 (13:22 +1000)]
test: fix a potential memory leak
Found by coverity
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Fri, 1 Nov 2019 08:45:43 +0000 (10:45 +0200)]
test: xkeyboard-config: bring back the progress bar
Signed-off-by: Ran Benita <ran@unusedvar.com>
Peter Hutterer [Fri, 1 Nov 2019 08:41:16 +0000 (18:41 +1000)]
test: xkeyboard-config: invoke the python3 command (#120)
python3 is always python3, but python could be python2 in some cases. Or just
missing (e.g. RHEL8).
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 1 Nov 2019 01:09:16 +0000 (11:09 +1000)]
test: xkeyboard-config: add missing variant tests
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 31 Oct 2019 23:54:29 +0000 (09:54 +1000)]
test: xkeyboard-config: use universal_newlines instead of decode
This way stdin/stdout of the process are opened in text mode and we don't need
manually decode.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 30 Oct 2019 02:03:48 +0000 (12:03 +1000)]
test: xkeyboard-config: flake8 fixes
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 30 Oct 2019 01:22:49 +0000 (11:22 +1000)]
test: xkeyboard-config: handle keyboard interrupts correctly
In python multiprocessing, each process needs to handle (and ignore) the
KeyboardInterrupt to avoid exception logging. This is a separate patch for
easier reviewing, the first hunks merely re-indent all of the
xkbcommontool/xkbcomp functions into a try/except KeyboardInterrupt block.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 30 Oct 2019 00:53:58 +0000 (10:53 +1000)]
test: xkeyboard-config: print to stderr on failure, stdout otherwise
This is a change in behavior and requires any automated callers to adjust
accordingly. Still, much easier to get the errors that way rather than it
being mixed into a thousands-of-lines output file.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 29 Oct 2019 06:06:10 +0000 (16:06 +1000)]
test: xkeyboard-config: add a multiprocessing.Pool() to speed up the test
Collect all options into a dictionary, then process that as async actions
through a process pool. This of course requires collecting the various print
statements to avoid mangled output.
This dropped the time to completion from around 14 min to 8 min on my local
machine (unscientific single run only for the original timing).
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 30 Oct 2019 01:15:49 +0000 (11:15 +1000)]
test: xkeyboard-config: use argparse for the path and the tool selection
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Thu, 31 Oct 2019 19:21:35 +0000 (21:21 +0200)]
scripts/makeheader: slight simplification
Signed-off-by: Ran Benita <ran@unusedvar.com>
Sebastian Wick [Thu, 31 Oct 2019 16:04:49 +0000 (17:04 +0100)]
scripts/makeheader: allow overriding the prefix path of the X11 headers
with X11_HEADERS_PREFIX
Signed-off-by: Sebastian Wick <sebastian@sebastianwick.net>
Peter Hutterer [Mon, 28 Oct 2019 01:40:56 +0000 (11:40 +1000)]
test: add test for the various default include paths
All tests create a temporary directory, set up the environment for that
directory and then check the include paths for the presence of that directory,
ideally in the right position of the list.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 25 Oct 2019 04:36:16 +0000 (14:36 +1000)]
Use XDG_CONFIG_HOME as first XKB search path
Use $XDG_CONFIG_HOME/xkb as the primary lookup path for XKB rules. Same
motivation as in
3a91788d9254b, however the XDG directories are more standard
and recommended these days than application-specific dotfiles.
The XDG spec says to fall back to $HOME/.config where XDG_CONFIG_HOME is not
set so we implement that behavior as well.
Fixes #112
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Sun, 20 Oct 2019 20:07:52 +0000 (23:07 +0300)]
Bump version to 0.9.1
Signed-off-by: Ran Benita <ran@unusedvar.com>
Jan Alexander Steffens (heftig) [Sun, 20 Oct 2019 19:06:19 +0000 (19:06 +0000)]
context: Don't fail to create the context if HOME isn't available
E.g. when Mutter has CAP_SYS_NICE and thus secure_getenv returns NULL.
Fixes https://bugs.archlinux.org/task/64191
[ran: changed to ignore error]
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 18 Oct 2019 21:55:21 +0000 (00:55 +0300)]
README: update my email address
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 18 Oct 2019 21:33:09 +0000 (00:33 +0300)]
Bump version to 0.9.0
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 18 Oct 2019 21:41:16 +0000 (00:41 +0300)]
build: remove leftover autotools file
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 18 Oct 2019 21:37:48 +0000 (00:37 +0300)]
test: fix printf("%s", NULL) in error path
../test/common.c: In function ‘test_get_path’:
../test/common.c:171:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
171 | fprintf(stderr, "Failed to allocate path (%d chars) for %s\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
172 | (int) path_len, path);
| ~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Wed, 16 Oct 2019 07:32:19 +0000 (10:32 +0300)]
keymap-dump: use consistent capitalization for "Group<N>"
It's used capitalized everywhere except a couple places.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Wed, 16 Oct 2019 07:27:12 +0000 (10:27 +0300)]
keymap-dump: fix invalid names used for levels above 8
xkbcomp only accepts the "Level" prefix for a level name for levels 1 to
8, but the keymap dumping code added it always, e.g. "Level15".
The plain integer, e.g. "8", "15" is always accepted, so just use that.
Fixes https://github.com/xkbcommon/libxkbcommon/issues/113
Signed-off-by: Ran Benita <ran@unusedvar.com>
Reported-by: progandy
Ran Benita [Thu, 3 Oct 2019 14:27:00 +0000 (17:27 +0300)]
context: move ~/.xkb to before XKB_CONFIG_ROOT in the default include path
Previously, the default include path was XKB_CONFIG_ROOT:~/.xkb.
The ~/.xkb include path is intended to allow the local user to customize
their keymaps without having to modify system paths.
But usually, the user only wants to customize specific parts. When
XKB_CONFIG_ROOT is first, the user can only customize through the "entry
point" (the RMLVO). When ~/.xkb is first, the user can drop in a file
and it will override the system one.
The impetus for this change is the rules file. "evdev" is hard-coded
everywhere, so it not often not possible to change to something else.
And the rules files determines how the rest of the RMLVO is interpreted.
So, to enable customization, we have these options:
A: System includes user.
B: User includes system.
C: Library goes over both in one or the other order.
Option A is problematic due to backward compatibility and is also
unnatural.
Option B gives the user control and is backward compatible, so that's
what we choose. This is also how Compose files are handled, and that
seems to work fine in the wild.
Option C is actually less flexible than B, and more complicated.
(The rules file format doesn't have an include statement yet, but it's
planned).
Signed-off-by: Ran Benita <ran@unusedvar.com>
Alan Coopersmith [Tue, 10 Sep 2019 00:56:42 +0000 (17:56 -0700)]
build: Solaris needs __EXTENSIONS__ instead of _GNU_SOURCE
Fix meson build on Solaris by using __EXTENSIONS__ where Linux & other
platforms use _GNU_SOURCE. Without this the build fails due to missing
prototypes for functions like strdup & getopt not defined in the C99
standard. (In autoconf, this was handled by AC_USE_SYSTEM_EXTENSIONS.)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Ran Benita [Sat, 10 Aug 2019 11:11:36 +0000 (14:11 +0300)]
build: remove autotools build
We introduced meson 2 years ago, hopefully that's was enough time for
everyone to convert.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Sat, 10 Aug 2019 11:04:29 +0000 (14:04 +0300)]
ci: remove travis CI
We moved to Azure Pipelines.
Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita [Fri, 9 Aug 2019 20:07:28 +0000 (23:07 +0300)]
Set up CI with Azure Pipelines
[skip ci]
Adrian Perez de Castro [Tue, 6 Aug 2019 20:55:22 +0000 (23:55 +0300)]
CI: Install graphviz using APT
This adds the missing graphviz dependency, from which Doxygen uses
"dot" to create diagrams for the documentation. Also, the meson
dependency is removed as it is installed using Pip, and ninja-build
added.
Adrian Perez de Castro [Tue, 6 Aug 2019 15:59:10 +0000 (18:59 +0300)]
CI: Publish test results from Meson
Adrian Perez de Castro [Tue, 6 Aug 2019 14:25:25 +0000 (17:25 +0300)]
CI: Try builds both with Clang and GCC
Adrian Perez de Castro [Tue, 6 Aug 2019 13:55:41 +0000 (16:55 +0300)]
CI: Enable a macOS job
Adrian Perez de Castro [Tue, 6 Aug 2019 13:24:43 +0000 (16:24 +0300)]
CI: Make Autotools and Meson builds parallel
This splits the steps for installing dependencies into a new template
file, as well as the build steps for Autotools. Both gets used to define
two jobs which can run in parallel for both build systems.
Adrian Perez de Castro [Tue, 6 Aug 2019 13:16:21 +0000 (16:16 +0300)]
CI: Always try to gather test results
Resulting test logs should be always attached to the task, regardless
of whether the test suite ran successfully or not.
Adrian Perez de Castro [Tue, 6 Aug 2019 12:34:37 +0000 (15:34 +0300)]
CI: Split Meson build steps into a separate YAML file
Adrian Perez de Castro [Tue, 6 Aug 2019 09:25:29 +0000 (12:25 +0300)]
CI: Save the Meson logs as downloadable files
This uploads the files saves to meson-build/meson-logs/ and associates
them to the pipeline task, which makes them availabl for download in the
Azure Pipelines web interface.
Adrian Perez [Tue, 6 Aug 2019 08:53:02 +0000 (11:53 +0300)]
CI: Initial set up to use Azure Pipelines
For the moment, configure only basic builds with Ubuntu 16.04, more to be added as follow-ups. [skip ci]
Ran Benita [Thu, 25 Jul 2019 07:12:53 +0000 (10:12 +0300)]
travis: improve configuration and add macOS
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 25 Jul 2019 10:49:41 +0000 (13:49 +0300)]
test/symbols-leak-test: fix sed regex on macOS
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 25 Jul 2019 10:34:49 +0000 (13:34 +0300)]
build: fixup autotools build after 97f41fe
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 25 Jul 2019 10:24:00 +0000 (13:24 +0300)]
test/symbols-leak-test: make it work with macOS diff
The <() stuff fails with an error:
diff: extra operand `/dev/fd/61'
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 25 Jul 2019 08:59:07 +0000 (11:59 +0300)]
test/rmlvo-to-keymap: drop basename usage
It wants some libgen.h include which is POSIX only, let's just remove
it as it's hardly important.
Signed-off-by: Ran Benita <ran234@gmail.com>
worldofpeace [Fri, 19 Jul 2019 06:56:41 +0000 (02:56 -0400)]
test/rmlvo-to-keymap.c: fix compilation on Darwin (#101)
program_invocation_short_name isn't portable.
Daniel Stone [Tue, 2 Jul 2019 12:48:32 +0000 (13:48 +0100)]
interactive-wayland: Port to stable xdg-shell (#100)
xdg_shell v6 was pretty close to the finalised stable version of
xdg-shell. We can now just use the stable version, which is supported
everywhere (Enlightenment, KWin, Mutter, Weston, wlroots).
This requires bumping the wayland-protocols dependency.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita [Tue, 11 Jun 2019 16:59:25 +0000 (19:59 +0300)]
Merge pull request #98 from michaelforney/popcount
Use bitwise test for power-of-2 instead of popcount
Michael Forney [Tue, 4 Jun 2019 21:01:02 +0000 (14:01 -0700)]
Use bitwise test instead of popcount to check if one bit is set
We don't need to determine the total number of bits set to determine if
exactly one is set.
Additionally, on x86_64 without any -march=* flag, __builtin_popcount
will get compiled to a function call to the compiler runtime (on gcc),
or a long sequence of bit operations (on clang).
Signed-off-by: Michael Forney <mforney@mforney.org>
Ran Benita [Wed, 5 Jun 2019 06:49:04 +0000 (09:49 +0300)]
Merge pull request #96 from Jjagg/patch-1
Fix a few doc typos
Jesse [Tue, 4 Jun 2019 21:44:42 +0000 (23:44 +0200)]
Fix some doc typos
Ran Benita [Sun, 24 Mar 2019 12:05:17 +0000 (14:05 +0200)]
Merge pull request #95 from Hi-Angel/fix-lgtm-warnings
Fix some of LGTM warnings
Konstantin Kharlamov [Sat, 23 Mar 2019 20:29:29 +0000 (23:29 +0300)]
symbols: add a comment to suppress warning from code analyzers
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Ran Benita [Tue, 12 Mar 2019 17:39:23 +0000 (19:39 +0200)]
Merge pull request #94 from milloni/milloni/m4
Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work
milloni [Tue, 12 Mar 2019 16:22:15 +0000 (16:22 +0000)]
Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work
With older versions of autotools, one needs to add this line to
Makefile.am. From the autoconf docs: "Note that if you use aclocal from
Automake to generate aclocal.m4, you must also set ACLOCAL_AMFLAGS = -I dir
in your top-level Makefile.am". [1]
I couldn't build with autoconf 2.68 without this.
[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Input.html
Signed-off-by: milloni <milloni@preemptable.org>
Ran Benita [Tue, 26 Feb 2019 16:27:53 +0000 (18:27 +0200)]
README: usage questions are alright
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Tue, 26 Feb 2019 16:26:01 +0000 (18:26 +0200)]
README: stop pointing at bugs.freedesktop.org
No-one filed bugs in there for a while, let's consolidate on the more
popular one.
Signed-off-by: Ran Benita <ran234@gmail.com>
maxice8 [Sat, 23 Feb 2019 08:55:00 +0000 (05:55 -0300)]
meson.build: use program from build machine not host or target.
We can't always execute binaries from the host or target machine,
as is the case in cross compilation.
closes #89
Ran Benita [Fri, 22 Feb 2019 20:26:49 +0000 (22:26 +0200)]
Bump version to 0.8.4
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 22 Feb 2019 20:26:11 +0000 (22:26 +0200)]
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 22 Feb 2019 13:37:27 +0000 (15:37 +0200)]
build: fix meson build from tarball generated by autotools
These files are used by the meson build only. Previously, trying to
build with meson using the tarball generated by distcheck would fail.
Fixes https://github.com/xkbcommon/libxkbcommon/issues/87.
Reported-by: manesm52
Signed-off-by: Ran Benita <ran234@gmail.com>
Peter Hutterer [Sun, 10 Feb 2019 23:19:28 +0000 (09:19 +1000)]
meson.build: link the sources directly into libxkbcommon-x11
Similar to
75ce741ab97e3d17a0c9b06dd4bdf57c00d5538e, just for the -x11
sublibrary.
This works around meson bug 3937, 'link_whole' arguments don't get added into
the final static library and we end up with a virtually empty 8-byte
libxkbcommon-x11.a file, see https://github.com/mesonbuild/meson/issues/3937
The internal lib is still built for the one test case that requires it.
Fixes #86
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Fri, 8 Feb 2019 10:39:01 +0000 (12:39 +0200)]
Bump version to 0.8.3
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 8 Feb 2019 10:38:02 +0000 (12:38 +0200)]
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 8 Feb 2019 10:29:27 +0000 (12:29 +0200)]
meson: make comment make sense now
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 8 Feb 2019 10:18:00 +0000 (12:18 +0200)]
Merge pull request #85 from whot/wip/static-lib-sources
meson.build: manually link all sources into the library
Peter Hutterer [Fri, 8 Feb 2019 02:15:48 +0000 (12:15 +1000)]
meson.build: manually link all sources into the library
This works around meson bug 3937, 'link_whole' arguments don't get added into
the final static library and we end up with a virtually empty 8-byte
libxkbcommon.a file, see https://github.com/mesonbuild/meson/issues/3937
Workaround is simply to add all sources to both libraries we need them in.
This obviously compiles them twice but this year's winter was cold and
bit of extra warmth will be appreciated.
Fixes #84
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Mon, 28 Jan 2019 14:29:09 +0000 (16:29 +0200)]
docs: fix a doxygen reference warning
Ran Benita [Fri, 25 Jan 2019 10:50:55 +0000 (12:50 +0200)]
Merge pull request #81 from whot/master
keysyms: fix comment for XKB_KEY_OCARON
Peter Hutterer [Thu, 24 Jan 2019 23:26:58 +0000 (09:26 +1000)]
keysyms: fix comment for XKB_KEY_OCARON
Reported-by: Keve Müller
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita [Tue, 22 Jan 2019 07:48:23 +0000 (09:48 +0200)]
Merge pull request #79 from jwrdegoede/add-2-new-keysyms
Sync Keysyms with recent xproto additions
Hans de Goede [Tue, 22 Jan 2019 07:31:43 +0000 (08:31 +0100)]
Sync Keysyms with recent xproto additions
xproto recently has been extended with 2 new keysyms:
XF86XK_MonBrightnessCycle
XF86XK_RotationLockToggle
This commit is the result of running "scripts/update-keysyms" on a system
with the updated xproto installed.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Ran Benita [Mon, 1 Oct 2018 07:24:45 +0000 (10:24 +0300)]
Merge pull request #69 from alanc/master
Fix off-by-one error in index check in xkb_file_type_to_string
Alan Coopersmith [Sun, 30 Sep 2018 23:04:29 +0000 (16:04 -0700)]
Fix off-by-one error in index check in xkb_file_type_to_string
Found by Oracle's Parfait 2.2 static analyzer:
Error: Buffer overrun
Read outside array bounds [read-outside-array-bounds] (CWE 125):
In array dereference of xkb_file_type_strings[type] with index type
Array size is 56 bytes, index <= 56
at line 734 of src/xkbcomp/ast-build.c in function 'xkb_file_type_to_string'.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Ran Benita [Fri, 24 Aug 2018 06:14:14 +0000 (09:14 +0300)]
darray: fix unprotected macro argument
Reported-by: @msmeissn
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Tue, 21 Aug 2018 06:05:09 +0000 (09:05 +0300)]
Merge pull request #68 from whot/wip/xkeyboard-config-tester
xkeyboard-config combination tester
Peter Hutterer [Mon, 20 Aug 2018 06:46:19 +0000 (16:46 +1000)]
test: allow for absolute paths to be resolved
This makes it possible to check a keymap sitting elsewhere than in the test
directory.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 20 Aug 2018 05:50:35 +0000 (15:50 +1000)]
test: drop the rmlvo ability from print-compiled-keymap
This is now handled by the rmlvo-to-keymap tool
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 14 Aug 2018 01:16:30 +0000 (11:16 +1000)]
test: add a tool to test-compile all LVO combinations from xkeyboard-config
This test contains of two parts:
- a simple program to convert RMLVO commandline arguments into a keymap (and
print that keymap if requested).
- a python script that runs through rules/evdev.xml, and tries to compile a
keymap for sort-of every layout/variant/option combination. Sort-of, because
we can have multiple options and it really only does one per layout(variant)
combination.
Same thing can be done using xkbcomp, but right now it doesn't take that as
argument, it's hard-coded.
This takes quite a while, installing python-tqdm is recommended to see fancy
progress bars instead of just miles of dumps.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>