commit-queue@webkit.org [Tue, 27 Sep 2011 18:19:01 +0000 (18:19 +0000)]
[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.
Install the flag, which indicates whether or not the optimization
script was executed, on the global object.
https://bugs.webkit.org/show_bug.cgi?id=68890
Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 18:17:32 +0000 (18:17 +0000)]
Autofocus on readonly inputs does not focus the element.
https://bugs.webkit.org/show_bug.cgi?id=24092
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-27
Reviewed by Ryosuke Niwa.
Source/WebCore:
Readonly input elements should be autofocusable. Removed the check.
Tests: fast/forms/autofocus-readonly-attribute.html
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
LayoutTests:
* fast/forms/autofocus-readonly-attribute-expected.txt: Added.
* fast/forms/autofocus-readonly-attribute.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 27 Sep 2011 18:06:06 +0000 (18:06 +0000)]
[GTK] Add WebKitWebContext to GTK API
https://bugs.webkit.org/show_bug.cgi?id=67931
Reviewed by Philippe Normand.
Initial implementation of WebKitWebContext for WebKit2 GTK API.
* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitWebContext.cpp: Added.
(webkitWebContextFinalize):
(webkit_web_context_init):
(webkit_web_context_class_init):
(createDefaultWebContext):
(webkit_web_context_get_default):
* UIProcess/API/gtk/WebKitWebContext.h: Added.
* UIProcess/API/gtk/tests/testwebcontext.c:
(testWebContextDefault):
(main):
* UIProcess/API/gtk/webkit2.h: Add <webkit2/WebKitWebContext.h>.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 18:04:01 +0000 (18:04 +0000)]
Remove duplicate of fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
https://bugs.webkit.org/show_bug.cgi?id=68915
Reviewed by Ryosuke Niwa.
r92496 and r92881 were only trying to move the baselines to
platform/mac-snowleopard/platform/mac/fast, but they also inadvertedly
copied the test itself.
* platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 17:58:55 +0000 (17:58 +0000)]
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Patch by Juan Carlos Montemayor Elosua <j.mont@me.com> on 2011-09-27
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This patch utilizes topCallFrame to create a stack trace when
an error is thrown. Users will also be able to use the stack()
command in jsc to get arrays with stack trace information.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::getCallerLine):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Parser.h:
(JSC::Parser::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
LayoutTests:
Unit tests that contain both normal and special cases for stack trace
generation.
* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
* fast/js/stack-trace-expected.txt: Added.
* fast/js/stack-trace.html: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 27 Sep 2011 17:55:02 +0000 (17:55 +0000)]
Clean up how FrameView accesses the RenderView
https://bugs.webkit.org/show_bug.cgi?id=68914
Reviewed by Sam Weinig.
Clean up how FrameView accesses the content renderer of its
frame. Previously, this was done in several different ways,
only some of which did null-checking.
Use an inline method to avoid having to expose Frame
in the header.
Standardize the terminology to use 'root' for this RenderView.
* page/FrameView.cpp:
(WebCore::rootRenderer):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 27 Sep 2011 17:53:32 +0000 (17:53 +0000)]
garden-o-matic results view should sort test and builder names
https://bugs.webkit.org/show_bug.cgi?id=68488
Reviewed by Andy Estes.
Previously, the test and builder names were displayed in an arbitrary
order that changed from time to time. That confused one user study
participant. This patch sorts the lists so that they occur in a
predictable order.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 27 Sep 2011 17:38:52 +0000 (17:38 +0000)]
[Chromium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882
Unreviewed rebaseline.
* platform/chromium-gpu-linux/compositing/video-page-visibility-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 17:29:46 +0000 (17:29 +0000)]
AXObjectCache cleared unnecessarily when non-top Document is detached.
https://bugs.webkit.org/show_bug.cgi?id=68636
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-27
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/deleting-iframe-destroys-axcache.html
* dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::detach):
LayoutTests:
* accessibility/deleting-iframe-destroys-axcache.html: Added.
* platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 17:27:12 +0000 (17:27 +0000)]
Unreviewed, rolling out r96108, r96111, r96113, and r96116.
http://trac.webkit.org/changeset/96108
http://trac.webkit.org/changeset/96111
http://trac.webkit.org/changeset/96113
http://trac.webkit.org/changeset/96116
https://bugs.webkit.org/show_bug.cgi?id=68913
Wait for working Qt5 (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
.:
* Source/WebKit.pro:
Source/WebCore:
* WebCore.pri:
* platform/graphics/qt/GraphicsLayerQt.cpp:
Source/WebKit/qt:
* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebframe.h:
* Api/qwebhistory.h:
* Api/qwebpage.h:
* Api/qwebsettings.h:
* Api/qwebview.h:
* QtWebKit.pro:
* WebCoreSupport/PageClientQt.h:
* WebCoreSupport/QtWebComboBox.cpp:
* WebCoreSupport/QtWebComboBox.h:
* declarative/declarative.pro:
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
* docs/webkitsnippets/webpage/main.cpp:
* examples/platformplugin/WebNotificationPresenter.h:
* tests/tests.pri:
Source/WebKit2:
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::chooseFiles):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/tests.pro:
* UIProcess/qt/ViewInterface.h:
* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
Tools:
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/ImageDiff.pro:
* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::BrowserView):
* MiniBrowser/qt/BrowserView.h:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.h:
* MiniBrowser/qt/main.cpp:
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.cpp:
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/locationedit.h:
* QtTestBrowser/main.cpp:
* QtTestBrowser/mainwindow.cpp:
* QtTestBrowser/mainwindow.h:
* QtTestBrowser/webinspector.h:
* QtTestBrowser/webpage.cpp:
* QtTestBrowser/webview.cpp:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::wkView):
(WTR::WebView::pageRef):
(WTR::WebView::~WebView):
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):
* WebKitTestRunner/qt/WebKitTestRunner.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 27 Sep 2011 17:26:23 +0000 (17:26 +0000)]
dump-as-markup conversion: editing/pasteboard/merge-end-list.html and merge-end-table.html
https://bugs.webkit.org/show_bug.cgi?id=68857
Reviewed by Kent Tamura.
Converted the tests into dump-as-markup tests. Also split each test into two tests.
* editing/pasteboard/merge-end-list-2-expected.txt: Added.
* editing/pasteboard/merge-end-list-2.html: Added.
* editing/pasteboard/merge-end-list-expected.txt: Added.
* editing/pasteboard/merge-end-list.html:
* editing/pasteboard/merge-end-table-2-expected.txt: Added.
* editing/pasteboard/merge-end-table-2.html: Added.
* editing/pasteboard/merge-end-table-expected.txt: Added.
* editing/pasteboard/merge-end-table.html:
* platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-cg-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-list-expected.txt: Removed.
* platform/gtk/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/gtk/editing/pasteboard/merge-end-table-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-list-expected.txt: Removed.
* platform/mac/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/mac/editing/pasteboard/merge-end-table-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-list-expected.txt: Removed.
* platform/qt/editing/pasteboard/merge-end-table-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-table-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 27 Sep 2011 17:18:06 +0000 (17:18 +0000)]
Crash in WebCore::HTMLParser::createHead
https://bugs.webkit.org/show_bug.cgi?id=32426
Reviewed by Darin Adler.
The crash was fixed some time ago but the test was not landed which kept the bug open.
* fast/parser/crash-HTMLParser-createHead.html: Added.
Tweaked the test case as we now throw an exception (DOM Exception 12).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 27 Sep 2011 17:06:26 +0000 (17:06 +0000)]
Fix ENABLE(SQL_DATABASE)=0 build after r95919
https://bugs.webkit.org/show_bug.cgi?id=68902
r95919 enabled OFFLINE_WEB_APPLICATIONS by default and
it needs SQLite stuff even if ENABLE_SQL_DATABASE=0.
Reviewed by Adam Barth.
* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteDatabase.cpp:
* platform/sql/SQLiteFileSystem.cpp:
* platform/sql/SQLiteStatement.cpp:
* platform/sql/SQLiteTransaction.cpp:
* storage/DatabaseAuthorizer.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 27 Sep 2011 16:55:59 +0000 (16:55 +0000)]
Crash because CSSPrimitiveValue::computeLengthDouble assumes fontMetrics are available
https://bugs.webkit.org/show_bug.cgi?id=66291
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/canvas/crash-set-font.html
This is Yet Another Missing updateFont (similar to bug 57756 and likely others). Here the issue is that
applying one of the font properties could mutate the parent style's font if m_parentStyle == m_style.
We would then query the newly created font when applying CSSPropertyFontSize, which has no font fallback
list as Font::update was never called.
The right fix would be to refactor of how we handle fonts to avoid such manual updates (see bug 62390).
Until this happens, it is better not to crash.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Added updateFont() here as the fonts could have been
mutated by the previous property change. Also added a comment explaining why it is safe to do it
this way.
LayoutTests:
* fast/canvas/crash-set-font-expected.txt: Added.
* fast/canvas/crash-set-font.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 27 Sep 2011 16:40:03 +0000 (16:40 +0000)]
[GTK] Rename WebKit2 GTK+ API main header as webkit2.h
https://bugs.webkit.org/show_bug.cgi?id=65178
Reviewed by Martin Robinson.
Source/WebKit2:
* GNUmakefile.am: Add webkit2.h.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/webkit2.h: Renamed from Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h.
* webkit2gtk.pc.in: Use webkitgtk-<api-version> as include dir.
Tools:
* GNUmakefile.am:
* GtkLauncher/main.c: Include <webkit2/webkit2.h>.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 27 Sep 2011 16:38:19 +0000 (16:38 +0000)]
[Texmap] Code cleanup: remove unused boundingRect/visibleRect calculations
https://bugs.webkit.org/show_bug.cgi?id=68897
Reviewed by Andreas Kling.
No new functionality so no new tests.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 27 Sep 2011 16:28:17 +0000 (16:28 +0000)]
[Texmap][Qt] Refactor texture-upload to allow direct chunk update
https://bugs.webkit.org/show_bug.cgi?id=68808
Add a function to BitmapTexture for direct pixel updates.
Modify BitmapTextureGL::endPaint to use that function. Since the BGRA
to RGBA swizzling is done inside that function, there's no need for the
RGBA32PremultipliedBuffer class to contain such function. Also,
RGBA32PremultipliedBuffer was renamed to BGRA32PremultipliedBuffer, correcting
an old mistake.
Reviewed by Andreas Kling.
No new tests. Existing tests in LayoutTests/compositing test this.
* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/opengl/TextureMapperGL.h:
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
* platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
* platform/graphics/qt/TextureMapperQt.h:
* platform/graphics/texmap/TextureMapper.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 27 Sep 2011 16:12:20 +0000 (16:12 +0000)]
[Qt][WK2] Buildfix after r96108.
Rubber-stamped by Andreas Kling.
Source/WebKit/qt:
* tests/tests.pri:
Tools:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
* WebKitTestRunner/qt/WebKitTestRunner.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 27 Sep 2011 15:52:14 +0000 (15:52 +0000)]
watchlist: Change watchlistparser.py to be class based.
https://bugs.webkit.org/show_bug.cgi?id=68869
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 27 Sep 2011 15:50:42 +0000 (15:50 +0000)]
Unreviewed followupfix for r96110.
This is a small adjustment of the heap size delta calculation.
* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 27 Sep 2011 15:36:39 +0000 (15:36 +0000)]
[Qt] Fix build of declarative plugin against Qt5
Reviewed by Andreas Kling.
* declarative/declarative.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 27 Sep 2011 15:35:49 +0000 (15:35 +0000)]
watchlist: Break out the diff boilerplate to allow for re-use.
https://bugs.webkit.org/show_bug.cgi?id=68871
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
Break out the diff into a new file.
* Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 27 Sep 2011 15:29:22 +0000 (15:29 +0000)]
[Qt] Fix build of WebKit2 unit-tests after r96108
Reviewed by Andreas Kling.
* UIProcess/API/qt/tests/tests.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 27 Sep 2011 15:26:34 +0000 (15:26 +0000)]
Web Inspector: UI performance: introduce heap size tracking stats.
https://bugs.webkit.org/show_bug.cgi?id=68901
It is interesting how much the heap memory is used by Inspector in order of running the test.
Reviewed by Yury Semikhatsky.
Tools:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::showDevTools):
(TestShell::closeDevTools):
LayoutTests:
* inspector/performance/resources/network-append-30-requests.html:
* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Tue, 27 Sep 2011 15:17:53 +0000 (15:17 +0000)]
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=68852
Rebaseline GPU tests for Mac, Win.
Reviewed by Shinichiro Hamaji.
* platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 27 Sep 2011 15:11:11 +0000 (15:11 +0000)]
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.
https://bugs.webkit.org/show_bug.cgi?id=68687
Reviewed by Andreas Kling.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 14:49:25 +0000 (14:49 +0000)]
Clipped high quality blur in skia has been fixed. Rebaseline layout tests.
https://bugs.webkit.org/show_bug.cgi?id=68577
Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
* platform/chromium-linux-x86/fast/box-shadow: Removed.
* platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 27 Sep 2011 14:13:07 +0000 (14:13 +0000)]
Source/WebCore: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved.
Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613
Reviewed by Yury Semikhatsky.
* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
* inspector/Inspector.draft-01.json:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMAttrImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMNode.prototype._setAttribute):
(WebInspector.DOMNode.prototype._removeAttribute):
(WebInspector.DOMAgent.prototype._attributeModified):
(WebInspector.DOMAgent.prototype._attributeRemoved):
(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMDispatcher.prototype.attributeModified):
(WebInspector.DOMDispatcher.prototype.attributeRemoved):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/validate-protocol-compatibility:
LayoutTests: Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613
Reviewed by Yury Semikhatsky.
* inspector/elements/mutate-unknown-node.html-disabled:
* inspector/elements/set-attribute.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 27 Sep 2011 14:09:00 +0000 (14:09 +0000)]
[Qt][WK2] Add support for hover API in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68369
Reviewed by Andreas Kling.
Source/WebKit2:
Based on the patch from Igor Oliveira in the same bug.
Expose a linkHovered() signal in QDesktopWebView, that passes the QUrl and the
QString corresponding to the link title. I left textContent out because was
unsure of its use case.
In QDesktopWebView we store the last URL and title emitted to make sure we send
the signal only if either value changes. Tests were added to the QML element to
check: if values are correctly emitted and if we don't emit more signals than
necessary.
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didMouseMoveOverElement):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/test2.html:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_mouseDidMoveOverElement):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/TouchViewInterface.h:
(WebKit::TouchViewInterface::didMouseMoveOverElement):
* UIProcess/qt/ViewInterface.h:
Tools:
Change the statusbar to show the link URL when hovering links in
MiniBrowser using QDesktopWebView.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onLinkHovered):
* MiniBrowser/qt/BrowserWindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 13:23:49 +0000 (13:23 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 13:12:20 +0000 (13:12 +0000)]
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 13:00:21 +0000 (13:00 +0000)]
Unreviewed, rolling out r96070 and r96075.
http://trac.webkit.org/changeset/96070
http://trac.webkit.org/changeset/96075
https://bugs.webkit.org/show_bug.cgi?id=68893
WK2 tests started crashing after r96070 for SL and Qt
(Requested by torarne on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/WebCore:
* page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner):
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner):
* platform/ScrollableArea.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::imageChanged):
LayoutTests:
* compositing/iframes/repaint-after-losing-scrollbars-expected.png:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 27 Sep 2011 12:58:02 +0000 (12:58 +0000)]
[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
https://bugs.webkit.org/show_bug.cgi?id=68889
Reviewed by Andreas Kling.
Signal parameters needs to be explicitly named in QML to be accessible.
This patch fix this problem.
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 27 Sep 2011 12:39:16 +0000 (12:39 +0000)]
[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
https://bugs.webkit.org/show_bug.cgi?id=67732
Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.
Reviewed by Pavel Feldman.
* src/js/Tests.js:
(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
(.TestSuite.prototype.testConsoleOnNavigateBack):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 12:34:42 +0000 (12:34 +0000)]
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885
Unreviewed typo fix.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 27 Sep 2011 12:21:24 +0000 (12:21 +0000)]
Web Inspector: JS exception upon clicking on "Word Wrap" checkbox in Settings screen
https://bugs.webkit.org/show_bug.cgi?id=68888
Reviewed by Pavel Feldman.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 27 Sep 2011 12:06:28 +0000 (12:06 +0000)]
Web Inspector: migrate RawSourceCode clients to SourceMapping class.
https://bugs.webkit.org/show_bug.cgi?id=68524
Source/WebCore:
Clients should use uiSourceCode(), rawLocationToUILocation(), uiLocationToRawLocation() methods of SourceMapping class.
Initially, RawSourceCode may not have associated SourceMapping, so it is natural to extract this methods and associated state to a separate class.
Reviewed by Yury Semikhatsky.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get sourceMapping):
LayoutTests:
Reviewed by Yury Semikhatsky.
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 11:20:34 +0000 (11:20 +0000)]
wrap attribute of textarea element cannot be accessed by JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=68592
Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.
Source/WebCore:
Added JS interface for wrap attribute to HTMLTextAreaElement.idl.
Test: fast/forms/textarea-wrap-attribute.html
* html/HTMLTextAreaElement.idl:
LayoutTests:
Added test cases to check accessibility to wrap attribute by JS.
* fast/forms/textarea-wrap-attribute-expected.txt: Added.
* fast/forms/textarea-wrap-attribute.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 27 Sep 2011 10:28:00 +0000 (10:28 +0000)]
[GTK] Add compatibility methods for DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68884
Reviewed by Philippe Normand.
Add compatibility methods for our DOM bindings.
* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_blob_slice): alias to the new method name.
(webkit_dom_html_form_element_dispatch_form_change): this was
removed from WebCore, so just print a warning about it.
(webkit_dom_html_form_element_dispatch_form_input): ditto.
* bindings/gobject/WebKitDOMCustom.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 10:22:19 +0000 (10:22 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 10:15:46 +0000 (10:15 +0000)]
[Chromium] Layout Test fast compositing/geometry/limit-layer-bounds-transformed-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68886
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 10:06:08 +0000 (10:06 +0000)]
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 09:56:27 +0000 (09:56 +0000)]
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68852
Unreviewed test_expectations.txt update. We may need GPU-CG, too.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 09:51:51 +0000 (09:51 +0000)]
[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 27 Sep 2011 09:35:55 +0000 (09:35 +0000)]
[GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616
Reviewed by Martin Robinson.
.:
* GNUmakefile.am: Initialize $libwebkitgtkincludedir to
$(prefix)/include/webkitgtk-<api-version>
Source/JavaScriptCore:
Install header files under $libwebkitgtkincludedir/JavaScriptCore.
* GNUmakefile.am: Use $libwebkitgtkincludedir.
* javascriptcoregtk.pc.in: Use webkitgtk-<api-version> as include dir.
Source/WebKit/gtk:
Install header files under $libwebkitgtkincludedir/webkit.
* GNUmakefile.am: Use $libwebkitgtkincludedir.
* webkit.pc.in: Use webkitgtk-<api-version> as include dir.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 09:31:07 +0000 (09:31 +0000)]
[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=68881
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 27 Sep 2011 09:24:24 +0000 (09:24 +0000)]
Unreviewed, GTK gardening
* platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing
in 32-Bits Release.
* platform/gtk/test_expectations.txt: Mark
media/video-timeupdate-reverse-play.html as flaky because of bug 67407.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 27 Sep 2011 09:00:08 +0000 (09:00 +0000)]
Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic
https://bugs.webkit.org/show_bug.cgi?id=68875
Reviewed by Kent Tamura.
Added InsertedNode class inside ReplaceSelection to encapsulate m_firstNodeInserted and m_lastLeafInserted.
Deployed it in removeRedundantStylesAndKeepStyleSpanInline, doApply, and insertAsListItems of ReplaceSelectionCommand.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::respondToNodeInsertion):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::InsertedNodes::firstNodeInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::lastLeafInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
* editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval): Moved from DeleteSelectionCommand.cpp.
* editing/htmlediting.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 27 Sep 2011 08:56:26 +0000 (08:56 +0000)]
[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 08:33:21 +0000 (08:33 +0000)]
Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing.
https://bugs.webkit.org/show_bug.cgi?id=60972
Patch by Arun Patole <bmf834@motorola.com> on 2011-09-27
Reviewed by Philippe Normand.
Source/WebCore:
The paused attribute should be set to true and the media element should emit a 'paused' at the end of playback.
WHATWG revision r6562: http://html5.org/tools/web-apps-tracker?from=6561&to=6562
Test: media/media-element-play-after-eos.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): set m_paused to true and schedule 'pause' event when playback ended.
LayoutTests:
Update media tests as the 'pause' event should be fired
and 'paused' should be set to true at the end of playback.
* media/event-attributes-expected.txt:
* media/event-attributes.html:
* media/media-element-play-after-eos-expected.txt: Added.
* media/media-element-play-after-eos.html: Added.
* media/video-loop-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 27 Sep 2011 08:21:06 +0000 (08:21 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/Skipped:
Skip outdated canvas/philip/tests/2d.drawImage.outsidesource.html.
* platform/gtk/test_expectations.txt:
media/video-playing-and-pause.html is flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 27 Sep 2011 08:08:27 +0000 (08:08 +0000)]
Unreviewed, GTK rebaseline after r95845, r95897 and r95857.
* platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
* platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
* platform/gtk/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
* platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 27 Sep 2011 07:55:09 +0000 (07:55 +0000)]
[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
https://bugs.webkit.org/show_bug.cgi?id=68848
Reviewed by Andreas Kling.
The presence of the FINAL attribute indicates that the property will not be
overridden by a derived class. This can be used for performance optimizations
by QML.
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qwebnavigationcontroller.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 07:34:16 +0000 (07:34 +0000)]
<input> with autofocus doesn't lose focus when it has a certain onblur listener
https://bugs.webkit.org/show_bug.cgi?id=68513
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/autofocus-focus-only-once.html
These changes make sure that an element is focused only once when autofocus attribute is used.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::shouldAutofocus):
(WebCore::HTMLFormControlElement::attach):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::hasAutofocused):
(WebCore::HTMLFormControlElement::setAutofocused):
LayoutTests:
These changes make sure that an element is focused only once when autofocus attribute is used.
* fast/forms/autofocus-focus-only-once-expected.txt: Added.
* fast/forms/autofocus-focus-only-once.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Tue, 27 Sep 2011 07:05:21 +0000 (07:05 +0000)]
[Qt] Add missing test expecteds after r95924.
Unreviewed gardening.
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 27 Sep 2011 06:55:34 +0000 (06:55 +0000)]
dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
https://bugs.webkit.org/show_bug.cgi?id=68865
Reviewed by Kent Tamura.
Converted the test.
* editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
* editing/deleting/delete-to-end-of-paragraph.html:
* platform/chromium-linux/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* platform/mac-leopard/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Tue, 27 Sep 2011 06:43:27 +0000 (06:43 +0000)]
[Qt] Skip two tests because they are failing after r96070.
Unreviewed gardening.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 27 Sep 2011 06:32:10 +0000 (06:32 +0000)]
garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 06:27:02 +0000 (06:27 +0000)]
Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68345
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Previously, the following test cases fail or crash:
- shouldBe("new PopStateEvent('eventType', { state: object1 }).state", "object1") -> FAIL
- new PopStateEvent('eventType', { state: document }).state -> CRASH in DRT
This is because PopStateEvent.state is implemented not as ScriptValue but as SerializedScriptValue.
However, we cannot simply change the type of PopStateEvent.state to ScriptValue,
since PopStateEvent can be constructed in the context that does not know ScriptValue.
For example, Document.cpp calls PopStateEvent::create() with SerializedScriptValue
popped from HistoryItem, but we cannot deserialize the SerializedScriptValue into
the corresponding ScriptValue here because the deserialization requires ExecState.
In other words, although we want to store PopStateEvent.state by ScriptValue internally,
PopStateEvent still needs to provide an API to construct it with SerializedScriptValue.
With these observations, this patch makes the following changes:
- If PopStateEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When PopStateEvent.state is called, the ScriptValue is returned.
- If PopStateEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point). When PopStateEvent.state is called, the SerializedScriptValue is
deserialized into the corresponding ScriptValue, and the ScriptValue is returned.
Tests: fast/events/constructors/pop-state-event-constructor.html
fast/events/fire-popstate-event.html
* GNUmakefile.list.am: Added JSPopStateEventCustom.cpp.
* UseJSC.cmake: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state): Custom getter for PopStateEvent.state.
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter): Custom getter for PopStateEvent.state.
* dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit): Added initialization code for PopStateEvent.m_state.
(WebCore::PopStateEvent::PopStateEvent): Ditto.
(WebCore::PopStateEvent::create): Ditto.
(WebCore::PopStateEvent::initPopStateEvent): Ditto.
* dom/PopStateEvent.h:
(WebCore::PopStateEvent::serializedState): Getter.
(WebCore::PopStateEvent::state): Getter.
* dom/PopStateEvent.idl: Change the type of 'stateArg' and 'state' to DOMObject. Added [CustomGetter] to 'state'.
LayoutTests:
* fast/events/constructors/pop-state-event-constructor-expected.txt:
* fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 27 Sep 2011 06:26:14 +0000 (06:26 +0000)]
[Qt][WK2] One more unreviewed buildfix after r96005.
* WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 27 Sep 2011 06:15:20 +0000 (06:15 +0000)]
[Qt][WK2] Unreviewed buildfix after r96005.
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 27 Sep 2011 05:50:02 +0000 (05:50 +0000)]
Pixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67858
Reviewed by Darin Adler.
When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.
Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).
* page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
* platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
* rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 27 Sep 2011 05:12:24 +0000 (05:12 +0000)]
Translucent scrollbars on composited layers render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58515
Source/WebCore:
Reviewed by Sam Weinig.
Scrollbars in composited elements were getting drawn twice,
because r41203 moved the call to paintOverflowControls() out of
RenderLayer::paintLayer(), but forgot to change RenderLayerBacking::paintIntoLayer().
Test: compositing/scrollbar-painting.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
LayoutTests:
Reviewed by Sam Weinig.
Pixel test with translucent scrollbars, to test whether they get
rendered twice.
* compositing/scrollbar-painting-expected.png: Added.
* compositing/scrollbar-painting-expected.txt: Added.
* compositing/scrollbar-painting.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 27 Sep 2011 03:24:03 +0000 (03:24 +0000)]
REGRESSION (r95912): Conservative marking doesn't filter out pointers to
MarkedBlock metadata
https://bugs.webkit.org/show_bug.cgi?id=68860
Reviewed by Oliver Hunt.
Bencher says no performance change, maybe a 7% speedup on kraken-imaging-darkroom.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::isAtomAligned): Renamed atomMask to atomAlignment mask
because the mask doesn't produce the actual atom number.
(JSC::MarkedBlock::isLiveCell): Testing just for alignment isn't good
enough; we also need to test that a pointer is beyond the metadata section
of a MarkedBlock, to avoid treating random metadata as a JSCell.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 27 Sep 2011 02:36:55 +0000 (02:36 +0000)]
[Qt] Fix WK2 build after r96014
https://bugs.webkit.org/show_bug.cgi?id=68856
Reviewed by Gustavo Noronha Silva.
Commit r96014 added inspectorBaseURL for Qt but removed
inspectorPageURL, adding it back.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 27 Sep 2011 02:18:14 +0000 (02:18 +0000)]
[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417
Source/WebCore:
Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.
Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.
* platform/graphics/IntRect.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418
Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.
* tests/CCLayerTreeHostTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 02:07:46 +0000 (02:07 +0000)]
Put back all Chromium platform failing expectations for some tests (they
still fail on all platforms on the GPU bots).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 27 Sep 2011 01:44:36 +0000 (01:44 +0000)]
[MutationObservers] implement MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=68824
Reviewed by Darin Adler.
Implements MutationRecord as specified in the thread at
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html,
including some minor naming changes from the original proposal.
This is a small part of the MutationObserver API, see
https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug covering
this feature.
No new tests as this isn't yet exposed to the platform.
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/MutationRecord.cpp: Added.
(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::MutationRecord):
(WebCore::MutationRecord::~MutationRecord):
* dom/MutationRecord.h: Added.
(WebCore::MutationRecord::target):
(WebCore::MutationRecord::addedNodes):
(WebCore::MutationRecord::removedNodes):
(WebCore::MutationRecord::previousSibling):
(WebCore::MutationRecord::nextSibling):
(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):
(WebCore::MutationRecord::oldValue):
(WebCore::MutationRecord::setOldValue):
* dom/MutationRecord.idl: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 01:36:08 +0000 (01:36 +0000)]
Implement a CloseEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68793
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/close-event-constructor.html
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKey): Just removed an extra space.
(WebCore::OptionsObject::getKeyValue): Returns an unsigned short value corresponding to the given key.
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8EventConstructors.cpp: Added the CloseEvent constructor.
* websockets/CloseEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled close-event-constructor.html, since now V8 has the CloseEvent constructor.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 27 Sep 2011 01:29:20 +0000 (01:29 +0000)]
Clean up CachedResource::load(). Collapse its
logic into a single callsite, taking just a
CachedResourceLoader and a ResourceLoaderOptions.
1. Its 'incremental' parameter is redundant.
2. With 'incremental' removed, the SecurityCheckPolicy is the only
parameter difference between the CachedResource::load() variants.
Making it a part of ResourceLoaderOptions removes yet another random
enum that is passed around individually.
3. We currently have to call setResourceLoaderOptions() before load() on a
new CachedResource, so we should just take the ResourceLoaderOptions in load().
https://bugs.webkit.org/show_bug.cgi?id=67443
Reviewed by Antti Koivisto.
No new tests, refactor only.
* loader/DocumentThreadableLoader.cpp:
* loader/FrameLoaderTypes.h: Move SecurityCheckPolicy to ResourceLoaderOptions.h.
* loader/MainResourceLoader.cpp:
* loader/NetscapePlugInStreamLoader.cpp:
* loader/ResourceLoadScheduler.cpp:
* loader/ResourceLoadScheduler.h:
* loader/ResourceLoader.cpp: Enforce SecurityCheckPolicy here instead of SubresourceLoader.
* loader/ResourceLoaderOptions.h: Store SecurityCheckPolicy on ResourceLoaderOptions.
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::defaultCachedResourceOptions): Define the default ResourceLoaderOptions for
CachedResource loads here instead of as a default parameter on requestResource().
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData): Remove m_incremental, since its purpose
is already enforced in the data() implementation of every CachedResource that doesn't want
incremental loads.
* loader/cache/CachedResourceRequest.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 27 Sep 2011 01:27:04 +0000 (01:27 +0000)]
garden-o-matic should be pretty in Open Sans.
https://bugs.webkit.org/show_bug.cgi?id=68845
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 01:13:06 +0000 (01:13 +0000)]
Chromium test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 27 Sep 2011 00:57:51 +0000 (00:57 +0000)]
editing/selection/select-bidi-run.html fails on Chromium Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=68832
Unreviewed; remove the failing test expectation because it started passing after r96016.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 27 Sep 2011 00:55:57 +0000 (00:55 +0000)]
Skip the test added by r95964 on Qt and GTK because it has been failing
on those two platforms. The failure is tracked by the bugs 68854 and 68855.
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 27 Sep 2011 00:52:19 +0000 (00:52 +0000)]
garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
https://bugs.webkit.org/show_bug.cgi?id=68841
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 00:43:02 +0000 (00:43 +0000)]
IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
https://bugs.webkit.org/show_bug.cgi?id=68818
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/factory-basics.html
Adds ability to enumerate IndexedDB databases within an origin.
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* storage/IDBAny.cpp:
(WebCore::IDBAny::domStringList):
(WebCore::IDBAny::set):
* storage/IDBAny.h:
* storage/IDBBackingStore.h:
* storage/IDBCallbacks.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
* storage/IDBFactory.h:
* storage/IDBFactory.idl:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):
* storage/IDBLevelDBCoding.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* storage/IDBRequest.h:
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::getDatabaseNames):
* storage/IDBSQLiteBackingStore.h:
Source/WebKit/chromium:
Adds ability to enumerate IndexedDB databases within an origin.
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
* src/IDBCallbacksProxy.h:
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
* src/WebIDBFactoryImpl.h:
LayoutTests:
Adds ability to enumerate IndexedDB databases within an origin.
* storage/indexeddb/factory-basics-expected.txt: Added.
* storage/indexeddb/factory-basics.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 00:40:40 +0000 (00:40 +0000)]
Remove failing Chromium expectations for tests that now pass.
Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.
* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 27 Sep 2011 00:36:19 +0000 (00:36 +0000)]
<animateColor> applied to filtered ellipse does not update
https://bugs.webkit.org/show_bug.cgi?id=68457
<rdar://problem/
10154777>
Reviewed by Darin Adler.
Invalidate the filter's cache when style changes take place so that style changes are respected.
Test: svg/filters/animate-fill.svg
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 27 Sep 2011 00:35:41 +0000 (00:35 +0000)]
[Qt] [WK2] Fix build after r95982
https://bugs.webkit.org/show_bug.cgi?id=68842
Reviewed by Anders Carlsson.
The patch in r95982 removed the paint() function, because it was doing
nothing (in both implementations). This patch remove the call we had
for it to fix the build.
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::paintContent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Tue, 27 Sep 2011 00:23:31 +0000 (00:23 +0000)]
Removed an unnecessary include in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=68834
Reviewed by Darin Fisher.
* src/WebFrameImpl.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 00:23:09 +0000 (00:23 +0000)]
Remove failing expectations for some ruby tests, since they were
renamed to -disabled with r94327 and thus aren't being run at all.
Add compositing/video-page-visibility.html Windows GPU baselines.
* platform/chromium-gpu-win/compositing/video-page-visibility-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 00:06:52 +0000 (00:06 +0000)]
Unreviewed Chromium test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 27 Sep 2011 00:03:07 +0000 (00:03 +0000)]
watchlist: Add parsing for definition section.
https://bugs.webkit.org/show_bug.cgi?id=68850
Reviewed by Adam Barth.
* Scripts/webkitpy/common/watchlist/watchlist.py:
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Mon, 26 Sep 2011 23:53:42 +0000 (23:53 +0000)]
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727
Reviewed by Geoffrey Garen.
JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 26 Sep 2011 23:29:34 +0000 (23:29 +0000)]
Remove failing Chromium test expectations for tests that now pass
(mainly due to r95751, which implemented Function.prototype.bind for
JSC, resulting in baseline updates that now work for V8 too).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 26 Sep 2011 23:21:42 +0000 (23:21 +0000)]
Set but unused variables cleanup in v8 bindings (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68079
Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/websocket/tests/hybi/send-object-tostring-check.html
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
LayoutTests:
* http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-object-tostring-check.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 26 Sep 2011 23:07:50 +0000 (23:07 +0000)]
switch the initial value of flex-order to 0
https://bugs.webkit.org/show_bug.cgi?id=68820
Source/WebCore:
The spec changed from having an initial value of 1 to 0.
Reviewed by Ojan Vafai.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialFlexOrder):
LayoutTests:
Reviewed by Ojan Vafai.
* css3/flexbox/flex-order.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Mon, 26 Sep 2011 23:02:17 +0000 (23:02 +0000)]
Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397
Reviewed by Simon Fraser.
Source/JavaScriptCore:
Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
* wtf/Platform.h:
WebKitLibraries:
Enable REQUEST_ANIMATION_FRAME for Windows
* win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 26 Sep 2011 23:00:37 +0000 (23:00 +0000)]
Fix WebKitTestRunner builds for Cairo, Windows and Qt.
* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Mon, 26 Sep 2011 22:58:29 +0000 (22:58 +0000)]
OfflineAudioDestinationNode must wait for thread completion in uninitialize()
https://bugs.webkit.org/show_bug.cgi?id=68725
Reviewed by Kenneth Russell.
No new tests. This fixes internal implementation details.
* webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::uninitialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 26 Sep 2011 22:50:38 +0000 (22:50 +0000)]
editing/selection/select-bidi-run.html timeouts on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=68831
Reviewed by Enrica Casucci.
Click at (0,0) to reset click count instead of a long leapForward.
* editing/selection/select-bidi-run.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 26 Sep 2011 22:46:28 +0000 (22:46 +0000)]
REGRESSION (r95747): Activating the web inspector causes the web process to be killed
https://bugs.webkit.org/show_bug.cgi?id=68762
Reviewed by Anders Carlsson.
* UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
Tell Web process that loading resources from WebCore resources directory is OK.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
* UIProcess/WebProcessProxy.h:
Renamed willLoadHTMLStringWithBaseURL to more generic assumeReadAccessToBaseURL.
* UIProcess/WebInspectorProxy.h:
* UIProcess/efl/WebInspectorEfl.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
Report what base directory Inspector has access to.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Mon, 26 Sep 2011 22:45:42 +0000 (22:45 +0000)]
[Chromium] Update the test expectaion file for media related tests.
It includes updating bug numbers, removing
media/video-controls-visible-audio-only.html, and unskipping
media/media-document-audio-repaint.html.
https://bugs.webkit.org/show_bug.cgi?id=68254
Reviewed by David Levin.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 26 Sep 2011 22:34:54 +0000 (22:34 +0000)]
Source/WebKit/chromium: Fix copy and paste error in r96002.
* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):
LayoutTests: Remove test that no longer crashes (fixed by r95985).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 26 Sep 2011 22:28:31 +0000 (22:28 +0000)]
[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68837
Reviewed by Martin Robinson.
* bindings/scripts/CodeGeneratorGObject.pm: add getters (but not
setters) for 'Replaceable' attributes. Punt for the future
actually making them settable, since it seems non trivial.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 26 Sep 2011 22:27:19 +0000 (22:27 +0000)]
Leopard build fix.
* testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 26 Sep 2011 22:22:23 +0000 (22:22 +0000)]
IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.
Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
* storage/IDBLevelDBCoding.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Mon, 26 Sep 2011 22:21:04 +0000 (22:21 +0000)]
[skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
https://bugs.webkit.org/show_bug.cgi?id=68807
Reviewed by Stephen White.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 26 Sep 2011 22:19:10 +0000 (22:19 +0000)]
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Tools:
Reviewed by Sam Weinig.
Convert DumpRenderTree to use use the repaint rects
exposed via WebKit API when generating the repaint test
overlay.
Fix WebKitTestRunner to work with repaint tests, again
using the repaint rects exposed from WK2.
In both cases, layoutTestController.display() now just
forces a display of the web view, and turns on repaint
rect tracking on the main FrameView.
Later, when pixel results are requested, the alpha overlay
that shows the repaint rects is generated using the list
of rects supplied by WebCore.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(displayWebView):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(paintRepaintRectOverlay):
(createBitmapContextFromWebView):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::setRepaintRects):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
(WTR::InjectedBundlePage::dump):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::display):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
LayoutTests:
Reviewed by Sam Weinig.
Update Mac results to use the new repaint rects. Differences from old results:
* There are no longer invalidates from scrolling.
* We no longer see the effects of AppKit rect coalescing.
* Composting tests show the overlay now, but repaints in compositing layers do not show.
Bad results in a couple of tests are covered by bugs 68830 and 68829.
* platform/mac/fast/repaint/4774354-expected.png:
* platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
* platform/mac/fast/repaint/border-radius-repaint-expected.png:
* platform/mac/fast/repaint/clipped-relative-expected.png:
* platform/mac/fast/repaint/containing-block-position-change-expected.png:
* platform/mac/fast/repaint/control-clip-expected.png:
* platform/mac/fast/repaint/delete-into-nested-block-expected.png:
* platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
* platform/mac/fast/repaint/fixed-scroll-simple-expected.png:
* platform/mac/fast/repaint/flexible-box-overflow-expected.png:
* platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
* platform/mac/fast/repaint/float-move-during-layout-expected.png:
* platform/mac/fast/repaint/float-overflow-expected.png:
* platform/mac/fast/repaint/float-overflow-right-expected.png:
* platform/mac/fast/repaint/iframe-scroll-repaint-expected.png:
* platform/mac/fast/repaint/inline-block-overflow-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/mac/fast/repaint/layer-child-outline-expected.png:
* platform/mac/fast/repaint/layer-outline-expected.png:
* platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/mac/fast/repaint/line-overflow-expected.png:
* platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png:
* platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png:
* platform/mac/fast/repaint/outline-child-repaint-expected.png:
* platform/mac/fast/repaint/outline-shrinking-expected.png:
* platform/mac/fast/repaint/overflow-delete-line-expected.png:
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
* platform/mac/fast/repaint/repaint-during-scroll-expected.png:
* platform/mac/fast/repaint/scale-page-shrink-expected.png:
* platform/mac/fast/repaint/search-field-cancel-expected.png:
* platform/mac/fast/repaint/selection-after-remove-expected.png:
* platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/mac/fast/repaint/static-to-positioned-expected.png:
* platform/mac/fast/repaint/table-cell-move-expected.png:
* platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
* platform/mac/fast/repaint/text-shadow-expected.png:
* platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 26 Sep 2011 22:12:55 +0000 (22:12 +0000)]
Disable Chromium gesture recognizer tests that started to fail on the
Mac bots recently.
* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc