platform/upstream/dotnet/runtime.git
6 years agoAdding test to verify FileStream.Dispose() ignores IO Related Exception in finalizer...
Maryam Ariyan [Thu, 15 Feb 2018 03:20:00 +0000 (22:20 -0500)]
Adding test to verify FileStream.Dispose() ignores IO Related Exception in finalizer (dotnet/corefx#26921)

* Adding test to verify FileStream.Dispose() skips IO Related Exception only on finalization

* Skipping test on netfx because the behavior in netfx is different

Commit migrated from https://github.com/dotnet/corefx/commit/a15cc53eb5a4248c76bdc60beb3e31628bd8acf8

6 years agoFixing fa-IR negative currency format for test GetCurrencyNegativePatterns (dotnet...
Maryam Ariyan [Thu, 15 Feb 2018 03:03:22 +0000 (22:03 -0500)]
Fixing fa-IR negative currency format for test GetCurrencyNegativePatterns (dotnet/corefx#27138)

Fixes dotnet/corefx#27022 and dotnet/corefx#27127

Commit migrated from https://github.com/dotnet/corefx/commit/fe548ac62bdc46785e7e153a5f2a3de15daefd6d

6 years agoDisable a SignalAndWait test so that relevant change in CoreCLR can be brought into...
Koundinya Veluri [Thu, 15 Feb 2018 00:15:01 +0000 (16:15 -0800)]
Disable a SignalAndWait test so that relevant change in CoreCLR can be brought into CoreFX (dotnet/corefx#27131)

Commit migrated from https://github.com/dotnet/corefx/commit/6f06dcc32df6939e726d46ca45f8491db7967fb8

6 years agoAdd some pattern transformation tests (dotnet/corefx#27133)
Jeremy Kuhne [Thu, 15 Feb 2018 00:06:04 +0000 (16:06 -0800)]
Add some pattern transformation tests (dotnet/corefx#27133)

Commit migrated from https://github.com/dotnet/corefx/commit/11182e0c4e65fb1e6fa0596ca9d991e3382c9fb2

6 years agoreduce regex op code time (dotnet/corefx#26877)
Viktor Hofer [Thu, 15 Feb 2018 00:02:08 +0000 (01:02 +0100)]
reduce regex op code time (dotnet/corefx#26877)

* reduce regex op code time

* Use ValueListBuilder and stackalloc during op code generation

* Increasing op array size

Commit migrated from https://github.com/dotnet/corefx/commit/1eb5ddf1d0a3dbc0a221769a45d81d2a2b7fa81d

6 years agoAdd support for PDB Checksum debug directory entry (dotnet/corefx#26976)
Tomáš Matoušek [Wed, 14 Feb 2018 23:01:55 +0000 (15:01 -0800)]
Add support for PDB Checksum debug directory entry (dotnet/corefx#26976)

Commit migrated from https://github.com/dotnet/corefx/commit/6b099e771d3b775b5cd273ec1b6fcec12ee7abbe

6 years agoMerge pull request dotnet/corefx#27088 from geoffkizer/refactorloopbackserver
Geoff Kizer [Wed, 14 Feb 2018 19:13:34 +0000 (11:13 -0800)]
Merge pull request dotnet/corefx#27088 from geoffkizer/refactorloopbackserver

reorganize and cleanup some LoopbackServer code

Commit migrated from https://github.com/dotnet/corefx/commit/46267c1dbe46f0127e670ce25933ff49a5ec9d6e

6 years agoAdd FixedTimeEquals and other crypto helper routines as public API
Jeremy Barton [Wed, 14 Feb 2018 15:33:30 +0000 (07:33 -0800)]
Add FixedTimeEquals and other crypto helper routines as public API

Commit migrated from https://github.com/dotnet/corefx/commit/3872bafe8186a3e74cb66efa4a2835d60ed67ba2

6 years agoAPI tweaks to match latest updates to spec (dotnet/corefx#27102)
Jeremy Kuhne [Wed, 14 Feb 2018 05:49:57 +0000 (21:49 -0800)]
API tweaks to match latest updates to spec (dotnet/corefx#27102)

* API tweaks to match latest updates to spec

Add a few new tests

See dotnet/corefx#25873

* Properly clear state when enumerating on Unix.
Make sure we don't include special directories in subdir processing. Add test.
Collapse helper that was only called in one place, and remove dead one.

Commit migrated from https://github.com/dotnet/corefx/commit/1c9cd8118abfa13165d88a4e660fbdcc6c2ebc4c

6 years agoFix and Enable Most ETW EventSource Tests (dotnet/corefx#27107)
Brian Robbins [Wed, 14 Feb 2018 04:25:55 +0000 (20:25 -0800)]
Fix and Enable Most ETW EventSource Tests (dotnet/corefx#27107)

Commit migrated from https://github.com/dotnet/corefx/commit/ad52ae103416ea67e30abf21c19d5d0c0cd01b11

6 years agoMerge pull request dotnet/corefx#27007 from pakrym/pakrym/pipelines
Krzysztof Cwalina [Wed, 14 Feb 2018 00:37:20 +0000 (16:37 -0800)]
Merge pull request dotnet/corefx#27007 from pakrym/pakrym/pipelines

Add System.IO.Pipelines API

Commit migrated from https://github.com/dotnet/corefx/commit/3c708ab64564304fed352355b52e2ea047860e4d

6 years agofix tests from merge
Geoff Kizer [Wed, 14 Feb 2018 00:03:28 +0000 (16:03 -0800)]
fix tests from merge

Commit migrated from https://github.com/dotnet/corefx/commit/b028092ce1af45e109edb0609b7b8cef42ee8a99

6 years agoadd response generation overloads
Geoff Kizer [Tue, 13 Feb 2018 23:03:42 +0000 (15:03 -0800)]
add response generation overloads

Commit migrated from https://github.com/dotnet/corefx/commit/6943fc7c0e92359e6335a618f6ff5ee8402af4ac

6 years agoaddress PR feedback
Geoff Kizer [Tue, 13 Feb 2018 21:14:44 +0000 (13:14 -0800)]
address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/6ab005635528a03daa52ca727a4a74dcc0316830

6 years agoreorganize and cleanup some LoopbackServer code
Geoff Kizer [Sun, 11 Feb 2018 22:04:30 +0000 (14:04 -0800)]
reorganize and cleanup some LoopbackServer code

Commit migrated from https://github.com/dotnet/corefx/commit/ec6a7215bb28a061d2357d8c3874447bc575132d

6 years agoChange HTTP default request version to HTTP/2 (dotnet/corefx#27079)
Caesar Chen [Tue, 13 Feb 2018 23:24:22 +0000 (15:24 -0800)]
Change HTTP default request version to HTTP/2 (dotnet/corefx#27079)

* change http default request version

* fix innerloop test

Commit migrated from https://github.com/dotnet/corefx/commit/f7a852f64bf20889579be70710f386a8d4802a34

6 years agoMore comments
Pavel Krymets [Tue, 13 Feb 2018 22:32:58 +0000 (14:32 -0800)]
More comments

Commit migrated from https://github.com/dotnet/corefx/commit/17b00a58129e659cf01a1cb6c045c400f8e0c984

6 years agoFix test project
Jose Perez Rodriguez [Tue, 13 Feb 2018 22:24:40 +0000 (14:24 -0800)]
Fix test project

Commit migrated from https://github.com/dotnet/corefx/commit/bb72f2e32593383ec3862d064cc8916ba5c4daa4

6 years agoEnable SocketsHttpHandler cancellation support (dotnet/corefx#27029)
Stephen Toub [Tue, 13 Feb 2018 21:30:34 +0000 (16:30 -0500)]
Enable SocketsHttpHandler cancellation support (dotnet/corefx#27029)

* Enable SocketsHttpHandler cancellation support

This change significantly improves the cancellation support in SocketsHttpHandler.  Previously we were passing the CancellationToken around to every method, eventually bottoming out in calls to the underlying Stream which then ends up passing them down to the underlying Socket.  But today Socket's support for cancellation is minimal, only doing up-front checks; if cancellation is requested during the socket operation rather than before, the request will be ignored.  Since HttpClient implements features like timeouts on top of cancellation support, it's important to do better than this.

The change implements cancellation by registering with the CancellationToken to dispose of the connection.  This will cause any reads/writes to wake up.  We then translate resulting exceptions into cancellation exceptions.  When in the main SendAsync method, we register once for the whole body of the operation until the point that we're returning the response message.  For individual operations on the response content stream, we register per operation; however, when feasible we try to avoid the registration costs by only registering if operations don't complete synchronously.  We also account for the case that on Unix, closing the connection may result in read operations waking up not with an exception but rather with EOF, which we also need to translate into cancellation when appropriate.

Along the way I cleaned up a few minor issues as well.

I also added a bunch of cancellation-related tests:
- Test cancellation occurring while sending request content
- Test cancellation occurring while receiving response headers
- Test cancellation occurring while receiving response body and using a buffered operation
- Test that all of the above are triggerable with CancellationTokenSource.Cancel, HttpClient.CancelPendingRequests, and HttpClient.Dispose
- Test cancellation occurring while receiving response body and using an unbuffered operation, either a ReadAsync or CopyToAsync on the response stream
- Test that a CancelPendingRequests doesn't affect unbuffered operations on the response stream

There are deficiencies here in the existing handlers, and tests have been selectively disabled accordingly (I also fixed a couple cases that naturally fell out of the changes I was making for SocketsHttpHandler).  SocketsHttpHandler passes now for all of them.

* Add test that Dispose doesn't cancel response stream

Commit migrated from https://github.com/dotnet/corefx/commit/53be85c2fe473fdea8c001e3d9fd81dd478b858e

6 years agoAdded tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx...
Oswald Maskens [Tue, 13 Feb 2018 21:04:14 +0000 (22:04 +0100)]
Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#1… (dotnet/corefx#26744)

* Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#14344

* added tests for ToBoolean fro Object

Commit migrated from https://github.com/dotnet/corefx/commit/c705032f0f4f6e3d34f65cf5660e3c8ea109ad47

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview2-02513-01, preview2-26213-05, preview2...
dotnet-maestro-bot [Tue, 13 Feb 2018 20:02:54 +0000 (14:02 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02513-01, preview2-26213-05, preview2-26213-06, respectively (dotnet/corefx#27093)

Commit migrated from https://github.com/dotnet/corefx/commit/b9b5b807378f7d17817749288c6b89db9694181a

6 years agoRemove 'PDBC' data signature
Tomáš Matoušek [Tue, 13 Feb 2018 19:41:05 +0000 (11:41 -0800)]
Remove 'PDBC' data signature

Commit migrated from https://github.com/dotnet/corefx/commit/a3647d844791f916dff1053665bbce4574d0b8ee

6 years agoFixing pkgproj
Jose Perez Rodriguez [Tue, 13 Feb 2018 19:24:31 +0000 (11:24 -0800)]
Fixing pkgproj

Commit migrated from https://github.com/dotnet/corefx/commit/200bae71172c2aaae4698eb7ab5f14d72d678bea

6 years agoFix Process Start tests in outerloop on Unix.
Eric Erhardt [Fri, 9 Feb 2018 05:02:42 +0000 (21:02 -0800)]
Fix Process Start tests in outerloop on Unix.

Get the real user name in the test process, not the child process.  The outerloop tests are run with 'sudo'.  Which means by the time we are in the child process SUDO_USER will be set to 'root', since the parent test process was run with 'sudo'.

Fixes dotnet/corefx#26675

Commit migrated from https://github.com/dotnet/corefx/commit/bca11a079c914ed971b2f300b876f89a920a0398

6 years agoNetCoreapp
Pavel Krymets [Tue, 13 Feb 2018 18:39:47 +0000 (10:39 -0800)]
NetCoreapp

Commit migrated from https://github.com/dotnet/corefx/commit/bb0d1299434fcaeabaecef5c602552cdcbe87359

6 years agoIDuplexPipe
Pavel Krymets [Tue, 13 Feb 2018 16:46:24 +0000 (08:46 -0800)]
IDuplexPipe

Commit migrated from https://github.com/dotnet/corefx/commit/82be16bb63124e8113ffb339b3d81c009996f957

6 years agoT
Pavel Krymets [Tue, 13 Feb 2018 16:22:58 +0000 (08:22 -0800)]
T

Commit migrated from https://github.com/dotnet/corefx/commit/792c5cdda0a93f59428e58a1d830dac0c1176e87

6 years agoFix SocketsHttpHandler connection pool accounting for dropped connections (dotnet...
Stephen Toub [Tue, 13 Feb 2018 13:38:32 +0000 (08:38 -0500)]
Fix SocketsHttpHandler connection pool accounting for dropped connections (dotnet/corefx#27068)

When MaxConnectionsPerServer is set to anything other than int.MaxValue, the SocketsHttpHandler pool keeps track of the number of connections handed out, and this count is updated when a connection is disposed.  But if a response stream isn't disposed of, resulting in the connection never being disposed of, the count may never be updated.  This fix adds an HttpConnection derived type that simply adds a finalizer, making it pay-for-play when MaxConnectionsPerServer is set to something other than the default.

Commit migrated from https://github.com/dotnet/corefx/commit/ffa5db357252913c52e0cdad63c1573020185f6e

6 years agoClear initlocals in a bunch of assemblies (dotnet/corefx#26993)
Stephen Toub [Tue, 13 Feb 2018 11:30:25 +0000 (06:30 -0500)]
Clear initlocals in a bunch of assemblies (dotnet/corefx#26993)

* Clear initlocals in a bunch of assemblies

Sets
```XML
<ILLinkClearInitLocals>true</ILLinkClearInitLocals>
```
for the assemblies:
    - System.IO.FileSystem
    - System.IO.Pipes
    - System.Memory
    - System.Net.Http
    - System.Net.Http.WinHttpHandler
    - System.Net.NameResolution
    - System.Net.NetworkInformation
    - System.Net.Primitives
    - System.Net.Requests
    - System.Net.Security
    - System.Net.Sockets
    - System.Net.WebSockets
    - System.Net.WebSockets.Client
    - System.Net.WebSockets.WebSocketsProtocol
    - System.Private.Uri
    - System.Runtime
    - System.Runtime.Extensions

Eventually we'd ideally set the flag for the whole repo; these are just the ones I audited thus far.  In a few cases I had to make code changes to adapt, where the code was expecting stackallocs to be cleared.  I also looked at a few other projects (System.Collections, System.Runtime.Numerics) where there were more significant dependencies on clearing and I decided to leave those for later.

* Disable ILLinkClearInitLocals running on Unix until it works there

Commit migrated from https://github.com/dotnet/corefx/commit/f0a032e4a1c8a848574a5db3e69e8a6fa0aae91e

6 years agoRevert Managed SNI usage flag (dotnet/corefx#27089)
Saurabh Singh [Tue, 13 Feb 2018 09:47:02 +0000 (01:47 -0800)]
Revert Managed SNI usage flag (dotnet/corefx#27089)

Commit migrated from https://github.com/dotnet/corefx/commit/23709d07c3cb8e5c4be36ffe7f480151becc54b3

6 years agoWorkstation Id should be returned correctly (dotnet/corefx#27076)
Saurabh Singh [Tue, 13 Feb 2018 07:54:59 +0000 (23:54 -0800)]
Workstation Id should be returned correctly (dotnet/corefx#27076)

* Fix workstation Id

* Tests for workstation id

* Add more test cases

Commit migrated from https://github.com/dotnet/corefx/commit/7425455ace4c7819b786c2f0b42fb630944aeef3

6 years agoMerge pull request dotnet/corefx#27069 from stephentoub/cachessl
Geoff Kizer [Tue, 13 Feb 2018 07:11:11 +0000 (23:11 -0800)]
Merge pull request dotnet/corefx#27069 from stephentoub/cachessl

Cache SslClientAuthenticationOptions on SocketsHttpHandler pool

Commit migrated from https://github.com/dotnet/corefx/commit/a438733f09a739bfbd4b9f945ba049386858019a

6 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-26213-00, beta-26213-00, respectively...
dotnet-maestro-bot [Tue, 13 Feb 2018 05:58:07 +0000 (23:58 -0600)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26213-00, beta-26213-00, respectively (dotnet/corefx#27083)

Commit migrated from https://github.com/dotnet/corefx/commit/73d8163328b17fee3d32ff295b03fab13fdb721e

6 years agoUpdate CoreClr, CoreFx to preview2-26212-08, preview2-26213-01, respectively (dotnet...
dotnet-maestro-bot [Tue, 13 Feb 2018 03:59:14 +0000 (21:59 -0600)]
Update CoreClr, CoreFx to preview2-26212-08, preview2-26213-01, respectively (dotnet/corefx#27080)

Commit migrated from https://github.com/dotnet/corefx/commit/bf5f02752633d92afcb249fe166a81ae84d59c77

6 years agoLower the default stack buffer size for calling getpwXXX_r methods.
Eric Erhardt [Tue, 13 Feb 2018 01:39:17 +0000 (19:39 -0600)]
Lower the default stack buffer size for calling getpwXXX_r methods.

By default, 1K is too large of a buffer to allocate on the stack.

Fixes dotnet/corefx#26959

Commit migrated from https://github.com/dotnet/corefx/commit/5cbac95f5530695a31a43e7748a4561e3a2dd32d

6 years agoMore PR comments
Pavel Krymets [Mon, 12 Feb 2018 23:48:28 +0000 (15:48 -0800)]
More PR comments

Commit migrated from https://github.com/dotnet/corefx/commit/1f7f6a2bb900b132689be5926c3fb132d7fe702d

6 years agoPR Comments, temporary undo src crosscompile
Pavel Krymets [Mon, 12 Feb 2018 23:34:33 +0000 (15:34 -0800)]
PR Comments, temporary undo src crosscompile

Commit migrated from https://github.com/dotnet/corefx/commit/0cfbb25249dc640059d10120ae044455764cc71a

6 years agoSwitch from using SafeHandle for Unix enumeration (dotnet/corefx#27052)
Jeremy Kuhne [Mon, 12 Feb 2018 21:56:17 +0000 (13:56 -0800)]
Switch from using SafeHandle for Unix enumeration (dotnet/corefx#27052)

* Switch from using SafeHandle for Unix enumeration

* Address feedback

* Fix faceplant, dispose in test.

Commit migrated from https://github.com/dotnet/corefx/commit/c9100ffc2988a0faf0e92898762a445ccb3c0e13

6 years agoProject changeS
Pavel Krymets [Mon, 12 Feb 2018 20:49:14 +0000 (12:49 -0800)]
Project changeS

Commit migrated from https://github.com/dotnet/corefx/commit/2d44625e288fd28ba644c813a9e0d23ecfc95ddb

6 years agoPipelines RP comments
Pavel Krymets [Mon, 12 Feb 2018 20:35:48 +0000 (12:35 -0800)]
Pipelines RP comments

Commit migrated from https://github.com/dotnet/corefx/commit/50713cf859900e8116986e80b6d1a1da736645fc

6 years agoDisable drawing test for distro Ubuntu18.04 (dotnet/corefx#27036)
Maryam Ariyan [Mon, 12 Feb 2018 19:35:36 +0000 (14:35 -0500)]
Disable drawing test for distro Ubuntu18.04 (dotnet/corefx#27036)

* Disable drawing test for distro Ubuntu18.04

* Adding a new properties called IsUbuntu1804 and IsUbuntu1710OrHigher in PlatformDetection

Related to dotnet/corefx#27021

Commit migrated from https://github.com/dotnet/corefx/commit/4b4440b4c0fc280d3a9c09d117a1a6eafbbcb6c2

6 years agoClear Authorization Headers on Redirect (dotnet/corefx#26864)
Max Kerr [Mon, 12 Feb 2018 19:28:09 +0000 (11:28 -0800)]
Clear Authorization Headers on Redirect (dotnet/corefx#26864)

When a user has added an Authorization header to a request via the HttpClient DefaultRequestHeaders Authorization field, ensure that header is stripped on redirect.

This change adds a method to strip Authorization headers that were set via the HttpClient DefaultRequestHeaders Authorization field, and calls that method on redirect. In addition, it adds a test to ensure that this behavior occurs as expected.

The new method ResetAuthRequestHeaders is based on the method ResetCookieRequestHeaders, which is used to reset cookie headers on redirect.

The issue also occurs in CurlHandler, but the fix is slightly different. Rather than remove the headers that have already been set, we can instead just skip them when copying over the new headers to the redirected request.

Fixes dotnet/corefx#26426

Commit migrated from https://github.com/dotnet/corefx/commit/7e6396b2bcb4d372b199cfb7b3b13e290c441124

6 years agoFix the throwing exception from ChannelReader.ReadAsync (dotnet/corefx#27070)
Tarek Mahmoud Sayed [Mon, 12 Feb 2018 19:20:55 +0000 (11:20 -0800)]
Fix the throwing exception from ChannelReader.ReadAsync (dotnet/corefx#27070)

Commit migrated from https://github.com/dotnet/corefx/commit/20d9824ac3f877b2a72dd6a729134e0c5fd960ee

6 years agoFix HttpClientMiniStress.UnreadResponseMessage_Collectible test (dotnet/corefx#27061)
Stephen Toub [Mon, 12 Feb 2018 18:39:02 +0000 (13:39 -0500)]
Fix HttpClientMiniStress.UnreadResponseMessage_Collectible test (dotnet/corefx#27061)

The async state machine was holding a reference to the response content object, which in turn prevented the response stream from being collected.

Commit migrated from https://github.com/dotnet/corefx/commit/6c9b62981190ae5886196f37d0f5dc614f4b0244

6 years agoUpdate rename of ManagedHandler to SocketsHttpHandler
Karel Zikmund [Mon, 12 Feb 2018 17:51:53 +0000 (09:51 -0800)]
Update rename of ManagedHandler to SocketsHttpHandler

Commit migrated from https://github.com/dotnet/corefx/commit/a07b356e61a0a1d8e2d6d02bcc1e2062fbbd64ae

6 years agoCache SslClientAuthenticationOptions on SocketsHttpHandler pool
Stephen Toub [Mon, 12 Feb 2018 17:17:33 +0000 (12:17 -0500)]
Cache SslClientAuthenticationOptions on SocketsHttpHandler pool

For the common case, we can just use a singleton cached instance with settings computed when the pool is created.  Only if it's accessed via HttpClientHandler with a server certificate callback do we need to still create an instance per request, in order to wrap the delegate to provide the expected semantics.

Commit migrated from https://github.com/dotnet/corefx/commit/911d4aff095f1c8648334d4a221c217cd09e466b

6 years agoUpdate CoreClr, CoreFx to preview2-26212-05, preview2-26212-05, respectively (dotnet...
dotnet-maestro-bot [Mon, 12 Feb 2018 17:13:52 +0000 (11:13 -0600)]
Update CoreClr, CoreFx to preview2-26212-05, preview2-26212-05, respectively (dotnet/corefx#27060)

Commit migrated from https://github.com/dotnet/corefx/commit/38ff6d112eee1b93d402521f924d9952bef98ef9

6 years agoAllow RangeAttribute use to request InvariantCulture conversions. (dotnet/corefx...
Jon Hanna [Mon, 12 Feb 2018 16:30:14 +0000 (16:30 +0000)]
Allow RangeAttribute use to request InvariantCulture conversions. (dotnet/corefx#25918)

* Allow RangeAttribute use to request InvariantCulture conversions.

Adds a ParseLimitsInInvariantCulture that affects the interpretation of
the extrema set, and ConvertValueInInvariantCulture that affects the
interpretation of values.

Separate methods allows for e.g. a component assuming a
dot-decimal-separator culture defining a property with the attribute
(so invariant culture should be used) the use of the property is done
in a comma-decimal-separator (so the current culture should be used),
or any permutation of the two booleans.

Fixes dotnet/corefx#2648

* Skip NetFX on associated tests.

* Update tests in dotnet/corefx#25918 to work with changes from dotnet/corefx#26050

Commit migrated from https://github.com/dotnet/corefx/commit/015cf5d9832ed9d6734367c8a2e29dfa8bae4a25

6 years agofix stress response generation, and disable failing test (dotnet/corefx#27059)
Geoff Kizer [Mon, 12 Feb 2018 12:25:24 +0000 (04:25 -0800)]
fix stress response generation, and disable failing test (dotnet/corefx#27059)

Commit migrated from https://github.com/dotnet/corefx/commit/472c3d95749910ba600df296bbf01d78d7c4f6d8

6 years agoUpdate CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-26212-01, preview...
dotnet-maestro-bot [Mon, 12 Feb 2018 10:28:43 +0000 (04:28 -0600)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-26212-01, preview2-26212-01, beta-26212-00, beta-26212-00, respectively (dotnet/corefx#27053)

Commit migrated from https://github.com/dotnet/corefx/commit/241ea5372d4770a7f596adf272833aa6dd63a289

6 years agoTweak CurlHandler SSL not supported messages to be more helpful (dotnet/corefx#27043)
Stephen Toub [Mon, 12 Feb 2018 10:27:57 +0000 (05:27 -0500)]
Tweak CurlHandler SSL not supported messages to be more helpful (dotnet/corefx#27043)

* Tweak CurlHandler SSL not supported messages to be more helpful

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/9cde3e174b2495cbcdf95995aea0bea4030d4aa9

6 years agoEnsure services get removed (dotnet/corefx#27054)
Dan Moseley [Mon, 12 Feb 2018 03:33:12 +0000 (19:33 -0800)]
Ensure services get removed (dotnet/corefx#27054)

Commit migrated from https://github.com/dotnet/corefx/commit/744c4cf021c1744082e12caf3e9b8dacf05a671a

6 years agoMerge pull request dotnet/corefx#26989 from geoffkizer/fixcookiehandling
Geoff Kizer [Mon, 12 Feb 2018 02:23:50 +0000 (18:23 -0800)]
Merge pull request dotnet/corefx#26989 from geoffkizer/fixcookiehandling

SocketsHttpHandler: Fix some issues with cookie handling, and add cookie tests

Commit migrated from https://github.com/dotnet/corefx/commit/8cee267154ef9dc6dde7a76a828844a200437872

6 years agoacutal -> actual (dotnet/corefx#27050)
John Doe [Mon, 12 Feb 2018 00:18:31 +0000 (16:18 -0800)]
acutal -> actual (dotnet/corefx#27050)

Commit migrated from https://github.com/dotnet/corefx/commit/36a15af564c8359881da9f98a7011a89253c0847

6 years agoModified Dns.GetHostAddressesAsync to be truly async (dotnet/corefx#26850)
Jeff Cyr [Mon, 12 Feb 2018 00:18:08 +0000 (19:18 -0500)]
Modified Dns.GetHostAddressesAsync to be truly async (dotnet/corefx#26850)

* Modified Dns.GetHostAddressesAsync to be truly async

* Applied code review recommendations

* Unix build fix

* Unix build fix dotnet/corefx#2

* Unix build fix dotnet/corefx#3

* NETFX build fix

* Fixed useGetHostByName logic

* Simplified ProcessResult code

* Cleaned up cancel code

* cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/d3ff31e3b9e8c7b1e6003196650bae4a658ef889

6 years agofix tests on netfx
Geoff Kizer [Sun, 11 Feb 2018 22:49:42 +0000 (14:49 -0800)]
fix tests on netfx

Commit migrated from https://github.com/dotnet/corefx/commit/c7cc2a879d0a5b5f039caff36bef0c99f52604a2

6 years agoconsolidate cookie tests
Geoff Kizer [Sun, 11 Feb 2018 20:38:20 +0000 (12:38 -0800)]
consolidate cookie tests

Commit migrated from https://github.com/dotnet/corefx/commit/c20262c69a93449498d511014e9e69bad18f987a

6 years agoUpdate CoreClr, CoreFx to preview2-26211-03, preview2-26211-04, respectively (dotnet...
dotnet-maestro-bot [Sun, 11 Feb 2018 17:41:34 +0000 (11:41 -0600)]
Update CoreClr, CoreFx to preview2-26211-03, preview2-26211-04, respectively (dotnet/corefx#27041)

Commit migrated from https://github.com/dotnet/corefx/commit/14185df4430c7f9432ea4654676c7663c5f8957e

6 years agoAdd SocketsHttpHandler check for TransferEncodingChunked w/o Content (dotnet/corefx...
Stephen Toub [Sun, 11 Feb 2018 17:19:03 +0000 (12:19 -0500)]
Add SocketsHttpHandler check for TransferEncodingChunked w/o Content (dotnet/corefx#27040)

Commit migrated from https://github.com/dotnet/corefx/commit/bf5a3183bc901723ebe0bb3d178bec86cda57429

6 years agoFix more new T[0] to be Array.Empty<T>() (dotnet/corefx#27042)
Stephen Toub [Sun, 11 Feb 2018 17:18:33 +0000 (12:18 -0500)]
Fix more new T[0] to be Array.Empty<T>() (dotnet/corefx#27042)

We've done several passes through the repo in the past.  More cases have snuck in since then.

Commit migrated from https://github.com/dotnet/corefx/commit/a127f01141ff4ffe2224da9ff63a1b5233ee5f06

6 years agoFix some license headers across the repo (dotnet/corefx#27039)
Stephen Toub [Sun, 11 Feb 2018 13:55:26 +0000 (08:55 -0500)]
Fix some license headers across the repo (dotnet/corefx#27039)

Commit migrated from https://github.com/dotnet/corefx/commit/7f19e761b7400521030707df2e6fac10daa36f26

6 years agoMark {Configured}ValueTaskAwaiter as readonly in contracts (dotnet/corefx#27030)
Stephen Toub [Sun, 11 Feb 2018 10:15:15 +0000 (05:15 -0500)]
Mark {Configured}ValueTaskAwaiter as readonly in contracts (dotnet/corefx#27030)

Commit migrated from https://github.com/dotnet/corefx/commit/4ff3c791c0eac88d96f135b16fc5425d48e02211

6 years agoAdd tests for T[] -> ArraySegment<T> cast (dotnet/corefx#27032)
Stephen Toub [Sun, 11 Feb 2018 10:10:13 +0000 (05:10 -0500)]
Add tests for T[] -> ArraySegment<T> cast (dotnet/corefx#27032)

Commit migrated from https://github.com/dotnet/corefx/commit/d690bb63b15556190fad7e6bb85eb7a4dce69c79

6 years agoUpdate BuildTools to preview2-02511-02 (dotnet/corefx#27034)
dotnet-maestro-bot [Sun, 11 Feb 2018 08:50:47 +0000 (02:50 -0600)]
Update BuildTools to preview2-02511-02 (dotnet/corefx#27034)

Commit migrated from https://github.com/dotnet/corefx/commit/f54ee41039db4b84fb5dc58bec4e1dd393fc2d0b

6 years agoFixing test CurrencyNegativePattern_Get() on newly added distro Ubuntu18.04 (dotnet...
Maryam Ariyan [Sun, 11 Feb 2018 06:46:58 +0000 (01:46 -0500)]
Fixing test CurrencyNegativePattern_Get() on newly added distro Ubuntu18.04 (dotnet/corefx#27035)

From class/project System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern

Fixes dotnet/corefx#27022

Commit migrated from https://github.com/dotnet/corefx/commit/8fdf896ebb78fcab5612de7a0ea84518d416d7c7

6 years agoFix TestService shutdown (dotnet/corefx#27028)
Dan Moseley [Sun, 11 Feb 2018 03:13:07 +0000 (19:13 -0800)]
Fix TestService shutdown (dotnet/corefx#27028)

Commit migrated from https://github.com/dotnet/corefx/commit/2af251c3c083817975d76d659069400d98073965

6 years agoUpdate CoreClr to preview2-26210-06 (dotnet/corefx#27026)
dotnet-maestro-bot [Sun, 11 Feb 2018 02:43:50 +0000 (20:43 -0600)]
Update CoreClr to preview2-26210-06 (dotnet/corefx#27026)

Commit migrated from https://github.com/dotnet/corefx/commit/530385c33afaf373ae28f5ab49cf5c0d902dda3e

6 years agoclasname -> classname (dotnet/corefx#27025)
John Doe [Sun, 11 Feb 2018 01:57:33 +0000 (17:57 -0800)]
clasname -> classname (dotnet/corefx#27025)

Commit migrated from https://github.com/dotnet/corefx/commit/08bcfb4b95ec4be00ce70eb985682aca8aec8fe9

6 years agoFix *Info classes for Unix when opened on root (dotnet/corefx#27024)
Jeremy Kuhne [Sun, 11 Feb 2018 01:19:49 +0000 (17:19 -0800)]
Fix *Info classes for Unix when opened on root (dotnet/corefx#27024)

Commit migrated from https://github.com/dotnet/corefx/commit/5349873018e481a2ad8a14bbdd5ff237780f02e3

6 years agoUpdate CoreClr to preview2-26210-04 (dotnet/corefx#27020)
dotnet-maestro-bot [Sat, 10 Feb 2018 15:27:34 +0000 (09:27 -0600)]
Update CoreClr to preview2-26210-04 (dotnet/corefx#27020)

Commit migrated from https://github.com/dotnet/corefx/commit/221950b31c1057b040670936519ddbc13f893062

6 years agoAdd FileStream tests for custom OwnedMemory with Read/WriteAsync (dotnet/corefx#26931)
Stephen Toub [Sat, 10 Feb 2018 12:11:12 +0000 (07:11 -0500)]
Add FileStream tests for custom OwnedMemory with Read/WriteAsync (dotnet/corefx#26931)

Commit migrated from https://github.com/dotnet/corefx/commit/7130581c8bd7114143628679624f7ae29cb56818

6 years agoAdd Hebrew Months test (dotnet/corefx#26915)
Tarek Mahmoud Sayed [Sat, 10 Feb 2018 12:11:03 +0000 (04:11 -0800)]
Add Hebrew Months test (dotnet/corefx#26915)

* Add Hebrew Months test

* add some spaces

Commit migrated from https://github.com/dotnet/corefx/commit/57ba13cbfa203c8bc5003dd9b3ab4aaa796c22f8

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Sat, 10 Feb 2018 04:58:58 +0000 (22:58 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02509-01, preview2-26209-08, preview2-26210-01, preview2-26209-04, beta-26209-02, beta-26209-02, respectively (dotnet/corefx#26940)

Commit migrated from https://github.com/dotnet/corefx/commit/1fc770a6cbc26dc072a44ee9ae6e6d9af5e61e1c

6 years agoFix Unix enumeration (dotnet/corefx#27019)
Jeremy Kuhne [Sat, 10 Feb 2018 04:33:26 +0000 (20:33 -0800)]
Fix Unix enumeration (dotnet/corefx#27019)

For non-trivial recursive enumerations we were running out of file descriptors. Stop creating them when we queue pending subdirectories and only create when we dequeue.

Commit migrated from https://github.com/dotnet/corefx/commit/430de8f582afb111697dd1e203f5c7a20f46acb2

6 years agoRestrict the Long Running option to MARS (dotnet/corefx#27010)
Saurabh Singh [Sat, 10 Feb 2018 01:57:04 +0000 (17:57 -0800)]
Restrict the Long Running option to MARS (dotnet/corefx#27010)

* Restrict the Long Running option to MARS

* Code review comments

Commit migrated from https://github.com/dotnet/corefx/commit/8cc3ffbea1da042f4f0ca61ad81e234630434f21

6 years agoTrying to collect info about ping test failures in macOS 10.12 (dotnet/corefx#26997)
Paulo Janotti [Fri, 9 Feb 2018 23:48:29 +0000 (15:48 -0800)]
Trying to collect info about ping test failures in macOS 10.12 (dotnet/corefx#26997)

See dotnet/corefx#26358

Commit migrated from https://github.com/dotnet/corefx/commit/7406c4c12ab76df15e0fde191856860eb87166d5

6 years agoUpdate intellisense file drop based on 2-2-2018 doc build (dotnet/corefx#27005)
Wes Haggard [Fri, 9 Feb 2018 23:24:18 +0000 (15:24 -0800)]
Update intellisense file drop based on 2-2-2018 doc build (dotnet/corefx#27005)

Commit migrated from https://github.com/dotnet/corefx/commit/54c80d877e2f90c4973b44db5033f2cb7abf5ce2

6 years agoaddress review feedback
Geoff Kizer [Fri, 9 Feb 2018 19:34:51 +0000 (11:34 -0800)]
address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/15beaca5f2062792bf4a2dd137a42d6e53f98e5e

6 years agominimal support for ManagedHandler proxy configuration on Windows (dotnet/corefx...
Tomas Weinfurt [Fri, 9 Feb 2018 20:05:30 +0000 (12:05 -0800)]
minimal support for ManagedHandler proxy configuration on Windows  (dotnet/corefx#26878)

* initial implementation

Commit migrated from https://github.com/dotnet/corefx/commit/468db63e2648f8a4c0c82d97e301e308b7887f7e

6 years agoCover
Pavel Krymets [Fri, 9 Feb 2018 19:00:30 +0000 (11:00 -0800)]
Cover

Commit migrated from https://github.com/dotnet/corefx/commit/4acf7f927ec0c132b301c79d79a6f3e5ba7d69fa

6 years agoMerge pull request dotnet/corefx#26981 from MattGal/Ubuntu18
Matt Galbraith [Fri, 9 Feb 2018 18:54:36 +0000 (10:54 -0800)]
Merge pull request dotnet/corefx#26981 from MattGal/Ubuntu18

Add Ubuntu 18 to supported Linux list

Commit migrated from https://github.com/dotnet/corefx/commit/be4cdaecf9374f1addf15eb10b3bbd1dc7550ed2

6 years agoIncreasing OSX build timeout while we investigate the Performance hit (dotnet/corefx...
Jose Perez Rodriguez [Fri, 9 Feb 2018 18:03:17 +0000 (10:03 -0800)]
Increasing OSX build timeout while we investigate the Performance hit (dotnet/corefx#27002)

Commit migrated from https://github.com/dotnet/corefx/commit/a72988c3793cc19b27e11d4599173cd0a5291b13

6 years agoResources
Pavel Krymets [Fri, 9 Feb 2018 17:48:45 +0000 (09:48 -0800)]
Resources

Commit migrated from https://github.com/dotnet/corefx/commit/c3a898a75c6fd0806631e072b4d89825dbf4ddb9

6 years agoconditionsed -> conditioned (dotnet/corefx#26998)
John Doe [Fri, 9 Feb 2018 15:58:43 +0000 (07:58 -0800)]
conditionsed -> conditioned (dotnet/corefx#26998)

Commit migrated from https://github.com/dotnet/corefx/commit/30f0b6323f7f4661c924b6229dbfc1fecc11cc0e

6 years agoFixing a regression introduced by the previous test fix. (dotnet/corefx#26970)
Konst Khurin [Fri, 9 Feb 2018 12:59:40 +0000 (04:59 -0800)]
Fixing a regression introduced by the previous test fix. (dotnet/corefx#26970)

Commit migrated from https://github.com/dotnet/corefx/commit/59f5f604794e562fdc000d5dbedb53f68b7ceac7

6 years agorework cookie logic to address issues and remove CookieHandler
Geoff Kizer [Fri, 9 Feb 2018 04:22:46 +0000 (20:22 -0800)]
rework cookie logic to address issues and remove CookieHandler

Commit migrated from https://github.com/dotnet/corefx/commit/7d11d419421cc9bea0b8fa3d186bb6a406cd3a4b

6 years agoadd protocol tests for cookie handling
Geoff Kizer [Thu, 8 Feb 2018 02:57:01 +0000 (18:57 -0800)]
add protocol tests for cookie handling

Commit migrated from https://github.com/dotnet/corefx/commit/750b29bbb1433ad5d4c3727217192dddbef90eef

6 years agoMake Unix filename conversion lazy (dotnet/corefx#26978)
Jeremy Kuhne [Fri, 9 Feb 2018 06:50:38 +0000 (22:50 -0800)]
Make Unix filename conversion lazy (dotnet/corefx#26978)

* Make Unix filename conversion lazy

Also hook error handling.

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ef0aca54454748002325b750c839dacba6ed3999

6 years agoDisable Http status line test cases on CurlHandler (dotnet/corefx#26982)
Caesar Chen [Fri, 9 Feb 2018 04:54:34 +0000 (20:54 -0800)]
Disable Http status line test cases on CurlHandler (dotnet/corefx#26982)

Commit migrated from https://github.com/dotnet/corefx/commit/6730463bd0bb1a65e679b8a6643d611b69086b29

6 years agoRefactor and tests for MS.CSharp's GetBestAccessibleType() (dotnet/corefx#26391)
Jon Hanna [Fri, 9 Feb 2018 04:26:23 +0000 (04:26 +0000)]
Refactor and tests for MS.CSharp's GetBestAccessibleType() (dotnet/corefx#26391)

* Rearrange GetBestAccessibleType to avoid repeated tests & recursion.

Keep all code for AggregateType in the first branch for AggregateType,
etc.

# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs

* Use ContextForMemberLookup instead of BindingContext for best accessible

The BindingContext is only used for this property, which it hits
repeatedly, so just pass it in instead.

# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs

* Don't use intermediate variables for out parameters.

If just going to assign it to something anyway.

# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs

* Return type directly from GetBestAccessibleType()

The type passed in can never be ParameterModifierType or PointerType so
the case where false is returned can never be hit. Change to returning
the accessible type directly, and remove branches for false returns.

# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs

* Add tests for getting best accessible type.

Commit migrated from https://github.com/dotnet/corefx/commit/ee64cb0126834cf8563d22db6fc73cdffc9ac4cd

6 years agoRemove some dead branches from Microsoft.CSharp (dotnet/corefx#26370)
Jon Hanna [Fri, 9 Feb 2018 04:21:17 +0000 (04:21 +0000)]
Remove some dead branches from Microsoft.CSharp (dotnet/corefx#26370)

* Don't report constrained in AdjustMemberObject.

Never gets set, and constrained isn't meaningful when not producing IL
directly.

* Remove FieldSymbol.isAssigned

Set but never used. CS1612 is meaningless in dynamic code.

* Remove objectIsLvalue(pOptionalObject) from check field is lvalue.

This test will always pass, so the second part is all that is required.

* Move lvalue-detection into ExprField ctor

* Remove objectIsLvalue(pOptionalObject) from check property is lvalue.

This test will always pass, so the second part is all that is required.

* Move lvalue-detection into ExprProperty ctor

* Make objectIsLvalue a debug-only assertion.

Now only used in assertions, so make it an assertion method.

* Remove dead branches from TryReportLvalueFailure

Since we can now see that we can't enter the branch for properties, nor
escape the branch for fields, we can see that pObject will never be set
and isNested never true. Remove branches for those conditions.

Includes removal of ERR_ReturnNotLValue, contributes to dotnet/corefx#22470

* Remove path for isNested from ReportReadOnlyError

Never true.

Includes removal of ERR_AssgReadonlyStatic2 and ERR_AssgReadonly2,
contributes to dotnet/corefx#22470

* Inline ReportReadOnlyError and TryReportLvalueFailure

These are now very small, and CheckLvalue's logic is clearer with all
errors happening within the same switch

* Use FundamentalType to judge whether value is unsigned.

We've already obtained and branched on this value, and they suffice to
know whether the type is unsigned or not, so just infer from that.

Commit migrated from https://github.com/dotnet/corefx/commit/47a92df7f73d8570176c18a499dbdda4d9323101

6 years agoMerge pull request dotnet/corefx#26964 from stephentoub/exposemanagedhandler
Stephen Toub [Fri, 9 Feb 2018 04:04:18 +0000 (23:04 -0500)]
Merge pull request dotnet/corefx#26964 from stephentoub/exposemanagedhandler

Expose SocketsHttpHandler

Commit migrated from https://github.com/dotnet/corefx/commit/eb892471f8691dad65ff47f5b12ddc8d378ae460

6 years agoAdd Ubuntu 18 to supported Linuxes
Matt Galbraith [Fri, 9 Feb 2018 03:08:12 +0000 (19:08 -0800)]
Add Ubuntu 18 to supported Linuxes

Commit migrated from https://github.com/dotnet/corefx/commit/5875a4ddad59a1bd40555af0375d3d6345a7e754

6 years agoRestore Channels ReadAsync implementation (dotnet/corefx#26934)
Tarek Mahmoud Sayed [Fri, 9 Feb 2018 01:30:56 +0000 (17:30 -0800)]
Restore Channels ReadAsync implementation (dotnet/corefx#26934)

* Restore Channels ReadAsync implementation

* Remove AutoResetAwaiter

* Add Base class  ReadAsync test

* address the feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ce0de73e21635252ceffdb140d3a56c6c19bb565

6 years agoFix ProcessStartInfo tests on CentOS in Debug (dotnet/corefx#26945)
Eric Erhardt [Fri, 9 Feb 2018 01:27:21 +0000 (17:27 -0800)]
Fix ProcessStartInfo tests on CentOS in Debug (dotnet/corefx#26945)

There is a bug in CentOS7.1 getpwnam_r where it returns the wrong value if you pass in a buffer that is too small to hold the data.  In Debug builds, we are purposefully passing in a buffer that is too small to test the fallback code, which is running into this OS bug.

See https://bugs.centos.org/view.php?id=7324

Fixes dotnet/corefx#26673

Commit migrated from https://github.com/dotnet/corefx/commit/03414aae30a0a90c5a54a85d79189e95f7f81ab4

6 years agoReturn canceled task from WaitToReadAsync even if data available (dotnet/corefx#26974)
Stephen Toub [Fri, 9 Feb 2018 00:14:22 +0000 (19:14 -0500)]
Return canceled task from WaitToReadAsync even if data available (dotnet/corefx#26974)

Commit migrated from https://github.com/dotnet/corefx/commit/5cec1f3491e8eac76255e48274cadccd040caf81

6 years agoFix WebSocketProtocol test that never worked on netfx
Stephen Toub [Thu, 8 Feb 2018 22:42:19 +0000 (17:42 -0500)]
Fix WebSocketProtocol test that never worked on netfx

Commit migrated from https://github.com/dotnet/corefx/commit/f6f5188044b126f3f6058ce361b060fc0b83257e

6 years agoAdd more SocketsHttpHandler tests
Stephen Toub [Thu, 8 Feb 2018 18:44:32 +0000 (13:44 -0500)]
Add more SocketsHttpHandler tests

Commit migrated from https://github.com/dotnet/corefx/commit/8cb4d130bc3e8151fc72fe9494787643c7b00c4b

6 years agoExpose SocketsHttpHandler
Stephen Toub [Thu, 8 Feb 2018 16:33:13 +0000 (11:33 -0500)]
Expose SocketsHttpHandler

- Renames ManagedHandler to SocketsHttpHandler
- Moves a bunch of files around accordingly
- Updates System.Net.WebSockets.Client to use SocketsHttpHandler directly
- Updates System.Net.Http's tests with a reflection-based rather than TLS-based method for instantiating an HttpClientHandler backed by a SocketsHttpHandler.

Commit migrated from https://github.com/dotnet/corefx/commit/852d40e723c849e8d0c486676d40332343e12ca5

6 years agoPDB Checksum Debug Directory Record Specification (dotnet/corefx#26912)
Tomáš Matoušek [Thu, 8 Feb 2018 23:59:47 +0000 (15:59 -0800)]
PDB Checksum Debug Directory Record Specification (dotnet/corefx#26912)

* PDB Checksum Debug Directory Record Specification

* Hash zeroed PDB ID

* Update PE-COFF.md

* Update PE-COFF.md

Commit migrated from https://github.com/dotnet/corefx/commit/d374be89418236e29ed3f88a3f622a3719242089