Mantas Mikulėnas [Wed, 8 Jan 2014 12:08:33 +0000 (14:08 +0200)]
bus: use existing macros from def.h
Kay Sievers [Wed, 8 Jan 2014 13:32:37 +0000 (21:32 +0800)]
bus-driverd: do not track identical matches
Identical matches are only one time in the hash map but multiple
times in the list; when removing, the hash will be empty but the
list still has entries.
Not adding dupicates to the list should keep us in sync and prevent
hitting the assert.
Kay Sievers [Wed, 8 Jan 2014 10:20:02 +0000 (18:20 +0800)]
bus-driverd: properly reply to UpdateActivationEnvironment call
Kay Sievers [Wed, 8 Jan 2014 10:10:39 +0000 (18:10 +0800)]
dbus1-generator: install user version
Kay Sievers [Mon, 6 Jan 2014 04:00:16 +0000 (08:00 +0400)]
pam_systemd: export DBUS_SESSION_BUS_ADDRESS
Lennart Poettering [Wed, 8 Jan 2014 10:09:25 +0000 (18:09 +0800)]
bus: allow omitting quotes for values in match strings
dbus-daemon allows this, the dbus specification doesn't explicitly say
anything about it, so let's follow dbus-daemon on this.
Lennart Poettering [Wed, 8 Jan 2014 10:09:05 +0000 (18:09 +0800)]
update TODO
Kay Sievers [Wed, 8 Jan 2014 09:09:31 +0000 (17:09 +0800)]
bus-driverd: implement UpdateActivationEnvironment method
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jan 2014 04:05:17 +0000 (23:05 -0500)]
man: document label escaping functions
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jan 2014 03:27:43 +0000 (22:27 -0500)]
man: fix bogus description of sd_bus_creds_has_*_cap
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jan 2014 03:18:46 +0000 (22:18 -0500)]
dbus1-generator: fix copy-pasto
Michele Curti [Tue, 7 Jan 2014 16:51:41 +0000 (17:51 +0100)]
sleep.c: fix typo
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jan 2014 02:46:36 +0000 (21:46 -0500)]
man: document sd-bus error functions
Kay Sievers [Tue, 7 Jan 2014 12:20:22 +0000 (20:20 +0800)]
bus-driverd: support user mode
Kay Sievers [Mon, 6 Jan 2014 23:30:34 +0000 (07:30 +0800)]
bus-proxyd: support --user bus address
Martin Pitt [Tue, 7 Jan 2014 08:40:01 +0000 (09:40 +0100)]
keymap: Recognize different Toshiba Satellite capitalizations
https://launchpad.net/bugs/665918
AppleBloom [Tue, 7 Jan 2014 01:51:47 +0000 (20:51 -0500)]
hwdb: fix match for Thinkpad X201 tablet
https://bugs.freedesktop.org/show_bug.cgi?id=71929
Dmitry Pisklov [Tue, 7 Jan 2014 01:08:21 +0000 (20:08 -0500)]
hwdb: remove duplicate entry for Samsung 700Z
keyboardbrightnessup/down are not even real keys.
https://bugs.freedesktop.org/show_bug.cgi?id=72311
Dmitry Pisklov [Tue, 7 Jan 2014 01:06:59 +0000 (20:06 -0500)]
hwdb: add Samsung 700G
https://bugs.freedesktop.org/show_bug.cgi?id=72311
Raudi [Tue, 7 Jan 2014 00:44:08 +0000 (19:44 -0500)]
hwdb: change key mappings for Samsung 90X3A
The Key codes didn't match with the described key. Also the key
identifier strings were missing. I hope I chose appropriate ones.
https://bugs.freedesktop.org/show_bug.cgi?id=70296
Lennart Poettering [Mon, 6 Jan 2014 23:25:05 +0000 (07:25 +0800)]
mount: don't creat local-fs.target links for mount units when runnin in user mode
Kay Sievers [Mon, 6 Jan 2014 23:09:08 +0000 (07:09 +0800)]
dbus1-generator: always pull proxy socket into sockets.target
dbus.socket does that for --system, we need to explicitly pull it
in for --user.
Kay Sievers [Mon, 6 Jan 2014 22:37:23 +0000 (06:37 +0800)]
core: do not add implicit dbus.socket dependency
Sockets are ordered before sockets.target anyway, and sockets.target
is ordered before basic.target, and hence all bus services end up
being ordered after dbus.socket anyway. Since for kdbus clients
dbus.socket is obsolete, let's not add this dependency explicitly.
Also, it's hot in Australia and we are going for breakfast now.
Kay Sievers [Mon, 6 Jan 2014 22:36:39 +0000 (06:36 +0800)]
bus-proxyd: --user -- add Accept=yes to socket
Lennart Poettering [Mon, 6 Jan 2014 22:34:39 +0000 (06:34 +0800)]
update TODO
Kay Sievers [Mon, 6 Jan 2014 03:52:17 +0000 (07:52 +0400)]
core: --user -- add basic.target an sort against it like --system does
Kay Sievers [Mon, 6 Jan 2014 03:50:26 +0000 (07:50 +0400)]
core: --user -- move generator directories from /tmp to $XDG_RUNTIME_DIR
Kay Sievers [Mon, 6 Jan 2014 17:33:58 +0000 (01:33 +0800)]
bus-proxyd: fix socket path
Tom Gundersen [Mon, 6 Jan 2014 11:17:34 +0000 (12:17 +0100)]
libsystemd-dns: expose list of DNS servers
My original patch only returned the first DNS server, but we might
want all of them.
Tom Gundersen [Sun, 5 Jan 2014 22:01:32 +0000 (23:01 +0100)]
libsystemd-dhcp: expose received DNS server
Dave Reisner [Sun, 5 Jan 2014 16:57:05 +0000 (11:57 -0500)]
configure: use POSIX conformant syntax for test
In shells like bash, == and = are equivalent in test contexts. In POSIX
compliant shells, == isn't a valid operator.
Michael Scherer [Sun, 5 Jan 2014 16:06:50 +0000 (17:06 +0100)]
Fix format string mismatch introduced in
ab9001a1
src/libsystemd-bus/sd-bus.c: In function 'sd_bus_open_user':
src/libsystemd-bus/sd-bus.c:1104:25: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'long unsigned int' [-Wformat=]
asprintf(&b->address, UNIX_USER_BUS_FMT, (unsigned long) getuid());
Kay Sievers [Sun, 5 Jan 2014 14:53:39 +0000 (18:53 +0400)]
Revert "bus: driverd: don't attempt to remove from empty list"
We need to find the real reason for the failure, this just
avoids the symptoms.
This reverts commit
215c7625dd510759290d45d6c46434e4338843ec.
George McCollister [Tue, 31 Dec 2013 20:37:32 +0000 (14:37 -0600)]
journal: Add missing byte order conversions
Convert entry_array.items[0] to host byte order prior to passing it to
chain_cache_put().
[zj: also use le64toh in journal-verify.c]
https://bugs.freedesktop.org/show_bug.cgi?id=73194
Zbigniew Jędrzejewski-Szmek [Fri, 27 Dec 2013 05:16:39 +0000 (00:16 -0500)]
shared/install: use char** convention for strvs
Zbigniew Jędrzejewski-Szmek [Sun, 5 Jan 2014 05:32:43 +0000 (00:32 -0500)]
Remove unused variables
Simon Peeters [Sat, 4 Jan 2014 01:35:27 +0000 (02:35 +0100)]
strv: multiple cleanups
- turn strv_merge into strv_extend_strv.
appending strv b to the end of strv a instead of creating a new strv
- strv_append: remove in favor of strv_extend and strv_push.
- strv_remove: write slightly more elegant
- strv_remove_prefix: remove unused function
- strv_overlap: use strv_contains
- strv_printf: STRV_FOREACH handles NULL correctly
Simon Peeters [Sat, 4 Jan 2014 01:35:25 +0000 (02:35 +0100)]
shared: util.c: unify split and split_quoted
David Herrmann [Sun, 5 Jan 2014 12:59:12 +0000 (13:59 +0100)]
TODO: extend login capability note
We cannot remove CAP_SYS_ADMIN, which basically makes removing all other
capabilities useless. Anyhow, still wouldn't hurt checking whether stuff
like CAP_KILL can be dropped from logind.
Marcel Holtmann [Sun, 5 Jan 2014 08:44:34 +0000 (00:44 -0800)]
hwdb: update
Marc-Antoine Perennou [Sat, 28 Dec 2013 04:54:18 +0000 (13:54 +0900)]
bus: driverd: don't attempt to remove from empty list
Mantas Mikulėnas [Sat, 4 Jan 2014 23:57:11 +0000 (01:57 +0200)]
bus: open user, not system, bus in bus_open_user_systemd()
Simon Peeters [Sat, 4 Jan 2014 01:35:26 +0000 (02:35 +0100)]
util.c: use read_one_line_file where possible
Simon Peeters [Sat, 4 Jan 2014 01:35:23 +0000 (02:35 +0100)]
shared: procfs_file_alloca: handle pid==0
when pid is set to 0 use /proc/self
Stefan Beller [Fri, 3 Jan 2014 19:33:21 +0000 (20:33 +0100)]
Update .mailmap file
This commit updates email addresses of people, who are already in the
.mailmap file, so I'd assume they have sorted out their viewpoint on
privacy within the .mailmap file.
The entries for this commit have been produced using:
# Finding out duplicates by comparing email addresses:
git shortlog -sne |awk '{ print $NF }' |sort |uniq -d
# Finding out duplicates by comparing names:
git shortlog -sne |awk '{ NF--; $1=""; print }' |sort |uniq -d
Stefan Beller [Fri, 3 Jan 2014 19:33:20 +0000 (20:33 +0100)]
swap: remove if/else with the same data path
This was introduced in
e1770af812 (2012-02-03, swap: replace failure
boolean by result enum).
This just removes unneeded lines of code, no functional change.
Zbigniew Jędrzejewski-Szmek [Sun, 5 Jan 2014 00:28:52 +0000 (19:28 -0500)]
man: document some more bus functions
Tom Gundersen [Sat, 4 Jan 2014 20:13:47 +0000 (21:13 +0100)]
networkd: refuse to use .network files with missing Address/Gateway key
These keys are mandatory in [Address]/[Route] sections. Otherwise, we
hit an assert:
ens3: setting addresses
Assertion 'address->family == 2 || address->family == 10' failed at /build/amd64-generic/tmp/portage/sys-apps/systemd-9999-r1/work/systemd-9999/src/network/networkd-address.c:137, function address_configure(). Aborting.
Reported-by: Alex Polvi <alex.polvi@coreos.com>
At the same time make sure Route's Destination and Gateway uses the same address family.
Thomas Hindoe Paaboel Andersen [Sat, 4 Jan 2014 22:21:13 +0000 (23:21 +0100)]
man: typo fix
Dave Reisner [Sat, 4 Jan 2014 02:15:00 +0000 (21:15 -0500)]
sd-event: add missing symbol, sd_event_source_set_io_fd
This appears to have been omitted in
30caf8f3afd29da8 when the
the function was added.
Tom Gundersen [Sat, 4 Jan 2014 13:43:45 +0000 (14:43 +0100)]
udev: net_id - handle virtio buses
This was already supported in path_id, so should be uncontroversial.
Tom Gundersen [Sat, 4 Jan 2014 03:22:06 +0000 (04:22 +0100)]
Revert "net-util: add support for Type=ethernet"
This reverts commit
4cd1214db6cf4b262e8ce6381bc710091b375c96.
This may still be fixed in the kernel, revert this for now until
we see how it all shakes out.
Thomas Hindoe Paaboel Andersen [Fri, 3 Jan 2014 22:50:59 +0000 (23:50 +0100)]
systemctl: improve readability on failed commands
Not long ago a failed command would print:
"Failed to start something.service: ..."
regardless of whether the command was to start/stop/restart/etc.
With e3e0314 this was improved to print the method used. E.g. for stopping:
"Failed to StopUnit something.service: ..."
This patch matches the method to a more human readable word. E.g:
"Failed to stop something.service: ..."
Zbigniew Jędrzejewski-Szmek [Sat, 4 Jan 2014 05:08:50 +0000 (00:08 -0500)]
man: document a batch of bus functions
Tom Gundersen [Fri, 3 Jan 2014 20:07:01 +0000 (21:07 +0100)]
man: networkd - document DHCP option
Tom Gundersen [Fri, 3 Jan 2014 19:55:23 +0000 (20:55 +0100)]
net-util: add support for Type=ethernet
When DEVTYPE is not set for a nic, it means it is a wired/ethernet
device.
Tom Gundersen [Fri, 3 Jan 2014 17:27:26 +0000 (18:27 +0100)]
networkd: link hash uses 64, not 32 bit keys
Tom Gundersen [Fri, 3 Jan 2014 17:20:11 +0000 (18:20 +0100)]
networkd: print the ifindex of added links
This debug information may be useful when comapring to dropped rtnetlink messages.
Tom Gundersen [Fri, 3 Jan 2014 15:38:18 +0000 (16:38 +0100)]
networkd: improve logging
This gives a bit better messages when a link is added twice.
Tom Gundersen [Fri, 3 Jan 2014 15:20:10 +0000 (16:20 +0100)]
networkd: improve link state change logging
Tom Gundersen [Fri, 3 Jan 2014 15:02:12 +0000 (16:02 +0100)]
networkd: add some debug info about notifications we ignore
Kay Sievers [Fri, 3 Jan 2014 01:57:45 +0000 (02:57 +0100)]
bus: always create --user bus when kdbus is active
We set the variable in the unit file for --user, so this check is
always true.
Tom Gundersen [Fri, 3 Jan 2014 01:07:56 +0000 (02:07 +0100)]
networkd: link - explicitly set the link to be up if the call to IFF_UP succeeds
No need to wait for the NEWLINK message to arrive.
Zbigniew Jędrzejewski-Szmek [Fri, 3 Jan 2014 00:49:49 +0000 (19:49 -0500)]
networkd: fix memory leak in error path
Zbigniew Jędrzejewski-Szmek [Fri, 3 Jan 2014 00:49:43 +0000 (19:49 -0500)]
networkd: do not deference null pointer in cleanup
Zbigniew Jędrzejewski-Szmek [Fri, 3 Jan 2014 00:49:33 +0000 (19:49 -0500)]
core: fix gcc unused variable warning
Zbigniew Jędrzejewski-Szmek [Wed, 1 Jan 2014 03:45:45 +0000 (22:45 -0500)]
bus: fix memleak in sd_bus_creds_new_from_pid
Zbigniew Jędrzejewski-Szmek [Wed, 1 Jan 2014 03:35:54 +0000 (22:35 -0500)]
Introduce cleanup functions for cap_free
Unfortunately a different cleanup function is necessary per type,
because cap_t** and char** are incompatible with void**.
Zbigniew Jędrzejewski-Szmek [Wed, 1 Jan 2014 01:20:17 +0000 (20:20 -0500)]
build-sys: add --disable-dbus autoconf option
Zbigniew Jędrzejewski-Szmek [Wed, 1 Jan 2014 01:19:58 +0000 (20:19 -0500)]
build-sys: make valgrind-tests target output nicer
Zbigniew Jędrzejewski-Szmek [Tue, 31 Dec 2013 17:56:59 +0000 (12:56 -0500)]
rtnl: fix memory corruptions after realloc
struct sd_rtnl_message would keep two additional pointers into the hdr
field. Every time hdr was realloced, those pointers should be adjusted,
but weren't. It seems less error-prone to keep offsets instead.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Dec 2013 04:13:38 +0000 (23:13 -0500)]
bus: break reference cycle between bus and messages
Because messages in the read and write queues hold a reference on the
bus, and the bus holds a reference on each of them, we would never
free the bus if the read or write queues were not empty. Explicitly
substract the number of messages in those queue from the bus reference
count when deciding whether to free or not.
A simple test which creates and unrefs simple objects is added.
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 22:22:26 +0000 (17:22 -0500)]
Use format patterns for usec_t, pid_t, nsec_t, usec_t
It is nicer to predefine patterns using configure time check instead of
using casts everywhere.
Since we do not need to use any flags, include "%" in the format instead
of excluding it like PRI* macros.
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 21:12:46 +0000 (16:12 -0500)]
Move bus path definitions to def.h
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 16:21:56 +0000 (11:21 -0500)]
core/service: check if mainpid matches only if it is set
https://bugzilla.redhat.com/show_bug.cgi?id=1047304
Zbigniew Jędrzejewski-Szmek [Sat, 28 Dec 2013 03:12:38 +0000 (22:12 -0500)]
core/manager: print info about interesting signals
Information about signals which are not routinely received by systemd
are printed at info level. This should make it easier to see what is
happening in the system.
Zbigniew Jędrzejewski-Szmek [Sat, 28 Dec 2013 01:03:27 +0000 (20:03 -0500)]
core/service: tweak messages on operation timeouts
Tom Gundersen [Fri, 3 Jan 2014 00:25:18 +0000 (01:25 +0100)]
libsystemd-dhcp: don't assert on client_stop()
We need to be able to stop the dhcp client at any time, and the function appears to be written to handle this.
Tom Gundersen [Thu, 2 Jan 2014 23:55:35 +0000 (00:55 +0100)]
networkd: dhcp - avoid null pointer dereference
Tom Gundersen [Thu, 2 Jan 2014 23:55:09 +0000 (00:55 +0100)]
networkd: add more asserts and ignore all events when link has failed
Kay Sievers [Fri, 3 Jan 2014 00:32:03 +0000 (01:32 +0100)]
rules: drivers - do not reset RUN list
Tom Gundersen [Thu, 2 Jan 2014 14:56:10 +0000 (15:56 +0100)]
networkd: only track state of links we are managing
If a network is not (yet) set for a link, we do not care about its state (as we
anyway don't know what to do with it).
Tom Gundersen [Thu, 2 Jan 2014 14:30:46 +0000 (15:30 +0100)]
networkd: improve logging
Remove redundant messages, add some debugging ones and make wording more uniform.
Kay Sievers [Thu, 2 Jan 2014 04:16:14 +0000 (05:16 +0100)]
networkd: fix NULL pointer deref
Tom Gundersen [Thu, 2 Jan 2014 00:43:05 +0000 (01:43 +0100)]
networkd: fix getting initial state
We were requesting the state and then ignoring it...
Tom Gundersen [Wed, 1 Jan 2014 14:16:34 +0000 (15:16 +0100)]
networkd: add DHCPv4 support
This adds basic DHCPv4 support. Link-sense is enabled unconditionally,
but the plan is to make that configurable.
I tested this in a VM with lots of NICs and over wifi in the various
coffee shops I found this Christmas, but more testing would definitely
be appreciated.
Tom Gundersen [Wed, 1 Jan 2014 14:16:10 +0000 (15:16 +0100)]
networkd: distinguish between static and dynamic addresses/routes
Static addresses/routes are associated with a network. Dynamic
addresses/routes are associtade with links (as the corresponding network
may be shared by several links).
Tom Gundersen [Tue, 31 Dec 2013 16:31:50 +0000 (17:31 +0100)]
network: add support for dropping address
Zbigniew Jędrzejewski-Szmek [Tue, 31 Dec 2013 17:51:46 +0000 (12:51 -0500)]
build-sys: make test output a bit nicer
Zbigniew Jędrzejewski-Szmek [Tue, 31 Dec 2013 16:57:38 +0000 (11:57 -0500)]
dhcp: fix creation of req_opts array
GREEDY_REALLOC needs to have two size variables: one for the
allocated size, and a second one for the used size. Using
the allocated size only lead to leaving some elements unitialized
and assigning some more than once.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Dec 2013 16:48:04 +0000 (11:48 -0500)]
build-sys: make test-dhcp-* statically linked
This makes them behave like everything else following
48d7417d3 'build-sys: link most internal libraries statically'.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Dec 2013 16:23:58 +0000 (11:23 -0500)]
sleep-config: fix double free
Before
34a3baa4d 'sleep-config: Dereference pointer before check for NULL'
oom conditions would not be detected properly. After that commit, a double
free was performed.
Rework the whole function to be easier to understand, and also replace
strv_split_nulstr with strv_new, since we know the strings anyway.
Stefan Beller [Mon, 30 Dec 2013 22:32:22 +0000 (23:32 +0100)]
boot-efi: Remove superfluous assignment
2 lines after the changed line we assign err to efi_get_variable(...)
unconditionally, so it makes no sense to initialize it to some value.
Stefan Beller [Mon, 30 Dec 2013 16:43:52 +0000 (17:43 +0100)]
sleep-config: Dereference pointer before check for NULL
This fixes a bug pointed out by http://css.csail.mit.edu/stack/
(Optimization-unstable code)
It is a similar fix as
f146f5e159 (2013-12-30, core:
Forgot to dereference pointer when checking for NULL)
To explain this bug consider the following similar, but simpler code:
if (!p)
free(*p)
Assume the if condition evaluates to true, then we will access *p,
which means the compiler can assume p is a valid pointer, so it could
dereference p and use the value *p.
Assuming p as a valid pointer, !p will be false.
But initally we assumed the condition evaluates to true.
By this reasoning the optimizing compiler can deduce, we have dead code.
("The if will never be taken, as *p must be valid, because otherwise
accessing *p inside the if would segfault")
This led to an error message of the static code checker, so I checked the
code in question.
As we access *modes and *states before the check in the changed line of
this patch, I assume the line to be wrong and we actually wanted to check
for *modes and *states being both non null.
Stefan Beller [Sun, 29 Dec 2013 23:09:56 +0000 (00:09 +0100)]
bootchart: Remove unneeded check for NULL
Directly before the changed line there is:
while ((parent->next_ps && parent->pid != ps->ppid))
parent = parent->next_ps;
which looks one element ahead of the list, hence we can rely on parent
being non null here.
If 'parent' were NULL at that while loop already, it would crash as we're
dereferencing 'parent' when checking for next_ps already.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 18:00:38 +0000 (13:00 -0500)]
tmpfiles: rename --unsafe to --boot
As suggested by Kay, it is better to describe what is done,
not what might happen.
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 17:10:14 +0000 (12:10 -0500)]
build-sys: fix systemd-stdio-bridge link to work with split /usr
shumski> there seems to be slight error in systemd git master Makefile.am
Stefan Beller [Sun, 29 Dec 2013 23:18:39 +0000 (00:18 +0100)]
core: Forgot to dereference pointer when checking for NULL
Actually we already checked for !rt before, now we'd like to examine
the return value of the memory allocation.
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 05:11:30 +0000 (00:11 -0500)]
man: expand on some more subtle points in systemd.socket(5)
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727708#1694
Zbigniew Jędrzejewski-Szmek [Mon, 30 Dec 2013 05:01:00 +0000 (00:01 -0500)]
systemd-python: fix listen_fds under Python 2