Craig Topper [Sat, 4 Jan 2020 01:18:07 +0000 (17:18 -0800)]
[X86] Autogenerate complete checks. NFC
Francis Visoiu Mistrih [Fri, 3 Jan 2020 22:50:19 +0000 (14:50 -0800)]
[Remarks] Warn if a remark file is not found when processing static archives
Static archives contain object files which contain sections pointing to
external remark files.
When static archives are shipped without the remark files, dsymutil
shouldn't generate an error.
Instead, generate a warning to inform the user that remarks for that
library won't be available in the .dSYM.
Davide Italiano [Sat, 4 Jan 2020 00:49:51 +0000 (16:49 -0800)]
[UserExpression] Clean up `return` after `else`.
Daniel Sanders [Sat, 4 Jan 2020 00:51:28 +0000 (16:51 -0800)]
[gicombiner] Correct
64f1bb5cd2c to account for MSVC's %p format
Tyker [Fri, 3 Jan 2020 23:14:17 +0000 (00:14 +0100)]
LLVM GN Syncbot [Sat, 4 Jan 2020 00:24:04 +0000 (00:24 +0000)]
[gn build] Port
64f1bb5cd2c
Daniel Sanders [Fri, 3 Jan 2020 23:53:25 +0000 (15:53 -0800)]
[gicombiner] Add GIMatchTree and use it for the code generation
Summary:
GIMatchTree's job is to build a decision tree by zipping all the
GIMatchDag's together.
Each DAG is added to the tree builder as a leaf and partitioners are used
to subdivide each node until there are no more partitioners to apply. At
this point, the code generator is responsible for testing any untested
predicates and following any unvisited traversals (there shouldn't be any
of the latter as the getVRegDef partitioner handles them all).
Note that the leaves don't always fit into partitions cleanly and the
partitions may overlap as a result. This is resolved by cloning the leaf
into every partition it belongs to. One example of this is a rule that can
match one of N opcodes. The leaf for this rule would end up in N partitions
when processed by the opcode partitioner. A similar example is the
getVRegDef partitioner where having rules (add $a, $b), and (add ($a, $b), $c)
will result in the former being in the partition for successfully
following the vreg-def and failing to do so as it doesn't care which
happens.
Depends on D69151
Reviewers: bogner, volkan
Reviewed By: volkan
Subscribers: lkail, mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69152
Stella Laurenzo [Wed, 1 Jan 2020 00:32:41 +0000 (16:32 -0800)]
Add missing mlir-headers target and add tablegen'd deps to it.
Summary:
Prior to this, "ninja install-mlir-headers" failed with an error indicating
the missing target. Verified that from a clean build, the installed
headers include generated files.
Subscribers: mgorny, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72045
Gabor Horvath [Fri, 3 Jan 2020 23:49:32 +0000 (15:49 -0800)]
[fuchsia] Enable Clang Static Analyzer
Differential Revision: https://reviews.llvm.org/D72188
Stanislav Mekhanoshin [Fri, 3 Jan 2020 21:19:51 +0000 (13:19 -0800)]
[AMDGPU] Revert scheduling to reduce spilling
We can revert region schedule if new schedule decreases occupancy.
However, if we already have only one wave we would accept any new
schedule even if it blows up register pressure. Such schedule may
result in quite heavy spilling which can be avoided if we reject
this new schedule.
Differential Revision: https://reviews.llvm.org/D72181
Jonas Devlieghere [Fri, 3 Jan 2020 22:17:25 +0000 (14:17 -0800)]
[lldb/Utility] YAML validation should be orthogonal to packet semantics.
It's not up to YAML to validate the semantics of the GDB remote packet
struct. This is especially wrong here as there's nothing that says that
the amount of bytes transmitted matches the packet payload size.
Jonas Devlieghere [Fri, 3 Jan 2020 21:59:08 +0000 (13:59 -0800)]
[lldb/Docs] Include the man page on the website
Jinsong Ji [Fri, 3 Jan 2020 20:56:06 +0000 (20:56 +0000)]
[PowerPC][LoopVectorize] Add tests for fp128 and fp16
Add two tests to reg-usage.ll
Daniel Sanders [Fri, 3 Jan 2020 21:35:56 +0000 (13:35 -0800)]
[globalisel] Fix another mismatch between %d and the RuleID type
Jonas Devlieghere [Fri, 3 Jan 2020 21:34:21 +0000 (13:34 -0800)]
[lldb/Docs] Include how to generate the man page
Jonas Toth [Fri, 3 Jan 2020 21:31:23 +0000 (22:31 +0100)]
[clang-tidy] fix linkage with clangSema for FixitHintUtils, undo previous wrong fix
Alexandre Ganea [Fri, 3 Jan 2020 21:31:24 +0000 (16:31 -0500)]
[mlir] Compilation fix: use LLVM_ATTRIBUTE_UNUSED following
6656e961c08393c3949412ef945ade0272b66fca
Differential Revision: https://reviews.llvm.org/D72124
River Riddle [Fri, 3 Jan 2020 21:12:25 +0000 (13:12 -0800)]
[mlir] Fix indexed_accessor_range to properly forward the derived class.
Summary: This fixes the return value of helper methods on the base range class.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D72127
Matt Arsenault [Sat, 9 Nov 2019 05:21:00 +0000 (21:21 -0800)]
GlobalISel: Add type argument to getRegBankFromRegClass
AMDGPU can't unambiguously go back from the selected instruction
register class to the register bank without knowing if this was used
in a boolean context.
Ayke van Laethem [Fri, 3 Jan 2020 21:10:27 +0000 (22:10 +0100)]
[bindings/go] Add Subprogram method
This method allows getting the subprogram metadata object from a
function value.
Differential Revision: https://reviews.llvm.org/D71528
Michael Liao [Wed, 27 Nov 2019 14:49:56 +0000 (09:49 -0500)]
[amdgpu] Skip non-instruction values in CF user tracing.
Summary:
- CF users won't be non-instruction values. Skip them to save the
compilation time. It's especially true when there are multiple
functions in that module, where, says, a constant may be used in most
functions. The current CF user tracing adds significant overhead.
Reviewers: alex-t, rampitec
Subscribers: arsenm, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72174
Jonas Toth [Fri, 3 Jan 2020 21:02:11 +0000 (22:02 +0100)]
[clang-tidy] quickfix: add -fno-delayed-template-parsing as default argument for runCheckOnCode unit-tests to unbreak windows
Jonas Toth [Fri, 3 Jan 2020 20:55:40 +0000 (21:55 +0100)]
[clang-tidy] fix broken linking for AddConstTest with adding clangSema as dependency (DeclSpec)
Stefan Gränitz [Fri, 3 Jan 2020 17:33:33 +0000 (18:33 +0100)]
[NFC][ORC] Fix typos and whitespaces in comments
LLVM GN Syncbot [Fri, 3 Jan 2020 20:30:09 +0000 (20:30 +0000)]
[gn build] Port
9861a8538c0
Jonas Paulsson [Mon, 30 Dec 2019 22:03:49 +0000 (23:03 +0100)]
[SystemZ] Don't allow CL option -mpacked-stack with -mbackchain.
-mpacked-stack is currently not supported with -mbackchain, so this should
result in a compilation error message instead of being silently ignored.
Review: Ulrich Weigand
Matt Arsenault [Fri, 3 Jan 2020 19:47:59 +0000 (14:47 -0500)]
AMDGPU: Add gfx9 run lines to a testcase
Matt Arsenault [Fri, 3 Jan 2020 14:10:00 +0000 (09:10 -0500)]
AMDGPU/GlobalISel: Add new utils file
There are some things that are shareable between the legalizer,
regbankselect, and the selector that don't have an obvious place to
go.
Matt Arsenault [Fri, 3 Jan 2020 01:59:29 +0000 (20:59 -0500)]
AMDGPU: Only allow regs for s_movrel_{b32|b64}
This would incorrectly allowing folding immediates. These currently
aren't selectable, but will be from GlobalISel soon.
Lei Zhang [Fri, 3 Jan 2020 20:08:54 +0000 (15:08 -0500)]
[mlir] Enhance classof() checks in StructsGen
Previously we only check that each field is of the correct
mlir::Attribute subclass. This commit enhances to also consider
the attribute's types, by leveraging the constraints already
encoded in TableGen attribute definitions.
Reviewed By: rsuderman
Differential Revision: https://reviews.llvm.org/D72162
Nicolas Vasilache [Fri, 3 Jan 2020 20:10:24 +0000 (15:10 -0500)]
[mlir][Linalg] NFC - Post-commit format fix
Nicolas Vasilache [Fri, 3 Jan 2020 20:05:39 +0000 (15:05 -0500)]
[mlir][Linalg] NFC - Hotfix GenericLoopNestBuilder compilation error on older gcc (-fpermissive)
This fixes the error:
```
mlir/include/mlir/Dialect/Linalg/Utils/Utils.h:72:3: error: from definition of 'template<class LoopTy> mlir::edsc::GenericLoopNestRangeBuilder<LoopTy>::GenericLoopNestRangeBuilder(llvm::ArrayRef<mlir::edsc::ValueHandle*>, llvm::ArrayRef<mlir::Value>)' [-fpermissive]
GenericLoopNestRangeBuilder(ArrayRef<edsc::ValueHandle *> ivs,
```
This was tested independently on a Docker image with gcc-5 by jpienaar@
Lei Zhang [Fri, 3 Jan 2020 20:05:24 +0000 (15:05 -0500)]
[mlir][spirv] Fix ADDITIONAL_HEADER_DIRS for SPIR-V libraries
SPIRV/ headers live under mlir/Dialect/.
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D72141
Sanjay Patel [Fri, 3 Jan 2020 19:57:35 +0000 (14:57 -0500)]
[DAGCombiner] fix miscompile in translating (X & undef) to shuffle
See PR42982 for more context:
https://bugs.llvm.org/show_bug.cgi?id=42982
Craig Topper [Fri, 3 Jan 2020 19:52:18 +0000 (11:52 -0800)]
[LegalizeVectorOps] Pass the post-UpdateNodeOperands version of Op to ExpandLoad/ExpandStore
UpdateNodeOperands might CSE to another existing node. So we should make sure we're legalizing that node otherwise we might fail to hook up the operands properly. I've moved the result registration up to the caller to avoid having to pass both Result and Op into the functions where it might be confusing which is which.
This address 2 other issues pointed out in D71861.
Differential Revision: https://reviews.llvm.org/D72021
Sanjay Patel [Fri, 3 Jan 2020 19:48:45 +0000 (14:48 -0500)]
[x86] add test for miscompile in XformToShuffleWithZero(); NFC
LLVM GN Syncbot [Fri, 3 Jan 2020 19:41:47 +0000 (19:41 +0000)]
[gn build] Port
cf48101200e
Craig Topper [Fri, 3 Jan 2020 18:56:09 +0000 (10:56 -0800)]
[X86] Improve for v2i32->v2f64 uint_to_fp
This uses an alternative implementation of this conversion derived
from our v2i32->v2f32 handling. We can zero extend the v2i32 to
v2i64, or it with the bit representation of 2.0^52 which will give
us 2.0^52 plus the 32-bit integer since double's mantissa is 52 bits.
Then we just need to subtract 2.0^52 as a double and let the floating
point unit normalize the remaining bits into a valid double.
This is less instructions then our previous code, but does require
a port 5 shuffle for the zero extend or unpack.
Differential Revision: https://reviews.llvm.org/D71945
Jonas Toth [Fri, 3 Jan 2020 19:36:49 +0000 (20:36 +0100)]
[clang-tidy] implement utility-function to add 'const' to variables
Summary:
This patch extends the already existing facility to add 'const' to variables
to be more flexible and correct. The previous version did not consider pointers
as value AND pointee. For future automatic introduction for const-correctness
this shortcoming needs to be fixed.
It always allows configuration where the 'const' token is inserted, either on
the left side (if possible) or the right side.
It adds many unit-tests to the utility-function that did not exist before, as
the function was implicitly tested through clang-tidy checks. These
tests were not changed, as the API is still compatible.
Reviewers: aaron.ballman, hokein, alexfh, shuaiwang, lebedev.ri
Reviewed By: aaron.ballman
Subscribers: jdoerfert, mgorny, xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D54395
Nicolas Vasilache [Fri, 3 Jan 2020 19:28:32 +0000 (14:28 -0500)]
[mlir][Linalg] NFC - Hotfix GenericLoopNestBuilder compilation error (-fpermissive)
This should fix the error:
```
mlir/include/mlir/Dialect/Linalg/Utils/Utils.h:72:3: error: from definition of 'template<class LoopTy> mlir::edsc::GenericLoopNestRangeBuilder<LoopTy>::GenericLoopNestRangeBuilder(llvm::ArrayRef<mlir::edsc::ValueHandle*>, llvm::ArrayRef<mlir::Value>)' [-fpermissive]
GenericLoopNestRangeBuilder(ArrayRef<edsc::ValueHandle *> ivs,
```
Reid Kleckner [Tue, 3 Dec 2019 00:42:33 +0000 (16:42 -0800)]
Move tail call disabling code to target independent code
When the "disable-tail-calls" attribute was added, checks were added for
it in various backends. Now this code has proliferated, and it is
something the target is responsible for checking. Move that
responsibility back to the ISels (fast, global, and SD).
There's no major functionality change, except for targets that never
implemented this check.
This LLVM attribute was originally added in
d9699bc7bdf0362173fcd256690f61a4d47429c2 (2015).
Reviewers: echristo, MaskRay
Differential Revision: https://reviews.llvm.org/D72118
Alexander Lanin [Fri, 3 Jan 2020 19:13:40 +0000 (14:13 -0500)]
Remove outdated svn/git information from hacking page
The patch files section is redundant to https://llvm.org/docs/GettingStarted.html.
There is nothing clang specific here. We are talking about a monorepo after all.
While it may seem nice to have one single clang page which explains everything,
it's not: It doesn't cover the topics in sufficient depth, it's redundant to
other pages and it's hard to keep it up to date as we see with the svn
instructions.
Roman Lebedev [Fri, 3 Jan 2020 18:10:51 +0000 (21:10 +0300)]
[NFC][InstCombine] '(Op1 & С) - Op1' -> '-(Op1 & ~C)' fold (PR44427)
This decreases use count of Op1, potentially allows
us to further hoist said 'neg' later on,
and results in marginally better X86 codegen.
Name: (Op1 & С) - Op1 -> -(Op1 & ~C)
%o = and i64 %Op1, C1
%r = sub i64 %o, %Op1
=>
%n = and i64 %Op1, ~C1
%r = sub i64 0, %n
https://rise4fun.com/Alive/rwgA
https://godbolt.org/z/R_RMfM
https://bugs.llvm.org/show_bug.cgi?id=44427
Roman Lebedev [Fri, 3 Jan 2020 18:05:34 +0000 (21:05 +0300)]
[NFC][InstCombine] '(Op1 & С) - Op1' pattern tests (PR44427)
Roman Lebedev [Fri, 3 Jan 2020 17:54:31 +0000 (20:54 +0300)]
[NFC][InstCombine] Autogenerate and2.ll checklines
Ahmed Taei [Fri, 3 Jan 2020 18:20:43 +0000 (13:20 -0500)]
[mlir][linalg] Lower linalg to affine loops
Reviewers: nicolasvasilache
Reviewed By: nicolasvasilache
Subscribers: mgester, lucyrfox, merge_guards_bot, AlexEichenberger, mravishankar, ftynse, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72094
Nicolas Vasilache [Fri, 3 Jan 2020 18:05:44 +0000 (13:05 -0500)]
[mlir][Vector] NFC - Add documentation for the VectorOps dialect.
Jonas Devlieghere [Fri, 3 Jan 2020 17:30:20 +0000 (09:30 -0800)]
[DWARF] Don't assume optional always has a value.
When getting the file name form the line table prologue we assume that a
valid string form value can always be extracted as a string. If you look
at the implementation of DWARFormValue this is not necessarily true. I
hit this assertion from LLDB when I create a "dummy" DWARFContext that
was missing the string section.
Roman Lebedev [Fri, 3 Jan 2020 16:53:29 +0000 (19:53 +0300)]
[NFC][InstCombine] '(X & (- Y)) - X' -> '- (X & (Y - 1))' fold (PR44448)
Name: (X & (- Y)) - X -> - (X & (Y - 1)) (PR44448)
%negy = sub i8 0, %y
%unbiasedx = and i8 %negy, %x
%r = sub i8 %unbiasedx, %x
=>
%ymask = add i8 %y, -1
%xmasked = and i8 %ymask, %x
%r = sub i8 0, %xmasked
https://rise4fun.com/Alive/OIpla
This decreases use count of %x, may allow us to
later hoist said negation even further,
and results in marginally nicer X86 codegen.
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Roman Lebedev [Fri, 3 Jan 2020 16:34:39 +0000 (19:34 +0300)]
[NFC][InstCombine] '(X & (- Y)) - X' pattern tests (PR44448)
As discussed in https://bugs.llvm.org/show_bug.cgi?id=44448,
we can hoist negation out of the pattern.
Fangrui Song [Fri, 3 Jan 2020 17:15:52 +0000 (09:15 -0800)]
[AArch64][test] Merge arm64-$i.ll Linux tests into $i.ll
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D72061
Sam McCall [Fri, 3 Jan 2020 16:26:33 +0000 (17:26 +0100)]
[clangd] targetDecl() returns only NamedDecls.
Summary:
While it's perfectly reasonable for non-named decls such as
static_assert to resolve to themselves:
- nothing else ever resolves to them
- features based on references (hover, highlight, find refs etc) tend
to be uninteresting where only trivial references are possible
- returning NamedDecl is a more convenient API (we cast to it in many places)
- this aligns closer to findExplicitReferences/explicitReferenceTargets
This fixes a crash in explicitReferenceTargets: if the target is a
non-named decl then there's an invalid unchecked cast to NamedDecl.
In practice this means when hovering over e.g. a static_assert:
- before
ac3f9e4842, we would show a (boring) hover card
- after
ac3f9e4842, we would crash
- after this patch, we will show nothing
Reviewers: kadircet, ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72163
Alexey Bataev [Fri, 3 Jan 2020 16:58:16 +0000 (11:58 -0500)]
[OPENMP]Fix crash on error message for declare reduction.
If the qualified reduction name is specified and not found, the compiler
may crash because of not specified parameter.
Nico Weber [Fri, 3 Jan 2020 17:11:36 +0000 (12:11 -0500)]
[clang-format/java] format multiple qualified annotations on one declaration better
Before:
class Foo {
@CommandLineFlags
.Add
@Features.foo
public void test() {}
}
Now:
class Foo {
@Features.foo
@CommandLineFlags.Add
public void test() { }
}
See also https://crbug.com/1034115
Kelvin Li [Fri, 3 Jan 2020 16:55:37 +0000 (11:55 -0500)]
[OpenMP] diagnose zero-length array section in the depend clause
The OpenMP specification disallows having zero-length array
sections in the depend clause (OpenMP 5.0 2.17.11).
Differential Revision: https://reviews.llvm.org/D71969
Johannes Doerfert [Thu, 2 Jan 2020 23:20:47 +0000 (17:20 -0600)]
[Attributor][FIX] Allow dead users of rewritten function
If we replace a function with a new one because we rewrite the
signature, dead users may still refer to the old version. With this
patch we reuse the code that deals with dead functions, which the old
versions are, to avoid problems.
Johannes Doerfert [Thu, 2 Jan 2020 22:53:37 +0000 (16:53 -0600)]
[Attributor][NFC] Unify the way we delete dead functions
Johannes Doerfert [Thu, 2 Jan 2020 22:41:17 +0000 (16:41 -0600)]
[Attributor][FIX] Don't crash on ptr2int/int2ptr instructions
An integer isn't allowed in getAlignmentForValue so we need to stop at a
ptr2int instruction during exploration.
Johannes Doerfert [Tue, 31 Dec 2019 22:09:12 +0000 (16:09 -0600)]
[Attributor][FIX] Do not derive nonnull and dereferenceable w/o access
An inbounds GEP results in poison if the value is not "inbounds", not in
UB. We accidentally derived nonnull and dereferenceable from these
inbounds GEPs even in the absence of accesses that would make the poison
to UB.
Johannes Doerfert [Tue, 31 Dec 2019 19:25:47 +0000 (13:25 -0600)]
[Attributor][FIX] Return CHANGED once a pessimistic fixpoint is reached.
Tyker [Fri, 3 Jan 2020 15:59:44 +0000 (16:59 +0100)]
[Diagnostic] Fixed add ftabstop to -Wmisleading-indentation
Summary:
this allow much better support of codebases like the linux kernel that mix tabs and spaces.
-ftabstop=//Width// allow specifying how large tabs are considered to be.
Reviewers: xbolva00, aaron.ballman, rsmith
Reviewed By: aaron.ballman
Subscribers: mstorsjo, cfe-commits, jyknight, riccibruno, rsmith, nathanchance
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71037
Matt Arsenault [Fri, 3 Jan 2020 15:02:08 +0000 (10:02 -0500)]
AMDGPU/GlobalISel: Fix off by one in operand index
This should be looking at the RHS of the add for a constant.
Roman Lebedev [Fri, 3 Jan 2020 13:14:29 +0000 (16:14 +0300)]
[DAGCombiner][X86][AArch64] Generalize `A-(A&B)`->`A&(~B)` fold (PR44448)
The fold 'A - (A & (B - 1))' -> 'A & (0 - B)'
added in
8dab0a4a7d691f2704f1079538e0ef29548db159
is too specific. It should/can just be 'A - (A & B)' -> 'A & (~B)'
Even if we don't manage to fold `~` into B,
we have likely formed `ANDN` node.
Also, this way there's less similar-but-duplicate folds.
Name: X - (X & Y) -> X & (~Y)
%o = and i32 %X, %Y
%r = sub i32 %X, %o
=>
%n = xor i32 %Y, -1
%r = and i32 %X, %n
https://rise4fun.com/Alive/kOUl
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Roman Lebedev [Fri, 3 Jan 2020 14:11:49 +0000 (17:11 +0300)]
[NFC][X86][AArch64] Add 'A - (A & B)' pattern tests (PR44448)
The fold 'A - (A & (B - 1))' -> 'A & (0 - B)'
added in
8dab0a4a7d691f2704f1079538e0ef29548db159
is too specific. It should just be 'A - (A & B)' -> 'A & (~B)'
Name: X - (X & Y) -> X & (~Y)
%o = and i32 %X, %Y
%r = sub i32 %X, %o
=>
%n = xor i32 %Y, -1
%r = and i32 %X, %n
https://rise4fun.com/Alive/kOUl
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Roman Lebedev [Fri, 3 Jan 2020 14:03:50 +0000 (17:03 +0300)]
[NFC][X86] Add BMI runlines to align-down.ll test
Roman Lebedev [Fri, 3 Jan 2020 13:01:16 +0000 (16:01 +0300)]
[DAGCombiner] `~(add X, -1)` -> `neg X` fold
The fold 'A - (A & (B - 1))' -> 'A & (0 - B)'
added in
8dab0a4a7d691f2704f1079538e0ef29548db159
is too specific. It should just be 'A - (A & B)' -> 'A & (~B)',
but we currently fail to sink that '~' into `(B - 1)`.
Name: ~(X - 1) -> (0 - X)
%o = add i32 %X, -1
%r = xor i32 %o, -1
=>
%r = sub i32 0, %X
https://rise4fun.com/Alive/rjU
Roman Lebedev [Fri, 3 Jan 2020 13:50:37 +0000 (16:50 +0300)]
[NFC][DAGCombine][X86] '~(X - 1)' pattern tests
The fold 'A - (A & (B - 1))' -> 'A & (0 - B)'
added in
8dab0a4a7d691f2704f1079538e0ef29548db159
is too specific. It should just be 'A - (A & B)' -> 'A & (~B)',
but we currently fail to sink that '~' into `(B - 1)`.
Name: ~(X - 1) -> (0 - X)
%o = add i32 %X, -1
%r = xor i32 %o, -1
=>
%r = sub i32 0, %X
https://rise4fun.com/Alive/rjU
Roman Lebedev [Fri, 3 Jan 2020 12:38:53 +0000 (15:38 +0300)]
[DAGCombine][X86][Thumb2/LowOverheadLoops] `A - (A & C)` -> `A & (~C)` fold (PR44448)
While we do manage to fold integer-typed IR in middle-end,
we can't do that for the main motivational case of pointers.
There is @llvm.ptrmask() intrinsic which may or may not be helpful,
but i'm not sure it is fully considered canonical yet,
not everything is fully aware of it likely.
Name: PR44448 ptr - (ptr & C) -> ptr & (~C)
%bias = and i32 %ptr, C
%r = sub i32 %ptr, %bias
=>
%r = and i32 %ptr, ~C
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Roman Lebedev [Fri, 3 Jan 2020 12:37:49 +0000 (15:37 +0300)]
[NFC][DAGCombine][X86] Tests for 'A - (A & C)' pattern (PR44448)
Name: PR44448 ptr - (ptr & C) -> ptr & (~C)
%bias = and i32 %ptr, C
%r = sub i32 %ptr, %bias
=>
%r = and i32 %ptr, ~C
The main motivational pattern involes pointer-typed values,
so this transform can't really be done in middle-end.
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Roman Lebedev [Fri, 3 Jan 2020 12:32:57 +0000 (15:32 +0300)]
[NFC][DAGCombine] Clarify comment for 'A - (A & (B - 1))' fold
Sam Parker [Fri, 3 Jan 2020 14:50:39 +0000 (14:50 +0000)]
[ARM][NFC] Update MIR test
serge-sans-paille [Fri, 3 Jan 2020 14:39:28 +0000 (15:39 +0100)]
Use llvm_canonicalize_cmake_booleans where intended
Differential Revision: https://reviews.llvm.org/D72130
serge-sans-paille [Fri, 3 Jan 2020 14:38:27 +0000 (15:38 +0100)]
Fix compiler extension testing
Correctly declare example dependency. Pipe stderr through FileCheck.
Differential Revision: https://reviews.llvm.org/D72130
serge-sans-paille [Fri, 3 Jan 2020 14:36:52 +0000 (15:36 +0100)]
Fix typo in compiler extension testing
s/CHECK-/CHECK
Differential Revision: https://reviews.llvm.org/D72130
Ankit [Fri, 3 Jan 2020 14:13:55 +0000 (14:13 +0000)]
Fix for a dangling point bug in DeadStoreElimination pass
The patch makes sure that the LastThrowing pointer does not point to any instruction deleted by call to DeleteDeadInstruction.
While iterating through the instructions the pass maintains a pointer to the lastThrowing Instruction. A call to deleteDeadInstruction deletes a dead store and other instructions feeding the original dead instruction which also become dead. The instruction pointed by the lastThrowing pointer could also be deleted by the call to DeleteDeadInstruction and thus it becomes a dangling pointer. Because of this, we see an error in the next iteration.
In the patch, we maintain a list of throwing instructions encountered previously and use the last non deleted throwing instruction from the container.
Reviewers: fhahn, bcahoon, efriedma
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D65326
Sanjay Patel [Fri, 3 Jan 2020 14:15:58 +0000 (09:15 -0500)]
[InstCombine] replace undef elements in vector constant when doing icmp folds (PR44383)
As shown in P44383:
https://bugs.llvm.org/show_bug.cgi?id=44383
...we can't safely propagate a vector constant through this icmp fold
if that vector constant contains undefined elements.
We know that each defined element of the constant is safe though, so
find the first of those and replicate it into the formerly undef lanes.
Differential Revision: https://reviews.llvm.org/D72101
Jay Foad [Fri, 3 Jan 2020 14:05:58 +0000 (14:05 +0000)]
Fix typo "psuedo" in comments
Jay Foad [Fri, 3 Jan 2020 13:32:52 +0000 (13:32 +0000)]
[TargetLowering] Remove comments referring to TLOF
These have been obsolete since about r221926, when
TargetLoweringObjectFile was completely moved from TargetLowering to
TargetMachine.
Lei Zhang [Fri, 3 Jan 2020 12:37:19 +0000 (07:37 -0500)]
[mlir][spirv] Fix shader ABI attribute prefix and add verification
This commit fixes shader ABI attributes to use `spv.` as the prefix
so that they match the dialect's namespace. This enables us to add
verification hooks in the SPIR-V dialect to verify them.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D72062
James Henderson [Thu, 2 Jan 2020 17:31:52 +0000 (17:31 +0000)]
[test][ELF] Use CHECK-NEXT to properly verify error messages
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D72092
James Henderson [Fri, 20 Dec 2019 15:13:29 +0000 (15:13 +0000)]
[DebugInfo] Remove redundant checks for past-the-end of prologue
The V5 directory and filename tables had checks in to make sure we
hadn't read past the end of the line table prologue. Since previous
changes to the data extractor class ensure we never read past the end,
these checks are now redundant, so this patch removes them.
There is still a check to show that the whole prologue remains within
the prologue length.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D71768
Anastasia Stulova [Fri, 3 Jan 2020 11:59:19 +0000 (11:59 +0000)]
[OpenCL] Add link to C++ for OpenCL documentation
Remove description of language mode from the language
extensions and add a link to pdf document.
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72076
Ilya Biryukov [Fri, 3 Jan 2020 11:05:14 +0000 (12:05 +0100)]
[Syntax] Build spanning SimpleDecalration for classes, structs, etc
When they are free-standing, e.g. `struct X;` or `struct X {};`.
Although this complicates the common case (of free-standing class
declarations), this ensures the less common case (e.g. `struct X {} a;`)
are handled uniformly and produce similar syntax trees.
James Henderson [Fri, 20 Dec 2019 12:40:20 +0000 (12:40 +0000)]
[test][llvm-dwarfdump] Use --implicit-check-not to simplify test checks
This removes the need to duplicate the LASTONLY check pattern and the
last part of the NONFATAL pattern in the modified test.
Reviewed By: MaskRay, JDevlieghere
Differential Revision: https://reviews.llvm.org/D71757
James Henderson [Fri, 20 Dec 2019 12:30:23 +0000 (12:30 +0000)]
[test][llvm-dwarfdump] Normalise contents and checks for line tables
The line tables in debug_line_malformed.s had contents that varied more
than was necessary for the testing, making it harder to follow what was
important. This patch normalises them so that they all share
more-or-less the same body. Additionally, it makes the testing for what
was printed more consistent, to show that the right parts of the line
table prologue and body are/are not parsed and printed.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D71755
James Henderson [Fri, 20 Dec 2019 11:57:38 +0000 (11:57 +0000)]
[test][llvm-dwarfdump] Add missing checks for table dumping
Some of the tables in debug_line_malformed.s were not being checked in
the NONFATAL checks in debug_line_invalid.test (only the warnings coming
from them were being checked). This made the test harder to follow.
Additionally, a later change will change the way the errors are handled
such that more of the line table will be printed. That will require
checks for these tables (or something equivalent) so that the difference
in behaviour can be observed. This patch adds checks for the three
tables that were missing checks.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D71753
Roman Lebedev [Fri, 3 Jan 2020 09:50:00 +0000 (12:50 +0300)]
[DAGCombine][X86][AArch64] 'A - (A & (B - 1))' -> 'A & (0 - B)' fold (PR44448)
While we do manage to fold integer-typed IR in middle-end,
we can't do that for the main motivational case of pointers.
There is @llvm.ptrmask() intrinsic which may or may not be helpful,
but i'm not sure it is fully considered canonical yet,
not everything is fully aware of it likely.
https://rise4fun.com/Alive/ZVdp
Name: ptr - (ptr & (alignment-1)) -> ptr & (0 - alignment)
%mask = add i64 %alignment, -1
%bias = and i64 %ptr, %mask
%r = sub i64 %ptr, %bias
=>
%highbitmask = sub i64 0, %alignment
%r = and i64 %ptr, %highbitmask
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Roman Lebedev [Fri, 3 Jan 2020 09:46:52 +0000 (12:46 +0300)]
[NFC][DAGCombine][X86][AArch64] Tests for 'A - (A & (B - 1))' pattern (PR44448)
https://rise4fun.com/Alive/ZVdp
Name: ptr - (ptr & (alignment-1)) -> ptr & (0 - alignment)
%mask = add i64 %alignment, -1
%bias = and i64 %ptr, %mask
%r = sub i64 %ptr, %bias
=>
%highbitmask = sub i64 0, %alignment
%r = and i64 %ptr, %highbitmask
The main motivational pattern involes pointer-typed values,
so this transform can't really be done in middle-end.
See
https://bugs.llvm.org/show_bug.cgi?id=44448
https://reviews.llvm.org/D71499
Raphael Isemann [Fri, 3 Jan 2020 10:24:12 +0000 (11:24 +0100)]
[lldb][NFC] Remove forward declaration for non-existent type clang::Action and delete references to it
There is no clang::Action anymore so our forward decl for it and the obsolete pointer in the
ASTStructExtractor can both go (that code anyway didn't do anything).
Raphael Isemann [Fri, 3 Jan 2020 09:36:31 +0000 (10:36 +0100)]
[lldb][NFC] Document TypeSystem and related Compiler* classes
Sam Parker [Fri, 3 Jan 2020 08:48:33 +0000 (03:48 -0500)]
[ARM][NFC] Move tail predication checks
Extract the tail predication validation checks out into their own
LowOverHeadLoop method.
Craig Topper [Fri, 3 Jan 2020 07:27:51 +0000 (23:27 -0800)]
[X86] Reorder X86any* PatFrags to put the strict node first so that chain property will be inferred for the instruction by the tablegen backend.
Also use X86any_vfpround instead of X86vfpround in some instruction
definitions so the strict version can be used to infer the chain
property.
Without these changes we don't propagate strict FP chain through
isel for some instructions.
Kadir Cetinkaya [Wed, 18 Dec 2019 10:23:47 +0000 (11:23 +0100)]
[clangd] Replace shortenNamespace with getQualification
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71652
TH3CHARLie [Fri, 3 Jan 2020 06:04:01 +0000 (14:04 +0800)]
[llvm-size] print a blank line between archieve members when using sysv format
Summary: This patch is related to https://bugs.llvm.org/show_bug.cgi?id=42967 and it fixes llvm-size's sysv format output by adding a blank line between archieve members
Reviewers: jhenderson, Jim, MaskRay
Reviewed By: jhenderson, Jim, MaskRay
Subscribers: MaskRay, Jim, rupprecht, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71957
Craig Topper [Fri, 3 Jan 2020 04:51:13 +0000 (20:51 -0800)]
[X86] Re-enable lowerUINT_TO_FP_vXi32 under fast-math by using an FSUB instead of an FADD.
Summary:
We previously disabled this under fast math due to aggressive
reassociation by the machine combiner. But I think we can work
around this by using a FSUB instead of FADD for the first
operation.
This matches the similar algorithm we do for uint_to_fp i64->f64
in TargetLowering::expandUINT_TO_FP. If reassociation hasn't
been a problem for that, hopefully its not a problem here.
Reviewers: RKSimon, spatel, scanon
Reviewed By: spatel
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71968
QingShan Zhang [Fri, 3 Jan 2020 03:26:41 +0000 (03:26 +0000)]
[DAGCombine] Initialize the default operation action for SIGN_EXTEND_INREG for vector type as 'expand' instead of 'legal'
For now, we didn't set the default operation action for SIGN_EXTEND_INREG for
vector type, which is 0 by default, that is legal. However, most target didn't
have native instructions to support this opcode. It should be set as expand by
default, as what we did for ANY_EXTEND_VECTOR_INREG.
Differential Revision: https://reviews.llvm.org/D70000
Wang, Pengfei [Fri, 3 Jan 2020 02:57:27 +0000 (10:57 +0800)]
[X86] Enable strict FP by default and remove option -disable-strictnode-mutation. NFCI.
Kazuaki Ishizaki [Fri, 3 Jan 2020 02:25:06 +0000 (10:25 +0800)]
[mlir] NFC: Fix broken links in docs
Summary: This commit fixes missing links that are caused by the repository movement.
Reviewers: Jim, rriddle, jpienaar
Reviewed By: Jim, rriddle, jpienaar
Subscribers: arpith-jacob, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72065
Hideto Ueno [Fri, 3 Jan 2020 02:03:56 +0000 (11:03 +0900)]
Revert "[Attributor] AAValueConstantRange: Value range analysis using constant range"
This reverts commit
e9963034314edf49a12ea5e29f694d8f9f52734a.
Kamil Rytarowski [Fri, 3 Jan 2020 01:35:33 +0000 (02:35 +0100)]
[compiler-rt] [netbsd] Switch to syscall for ThreadSelfTlsTcb()
This change avoids using internal, namespaced per-CPU calls that
are not a stable interface to read the TSL base value.