VladislavAntonyuk [Mon, 2 Dec 2019 10:38:05 +0000 (12:38 +0200)]
[Bug] FontImageSourse doesn't work on macOS (#8590) fixes #8469
* [Bug] FontImageSourse doesn't work on macOS
* revert VS changes
* ExportImageSourceHandler
* Revert info.plist
Stephane Delcroix [Mon, 2 Dec 2019 10:25:47 +0000 (11:25 +0100)]
Merge branch '4.4.0'
Stephane Delcroix [Mon, 2 Dec 2019 10:24:02 +0000 (11:24 +0100)]
Merge branch '4.3.0' into 4.4.0
Stephane Delcroix [Mon, 2 Dec 2019 10:22:59 +0000 (11:22 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Sun, 1 Dec 2019 18:37:40 +0000 (11:37 -0700)]
[iOS] Additional Preserve Attributes (#8721)
Shane Neuville [Sun, 1 Dec 2019 01:55:09 +0000 (18:55 -0700)]
IOS Linker fixes inside Xamarin.Forms (#8001)
* Mark iOS platform as linker safe
- remove UIWebView references
* - move linker safe to platform
* Update Xamarin.Forms.ControlGallery.iOS/Xamarin.Forms.ControlGallery.iOS.csproj
* - preserve constructors
* - gallery updates
Kevin Petit [Thu, 28 Nov 2019 11:53:41 +0000 (12:53 +0100)]
Call the application OnResume, on Android Resume instead of Restart. (#7477) Fixes #7400
Gerald Versluis [Thu, 28 Nov 2019 10:15:00 +0000 (11:15 +0100)]
Added defensive code (#8666)
Brayan Khosravian [Thu, 28 Nov 2019 08:12:23 +0000 (09:12 +0100)]
Fix-7167-UWP-ListViewRenderer-ScrollToTop-when-NotifyCollectionChangedAction.Reset (#7279)
* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.
* - changed controlgalery.projitems manually after cherrypick
* - made testcase uitestable
* - fixed uitesting exception
* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)
* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.
* - changed controlgalery.projitems manually after cherrypick
* - made testcase uitestable
* - fixed uitesting exception
* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)
* - wrote uitest, formetted
* - updated comments
* - uitest are only being executed for UWP
* - removed comments (PR feedback)
Konrad Müller [Wed, 27 Nov 2019 19:04:48 +0000 (20:04 +0100)]
[macOS] Implement slider min/max/thumb color (#8098)
* Add slider min/max/thumb color to macOS
* Use forms slider; make custom cell internal
* Remove private modifier
Rui Marinho [Wed, 27 Nov 2019 17:52:46 +0000 (17:52 +0000)]
[Core,iOS,Android] Remove NumberOfSideItems (#8614)
* [Core,iOS,Android] Remove number of side items
* [Controls] Fix IndicadorCodeGallery
Kangho Hur [Wed, 27 Nov 2019 16:54:42 +0000 (08:54 -0800)]
[Tizen] Use pre-created window at initailzation time (#8685)
Seungkeun Lee [Wed, 27 Nov 2019 15:04:13 +0000 (00:04 +0900)]
[Tizen] Add SwipeViewRenderer on Tizen (#8542)
* Add SwipeViewRenderer on Tizen
* Update SwipeItemWidth and Height to PX
* Rebase to 4.4.0
- Fix build error
- Fix async method naming
* Update StaticRegistrar
Shane Neuville [Tue, 26 Nov 2019 19:27:50 +0000 (12:27 -0700)]
Change build type on Android CG (#7909)
Rui Marinho [Tue, 26 Nov 2019 18:29:04 +0000 (18:29 +0000)]
[Tizen]Update StaticRegistrar (#8676)
Kangho Hur [Tue, 26 Nov 2019 16:21:04 +0000 (08:21 -0800)]
[Tizen] Provides Static Registrar (#8642)
* [Tizen] Provides Static Registrar
* Adds Lookup handler instead of fallback mechanism
sung-su.kim [Tue, 26 Nov 2019 15:54:42 +0000 (00:54 +0900)]
[Tizen] Add CarouselViewRenderer (#8081)
* [Tizen] Add CarouselViewRenderer
* [Tizen] Fix item size
* Move ItemSizingStrategy property to StructuredItemsView
Shane Neuville [Tue, 26 Nov 2019 15:26:39 +0000 (08:26 -0700)]
fix generating nugets (#8660)
Javier Suárez Ruiz [Tue, 26 Nov 2019 09:13:21 +0000 (10:13 +0100)]
Implement CollectionView Scrolled event on UWP (#8549)
fixes #8508
Stephane Delcroix [Tue, 26 Nov 2019 00:29:40 +0000 (01:29 +0100)]
[X] RegisterSourceInfo for XamlC (#8579)
When compiling in DEBUG, Register sourceInfo even for compiled code
Shane Neuville [Sun, 24 Nov 2019 18:16:20 +0000 (11:16 -0700)]
fix reflection call uwp (#8636)
shane [Sun, 24 Nov 2019 00:19:34 +0000 (17:19 -0700)]
Merge branch '4.4.0'
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
# Xamarin.Forms.Core/Button.cs
# Xamarin.Forms.Core/IImageElement.cs
# Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootHeader.cs
shane [Sat, 23 Nov 2019 04:05:36 +0000 (21:05 -0700)]
Merge branch '4.3.0' into 4.4.0
# Conflicts:
# Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootHeader.cs
Andrei [Sat, 23 Nov 2019 01:09:32 +0000 (04:09 +0300)]
Added IndicatorsView (#7465)
* Added IndicatorsView
* removed static ctor
* refused plural in naming
* opened ItemsSource property
* followed code convention
* renamed IndicatorView (removed plural)
* made Color.Default as initial value
* updated IndicatorSize initial value
* Added IndicatorViewExtensions
* naming changes
* fix build
* small cleanup
* refactored control to templatedView
* added UIPageControl renderer for iOS
* moved extensions class to separate file
* removed useless private methods
* local vars name refactoring
* tapGesture naming update
* avoided linq
* code styling
* fixed default indicator colors for iOS
* added experimental flag
* [Core]Update api naming for IndicatorView
* Update IndicatorView.cs
* [Core] Add forms visual
* Revert "[Core] Add forms visual"
This reverts commit
380f36684ebf1d90ce8df074c13f70f8549ba8db.
* Revert "Revert "[Core] Add forms visual""
This reverts commit
6619e9e758970de3c11672ed2fb181dc37fe6ad0.
* [Gallery]Revert changes to gallery
* [Android] Export default renderer for FormsVisual
* [iOS] Handle FormsVisual for IndicatorView
* [iOS] Update Position from native renderer
* [iOS] IndicatorVIewRendederer updates and dispose
* [Controls] Fix merge
* Added IndicatorView Core Gallery sample
* Add IndicatorSample
* Update Xamarin.Forms.Controls.csproj
* [Core] Fix FormsVisual check
* [iOS] Fix FormsVisual check
* [Controls] Fix Indicator Gallery sample
* [Core] Cleanup IndicatorView
* [Core]Fix toogle between template and shapes on FormsVisual
* [Controls] Fix indicators samples
* [Controls] Fix IndicatorTemplate
* [Core] Add ItemsSourceBy xaml option
* [iOS,Android,Core] Add IndicatorStacklayout
* [Android] Remove extra renderer for FormsVisual
* [Controls] Remove Visual from Indicator sample
* [Core, iOS, Android] Fix bug on IndcatorView
* - remove forms visual
* - remove extra shared
* - remove forms visual
* - remove disposable
* - remove renderer from tizen
Javier Suárez Ruiz [Sat, 23 Nov 2019 00:47:01 +0000 (01:47 +0100)]
SwipeView (#7603)
* Implemented SwipeView Spec
* Fixed close SwipeView when scrolling ScrollView in iOS
* Removed unnecessary SwipeItemInvokedEventArgs
* Separate ISwipeItem in a new file
* Changed BaseSwipeEventArgs to be abstract
* Changed SwipeView SwipeItems properties to use OneWay BindingMode
* SwipeDirectionHelpers is now no EditorBrowsable
* Removed unnecessary ContextItem
* Changed SwipeItems base type from BO to Element
* Added defaultValueCreator for SwipeItems (and new sample)
* Changes in UWP SwipeViewRenderer to change some SwipeItems validations
* Renamed CustomSwipeItem to SwipeItemView
Added Close method
Added new SwipeView sample in Core Gallery
Propagate BindingContext from SwipeView to SwipeItems
Fixed bug in Android where occasionally was not rendering the SwipeItem (BindableLayout)
* Moved command execution from the renderers to the abstraction
* Implemented Close method on UWP
Fixed issue to notify SwipeItems changes (add/remove) on UWP
Implemented Uri IconSource (fix SwipeItem using an Url on UWP)
* Updated CustomSwipeItem samples
* Fixed issue on Android (not rendering SwipeItem occasionally)
* Avoid use MessagingCenter to close the SwipeView when scrolling
* Added new Core Gallery sample using custom size SwipeItems
Fixed icon position on Android with big SwipeItems
Fixed custom SwipeItem size issue
* Fixed vertical swipe threshold calc
* Created ISwipeViewController
Moved SwipeItemView to a new class
Moved SwipeEventArgs to a new class
Changes in touch events in Android to have the same behavior as in Android
* Unsubscribe CollectionChanged from the OldElement on UWP renderer
* Allow open the swipeView if the width of the SwipeItems exceeds the width of the SwipeView
Fixed Android SwipeItem icon position calc issue
* Updated SwipeItems to use ISwipeViewController
* Fixed typo
* Fixed typo
* - remove EditorBrowsable
* Changed SwipeTransitionMode enum values
* - fix samsung fussiness
* - fix compile error for UAP
Shane Neuville [Fri, 22 Nov 2019 21:06:14 +0000 (14:06 -0700)]
fix threadpool when compiling for 14393 (#8628)
Chase Marsh [Fri, 22 Nov 2019 19:20:23 +0000 (13:20 -0600)]
Fix 6693 - [Bug] [WPF] ViewRenderer does not work properly with FrameworkElement derived native controls (#8357)
* Resolved merge conflict
* Added if APP compiler directive around InitializeComponent
* Removed LangVersion from WPF csproj so that build server will use the appropriate C# version.
Fixes #6693
Jiarui Guo [Fri, 22 Nov 2019 16:57:21 +0000 (08:57 -0800)]
#3533 Bring back uap10.0/netstandard1.4 support (#7079) fixes #3533
* target netstandard 1.4 for supporting rs2
* multi targeting
* initial tests
* - set a couple libraries to NS1.0
* - ns1.4
* - fix gallery project
* - fix min targets
* - fix target
* - remove sdk
* - buildControlsPath
* - nuget restore
* - controls path
* - uwp version
* - add generic
* - fix xbf
* - add tuple nuget
* - set max target to 16299
* - proj fixes
Gerald Versluis [Fri, 22 Nov 2019 14:51:22 +0000 (15:51 +0100)]
Update LabelRenderer.cs (#8571) fixes #7019
Gerald Versluis [Fri, 22 Nov 2019 03:04:10 +0000 (04:04 +0100)]
[UWP] Fix MDP Button "Padding" issue (#8610)
* Update MasterDetailControlStyle.xaml
* Added comments
* Update MasterDetailControlStyle.xaml
Stephane Delcroix [Fri, 22 Nov 2019 00:25:32 +0000 (01:25 +0100)]
[C] avoid calling ChangeVisualState twice (#8381)
Todd [Fri, 22 Nov 2019 00:22:09 +0000 (18:22 -0600)]
Fix to double escaping. (#8473)
fixes #4880
melimion [Fri, 22 Nov 2019 00:21:51 +0000 (03:21 +0300)]
WPF Implement editor placeholder (#8504)
* Placeholder implemented
* PlaceholderColor added to EditorCoreGalleryPage
Peter Moore [Fri, 22 Nov 2019 00:21:33 +0000 (18:21 -0600)]
RelativeSource Binding Bug Fixes (Gh8450) (#8541)
* RelativeSource Binding Bug FIxes
(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes;
(2) fix incorrect interpretation of AncestorLevel;
(3) much more robust unit tests for RelativeSource ancestor-type binding (#4)
* Update Xamarin.Forms.Core.UnitTests/RelativeSourceBindingTests.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Fixes #8450
Brian Runck [Thu, 21 Nov 2019 23:49:05 +0000 (18:49 -0500)]
[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)
* iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command property binding on non-Xamarin.Forms.Command ICommand implementations
* Changes after code review
* - add ui test to android
E.Z. Hart [Thu, 21 Nov 2019 15:53:39 +0000 (08:53 -0700)]
Remove ItemSizingStrategy from CarouselView (#8588)
* Move ItemSizingStrategy
* Fix tests
* Fix Android
* Fix Tizen
* Fix iOS
Shane Neuville [Thu, 21 Nov 2019 15:33:05 +0000 (08:33 -0700)]
[iOS] Fix top tab highlighting (#8599)
* Let UICollectionViewCell handle state itself (#7884)
Fixes #7416
* [iOS] Fix top tab highlighting
melimion [Thu, 21 Nov 2019 15:22:40 +0000 (18:22 +0300)]
Fix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility=WhenEditing (#8429)
* repro
* fix
* set _clearBtn to null in Dispose
* comment removed
Shane Neuville [Thu, 21 Nov 2019 06:02:30 +0000 (23:02 -0700)]
slow down gesture scroll for ui test and let it retry (#8591)
Shane Neuville [Thu, 21 Nov 2019 05:52:52 +0000 (22:52 -0700)]
Gif Animation Support (#7330)
* Add image animation API.
* Add animated image tests.
* Add animated image UWP implementation.
* Add animated image IOS implementation.
* Add animated image Android implementation.
Also include GIF image parser base class + android parser sub class.
* Add animation finished playing event to Android/IOS for image.
* Add fallback when loading none GIF as animation image.
* Adding a couple of additional tests for animated images.
* Adjusting image animation support based on PR feedback.
* Add support to reload as animated image on StartAnimation call.
* Add UITest and activity indicator when loading from source for Issue1704.
* Reduce number of temporary bitmaps when scaling.
* Implemented review feedback.
* Animation problems related to Android API level 19 and earlier
due to a couple of bugs and changed behavior in AnimationDrawable class.
Implemented a couple of fixes and workaround related to these bugs, fixing
the animation issues on devices before Android Lollipop.
* Moved a couple of methods implemented in FormsAnimationDrawable into an
interface that is used to hide implementation details. Enables possibility
to factor different implementations of animation support going forward.
* Fixed review feedback and comments.
* Notify IOS to redraw control when changing animation layer.
* - android rebase fixes
* - first set of iOS changes for gifs
* - uwp Gif changes
* - clean up android gif code and enable gif for ImageButtons
* - cleanup iOS gif implementation
* - fix imagebutton and other sources
* - add imagebutton to tests
* - getting rid of start/stop and just using IsAnimationPlaying
* - image button
* - adding animation handler for android
* - replace gifs
* - fix rebase issues
* Added gif samples in Core Gallery
* Updated gif Core Gallery sample
* Fixed UWP gif samples path
* - remove auto play
- fix uwp so it plays correctly on load
* Added support to Url gifs on Android
* - fix rebase
* - fix NRE and iOS repeat
* - fix android loop counter
* - fix animation stopped on ios
* - fix removed ImageHandler interface Android
* - add top margin so ui tests can click button
Shane Neuville [Wed, 20 Nov 2019 11:51:30 +0000 (04:51 -0700)]
Shell Navigation Bar Has Shadow property (#8408)
* add shadow api for shell nav bar
* - ios fixes
* - ios fixes
* - name fix android and simplify types on ios
* - change to listener
* - cleanup
* - remove toolbar
* - fix ios to propagate nav bar on page push
* - fix android crash
E.Z. Hart [Tue, 19 Nov 2019 19:19:14 +0000 (12:19 -0700)]
Fix NRE on iOS 10 when navigating away from a page with a grouped CollectionView (#8496)
Shane Neuville [Tue, 19 Nov 2019 14:19:57 +0000 (07:19 -0700)]
Expose top tab creation methods (#8441) fixes #7808 fixes #8428
Gerald Versluis [Tue, 19 Nov 2019 11:05:18 +0000 (12:05 +0100)]
Update MacDeviceInfo.cs (#8561) fixes #8559
Javier Suárez Ruiz [Tue, 19 Nov 2019 10:24:53 +0000 (11:24 +0100)]
Fix crash using the CarouselView and EmptyView (#8430)
Felipe Baltazar [Tue, 19 Nov 2019 10:09:16 +0000 (07:09 -0300)]
Fix Bug 7823 - Frame corner radius (#8032)
* Fix Bug 7823
* Code review
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Code review ♻
* Code review ♻
* revert
7f93346a3d1d3261d05843084d1934d5201b0c75
* Revert
d9ad8f31507e8373a2db1f4b9eb737b256dcf6ad
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* rebase 4.4.0 fixes
* fix rebase 4.4.0
* fix rebase 4.4.0
* Fix test 7823
* Fixes api 19 test
Shane Neuville [Tue, 19 Nov 2019 01:32:14 +0000 (18:32 -0700)]
Merge branch '4.4.0'
Shane Neuville [Tue, 19 Nov 2019 01:31:25 +0000 (18:31 -0700)]
Merge branch '4.3.0' into 4.4.0
# Conflicts:
# Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
# build.cake
Alexander Olshansky [Tue, 19 Nov 2019 01:03:22 +0000 (03:03 +0200)]
Fix 7709 | Fix showing keyboard when changing placeholder in entry focused event (#7984)
* Fixes 7709
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7709.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update code style of conditional parameter
Shane Neuville [Tue, 19 Nov 2019 00:58:28 +0000 (17:58 -0700)]
Merge branch '4.2.0' into 4.3.0
# Conflicts:
# azure-pipelines.yml
Shane Neuville [Tue, 19 Nov 2019 00:54:56 +0000 (17:54 -0700)]
Add export method for transform string on UI Tests (#8532)
* export transform string
* - add missing renderers to performance tracker
* Update Xamarin.Forms.ControlGallery.iOS/PerformanceTrackerRenderer.cs
Javier Suárez Ruiz [Mon, 18 Nov 2019 19:24:54 +0000 (20:24 +0100)]
[UWP] Implement CurrentItem on CarouselView (#7590)
* Implement CurrentItem on CarouselView UWP
* Removed unnecesary VerticalListItemsPanel (Carousel)
Shane Neuville [Mon, 18 Nov 2019 17:10:14 +0000 (10:10 -0700)]
Implement FormsStack and FormsQueue internally for VS 2017 Compatibility (#8403)
* FormsStack and FormsQueue for VS 2017 Compat
* - sync stable vs mac versions
* - mono version
* - gtk
* - fix mono provision
* Update Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
* - remove uwp changes
* - add 2019 back in
* Update azure-pipelines.yml
Glenn Versweyveld [Mon, 18 Nov 2019 14:38:35 +0000 (15:38 +0100)]
Keep tab image collapsed if no datasource is available (#8050) fixes #6757
Stephane Delcroix [Mon, 18 Nov 2019 10:40:11 +0000 (11:40 +0100)]
Merge branch '4.4.0'
Stephane Delcroix [Mon, 18 Nov 2019 10:39:51 +0000 (11:39 +0100)]
Merge branch '4.3.0' into 4.4.0
Stephane Delcroix [Mon, 18 Nov 2019 10:38:36 +0000 (11:38 +0100)]
Merge branch '4.2.0' into 4.3.0
E.Z. Hart [Mon, 18 Nov 2019 09:19:50 +0000 (02:19 -0700)]
Disable packager for CollectionView on UWP (#8404)
* Reproduce issue 8366
* Clean up old comments
* Turn off packaging for the CollectionView on UWP
Fixes #8366
Jon Robinson Levy [Fri, 15 Nov 2019 13:54:35 +0000 (14:54 +0100)]
Fix 7361 - [UWP] Stepper buttons not becoming enabled again, when disabled more than once. (#8191)
* Adding test class Issue7361
* Adding checks to prevent PseudoDisable from being called once _plus- or _minusStateCache is set.
* Improving Instructions in Issue7361 test page.
Rui Marinho [Wed, 13 Nov 2019 23:44:47 +0000 (23:44 +0000)]
[Build] Update version numbers to ship from yaml (#8437)
* Update version numbers
* Update Version.targets
* Fix variables
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
Stephane Delcroix [Wed, 13 Nov 2019 15:09:43 +0000 (16:09 +0100)]
[X] FontSizeConverter on FontImageExtension (#8375)
fixes https://github.com/xamarin/Xamarin.Forms/pull/7887#issuecomment-
549437276
Kangho Hur [Tue, 12 Nov 2019 11:04:43 +0000 (03:04 -0800)]
[Tizen] Enables SwipeGestureHandler (#8456)
Philippe Leybaert [Mon, 11 Nov 2019 18:50:53 +0000 (12:50 -0600)]
Reset transformation properly on UWP (#7385) (#7386)
Akihiko Odaki [Mon, 11 Nov 2019 15:30:19 +0000 (00:30 +0900)]
Add a missing '}' in Xamarin.Forms.Xaml.UnitTests/Issues/Bz24485.xaml (#8448)
Shane Neuville [Mon, 11 Nov 2019 14:42:46 +0000 (07:42 -0700)]
Revert "Return all visual elements needed (#8100) fixes #7027" (#8453)
This reverts commit
da769d8c8d4c87db9368d7d8952e8ab0db318a69.
Shane Neuville [Fri, 8 Nov 2019 20:38:21 +0000 (13:38 -0700)]
Merge branch '4.4.0'
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
# Xamarin.Forms.Platform.UAP/Resources.xaml
Shane Neuville [Fri, 8 Nov 2019 20:33:32 +0000 (13:33 -0700)]
Merge branch '4.3.0' into 4.4.0
E.Z. Hart [Fri, 8 Nov 2019 19:44:08 +0000 (12:44 -0700)]
Make character spacing work for UWP Picker without breaking ItemsSource (#8356)
* Make character spacing work for UWP Picker without breaking ItemsSource
Fixes #8177
* Add test instructions
Pavel Yakovlev [Thu, 7 Nov 2019 21:48:27 +0000 (13:48 -0800)]
[previewer] removed empty ItemsSourse attribute from toolbox snippets (#8379)
Glenn Versweyveld [Thu, 7 Nov 2019 12:22:10 +0000 (13:22 +0100)]
Return all visual elements needed (#8100) fixes #7027
* Return all visual elements needed
Fixes #7027
* Drop the private
Force of habit
* Added testpage
#7027
* Tidy up
VladislavAntonyuk [Thu, 7 Nov 2019 09:55:27 +0000 (11:55 +0200)]
[Bug] WPF ListViewRenderer fails on item tapped with empty item source #7995 (#8223)
* [Bug] WPF ListViewRenderer fails on item tapped with empty item source #7995
* Check ItemSource for null
Gerald Versluis [Wed, 6 Nov 2019 14:48:39 +0000 (15:48 +0100)]
[C] Added ability to predefine value to prompt (#8362) fixes #8346
* Added ability to predefine value
* Prevent ABI break
* Update Issue6713.cs
Shane Neuville [Wed, 6 Nov 2019 10:28:01 +0000 (03:28 -0700)]
Ensure that ParentSet fires before OnAppearing (#8242)
Rui Marinho [Wed, 6 Nov 2019 10:12:42 +0000 (10:12 +0000)]
[Android] Fix API usage on Android19 (#8378)
* [Android] Check api usage for set color on image drawable
* [Android] Add missing brackets
melimion [Tue, 5 Nov 2019 22:37:43 +0000 (01:37 +0300)]
Fix Button.CornerRadius doesn't work on WPF (#7895)
* fix
* test added
* button without corner radius added to test
fixes #6556
Shane Neuville [Tue, 5 Nov 2019 19:08:36 +0000 (12:08 -0700)]
Fix corner clipping on ImageButton and Button (FR) (#7723)
* Clip Button/ImageButton to corner radius
* - add ui test
* - fix warnings
Felipe Baltazar [Tue, 5 Nov 2019 16:33:28 +0000 (13:33 -0300)]
Fix 7181 | [Bug] Cannot update ToolbarItem text and icon (#8254) fixes #7181
* Created handler for Toolbaritem.OnPropertyChanged
* Code review ♻
* Code review ♻
Javier Suárez Ruiz [Tue, 5 Nov 2019 14:56:17 +0000 (15:56 +0100)]
[Android] Fix Switch Thumb wrong color (#7777) fixes #7249
Oliver Brown [Tue, 5 Nov 2019 14:53:33 +0000 (14:53 +0000)]
[macOS] Add character spacing to button and label (#8206)
* Add character spacing extension method to macOS
* Add character spacing to label on macOS.
* Add character spacing for button on macOS
* Add color pickers to character spacing gallery to check everything works with colors.
* Make character spacing and text color work properly together on button and label on macOS.
Joe Manke [Tue, 5 Nov 2019 14:52:34 +0000 (08:52 -0600)]
[Android Maps] Check for location permissions when IsShowingUser=true (#7282) fixes #4691
* Check for location permissions when IsShowingUser=true instead of crashing
* Fix courseLocationPermission -> coarseLocationPermission
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Gerald Versluis [Tue, 5 Nov 2019 09:53:34 +0000 (10:53 +0100)]
Added defensive code (#8324)
Mohamed CHOUCHANE [Tue, 5 Nov 2019 00:39:17 +0000 (01:39 +0100)]
[WPF] View doesn't render when set IsClippedToBounds to true (#8195)
fixes #5910
fixes #8087
Gerald Versluis [Mon, 4 Nov 2019 23:09:26 +0000 (00:09 +0100)]
Update FrameRenderer.cs (#7871)
fixes #7667
Oliver Brown [Mon, 4 Nov 2019 22:18:51 +0000 (22:18 +0000)]
[iOS] [macOS] Fix HTML string encoding (#8265)
* Improve HTML tests.
* Load HTML as UTF-8. Fix 8156
* Separate document attributes into a virtual method
fixes #8156
E.Z. Hart [Mon, 4 Nov 2019 21:21:59 +0000 (14:21 -0700)]
Add missing null check on ItemsSource when IsGrouped is true; fixes #8269 (#8273)
Gerald Versluis [Mon, 4 Nov 2019 20:37:28 +0000 (21:37 +0100)]
Fix UWP Toolbar icons (#8147)
* Added demo and fix
* Update Issue7505.cs
* Update Platform.cs
* Fixed AsyncValue
CleanCodeDeveloper [Mon, 4 Nov 2019 20:14:04 +0000 (21:14 +0100)]
[UWP] Enables usage of font image source for bottom bar tabs (#8354)
* Update StoreShell.xaml
Demonstrates the problem, FontImageIcon is not displayed in Bottom Tab Bar
* Update ShellItemRenderer.cs
Enables usage of FontImageSource for Tabs in Bottom Bar
Javier Suárez Ruiz [Mon, 4 Nov 2019 20:08:43 +0000 (21:08 +0100)]
Fix crash using an object that implements IEnumerable and INotifyCollectionChanged (#8283) fixes #8200
Felipe Baltazar [Mon, 4 Nov 2019 20:04:22 +0000 (17:04 -0300)]
Fixe issue 5367 | Crash assigning excessively long text to Editor with MaxLength property set (#8052) fixes #5367
* Fixe issue 5367 🐛
* Code review
* code review
Rui Marinho [Mon, 4 Nov 2019 13:28:16 +0000 (13:28 +0000)]
Merge branch '4.4.0'
Rui Marinho [Mon, 4 Nov 2019 13:26:25 +0000 (13:26 +0000)]
Merge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 4 Nov 2019 13:10:00 +0000 (13:10 +0000)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Fri, 1 Nov 2019 20:58:47 +0000 (20:58 +0000)]
[Android] Fix API21 usage on shell (#8335)
* [Android] Fix API21 usage
* [Android] Remove extra usings
E.Z. Hart [Fri, 1 Nov 2019 20:20:32 +0000 (14:20 -0600)]
Prevent UWP error/crash when updating binding off the main thread; fixes #8167 (#8311)
Konrad Müller [Fri, 1 Nov 2019 18:50:32 +0000 (19:50 +0100)]
[iOS] Fix scroll to does not scroll to end (#8241)
* Fix scroll to does not scroll to end
* Remove private modifier
kingces95 [Thu, 31 Oct 2019 17:10:59 +0000 (07:10 -1000)]
multithreaded droid os calls during startup (#8245)
Rui Marinho [Thu, 31 Oct 2019 17:06:42 +0000 (17:06 +0000)]
[Build] Clean repos, update vs image (#8339)
Glenn Versweyveld [Thu, 31 Oct 2019 10:37:35 +0000 (11:37 +0100)]
Check for ValueType items to perform equals (#8299)
Johann Weiher [Thu, 31 Oct 2019 10:35:09 +0000 (11:35 +0100)]
macOS: Fixed IsPresented PopOver (#8312)
#3149
Samantha Houts [Thu, 31 Oct 2019 00:31:13 +0000 (17:31 -0700)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#8096)