Tarun Pothulapati [Fri, 5 May 2017 17:49:59 +0000 (17:49 +0000)]
Removed Dictionary<TKey, TValue>.GetValueOrDefault Methods (#11388)
* Removed Dictionary.GetValueOrDefault Methods and the method calls in Rtpe.cs,CustomAttribute.cs
* Replaced the Dictionary.GetValueOrDefault Methods
* Used !s_pca.ContainsKey(caType) instead of s_pca.ContainsKey(caType) == false
Drew Scoggins [Fri, 5 May 2017 17:39:15 +0000 (02:39 +0900)]
Add lean run support to CoreCLR perf (#11347)
In the xunit performance harness we added support for a "lean" run which
only runs the stopwatch to collect duration and none of the ETW
providers are turned on. This adds support in the automation for doing
runs that use this lean feature.
Stephen Toub [Fri, 5 May 2017 16:35:21 +0000 (12:35 -0400)]
Merge pull request #11411 from justinvp/delegate_opequality
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks
dotnet bot [Fri, 5 May 2017 15:19:07 +0000 (08:19 -0700)]
Update CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (#11384)
sergey ignatov [Fri, 5 May 2017 15:12:07 +0000 (18:12 +0300)]
Fixed issue #11383 (#11385)
Bruce Forstall [Fri, 5 May 2017 14:24:49 +0000 (07:24 -0700)]
Merge pull request #11361 from mikedn/imp-strlen-except
Add missing GTF_EXCEPT when importing string length intrinsic
Mike McLaughlin [Fri, 5 May 2017 05:48:21 +0000 (22:48 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (#11395) again (#11415)
There was a simple msbuild property.
Issue #11381
Mike Danes [Wed, 3 May 2017 05:35:13 +0000 (08:35 +0300)]
Add missing GTF_EXCEPT when importing string length intrinsic
Jan Kotas [Fri, 5 May 2017 04:12:20 +0000 (21:12 -0700)]
Move UnmanagedMemoryStream and related types to shared CoreLib partition (#11409)
Bruce Forstall [Fri, 5 May 2017 03:55:26 +0000 (20:55 -0700)]
Add new test for COMPlus_TailcallStress=1 bug, currently disabled (#11410)
Add new test for COMPlus_TailcallStress=1 bug, currently disabled
William Godbe [Fri, 5 May 2017 02:54:53 +0000 (19:54 -0700)]
Merge pull request #11401 from wtgodbe/DeleteNis
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
Karel Zikmund [Thu, 4 May 2017 23:23:21 +0000 (16:23 -0700)]
Update contributing-workflow.md
Bruce Forstall [Thu, 4 May 2017 23:07:26 +0000 (16:07 -0700)]
Refactor arm32/arm64 per-node codegen into functions (#11377)
These new functions can sometimes be shared, as they are identical or
virtually so.
In addition, the driver function genCodeForTreeNode() has been
made common.
wtgodbe [Thu, 4 May 2017 18:57:51 +0000 (11:57 -0700)]
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
Mike McLaughlin [Thu, 4 May 2017 22:19:57 +0000 (15:19 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (#11395)
Issue #11381
Carol Eidt [Thu, 4 May 2017 22:09:55 +0000 (15:09 -0700)]
Update first-class-structs.md
Carol Eidt [Thu, 4 May 2017 22:07:37 +0000 (15:07 -0700)]
Update first-class-structs.md
Justin Van Patten [Thu, 4 May 2017 22:05:38 +0000 (15:05 -0700)]
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks
The reference equality check is more efficient than
Delegate.op_Equality.
Ian Hays [Thu, 4 May 2017 22:01:16 +0000 (15:01 -0700)]
Remove UnmanagedMemoryStream overflow checks. (#11376)
* Remove UnmanagedMemoryStream overflow checks.
* Catch negative UMS PositionPointers
* Switch UMS PositionPointer exception order
Jan Kotas [Thu, 4 May 2017 19:37:39 +0000 (12:37 -0700)]
Fix ProjectN build break (dotnet/corert#3517)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Viktor Hofer [Thu, 4 May 2017 21:11:33 +0000 (23:11 +0200)]
System.IO.Path.GetPathRoot string.Empty or whitespace character string should throw ArgumentException (#11387)
* GetPathRoot string.Empty and string whitespace throws ArgumentException
* throw in next line
* Refined method description
* Unix impl adjusted
* Indentation
* pr feedback
* Delete Path.Unix.cs
* Adding param to ArgumentException
Jan Vorlicek [Thu, 4 May 2017 20:19:53 +0000 (13:19 -0700)]
Reenable MapViewOfFile PAL test1 (#11393)
This change reenables the test that was having problems on systems when the /tmp
is created on tmpfs file system which doesn't support direct access (unbuffered).
The fix is to explicitly use /var/tmp instead (and /data/local/tmp/ on Android).
Mike McLaughlin [Thu, 4 May 2017 17:58:58 +0000 (10:58 -0700)]
Remove stale section on managed debugging. (#11392)
Carol Eidt [Thu, 4 May 2017 17:49:09 +0000 (10:49 -0700)]
Merge pull request #11370 from CarolEidt/ILOffsetDump
Dump GT_IL_OFFSET value in hex
Tom Deseyn [Thu, 4 May 2017 15:13:22 +0000 (17:13 +0200)]
Document Linux libnuma dependency (#11367)
Davis Goodin [Thu, 4 May 2017 14:17:24 +0000 (09:17 -0500)]
Disable symbol package MyGet publish on release/* (#11372)
Jan Kotas [Thu, 4 May 2017 03:35:14 +0000 (20:35 -0700)]
Delete moved file
Jan Kotas [Thu, 4 May 2017 01:58:57 +0000 (18:58 -0700)]
Merge pull request dotnet/corert#3506 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet bot [Thu, 4 May 2017 04:58:52 +0000 (21:58 -0700)]
Update CoreClr, CoreFx to preview2-25303-03, preview2-25303-04, respectively (#11354)
Mike McLaughlin [Thu, 4 May 2017 00:17:22 +0000 (17:17 -0700)]
Createdump fixes and cleanup. (#11368)
Fixed "with heap" option to actually include all the heaps. The way /proc/$pid/maps
was parsed missed most of the RW data/heap regions.
Added -u/--full full core dump options.
Removed the useless m_memStatus variable in enummem.cpp.
Steve MacLean [Wed, 3 May 2017 22:52:42 +0000 (18:52 -0400)]
[Arm64/Unix] Revise JIT_MemSet (#11217)
* [Arm64/Unix] Revise JIT_MemSet
Use DC ZVA
Use stp
Correctly handle short set lengths
Simplify code & pseudo code
Use uint*_t to make pseudo code more readable
Vladimir Sadov [Wed, 3 May 2017 22:22:32 +0000 (15:22 -0700)]
Adding System\Runtime\CompilerServices\IsByRefLikeAttribute type (#11369)
described in: https://github.com/dotnet/corefx/issues/19212
Russ Keldorph [Sun, 30 Apr 2017 13:17:30 +0000 (06:17 -0700)]
Fix some static analysis warnings
Most fixes are just addressing the use of (signed) enum-typed variables
as array indices. Casting to unsigned allows us to cheaply include the
lower bound checks in the existing upper bound checks. I would prefer
to force the underlying types of enumerations to be unsigned, but that
is a relatively new C++ feature and could have broader consequences than
I want to risk at this point.
The one other fix to asmparse.cpp just suppresses a warning that, while
technically valid, is not causing a real problem. Perhaps this will get
better if/when #2305 is addressed.
Carol Eidt [Wed, 3 May 2017 21:01:44 +0000 (14:01 -0700)]
Dump GT_IL_OFFSET value in hex
Jan Vorlicek [Wed, 3 May 2017 18:57:04 +0000 (11:57 -0700)]
Remove COMCoverage::nativeCoverBlock (#11364)
Remove this unused function and the corresponding references in
ecalllist.h
Steve MacLean [Wed, 3 May 2017 18:24:21 +0000 (14:24 -0400)]
Fix Binder NI to IL fallback (#11341)
* Fix Binder NI to IL fallback
Always try NI first
* Fix Windows warning as error
* [Arm64/Unix] Revise PR per feedback
* More cleanup
Gaurav Khanna [Wed, 3 May 2017 17:50:34 +0000 (10:50 -0700)]
Place precompiled SPC.dll in native assets folder. (#11359)
Place precompiled SPC.dll in native assets folder.
Gaurav Khanna [Wed, 3 May 2017 15:35:56 +0000 (08:35 -0700)]
Fix load from (#11342)
* Add LoadFrom dependencies to the LoadFrom list
* Add a comment
Atsushi Kanamori [Wed, 3 May 2017 13:40:42 +0000 (06:40 -0700)]
Implement Type.IsTypeDefinition property on CoreCLR (#11355)
This api was just approved.
https://github.com/dotnet/corefx/issues/17345
Russ Keldorph [Wed, 3 May 2017 03:59:24 +0000 (20:59 -0700)]
Revert "[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest"
This reverts commit
2ec8b5c2cc6d68ca02eb743e679997a8f11c90aa.
Drew Scoggins [Wed, 3 May 2017 07:08:18 +0000 (16:08 +0900)]
Merge pull request #11362 from DrewScoggins/FixSmoketest
Fix triggering of perf correctness runs
Drew Scoggins [Wed, 3 May 2017 06:55:33 +0000 (23:55 -0700)]
Fix triggering of perf correctness runs
When I made the change to have the correctness runs fire in a PR without
the trigger phrase I accidentally did it for all PR's not just for the
smoketest runs. This change fixes that.
Drew Scoggins [Wed, 3 May 2017 04:44:46 +0000 (13:44 +0900)]
Merge pull request #11180 from DrewScoggins/AddCorrectnessRuns
Add smoketest for performance tests
Drew Scoggins [Mon, 24 Apr 2017 18:36:27 +0000 (11:36 -0700)]
Add smoketest for performance tests
This adds a run that will fire on the set of Azure VMs and will only run
for one interation. This along with the changes to fail a performance
run if a test fails will allow us to start gating checkins on the
performance tests still running.
Eric StJohn [Tue, 2 May 2017 23:39:14 +0000 (16:39 -0700)]
Merge pull request #11340 from ericstj/fixCrossTargetFolder
Fix folder name for cross-targeting assets
Hyeongseok Oh [Wed, 26 Apr 2017 06:44:16 +0000 (15:44 +0900)]
[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest
- Copy tests.zip only from x86 Windows build for CI test
- Use x86 unittest instead of x64: 32bit architecture
John Bottenberg [Tue, 2 May 2017 20:54:52 +0000 (13:54 -0700)]
Enable Marshal.SecureStringToBSTR and Marshal.ZeroFreeBSTR on Unix (#11234)
William Godbe [Tue, 2 May 2017 20:34:51 +0000 (13:34 -0700)]
Merge pull request #11336 from wtgodbe/TestingOnLinux
Update Unix test instructions
wtgodbe [Tue, 2 May 2017 19:10:00 +0000 (12:10 -0700)]
Update Unix test instructions
Eric St. John [Tue, 2 May 2017 20:16:52 +0000 (13:16 -0700)]
Fix folder name for cross-targeting assets
Gaurav Khanna [Tue, 2 May 2017 20:14:01 +0000 (13:14 -0700)]
Enable LoadFrom to pickup assemblies next to requesting assembly (#11333)
* Enable LoadFrom to pickup assemblies from next to requestor
* Make early out explicit
Bruce Forstall [Tue, 2 May 2017 18:28:38 +0000 (11:28 -0700)]
Merge pull request #11329 from BruceForstall/RefactorArmCodegen
Refactor arm32/arm64 codegen
dotnet bot [Tue, 2 May 2017 18:21:36 +0000 (11:21 -0700)]
Update CoreFx to preview2-25302-03 (#11331)
Russ Keldorph [Mon, 1 May 2017 16:57:21 +0000 (09:57 -0700)]
Surgically remove unsupported tailcall cases
Rather than disabling tailcall tests entirely, surgically remove the
failing cases so the remaining cases can be enabled.
dotnet bot [Tue, 2 May 2017 14:23:21 +0000 (07:23 -0700)]
Update CoreClr, CoreFx to preview2-25302-02, preview2-25302-01, respectively (#11326)
Cyd Haselton [Tue, 2 May 2017 11:52:46 +0000 (06:52 -0500)]
Added missing icu headers for Android (#11325)
urename.h and ustring.h contain the u_stncpy and its definition.
If they are not in the list of icushim.h headers, Android build fails.
Bruce Forstall [Tue, 2 May 2017 06:52:12 +0000 (23:52 -0700)]
Fix assert
Aditya Mandaleeka [Tue, 2 May 2017 05:03:25 +0000 (22:03 -0700)]
Fix rgTail corruption in rare scavenging cases [Desktop port]. (#11327)
Jan Kotas [Tue, 2 May 2017 03:10:26 +0000 (20:10 -0700)]
Partial revert "Move a few more files to shared CoreLib partition" (#11328)
Revert change from Hashtable to Dictionary
Bruce Forstall [Tue, 2 May 2017 01:50:16 +0000 (18:50 -0700)]
Formatting
Bruce Forstall [Tue, 2 May 2017 01:49:13 +0000 (18:49 -0700)]
Refactor GT_NEG/GT_NOT
Bruce Forstall [Tue, 2 May 2017 01:35:27 +0000 (18:35 -0700)]
Refactor compares
Bruce Forstall [Tue, 2 May 2017 01:19:46 +0000 (18:19 -0700)]
Refactor GT_PUTARG_REG
Bruce Forstall [Tue, 2 May 2017 01:10:23 +0000 (18:10 -0700)]
Refactor GT_SWAP
Bruce Forstall [Tue, 2 May 2017 00:59:38 +0000 (17:59 -0700)]
Refactor GT_RETURNTRAP
Bruce Forstall [Tue, 2 May 2017 00:49:21 +0000 (17:49 -0700)]
Refactor GT_STOREIND
Bruce Forstall [Tue, 2 May 2017 00:32:15 +0000 (17:32 -0700)]
Refactor GT_LCL_VAR and GT_STORE_LCL_VAR
Bruce Forstall [Tue, 2 May 2017 00:06:55 +0000 (17:06 -0700)]
Refactor GT_STORE_LCL_FLD
Bruce Forstall [Mon, 1 May 2017 23:48:28 +0000 (16:48 -0700)]
Refactor ARM/ARM64 GT_LCL_FLD codegen
Wes Haggard [Mon, 1 May 2017 22:37:14 +0000 (15:37 -0700)]
Merge pull request #11323 from dotnet-bot/master-UpdateDependencies
Update CoreClr to preview2-25301-03 (master)
Bruce Forstall [Mon, 1 May 2017 21:12:19 +0000 (14:12 -0700)]
Merge pull request #11067 from sjsinju/model_kill_set
[WIP][RyuJIT/ARM32] Implement the model kill for CORINFO_HELP_ASSGN_BYREF helper
dotnet-bot [Mon, 1 May 2017 21:03:47 +0000 (21:03 +0000)]
Update CoreClr to preview2-25301-03
Pat Gavlin [Mon, 1 May 2017 19:31:25 +0000 (12:31 -0700)]
Merge pull request #11304 from pgavlin/GH11273
Fix #11273 by adjusting the fix for VSO 406163.
Jan Kotas [Sun, 16 Apr 2017 22:14:48 +0000 (15:14 -0700)]
Move a few more files to shared CoreLib partition
Hyung-Kyu Choi [Mon, 1 May 2017 19:00:01 +0000 (04:00 +0900)]
[ARM] Update rootfs for Tizen armel (#11202)
* [ARM] Update cross rootfs for armel Tizen
Update cross rootfs for armel Tizen
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
* [ARM] Update cmake file and CI for armel Tizen
Update CI and cmake file for armel Tizen, because rootfs for Tizen is updated.
And rootfs for Tizen is embedded in Docker image for CI as Ubuntu for arm does.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Davis Goodin [Mon, 1 May 2017 18:35:13 +0000 (13:35 -0500)]
Fix current publish build warnings (#11317)
* Make VSTS Drop metadata distinct
* Remove PublishLogs artifact publish: no matches
William Godbe [Mon, 1 May 2017 17:49:46 +0000 (10:49 -0700)]
Merge pull request #11309 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to preview2-25301-01, preview2-25301-02, respectively (master)
Jan Kotas [Sat, 29 Apr 2017 14:43:23 +0000 (07:43 -0700)]
Fetch secondary handle only if primary is non-null
The GC is not tracking the secondary handle once primary gets cleared.
Fixes #11270
Jan Kotas [Fri, 28 Apr 2017 01:28:34 +0000 (18:28 -0700)]
Avoid unnecessary out arguments in DependentHandle FCalls
Make the signatures closer to what they are in CoreRT
Pat Gavlin [Mon, 1 May 2017 17:21:28 +0000 (10:21 -0700)]
Merge pull request #11262 from pgavlin/NoCompatJit
Remove support for the x86 compat JIT from .NET Core.
Pat Gavlin [Mon, 1 May 2017 17:14:48 +0000 (10:14 -0700)]
Format code and fix a comment.
Davis Goodin [Mon, 1 May 2017 14:54:03 +0000 (09:54 -0500)]
Add symbol publish (index/archive) build leg (#11300)
* Add symbol publish (index/archive) build leg
* Use BuildType property name in symbol publish leg
Carol Eidt [Mon, 1 May 2017 14:47:50 +0000 (07:47 -0700)]
Merge pull request #11275 from CarolEidt/Fix11141
Avoid over-constrained delayed-use register case
dotnet-bot [Mon, 1 May 2017 14:10:46 +0000 (14:10 +0000)]
Update CoreClr, CoreFx to preview2-25301-01, preview2-25301-02, respectively
Jan Kotas [Mon, 1 May 2017 05:52:25 +0000 (22:52 -0700)]
Rename internal field of primitive type structs and make it private (#11312)
Reduce diffs with CoreRT and conform to coding conventions
Drew Scoggins [Sat, 29 Apr 2017 22:03:00 +0000 (07:03 +0900)]
Merge pull request #11297 from DrewScoggins/AddPerfRunInstr
Add instructions for running local perf tests
William Godbe [Sat, 29 Apr 2017 20:58:30 +0000 (13:58 -0700)]
Merge pull request #11272 from wtgodbe/CrossgenMove
Ensure we run the Crossgened test executable in R2R tests
Yi Zhang (CLR) [Sat, 29 Apr 2017 16:51:03 +0000 (09:51 -0700)]
Bring back Marshal.Read/Write overloads that takes object (#11251)
* Bring back desktop version of Marshal.Read/Write APIs that takes object and add a test
dotnet bot [Sat, 29 Apr 2017 06:08:49 +0000 (23:08 -0700)]
Update CoreClr to preview2-25229-01 (#11303)
William Godbe [Sat, 29 Apr 2017 01:54:48 +0000 (18:54 -0700)]
Update runtest.sh
Update if statement
Pat Gavlin [Fri, 28 Apr 2017 23:31:25 +0000 (16:31 -0700)]
Fix #11273 by adjusting the fix for VSO 406163.
Issue #11273 revealed an issue with the fix for VSO 406163: as of today,
the compiler models the incoming exception object in a handler by
looking for `GT_CATCH_ARG` in the first block of a handler and if found
marking the register that contains the exception object as holding a GC
pointer. Unfortunately, this breaks down under the transform that the
original fix (#11134) was performing for single-block filters. That
transformation was from this:
```
filter start: BBN (BBJ_EHFILTERRET)
```
to this:
```
filter start: BBN + 1 (BBJ_ALWAYS -> BBN)
BBN + 2 (jumpKind)
BBN (BBJ_EHFILTERRET)
```
After this transform, `BBN` still contains the `GT_CATCH_ARG`, but the
register containing the exception object must be live through `BBN + 1`
as well as live in to `BBN`.
There are a number of possible solutions to this problem (e.g. modeling
the liveness of the exception object in some fashion or splitting the
single-block filter either after the catch arg or before the filter
ret), but many of them are complicated by the fact that this
transformation needs to operate on both HIR and LIR and must be be able
to run in a variety of locations, including after registers have been
allocated. Instead, this change takes the approach of ensuring that no
single-block filter regions exist on platforms that target the JIT32 GC
encoder by inserting a spill of the exception object to a local var in
its own block at the start of a filter.
wtgodbe [Thu, 27 Apr 2017 22:40:23 +0000 (15:40 -0700)]
Ensure we run the Crossgened test executable in R2R tests
Gaurav Khanna [Fri, 28 Apr 2017 23:06:54 +0000 (16:06 -0700)]
Correctly enumerate loaded assemblies in AppDomain (#11294)
* Correctly enumerate loaded assemblies in AppDomain
* Remove unrequired attribute
Drew Scoggins [Fri, 28 Apr 2017 22:56:36 +0000 (15:56 -0700)]
Fix typo
Drew Scoggins [Fri, 28 Apr 2017 18:45:01 +0000 (11:45 -0700)]
Add instructions for running local perf tests
dotnet bot [Fri, 28 Apr 2017 19:50:38 +0000 (12:50 -0700)]
Update CoreClr, CoreFx to preview2-25228-02, preview2-25228-02, respectively (#11283)
Jonghyun Park [Fri, 28 Apr 2017 18:08:36 +0000 (03:08 +0900)]
Enable interpreter build (#11252)
Enable FEATURE_INTERPRETER build
Brian Sullivan [Fri, 28 Apr 2017 17:57:50 +0000 (10:57 -0700)]
Merge pull request #11268 from sdmaclea/PR-ARM64-two-gc-attributes
[Arm64] Support two GC attributes in pair forms
Carol Eidt [Thu, 27 Apr 2017 22:28:17 +0000 (15:28 -0700)]
Avoid over-constrained delayed-use register case
When a node has a delayed-use register (either due to an RMW def or due to an internalRegDelayFree),
if its result has a fixed-use, don't propagate the register constraint to the def, because there's
no associated fixed-reference to ensure that it will not be used by the delay-free register.
Fix #11141
Yi Zhang (CLR) [Fri, 28 Apr 2017 15:41:29 +0000 (08:41 -0700)]
Fix R2R issue with virtual method resolving to non-generic base (#11289)