Travis Reitter [Mon, 17 Jan 2011 19:37:55 +0000 (11:37 -0800)]
Suppress Telepathy logger warning for tests.
Fixes bgo#639742 - Logger service unavailable in make check
Travis Reitter [Mon, 17 Jan 2011 20:03:16 +0000 (12:03 -0800)]
Only spew D-Bus info during tests if >= 1
Travis Reitter [Mon, 17 Jan 2011 19:42:11 +0000 (11:42 -0800)]
Silence generally-useless Tp test message.
Philip Withnall [Mon, 17 Jan 2011 22:02:55 +0000 (22:02 +0000)]
Don't add a duplicate candidate individual if one matches by user and IID
If an individual matches a persona being aggregated both by them both being
the user, and by IID match, don't list the individual as a candidate
individual twice (which would cause their personas to appear twice in the
final individual).
Eitan Isaacson [Wed, 12 Jan 2011 20:51:12 +0000 (22:51 +0200)]
Added valgrind support in make check.
https://bugzilla.gnome.org/show_bug.cgi?id=639366
Travis Reitter [Fri, 14 Jan 2011 17:47:01 +0000 (09:47 -0800)]
Add policy for keeping the build healthy.
Travis Reitter [Fri, 14 Jan 2011 00:04:21 +0000 (16:04 -0800)]
Finish catching BackendStore up to our coding style.
Travis Reitter [Thu, 13 Jan 2011 01:27:37 +0000 (17:27 -0800)]
Fix dependencies for internal g-i files.
As it was, these libraries wouldn't be re-created after a maintainer-clean (or
on the very first build).
Travis Reitter [Wed, 12 Jan 2011 23:55:57 +0000 (15:55 -0800)]
Also print a stack trace upon a failed test assertion.
Travis Reitter [Wed, 12 Jan 2011 19:44:07 +0000 (11:44 -0800)]
Don't double-list files in MAINTAINERCLEANFILES.
Travis Reitter [Wed, 12 Jan 2011 01:26:01 +0000 (17:26 -0800)]
Distribute sources for generated files.
This un-breaks distcheck by ensuring the generated files don't stick around in
_build after the final distclean.
This fulfills the requirements laid out in the Automake manual page:
http://www.gnu.org/software/hello/manual/automake/distcleancheck.html
Travis Reitter [Wed, 12 Jan 2011 00:30:56 +0000 (16:30 -0800)]
Define the Telepathy BACKEND_NAME directly.
Properly distributing the backend.mk file proved more difficult than it was
worth (it was breaking 'make check' during distcheck), so we've reverted to
direct definition.
Travis Reitter [Tue, 11 Jan 2011 23:01:45 +0000 (15:01 -0800)]
Force Vala for non-release builds.
This should make buildbot builds a little more consistent.
Travis Reitter [Tue, 11 Jan 2011 22:30:16 +0000 (14:30 -0800)]
Add Vala requirement checks for newer tests.
Philip Withnall [Mon, 10 Jan 2011 00:30:13 +0000 (00:30 +0000)]
Bug 639113 — Add static aggregation tests
Add some tests which cover several of the ways which personas can be
statically aggregated at present. These tests are “static” (as opposed to
“dynamic”) because they don't change the inputs to the aggregator after
it's been prepared. Consequently, they don't cover much of the interesting
and bug-prone behaviour of the aggregator. Still, they're a start.
Closes: bgo#639113
Travis Reitter [Tue, 11 Jan 2011 19:31:10 +0000 (11:31 -0800)]
Don't announce removal of Individuals twice.
Before this patch, we would announce an Individual's removal, "dispose" of the
individual, then announce their removal again (at which point they would have
zero Personas, which can make it harder for clients to do anything useful with
the notification anyhow).
Helps: bgo#639113
Philip Withnall [Sun, 9 Jan 2011 21:52:54 +0000 (21:52 +0000)]
Allow multiple test accounts to be connected simultaneously
This doesn't affect any existing tests, but will be useful for testing that
aggregation across different persona stores works correctly.
Travis Reitter [Tue, 11 Jan 2011 05:59:39 +0000 (21:59 -0800)]
Override the test log handler for Telepathy tests.
This avoids aborting and printing unnecessary stack traces for the
well-known Telepathy-logger warning message.
Fixes bgo#639195 - Print stack traces for failed tests to improve
remote debugging
Travis Reitter [Tue, 11 Jan 2011 00:50:27 +0000 (16:50 -0800)]
Factor Tp logger warning out of Tp tests.
Helps bgo#639195 - Print stack traces for failed tests to improve
remote debugging
Travis Reitter [Tue, 11 Jan 2011 00:40:14 +0000 (16:40 -0800)]
When a test would print a message >= warning, print a stack trace.
This is largely to benefit remote debugging of build bots but also makes
debugging test errors easier.
Helps bgo#639195 - Print stack traces for failed tests to improve
remote debugging
Travis Reitter [Tue, 11 Jan 2011 00:10:41 +0000 (16:10 -0800)]
Cut unnecessary log handler for key-file test.
Helps bgo#639195 - Print stack traces for failed tests to improve
remote debugging
Travis Reitter [Mon, 10 Jan 2011 22:44:39 +0000 (14:44 -0800)]
Cut unnecessary Tp log handler for the general test.
Helps bgo#639195 - Print stack traces for failed tests to improve
remote debugging
Travis Reitter [Thu, 6 Jan 2011 23:48:08 +0000 (15:48 -0800)]
Note the fix of bgo#638609 in the NEWS
Travis Reitter [Thu, 6 Jan 2011 23:39:20 +0000 (15:39 -0800)]
Register core debugging as global G_LOG_DOMAIN to reduce magic strings.
Fixes bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Tue, 4 Jan 2011 20:19:27 +0000 (12:19 -0800)]
Pin backends' names to global BACKEND_NAME to reduce magic strings.
Helps bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Tue, 4 Jan 2011 18:58:15 +0000 (10:58 -0800)]
Make the main debug domain 'folks' to match the backends.
Helps bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Tue, 4 Jan 2011 18:51:49 +0000 (10:51 -0800)]
Make the backends' log domains match their type_id.
Helps bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Tue, 4 Jan 2011 19:26:34 +0000 (11:26 -0800)]
Push flag setting into the Debug constructor.
Helps bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Tue, 4 Jan 2011 18:54:01 +0000 (10:54 -0800)]
Add new API for setting debugging levels.
Helps bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Tue, 4 Jan 2011 00:23:05 +0000 (16:23 -0800)]
Make Folks.Debug a class so we can store state.
Helps bgo#638609 - libfolks hard-codes backend names for debugging
Travis Reitter [Mon, 3 Jan 2011 22:15:58 +0000 (14:15 -0800)]
Don't use a magic string in the Tp backend.
Travis Reitter [Mon, 3 Jan 2011 21:29:06 +0000 (13:29 -0800)]
Add a comment for bgo#638609 - backend debug hard-coding
Philip Withnall [Fri, 31 Dec 2010 14:23:31 +0000 (14:23 +0000)]
Bug 638395 — folks-inspect prevents default Vala-free builds
Add notices and errors to the configure script to notify the user of why
the inspect tool is not being built. Closes: bgo#638395
Philip Withnall [Fri, 31 Dec 2010 14:21:11 +0000 (14:21 +0000)]
Add a missing backslash to the configure.ac file
Travis Reitter [Fri, 31 Dec 2010 07:19:31 +0000 (23:19 -0800)]
Don't break the build if building folks-inspect without Vala
Philip Withnall [Thu, 30 Dec 2010 17:59:37 +0000 (17:59 +0000)]
Fix some variable names in the inspector signal parsing code
See: https://bugzilla.gnome.org/show_bug.cgi?id=629075#c8
Philip Withnall [Mon, 6 Sep 2010 18:38:21 +0000 (19:38 +0100)]
Bug 629075 — Add folks command line application
Add an interactive command line inspection utility for libfolks.
Closes: bgo#629075.
Travis Reitter [Thu, 30 Dec 2010 17:23:31 +0000 (09:23 -0800)]
Add NEWS entry for bgo#629083 fix
Travis Reitter [Thu, 30 Dec 2010 17:22:24 +0000 (09:22 -0800)]
Add NEWS entry for bgo#638311 fix
Travis Reitter [Wed, 29 Dec 2010 01:21:53 +0000 (17:21 -0800)]
Refer to non-local variables and methods with full name.
The benefit here is to make it easier to tell when variables are local. Methods
are referred to similarly for consistency.
Fixes bgo#629083
Travis Reitter [Wed, 29 Dec 2010 00:58:34 +0000 (16:58 -0800)]
Cut unnecessary casting.
Excessive casting can hide real compiler warnings/errors and is best avoided.
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 17:15:23 +0000 (09:15 -0800)]
Maximize use of 'unowned' keyword.
This is used when (and only when) variables:
1. would avoid a non-trivial copy (eg, a string or array but not an int or
object ref-count increase)
AND
2. will only be assigned unowned values (excessive use of 'unowned' here will be
caught by the compiler)
The net benefit is avoiding unecessary memory allocation/freeing.
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 01:22:21 +0000 (17:22 -0800)]
Maximize use of the 'var' keyword.
This is used whenever a variable:
1. is declared and initialized in the same line
AND
2. would not avoid a copy by using the 'unowned'. In the future, we may be able
to declare variables 'unowned var', in which case this point won't matter. See
bgo#638199.
The net benefit is less noise on variable declaration lines.
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 01:14:45 +0000 (17:14 -0800)]
Ensure private and internal methods begin with a _
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 00:28:38 +0000 (16:28 -0800)]
Ensure private and internal data members begin with a _
Helps bgo#629083
Travis Reitter [Wed, 29 Dec 2010 23:55:44 +0000 (15:55 -0800)]
Write down development policies.
Fixes bgo #638311.
Philip Withnall [Fri, 17 Dec 2010 11:16:04 +0000 (11:16 +0000)]
Bug 637240 — libfolks-telepathy.so exports private symbols
Limit the symbols exported by the libfolks-telepathy.so library to those
starting with “tpf_”. Based on a patch by
Emilio Pozuelo Monfort <pochu27@gmail.com>. Closes: bgo#637240
Philip Withnall [Mon, 13 Dec 2010 16:49:18 +0000 (16:49 +0000)]
Post-release version bump
Philip Withnall [Mon, 13 Dec 2010 16:45:07 +0000 (16:45 +0000)]
Release version 0.3.3
Philip Withnall [Mon, 13 Dec 2010 16:40:29 +0000 (16:40 +0000)]
Add missing files to POTFILES.in and POTFILES.skip
Philip Withnall [Mon, 13 Dec 2010 16:35:59 +0000 (16:35 +0000)]
Remove outdated translation files from EXTRA_DIST
They're no longer copied into the build tree since we no longer call
autopoint. See: bgo#635649
Philip Withnall [Mon, 13 Dec 2010 15:35:38 +0000 (15:35 +0000)]
Ensure each Persona is added to the relinked_personas list at most once
In some cases when relinking the user's Individual when taking Empathy
offline, several of the user's Personas can get into the relinked_personas
list multiple times. This causes an infinite loop of linking and relinking
those Personas. Closes: bgo#637136
Philip Withnall [Sun, 12 Dec 2010 17:52:52 +0000 (17:52 +0000)]
Bug 636714 — Assertion failure on invalid IM address
Handle invalid IM addresses in relationships.ini more gracefully by throwing
an exception from IMable.normalise_im_address() if it detects an invalid
address, rather than aborting due to an assertion failure. Closes: bgo#636714
Philip Withnall [Mon, 13 Dec 2010 15:23:15 +0000 (15:23 +0000)]
Don't trust personas from IRC
Philip Withnall [Sun, 12 Dec 2010 18:32:51 +0000 (18:32 +0000)]
Rename the Favourite interface to Favouritable
Closes: bgo#627397
Philip Withnall [Sun, 12 Dec 2010 18:28:20 +0000 (18:28 +0000)]
Rename the Presence interface to HasPresence
Helps: bgo#627397
Philip Withnall [Sun, 12 Dec 2010 18:24:08 +0000 (18:24 +0000)]
Rename the Avatar interface to HasAvatar
Helps: bgo#627397
Philip Withnall [Sun, 12 Dec 2010 17:44:35 +0000 (17:44 +0000)]
Add recent bug fixes to NEWS file
Philip Withnall [Sun, 12 Dec 2010 17:06:38 +0000 (17:06 +0000)]
Add documented libraries to LDFLAGS in the documentation Makefile.am
gtkdoc-scangobj expects to have the libraries it's linking its scanner program
to present in LDFLAGS. gtk-doc.make normally does this automatically for
normal gtk-doc-enabled projects, but we need to do it manually.
Philip Withnall [Sun, 12 Dec 2010 16:34:01 +0000 (16:34 +0000)]
Add missing documentation for method parameters
Philip Withnall [Sun, 12 Dec 2010 16:29:07 +0000 (16:29 +0000)]
Fix documentation of enum members
The documentation comments for enum members have to be proper valadoc comments
(i.e. starting with /** and ending with */ on separate lines).
Philip Withnall [Sun, 12 Dec 2010 16:18:57 +0000 (16:18 +0000)]
Fix string length calculation in the BackendStore for Vala 0.12
Philip Withnall [Sun, 12 Dec 2010 16:18:01 +0000 (16:18 +0000)]
Remove use of deprecated GLib API in Vala 0.12
Philip Withnall [Sun, 12 Dec 2010 16:15:22 +0000 (16:15 +0000)]
Remove use of Unicode characters in documentation comments
The normal valadoc doclet is fine with them, but the gtkdoc doclet doesn't
like them. See: bgo#637072
Travis Reitter [Mon, 18 Oct 2010 20:00:13 +0000 (13:00 -0700)]
Generate gtk-doc for libfolks and libfolks-telepathy.
Philip Withnall [Sun, 12 Dec 2010 11:09:12 +0000 (11:09 +0000)]
Don't delete in-tree m4 macros when doing maintainer-clean
Philip Withnall [Sun, 12 Dec 2010 11:04:58 +0000 (11:04 +0000)]
Remove libtool m4 macros from the git tree
They're copied into the build tree from the system libtool installation by
libtoolize, and don't belong in git.
Stef Walter [Wed, 1 Dec 2010 20:50:22 +0000 (20:50 +0000)]
Bug 636251 — Fails to add contact
Vala compiles this line of code wrong, and tries to double check
that there is a GValue boxed inside of the GValue.
Closes: bgo#636251
Robert Ancell [Fri, 26 Nov 2010 03:32:39 +0000 (14:32 +1100)]
Bug 635823 — Link telepathy test program to GIO
Closes: bgo#635823
Philip Withnall [Sat, 27 Nov 2010 21:32:41 +0000 (21:32 +0000)]
Bug 635703 – Leak in connection_get_requestable_channel_classes_cb
Tidy up memory handling in the function so that it doesn't leak in odd
conditions. Closes: bgo#635703
Philip Withnall [Sat, 27 Nov 2010 21:17:56 +0000 (21:17 +0000)]
Fix return types and documentation for a tp-lowlevel.c method
folks_tp_lowlevel_connection_get_requestable_channel_classes_finish() had
incorrect return values in assertion failure conditions, and the
documentation said to use the wrong function to free its return value.
Philip Withnall [Sat, 27 Nov 2010 21:08:12 +0000 (21:08 +0000)]
Bug 635649 — autopoint fails to run
Since the changes due to bgo#635134, we should no longer call autopoint in
autogen.sh. Closes: bgo#635649
Philip Withnall [Mon, 22 Nov 2010 22:06:04 +0000 (22:06 +0000)]
Don't use IT_PROG_INTLTOOL and AM_GNU_GETTEXT
They conflict. See bgo#635134.
Philip Withnall [Thu, 18 Nov 2010 21:20:17 +0000 (21:20 +0000)]
Fix leak in tp-lowlevel.c
Closes: bgo#635178
Travis Reitter [Sun, 14 Nov 2010 23:58:42 +0000 (15:58 -0800)]
Release 0.3.2
Travis Reitter [Mon, 15 Nov 2010 00:30:26 +0000 (16:30 -0800)]
Relocate the g-i scanner args in configure for consistency.
Travis Reitter [Mon, 15 Nov 2010 00:29:40 +0000 (16:29 -0800)]
Fix syntax errors for the release version of configure.
Travis Reitter [Sun, 14 Nov 2010 23:28:23 +0000 (15:28 -0800)]
Ensure vapi files have an appropriate age.
Vapigen doesn't update the age of vapi files if they don't change. This means
that make will always generate them during distcheck, implicitly requiring
vapigen.
Helps bgo#633718.
Travis Reitter [Sun, 14 Nov 2010 21:21:56 +0000 (13:21 -0800)]
Cast Individuals to Presence as necessary for the tests.
Philip Withnall [Sat, 13 Nov 2010 14:32:28 +0000 (14:32 +0000)]
Fix notification order in backends
Philip Withnall [Fri, 17 Sep 2010 11:00:19 +0000 (12:00 +0100)]
Remove the exception from Tpf.Persona's constructor
It was not possible for it to ever be thrown (since TpContact.get_identifier()
is guaranteed to always return a valid ID, and having *_new() methods throw
exceptions is never a good idea. (GInitable should be used instead.)
This breaks both the Vala and C APIs.
Helps: bgo#629078
Philip Withnall [Fri, 10 Sep 2010 14:45:30 +0000 (15:45 +0100)]
Hide setter for Persona.linkable_properties
Philip Withnall [Fri, 10 Sep 2010 14:25:31 +0000 (15:25 +0100)]
Remove casting convenience functions in Individual
They're not needed for Vala, and weren't particularly well thought
out (or complete) in C.
Philip Withnall [Fri, 10 Sep 2010 14:20:51 +0000 (15:20 +0100)]
Hide setter for Backend.persona_stores
Philip Withnall [Fri, 10 Sep 2010 14:13:29 +0000 (15:13 +0100)]
Hide setter for Backend.name
Philip Withnall [Fri, 10 Sep 2010 13:57:01 +0000 (14:57 +0100)]
Hide setters for PersonaStore.type_id, .display_name and .id
Philip Withnall [Sat, 13 Nov 2010 12:07:33 +0000 (12:07 +0000)]
Ensure we use string's byte length in both Vala 0.10 and 0.12
string.length gives the byte length in Vala 0.12 and string.size() is
deprecated, however string.length gives the character length in Vala 0.10,
so we need to conditionally change the code for Vala <= 0.10.
Re-closes: bgo#628930
Philip Withnall [Sun, 7 Nov 2010 21:56:42 +0000 (21:56 +0000)]
Consolidate persona link removal code
Philip Withnall [Sun, 7 Nov 2010 21:46:09 +0000 (21:46 +0000)]
Remove links to personas before they're relinked in the aggregator
If one persona is removed from a non-singleton individual (e.g. because they
went offline), the other personas in the individual will be relinked into new
individuals (singleton or not). We previously didn't ensure that the entries
in the link map corresponding to these personas were removed before the
personas were relinked which, under certain circumstances (which I haven't
fully explored), could cause the personas to be relinked to the individual
which had just been removed. This would cause the individual's persona list
to grow exponentially, and generally Bad Things to happen.
I could reproduce this situation by logging into two accounts, both of which
had the other added to their roster. The resulting four personas corresponding
to the two accounts (2 user personas and 2 normal personas) would be linked
to form one user individual. Going offline and then online again would trigger
the bug.
Closes: bgo#633080
Philip Withnall [Sun, 31 Oct 2010 16:26:51 +0000 (16:26 +0000)]
Combine personas_changed() emissions for Individuals replaced due to relinking
This re-fixes bgo#632564 so that the optimisation of grouping emissions of
the personas_changed() signal is preserved. Closes: bgo#632564
Philip Withnall [Sun, 31 Oct 2010 16:25:56 +0000 (16:25 +0000)]
Improve debug output of the aggregator
Add an indication as to whether personas are the user.
Travis Reitter [Thu, 11 Nov 2010 02:26:35 +0000 (18:26 -0800)]
Note the recent build clean-ups in the NEWS.
Travis Reitter [Thu, 11 Nov 2010 02:19:12 +0000 (18:19 -0800)]
Un-break distclean for the general test library
Travis Reitter [Thu, 11 Nov 2010 02:09:46 +0000 (18:09 -0800)]
Un-break distclean for the Telepathy test library
Travis Reitter [Thu, 11 Nov 2010 01:55:11 +0000 (17:55 -0800)]
Un-break distclean for the tests
Travis Reitter [Thu, 11 Nov 2010 01:41:38 +0000 (17:41 -0800)]
Un-break distclean for the Telepathy backend
Travis Reitter [Wed, 10 Nov 2010 23:49:27 +0000 (15:49 -0800)]
Distribute the key-file test library VAPI
Travis Reitter [Wed, 10 Nov 2010 23:11:48 +0000 (15:11 -0800)]
Add the Telepathy test library g-i and Vala files to DISTCLEANFILES
Travis Reitter [Wed, 10 Nov 2010 20:02:53 +0000 (12:02 -0800)]
Add missing general test VAPI distribution.
Travis Reitter [Wed, 10 Nov 2010 19:59:46 +0000 (11:59 -0800)]
Simplify the tp contactlist test lib build