Matthew Waters [Mon, 17 Nov 2014 03:00:10 +0000 (14:00 +1100)]
aggregator: add _get_latency() for subclass usage
API: gst_aggregator_get_latency
https://bugzilla.gnome.org/show_bug.cgi?id=739996
Vineeth T M [Mon, 17 Nov 2014 04:06:52 +0000 (09:36 +0530)]
glcontext: build errors when GST_GL_HAVE_OPENGL is 0
Moving variables within #if GST_GL_HAVE_OPENGL, which are not going to be used otherwise.
and which are needed only when OpenGl is present
https://bugzilla.gnome.org/show_bug.cgi?id=740235
Sreerenj Balachandran [Mon, 17 Nov 2014 09:10:35 +0000 (11:10 +0200)]
examples: relicense opencv gsthanddetect_test to LGPLv2+
The GPL3 license header was copy'n'pasted from a
neighbouring source file by mistake, the original
code was not GPL3 licensed, but fell under the
default GStreamer license, which is LGPLv2+.
https://bugzilla.gnome.org/show_bug.cgi?id=685655
Matthew Waters [Mon, 17 Nov 2014 07:50:28 +0000 (18:50 +1100)]
glfilter: add read-only context property
Matthew Waters [Mon, 17 Nov 2014 07:50:04 +0000 (18:50 +1100)]
glmixer: add read-only context property
Hyunjun Ko [Tue, 11 Nov 2014 08:08:25 +0000 (17:08 +0900)]
opencv-example: Use g_snprintf instead of sprintf
https://bugzilla.gnome.org/show_bug.cgi?id=739846
Reynaldo H. Verdejo Pinochet [Sun, 16 Nov 2014 23:32:56 +0000 (20:32 -0300)]
dvbsrc: drop explicit comparisons against 0 for true/false
Sebastian Dröge [Sun, 16 Nov 2014 10:00:14 +0000 (11:00 +0100)]
gl/cocoa: Only use convertRectToBacking on OSX >= 10.7
It does not exist before and older versions also don't have
support for HiDPI displays anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=740201
Sebastian Dröge [Sun, 16 Nov 2014 09:57:55 +0000 (10:57 +0100)]
gl: Use numeric OSX version instead of the macro
The macro is not defined on older OSX versions and evaluates to 0.
https://bugzilla.gnome.org/show_bug.cgi?id=740201
Tim-Philipp Müller [Sat, 15 Nov 2014 21:59:48 +0000 (21:59 +0000)]
dvbbasebin: fix possible crash by passing 64 bits for 64-bit queue property
https://bugzilla.gnome.org/show_bug.cgi?id=740191
Sebastian Dröge [Fri, 14 Nov 2014 09:40:31 +0000 (10:40 +0100)]
decklink: Fix indention
Gwenole Beauchesne [Mon, 10 Nov 2014 09:01:24 +0000 (10:01 +0100)]
codecparsers: h264: fix derivation of MaxPicNum variable.
The logic to compute the MaxPicNum variable was reversed. In paricular,
MaxPicNum is double MaxFrameNum only if field_pic_flag is set to 1.
https://bugzilla.gnome.org/show_bug.cgi?id=739291
Sebastian Dröge [Thu, 13 Nov 2014 11:01:25 +0000 (12:01 +0100)]
gl/cocoa: Don't override the application delegate
Otherwise interesting things will happen in Cocoa applications, like
infinite event loops that block the NSApplication loop forever.
This was only needed for GNUStep and thus can safely be removed now.
Sebastian Dröge [Thu, 13 Nov 2014 10:58:07 +0000 (11:58 +0100)]
gl/cocoa: Remove GNUStep support
Until gcc and GNUStep properly support Objective-C blocks and other
"new" features of Objective-C we can't properly support them without
making the code much more ugly.
https://bugzilla.gnome.org/show_bug.cgi?id=739152
Sebastian Dröge [Wed, 12 Nov 2014 17:06:45 +0000 (18:06 +0100)]
interaudiosink: Make sure to store at least period-time samples at once in the adapter
It's better to create some more silence than having the source pull multiple
short buffers out of the adapter and insert silence between them.
Alessandro Decina [Wed, 12 Nov 2014 15:45:12 +0000 (16:45 +0100)]
vtenc: fix build on iOS
Alessandro Decina [Wed, 12 Nov 2014 14:35:36 +0000 (15:35 +0100)]
coremediabuffer: set ->pixel_buf for CVPixelBuffer buffers
Fix a bug for which we never actually set ->pixel_buf to non-NULL for
CVPixelBuffer buffers.
Vincent Penquerc'h [Fri, 6 Jun 2014 12:57:30 +0000 (13:57 +0100)]
faad: set channel positions using the appropriate API
https://bugzilla.gnome.org/show_bug.cgi?id=731038
Sebastian Dröge [Wed, 12 Nov 2014 12:58:56 +0000 (13:58 +0100)]
intervideosrc: Stop showing the current frame after 1 second, not after 30 frames
Julien Isorce [Wed, 12 Nov 2014 09:41:53 +0000 (09:41 +0000)]
tests: add CFLAGS and LADD for glimagesink unit test
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732694
Sebastian Dröge [Wed, 12 Nov 2014 10:52:58 +0000 (11:52 +0100)]
openh264enc: Add new enable-frame-skip property and disable it by default
Otherwise e.g. videotestsrc ! openh264enc ! ... will drop every second frame
because otherwise the target bitrate can't be reached without loosing too
much quality.
Alessandro Decina [Wed, 12 Nov 2014 08:59:53 +0000 (09:59 +0100)]
vtenc: fix compilation on < 10.9
Matthew Waters [Wed, 12 Nov 2014 00:44:07 +0000 (11:44 +1100)]
glimagesink: don't set the upload to NULL on the drain query
https://bugzilla.gnome.org/show_bug.cgi?id=732694
Hyunjun Ko [Tue, 11 Nov 2014 08:04:48 +0000 (17:04 +0900)]
gl: Correct invalid comment text
Julien Isorce [Tue, 11 Nov 2014 23:54:44 +0000 (23:54 +0000)]
gl: add unit test that checks for glimagesink drain query handling
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732694
Julien Isorce [Tue, 11 Nov 2014 23:49:59 +0000 (23:49 +0000)]
glimagesink: release stored buffers on drain query
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732694
Julien Isorce [Tue, 11 Nov 2014 23:43:42 +0000 (23:43 +0000)]
gl: do not raise a critical msg if the backend does not handle window events
Fix "assertion 'window_class->handle_events != NULL' failed"
if not using a X11 window.
Alessandro Decina [Tue, 11 Nov 2014 17:01:54 +0000 (18:01 +0100)]
vtenc: enable the hw encoder on OSX
Sebastian Dröge [Tue, 11 Nov 2014 11:00:30 +0000 (12:00 +0100)]
decklinksink: Check the correct variable for failure
If we can't get an output, we would otherwise just use it later and crash.
Sebastian Dröge [Tue, 11 Nov 2014 10:18:19 +0000 (11:18 +0100)]
interaudiosrc: Make sure we have a writable buffer before we start changing metadata
Sebastian Dröge [Tue, 11 Nov 2014 10:15:35 +0000 (11:15 +0100)]
intervideosrc: Set the GAP flag on repeated buffers
videorate does the same and it allows optimizations downstream.
Sebastian Dröge [Tue, 11 Nov 2014 10:12:55 +0000 (11:12 +0100)]
interaudiosrc: Set the GAP flag on buffers that only contain silence
Matthew Waters [Tue, 11 Nov 2014 03:23:55 +0000 (14:23 +1100)]
gl: remove the width/height fields from the caps to support frame resizing
It was previously only occuring with sysmem caps features
https://bugzilla.gnome.org/show_bug.cgi?id=739334
Aurélien Zanelli [Mon, 10 Nov 2014 16:42:20 +0000 (17:42 +0100)]
h264parser: fix GstH264ParserResult documentation typo
https://bugzilla.gnome.org/show_bug.cgi?id=739906
Sebastian Dröge [Mon, 10 Nov 2014 15:01:25 +0000 (16:01 +0100)]
tests: Add x265enc unit test to .gitignore
Tim-Philipp Müller [Sun, 9 Nov 2014 20:53:34 +0000 (20:53 +0000)]
pngparse: optimise reading of png files
Read PNG data chunk in one go by letting the parser
base class know the size we need, so that it doesn't
drip-feed us small chunks of data (causing a lot of
reallocs and memcpy in the process) until we have
everything.
Improves parsing performance of very large PNG files
(65MB) from ~13 seconds to a couple of millisecs.
https://bugzilla.gnome.org/show_bug.cgi?id=736176
Tim-Philipp Müller [Sun, 9 Nov 2014 19:23:47 +0000 (19:23 +0000)]
examples: remove pointless mpegtsmux example
Serves no purpose, is not even hooked up to the
build system, has hard coded file names and paths,
and can easily be replaced with a gst-launch line.
https://bugzilla.gnome.org/show_bug.cgi?id=739844
Sebastian Dröge [Sun, 9 Nov 2014 09:25:25 +0000 (10:25 +0100)]
avfvideosrc: Don't pretend to support reconfiguration
We will run into an assertion in set_caps() if we try to change
caps while the source is already running. Don't try to find new
caps in GstBaseSrc::negotiate() to prevent caps changes.
Aurélien Zanelli [Thu, 9 Oct 2014 11:11:48 +0000 (13:11 +0200)]
vc1parse: set seq_layer_sent to FALSE on reset()
https://bugzilla.gnome.org/show_bug.cgi?id=738526
Aurélien Zanelli [Thu, 9 Oct 2014 11:03:56 +0000 (13:03 +0200)]
vc1parse: implement asf to *-frame-layer stream-format
This commit add an helper to convert a frame to frame-layer format and
use it to implement these two stream-format conversion:
- asf --> sequence-layer-frame-layer
- asf --> frame-layer
In simple/main profile, we basically have a raw frame, so building a
frame layer isn't too complicated. But in advanced profile, the first
frame-layer should contain sequence-header, entrypoint, and frame and
each keyframe should contain entrypoint, so we have to handle these
carefully.
https://bugzilla.gnome.org/show_bug.cgi?id=738526
Aurélien Zanelli [Thu, 9 Oct 2014 08:38:40 +0000 (10:38 +0200)]
vc1parse: check output format at negotiation time
Add an helper to check that output stream-format is coherent with
profile and header-format. It also check if we know how to do the
conversion if the input stream-format differs from selected
output-format.
So, in case output stream-format is not allowed, it will now fail at
negotiation rather than in pre_push_frame.
https://bugzilla.gnome.org/show_bug.cgi?id=738526
Aurélien Zanelli [Tue, 30 Sep 2014 13:35:38 +0000 (15:35 +0200)]
vc1parse: add some asf related stream-format conversions
This commit introduces an helper to convert an ASF frame to BDUs format with
startcodes and use this helper to implements following stream-format
conversions:
- asf --> bdu
- asf --> sequence-layer-bdu
- asf --> sequence-layer-raw-frame
https://bugzilla.gnome.org/show_bug.cgi?id=738526
Aurélien Zanelli [Tue, 30 Sep 2014 13:28:55 +0000 (15:28 +0200)]
vc1parse: add some simple stream-format conversion
It add the support of following stream-format conversion:
- bdu --> sequence-layer-bdu
- bdu-frame --> sequence-layer-bdu-frame
- frame-layer --> sequence-layer-frame-layer
For these conversion, the only requirements is to push a sequence-layer
buffer prior to data.
https://bugzilla.gnome.org/show_bug.cgi?id=738526
Aurélien Zanelli [Tue, 30 Sep 2014 12:53:25 +0000 (14:53 +0200)]
vc1parse: prepare the stream-format conversion code and add the simplest ones
It prepares the template for stream-format conversion and it implements
the following conversion:
- sequence-layer-bdu --> bdu
- sequence-layer-bdu-frame --> bdu-frame
- sequence-layer-frame-layer --> frame-layer
Work is done in the pre_push_frame() method.
https://bugzilla.gnome.org/show_bug.cgi?id=738526
Matthieu Bouron [Fri, 5 Sep 2014 15:57:47 +0000 (17:57 +0200)]
dashdemux: do not override last known stream error
https://bugzilla.gnome.org/show_bug.cgi?id=736141
Thiago Santos [Fri, 7 Nov 2014 22:30:18 +0000 (19:30 -0300)]
mssdemux: seeks in the manifest never fail
Set void as the return and remove error handling as it could
never fail
Thiago Santos [Fri, 7 Nov 2014 22:16:47 +0000 (19:16 -0300)]
dashdemux: make sure flushes have the same seqnum as the seek event
They are part of the same operation and should preserve the seqnum
Thiago Santos [Fri, 7 Nov 2014 22:09:15 +0000 (19:09 -0300)]
dashdemux: simplify seek to eos handling
Remove redundant flush stop pushing and remove a goto to make
the code flow simpler
Matthieu Bouron [Wed, 17 Sep 2014 13:22:59 +0000 (15:22 +0200)]
dashdemux: send missing FLUSH_STOP/EOS when no seeking period is found
https://bugzilla.gnome.org/show_bug.cgi?id=736800
Josep Torra [Fri, 7 Nov 2014 14:50:51 +0000 (15:50 +0100)]
h264parse: set the HEADER flag on buffers containing SPS or PPS
Josep Torra [Fri, 7 Nov 2014 14:41:15 +0000 (15:41 +0100)]
h265parse: set the HEADER flag on buffers containing VPS, SPS or PPS
Sebastian Dröge [Fri, 7 Nov 2014 10:41:01 +0000 (11:41 +0100)]
gstglconfig: Put gstglconfig.h into $(libdir)/gstreamer-1.0/include
It's architecture dependent and should not be placed into the include
directory as the assumption is that all those headers are architecture
independent.
https://bugzilla.gnome.org/show_bug.cgi?id=739767
Tim-Philipp Müller [Fri, 7 Nov 2014 00:16:12 +0000 (00:16 +0000)]
smoothstreaming: initialise new GstH264NalUnit fields
CID #1251107.
Alessandro Decina [Thu, 6 Nov 2014 22:58:06 +0000 (23:58 +0100)]
glimagesink: don't make gst_glimage_sink_handle_events call _ensure_gl_setup
gst_glimage_sink_handle_events can be called from the overlay interface and from
the main thread before GL is setup. Before this change, that would call
_ensure_gl_setup() and deadlock on OSX.
Change things so that it's always safe to call gst_glimage_sink_handle_events()
without stuff deadlocking.
Alessandro Decina [Thu, 6 Nov 2014 22:55:20 +0000 (23:55 +0100)]
glimagesink: fix possible deadlock on osx
Remove gst_glimage_sink_handle_events call in gst_glimage_sink_init. It was
unnecessary and when the element was instantiated from the main thread, caused a
deadlock in OSX creating the context (thread).
Alessandro Decina [Thu, 6 Nov 2014 12:22:17 +0000 (13:22 +0100)]
vtenc: add realtime and allow-frame-reordering properties
Matthew Waters [Thu, 6 Nov 2014 23:01:59 +0000 (10:01 +1100)]
glimagesink: clamp the resize width/height to >= 1 to avoid a GL error
Sebastian Dröge [Thu, 6 Nov 2014 16:36:15 +0000 (17:36 +0100)]
intervideosrc: Print a warning into the debug log on generating black frames
Sebastian Dröge [Thu, 6 Nov 2014 16:21:39 +0000 (17:21 +0100)]
intervideosink: Add some debug output in the render function
Sebastian Dröge [Thu, 6 Nov 2014 10:53:04 +0000 (11:53 +0100)]
h265parse: don't unnecesarily set src_caps
https://bugzilla.gnome.org/show_bug.cgi?id=739374
Matej Knopp [Wed, 29 Oct 2014 21:55:47 +0000 (22:55 +0100)]
h264parse: don't unnecesarily set src_caps
https://bugzilla.gnome.org/show_bug.cgi?id=739374
Matthew Waters [Thu, 6 Nov 2014 07:43:01 +0000 (18:43 +1100)]
glutils: only attempt getting the app context when we don't already have a display
avoids querying/messaging the world on each frame
Matthew Waters [Thu, 6 Nov 2014 07:37:23 +0000 (18:37 +1100)]
glcontext: fail context creation if glGetString returns NULL
Lubosz Sarnecki [Wed, 29 Oct 2014 11:24:16 +0000 (12:24 +0100)]
glimagesink: implement gst_video_overlay_handle_events
https://bugzilla.gnome.org/show_bug.cgi?id=736035
Sebastian Dröge [Tue, 4 Nov 2014 14:16:33 +0000 (15:16 +0100)]
interaudiosrc: Fix compiler warning about unused variables
gstinteraudiosrc.c: In function 'gst_inter_audio_src_create':
gstinteraudiosrc.c:339:27: error: variable 'buffer_samples' set but not used [-Werror=unused-but-set-variable]
guint64 period_samples, buffer_samples;
^
Sebastian Dröge [Tue, 4 Nov 2014 13:56:55 +0000 (14:56 +0100)]
interaudio: Make buffer size and latency handling more explicit and add properties for them
This now makes audio work more reliable without disconts.
Sebastian Dröge [Tue, 4 Nov 2014 12:59:20 +0000 (13:59 +0100)]
interaudiosink: Use the bpf from the audio info instead of hardcoding 4
Sebastian Dröge [Tue, 4 Nov 2014 12:58:44 +0000 (13:58 +0100)]
interaudio: Only flush the ringbuffer on the sink side
Sebastian Dröge [Tue, 4 Nov 2014 12:46:46 +0000 (13:46 +0100)]
interaudiosink: Flush the adapter when we get new caps
Ideally we would drain the source but that would require more coordination
between sink and source than what we currently have.
Sebastian Dröge [Tue, 4 Nov 2014 08:52:11 +0000 (09:52 +0100)]
gl/cocoa: include gl3.h in configure too for consistency with gstglapi.h
Olivier Crête [Tue, 4 Nov 2014 01:45:03 +0000 (20:45 -0500)]
insertbin: Add doc for the ignored user-data in action signals
Julien Isorce [Mon, 3 Nov 2014 23:24:33 +0000 (23:24 +0000)]
gl/cocoa: use NSAutoreleasePool to free resize data
Otherwise when resizing the window you will also get messages like:
class NSConcreteMapTable autoreleased with no pool in place - just leaking
class NSConcreteValue autoreleased with no pool in place - just leaking
class NSConcreteValue autoreleased with no pool in place - just leaking
class __NSCFDictionary autoreleased with no pool in place - just leaking
Julien Isorce [Mon, 3 Nov 2014 23:08:09 +0000 (23:08 +0000)]
gl/cocoa: include gl3.h to have GL_CONTEXT_PROFILE_MASK
Julien Isorce [Mon, 3 Nov 2014 23:07:34 +0000 (23:07 +0000)]
gl/cocoa: make sure to turn on frame rectangle changes notifications
Default value of property postsFrameChangedNotifications is YES
but it is worth to explicitly enable it.
Julien Isorce [Mon, 3 Nov 2014 23:02:17 +0000 (23:02 +0000)]
gl/cocoa: fix uncaught exception 'unrecognized selector sent to instance'
Need to set the ':' as the reshape method now takes one parameter.
For the story, the GstGLNSView was previously inheriting from
NSOpenGLView which has a reshape function without any parameter.
Now the GstGLNSView inherits from NSView and we re-use the reshape
function manually.
Julien Isorce [Mon, 3 Nov 2014 22:59:41 +0000 (22:59 +0000)]
gl/cocoa: fix compiler warning
Use the reshape function after being defined. The other way
would have been to declare the reshape function in the header.
gstglwindow_cocoa.m: In function '-[GstGLNSView drawRect:]':
gstglwindow_cocoa.m:555: warning: 'GstGLNSView' may not respond to '-reshape'
gstglwindow_cocoa.m:555: warning: (Messages without a matching method signature
gstglwindow_cocoa.m:555: warning: will be assumed to return 'id' and accept
gstglwindow_cocoa.m:555: warning: '...' as arguments.)
Sebastian Dröge [Mon, 3 Nov 2014 15:54:58 +0000 (16:54 +0100)]
intervideosrc: Negotiate framerate with downstream
Prefer the closest framerate to the input framerate though.
Sebastian Dröge [Mon, 3 Nov 2014 15:24:33 +0000 (16:24 +0100)]
inter*src: No need to set caps manually on the pad
basesrc does that for us already.
Sebastian Dröge [Mon, 3 Nov 2014 15:13:23 +0000 (16:13 +0100)]
videoaggregator: Swap source/destination parameters of gst_video_converter_frame()
Wim Taymans [Mon, 3 Nov 2014 14:19:48 +0000 (15:19 +0100)]
inter: fix order of arguments
Sebastian Dröge [Mon, 3 Nov 2014 09:05:59 +0000 (10:05 +0100)]
interaudio: Set all required fields on the template caps
https://bugzilla.gnome.org/show_bug.cgi?id=739542
Tim-Philipp Müller [Mon, 3 Nov 2014 00:17:41 +0000 (00:17 +0000)]
gl: fix Since marker for gst_gl_window_run_navigation()
Tim-Philipp Müller [Sun, 2 Nov 2014 23:24:39 +0000 (23:24 +0000)]
inter: don't leak surface name
Tim-Philipp Müller [Tue, 3 Sep 2013 10:11:54 +0000 (11:11 +0100)]
mpegdemux: start pushing data again when a pad gets linked later
The whole not_linked optimisation is really a bit dodgy here, but
let's leave it in place for now and at least start pushing data
again when a pad got linked later, in which case we should get a
RECONFIGURE event.
Tim-Philipp Müller [Mon, 2 Sep 2013 22:36:43 +0000 (23:36 +0100)]
mpegdemux: namespace fixes
Tim-Philipp Müller [Sun, 2 Nov 2014 19:26:20 +0000 (19:26 +0000)]
audiovisualizer: post QoS messages when dropping frames due to QoS
Tim-Philipp Müller [Sun, 2 Nov 2014 19:12:56 +0000 (19:12 +0000)]
audiovisualizer: fix boilerplate macros
Tim-Philipp Müller [Sun, 2 Nov 2014 17:18:12 +0000 (17:18 +0000)]
Sprinkle some G_PARAM_DEPRECATED and #ifndef GST_REMOVE_DEPRECATED
Tim-Philipp Müller [Sun, 2 Nov 2014 17:17:46 +0000 (17:17 +0000)]
hls: fix indentation
Luis de Bethencourt [Wed, 29 Oct 2014 18:18:07 +0000 (18:18 +0000)]
glshader: Fix memory leak
Memory is only freed in the TRUE clause of the if conditional. Free in the else
clause as well.
Also, consolidate g_malloc + sprintf into a g_strdup_printf().
CID #1212171
https://bugzilla.gnome.org/show_bug.cgi?id=739368
Nicolas Dufresne [Sat, 1 Nov 2014 14:10:27 +0000 (10:10 -0400)]
rtpopus: Use OPUS encoding name
Both Firefox and Chrome uses OPUS as the encoding in their SDP.
Adding this now defacto standard name remove the need for special
case in SDP parsing code.
https://bugzilla.gnome.org/show_bug.cgi?id=737810
Thiago Santos [Fri, 31 Oct 2014 20:32:56 +0000 (17:32 -0300)]
mssdemux: add type of stream to debug log
Makes it faster to debug why certain streams are not showing
Thiago Santos [Fri, 31 Oct 2014 20:32:39 +0000 (17:32 -0300)]
mssdemux: do not unlock not locked mutex
Luis de Bethencourt [Fri, 31 Oct 2014 10:45:19 +0000 (10:45 +0000)]
glcolorconvert: fix comments that confuse gtk-doc
GTK-Doc uses a special syntax for code documentation. A multiline comment that
starts with an additional '*' marks a documentation block that will be processed
by the GTK-Doc tools. So GTK-Doc is confused if a comment block starts with that
additional '*' but isn't meant to be processed. Removing this additional '*'.
https://bugzilla.gnome.org/show_bug.cgi?id=739444
Matthew Waters [Fri, 31 Oct 2014 01:52:50 +0000 (12:52 +1100)]
glimagesink: resize the viewport correctly on a caps change
with force-aspect-ratio=true, if the width or height changed, the
viewport wasn't being updated to respect the new video width and height
until a resize occured.
Matthew Waters [Fri, 31 Oct 2014 01:52:07 +0000 (12:52 +1100)]
glmixer: advertise support for changing input caps mid-stream
https://bugzilla.gnome.org/show_bug.cgi?id=739334
Matthew Waters [Fri, 31 Oct 2014 01:30:53 +0000 (12:30 +1100)]
gl: sprinkle some Since markers
Luis de Bethencourt [Thu, 30 Oct 2014 14:27:38 +0000 (14:27 +0000)]
mpegts: remove storage of never used values
Both _parse_atsc_mgt() and _parse_atsc_vct () change the value of the variable
data just before returning. The new value is never used since data is a pointer
declared at the beginning of the function and going out of scope just after the
new value is stored.
https://bugzilla.gnome.org/show_bug.cgi?id=739404
Luis de Bethencourt [Thu, 30 Oct 2014 17:06:01 +0000 (17:06 +0000)]
gaudieffects: remove < 0 comparison on guint32
Current CLAMP checks both if the value is below 0 or above 255. Considering it
is an unsigned value it can never be less than zero, so that comparison is
unnecessary. Switching to using if just for the upper bound.
CID #1139796
Luis de Bethencourt [Thu, 30 Oct 2014 16:05:14 +0000 (16:05 +0000)]
gaudieffects: declare floor and ceiling as constants