Jeremy Koritzinsky [Thu, 12 May 2022 21:53:12 +0000 (14:53 -0700)]
Generate the DAC table on Windows with MSVC linker directives instead of resource injection (#68065)
Ankit Jain [Thu, 12 May 2022 20:19:09 +0000 (16:19 -0400)]
[wasm] Wasm.Build.Tests: Capture test output with xunit, so the output is cleaner, and the (#69201)
* [wasm] Capture test output with xunit, so the output is cleaner, and the
.. test results have the full text.
* [wasm] Wasm.Build.Tests: remove unncessary output
.. like test args. And add some start/end banners for tests, since they
can be long running.
* Don't use _testOutput in the test programs
* fixup
Viktor Hofer [Thu, 12 May 2022 19:56:02 +0000 (21:56 +0200)]
Fix CoreLib fast up-to-date check (#69240)
* Fix CoreLib fast up-to-date check
Fixes https://github.com/dotnet/runtime/issues/68698
CoreLib's fast up-to-date check was broken because the output pdb was
moved into a different folder. Changing this to use a copy task instead
and consolidate the two targets into one.
I couldn't find a publicly exposed property that allows to change the
pdb's output path, hence I decided to copy.
SingleAccretion [Thu, 12 May 2022 19:51:38 +0000 (22:51 +0300)]
Simplify `fgMorphMultiregStructArg` (#68853)
* Remove invalid code from "fgMorphMultiregStructArg"
In an "OBJ(ADDR(LCL_VAR))" construction, it is legal for the "OBJ" to not match "LCL_VAR",
exactly, and the code in multi-reg argument morphing already handles this correctly.
So, just remove the asserts and the second-guessing of the "type" array.
SingleAccretion [Thu, 12 May 2022 18:54:14 +0000 (21:54 +0300)]
Treat `INDEX_ADDR`s as non-null (#69209)
* Treat INDEX_ADDRs as non-null
If they range check that is.
* Also use IsBoundsChecked in more places
Stephen Toub [Thu, 12 May 2022 18:11:54 +0000 (14:11 -0400)]
Add a few RegexGenerator tests for valid string arguments (#69221)
Will Smith [Thu, 12 May 2022 18:09:20 +0000 (11:09 -0700)]
ARM64 - Consolidate 'msub' and 'madd' logic (#68363)
* Changed GT_MADD to not emit msub
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Added break
* Added lowering pass
* Updates to lowering
* Removing morph transformation
* Minor format
* Removed GT_MSUB. Using simple containment to emit msub.
* Removed GT_MSUB case
* Removed extra code
* Updated comment
* Formatting
* Minor change
* Combining GT_MADD changes
* Added extra set flag checks
* Added extra set flag checks
* Creating helper functions
* Fixing build
* Fixing build
* Fixing build and better codegen
* Should produce zero diffs
* Formatting
* Update lowerarmarch.cpp
Viktor Hofer [Thu, 12 May 2022 18:01:53 +0000 (20:01 +0200)]
Remove properties that are already set globally (#69255)
Jakob Botsch Nielsen [Thu, 12 May 2022 17:58:10 +0000 (19:58 +0200)]
JIT: Remove "promoted parameter" tailcall limitation (#69034)
This is allowed for explicit tailcalls so it seems unlikely that there
are any actual problems with allowing this.
Radek Zikmund [Thu, 12 May 2022 17:35:05 +0000 (10:35 -0700)]
Unify SendContent cancellation between HTTP3 and HTTP2 (#67954)
* Unify SendContent cancellation between HTTP3 and HTTP2
* Fix comment
* Add Unit tests
* Fix flaky test
* Don't propagate cancellation for duplex content
* fixup! Fix flaky test
* Cancel body on all exceptions (except cancellation)
* Revert unwanted changes
* fixup! Merge remote-tracking branch 'upstream/main' into 60253-HTTP3-cancellation
* Apply suggestions from code review
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Tomas Weinfurt [Thu, 12 May 2022 17:16:03 +0000 (10:16 -0700)]
fix invalid Host header for link-local IPv6 (#69203)
* fix invalid Host headr for link-local IPv6
* feedback from review
Jeremy Koritzinsky [Thu, 12 May 2022 17:04:09 +0000 (10:04 -0700)]
Various refactorings to share more code with future generators (#67997)
Marek Fišera [Thu, 12 May 2022 17:02:39 +0000 (19:02 +0200)]
Mark all assets from System.Runtime and System.Threading.Overlapped references private (#69191)
Tomas Weinfurt [Thu, 12 May 2022 16:54:19 +0000 (09:54 -0700)]
make sure NetworkInfo works without IPv6 on Linux (#69172)
* make sure NetworkInfo works without IPv6 on Linux"
* remove unneeded reference
Viktor Hofer [Thu, 12 May 2022 16:18:01 +0000 (18:18 +0200)]
Update NoTargets.SDK and remove unnecessary properties being set (#69242)
Update NoTargets.SDK and remove unnecessary properties being set
Peter Sollich [Thu, 12 May 2022 15:44:01 +0000 (17:44 +0200)]
First version - just make sure all heaps sweep rather than compact if special_sweep_p is set by one heap. (#69177)
The issue was that in SVR GC, some GC threads would not be able to obtain a region for gen 0, and thus set special_sweep_p, but later on, this setting would be ignored when GC threads voted whether to sweep or compact. So we ended up compacting anyway, not getting a gen 0 region for some heaps, and verify_regions failing.
Fix is simply to always do sweep when special_sweep_p is set.
This still doesn't make ASP.NET work with tight hard limits - more work is needed.
Jakob Botsch Nielsen [Thu, 12 May 2022 14:18:41 +0000 (16:18 +0200)]
Disable HardwareIntrinsics NotSupported test on arm64 (#69241)
Elinor Fung [Thu, 12 May 2022 13:53:18 +0000 (06:53 -0700)]
Fix entry point for string marshalling tests with ownership transfer (#69226)
Stephen Toub [Thu, 12 May 2022 13:40:19 +0000 (09:40 -0400)]
Update to a newer Roslyn compiler (#69211)
Steve Harter [Thu, 12 May 2022 13:09:19 +0000 (08:09 -0500)]
Fix Assembly.GetCallingAssembly() (#69225)
Meri Khamoyan [Thu, 12 May 2022 12:55:03 +0000 (16:55 +0400)]
Revert "49936 text json failures" (#69243)
* Revert "49936 text json failures (#68758)"
This reverts commit
43dd0a74ab524278620d8c6a9d33a9b73b2d2228.
Jakob Botsch Nielsen [Thu, 12 May 2022 12:13:09 +0000 (14:13 +0200)]
Stop running both normal and no_tiered_compilation scenarios for coreclr PRs (#69178)
Viktor Hofer [Thu, 12 May 2022 11:33:16 +0000 (13:33 +0200)]
Enable corelib source generator in design time (#69235)
This should be fixed with the usage of an incremental source generator and VS2022, based on https://github.com/dotnet/runtime/pull/50741#issuecomment-
814495815.
SingleAccretion [Thu, 12 May 2022 11:26:39 +0000 (14:26 +0300)]
Fix `impBoxPatternMatch` (#68382)
Peter Sollich [Thu, 12 May 2022 10:38:16 +0000 (12:38 +0200)]
I noticed some initalization were missing at the beginning of ProcessStressLog(). (#69176)
The effect is that some command line options appear sticky, e.g. if you give a filter, run, and rerun without it, it will still take effect
Jakob Botsch Nielsen [Thu, 12 May 2022 08:50:50 +0000 (10:50 +0200)]
Disable k-nucleotide-9 in llvmfullaot (#69173)
Viktor Hofer [Thu, 12 May 2022 07:22:26 +0000 (09:22 +0200)]
Define convention to consume and/or package analyzers (#69069)
* Define convention to include analyzers in ref pack
Fixes https://github.com/dotnet/runtime/issues/61321
Until now we required source libraries to define ProjectReferences when
an analyzer should be part of the shared framework. That strategy causes
analyzer projects to leak into the ProjectReference closure and by that
into a solution file.
As an example:
When another library references the source library that references the
analyzer, the analyzer is part of the dependency closure even though it
might not be required.
This change makes it possible to define the shared framework analyzer
projects in the NetCoreAppLibrary.props file for both the .NETCoreApp,
and the AspNetCoreApp shared framework.
Out-of-band projects which ship analyzers inside their produced package,
continue to reference the analyzers via the `AnalyzerProject` item.
* Use AnalyzerReference consistently
* Don't reference analyzer when its packaged
* Fix P2P reference
* Fix multi target roslyn component target condition
Viktor Hofer [Thu, 12 May 2022 05:52:45 +0000 (07:52 +0200)]
Fix linker tests not running and show full path during trimming test execution (#69118)
* Show full path during trimming test execution
Fixes https://github.com/dotnet/runtime/issues/38377. Also addresses @danmoseley's additional feedback regarding separating the "..." from the path.
* Fix linker tests not running
Update tests.proj
Update InvariantGlobalizationTrue.cs
Elinor Fung [Thu, 12 May 2022 05:03:58 +0000 (22:03 -0700)]
Pull out some common code snippets for custom struct marshalling tests (#69215)
* Pull out some common code snippets for custom struct marshalling tests
Elinor Fung [Thu, 12 May 2022 01:53:44 +0000 (18:53 -0700)]
Fix message about missing constructor for CallerAllocatedBuffer support (#69216)
Filip Navara [Thu, 12 May 2022 00:48:56 +0000 (02:48 +0200)]
Fix NTAuthentication.MakeSignature/VerifySignature on Linux (#65679)
* Add NTLM MakeSignature test, fix the output on Linux
* Add test for VerifySignature, make it working on macOS
* Use utf-8 string literals
SingleAccretion [Thu, 12 May 2022 00:18:38 +0000 (03:18 +0300)]
Do not discard byref zeros in `native int + byref` additions (#68086)
* Delete morph transform
* Reinstate assert
Tanner Gooding [Thu, 12 May 2022 00:12:08 +0000 (17:12 -0700)]
Treat System.Runtime.CompilerServices.Unsafe as intrinsic (#68739)
* Treat System.Runtime.CompilerServices.Unsafe as intrinsic
* Remove duplicated logic from Get_CORINFO_SIG_INFO
* Don't create a multiply node if the size is 1
* Remove unnecessary impBashVarAddrsToI calls over gtNewIconNode
* Use `#ifdef TARGET_64BIT` rather than `#if (REGSIZE_BYTES == 8)`
* Don't unnecessarily call `genActualType(TYP_U_IMPL)`, just use `TYP_I_IMPL` directly
* Only insert casts for `TYP_INT` to `TYP_I_IMPL` or `TYP_U_IMPL` on 64-bit
* Have Unsafe.SkipInit create a `GT_NO_OP` node
* Have Unsafe.Subtract and Unsafe.SubtractByteOffset be intrinsic
* Adding a couple `CLANG_FORMAT_COMMENT_ANCHOR;` to comments that precede an `#ifdef`
* Applying formatting patch
* Revert "Have Unsafe.Subtract and Unsafe.SubtractByteOffset be intrinsic"
This reverts commit
2301adc9e44145a11ce5184e3146f7df7d3afdcc.
* Fixing the operand evaluation order for NI_SRCS_UNSAFE_Add
* Fixing the operand evaluation order for NI_SRCS_UNSAFE_ByteOffset
* Implement NI_SRCS_UNSAFE_SubtractByteOffset
* Fix the build failure
* Ensure impImplicitIorI4Cast is called on op2 for NI_SRCS_UNSAFE_Add
* Don't declare a `tmp` in NI_SRCS_UNSAFE_Add to make the logic clearer
* Have NI_SRCS_UNSAFE_SkipInit return gtNewNothingNode
* Handle side effects for NI_SRCS_UNSAFE_SkipInit
* Revert "Implement NI_SRCS_UNSAFE_SubtractByteOffset"
This reverts commit
7166b2e0dcc6ed267e15a0e474c6ce3f0c54c3b7.
* Manually simplify some of the NI_SRCS_* import logic
* Ensure NI_SRCS_SkipInit returns the unused node when its side-effecting
* Remove unnecessary comment anchors
* Applying formatting patch
* Try to workaround the JIT issue by spilling op1/op2 for Unsafe.Add
* Apply formatting patch
* Revert "Try to workaround the JIT issue by spilling op1/op2 for Unsafe.Add"
* Have Unsafe.Subtract and Unsafe.SubtractByteOffset be intrinsic
This reverts commit
982660eb015641a095cb9a0baf2dc93655cf1e5d.
Will Smith [Wed, 11 May 2022 23:48:23 +0000 (16:48 -0700)]
Enable UMOD optimization for x64 (#68091)
Kunal Pathak [Wed, 11 May 2022 23:18:55 +0000 (16:18 -0700)]
Reset the bbNatLoopNum of block for removed loop (#68804)
* Reset the bbNatLoopNum of block for removed loop
* review comments
* Update the lpParent too:
* Remove the assertion
* review comments
dotnet-maestro[bot] [Wed, 11 May 2022 22:13:55 +0000 (15:13 -0700)]
[main] Update dependencies from dotnet/linker (#69128)
* Update dependencies from https://github.com/dotnet/linker build
20220509.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22256.1 -> To Version 7.0.100-1.22259.1
* Update dependencies from https://github.com/dotnet/linker build
20220510.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22256.1 -> To Version 7.0.100-1.22260.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
SingleAccretion [Wed, 11 May 2022 21:09:01 +0000 (00:09 +0300)]
Fold range checks with constant operands (#69056)
Addresses an old TODO-CQ from a refactoring change.
David Mason [Wed, 11 May 2022 20:33:50 +0000 (13:33 -0700)]
Update perf map docs (#68181)
* update doc
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Kunal Pathak [Wed, 11 May 2022 19:18:06 +0000 (12:18 -0700)]
Loop alignment: Fix loop size calculation to exclude IG's size that are marked as not aligned (#68869)
* Flag to track IGs whose alignment was removed
* Update src/coreclr/jit/emit.cpp
Co-authored-by: Wraith <wraith2@gmail.com>
* Fix for 65988: Unmark the firstBB as not aligned
* Add test case for #65690
* Replace IGF_REMOVE_FLAG with different logic
* improve loops natvis
* Add back IGF_REMOVED_ALIGN
* review comments
Co-authored-by: Wraith <wraith2@gmail.com>
Elinor Fung [Wed, 11 May 2022 19:02:26 +0000 (12:02 -0700)]
Fix error on return value marshalling without CustomTypeMarshallerDirection.In (#69189)
David Wrighton [Wed, 11 May 2022 18:12:29 +0000 (11:12 -0700)]
Add Arm64 PGO Builds (#66867)
- Add PGO for arm64
- Switch to using compiler container images which support PGO compilation on Arm64
anthonycanino [Wed, 11 May 2022 17:08:32 +0000 (10:08 -0700)]
Add X86Serialize hardware intrinsic. (#68677)
Jan Kotas [Wed, 11 May 2022 15:41:15 +0000 (08:41 -0700)]
StringMarshaller optimizations (#69035)
* StringMarshaller optimizations
- Make the StringMarshallers smaller. They do not need to store the full stackallocated Span.
- Use the stack allocated buffer more often.
- Other fixes for consistency
* Delete Utf16StringMarshaller constructor that takes caller allocated buffer
* Update src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/Utf16StringMarshaller.cs
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Joni Aromaa [Wed, 11 May 2022 15:02:57 +0000 (18:02 +0300)]
Adjust the usage of ReverseEndianness in BinaryPrimitives (#69063)
Marie Píchová [Wed, 11 May 2022 14:29:45 +0000 (16:29 +0200)]
"[QUIC] Adopted msquic generated interop (#68288)" attempt no 2 (#69009)
* Revert "Revert "[QUIC] Adopted msquic generated interop (#68288)" (#68940)"
This reverts commit
4820674a4471872d742c380f38e766b80dc79385.
* Exclude S.N.Quic from Mono AOT
* Fix #68954
Aaron Robinson [Wed, 11 May 2022 14:25:16 +0000 (07:25 -0700)]
Support strictly blittable type marshalling (#69100)
* Support strictly blittable type marshalling
* Update design document.
* Add test to validate check for blittability for assembly reference
dotnet-maestro[bot] [Wed, 11 May 2022 13:58:38 +0000 (09:58 -0400)]
Update dependencies from https://github.com/dotnet/hotreload-utils build
20220509.2 (#69131)
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.1.0-alpha.0.22252.2 -> To Version 1.1.0-alpha.0.22259.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Radek Zikmund [Wed, 11 May 2022 13:28:45 +0000 (06:28 -0700)]
Don't return SslStreamBuffer when disposing during handshake (#68956)
* Don't return SslStreamBuffer when disposing during handshake
* Update src/libraries/System.Net.Security/src/System/Net/Security/SslStream.IO.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Viktor Hofer [Wed, 11 May 2022 11:37:12 +0000 (13:37 +0200)]
Error if a reference assembly is platform specific (#69116)
Fixes https://github.com/dotnet/runtime/issues/29154. I didn't introduce a new target to keep the validation cost as low as possible.
SingleAccretion [Wed, 11 May 2022 09:40:50 +0000 (12:40 +0300)]
Copy propagate on `LCL_FLD`s (#68592)
Levi Broderick [Wed, 11 May 2022 06:23:22 +0000 (23:23 -0700)]
Call simpler overloads of Substring and Slice (#68937)
Jim Daly [Wed, 11 May 2022 03:53:15 +0000 (20:53 -0700)]
Removing comments so won't overwrite doc changes (#69089)
* Removing comments so won't overwrite doc changes
* removing comments from two more places as directed
Andy Ayers [Wed, 11 May 2022 01:43:54 +0000 (18:43 -0700)]
JIT: fix issue with assert seen in OSR+PGO tests (#69067)
Update `IsIconHandle` to work for all tree types.
Closes #69032.
Tanner Gooding [Wed, 11 May 2022 00:35:25 +0000 (17:35 -0700)]
Updating BigInteger to implement IBinaryInteger and ISignedNumber (#68964)
* Updating BigInteger to implement the generic math interfaces
* Adding generic math tests for BigInteger
* Addressing PR feedback
David Cantú [Tue, 10 May 2022 23:54:57 +0000 (16:54 -0700)]
CreateSymbolicLink PInvoke retval must be marshalled as U1 (#69150)
* CreateSymbolicLink PInvoke retval must be marshalled as U1
* Fix redundant invocations of Environment.OSVersion.Version
Viktor Hofer [Tue, 10 May 2022 23:50:22 +0000 (01:50 +0200)]
Update minimum required version of VS to 17.3 (#69162)
Fixes https://github.com/dotnet/runtime/issues/68764
The in the above issue mentioned warnings are resolved by using VS 17.3 (currently Preview1).
Jan Kotas [Tue, 10 May 2022 22:34:53 +0000 (15:34 -0700)]
Fix typo in AssemblyName handling (#69157)
Fix typo in AssemblyName handling and add test that catches the bug introduced by the typo
Stephen Toub [Tue, 10 May 2022 21:56:24 +0000 (17:56 -0400)]
Tweak Rune.DecodeFromUtf8 (#68799)
Badre BSAILA [Tue, 10 May 2022 21:41:48 +0000 (23:41 +0200)]
skip ignoring Content-Length test on NodeJs (#69109)
* skip test on ignoring Content-Length on browser
* exclude test only from nodejs
Elinor Fung [Tue, 10 May 2022 21:24:38 +0000 (14:24 -0700)]
Add doc about using local build of apphost (#69097)
Viktor Hofer [Tue, 10 May 2022 20:38:39 +0000 (22:38 +0200)]
Update generators.targets (#68860)
* Update generators.targets
Changes:
- Improve perf of LibraryImportGenerator condition and simplify it
- Use the same msbuild code styling as in other projects in src/libraries
- Update comments that were outdated
- Remove the item conditions for the regex source generator which doesn't
work well with the CPS (common project system) inside VS.
- Remove unnecessary property
* Update eng/generators.targets
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update generators.targets
* Update generators.targets
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Tomas Weinfurt [Tue, 10 May 2022 20:36:57 +0000 (13:36 -0700)]
add option to set TLS cache size (#69065)
Parker Bibus [Tue, 10 May 2022 20:19:57 +0000 (15:19 -0500)]
Perf fix maui dotnet running (#69148)
* Echo the string into a local global.json.
* Complete some final cleanup stuff.
Jakob Botsch Nielsen [Tue, 10 May 2022 19:46:58 +0000 (21:46 +0200)]
Stop keeping parent stacks for fgWalkTree and friends (#69120)
We do not use this stack anywhere that uses the generic tree walker so
avoid computing it.
Jakob Botsch Nielsen [Tue, 10 May 2022 17:59:50 +0000 (19:59 +0200)]
Increase helix job timeout for win-arm64 to 300 minutes (#69129)
Ankit Jain [Tue, 10 May 2022 17:37:40 +0000 (13:37 -0400)]
[wasm] Move `Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests` to (#69087)
the high-resource-aot build job.
Tomas Weinfurt [Tue, 10 May 2022 16:42:30 +0000 (09:42 -0700)]
skip unnecesary ALPN processing on Windows (#69103)
Bond-009 [Tue, 10 May 2022 16:41:41 +0000 (18:41 +0200)]
Avoid byte[] allocation for IPAddressUtil.IsMulticast (#68591)
Ping.RawSocket his its own inline implementaion of this, maybe this
should be consolidated somewhere?
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.RawSocket.cs
L101
Kunal Pathak [Tue, 10 May 2022 16:36:53 +0000 (09:36 -0700)]
Handle case to update loop tables when preheader is removed (#68803)
* fix preheader removal
* just check the fgBBNumMax
Peter Sollich [Tue, 10 May 2022 16:13:43 +0000 (18:13 +0200)]
Fix heap corruption issue 68443. (#69106)
This has first seen with regions, but should be an issue with segments as well.
What happened was that in revisit_written_pages, we determined the highest allocated address in a region, then obtained the dirty pages up to that high address.
In parallel, another thread allocated a new object after the high address and wrote to it.
The background GC thread saw the dirty page, but didn't explore the object because it was after its stale value for the high address. That caused some objects pointed at from the beginning of the new object to be seen as dead by background GC.
Because the allocating thread also set the card table entries, the next ephemeral GC crashed because the references from the new object were now invalid.
The fix is to refetch the high address after we have obtained the dirty pages. That way, we'll explore new objects allocated while we were getting the dirty pages. New objects allocated and written to after we obtained the dirty pages will cause more dirty pages and will thus be explored later.
My repro case that caused about a crash every two hours or so has run overnight with this fix without issues.
Bruce Forstall [Tue, 10 May 2022 15:36:59 +0000 (08:36 -0700)]
Automatically choose correct cross-compile JIT name for SPMI replay/asmdiffs (#69091)
If, say, doing asm diffs with `superpmi.py asmdiffs -target_arch arm64`,
you now don't also need to specify a correct `-jit_name`; the correct name
is chosen by default.
Larry Ewing [Tue, 10 May 2022 15:26:07 +0000 (10:26 -0500)]
Revert "Add the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefinitionAs (#69057)" (#69137)
This reverts commit
d0d7c30bbf19bae9d70343e6bb7d641dfb4e6848.
Meri Khamoyan [Tue, 10 May 2022 11:18:06 +0000 (15:18 +0400)]
49936 text json failures (#68758)
* #49936 fixed text json failures and enabled System.Text.Json\tests
Viktor Hofer [Tue, 10 May 2022 10:10:30 +0000 (12:10 +0200)]
Update testPackages.proj (#69074)
Viktor Hofer [Tue, 10 May 2022 10:10:15 +0000 (12:10 +0200)]
Update System.Net solution files (#69112)
* Update System.Net solution files
https://github.com/dotnet/runtime/commit/
8823eefe91f6b774961c32800dea977b687d7328 added a dependency onto the source project of System.Net.Security. Because of that, the closure of the System.Net.Quic and System.Net.Http solution files changed. Currently this is manual as we don't have a CI leg that makes sure that solution files are up-to-date.
* Update System.Net.Http.sln
Jérôme Laban [Tue, 10 May 2022 09:49:22 +0000 (05:49 -0400)]
fix(wasm): Discriminate satellite assemblies loading based on culture (#68195)
* fix(wasm): Discriminate satellite assemblies loading based on culture
* add `--fetch-random-delay` test parameter
* enable emscripten ASSERTIONS=1 on SatelliteAssembliesTests.ResourcesFromMainAssembly
Co-authored-by: pavelsavara <pavel.savara@gmail.com>
Viktor Hofer [Tue, 10 May 2022 08:56:34 +0000 (10:56 +0200)]
Update ApiCompat.proj (#69075)
Fixes https://github.com/dotnet/runtime/issues/68730 but keeps the separate `ValidateBaseline` property as it might be useful to disable the baseline validation again in the future.
Tarun047 [Tue, 10 May 2022 08:08:21 +0000 (13:38 +0530)]
Implement JsonContext and JsonTypeInfo Overloads for Binary Data (#69012)
dotnet bot [Tue, 10 May 2022 07:32:01 +0000 (00:32 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1761806 (#69088)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1761331
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1761597
Thefrank [Tue, 10 May 2022 07:31:38 +0000 (00:31 -0700)]
Remove Hardlink workaround under FreeBSD (#69102)
No longer needed and https://github.com/dotnet/runtime/issues/3335 and https://github.com/dotnet/core-setup/issues/4742 are now closed
Ankit Jain [Tue, 10 May 2022 04:53:14 +0000 (00:53 -0400)]
Reenable `System.Runtime.Serialization.Xml.Tests` (#68921)
* Reenable `System.Runtime.Serialization.Xml.Tests`
This was disabled due to https://github.com/dotnet/runtime/issues/59926,
which was then tracked by https://github.com/dotnet/runtime/issues/61061
.
The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one - `DCS_DeeplyLinkedData`.
* Disable the test with `SkipOnPlatform` instead, for wasm, as it is
.. unlikely to be fixed (- vargaz).
Ankit Jain [Tue, 10 May 2022 04:34:01 +0000 (00:34 -0400)]
[wasm][debugger][tests] Fix crash in `EvaluateOnCallFrameTests` on CI (#69073)
* Clean up debug messages
* [wasm][debugger][tests] Allow MonoProxy instances to get gc'ed
In `TestHarnessProxy`, we recently started adding proxy instances to a
static table, to enable getting the correct exit state from the client.
But the instances were not removed from the table, which prevented the
GC from collecting them.
This manifests as the test process crashing on systems with 8GB of
memory, when running `EvaluateOnCallFrameTests`. It would end up getting
to a resident size of 2.2-2.7G, and then crash after about 30 tests. With these changes, the
proxy gets collected, and the resident memory hovers around 500M.
Future work: this will change once we start using the upcoming app host
work, and thus moving the proxy to a separate process via `dotnet run
--debug`.
Stephen Toub [Tue, 10 May 2022 03:10:46 +0000 (23:10 -0400)]
Allow some lazy loops to upgrade with auto-atomicity (#68989)
* Allow some lazy loops to upgrade with auto-atomicity
* Update RegexNode.cs
dotnet-maestro[bot] [Tue, 10 May 2022 01:42:57 +0000 (20:42 -0500)]
[main] Update dependencies from dotnet/hotreload-utils (#67905)
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20220411.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22211.2
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20220418.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22218.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20220425.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22225.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20220426.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22226.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20220502.2
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22252.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Elinor Fung [Tue, 10 May 2022 00:54:40 +0000 (17:54 -0700)]
Remove coverlet.collector reference from LibraryImportGenerator tests (#69078)
Zoltan Varga [Tue, 10 May 2022 00:40:31 +0000 (20:40 -0400)]
[mono] Avoid an assertion when cattrs with array parameters are constructed during AOT. (#69077)
Fixes https://github.com/dotnet/runtime/issues/57361.
Jan Kotas [Tue, 10 May 2022 00:09:23 +0000 (17:09 -0700)]
Fix namespace in error message (#69083)
DisableRuntimeMarshallingAttribute is under System.Runtime.CompilerServices
Lakshan Fernando [Mon, 9 May 2022 22:19:44 +0000 (15:19 -0700)]
Add the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefinitionAs (#69057)
* Fix for issue 67533
* FB
dotnet-maestro[bot] [Mon, 9 May 2022 19:39:40 +0000 (14:39 -0500)]
[main] Update dependencies from 7 repositories (#68126)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20220416.9
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.22215.3 -> To Version 1.0.0-prerelease.22216.9
* Update dependencies from https://github.com/dotnet/runtime build
20220417.5
runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.4.22217.5
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20220417.3
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.22215.3 -> To Version 1.0.0-prerelease.22217.3
* Update dependencies from https://github.com/dotnet/icu build
20220418.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.4.22218.1
* Update dependencies from https://github.com/dotnet/xharness build
20220419.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22219.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220418.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22218.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20220418.2
runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22218.2
* Update dependencies from https://github.com/dotnet/icu build
20220419.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22219.2
* Update dependencies from https://github.com/dotnet/emsdk build
20220419.2
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22219.2
* Update dependencies from https://github.com/dotnet/xharness build
20220420.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22220.1
* Update dependencies from https://github.com/dotnet/runtime build
20220424.3
runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22224.3
* Update dependencies from https://github.com/dotnet/icu build
20220425.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22225.1
* Update dependencies from https://github.com/dotnet/xharness build
20220425.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22225.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220425.1
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22225.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20220425.2
runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22225.2
* Update dependencies from https://github.com/dotnet/xharness build
20220426.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22226.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20220426.1
runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22226.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220429.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22229.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220430.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22230.1
* Update dependencies from https://github.com/dotnet/runtime build
20220501.6
runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22251.6
* Update dependencies from https://github.com/dotnet/xharness build
20220502.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22252.1
* Update dependencies from https://github.com/dotnet/icu build
20220502.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22252.1
* Update dependencies from https://github.com/dotnet/xharness build
20220503.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22253.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220502.1
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22252.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220502.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22252.2
* Update dependencies from https://github.com/dotnet/llvm-project build
20220502.1
runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter
From Version 1.0.0-alpha.1.22204.1 -> To Version 1.0.0-alpha.1.22252.1
* Update dependencies from https://github.com/dotnet/xharness build
20220503.2
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22253.2
* Update dependencies from https://github.com/dotnet/xharness build
20220504.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22254.1
* Update dependencies from https://github.com/dotnet/xharness build
20220506.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22256.1
* Update dependencies from https://github.com/dotnet/xharness build
20220506.2
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22256.2
* Update dependencies from https://github.com/dotnet/runtime build
20220508.4
runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22258.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Egor Bogatov <egorbo@gmail.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Zoltan Varga [Mon, 9 May 2022 19:26:51 +0000 (15:26 -0400)]
[mono][arm64] Save the full 128 bit simd argument registers in the trampoline code. (#68997)
SingleAccretion [Mon, 9 May 2022 18:39:58 +0000 (21:39 +0300)]
Mark "push [mem]" candidates reg optional (#68641)
Badre BSAILA [Mon, 9 May 2022 18:38:44 +0000 (20:38 +0200)]
format correctly chuncked response with Content-Length header (#69016)
SingleAccretion [Mon, 9 May 2022 18:08:06 +0000 (21:08 +0300)]
Initialize "VNFuncApp.m_func" in "VNForBitCast" (#69051)
Jakob Botsch Nielsen [Mon, 9 May 2022 17:23:46 +0000 (19:23 +0200)]
Fix formatting job on windows (#69054)
Kevin Jones [Mon, 9 May 2022 15:38:36 +0000 (11:38 -0400)]
Remove an allocation during CNG RSA key generation
Spanify CngProperty to remove a temporary `new byte[4]`.
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Andy Ayers [Mon, 9 May 2022 15:10:19 +0000 (08:10 -0700)]
JIT: minor enhancement to jump threading (#69022)
Allow jump threading of branches with exceptions, provided the branch and the
dominating branch are in the same EH region.
Adeel Mujahid [Mon, 9 May 2022 14:21:29 +0000 (17:21 +0300)]
Specify action permissions in cleanup task (#69014)
Steve Harter [Mon, 9 May 2022 14:11:28 +0000 (09:11 -0500)]
Add IL Emit support for MethodInfo.Invoke() and friends (#67917)
Adeel Mujahid [Mon, 9 May 2022 11:56:12 +0000 (14:56 +0300)]
Fix packs.product subset build with gcc (#68998)
Jakob Botsch Nielsen [Mon, 9 May 2022 09:57:04 +0000 (11:57 +0200)]
Remove GT_PUTARG_TYPE (#68748)
This change removes GT_PUTARG_TYPE by storing the signature type of the argument inside CallArg right away when arguments are added, instead of only from morph and on.