profile/ivi/webkit-efl.git
13 years agoRename flex-align values to match the spec
tony@chromium.org [Sat, 17 Sep 2011 02:40:27 +0000 (02:40 +0000)]
Rename flex-align values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=67741

Reviewed by Ojan Vafai.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[V8] REGRESSION(94783): calling the binding script during V8 context creation slows...
commit-queue@webkit.org [Sat, 17 Sep 2011 02:31:00 +0000 (02:31 +0000)]
[V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-16
Reviewed by Kenneth Russell.

Call the binding script lazily on the first run of the set() method of
a typed array.

* ../../Source/WebCore/WebCore.gypi:
* ../../Source/WebCore/bindings/v8/V8BindingScripts.cpp: Removed.
* ../../Source/WebCore/bindings/v8/V8BindingScripts.h: Removed.
* ../../Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
* ../../Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium pixel test rebaseline for r95335.
rniwa@webkit.org [Sat, 17 Sep 2011 02:24:26 +0000 (02:24 +0000)]
Chromium pixel test rebaseline for r95335.

* platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-win-vista/editing: Removed.
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImplement an ErrorEvent constructor for JSC
commit-queue@webkit.org [Sat, 17 Sep 2011 02:01:29 +0000 (02:01 +0000)]
Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-16
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ErrorEvent constructor is here:
http://dev.w3.org/html5/workers/#errorevent

Test: fast/events/constructors/error-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent.
* dom/ErrorEvent.cpp:
(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::initErrorEvent):
(WebCore::ErrorEvent::isErrorEvent):
* dom/ErrorEvent.h: Added a definition for ErrorEventInit.
(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::message):
(WebCore::ErrorEvent::filename):
(WebCore::ErrorEvent::lineno):
* dom/ErrorEvent.idl: Makes ErrorEvent constructible.

LayoutTests:

error-event-constructor.html checks the behavior of the ErrorEvent constructor.

* fast/dom/constructed-objects-prototypes-expected.txt: Now window has ErrorEvent.
* fast/events/constructors/error-event-constructor-expected.txt: Added.
* fast/events/constructors/error-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped error-event-constructor.html, since V8 does not yet have the ErrorEvent constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCORS images viewed from different domains fail security checks
abarth@webkit.org [Sat, 17 Sep 2011 01:47:36 +0000 (01:47 +0000)]
CORS images viewed from different domains fail security checks
https://bugs.webkit.org/show_bug.cgi?id=68011

Reviewed by Darin Adler.

I am unable to reproduce the bug, but the test I wrote in the process
might be worth having anyway.

* http/tests/security/canvas-cors-with-two-hosts-expected.txt: Added.
* http/tests/security/canvas-cors-with-two-hosts.html: Added.
* http/tests/security/resources/canvas-cors-subtest.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOverhangs a ruby by no more than half the width of the neighboring text.
haraken@google.com [Sat, 17 Sep 2011 01:36:07 +0000 (01:36 +0000)]
Overhangs a ruby by no more than half the width of the neighboring text.
https://bugs.webkit.org/show_bug.cgi?id=62684

Reviewed by Dan Bernstein.

Assume two rubies between which a narrow text exists, like
"<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>".
In order to avoid the two rubies overlapping with each other,
this patch overhangs the ruby by no more than half the ruby font
size and no more than half the width of the neighboring text.

Source/WebCore:

Tests: fast/ruby/overhang-horizontal-no-overlap1.html
       fast/ruby/overhang-horizontal-no-overlap2.html
       fast/ruby/overhang-vertical-no-overlap1.html
       fast/ruby/overhang-vertical-no-overlap2.html

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging.

LayoutTests:

* fast/ruby/overhang-horizontal-no-overlap1-expected.png: Added.
* fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Added.
* fast/ruby/overhang-horizontal-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* fast/ruby/overhang-horizontal-no-overlap2-expected.png: Added.
* fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Added.
* fast/ruby/overhang-horizontal-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* fast/ruby/overhang-vertical-no-overlap1-expected.png: Added.
* fast/ruby/overhang-vertical-no-overlap1-expected.txt: Added.
* fast/ruby/overhang-vertical-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* fast/ruby/overhang-vertical-no-overlap2-expected.png: Added.
* fast/ruby/overhang-vertical-no-overlap2-expected.txt: Added.
* fast/ruby/overhang-vertical-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Removed.
* platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Removed.
* platform/chromium/test_expectations.txt: Skips overhang-horizontal.html.  We will update the result image as a rebase line.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r95304.
rniwa@webkit.org [Sat, 17 Sep 2011 01:32:10 +0000 (01:32 +0000)]
Unreviewed, rolling out r95304.
http://trac.webkit.org/changeset/95304
https://bugs.webkit.org/show_bug.cgi?id=68299

Broke GTK+ builds. It pulls derived headers into main.c
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* bindings/scripts/CodeGeneratorGObject.pm:
():
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRe-named isRootLayer to isNonCompositedContent because
commit-queue@webkit.org [Sat, 17 Sep 2011 01:14:47 +0000 (01:14 +0000)]
Re-named isRootLayer to isNonCompositedContent because
that is what the flag actually means.
https://bugs.webkit.org/show_bug.cgi?id=68214

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsNonCompositedContent):
(WebCore::LayerChromium::isNonCompositedContent):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setIsNonCompositedContent):
(WebCore::CCLayerImpl::isNonCompositedContent):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
simon.fraser@apple.com [Sat, 17 Sep 2011 01:12:48 +0000 (01:12 +0000)]
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Source/WebCore:

Reviewed by Sam Weinig.

Add a new setting to control whether the mock scrollbar theme is used.
This is a global setting, so that it can be set without having to
access a specific Settings object.

* page/Settings.h:
(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::mockScrollbarsEnabled):

Source/WebKit/mac:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences mockScrollbarsEnabled]):
(-[WebPreferences setMockScrollbarsEnabled:]):
* WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMockScrollbarsEnabled):
(WKPreferencesGetMockScrollbarsEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLarge canvas fills should not crash or create unnecessarily large image buffers
commit-queue@webkit.org [Sat, 17 Sep 2011 01:02:45 +0000 (01:02 +0000)]
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas. If the area of intersection between the fill and the
canvas is empty the canvas is completely cleared and a temporary buffer is not used.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

Test: fast/canvas/canvas-large-fills.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

* fast/canvas/canvas-large-fills-expected.txt: Added.
* fast/canvas/canvas-large-fills.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove default NULL argument in LayerChromium::create().
commit-queue@webkit.org [Sat, 17 Sep 2011 00:50:28 +0000 (00:50 +0000)]
Remove default NULL argument in LayerChromium::create().
https://bugs.webkit.org/show_bug.cgi?id=68211

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

* platform/graphics/chromium/LayerChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Rebaseline fix up due to r95239.
levin@chromium.org [Sat, 17 Sep 2011 00:45:50 +0000 (00:45 +0000)]
[chromium] Rebaseline fix up due to r95239.

Add back in a baseline that was removed in my last change.

* platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the rebaseline in r95325 and also rebaseline for r95335.
rniwa@webkit.org [Sat, 17 Sep 2011 00:44:34 +0000 (00:44 +0000)]
Fix the rebaseline in r95325 and also rebaseline for r95335.

* inspector/styles/styles-update-from-js-expected.txt:
* platform/chromium/test_expectations.txt
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
enne@google.com [Sat, 17 Sep 2011 00:33:09 +0000 (00:33 +0000)]
[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272

Reviewed by James Robinson.

All the OpenGL code is in LayerRendererChromium and the CCLayerImpl
tree, so move the static drawTexturedQuad/toGLMatrix functions to
LayerRendererChromium, where they really belong.

Just moving code around. Tested by existing compositor tests.

* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::drawDebugBorder):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCleanup JSTypeInfo a bit
weinig@apple.com [Sat, 17 Sep 2011 00:22:50 +0000 (00:22 +0000)]
Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289

Reviewed by Anders Carlsson.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.

* runtime/JSObject.h:
(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.

* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.

(JSC::TypeInfo::isFinalObject):
Added.

(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
Use new isFinalObject() predicate.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoStop installing source and header files in to WebKit2.framework after r95303.
mrowe@apple.com [Sat, 17 Sep 2011 00:22:37 +0000 (00:22 +0000)]
Stop installing source and header files in to WebKit2.framework after r95303.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnsigned bit shift fails under certain conditions in 32 bit builds
barraclough@apple.com [Sat, 17 Sep 2011 00:20:24 +0000 (00:20 +0000)]
Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166

Reviewed by Geoff Garen.

Source/JavaScriptCore:

The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate).  The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).

* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):

LayoutTests:

Added layout test.

* fast/js/floating-point-truncate-rshift-expected.txt:
* fast/js/floating-point-truncate-rshift.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd the forgotten test, also suppress a test in Chromium as it needs a rebaseline.
rniwa@webkit.org [Sat, 17 Sep 2011 00:08:06 +0000 (00:08 +0000)]
Add the forgotten test, also suppress a test in Chromium as it needs a rebaseline.

* platform/chromium/test_expectations.txt:
* editing/deleting/merge-paragraph-into-blockquote-expected.txt: Added.
* editing/deleting/merge-paragraph-into-blockquote.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed const correctness on accessors in LayerChromium
commit-queue@webkit.org [Sat, 17 Sep 2011 00:07:18 +0000 (00:07 +0000)]
Fixed const correctness on accessors in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68210

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::replicaLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDeleting line break before h1 converts h1 to span
rniwa@webkit.org [Sat, 17 Sep 2011 00:00:07 +0000 (00:00 +0000)]
Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote.

We already had a logic to overriding styles of merged paragraphs by Mail blockquote so
just extend this logic for h1-h6, pre, etc...

Tests: editing/deleting/merge-paragraph-from-address.html
       editing/deleting/merge-paragraph-from-h6-with-style.html
       editing/deleting/merge-paragraph-from-h6.html
       editing/deleting/merge-paragraph-from-listing.html
       editing/deleting/merge-paragraph-into-h1-with-style.html
       editing/deleting/merge-paragraph-into-h1.html
       editing/deleting/merge-paragraph-into-pre.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* editing/markup.cpp:
(WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance.
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
* editing/markup.h:

LayoutTests:

Added a bunch of tests to ensure WebKit does not keep block elements' style when merging paragraphs.
When removing line breaks between <h1>hello</h1>world and hello<pre>world</pre> for example,
we should not be overriding and preserving styles from h1 in the merge paragraph respectively.

* editing/deleting/merge-paragraph-from-address-expected.txt: Added.
* editing/deleting/merge-paragraph-from-address.html: Added.
* editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
* editing/deleting/merge-paragraph-from-h6.html: Added.
* editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
* editing/deleting/merge-paragraph-from-listing.html: Added.
* editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
* editing/deleting/merge-paragraph-into-h1.html: Added.
* editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
* editing/deleting/merge-paragraph-into-pre.html: Added.
* platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Create WebGL layer for graphics contexts on demand
nduca@chromium.org [Fri, 16 Sep 2011 23:33:23 +0000 (23:33 +0000)]
[chromium] Create WebGL layer for graphics contexts on demand
https://bugs.webkit.org/show_bug.cgi?id=68288

Reviewed by James Robinson.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
* src/GraphicsContext3DPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSet but not used variables cleanup (gcc 4.6)
commit-queue@webkit.org [Fri, 16 Sep 2011 23:24:34 +0000 (23:24 +0000)]
Set but not used variables cleanup (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68157

Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-16
Reviewed by Darin Adler.

* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::process):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Rebaseline fix up due to r95239.
levin@chromium.org [Fri, 16 Sep 2011 23:07:43 +0000 (23:07 +0000)]
[chromium] Rebaseline fix up due to r95239.

Expectation removal due to r95322 and r95325.

 * platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-cg-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-cg-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-cg-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-linux/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.txt: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
 * platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemoved undetectable style.filter.
ggaren@apple.com [Fri, 16 Sep 2011 23:02:43 +0000 (23:02 +0000)]
Removed undetectable style.filter.

Reviewed by Sam Weinig.

This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.

Source/JavaScriptCore:

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSTypeInfo.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.

Source/WebCore:

* ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
* WebCore.order:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):

LayoutTests:

* fast/dom/undetectable-style-filter-expected.txt: Removed.
* fast/dom/undetectable-style-filter.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-09-16 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 16 Sep 2011 22:50:44 +0000 (22:50 +0000)]
2011-09-16  Rob Buis  <rbuis@rim.com>

        Add Eli's rim address and change the nick.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r95317.
commit-queue@webkit.org [Fri, 16 Sep 2011 22:29:56 +0000 (22:29 +0000)]
Unreviewed, rolling out r95317.
http://trac.webkit.org/changeset/95317
https://bugs.webkit.org/show_bug.cgi?id=68282

Remove newly added overlapping test expectations. (Requested
by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] compilation failed in target 'webkit_unit_tests'.
commit-queue@webkit.org [Fri, 16 Sep 2011 22:27:29 +0000 (22:27 +0000)]
[chromium] compilation failed in target 'webkit_unit_tests'.
https://bugs.webkit.org/show_bug.cgi?id=68078

Patch by chandra shekar v <chandra.vallala@motorola.com> on 2011-09-16
Reviewed by Adam Barth.

* tests/WebFrameTest.cpp:
(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate JSC results to account for intrinsics change.
abarth@webkit.org [Fri, 16 Sep 2011 22:02:37 +0000 (22:02 +0000)]
Update JSC results to account for intrinsics change.

* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPrepare JSTypes for more Object subtypes
weinig@apple.com [Fri, 16 Sep 2011 21:34:20 +0000 (21:34 +0000)]
Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200

Reviewed by Gavin Barraclough.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
* runtime/JSObject.h:
(JSC::JSObject::finishCreation):
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/Operations.cpp:
(JSC::jsIsObjectType):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::isObject):
(JSC::JSCell::isObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRebaseline from r95242.
rniwa@webkit.org [Fri, 16 Sep 2011 21:12:03 +0000 (21:12 +0000)]
Rebaseline from r95242.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRolled back in r95201 with test failure fixed.
ggaren@apple.com [Fri, 16 Sep 2011 21:05:09 +0000 (21:05 +0000)]
Rolled back in r95201 with test failure fixed.

I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.

* jit/JIT.h:
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace use of access to nodeList using call, with array style notation.
weinig@apple.com [Fri, 16 Sep 2011 20:59:25 +0000 (20:59 +0000)]
Replace use of access to nodeList using call, with array style notation.

* editing/pasteboard/paste-noscript.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agohttp/tests/history/back-with-fragment-change.php fails on non-Chromium bots
mihaip@chromium.org [Fri, 16 Sep 2011 20:43:41 +0000 (20:43 +0000)]
http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

* http/tests/history/back-with-fragment-change.php:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed Windows build fix after 95318.
fpizlo@apple.com [Fri, 16 Sep 2011 20:42:19 +0000 (20:42 +0000)]
Unreviewed Windows build fix after 95318.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r95312.
commit-queue@webkit.org [Fri, 16 Sep 2011 20:33:55 +0000 (20:33 +0000)]
Unreviewed, rolling out r95312.
http://trac.webkit.org/changeset/95312
https://bugs.webkit.org/show_bug.cgi?id=68277

It's innocent, innocent I tell you! (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::beginCommitOnCCThread):
(WTF::TestHooks::commitCompleteOnCCThread):
(WTF::TestHooks::drawLayersOnCCThread):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayers):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::create):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::createCompositorThread):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::createRootLayerPainter):
(WTF::MockLayerTreeHostClient::didRecreateGraphicsContext):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(WTF::CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWindows build fix after r95310
aroben@apple.com [Fri, 16 Sep 2011 20:33:38 +0000 (20:33 +0000)]
Windows build fix after r95310

* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added include\private\JavaScriptCore to the
include path so DFGIntrinsic.h can be found.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRationalize JSObject::putDirect* methods
barraclough@apple.com [Fri, 16 Sep 2011 20:32:15 +0000 (20:32 +0000)]
Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274

Reviewed by Sam Weinig.

Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.

* JavaScriptCore.exp:
* jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
* runtime/JSObject.h:
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::lookupPut):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed; new expectations (Skia on Mac)
caryclark@google.com [Fri, 16 Sep 2011 20:22:20 +0000 (20:22 +0000)]
Unreviewed; new expectations (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac (Leopard only).

* LayoutTests/platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed build fix for Windows.
fpizlo@apple.com [Fri, 16 Sep 2011 20:18:46 +0000 (20:18 +0000)]
Unreviewed build fix for Windows.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preser...
andersca@apple.com [Fri, 16 Sep 2011 20:12:07 +0000 (20:12 +0000)]
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269

Reviewed by Geoffrey Garen.

Source/WebKit2:

Add back WKPageMouseDidMoveOverElementCallback last and deprecate the current callback.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

Update client function signatures.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUIClientInit):
* MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Give local builds of WebProcess different icon to distinguish them from built...
ap@apple.com [Fri, 16 Sep 2011 20:06:00 +0000 (20:06 +0000)]
    Give local builds of WebProcess different icon to distinguish them from built-in Safariâ\80\99s WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=68268

        Reviewed by Darin Adler.

        * Configurations/WebProcess.xcconfig: Add an icon in Debug and Release builds.  The empty
        value for production resulted in WebKit not adding the key to plist at all, which is what
        we want (but I don't know if it's a supported feature).
        Also, don't copy the icon file to built framework in production builds.

        * WebKit2.xcodeproj/project.pbxproj: Added WebKit.icns.

        * WebProcess/Info.plist: Added a key for the icon.

        * WebProcess/mac/WebKit.icns: Copied from Websites/webkit.org/images/surfin-safari.icns.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed build fix for non-DFG builds.
fpizlo@apple.com [Fri, 16 Sep 2011 20:05:29 +0000 (20:05 +0000)]
Unreviewed build fix for non-DFG builds.

* runtime/Executable.h:
(JSC::NativeExecutable::finishCreation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r95309.
commit-queue@webkit.org [Fri, 16 Sep 2011 20:05:01 +0000 (20:05 +0000)]
Unreviewed, rolling out r95309.
http://trac.webkit.org/changeset/95309
https://bugs.webkit.org/show_bug.cgi?id=68271

Broke many chromium gpu tests. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::animateAndLayout):
(WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
(WTF::CCLayerTreeHostTest::commitOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
(WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTest::updateLayers):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::doEndTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::updateLayers):
(WTF::MockLayerTreeHostCommitter::create):
(WTF::MockLayerTreeHostCommitter::commit):
(WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::create):
(WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::updateLayers):
(WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
(WTF::MockLayerTreeHost::beginCommit):
(WTF::MockLayerTreeHost::commitComplete):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTemporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
andersca@apple.com [Fri, 16 Sep 2011 19:29:07 +0000 (19:29 +0000)]
Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
https://bugs.webkit.org/show_bug.cgi?id=68266

Reviewed by John Sullivan.

Source/WebKit2:

* UIProcess/API/C/WKPage.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

* MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDFG JIT should inline Math.abs
fpizlo@apple.com [Fri, 16 Sep 2011 18:50:04 +0000 (18:50 +0000)]
DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.

On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.

Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h

This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.

* JavaScriptCore.xcodeproj/project.pbxproj:
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
* dfg/DFGIntrinsic.h: Added.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/DateInstanceCache.h:
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

Source/WebCore:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.

* CMakeLists.txt:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):

Source/WebKit:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

* CMakeLists.txt:

Source/WebKit2:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Fix CCLayerTreeHostTest
jamesr@google.com [Fri, 16 Sep 2011 18:43:37 +0000 (18:43 +0000)]
[chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418

Source/WebCore:

This is a minimal set of changes to get CCLayerTreeHostTest
compiling, running and passing with USE_THREADED_COMPOSITING
enabled.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

Fixes needed to compile and link with USE_THREADED_COMPOSITING
enabled, and to pass the basic unit test.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
* src/GraphicsContext3DPrivate.h:
* tests/CCLayerTreeHostTest.cpp:
(TestHooks::beginCommitOnCCThread):
(TestHooks::commitCompleteOnCCThread):
(TestHooks::drawLayersOnCCThread):
(MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHostImpl::beginCommit):
(MockLayerTreeHostImpl::commitComplete):
(MockLayerTreeHostImpl::drawLayers):
(MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHost::createLayerTreeHostImpl):
(CompositorMockWebGraphicsContext3D::makeContextCurrent):
(CompositorMockWebGraphicsContext3D::createProgram):
(CompositorMockWebGraphicsContext3D::createShader):
(CompositorMockWebGraphicsContext3D::getShaderiv):
(CompositorMockWebGraphicsContext3D::getProgramiv):
(MockLayerTreeHostClient::MockLayerTreeHostClient):
(MockLayerTreeHostClient::animateAndLayout):
(MockLayerTreeHostClient::createCompositorThread):
(MockLayerTreeHostClient::createLayerTreeHostContext3D):
(MockLayerTreeHostClient::createRootLayerPainter):
(MockLayerTreeHostClient::didRecreateGraphicsContext):
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(CCLayerTreeHostTest::onEndTest):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(CCLayerTreeHostTest::runTest):
(CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestShortlived3::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoREGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
fpizlo@apple.com [Fri, 16 Sep 2011 18:43:25 +0000 (18:43 +0000)]
REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220

Reviewed by Oliver Hunt.

Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.

* heap/Heap.cpp:
(JSC::Heap::markRoots):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r95227.
commit-queue@webkit.org [Fri, 16 Sep 2011 18:32:01 +0000 (18:32 +0000)]
Unreviewed, rolling out r95227.
http://trac.webkit.org/changeset/95227
https://bugs.webkit.org/show_bug.cgi?id=68262

Broke a bunch of SVG tests (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsSize):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformContentsSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-09-16 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Fri, 16 Sep 2011 18:26:24 +0000 (18:26 +0000)]
2011-09-16  James Simonsen  <simonjam@chromium.org>

        Fix HTML5 parser's adoption agency algorithm to reparent correctly
        https://bugs.webkit.org/show_bug.cgi?id=68147

        Reviewed by Eric Seidel.

        * html5lib/resources/webkit02.dat:
2011-09-16  James Simonsen  <simonjam@chromium.org>

        Fix HTML5 parser's adoption agency algorithm to reparent correctly
        https://bugs.webkit.org/show_bug.cgi?id=68147

        Reviewed by Eric Seidel.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed commit. Fix Windows and MacOSX compilation after r95303.
igor.oliveira@openbossa.org [Fri, 16 Sep 2011 18:22:21 +0000 (18:22 +0000)]
Unreviewed commit. Fix Windows and MacOSX compilation after r95303.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCodeGeneratorGObject should use C++ style comments for ENABLE guards
abarth@webkit.org [Fri, 16 Sep 2011 18:06:30 +0000 (18:06 +0000)]
CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256

Reviewed by Darin Adler.

This patch should have not behavioral effect.  It just cleans up the
GObject code generator to use C++-style comments for ENABLE guards and
to use the usual comment style for license blocks.

* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-09-16 Igor Oliveira <igor.oliveira@openbossa.org>
igor.oliveira@openbossa.org [Fri, 16 Sep 2011 17:31:31 +0000 (17:31 +0000)]
2011-09-16  Igor Oliveira  <igor.oliveira@openbossa.org>

        [WK2] mouseDidMoveOverElement needs to send more information about hovered element to UiProcess.
        https://bugs.webkit.org/show_bug.cgi?id=68125

        This patch implements support for the UiProcess to know what is the link url of a hovered element.

        Reviewed by Anders Carlsson.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        * Shared/WebHitTestResult.cpp: Added.

        WebHitTestResult has hovered element information.

        (WebKit::WebHitTestResult::create):
        (WebKit::WebHitTestResult::Data::encode):
        (WebKit::WebHitTestResult::Data::decode):
        * Shared/WebHitTestResult.h: Added.
        (WebKit::WebHitTestResult::absoluteImageURL):
        (WebKit::WebHitTestResult::absoluteLinkURL):
        (WebKit::WebHitTestResult::absoluteMediaURL):
        (WebKit::WebHitTestResult::linkLabel):
        (WebKit::WebHitTestResult::linkTitle):
        (WebKit::WebHitTestResult::WebHitTestResult):
        (WebKit::WebHitTestResult::type):
        * UIProcess/API/C/WKAPICast.h:
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::mouseDidMoveOverElement):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::mouseDidMoveOverElement):
        * UIProcess/WebUIClient.h:
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::mouseDidMoveOverElement):
        * win/WebKit2.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] REGRESSION(r95091) It made many tests flakey
ossy@webkit.org [Fri, 16 Sep 2011 17:28:00 +0000 (17:28 +0000)]
[Qt] REGRESSION(r95091) It made many tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68232

Unreviewed rolling out r95091 and followup patches.

Source/WebCore:

* English.lproj/localizedStrings.js:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
* inspector/InspectorTimelineAgent.cpp:
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
* inspector/TimelineRecordFactory.h:
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

* inspector/timeline/timeline-animation-frame-expected.txt: Removed.
* inspector/timeline/timeline-animation-frame.html: Removed.
* inspector/timeline/timeline-enum-stability-expected.txt:
* inspector/timeline/timeline-test.js:
* platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agocachedFont not getting updated for inline SVG text.
inferno@chromium.org [Fri, 16 Sep 2011 17:23:52 +0000 (17:23 +0000)]
cachedFont not getting updated for inline SVG text.
https://bugs.webkit.org/show_bug.cgi?id=68060

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The cached scaledFont needs to be updated on every style set call. It
is not similar to m_style which can get derived from parent's style and
hence will get automatically updated on ancestor's style change. This is
required, otherwise we will maintain stale font list in cached scaledFont
when custom fonts are retired on Document::recalcStyle.

Test: svg/text/text-style-recalc-crash.html

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::styleDidChange):
(WebCore::RenderSVGInlineText::setStyle):
* rendering/svg/RenderSVGInlineText.h:

LayoutTests:

* svg/text/text-style-recalc-crash-expected.txt: Added.
* svg/text/text-style-recalc-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd support for attributes on message parameters
aroben@apple.com [Fri, 16 Sep 2011 16:58:38 +0000 (16:58 +0000)]
Add support for attributes on message parameters

Parameter attributes are specified as a space-separated list inside square brackets before
the parameter's type. WebKit2 doesn't use this, but other projects that use these scripts
would like to.

Fixes <http://webkit.org/b/68219> Would like a way to specify attributes on message
parameters

Reviewed by Sam Weinig.

* Scripts/webkit2/messages_unittest.py: Added tests for parameter attributes.

* Scripts/webkit2/model.py:
(Parameter.__init__): Added a new attributes parameter, which is stored in the self.attributes
property.
(Parameter.has_attribute): Added. Returns true if this parameter has the given attribute.

* Scripts/webkit2/parser.py:
(parse): Moved attributes-parsing code from here...
(parse_attributes_string): ...to here.
(parse_parameters_string): Renamed from parse_parameter_string. Now also parses parameter
attributes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake WebKit2's message-generation model and parser scripts accessible to other projects
aroben@apple.com [Fri, 16 Sep 2011 16:58:14 +0000 (16:58 +0000)]
Make WebKit2's message-generation model and parser scripts accessible to other projects

We copy them into the build products directory so other projects can find them.

Fixes <http://webkit.org/b/68169> Would like to be able to use WebKit2's message-generation
scripts in other projects

Reviewed by Darin Adler.

* WebKit2.xcodeproj/project.pbxproj: Copy the scripts to PrivateHeaders.

* win/WebKit2.make: Copy the scripts from obj/WebKit2/scripts to
tools/scripts, like WebCore does.

* win/WebKit2Generated.make: Copy the scripts to obj/WebKit2/scripts, which is similar to what
WebCore does for its bindings scripts.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSplit some of the message-generation code into separate modules
aroben@apple.com [Fri, 16 Sep 2011 16:57:50 +0000 (16:57 +0000)]
Split some of the message-generation code into separate modules

This is in preparation for making these modules scripts usable by other projects.

Fixes <http://webkit.org/b/68217> Model and parsing functionality for WebKit2's
message-generation scripts is trapped inside a much larger module

Reviewed by Darin Adler.

* DerivedSources.make:
* DerivedSources.pro:
* GNUmakefile.am:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.vcproj:
Added new files.

* Scripts/webkit2/messages.py: Moved some code from here...

* Scripts/webkit2/model.py: Added.
* Scripts/webkit2/parser.py: Added.
...to here. MessageReceiver.parse was split out into a function in the new parser module.

* Scripts/webkit2/messages_unittest.py: Updated for renames.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSource/JavaScriptCore: REGRESSION(r95201): It made two tests fail
ossy@webkit.org [Fri, 16 Sep 2011 16:36:22 +0000 (16:36 +0000)]
Source/JavaScriptCore: REGRESSION(r95201): It made two tests fail
https://bugs.webkit.org/show_bug.cgi?id=68230

Unreviewed rolling out r95201.

* jit/JIT.h:
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
* jit/JITInlineMethods.h:

LayoutTests: Unreviewed rolling out r95277.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: UI performance tests are required.
loislo@chromium.org [Fri, 16 Sep 2011 16:26:20 +0000 (16:26 +0000)]
Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234

The idea is to create a set of tests which cover frequently used UI actions
and print the average time of these actions.
There are two pilot tests. The common part was extracted into performance-test helper.

Reviewed by Pavel Feldman.

* inspector/performance/resources/network-append-30-requests.html: Added.
* inspector/performance/resources/performance-test.js: Added.
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):
* inspector/performance/resources/show-panel-network.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoREGRESSION (r95052): SelectorChecker identifier filter not working
antti@apple.com [Fri, 16 Sep 2011 16:25:13 +0000 (16:25 +0000)]
REGRESSION (r95052): SelectorChecker identifier filter not working
https://bugs.webkit.org/show_bug.cgi?id=68244

Reviewed by Dan Bernstein.

Missing &.

* css/SelectorChecker.cpp:
(WebCore::collectDescendantSelectorIdentifierHashes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed typo fix after r95271.
ossy@webkit.org [Fri, 16 Sep 2011 16:08:43 +0000 (16:08 +0000)]
Unreviewed typo fix after r95271.

* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd Vincent Scheib to the committers list.
scheib@chromium.org [Fri, 16 Sep 2011 15:58:25 +0000 (15:58 +0000)]
Add Vincent Scheib to the committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Unreviewed gardening. Skip a flakey test.
ossy@webkit.org [Fri, 16 Sep 2011 15:50:06 +0000 (15:50 +0000)]
[Qt] Unreviewed gardening. Skip a flakey test.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Unreviewed gardening. Add Qt specific expexted results for new tests introduced...
ossy@webkit.org [Fri, 16 Sep 2011 15:42:59 +0000 (15:42 +0000)]
[Qt] Unreviewed gardening. Add Qt specific expexted results for new tests introduced in r95239.

* platform/qt/fast/clip/overflow-border-radius-combinations-expected.png: Added.
* platform/qt/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
* platform/qt/fast/clip/overflow-border-radius-composited-expected.png: Added.
* platform/qt/fast/clip/overflow-border-radius-composited-expected.txt: Added.
* platform/qt/fast/clip/overflow-border-radius-transformed-expected.png: Added.
* platform/qt/fast/clip/overflow-border-radius-transformed-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r95285.
commit-queue@webkit.org [Fri, 16 Sep 2011 15:24:51 +0000 (15:24 +0000)]
Unreviewed, rolling out r95285.
http://trac.webkit.org/changeset/95285
https://bugs.webkit.org/show_bug.cgi?id=68247

It broke a webkitpy test (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* Scripts/webkitpy/layout_tests/controllers/manager.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-09-16 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 16 Sep 2011 13:30:21 +0000 (13:30 +0000)]
2011-09-16  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] support extensions for remote inspector front-end
        https://bugs.webkit.org/show_bug.cgi?id=67840

        Reviewed by Pavel Feldman.

        - Merge ExtensionCommon.js into ExtensionAPI.js
        - refactor building of extension API for better reuse
        - expose interface for extension registration

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ExtensionAPI.js:
        (defineCommonExtensionSymbols):
        (buildExtensionAPIInjectedScript):
        * inspector/front-end/ExtensionCommon.js:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._addExtensions):
        (WebInspector.ExtensionServer.prototype._addExtension):
        (WebInspector.ExtensionServer.prototype._buildExtensionAPIScript):
        (WebInspector.ExtensionServer.prototype._onWindowMessage):
        (WebInspector.ExtensionServer.prototype._registerExtension):
        (WebInspector.ExtensionServer.prototype._expandResourcePath):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

2011-09-16  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] support extensions for remote inspector front-end
        https://bugs.webkit.org/show_bug.cgi?id=67840

        Reviewed by Pavel Feldman.

        - expose extension API as a single, standalone file for easy reuse in remote extension scripts.

        * WebKit.gyp:
        * scripts/generate_devtools_extension_api.py: Added.
        * scripts/generate_devtools_zip.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed test fix for r95287.
loislo@chromium.org [Fri, 16 Sep 2011 13:19:50 +0000 (13:19 +0000)]
Unreviewed test fix for r95287.

* inspector/debugger/debugger-expand-scope.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: change WebInspector.currentPanel getter/setter to functions.
loislo@chromium.org [Fri, 16 Sep 2011 12:55:32 +0000 (12:55 +0000)]
Web Inspector: change WebInspector.currentPanel getter/setter to functions.
https://bugs.webkit.org/show_bug.cgi?id=68242

This is necessary for the panel switching performance tests.

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
* inspector/front-end/inspector.js:
(WebInspector.currentPanel):
(WebInspector._updateFocusedNode):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
(WebInspector.PanelHistory.prototype.goBack):
(WebInspector.PanelHistory.prototype.goForward):

Source/WebKit/chromium:

* src/js/Tests.js:
(.TestSuite.prototype.showPanel):

LayoutTests:

* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
* inspector/debugger/debugger-expand-scope.html:
* inspector/debugger/debugger-proto-property.html:
* inspector/storage-panel-dom-storage.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt][WK2] bot lucks mobility
kbalazs@webkit.org [Fri, 16 Sep 2011 12:42:20 +0000 (12:42 +0000)]
[Qt][WK2] bot lucks mobility
https://bugs.webkit.org/show_bug.cgi?id=68243

Unreviwed test skipping.

* platform/qt-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuildbot marks a nrwt bot red when tests are missing results
ossy@webkit.org [Fri, 16 Sep 2011 12:04:48 +0000 (12:04 +0000)]
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-16
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/manager.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed. Fix release compilation after r95264
mnaganov@chromium.org [Fri, 16 Sep 2011 12:00:36 +0000 (12:00 +0000)]
Unreviewed. Fix release compilation after r95264

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
carlosgc@webkit.org [Fri, 16 Sep 2011 11:43:16 +0000 (11:43 +0000)]
[GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
https://bugs.webkit.org/show_bug.cgi?id=68178

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-16
Reviewed by Xan Lopez.

.:

* configure.ac: Do not build WebKit2 by default. Re-add pkgconfig support
for WebKit2.

Source/WebKit2:

* GNUmakefile.am: Do not build WebKit2 by default. Re-add pkgconfig support
for WebKit2.

Tools:

Add a work-around to enable WebKit2 when using build-webkit.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush...
pfeldman@chromium.org [Fri, 16 Sep 2011 09:29:14 +0000 (09:29 +0000)]
Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
https://bugs.webkit.org/show_bug.cgi?id=68165

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::clearConsoleMessages):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearMessages):
* inspector/InspectorConsoleAgent.h:
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype.requestClearMessages):

LayoutTests:

* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/console-agent.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Rebaselines due to r95203 and r95207.
keishi@webkit.org [Fri, 16 Sep 2011 09:13:34 +0000 (09:13 +0000)]
[chromium] Rebaselines due to r95203 and r95207.

* platform/chromium-cg-mac-leopard/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-09-16 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 16 Sep 2011 08:39:31 +0000 (08:39 +0000)]
2011-09-16  Alejandro G. Castro  <alex@igalia.com>

        Fix build after r95245.

        * GNUmakefile.list.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Update expecteds of failing tests after r95260 and r95242.
reni@webkit.org [Fri, 16 Sep 2011 08:35:55 +0000 (08:35 +0000)]
[Qt] Update expecteds of failing tests after r95260 and r95242.

Unreviewed gardening.

* editing/style/non-inheritable-styles-expected.txt: after r95242.
* fast/dom/constructed-objects-prototypes-expected.txt: after r95260.
* inspector/styles/styles-new-API-expected.txt: after r95242.
* inspector/styles/styles-source-lines-expected.txt: after r95242.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] One test failed after r95203
reni@webkit.org [Fri, 16 Sep 2011 08:26:15 +0000 (08:26 +0000)]
[Qt] One test failed after r95203
https://bugs.webkit.org/show_bug.cgi?id=68233

Unreviewed gardening.

* platform/qt/Skipped: failed test is skipped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] One test runs out of time after r95091
reni@webkit.org [Fri, 16 Sep 2011 08:21:47 +0000 (08:21 +0000)]
[Qt] One test runs out of time after r95091
https://bugs.webkit.org/show_bug.cgi?id=68232

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Two tests fail after r95201
reni@webkit.org [Fri, 16 Sep 2011 08:16:30 +0000 (08:16 +0000)]
[Qt] Two tests fail after r95201
https://bugs.webkit.org/show_bug.cgi?id=68230

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Crash when dragging google maps.
leo.yang@torchmobile.com.cn [Fri, 16 Sep 2011 07:15:57 +0000 (07:15 +0000)]
[Qt] Crash when dragging google maps.
https://bugs.webkit.org/show_bug.cgi?id=68223

Source/WebCore:

The custom image for a cursor might not be ready when WebKit trying
to use it to construct the cursor in Qt porting. This patch is using
arrow image to substitute the unready custom image.

Reviewed by Adam Barth.

Test: fast/css/crash-on-custom-cursor-when-loading.html

* platform/qt/CursorQt.cpp:
(WebCore::createCustomCursor):
(WebCore::Cursor::ensurePlatformCursor):

LayoutTests:

Test case to use an unready custom cursor.

Reviewed by Adam Barth.

* fast/css/crash-on-custom-cursor-when-loading-expected.txt: Added.
* fast/css/crash-on-custom-cursor-when-loading.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Add slow to calculate-percentage.html
keishi@webkit.org [Fri, 16 Sep 2011 06:52:00 +0000 (06:52 +0000)]
[chromium] Add slow to calculate-percentage.html

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDFG JIT does not optimize method_check
fpizlo@apple.com [Fri, 16 Sep 2011 06:33:55 +0000 (06:33 +0000)]
DFG JIT does not optimize method_check
https://bugs.webkit.org/show_bug.cgi?id=68215

Reviewed by Oliver Hunt.

MethodCallLinkInfo and StructureStubInfo are now searchable by
bytecodeIndex, so that DFG::ByteCodeParser can use that information
to determine how to optimize GetMethod.

A new node op has been added to DFG: CheckMethod. This is a variant
of GetMethod that has been optimized for the case that GetMethod
always takes the fast path. CheckMethod results in only a very
small amount of code (two loads and two branches in the worst case,
one load and one branch in the best case). CheckMethod behaves as
if it were a constant.

Introduced the notion that a DFG node that is not JSConstant
behaves as a constant. CheckMethod uses this functionality.

This is a 3% speed-up on Kraken, and a small speed-up on V8.
Appears to be neutral on SunSpider.

* bytecode/CodeBlock.h:
(JSC::getStructureStubInfoBytecodeIndex):
(JSC::getMethodCallLinkInfoBytecodeIndex):
* bytecode/PredictedType.cpp:
(JSC::predictionFromCell):
(JSC::predictionFromValue):
* bytecode/PredictedType.h:
* bytecode/StructureStubInfo.h:
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordGetMethod):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfJSConstantNode):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasMethodCheckData):
(JSC::DFG::Node::methodCheckDataIndex):
(JSC::DFG::Node::valueOfJSConstant):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::structureAddress):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSigh. Missed this one.
abarth@webkit.org [Fri, 16 Sep 2011 05:43:11 +0000 (05:43 +0000)]
Sigh.  Missed this one.

* features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
abarth@webkit.org [Fri, 16 Sep 2011 05:41:19 +0000 (05:41 +0000)]
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=68205

Reviewed by Eric Seidel.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

Source/WebCore:

As discussed on webkit-dev.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* UseJSC.cmake:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::databaseId):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
* bindings/js/JSSQLTransactionCustom.cpp:
* bindings/js/JSSQLTransactionSyncCustom.cpp:
* bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
* bindings/scripts/test/CPP/WebDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/JS/JSTestCallback.cpp:
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
* bindings/scripts/test/TestCallback.idl:
* bindings/scripts/test/V8/V8TestCallback.cpp:
* bindings/scripts/test/V8/V8TestCallback.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
* dom/Document.cpp:
* dom/Document.h:
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* features.pri:
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
* inspector/InspectorController.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseInstrumentation.h:
* inspector/InspectorDatabaseResource.cpp:
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* page/ChromeClient.h:
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/DOMWindow.idl:
* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteDatabase.cpp:
* platform/sql/SQLiteFileSystem.cpp:
* platform/sql/SQLiteStatement.cpp:
* platform/sql/SQLiteTransaction.cpp:
* storage/AbstractDatabase.cpp:
* storage/AbstractDatabase.h:
* storage/ChangeVersionWrapper.cpp:
* storage/ChangeVersionWrapper.h:
* storage/Database.cpp:
* storage/Database.h:
* storage/Database.idl:
* storage/DatabaseAuthorizer.cpp:
* storage/DatabaseCallback.h:
* storage/DatabaseCallback.idl:
* storage/DatabaseDetails.h:
* storage/DatabaseSync.cpp:
* storage/DatabaseSync.h:
* storage/DatabaseSync.idl:
* storage/DatabaseTask.cpp:
* storage/DatabaseTask.h:
* storage/DatabaseThread.cpp:
* storage/DatabaseThread.h:
* storage/DatabaseTracker.cpp:
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h:
* storage/OriginQuotaManager.cpp:
* storage/OriginQuotaManager.h:
* storage/OriginUsageRecord.cpp:
* storage/OriginUsageRecord.h:
* storage/SQLCallbackWrapper.h:
* storage/SQLError.h:
* storage/SQLError.idl:
* storage/SQLException.h:
* storage/SQLException.idl:
* storage/SQLResultSet.cpp:
* storage/SQLResultSet.h:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.cpp:
* storage/SQLResultSetRowList.h:
* storage/SQLResultSetRowList.idl:
* storage/SQLStatement.cpp:
* storage/SQLStatement.h:
* storage/SQLStatementCallback.h:
* storage/SQLStatementCallback.idl:
* storage/SQLStatementErrorCallback.h:
* storage/SQLStatementErrorCallback.idl:
* storage/SQLStatementSync.cpp:
* storage/SQLStatementSync.h:
* storage/SQLTransaction.cpp:
* storage/SQLTransaction.h:
* storage/SQLTransaction.idl:
* storage/SQLTransactionCallback.h:
* storage/SQLTransactionCallback.idl:
* storage/SQLTransactionClient.cpp:
* storage/SQLTransactionClient.h:
* storage/SQLTransactionCoordinator.cpp:
* storage/SQLTransactionCoordinator.h:
* storage/SQLTransactionErrorCallback.h:
* storage/SQLTransactionErrorCallback.idl:
* storage/SQLTransactionSync.cpp:
* storage/SQLTransactionSync.h:
* storage/SQLTransactionSync.idl:
* storage/SQLTransactionSyncCallback.h:
* storage/SQLTransactionSyncCallback.idl:
* storage/chromium/DatabaseObserver.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
* storage/chromium/QuotaTracker.cpp:
* storage/chromium/QuotaTracker.h:
* storage/chromium/SQLTransactionClientChromium.cpp:
* workers/WorkerContext.cpp:
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):

Source/WebKit/chromium:

* src/DatabaseObserver.cpp:
* src/WebDatabase.cpp:
(WebKit::WebDatabase::updateDatabaseSize):
(WebKit::WebDatabase::updateSpaceAvailable):
(WebKit::WebDatabase::resetSpaceAvailable):
(WebKit::WebDatabase::closeDatabaseImmediately):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:
* ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
* webkit/webkitsecurityorigin.cpp:
(webkit_security_origin_get_web_database_usage):
(webkit_security_origin_get_web_database_quota):
(webkit_security_origin_set_web_database_quota):
(webkit_security_origin_get_all_web_databases):
* webkit/webkitwebdatabase.cpp:
(webkit_web_database_get_display_name):
(webkit_web_database_get_expected_size):
(webkit_web_database_get_size):
(webkit_web_database_get_filename):
(webkit_web_database_remove):
(webkit_remove_all_web_databases):
(webkit_get_web_database_directory_path):
(webkit_set_web_database_directory_path):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

* Storage/WebDatabaseManager.mm:
* Storage/WebDatabaseManagerInternal.h:
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseQuotaManager.mm:
(-[WebDatabaseQuotaManager usage]):
(-[WebDatabaseQuotaManager quota]):
(-[WebDatabaseQuotaManager setQuota:]):
* Storage/WebDatabaseTrackerClient.h:
* Storage/WebDatabaseTrackerClient.mm:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):
* WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

* Api/qwebdatabase.cpp:
(QWebDatabase::displayName):
(QWebDatabase::expectedSize):
(QWebDatabase::size):
(QWebDatabase::fileName):
(QWebDatabase::removeDatabase):
(QWebDatabase::removeAllDatabases):
* Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::databaseUsage):
(QWebSecurityOrigin::databaseQuota):
(QWebSecurityOrigin::setDatabaseQuota):
(QWebSecurityOrigin::allOrigins):
(QWebSecurityOrigin::databases):
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::setOfflineStoragePath):
(QWebSettings::offlineStoragePath):
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

* ForEachCoClass.h:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebDatabaseManager.cpp:
* WebDatabaseManager.h:
* WebSecurityOrigin.cpp:
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
* WebView.cpp:
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:
* WebView.cpp:
(wxWebView::Create):
(wxWebView::SetDatabaseDirectory):
(wxWebView::GetDatabaseDirectory):
(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] add timeout to test expectation of styles-source-lines.html
keishi@webkit.org [Fri, 16 Sep 2011 04:07:13 +0000 (04:07 +0000)]
[chromium] add timeout to test expectation of styles-source-lines.html

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] add timeout to test expectation of styles-new-API.html
keishi@webkit.org [Fri, 16 Sep 2011 04:01:27 +0000 (04:01 +0000)]
[chromium] add timeout to test expectation of styles-new-API.html

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] rebaseline expectations due to r95264
keishi@webkit.org [Fri, 16 Sep 2011 03:59:22 +0000 (03:59 +0000)]
[chromium] rebaseline expectations due to r95264

* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] added fail expectation for back-with-fragment-change.php
keishi@webkit.org [Fri, 16 Sep 2011 03:52:35 +0000 (03:52 +0000)]
[chromium] added fail expectation for back-with-fragment-change.php

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] adding text_expectation for zoom-svg-through-object-with-percentage-size...
keishi@webkit.org [Fri, 16 Sep 2011 03:48:05 +0000 (03:48 +0000)]
[chromium] adding text_expectation for zoom-svg-through-object-with-percentage-size.xhtml

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] adding fail to test_expectations due to r95188
keishi@webkit.org [Fri, 16 Sep 2011 03:44:43 +0000 (03:44 +0000)]
[chromium] adding fail to test_expectations due to r95188

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[CSSRegions] Regions should not slice line box rendering
achicu@adobe.com [Fri, 16 Sep 2011 02:56:19 +0000 (02:56 +0000)]
[CSSRegions] Regions should not slice line box rendering
https://bugs.webkit.org/show_bug.cgi?id=66198

Source/WebCore:

Created a new LayoutState constructor for the RenderFlowThread. It will
set m_isPaginated to true and force a pageHeight if 1. The actual pageHeight is
not used, because pageLogicalHeightForOffset will actually redirect the call
to RenderFlowThread.

Removed some of the duplicate code that calculated the page logical offset.
Added new methods like logicalPageOffset, pageLogicalHeightForOffset,
pageRemainingLogicalHeightForOffset.

There are still some issues related to incremental layout and different region widths.
Those issues will be addressed in different patches.

Reviewed by David Hyatt.

Tests: fast/regions/text-region-breaks.html
       fast/regions/text-region-split-horizontal-bt.html
       fast/regions/text-region-split-vertical-rl.html
       fast/regions/text-region-split-vertical.html
       fast/regions/text-region-split.html

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginated):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
(WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::logicalPageOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
* rendering/RenderFlowThread.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
* rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

LayoutTests:

Also updated the results for some older tests that now work correctly.

Reviewed by David Hyatt.

* fast/regions/resources/helper.js:
(isDebugEnabled):
(assertEqualRects):
(testBoundingRects):
(assertRectContains):
(addPageLevelDebugBox):
(testContentToRegionsMapping):
* fast/regions/text-region-breaks-expected.txt: Added.
* fast/regions/text-region-breaks.html: Added.
* fast/regions/text-region-split-expected.txt: Added.
* fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
* fast/regions/text-region-split-horizontal-bt.html: Added.
* fast/regions/text-region-split-vertical-expected.txt: Added.
* fast/regions/text-region-split-vertical-rl-expected.txt: Added.
* fast/regions/text-region-split-vertical-rl.html: Added.
* fast/regions/text-region-split-vertical.html: Added.
* fast/regions/text-region-split.html: Added.
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
* fast/repaint/japanese-rl-selection-repaint-in-regions.html:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] rebaseline expectations due to r95239
keishi@webkit.org [Fri, 16 Sep 2011 02:53:43 +0000 (02:53 +0000)]
[chromium] rebaseline expectations due to r95239

* platform/chromium-cg-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-cg-mac/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImplement a PopStateEvent constructor for JSC
haraken@google.com [Fri, 16 Sep 2011 02:45:55 +0000 (02:45 +0000)]
Implement a PopStateEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67977

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/pop-state-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the PopStateEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for PopStateEvent.
* dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit):
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
* dom/PopStateEvent.h: Added a definition for PopStateEventInit.
* dom/PopStateEvent.idl: Makes PopStateEvent constructible.

LayoutTests:

pop-state-event-constructor.html checks the behavior of the PopStateEvent constructor.

* fast/events/constructors/pop-state-event-constructor-expected.txt: Added.
* fast/events/constructors/pop-state-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped pop-state-event-constructor.html, since V8 does not yet have the PopStateEvent constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] remove duplicate entries in test_expectations.txt
keishi@webkit.org [Fri, 16 Sep 2011 02:43:37 +0000 (02:43 +0000)]
[chromium] remove duplicate entries in test_expectations.txt

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFragment navigations should interrupt a provisional load of a different document
mihaip@chromium.org [Fri, 16 Sep 2011 02:16:46 +0000 (02:16 +0000)]
Fragment navigations should interrupt a provisional load of a different document
https://bugs.webkit.org/show_bug.cgi?id=64556

Source/WebCore:

Reviewed by Adam Barth.

Tests: http/tests/history/back-with-fragment-change.php
       http/tests/navigation/navigation-interrupted-by-fragment.html

* loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
* loader/HistoryController.cpp: Don't commit the wrong provisional item.

LayoutTests:

Reviewed by Adam Barth.

Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy <a href="#"> link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.

* fast/loader/page-dismissal-modal-dialogs.html:
* fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
* http/tests/history/back-with-fragment-change-expected.txt: Added.
* http/tests/history/back-with-fragment-change.php: Added.
* http/tests/history/resources/back-with-fragment-change-target.html: Added.
* http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
* http/tests/navigation/navigation-interrupted-by-fragment.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
jamesr@google.com [Fri, 16 Sep 2011 02:14:07 +0000 (02:14 +0000)]
Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed...
commit-queue@webkit.org [Fri, 16 Sep 2011 02:03:20 +0000 (02:03 +0000)]
UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
https://bugs.webkit.org/show_bug.cgi?id=68003

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
enne@google.com [Fri, 16 Sep 2011 01:54:35 +0000 (01:54 +0000)]
[chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
https://bugs.webkit.org/show_bug.cgi?id=68204

Reviewed by James Robinson.

Add CRASH calls to determine which assumptions are being violated.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove TestWebKitAPI from the chromium build until it is made to work
levin@chromium.org [Fri, 16 Sep 2011 01:32:32 +0000 (01:32 +0000)]
Remove TestWebKitAPI from the chromium build until it is made to work
with the shared component build.

* WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
mrowe@apple.com [Fri, 16 Sep 2011 01:32:14 +0000 (01:32 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95254 268f45cc-cd09-0410-ab3c-d52691b4dbfc