mtklein [Thu, 7 Apr 2016 01:24:34 +0000 (18:24 -0700)]
Revert of Track GL buffer state based on unique resource ID (patchset #6 id:100001 of https://codereview.chromium.org/
1854283004/ )
Reason for revert:
Chrome roll's broken, seems to be missing fTarget:
https://codereview.chromium.org/
1861473005
Original issue's description:
> Track GL buffer state based on unique resource ID
>
> Reworks GrGLGpu to track GL buffer state based on the unique
> GrGpuResource ID. This eliminates the need to notify the gpu object
> whenever a buffer is deleted.
>
> This change also allows us to remove the type specifier from GrBuffer.
> At this point a buffer is just a chunk of memory, and the type
> given at creation time is just a suggestion to the GL backend about
> which target to bind to for updates.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854283004
>
> Committed: https://skia.googlesource.com/skia/+/
deacc97bc63513b5eacaf21f858727f6e8b98ce5
TBR=bsalomon@google.com,jvanverth@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1870553002
msarett [Wed, 6 Apr 2016 22:45:41 +0000 (15:45 -0700)]
Mark webps as sRGB
This may cause some diffs in Gold.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1838603002
Review URL: https://codereview.chromium.org/
1838603002
mtklein [Wed, 6 Apr 2016 22:01:57 +0000 (15:01 -0700)]
Fix lazy coding in ViaSingletonPictures.
I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().
This was causing spurious quick rejects in drawPatch(). I didn't really
look much deeper to figure out why. It's easy enough to just feed it the
proper bounds of the entire content.
This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1865143002
Review URL: https://codereview.chromium.org/
1865143002
cdalton [Wed, 6 Apr 2016 21:26:33 +0000 (14:26 -0700)]
Track GL buffer state based on unique resource ID
Reworks GrGLGpu to track GL buffer state based on the unique
GrGpuResource ID. This eliminates the need to notify the gpu object
whenever a buffer is deleted.
This change also allows us to remove the type specifier from GrBuffer.
At this point a buffer is just a chunk of memory, and the type
given at creation time is just a suggestion to the GL backend about
which target to bind to for updates.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854283004
Review URL: https://codereview.chromium.org/
1854283004
mtklein [Wed, 6 Apr 2016 21:25:35 +0000 (14:25 -0700)]
path_stroke_with_zero_length: turn off drawFat() by default.
The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.
I don't mind if we leave it alone, but I thought I'd check to see your opinion.
BUG=skia:4095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1862113004
Review URL: https://codereview.chromium.org/
1862113004
bsalomon [Wed, 6 Apr 2016 21:02:39 +0000 (14:02 -0700)]
Make existing unit tests only run on GL contexts
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1869503002
Review URL: https://codereview.chromium.org/
1869503002
mtklein [Wed, 6 Apr 2016 20:57:38 +0000 (13:57 -0700)]
alternate textblobgeometrychange fix... just make our own surface if needed
This should decopple fixing the replay modes from revising the API.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1868553005
Review URL: https://codereview.chromium.org/
1868553005
egdaniel [Wed, 6 Apr 2016 20:47:08 +0000 (13:47 -0700)]
Switch uniforms to be descriptor set 0 in Vulkan
This (plus some cleanup) gives us some minor perf gains and as a side effect
the perf debug layer no longer complains when we bind certain descriptor sets.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1864303002
Review URL: https://codereview.chromium.org/
1864303002
cdalton [Wed, 6 Apr 2016 20:36:38 +0000 (13:36 -0700)]
Fix null context GenBuffers
Fixes the null context to not return 0 for GenBuffers.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1863923003
Review URL: https://codereview.chromium.org/
1863923003
mtklein [Wed, 6 Apr 2016 19:42:48 +0000 (12:42 -0700)]
Remove conditional flavor text on blend GM.
This was breaking replay modes for no good reason.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1864253002
Review URL: https://codereview.chromium.org/
1864253002
mtklein [Wed, 6 Apr 2016 19:27:07 +0000 (12:27 -0700)]
Register SkLocalMatrixImageFilter for serialization.
This fixes one of the zillions of serialize-8888 backlisted tests.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1868453003
Review URL: https://codereview.chromium.org/
1868453003
jvanverth [Wed, 6 Apr 2016 19:08:51 +0000 (12:08 -0700)]
Clean up input handling in VulkanViewer
Sets up proper handling of characters and keycodes, and event modifiers.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1865553005
Review URL: https://codereview.chromium.org/
1865553005
borenet [Wed, 6 Apr 2016 18:38:55 +0000 (11:38 -0700)]
More iOS swarming bot fixes
- Copy the packaged app into xcodebuild/...
- Isolate ios/bin directory
BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1860333002
Review URL: https://codereview.chromium.org/
1860333002
bsalomon [Wed, 6 Apr 2016 16:22:36 +0000 (09:22 -0700)]
Alter dm_flags.py logic flow for certain configs to be subtractive
Replace msaa4 on Shield Tablet with glmsaa4.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1868473003
Review URL: https://codereview.chromium.org/
1868473003
caryclark [Wed, 6 Apr 2016 15:54:06 +0000 (08:54 -0700)]
cubic stroke fix
Normally parallel tangents means that the stroke can
be represented with a line. But looping cubics can
have parallel tangents if the loop is 180 degrees.
Check to see if the tangents direction is opposite
to subdivide further.
R=reed@google.com
BUG=skia:5099
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1862753002
Review URL: https://codereview.chromium.org/
1862753002
robertphillips [Wed, 6 Apr 2016 15:40:59 +0000 (08:40 -0700)]
Update DropShadowImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1861843002
Review URL: https://codereview.chromium.org/
1861843002
bsalomon [Wed, 6 Apr 2016 15:35:15 +0000 (08:35 -0700)]
Add exclusion for keymobi_shop_mobileweb_ebay_com.skp on N5
BUG=skia:5178
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1857123005
Review URL: https://codereview.chromium.org/
1857123005
robertphillips [Wed, 6 Apr 2016 14:44:01 +0000 (07:44 -0700)]
Update DownSampleImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1864583005
Review URL: https://codereview.chromium.org/
1864583005
brianosman [Wed, 6 Apr 2016 14:38:23 +0000 (07:38 -0700)]
SkSurfaceProps now has a gamma-correct ("AllowSRGBInputs") flag. That's propagated in a few places so that the backend can do the right thing for L32 vs S32 mode.
Also added SkSurfaceProps to SkSpecialImage, so that Image -> Surface conversion can preserve the desired behavior during filtering.
Many small changes, including a bunch of comments about places where we may be losing information right now. My approach was to ensure that if anything fails, it will always fall back to "legacy" mode - gamma-correctness is opt-in, so I'll just have to feed things through as missing cases are exposed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1838953007
Review URL: https://codereview.chromium.org/
1845283003
brianosman [Wed, 6 Apr 2016 14:32:08 +0000 (07:32 -0700)]
Add mipmap procs for F16 format.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1831353002
Review URL: https://codereview.chromium.org/
1831353002
yujieqin [Wed, 6 Apr 2016 13:47:15 +0000 (06:47 -0700)]
Enable RAW codec for Windows
BUG=skia:4890 b/
26973157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853093002
Review URL: https://codereview.chromium.org/
1853093002
mtklein [Wed, 6 Apr 2016 13:12:01 +0000 (06:12 -0700)]
Another NDK release. Still just bug fixes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1864073002
Review URL: https://codereview.chromium.org/
1864073002
jvanverth [Wed, 6 Apr 2016 13:08:59 +0000 (06:08 -0700)]
First pass at VulkanViewer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848833005
Review URL: https://codereview.chromium.org/
1848833005
robertphillips [Tue, 5 Apr 2016 23:55:41 +0000 (16:55 -0700)]
"Fix" compiler issue in SkRandomScalerContext
BUG=skia:5164
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1862643002
Review URL: https://codereview.chromium.org/
1862643002
robertphillips [Tue, 5 Apr 2016 22:09:00 +0000 (15:09 -0700)]
Update SkMatrixImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1858353002
Review URL: https://codereview.chromium.org/
1858353002
mtklein [Tue, 5 Apr 2016 20:46:00 +0000 (13:46 -0700)]
Get back on mainline libpng 1.6 now that 3bpp perf patches are merged.
Checked manually in Instruments that we're still running our SSE filters for both RGB and RGBA PNGs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1865633002
Review URL: https://codereview.chromium.org/
1865633002
bsalomon [Tue, 5 Apr 2016 19:59:06 +0000 (12:59 -0700)]
One signature for creating unit tests that run on premade GrContexts
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1860593002
Review URL: https://codereview.chromium.org/
1860593002
kjlubick [Tue, 5 Apr 2016 19:48:47 +0000 (12:48 -0700)]
Do an in-place replacement of SkRandom with Fuzz for FilterFuzz
This feels rather clunky, because we aren't using the full potential of the
fuzzer, but it works, it seems.
BUG=skia:4969
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1710183002
Review URL: https://codereview.chromium.org/
1710183002
robertphillips [Tue, 5 Apr 2016 19:48:34 +0000 (12:48 -0700)]
Update SkXfermodeImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852123002
Committed: https://skia.googlesource.com/skia/+/
3bc969264d4720d67f0b137552b3777a03b431a8
Review URL: https://codereview.chromium.org/
1852123002
borenet [Tue, 5 Apr 2016 19:14:59 +0000 (12:14 -0700)]
Set 'device_cfg' parameter for iOS bots
For https://codereview.chromium.org/
1859993003/
BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1862723002
Review URL: https://codereview.chromium.org/
1862723002
msarett [Tue, 5 Apr 2016 19:00:49 +0000 (12:00 -0700)]
Revert of Delete SkFlattenable::Type (part 1) (patchset #1 id:1 of https://codereview.chromium.org/
1861013002/ )
Reason for revert:
See sugoi's comment.
Original issue's description:
> Delete SkFlattenable::Type (part 1)
>
> This should allow me to delete uses of SkFlattenable::Type in Chrome.
> Then I'll follow up with the full delete.
> https://codereview.chromium.org/
1834303003/
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1861013002
>
> Committed: https://skia.googlesource.com/skia/+/
6b63536e917d86028630199c4eef4aa1597292ce
TBR=reed@google.com,mtklein@google.com,sugoi@chromium.org,senorblanco@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1860693005
robertphillips [Tue, 5 Apr 2016 18:50:42 +0000 (11:50 -0700)]
Update SkColorFilterImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1858813002
Review URL: https://codereview.chromium.org/
1858813002
brianosman [Tue, 5 Apr 2016 18:37:49 +0000 (11:37 -0700)]
Create output directory in skdiff
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1865563002
Review URL: https://codereview.chromium.org/
1865563002
bsalomon [Tue, 5 Apr 2016 18:06:27 +0000 (11:06 -0700)]
Rename enums in GrContextFactory to remove "GL"
Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845923004
Committed: https://skia.googlesource.com/skia/+/
2d9c6f81353597aebf5934547e5cba7a872196fb
Review URL: https://codereview.chromium.org/
1845923004
egdaniel [Tue, 5 Apr 2016 18:00:29 +0000 (11:00 -0700)]
Fix vulkan dual source blending
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856283003
Review URL: https://codereview.chromium.org/
1856283003
bsalomon [Tue, 5 Apr 2016 17:57:13 +0000 (10:57 -0700)]
Remove 'native' context unit test macro.
The only test ran long is GLPrograms. I halved its iteration count to preserve the runtime on devices that support GL and GLES.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1855993002
Review URL: https://codereview.chromium.org/
1855993002
borenet [Tue, 5 Apr 2016 17:12:56 +0000 (10:12 -0700)]
Reland of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/
1861713002/ )
Reason for revert:
Retry again
Original issue's description:
> Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/
1856373003/ )
>
> Reason for revert:
> Try again.
>
> Original issue's description:
> > Whitespace change to test Bugdroid+AutoRoll
> >
> > BUG=598773
> > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856373003
> >
> > Committed: https://skia.googlesource.com/skia/+/
74f047b58b70935f21cc08d30b7cc789b22bc7cf
>
> TBR=borenet@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=598773
>
> Committed: https://skia.googlesource.com/skia/+/
cd76ae50e9bba22282a283eb18d092291b1f98ad
TBR=borenet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598773
Review URL: https://codereview.chromium.org/
1864573002
msarett [Tue, 5 Apr 2016 16:32:35 +0000 (09:32 -0700)]
Delete SkFlattenable::Type (part 1)
This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/
1834303003/
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1861013002
Review URL: https://codereview.chromium.org/
1861013002
robertphillips [Tue, 5 Apr 2016 16:09:36 +0000 (09:09 -0700)]
Update SkMorphology ImageFilters to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1860573002
Review URL: https://codereview.chromium.org/
1860573002
bsalomon [Tue, 5 Apr 2016 15:49:38 +0000 (08:49 -0700)]
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853103003
Committed: https://skia.googlesource.com/skia/+/
74cb44dee50b5db94c1374cbcf0b0a1babd09d89
Review URL: https://codereview.chromium.org/
1853103003
rmistry [Tue, 5 Apr 2016 15:31:48 +0000 (08:31 -0700)]
Add valgrind suppression file to infrabots.isolate
BUG=skia:5149
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1859083002
Review URL: https://codereview.chromium.org/
1859083002
borenet [Tue, 5 Apr 2016 15:25:38 +0000 (08:25 -0700)]
Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/
1856373003/ )
Reason for revert:
Try again.
Original issue's description:
> Whitespace change to test Bugdroid+AutoRoll
>
> BUG=598773
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856373003
>
> Committed: https://skia.googlesource.com/skia/+/
74f047b58b70935f21cc08d30b7cc789b22bc7cf
TBR=borenet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598773
Review URL: https://codereview.chromium.org/
1861713002
rmistry [Tue, 5 Apr 2016 15:24:29 +0000 (08:24 -0700)]
Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind
BUG=skia:5149
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856403002
Review URL: https://codereview.chromium.org/
1856403002
caryclark [Tue, 5 Apr 2016 14:28:48 +0000 (07:28 -0700)]
give up if huge paths have unresolvable coincidence
This fuzzy test has enormous curves with coincidence runs that break numerics.
If the computed intersections identify that the span of coincidence has been deleted,
give up and return that the path op failed.
TBR=reed@google.com
BUG=597926
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854333002
Review URL: https://codereview.chromium.org/
1854333002
bsalomon [Tue, 5 Apr 2016 14:26:28 +0000 (07:26 -0700)]
Revert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL… (patchset #3 id:40001 of https://codereview.chromium.org/
1853103003/ )
Reason for revert:
causing crashes on win8 bot?
Original issue's description:
> Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853103003
>
> Committed: https://skia.googlesource.com/skia/+/
74cb44dee50b5db94c1374cbcf0b0a1babd09d89
TBR=egdaniel@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1857233002
egdaniel [Tue, 5 Apr 2016 14:23:38 +0000 (07:23 -0700)]
Implement blit image for copySurface in Vulkan
Also allows CopyImage to handle GrRenderTargets which are not textures.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852413002
Review URL: https://codereview.chromium.org/
1852413002
bsalomon [Tue, 5 Apr 2016 14:03:42 +0000 (07:03 -0700)]
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853103003
Review URL: https://codereview.chromium.org/
1853103003
reed [Tue, 5 Apr 2016 13:25:14 +0000 (06:25 -0700)]
remove avoid and pixelxor xfermodes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853103005
Review URL: https://codereview.chromium.org/
1853103005
borenet [Tue, 5 Apr 2016 12:57:46 +0000 (05:57 -0700)]
Whitespace change to test Bugdroid+AutoRoll
BUG=598773
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856373003
Review URL: https://codereview.chromium.org/
1856373003
senorblanco [Tue, 5 Apr 2016 11:43:45 +0000 (04:43 -0700)]
Fix failed filter followed by an affects-transparent-black filter.
When an upstream filter returns null, either through failure or clipping, a downstream affects-transparent-black
filter should still produce non-transparent pixels.
This patch fixes SkColorFilterImageFilter.
Note: this will affect the results of the imagefilterscropexpand GM.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1844593002
Review URL: https://codereview.chromium.org/
1844593002
mtklein [Mon, 4 Apr 2016 21:57:19 +0000 (14:57 -0700)]
Revert of Delete SkFlattenable::Type (patchset #2 id:20001 of https://codereview.chromium.org/
1834303003/ )
Reason for revert:
Used by Chrome.
c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C2039: 'GetFlattenableType': is not a member of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\third_party\skia\include\core\skshader.h(19): note: see declaration of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C3861: 'GetFlattenableType': identifier not found
Original issue's description:
> Delete SkFlattenable::Type
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834303003
>
> Committed: https://skia.googlesource.com/skia/+/
99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f
TBR=reed@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1853383002
msarett [Mon, 4 Apr 2016 20:53:02 +0000 (13:53 -0700)]
Delete SkFlattenable::Type
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834303003
Review URL: https://codereview.chromium.org/
1834303003
mtklein [Mon, 4 Apr 2016 20:48:41 +0000 (13:48 -0700)]
Roll up to use >=4.
https://github.com/mtklein/libpng/commit/
d0513638e7cc7d22b7dace879afea848b342fe33
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854293002
Review URL: https://codereview.chromium.org/
1854293002
borenet [Mon, 4 Apr 2016 19:39:32 +0000 (12:39 -0700)]
Fixes for iOS Swarming bot
BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1855223002
Review URL: https://codereview.chromium.org/
1855223002
halcanary [Mon, 4 Apr 2016 19:14:46 +0000 (12:14 -0700)]
Fix ParseConfigs_OutParam tests
Review URL: https://codereview.chromium.org/
1857923002
mtklein [Mon, 4 Apr 2016 19:08:46 +0000 (12:08 -0700)]
Point libpng at upstream libpng 1.6 + my new perf patch.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852363002
Review URL: https://codereview.chromium.org/
1852363002
robertphillips [Mon, 4 Apr 2016 19:07:47 +0000 (12:07 -0700)]
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854133002
Review URL: https://codereview.chromium.org/
1854133002
ethannicholas [Mon, 4 Apr 2016 18:41:30 +0000 (11:41 -0700)]
Revert of added GrMSAAPathRenderer (patchset #9 id:160001 of https://codereview.chromium.org/
1834133003/ )
Reason for revert:
driver crash on Windows
Original issue's description:
> added GrMSAAPathRenderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
>
> Committed: https://skia.googlesource.com/skia/+/
47a2dc8e229e93e1bcf7405747320920da1ab742
>
> Committed: https://skia.googlesource.com/skia/+/
b0fabd4ed55abcb6f5ed2f331c96c783f42bd37c
TBR=bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1853223003
ethannicholas [Mon, 4 Apr 2016 18:00:00 +0000 (11:00 -0700)]
added GrMSAAPathRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
Committed: https://skia.googlesource.com/skia/+/
47a2dc8e229e93e1bcf7405747320920da1ab742
Review URL: https://codereview.chromium.org/
1834133003
scroggo [Mon, 4 Apr 2016 17:05:23 +0000 (10:05 -0700)]
Add SK_API to SkROBuffer::Iter
Necessary for crrev.com/
1812273003 in Chromium.
Also remove trailing whitespace.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856033002
Review URL: https://codereview.chromium.org/
1856033002
reed [Mon, 4 Apr 2016 17:02:58 +0000 (10:02 -0700)]
switch maskfilters to sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852113003
Review URL: https://codereview.chromium.org/
1852113003
robertphillips [Mon, 4 Apr 2016 16:18:52 +0000 (09:18 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
Committed: https://skia.googlesource.com/skia/+/
33550dab45516bbcfa5ab908c5857fb382535c44
Review URL: https://codereview.chromium.org/
1851583002
ethannicholas [Mon, 4 Apr 2016 15:27:03 +0000 (08:27 -0700)]
Revert of added GrMSAAPathRenderer (patchset #8 id:140001 of https://codereview.chromium.org/
1834133003/ )
Reason for revert:
nanobench failure
Original issue's description:
> added GrMSAAPathRenderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
>
> Committed: https://skia.googlesource.com/skia/+/
47a2dc8e229e93e1bcf7405747320920da1ab742
TBR=bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1860563002
robertphillips [Mon, 4 Apr 2016 15:06:17 +0000 (08:06 -0700)]
Revert of Update SkXfermodeImageFilter to sk_sp (patchset #4 id:60001 of https://codereview.chromium.org/
1852123002/ )
Reason for revert:
Chrome-land compilation failure.
Original issue's description:
> Update SkXfermodeImageFilter to sk_sp
>
> TBR=reed@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852123002
>
> Committed: https://skia.googlesource.com/skia/+/
3bc969264d4720d67f0b137552b3777a03b431a8
TBR=fmalita@chromium.org,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1852273002
ethannicholas [Mon, 4 Apr 2016 14:57:39 +0000 (07:57 -0700)]
added GrMSAAPathRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
Review URL: https://codereview.chromium.org/
1834133003
robertphillips [Mon, 4 Apr 2016 14:13:49 +0000 (07:13 -0700)]
Update SkXfermodeImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852123002
Review URL: https://codereview.chromium.org/
1852123002
halcanary [Mon, 4 Apr 2016 13:12:15 +0000 (06:12 -0700)]
DM/PDF: stop adding unused rasterizer keywords
We can always add it back if we need it in the future.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852713002
Review URL: https://codereview.chromium.org/
1852713002
bsalomon [Mon, 4 Apr 2016 12:56:59 +0000 (05:56 -0700)]
Revert of Rename enums in GrContextFactory to remove "GL" (patchset #4 id:60001 of https://codereview.chromium.org/
1845923004/ )
Reason for revert:
Many GM images unexpectedly changed with this CL.
Original issue's description:
> Rename enums in GrContextFactory to remove "GL"
>
> Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845923004
>
> Committed: https://skia.googlesource.com/skia/+/
2d9c6f81353597aebf5934547e5cba7a872196fb
TBR=egdaniel@google.com,jvanverth@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/
1856703002
robertphillips [Mon, 4 Apr 2016 12:28:03 +0000 (05:28 -0700)]
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #6 id:100001 of https://codereview.chromium.org/
1851583002/ )
Reason for revert:
changing images on bots
Original issue's description:
> Switch SkDownSampleImageFilter over to new onFilterImage interface
>
> This will slightly change the testimagefilters GM images
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
>
> Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
>
> Committed: https://skia.googlesource.com/skia/+/
33550dab45516bbcfa5ab908c5857fb382535c44
TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1859533002
robertphillips [Mon, 4 Apr 2016 12:05:11 +0000 (05:05 -0700)]
Update internal testing ImageFilters to sk_sp
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854023003
Review URL: https://codereview.chromium.org/
1854023003
robertphillips [Mon, 4 Apr 2016 12:04:45 +0000 (05:04 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
Review URL: https://codereview.chromium.org/
1851583002
robertphillips [Mon, 4 Apr 2016 11:31:25 +0000 (04:31 -0700)]
Update SkBlurImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852743002
Review URL: https://codereview.chromium.org/
1852743002
reed [Sun, 3 Apr 2016 16:11:13 +0000 (09:11 -0700)]
change flattenable factory to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1855733002
Review URL: https://codereview.chromium.org/
1855733002
update-skps [Sun, 3 Apr 2016 07:59:16 +0000 (00:59 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851323002
Review URL: https://codereview.chromium.org/
1851323002
reed [Sun, 3 Apr 2016 01:40:40 +0000 (18:40 -0700)]
check for bad params sent to discrete patheffect
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853953002
TBR=
Review URL: https://codereview.chromium.org/
1853953002
senorblanco [Fri, 1 Apr 2016 23:41:10 +0000 (16:41 -0700)]
Image filters: optimize crop rect application.
If a filter does not affect transparent black, there's no
reason to allow the crop rect to expand beyond the optimal
size determined by onFilterNodeBounds(). So don't enlarge
the bounds unless the filter affects transparent black.
In order to determine which filters affect transparent
black, I've pulled the inverse of the canComputeFastBounds()
logic into a non-recursive, affectsTransparentBlack()
virtual, and left canComputeFastBounds() as a non-virtual,
recursive function that calls it.
BUG=599933
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848953002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1848953002
bsalomon [Fri, 1 Apr 2016 20:38:04 +0000 (13:38 -0700)]
Rename enums in GrContextFactory to remove "GL"
Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845923004
Review URL: https://codereview.chromium.org/
1845923004
bsalomon [Fri, 1 Apr 2016 18:54:31 +0000 (11:54 -0700)]
Add GrContext::releaseAndAbandonContext()
Like abandonContext() this disconnects the GrContext from the underlying 3D API. However, unlike abandonContext it first frees all allocated GPU resources.
BUG=skia:5142
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852733002
Review URL: https://codereview.chromium.org/
1852733002
halcanary [Fri, 1 Apr 2016 18:51:00 +0000 (11:51 -0700)]
SkPDF: properly dedup bitmaps in shaders
BUG=skia:5161
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848383002
Review URL: https://codereview.chromium.org/
1848383002
halcanary [Fri, 1 Apr 2016 18:43:39 +0000 (11:43 -0700)]
SkPDF: PDFShader does not hold images/bitmaps
motivation: measurable memory savings.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851123002
Review URL: https://codereview.chromium.org/
1851123002
robertphillips [Fri, 1 Apr 2016 17:34:43 +0000 (10:34 -0700)]
Update SkAlphaThresholdFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847053004
Review URL: https://codereview.chromium.org/
1847053004
egdaniel [Fri, 1 Apr 2016 17:10:45 +0000 (10:10 -0700)]
Update vulkan format features in caps.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847963003
Review URL: https://codereview.chromium.org/
1847963003
robertphillips [Fri, 1 Apr 2016 16:28:51 +0000 (09:28 -0700)]
Update SkImageSource to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842243002
Review URL: https://codereview.chromium.org/
1842243002
senorblanco [Fri, 1 Apr 2016 16:24:48 +0000 (09:24 -0700)]
Fix padding bug in SkTileImageFilter.
When padding an image out to tile size, use the filter input, not the
source primitive.
NOTE: this will affect the tileimagefilter GM (new test case & size).
R=robertphillips@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853803003
Review URL: https://codereview.chromium.org/
1853803003
bsalomon [Fri, 1 Apr 2016 16:04:35 +0000 (09:04 -0700)]
Delete duplicate null GL interface implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1846253002
Review URL: https://codereview.chromium.org/
1846253002
egdaniel [Fri, 1 Apr 2016 15:47:35 +0000 (08:47 -0700)]
Initialize variable to appease compiler warning
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854773002
Review URL: https://codereview.chromium.org/
1854773002
bsalomon [Fri, 1 Apr 2016 15:40:55 +0000 (08:40 -0700)]
Respect build type arg in build_shaderc.py
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854733004
Review URL: https://codereview.chromium.org/
1854733004
robertphillips [Fri, 1 Apr 2016 15:09:44 +0000 (08:09 -0700)]
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #2 id:20001 of https://codereview.chromium.org/
1851583002/ )
Reason for revert:
Some images are incorrect
Original issue's description:
> Switch SkDownSampleImageFilter over to new onFilterImage interface
>
> This will slightly change the testimagefilters GM images
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
>
> Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1853823002
bsalomon [Fri, 1 Apr 2016 14:42:05 +0000 (07:42 -0700)]
Restore Vulkan setup code accidentally reverted in GrContextFactory.cpp
TBR=egdaniel@google.com,jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852553004
Review URL: https://codereview.chromium.org/
1852553004
borenet [Fri, 1 Apr 2016 14:18:27 +0000 (07:18 -0700)]
Support for Android Swarming bots
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1819033002
Review URL: https://codereview.chromium.org/
1819033002
robertphillips [Fri, 1 Apr 2016 14:13:42 +0000 (07:13 -0700)]
Switch SkMatrixImageFilter over to new onFilterImage interface
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847953003
Review URL: https://codereview.chromium.org/
1847953003
robertphillips [Fri, 1 Apr 2016 14:13:23 +0000 (07:13 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
Review URL: https://codereview.chromium.org/
1851583002
benjaminwagner [Fri, 1 Apr 2016 13:54:34 +0000 (06:54 -0700)]
Add SK_SUPPORT_LEGACY_IMAGEFILTER_PTR to public.bzl DEFINES to fix build.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853773002
Review URL: https://codereview.chromium.org/
1853773002
bsalomon [Fri, 1 Apr 2016 13:06:20 +0000 (06:06 -0700)]
Simplify GrDrawBatch uploads and token uage.
GrVertexBatch subclasses no longer need "initDraw".
Simplifies GrTestBatch
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1835283002
Review URL: https://codereview.chromium.org/
1835283002
benjaminwagner [Fri, 1 Apr 2016 12:00:51 +0000 (05:00 -0700)]
In public.bzl, change file locations after https://codereview.chromium.org/
1815823002
Depends on https://codereview.chromium.org/
1847923002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842363002
Review URL: https://codereview.chromium.org/
1842363002
mtklein [Fri, 1 Apr 2016 11:55:51 +0000 (04:55 -0700)]
sk_sp for SkCanvas::drawAnnotation()
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1849703003
Review URL: https://codereview.chromium.org/
1849703003
mtklein [Fri, 1 Apr 2016 11:55:47 +0000 (04:55 -0700)]
fix typo: add missing const
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848533004
Review URL: https://codereview.chromium.org/
1848533004
bsalomon [Fri, 1 Apr 2016 11:50:45 +0000 (04:50 -0700)]
Add CreatePlatformGLTestContext_none.cpp for Google3 build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847923002
Review URL: https://codereview.chromium.org/
1847923002
kkinnunen [Fri, 1 Apr 2016 11:50:37 +0000 (04:50 -0700)]
Remove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget
Remove ownership parameter from
GrResourceProvider::wrapBackendTextureAsRenderTarget.
The function leaks the texture id if kAdopt_LifeCycle is passed.
There is no public API to access the parameter.
BUG=594928
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842313003
Review URL: https://codereview.chromium.org/
1842313003
Brian Salomon [Thu, 31 Mar 2016 18:30:08 +0000 (14:30 -0400)]
Fix compilation of GLTestContext_angle.cpp"
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1850783003
BUG=skia:
Review URL: https://codereview.chromium.org/
1850783003 .
projects / platform / upstream / libSkiaSharp.git / log