Cedric Bail [Tue, 10 Oct 2017 00:44:33 +0000 (17:44 -0700)]
eio: update example for openning and closing file asynchronously using a chain.
Subodh Kumar [Mon, 9 Oct 2017 23:41:19 +0000 (16:41 -0700)]
evas: there is no effect of variable assignment while clean up.
Summary:
There is no effect of assingning a variable while clean up.
@fix
Reviewers: raster, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5272
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:40:11 +0000 (16:40 -0700)]
ephysic: comparing with same statement.
Summary:
There is no effect of comparing with same expression.
@fix
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5271
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:38:25 +0000 (16:38 -0700)]
emile: comparing less than zero with unsigned interger.
Summary:
Unsigned integer should not be compared to less than zero.
@fix
Reviewers: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5270
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:37:47 +0000 (16:37 -0700)]
eina: comparing less than zero with unsigned long int
Summary:
Unsigned integer should not be compared to less than zero
@fix
Test Plan: NA
Reviewers: cedric
Reviewed By: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5269
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:36:54 +0000 (16:36 -0700)]
eina: same expression on both statement.
Summary:
Comparing with same expression is avoided.
@fix
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5268
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Marcel Hollerbach [Mon, 9 Oct 2017 11:12:06 +0000 (13:12 +0200)]
efl_ui_focus_manager_calc: we dont need the explicit root handling,
that is done later in line 1205
Marcel Hollerbach [Mon, 9 Oct 2017 11:06:47 +0000 (13:06 +0200)]
efl_ui_focus_manager_calc: focus a child if a logical is focused
If you call focus_set(m, o) where o is a logical child, then the focus
will go to any none logical child of o, or if there is nothing in the
children of o, then the focus will remain on the now focused element.
Carsten Haitzler (Rasterman) [Sat, 7 Oct 2017 10:26:10 +0000 (19:26 +0900)]
Revert "edje: moved from edje_multisense.c to Ecore_Audio.h for select the type of render."
This reverts commit
c1c424a4075a85375c83f4c137b74c9919c5fc57.
revert edje multisense changes to match ecore audio revert
Carsten Haitzler (Rasterman) [Sat, 7 Oct 2017 10:09:53 +0000 (19:09 +0900)]
Revert "ecore_audio: a minimal template for playing sound on WINDOWS is added"
This reverts commit
7a98f617e94ef42787e06e685a8d5e7be34fff21.
this commit breaks compiling things against efl badly. i'm on holiday
and haver only a mini screen and keyboard wwith me so any serious wok
in hunting these issues isn't going to be fun or easy. as this causes
bad build brreaks this is worth a revert IMHO. please re-submit wwhen
you've tested against efl by building things against it. also our
public headers just should not have such ifdefs/if's that change api
presented based on how efl is cnfigured. we expose the same api and
macros and types regardless of internal config.
Carsten Haitzler (Rasterman) [Sat, 7 Oct 2017 09:24:29 +0000 (18:24 +0900)]
emotion gst1 - handle null imagwe data returrn and dont crash
fix crash i spotted thanks to getting img obbj data returning null.
@fix
Subodh Kumar [Fri, 6 Oct 2017 16:53:15 +0000 (09:53 -0700)]
efreet: unsigned int cannot be compared to less than zero.
Summary:
Wrong camparision with less than zero for unsigned integer.
@fix
Test Plan: NA
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5262
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Fri, 6 Oct 2017 16:52:41 +0000 (09:52 -0700)]
evas: there is no effect of variable assignment outside the function.
Summary:
Variable assigned is not used anywhere else, making it unused.
@fix
Test Plan: Na
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5263
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Fri, 6 Oct 2017 16:51:13 +0000 (09:51 -0700)]
eet: wrong comparision to less than zero with unsigned integer.
Summary:
Unsigned interger should not be compared to less than zero.
@fix
Test Plan: Na
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5264
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Fri, 6 Oct 2017 16:50:20 +0000 (09:50 -0700)]
elementary: passing NULL to variadic funtion can be undefined.
Summary:
Passing NULL to variadic funtion may lead to undefined behaviour.
@fix
Test Plan: NA
Reviewers: lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5265
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Godly T.Alias [Fri, 6 Oct 2017 16:48:28 +0000 (09:48 -0700)]
evas: fix for sscanf use with save flags input.
Summary:
As 'flags' can be supplied by application, in case application is supplying
a big string(error case), it can cause crash in some version of glibc.
Setting maximum possible input (0x64) length as width specifier
Fix for static code analyzer warnings
- scanf without field width limits can crash with huge input data on some versions of libc
Signed-off-by: Godly T.Alias <godlytalias@yahoo.co.in>
Test Plan: Run SonarQube
Reviewers: cedric, raster, Princekrdubey, rajeshps
Reviewed By: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5266
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Yeongjong Lee [Fri, 6 Oct 2017 16:46:21 +0000 (09:46 -0700)]
elementary: fix unintentional visibility of elm_hover in combobox constructor
Summary:
since
fd9cf1d3b628f70d66ec85a4f2433c675d9ad243, All Eo canvas objects remain
visible by default.
but elm_hover doesn't want to be shown in combobox constructor.
showing elm_hover in constructor occurs unexpected behavior.
this fixes that bug.
Test Plan:
1. elementary_test - Combobox
2. Click the combobox to Expand the list.
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5267
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Thu, 5 Oct 2017 23:24:47 +0000 (16:24 -0700)]
efl: properly initialize Eina_File.
CID 1381605.
Cedric BAIL [Thu, 5 Oct 2017 23:23:50 +0000 (16:23 -0700)]
build: fix make examples on Windows
Summary: We should define the windows version before including evil.
Test Plan: Run make examples on windows newer than XP.
Reviewers: vtorri
Subscribers: jenkins, cedric, jpeg
Tags: #efl, #windows
Differential Revision: https://phab.enlightenment.org/D5261
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Thu, 5 Oct 2017 23:02:47 +0000 (16:02 -0700)]
evas: make sure we always open the file and look at its header before trying to load data.
Cedric BAIL [Thu, 5 Oct 2017 21:21:23 +0000 (14:21 -0700)]
eio: migrate example to use Eina_Future.
Cedric BAIL [Thu, 5 Oct 2017 18:36:23 +0000 (11:36 -0700)]
evas: remove evas_canvas3d_texture_file_set and efl_file_set instead.
Cedric BAIL [Thu, 5 Oct 2017 16:42:36 +0000 (09:42 -0700)]
evas: remove unused function evas_cache_image_request.
Cedric BAIL [Thu, 5 Oct 2017 16:41:41 +0000 (09:41 -0700)]
evas: remove unused function evas_cache_engine_image_request.
Cedric BAIL [Thu, 5 Oct 2017 16:37:07 +0000 (09:37 -0700)]
evas: remove unused function evas_common_load_image_from_file.
Cedric BAIL [Thu, 5 Oct 2017 16:36:45 +0000 (09:36 -0700)]
evas: remove unused fonction evas_gl_common_image_load.
Cedric BAIL [Thu, 5 Oct 2017 16:28:13 +0000 (09:28 -0700)]
eina: continue to check for magic.
Chris Michael [Thu, 5 Oct 2017 13:54:03 +0000 (09:54 -0400)]
evas-gl-image: Fix dereference after null check
Coverity reports passing a null pointer 'im->gc' to
evas_gl_common_context_flush which directly dereferences it, so lets
be sure that 'im->gc' is valid before passing it to context_flush
Fixes CID1374273
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 5 Oct 2017 13:51:00 +0000 (09:51 -0400)]
evas-gl-common: Fix dereference after null check
Coverity reports that there may be a null pointer dereference here so
check that 'error' exists before trying to set it.
Fixes CID1374272
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 5 Oct 2017 13:46:18 +0000 (09:46 -0400)]
eolian-bin: Free previously allocated eina_strbuf
Coverity reports that the eina_strbuf 'param_call' leaks when it goes
out of scope here, so fix the leak by freeing the strbuf
Fixes CID1381502
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Cedric Bail [Thu, 5 Oct 2017 04:48:26 +0000 (21:48 -0700)]
evas: remove image_load from the engine.
Cedric Bail [Thu, 5 Oct 2017 04:32:22 +0000 (21:32 -0700)]
evas: remove use of engine image_load from Evas.Canvas3D.Texture.
Cedric Bail [Thu, 5 Oct 2017 04:01:35 +0000 (21:01 -0700)]
evas: remove duplicated code and rely on Efl.File { get; set; }
We can almost remove image_load from the engine backend after this patch.
One little bit left in Evas_3D.
Cedric Bail [Thu, 5 Oct 2017 04:00:56 +0000 (21:00 -0700)]
edje: remove duplicated code and rely on Efl.File { set; get; } mixin.
Cedric Bail [Thu, 5 Oct 2017 03:58:06 +0000 (20:58 -0700)]
efl: make Efl.File a mixin that implement file_set for everyone.
Cedric Bail [Thu, 5 Oct 2017 03:57:08 +0000 (20:57 -0700)]
eina: Eina_Prefix should never contain a NULL, no code expect it.
Cedric Bail [Thu, 5 Oct 2017 03:56:15 +0000 (20:56 -0700)]
eina: allow eina_file_close(NULL) to simplify code using Eina_File.
Cedric Bail [Wed, 4 Oct 2017 18:32:09 +0000 (11:32 -0700)]
elementary: update code highlighting to follow eolian syntax change.
Chris Michael [Wed, 4 Oct 2017 15:41:59 +0000 (11:41 -0400)]
ecore-evas-drm: Implement support for hardware output rotations
This patch adds support for doing output rotations via hardware. This
is implemented inside the Ecore_Evas engine so that it is transparent
to the caller of ecore_evas_rotation_set.
ref T5999
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Bryce Harrington [Tue, 3 Oct 2017 18:36:41 +0000 (11:36 -0700)]
ector: minor grammar fixups
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5234
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Ivan Furs [Tue, 3 Oct 2017 18:22:07 +0000 (11:22 -0700)]
edje: moved from edje_multisense.c to Ecore_Audio.h for select the type of render.
Reviewers: NikaWhite, raster, cedric, vtorri, rimmed
Reviewed By: NikaWhite, vtorri
Subscribers: artem.popov, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5096
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Ivan Furs [Tue, 3 Oct 2017 18:21:07 +0000 (11:21 -0700)]
ecore_audio: a minimal template for playing sound on WINDOWS is added
Summary:
Realization of audio data playback through WASAPI (Windows Audio Session API).(minimal)
WASAPI model:
1. Find a playback device (in the default system)
2. Register the client on the playback device.
3. Create a playback format for audio data.
4. Initialize the client with the created format, and access mode, ....
5. Take the object-rendering from the client for play the data stream.
6. Play data stream
ecore_audio model:
1. create a object for play the data stream(out object)
2. create a object to receive the data stream(in object)
3. register in the out-object the in-object
4. play data stream
Necessary:
Realize the ecore_audio object to play the data stream using the WASAPI model.
How implemented:
1. The object ecore_audio_out_wasapi is implemented
2. object ecore_audio_out_wasapi - the object constructor is find a playback device (in the default system)(WASAPI)
3. _ecore_audio_out_wasapi_ecore_audio_out_input_attach - register in the out-object the in-object
3.1 Register the client on the playback device.(WASAPI)
3.2 Create a playback format for audio data.(WASAPI)
3.3 Initialize the client with the created format, and access mode, ....(WASAPI)
4. _write_cb - play data
4.1 Take the object-rendering from the client for play the data stream.(WASAPI)
4.2 Play data stream(WASAPI)
Reviewers: cedric, vtorri, raster, an.kroitor, NikaWhite, FurryMyad, rimmed, t.naumenko, Jaehyun, bowonryu
Reviewed By: vtorri, NikaWhite
Subscribers: artem.popov, cedric, jpeg
Tags: #windows
Differential Revision: https://phab.enlightenment.org/D5029
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Tue, 3 Oct 2017 17:25:03 +0000 (13:25 -0400)]
elput: Fix issue of pointer rotation not being set on startup
elput_input_pointer_rotation_set may be getting called before input
devices are actually added, so we need to be able to set pointer
rotation when a device actually gets added.
To fix this, we will store the requested input rotation value, and
apply it at the time of input device creation.
NB: The current case is that the wl_drm module will apply existing
output rotation before Input has completely initialized, thus any
calls to set the pointer rotation there will not succeed as input
devices have not been created yet.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Tue, 3 Oct 2017 17:33:14 +0000 (13:33 -0400)]
ecore-file: do not emit events when an inotify watch is removed
???????????????????????????????????????????????????????????????????????????????
@fix
Chris Michael [Mon, 2 Oct 2017 12:19:42 +0000 (08:19 -0400)]
elementary: Mark unused function parameter as unused
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 2 Oct 2017 12:12:06 +0000 (08:12 -0400)]
ecore-con: Mark unused function paramater as unused
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Hirt [Mon, 2 Oct 2017 08:03:37 +0000 (11:03 +0300)]
Canvas layout: fix Efl.text (non-legacy) TEXT parts
Current implementation should also support TEXT parts (like button)
with usage of efl_text_set.
Follow-up to
0061a4bb349e6c8e122913791bf83f7f40b0cede.
Vincent Torri [Sun, 1 Oct 2017 16:07:02 +0000 (17:07 +0100)]
Windows: remove XP support and forbid compilation and run on this platform
Test Plan: run on XP
Reviewers: jpeg, cedric, ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5245
Daniel Hirt [Sun, 1 Oct 2017 15:40:50 +0000 (18:40 +0300)]
Ui layout: handle Efl.Text legacy code better
This should cover the cases without need to duplicate a lot of code.
Follow-up to
deca3c947ff1a2bed3f4baadce576105055af266.
Daniel Hirt [Sun, 1 Oct 2017 15:38:18 +0000 (18:38 +0300)]
Canvas layout: improve legacy code paths for Efl.Text
Better handling of specific cases where you want to efl_text_set on
a TEXTBLOCK part.
Follow-up to
af1595fd0160f76de82cddeb2576143f65492c0b.
Al Poole [Sun, 1 Oct 2017 10:10:28 +0000 (11:10 +0100)]
elm_code_widget: set appropriate background colour.
Daniel Hirt [Sun, 1 Oct 2017 08:37:42 +0000 (11:37 +0300)]
Canvas layout: fix legacy text set
Keep the legacy code path when using edje_object_part_text_set.
Fixes e's notification that got broken after
3642b3ae679e3bedba4155fb9e54b44483b3b9e1.
Also, limit new efl_text_markup set to TEXTBLOCK parts.
Carsten Haitzler (Rasterman) [Sun, 1 Oct 2017 07:04:35 +0000 (16:04 +0900)]
eina debug - add missing unlock in erite err case
fix CID 1381503
Marcel Hollerbach [Sat, 30 Sep 2017 17:32:31 +0000 (19:32 +0200)]
efl_ui_focus_object: also implement focus.get
Marcel Hollerbach [Sat, 30 Sep 2017 17:29:00 +0000 (19:29 +0200)]
evas_focus: skip focus set if the focus state is the same
Cedric BAIL [Fri, 29 Sep 2017 23:01:02 +0000 (16:01 -0700)]
ecore_con: simplify Efl.Net.Server.Ssl by inheriting from Efl.Net.Server.Tcp.
Cedric BAIL [Fri, 29 Sep 2017 21:12:03 +0000 (14:12 -0700)]
ecore_con: add an intermediate Efl.Net.Server.Ip
Daniel Kolesa [Fri, 29 Sep 2017 11:00:07 +0000 (13:00 +0200)]
eolian gen: simplify generate_normal_free a bit
Marcel Hollerbach [Fri, 29 Sep 2017 09:27:18 +0000 (11:27 +0200)]
efl_ui_focus_manager_calc: correctly specify owned where its needed
Marcel Hollerbach [Fri, 29 Sep 2017 09:09:33 +0000 (11:09 +0200)]
Revert "elm focus manager - dont leak child lists when updating focus order"
This reverts commit
bd6dcbb044ffea543f27cc69c421317bdea4a14a.
This was not fixing the issue, just ducktaping over a bug in eolian, the
bug is now probebly fixed in eo / eolian.
Marcel Hollerbach [Fri, 22 Sep 2017 20:56:31 +0000 (22:56 +0200)]
eolian: add tests for the new owning functions
Marcel Hollerbach [Thu, 14 Sep 2017 13:12:30 +0000 (15:12 +0200)]
eolian: generate free function for owned parameters
With this commit owned parameters are freed if the object function
cannot be called, this means bla(NULL,param) will not leak anymore
Marcel Hollerbach [Thu, 14 Sep 2017 11:55:41 +0000 (13:55 +0200)]
eo: introduce function definitions with fallback
there can be cases where the call to such a function is never going to
be directed to the actual implementation. In those cases the FallackCall
will be called.
Youngbok Shin [Fri, 29 Sep 2017 06:29:31 +0000 (15:29 +0900)]
edje entry: fill content info when text is deleted by imf event
Summary:
There was missing info when text is deleted by _edje_entry_imf_event_delete_surrounding_cb().
@fix
Test Plan: N/A
Reviewers: kimcinoo, raster, cedric, jpeg, herdsman
Differential Revision: https://phab.enlightenment.org/D5240
Youngbok Shin [Fri, 29 Sep 2017 06:16:21 +0000 (15:16 +0900)]
evas font: check returned value of FcPatternGet function
Summary:
Evas should add font when only FcPatternGet function gives matched result.
@fix
Test Plan: N/A
Reviewers: raster, cedric, herdsman, jpeg
Differential Revision: https://phab.enlightenment.org/D5236
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 05:52:04 +0000 (14:52 +0900)]
efl ui textpath - remove more unused vars
Amitesh Singh [Fri, 29 Sep 2017 04:35:21 +0000 (13:35 +0900)]
elm test: rename test_slider_interval.c to test_ui_slider_interval.c
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 03:32:10 +0000 (12:32 +0900)]
efl ui textpath - remove unused vars due to dead code removal
fix warning
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 03:07:48 +0000 (12:07 +0900)]
evas cserve - fix validation of cserve mesg size field
fix coverity CID 1039567
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 03:03:37 +0000 (12:03 +0900)]
evas cseve - check msgsize before using - coverity
fix CID 1039568
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:57:06 +0000 (11:57 +0900)]
elm atspi - fix checking return of eldbus_message_iter_arguments_get
fix coverity CID 1353590
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:52:42 +0000 (11:52 +0900)]
elm config - fix eina value setting to check get return
fix CID 1357139
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:47:55 +0000 (11:47 +0900)]
evas ector gl - fix leak of image data on data put
@fix
fix coverity found leak CID 1374645
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:45:30 +0000 (11:45 +0900)]
evas ector gl - make coverity happy about leaks on data put
fix CID 1374646
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:39:39 +0000 (11:39 +0900)]
eina debug - check write return values and complain on failure
coverity - fix CID 1377521
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:31:17 +0000 (11:31 +0900)]
eina debug - check write return value and complain
makes coverity happy - CID 1377524
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:21:37 +0000 (11:21 +0900)]
efl debugd - check return of write func and report errors
makes coverity happy and reports write errors... fix CID 1377525
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 02:07:12 +0000 (11:07 +0900)]
efl model - fix checking return of eina_accessor_data_get
coverity - fixes CID 1380995
Cedric Bail [Fri, 29 Sep 2017 01:22:32 +0000 (18:22 -0700)]
eio: do not copy memory for nothing.
Cedric Bail [Fri, 29 Sep 2017 01:21:18 +0000 (18:21 -0700)]
eio: use TIMESTAMP when meaningful.
Cedric Bail [Fri, 29 Sep 2017 01:18:38 +0000 (18:18 -0700)]
eio: migrate efl.io.manager.ls to use Eina_Future.
Cedric Bail [Fri, 29 Sep 2017 01:17:57 +0000 (18:17 -0700)]
ecore: allow other thread to write local data on a thread to increase utility.
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 00:09:04 +0000 (09:09 +0900)]
elm widget - event legacy propagation - remove coverity warning
fix CID 1379920 - event_flags is actually never NULL or undefined in
the function logic. it's always set to point to the specific event
flags field depending on struct type or the function will return
before using the pointer.
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 00:03:04 +0000 (09:03 +0900)]
efl text markup - fix hex check to be or not and - found by coverity
fix CID 1381491
Carsten Haitzler (Rasterman) [Fri, 29 Sep 2017 00:00:43 +0000 (09:00 +0900)]
efl ui focusable - remove pointless check of ptr already checked
coverity fix CID 1381492
Daniel Kolesa [Thu, 28 Sep 2017 21:25:12 +0000 (23:25 +0200)]
eolian: fix tests after extra checks
Daniel Kolesa [Thu, 28 Sep 2017 21:22:05 +0000 (23:22 +0200)]
eolian: validate inner types of complex types
This makes sure the inner types are all correctly defined and
that freefuncs are actually correctly filled.
Felipe Magno de Almeida [Thu, 28 Sep 2017 20:48:04 +0000 (17:48 -0300)]
eolian-cxx: Add optional parameter to lambda for unnamed proxy instantiation
Stefan Schmidt [Thu, 28 Sep 2017 20:35:13 +0000 (22:35 +0200)]
ci: disable examples build for osx for now
On the 10.12 build we regularly run into the maximum time limit for a
osx build job (45min?). Lets focus on the normal build for now.
Daniel Hirt [Thu, 28 Sep 2017 07:27:32 +0000 (10:27 +0300)]
Ui layout: support markup for efl_part()
Also implement markup_set/get for:
- Efl.Ui.Frame
- Efl.Ui.Slider
Users may choose between text_set/get and markup_set/get, depending on
whether they want to escape their text or not.
Daniel Hirt [Thu, 28 Sep 2017 06:46:42 +0000 (09:46 +0300)]
Canvas layout: support markup for efl_part
Users can now do either:
efl_text_set(efl_part(obj, "part"), "text");
efl_text_markup_set(efl_part(obj, "part"), "text");
Also have efl_text_get/markup_get.
Using markup_set will allow to choose whether to set a markup or a text
to the text part.
Daniel Hirt [Thu, 28 Sep 2017 16:29:35 +0000 (19:29 +0300)]
Canvas text: use EINA_UNUSED for unused variables
Nothing special here. No need to for the "(void) eo_obj".
Daniel Hirt [Thu, 28 Sep 2017 16:26:41 +0000 (19:26 +0300)]
Ui text: add test for Efl.Text.Markup
Daniel Hirt [Mon, 25 Sep 2017 16:21:21 +0000 (19:21 +0300)]
Efl text: add Efl.Text.Markup interface
Adds basic markup operations for text objects, and implements it in
Efl.Canvas.Text.
Also, this adds the Efl.Text.Markup_Util class.
This utility class allows basic text-markup conversions.
@feature
Stefan Schmidt [Thu, 28 Sep 2017 13:34:56 +0000 (15:34 +0200)]
ci: README: simple docs for the current CI setup
Describe what we currently do in terms of building on Travis and how
developer can do a local test with the docker build.
Stefan Schmidt [Thu, 28 Sep 2017 13:26:55 +0000 (15:26 +0200)]
ci: initial travis CI support for Linux distros and MacOSX builds
This has been used by myself in a branch for a while now and it is time
to bring it into master as a base for all future CI related work.
I plan to use the same scripts and other bits for Jenkins as well as
other CI systems later on.
What we currently cover with this setup are linux builds for three
different distros and MacOSX builds for two different versions.
Travis will only be called when new commits get mirrored onto our GitHub
mirror (which only happens once an hour). Expect delays on these builds.
https://travis-ci.org/Enlightenment/efl
Shinwoo Kim [Thu, 28 Sep 2017 11:08:25 +0000 (20:08 +0900)]
elementary: atspi - fix dbus abort
This patch set fix following abort occured on dbus side.
(gdb) bt
0 __GI_raise (sig=sig@entry=6)
1 __GI_abort ()
2 _dbus_abort ()
3 _dbus_warn_check_failed
4 dbus_message_iter_append_basic
5 append_basic
6 eldbus_message_iter_basic_append
7 _bridge_signal_send
8 _text_text_removed_send
9 _bridge_accessible_event_dispatch
10 _elm_interface_atspi_accessible_event_emit
11 elm_interface_atspi_accessible_event_emit
12 _entry_changed_user_signal_cb
(gdb) f 12
(gdb) p *$1
$2 = {change = {insert = {content = 0x0, pos = 0, plain_length = 1},
del = {content = 0x0, start = 0, end = 1}},
insert = 0 '\000', merge = 0 '\000'}
The following patch set would fix the root cause of this problem.
https://phab.enlightenment.org/D5240
Jean-Philippe Andre [Thu, 28 Sep 2017 08:11:15 +0000 (17:11 +0900)]
efl: Remove @owned tag from pack/content APIs
Refer to the previous commits for more context.
When an evas object is given to a container, be it with a variant of
efl_pack() or efl_content_set(), its "ownership" is given to the new
parent container. But ownership here means that the new container may
delete the child when it sees fit (i.e. when the container itself dies,
for instance). This does not mean that a reference was passed from the
calling context to the container. The actual EO owner of the child is
always the canvas or another canvas object, even if it the object is
unpacked.
Note: This means that invalid calls to efl_pack or efl_content_set will
not automatically delete the child object. This is the same as legacy,
and results in floating objects. Just check the return value! :)
Hopefully this is correct for bindings.
Jean-Philippe Andre [Thu, 28 Sep 2017 07:50:53 +0000 (16:50 +0900)]
tests: Use efl_unref() on duplicated event objects
efl_del() is valid but bindings such as C++ should be using efl_unref()
and not efl_del() in this situation: a reference was given, so it should
be released.
Jean-Philippe Andre [Thu, 28 Sep 2017 07:45:45 +0000 (16:45 +0900)]
evas: Give a parent to duplicated event objects
This comes back to an earlier situation where the fake event objects
created by efl_input_dup() had a parent (it should be the evas or maybe
the window). But that led to issues as efl_unref() would print error
messages. Using efl_allow_parent_unref_set() we hide the error message,
because in this situation we want the caller to use efl_unref() and not
efl_del() (eg. think of bindings...).
See
d3436af616319f1fdbbd4a0aa71a7835a14699ac
See
6bed255fc4bbe1b30c960339e8dda2fc6e7925cd
See
96d94e0076773d6b29107035dc61f5df01a3347f <-- main commit