JunsuChoi [Mon, 6 Jan 2020 01:13:28 +0000 (10:13 +0900)]
Efl.Ui.Animation_View : resolve migration build error
Migration patch
0b55cf4 Efl.Ui.Vg_Animation: Implaments Efl.Playable interface
4addc4b Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation
2b8e667 Efl.Player: Add setter of playback_progress
c555580 Efl.Ui.Animation_View: Change state name
1a34395 Efl.Ui.Animation_View: Implements Efl.Player interface
Change-Id: Id09ecb5562668093528795bcd599c90cd602c561
JunsuChoi [Thu, 2 Jan 2020 07:57:39 +0000 (16:57 +0900)]
elm_animation_view: Fix play/play_back behavior
Summary:
In elm_animation_view(legacy), play means forward and play_back backward.
So change the sign of the speed value for control.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10995
JunsuChoi [Tue, 31 Dec 2019 14:53:23 +0000 (09:53 -0500)]
Efl.Ui.Vg_Animation: Implaments Efl.Playable interface
Summary:
Change API
.duration_time => Efl.Playable.length.get
ref T8476
Depends on D10939
Test Plan: N/A
Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi, zmike
Reviewed By: segfaultxavi, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D10953
JunsuChoi [Tue, 31 Dec 2019 14:53:16 +0000 (09:53 -0500)]
Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation
Summary:
Since "View" is a reserved word for MVVM, change the class name appropriately.
Efl.Ui.Animation_View => Efl.Ui.Vg_Animation
ref T8476
Depends on D10931
Test Plan: elementary_test -> "Vector Graphcis Animation"
Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D10939
JunsuChoi [Tue, 31 Dec 2019 14:53:10 +0000 (09:53 -0500)]
Efl.Player: Add setter of playback_progress
Summary:
The setter of Efl.Player.playback_progress is implemented in each class below.
Efl.Ui.Animation_View
Efl.Ui.Image
Efl.Ui.Image_Zoomable
Efl.Canvas.Video
ref T8476
Depends on D10915
Test Plan: N/A
Reviewers: Hermet, bu5hm4n, kimcinoo, Jaehyun_Cho, segfaultxavi, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D10931
JunsuChoi [Tue, 31 Dec 2019 14:53:03 +0000 (09:53 -0500)]
Efl.Ui.Animation_View: Change state name
Summary:
play-> playing
play_back -> playing_backwards
pause -> paused
stop -> stoped
Depends on D10862
ref T8476
Test Plan: N/A
Reviewers: Hermet, bu5hm4n, segfaultxavi, kimcinoo
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D10915
JunsuChoi [Tue, 31 Dec 2019 14:52:56 +0000 (09:52 -0500)]
Efl.Ui.Animation_View: Implements Efl.Player interface
Summary:
Chnaged API
.speed.set => Efl.Player.playback_speed.set
.speed.get => Efl.Player.playback_speed.get
.progress.get => Efl.Player.playback_progress.get
.play => Efl.Player.playing.set(true)
.stop => Efl.Player.playing.set(false)
.pause => Efl.Player.paused.set(true)
.resume => Efl.Player.paused.set(false)
.play_sector => .playing_sector
.auto_play => .autoplay
.auto_repeat => .autorepeat
Remove API
.is_playing_back
.playback => (use negative speed value)
New feature API
Efl.Player.playback_position.set
Efl.Player.playback_position.get
Efl.Player.playing.get
Efl.Player.paused.get
ref T8476
Test Plan:
meson_option.txt -> remove json in evas-loaders-disabler option
elementary_test -to "animation view"
Reviewers: Hermet, bu5hm4n, kimcinoo, Jaehyun_Cho, segfaultxavi, zmike
Reviewed By: segfaultxavi, zmike
Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D10862
Alastair Poole [Sun, 5 Jan 2020 17:36:33 +0000 (17:36 +0000)]
elm_code_text: Return empty string on 0 length.
Throughout elm_code we rely on this function returning a valid
string (unless the line object isn't set/is NULL).
Carsten Haitzler (Rasterman) [Sat, 4 Jan 2020 20:58:16 +0000 (20:58 +0000)]
elm - widget - actually check object smart data return for no data
so sometimes widgets dont have smart data - some situtions happen...
but let's not segfault. instead we now see the usual eina log eerrs
and things march on... and no segv.
@fix
Carsten Haitzler (Rasterman) [Fri, 3 Jan 2020 18:22:28 +0000 (18:22 +0000)]
gl native surf - create pixmap failes - make them warns
these can be race conditions so really should be warns and not errors.
they just are noise we'll never fix as it's racey anyway...
Xavi Artigas [Fri, 3 Jan 2020 15:14:45 +0000 (16:14 +0100)]
docs: whitespace and punctuation of Efl.Canvas.Animation_Scale
Hermet Park [Fri, 3 Jan 2020 11:51:21 +0000 (20:51 +0900)]
evas map: ++Safety for range overflow.
This might fix this issue.
{T8199}
Xavi Artigas [Fri, 3 Jan 2020 10:57:27 +0000 (11:57 +0100)]
docs: Remove Evas reference from Efl.Canvas.Textblock
abdulleh Ghujeh [Fri, 3 Jan 2020 10:24:35 +0000 (11:24 +0100)]
Example: Add efl_canvas_textblock_obstacles example
Summary: Add efl canvas textblock example based on unified APIs (converted from legacy)
Reviewers: ali.alzyod, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: woohyun, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8460
Differential Revision: https://phab.enlightenment.org/D10955
abdulleh Ghujeh [Fri, 3 Jan 2020 07:45:26 +0000 (16:45 +0900)]
Evas Textblock : Fix obstacles & word overlap
Summary:
Revert part of old commit which caused wrong behavior in textblock with obstacles, we should use obstacle x pos.
There is no comments about why this was changed.
{
F3821294}
Old commit is :
Aug 23, 2017
e63be982d904a01ade5aced9ef9924a78d155b8a
related to D10955
Test Plan: Run Textblock Obstacle example
Reviewers: ali.alzyod, woohyun, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11005
Bruno da Silva Belo [Thu, 2 Jan 2020 22:27:25 +0000 (22:27 +0000)]
c#: Checking null for parameters generated code.
Checking null for generated code
ref T8399
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10970
Marcel Hollerbach [Thu, 2 Jan 2020 14:56:29 +0000 (09:56 -0500)]
efl_ui_spin_button: improve "keep clicking" behavior
Summary:
when you keep a pressed cursor on the inc or dec button, you likely dont
want to have to wait 0.8s for one tick, so this is simply lowering this
time to 0.2.
Depends on D11000
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11001
Marcel Hollerbach [Thu, 2 Jan 2020 14:49:50 +0000 (09:49 -0500)]
efl_spec_suite: remove callbacks at the end of a test
Summary:
we might access changed, which is stacked. This fixes a potential crash.
Depends on D11001
Reviewers: cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11002
Marcel Hollerbach [Thu, 2 Jan 2020 14:35:34 +0000 (09:35 -0500)]
efl_canvas_animation_scale: enhance documentation
Reviewers: segfaultxavi, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10996
Marcel Hollerbach [Thu, 2 Jan 2020 14:35:31 +0000 (09:35 -0500)]
evas: protect against leaking callbacks
Summary:
when someone accidently does not clean up all his animation callbacks,
we might end up with a lot of errors on console, as we keep delivering
tick events to a dead object.
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10998
Marcel Hollerbach [Thu, 2 Jan 2020 14:30:20 +0000 (09:30 -0500)]
efl_ui_spotlight_manager_stack: stack hide content below show content
Summary:
the spotlight manger fades in new content, and hides the old content.
With this commit the show content is stacked above the hide content,
which means, the user can already interact with the new content, before
the old one is hidden.
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10997
Marcel Hollerbach [Thu, 2 Jan 2020 14:27:16 +0000 (09:27 -0500)]
efl_ui_spotlight_manager_stack: do not keep final state
Summary:
keeping the final state here results in the fact that the map is not
getting reseted. Which is a problem, as the element would not be
displayed correctly after that.
Final state here means, that the last configuration of Efl.Gfx.Mapping will be kept, and it will *not* be resetted.
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10999
Marcel Hollerbach [Thu, 2 Jan 2020 14:07:13 +0000 (09:07 -0500)]
efl_ui_item: add API that restricts a item from beeing unselected
Summary:
There are usecases where items should not be unselectable by the user.
For example in the tab_bar. With this commit, a tab bar user cannot
unselect a item by hand anymore.
Depends on D10305
Reviewers: zmike, woohyun, segfaultxavi, cedric
Reviewed By: zmike, segfaultxavi, cedric
Subscribers: SanghyeonLee, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10306
ali [Thu, 2 Jan 2020 11:52:22 +0000 (12:52 +0100)]
efl.text: add null check for cursor and attribute internal methods
Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike
Reviewed By: bu5hm4n
Subscribers: ProhtMeyhet, cedric, #reviewers, #committers
Tags: #efl
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10899
Cedric BAIL [Fri, 27 Dec 2019 21:50:48 +0000 (13:50 -0800)]
evas: don't initialize font multiple time.
After splitting font family and size set operation, expedite lost a 10%
speed due to doing a double initialization (Once when the family is set
and one when the size is set). This was noticable in a few tight running
tests. This patch enforce that no initialization is called until the size
and the family are set.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10976
Ali Alzyod [Tue, 31 Dec 2019 07:15:29 +0000 (07:15 +0000)]
Efl.Text.Font.Properties: rename Efl.Text_Font_Properties
Efl.Text.Font.Properties: rename Efl.Text_Font_Properties
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10990
Boris Faure [Thu, 2 Jan 2020 11:38:31 +0000 (11:38 +0000)]
evas: fix compilation with -Dwl=false
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10994
Ali Alzyod [Thu, 2 Jan 2020 08:19:24 +0000 (08:19 +0000)]
efl_ui_text: scroller mode clean up
simplify code, and reduce calls:
It is only required to set scroll mode in two cases:
- When creating scroller
- When changing multiline property
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10981
ali [Fri, 27 Dec 2019 06:24:55 +0000 (06:24 +0000)]
efl.text.font.properties: remove comments from eo files
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10971
Marcel Hollerbach [Sun, 29 Dec 2019 10:31:53 +0000 (11:31 +0100)]
efl_ui_collection: always scroll in the item
never the focused element. The focused element can be different from the
item. This fixes a error when item is not focusable, but content in the
item is.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10980
Ali Alzyod [Thu, 2 Jan 2020 07:25:35 +0000 (07:25 +0000)]
efl.text.cursor: emit events CANVAS_TEXTBLOCK_CHANGED when insert text using efl_text_cursor_markup_insert
efl.text.cursor: emit events CANVAS_TEXTBLOCK_CHANGED when insert text using efl_text_cursor_markup_insert
Differential Revision: https://phab.enlightenment.org/D10985
Ali Alzyod [Sun, 29 Dec 2019 09:49:04 +0000 (09:49 +0000)]
efl.text.interactive: remove event freeze when keyboard button is pressed
this event freeze will prevent submission of EFL_UI_TEXTBOX_EVENT_CHANGED on efl.ui.textbox object, when inserting text using the keyboard.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10979
Alastair Poole [Thu, 2 Jan 2020 00:01:00 +0000 (00:01 +0000)]
elm_code_widget: Line numbers Off then Gutter Off.
When line numbers were disabled in the widget there was still
some remnant of the background colour of gutter in the widget.
This respects having the line numbers disabled visually.
Alastair Poole [Wed, 1 Jan 2020 23:16:25 +0000 (23:16 +0000)]
elm_code_widget: Fix cursor position sync.
The scroller was causing the cursor to be out of sync with the
widget content. This fixes that.
SangHyeon Jade Lee [Tue, 31 Dec 2019 14:48:18 +0000 (09:48 -0500)]
evas: fix legacy evas_object_clip_unset for group object.
Summary:
evas_object_clip_unset was broken for group object in several month or year..
basically,
evas_object_clip_unset(obj)
efl_canvas_object_clipper_set(obj, NULL)
is equal on efl_clip implements,
but on the group object, we need to unclip the whole group children in
efl_canvas_group_efl_canvas_object_clipper_set
which was not performed by legacy clip_usnet API.
Test Plan:
try clip_unset(obj) and clipper_set(obj, NULL) in any group clipped case
(i.e. scroller content) and see clip_unset is broken and fixed by patch.
Reviewers: cedric, bu5hm4n, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10984
Ali Alzyod [Mon, 30 Dec 2019 15:36:02 +0000 (15:36 +0000)]
efl_ui_text: support focus navigation
With this commit you can move the focus from the textbox widget to the surrounding widgets, (as it is done in legacy).
ref T8538
ref T8522
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10987
Ali Alzyod [Mon, 30 Dec 2019 14:15:58 +0000 (14:15 +0000)]
elementary_text: Efl.Ui.Textbox Input Field
Entry was added to the same box. This commit fixes this.
You could observe this problem when starting the "Textbox Input Field" demo in elm_test
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10986
Marcel Hollerbach [Tue, 31 Dec 2019 08:59:41 +0000 (09:59 +0100)]
efl_ui_datepicker: do not substract anything fom mday
out of the documentation of struct tm:
int tm_mday; /* Day. [1-31] */
shifting this range one up results in day 32 beeing selectable, but 1
not beeing selectable.
With this commit we could have again working CI.
Differential Revision: https://phab.enlightenment.org/D10992
Lauro Moura [Mon, 30 Dec 2019 21:42:24 +0000 (21:42 +0000)]
csharp: Add StyleCop support to dotnet build
This patch adds support to run the StyleCop rules. To enable, -Ddotnet=true
is needed, You can pass -Ddotnet-stylecop=CAXXXX,CAXXYY where X and Y are digits for CAs
or SAs. You can also ask that the CAs and SAs cause errors instead of warnings.
Differential Revision: https://phab.enlightenment.org/D10969
Hermet Park [Fri, 3 Jan 2020 11:37:55 +0000 (20:37 +0900)]
Revert "Revert "Revert "evas map: diable high quality texture mapping feature."""
This reverts commit
3b2dc28faca904e5ac67bfa1340bc9b585b55ce0.
Change-Id: I221dbb8b60723666cd9dffe42e70d768f242bb92
Hermet Park [Thu, 2 Jan 2020 05:14:47 +0000 (14:14 +0900)]
ui_image: fix wrong scale_method expand behavior.
Previous fix
46ee203331d596ac3aa1ec48b729be42c084088a is not perfect
at some cases, its condition should be this.
Change-Id: I4616737214fc1084da7c9684876b004164aa628b
Hermet Park [Tue, 31 Dec 2019 07:27:25 +0000 (16:27 +0900)]
evas gl: enable GL_LINE_SMOOTH only at gles 1.x
As the GLES specification,
GL_LINE_SMOOTH is not supported since GLES2.
Change-Id: I8db4c26aad2247d7182c83844382745556c79004
Hermet Park [Tue, 31 Dec 2019 06:13:45 +0000 (15:13 +0900)]
vector container: skip re-ordering as possible.
don't try anything if the stack is already top or bottom.
Change-Id: I98be79b03ca52e66d086e3ad553313909ba593e7
Hermet Park [Tue, 31 Dec 2019 05:32:53 +0000 (14:32 +0900)]
vector lottie: update shape layer order properly.
Shape layer order can be changed during animation,
We should rearrange them if it's necessary.
Change-Id: I2ff3e74fbc268f97430a2ef694a1a5e3b6d7dc34
Hermet Park [Tue, 31 Dec 2019 05:15:49 +0000 (14:15 +0900)]
evas vg: add an new interface efl_canvas_vg_container_children_direct_get()
Summary: We need an efficient method to navigate children faster.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10989
Change-Id: I94665add04127a18f3c131a84c2b6684186e460f
Hermet Park [Tue, 31 Dec 2019 04:29:24 +0000 (13:29 +0900)]
evas vg: rewrite efl_gfx_stack_raise_to_top, lower_to_bottom()
The implementation was totally stupid,
previous function were wrongly working.
Thus, we rewrite it simple again.
Change-Id: I02f5c386a1f0bf1e0c79f285702ee986ec28eeec
Hosang Kim [Mon, 30 Dec 2019 10:45:33 +0000 (19:45 +0900)]
elm_atspi_bridge: Add re-reading of highlight object feature
@tizen_only
Change-Id: Iacec8f8924db9ce2aa5ba3021d099240ecf6d966
Hosang Kim [Mon, 30 Dec 2019 10:43:26 +0000 (19:43 +0900)]
accessibility: Accessibility Highlight Frame added
@tizen_only
Change-Id: I042501d4ad2d20a7c7b9d6f4198e858f3809b34d
Stefan Schmidt [Mon, 30 Dec 2019 16:38:03 +0000 (11:38 -0500)]
ci: create a daily build to run with coverage enabled and upload to codecov
Summary:
For this we bring back a native Linux build on the Travis with Ubuntu
bionic. This allows use easy integration with codecov as Travis and
Codecov have figured out all details.
This means we need to be a bit more careful with our $DIST checks as
empty no longer means osx. It could as well be the Linux job.
Covergae reports will show up here:
https://codecov.io/gh/Enlightenment/efl
We are starting with 36%. Time to improve. :-)
Fixes: T7910
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10867
Hosang Kim [Mon, 30 Dec 2019 16:23:22 +0000 (11:23 -0500)]
ecore_evas_buffer: Unregister input events when ecore_evas_buffer is freed
Summary:
When ecore_evas_buffer is freed, input events is not unregistered.
So _window_hash size is increasing.
Reviewers: Hermet, cedric, raster, zmike
Reviewed By: zmike
Subscribers: zmike, rajeev.jnnce, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10983
a.srour [Mon, 30 Dec 2019 16:12:37 +0000 (11:12 -0500)]
Edje: edc text_class applied without font or font_size in style
Summary:
The issue with `text_class` in Edc styles has to be within a string containing `font` & `font_size` properties to effect style, if font or font_size not presented in the same string text_class will be ignored.
So in the following Edc example, `text_class` will be ignored:
```
collections {
text_classes {
text_class {
name: "tc1";
font: "Sans";
size: 20;
}
}
styles {
style {
name: "style1";
base: "color=#00FF00 text_class=tc1";
tag: "br" "\n";
}
}
}
```
To apply text_class `tc1`, font and font_size has to be added to `styles.style.base` value, to be as follows:
```
...
base: "font=Serif font_size=15 color=#00FF00 text_class=tc1";
...
```
NOTE: The produced font will be `Sans` and font_size equal to `20`
Test Plan:
`layout.edc`
```
// compile: edje_cc layout.edc
// play: edje_player layout.edj
collections {
text_classes {
text_class {
name: "tc1";
font: "Sans";
size: 20;
}
}
styles {
style {
name: "style1";
base: "color=#FFFFFF text_class=tc1";
}
}
group {
name : "group1";
parts {
part {
name : "tb1";
type: TEXTBLOCK;
scale: 1;
entry_mode: NONE;
description {
state: "default" 0.0;
rel1.relative: 0.0 0.0;
rel2.relative: 0.5 0.5;
text {
style: "style1";
align: 0.0 0.0;
text: "Hello EFL";
}
}
}
}
}
}
Reviewers: segfaultxavi, smohanty, ali.alzyod, cedric, zmike
Reviewed By: zmike
Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8477, T8478
Differential Revision: https://phab.enlightenment.org/D10692
Marcel Hollerbach [Mon, 30 Dec 2019 16:12:32 +0000 (11:12 -0500)]
efl_ui_spin_button: lets support floating point numbers
Summary: this was a int ... cutting of the floating point digits. Now it works.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10977
Marcel Hollerbach [Mon, 30 Dec 2019 16:08:53 +0000 (11:08 -0500)]
efl_ui_progressbar: rename from pulse to infinite_mode
Summary:
ref T8501
Depends on D10942
Reviewers: cedric, woohyun, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8501
Differential Revision: https://phab.enlightenment.org/D10943
Marcel Hollerbach [Mon, 30 Dec 2019 16:08:47 +0000 (11:08 -0500)]
efl_ui_progressbar: remove pulse_mode
Summary:
pulse_mode is now implicit with pulse, if you set the progressbar to
pulse, the state is internally adjusted in a way that the theme is put
into the correct state. Legacy is not impacted by this because of the
previous commit.
ref T8501
Depends on D10941
Reviewers: cedric, woohyun, zmike, segfaultxavi
Reviewed By: zmike, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8501
Differential Revision: https://phab.enlightenment.org/D10942
Marcel Hollerbach [Mon, 30 Dec 2019 16:08:41 +0000 (11:08 -0500)]
elm_progressbar: make pulse and pulse_mode independend from legacy
Summary:
the next commit will refactor this API for Efl.Ui namespace.
ref T8501
Reviewers: cedric, woohyun, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8501
Differential Revision: https://phab.enlightenment.org/D10941
Carsten Haitzler (Rasterman) [Mon, 30 Dec 2019 14:06:50 +0000 (14:06 +0000)]
elm - theme - fix corner case of double-select on new radio styles
ali [Mon, 30 Dec 2019 04:27:13 +0000 (13:27 +0900)]
efl.text.style: underline enum rename + underline method fix
Summary: underline methods was not working + fix enums names
Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7945
Differential Revision: https://phab.enlightenment.org/D10975
ali [Mon, 30 Dec 2019 01:56:37 +0000 (10:56 +0900)]
efl.text.style: strikethrough_type & Background_type enum rename
Summary:
rename **solid color** to **single**
rename **disabled** to **none**
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7942, T7941
Differential Revision: https://phab.enlightenment.org/D10974
Ali Alzyod [Mon, 30 Dec 2019 01:31:32 +0000 (10:31 +0900)]
efl_ui_textbox: replace legacy calls with new ones
Summary: This patch only changes some of legacy calls, with new ones
Reviewers: woohyun, zmike, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D10982
Jongmin Lee [Sun, 29 Dec 2019 20:59:50 +0000 (05:59 +0900)]
build: resolve migration build error
Change-Id: Iede685655597e8ad3f06c41723be319717f6f257
suresh.ku1 [Thu, 26 Dec 2019 12:43:38 +0000 (18:13 +0530)]
[Naviframe] Support added for mirroring enable and disable
Change-Id: I87e3c8582cf5d3652c5a4af4ef2135c79953e8a0
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Shilpa Singh [Mon, 16 Dec 2019 10:46:19 +0000 (16:16 +0530)]
[Entry]: Anchor reading and related fixes
Change-Id: Ib4a603a9731a6f9d699bbf2aee467672e8c4c1e0
Signed-off-by: Nihar Raichada <n.raichada@samsung.com>
rafspiny [Sat, 28 Dec 2019 22:06:17 +0000 (22:06 +0000)]
Fix check for XIGetProperty
Summary: The function XIGetProperty returns 0 on success. More info on the function here: https://www.x.org/releases/X11R7.5/doc/man/man3/XIGetProperty.3.html
Reviewers: raster, stefan_schmidt, bu5hm4n
Reviewed By: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10978
Carsten Haitzler (Rasterman) [Sat, 28 Dec 2019 20:36:52 +0000 (20:36 +0000)]
elm - add plain and icon style radio and check and elm tests for it
this will be common enough to put into elm - there is no way to do a
gimp style "tool palette" where you select one of them (like one from
a set of radio buttons) at all times... but you don't want the "round
circle" but instead want it to look more like a button to fit in with
a palette style look. this calls for styles... so here they are.
@feat
Ross Vandegrift [Wed, 25 Dec 2019 04:33:53 +0000 (04:33 +0000)]
correct edje pkg-config generation for luaold
Currently, edje.pc gets its lua Requires from the -Dlua-interpreter argument.
If -Dlua-interpreter=lua, an unversioned lua entry ends up in Requires, which
cannot always be satisifed. The evas filters meson.build handles this case by
generating a version-specific entry. This patch copies that logic into the top
level meson.build, and passes the result to the edje subproject.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10965
Xavi Artigas [Fri, 27 Dec 2019 10:45:35 +0000 (11:45 +0100)]
whitespace
Xavi Artigas [Fri, 27 Dec 2019 10:36:24 +0000 (11:36 +0100)]
docs:Clarify Efl.Text_Formatter format parameter
Ref T8455
Cedric BAIL [Thu, 19 Dec 2019 18:47:57 +0000 (10:47 -0800)]
elementary: make sure that our index for the maximum number of object is actually unsigned int bound.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10927
Cedric BAIL [Fri, 15 Nov 2019 01:11:03 +0000 (17:11 -0800)]
elementary: improve focus memory for Efl.Ui.CollectionView.
This patch will make the CollectionView remember at all time the last
focus object and the last item in the list.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10677
Ali Alzyod [Fri, 27 Dec 2019 07:10:24 +0000 (16:10 +0900)]
efl_style: rename enums (background,strikthrough) from enabled to solid_color
Reviewers: woohyun, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7942
Differential Revision: https://phab.enlightenment.org/D10967
Ali Alzyod [Fri, 27 Dec 2019 01:17:17 +0000 (10:17 +0900)]
efl.ui.textbox: fix crash when toggle scroll mode
Reviewers: eagleeye, bu5hm4n, cedric, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10924
Bruno da Silva Belo [Mon, 23 Dec 2019 22:15:50 +0000 (22:15 +0000)]
c#: Checking null for parameters.
Checking for non-generated code.
ref T8399
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10959
ali [Thu, 26 Dec 2019 09:08:00 +0000 (18:08 +0900)]
efl.text.font: rename to efl.text.font.properties
Reviewers: segfaultxavi, woohyun, zmike, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7855
Differential Revision: https://phab.enlightenment.org/D10966
Ali Alzyod [Thu, 26 Dec 2019 09:01:32 +0000 (18:01 +0900)]
efl_text_format: rename tabstops,lingap,linerelgap
Summary: rename tabstops,lingap,linerelgap to have underscore between words
Reviewers: segfaultxavi, woohyun
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7856
Differential Revision: https://phab.enlightenment.org/D10963
a.srour [Thu, 26 Dec 2019 08:45:29 +0000 (17:45 +0900)]
Efl.Text.Cursor: Add tests for evas_suite
Summary: This patch add tests for almost all `Efl.Text.Cursor` exposed methods.
Test Plan: Using `ninja test`
Reviewers: ali.alzyod, segfaultxavi, woohyun
Subscribers: #committers, cedric, #reviewers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10950
ali [Thu, 26 Dec 2019 07:05:37 +0000 (16:05 +0900)]
efl_text_cursor: movement word start/end
Summary:
This patch will make **efl_text_cursor_move** method, when it is working with **WORD_START** or **WORD_END** If no actual movement happened then return false, and do not fire CHANGE event
for example if cursor at word start, and we call efl_text_cursor_move(cursor, word_start);
1- this call should return false because no actual movement happened. If no actual movement happened then return false
2- this call should not fire CHANGE event for cursor.and do not fire CHANGE event
Reviewers: woohyun, segfaultxavi, cedric, zmike
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10949
Ali Alzyod [Thu, 26 Dec 2019 00:55:28 +0000 (09:55 +0900)]
efl_text_cursor: line jump by fix movement
Summary:
When the cursor is at line beginning of line, and user click "Up" then "Down" on keyboard cursor will position at second character.
If text is: **occaecat \n mollit**
Reviewers: woohyun, zmike, cedric, segfaultxavi
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10947
Ali Alzyod [Wed, 25 Dec 2019 21:53:13 +0000 (06:53 +0900)]
elm_entry: remove variation sequences as part of glyph when delete clusters
Summary:
This will fix the task:
T8542
Remove variation sequences as part of glyph when deleting clusters, variation sequence is meaningless alone, so they should be removed when deleting
Reviewers: woohyun, bowonryu
Reviewed By: bowonryu
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10956
Dheeraj Reddy [Thu, 26 Dec 2019 19:25:19 +0000 (00:55 +0530)]
elm_genlist: Fix looping in case first or last item is disabled.
Summary:
Issue with item focus in loop-up when last item is disabled,
check is added to get previous valid item in this case.
Similar change added to loop-down handling.
Change-Id: I2c7b413f29d84b2f5b82d207532c183865082f12
Signed-off-by: Dheeraj Reddy <dheeraj.sj@samsung.com>
Myoungwoon Roy, Kim [Tue, 24 Dec 2019 14:24:07 +0000 (09:24 -0500)]
docs: Fix a typo in guideline about deprecated API
Summary: Fix a typo (elm_textpath_circluar_set -> elm_textpath_circular_set)
Test Plan: Revise documentation only
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10962
Stefan Schmidt [Tue, 24 Dec 2019 14:23:29 +0000 (09:23 -0500)]
examples: js: use correct var to display user name
Summary:
screen_name was used to for both displays, user name and screen name.
Fix this typo and make sure the user_name variable is actually used.
Depends on D10886
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, ProhtMeyhet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10934
Stefan Schmidt [Tue, 24 Dec 2019 14:23:22 +0000 (09:23 -0500)]
examples: js: make sure we declare all variables
Summary:
Avoiding local variables to be declared global and shared automatically.
Depends on D10882
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, zmike
Reviewed By: zmike
Subscribers: zmike, ProhtMeyhet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10884
Stefan Schmidt [Tue, 24 Dec 2019 14:23:14 +0000 (09:23 -0500)]
examples: js: ensure we finish all statements with a semicolon
Summary:
JS interpreters seems to be forgiving for these but the majority of the
js code examples already use semicolons. Make it consistent and fix up
the missing places.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10882
Cedric BAIL [Tue, 24 Dec 2019 14:20:11 +0000 (09:20 -0500)]
elementary: enforce container type check for efl_ui_item_index_get and improve documentation.
Summary: Depends on D10927
Reviewers: bu5hm4n, segfaultxavi, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: zmike, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8351
Differential Revision: https://phab.enlightenment.org/D10945
Stefan Schmidt [Thu, 21 Nov 2019 15:51:45 +0000 (16:51 +0100)]
examples_check: remove double dictionary
Same thing as two lines below.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10886
Ali Alzyod [Tue, 24 Dec 2019 08:17:31 +0000 (17:17 +0900)]
efl_text_cursor: assign source textobject to destination on cursor_copy
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10951
a.srour [Tue, 24 Dec 2019 07:34:14 +0000 (16:34 +0900)]
Efl.Text.Cursor: Fix line_jump_by return logic
Summary:
From documentation `line_jump_by` should return `EINA_TRUE` if cursor moved, and `EINA_FALSE` if not moved.
But the current behaviour is reversed, so this should fix it.
Reviewers: ali.alzyod, segfaultxavi, woohyun
Subscribers: AbdullehGhujeh, #committers, cedric, #reviewers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10946
Bowon Ryu [Tue, 24 Dec 2019 02:36:49 +0000 (11:36 +0900)]
evas_object_textblock: remove unreachable code
Summary:
This less-than-zero comparison of an unsigned value is never true..
this condition can not be true.
Test Plan: N/A
Reviewers: ali.alzyod, woohyun, jsuya
Reviewed By: jsuya
Subscribers: jsuya, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10961
Change-Id: I2f464965547a75eae6c7796a47547578257b69f5
JunsuChoi [Tue, 24 Dec 2019 01:54:04 +0000 (10:54 +0900)]
evas_vg_cache: Prevent memory leak
Summary: free hash_key pointer
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10960
Change-Id: I532df49864c8ca9a1070ff84a90d03a60092d268
Carsten Haitzler (Rasterman) [Tue, 24 Dec 2019 00:22:37 +0000 (00:22 +0000)]
ecore-x - fix fallbacks to use capital X in lib name
thanks peter. fixes T8543
@fix
Felipe Magno de Almeida [Mon, 23 Dec 2019 22:26:33 +0000 (07:26 +0900)]
eolian: inherit since information from struct and enum to field
Summary:
If a struct or enum field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.
Reviewers: jptiz, Jaehyun_Cho, woohyun, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8359
Differential Revision: https://phab.enlightenment.org/D10948
Bowon Ryu [Tue, 24 Dec 2019 02:36:49 +0000 (11:36 +0900)]
evas_object_textblock: remove unreachable code
Summary:
This less-than-zero comparison of an unsigned value is never true..
this condition can not be true.
Test Plan: N/A
Reviewers: ali.alzyod, woohyun, jsuya
Reviewed By: jsuya
Subscribers: jsuya, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10961
Change-Id: Ib217d15d5a0a011a3a97c2d45cff35e3d61d31df
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Yeongjong Lee [Tue, 24 Dec 2019 02:14:49 +0000 (11:14 +0900)]
eolian_mono: restore removed code to replace WidgetFocus with Focus
This code was removed during migration.
ref
ecaafb08e8b825321d4051133e8b50853311386e
@tizen_fix
Change-Id: I74a83829993608d64488068052c62838a5f37886
JunsuChoi [Tue, 24 Dec 2019 01:54:04 +0000 (10:54 +0900)]
evas_vg_cache: Prevent memory leak
Summary: free hash_key pointer
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10960
Change-Id: Idd9f37271bcb63eb998dfe80526c2045598431c7
Prasoon Singh [Tue, 10 Dec 2019 12:22:01 +0000 (17:52 +0530)]
[OneUI1.5] spinner: Add list view spinner
Change-Id: I685003cf7020bb22db20c80c602f82c381808ca8
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
godlytalias14573465 [Thu, 19 Dec 2019 13:06:15 +0000 (18:36 +0530)]
[Genlist] Support for skipping item queue
Issue: Whether to use style or new API for the item skipping support
Change-Id: If43ffafa94b263018e2a3cdf6944eb5373917b9c
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
godlytalias14573465 [Mon, 16 Dec 2019 14:25:32 +0000 (19:55 +0530)]
[OneUI1.5] Genlist Bottom margin
Change-Id: Iaa6914138168713244fd0b98fb10904e07d53c49
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Yeongjong Lee [Thu, 19 Dec 2019 02:46:11 +0000 (02:46 +0000)]
eina_mono: make internal classes internal
This hide internal classes..
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10912
Yeongjong Lee [Fri, 20 Dec 2019 10:24:29 +0000 (10:24 +0000)]
eo_mono: make BindingEntityAttribute internal
`BindingEntityAttribute` is used internally to check whether the object is
generated binding classes or not.
API user should use protected `IsGeneratedBindingClass` instead.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10937
Yeongjong Lee [Fri, 20 Dec 2019 11:00:45 +0000 (11:00 +0000)]
eo_mono: make Eo.Globals internal
All members of `Eo.Globals` are already `internal`.
It is unnecessary for `Eo.Globals` to be `public`.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10938