review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

commit | commitdiff | tree

robertphillips@google.com [Sat, 13 Jul 2013 17:11:59 +0000 (17:11 +0000)]

More valgrind suppressions

git-svn-id: http://skia.googlecode.com/svn/trunk@10061 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sat, 13 Jul 2013 15:37:25 +0000 (15:37 +0000)]

Reverted 10056-10059

git-svn-id: http://skia.googlecode.com/svn/trunk@10060 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 13 Jul 2013 07:00:56 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10059 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 12 Jul 2013 22:15:12 +0000 (22:15 +0000)]

fix windows warning

git-svn-id: http://skia.googlecode.com/svn/trunk@10058 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 12 Jul 2013 21:25:05 +0000 (21:25 +0000)]

64bitmac buildfix

git-svn-id: http://skia.googlecode.com/svn/trunk@10057 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 12 Jul 2013 21:14:33 +0000 (21:14 +0000)]

Working plumb of image scaling:

1) always generate mipmaps if we detect that we are downsampling.
2) pre-scale the image if we detect that we are upsampling
(currently valid for scale+translate only)
3) A few miscellaneous bug fixes related to image scaling.

Still need SSE/Neon versions of these image scalers.

BUG=
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18978014

git-svn-id: http://skia.googlecode.com/svn/trunk@10056 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Fri, 12 Jul 2013 20:15:34 +0000 (20:15 +0000)]

Add implicit hairline conic rendering to GPU

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18258005

git-svn-id: http://skia.googlecode.com/svn/trunk@10055 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 12 Jul 2013 19:58:37 +0000 (19:58 +0000)]

Fix valgrind suppressions file

git-svn-id: http://skia.googlecode.com/svn/trunk@10054 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 12 Jul 2013 18:44:23 +0000 (18:44 +0000)]

Fix leak in SkAutoSTArray

https://codereview.chromium.org/18915010/

git-svn-id: http://skia.googlecode.com/svn/trunk@10053 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 12 Jul 2013 18:36:12 +0000 (18:36 +0000)]

clean up extra printfs in count_effects.lua

git-svn-id: http://skia.googlecode.com/svn/trunk@10052 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 12 Jul 2013 18:31:59 +0000 (18:31 +0000)]

Add newline for r10050.

git-svn-id: http://skia.googlecode.com/svn/trunk@10051 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 12 Jul 2013 18:22:49 +0000 (18:22 +0000)]

R=mtklein@google.com

Review URL: https://codereview.chromium.org/18503009

git-svn-id: http://skia.googlecode.com/svn/trunk@10050 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Fri, 12 Jul 2013 18:11:04 +0000 (18:11 +0000)]

If a user requests a try on "all" builders, ask for confirmation

Addresses https://code.google.com/p/skia/issues/detail?id=1208
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/18190006

git-svn-id: http://skia.googlecode.com/svn/trunk@10049 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 12 Jul 2013 17:29:30 +0000 (17:29 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10048 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 12 Jul 2013 15:52:59 +0000 (15:52 +0000)]

gm: since we don't record output of gpudebug test, don't record checksums either
BUG=https://code.google.com/p/skia/issues/detail?id=1410
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19096012

git-svn-id: http://skia.googlecode.com/svn/trunk@10046 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Fri, 12 Jul 2013 13:39:53 +0000 (13:39 +0000)]

modularize the display of diffs for skpdiff

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18925004

git-svn-id: http://skia.googlecode.com/svn/trunk@10044 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 12 Jul 2013 13:31:51 +0000 (13:31 +0000)]

Revert "switch all the arm7 devices to build with thumb for a while"

This reverts r10028 which has altered the GM expectations.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/18762006

git-svn-id: http://skia.googlecode.com/svn/trunk@10043 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 12 Jul 2013 12:32:32 +0000 (12:32 +0000)]

rebaseline.py: until we fix bug 1410, keep going if we can't download an actual GM result

Review URL: https://codereview.chromium.org/19096007

git-svn-id: http://skia.googlecode.com/svn/trunk@10037 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 12 Jul 2013 07:01:14 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10033 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 11 Jul 2013 23:49:56 +0000 (23:49 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10031 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 22:29:29 +0000 (22:29 +0000)]

The two leaks are:
missing unrefs in megalooper GM
missing reset capability in oval renderer

This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet)

R=bsalomon@google.com, jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/18461007

git-svn-id: http://skia.googlecode.com/svn/trunk@10030 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 11 Jul 2013 20:50:10 +0000 (20:50 +0000)]

Initialize the matrix used when recursing from a GPU image filter -> raster image filter.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/5636027884503040

git-svn-id: http://skia.googlecode.com/svn/trunk@10029 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 20:28:38 +0000 (20:28 +0000)]

switch all the arm7 devices to build with thumb for a while

BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/18563004

git-svn-id: http://skia.googlecode.com/svn/trunk@10028 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Thu, 11 Jul 2013 20:28:30 +0000 (20:28 +0000)]

reenable the scale benchmark, and only bench actual canvas draw commands
instead of direct invocations of the (now private) bitmap scale method

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/18941009

git-svn-id: http://skia.googlecode.com/svn/trunk@10027 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 20:28:24 +0000 (20:28 +0000)]

ARM Skia NEON patches - 13 - S32A_Opaque

Blitrow32: S32A_Opaque code cleaning and speed improvement

- the old way of calculating alpha doesn't seem to be used anymore,
  so remove the remaining code
- adding prefetching allows to improve performance greatly in some
  cases at the expense of a little trade-off:

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1,2   | 0         | 0          |
+-------+-----------+------------+
| 4     | 0         | -3%        |
+-------+-----------+------------+
| 8     | 0         | -4%        |
+-------+-----------+------------+
| 16    | 0         | -5%        |
+-------+-----------+------------+
| 64    | +14%      | 0          |
+-------+-----------+------------+
| 256   | +14%      | +12%       |
+-------+-----------+------------+
| 1024  | +115%     | +15%       |
+-------+-----------+------------+

BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18459008

git-svn-id: http://skia.googlecode.com/svn/trunk@10026 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 11 Jul 2013 19:20:30 +0000 (19:20 +0000)]

rebaseline.py: skip any platforms we don't have actual results for, with warning message

R=borenet@google.com

Review URL: https://codereview.chromium.org/19052007

git-svn-id: http://skia.googlecode.com/svn/trunk@10022 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 11 Jul 2013 18:46:30 +0000 (18:46 +0000)]

Disable soft floating point on ChromeOS

Should fix the Daisy build.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18812006

git-svn-id: http://skia.googlecode.com/svn/trunk@10020 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 11 Jul 2013 18:11:56 +0000 (18:11 +0000)]

Make ChromeOS build exit nonzero on failure

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18621004

git-svn-id: http://skia.googlecode.com/svn/trunk@10018 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 11 Jul 2013 18:05:25 +0000 (18:05 +0000)]

Add script to verify that image files exist for every actual_result checksum

Should help with https://code.google.com/p/skia/issues/detail?id=1410
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/18743006

git-svn-id: http://skia.googlecode.com/svn/trunk@10017 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 11 Jul 2013 17:51:26 +0000 (17:51 +0000)]

check JSON-format expectations into experimental/ for manual testing

Review URL: https://codereview.chromium.org/19052006

git-svn-id: http://skia.googlecode.com/svn/trunk@10016 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Thu, 11 Jul 2013 16:25:55 +0000 (16:25 +0000)]

SkObjectParser::SaveFlagsToString() should handle SaveFlags as a bitmask.

Test one SaveFlags bit at a time instead of exploring the whole value space.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18034028

git-svn-id: http://skia.googlecode.com/svn/trunk@10014 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 16:25:51 +0000 (16:25 +0000)]

pdfviewer: add option to run the load or render multiple times, --benchLoad, --benchRender

Review URL: https://codereview.chromium.org/18093008

git-svn-id: http://skia.googlecode.com/svn/trunk@10013 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 15:40:31 +0000 (15:40 +0000)]

fix build break on sample app

Review URL: https://codereview.chromium.org/19000005

git-svn-id: http://skia.googlecode.com/svn/trunk@10011 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 15:20:50 +0000 (15:20 +0000)]

add ability to specify the DPI at which to render the page

Review URL: https://codereview.chromium.org/19000004

git-svn-id: http://skia.googlecode.com/svn/trunk@10009 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 14:50:12 +0000 (14:50 +0000)]

pdfviewer: render in the same way regadless if we write the result to a file or not.

Review URL: https://codereview.chromium.org/18503013

git-svn-id: http://skia.googlecode.com/svn/trunk@10008 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 14:45:20 +0000 (14:45 +0000)]

(unreviewed) sample app: fix break in pdf viewer (podofo was replaced by native parser)

Review URL: https://codereview.chromium.org/18507004

git-svn-id: http://skia.googlecode.com/svn/trunk@10007 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 14:43:15 +0000 (14:43 +0000)]

pdfviewer: some code cleanup in renderer

Review URL: https://codereview.chromium.org/18093005

git-svn-id: http://skia.googlecode.com/svn/trunk@10006 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 14:28:04 +0000 (14:28 +0000)]

Add an option to have a PdfViewer in SampleApp. Add a parameter --pdfDir to pass the dir with pdfs. Add flag --sort to sort samples acording to title, so foo.skp follows foo.pdf and we can quickly compare diffs.
The option needs to be enabled manually by developer to be compiled locally, since the pdf viewer is work in progress.

R=reed@google.com

Review URL: https://codereview.chromium.org/17904006

git-svn-id: http://skia.googlecode.com/svn/trunk@10004 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 14:26:09 +0000 (14:26 +0000)]

Streamline picture_record_recurring_ bench.

Reduce benchmark runtime from ~17 ms to ~13.25ms by moving SkPaint
construction out of the inner loop and by using random colors in the
SkPaints instead of sequential integers, which were seeing bad hashing.

This doesn't actually improve our performance, but makes the benchmark
more focused on pure recording costs.

BUG=
R=mtklein@google.com, reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18119011

git-svn-id: http://skia.googlecode.com/svn/trunk@10003 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 13:57:29 +0000 (13:57 +0000)]

add _thumb variants for arm devices

BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/19024002

git-svn-id: http://skia.googlecode.com/svn/trunk@10001 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Thu, 11 Jul 2013 13:53:44 +0000 (13:53 +0000)]

add newline to bitmap rotation script output

BUG=

Review URL: https://codereview.chromium.org/18071007

git-svn-id: http://skia.googlecode.com/svn/trunk@10000 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 12:53:06 +0000 (12:53 +0000)]

pdfviewer: add --pages arg: render a certain page (all, all in desceding order, firsl, last and by page number)

Review URL: https://codereview.chromium.org/18584010

git-svn-id: http://skia.googlecode.com/svn/trunk@9999 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 11 Jul 2013 12:48:14 +0000 (12:48 +0000)]

ARM Skia NEON patches - 10 - ARM build

ARM-Build: make Linux arm/NEON builds possible

This factorizes the definitions common to Linux & assimilated
and Android. It also enables to do native builds on Linux for
ARM processors.

BUG=
R=djsollen@google.com, borenet@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18243007

git-svn-id: http://skia.googlecode.com/svn/trunk@9997 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 11 Jul 2013 12:27:21 +0000 (12:27 +0000)]

pdfviewer: measure mem usage, command line flags library.

Review URL: https://codereview.chromium.org/18562010

git-svn-id: http://skia.googlecode.com/svn/trunk@9996 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 11 Jul 2013 11:28:41 +0000 (11:28 +0000)]

Add safesync_url to build-tot-chromium.sh

(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/18429006

git-svn-id: http://skia.googlecode.com/svn/trunk@9993 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 11 Jul 2013 07:01:01 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9992 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 11 Jul 2013 00:01:39 +0000 (00:01 +0000)]

Win7/8 compiler warnings/errors fix for r9980

git-svn-id: http://skia.googlecode.com/svn/trunk@9991 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 23:36:56 +0000 (23:36 +0000)]

pdfviewer: ignore more bad stauff in pdfs

Review URL: https://codereview.chromium.org/18112023

git-svn-id: http://skia.googlecode.com/svn/trunk@9990 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 23:26:54 +0000 (23:26 +0000)]

pdfviewer: don't delete variables, they are managed by the doc now

Review URL: https://codereview.chromium.org/18435010

git-svn-id: http://skia.googlecode.com/svn/trunk@9989 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 23:17:31 +0000 (23:17 +0000)]

pdfviewer: more load references dinamically plumming

Review URL: https://codereview.chromium.org/18536014

git-svn-id: http://skia.googlecode.com/svn/trunk@9988 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 22:53:40 +0000 (22:53 +0000)]

pdfviewer: don't crash when trailer is missing

Review URL: https://codereview.chromium.org/19027003

git-svn-id: http://skia.googlecode.com/svn/trunk@9987 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Wed, 10 Jul 2013 22:42:30 +0000 (22:42 +0000)]

add matrix objects to the lua bindings, as well as a lua script to find the proportion of image draw commands with different kinds of matrices

git-svn-id: http://skia.googlecode.com/svn/trunk@9986 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 22:37:38 +0000 (22:37 +0000)]

pdfviewer: fix bug, page -1 means render page 0 with no page extension

Review URL: https://codereview.chromium.org/18660009

git-svn-id: http://skia.googlecode.com/svn/trunk@9985 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Wed, 10 Jul 2013 22:34:05 +0000 (22:34 +0000)]

fix 64 bit warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@9984 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 22:33:10 +0000 (22:33 +0000)]

pdf viewer: refactor, add -w parameter to pdfviewer, add -n to remove extenassion page when there is a single page (so skdiff can be run easily) and fix a bug (SkPdfobject should not reset on destruct)

Review URL: https://codereview.chromium.org/18435007

git-svn-id: http://skia.googlecode.com/svn/trunk@9983 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Wed, 10 Jul 2013 22:21:03 +0000 (22:21 +0000)]

remove unused variables

git-svn-id: http://skia.googlecode.com/svn/trunk@9982 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 10 Jul 2013 21:51:47 +0000 (21:51 +0000)]

use SkIntToScalar

BUG=
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18622004

git-svn-id: http://skia.googlecode.com/svn/trunk@9981 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Wed, 10 Jul 2013 21:49:29 +0000 (21:49 +0000)]

fix bug with awesome filtered images sometimes being slightly offset.

BUG=

Review URL: https://codereview.chromium.org/19013004

git-svn-id: http://skia.googlecode.com/svn/trunk@9980 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 10 Jul 2013 21:23:49 +0000 (21:23 +0000)]

add paint:getEffects to return table of bools of a given effect is present on the paint

git-svn-id: http://skia.googlecode.com/svn/trunk@9978 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 21:22:18 +0000 (21:22 +0000)]

Implement offset for GPU filter path. Although we can't yet use this in Blink for FEOffset, due to SVG semantics, we can use it to support crop rect (upcoming patch).

This patch adds the parameter to the filterImageGPU() signature, plumbs through the code on the GPU side, and implements support for it in SkXfermodeImageFilter for both raster and GPU.

Of the remaining filters with GPU implementations, Blur, Morphology, Bicubic and Displacement work fine; they're commutative wrt offset and can simply pass it up the chain. Blend is not, but will be removed shortly anyway (has been replaced with SkXfermodeImageFilter in Blink).

R=reed@google.com, bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15995026

git-svn-id: http://skia.googlecode.com/svn/trunk@9977 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 20:55:39 +0000 (20:55 +0000)]

Remove SkRasterClip::setPath(const SkPath&, const SkRasterClip&, bool).

The method is only used in SkCanvas::clipPathHelper() and only called when isRect() is true (which effectively disables the !isBW branch).

Thus, we can promote the isBW branch to the caller and drop the rest of the method.

R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18552004

git-svn-id: http://skia.googlecode.com/svn/trunk@9974 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 20:42:12 +0000 (20:42 +0000)]

don't leak the bitmap filter

BUG=
R=reed@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/18999005

git-svn-id: http://skia.googlecode.com/svn/trunk@9973 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 10 Jul 2013 19:07:56 +0000 (19:07 +0000)]

Allow use of SKIA_OUT on Windows

This works as expected, except that %SKIA_OUT% must be on the same drive

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18467010

git-svn-id: http://skia.googlecode.com/svn/trunk@9972 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 18:38:02 +0000 (18:38 +0000)]

pdfviewer: remove assert

Review URL: https://codereview.chromium.org/18518006

git-svn-id: http://skia.googlecode.com/svn/trunk@9971 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 18:20:06 +0000 (18:20 +0000)]

pdfviewer: fix warnings on mac
Review URL: https://codereview.chromium.org/18293014

git-svn-id: http://skia.googlecode.com/svn/trunk@9970 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 10 Jul 2013 18:09:55 +0000 (18:09 +0000)]

make svndiff.py executable

git-svn-id: http://skia.googlecode.com/svn/trunk@9969 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 17:44:55 +0000 (17:44 +0000)]

pdf viewer: fix a few warnings, and enable warning as errors

Review URL: https://codereview.chromium.org/18293012

git-svn-id: http://skia.googlecode.com/svn/trunk@9966 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 10 Jul 2013 17:23:47 +0000 (17:23 +0000)]

Fix Housekeeper bot after r9961

git-svn-id: http://skia.googlecode.com/svn/trunk@9965 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 17:14:56 +0000 (17:14 +0000)]

RIP podofo

Review URL: https://codereview.chromium.org/18518005

git-svn-id: http://skia.googlecode.com/svn/trunk@9964 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 17:11:29 +0000 (17:11 +0000)]

remove podofo from deps

Review URL: https://codereview.chromium.org/18539008

git-svn-id: http://skia.googlecode.com/svn/trunk@9963 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 10 Jul 2013 17:09:50 +0000 (17:09 +0000)]

Native PDF parser implementation - don't try it on pdfs that are not generated by skia, Crome Print Preview or Chrome Save As Pdf - it will crash as mising xref, pdfs with updates, and other features are not supported yer.

Review URL: https://codereview.chromium.org/18323019

git-svn-id: http://skia.googlecode.com/svn/trunk@9962 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 10 Jul 2013 16:54:10 +0000 (16:54 +0000)]

rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir
BUG=https://code.google.com/p/skia/issues/detail?id=1403
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18416005

git-svn-id: http://skia.googlecode.com/svn/trunk@9961 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 16:13:14 +0000 (16:13 +0000)]

Added a high-color (50 colors) gradient for each gradient type.

To do so I added an enumerated type called ColorType that can toggle between kColors_2 and kColors_50 to swap between 2 and 50 color gradients.

Added hicolor bench for each gradient type.

BUG=
R=reed@google.com, bsalomon@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18655012

git-svn-id: http://skia.googlecode.com/svn/trunk@9960 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 10 Jul 2013 15:55:04 +0000 (15:55 +0000)]

restore hash size to 8 bits, following windows fix in 3591f7a4a56153349240dfc542cc61a11fab2487

git-svn-id: http://skia.googlecode.com/svn/trunk@9959 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Wed, 10 Jul 2013 15:53:36 +0000 (15:53 +0000)]

fix swapped bitmap channels on Mac for debugger

BUG=
R=djsollen@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18485004

git-svn-id: http://skia.googlecode.com/svn/trunk@9958 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 10 Jul 2013 15:38:20 +0000 (15:38 +0000)]

allow createScalerContext to return null, and then have the GDI backend trigger that if we fail to create the necessary GDI resources

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/18484005

git-svn-id: http://skia.googlecode.com/svn/trunk@9957 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 10 Jul 2013 15:27:18 +0000 (15:27 +0000)]

rebaseline.py: use specified configs/tests as a FILTER over actually-run tests

Now that we have the actual-results.json file for every bot type, we know
the full set of tests that actual results are available for. If configs and/or
tests are specified, just use those as FILTERS over the actually available
results.

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18324018

git-svn-id: http://skia.googlecode.com/svn/trunk@9956 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 15:03:52 +0000 (15:03 +0000)]

ARM Skia NEON patches - 09 - Bugfix

Misc: fix a PDF warning/bug on ARM

char is unsigned by default on ARM, so the (curNibble < 0) test is
always false, probably leading to a bug.

BUG=
R=djsollen@google.com, edisonn@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18365005

git-svn-id: http://skia.googlecode.com/svn/trunk@9954 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 13:55:46 +0000 (13:55 +0000)]

ARM Skia NEON patches - 05 - Cleaning

Misc: move definition of empty SkBlitRow::ColorRectProc

For the sake of consistency, the empty SkBlitRow::ColorRectProc
should be defined in SkBlitRow_opts_none.cpp rather than
SkUtils_opts_none.cpp

BUG=
R=djsollen@google.com, reed@google.com, tomhudson@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18314005

git-svn-id: http://skia.googlecode.com/svn/trunk@9953 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 13:53:19 +0000 (13:53 +0000)]

ARM Skia NEON patches - 02 - Tune filter clobber list

Misc: reduce clobber list in SkBitmapProcState_filter_neon.h

This may allow the compiler to do a better job

BUG=
R=djsollen@google.com, tomhudson@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18996003

git-svn-id: http://skia.googlecode.com/svn/trunk@9952 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 10 Jul 2013 13:38:33 +0000 (13:38 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9951 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 10 Jul 2013 10:14:35 +0000 (10:14 +0000)]

Allow the resource cache to (indirectly) flush the InOrderDrawBuffer

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/18466005

git-svn-id: http://skia.googlecode.com/svn/trunk@9949 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 10 Jul 2013 07:00:58 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9948 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 23:19:53 +0000 (23:19 +0000)]

Fix Win7 compiler errors/warnings for r9945

git-svn-id: http://skia.googlecode.com/svn/trunk@9947 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 9 Jul 2013 21:58:56 +0000 (21:58 +0000)]

Make 'rotate' animate in SampleApp.

R=reed@google.com

Review URL: https://codereview.chromium.org/18948002

git-svn-id: http://skia.googlecode.com/svn/trunk@9946 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Tue, 9 Jul 2013 21:55:47 +0000 (21:55 +0000)]

avoid introducing duplicate const in release builds

git-svn-id: http://skia.googlecode.com/svn/trunk@9945 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Tue, 9 Jul 2013 21:37:14 +0000 (21:37 +0000)]

New bitmap filter checkin; this time with less build breakage

BUG=

Review URL: https://codereview.chromium.org/18942002

git-svn-id: http://skia.googlecode.com/svn/trunk@9944 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 9 Jul 2013 21:31:54 +0000 (21:31 +0000)]

use typedef to name our ID type in SkImageCache

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/18612003

git-svn-id: http://skia.googlecode.com/svn/trunk@9943 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Tue, 9 Jul 2013 21:08:28 +0000 (21:08 +0000)]

add diff viewer website

- adjust PMetric output to be percentage

R=borenet@google.com, bsalomon@google.com

Review URL: https://codereview.chromium.org/18132007

git-svn-id: http://skia.googlecode.com/svn/trunk@9942 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Tue, 9 Jul 2013 20:35:03 +0000 (20:35 +0000)]

Remove old and unused Android font host code

R=bungeman@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/18666003

git-svn-id: http://skia.googlecode.com/svn/trunk@9940 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 9 Jul 2013 19:43:35 +0000 (19:43 +0000)]

Export SkPathOps.h functions for external use.

In order to make Op() and Simplify() accessible from Blink, they need to be SK_API-annotated.

R=caryclark@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18912002

git-svn-id: http://skia.googlecode.com/svn/trunk@9939 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 9 Jul 2013 19:43:29 +0000 (19:43 +0000)]

Added GM and Bench

Added GM's and Bench

Added GM file nate_gradients.cpp

BUG=
R=reed@google.com, bsalomon@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18259012

git-svn-id: http://skia.googlecode.com/svn/trunk@9938 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Tue, 9 Jul 2013 18:02:06 +0000 (18:02 +0000)]

Revert "More general image filter interface; tested implementation of standalone"

This reverts commit 4df3e8b079e019af5f60c13e7e6ec6589663962a.

git-svn-id: http://skia.googlecode.com/svn/trunk@9937 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Tue, 9 Jul 2013 17:48:15 +0000 (17:48 +0000)]

More general image filter interface; tested implementation of standalone
image scaler (not yet plumbed). High quality downsampler. Fast SSE
resampler.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/17381008

git-svn-id: http://skia.googlecode.com/svn/trunk@9936 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 16:57:01 +0000 (16:57 +0000)]

Fix Win7 compiler warnings/errors in r9934

git-svn-id: http://skia.googlecode.com/svn/trunk@9935 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 9 Jul 2013 16:30:38 +0000 (16:30 +0000)]

Animated the PathUtils Sample to show path contours# Enter a description of the change.

Animated the PathUtils Sample to path contours

BUG=
R=reed@google.com, scroggo@google.com, djsollen@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18552005

git-svn-id: http://skia.googlecode.com/svn/trunk@9934 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 9 Jul 2013 16:04:32 +0000 (16:04 +0000)]

When gather pixel refs was broken, REPORTER_ASSERT(data) realized that data was NULL, but subsequent lines dereferenced it anyway, and so segfaulted.

R=reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18904003

git-svn-id: http://skia.googlecode.com/svn/trunk@9933 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 9 Jul 2013 15:48:24 +0000 (15:48 +0000)]

Allow ico decoder to decode PNG sub-images.

Since Windows Vista, PNG can be embedded in an ICO file. Update
our decoder to support this.

BUG=https://code.google.com/p/skia/issues/detail?id=1398
R=djsollen@google.com

Review URL: https://codereview.chromium.org/18655007

git-svn-id: http://skia.googlecode.com/svn/trunk@9932 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 9 Jul 2013 15:45:14 +0000 (15:45 +0000)]

Remove bitmap reuse from SkImageDecoder.

Now that Android is using an SkBitmap::Allocator to reuse bitmap
memory, remove the unnecessary code to handle bitmap reuse inside
the decoders themselves.

Leaves in the code for bitmap reuse in decodeSubset, which still
may reuse bitmaps, and cropBitmap, which is called by decodeSubset.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/17620004

git-svn-id: http://skia.googlecode.com/svn/trunk@9931 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 9 Jul 2013 15:29:32 +0000 (15:29 +0000)]

move failable work outside of constructors for SkGlyphCache and SkScalerContextGDI. If we fail, try to purge everything and try again, in case the failure was from memory/os-resource exhaustion (e.g. out of HDC handles in windows)

BUG=

Review URL: https://codereview.chromium.org/18132009

git-svn-id: http://skia.googlecode.com/svn/trunk@9930 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom