Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API
Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.
Reviewers: zmike, segfaultxavi, bu5hm4n
Reviewed By: zmike, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10186
Change-Id: If8039795398b3681c7329d8103d196d02393612b
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value
Summary:
When invalid object comes, the return value should be
EINA_FALSE.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10185
Change-Id: I3b2434528d68e8570308b25049442d07f4174a86
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value
Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10187
Change-Id: I27ae9dcc4030b26ffc124f11a66c4fc7bf1436e9
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable
Summary:
fixes T7871
fixes T7852
This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.
Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: SanghyeonLee, cedric
Tags: #efl
Maniphest Tasks: T7871, T7852
Differential Revision: https://phab.enlightenment.org/D10184
Marcel Hollerbach [Thu, 26 Sep 2019 09:16:24 +0000 (18:16 +0900)]
efl_ui_*selectable: unify these APIs with the same c_prefix
Summary:
with this commit that api for single and multi selectable shares the
same prefix, which makes sense in c as we do not really differ between
those two types there anyway.
ref T7871
Reviewers: SanghyeonLee, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7871
Differential Revision: https://phab.enlightenment.org/D10183
SangHyeon Jade Lee [Thu, 26 Sep 2019 08:38:37 +0000 (10:38 +0200)]
efl_ui : add document comment on efl_ui_item_clickable event data
Summary: Add document comment on Efl_Ui_Item_Clickable.Clickable_Clicked.
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10181
Cedric Bail [Thu, 26 Sep 2019 01:59:29 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Item_Clickable.
Summary: Depends on D10177
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10173
Cedric Bail [Thu, 26 Sep 2019 01:59:25 +0000 (21:59 -0400)]
elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Summary: Depends on D10176
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10177
Cedric Bail [Thu, 26 Sep 2019 01:59:20 +0000 (21:59 -0400)]
elementary: temporary workaround include issue that prevent acces to Evas_Eo.h
Summary: Depends on D10175
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10176
Cedric Bail [Thu, 26 Sep 2019 01:59:14 +0000 (21:59 -0400)]
elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Summary: Depends on D10171
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10175
Cedric Bail [Thu, 26 Sep 2019 01:59:09 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Collection_View.
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8261
Differential Revision: https://phab.enlightenment.org/D10171
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:38 +0000 (17:56 -0400)]
api: mark Efl.Ui.Image_Zoomable stable
Summary:
ref T7875
Depends on D10125
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D10126
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:33 +0000 (17:56 -0400)]
api: mark Efl.Gfx.Image_Load_Controller stable
Summary:
fix T7876
Depends on D10124
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7876
Differential Revision: https://phab.enlightenment.org/D10125
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:29 +0000 (17:56 -0400)]
api: mark efl.gfx.image and related types stable
Summary:
fix T7875
fix T7926
fix T7927
fix T7926
fix T7929
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7929, T7927, T7926, T7875
Differential Revision: https://phab.enlightenment.org/D10124
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:17 +0000 (17:56 -0400)]
theme: migrate all efl,anim,activate (and similar) signals to efl,state,animation,activated
Summary:
ref T8231
Depends on D10166
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10167
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:11 +0000 (17:56 -0400)]
theme: efl,state,anim,stop -> efl,state,animating,stopped
Summary:
ref T8231
Depends on D10165
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10166
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:06 +0000 (17:56 -0400)]
api: efl,state,busy,(start|stop) -> efl,state,busy,(started|stopped)
Summary:
ref T8231
Depends on D10163
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10165
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:01 +0000 (17:56 -0400)]
theme: remove unused scroller group
Summary:
this is just copied from legacy but not used for anything
ref T8231
Depends on D10162
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10163
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:55 +0000 (17:55 -0400)]
theme: use more explicit signal names for C <- theme scrollbar signals
Summary:
ref T8231
Depends on D10161
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10162
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:50 +0000 (17:55 -0400)]
theme: efl,action,clicked -> efl,action,click
Summary:
action signals should infinitives
ref T8231
Depends on D10160
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10161
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:45 +0000 (17:55 -0400)]
theme: use more explicit signal names for C -> theme scrollbar signals
Summary:
ref T8231
Depends on D10159
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10160
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:40 +0000 (17:55 -0400)]
theme: use 'visible' style signals for spin_button button/entry visibility
Summary:
ref T8231
Depends on D10158
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10159
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:35 +0000 (17:55 -0400)]
theme: efl,state,(content|text),(set|unset) -> efl,(content|text),(set|unset)
Summary:
this is versioned, so the correct signal will always be emitted for the theme
version that is provided
ref T8231
Depends on D10164
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10158
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:29 +0000 (17:55 -0400)]
efl_ui/layout: add mechanism for deferring versioned theme signals
Summary:
the theme version isn't available until the theme has been applied, so
we can create an array of all the pending signals and defer them until
such time as we get a theme or destroy the object
this is internal and can be reworked at a later time as needed
ref T8231
Depends on D10157
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10164
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:24 +0000 (17:55 -0400)]
api: move eo-based radio and check widgets to use selectable signal names
Summary:
this is a more standardized name
ref T8231
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10157
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:19 +0000 (17:55 -0400)]
theme: /efl,orient,(horizontal|vertical)/efl,state,(horizontal|vertical)/
Summary:
these signals aren't actually used by anything, just changing for grep
ref T8231
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10156
WooHyun Jung [Thu, 26 Sep 2019 10:27:09 +0000 (19:27 +0900)]
efl_ui_win: add validation check to return legacy default value
This should be reverted when https://phab.enlightenment.org/D10187
is updated.
@tizen_fix
Change-Id: I990dab1313aebdfde2a8cc1e9b89d2fff0983863
WooHyun Jung [Thu, 26 Sep 2019 10:26:08 +0000 (19:26 +0900)]
efl_ui_image: fix a wrong return value of legacy API
This should be reverted when https://phab.enlightenment.org/D10186
is updated.
@tizen_fix
Change-Id: Ifdfbd9685f13ea428661c3644cd708fac2e8ec3d
WooHyun Jung [Thu, 26 Sep 2019 10:24:24 +0000 (19:24 +0900)]
edje_legacy: add validation check to return legacy default value
This should be reverted when https://phab.enlightenment.org/D10185
is updated
@tizen_fix
Change-Id: I8e42c74420d2cf0ea218ca3ae29d2480663538f1
WooHyun Jung [Thu, 26 Sep 2019 08:11:05 +0000 (17:11 +0900)]
Revert "slider: delete unnecessary tizen only code"
This reverts commit
c8633f099a438b1f99ae94d350b3554b0ded218a.
Change-Id: Ib2e87a3ceeec4fec7d164f9b9aed862873fbee66
Jongmin Lee [Wed, 25 Sep 2019 21:36:28 +0000 (06:36 +0900)]
bulild: resolve build error caused by te use of efl_player_start/stop API
change the use of efl_player_start/stop to efl_player_playing_set
Change-Id: I7ece1dc749716bcd4b4caaa49656e139a07864ce
Cedric Bail [Wed, 25 Sep 2019 15:05:38 +0000 (12:05 -0300)]
ecore: stabilize Efl.Loop_Model
Summary:
T8270
Depends on D10138
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10139
Cedric Bail [Wed, 25 Sep 2019 15:03:27 +0000 (12:03 -0300)]
ecore: stabilize Efl.Composite_Model.
Summary: Depends on D10137
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10138
Cedric Bail [Wed, 25 Sep 2019 15:02:14 +0000 (12:02 -0300)]
elementary: stabilize Efl.Ui.View_Model
Summary:
T8268
Depends on D10136
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10137
Cedric Bail [Wed, 25 Sep 2019 15:00:28 +0000 (12:00 -0300)]
efl: stabilize Efl.Model
Summary:
T8267
Depends on D10135
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10136
Cedric Bail [Wed, 25 Sep 2019 14:59:45 +0000 (11:59 -0300)]
efl: stabilize Efl.Ui.Factory_Bind
Summary:
T8264
Depends on D10134
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10135
Cedric Bail [Wed, 25 Sep 2019 14:56:54 +0000 (11:56 -0300)]
efl: stabilize Efl.Ui.Property_Bind
Summary:
T7579
Depends on D10133
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10134
Cedric Bail [Wed, 25 Sep 2019 14:55:30 +0000 (11:55 -0300)]
efl: stabilize Efl.Ui.Factory.
Summary:
T8262
Depends on D10132
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10133
Cedric Bail [Wed, 25 Sep 2019 14:45:38 +0000 (11:45 -0300)]
elementary: stabilize Efl.Ui.Widget_Factory.
Summary:
T8271
Depends on D10130
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10131
Lauro Moura [Wed, 25 Sep 2019 20:15:43 +0000 (16:15 -0400)]
elm: Avoid maybe unitialized variable accesses
Reviewers: cedric, bu5hm4n, zmike, felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10170
Cedric Bail [Wed, 25 Sep 2019 19:50:35 +0000 (15:50 -0400)]
efl: improve error message to be really useful.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10168
Marcel Hollerbach [Wed, 25 Sep 2019 19:46:54 +0000 (21:46 +0200)]
Revert "elm: add basics test to create a destroy *every* widget with errors"
This reverts commit
10cdb070180e0f1e62d5b8e5d5164a19fbc51548.
this does not pass on ci ... o.O
SangHyeon Jade Lee [Wed, 25 Sep 2019 10:57:03 +0000 (10:57 +0000)]
efl_ui : change selected_items_get to selected_iterator_new.
multi_selectable_aync already changed name as
selected_iterator_new
so multi_selectable change name also for unity of API.
not sure about we need unselected_items_get in multi_selectable,
so skip to create new api for this time.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10148
Marcel Hollerbach [Mon, 23 Sep 2019 18:43:47 +0000 (20:43 +0200)]
elm: add basics test to create a destroy *every* widget with errors
this simply creates packs, resizes, and destroys every single widget
that we have in legacy elm.
This i made to ensure that there are no mistakes in the construction
chain. Additionally, a second test case checks that creation with none
elm parents is erroring but not failing, this seems weird, but we have
provided that in the past, so we should continue providing this.
Differential Revision: https://phab.enlightenment.org/D10088
Cedric Bail [Tue, 24 Sep 2019 23:48:31 +0000 (16:48 -0700)]
elementary: properly mark iterator usage in Efl.Ui.Factory.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10132
Cedric Bail [Wed, 25 Sep 2019 16:52:18 +0000 (16:52 +0000)]
elementary: return an error when unimplemented function on Efl.Ui.Widget_Factory.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10130
Cedric Bail [Wed, 25 Sep 2019 00:13:49 +0000 (17:13 -0700)]
elementary: add support for default property on item being created by Efl.Ui.Widget_Factory.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10129
Mike Blumenkrantz [Wed, 25 Sep 2019 10:47:49 +0000 (06:47 -0400)]
efl_ui/image: fix playback_speed timer calcs
I accidentally inverted this; the frame timing needs to be divided by
the playback speed to have the correct time here
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10147
Mike Blumenkrantz [Wed, 25 Sep 2019 11:30:24 +0000 (07:30 -0400)]
efl_ui/layout: add explicit error case when theme version > efl version
it's important to handle cases where a "future" theme is trying to be used
by "current" efl. this throws a serious error, since it's possible that the
widget may look/act in a way that makes it unusable
ref T8231
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10153
Daniel Kolesa [Wed, 25 Sep 2019 16:17:48 +0000 (18:17 +0200)]
eolian: expose most API as stable
There is still some TODO with builtin types, parameter
directions and prefixes, which will be resolved in the
next commits.
Mike Blumenkrantz [Wed, 25 Sep 2019 13:02:52 +0000 (15:02 +0200)]
efl_ui/layout: improve docs
Summary: add doc notes for these classes
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10155
Mike Blumenkrantz [Wed, 25 Sep 2019 11:34:01 +0000 (13:34 +0200)]
api: mark Efl.Ui.Scrollable stable
Summary: fix T7883
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7883
Differential Revision: https://phab.enlightenment.org/D10151
Mike Blumenkrantz [Wed, 25 Sep 2019 11:28:46 +0000 (13:28 +0200)]
api: mark Efl.Ui.Spin_Button stable
Summary: fix T8097
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T8097
Differential Revision: https://phab.enlightenment.org/D10152
Mike Blumenkrantz [Wed, 25 Sep 2019 11:27:42 +0000 (13:27 +0200)]
api: mark Efl.Ui.Box_Stack stable
Summary: fix T8207
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T8207
Differential Revision: https://phab.enlightenment.org/D10150
Mike Blumenkrantz [Wed, 25 Sep 2019 11:22:34 +0000 (13:22 +0200)]
efl/arrangement: mark content_padding beta
Summary:
this still potentially needs some work and changing the implementations
now would be too invasive
ref T7864
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7864
Differential Revision: https://phab.enlightenment.org/D10149
Shinwoo Kim [Wed, 25 Sep 2019 10:53:53 +0000 (06:53 -0400)]
evas_callbacks: check if obj is NULL before using it
Summary:
evas_object_callbacks_finalized could take NULL obj because
_efl_canvas_object_efl_object_finalize could call it with NULL obj.
Reviewers: bu5hm4n, jsuya, Hermet
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10141
WooHyun Jung [Wed, 25 Sep 2019 10:53:51 +0000 (06:53 -0400)]
efl_ui_spin_button: mark "direct_text_input" property @beta
Summary:
After making efl_ui_text interface be stabilized, this property
can be considered again about its opening.
ref T8097
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8097
Differential Revision: https://phab.enlightenment.org/D10140
Yeongjong Lee [Wed, 25 Sep 2019 10:44:56 +0000 (06:44 -0400)]
efl_ui_layout: fix null pointer dereferences
Summary: If theme doesn't have version data, `version` can be NULL.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10146
Xavi Artigas [Wed, 25 Sep 2019 10:33:24 +0000 (12:33 +0200)]
docs: formatting nitpick in Efl.Player.eo
Stefan Schmidt [Wed, 25 Sep 2019 09:13:32 +0000 (11:13 +0200)]
release: Update NEWS and bump version for 1.23.0-beta3 release
Mike Blumenkrantz [Tue, 24 Sep 2019 20:38:04 +0000 (16:38 -0400)]
efl/image: remove load_controller events
these aren't implemented by anything and duplicate the functionality provided
by efl.gfx.image::image,preload_state,changed
ref T7876
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10128
SangHyeon Jade Lee [Wed, 25 Sep 2019 07:50:06 +0000 (07:50 +0000)]
efl_ui : put beta on range select/unselect as parameter unstable
there are more discussion need on this range selection.
we could extend this parameter with range structure(aka Eina.Range)
so that extendable object to object, int to int, Range to Range.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10145
WooHyun Jung [Wed, 25 Sep 2019 05:18:04 +0000 (05:18 +0000)]
efl_ui_win: default window type change should not be applied to legacy one
If my understanding is correct, below referenced commit needs to be applied to
efl_ui_win only.
@ref D10049
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10143
SangHyeon Jade Lee [Wed, 25 Sep 2019 07:39:30 +0000 (16:39 +0900)]
efl_ui : reverse the select method name to be ended verb on the last.
Summary:
our new method naming rule only allow verb at the last position,
so change name to fallow rule.
Reviewers: bu5hm4n, cedric, segfaultxavi
Reviewed By: bu5hm4n, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10144
Mike Blumenkrantz [Tue, 24 Sep 2019 20:53:49 +0000 (16:53 -0400)]
api: mark Efl.Player stable
fix T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10127
Mike Blumenkrantz [Tue, 24 Sep 2019 19:43:00 +0000 (15:43 -0400)]
efl_ui/image: implement efl.player::playback_speed methods
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10121
Mike Blumenkrantz [Tue, 24 Sep 2019 19:30:11 +0000 (15:30 -0400)]
efl_ui/image: implement efl.player::playback_progress method
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10120
Mike Blumenkrantz [Tue, 24 Sep 2019 19:27:24 +0000 (15:27 -0400)]
efl_ui/image: implement required efl.player::playback_position methods
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10119
Mike Blumenkrantz [Tue, 24 Sep 2019 18:21:29 +0000 (14:21 -0400)]
efl/player: improve docs
some doc improvements
ref T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10117
Mike Blumenkrantz [Tue, 24 Sep 2019 18:21:04 +0000 (14:21 -0400)]
efl/player: progress -> playback_progress
no functional changes
ref T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10116
Mike Blumenkrantz [Tue, 24 Sep 2019 18:16:13 +0000 (14:16 -0400)]
efl/player: play_speed -> playback_speed
no functional changes
ref T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10115
Mike Blumenkrantz [Tue, 24 Sep 2019 15:18:57 +0000 (11:18 -0400)]
efl/player: rename 'play' property to 'pause'
this is a bit of an overhaul wherein the existing 'play' mechanics are
all inverted. 'pause' is a state which stops playback but does not affect
the playback_position property.
this patch also includes implementations of Efl.Player::playing for
a couple classes which (now) only implement pause, as this is a requirement
for the objects to actually activate their animations
test cases:
* unit tests
* all elm_test animation cases
* elm_test video
* rage
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10114
Mike Blumenkrantz [Tue, 24 Sep 2019 14:11:26 +0000 (10:11 -0400)]
efl/player: merge start+stop methods into 'playing' property
this has some overlap with the existing 'play' property which will
soon be renamed. the intent here is that there is a property for
controlling the 'playing' state and then another property for managing
'pausing' the play state
ref T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10113
Mike Blumenkrantz [Tue, 24 Sep 2019 14:02:54 +0000 (10:02 -0400)]
efl/player: pos -> playback_position
ref T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10112
Mike Blumenkrantz [Tue, 24 Sep 2019 13:39:21 +0000 (09:39 -0400)]
efl/player: prune properties duplicated in efl.playable
efl.playable implements a number of properties which are also present
in efl.player. playable was intended to be separate, so enforce this
split in all classes which use player
ref T7877
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10109
Yeongjong Lee [Wed, 25 Sep 2019 06:59:23 +0000 (15:59 +0900)]
elm_object: revert deferred sizing_eval to keep backward compatibility
If legacy widget that override `efl_canvas_group_calculate` call
`elm_layout_sizing_eval`, the overridden function
`_xxx_efl_canvas_group_group_calculate` is called.
This reverts commit
29270c6861f999fae438b650e009dd9c706b4015.
This reverts commit
29270c6861f999fae438b650e009dd9c706b4015.
@tizen_fix
Change-Id: Ib3efae3ad057ac166309414aff8dc3ba44247b49
Hosang Kim [Wed, 25 Sep 2019 06:21:07 +0000 (15:21 +0900)]
slider: delete unnecessary tizen only code
Change-Id: If34391956a8b81a2b7d2b57fa0759919b7a4ab59
WooHyun Jung [Tue, 24 Sep 2019 22:14:29 +0000 (07:14 +0900)]
Revert "efl_canvas_object: set default value to false for not breaking compatibility"
This reverts commit
5d4c3446016a97622aae0c03c9a4d423c1f1e41d.
This was commit only for Tizen and it was fixed by upstream properly.
So, reverting this commit is right process.
Change-Id: I1fd2631e06ae76050e9b124d64f9d049124800d5
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:58 +0000 (17:02 -0400)]
efl_ui/spin_button: fix signal namespacing
Summary:
efl,anim,activate is the signal used by buttons, which is what this is
ref T8231
Depends on D10099
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10100
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:52 +0000 (17:02 -0400)]
efl_ui/timepicker: rename and namespace visibility signals
Summary:
this is consistent with efl api 'visible' property
ref T8231
Depends on D10098
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10099
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:46 +0000 (17:02 -0400)]
efl_ui/scroller: remove unused "looping" signals
Summary:
this feature is not implemented
revert this patch to restore signal handling when the corresponding
features are implemented by widgets
ref T8231
Depends on D10097
Reviewers: cedric
Reviewed By: cedric
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10098
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:40 +0000 (17:02 -0400)]
efl_ui/focus: rename focus visibility signals
Summary:
this is consistent with efl api 'visible' property
ref T8231
Depends on D10096
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10097
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:34 +0000 (17:02 -0400)]
efl_ui/scroller: rename bar visibility signals
Summary:
this is consistent with efl api 'visible' property
ref T8231
Depends on D10095
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10096
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:56 +0000 (16:59 -0400)]
efl_ui/alert_popup: rename show/hide signals to visible,on/off
Summary:
this is consistent with the efl api
ref T8231
Depends on D10081
Reviewers: segfaultxavi, cedric
Reviewed By: cedric
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10095
Xavi Artigas [Tue, 24 Sep 2019 20:59:50 +0000 (16:59 -0400)]
theme: add 'required' to efl/border parts
Summary: ref T8231
Reviewers: zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10094
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:49 +0000 (16:59 -0400)]
elm: rename _use_build_config variable -> _running_in_tree
Summary:
this makes the meaning of the variable more clear
no functional changes
Depends on D10092
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10093
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:44 +0000 (16:59 -0400)]
efl_ui/alert_popup: use normal C-based part aliasing and remove theme alias
Summary:
part aliasing should be done at the layout level, not using bespoke string
comparisons. also this removes the "title" part of the alert_popup theme
which was previously considered api
Depends on D10091
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10092
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:39 +0000 (16:59 -0400)]
efl_ui/layout: validate theme api version in theme_apply
Summary:
this throws error and warning messages if the theme api version does
not match the current efl version, and it will cause unit tests to fail
when the theme version is not updated
ref T8231
Depends on D10093
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10081
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:33 +0000 (16:59 -0400)]
theme: manually specify version info for all eo-based widget themes
Summary:
this needs to be provided to verify that the theme corresponds to the
current version of the widget
ref T8231
Depends on D10079
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10080
Bruno da Silva Belo [Tue, 24 Sep 2019 19:50:49 +0000 (16:50 -0300)]
eolian: fixing switch case.
Summary: Scope of the switch breaks compilation.
Reviewers: felipealmeida, segfaultxavi, brunobelo
Reviewed By: brunobelo
Subscribers: segfaultxavi, cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10118
Lauro Moura [Tue, 24 Sep 2019 14:36:34 +0000 (11:36 -0300)]
csharp: Fix wrapping of private classes
Summary:
Sometimes, valid Eo objects of private classes can be returned from
methods. Currently we try to wrap in a minimal `Efl.Object` instance,
but as it is an abstract class, we can't instantiate directly.
This commits adds a dummy `Efl.ObjectRealized` to be instantiated when
wrapping such classes alongside a test case.
Fixes: T8258
Reviewers: felipealmeida, brunobelo, segfaultxavi, Jaehyun_Cho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10101
Stefan Schmidt [Tue, 24 Sep 2019 20:56:48 +0000 (16:56 -0400)]
efl_ui_selection_manager: fix potential out of bounce access
Summary:
We have been casting the selection to unsigned char * for the address of
sel and not for the value. Coverity pointed this out:
Overrunning buffer pointed to by (unsigned char *)&sel of 8 bytes by
passing it to a function which accesses it at byte offset 167 using argument 168
It seems this has been working by memory layout and luck if I understand
it all correctly.
Coverity ID: 1402666
Reviewers: thiepha, raster, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10107
Mike Blumenkrantz [Mon, 23 Sep 2019 19:20:07 +0000 (15:20 -0400)]
efl_ui/layout: fix part aliasing for non-legacy widgets
if a non-null value is passed here, this needs to actually evaluate
all the part aliases
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10091
Mike Blumenkrantz [Mon, 23 Sep 2019 17:24:51 +0000 (13:24 -0400)]
elm: rename layout part aliasing functions/macros
these are internal apis for managing part aliasing on the C side,
but they apply to efl_ui_layout and not elm_layout
no functional changes
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10090
Mike Blumenkrantz [Tue, 24 Sep 2019 20:11:33 +0000 (16:11 -0400)]
evas: fix error return of evas_object_propagate_events_get()
ref T8259
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10123
Lauro Moura [Tue, 24 Sep 2019 20:06:29 +0000 (20:06 +0000)]
csharp: Fix factory instantiation
After
892c26f906d23595b709b834dde6b032bdd6d89d, widget factories require
a widget to be their parents.
This commit updates C# tests and adds a warning message to elementary if the user does
not provide one.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10122
Mike Blumenkrantz [Tue, 24 Sep 2019 18:51:04 +0000 (14:51 -0400)]
efl/audio_control: remove player
Summary: this does not require any other interfaces
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10110
Xavi Artigas [Tue, 24 Sep 2019 18:51:01 +0000 (14:51 -0400)]
docs: Update Efl.Ui.Scrollbar docs
Summary: Ref T7884
Reviewers: zmike, eagleeye
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7884
Differential Revision: https://phab.enlightenment.org/D10041
Cedric Bail [Tue, 24 Sep 2019 18:54:20 +0000 (11:54 -0700)]
elementary: another forgotten file that need removal.
projects / platform / upstream / efl.git / log