platform/upstream/dbus.git
16 years ago2008-08-24 Peter McCurdy <pmccurdy@skeptopotamus>
Peter McCurdy [Mon, 25 Aug 2008 14:00:09 +0000 (10:00 -0400)]
2008-08-24  Peter McCurdy <pmccurdy@skeptopotamus>

* dbus/dbus-marshal-recursive.c: A stray comma
        between two string literals caused incorrect
        output and a compiler warning.

Signed-off-by: Colin Walters <walters@verbum.org>
16 years agoBug 17280: Add a prototype for _dbus_credentials_add_adt_audit_data()
Peter McCurdy [Mon, 25 Aug 2008 14:10:00 +0000 (10:10 -0400)]
Bug 17280: Add a prototype for _dbus_credentials_add_adt_audit_data()

* dbus/dbus-credentials.h: Add a prototype for
_dbus_credentials_add_adt_audit_data()

Signed-off-by: Colin Walters <walters@verbum.org>
16 years agoBug 17803: Panic from dbus_signature_validate
Colin Walters [Wed, 1 Oct 2008 17:49:48 +0000 (13:49 -0400)]
Bug 17803: Panic from dbus_signature_validate

* dbus/dbus-marshal-validate.c: Ensure we validate
a basic type before calling is_basic on it.
* dbus-marshal-validate-util.c: Test.

16 years agoBug 17061: Handle error return from sysconf correctly
Joe Marcus Clarke [Fri, 5 Sep 2008 02:13:30 +0000 (22:13 -0400)]
Bug 17061: Handle error return from sysconf correctly

* dbus/dbus-sysdeps-unix.c:
* dbus/dbus-sysdeps-util-unix.c: Cast return
from sysconf temporarily so we actually see
-1.

Signed-off-by: Colin Walters <walters@verbum.org>
16 years agoBug 13387: Fix compilation failure with AI_ADDRCONFIG
Jens Granseuer [Thu, 7 Aug 2008 18:45:51 +0000 (14:45 -0400)]
Bug 13387: Fix compilation failure with AI_ADDRCONFIG

Signed-off-by: Colin Walters <walters@verbum.org>
16 years agoBug 17352: synchronize the file before renaming
Artem Bityutskiy [Fri, 29 Aug 2008 14:13:15 +0000 (17:13 +0300)]
Bug 17352: synchronize the file before renaming

Dbus is doing atomic file updates by copying them, changing
the copy, and re-naming them. However, it does not synchronize
the file before re-naming, which results in corruption in
case of unclean reboots. The reason for this is that file-systems
have write-back cache and they postpone writing data to the media.

This patch adds the missed fsync() for the Unix part. I do
not have windows so cannot provide a windows port fix.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Colin Walters <walters@verbum.org>
16 years agoCorrectly dist 1.2.3 tarball with docs enabled dbus-1.2.3
Colin Walters [Wed, 6 Aug 2008 19:58:41 +0000 (15:58 -0400)]
Correctly dist 1.2.3 tarball with docs enabled

16 years agoBump configure.ac to 1.2.2
Colin Walters [Wed, 6 Aug 2008 17:21:54 +0000 (13:21 -0400)]
Bump configure.ac to 1.2.2

16 years agoBug 15646: Remove spurious debugging fprintf(stderr
Colin Walters [Mon, 28 Jul 2008 20:31:09 +0000 (16:31 -0400)]
Bug 15646: Remove spurious debugging fprintf(stderr

16 years agoBug 16727: Handle ERANGE for getgr; fixes user in many groups
Marc Brockschmidt [Mon, 28 Jul 2008 20:09:53 +0000 (16:09 -0400)]
Bug 16727: Handle ERANGE for getgr; fixes user in many groups

Patch originally from Noèl Köthe.
Modified by Colin Walters <walters@verbum.org>

* dbus/dbus-sysdeps-unix.c, dbus/dbus-sysdeps-unix-utils.c:
Use a while() loop to reallocate buffer if we get ERANGE
return.  This fixes the case where a user is in a large
number of groups.

16 years agoBug 16294: Don't lose inotify watch when config fails to parse
Colin Walters [Mon, 28 Jul 2008 16:02:56 +0000 (12:02 -0400)]
Bug 16294: Don't lose inotify watch when config fails to parse

* bus/dir-watch-inotify.c: Always drop the watch in
handle_inotify_watch; this ensures we always readd it
correctly in bus_drop_all_directory_watches.

16 years agoBug 16838: Use bash instead of sh to avoid breaking on Ubuntu
Colin Walters [Thu, 24 Jul 2008 20:37:25 +0000 (16:37 -0400)]
Bug 16838: Use bash instead of sh to avoid breaking on Ubuntu

16 years agoMerge branch 'master' of ssh://walters@git.freedesktop.org/git/dbus/dbus
Colin Walters [Thu, 24 Jul 2008 20:19:34 +0000 (16:19 -0400)]
Merge branch 'master' of ssh://walters@git.freedesktop.org/git/dbus/dbus

16 years agoBug 16839: Fix bus names in test case so it actually works.
Scott James Remnant [Thu, 24 Jul 2008 20:19:14 +0000 (16:19 -0400)]
Bug 16839: Fix bus names in test case so it actually works.

* test/name-test/test-privserver.c (filter_session_message, main),
* test/name-test/test-privserver-client.c (open_shutdown_private_connection):
 Replace TestServer with PrivServer to match the service definition files.

16 years agoFix leaks in bus_activation_get_environment error paths
Ray Strode [Tue, 15 Jul 2008 08:01:49 +0000 (04:01 -0400)]
Fix leaks in bus_activation_get_environment error paths

Commit 91306ef938873fce8f2ae2d4a6b3282d0379c65a introduced
two memory leaks on OOM error paths.  In one case the
environment string array wasn't getting freed, and in the
other case it was getting freed with dbus_free instead of
dbus_free_string_array.

16 years agoUpdate man page to make the point of the <type> element more clear
Ray Strode [Fri, 11 Jul 2008 14:27:07 +0000 (10:27 -0400)]
Update man page to make the point of the <type> element more clear

There have been a number of patches in the past try to key system
versus session bus policy off of the message bus type, when the
policy should be distinguished from more fine-grained options in the
individulal policy files.  Hopefully, this man page update will make
that more clear.

16 years agoAdd new UpdateActivationEnvironment bus message
Ray Strode [Thu, 10 Jul 2008 17:19:44 +0000 (13:19 -0400)]
Add new UpdateActivationEnvironment bus message

It adjusts the environment of activated bus clients.
This is important for session managers that get started
after the session bus daemon and want to influence the
environment of desktop services that are started by the
bus.

16 years agoStore what environment to activate with on activation object
Ray Strode [Thu, 10 Jul 2008 18:35:38 +0000 (14:35 -0400)]
Store what environment to activate with on activation object

We now keep the environment in a hash table member of the
activation object and provide a method
bus_activation_set_environment_variable to modify the
hash table.  This hash table is seeded initially with the
environment of the bus daemon itself.

16 years agoWhen spawning processes, don't ignore the passed in environment
Ray Strode [Thu, 10 Jul 2008 17:12:01 +0000 (13:12 -0400)]
When spawning processes, don't ignore the passed in environment

Previously, we'd always call execv() and unconditionally use
the environment of the parent.  Now we call execve() with the
passed in environment.  For compatibility, we detect if
the passed in environment is NULL and for that case, use the
environment from the parent instead.

16 years agoAdd new function _dbus_string_split_on_byte
Ray Strode [Fri, 11 Jul 2008 15:32:30 +0000 (11:32 -0400)]
Add new function _dbus_string_split_on_byte

It allows you to turn a string like KEY=VALUE
into two strings key and value.

16 years agoAdd new _dbus_get_environment call
Ray Strode [Thu, 10 Jul 2008 16:45:36 +0000 (12:45 -0400)]
Add new _dbus_get_environment call

It's a wrapper around the environ external variable.
It will be important in the future when we allow
bus clients to modify the environment of future
activated clients. Presently, we just always use the
bus daemon environment wholesale.

16 years agoMerge branch 'dbus-1.2'
Thiago Macieira [Sat, 7 Jun 2008 15:48:04 +0000 (17:48 +0200)]
Merge branch 'dbus-1.2'

16 years agoFix inverted return value from dbus_connection_read_write()
Oswald Buddenhagen [Sat, 7 Jun 2008 15:24:50 +0000 (17:24 +0200)]
Fix inverted return value from dbus_connection_read_write()

    * dbus/dbus-connection.c (_dbus_connection_read_write_dispatch):
      The double negation re no_progress_possible was obviously too
      confusing: the path for dispatch = FALSE would return an inverted
      status. So make it progress_possible and fix the logic.

Signed-off-by: Thiago Macieira <thiago@kde.org>
16 years agoBug 15740: Solaris/ADT auditing support (simon zheng)
Colin Walters [Thu, 5 Jun 2008 21:24:34 +0000 (17:24 -0400)]
Bug 15740: Solaris/ADT auditing support (simon zheng)

* bus/driver.c: Add GetAdtAuditSessionData method
which returns audit data for a connection.
* configure.in: Detect ADT auditing support
* dbus/dbus-auth.c: Read ADT auditing creds.
* dbus/dbus-connection.c: Implement
dbus_connection_get_adt_audit_session_data.
* dbus/dbus-connection.h: Export it.
* dbus/dbus-credentials.c: Add support for
gathering adt_audit_data and retrieving it
via _dbus_credentials_get_adt_audit_data.
* dbus/dbus-credentials.h: Add
DBUS_CREDENTIAL_ADT_AUDIT_DATA_ID.
* dbus/dbus-protocol.h: New error
DBUS_ERROR_ADT_AUDIT_DATA_UNKNOWN.
* dbus/dbus-sysdeps.c: Support for reading
audit credentials via ADT API.
* dbus/dbus-transport.c: New function
_dbus_transport_get_adt_audit_session_data
to retrieve credentials.
* dbus/dbus-transport.h: Export it.

16 years agoTweak HACKING to describe test/name-test briefly
Colin Walters [Sat, 31 May 2008 01:05:48 +0000 (21:05 -0400)]
Tweak HACKING to describe test/name-test briefly

* HACKING: Describe test/name-test.

16 years agoBug 15635: Hold a reference during read/write dispatch (Scott James Remnant)
Colin Walters [Sat, 31 May 2008 00:41:49 +0000 (20:41 -0400)]
Bug 15635: Hold a reference during read/write dispatch (Scott James Remnant)

* dbus/dbus-connection.c (_dbus_connection_read_write_dispatch):
  Reference the D-Bus connection during the function call since we
  call other functions that may free the last reference and we
  still expect to be able to check the connection after they return
  to decide our own return value.

16 years agoBug 15571: Clean up GUID-less connections correctly (Scott James Remnant)
Colin Walters [Sat, 31 May 2008 00:25:36 +0000 (20:25 -0400)]
Bug 15571: Clean up GUID-less connections correctly (Scott James Remnant)

* dbus/dbus-connection.c (connection_forget_shared_unlocked):
  Remove shared connections which lack a GUID from the list that
  caches those, otherwise references to them will remain after
  they have been freed.
* test/name-test/test-privserver-client.c: Update test to
try GUID-less connections too.

16 years agoBug 15570: Reset initialized state on dbus_shutdown (Scott James Remnant)
Colin Walters [Fri, 30 May 2008 23:58:13 +0000 (19:58 -0400)]
Bug 15570: Reset initialized state on dbus_shutdown (Scott James Remnant)

* dbus/dbus-bus.c (addresses_shutdown_func): Reset initialized back
  to FALSE after cleaning up the address list so that it will be
  reinitialized again if D-Bus is used after dbus_shutdown()
* test/name-test/test-privserver-client.c: Uncomment part of
test which should now pass.

16 years agoAdd "PrivServer" test which exercises DBusServer and dbus_shutdown
Colin Walters [Fri, 30 May 2008 21:11:15 +0000 (17:11 -0400)]
Add "PrivServer" test which exercises DBusServer and dbus_shutdown

* test/data/valid-service-files/org.freedesktop.DBus.TestSuite.PrivServer.service.in:
New service file for PrivServer.
* configure.in: Generate it.
* test/name-test/Makefile.am: Build test-privserver and
test-privserver-client.
* test/name-test/test-privserver.c: Use DBusServer to
serve a private connection.
* test/name-test/test-privserver-client.c: Connect
via session bus and get address of private server,
exercise dbus_shutdown().
* test/name-test/run-test.sh: Run it.

16 years agoAdd noinst convenience test library, add a test-shutdown
Colin Walters [Fri, 30 May 2008 20:53:35 +0000 (16:53 -0400)]
Add noinst convenience test library, add a test-shutdown

* test/Makefile.am: New convenience library
libdbus_testutils_la.  Reorder build so that
test/ gets built before test/name-test so
name-test files can depend on it.
* test/name-test/test-shutdown.c: New file,
exercises dbus_shutdown () a bit.
* test/name-test/run-test.sh Run test-shutdown.
* test/test-utils.h: In some cases we already have
DBUS_COMPILATION defined, avoid double definition
warning.

16 years agoAdd test library functions for using DBusServer
Colin Walters [Fri, 30 May 2008 14:33:18 +0000 (10:33 -0400)]
Add test library functions for using DBusServer

* test/test-utils.h, test/test-utils.c: Add functions
which hook up a DBusServer to a DBusLoop, useful
for test cases.

16 years agoBug 15588: Fix typo in #ifdef for userdb cache (Scott James Remnant)
Colin Walters [Fri, 30 May 2008 15:14:46 +0000 (11:14 -0400)]
Bug 15588: Fix typo in #ifdef for userdb cache (Scott James Remnant)

* dbus/dbus-userdb-util.c, dbus/dbus-userdb.c: Correct name of
  macro used in #ifdef block to match that defined by configure,
  otherwise the userdb cache will never be enabled.

16 years agoBug 15947: Close file descriptors before execing helper (Markus Rechberger)
Colin Walters [Wed, 28 May 2008 20:01:22 +0000 (16:01 -0400)]
Bug 15947: Close file descriptors before execing helper (Markus Rechberger)

* dbus/dbus-sysdeps-unix.c (_dbus_get_autolaunch_address):
Close file descriptors before exec.

16 years agoMerge branch 'dbus-1.2'
Thiago Macieira [Sat, 17 May 2008 08:11:20 +0000 (10:11 +0200)]
Merge branch 'dbus-1.2'

16 years agoPrevent a crash in some applications due to timers leaking after the
Thiago Macieira [Sat, 17 May 2008 08:09:20 +0000 (10:09 +0200)]
Prevent a crash in some applications due to timers leaking after the
DVusPendingCall object was freed.

    * dbus-connection.c: Remove the timer for the pending call's timeout in
      case the reply has timed out in blocking code. This fixes bug 15684.

16 years agotake out trailing comma inside an enum so non gcc compilers don't error out
John (J5) Palmieri [Wed, 16 Apr 2008 14:49:25 +0000 (10:49 -0400)]
take out trailing comma inside an enum so non gcc compilers don't error out

* tools/dbus-monitor.c: take out the trailing comma in the
  ProfileAttributeFlags enum as it isn't in our style guides and causes
  some compilers to error out

16 years agotake out trailing comma inside an enum so non gcc compilers don't error out
John (J5) Palmieri [Wed, 16 Apr 2008 14:49:25 +0000 (10:49 -0400)]
take out trailing comma inside an enum so non gcc compilers don't error out

* tools/dbus-monitor.c: take out the trailing comma in the
  ProfileAttributeFlags enum as it isn't in our style guides and causes
  some compilers to error out

16 years agoup version for unstable development
John (J5) Palmieri [Fri, 4 Apr 2008 19:42:58 +0000 (15:42 -0400)]
up version for unstable development

16 years agogetting ready for 1.2 stable branch
John (J5) Palmieri [Fri, 4 Apr 2008 19:37:50 +0000 (15:37 -0400)]
getting ready for 1.2 stable branch

* ChangeLog.pre-1-2: rename ChangeLog
* NEWS.pre-1-2: rename NEWS
* Makefile.am: list the pre files in EXTRA_DIST; the pre-1-0 files had not
  been added yet so do that too

16 years agobump version after release
John (J5) Palmieri [Fri, 4 Apr 2008 19:26:52 +0000 (15:26 -0400)]
bump version after release

16 years agoReleased 1.2.1 dbus-1.2.1
John (J5) Palmieri [Fri, 4 Apr 2008 19:24:46 +0000 (15:24 -0400)]
Released 1.2.1

16 years agochange version to 1.2.1 to prep release
John (J5) Palmieri [Fri, 4 Apr 2008 19:15:22 +0000 (15:15 -0400)]
change version to 1.2.1 to prep release

* we are moving to the 1.2.x version scheme because re-licensing seems to be
  blocked indefinitely

16 years agoRevert "fix dbus-send so it can correctly send dictionaries"
John (J5) Palmieri [Fri, 4 Apr 2008 18:58:07 +0000 (14:58 -0400)]
Revert "fix dbus-send so it can correctly send dictionaries"

This reverts commit a689ef29f176110b0f74e47fd5dd1d2d6ad3dfd3.

Conflicts:

ChangeLog

* Turns out I reversed a patch that was alread committed but the bug had not
  been closed.  Since the patch was applied before I also reverted the
  mention of Jérémie in the AUTHORS list mainly for license book keeping
  sanity.

16 years agofix memleak due to autolaunch and recursive calls to _dbus_open_transport
John (J5) Palmieri [Thu, 3 Apr 2008 20:08:40 +0000 (16:08 -0400)]
fix memleak due to autolaunch and recursive calls to _dbus_open_transport

* Patch from Sumit <sumitskj_20@yahoo.com>, comments added

* dbus/dbus-transport.c(_dbus_transport_open): fix mem leak

16 years agomodify dbus_connection_send documentation
John (J5) Palmieri [Thu, 3 Apr 2008 17:15:45 +0000 (13:15 -0400)]
modify dbus_connection_send documentation

* dbus/dbus-connection.c (dbus_connection_send): add documentation
  to describe when to call dbus_connection_flush and
  dbus_connection_unref after a call to dbus_connection_send is made
  Initial wording by Stanislav Brabec <sbrabec at suse.cz>
  (fd.o bug#13558)

16 years agofix dbus-send so it can correctly send dictionaries
Jérémie Dimino [Thu, 3 Apr 2008 15:32:09 +0000 (11:32 -0400)]
fix dbus-send so it can correctly send dictionaries

* tools/dbus-send.c (append_dict): Send in signature when opening up
  a dict entry container

* AUTHORS: Add Jérémie to AUTHORS file since it was a slightly above
  trivial fix

16 years agofix expiration of pending replies
Kimmo Hämäläinen [Thu, 3 Apr 2008 15:12:27 +0000 (11:12 -0400)]
fix expiration of pending replies

* bus/expirelist.c
  (do_expiration_with_current_time): calculate correct min wait time
  and next interval
  (bus_expire_list_add, bus_expire_list_add_link): if the timeout is
  disabled when we add an item to the expire list, enable the timeout
  (do_expiration_with_current_time): only set timeout if there are
  items to expire

16 years agoMerge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus
John (J5) Palmieri [Thu, 3 Apr 2008 15:11:19 +0000 (11:11 -0400)]
Merge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus

Conflicts:

ChangeLog

16 years agoFixes for the inotify configuration file monitor backend.
Frederic Crozat [Tue, 1 Apr 2008 16:09:46 +0000 (18:09 +0200)]
Fixes for the inotify configuration file monitor backend.

2008-04-01  Timo Hoenig  <thoenig@suse.de>

Patch from Frederic Crozat <fcrozat@mandriva.com>

* bus/dir-watch-inotify.c (bus_watch_directory): Only monitor
  IN_CLOSE_WRITE, IN_DELETE, IN_MOVE_TO and IN_MOVE_FROM events. This
  way, only atomic changes to configuration file are monitored.
* bus/dir-watch-inotify.c (_handle_inotify_watch): Fix typo in
  _dbus_verbose function call
* bus/dir-watch-inotify.c (bus_drop_all_directory_watches): Use
  _dbus_strerror instead of perror

16 years agoCheck for X11 events before selecting (FDO bug #15293)
Colin Walters [Mon, 31 Mar 2008 22:20:07 +0000 (18:20 -0400)]
Check for X11 events before selecting (FDO bug #15293)

16 years agoMake sure we call XFlush() on all code paths (FDO bug #15293)
Colin Walters [Mon, 31 Mar 2008 22:16:00 +0000 (18:16 -0400)]
Make sure we call XFlush() on all code paths (FDO bug #15293)

16 years agoDo not provide a signature to dbus_message_iter_open_container() when opening a dict...
Havoc Pennington [Thu, 27 Mar 2008 20:52:40 +0000 (16:52 -0400)]
Do not provide a signature to dbus_message_iter_open_container() when opening a dict entry.

2008-03-27  Havoc Pennington  <hp@redhat.com>

* tools/dbus-send.c (append_dict): Do not provide a signature to
dbus_message_iter_open_container() when opening a dict entry.

16 years agoSet default exit_on_disconnect after registration
Colin Walters [Wed, 26 Mar 2008 14:28:40 +0000 (10:28 -0400)]
Set default exit_on_disconnect after registration

2008-03-26  Colin Walters  <walters@verbum.org>
Patch from Scott James Remnant <scott@netsplit.com>

* dbus/dbus-bus.c: Set default exit_on_disconnect after registration with
the bus, not before.  This ensures that programs which wish to set
exit_on_disconnect to FALSE will not be terminated if the bus exits
during registration.  (FDO Bug #15112)

16 years agoMake BusExpireList an opaque data type
Havoc Pennington [Thu, 8 Nov 2007 22:51:15 +0000 (17:51 -0500)]
Make BusExpireList an opaque data type

2007-11-08  Havoc Pennington  <hp@redhat.com>

* bus/connection.c, bus/expirelist.c: Make the BusExpireList
struct opaque, adding accessors for manipulating the list. In this
commit there should be no change in functionality or behavior. The
purpose of this change is to improve encapsulation prior to fixing
some bugs Kimmo Hämäläinen found where the timeout is not properly
updated, since we need to e.g. take some action whenever adding
and removing stuff from the expire list.

16 years agofix broken poll on Mac OSX - build patch by Benjamin Reed
John (J5) Palmieri [Tue, 4 Mar 2008 18:21:05 +0000 (13:21 -0500)]
fix broken poll on Mac OSX - build patch by Benjamin Reed

* configure.in: check for OSX's deadlocking poll
* dbus/dbus-sysdeps-unix.c (_dbus_poll): if we have a broken poll
  don't use poll

16 years agocheck if the linker supports a flag instead of just checking for GNU ld
John (J5) Palmieri [Tue, 4 Mar 2008 18:09:07 +0000 (13:09 -0500)]
check if the linker supports a flag instead of just checking for GNU ld

* configure.in: move AM_PROG_LIBTOOL to the top
  (ld_supports_flag): new function for checking if the linker supports
  a given flag

16 years agoadd a changelog for Benjamin Reed's git patch (OS X build fixes)
John (J5) Palmieri [Tue, 4 Mar 2008 18:07:38 +0000 (13:07 -0500)]
add a changelog for Benjamin Reed's git patch (OS X build fixes)

* configure.in: Platform build fixes for Mac OS X
  the Darwin linker does not understand the -z option; wrap it in
  a check for $with_gnu_ld.
  environ is only available at runtime, so you need to make a
  reference to _NSGetEnviron instead for symbols to resolve properly.

16 years agoPlatform build fixes for Mac OS X
Benjamin Reed [Mon, 28 Jan 2008 18:25:56 +0000 (13:25 -0500)]
Platform build fixes for Mac OS X

- the Darwin linker does not understand the -z option; wrap it in
  a check for $with_gnu_ld.
- environ is only available at runtime, so you need to make a
  reference to _NSGetEnviron instead for symbols to resolve properly.

16 years agoconfigure.in: add $THREAD_LIBS to DBUS_LAUNCHER_LIBS so we link correctly
John (J5) Palmieri [Tue, 4 Mar 2008 15:12:57 +0000 (10:12 -0500)]
configure.in: add $THREAD_LIBS to DBUS_LAUNCHER_LIBS so we link correctly

16 years agotools/dbus-launch.c: wrap X'ism in #ifdef so we can compile without X
John (J5) Palmieri [Tue, 4 Mar 2008 15:03:14 +0000 (10:03 -0500)]
tools/dbus-launch.c: wrap X'ism in #ifdef so we can compile without X

16 years agoMerge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus
John (J5) Palmieri [Thu, 28 Feb 2008 18:19:14 +0000 (13:19 -0500)]
Merge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus

16 years agodefine _AI_ADDRCONFIG if not defined so that we can compile with an older glibc
John (J5) Palmieri [Thu, 28 Feb 2008 18:18:03 +0000 (13:18 -0500)]
define _AI_ADDRCONFIG if not defined so that we can compile with an older glibc

16 years agoadd 'tags' to .gitignore
Ryan Lortie [Wed, 27 Feb 2008 21:21:12 +0000 (16:21 -0500)]
add 'tags' to .gitignore

16 years agoReleased 1.1.20 dbus-1.1.20
John (J5) Palmieri [Tue, 26 Feb 2008 18:37:48 +0000 (13:37 -0500)]
Released 1.1.20

16 years agoCVE-2008-0595 dbus security policy circumvention
John (J5) Palmieri [Tue, 26 Feb 2008 18:30:47 +0000 (13:30 -0500)]
CVE-2008-0595 dbus security policy circumvention

* CVE-2008-0595 - security policy of the type <allow send_interface=
  "some.interface.WithMethods"/> work as an implicit allow for
  messages sent without an interface bypassing the default deny rules
  and potentially allowing restricted methods exported on the bus to be
  executed by unauthorized users.  This patch fixes the issue.
* bus/policy.c (bus_client_policy_check_can_send,
  bus_client_policy_check_can_receive): skip messages without an
  interface when evaluating an allow rule, and thus pass it to the
  default deny rules

16 years agocorrectly unref connections without guids during shutdown
John (J5) Palmieri [Tue, 26 Feb 2008 15:35:56 +0000 (10:35 -0500)]
correctly unref connections without guids during shutdown

* dbus/dbus-connection.c (close_connection_on_shutdown): new method
  split out from shared_connections_shutdown
  (shared_connections_shutdown): shutdown all shared connections
  without guids
  (_dbus_connection_ref_unlocked): handle OOM when prepending no guid
  connections to the shared_connections_no_guid list
* Patch by  Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

16 years agofix build against the latest gcc/glibc
John (J5) Palmieri [Thu, 21 Feb 2008 18:42:06 +0000 (13:42 -0500)]
fix build against the latest gcc/glibc

* dbus/dbus-sysdeps-unix.c: define _GNU_SOURCE
* bus/selinux.c: include limits.h
* Patch by Matthias Clasen <mclasen at redhat.com>

16 years agofixes dbus-launch so the bus goes away when X does (Red Hat Bug #430412)
John (J5) Palmieri [Thu, 21 Feb 2008 17:02:58 +0000 (12:02 -0500)]
fixes dbus-launch so the bus goes away when X does (Red Hat Bug #430412)

* tools/dbus-launch.c (main): set xdisplay = NULL
* Patch by Matthias Clasen <mclasen at redhat.com>
+

16 years agopost-release bump
John (J5) Palmieri [Thu, 17 Jan 2008 20:21:50 +0000 (15:21 -0500)]
post-release bump

16 years agoRelease 1.1.4(1.2.0RC2) dbus-1.1.4
John (J5) Palmieri [Thu, 17 Jan 2008 20:20:25 +0000 (15:20 -0500)]
Release 1.1.4(1.2.0RC2)

16 years agofix inotify support
John (J5) Palmieri [Thu, 17 Jan 2008 19:57:47 +0000 (14:57 -0500)]
fix inotify support

2008-01-17  Timo Hoenig  <thoenig@suse.de>
* fix inotify support
* bus/dir-watch-inotify.c (_handle_inotify_watch): fix reading of the
inotify events. Also, use ssize_t not size_t for 'ret'.
* bus/dir-watch-inotify.c (bus_watch_directory): watch not only for
IN_MODIFY but also for IN_CREATE and IN_DELETE
* bus/dir-watch-inotify.c (bus_drop_all_directory_watches): drop the
inotify watches more elegantly by closing inotify:_fd, set inotify_fd to
-1 after dropping the watches

16 years agopost-release version bump
John (J5) Palmieri [Wed, 16 Jan 2008 00:54:46 +0000 (19:54 -0500)]
post-release version bump

16 years agoReleased 1.1.3 (1.2.0RC1) dbus-1.1.3
John (J5) Palmieri [Wed, 16 Jan 2008 00:52:40 +0000 (19:52 -0500)]
Released 1.1.3 (1.2.0RC1)

16 years agofix HACKING to say git instead of cvs
John (J5) Palmieri [Tue, 15 Jan 2008 23:35:41 +0000 (18:35 -0500)]
fix HACKING to say git instead of cvs

16 years agowrap all_reader_classes[] in #ifndef DBUS_DISABLE_ASSERT (FDO Bug #9030)
John (J5) Palmieri [Tue, 15 Jan 2008 23:10:50 +0000 (18:10 -0500)]
wrap all_reader_classes[] in #ifndef DBUS_DISABLE_ASSERT (FDO Bug #9030)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Sébastien Couret <10function at gmail dot com>

* dbus/dbus-marshal-recursive.c (all_reader_classes[]): wrap in
#ifndef DBUS_DISABLE_ASSERT since it is only used in asserts which
are noop

16 years agohandle SASL EXTERNAL's inital empty responce (FDO Bug #9945)
John (J5) Palmieri [Tue, 15 Jan 2008 22:21:52 +0000 (17:21 -0500)]
handle SASL EXTERNAL's inital empty responce (FDO Bug #9945)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Magnus Henoch <henoch plus bfdo at dtek dot chalmers dot se>

* dbus/dbus-auth.c (handle_server_data_external_mech): handle SASL
EXTERNAL's inital empty responce (FDO Bug #9945)

16 years agoadd lsb headers to init script (FDO Bug #11491)
John (J5) Palmieri [Tue, 15 Jan 2008 21:58:36 +0000 (16:58 -0500)]
add lsb headers to init script (FDO Bug #11491)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* bus/messagebus.in: add lsb headers (FDO Bug #11491)

16 years agocheck write return value so we don't hang (FDO Bug #11665)
John (J5) Palmieri [Tue, 15 Jan 2008 21:51:30 +0000 (16:51 -0500)]
check write return value so we don't hang (FDO Bug #11665)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Peter O'Gorman <pogma at thewrittenword dot com>

* dbus/dbus-spawn.c (babysit_signal_handler): check write return value
so we don't hang (FDO Bug #11665)

16 years agosupport for AIX poll implementation (FDO Bug #11666)
John (J5) Palmieri [Tue, 15 Jan 2008 21:43:46 +0000 (16:43 -0500)]
support for AIX poll implementation (FDO Bug #11666)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Peter O'Gorman <pogma at thewrittenword dot com>

* dbus/dbus-sysdeps.h: support for AIX poll implementation (FDO Bug
#11666)

16 years agomake shell script more portable (FDO Bug #11667)
John (J5) Palmieri [Tue, 15 Jan 2008 21:23:54 +0000 (16:23 -0500)]
make shell script more portable (FDO Bug #11667)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* tests/name-test/run-test.sh: make more portable (FDO Bug #11667)

16 years agodon't check for < 0 on an unsigned variable (FDO Bug #12924)
John (J5) Palmieri [Tue, 15 Jan 2008 20:57:34 +0000 (15:57 -0500)]
don't check for < 0 on an unsigned variable (FDO Bug #12924)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-connection.c (_dbus_connection_get_next_client_serial):
don't check for < 0 on an unsigned variable (FDO Bug #12924)

16 years agocheck failed allocation (FDO Bug #12920)
John (J5) Palmieri [Tue, 15 Jan 2008 20:49:35 +0000 (15:49 -0500)]
check failed allocation (FDO Bug #12920)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* bus/bus.c (setup_server): check failed allocation (FDO Bug #12920)

16 years agothe API contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)
John (J5) Palmieri [Tue, 15 Jan 2008 20:45:20 +0000 (15:45 -0500)]
the API contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): the API
contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)

16 years agouse correct ssize_t type instead of size_t (FDO Bug #12862)
John (J5) Palmieri [Tue, 15 Jan 2008 20:40:31 +0000 (15:40 -0500)]
use correct ssize_t type instead of size_t (FDO Bug #12862)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-spawn.c (read_ints, read_pid): use correct ssize_t type
instead of size_t (FDO Bug #12862)

16 years agomake sure to call va_end if we hit an OOM error inside va_start (FDO Bug #12846)
John (J5) Palmieri [Tue, 15 Jan 2008 20:30:19 +0000 (15:30 -0500)]
make sure to call va_end if we hit an OOM error inside va_start (FDO Bug #12846)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-errors.c (dbus_set_error): make sure to call va_end if we
hit an OOM error inside va_start (FDO Bug #12846)

16 years agofix possible crash if pending_return is NULL (FDO Bug #12673)
John (J5) Palmieri [Tue, 15 Jan 2008 20:23:57 +0000 (15:23 -0500)]
fix possible crash if pending_return is NULL (FDO Bug #12673)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-connection.c (dbus_connection_send_with_reply):
fix possible crash if pending_return is NULL (FDO Bug #12673)

16 years agonever auto-select libxml
John (J5) Palmieri [Tue, 15 Jan 2008 20:16:23 +0000 (15:16 -0500)]
never auto-select libxml

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* portions of patch submitted by Tim Mooney
<enchanter at users dot sourceforge dot net>

* configure.in: never auto-select libxml (FDO Bug #12479)

16 years agoadd OOM handling in various places
John (J5) Palmieri [Tue, 15 Jan 2008 19:43:19 +0000 (14:43 -0500)]
add OOM handling in various places

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patches by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-sysdeps-unix (_dbus_get_autolaunch_address): handle OOM
(FDO Bug #12945)

* dbus/dbus-uuidgen.c (return_uuid): handle OOM (FDO Bug #12928)

* dbus/dbus-misc.c (dbus_get_local_machine_id): handle OOM, fix return
value to return NULL not FALSE (FDO Bug #12946)

16 years agorewrite selinux error handling to not abort due to a NULL read
John (J5) Palmieri [Tue, 15 Jan 2008 19:20:43 +0000 (14:20 -0500)]
rewrite selinux error handling to not abort due to a NULL read

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* bus/bus.c (bus_context_check_security_policy): rewrite selinux error
handling to not abort due to a NULL read and to set the error only if
it is not already set (Based off of FDO Bug #12430)

16 years agoadd OOM handling
John (J5) Palmieri [Tue, 15 Jan 2008 18:53:54 +0000 (13:53 -0500)]
add OOM handling

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-internals.c (_dbus_read_uuid_file_without_creating,
_dbus_create_uuid_file_exclusively): add OOM handling (FDO Bug #12952)

16 years agoadd error handling when polling (FDO Bug #12954)
John (J5) Palmieri [Tue, 15 Jan 2008 18:46:50 +0000 (13:46 -0500)]
add error handling when polling (FDO Bug #12954)

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-spawn.c (babysit, babysitter_iteration): add error
handling when polling (FDO Bug #12954)

16 years agoremove dead code
John (J5) Palmieri [Tue, 15 Jan 2008 18:32:47 +0000 (13:32 -0500)]
remove dead code

2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* bus/config-parser.c (locate_attributes): remove dead code which
always evaluated to TRUE

* dbus/dbus-shell.c (_dbus_shell_quote): remove unused code

16 years agoplug a possible BusClientPolicy leak (FDO Bug #13242)
John (J5) Palmieri [Tue, 15 Jan 2008 00:04:41 +0000 (19:04 -0500)]
plug a possible BusClientPolicy leak (FDO Bug #13242)

2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* bus/connection.c (bus_connection_complete): plug a possible
BusClientPolicy leak (FDO Bug #13242)

16 years agoadd inotify support (FDO Bz#13268)
John (J5) Palmieri [Tue, 15 Jan 2008 00:00:36 +0000 (19:00 -0500)]
add inotify support (FDO Bz#13268)

2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

* patch by Frederic Crozat <fcrozat at mandriva dot com> (FDO Bz#
13268)

* add inotify support

* bus/Makefile.am: add inotify module to the build

* bus/dir-watch-inotify.c: inotify module based off the dnotify and
kqueue modules

* configure.in: add checks and switch for inotify
also add a printout at the end of configure if inotify and kqueue
support is being built in (dnotify already had this)

16 years agowatch for file creates in dnotify
John (J5) Palmieri [Mon, 14 Jan 2008 23:17:53 +0000 (18:17 -0500)]
watch for file creates in dnotify

2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

* patch by Frederic Crozat <fcrozat at mandriva dot com>

* bus/dir-watch-dnotify.c (bus_watch_directory): watch for file
creates also

16 years agoreturn message loader buffer in case of OOM (FDO Bug#12666)
John (J5) Palmieri [Mon, 14 Jan 2008 23:09:14 +0000 (18:09 -0500)]
return message loader buffer in case of OOM (FDO Bug#12666)

2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

* dbus/dbus-transport-socket.c(do_reading): return message
loader buffer in case of OOM (FDO Bug#12666)

16 years agoadd warning to output when libxml is selected
John (J5) Palmieri [Mon, 14 Jan 2008 20:53:13 +0000 (15:53 -0500)]
add warning to output when libxml is selected

2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

* configure.in: add warning to output when libxml is selected since
we don't have a libxml maintainer and expat works perfectly fine
for what we need an xml parser for

16 years agoadd _dbus_geteuid to fix EXTERNAL authentication in setuid applications
John (J5) Palmieri [Mon, 14 Jan 2008 20:07:48 +0000 (15:07 -0500)]
add _dbus_geteuid to fix EXTERNAL authentication in setuid applications

2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

* Patch by Andrea Luzzardi  <scox at sig11 dot org>: creates a
_dbus_geteuid function to fix EXTERNAL authentication in setuid
applications

*  dbus/dbus-sysdeps-unix.c (_dbus_geteuid): used to get the effective
uid of the running program
(_dbus_credentials_add_from_current_process): use geteuid instead of
getuid
(_dbus_append_user_from_current_process): use geteuid instead of
getuid

* dbus/dbus-sysdeps-util-unix.c (_dbus_change_to_daemon_user): use
geteuid instead of getuid
(_dbus_unix_user_is_at_console): use geteuid instead of getuid

* dbus/dbus-sysdeps-win.c (_dbus_geteuid): add a windows equivilant
that returns DBUS_UID_UNSET

16 years agofix some curly braces that were on the wrong line
Havoc Pennington [Tue, 18 Dec 2007 20:20:17 +0000 (15:20 -0500)]
fix some curly braces that were on the wrong line

2007-12-18  Havoc Pennington  <hp@redhat.com>

* dbus/dbus-connection.c (_dbus_connection_block_pending_call):
fix location of curly braces

16 years agoAllow a normal session bus to be reused by applications using autolaunching
Sjoerd Simons [Fri, 23 Nov 2007 10:31:05 +0000 (11:31 +0100)]
Allow a normal session bus to be reused by applications using autolaunching

2007-11-23  Sjoerd Simons  <sjoerd@luon.net>

   * tools/dbus-launch.c: let both a normal dbus-launch and an
   autolaunched bus save their parameters in X11 if possible. This makes
   the autolaunch and non-autolaunch behaviour more similar. With the
   exception that on a normal launch there will always be a new session
   bus and not being able to save parameters is not fatal. This also
   enables to launch programs directly with autolaunch (not very usefull
   though).