Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main

Change-Id: I240f056caf5a2e3e0037a27718077281a105f358

Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2

Change-Id: I840fb91ba7f6e91956f56b765dba16e2435d4162

Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main

Change-Id: I359783cd885569b2d6eb6846760ee2d030657940

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8

Change-Id: I583b180f82fbb1c9af9a0ddec49f94c84785dc1f

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ie5909532e6b5af30e4e28702a5731ab3b7b4d0a3

Fix build in C++20 mode.

* Compound assignments to volatiles are deprecated.  Use non-compound
  forms.
* Math between disparate enums is deprecated.  Use constexprs.
* The full definition of a type T must be visible for code that
  instantiates std::vector<T>.  Reorder code to guarantee this.

Components: Framework

Bug: chromium:1284275
Change-Id: I75a99b5c09cc911f2312aabe85f49aadff84dc51

Fix build in C++20 mode.

* Compound assignments to volatiles are deprecated.  Use non-compound
  forms.
* Math between disparate enums is deprecated.  Use constexprs.
* The full definition of a type T must be visible for code that
  instantiates std::vector<T>.  Reorder code to guarantee this.

Components: Framework

Bug: chromium:1284275
Change-Id: I75a99b5c09cc911f2312aabe85f49aadff84dc51

Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main" into main

Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main

Change-Id: Ic6be7702f895e29e162fb975ef280af57ccdabe4

VKSC low-memory implementations require lower semaphore count for chain test.

Components: Vulkan SC

VK-GL-CTS issue: 3903

Affects:
dEQP-VKSC.synchronization.basic.binary_semaphore.chain

Change-Id: Ic64f23ee2ee7f770d8b5db3d39deb79a394796ac

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main

Change-Id: I44edd12c04383ff54403341843b3a24335bf96e4

Reintroduce tests for VK_EXT_color_write_enable extension

Adding tests back in to enable coverage for this feature

VK-GL-CTS Issue: 3759
Components: Vulkan

Affects:
dEQP-VK.pipeline.*.color_write_enable_maxa.cwe_after_bind.*
dEQP-VK.pipeline.*.color_write_enable_maxa.cwe_before_bind.*

Change-Id: Ia43d495097038272df407ac633a05ce729af3ea3

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I590325438900e9a2d08d5abe584d63a50a0781f7

Fix dynamic rendering tests using queries with multiview

If queries are used in a render pass instance with multiview enabled
then the query uses N consecutive query indices

Components: Vulkan

VK-GL-CTS issue: 3877

Affected tests:
dEQP-VK.dynamic_rendering*random.seed*

Change-Id: I884b30f7e1be470c0515a6783dbfe1771f1a3ba0

Test per-stage descriptor limits

Add tests to verify that per-stage descriptor limit support works as
advertised.

Components: Vulkan

VK-GL-CTS Issue: 3470

New tests: dEQP-VK.pipeline.*.descriptor_limits.*

Change-Id: I89164d5fbf5382ff4a63410541b6f68efb5c9ad4

Tests for VK_FUCHSIA_external_*

New tests:
dEQP-VK.api.external.semaphore.zircon_event.*
dEQP-VK.api.external.memory.*
dEQP-VK.synchronization.cross_instance.*_zircon_handle
dEQP-VK.synchronization2.cross_instance.*_zircon_handle

Components: Vulkan
VK-GL-CTS issue: 3911

Change-Id: I6c8e61d61f2c0dd380f01711ce7886aa6e3b60df

Test barriers in conditional control flow

Barriers in compute shaders are allowed to be within uniform control
flow, but there were no tests with any barriers in selection constructs.
Add a test.

Uniform control flow for barriers is only required when the barrier is
actually executed (see cross-api/memory-model#116), so the test uses a
mix of uniform and non-uniform selections whilst ensuring that the
barrier is only executed in uniform control flow.

Components: Vulkan
New Test: dEQP-VK.compute.basic.branch_past_barrier

Change-Id: Ic4fbf95f2d903724aa0e564ebc2c3adca982b6da

Extend tests for depth parameter of OpTypeImage

Add tests for depth parameter of OpTypeImage for compute pipeline.
All existing tests will now have 3 variations with depth property
being 0, 1 and 2. Modified name will be same as previous with
'depth.value' added to it.

Extend graphics pipeline tests to correctly generate all tests
for depth parameter of OpTypeImage. Existing tests will be replaced
by tests with similar name with 'depth.value' added to it.

Removed tests:
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.depth_property.*

New tests:
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.*

Components: Vulkan

VK-GL-CTS issue: 3603

Change-Id: I396e767de14381867c2cb042c2b94b985c80190b

Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main

Change-Id: Id9b9246a43eaada1ac75f94980627dd536f5ce5f

Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2

Change-Id: I4c597cb9671bc4a7893d4d921dbaf4bfb42843e0

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ib404387348df248f2a0a6e50f22813bf004c4935

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I5a2183d155a48675e5ef2edc90f4323fe59a9032

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Id151a00583138c75f0ef53f559a3465dabcfdf6e

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I58b46f7b755b5f731d3865d16b2e248eb0653501

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Idcb4f9a2cb008e61fcfcd45aaed0e31be4cf8e1b

Fix wrong calculation to check diff between floats.

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.*

Components: Vulkan

VK-GL-CTS issue: 3916

Change-Id: I05d2b7375c0bd34b6b7fffabbfe52969009ea218

VK_EXT_pipeline_creation_feedback: Invalid feedback is legal

The tests incorrectly required that
VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT be set in
VkPipelineCreationFeedbackCreateInfo::pPipelineCreationFeedback.
However, the tests already and correctly permit the bit to be unset in
VkPipelineCreationFeedbackCreateInfo::pPipelineStageCreationFeedbacks.

The Vulkan 1.3.225 spec says:
    An implementation should write pipeline creation feedback to
    pPipelineCreationFeedback and may write pipeline stage creation
    feedback to pPipelineStageCreationFeedbacks. An implementation must
    set or clear the VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT in
    VkPipelineCreationFeedback::flags for pPipelineCreationFeedback and
    every element of pPipelineStageCreationFeedbacks.

Components: Vulkan
VK-GL-CTS Issue: 3912
Affects:
dEQP-VK.pipeline.creation_feedback.*

Signed-off-by: Chad Versace <chadversary@google.com>
Change-Id: I4eb37b5888a4d780b4b0b12f9c65960aca9f7806

Stay within the minimum required limit for maxUniformBufferRange

The biggest one was i64vec4 which consumed 128kB. Now it fits within the
16384 byte minimum supported buffer range.

Affects:
dEQP-VK.robustness.buffer_access.vertex.*
dEQP-VK.robustness.buffer_access.fragment.*
dEQP-VK.robustness.buffer_access.compute.*

Components: Vulkan

VK-GL-CTS issue: 3776

Change-Id: Ib71dce12a346bce79a9b719e227cd6ddfb0d64b6

Added missing android hardware buffer formats

Android hardware buffer formats are added in image compression
control test. Also, updated the test names.

Components: Vulkan
VK-GL-CTS issue: 3883

Affects:
dEQP-VK.api.image_compression_control.android_hardware_buffer.*

Change-Id: I39643d186200d63a81cff2eb244bbdf085954a03

Test PGQ with disabled color output

Add variants with empty fragment shaders, attachmentless render
passes and VK_EXT_color_write_enable with and without depth stencil
attachments to the same subgroup as the existing rasterizer discard
tests.

New tests:
dEQP-VK.transform_feedback.primitives_generated_query.*.empty_frag.*
dEQP-VK.transform_feedback.primitives_generated_query.*.no_attachment.*
dEQP-VK.transform_feedback.primitives_generated_query.*.color_write_disable_*

Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*

Components: Vulkan

VK-GL-CTS issue: 2739

Change-Id: If1b6077290fddfcae704f4d0af14b82d0dde6d98

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main

Change-Id: I14e9d2f875ed566f4622dd347ecddd51856faea0

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I46fc9aef51fa742fdaf5159861d3f9f68326cf3d

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Iaf496a1c9317287562c43d586010ee9cbc744bc8

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Ib963ea274243454803090094d0ac61136ab8e998

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ibfc38c618b170dc12bcd04c2db36ed3e0e3b386a

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: If2412675c25225c696d61dec802d76ed8001180e

Fix unsupported condition in memory requirements test

This fixes parantheses to not require VK_KHR_sampler_ycbcr_conversion
extension for non-YCbCr formats

VK-GL-CTS Issue: 3902

Affects: dEQP-VK.memory.requirements.*

Components: Vulkan
Change-Id: I17c58fb1f085e7d32dea9aceb2b9e421990499a5

Fix device_memory_report test

allocation_failed test for VK_EXT_device_memory_report attempts to
allocate UINT64_MAX bytes of memory in order to deliberately trigger
an allocation failure. However, vkAllocateMemory also has VU in which
allocationSize must be less than or equal to
VkPhysicalDeviceMemoryProperties::memoryHeaps[memindex].size .

VK-GL-CTS issue: 3775

Components: Vulkan

Affects:
dEQP-VK.memory.device_memory_report.vk_device_memory.allocation_failed

Change-Id: I0b9db1beb1e7b01d369d5ee6bbfb93c2eb3e1c97

Fix undefined behaviour by allowing NaNs

One graphicsfuzz test contains computations with the float constant 0x1.8p+128.
This constant represents a NaN value. The computation with undef in the test
allows any optimization/triggers undefined behavior and the driver is free
to crash. Adding OpExecutionMode %4 SignedZeroInfNanPreserve 32 to the CTS fixes
this by allowing NaNs.

Affects:
dEQP-VK.graphicsfuzz.cov-instruction-simplify-atanh-log-undefined

Components: Vulkan

VK-GL-CTS issue: 3787

Change-Id: I2442bc4f50add8b8f779dbfae3c5fe2be8fd85f4

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Id9e93b66b2242c3b789e5742b84432c1ba8b355e

Remove non-compliant event wait test

Removed tests:
dEQP-VK.api.command_buffers.record_simul_use_primary
dEQP-VK.api.command_buffers.record_simul_use_secondary

Components: Vulkan

VK-GL-CTS issue: 3432

Change-Id: I297b53dcee56bec69e3abd3693639f64e462a574

Rework platform memory limits

Some OpenGL tests in openglcts and kc_cts used Vulkan platform class to
get the available system / device memory. The memory limits are not
Vulkan related.

This CL moves the getMemoryLimits function to the base class of all
platforms, so the functions can be accessed from openglcts without
referencing any Vulkan files.

Affects:

dEQP-VK.info.memory_limits
dEQP-VK.api.buffer.suballocation.*
dEQP-VK.api.buffer.dedicated_alloc.*
dEQP-VK.api.object_management.*
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.pipeline.render_to_image.*.small.*
dEQP-VK.pipeline.render_to_image.*.huge.*

KHR-GL4*.shader_image_load_store.advanced-*

Components:
Vulkan, OpenGL, Framework

VK-GL-CTS issue: 3360

Change-Id: I0743a83148c946d962fd793c8771f2c3c2e33ecc

Update structs and enums that were renamed in the latest spec

Some structs and enums for the video extensions were renamed

Components: Vulkan

VK-GL-CTS issue: 3905

Affected tests:
dEQP-VK.api.buffer_memory_requirements.*
dEQP-VK.api.info.get_physical_device_properties2.features.rasterization_order_attachment_access_features_ext
dEQP-VK.api.info.get_physical_device_properties2.features.amigo_profiling_features_sec
dEQP-VK.api.info.get_physical_device_properties2.features.attachment_feedback_loop_layout_features_ext
dEQP-VK.api.device_init.create_device_unsupported_features.rasterization_order_attachment_access_features_ext
dEQP-VK.api.device_init.create_device_unsupported_features.amigo_profiling_features_sec
dEQP-VK.api.device_init.create_device_unsupported_features.attachment_feedback_loop_layout_features_ext

Change-Id: Ic2e4767d1c712345d19f8c2aa890d2c2fffe3993

VK_EXT_pipeline_creation_feedback: Add indentation

No change in behavior.

Add an indentation level to some code. This prepares for the next
commit, making its diff understandable.

Components: Vulkan

Change-Id: I31e5f706ca6f05b42682a862c740bc4953a91f9b

Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main

Add dynamic rendering test for mixed inside/outside render pass commands

New test:
dEQP-VK.dynamic_rendering.basic.secondary_cmdbuffer_out_of_rendering_commands

Components: Vulkan

VK-GL-CTS issue: 3394

Change-Id: Iafebdeab6e365e376be0cf0a85af46b94836b6ca

Tests for AMD_shader_early_and_late_fragment_tests

New tests:
dEQP-VK.fragment_operations.early_fragment.*early_and_late*
dEQP-VK.fragment_shading_rate.*.fragdepth_early_late.*
dEQP-VK.fragment_shading_rate.*.fragstencil_early_late.*
dEQP-VK.pipeline.*.op_replace_early_and_late
dEQP-VK.spirv_assembly.instruction.graphics.early_and_late_fragment.*
dEQP-VK.fragment_operations.early_fragment.*early_and_late*

Affected:
dEQP-VK.fragment_operations.early_fragment.*
dEQP-VK.fragment_shading_rate.*
dEQP-VK.pipeline.fast_linked_library.shader_stencil_export.*
dEQP-VK.pipeline.monolithic.shader_stencil_export.*
dEQP-VK.pipeline.pipeline_library.shader_stencil_export.*
dEQP-VK.spirv_assembly.instruction.graphics.*
dEQP-VK.fragment_operations.early_fragment.*

Components: Vulkan
VK-GL-CTS issue: 3866

Change-Id: I279310ed8be42c3a6cd4ed83febcb6a404752a1a

Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main

Change-Id: I32263338d6ff1c7c9da96a1ed44cb418fbb27ada

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8

Change-Id: Ib61101e1c720a4f28429af20dba9554ad03dd94e

Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main" into main

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ia00eca74b753f1f88ac794c6d3664a769cfc2c6f

Fix triangle strip adjacency tests vertex ordering

OpenGL got an update where the ordering of vertices captured
by transform feedback when GL_TRIANGLE_STRIP_ADJACENCY is used
can either match the old OpenGL ordering or the new Vulkan ordering

Components: OpenGL

VK-GL-CTS issue: 3671

Affected tests:
KHR-GLES31.core.geometry_shader.*
KHR-GLES32.core.geometry_shader.*

Change-Id: I7f75b357593429110cc4517d0852b5cf2f7bb8db

Fix enabling of partially promoted extensions

Recent framework change that generates .inl files
directly from vk.xml introduced an error in which
partially promoted extensions were added to core
device extensions list. This resulted in not
enabling those extensions which lead to failure of
some tests. This change fixed this.

VK-GL-CTS issue: 3892

Components: Framework, Vulkan

Affects:
dEQP-VK.pipeline.monolithic.extended_dynamic_state.*.logic_op_or
dEQP-VK.*

Change-Id: Ieb6b9e2d469be14d30ecd86b4b112655c82e297c

Fix subpassMergeFeedback mandatory feature check

While checking subpassMergeFeedback mandatory feature test
checked presence of VK_KHR_create_renderpass2 instead of
VK_EXT_subpass_merge_feedback.

VK-GL-CTS issue: 3879

Components: Framework, Vulkan

Affects:
dEQP-VK.info.device_mandatory_features

Change-Id: Idaeb522c1bda0e07a4a0286d59ded7ca51b1c6cb

Fix aliases of aliases

Recent framework change that generates .inl files directly from
vk.xml introduced an error in which aliases of aliases were missing
from vkBasicTypes.inl. This change fixed this.

VK-GL-CTS issue: 3875

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: I98fbe520d9f611077254454721732a6142efaf06

Depth and stencil clears in dynamic rendering

Exposure of cleaning values for depth and stencil
attachments. Different values are to ensure
that corresponding attachments are using dedicated
clearing values

Components: Vulkan

VK-GL-CTS issue: 3695

Affects:
dEQP-VK.dynamic_rendering.basic.*

Change-Id: I9b833b2fa2e6e5468b63b8e1d3cd51bafbc8d709

Add support for VK_EXT_rasterization_order_attachment_access

Modify existing tests for VK_ARM_rasterization_order_attachment_access
to also run if only the EXT version of the extension is supported.

Affected tests:
dEQP-VK.rasterization.rasterization_order_attachment_access.*

Components: Vulkan

Change-Id: Ia5ad0ee82c7a2aa8fa9681a3ba0a34f6e3818059

Test clears of 3D depth/stencil images

Existing clear tests checked only 2D depth/stencil images.
This change extend these tests to exercise also 3D depth/stencil
clears. It also adds missing barrier that was reported by layers.

Components: Vulkan

VK-GL-CTS issue: 3693

Affects:
dEQP-VK.api.image_clearing.*

Change-Id: Ia84c2ef8de49f3e0db1ace2e7a59450e4d5c2202

Use multi-level multi-layer compressed image views

This test verifies whether implementations can handle multi-layer and multi-level
compressed image views of compressed images created with
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT.

Currently the specification states:
https://www.khronos.org/registry/vulkan/specs/1.3/html/vkspec.html#VUID-VkImageViewCreateInfo-image-01584
If image was created with the VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT flag,
the levelCount and layerCount members of subresourceRange must both be 1

The proposal is to only require levelCount and layerCount to be 1 when the view
uses an uncompressed format:
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5149

Affects:

dEQP-VK.image.texel_view_compatible.*

Components: Vulkan

VK-GL-CTS issue: 3749

Change-Id: I6a7cc858f4464b07fbc216547e53c961e130dd2c

Reenable texel_view_compatible 3d_image tests

These tests are disabled because they violate VUID-VkImageViewCreateInfo-image-04739.
This was removed from the spec.

See https://gitlab.khronos.org/vulkan/vulkan/-/issues/3164 for the spec issue.

Affects:

dEQP-VK.image.texel_view_compatible.*.3d_image.*
dEQP-VKSC.image.texel_view_compatible.*.3d_image.*

Components: Vulkan

VK-GL-CTS issue: 3835

Change-Id: Id513c29dd9b042d498dd0a12ca2f5d3b6257b705

Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main

Change-Id: Ife4384ed5b6c254cd4e72cc425549624f34f261d

Add CTS tests for VK_EXT_application_parameters

New tests:
dEQP-VKSC.sc.application_parameters.*

New command-line option:
--deqp-app-params-input-file=<path>

Components: Vulkan SC, Framework

VK-GL-CTS issue: 3850

Change-Id: I19807696fd3c7fccab3b7f719474c8cfaf62f766

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main

Change-Id: Ie46b51dc959d6a3c5c73e61b9698dec7dc921f5d

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I80a5e97d6ee8d7d15c8d67de7f084f7f3fd239e0

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I3dcb14db985ef75cff08dae8e346cefd7a27ff19

Adds reset watchdog timer to timeline sempahore tests

Tests go through many iterations which exceeds test
max time when matchdog timer is enabled

Components: Vulkan
VK-GL-CTS Issue: 3884

Affects:
dEQP-VK.synchronization*.basic.timeline_semaphore.chain

Change-Id: Id257b7162d49cfaf5b78c198cdc932f74c0d4a2b

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I1be609e78cf12d03a7db1430364c332ec1ac37ae

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: If088fd987f51bff07712612cfc9672f1cddd1df6

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I17c7fc7a6c0dde2555e90873105027b0f26e94ad

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Ia1e9c64b9149680d40e6c2deff9e64725c227439

Improve the error message when storing uncomressed images fails.

It's been ambiguous since the output doesn't have any information when
storing an uncompressed image fails.

Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.*

Components: Vulkan

VK-GL-CTS issue: 3897

Change-Id: I923efb15a9927c87c581dc3c96115b5d6c0b2580

Fix loop continue construct for SPIR-V assembly

The multi-block continue construct tests were setting the continue
target to the loop header itself, which is not valid according to the
new structural dominance rules. Set it to the first block inside the
loop instead, which still gives a multi-block continue construct but
also follows the validation rules.

Components: Vulkan
VK-GL-CTS issue: 3896
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.loop.multi_block_continue_construct_*

Change-Id: I7480f6107696ec8587625bfa110aa7478308512f

Fix SPIRV validation for decoration tests

The decoration matching tests were incorrectly using Flat and
NoPerspective decoration on vertex inputs. The validator has been
updated to catch these errors, so the tests now cause an InternalError.

Compoennts: Vulkan
VK-GL-CTS issue: 3895
Affects: dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.flat
         dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.no_perspective
         dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.flat
         dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.no_perspective

Change-Id: I818868ca87d15d068430e9721204be620b28e225

Fixes arrays of arrays tests

Tests were requiring more ssbos in shaders
than what the implementation supports

VK-GL-CTS Public Issue: 324
Components: OpenGL

Affects either:
KHR-GL46.arrays_of_arrays_gl.InteractionInterfaceArrays1
or
KHR-Single-GL46.arrays_of_arrays_gl.InteractionInterfaceArrays1
depending on branch.

Change-Id: I8664e7b85ff78b93aeb52c4e0739a4cc3c14e6aa

Run DR tests with secondary command buffers

dynamic_rendering tests were replaced with three sub groups:
primary_cmd_buff, partial_secondary_cmd_buff and
complete_secondary_cmd_buff.
* primary_cmd_buff subgroup contains previously existing dynamic
rendering tests where drawing is done in primary command buffer.
* partial_secondary_cmd_buff contains tests where drawing commands
are recorded in secondary command buffer but begin/endRendering
are recorded to primary command buffer.
* complete_secondary_cmd_buff executes tests using secondaries that
completely contain the dynamic render pass.

Components: Vulkan

VK-GL-CTS issue: 3516

Affects:
dEQP-VK.dynamic_rendering.*
dEQP-VK.renderpass*

Change-Id: Id640e0fb8f6e9382d48844d3cdee4a7e040eb609

Fix division by zero in glsBuiltinPrecisionTests

GLSL precision tests were using 1 / InverseSqrt(x) to calculate
reference values for square root. This is problematic when x = 0,
as it causes a division by zero.

VK-GL-CTS Issue: 3330

Affects:

dEQP-GLES3*.functional.shaders.builtin_functions.precision.*

Components: OpenGL ES
Change-Id: I199f16b2eeb66ab042f0bb1ab6b588246efeb6d5

Merge vk-gl-cts/dev/VK_EXT_attachment_feedback_loop_layout into vk-gl-cts/main

Change-Id: Ic7fcede2a0f71c344a41e76cbb1e9cd68301dfb8

Merge vk-gl-cts/main into vk-gl-cts/dev/VK_EXT_attachment_feedback_loop_layout

Change-Id: Ieb2f535a96807e0d1fcd8ca6a84cac46651fc8f3

Fix barrier VK_AMD_buffer_marker

Affected tests:
dEQP-VK.api.buffer_marker.*

Components: Vulkan
VK-GL-CTS issue: 3854

Change-Id: Ia65c7ec44db3019125012b7d7e2d1b65e0f942f6

Update Amber to fix Clang 11 build

Building Amber with Clang 11 failed due to -Werror and several
-Wsuggest-destructor-override warnings.

Affects: dEQP-VK.*

VK-GL-CTS issue: 2628

Change-Id: Ibae8dbc955d32bb50eb6f5c26cd62579bc6967dd

Update Amber

Components: Framework
Affects: dEQP-VK.*

Change-Id: I0bb5016b2ec063396cd797060e14d6de474b96af

Update Amber to fix regression

Affects:

dEQP-VK.glsl.combined_operations.*
dEQP-VK.compute.basic.write_ssbo_array
dEQP-VK.draw.output_location.array.*
dEQP-VK.graphicsfuzz.*
dEQP-VK.pipeline.vertex_only.position_to_ssbo
dEQP-VK.rasterization.provoking_vertex.*
dEQP-VK.rasterization.line_continuity.*
dEQP-VK.spirv_assembly.*
dEQP-VK.texture.conversion.*
dEQP-VK.texture.multisample.*
dEQP-VK.texture.subgroup_lod.*
dEQP-VK.texture.texel_buffer.*

Components: Vulkan

VK-GL-CTS issue: 2443

Change-Id: I3c6ec1eb0ee8695468c54f95c210cc81b50a4f1a

Add test for writing to an SSBO array

VK-GL-CTS Issue: 2285

New tests:

dEQP-VK.compute.basic.write_ssbo_array

Components: Vulkan
Change-Id: I6650aa1e087a5fb3c2bdad5eb3788b944faf996e

Add modfStruct comparison tests

Add tests for comparing the output of modf and modfStruct with 32-bit floats
and vectors as input. Update Amber and implement delegate for loading buffers
from files in AmberScript.

New tests:
dEQP-VK.spirv_assembly.instruction.*.float32.comparison_*.modfstruct*

Components: Vulkan

VK-GL-CTS issue: 1728

Change-Id: If2ee37779472be543038bae313792e2367051bdf

Fix Fedora 32 gcc/clang warnings

Component: AOSP, OpenGL, Vulkan

VK-GL-CTS issue: 2350

Affects:
KHR*direct_state_access.vertex_arrays*
KHR*core.arrays_of_arrays.sized_declarations_invalid*
dEQP-VK.geometry.*

Change-Id: I55680ac671d0610917d45f7187deec6e883dd6b7

Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main

Change-Id: Idb23c14d0c59ef6dd554b27ecca20ee9dfdbcb0c

Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2

Change-Id: I621d54886cc3e3521d3e02f456017abad2085796

Add missing checks for update after bind support

Some descriptor_copy tests use update-after-bind without checking
the corresponding field of VkPhysicalDeviceDescriptorIndexingFeatures.

Affects: dEQP-VKSC.binding_model.descriptor_copy.*

Components: Vulkan, VulkanSC
Change-Id: I3cfefda0b118bb05d210c47dbcf504a9a985c123

Add coverage for MaxAtomicCounterBufferSize

Test if placing an atomic counter into a buffer
at such an offset that the buffer is too large results
in a compilation error.

Components: OpenGL

VK-GL-CTS issue: 3124

Affects:
KHR-GL42.shader_atomic_counters.negative-large-offset
KHR-GLES31.core.shader_atomic_counters.negative-large-offset

Change-Id: Ib1ea21f2c1035d0a86ab2d4b3e4260756c88bfba

Check that image*Shadow are not reserved keywords

There used to be a tests that treated: image1DShadow, image2DShadow,
image1DArrayShadow, image2DArrayShadow as reserved keywords but they
were removed because the spec doesn't actually reserve them. Any
drivers that were passing the old test were behaving incorrectly so
this change adds new tests that check if these keywords are not
reserved.

Components: OpenGL ES

VK-GL-CTS issue: 3007

Affects:
dEQP-GLES3.functional.shaders.keywords.allowed_keywords.*

Change-Id: Ic6b4463e51b45611441481d661d71735570dd15a

Fix vkGetPhysicalDeviceProperties2 query

Recent framework change added few invalid structures to
pNext chain of vkGetPhysicalDeviceProperties2.

VK-GL-CTS issue: 3872

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: Iae75d84e454ee4c55ae31db3ea0b756574747066

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main

Change-Id: Iaa17ebf16e629e5d5c221511fbd198d392dd92d5

Check device and group indices before using them

dEQP-VK.info.device_group_peer_memory_features was using the device and
group indices without checking if they were valid first for the array of
reported physical device groups.

Affects:
dEQP-VK.info.device_group_peer_memory_features

Components: Vulkan
VK-GL-CTS issue: 3873

Change-Id: I2601e74158496f0ee7ec1cdb42af2faf1c587216

Remove invalid depth stencil resolve tests

Tests where both depthResolveMode and stencilResolveMode are
VK_RESOLVE_MODE_NONE are invalid as they violate VUID 03178

Components: Vulkan

VK-GL-CTS issue: 3798

Affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*

Change-Id: I06b9bd5207cd9d119ff2aa3877edaf7fd472bde2

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I36762c268b845c6acb978ea9bfdafac065ecaa59

Added valid vertex geometry to PGQ tests

Undefined output of VS causes AMD HW to cull such primitives.
Added valid vertex geometry to PGQ tests to avoid such culling.

Affects:
dEQP-VK.transform_feedback.primitives_generated_query*

Components: Vulkan

VK-GL-CTS issue: 3830

Change-Id: Ibc3cde7c2c490a72eedd95b30e5db7a57c30cf86

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ia6467ac46eff3121b5bff009e333896eca33aa60

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I5f375b6bff37ba08cc50312cfa343687d0c47100

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ie7efa23462961766664d6368f320b20e2c78ae2b

Use correct render target format in YCbCr view tests

For render target use the same format type as plane
compatibility format

Components: Vulkan

VK-GL-CTS issue: 3601

Affected tests:
dEQP-VK.ycbcr.plane_view.image_view.*

Change-Id: I7f03c90069b21a6ea84c6ee9d6d85c31cee3e3ad