Konstantin Baladurin [Fri, 12 Jan 2018 08:46:48 +0000 (11:46 +0300)]
dllimportcallback: remove code for CallbackOnCollectedDelegate MDA
Commit migrated from https://github.com/dotnet/coreclr/commit/
f2e52524fe421ac050b8a693438f662b40214074
Konstantin Baladurin [Fri, 12 Jan 2018 15:55:10 +0000 (18:55 +0300)]
UMEntryThunk: store freed thunks into FIFO free list
Use free list to delay reusing deleted thunks. It improves
collected delegate calls diagnostic.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b0a10f69a85404bcc9c377c80dc2950f927f8731
Konstantin Baladurin [Wed, 10 Jan 2018 15:26:01 +0000 (18:26 +0300)]
Improve UMEntryThunkCode::Poison method.
Improve UMEntryThunkCode::Poison to produce diagnostic message
when collected delegate was called.
Commit migrated from https://github.com/dotnet/coreclr/commit/
28839fc0b2dcaf89b7217741291c8c3f578f38a0
dotnet-maestro-bot [Fri, 12 Jan 2018 20:38:25 +0000 (14:38 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26112-01, preview1-26112-01, master-
20180112-0034, respectively (dotnet/coreclr#15837)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f2ef496c87c7ba66f54390d9b5cc08f863183b2f
Jarret Shook [Fri, 12 Jan 2018 15:36:03 +0000 (07:36 -0800)]
Merge pull request dotnet/coreclr#15815 from jashook/fix_helix_publish
Fix overwriting os/arch when publishing to helix
Commit migrated from https://github.com/dotnet/coreclr/commit/
140ba024bf6edb61744fe6b84bd635d389fe1413
jashook [Wed, 10 Jan 2018 18:52:27 +0000 (10:52 -0800)]
Fix overwriting os/arch when publishing to helix
Commit migrated from https://github.com/dotnet/coreclr/commit/
ed7cab5604c1bf49ea74f4b82c08eb0da41df64c
Michelle McDaniel [Fri, 12 Jan 2018 15:31:56 +0000 (07:31 -0800)]
Convert run-xunit-perf to py script (dotnet/coreclr#15568)
* Convert run-xunit-perf to python script
This change merges the two run-xunit-perf scripts (.sh and .cmd) into
one unified python script and updates the pipeline job to use the
pythong script. This change also updates the linux jobs to use the new
build-tests.sh generatelayoutonly command so that we don't need to pull
down corefx from the cloud anymore. The unified python script enables us
to more easily update both linux scripting and windows scripting at the
same time so that one does not lag behind the other (such as when we add
new configurations or options like slicing). This change also turns
linux testing back on by default for PRs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5378afc7c2406074972c415a2ccabfc43273db49
Bruce Forstall [Fri, 12 Jan 2018 07:27:20 +0000 (23:27 -0800)]
Merge pull request dotnet/coreclr#15835 from BruceForstall/FixGCKeepAlive
Fix GC.KeepAlive test case
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d6da797d1f7dc47d5934189787a4e8006ab3a04
Bruce Forstall [Fri, 12 Jan 2018 07:26:02 +0000 (23:26 -0800)]
Merge pull request dotnet/coreclr#15832 from BruceForstall/DisableNoGCInStress
Disable NoGC test in GCStress test runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
57ea03473769229286f42af655a8ce916ba9f072
dotnet-maestro-bot [Fri, 12 Jan 2018 02:01:15 +0000 (20:01 -0600)]
Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02411-04, preview1-26111-02, preview1-26111-02, master-
20180111-0041, respectively (dotnet/coreclr#15807)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b3a9220143791efb7ff585fffb4c1704fc86b6ec
Sean Gillespie [Fri, 12 Jan 2018 00:43:03 +0000 (16:43 -0800)]
[Local GC] Introduce standalone eventing design document (dotnet/coreclr#15570)
* Typing
* First draft
* Update the doc based on feedback
* Next iteration based on feedback
* Iteration feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
50dd8346635c61efa9b0aaf121a888c9c93b3c66
Bruce Forstall [Fri, 12 Jan 2018 00:22:55 +0000 (16:22 -0800)]
Fix GC.KeepAlive test case
In the test, as written, a GC could sneak in between the GC.KeepAlive()
call and the subsequent line that checks whether the finalizer
has run, especially in GC stress modes. Simply move the GC.KeepAlive()
call down.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d087b29b9f68db08e6606a50d8ce2e80fe156dbf
Bruce Forstall [Thu, 11 Jan 2018 23:28:52 +0000 (15:28 -0800)]
Disable NoGC test in GCStress test runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff60c21fb2c963139bd04f8e36eb649d8932c519
Carol Eidt [Thu, 11 Jan 2018 18:19:40 +0000 (10:19 -0800)]
Merge pull request dotnet/coreclr#15791 from dotnetrt/dstdstsrc
Refactor emitter::IsDstDstSrcAVXInstruction and emitter::IsDstSrcSrcAVXInstruction
Commit migrated from https://github.com/dotnet/coreclr/commit/
66bd34e16bc9058263a2c5cd522ee6b59e1b4419
Jacek Blaszczynski [Thu, 11 Jan 2018 17:33:32 +0000 (18:33 +0100)]
[Infrastructure/Win] Add C++ header files to Visual Studio clrjit project (dotnet/coreclr#15775)
* Add C++ header files to Visual Studio clrjit project
* Add comment about script change impact and usage
Commit migrated from https://github.com/dotnet/coreclr/commit/
82f2576ef4de9f202a7dffd5a388b94a28e34bfd
Jacek Blaszczynski [Thu, 11 Jan 2018 12:29:26 +0000 (13:29 +0100)]
movhlps categorized as dstdstsrc
Commit migrated from https://github.com/dotnet/coreclr/commit/
90f1918d672eec9cea327c20a7a40ac96b318af1
Ben Adams [Thu, 11 Jan 2018 09:10:35 +0000 (09:10 +0000)]
Allow CALLEE_IS_FORCE_INLINE precedent over CALLEE_DOES_NOT_RETURN (dotnet/coreclr#14586)
Allow CALLEE_IS_FORCE_INLINE precedent over CALLEE_DOES_NOT_RETURN
Commit migrated from https://github.com/dotnet/coreclr/commit/
c459b52c0f300860bb877b46165018a882e8ee99
dotnet bot [Thu, 11 Jan 2018 08:56:01 +0000 (00:56 -0800)]
Keep LowLevelDictionary for CoreRT for now (dotnet/coreclr#15824)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
d97e8854e0d2e7bbc8c549a68d9592c1dbc5ac4e
Ben Adams [Thu, 11 Jan 2018 07:58:00 +0000 (07:58 +0000)]
Improve performance for Math.Abs (dotnet/coreclr#15823)
* Improve perf for Math.Abs
* Inline Math.Abs
Commit migrated from https://github.com/dotnet/coreclr/commit/
288bd46585fb5334eac31b285eba64e17831df72
Jan Kotas [Thu, 11 Jan 2018 06:06:28 +0000 (22:06 -0800)]
Fix Obsolete on ReadOnlySpan Equals and GetHashCode methods (dotnet/coreclr#15820)
* Fix Obsolete on ReadOnlySpan Equals and GetHashCode methods
* Delete unnecessary CLSCompliant attribute
Commit migrated from https://github.com/dotnet/coreclr/commit/
8266cbcf4563011b3a6686405f2fd56964123506
Carol Eidt [Thu, 11 Jan 2018 03:57:16 +0000 (19:57 -0800)]
Merge pull request dotnet/coreclr#15814 from CarolEidt/FixObj
Fix change to fgMorphBlockOperand
Commit migrated from https://github.com/dotnet/coreclr/commit/
20010ab1f8ec0caa413305b72bb8ba80449be503
Carol Eidt [Tue, 9 Jan 2018 23:56:25 +0000 (15:56 -0800)]
Fix change to fgMorphBlockOperand
My recent fix broke the `DYN_BLK` case. In addition to checking that types match, we *still* need to check that the sizes match.
This was caught by desktop testing. The test cases are somewhat complex, so I created a smaller repro.
Commit migrated from https://github.com/dotnet/coreclr/commit/
06055495d96093502deae21c33134338229f6554
Victor "Nate" Graf [Wed, 10 Jan 2018 23:25:34 +0000 (15:25 -0800)]
Fix incremental build by preventing nonchanging writes (dotnet/coreclr#15817)
Fix incremental build by preventing non-changing writes in generated ETW source code
Commit migrated from https://github.com/dotnet/coreclr/commit/
e275d2dfe18ad1f7db9c35220283001a81a7c669
Jarret Shook [Wed, 10 Jan 2018 21:06:39 +0000 (13:06 -0800)]
Merge pull request dotnet/coreclr#15784 from fiigii/hwci
Add new CI mode for Intel HW intrinsics
Commit migrated from https://github.com/dotnet/coreclr/commit/
240c607d3f5dcea6fa6aa642a4d9584e3b06b738
Atsushi Kanamori [Wed, 10 Jan 2018 20:32:07 +0000 (12:32 -0800)]
Underlying CoreCLR support for new string slicing overloads (dotnet/coreclr#15811)
* Underlying CoreCLR support for new string slicing overloads
https://github.com/dotnet/corefx/issues/25254
These add the underlying support for the fast versions of
these extension methods.
* Underlying CoreCLR support for new string slicing overloads
https://github.com/dotnet/corefx/issues/24072
These add the underlying support for the fast versions of
these extension methods.
Commit migrated from https://github.com/dotnet/coreclr/commit/
da46977d76051ba94fb21a9d25f45a41ceac07de
chcosta [Wed, 10 Jan 2018 19:48:17 +0000 (11:48 -0800)]
Add privaterun properties (dotnet/coreclr#15816)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a63990ce5eed402b24b8b7c696c499065cf4e2e5
Jan Kotas [Wed, 10 Jan 2018 13:35:39 +0000 (05:35 -0800)]
Move System.Globalization.CultureData to shared CoreLib partition (dotnet/coreclr#15805)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8719e73302f427dcb6332a6ba74e3c541577d560
dotnet-maestro-bot [Wed, 10 Jan 2018 05:45:09 +0000 (23:45 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26109-03, preview1-26110-01, master-
20180109-0023, respectively (dotnet/coreclr#15788)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef42ec4274c69fb6fb617cfc836c50ecf3ac6072
Tarek Mahmoud Sayed [Wed, 10 Jan 2018 05:08:34 +0000 (21:08 -0800)]
Port servicing fix (dotnet/coreclr#15802)
* Port the servicing fix
This is porting the servcing fix https://github.com/dotnet/coreclr/commit/dotnet/coreclr@
8ce622d569fae9feb160399db03dc2b86577be1b with a small change to get rid of unsafe code in CultureData per Jan recommendation
* remove un-needed lines
* rename the variable name as it is not a pointer anymore
Commit migrated from https://github.com/dotnet/coreclr/commit/
dce9085e36908c076417ae56b5b8ce69480a29f2
Fei Peng [Wed, 10 Jan 2018 00:57:07 +0000 (16:57 -0800)]
Add new CI mode for Intel HW intrinsics
Commit migrated from https://github.com/dotnet/coreclr/commit/
2267b5d8675b7316d32a14c76ee992a2aac4a123
Jan Kotas [Wed, 10 Jan 2018 00:37:42 +0000 (16:37 -0800)]
Update the document for netcoreapp2.1
Commit migrated from https://github.com/dotnet/coreclr/commit/
a2336484d07c904ac93c894d32e6a4c521788aae
Jan Kotas [Wed, 10 Jan 2018 00:22:19 +0000 (16:22 -0800)]
Update links to nightly .NET Core SDK builds (dotnet/coreclr#15799)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f5896223846cdb13745497cc9b6a449006bf73b
Carol Eidt [Wed, 10 Jan 2018 00:00:14 +0000 (16:00 -0800)]
Merge pull request dotnet/coreclr#15724 from sdmaclea/PR-ARM64-VECTOR64
[Arm64] Add Vector64 HW Intrinsic support
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ee10283292a11a0480773194168f44d9c3e9fd4
Anirudh Agnihotry [Tue, 9 Jan 2018 23:30:29 +0000 (15:30 -0800)]
Adds StringBuilder.Equals(ReadOnlySpan<char>) Api (dotnet/coreclr#15759)
Adds StringBuilder.Equals(ReadOnlySpan<char>) Api
Commit migrated from https://github.com/dotnet/coreclr/commit/
55bb222db872ef42ae771967ba45d94326f34d73
Jacek Blaszczynski [Tue, 9 Jan 2018 21:58:00 +0000 (22:58 +0100)]
Address review feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
90e017eb85c9e1c87ad19bcf785113ba45b5d72f
Fei Peng [Tue, 9 Jan 2018 19:58:53 +0000 (11:58 -0800)]
fix corefx/dotnet/coreclr#26230 (dotnet/coreclr#15792)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2bb0fedb21d09c6982259fffdcdbef839afe1838
José Rivero [Tue, 9 Jan 2018 15:46:39 +0000 (07:46 -0800)]
Fixing https://github.com/aspnet/JitBench/issues/80 (dotnet/coreclr#15764)
- Issue was fixed with this: https://github.com/aspnet/JitBench/pull/82
- Set the UseSharedCompilation=false to avoid that the `VBCSCompiler.exe` stays running.
Commit migrated from https://github.com/dotnet/coreclr/commit/
064136ca259dcf47dc8cb34516a44ba057eb01f1
Jacek Blaszczynski [Tue, 9 Jan 2018 14:31:46 +0000 (15:31 +0100)]
Refactor emitter::IsDstDstSrcAVXInstruction function implementation
Commit migrated from https://github.com/dotnet/coreclr/commit/
1deda46cefeb4915582fdc65324e95c92a78aec7
dotnet-maestro-bot [Tue, 9 Jan 2018 05:53:35 +0000 (23:53 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26108-06, preview1-26109-01, master-
20180108-1624, respectively (dotnet/coreclr#15785)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4e6435be1f5a77abb875f946fa7bd5dbeb5c3864
dotnet-maestro-bot [Tue, 9 Jan 2018 00:33:25 +0000 (18:33 -0600)]
Update BuildTools, CoreClr, CoreFx to prerelease-02408-01, preview1-26108-02, preview1-26108-02, respectively (dotnet/coreclr#15763)
Commit migrated from https://github.com/dotnet/coreclr/commit/
334dd046627c9a4a9375a2c887c2a45c846b36db
Mike McLaughlin [Tue, 9 Jan 2018 00:13:27 +0000 (16:13 -0800)]
Fixed superpmi JIT debugging on desktop build. (dotnet/coreclr#15773)
Commit migrated from https://github.com/dotnet/coreclr/commit/
da381a716cc9a39897de45a764326ec10c3191f1
Fei Peng [Mon, 8 Jan 2018 20:40:24 +0000 (12:40 -0800)]
Update Intel hardware intrinsic APIs (dotnet/coreclr#15601)
- add missing APIs
- fix generic names
- fix comments
- disambiguate with `using static`
Commit migrated from https://github.com/dotnet/coreclr/commit/
cab0db6345a7941f75d991281bcc0079d28ba182
Andy Ayers [Mon, 8 Jan 2018 16:44:14 +0000 (08:44 -0800)]
JIT: improve return types in cases with spill temps (dotnet/coreclr#15766)
If the jit sees that an inlinee has multiple return sites or has gc ref locals
it will choose to return the inline result via a temp. The jit was not assigning
a type to that temp and so losing track of some type information.
So, for inlinees returning ref types, initially type the return spill temp with
the declared return type of the method.
When importing we may discover that particular return sites will return more
specific types. If all discovered return sites agree, we can update the return
type for the spill temp to match the consensus improved type.
This can lead to removal of some type checks and also to devirtualization.
Addresses issues discussed in dotnet/coreclr#9908 and dotnet/coreclr#15743.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a76445568d42b9b7d37d9f6e94ec47393179585e
Tanner Gooding [Sun, 7 Jan 2018 20:28:14 +0000 (12:28 -0800)]
Merge pull request dotnet/coreclr#15772 from tannergooding/hwintrin-expand
Updating the x86 HWIntrinsic importer to not inline when returning gtNewMustThrowException
Commit migrated from https://github.com/dotnet/coreclr/commit/
d36b8e18fa0e1f81a176174e0413c368f2743297
Tanner Gooding [Sat, 6 Jan 2018 17:07:08 +0000 (09:07 -0800)]
Updating the x86 HWIntrinsic importer to not inline when returning gtNewMustThrowException
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d910b40c09e311d88aad742e08c8d4186b17ace
Jan Kotas [Sat, 6 Jan 2018 17:14:22 +0000 (09:14 -0800)]
Move types to shared corelib partition (dotnet/coreclr#15768)
- YieldAwaitable: Fixed readonly mismatch
- Comparer: Made public to fix https://github.com/dotnet/corefx/issues/25973
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c254c4085328511225e267c541561405f6916c3
Justin Van Patten [Sat, 6 Jan 2018 17:12:16 +0000 (09:12 -0800)]
Cleanup Activator (dotnet/coreclr#15767)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1d8831b8c6b66b9607972c27a36c989649aeaa1
Brian Sullivan [Sat, 6 Jan 2018 04:17:25 +0000 (20:17 -0800)]
Merge pull request dotnet/coreclr#15756 from briansull/fix-15671
Fix for 15671
Commit migrated from https://github.com/dotnet/coreclr/commit/
180a3c80b1d193f4c63b265e21bd29277b81cbcd
Mike McLaughlin [Sat, 6 Jan 2018 02:14:21 +0000 (18:14 -0800)]
Change just-in-time debugging registry keys. (dotnet/coreclr#15722)
From "SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug" to "SOFTWARE\Microsoft\.NETCore\JITDebugging".
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b2cac974db3edde38e1a555455f53592d03b68e
Sergey Andreenko [Sat, 6 Jan 2018 02:11:39 +0000 (18:11 -0800)]
ARM r2r fix. (dotnet/coreclr#15758)
Do not trash CALLEE_SAVED register r4.
Use r12 that is CALLEE_TRASH.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c226c48f42438e0742ff9293fbfb4d5c7a1e864
Andy Ayers [Sat, 6 Jan 2018 01:47:09 +0000 (17:47 -0800)]
JIT: fix decompose long left shift for overshift cases (dotnet/coreclr#15704)
Need to reduce the shift amount modulo 64 to match the helper and
`gtFoldExpr` behavior. Since reduced amount must be less than 64
we can remove handling for that case.
Also updating the arm LLSH helper.
Re-enable the test case disabled by dotnet/coreclr#15567 and also enable for arm/arm64.
Closes dotnet/coreclr#15566.
Commit migrated from https://github.com/dotnet/coreclr/commit/
16246c9117aa456eb0786d4e23e827dce585b6c0
Brian Sullivan [Sat, 6 Jan 2018 01:34:21 +0000 (17:34 -0800)]
Proposed fix for 15671
If we are fetching an Array Length for an array ref that came from global memory
then for CSE safety we must use the conservative value number for both
Commit migrated from https://github.com/dotnet/coreclr/commit/
89e64081a058ee0318da8ba236bf98bc53c5574e
Jan Kotas [Sat, 6 Jan 2018 01:14:09 +0000 (17:14 -0800)]
Simplify and unify EnumCalendars interop (dotnet/coreclr#15762)
Windows was not allocating GCHandles, switch Unix to do the same.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f4510d4db515b49015a961d335facd3e59b8614
Tanner Gooding [Sat, 6 Jan 2018 00:51:01 +0000 (16:51 -0800)]
Merge pull request dotnet/coreclr#15639 from tannergooding/expand-hwintrin
Updating Compiler::impIntrinsic to always expand hardware intrinsics.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6f79b79f4e33a029bf1d993b2d7e9b108aa3ff72
Andy Ayers [Sat, 6 Jan 2018 00:41:02 +0000 (16:41 -0800)]
JIT: fix issue with inline observations (dotnet/coreclr#15713)
In DEBUG/CHECK builds the jit tries to keep track of failed inlines.
Because inlines can be rejected "early" (when the parent method
is being imported) as well as "late" (when their call site is encountered
by the inliner) there is a tracking mechanism to convey the early observations
that cause failures to be resurrected later on.
These observations sometimes didn't end up in the inline context, leading
to assertions when dumping methods.
Fix is to add a new way to propagate the earlier observation to the context
that bypasses some of the policy sanity checks and simply record the reason
that the inline failed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a46475cdacca8beeb02193c2298f1df62328a317
Brian Sullivan [Sat, 6 Jan 2018 00:38:04 +0000 (16:38 -0800)]
Merge pull request dotnet/coreclr#15760 from briansull/fix-budget
Fix issue where the unsigned value used for the the VN map select budget could underflow
Commit migrated from https://github.com/dotnet/coreclr/commit/
a91d3fd660568a53a9395ef5d0eeaf869e56606a
Carol Eidt [Sat, 6 Jan 2018 00:22:13 +0000 (16:22 -0800)]
Merge pull request dotnet/coreclr#15716 from CarolEidt/RefactorMinRegCount
Refactor minRegCount and eliminate auto
Commit migrated from https://github.com/dotnet/coreclr/commit/
16b7c1420c08aebc594242733f4db3210af8033b
Carol Eidt [Thu, 4 Jan 2018 02:55:17 +0000 (18:55 -0800)]
Refactor minRegCount and eliminate auto
When building RefPositions in the TreeNodeInfoInit methods, it is very complex and messy to have the setting of the (debug-only) `minRegCandidateCount` spread all over. Instead, set them for all the RefPositions for a given node after they have been created.
This required the ability to create an iterator marking the end of the list, prior to creating the new ones.
In the process, eliminated the use of auto from lsra.cpp in the interest of strong typing, as well as avoiding the confusion of having things with `RefPosition` in their name that are actually iterators.
These changes originally caused failures with JitStressRegs because `getKillSetForNode()` had side effects - generating Kill `RefPosition`s for `MOD` & `DIV`. This is not actually necessary, and causes problems when the debug-only stress code was calling it *after* all the `RefPosition`s had been created. Also, this had the weird (existing) effect that duplicate kill `RefPosition`s were being generated in the stress case!
Commit migrated from https://github.com/dotnet/coreclr/commit/
a1c324833712ef0a1ba62cd88ec5d41b9f55092d
Brian Sullivan [Fri, 5 Jan 2018 19:43:42 +0000 (11:43 -0800)]
Fix issue where the unsigned value used for the the map select budget could underflow
resulting in an unlimited budget
Changed m_mapSelectBudget and budget to be a signed integer
Added an assert that ensures that the remaining budget is between [0..m_mapSelectBudget]
Change the test for running out of budge to be a <= zero test instead of an equal zero test.
Fixed the bug in the handling of phiArgs in VNForMapSelectWork
by adding a check if we exceeded our budget when processing the first phiArg.
Added a define for DEFAULT_MAP_SELECT_BUDGET
Commit migrated from https://github.com/dotnet/coreclr/commit/
3fc07ad6ffcb49646d629ba63b6f156a7071c2eb
Justin Van Patten [Fri, 5 Jan 2018 22:53:21 +0000 (14:53 -0800)]
Cleanup AppDomain (dotnet/coreclr#15748)
Remove dead code and various cleanup.
Commit migrated from https://github.com/dotnet/coreclr/commit/
60ba4751a4bab0651db356af1b269bc5d96822c5
Jan Kotas [Fri, 5 Jan 2018 22:44:18 +0000 (14:44 -0800)]
Detect ByRefLike types using attribute (dotnet/coreclr#15745)
* Detect ByRefLike types using attribute and improve error messages for their invalid use
Fixes dotnet/coreclr#11371 and dotnet/coreclr#15458
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c12105bb8cc1821ba5d5c3d36aad609a44308e0
Sergey Andreenko [Fri, 5 Jan 2018 22:41:40 +0000 (14:41 -0800)]
fix COMPlus_JitHalt for arm32. (dotnet/coreclr#15761)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a785420a57925d1ea67fa9361e1f826a7e74f2b
dotnet-maestro-bot [Fri, 5 Jan 2018 19:53:37 +0000 (13:53 -0600)]
Update BuildTools, CoreClr, CoreFx to prerelease-02404-02, preview1-26105-01, preview1-26105-01, respectively (dotnet/coreclr#15736)
Commit migrated from https://github.com/dotnet/coreclr/commit/
23ada7df49d3717c70635164864e3c0e6bb11162
Justin Van Patten [Fri, 5 Jan 2018 06:10:46 +0000 (22:10 -0800)]
AggregateException: Use StringBuilder.AppendFormat (dotnet/coreclr#15747)
Use `AppendFormat(...)` instead of `Append(string.Format(...))` and
`AppendLine()` instead of `Append(Environment.NewLine)`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
41d23b05acac98c68d3b348c60bf151cfedd778f
Justin Van Patten [Fri, 5 Jan 2018 04:43:20 +0000 (20:43 -0800)]
Unix: Specify Ordinal comparison in TimeZoneInfo (dotnet/coreclr#15739)
The default behavior for StartsWith uses the current culture for
comparisons. These should be ordinal.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2e86cf5e7b891ca2b4fac83c0c9511c83c4ede2
Justin Van Patten [Fri, 5 Jan 2018 04:42:58 +0000 (20:42 -0800)]
Address ReflectionTypeLoadException feedback (dotnet/coreclr#15738)
* Address ReflectionTypeLoadException feedback
Address additional minor feedback from dotnet/coreclr#15711:
- Share the code for `Message` and `ToString`
- Remove trailing `NewLine` from resulting string
- Pass initial base string to `StringBuilder..ctor`
- Cache the exceptions array in a local (passed-in as a parameter)
- Move methods below properties
- Remove trailing whitespace
Commit migrated from https://github.com/dotnet/coreclr/commit/
6faa6bb6de44693b7da95c61c0f22df89ef8e373
Justin Van Patten [Fri, 5 Jan 2018 04:42:28 +0000 (20:42 -0800)]
Use string.Contains(char) instead of Contains(string) (dotnet/coreclr#15740)
Now that string.Contains(char) exists, use it in corelib.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a24f196ef4d792b2ee1b397786419c8bad6e070a
Maryam Ariyan [Fri, 5 Jan 2018 04:23:39 +0000 (23:23 -0500)]
Adding EnsureCapacity implementation for Dictionary (dotnet/coreclr#15729)
Adding EnsureCapacity implementation for Dictionary
Commit migrated from https://github.com/dotnet/coreclr/commit/
391be015430d213365a1a5d09230f99f24a80de3
Tanner Gooding [Fri, 5 Jan 2018 04:14:03 +0000 (20:14 -0800)]
Updating the existing HWIntrinsic tests to also test indirect calling via reflection.
Commit migrated from https://github.com/dotnet/coreclr/commit/
eaeb4d39ead6004de4734b7dc8bac5b25a29224f
Sung Yoon Whang [Fri, 5 Jan 2018 02:04:07 +0000 (18:04 -0800)]
Update profiling API status (dotnet/coreclr#15659)
* Update profiling API status
* Fix wording for ARM ReJIT issue
Commit migrated from https://github.com/dotnet/coreclr/commit/
2efb857f0e904f829e71597875409abd0717fc48
Sung Yoon Whang [Fri, 5 Jan 2018 01:54:29 +0000 (17:54 -0800)]
Remove duplicate callback to AppDomainCreationFinished in profiler (dotnet/coreclr#15691)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f5da3a5e53529880907efd6c30d0abdeba0ba29
Koundinya Veluri [Fri, 5 Jan 2018 01:34:35 +0000 (17:34 -0800)]
Change monitor test (dotnet/coreclr#15727)
Relevant to https://github.com/dotnet/coreclr/issues/15592:
- Not sure what is actually happening, guessing there is an exception during TryEnter() and the exception from Exit() from the finally block is hiding the actual exception
- Moved TryEnter() to before the try block
- Fixed pass/fail condition for some similar monitor tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
b5a755ef274fa182cd17317208be4cb4dc3896de
Koundinya Veluri [Fri, 5 Jan 2018 01:34:09 +0000 (17:34 -0800)]
Fix waitone test (dotnet/coreclr#15728)
Fixes https://github.com/dotnet/coreclr/issues/15098:
- Probably a timing issue, changed to use Thread.Join() instead of sleeps
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3796c748b6fe561797d59307e0671f02eebd391
Tanner Gooding [Wed, 27 Dec 2017 05:01:51 +0000 (21:01 -0800)]
Updating Compiler::impIntrinsic to always expand hardware intrinsics.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a71f4bc0f161140855eaf87e27cd82100df0a9e0
mikedn [Thu, 4 Jan 2018 23:40:59 +0000 (01:40 +0200)]
Reset lvIsStructField when removing promoted struct vars (dotnet/coreclr#15721)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e79a4d58a433c84a6df9059b210922a5bd2c6690
Carol Eidt [Thu, 4 Jan 2018 23:35:03 +0000 (15:35 -0800)]
Merge pull request dotnet/coreclr#15726 from CarolEidt/Fix15237
Keep OBJ on mismatched struct assignment
Commit migrated from https://github.com/dotnet/coreclr/commit/
d5a9c01e24b2ff41eb9ba91fd3810b836f0ac404
William Godbe [Thu, 4 Jan 2018 23:04:46 +0000 (15:04 -0800)]
Remove bad assert in Mutex & update error messages (dotnet/coreclr#15734)
* Remove bad assert in Mutex & update error messages
* Redo error message
Commit migrated from https://github.com/dotnet/coreclr/commit/
d2f2e81294a80a1b463ea185decd07e49e67f976
dotnet bot [Thu, 4 Jan 2018 21:59:50 +0000 (13:59 -0800)]
Merge changes from TFS (dotnet/coreclr#15732)
* Remove unused CORJIT_FLAG_USE_SSE3_4
This changes the JIT-EE interface GUID.
This is the desktop side of https://github.com/dotnet/coreclr/pull/14825.
[tfs-changeset: 1685154]
* Pick up rest of desktop side changes
Commit migrated from https://github.com/dotnet/coreclr/commit/
38ec680aa59010221bfc15afa23af73764fd0406
Davis Goodin [Thu, 4 Jan 2018 20:54:25 +0000 (14:54 -0600)]
Mark all CoreCLR packages as non-shipping (dotnet/coreclr#15725)
This indicates the packages shouldn't be shipped to the NuGet gallery.
Commit migrated from https://github.com/dotnet/coreclr/commit/
36bf4472c2464801dd784b3986e020764ce4f7c4
Steve MacLean [Wed, 3 Jan 2018 17:24:20 +0000 (12:24 -0500)]
[Arm64] Add Vector64 HW Intrinsic support
Commit migrated from https://github.com/dotnet/coreclr/commit/
44a7dc7421a0d54f502233ec501b4e194f67c357
dotnet-maestro-bot [Thu, 4 Jan 2018 15:41:17 +0000 (09:41 -0600)]
Update BuildTools, CoreClr, CoreFx to prerelease-02403-01, preview1-26103-02, preview1-26104-02, respectively (dotnet/coreclr#15684)
Commit migrated from https://github.com/dotnet/coreclr/commit/
66b31aab41996565ef02893cfdf12db485b7c07d
Jan Kotas [Thu, 4 Jan 2018 06:22:09 +0000 (22:22 -0800)]
Fix link to IdnMapping.cs (dotnet/coreclr#15717)
Commit migrated from https://github.com/dotnet/coreclr/commit/
75ff3e46c33bd8062fb13dd5371521485d9a01e3
Atanu [Thu, 4 Jan 2018 06:14:55 +0000 (11:44 +0530)]
Link to THIRD-PARTY-NOTICES is fixed (dotnet/coreclr#15665)
The link to the THIRD-PARTY-NOTICES page is broken in contributing.md [https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/contributing.md]
The current link is [https://github.com/dotnet/coreclr/blob/master/THIRD-PARTY-NOTICES]
Seems it is missing a '.TXT' at the end of the URL. The correct link should be [https://github.com/dotnet/coreclr/blob/master/THIRD-PARTY-NOTICES.TXT] which is working fine.
Issue dotnet/coreclr#15664
Commit migrated from https://github.com/dotnet/coreclr/commit/
e432923a0cc31e1c34f94c5a2e9b75570ecf9d9a
William Godbe [Thu, 4 Jan 2018 04:35:55 +0000 (20:35 -0800)]
Check for null in ReflectionTypeLoadException Message/ToString (dotnet/coreclr#15711)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3210b9ea76f2612b1ef014a2e570b72f994bc509
Russell Cohen [Thu, 4 Jan 2018 04:15:12 +0000 (20:15 -0800)]
Fix typo in docstring (dotnet/coreclr#15714)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b53b6ea1a0856a904ff8bb2df31306f9ca1e282c
Carol Eidt [Thu, 4 Jan 2018 01:45:07 +0000 (17:45 -0800)]
Keep OBJ on mismatched struct assignment
In a mismatched struct assignment, e.g. using Unsafe.As, we need to retain the OBJ(ADDR(lcl)) on the rhs of the assignment.
Fix dotnet/coreclr#15237
Commit migrated from https://github.com/dotnet/coreclr/commit/
76b4b48489a249c037f15b5d1c66393c149151d8
Bruce Forstall [Thu, 4 Jan 2018 00:57:13 +0000 (16:57 -0800)]
Merge pull request dotnet/coreclr#15706 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
83a769b5db713895fb26904c3ba6c798b27e7434
dotnet bot [Thu, 4 Jan 2018 00:46:05 +0000 (16:46 -0800)]
Use the message that the ReflectionTypeLoadException exception was initialized with (dotnet/coreclr#15708)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
b11ddd33db2d784f004e22b81b5aa72262f9dc92
Tanner Gooding [Thu, 4 Jan 2018 00:45:10 +0000 (16:45 -0800)]
Updating the build script to work when python is installed to a path containing a space. (dotnet/coreclr#15707)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8337aa4fa5cdbccddee0ff81bf0b3c8db80956d3
Bruce Forstall [Thu, 4 Jan 2018 00:26:47 +0000 (16:26 -0800)]
Merge pull request dotnet/coreclr#15614 from BruceForstall/AddPushPeriodicViews
Add more Views to Jenkins UI
Commit migrated from https://github.com/dotnet/coreclr/commit/
ec76b8a2df66a5ddfcd5cc373221a6d32a73dbd3
Victor "Nate" Graf [Wed, 3 Jan 2018 22:55:35 +0000 (14:55 -0800)]
Fix size-on-disk benchmark to handle new CLI behavior (dotnet/coreclr#15689)
Add flag to ensure ensure the compiler server is not used so that the installation can be deleted successfully after the test. Additionally use a more robust deletion strategy to ensure files are deleted and the test does not fail spuriously due to random IO errors.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b008aa05ab3572edf8946b95cf3b1fe2a4a2cdc
Andy Ayers [Wed, 3 Jan 2018 22:46:20 +0000 (14:46 -0800)]
Fix formatting
Commit migrated from https://github.com/dotnet/coreclr/commit/
acfabcda8a00b9898979d89ae8285edd25843aee
Bruce Forstall [Wed, 3 Jan 2018 22:24:34 +0000 (14:24 -0800)]
Merge pull request dotnet/coreclr#15602 from sdmaclea/PR-HWINT-XARCH-DEP
[Arm64] getBaseTypeAndSizeOfSIMDType
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a586656822e41cb16a069f5471335fa18703988
Andy Ayers [Wed, 3 Jan 2018 22:11:18 +0000 (14:11 -0800)]
Spill the eval stack when storing to a pinned local.
The jit may not see direct interference between a pinned local and expressions that use the pinned value. So worst case it should assume that such interference exists and spill the stack when storing to a pinned local. Otherwise the jit may reorder unpins and calls that refer to pinned storage.
Fixes DevDiv 545749
[tfs-changeset: 1685045]
Commit migrated from https://github.com/dotnet/coreclr/commit/
60f74b3bf12e2993c7f928856b5740cbe03f6612
Davis Goodin [Wed, 3 Jan 2018 21:47:58 +0000 (15:47 -0600)]
Pass manifest details to PushToBlobFeed (dotnet/coreclr#15705)
Commit migrated from https://github.com/dotnet/coreclr/commit/
247d60deec8fae0dd81c3864921ca46d3f6d2283
Carol Eidt [Wed, 3 Jan 2018 19:23:24 +0000 (11:23 -0800)]
Merge pull request dotnet/coreclr#15702 from sdmaclea/PR-EOL
Normalize lsra.h line endings
Commit migrated from https://github.com/dotnet/coreclr/commit/
55f9cc3af46fdca20b08e7d0cf9c19fe833a8679
Steve MacLean [Wed, 3 Jan 2018 18:45:52 +0000 (13:45 -0500)]
Normalize lsra.h line endings
Commit migrated from https://github.com/dotnet/coreclr/commit/
3632bcd4734b8b5529a10d1f925fe94010f71080
William Godbe [Wed, 3 Jan 2018 18:42:37 +0000 (10:42 -0800)]
Print Inner Exceptions in ReflectionTypeLoadException ToString (dotnet/coreclr#15688)
* Print Inner Exceptions in ReflectionTypeLoadException ToString
* Simplify formatting
* Remove tab
* Fix newlines
* Use AppendLine
* Use foreach
* Remove ToString
* Update string & message
* Modify Message
* Remove parens
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d26be528cac52afb5bebc12eca8f7260040578c
Steve MacLean [Tue, 19 Dec 2017 22:53:17 +0000 (17:53 -0500)]
[Arm64] getBaseTypeAndSizeOfSIMDType
Remove XARCH platform dependencies
Disable Vector256 support on Arm64 until needed
Commit migrated from https://github.com/dotnet/coreclr/commit/
d70e11bb0c5aec9b65df5abe102ed3b6418abb4b
Bruce Forstall [Wed, 3 Jan 2018 17:24:35 +0000 (09:24 -0800)]
Merge pull request dotnet/coreclr#15698 from mikedn/patch-1
Fix minor formatting issue in jit-call-morphing.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1b2aca2fd9872b378984c7b2d3881df909a1432