Pat Gavlin [Mon, 10 Apr 2017 23:58:46 +0000 (16:58 -0700)]
Merge pull request #10866 from pgavlin/VSO405852
Fix VSO bug 405852.
Dan Moseley [Mon, 10 Apr 2017 23:20:05 +0000 (16:20 -0700)]
empty array (#10841)
Make EmptyArray private in favor of Array.Empty<T>
Roman Artemev [Mon, 10 Apr 2017 22:55:54 +0000 (15:55 -0700)]
Merge pull request #10814 from rartemev/ilasm_reference_resolver_fix
Added 'netstandard' corelib name into ilasm reference resolver
Bruce Forstall [Mon, 10 Apr 2017 22:55:14 +0000 (15:55 -0700)]
Merge pull request #10808 from sdmaclea/PR-ARM64-enable-initblk-unroll
[Arm64] enable initblk loop unrolling
Sergey Andreenko [Mon, 10 Apr 2017 22:41:54 +0000 (15:41 -0700)]
add test with deep execution tree without stores. (#10835)
Add a test that should fail with stack overflow if the compiler doesn't spill trees from time to time.
Pat Gavlin [Mon, 10 Apr 2017 22:13:58 +0000 (15:13 -0700)]
Format code.
Pat Gavlin [Mon, 10 Apr 2017 21:17:08 +0000 (14:17 -0700)]
Fix VSO bug 405852.
This bug was due to a mismatch between the semantics of the FP modulus
operator as specified by ECMA-335 and as implemented by value numbering.
ECMA-335 requires the following behavior for FP modulus:
- If the divisor is 0 or the dividend is not finite, the result is NaN
- If the divisor is not finite and is not NaN, the result is the
dividend.
Value numbering, however, simply used `fmod`, which does not have these
semantics. This change implements the required semantics in VN.
Jan Kotas [Mon, 10 Apr 2017 20:57:03 +0000 (13:57 -0700)]
Add back UnmanagedType.LPUTF8Str (#10859)
Rew [Mon, 10 Apr 2017 20:06:49 +0000 (16:06 -0400)]
CoreLib Build System portability updates (#10839)
Updates to corelib project file for target specific includes. Intended
to ease maintainability of existing targets and clarify necessary work
for new targets.
Koundinya Veluri [Mon, 10 Apr 2017 20:00:48 +0000 (13:00 -0700)]
Fix contract to allow call into GarbageCollect() to throw (#10856)
I did not intend to mark this function as NOTHROW, and there is no reason to expect NOTHROW here. Other functions that call into GarbageCollect() allow THROWS.
Aditya Mandaleeka [Mon, 10 Apr 2017 19:53:41 +0000 (12:53 -0700)]
Merge pull request #10823 from adityamandaleeka/move_variable_handle_creation
Refactor variable strength handle creation
Omar Tawfik [Mon, 10 Apr 2017 19:52:22 +0000 (12:52 -0700)]
Add empty System.Runtime.CompilerServices.RuntimeFeature.IsSupported() API (#10779)
Roman Artemev [Fri, 7 Apr 2017 23:07:14 +0000 (16:07 -0700)]
Added netstandard corelib into ilasm reference resolver
Atsushi Kanamori [Mon, 10 Apr 2017 19:43:24 +0000 (12:43 -0700)]
Fix perf penalty for creating dictionaries the easy way. (#10855)
We went to the trouble of mitigating the perf hit
introduced by using randomized string hashing.
I assume that said perf benefit wasn't meant to be denied
to the 90% case where people use the nullary
constructor to create the Dictionary...
[Arm64] Cleanup/fix InitBlkUnroll
dotnet bot [Mon, 10 Apr 2017 18:18:31 +0000 (11:18 -0700)]
Update CoreFx to preview1-25210-01 (#10850)
James Ko [Mon, 10 Apr 2017 17:26:12 +0000 (13:26 -0400)]
Implement slicing APIs for ArraySegment<T> (#9926)
Ilya [Mon, 10 Apr 2017 17:21:41 +0000 (20:21 +0300)]
Incorrect parameter order found by PVS-Studio (#10497)
* Incorrect parameter order found by PVS-Studio
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V3066 diagnostic https://www.viva64.com/en/w/V3066/
Atsushi Kanamori [Mon, 10 Apr 2017 17:14:09 +0000 (10:14 -0700)]
Get rid of "#if FEATURE_RANDOMIZED_STRING_HASHING" in shared partition. (#10851)
Since CoreCLR defines it (for now) and CoreRT doesn't, let's not have
"#if's" on this in shared code. It just creates confusion.
The only ones are in StringComparer.cs and fortunately, they are quite
expendable as...
1. It's only purpose is serialize Hashtables and Dictionaries in
a way that CLR 1.1 can deserialize them. We don't care about that in
.NET Core.
2. In CoreCLR as of today, this infrastructure is not changing the serialization
blob one iota since all the GetEqualityComparerForSerialization() methods
return "this."
So this removes the appearance of downgrading the comparers to non-randomized
versions for serialization purposes (and yes, we could go on and remove
all the other "let's do it for Everett and RTM" stuff in Hashtable.cs, but
I want to keep this PR on topic. Hashtable.cs is not going to be imported
into CoreRT so it's low priority for me.)
Cyd Haselton [Mon, 10 Apr 2017 17:03:53 +0000 (12:03 -0500)]
Updating CODE_OWNERS.TXT (#10834)
Added Nuget package implementation owners
Sergey Andreenko [Mon, 10 Apr 2017 16:41:49 +0000 (09:41 -0700)]
Forbid lea without index and base. (#10771)
Jan Kotas [Mon, 10 Apr 2017 16:28:38 +0000 (09:28 -0700)]
Delete FEATURE_READYTORUN define for CoreLib build (#10840)
This define does not have much value for the CoreLib build, and it was missing on arm64.
Also deleted dead props and targets files left over from the legacy build
Jonghyun Park [Mon, 10 Apr 2017 13:21:11 +0000 (22:21 +0900)]
[x86/Linux] Set ResumeEsp as Caller Sp when unwond to native frame (#10838)
Jonghyun Park [Mon, 10 Apr 2017 12:51:10 +0000 (21:51 +0900)]
[x86/Linux] 16-byte aligned ResolveWorkerChainLookupAsmStub (#10754)
Buyduck [Mon, 10 Apr 2017 12:48:57 +0000 (16:48 +0400)]
* Fixed issue, when structures with many fields had wrong size in dwarf (#10797)
Jan Kotas [Mon, 10 Apr 2017 05:53:50 +0000 (22:53 -0700)]
Move files to shared CoreLib partition (#10837)
Aditya Mandaleeka [Sat, 8 Apr 2017 01:44:23 +0000 (18:44 -0700)]
Move variable handle creation.
Sean Gillespie [Sun, 9 Apr 2017 20:58:29 +0000 (13:58 -0700)]
[Local GC] Move knowledge of the free object method table outside of the GC (#10755)
* [Local GC] Move knowledge of the free object method table outside of the GC
* Revert "[Local GC] Move knowledge of the free object method table outside of the GC"
This reverts commit
02979e5eb12dd44edb2603e16411dd7d7ffc377d.
* Address code review feedback: leave ArrayBase alone, as it should be part of the binary contract between the EE and the GC
* Correct a bad merge
Jan Kotas [Sun, 9 Apr 2017 13:55:23 +0000 (06:55 -0700)]
Move files to shared CoreLib partition (#10830)
Joseph Tremoulet [Sun, 9 Apr 2017 06:50:02 +0000 (02:50 -0400)]
Update VS2017 'Individual Components' install info (#10695)
A few small changes to make it easier to compare selections in the
installer UI against the list in the doc:
- Re-order the list to match the order presented in the installer UI
- Place the individual items under groupings matching the installer
- Change casing to match installer UI
Jan Kotas [Sun, 9 Apr 2017 05:12:22 +0000 (22:12 -0700)]
Delete reference to model.xml since it no longer exists (#10827)
Jim Ma [Sun, 9 Apr 2017 03:43:12 +0000 (11:43 +0800)]
Fix the broken link in contributing.md (#10828)
The List.cs link is broken in contributing.md. This PR updates the link to List.cs accordingly.
Fix #10822
Bruce Forstall [Sun, 9 Apr 2017 03:23:52 +0000 (20:23 -0700)]
Merge pull request #10776 from sdmaclea/PR-ARM64-CpBlkUnroll
[Arm64] Enable cpblk loop unrolling
Bruce Forstall [Sun, 9 Apr 2017 03:23:34 +0000 (20:23 -0700)]
Merge pull request #10736 from sdmaclea/PR-ARM64-GC-genLeaInstruction
[Arm64] Fix GC Hole in genLeaInstruction
Hadi Brais [Sat, 8 Apr 2017 19:24:23 +0000 (00:54 +0530)]
Fix corerun issue when loaded from PATH (#10745)
Alex Perovich [Sat, 8 Apr 2017 19:24:01 +0000 (14:24 -0500)]
Use a monotonic clock for test timing (#10812)
Fixes #8348
Koundinya Veluri [Sat, 8 Apr 2017 19:23:33 +0000 (12:23 -0700)]
Handle SIGTERM on OSX (#10723)
* Handle SIGTERM on OSX
Fixes #7394
* Address feedback
Jim Ma [Sat, 8 Apr 2017 16:43:47 +0000 (00:43 +0800)]
Exit gracefully when running ildasm -nat against unsupported ni file. (#10821)
ildasm -nat only works for fragile native images (ie CoreLib only by default).
Running ildasm -nat against unsupported native images would cause a segmentation fault. This PR checks pNativeHeader->Signature == CORCOMPILE_SIGNATURE and end the program with a meaningful error message.
fix #10247
Bruce Forstall [Sat, 8 Apr 2017 15:37:44 +0000 (08:37 -0700)]
Merge pull request #10811 from BruceForstall/RemoveRELOC_SUPPORT
Remove RELOC_SUPPORT define
Sean Gillespie [Sat, 8 Apr 2017 06:59:00 +0000 (23:59 -0700)]
[Local GC] Fix some interface violations (#10817)
Jan Kotas [Fri, 7 Apr 2017 23:49:04 +0000 (16:49 -0700)]
Merge pull request dotnet/corert#3262 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Fri, 7 Apr 2017 23:49:58 +0000 (16:49 -0700)]
Find & replace Exception.SetErrorCode with Exception.HResult setter (#10810)
Aditya Mandaleeka [Fri, 7 Apr 2017 22:02:53 +0000 (15:02 -0700)]
Merge pull request #10757 from adityamandaleeka/handle_table_local_gc_init
[Local GC] Move handle creation to IGCHandleTable
Aditya Mandaleeka [Fri, 7 Apr 2017 01:11:57 +0000 (18:11 -0700)]
Move OBJECTHANDLE definition to gcinterface.h
Aditya Mandaleeka [Thu, 6 Apr 2017 02:31:32 +0000 (19:31 -0700)]
Add creation of special handle types to IGCHandleTable.
Omar Tawfik [Fri, 7 Apr 2017 21:48:09 +0000 (14:48 -0700)]
Add System.Runtime.CompilerServices.ReadOnlyAttribute (#10777)
Davis Goodin [Fri, 7 Apr 2017 21:38:02 +0000 (16:38 -0500)]
Temporarily disable symweb indexing (#10807)
Bruce Forstall [Fri, 7 Apr 2017 21:18:26 +0000 (14:18 -0700)]
Remove RELOC_SUPPORT define
It's always defined, is always expected to be defined, and the build
doesn't work without it.
Also remove unused `SECURITY_CHECK` and `VERIFY_IMPORTER` defines.
Jeremy Kuhne [Fri, 7 Apr 2017 21:21:47 +0000 (14:21 -0700)]
Strip out unused reg code. (#10741)
* Strip out unused reg code.
Removing the unused code to better be able to audit our CoreLib usage and to prepare for targeted code sharing with CoreFX. Wraps key usages in using statements.
* Fix static init and remove Contract
[Arm64] enable initblk loop unrolling
William Godbe [Fri, 7 Apr 2017 20:46:11 +0000 (13:46 -0700)]
Merge pull request #10806 from wtgodbe/portableMac
Publish portable OSX binaries into separate container in pipeline
Jan Kotas [Fri, 7 Apr 2017 18:38:02 +0000 (11:38 -0700)]
Delete moved file
Jan Kotas [Fri, 7 Apr 2017 15:34:41 +0000 (08:34 -0700)]
Merge pull request dotnet/corert#3247 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Ahson Ahmed Khan [Fri, 7 Apr 2017 20:05:29 +0000 (13:05 -0700)]
Using AsSpan since we no longer have slice on string. Renaming Tests. (#10758)
Bruce Forstall [Fri, 7 Apr 2017 19:54:00 +0000 (12:54 -0700)]
Merge pull request #10799 from sdmaclea/PR-Fix-lvRegister-assert
Correct assert w.r.t meaning of lvRegister
wtgodbe [Fri, 7 Apr 2017 19:47:22 +0000 (12:47 -0700)]
Publish portable OSX binaries into separate container in pipeline
Jan Kotas [Fri, 7 Apr 2017 18:31:03 +0000 (11:31 -0700)]
Move public ThreadAbortException back to CoreLib (#10801)
dotnet bot [Fri, 7 Apr 2017 18:20:52 +0000 (11:20 -0700)]
Update CoreClr, CoreFx to preview1-25207-02, preview1-25205-01, respectively (#10787)
Address #10799 comments
Bruce Forstall [Fri, 7 Apr 2017 18:09:16 +0000 (11:09 -0700)]
Merge pull request #10656 from hseok-oh/ryujit/fix_10654
[RyuJIT/ARM32] [ReadyToRun] Fix target register for invocation to Thunk
Roman Artemev [Fri, 7 Apr 2017 18:09:02 +0000 (11:09 -0700)]
Merge pull request #10781 from rartemev/ilasm_path_length_fix
Changes for #9757 issue. Handle long parameters in the right way.
William Godbe [Fri, 7 Apr 2017 17:45:37 +0000 (10:45 -0700)]
Merge pull request #10704 from wtgodbe/BuildDefs
Initial commit of checked in build definitions for CoreCLR
[Arm64] Use ldp/stp in CpBlkUnroll
Michelle McDaniel [Fri, 7 Apr 2017 17:02:04 +0000 (10:02 -0700)]
Merge pull request #10798 from adiaaida/fixjit32Perf
Fix jit32 Perf testing
Jan Kotas [Fri, 7 Apr 2017 13:29:10 +0000 (06:29 -0700)]
Delete duplicate files and fix build breaks
Jan Kotas [Fri, 7 Apr 2017 06:54:36 +0000 (23:54 -0700)]
Merge pull request dotnet/corert#3243 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Address review feedback
Correct assert w.r.t meaning of lvRegister
Per recomendation of Pat Gavlin in #9898
Fixes #9898
Michelle McDaniel [Fri, 7 Apr 2017 15:45:30 +0000 (08:45 -0700)]
Fix jit32 Perf testing
In the CI, we were moving compatjit.dll into the Products directory
instead of the core_root directory, so the jit32 compatjit.dll was not
being picked up by the build. This change moves the nuget logic to before
we run runtest.cmd generatelayoutonly, so the jit32 compatjit.dll will be
moved to the core_root directory along with everything else.
Jim Ma [Fri, 7 Apr 2017 15:33:21 +0000 (23:33 +0800)]
Handle unsupported varargs tests on Unix gracefully. (#10794)
Some of mcc_i* tests caused segmentation faults on Unix. This commit make these tests exit by throwing a System.EntryPointNotFoundException exception instead of causing a segmentation fault.
Fix #9530
Yi Zhang (CLR) [Fri, 7 Apr 2017 14:29:10 +0000 (07:29 -0700)]
Bring back DefaultDllImportSearchPathsAttribute (#10786)
Jan Vorlicek [Fri, 7 Apr 2017 13:35:34 +0000 (15:35 +0200)]
Add reporting swap file size to GlobalMemoryStatusEx on Unix (#10700)
The swap file size reporting is added using the Linux, OSX and FreeBSD
means. Also a new PAL test was added to exercise the function.
Jan Kotas [Fri, 7 Apr 2017 04:00:36 +0000 (21:00 -0700)]
Delete duplicate files and fix build breaks
Simon Nattress [Fri, 7 Apr 2017 01:02:03 +0000 (18:02 -0700)]
Merge pull request dotnet/corert#3226 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Koundinya Veluri [Fri, 7 Apr 2017 06:51:13 +0000 (23:51 -0700)]
Call custom parameterless constructor on structs through Activator (#10778)
Fixes #6843
- Disabled caching struct types that have custom parameterless constructors in `ActivatorCache`
- Removed some things relevant to security, which don't apply to CoreCLR
Dan Moseley [Fri, 7 Apr 2017 04:28:14 +0000 (21:28 -0700)]
remove fedora 23 (#10725)
* remove fedora 23
* Fedora rename
Atsushi Kanamori [Fri, 7 Apr 2017 02:33:50 +0000 (19:33 -0700)]
NS2.0 Prepare FileNotFoundException for move to shared partition. (#10775)
* String->string - get rid of the big comment block.
* Fields into autoprops.
* FullName => ToString() to avoid MME problems on N.
* Remove SecurityException guard around FusionLog
* Split off the parts we don't want to share.
Michal Strehovský [Wed, 5 Apr 2017 18:25:20 +0000 (11:25 -0700)]
Merge pull request dotnet/corert#3216 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Brian Sullivan [Fri, 7 Apr 2017 02:13:35 +0000 (19:13 -0700)]
Merge pull request #10784 from briansull/ibc-shutdown-fix
Fix shutdown A/V issue when IBC logging with the Music Store app
Ben Adams [Fri, 7 Apr 2017 02:05:18 +0000 (03:05 +0100)]
Devirtualizable default encoding (#10783)
Yi Zhang (CLR) [Fri, 7 Apr 2017 01:36:22 +0000 (18:36 -0700)]
don't switch to COOP GC when logging CCW ref count (#10756)
Hyeongseok Oh [Fri, 7 Apr 2017 01:33:54 +0000 (10:33 +0900)]
Use _TARGET_ARMARCH_
Chagne _TARGET_ARM_ and _TARGET_ARM64_ to _TARGET_ARMARCH_
Brian Sullivan [Fri, 7 Apr 2017 00:36:15 +0000 (17:36 -0700)]
Fix shutdown A/V issue when IBC logging with the Music Store app
This app continues to run managed code on other threads after the Main thread exits and enters shutdown.
We now block IBC logging during the time that we are writing out the IBC data.
Swaroop Sridhar [Wed, 5 Apr 2017 01:38:17 +0000 (18:38 -0700)]
Update ILLink build scripts
Update ILLINK build commands to reflect current CoreBuild of ILLinker.
Also remove the line that sets DoNotEmbedDescriptors,
since it is no longer necessary.
Roman Artemev [Thu, 6 Apr 2017 22:54:03 +0000 (15:54 -0700)]
Correct fix for long ilasm params
Fix formating
Bruce Forstall [Thu, 6 Apr 2017 21:40:08 +0000 (14:40 -0700)]
Merge pull request #10768 from mskvortsov/ryujit-arm32-lea
[RyuJIT/ARM32] Update genLeaInstruction
[Arm64] Enable cpblk loop unrolling
Matt Mitchell [Thu, 6 Apr 2017 20:54:23 +0000 (13:54 -0700)]
Add views for the jitstress and illink folders (#10773)
wtgodbe [Tue, 4 Apr 2017 18:52:59 +0000 (11:52 -0700)]
Initial commit of checked in build definitions for CoreCLR
Tarek Mahmoud Sayed [Thu, 6 Apr 2017 19:58:17 +0000 (12:58 -0700)]
Make Encoding.Default return UTF8 without BOM emission (#10747)
* Make Encoding.Default return UTF8 without BOM emission
* Remove SL reference in the code
* Remove the static cache
Bruce Forstall [Thu, 6 Apr 2017 18:29:42 +0000 (11:29 -0700)]
Merge pull request #10697 from sdmaclea/PR-FIX-RUNTEST
Do not use declare -A
Bruce Forstall [Thu, 6 Apr 2017 18:26:37 +0000 (11:26 -0700)]
Merge pull request #9086 from mikedn/simd-cast
Add Vector.op_Explicit tests
Tarek Mahmoud Sayed [Thu, 6 Apr 2017 17:11:21 +0000 (10:11 -0700)]
Revert EncodingForwarder for the sake of the Perf (#10740)
* Revert EncodingForwarder for the sake of the Perf
* Add missing optimization
Hyeongseok Oh [Thu, 6 Apr 2017 16:23:13 +0000 (01:23 +0900)]
[x86/Linux] PAL test in CI build (#10688)
* [x86/Linux] PAL test in CI build
Add PAL test in CI x86/Linux build
Change docker image: including rootfs
* Fix netci.groovy
Add PAL test's result
Hyung-Kyu Choi [Thu, 6 Apr 2017 16:22:53 +0000 (01:22 +0900)]
[ARM/CI] Update image for armel Tizen CI (#10730)
Update image for armel CI to sync with Tizen rootfs
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Mikhail Skvortcov [Thu, 6 Apr 2017 15:53:15 +0000 (18:53 +0300)]
RyuJIT/ARM32: update GT_LEA codegen
Bruce Forstall [Thu, 6 Apr 2017 15:52:42 +0000 (08:52 -0700)]
Merge pull request #10742 from BruceForstall/RemoveUnusedDefine
Remove unused PREDICT_REG_RER_INDIRECT_PARAM define
Bruce Forstall [Thu, 6 Apr 2017 15:52:24 +0000 (08:52 -0700)]
Merge pull request #10752 from BruceForstall/FixBBFformatting
Clean up block.h formatting
Atsushi Kanamori [Thu, 6 Apr 2017 14:45:58 +0000 (07:45 -0700)]
Clean up and prepare FileLoadException.cs for move to Shared Partition. (#10764)
* String => string
* Replace fields with autoprops.
* Turn Type.FullName call to Type.ToString() in ToString().
Avoids MissingMetadataExceptions on CoreRT.
Assuming metadata exists, ToString() and FullName()
still generates the same string except in the weird
case where an app subclasses FileLoadException
with a generic exception type - in which case,
the ToString() version is actually more readable.
* Get rid of useless try-catch around FusionLog calls.
FusionLog is now just a normal property and an answer
to a trivia question - it won't throw SecurityException.
* Get rid of low-value SetMessageField() middleman.
* Split off the stuff we don't want to share.
* The complementary carwash...
* Don't conditionalize FusionLog serialization.