djsollen@google.com [Mon, 3 Jun 2013 16:02:22 +0000 (16:02 +0000)]
update android_gdb_exe to work with skia shared lib
R=borenet@google.com
Review URL: https://codereview.chromium.org/
16140013
git-svn-id: http://skia.googlecode.com/svn/trunk@9404
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 3 Jun 2013 15:56:44 +0000 (15:56 +0000)]
fix gm on android
R=borenet@google.com
Review URL: https://codereview.chromium.org/
15927011
git-svn-id: http://skia.googlecode.com/svn/trunk@9403
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 3 Jun 2013 14:51:14 +0000 (14:51 +0000)]
yet another build fix for skia_launcher
R=borenet@google.com
Review URL: https://codereview.chromium.org/
15969009
git-svn-id: http://skia.googlecode.com/svn/trunk@9402
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 3 Jun 2013 14:44:52 +0000 (14:44 +0000)]
Fix broken include path for directwrite backend
R=borenet@google.com
Review URL: https://codereview.chromium.org/
16325006
git-svn-id: http://skia.googlecode.com/svn/trunk@9400
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 3 Jun 2013 14:02:15 +0000 (14:02 +0000)]
fix broken skia_launcher app
R=borenet@google.com
Review URL: https://codereview.chromium.org/
15995008
git-svn-id: http://skia.googlecode.com/svn/trunk@9399
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 3 Jun 2013 13:06:42 +0000 (13:06 +0000)]
Whitespace change to trigger rebuilds
Review URL: https://codereview.chromium.org/
16329005
git-svn-id: http://skia.googlecode.com/svn/trunk@9397
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 3 Jun 2013 12:10:19 +0000 (12:10 +0000)]
Prepare skia for shared library build on android
This reapplies revision 9378 after the buildbot has been updated.
R=borenet@google.com, djsollen@google.com
Review URL: https://codereview.chromium.org/
15855006
git-svn-id: http://skia.googlecode.com/svn/trunk@9395
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 2 Jun 2013 16:47:06 +0000 (16:47 +0000)]
Hamfisted fix to drawLooper w/ 0 stages bug
https://codereview.chromium.org/
16305002/
git-svn-id: http://skia.googlecode.com/svn/trunk@9393
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 2 Jun 2013 15:01:06 +0000 (15:01 +0000)]
Disable colortype GM due to crash
git-svn-id: http://skia.googlecode.com/svn/trunk@9392
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 2 Jun 2013 13:37:32 +0000 (13:37 +0000)]
N7 performance trigger rebaselines after skp update
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9390
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 1 Jun 2013 07:01:39 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9387
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 31 May 2013 21:13:36 +0000 (21:13 +0000)]
fix another int -- float warning
git-svn-id: http://skia.googlecode.com/svn/trunk@9384
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 31 May 2013 21:09:06 +0000 (21:09 +0000)]
skip_picture in colortype gm for now
git-svn-id: http://skia.googlecode.com/svn/trunk@9383
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 31 May 2013 21:06:03 +0000 (21:06 +0000)]
use SkIntToScalar to fix warning
git-svn-id: http://skia.googlecode.com/svn/trunk@9382
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 31 May 2013 20:17:57 +0000 (20:17 +0000)]
start a wrapper for color fonts
BUG=
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
14890016
git-svn-id: http://skia.googlecode.com/svn/trunk@9381
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 31 May 2013 20:09:47 +0000 (20:09 +0000)]
prepare skia for shared library build on android
R=borenet@google.com, djsollen@google.com
Committed: https://code.google.com/p/skia/source/detail?r=9378
Review URL: https://codereview.chromium.org/
15855006
git-svn-id: http://skia.googlecode.com/svn/trunk@9379
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 31 May 2013 20:02:56 +0000 (20:02 +0000)]
prepare skia for shared library build on android
R=borenet@google.com, djsollen@google.com
Review URL: https://codereview.chromium.org/
15855006
git-svn-id: http://skia.googlecode.com/svn/trunk@9378
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 31 May 2013 19:46:02 +0000 (19:46 +0000)]
sort the glyphID arrays
add head/tail code
git-svn-id: http://skia.googlecode.com/svn/trunk@9376
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 31 May 2013 18:04:20 +0000 (18:04 +0000)]
Remove SK_API, from SkTSet. the template is not public.
Review URL: https://codereview.chromium.org/
15792016
git-svn-id: http://skia.googlecode.com/svn/trunk@9374
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 31 May 2013 17:49:12 +0000 (17:49 +0000)]
Implement SkXfermode image filter. This required changing the signature of SkXfermode::asNewEffectOrCoeffs(), to add an optional background texture.
For the raster path, we do a straightforward 2-pass method: draw background, then composite the foreground over it.
For the GPU path, if the xfermode can be expressed as an effect, we build an effect with the background texture incorporated, then do a single-pass draw fetching both foreground and background textures, and compositing to the result. If the xfermode is expressed as src/dst coefficients, we do a 2-pass draw as in the raster path and use fixed-function blending.
R=bsalomon@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
16125008
git-svn-id: http://skia.googlecode.com/svn/trunk@9373
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 31 May 2013 17:41:03 +0000 (17:41 +0000)]
All SKP files in Google Storage have been updated. (AddDashboardAnnotation)
git-svn-id: http://skia.googlecode.com/svn/trunk@9371
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 31 May 2013 15:17:50 +0000 (15:17 +0000)]
bump picture version since SkPath has changed (conics)
enable conics in SkPath
git-svn-id: http://skia.googlecode.com/svn/trunk@9370
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 31 May 2013 14:39:54 +0000 (14:39 +0000)]
Read and write pixel offset when serializing bitmaps.
Remove ifdef's preventing a change to read and write offsets.
This fixes a bug where the SKP will draw the wrong portion
of bitmaps.
In addition, read the offset from the stream whether the
bitmap decoder succeeds or not, so that a failure to decode
still advances the stream to the correct spot.
Set the offset to 0 before calling SkPicture::EncodeBitmap,
so that if the function does not set it, we will not
modify the offset.
REQUIRES A CHANGE TO THE PICTURE VERSION. Does not change
PICTURE_VERSION itself, since other CLs are also requiring
a change.
BUG=https://code.google.com/p/skia/issues/detail?id=1301
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
15713015
git-svn-id: http://skia.googlecode.com/svn/trunk@9368
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 31 May 2013 14:27:55 +0000 (14:27 +0000)]
Fix iOS build.
Review URL: https://codereview.chromium.org/
15647010
git-svn-id: http://skia.googlecode.com/svn/trunk@9367
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 31 May 2013 14:06:16 +0000 (14:06 +0000)]
Fix build.
Remove CreateDefaultDecoder call, since the function was removed.
Review URL: https://codereview.chromium.org/
16256003
git-svn-id: http://skia.googlecode.com/svn/trunk@9365
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 31 May 2013 14:00:10 +0000 (14:00 +0000)]
Separate core and images project.
SkImage calls functions on SkImageDecoder and SkImageEncoder. This
is desired behavior, and it is also desired to include SkImage as
a part of core. In order to keep core from depending on images,
update SkImageDecoder_empty.cpp to implement all of SkImageDecoder
and SkImageEncoder. This file will be built by chrome (in
https://codereview.chromium.org/
15960015).
Move force_linking from SkImageDecoder.cpp to its own file. It must
be called to force linking with the image decoders if desired. Call
the function in tools that need it:
sk_image
render_pictures
render_pdfs
sk_hello
filter
bench_pictures
debugger
SkImageDecoder:
Derive from SkNoncopyable, instead of duplicating its
hiding of constructors.
skhello:
Return rather than trying to write a null SkData to the stream.
Revert "Hamfistedly removed core dependence on images"
(commit
0f05f682a90bc125323677abf3476e1027d174f5) and
"Move SkImage::encode to SkImage_Codec.cpp."
(commit
83e47a954d0bf65439f3d9c0c93213063dd70da3.)
These two commits were temporary fixes that this change
cleans up.
SkSnapshot.cpp:
Check for a NULL encoder returned by SkImageEncoder::Create.
BUG=https://code.google.com/p/skia/issues/detail?id=1275
R=djsollen@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
15806010
git-svn-id: http://skia.googlecode.com/svn/trunk@9364
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 31 May 2013 13:27:02 +0000 (13:27 +0000)]
Add atlasing option to GameBench bench
https://codereview.chromium.org/
15660012/
git-svn-id: http://skia.googlecode.com/svn/trunk@9363
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Fri, 31 May 2013 12:58:29 +0000 (12:58 +0000)]
fix warnings on MacOS 10.6
git-svn-id: http://skia.googlecode.com/svn/trunk@9362
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Fri, 31 May 2013 12:50:39 +0000 (12:50 +0000)]
More general GM for testing bitmap filtering, including checkerboards, images, and text.
Review URL: https://codereview.chromium.org/
15755019
git-svn-id: http://skia.googlecode.com/svn/trunk@9361
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Fri, 31 May 2013 12:49:18 +0000 (12:49 +0000)]
specialize bicubic filtering for scale-only
BUG=
Review URL: https://codereview.chromium.org/
15941012
git-svn-id: http://skia.googlecode.com/svn/trunk@9360
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 30 May 2013 19:52:38 +0000 (19:52 +0000)]
Mark picture record benches as non-rendering.
Review URL: https://codereview.chromium.org/
16244004
git-svn-id: http://skia.googlecode.com/svn/trunk@9355
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 30 May 2013 18:55:14 +0000 (18:55 +0000)]
add script to scrape glyph usage in drawText calls
git-svn-id: http://skia.googlecode.com/svn/trunk@9353
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 30 May 2013 15:46:19 +0000 (15:46 +0000)]
rebaseline.py: use argparse command-line flags for more flexibility
--tests is the only mandatory argument.
If you used to run this:
rebaseline.py aaclip bigmatrix
Run this instead:
rebaseline.py --tests aaclip bigmatrix
That's the only change you NEED to make.
And then, if you WANT to specify --configs, --subdirs, etc. you CAN.
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
15675010
git-svn-id: http://skia.googlecode.com/svn/trunk@9348
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 30 May 2013 15:29:48 +0000 (15:29 +0000)]
Revert "add asserts to point<-->verb helpers"
This reverts commit
b4775ac7b55802e87231768f002e4b42f233b0aa.
git-svn-id: http://skia.googlecode.com/svn/trunk@9347
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 30 May 2013 14:57:55 +0000 (14:57 +0000)]
add asserts to point<-->verb helpers
patch from issue
16153005
BUG=
Review URL: https://codereview.chromium.org/
16195004
git-svn-id: http://skia.googlecode.com/svn/trunk@9344
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 30 May 2013 07:01:29 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9343
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 29 May 2013 23:41:28 +0000 (23:41 +0000)]
Speculative fix for Tegra-based Androids: don't try to unpremultiply dstColor in-place; put it in a temporary.
TBR=bsalomon
Review URL: https://codereview.chromium.org/
16214002
git-svn-id: http://skia.googlecode.com/svn/trunk@9336
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 29 May 2013 21:27:53 +0000 (21:27 +0000)]
Replace GrDrawState::AutoDeviceCoordDraw with GrDrawState::AutoViewMatrixRestore::setIdentity(). s
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
15780002
git-svn-id: http://skia.googlecode.com/svn/trunk@9331
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 29 May 2013 20:55:09 +0000 (20:55 +0000)]
Provide a GPU implementation of SkArithmeticMode, using a custom GrEffect exposed via asNewEffectOrCoeff().
Doing it this way required modifying the arithmode GM to use saveLayer()/restore() rather than creating an offscreen SkBitmap, since otherwise the compositing is always done in raster mode. Fixing that in turn exposed that SkArithmeticMode did not work in Picture mode, since it wasn't flattenable. Made it so.
Note: this will require rebaselining the arithmode GM (again).
R=bsalomon@google.com, reed@google.com
Originally committed: https://code.google.com/p/skia/source/detail?r=9324
Reverted: https://code.google.com/p/skia/source/detail?r=9325
Review URL: https://codereview.chromium.org/
16064002
git-svn-id: http://skia.googlecode.com/svn/trunk@9330
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 29 May 2013 20:10:25 +0000 (20:10 +0000)]
Use macros for new and delete in SkTemplates.h
Remove use of new placement array.
R=bungeman@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
15739013
git-svn-id: http://skia.googlecode.com/svn/trunk@9329
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 29 May 2013 19:22:20 +0000 (19:22 +0000)]
use SkStream factory for files, and check for null (file-not-found) speedup sampleapp's animation
BUG=
Review URL: https://codereview.chromium.org/
16173003
git-svn-id: http://skia.googlecode.com/svn/trunk@9327
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 29 May 2013 19:09:48 +0000 (19:09 +0000)]
Moving updateClipConservativelyUsingBounds into SkCanvas
This method is being moved from SkPictureRecord to become a protected member of SkCanvas so that other classes derived from SkCanvas can use it.
This Patch also applies the fix provided by updateClipConservativelyUsingBounds to SkPictureUtils::GatherPixelRefs
BUG=https://code.google.com/p/chromium/issues/detail?id=244893
Review URL: https://codereview.chromium.org/
15894005
git-svn-id: http://skia.googlecode.com/svn/trunk@9326
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 29 May 2013 19:05:54 +0000 (19:05 +0000)]
Revert "Provide a GPU implementation of SkArithmeticMode, using a custom GrEffect exposed via asNewEffectOrCoeff()."
This reverts commit
b8ffe17b5c684f9cfff02285f27e6aa1f75c9b53.
TBR=robertphillips
Review URL: https://codereview.chromium.org/
16115007
git-svn-id: http://skia.googlecode.com/svn/trunk@9325
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 29 May 2013 18:50:46 +0000 (18:50 +0000)]
Provide a GPU implementation of SkArithmeticMode, using a custom GrEffect exposed via asNewEffectOrCoeff().
Doing it this way required modifying the arithmode GM to use saveLayer()/restore() rather than creating an offscreen SkBitmap, since otherwise the compositing is always done in raster mode. Fixing that in turn exposed that SkArithmeticMode did not work in Picture mode, since it wasn't flattenable. Made it so.
Note: this will require rebaselining the arithmode GM (again).
R=bsalomon@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
16064002
git-svn-id: http://skia.googlecode.com/svn/trunk@9324
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 29 May 2013 18:05:52 +0000 (18:05 +0000)]
add != operator for SkTDArray
BUG=
Review URL: https://codereview.chromium.org/
16203002
git-svn-id: http://skia.googlecode.com/svn/trunk@9323
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 29 May 2013 17:36:43 +0000 (17:36 +0000)]
Use updated signature for decode in empty decoder.
This allows chromium to build SkImageDecoder_empty.cpp
(https://codereview.chromium.org/
15960015/) until Skia
has https://codereview.chromium.org/
15806010/ (which
is a superset of this change).
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
15742029
git-svn-id: http://skia.googlecode.com/svn/trunk@9321
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 29 May 2013 17:09:43 +0000 (17:09 +0000)]
Refactor rebaseline.py into functions ; no behavioral changes.
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
16160008
git-svn-id: http://skia.googlecode.com/svn/trunk@9318
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 29 May 2013 16:31:41 +0000 (16:31 +0000)]
use integer math instead of float per-pixel. about a 2x speedup. not tested well, so this is just experimental.
BUG=
Review URL: https://codereview.chromium.org/
15715015
git-svn-id: http://skia.googlecode.com/svn/trunk@9317
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 29 May 2013 16:19:48 +0000 (16:19 +0000)]
cast enum to float to fix (really bad) warning
git-svn-id: http://skia.googlecode.com/svn/trunk@9316
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 29 May 2013 15:39:54 +0000 (15:39 +0000)]
extend SkBenchmark to allow a bench to return a durationScale, which allows it to perform fewer actual interations, but report a scale factor to account for that. Thus a very slow bench can be compared head-to-head with a faster one, w/o actually forcing the tool to run for the full duration of the slower test.
Extend BitmapBench to time bicubic filtering, and use this durationScale for it.
Extend SkBenchmark to have setBitmapFlags(or, clear), allowing it to request a set of paint flags to be cleared, and set to be set.
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
16069010
git-svn-id: http://skia.googlecode.com/svn/trunk@9315
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 29 May 2013 14:53:48 +0000 (14:53 +0000)]
Fix cmykjpeg test to check if file was found.
git-svn-id: http://skia.googlecode.com/svn/trunk@9314
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 29 May 2013 13:43:31 +0000 (13:43 +0000)]
Change SkStream.
https://codereview.chromium.org/
15298009/
git-svn-id: http://skia.googlecode.com/svn/trunk@9312
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 29 May 2013 13:26:32 +0000 (13:26 +0000)]
Remove dependency of gsutil to download ndk
Currently we use gsutil to download ndk. However, it requires extra
steps to install, and is not convenient to configure (several steps to
enable Google storage), especially for developers behind proxy (need to
set config of boto). Chromium provides some python scripts to help
download nacl toolchains that can meet this need well. So this patch
basically borrows two python scripts from there, and makes some
according changes to remove the usage of gsutil. With new script, we may
also implement some advanced features, such as hash check, so that the
download would be more intelligent.
BUG=
R=djsollen@google.com, borenet@google.com, reed@google.com
Author: yang.gu@intel.com
Review URL: https://chromiumcodereview.appspot.com/
15951008
git-svn-id: http://skia.googlecode.com/svn/trunk@9311
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 29 May 2013 13:24:23 +0000 (13:24 +0000)]
First pass at Comment API
https://codereview.chromium.org/
13957009/
git-svn-id: http://skia.googlecode.com/svn/trunk@9310
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 29 May 2013 13:11:54 +0000 (13:11 +0000)]
Get correct GLVersion for Mesa to avoid GrContext creation failure
Path originally written by yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
15779009/
git-svn-id: http://skia.googlecode.com/svn/trunk@9309
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 29 May 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9307
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 28 May 2013 20:48:14 +0000 (20:48 +0000)]
use DEF_BENCH
BUG=
Review URL: https://codereview.chromium.org/
16069005
git-svn-id: http://skia.googlecode.com/svn/trunk@9305
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 28 May 2013 19:43:05 +0000 (19:43 +0000)]
Fix alpha computation in SkArithmeticMode.
Note: this will require new baselines for the arithmode GM.
R=reed@google.com
Review URL: https://codereview.chromium.org/
15917010
git-svn-id: http://skia.googlecode.com/svn/trunk@9302
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 28 May 2013 18:17:23 +0000 (18:17 +0000)]
Build fix
TBR=reed
git-svn-id: http://skia.googlecode.com/svn/trunk@9299
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 28 May 2013 17:39:08 +0000 (17:39 +0000)]
Changing SkDeferredCanvas to use factories for creation
The objective of this change is to remove all calls to
SkCanvas::setDevice. The factory API is hidden behind
a build flag in order to ease the roll into chromium.
A side-effect of the factory pattern is that it will
no longer be possible to allocate a SkDeferredCanvas on
the stack. This changes nothing for chrome, but it
impacts skia test programs.
Review URL: https://codereview.chromium.org/
16040002
git-svn-id: http://skia.googlecode.com/svn/trunk@9298
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 28 May 2013 17:25:49 +0000 (17:25 +0000)]
Make GrContext track the current matrix, render target, and clip directly rather than using GrDrawState.
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
15821008
git-svn-id: http://skia.googlecode.com/svn/trunk@9297
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 28 May 2013 16:45:07 +0000 (16:45 +0000)]
Reland 'Add path utils, plus a test for it.'
Build SkPathJoin and SkBasename on windows also.
Previous CL did not build on Windows because the two functions were
accidentally placed inside an ifdef that did not include windows.
Move the functions to the top of the file, and add a comment by the
endif for clarity.
Previously reviewed at https://codereview.chromium.org/
15747004/
Review URL: https://codereview.chromium.org/
15740024
git-svn-id: http://skia.googlecode.com/svn/trunk@9295
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 28 May 2013 16:39:52 +0000 (16:39 +0000)]
don't unref() null (from typeface::create) you gunky
git-svn-id: http://skia.googlecode.com/svn/trunk@9294
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 28 May 2013 15:42:21 +0000 (15:42 +0000)]
use inttoscalar to fix warning
BUG=
Review URL: https://codereview.chromium.org/
15929006
git-svn-id: http://skia.googlecode.com/svn/trunk@9293
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 28 May 2013 15:35:47 +0000 (15:35 +0000)]
use explicit conversion for int->scalar
BUG=
Review URL: https://codereview.chromium.org/
16123004
git-svn-id: http://skia.googlecode.com/svn/trunk@9292
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 28 May 2013 15:29:25 +0000 (15:29 +0000)]
add new gm for bicubic filtering
BUG=
Review URL: https://codereview.chromium.org/
16123003
git-svn-id: http://skia.googlecode.com/svn/trunk@9291
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 28 May 2013 15:25:38 +0000 (15:25 +0000)]
Split GM json schema out of display_json_results.py, for sharing with other tools
R=rmistry@google.com
Review URL: https://codereview.chromium.org/
16155002
git-svn-id: http://skia.googlecode.com/svn/trunk@9290
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 28 May 2013 13:16:20 +0000 (13:16 +0000)]
Decrease GPU drawn brightness for < 1 pixel wide/high rects
https://codereview.chromium.org/
15715012/
git-svn-id: http://skia.googlecode.com/svn/trunk@9288
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 28 May 2013 13:13:56 +0000 (13:13 +0000)]
check texture is not NULL to aovid segmentation fault. If the texture created by GrLockAndRefCachedBitmapTexture() is NULL, ColorTableEffect::Create will cause segmentation fault by GrAssert in src/gpu/GrTextureAccess.cpp. The simple patch checked texture to avoid segment fault, and returned a NULL effect to the caller. The caller will handle NULL effect, for example, it will set default effect.
R=bsalomon@google.com, robertphillips@google.com
Author: yunchao.he@intel.com
Review URL: https://chromiumcodereview.appspot.com/
15824003
git-svn-id: http://skia.googlecode.com/svn/trunk@9287
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 25 May 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9285
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 24 May 2013 20:31:57 +0000 (20:31 +0000)]
Android specific changes that are upstreamed from the android framework.
R=reed@google.com
Review URL: https://codereview.chromium.org/
15720006
git-svn-id: http://skia.googlecode.com/svn/trunk@9283
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 May 2013 18:52:52 +0000 (18:52 +0000)]
fix slowness of getImageData() for CanvasRenderingContext2D in linux due to un-optimized format for glReadPixels
This is a continuation of https://codereview.chromium.org/
15331003/
BUG=242093
R=robertphillips@google.com, jun.a.jiang@intel.com, bsalomon@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
15746007
git-svn-id: http://skia.googlecode.com/svn/trunk@9280
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 May 2013 18:51:55 +0000 (18:51 +0000)]
Fix degenerate and near-degenerate hairlines on the gpu
R=robertphillips@google.com, bsalomon@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
16035002
git-svn-id: http://skia.googlecode.com/svn/trunk@9279
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 24 May 2013 18:28:57 +0000 (18:28 +0000)]
Revert "Add path utils, plus a test for it."
This reverts commit
d172374b46cae0bd5d7c024b9848f5bdafcc6a16.
This CL broke on Windows.
Review URL: https://codereview.chromium.org/
15986004
git-svn-id: http://skia.googlecode.com/svn/trunk@9278
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 24 May 2013 18:12:17 +0000 (18:12 +0000)]
Add path utils, plus a test for it.
SkOSFile:
Added class SkOSPath with functions for
modifying strings representing path names.
OSPathTest.cpp:
Test of the new utilities.
factory.cpp:
Use SkPathJoin.
gmmain and gm_expectations:
Use SkOSPath::SkPathJoin instead of a local version.
skimage_main.cpp:
Use the new location of SkPathJoin and SkBasename.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
15747004
git-svn-id: http://skia.googlecode.com/svn/trunk@9277
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 24 May 2013 17:13:00 +0000 (17:13 +0000)]
Adding setSurface public API method to SkDeferredCanvas
The purpose of this change is to provide an API that Blink 2D canvas layers can use
to install a new render target when recovering from a lost graphics context.
Review URL: https://codereview.chromium.org/
15896005
git-svn-id: http://skia.googlecode.com/svn/trunk@9276
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 24 May 2013 16:31:30 +0000 (16:31 +0000)]
Revert "Patch to prevent chromium breakage until the DEPS."
This reverts commit
d2a284728d30082d46b02c39d916294c6d36e11f.
Review URL: https://codereview.chromium.org/
16019005
git-svn-id: http://skia.googlecode.com/svn/trunk@9275
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 24 May 2013 15:04:07 +0000 (15:04 +0000)]
Remove SkImageFilter::getInputResult(), since its return value is not
style-compliant, and doesn't allow us to abort on failure.
R=reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=9245
Review URL: https://codereview.chromium.org/
15600003
git-svn-id: http://skia.googlecode.com/svn/trunk@9274
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 24 May 2013 14:58:44 +0000 (14:58 +0000)]
Add flag to gradients to interpolate colors in premul space. Experimental API to encapsulate the shared parameters for all gradients into a struct.
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
15893002
git-svn-id: http://skia.googlecode.com/svn/trunk@9273
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 May 2013 14:57:53 +0000 (14:57 +0000)]
Move SkDrawLooper implementation to its own file.
It previously lived in SkPaint.cpp.
BUG=
R=reed@google.com, tomhudson@chromium.org, jbroman@chromium.org
Author: jbroman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15896004
git-svn-id: http://skia.googlecode.com/svn/trunk@9272
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 24 May 2013 14:33:28 +0000 (14:33 +0000)]
GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value (12345)
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
15883004
git-svn-id: http://skia.googlecode.com/svn/trunk@9271
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 24 May 2013 07:01:26 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9266
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 20:16:17 +0000 (20:16 +0000)]
don't reference missing header
BUG=
Review URL: https://codereview.chromium.org/
15888004
git-svn-id: http://skia.googlecode.com/svn/trunk@9265
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 20:11:56 +0000 (20:11 +0000)]
clone of https://codereview.chromium.org/
15316014/ with teaks
BUG=
Review URL: https://codereview.chromium.org/
15904005
git-svn-id: http://skia.googlecode.com/svn/trunk@9264
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 19:47:05 +0000 (19:47 +0000)]
use SkScalar instead of int for loops, to avoid warning in canvas->translate() calls
BUG=
Review URL: https://codereview.chromium.org/
15875012
git-svn-id: http://skia.googlecode.com/svn/trunk@9263
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 19:39:15 +0000 (19:39 +0000)]
don't overclamp cubics (see skbug.com/1316)
BUG=
Review URL: https://codereview.chromium.org/
15924003
git-svn-id: http://skia.googlecode.com/svn/trunk@9262
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 19:30:48 +0000 (19:30 +0000)]
add comment
add test for skbug/com/1316
BUG=
Review URL: https://codereview.chromium.org/
15790006
git-svn-id: http://skia.googlecode.com/svn/trunk@9261
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 19:03:05 +0000 (19:03 +0000)]
use Descriptor struct to encapsulate all the common paramaeters between our various gradient types. If we like it, might promote it to the public API.
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
15733007
git-svn-id: http://skia.googlecode.com/svn/trunk@9260
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 23 May 2013 17:04:19 +0000 (17:04 +0000)]
use SK_OVERRIDE and DEF_GM
BUG=
Review URL: https://codereview.chromium.org/
15873004
git-svn-id: http://skia.googlecode.com/svn/trunk@9259
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 May 2013 16:41:42 +0000 (16:41 +0000)]
remove outdated debugging code now that we no longer support fixed point
R=reed@google.com, djsollen@google.com
Author: djsollen@google.com
Review URL: https://chromiumcodereview.appspot.com/
15879003
git-svn-id: http://skia.googlecode.com/svn/trunk@9258
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 23 May 2013 14:59:40 +0000 (14:59 +0000)]
Fix bug in SkAutoSMalloc::reset
https://codereview.chromium.org/
15858007/
git-svn-id: http://skia.googlecode.com/svn/trunk@9257
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 23 May 2013 14:11:41 +0000 (14:11 +0000)]
Fix compiler error/warning in r9255
git-svn-id: http://skia.googlecode.com/svn/trunk@9256
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 23 May 2013 14:00:17 +0000 (14:00 +0000)]
Add printing of SkColorFilter-derived classes to debugger
https://codereview.chromium.org/
15697012/
git-svn-id: http://skia.googlecode.com/svn/trunk@9255
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 23 May 2013 13:41:55 +0000 (13:41 +0000)]
Rebaseline performance triggers
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9254
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 23 May 2013 13:21:18 +0000 (13:21 +0000)]
Remove offsetcanvas from debugger
https://codereview.chromium.org/
15746003/
git-svn-id: http://skia.googlecode.com/svn/trunk@9253
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 23 May 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9252
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 22 May 2013 23:56:49 +0000 (23:56 +0000)]
Reverting r9245 due to Chrome breakage
git-svn-id: http://skia.googlecode.com/svn/trunk@9250
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 22 May 2013 21:11:42 +0000 (21:11 +0000)]
Mark SkDrawPictureCallback with SK_API, so that it can be derived from by SK_API classes
R=reed@google.com
Author: vmpstr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15745015
git-svn-id: http://skia.googlecode.com/svn/trunk@9249
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 22 May 2013 20:53:42 +0000 (20:53 +0000)]
use macro to encapsulate building get_mtname() specializations
BUG=
Review URL: https://codereview.chromium.org/
15773002
git-svn-id: http://skia.googlecode.com/svn/trunk@9248
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 22 May 2013 20:12:50 +0000 (20:12 +0000)]
expand SkLua to handle creation of its own State
add lua sample
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
15742009
git-svn-id: http://skia.googlecode.com/svn/trunk@9247
2bbb7eff-a529-9590-31e7-
b0007b416f81