Vincent Torri [Thu, 20 Jun 2019 11:50:35 +0000 (12:50 +0100)]
tests: fix warnings and undef ref on Windows (using meson :-) )
Summary: we need to include evil_private.h so that some symbols are declared
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9129
Carsten Haitzler (Rasterman) [Thu, 20 Jun 2019 11:08:14 +0000 (12:08 +0100)]
evas - events - protect on object deletion while calling callbacks
mouse in/out feeds can call callabcks that can then go delete objects
- ref them all to ensure they stay alive while we use them. this will
fix a segv apbbb saw.
Carsten Haitzler (Rasterman) [Thu, 20 Jun 2019 10:32:12 +0000 (11:32 +0100)]
efl_wfl: fix warning and err prints for wl keymap tmp file
Carsten Haitzler (Rasterman) [Thu, 20 Jun 2019 10:24:57 +0000 (11:24 +0100)]
ecore - efl thread - handle write call mishaps and complain
fixes warnings too.
Carsten Haitzler (Rasterman) [Thu, 20 Jun 2019 10:06:37 +0000 (11:06 +0100)]
meson - docs - convert - we aren't using it so don't require it
comment it out and move it closer to the block that needs it to make
it obvious ... we don't need it.
i'm all-in-all not that into the eps conversion thing for docs there
too... :(
WooHyun Jung [Thu, 20 Jun 2019 08:55:05 +0000 (08:55 +0000)]
elm_slider: fix to call legacy "delay,changed" callback
Just fixed a backward compatibility issue in elm_slider.
Now it calls "delay,changed" as it had done previously.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9130
Mike Blumenkrantz [Wed, 19 Jun 2019 18:09:32 +0000 (14:09 -0400)]
Revert "efl_ui_suite_spec: add a hack to have running tests again"
This reverts commit
2ef8894fcd415cdc24d7bc222a9f8425fb8f9f34.
this is no longer needed
Differential Revision: https://phab.enlightenment.org/D9126
Mike Blumenkrantz [Wed, 19 Jun 2019 18:05:55 +0000 (14:05 -0400)]
efl_ui/active_view: fix object destruction
when the activeview is being destroyed, we can skip a lot of steps in
unregistering widgets due to hierarchy-enforced deletion and class
chaining of destructors.
on the flip side, we also need to be cautious of triggering codepaths that
will perpetuate object lifecycles past when they should be destroyed and
trigger unwanted behavior.
for this case, when the activeview is being destroyed we can simply efl_del
all the contents to reuse existing callbacks, and then we can skip doing
all the update propagation through activeview subcomponents since those will
be destroyed presently. also, these subcomponents already handle subobject
destruction with callbacks, so they'll automatically clean everything up.
probably.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9125
Marcel Hollerbach [Wed, 19 Jun 2019 13:37:19 +0000 (09:37 -0400)]
efl_ui_suite_spec: add a hack to have running tests again
Summary:
it seems something is leading to weird stack behavior with gcc when we
do not delete the widget here. Later deletion in _elm_win_shutdown leads
to a crash like:
#0 0x00007f7b30dd5bd7 in _elm_win_shutdown () at ../src/lib/elementary/efl_ui_win.c:3805
#1 0x01007f7b30cdf3a2 in ?? ()
#2 0x00007fffa4e60570 in ?? ()
#3 0x0000000000407b14 in _elm_suite_shutdown () at ../src/tests/elementary/suite_helpers.c:52
which is kind of weird. After a day of debugging i did not get any
further, so maybe it is better to do add a hack, so we are having at
least a running CI again
Reviewers: stefan_schmidt, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9112
Stefan Schmidt [Wed, 19 Jun 2019 13:26:29 +0000 (09:26 -0400)]
ci: travis: no need to cache the autom4te.cache any longer
Summary:
This was part of the caching speedup for autotools we no longer need.
Depends on D9121
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9122
Stefan Schmidt [Wed, 19 Jun 2019 13:26:23 +0000 (09:26 -0400)]
ci: remove no longer needed make examples script
Summary:
With the meson build the examples do not have a dedicated target, no
need for this script anymore.
Depends on D9120
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9121
Stefan Schmidt [Wed, 19 Jun 2019 13:26:18 +0000 (09:26 -0400)]
ci: rename some travis fold log names and add more
Summary:
For an easier to grasp travis output we are using the travis_fold and
endfold markers in our scripts. Renaming a few here to match the usage
of meson and ninja instead of make. Also adding a few more that have
been missing.
While we are add it remove a now silly extra mingw conditional.
Depends on D9119
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9120
Stefan Schmidt [Wed, 19 Jun 2019 13:26:13 +0000 (09:26 -0400)]
ci: enhance enabled/disabled meson builds to cover almost all options
Summary:
We have been lacking to test many of the build options we have with
meson. Catching up on them here for the enabled and disabled build jobs.
Not everythign could be covered yet, but I leave notes about what stil
needs handling.
Depends on D9118
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9119
Stefan Schmidt [Wed, 19 Jun 2019 13:26:08 +0000 (09:26 -0400)]
ci: remove no longer needed MAKEFLAGS env variable
Summary:
This was used to pass to make and is no longer used with ninja.
Depends on D9117
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9118
Stefan Schmidt [Wed, 19 Jun 2019 13:26:01 +0000 (09:26 -0400)]
ci: travis: remove no longer used BUILDSYSTEM env variable
Summary:
We used this to have a conditional to enter the different autotools
and meson branches in our build scripts. No longer needed.
Depends on D9116
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9117
Stefan Schmidt [Wed, 19 Jun 2019 13:25:56 +0000 (09:25 -0400)]
ci: remove no longer used scripts and patch file
Summary:
With the autotools build system gone we now longer need these files in
our CI system.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9116
Mike Blumenkrantz [Tue, 18 Jun 2019 14:20:32 +0000 (10:20 -0400)]
ci: remove autotools-related conditionals
these are no longer used by anything
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9108
Stefan Schmidt [Wed, 19 Jun 2019 08:58:42 +0000 (10:58 +0200)]
build: emotion: fix lookup of gstreamer 0.10 dependency
The pkg-config file for the 0.10 series of gstreamer is called
gstreamer-0.10.pc and we need to correct name in the dependency check
here to find it. Improving our CI coverage does spot bugs. :-)
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9114
Stefan Schmidt [Wed, 19 Jun 2019 11:09:05 +0000 (13:09 +0200)]
build: emotions: gstreamer: add needed ecore_x internal dependency
The 0.10 gstreamer module needs Ecore_X.h during build. Make sure we
actually have this dependency right so the build can succeed.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9113
Xavi Artigas [Wed, 19 Jun 2019 08:19:49 +0000 (10:19 +0200)]
Fix miscellaneous build warnings
Nothing serious, but they were driving me mad.
Mike Blumenkrantz [Wed, 19 Jun 2019 07:55:51 +0000 (09:55 +0200)]
efl_ui_range_display: range_min_max -> range_limits
Summary: ref T7895
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7895
Differential Revision: https://phab.enlightenment.org/D9110
Yeongjong Lee [Wed, 19 Jun 2019 06:59:54 +0000 (15:59 +0900)]
efl_mono: support multilevel inheritance of NativeClass
Summary:
When it creates multilevel class of NativeClass, internal c function is not
called because eo vtables aren't created
Test Plan:
Check "MyBox2 UpdateLayout" printed.
```
//mcs test_box.cs -out:test_box.exe `pkg-config --libs efl-mono`
//mono test_box.exe
using System;
public class MyBox2 : MyBox
{
public MyBox2(Efl.Object parent, string style = null) : base(parent, style)
{
}
public override void UpdateLayout()
{
Eina.Log.Error("MyBox2 UpdateLayout");
base.UpdateLayout();
}
}
public class MyBox : Efl.Ui.Box
{
public MyBox(Efl.Object parent, string style = null) : base(parent, style)
{
}
public override void UpdateLayout()
{
Eina.Log.Error("MyBox UpdateLayout");
base.UpdateLayout();
}
}
public class Example : Efl.Csharp.Application
{
protected override void OnInitialize(Eina.Array<System.String> args)
{
Efl.Ui.Win win = new Efl.Ui.Win(Efl.App.AppMain);
var box = new MyBox(win);
box.SetHintSizeMin(new Eina.Size2D(360, 240));
win.SetContent(box);
var box2 = new MyBox2(win);
box2.SetHintSizeMin(new Eina.Size2D(360, 240));
box2.Pack(box);
var button = new Efl.Ui.Button(box);
button.SetText("Click");
button.ClickedEvt += (object sender, Efl.Ui.IClickableClickedEvt_Args e) =>
{
box.CalculateGroup();
box2.CalculateGroup();
};
box.Pack(button);
}
public static void Main()
{
var example = new Example();
example.Launch();
}
}
```
Reviewers: segfaultxavi, vitor.sousa, felipealmeida, lauromoura, woohyun, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9079
Marcel Hollerbach [Sat, 18 May 2019 16:45:50 +0000 (18:45 +0200)]
efl_ui_stack: remove!
this can now be done with active_view. This is done in order to reduce
the LOC in elementary that basically do the same.
Differential Revision: https://phab.enlightenment.org/D8920
Wonki Kim [Thu, 20 Jun 2019 06:49:02 +0000 (15:49 +0900)]
spec: switch buildsystem to meson from autotools
from upstream, autotools buildsystem has removed.
tizen efl now uses meson for its buildsystem.
Change-Id: I82e76cf9dab0f7933501d12bf92a9e84a32f34cd
Marcel Hollerbach [Sun, 26 May 2019 16:30:54 +0000 (18:30 +0200)]
autotools: REMOVAL!
Get your seatbelt fastend! It is happening! AUTOTOOLS IS GONE NOW!
All praise to meson!
This time the final version, ci has been adjusted, and now does not try
anymore to build a removed buildsystem. However, the scripts in there
need cleaning up.
Differential Revision: https://phab.enlightenment.org/D9027
Marcel Hollerbach [Tue, 18 Jun 2019 06:12:44 +0000 (08:12 +0200)]
Revert "autotools: REMOVAL!"
This reverts commit
e8c69667b01e2795c1e4ead0536652f935ffa674.
git push on a wrong branch, sorry. This will land today, but not now.
Marcel Hollerbach [Sun, 26 May 2019 16:30:54 +0000 (18:30 +0200)]
autotools: REMOVAL!
Get your seatbelt fastend! It is happening! AUTOTOOLS IS GONE NOW!
All praise to meson!
Differential Revision: https://phab.enlightenment.org/D9027
Change-Id: I8574ad29fed8173455e6995cade966b0bac29f2b
Hermet Park [Mon, 24 Jun 2019 12:29:14 +0000 (21:29 +0900)]
efl_ui_textpath: fix a center align but that doesn't happen at text_set().
When textpath obj has a new text data, it must update center align position
based on the new text length. Previously, it missed that logic.
@fix
Change-Id: Ibba951791904a797d0ddd1553799fc7cc0d18bb2
Shinwoo Kim [Mon, 24 Jun 2019 06:22:00 +0000 (15:22 +0900)]
elementary: remove deprecated API
The elm_ctxpopup_direction_available_get should have been removed by
commit
9d0e1d766c4485df85416d8c1c0ae77354cc8813
[Commit Details]
- commit
9d0e1d766c4485df85416d8c1c0ae77354cc8813
- Author: Shinwoo Kim <cinoo.kim@samsung.com>
- Date: Wed May 22 16:52:37 2019 +0900
elementary: remove deprecated API
Following API was deprecated from 2.4.
- elm_ctxpopup_direction_available_get (ACR-319)
- elm_win_profiles_set (ACR-353)
It is time to remove. This patch is related to ACR-1373.
Change-Id: Ic5e073fcc54cdfa9d9089d74a4c0de94009bc62b
Hermet Park [Mon, 24 Jun 2019 06:03:25 +0000 (15:03 +0900)]
evas vg: fix build break.
Removed duplicated code snippets that were introduced by wrong merge.
Change-Id: Ib0238e8f6ded0e17c7ee90ac3d56f1f61d442884
Hermet Park [Fri, 21 Jun 2019 08:36:16 +0000 (17:36 +0900)]
evas vector: add a lottie animation example.
Summary: Depends on {D8941}
Reviewers: #committers, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8944
Change-Id: I5fc565798b1408095ac89b8d55446432794a41a3
Hermet Park [Fri, 21 Jun 2019 08:32:37 +0000 (17:32 +0900)]
evas vector: support lottie animation as using json loader.
Summary:
This patch extends efl_canvas_vg_object class to implement efl_gfx_frame_controller
to suppor any playable animation on it.
Plus, vector object takes care of lottie animation by using json loader.
it's caching mechanism is changed to cache only static frame, not all frames.
vg_cache supports json loader and make it animation request properly.
This feature has been stabilized enough, it's using in Samsung Galaxy Watch active product,
proved its stability enough.
Depends on {D8940}
Co-authored-by: JunsuChoi <jsuya.choi@samsung.com>
Reviewers: #committers, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8941
Change-Id: I7a71bbb3bbf58aa7faed05033e5ede18e7877739
Hermet Park [Fri, 21 Jun 2019 08:30:19 +0000 (17:30 +0900)]
evas vector: support json loader for rlottie integration.
Summary:
Introduce a new evas json loader to support lottie animation.
This json loader uses rlottie library which is a new github open project.
These days most ui frameworks (windowpws, skia, qt, xamarin, react, nativescript) supports lottie,
the rlottie was designed to support lottie as a standalone library and compatible with efl as well.
To enable this,please install rlottie library then remove json disabler in meson_options.txt
For more information, See lottie/rlottie project and its a introdcution article:
https://airbnb.io/lottie/#/
https://github.com/samsung/rlottie
https://hermet.pe.kr/143
Co-authored-by: JunsuChoi <jsuya.choi@samsung.com>
{D8941}
{D8944}
Reviewers: #committers, jsuya, bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8940
Change-Id: I6216baf76bc725a95a31498a78c1b1b70441fd5e
JunsuChoi [Thu, 20 Jun 2019 07:07:05 +0000 (16:07 +0900)]
ector: Fix precomp layer rendering issue when it has alpha value
Summary:
When the precomp layer(parent layer) has alpha transparency and has more than 1 child layer
and they overlap each other if vg object just propagate the alpha to child layer
it will be applied twice in overlapped area.
Even if the child layer does not have alpha transparency, parent alpha is applied to each child.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, kimcinoo, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9072
Change-Id: I67e1fd3781050fc4427011865f8801998b530e52
Shinwoo Kim [Wed, 19 Jun 2019 01:28:34 +0000 (10:28 +0900)]
evas filter: make curve work for every
Summary:
If an input buffer and an output buffer for the curve filter are same, it reads
and writes to the same texture which behavior is not defined. I could not find
good reference for this, but following could be a reference.
https://stackoverflow.com/questions/
11410292/opengl-read-and-write-to-the-same-texture
The texture gets 0 color value as a result. So the curve filter does not work.
This patch makes the curve filter use different input and output buffer.
Test Plan:
This attached file could explain what 'read and write to the same texture' is.
{
F3724537}
Reviewers: Hermet, jpeg, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9085
Marcel Hollerbach [Tue, 18 Jun 2019 16:22:54 +0000 (12:22 -0400)]
efl_ui_spec: Support running with CK_FORK=no
Summary: this was simply not tested before. But works now.
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9109
Vincent Torri [Tue, 18 Jun 2019 12:22:05 +0000 (13:22 +0100)]
define HAVE_REALPATH in evil_stdlib.h
Summary: instead of relying on build system, define HAVE_REALPATH in Evil header file
Reviewers: zmike, raster, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9107
Vincent Torri [Tue, 18 Jun 2019 12:07:26 +0000 (13:07 +0100)]
Ecore net dialer Windows example: fix undeclared symbols
Summary:
missing symbols :
efl_net_dialer_address_dial_get
efl_net_socket_address_remote_get
efl_net_socket_address_local_get
EFL_NET_DIALER_EVENT_DIALER_CONNECTED
EFL_NET_DIALER_EVENT_DIALER_RESOLVED
EFL_NET_DIALER_EVENT_DIALER_ERROR
EFL_NET_DIALER_WINDOWS_CLASS
Test Plan: compilation
Reviewers: zmike, raster, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9106
Carsten Haitzler (Rasterman) [Tue, 18 Jun 2019 10:21:13 +0000 (11:21 +0100)]
ecore_x - restore move event skipper that was removed long ago
so i've been wondering what is going on for a few days... and i've
figured it out finally... my mouse seems ot like to generate 1000
events per second. not your usual 100 or 200. it only happened on this
one machine so i was wondering what on earth was up. this machine was
different in other ways like an arm cpu, differing gpu (rx550),
different distro and so on. this is creating a storm of motion events..
and this is causing all sorts of overhead in just trying to deal with
them all like generate more internal events, emit signals for every
one of them and so on. there is no attempt to play catch-up or
anything - just build up a bigger and bigger queue of them to deal
with. this is NOT GOOD. this restores our old commented out event
skipper that got commented out during some xcb work actually -
not on its own. it was a huge xcb patch that commented it out.
this restores it and makes it a little cleaner with a bool and now the
perf issues i was seeing are gone. this is such a major performance
fix that this deserves a backport.
@fix @optimize
Carsten Haitzler (Rasterman) [Mon, 17 Jun 2019 08:09:06 +0000 (09:09 +0100)]
example - use LC_ALL not LC_MESSAGES for windows examples to build
so they don't need evil anymore. should help vtorri + windows
port/support.
Carsten Haitzler (Rasterman) [Mon, 17 Jun 2019 08:08:24 +0000 (09:08 +0100)]
example - use putenev, not sentenv to be more portable
yes - it's much more code too. that's life with putenv().
Carsten Haitzler (Rasterman) [Sat, 15 Jun 2019 08:38:06 +0000 (09:38 +0100)]
evas optimization - fix the "start in list middle" case
i missed 1 rare case where we start in the middle of the list and have
to walk to the end. testing didnt show it up. fix. this fixes up that
case in
b5ed76ba9f22ea659e9e6a3daa32c68354920455
Carsten Haitzler (Rasterman) [Sat, 15 Jun 2019 08:31:51 +0000 (09:31 +0100)]
optimize - avoid eina_inlist_last where not needed
really minor places.
Carsten Haitzler (Rasterman) [Sat, 15 Jun 2019 08:19:20 +0000 (09:19 +0100)]
evas - pointer in get - dont On walk inlist but O1 jump to last
to walk inreverse we need to jump to last first then walk backwards...
what we were doing is calling eina_inlist_last() which is defined to
walk rather than that using list->last ... this totally got rid of
_evas_event_object_list_raw_in_get() from my perf list ... and i was
wondering how it got there to start with.
this is such an obvious optimization...
Carsten Haitzler (Rasterman) [Fri, 14 Jun 2019 23:33:08 +0000 (00:33 +0100)]
edje messages - use trash to keep message structs around for a short time
more optimizations for edje messages to avoid excess alloc and frees
if we have some trash around... since messages already have list
nodes, re-use the main list node for storing trash and not eina trash
as this avoids extra allocs for trash nodes.
Carsten Haitzler (Rasterman) [Fri, 14 Jun 2019 23:06:42 +0000 (00:06 +0100)]
edje messages - on del use the per edje message list not global
this massively cuts the walk to remove messages to only what's needed
on teardown ... so yay! speedup.
Carsten Haitzler (Rasterman) [Fri, 14 Jun 2019 22:55:53 +0000 (23:55 +0100)]
edje messages - avoid nasty On2 walk of message lists with skipping
so to process a single obj we added a lot of mesgs to the message
queueue only then to wak most and SKIP most msgs again and again -
when this adds up to 1000's of messages and 10k+ then literally moving
a window in e hangs for multiple seconds and we walk such lists in On2
like complexity. this gets it down to O(1) along with some other minor
optimizations of not adding to tmp list only then to add them to the
nex queue/list.
there is more i can optimize here as well now we track messages for an
edje in th edje. that's next.
Carsten Haitzler (Rasterman) [Fri, 14 Jun 2019 21:49:25 +0000 (22:49 +0100)]
edje messages - track all messages for an edge obj in the edje
this is the basis for some future speedups to avoid full message queue
walks - get this right first.
Carsten Haitzler (Rasterman) [Fri, 14 Jun 2019 19:39:39 +0000 (20:39 +0100)]
edje messages - make it use inlist to fragment ram less
using regular lists means we double our indirect ptr jumps and
fragment ram more - this is step one in improving performance of
message handling in some nasty corner cases i have found. first this
so it can be identified as an issue on its own if it is one. i've
tested it and it seems ok. so this si stage 1.
Xavi Artigas [Fri, 14 Jun 2019 16:03:32 +0000 (12:03 -0400)]
Efl.Ui.Slider: Rename event delay,changed to steady
Summary:
And update the docs to explain its purpose.
Related to T7893
Test Plan: Everything builds and tests pass
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9090
Marcel Hollerbach [Thu, 13 Jun 2019 13:21:38 +0000 (09:21 -0400)]
efl_ui_check: make it undependend of nstate
Summary:
check can only display 2 states, and is only designed to do so.
Additionally, nstate inherits from button, which
brings in autorepeat, which is hileriously broken on check and cannot
really work.
Right now there is not even support in the theme for clickable. So its a
good idea to get rid of this for now IMO.
ref T7865
Reviewers: stefan_schmidt, zmike, segfaultxavi, akanad, YOhoho
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7865, T7867
Differential Revision: https://phab.enlightenment.org/D9018
JunsuChoi [Thu, 13 Jun 2019 04:55:29 +0000 (13:55 +0900)]
efl_canvas_vg_container: Initialize alpha color
Summary:
The vg object (container, shape, ...) follows color of VG node data.
The color of node data is not initialized. it can set the required color for each object.
vg container should be layer with an alpha value of 255.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, kimcinoo, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9083
Change-Id: I232ffdb71dd8bb64ca16e30c60016f00c384790d
Stefan Schmidt [Wed, 12 Jun 2019 15:44:05 +0000 (11:44 -0400)]
ci: travis: switch to newer distro releases
Summary:
We follow Debian 9.9, Ubuntu 19.04 and Fedora 30 releases.
Also adding a build for Ubuntu 18.04 LTS to the cron job.
Not all jobs are updated yet as some experience failures
(old or new versions) which need to be understand and fixed
before we move on.
Reviewers: zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9088
Mike Blumenkrantz [Wed, 12 Jun 2019 12:54:20 +0000 (08:54 -0400)]
tests/efl_ui: remove unnecessary shutdown fixture code
Summary: this is automatically handled by elm_shutdown at the end of every test
Reviewers: YOhoho
Reviewed By: YOhoho
Subscribers: YOhoho, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9087
Yeongjong Lee [Thu, 30 May 2019 04:23:36 +0000 (13:23 +0900)]
ecore_evas_wayland_common: remove unused variable
Change-Id: Ife5f51016bd2fd72fdd23e23c8cc4a0c453ebecb
JunsuChoi [Tue, 11 Jun 2019 10:01:11 +0000 (19:01 +0900)]
vg_common_json: Set container's alpha color
Summary: If the layer has an alpha value, we have make it available to container.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, kimcinoo, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9081
Change-Id: I6e28865b2371fc6a523d28b51a62f805d7571398
JunsuChoi [Thu, 13 Jun 2019 04:55:29 +0000 (13:55 +0900)]
efl_canvas_vg_container: Initialize alpha color
Summary:
The vg object (container, shape, ...) follows color of VG node data.
The color of node data is not initialized. it can set the required color for each object.
vg container should be layer with an alpha value of 255.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, kimcinoo, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9083
Change-Id: Ie5334d86e21c840ef3bf09df503ed6bfce42b839
Yeongjong Lee [Thu, 30 May 2019 04:18:47 +0000 (13:18 +0900)]
ecore_evas_tbm: return int type instead of null pointer
This patch fixes complier warning
```
modules/ecore_evas/engines/tbm/ecore_evas_tbm.c: In function 'ecore_evas_tbm_stride_get':
../src/lib/eina/eina_safety_checks.h:130:20: warning: return makes integer from pointer without a cast [-Wint-conversion]
return (val);
^
```
Change-Id: I3ca91052905b10193de8f92de91fa08d46000444
Jaehyun Cho [Mon, 17 Jun 2019 12:20:53 +0000 (21:20 +0900)]
evas_object_text_block: fix halign_set to work
New format's halign and halign_auto were initialized with default values
after the new format copied halign and halign_auto from original format.
This caused that the halign value given by halign_set was not applied.
To keep backward compatibility and to resolve the bug, halign and
halign_auto are initialized only for legacy textblock.
Change-Id: I9639fcea898c4bea41c1eed6c91cffd7feadd695
Jaehyun Cho [Wed, 12 Jun 2019 02:44:09 +0000 (11:44 +0900)]
ecore_evas: set maximized value using the client set
tizen enligthenment didn't suppor maximized window type.
so, client should not expect server send ZXDG_TOPLEVEL_V6_STATE_MAXIMIZED state in
_zxdg_toplevel_cb_configure function.
In tizen, we set ecore_evas's maximized value using the value set by client
This patch refers
47a38e1591fe84979f5797488da4dafe949d3e26
Change-Id: Id70b2819516d494bb6978ebdaa7c91bfa6c29224
Yeongjong Lee [Thu, 13 Jun 2019 02:08:35 +0000 (11:08 +0900)]
elm_focus: fix build warning related to elm_focus
1. Remove unimplemented function.
2. Fix correct function name.
Change-Id: I57be6d819ffa87c3a1d030d6c9c3fee539597ba1
Hosang Kim [Thu, 13 Jun 2019 04:42:10 +0000 (13:42 +0900)]
ecore_evas: fix build warning
add missed wayland-tbm-client header
Change-Id: I492d3d7da214d8ae26d6713e9c74895b82e5bc90
Hosang Kim [Thu, 13 Jun 2019 04:10:52 +0000 (13:10 +0900)]
ecore_con: fix build warning
add missing function to header
Change-Id: I45719a04d0bd2e56875e430743c06cbeb0578f3f
Xavi Artigas [Tue, 11 Jun 2019 17:57:24 +0000 (19:57 +0200)]
docfx: Only add media files in use to the final docs
The setup script copied ALL media files, but only the C# tutorials and guides.
A lot of space can be saved in the generated _site folder if only the media
files relevant to C# are copied.
Carsten Haitzler (Rasterman) [Tue, 11 Jun 2019 17:30:41 +0000 (18:30 +0100)]
efl sel manager - flush wl conenction in cnp to avoid hangs...
we don't force buffers to flush in wl... this will fix that and force
them removing an ugly hang for possibly seconds in cnp from client to
client or even within a client.
remember:
flush your mush.
@fix
Christopher Michael [Tue, 11 Jun 2019 13:47:00 +0000 (09:47 -0400)]
ecore-wl2: Add TODO notes for missing doxygen
I have marked these as TODO (for doxygen) because we still need to
determine if we are keeping these functions in the public API
ref T8014
Christopher Michael [Tue, 11 Jun 2019 13:45:08 +0000 (09:45 -0400)]
ecore-wl2: Add doxygen for ecore_wl2_input_seat_get
ref T8014
Christopher Michael [Tue, 11 Jun 2019 13:36:05 +0000 (09:36 -0400)]
ecore-wl2: Add missing doxygen for ecore_wl2_window_display_get
ref T8014
Jongmin Lee [Tue, 11 Jun 2019 12:27:49 +0000 (08:27 -0400)]
elm/interface_scrollable: check parameters before using them
Summary: it crashes when calling elm_interface_scrollable_loop_get() function with NULL parameters.
Test Plan: call elm_interface_scrollable_loop_get() function with NULL parameters.
Reviewers: Hermet, woohyun, kimcinoo, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9082
Woochanlee [Tue, 11 Jun 2019 07:17:47 +0000 (16:17 +0900)]
efl_ui_win: Added more gesture config values for gesture manager.
Summary:
https://phab.enlightenment.org/T7544
This is for set config values for gesture manager.
C# will use gesture manager instead of elm_gesture_layer.
Those config values should import to gesture manager to recognize and handle gestures.
Reviewers: segfaultxavi, stefan_schmidt, bu5hm4n, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Jaehyun_Cho, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7962
Mike Blumenkrantz [Mon, 10 Jun 2019 13:54:22 +0000 (09:54 -0400)]
tests/efl_ui: reset active view counter structs between tests
Summary: this fixes running the tests with CK_FORK=no
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9080
Mike Blumenkrantz [Mon, 10 Jun 2019 12:57:35 +0000 (08:57 -0400)]
efl-wl: add missing docs for efl_wl_global_add()
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8900
Marcel Hollerbach [Mon, 10 Jun 2019 12:49:03 +0000 (08:49 -0400)]
meson: fix cmake generation
Summary:
there were missing Version files. These are generated now. Tested and
verified with ecrire.
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9054
Mike Blumenkrantz [Mon, 10 Jun 2019 12:44:33 +0000 (08:44 -0400)]
theme: fix fileselector search button layout
Summary:
to correctly (and quickly) calculate part geometry when setting a part relative
to another part, align must be set on the axis that is relative to another part.
also since the height on this part should not be changing, set fixed on the
vertical axis to optimize geometry calcs
@fix
Depends on D9009
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9010
Marcel Hollerbach [Sun, 9 Jun 2019 11:14:57 +0000 (13:14 +0200)]
edje_cc: protect array lookup
it seems with those two actions here in the commit, do use id in a
different way the other actions do. This is commit protects against
this.
Differential Revision: https://phab.enlightenment.org/D9078
Alastair Poole [Fri, 7 Jun 2019 19:34:19 +0000 (19:34 +0000)]
edje_cc_out: Exit instead of segfault on OpenBSD.
Until the cause of these issues can be found exit and
print error messages to console. edje_cc is currently
not reliable on OpenBSD. Until then anyone wanting to
use EFL on this platform will need pre-compiled .edj
files.
Differential Revision: https://phab.enlightenment.org/D9077
Marcel Hollerbach [Tue, 4 Jun 2019 18:11:43 +0000 (20:11 +0200)]
efl_ui_active_view: fix view_manager_scroll
the problem that can be observed when clicking permanently on a view in
the view_manager_scroll. You will see things jump arround uncontrolled,
then when you quickly drag and drop, you will also see a lot of weird
moving arround artifacts. The reason for this is, that progress was not
correctly resetted, additionally, mouse_active also was not resetted
correctly in one case.
fix T7988
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9074
Marcel Hollerbach [Tue, 4 Jun 2019 17:55:50 +0000 (19:55 +0200)]
efl_ui_active_view: fix plain view_manager
the problem here is, when we update content. We need to unset visibility
to the *old* content, and set visibility to the *new* content. This is
now finally fixed.
fix T8002
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9073
Carsten Haitzler (Rasterman) [Thu, 6 Jun 2019 12:52:20 +0000 (13:52 +0100)]
efreetd - timeout in 2 not 10sec to have fewer hangs on shutdown/exit
Cedric BAIL [Wed, 5 Jun 2019 20:23:45 +0000 (13:23 -0700)]
eio: fix Efl.Io.Model properties iterator.
It kind of worked by luck for 6 months, but really shouldn't. This
is now a custom iterator that will walk the string part of the properties
only. It could become a generic iterator if necessary one day, but
for now, it is fine just here.
T7771
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9075
Woochanlee [Wed, 5 Jun 2019 11:31:19 +0000 (20:31 +0900)]
efl_gesture_manager: Delete type property.
Summary:
User already know the gesture type.
And the gesture type(Efl.Event.Description) can't using after binding.
T7959
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7959
Differential Revision: https://phab.enlightenment.org/D9033
Carsten Haitzler (Rasterman) [Tue, 4 Jun 2019 14:23:29 +0000 (15:23 +0100)]
ecore_evas wl - make ERR's into WRNS as they really are just that
Jaehyun Cho [Tue, 4 Jun 2019 12:49:08 +0000 (21:49 +0900)]
efl_canvas_animation: fix final_state_keep logic
Previously, final_state_keep did not work correctly with animation
repeat.
e.g. repeat mode is restart and repeat count is 1, then final_state_keep
did not work.
Now, final_state_keep logic has been fixed to work correctly.
Jaehyun Cho [Tue, 4 Jun 2019 09:52:14 +0000 (18:52 +0900)]
efl_canvas_animation: fix numerical error on map effect calculation
Previously, for a single canvas animation, map effect was applied in
animator callback without resetting previously applied map effect.
This increased numerical error because each time map effect factors
(e.g. scale, degree) should be calculated based on the current map
coordinates.
To resolve this numerical error, now the previously applied map effect
is reset before applying the current map effect in animator callback.
Taehyub Kim [Tue, 4 Jun 2019 11:14:03 +0000 (20:14 +0900)]
efl_ui_layout_orientation: fix the bitwise condition logic
Summary: fix the bitwise condition logic
Reviewers: Jaehyun_Cho, zmike
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9067
Carsten Haitzler (Rasterman) [Tue, 4 Jun 2019 00:14:20 +0000 (02:14 +0200)]
efl proc/exe envrion work again - after a break earlier on freebsd
efl seemingly has been broken on freebsd for a while - environ the
symbol does not exist for SHARED LIBS on freebsd (discussin had been
had on this already, but i gave up). use dlsym as the escape mechanism
so we build on freebsd again.
Carsten Haitzler (Rasterman) [Tue, 4 Jun 2019 00:13:16 +0000 (02:13 +0200)]
elm - tests - generator - be python2 explicit so we build on freebsd
no python bonary there (no symplink) but need to be explicit about
python2 or 3 - so do so and we now build on freebsd...
Mike Blumenkrantz [Mon, 3 Jun 2019 16:55:59 +0000 (12:55 -0400)]
elm_test/ui.bg: use full white+opaque for unchecked 'bg color' state
Summary:
using 0,0,0 (black) with 0 alpha (transparent) here causes the clipper for the
image to draw a fully transparent rectangle, which means that no pixels for
the clipped image are visible.
the expectation when using this test is that enabling the bg color will shade
the image with a red tint, and disabling the bg color will return the image to
its normal color. the current version of this test gives the impression that
disabling the color setting on this widget breaks the widget, which is not
accurate. currently.
fix T7984
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7984
Differential Revision: https://phab.enlightenment.org/D9066
Marcel Hollerbach [Mon, 3 Jun 2019 12:46:29 +0000 (08:46 -0400)]
meson: remove unneeded install: flags
Summary:
when install is not set, meson take the value of install_dir. So when
this is removed, things will continue working correctly.
Reviewers: zmike, stefan_schmidt, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9065
Jaehyun Cho [Wed, 22 May 2019 04:17:39 +0000 (13:17 +0900)]
ecore_wl2: fix to update "fullscreen", "maximized" properties of ecore_evas
Previously, elm_win_fullscreen_set and elm_win_maximized_set did not
work on wayland because the window properties of ecore_evas were not
updated.
The window properties of ecore_evas are updated in
_ecore_evas_wl_common_cb_window_configure.
To call _ecore_evas_wl_common_cb_window_configure,
ECORE_WL2_EVENT_WINDOW_CONFIGURE event is added.
To add ECORE_WL2_EVENT_WINDOW_CONFIGURE event,
_ecore_wl2_window_configure_send is called.
Now, by calling _ecore_wl2_window_configure_send after modifying window
properties of ecore_wl2, the window properties of ecore_evas are updated
in _ecore_evas_wl_common_cb_window_configure correctly.
Change-Id: I448b9f294aa7d1b4b9b218612beebf34b2cc56cf
SangHyeon Jade Lee [Mon, 10 Jun 2019 11:36:36 +0000 (20:36 +0900)]
genlist : fix item lost highlight at the end of scroll
adjusted item can be last item or NULL,
as the position is out of boundary,
but they are not centered item, so highlight could be disappear.
limiting the adjusted item for the previous one of last item
solve the issue.
Change-Id: Id032bb63b00c4d025653c34ce59246fa7661ae2c
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Hermet Park [Wed, 5 Jun 2019 07:42:15 +0000 (16:42 +0900)]
canvas vg: optmize lottie vector tree.
Skip invisible stroke nodes as possible.
Change-Id: I124a0eb7faf3891eb65602392775fa20dda3796c
Taehyub Kim [Tue, 4 Jun 2019 11:19:15 +0000 (20:19 +0900)]
evas_out: fix the condition logic for evas_output_view_set
Change-Id: I0c3727c11435c74b55a1043ae326f2a25022257f
SangHyeon Jade Lee [Tue, 4 Jun 2019 08:32:42 +0000 (17:32 +0900)]
genlist: fix the issue on genlist disappeared focus
Change-Id: Ibbea245d21c3e536932d7420e3e071186d6b7de9
Hermet Park [Tue, 4 Jun 2019 04:42:26 +0000 (13:42 +0900)]
efl_ui_animation_view: access only valid transit.
Change-Id: Ia292e1091daa9f2245a7ebe3aeaaf8edb2af026a
Yeongjong Lee [Thu, 30 May 2019 04:14:35 +0000 (13:14 +0900)]
ecore_wl2_display: remove unused variable
Change-Id: I10d053c8467e3cc7c265301def2c38121701fda2
Yeongjong Lee [Thu, 30 May 2019 04:02:16 +0000 (13:02 +0900)]
ecore_wl2_tbmsurface: remove unused variable
ref
507f7293ed7ab5e5c3608a1d7017c403f5fb31b8
Change-Id: Ibf3da29ad8606f192a68f4a92c2c2ae6077b0921
Yeongjong Lee [Thu, 30 May 2019 03:46:40 +0000 (12:46 +0900)]
ecore_wl2_tbmsurface: add purge option to surface flush
This patch fixes compiler warning
`lib/ecore_wl2/ecore_wl2_tbmsurface.c:419:13: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
.flush = _evas_tbmbuf_surface_flush,`
ref
486cc513aabde061d9ead25b7e5f4b0814a023a1
Change-Id: Ib93127fbe33c197d1308ad57151b24804f23b682
Yeongjong Lee [Thu, 30 May 2019 03:44:31 +0000 (12:44 +0900)]
ecore_wl2_tbmsurface: add missing EINA_UNUSED
Change-Id: Ie36e5a31b95f65e0797e6072c564fdb1ec288a0a
Wonki Kim [Mon, 3 Jun 2019 08:04:37 +0000 (17:04 +0900)]
build: fix a tizen am file to follow convention
Change-Id: I3033a39d548cabf87d5b4648e2146a938302b17c