profile/ivi/webkit-efl.git
12 years agoWeb Inspector: don't report context ids before DidCommitLoad
yurys@chromium.org [Wed, 20 Jun 2012 15:07:28 +0000 (15:07 +0000)]
Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567

Reviewed by Pavel Feldman.

When inspector state is restored only report existing context ids
if "did commit load" even has already been dispatched.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::restore):
* inspector/PageRuntimeAgent.h:
(WebCore):
(WebCore::PageRuntimeAgent::create):
(PageRuntimeAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
ossy@webkit.org [Wed, 20 Jun 2012 15:03:23 +0000 (15:03 +0000)]
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
https://bugs.webkit.org/show_bug.cgi?id=67935

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-06-20
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Remove redundant #includes in compositor
commit-queue@webkit.org [Wed, 20 Jun 2012 13:52:50 +0000 (13:52 +0000)]
[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.

Source/WebCore:

Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.

No new tests are required, as this is only affects compile-time behavior.

* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/Canvas2DLayerBridge.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ProgramBinding.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureManager.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
* platform/graphics/chromium/cc/CCProxy.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCRenderer.h:
* platform/graphics/chromium/cc/CCScopedThreadProxy.h:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCTimer.cpp:
* platform/graphics/chromium/cc/CCTimer.h:
(WebCore):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

Minor adjustments to #include statements to remove
dependencies. No new tests.

* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
* tests/CCLayerTestCommon.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerImplTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Implement native memory bar diagram
commit-queue@webkit.org [Wed, 20 Jun 2012 13:32:16 +0000 (13:32 +0000)]
Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-20
Reviewed by Yury Semikhatsky.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
(WebInspector.NativeMemoryBarChart.prototype.willHide):
(WebInspector.NativeMemoryBarChart.prototype.wasShown):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-name):
(.memory-bar-chart-bar):
(.memory-bar-chart-size):
(.memory-bar-chart-total):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION (120705) : LayerTreeHostQt asserts in debug.
alexis.menard@openbossa.org [Wed, 20 Jun 2012 13:26:56 +0000 (13:26 +0000)]
REGRESSION (120705) : LayerTreeHostQt asserts in debug.
https://bugs.webkit.org/show_bug.cgi?id=89487

Reviewed by Noam Rosenthal.

We try to call createHandle twice on the same handle when the
first matching atlas is full. This patch solved the problem by
moving the createHandle call inside UpdateAtlas and call createHandle
only when the atlas is not full. We can also remove the surface()
getter as it is not used anymore.

* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlas):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::beginContentUpdate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeech JavaScript API: add SpeechRecognition.maxAlternatives attribute
hans@chromium.org [Wed, 20 Jun 2012 12:35:41 +0000 (12:35 +0000)]
Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute
https://bugs.webkit.org/show_bug.cgi?id=89459

Reviewed by Eric Seidel.

Source/WebCore:

Add the SpeechRecognition.maxAlternatives attribute.

Test: fast/speech/scripted/basics.html:

* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::SpeechRecognition):
* Modules/speech/SpeechRecognition.h:
(WebCore::SpeechRecognition::maxAlternatives):
(WebCore::SpeechRecognition::setMaxAlternatives):
(SpeechRecognition):
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechRecognitionClient.h:
(SpeechRecognitionClient):
* Modules/speech/SpeechRecognitionController.h:
(WebCore::SpeechRecognitionController::start):
(SpeechRecognitionController):

Source/WebKit/chromium:

Plumbing for the maxAlternatives attribute.

* public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::maxAlternatives):
(WebSpeechRecognitionParams):
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):

LayoutTests:

Update the basic test to check for presence of the maxAlternatives attribute.

* fast/speech/scripted/basics-expected.txt:
* fast/speech/scripted/basics.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoapplyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable.
commit-queue@webkit.org [Wed, 20 Jun 2012 11:48:24 +0000 (11:48 +0000)]
applyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable.
https://bugs.webkit.org/show_bug.cgi?id=89061

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-20
Reviewed by Dimitri Glazkov.

Source/WebCore:

Fixing apply-author-styles bug. If there exists some shadow subtree A
and A has apply-author-styles flag set, whether some rules declared in
a tree B is applicable in A or not depends on:
- the tree B encloses the tree A, and
- all trees which enclose A and are enclosed by B has
  apply-author-styles set.
c.f.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles
However the second rule was not implemented.

Test: fast/css/style-scoped/style-scoped-apply-author-styles.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::setupScopeStack):
Modified to add a new member variable, authorStyleBoundsIndex to
ScopeStackFrame used by m_scopeStack. The index means: if shadow dom
subtree A and B has the same value and A encloses B, all shadow dom
subtrees which enclose B and are enclosed by B have
apply-author-styles set. And B also has apply-author-styles set.
This means, if some element X has authorStyleBoundsIndex N, all
rulesets whose scopes have authorStyleBoundsIndex N are applicable in
B's tree scope. If all shadow dom subtrees have apply-author-styles
unset, the index looks almost the same as treeScope(). In this case,
Rules in different tree scopes have different author style bounds
index.
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
Added the code for updating m_scopeStackParentBoundsIndex. The member
variable keeps m_scopeStackParent's author style bounds index.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to consider author style's bounds index. Firstly applying
scoped styles declared in document if apply-author-styles is set.
Next, applying scoped styles declared in shadow dom subtree with
considering author style bounds index, i.e. considering
apply-author-styles flag.
* css/StyleResolver.h:
(WebCore::StyleResolver::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
Added m_authorStyleBoundsIndex to keep apply-author-styles flag
information. m_authorStyleBoundsIndex increments by 1 if shadow root is
given and it has apply-author-styles unset.
Now rules in the same authorStyleBoundsIndex should be applied.
(StyleResolver):
Added m_scopeStackParentBoundsIndex.
As m_scopeStackParentAuthorStyleBoundsIndex is a little long,
used m_scopeStackParentBoundsIndex.

LayoutTests:

* fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt: Added.
* fast/css/style-scoped/style-scoped-apply-author-styles.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed trivial permissions fix.
hausmann@webkit.org [Wed, 20 Jun 2012 11:07:53 +0000 (11:07 +0000)]
Unreviewed trivial permissions fix.

* qmake/mkspecs/features/features.prf: Don't mark this file as executable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds DeviceMotionClientMock
commit-queue@webkit.org [Wed, 20 Jun 2012 10:36:50 +0000 (10:36 +0000)]
Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-20
Reviewed by Steve Block.

No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.

Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/mock/DeviceMotionClientMock.cpp: Added.
(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):
* platform/mock/DeviceMotionClientMock.h: Added.
(WebCore):
(DeviceMotionClientMock):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed build fix
hausmann@webkit.org [Wed, 20 Jun 2012 09:58:22 +0000 (09:58 +0000)]
[Qt] Unreviewed build fix

The platform plugin example uses QGridLayout and thus needs QT += widgets

* examples/platformplugin/platformplugin.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed GTK gardening. Removed some tests from TestExpectations
sergio@webkit.org [Wed, 20 Jun 2012 08:47:23 +0000 (08:47 +0000)]
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed rebaselining.
morrita@google.com [Wed, 20 Jun 2012 07:54:17 +0000 (07:54 +0000)]
Unreviewed rebaselining.

* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Select the marker range when right-clicking on a marker.
hbono@chromium.org [Wed, 20 Jun 2012 07:00:34 +0000 (07:00 +0000)]
[chromium] Select the marker range when right-clicking on a marker.
https://bugs.webkit.org/show_bug.cgi?id=89331

Reviewed by Hajime Morita.

Chromium always selects only one word when right-clicking on a spelling marker.
This prevents selecting whole region specified by a marker if the marker
consists of two or more words. This change retrieves a range coverted by a
marker and select the range. This emulates the behavior of Mac Chromium and it
does not need any workarounds for Mac.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Clicking "Clear all profiles" while ongoing recording should reset...
commit-queue@webkit.org [Wed, 20 Jun 2012 06:51:34 +0000 (06:51 +0000)]
Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView
https://bugs.webkit.org/show_bug.cgi?id=89464

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.

Resetting the ProfileLauncherView in order to reflect the correct states of buttons

No new tests as UI related minor fix.

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][Mac] Speculative skipping to try to paint the bot green.
ossy@webkit.org [Wed, 20 Jun 2012 06:46:31 +0000 (06:46 +0000)]
[Qt][Mac] Speculative skipping to try to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][Regression] Build break after r120786
ryuan.choi@samsung.com [Wed, 20 Jun 2012 06:30:00 +0000 (06:30 +0000)]
[EFL][Regression] Build break after r120786
https://bugs.webkit.org/show_bug.cgi?id=89549

Unreviewed build fix for Efl port.

Source/WebKit2:

* CMakeLists.txt: Added disassembler in includes.

Tools:

* DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAssertion for event's target is wrong.
hayato@chromium.org [Wed, 20 Jun 2012 06:29:59 +0000 (06:29 +0000)]
Assertion for event's target is wrong.
https://bugs.webkit.org/show_bug.cgi?id=89479

Reviewed by Hajime Morita.

Fix an assertion to ensure that event's target is reachable from a current target.

No new tests. Fix an assert condition.

* dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
* dom/EventContext.h:
(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::isUnreachableNode):
(WebCore):
(WebCore::EventContext::isReachable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CMake] Unreviewed speculative buildfix after r120786.
ossy@webkit.org [Wed, 20 Jun 2012 06:23:13 +0000 (06:23 +0000)]
[CMake] Unreviewed speculative buildfix after r120786.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRefactoring: Geolocation::startRequest() should not create the GeoNotifiers
benjamin@webkit.org [Wed, 20 Jun 2012 06:03:07 +0000 (06:03 +0000)]
Refactoring: Geolocation::startRequest() should not create the GeoNotifiers
https://bugs.webkit.org/show_bug.cgi?id=89533

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-06-19
Reviewed by David Kilzer.

It was odd to create the GeoNotifiers in Geolocation::startRequest() and having
assertions from the call site.

This patch move GeoNotifiers initialization to the exposed methods and pass them to
startRequest() as needed.
This will also help when adding support for dynamic permission reset and suspend/resume.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):
* Modules/geolocation/Geolocation.h:
(Geolocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRefine syncLayersTimeoutCallback for Accelerated Compositing.
commit-queue@webkit.org [Wed, 20 Jun 2012 05:51:07 +0000 (05:51 +0000)]
Refine syncLayersTimeoutCallback for Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=89538

Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-06-19
Reviewed by Martin Robinson.

syncLayersTimeout reschedules the timer so that it can render each frame
every 1/60 seconds on animation. However, because it takes to time to execute
renderLayersToWindow, the timer is delayed. To fix this, we must reschedule
the timer before calling renderLayersToWindow.

* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][Mac] Skip one more crashing test.
ossy@webkit.org [Wed, 20 Jun 2012 05:40:07 +0000 (05:40 +0000)]
[Qt][Mac] Skip one more crashing test.

* platform/qt-mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Fixes condition where inserting a CounterNode subtree which could...
cdn@chromium.org [Wed, 20 Jun 2012 05:36:27 +0000 (05:36 +0000)]
Source/WebCore: Fixes condition where inserting a CounterNode subtree which could result in incorrect placement.
https://bugs.webkit.org/show_bug.cgi?id=88142

Reviewed by Adam Barth.

Test: fast/css/counters/counter-reset-subtree-insert-crash.html

* rendering/CounterNode.cpp:
(WebCore::CounterNode::insertAfter):

LayoutTests: Add test which inserts a CounterNode subtree which contains reset nodes into another tree.
https://bugs.webkit.org/show_bug.cgi?id=88142

Reviewed by Adam Barth.

* fast/css/counters/counter-reset-subtree-insert-crash-expected.txt: Added.
* fast/css/counters/counter-reset-subtree-insert-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed expected update after r120735.
ossy@webkit.org [Wed, 20 Jun 2012 05:34:01 +0000 (05:34 +0000)]
Unreviewed expected update after r120735.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed buildfix after r120790. Typo fix.
ossy@webkit.org [Wed, 20 Jun 2012 05:18:29 +0000 (05:18 +0000)]
[Qt] Unreviewed buildfix after r120790. Typo fix.

* platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse testRunner instead of layoutTestController in fast/{files,filesystem}
kinuko@chromium.org [Wed, 20 Jun 2012 05:12:22 +0000 (05:12 +0000)]
Use testRunner instead of layoutTestController in fast/{files,filesystem}
https://bugs.webkit.org/show_bug.cgi?id=89462

Reviewed by Ryosuke Niwa.

* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/blob-builder-crash.html:
* fast/files/blob-slice-overflow.html:
* fast/files/blob-slice-test.html:
* fast/files/create-blob-url-crash.html:
* fast/files/domurl-script-execution-context-crash.html:
* fast/files/file-reader-abort.html:
* fast/files/file-reader-directory-crash.html:
* fast/files/file-reader-event-listener.html:
* fast/files/file-reader-file-url.html:
* fast/files/file-reader-sandbox-iframe.html:
* fast/files/null-origin-string.html:
* fast/files/read-blob-async.html:
* fast/files/read-file-async.html:
* fast/files/resources/file-reader-real.html:
* fast/files/resources/setup-for-read-common.js:
* fast/files/revoke-blob-url.html:
* fast/files/script-tests/xhr-response-blob.js:
* fast/files/workers/inline-worker-via-blob-url.html:
* fast/files/workers/worker-apply-blob-url-to-xhr.html:
* fast/files/workers/worker-read-blob-async.html:
* fast/files/workers/worker-read-blob-sync.html:
* fast/files/workers/worker-read-file-async.html:
* fast/files/workers/worker-read-file-sync.html:
* fast/filesystem/cross-filesystem-op.html:
* fast/filesystem/file-after-reload-crash.html:
* fast/filesystem/file-metadata-after-write.html:
* fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
* fast/filesystem/filesystem-uri-origin.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Shadow DOM] ShadowRoot.host should be gone
commit-queue@webkit.org [Wed, 20 Jun 2012 04:31:37 +0000 (04:31 +0000)]
[Shadow DOM] ShadowRoot.host should be gone
https://bugs.webkit.org/show_bug.cgi?id=88387

Source/WebCore:

According to the w3c spec change,
i.e. https://www.w3.org/Bugs/Public/show_bug.cgi?id=16764
Removed host attribute from ShadowRoot.idl.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.

No new tests, because this change modified only idl.

* dom/ShadowRoot.idl:
Just removed host attribute.

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.

* fast/css/style-scoped/style-scoped-in-shadow-expected.txt:
* fast/css/style-scoped/style-scoped-in-shadow.html:
* fast/dom/shadow/resources/shadow-dom.js:
(isShadowRoot):
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:
Just removed references to shadow root's host attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix a form restore test broken by HTML5 parser
tkent@chromium.org [Wed, 20 Jun 2012 04:26:13 +0000 (04:26 +0000)]
Fix a form restore test broken by HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=89539

Reviewed by Kentaro Hara.

Before HTML5 parser, we parsed innerHTML input text and we attached
renderers to parsed nodes at the same time. The parsed nodes had
restored form values because we restore form values only for attached
elements.

After HTML5 parser, we don't attach renderers during innerHTML
parsing. state-restore-to-nonedited-controls.html used innerHTML to
built a form and the test haven't worked since introducing HTML5 parser.

This patch changes the test so that it uses document.write() instead of
innerHTML.

* fast/forms/state-restore-to-non-edited-controls-expected.txt:
Note that the FAIL line is expected. It's due to Bug 88685.
* fast/forms/state-restore-to-non-edited-controls.html:
Use document.write() instead of innerHTML.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNRWT spins up and down the WebSocket server when running a single HTTP test from...
dpranke@chromium.org [Wed, 20 Jun 2012 04:06:17 +0000 (04:06 +0000)]
NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
https://bugs.webkit.org/show_bug.cgi?id=64489

Reviewed by Tony Chang.

This change changes NRWT so that we don't start the websocket
server if we aren't running websocket tests and don't start the
HTTP server if we aren't running http tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._websocket_tests):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_servers_started):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agotest-webkitpy: add a -p flag to pass through captured output to enable debugging
dpranke@chromium.org [Wed, 20 Jun 2012 04:01:29 +0000 (04:01 +0000)]
test-webkitpy: add a -p flag to pass through captured output to enable debugging
https://bugs.webkit.org/show_bug.cgi?id=89158

Reviewed by Eric Seidel.

Normally when outputcapture runs it intercepts stdout/stderr,
which makes running under the debugger difficult and mostly
pointless (since you can't see any output). This change adds a
flag to test-webkitpy (-p) that will cause outputcapture to pass
through the output as well as capture it.

* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.stream_wrapper):
(OutputCapture._capture_output_with_name):
* Scripts/webkitpy/common/system/outputcapture_unittest.py:
(OutputCaptureTest.setUp):
* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester._run_tests):
(Tester._log_exception):
(_CaptureAndPassThroughStream):
(_CaptureAndPassThroughStream.__init__):
(_CaptureAndPassThroughStream.write):
(_CaptureAndPassThroughStream._message_is_from_pdb):
(_CaptureAndPassThroughStream.flush):
(_CaptureAndPassThroughStream.getvalue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTest fix after r120521.
rniwa@webkit.org [Wed, 20 Jun 2012 03:43:21 +0000 (03:43 +0000)]
Test fix after r120521.

* webarchive/resources/dump-webarchive.js:
* webarchive/test-duplicate-resources-expected.webarchive:
* webarchive/test-script-src-expected.webarchive:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse testRunner instead of layoutTestController in fast/doctypes, dom, dynamic, encodi...
rniwa@webkit.org [Wed, 20 Jun 2012 03:28:42 +0000 (03:28 +0000)]
Use testRunner instead of layoutTestController in fast/doctypes, dom, dynamic, encoding, events, eventsource, and exclusions tests
https://bugs.webkit.org/show_bug.cgi?id=89438

Reviewed by Tony Chang.

* fast/doctypes/005-case-preserving.html:
* fast/doctypes/doctype-after-comment.html:
* fast/doctypes/doctype-at-end.html:
* fast/doctypes/doctype-in-element.html:
* fast/doctypes/doctype-parsing.html:
* fast/doctypes/html-doctype.html:
* fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml:
* fast/doctypes/xml-doctype.xhtml:
* fast/dom/:
* fast/dynamic/5872671.html:
* fast/dynamic/ancestor-to-absolute.html:
* fast/dynamic/checkbox-selection-crash.html:
* fast/dynamic/containing-block-change.html:
* fast/dynamic/crash-generated-counter.html:
* fast/dynamic/crash-generated-image.html:
* fast/dynamic/crash-generated-quote.html:
* fast/dynamic/crash-generated-text.html:
* fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled:
* fast/dynamic/float-remove-above-line-2.html:
* fast/dynamic/float-remove-above-line.html:
* fast/dynamic/hover-before-position-after-style-change.html:
* fast/dynamic/hover-before-position-after-style-change2.html:
* fast/dynamic/hover-style-recalc-crash.html:
* fast/dynamic/hovered-detach.html:
* fast/dynamic/inline-to-block-crash.html:
* fast/dynamic/insertAdjacentElement.html:
* fast/dynamic/insertAdjacentHTML-allowed-parents.html:
* fast/dynamic/insertAdjacentHTML.html:
* fast/dynamic/insertAdjacentText.html:
* fast/dynamic/jQuery-animation-crash.html:
* fast/dynamic/layer-hit-test-crash.html:
* fast/dynamic/layer-no-longer-paginated.html:
* fast/dynamic/outerHTML-no-element.html:
* fast/dynamic/paused-event-dispatch.html:
* fast/dynamic/position-absolute-to-fixed-crash.html:
* fast/dynamic/position-change-layout.html:
* fast/dynamic/recursive-layout.html:
* fast/dynamic/style-access-late-stylesheet-load.html:
* fast/dynamic/subtree-common-root.html:
* fast/dynamic/subtree-table-cell-height.html:
* fast/dynamic/subtree-unrooted.html:
* fast/encoding/:
* fast/events/:
* platform/chromium/fast/events/drag-downloadURL.html:
* platform/chromium/fast/events/intercept-postmessage.html:
* platform/chromium/fast/events/rtl-scrollbar.html:
* platform/gtk/fast/events/event-sender-metakey.html:
* platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html:
* platform/mac/fast/dom/character-index-for-point.html:
* platform/mac/fast/dom/objc-wrapper-identity.html:
* platform/mac/fast/dom/wrapper-classes-objc.html:
* platform/mac/fast/dom/wrapper-round-tripping.html:
* platform/mac/fast/events/objc-event-api.html:
* platform/mac/fast/events/objc-keyboard-event-creation.html:
* platform/qt/fast/events/event-sender-keydown-frame.html:
* platform/win/fast/events/alt-numpad.html:
* platform/win/fast/events/alt-space-scroll.html:
* platform/win/fast/events/double-dead-char.html:
* platform/win/fast/events/keyLocation-numpad.html:
* platform/win/fast/events/panScroll-correct-direction.html:
* platform/win/fast/events/panScroll-event-fired.html:
* platform/win/fast/events/panScroll-image-no-scroll.html:
* platform/win/fast/events/panScroll-imageMap-href-no-scroll.html:
* platform/win/fast/events/panScroll-imageMap-noHref-scroll.html:
* platform/win/fast/events/panScroll-nested-divs.html:
* platform/win/fast/events/panScroll-no-iframe-jump.html:
* platform/win/fast/events/panScroll-preventDefault.html:
* platform/win/fast/events/script-tests/context-click-events.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPass ScriptValue by const ref where possible
adamk@chromium.org [Wed, 20 Jun 2012 03:27:27 +0000 (03:27 +0000)]
Pass ScriptValue by const ref where possible
https://bugs.webkit.org/show_bug.cgi?id=89531

Reviewed by Kentaro Hara.

Previously ScriptValue was sometimes passed by value, sometimes by const ref.

For consistency and optimality, pass by const ref everywhere (except where
ScriptValue is returned from non-accessor methods).

No new tests, no change in behavior.

* bindings/js/ScriptFunctionCall.h:
(ScriptCallback):
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
* bindings/js/ScriptProfiler.h:
(ScriptProfiler):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::setException):
* bindings/js/WorkerScriptController.h:
(WorkerScriptController):
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::ScriptCallback):
* bindings/v8/ScriptFunctionCall.h:
(ScriptCallback):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(ScriptProfiler):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::operator!=):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::setException):
* bindings/v8/WorkerScriptController.h:
(WorkerScriptController):
* css/MediaQueryListListener.h:
(WebCore::MediaQueryListListener::create):
(WebCore::MediaQueryListListener::MediaQueryListListener):
* dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
* dom/CustomEvent.h:
(CustomEvent):
(WebCore::CustomEvent::detail):
* dom/MessageEvent.h:
(WebCore::MessageEvent::dataAsScriptValue):
* dom/PopStateEvent.h:
(WebCore::PopStateEvent::state):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
* inspector/InjectedScript.h:
(InjectedScript):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GStreamer] 0.11 video-sink
philn@webkit.org [Wed, 20 Jun 2012 02:25:14 +0000 (02:25 +0000)]
[GStreamer] 0.11 video-sink
https://bugs.webkit.org/show_bug.cgi?id=77087

Reviewed by Martin Robinson.

* configure.ac: Fix required gstreamer 0.11 version

Source/WebCore:

Port the video sink to GStreamer 0.11 APIs. There is no change in
functionality compared to 0.10, for now.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGetVideoSizeAndFormatFromCaps):
(webkitGstCreateBuffer):
* platform/graphics/gstreamer/GStreamerVersioning.h:
(WebCore):
* platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::createImage):
(WebCore::ImageGStreamer::setCropRect):
(WebCore::ImageGStreamer::rect):
(ImageGStreamer):
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
* platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(_WebKitVideoSinkPrivate):
(webkitVideoSinkRender):
(webkitVideoSinkProposeAllocation):
(webkit_video_sink_class_init):
* platform/graphics/gstreamer/VideoSinkGStreamer.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd monitor profile support for Win
commit-queue@webkit.org [Wed, 20 Jun 2012 02:15:00 +0000 (02:15 +0000)]
Add monitor profile support for Win
https://bugs.webkit.org/show_bug.cgi?id=88565

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-19
Reviewed by Eric Seidel.

Source/Platform:

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::screenColorProfile):

Source/WebCore:

Tests: fast/images/jpeg-with-color-profile.html
fast/images/png-with-color-profile.html. Also covered by numerous
layout tests.

* WebCore.gyp/WebCore.gyp:
* platform/PlatformScreen.h:
(WebCore):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenColorProfile):
(WebCore):
* platform/image-decoders/ImageDecoder.h:
(ImageFrame):
(ImageDecoder):
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(turboSwizzled):
(colorSpaceHasAlpha):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogarden-o-matic fails to rebaseline tests with MISSING results
abarth@webkit.org [Wed, 20 Jun 2012 02:12:29 +0000 (02:12 +0000)]
garden-o-matic fails to rebaseline tests with MISSING results
https://bugs.webkit.org/show_bug.cgi?id=89521

Reviewed by Kenneth Russell.

If the bots report "MISSING", we should try to find PNG and TXT results on the server.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agosvn.delete_list fails to delete empty parent directories
abarth@webkit.org [Wed, 20 Jun 2012 01:46:34 +0000 (01:46 +0000)]
svn.delete_list fails to delete empty parent directories
https://bugs.webkit.org/show_bug.cgi?id=89520

Reviewed by Dirk Pranke.

These functions were calling scm.delete and scm.add, which already
delete the parent directory. We'd get an exception when we tried to
delete the parent directory again.

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN._add_parent_directories):
(SVN._delete_parent_directories):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSC should be able to show disassembly for all generated JIT code
fpizlo@apple.com [Wed, 20 Jun 2012 01:33:30 +0000 (01:33 +0000)]
JSC should be able to show disassembly for all generated JIT code
https://bugs.webkit.org/show_bug.cgi?id=89536

Reviewed by Gavin Barraclough.

Now instead of doing linkBuffer.finalizeCode(), you do
FINALIZE_CODE(linkBuffer, (... explanation ...)). FINALIZE_CODE() then
prints your explanation and the disassembled code, if
Options::showDisassembly is set to true.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/LinkBuffer.cpp: Added.
(JSC):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
* assembler/LinkBuffer.h:
(LinkBuffer):
(JSC):
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(MacroAssemblerCodeRef):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* disassembler/Disassembler.h:
(JSC):
(JSC::tryToDisassemble):
* disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassemble):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITCode.h:
(JSC::JITCode::tryToDisassemble):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: Simplify fetch_bugs_matching_search()
commit-queue@webkit.org [Wed, 20 Jun 2012 01:31:29 +0000 (01:31 +0000)]
webkitpy: Simplify fetch_bugs_matching_search()
https://bugs.webkit.org/show_bug.cgi?id=89497

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Adam Barth.

Removed parameter with default value. It's not being used
and the handling of the parameter was wrong. Saves a check.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_matching_search):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_matching_search):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the failing expected results added in
jhoneycutt@apple.com [Wed, 20 Jun 2012 01:29:26 +0000 (01:29 +0000)]
Remove the failing expected results added in
http://trac.webkit.org/changeset/119190 now that these tests pass.

Rubber-stamped by Jessie Berlin.

* platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Removed.
* platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
* platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
* platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Fix issue where a callback got a null calling context
arv@chromium.org [Wed, 20 Jun 2012 01:04:00 +0000 (01:04 +0000)]
[V8] Fix issue where a callback got a null calling context
https://bugs.webkit.org/show_bug.cgi?id=89532

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/dom/Window/post-message-crash.html

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback): Check the calling context and throw a type error (like JSC) if it is null.

LayoutTests:

* fast/dom/Window/post-message-crash-expected.txt: Added.
* fast/dom/Window/post-message-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRefactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative
tony@chromium.org [Wed, 20 Jun 2012 00:40:39 +0000 (00:40 +0000)]
Refactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative
https://bugs.webkit.org/show_bug.cgi?id=89493

Reviewed by Eric Seidel.

The spec stopped referring to positive and negative flex and now
talks about flex grow and flex shrink. Also, the preferred size is
now known as the flex basis. Make the code match the terms used in
the spec. http://dev.w3.org/csswg/css3-flexbox/

This will also make it easier to split flex into long hand notation
(flex-grow, flex-shrink and flex-basis).

No new tests, covered by existing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flexBasisForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
* rendering/RenderFlexibleBox.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed test expectations update.
kbr@google.com [Wed, 20 Jun 2012 00:25:40 +0000 (00:25 +0000)]
[Chromium] Unreviewed test expectations update.

* platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt: Removed.
* platform/chromium/TestExpectations:
    Referenced bugs 89529 and 89534.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][Mac] REGRESSION(r120742): It broke the build
mhahnenberg@apple.com [Wed, 20 Jun 2012 00:20:30 +0000 (00:20 +0000)]
[Qt][Mac] REGRESSION(r120742): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=89516

Reviewed by Geoffrey Garen.

Removing GCActivityCallbackCF.cpp because it doesn't mesh well with cross-platform
code on Darwin (e.g. Qt). We now use plain ol' vanilla ifdefs to handle platforms
without CF support. These if-defs will probably disappear in the future when we
use cross-platform timers in HeapTimer.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/GCActivityCallback.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):
* runtime/GCActivityCallbackCF.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: remove unneeded imports in layout_tests/port/chromium.py
dpranke@chromium.org [Wed, 20 Jun 2012 00:15:35 +0000 (00:15 +0000)]
webkitpy: remove unneeded imports in layout_tests/port/chromium.py
https://bugs.webkit.org/show_bug.cgi?id=89522

Reviewed by Eric Seidel.

They were no longer being used. No tests necessary.

* Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Make DOMFileSystem selectively structure clonable so it can be the...
commit-queue@webkit.org [Wed, 20 Jun 2012 00:09:05 +0000 (00:09 +0000)]
Source/WebCore: Make DOMFileSystem selectively structure clonable so it can be the body of a web intent.
https://bugs.webkit.org/show_bug.cgi?id=88267

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-06-19
Reviewed by David Levin.

This functionality will allow FileSystem API objects to be dispatched to
web content in order to enable, for instance, an intent notifying web
content that a particular filesystem has been mounted by the local
system. The goal at this point is not to enable across-the-board
clonability, but just for handling the particular use case.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::V8ObjectMap::Writer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readDOMFileSystem):

LayoutTests: Add filesystem regression test to check that the filesystem object is
not serializable as created by javascript.
https://bugs.webkit.org/show_bug.cgi?id=88267

Patch by Greg Billock <gbillock@google.com> on 2012-06-19
Reviewed by David Levin.

* fast/filesystem/filesystem-unserializable-expected.html: Added.
* fast/filesystem/filesystem-unserializable.html: Added.
* fast/filesystem/script-tests/filesystem-unserializable.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r120772.
kbr@google.com [Wed, 20 Jun 2012 00:07:03 +0000 (00:07 +0000)]
Unreviewed, rolling out r120772.
http://trac.webkit.org/changeset/120772
https://bugs.webkit.org/show_bug.cgi?id=89503

Broke build on Chromium Mac

Source/WebCore:

* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/Canvas2DLayerBridge.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ProgramBinding.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureManager.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
* platform/graphics/chromium/cc/CCProxy.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCRenderer.h:
(WebCore):
* platform/graphics/chromium/cc/CCScopedThreadProxy.h:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
* platform/graphics/chromium/cc/CCTimer.cpp:
* platform/graphics/chromium/cc/CCTimer.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
* tests/CCLayerTestCommon.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerImplTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Should check the return value of fromUTF8() before executing the script.
commit-queue@webkit.org [Tue, 19 Jun 2012 23:50:32 +0000 (23:50 +0000)]
[BlackBerry] Should check the return value of fromUTF8() before executing the script.
https://bugs.webkit.org/show_bug.cgi?id=89500

Patch by Yong Li <yoli@rim.com> on 2012-06-19
Reviewed by Rob Buis.
PR# 166623.

WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
before executing the script to avoid potential crash on invalid script source.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkipping failing tests to keep the bots green. Filed
bdakin@apple.com [Tue, 19 Jun 2012 23:47:25 +0000 (23:47 +0000)]
Skipping failing tests to keep the bots green. Filed
https://bugs.webkit.org/show_bug.cgi?id=89528 to track fixing the
real problem.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Remove redundant #includes in compositor
commit-queue@webkit.org [Tue, 19 Jun 2012 23:46:26 +0000 (23:46 +0000)]
[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-19
Reviewed by Adrienne Walker.

Source/WebCore:

Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.

No new tests are required, as this is only affects compile-time behavior.

* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/Canvas2DLayerBridge.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ProgramBinding.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureManager.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
* platform/graphics/chromium/cc/CCProxy.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCRenderer.h:
* platform/graphics/chromium/cc/CCScopedThreadProxy.h:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCTimer.cpp:
* platform/graphics/chromium/cc/CCTimer.h:
(WebCore):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

Minor adjustments to #include statements to remove
dependencies. No new tests.

* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
* tests/CCLayerTestCommon.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerImplTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAlign RenderLayer's descendant dependent flags semantics
jchaffraix@webkit.org [Tue, 19 Jun 2012 23:39:16 +0000 (23:39 +0000)]
Align RenderLayer's descendant dependent flags semantics
https://bugs.webkit.org/show_bug.cgi?id=89241

Reviewed by Simon Fraser.

Refactoring only, covered by existing tests.

This change aligns the naming and implementation of the different descendant
dependent flags. While aligning, I found some bugs (inefficiencies) with how
the visible descendant flags was computed.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasVisibleContent):
Changed this method to not take a boolean as every callers was passing 'true'.
Reworked the logic under this assumption.

(WebCore::RenderLayer::dirtyVisibleContentStatus):
Updated after the following renaming.

(WebCore::RenderLayer::dirtyAncestorChainVisibleDescendantStatus):
Renamed this function from dirtyVisibleDescendantStatus to match the hasSelfPaintingLayer
naming and implementation.

(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
Added this function to factor the visible descendant setting out of defunct childVisibilityChanged.
Also improved the efficiency of the function by clearing the dirty flag as it goes up (an unnoticed bug).

(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
Updated to use the new functions lieu of childVisibilityChanged.
* rendering/RenderLayer.h:
(RenderLayer::childVisibilityChanged):
Removed this function as it wasn't adding much and it's a lot more clear to call
dirtyAncestorChainVisibleDescendantStatus / setAncestorChainHasVisibleDescendant.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Updated those callers after removing the boolean parameter from setHasVisibleContent.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Extract InjectedScriptBase class from the InjectedScript
pfeldman@chromium.org [Tue, 19 Jun 2012 23:21:03 +0000 (23:21 +0000)]
Web Inspector: Extract InjectedScriptBase class from the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89107

Extract methods from the InjectedScript that do not depend on
the concrete InjectedScriptSource.js implementation.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-19
Reviewed by Pavel Feldman.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::findObjectById):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::nodeAsScriptValue):
* inspector/InjectedScript.h:
(WebCore):
(InjectedScript):
* inspector/InjectedScriptBase.cpp: Added.
(WebCore):
(WebCore::InjectedScriptBase::InjectedScriptBase):
(WebCore::InjectedScriptBase::canAccessInspectedWindow):
(WebCore::InjectedScriptBase::injectedScriptObject):
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
(WebCore::InjectedScriptBase::makeCall):
(WebCore::InjectedScriptBase::makeEvalCall):
* inspector/InjectedScriptBase.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.
(WebCore):
(InjectedScriptBase):
(WebCore::InjectedScriptBase::~InjectedScriptBase):
(WebCore::InjectedScriptBase::hasNoValue):
(WebCore::InjectedScriptBase::scriptState):
* inspector/InspectorAllInOne.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip...
kbr@google.com [Tue, 19 Jun 2012 23:19:19 +0000 (23:19 +0000)]
[Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm is failing
https://bugs.webkit.org/show_bug.cgi?id=89411

Unreviewed test expectations update generated by garden-o-matic.

* ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt.
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium/TestExpectations:
    Removed IMAGE MISSING expectation for this test.
* platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNo...
fpizlo@apple.com [Tue, 19 Jun 2012 23:10:12 +0000 (23:10 +0000)]
DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant
https://bugs.webkit.org/show_bug.cgi?id=89511
<rdar://problem/11700089>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):

LayoutTests:

* fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added.
* fast/js/dfg-constant-fold-logical-not-branch.html: Added.
* fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added.
(foo1):
(foo2):
(Stuff):
(Stuff.prototype.thingy):
(Stuff.prototype.otherThingy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the failing results added in
jhoneycutt@apple.com [Tue, 19 Jun 2012 23:09:07 +0000 (23:09 +0000)]
Remove the failing results added in
http://trac.webkit.org/changeset/119144 and
http://trac.webkit.org/changeset/119149 now that these tests pass
without them.

Rubber-stamped by Jessie Berlin.

* platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Removed.
* platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Removed.
* platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
* platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Removed.
* platform/win/fast/events/popup-blocking-timers-expected.txt: Removed.
* platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Removed.
* platform/win/fast/events/remove-target-in-mouseup-expected.txt: Removed.
* platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Removed.
* platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Removed.
* platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r120621.
commit-queue@webkit.org [Tue, 19 Jun 2012 22:51:37 +0000 (22:51 +0000)]
Unreviewed, rolling out r120621.
http://trac.webkit.org/changeset/120621
https://bugs.webkit.org/show_bug.cgi?id=89518

Memory graph should have been behind the experimental flag.
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19

* inspector/front-end/NativeMemorySnapshotView.js:
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-blocks-list .item):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThe CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed
commit-queue@webkit.org [Tue, 19 Jun 2012 22:49:19 +0000 (22:49 +0000)]
The CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=89403

Patch by Hans Muller <hmuller@adobe.com> on 2012-06-19
Reviewed by Eric Seidel.

Removed CSS_WRAP_SHAPE_PATH definition from CSSWrapShapes.h.
It's no longer required. This definition was never used or
tested, no new tests are required.

* css/CSSWrapShapes.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Missing notifyContentRendered() when resuming rendering
jpetsovits@rim.com [Tue, 19 Jun 2012 22:48:01 +0000 (22:48 +0000)]
[BlackBerry] Missing notifyContentRendered() when resuming rendering
https://bugs.webkit.org/show_bug.cgi?id=89507
RIM PR 150049

Reviewed by Antonio Gomes.

All the current calls to notifyContentRendered() are
located in the RenderQueue, but this omits the case
when we force rendering from resumeBackingStore()
after rendering had been suspended for a while.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAbsolute positioned objects should not be added to anonymous block lists
kenrb@chromium.org [Tue, 19 Jun 2012 22:34:55 +0000 (22:34 +0000)]
Absolute positioned objects should not be added to anonymous block lists
https://bugs.webkit.org/show_bug.cgi?id=87768

Reviewed by Abhishek Arya.

Source/WebCore:

containingBlock() was returning an anonymous block for absolute
positioned objects under a relative positioned inline in the case
that the inline is split and the object is underneath the block
continuation. Anonymous blocks should never have anything in their
positioned object lists because they can be destroyed at any time
for a different reasons such as anonymous block merging, which is
a problem for layout if they have m_posChildNeedsLayout set.

This patch adds a generic check for anonymous blocks in
containingBlock() to correct this problem.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):

LayoutTests:

Test crashing condition in bug 87768.

* fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash-expected.txt: Added
* fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html: Added
* fast/block/positioning/insert-positioned-in-anonymous-crash-expected.txt: Added
* fast/block/positioning/insert-positioned-in-anonymous-crash.html: Added

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Web Inspector: extensionPanel.onSearch `action` strings should be
commit-queue@webkit.org [Tue, 19 Jun 2012 22:30:10 +0000 (22:30 +0000)]
Source/WebCore: Web Inspector: extensionPanel.onSearch `action` strings should be
enumerated.
https://bugs.webkit.org/show_bug.cgi?id=89509

Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
Reviewed by Pavel Feldman.

Fixed LayoutTests/inspector/extensions/extensions-api-expected.txt
accordingly.

* inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):
(injectedExtensionAPI.Panels.prototype.get SearchAction):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.searchCanceled):
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):

LayoutTests: Web Inspector: extensionPanel.onSearch `action` strings should be enumerated
https://bugs.webkit.org/show_bug.cgi?id=89509

Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
Reviewed by Pavel Feldman.

* inspector/extensions/extensions-api-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add an allocation step for CCRenderer before drawing a frame
danakj@chromium.org [Tue, 19 Jun 2012 22:18:48 +0000 (22:18 +0000)]
[chromium] Add an allocation step for CCRenderer before drawing a frame
https://bugs.webkit.org/show_bug.cgi?id=88924

Reviewed by Adrienne Walker.

This step will be used to decide which RenderPass textures can be kept
alive and do not need to be drawn again.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::beginDrawingFrame):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCRenderer.h:
(CCRenderer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed gardening.
kbr@google.com [Tue, 19 Jun 2012 22:01:11 +0000 (22:01 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt:
    Added expectations without trailing newlines; unclear why this only happens in this configuration.
* platform/chromium/TestExpectations:
    Added reference to https://bugs.webkit.org/show_bug.cgi?id=89510 .

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CSS Shaders] Create a shared object between FECustomFilter objects to store the...
achicu@adobe.com [Tue, 19 Jun 2012 21:44:48 +0000 (21:44 +0000)]
[CSS Shaders] Create a shared object between FECustomFilter objects to store the shared resources
https://bugs.webkit.org/show_bug.cgi?id=87878

Reviewed by Dean Jackson.

An object called CustomFilterGlobalContext is created the first time a new FECustomFilter is needed in a document.
It is used to store the GraphicsContext3D needed to render the CSS Shaders. The context is shared by all the elements
in a document (no cross-domain).

More resources will be shared in following patches, including precompiled shaders and vertices/indices data.
https://bugs.webkit.org/show_bug.cgi?id=88427
https://bugs.webkit.org/show_bug.cgi?id=88429

The plan is to make CustomFilterGlobalContext and FECustomFilter (or a base class extracted out of it) usable from platform
code in the hardware accelerated compositing layer. The only dependency of the code is on the GraphicsContext3D.

No new tests. No functionality is changed yet, just added the new objects.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/CustomFilterGlobalContext.cpp: Added.
(WebCore):
(WebCore::CustomFilterGlobalContext::CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
* platform/graphics/filters/CustomFilterGlobalContext.h: Added.
(WebCore):
(CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::context):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter): Changed to use the global context instead of the host window.
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::initializeContext):
* platform/graphics/filters/FECustomFilter.h:
(WebCore):
(FECustomFilter):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build): Changed to initialize the global context if needed and pass it to the FECustomFilter.
* rendering/RenderView.cpp:
(WebCore):
(WebCore::RenderView::customFilterGlobalContext):
* rendering/RenderView.h:
(WebCore):
(RenderView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMissing results aren't shown in garden-o-matic
abarth@webkit.org [Tue, 19 Jun 2012 21:43:52 +0000 (21:43 +0000)]
Missing results aren't shown in garden-o-matic

Reviewed by Kenneth Russell.

Previously we didn't know to look for text and image results when the
bot told us that results were missing.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
commit-queue@webkit.org [Tue, 19 Jun 2012 21:33:56 +0000 (21:33 +0000)]
[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
Reviewed by Martin Robinson.

Source/WebCore:

Clipping previously unlimited vertical and horizontal pattern repeats with
a clip rectangle similar to the Qt Graphics Context.

No new tests, this patch fixes
canvas/philip/tests/2d.pattern.paint.repeat* tests.

* platform/graphics/Pattern.h:
(WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::prepareForFilling):
(WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.
* platform/graphics/cairo/PlatformContextCairo.h:

LayoutTests:

canvas/philip/tests/2d.pattern.paint.repeat* tests now passing.

* platform/efl/Skipped:
* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Shadow DOM] An upper boundary breaks if a child node of an insertion point is clicked.
hayato@chromium.org [Tue, 19 Jun 2012 21:20:22 +0000 (21:20 +0000)]
[Shadow DOM] An upper boundary breaks if a child node of an insertion point is clicked.
https://bugs.webkit.org/show_bug.cgi?id=89407

Reviewed by Dimitri Glazkov.

Source/WebCore:

Update an event re-targeting algorithm so that it can set event's
target correctly when a fallback element in an insertion point is
clicked. To distinguish between distributed nodes and fallback
elements in an ancestor chain of composite shadow tree, an event
dispatcher checks explicitly whether a node is actually
distributed or assigned to the given insertion point.

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

* dom/EventDispatcher.cpp:
(WebCore::isAssignedTo):
(WebCore):
(WebCore::EventDispatcher::ensureEventAncestors):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::contains):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Add new type (and chromium webkit API) for metadata snapshot
jsbell@chromium.org [Tue, 19 Jun 2012 21:19:37 +0000 (21:19 +0000)]
IndexedDB: Add new type (and chromium webkit API) for metadata snapshot
https://bugs.webkit.org/show_bug.cgi?id=88678

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::metadata):
* public/WebIDBKeyPath.h:
(WebIDBKeyPath):
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::~WebIDBKeyPath):
(WebKit::WebIDBKeyPath::operator=): Used by Chromium backend.
* public/WebIDBMetadata.h: Added new type.
(WebKit):
(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):
(ObjectStore):
(WebKit::WebIDBMetadata::ObjectStore::ObjectStore):
(Index):
(WebKit::WebIDBMetadata::Index::Index):
* src/WebIDBKeyPath.cpp: Conform to normal WebXXX patern.
(WebKit::WebIDBKeyPath::assign):
(WebKit):
(WebKit::WebIDBKeyPath::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Add LayoutTests for find in page.
commit-queue@webkit.org [Tue, 19 Jun 2012 21:12:46 +0000 (21:12 +0000)]
[Chromium] Add LayoutTests for find in page.
https://bugs.webkit.org/show_bug.cgi?id=89453

Patch by Martin Kosiba <mkosiba@google.com> on 2012-06-19
Reviewed by Adam Barth.

* platform/chromium/editing/text-iterator/findString-restarts-at-last-position-expected.txt: Added.
* platform/chromium/editing/text-iterator/findString-restarts-at-last-position.html: Added.
* platform/chromium/editing/text-iterator/findString-start-search-after-selection-expected.txt: Added.
* platform/chromium/editing/text-iterator/findString-start-search-after-selection.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCodeBlock::needsCallReturnIndices() is no longer needed.
commit-queue@webkit.org [Tue, 19 Jun 2012 21:06:08 +0000 (21:06 +0000)]
CodeBlock::needsCallReturnIndices() is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=89490

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-19
Reviewed by Geoffrey Garen.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::needsCallReturnIndices): removed.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix scrollbar layers being misplaced with a clipped owner layer
enne@google.com [Tue, 19 Jun 2012 21:00:09 +0000 (21:00 +0000)]
Fix scrollbar layers being misplaced with a clipped owner layer
https://bugs.webkit.org/show_bug.cgi?id=89486

Reviewed by Simon Fraser.

Source/WebCore:

Scrollbar layers are positioned relative to their parent layer. If
that parent gets clipped, then that positioning becomes incorrect and
scrollbars get positioned relative to the clipped bounds instead of
the full bounds. Fix by not clipping in this case.

Test: compositing/overflow/scrollbars-with-clipped-owner.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):

LayoutTests:

* compositing/overflow/scrollbars-with-clipped-owner-expected.png: Added.
* compositing/overflow/scrollbars-with-clipped-owner-expected.txt: Added.
* compositing/overflow/scrollbars-with-clipped-owner.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Shadow][Editing] applying document.execCommand('bold') twice to elements having...
shinyak@chromium.org [Tue, 19 Jun 2012 20:13:45 +0000 (20:13 +0000)]
[Shadow][Editing] applying document.execCommand('bold') twice to elements having shadow insertion points causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=88502

Reviewed by Ryosuke Niwa.

Source/WebCore:

When inserting or removing insertion points (<shadow> or <content>) into or from Shdaow DOM,
ElementShadow::invalidateDistribution() will be called immediately. It will remove all the renderers
of elements in the Shadow DOM. Since Node::rendererIsEditable() returns false when an renderer does not
exist, all the elements in the Shadow DOM will be considered as non-content-editable until recalculating
layout, though some of them may actually be content-editable.

Actually the current code does not recalculate layout inside editing command, so a disaster happens.
For example, performing an editing command quits before completing all the commands, because the command
thinks it is adding some elements to a non-content-editable element (but actually it's content-editable).

So we have to recalculate layout if necessary when checking an element is content-editable or not.
This can be achieved by using Node::isContentEditable() instead of Node::rendererIsEditable().

Test: editing/shadow/bold-twice-in-shadow.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
* editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):

LayoutTests:

* editing/shadow/bold-twice-in-shadow-expected.txt: Added.
* editing/shadow/bold-twice-in-shadow.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r120744.
kbr@google.com [Tue, 19 Jun 2012 20:11:42 +0000 (20:11 +0000)]
Unreviewed, rolling out r120744.
http://trac.webkit.org/changeset/120744
https://bugs.webkit.org/show_bug.cgi?id=89220

Broke build on Chromium Windows canary bots

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/mock/DeviceMotionClientMock.cpp: Removed.
* platform/mock/DeviceMotionClientMock.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, try to fix Windows build.
fpizlo@apple.com [Tue, 19 Jun 2012 20:05:06 +0000 (20:05 +0000)]
Unreviewed, try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove some failing layout tests results added in
jhoneycutt@apple.com [Tue, 19 Jun 2012 19:48:27 +0000 (19:48 +0000)]
Remove some failing layout tests results added in
http://trac.webkit.org/changeset/119285 and
http://trac.webkit.org/changeset/119295. Most of these tests pass
without the failing results. Only one of them passes with the failing
result; compositing/layer-creation/spanOverlapsCanvas.html. I left that
failing result in place.

Rubber-stamped by Alexey Proskuryakov.

* platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
* platform/win/compositing/geometry/foreground-layer-expected.txt: Removed.
* platform/win/compositing/geometry/foreground-offset-change-expected.txt: Removed.
* platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
* platform/win/compositing/geometry/outline-change-expected.txt: Removed.
* platform/win/compositing/geometry/partial-layout-update-expected.txt: Removed.
* platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
* platform/win/compositing/geometry/root-layer-update-expected.txt: Removed.
* platform/win/compositing/geometry/tall-page-composited-expected.txt: Removed.
* platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Removed.
* platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
* platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Removed.
* platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Removed.
* platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
* platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
* platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
* platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
* platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
* platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
* platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
* platform/win/compositing/iframes/resizer-expected.txt: Removed.
* platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
* platform/win/compositing/images: Removed.
* platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
* platform/win/compositing/images/direct-image-background-color-expected.txt: Removed.
* platform/win/compositing/images/direct-pdf-image-expected.txt: Removed.
* platform/win/compositing/images/direct-svg-image-expected.txt: Removed.
* platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed.
* platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-animation-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
* platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
* platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
* platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
* platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
* platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
* platform/win/compositing/masks: Removed.
* platform/win/compositing/masks/direct-image-mask-expected.txt: Removed.
* platform/win/compositing/masks/masked-ancestor-expected.txt: Removed.
* platform/win/compositing/masks/multiple-masks-expected.txt: Removed.
* platform/win/compositing/masks/simple-composited-mask-expected.txt: Removed.
* platform/win/compositing/overflow/ancestor-overflow-expected.txt: Removed.
* platform/win/compositing/overflow/clip-descendents-expected.txt: Removed.
* platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
* platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-positioning-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
* platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
* platform/win/compositing/rtl: Removed.
* platform/win/compositing/rtl/rtl-absolute-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-relative-expected.txt: Removed.
* platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
* platform/win/compositing/visibility: Removed.
* platform/win/compositing/visibility/layer-visible-content-expected.txt: Removed.
* platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIt should be possible to look at disassembly
fpizlo@apple.com [Tue, 19 Jun 2012 19:42:55 +0000 (19:42 +0000)]
It should be possible to look at disassembly
https://bugs.webkit.org/show_bug.cgi?id=89319

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This imports the udis86 disassembler library. The library is placed
behind an abstraction in disassembler/Disassembler.h, so that we can
in the future use other disassemblers (for other platforms) whenever
appropriate. As a first step, the disassembler is being invoked for
DFG verbose dumps.

If we ever want to merge a new version of udis86 in the future, I've
made notes about changes I made to the library in
disassembler/udis86/differences.txt.

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* disassembler: Added.
* disassembler/Disassembler.h: Added.
(JSC):
(JSC::tryToDisassemble):
* disassembler/UDis86Disassembler.cpp: Added.
(JSC):
(JSC::tryToDisassemble):
* disassembler/udis86: Added.
* disassembler/udis86/differences.txt: Added.
* disassembler/udis86/itab.py: Added.
(UdItabGenerator):
(UdItabGenerator.__init__):
(UdItabGenerator.toGroupId):
(UdItabGenerator.genLookupTable):
(UdItabGenerator.genLookupTableList):
(UdItabGenerator.genInsnTable):
(genItabH):
(genItabH.UD_ITAB_H):
(genItabC):
(genItab):
(main):
* disassembler/udis86/optable.xml: Added.
* disassembler/udis86/ud_opcode.py: Added.
(UdOpcodeTables):
(UdOpcodeTables.sizeOfTable):
(UdOpcodeTables.nameOfTable):
(UdOpcodeTables.updateTable):
(UdOpcodeTables.Insn):
(UdOpcodeTables.Insn.__init__):
(UdOpcodeTables.Insn.__init__.opcode):
(UdOpcodeTables.parse):
(UdOpcodeTables.addInsnDef):
(UdOpcodeTables.print_table):
(UdOpcodeTables.print_tree):
* disassembler/udis86/ud_optable.py: Added.
(UdOptableXmlParser):
(UdOptableXmlParser.parseDef):
(UdOptableXmlParser.parse):
(printFn):
(parse):
(main):
* disassembler/udis86/udis86.c: Added.
(ud_init):
(ud_disassemble):
(ud_set_mode):
(ud_set_vendor):
(ud_set_pc):
(ud):
(ud_insn_asm):
(ud_insn_off):
(ud_insn_hex):
(ud_insn_ptr):
(ud_insn_len):
* disassembler/udis86/udis86.h: Added.
* disassembler/udis86/udis86_decode.c: Added.
(eff_adr_mode):
(ud_lookup_mnemonic):
(decode_prefixes):
(modrm):
(resolve_operand_size):
(resolve_mnemonic):
(decode_a):
(decode_gpr):
(resolve_gpr64):
(resolve_gpr32):
(resolve_reg):
(decode_imm):
(decode_modrm_reg):
(decode_modrm_rm):
(decode_o):
(decode_operand):
(decode_operands):
(clear_insn):
(resolve_mode):
(gen_hex):
(decode_insn):
(decode_3dnow):
(decode_ssepfx):
(decode_ext):
(decode_opcode):
(ud_decode):
* disassembler/udis86/udis86_decode.h: Added.
(ud_itab_entry_operand):
(ud_itab_entry):
(ud_lookup_table_list_entry):
(sse_pfx_idx):
(mode_idx):
(modrm_mod_idx):
(vendor_idx):
(is_group_ptr):
(group_idx):
* disassembler/udis86/udis86_extern.h: Added.
* disassembler/udis86/udis86_input.c: Added.
(inp_buff_hook):
(inp_file_hook):
(ud):
(ud_set_user_opaque_data):
(ud_get_user_opaque_data):
(ud_set_input_buffer):
(ud_set_input_file):
(ud_input_skip):
(ud_input_end):
(ud_inp_next):
(ud_inp_back):
(ud_inp_peek):
(ud_inp_move):
(ud_inp_uint8):
(ud_inp_uint16):
(ud_inp_uint32):
(ud_inp_uint64):
* disassembler/udis86/udis86_input.h: Added.
* disassembler/udis86/udis86_itab_holder.c: Added.
* disassembler/udis86/udis86_syn-att.c: Added.
(opr_cast):
(gen_operand):
(ud_translate_att):
* disassembler/udis86/udis86_syn-intel.c: Added.
(opr_cast):
(gen_operand):
(ud_translate_intel):
* disassembler/udis86/udis86_syn.c: Added.
* disassembler/udis86/udis86_syn.h: Added.
(mkasm):
* disassembler/udis86/udis86_types.h: Added.
(ud_operand):
(ud):
* jit/JITCode.h:
(JITCode):
(JSC::JITCode::tryToDisassemble):

Source/WebCore:

Reviewed by Sam Weinig.

Just fixing EFL's build system now that JSC has a new directory.

* CMakeLists.txt:

Source/WTF:

Reviewed by Sam Weinig.

Made changes to Assertions.h to make it friendly to C code again.

Added ENABLE(DISASSEMBLER) and USE(UDIS86) logic to Platform.h.

* wtf/Assertions.h:
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds DeviceMotionClientMock
commit-queue@webkit.org [Tue, 19 Jun 2012 19:27:48 +0000 (19:27 +0000)]
Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.

No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/mock/DeviceMotionClientMock.cpp: Added.
(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):
* platform/mock/DeviceMotionClientMock.h: Added.
(WebCore):
(DeviceMotionClientMock):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix regression introduced in r120646 where the svn revision isn't saved in results...
dpranke@chromium.org [Tue, 19 Jun 2012 19:22:21 +0000 (19:22 +0000)]
Fix regression introduced in r120646 where the svn revision isn't saved in results.json

Unreviewed, build fix.

It turns out that we store the svn revision two different ways
in the JSON, and I only caught one of them :(. This should fix
the other.

Also, this part of the code is poorly tested. I will investigate
adding at least a basic test for this in a separate fix.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGCActivityCallback and IncrementalSweeper should share code
mhahnenberg@apple.com [Tue, 19 Jun 2012 19:17:31 +0000 (19:17 +0000)]
GCActivityCallback and IncrementalSweeper should share code
https://bugs.webkit.org/show_bug.cgi?id=89400

Reviewed by Geoffrey Garen.

A lot of functionality is duplicated between GCActivityCallback and IncrementalSweeper.
We should extract the common functionality out into a separate class that both of them
can inherit from. This refactoring will be an even greater boon when we add the ability
to shut these two agents down in a thread-safe fashion

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/Heap.cpp:
(JSC::Heap::Heap): Move initialization down so that the JSGlobalData has a valid Heap when
we're initializing the GCActivityCallback and the IncrementalSweeper.
* heap/Heap.h:
(Heap):
* heap/HeapTimer.cpp: Added.
(JSC):
(JSC::HeapTimer::HeapTimer): Initialize the various base class data that
DefaultGCActivityCallback::commonConstructor() used to do.
(JSC::HeapTimer::~HeapTimer): Call to invalidate().
(JSC::HeapTimer::synchronize): Same functionality as the old DefaultGCActivityCallback::synchronize().
Virtual so that non-CF subclasses can override.
(JSC::HeapTimer::invalidate): Tears down the runloop timer to prevent any future firing.
(JSC::HeapTimer::timerDidFire): Callback to pass to the timer function. Casts and calls the virtual doWork().
* heap/HeapTimer.h: Added. This is the class that serves as the common base class for
both GCActivityCallback and IncrementalSweeper. It handles setting up and tearing down run loops and synchronizing
across threads for its subclasses.
(JSC):
(HeapTimer):
* heap/IncrementalSweeper.cpp: Changes to accomodate the extraction of common functionality
between IncrementalSweeper and GCActivityCallback into a common ancestor.
(JSC):
(JSC::IncrementalSweeper::doWork):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::create):
* heap/IncrementalSweeper.h:
(IncrementalSweeper):
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
* runtime/GCActivityCallback.h:
(GCActivityCallback):
(JSC::GCActivityCallback::willCollect):
(JSC::GCActivityCallback::GCActivityCallback):
(JSC):
(DefaultGCActivityCallback): Remove the platform data struct. The platform data should be kept in
the class itself so as to be accessible by doWork(). Most of the platform data for CF is kept in
HeapTimer anyways, so we only need the m_delay field now.
* runtime/GCActivityCallbackBlackBerry.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
* runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix link error with fillWithEmptyClients
commit-queue@webkit.org [Tue, 19 Jun 2012 19:09:49 +0000 (19:09 +0000)]
Fix link error with fillWithEmptyClients
https://bugs.webkit.org/show_bug.cgi?id=89484

Patch by Alexandre Elias <aelias@google.com> on 2012-06-19
Reviewed by Ryosuke Niwa.

fillWithEmptyClients() was within #if ENABLE() guard in the .cpp file
but not in the header.  There is now a caller unrelated to these ENABLEs
in WebHelperPluginImpl, so linking fails if both SVG and PAGE_POPUP
are disabled.

This function looks generic, so just remove the ENABLE guards.

No new tests. (Build fix.)

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION (NRWT): Results for new non-text-only tests are always put in the most...
dpranke@chromium.org [Tue, 19 Jun 2012 18:27:29 +0000 (18:27 +0000)]
REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
https://bugs.webkit.org/show_bug.cgi?id=78127

Reviewed by Ryosuke Niwa.

Add the --add-platform-exceptions flag from ORWT, and ensure
that --new-baseline is equivalent to --reset-results
--add-platform-exceptions. Also fix the default logic for where to
put PNGs and render tree dumps if --new-test-results is true:
if --add-platform-exceptions is False, baselines should go in
the least-specific platform directory (e.g., platform/mac)
rather than the most-specific (platform/mac-snowleopard).

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner):
(SingleTestRunner.run):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._add_missing_baselines):
(SingleTestRunner._location_for_new_baseline):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._save_baseline_data):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_path):
(Port):
(Port.baseline_platform_dir):
(Port.baseline_version_dir):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRebaseline some media controller tests.
simon.fraser@apple.com [Tue, 19 Jun 2012 18:25:01 +0000 (18:25 +0000)]
Rebaseline some media controller tests.

* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNRWT should not take memory used as disk cache into account when deciding how many...
dpranke@chromium.org [Tue, 19 Jun 2012 18:21:16 +0000 (18:21 +0000)]
NRWT should not take memory used as disk cache into account when deciding how many processes to launch
https://bugs.webkit.org/show_bug.cgi?id=81379

Reviewed by Eric Seidel.

The 'free memory' calculation we were running on the mac seemed
to underestimate how many children we can run in parallel, and
it was complex. This patch replaces that calculation with a
simpler one that reserves 2GB for overhead and assumes 256MB per
DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.

Also, there was a bug where we were truncating the memory
installed on the machine to 4GB by casting to an int instead of
a long; this was probably the source of some of the earlier
problems when using total memory.

This patch also removes the no-longer-needed restrictions on the
number of workers on beefy Lion boxes for both Apple Mac and Chromium
Mac; we should now use all of the cores by default.

The memory calculations have only been implemented on the mac;
having the calculation in base.default_child_processes() was IMO
misleading, and so this patch also moves the computation into
the MacPort. I have not heard of the # of workers being an issue
on any other ports, so this should be fine.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.total_bytes_memory):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(PlatformInfo.total_bytes_memory):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._win_version_tuple_from_cmd):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.operating_system):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(TestMacPort.test_default_child_processes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash in RenderInline::willBeDestroyed.
inferno@chromium.org [Tue, 19 Jun 2012 18:05:58 +0000 (18:05 +0000)]
Crash in RenderInline::willBeDestroyed.
https://bugs.webkit.org/show_bug.cgi?id=89386

Reviewed by Julien Chaffraix.

Source/WebCore:

We were unable to find the previous continuation during the process
of cleaning up empty anonymous block continuation. The reason being
that we were just looking till our immediate parent and ignoring the
fact that it can be enclosed in anonymous blocks. The change skips
over anonymous blocks in the parent chain.

Test: fullscreen/empty-anonymous-block-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

* fullscreen/empty-anonymous-block-continuation-crash-expected.txt: Added.
* fullscreen/empty-anonymous-block-continuation-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agonew-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is...
dpranke@chromium.org [Tue, 19 Jun 2012 18:03:22 +0000 (18:03 +0000)]
new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
https://bugs.webkit.org/show_bug.cgi?id=85446

Reviewed by Simon Fraser.

Tools:

Embed whether pixel testing was enabled into the results.json.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):

LayoutTests:

This change makes results.html aware of whether pixel tests were
enabled when the tests were run; if they weren't, we ignore
expected IMAGE tests that pass instead of reporting them as
'unexpected pass'.

* fast/harness/resources/results-test.js:
(mockResults):
* fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the -webkit-match-nearest-mail-blockquote-color property.
kling@webkit.org [Tue, 19 Jun 2012 17:59:44 +0000 (17:59 +0000)]
Remove the -webkit-match-nearest-mail-blockquote-color property.
<http://webkit.org/b/89480>

Reviewed by Antti Koivisto.

Source/WebCore:

This property does nothing except taking up a bit on StyleRareNonInheritedData.
It's apparently famous for being the longest property name we support.
This passes the torch to -webkit-border-bottom-right-radius.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

* fast/css/getComputedStyle/resources/property-names.js:
* fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt:
* fast/dom/CSSStyleDeclaration/access-longest-css-property.html:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Animations continue to request frames after they have finished
commit-queue@webkit.org [Tue, 19 Jun 2012 17:57:24 +0000 (17:57 +0000)]
[BlackBerry] Animations continue to request frames after they have finished
https://bugs.webkit.org/show_bug.cgi?id=89483

Patch by Andrew Lo <anlo@rim.com> on 2012-06-19
Reviewed by Rob Buis.

Don't report that we have running animations if all the animations
are finished. This prevents unnecessary requesting of animation frames.
Internal PR165119
Internally Reviewed by Arvid Nilsson.

* platform/graphics/blackberry/LayerAnimation.cpp:
(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):
* platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::finished):
(WebCore::LayerAnimation::LayerAnimation):
(LayerAnimation):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWrong repaintContainerSkipped in RenderObject::container()
inferno@chromium.org [Tue, 19 Jun 2012 17:55:23 +0000 (17:55 +0000)]
Wrong repaintContainerSkipped in RenderObject::container()
when positioned objects are enclosed in a <foreignObject>.
https://bugs.webkit.org/show_bug.cgi?id=89384

Reviewed by Simon Fraser.

No new tests. The bug was found in a code audit.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash in WebCore::RenderSVGModelObject::checkIntersection
inferno@chromium.org [Tue, 19 Jun 2012 17:43:22 +0000 (17:43 +0000)]
Crash in WebCore::RenderSVGModelObject::checkIntersection
https://bugs.webkit.org/show_bug.cgi?id=89059

Reviewed by Rob Buis.

Source/WebCore:

getElementCTM updates layout causing the renderer to be destroyed. We get
the new renderer by storing the element pointer and later accessing it using
the element pointer.

Test: svg/custom/intersection-list-crash.svg

* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):

LayoutTests:

* svg/custom/intersection-list-crash-expected.txt: Added.
* svg/custom/intersection-list-crash.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFileWriter progress events should be throttled to 50ms
ericu@chromium.org [Tue, 19 Jun 2012 17:25:06 +0000 (17:25 +0000)]
FileWriter progress events should be throttled to 50ms
https://bugs.webkit.org/show_bug.cgi?id=89022

Reviewed by Kent Tamura.

No new tests; existing tests validate our event sequences, and testing
timing is likely to be flaky.

* Modules/filesystem/FileWriter.cpp:
(WebCore):
(WebCore::FileWriter::FileWriter):
(WebCore::FileWriter::didWrite): Throttle sending progress events.
* Modules/filesystem/FileWriter.h:
(FileWriter): Add a variable that remembers when the last event was
sent.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: WebCore part of: Paginated display API doesn’t allow setting the...
mitz@apple.com [Tue, 19 Jun 2012 17:10:47 +0000 (17:10 +0000)]
Source/WebCore: WebCore part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

Updated fast/multicol/pagination-*.html.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForDocument): Changed to handle the new Pagination::Mode enum
values and set the column progression in addition to the column axis.
* page/Page.h: Changed the Pagination::Mode enum values to ones that specify an axis and a
direction along that axis.
* testing/Internals.cpp:
(WebCore::Internals::setPagination): Changed to support the new Pagination::Mode enum values.

Source/WebKit/mac: WebKit/mac part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

* WebView/WebView.mm:
(-[WebView _setPaginationMode:]): Changed to map new WebPaginationMode values to new
Pagination::Mode values.
(-[WebView _paginationMode]): Similarly, in the opposite direction.
* WebView/WebViewPrivate.h: Replaced WebPaginationMode values with ones that specify an
axis and a direction along that axis.

Source/WebKit2: WebKit2 part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationMode): Changed to map new WKPaginationMode values to new
Pagination::Mode values.
(WKPageGetPaginationMode): Similarly, in the opposite direction.
* UIProcess/API/C/WKPagePrivate.h: Replaced WKPaginationMode values with ones that specify
an axis and a direction along that axis.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationMode:]): Changed to handle new values.
(-[WKBrowsingContextController paginationMode]): Ditto.
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Replaced
WKBrowsingContextPaginationMode values with ones that specify an axis and a direction along
that axis.

LayoutTests: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

* fast/multicol/pagination-h-horizontal-bt.html:
* fast/multicol/pagination-h-horizontal-tb.html:
* fast/multicol/pagination-h-vertical-lr.html:
* fast/multicol/pagination-h-vertical-rl.html:
* fast/multicol/pagination-v-horizontal-bt.html:
* fast/multicol/pagination-v-horizontal-tb.html:
* fast/multicol/pagination-v-vertical-lr.html:
* fast/multicol/pagination-v-vertical-rl.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
aestes@apple.com [Tue, 19 Jun 2012 17:09:32 +0000 (17:09 +0000)]
[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
https://bugs.webkit.org/show_bug.cgi?id=89434

Reviewed by Darin Adler.

* WebView/WebPDFView.mm:
(-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
NSMenuItems once they're stored in copiedItems.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][Mac] Skip new failing and crashing tests to try to paint the bot green.
ossy@webkit.org [Tue, 19 Jun 2012 16:37:40 +0000 (16:37 +0000)]
[Qt][Mac] Skip new failing and crashing tests to try to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, remove unnecessary expected files.
ossy@webkit.org [Tue, 19 Jun 2012 16:21:43 +0000 (16:21 +0000)]
[Qt] Unreviewed gardening, remove unnecessary expected files.

* platform/qt/animations/combo-transform-translate+scale-expected.txt: Removed.
* platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Removed.
* platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
* platform/qt/editing/inserting/return-key-in-hidden-field-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-noscript-expected.txt: Removed.
* platform/qt/editing/pasteboard/select-element-1-expected.txt: Removed.
* platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Removed.
* platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Removed.
* platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Removed.
* platform/qt/fast/events/mouse-relative-position-expected.txt: Removed.
* platform/qt/fast/preloader/document-write-noscript-expected.txt: Removed.
* platform/qt/fast/repaint/table-hover-on-link-expected.txt: Removed.
* platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Removed.
* platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Removed.
* platform/qt/svg/custom/acid3-test-77-expected.txt: Removed.
* platform/qt/svg/custom/circular-marker-reference-1-expected.txt: Removed.
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Removed.
* platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Removed.
* platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Removed.
* platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Removed.
* platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Removed.
* platform/qt/svg/dom/css-transforms-expected.txt: Removed.
* platform/qt/svg/dom/font-face-elements-expected.txt: Removed.
* platform/qt/svg/hixie/links/001-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, remove unnecessary expected files.
ossy@webkit.org [Tue, 19 Jun 2012 16:15:38 +0000 (16:15 +0000)]
[Qt] Unreviewed gardening, remove unnecessary expected files.

* platform/qt-5.0/fast/dom/DeviceMotion/create-event-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/create-event-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake RenderTableSection - nodeAtPoint and paintObject reuse spanning logic.
commit-queue@webkit.org [Tue, 19 Jun 2012 16:07:00 +0000 (16:07 +0000)]
Make RenderTableSection - nodeAtPoint and paintObject reuse spanning logic.
https://bugs.webkit.org/show_bug.cgi?id=88066

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-19
Reviewed by Julien Chaffraix.

Makes dirtiedRows and dirtiedColumns reuse spannedRows and spannedColumns
internally. This also changes their API to accept a damage-rect flipped
by logicalRectForWritingModeAndDirection.

The generic code in spannedRows and spannedColumns solves a few FIXMEs
surrounding RTL tables, which should improve performance.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
(WebCore::RenderTableSection::paintObject):
* rendering/RenderTableSection.h:
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
(CellSpan):
(RenderTableSection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, skip one more failing test.
ossy@webkit.org [Tue, 19 Jun 2012 15:59:52 +0000 (15:59 +0000)]
[Qt] Unreviewed gardening, skip one more failing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)
commit-queue@webkit.org [Tue, 19 Jun 2012 15:47:29 +0000 (15:47 +0000)]
[JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)
https://bugs.webkit.org/show_bug.cgi?id=89447

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-19
Reviewed by Adam Barth.

Add implementation for JSDictionary::convertValue(Vector<String>& result)
so that IDBDatabase::createObjectStore() compiles with JSC.

Tests: storage/indexeddb

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
* bindings/js/JSDictionary.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Mac] AudioFileReader::createBus() leaks an AudioBufferList if ExtAudioFileRead(...
aestes@apple.com [Tue, 19 Jun 2012 15:45:05 +0000 (15:45 +0000)]
[Mac] AudioFileReader::createBus() leaks an AudioBufferList if ExtAudioFileRead() returns an error
https://bugs.webkit.org/show_bug.cgi?id=89429

Reviewed by Darin Adler.

* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus): Call destroyAudioBufferList()
before returning if ExtAudioFileRead() returns an error.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing Typos in DeviceOrientation and DeviceMotion Tests
commit-queue@webkit.org [Tue, 19 Jun 2012 15:40:37 +0000 (15:40 +0000)]
Fixing Typos in DeviceOrientation and DeviceMotion Tests
https://bugs.webkit.org/show_bug.cgi?id=89339

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

* fast/dom/DeviceMotion/create-event-expected.txt:
* fast/dom/DeviceMotion/script-tests/create-event.js:
* fast/dom/DeviceOrientation/no-synchronous-events-expected.txt:
* fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Style Fix in WebDeviceOrientationController
commit-queue@webkit.org [Tue, 19 Jun 2012 15:38:07 +0000 (15:38 +0000)]
[Chromium] Style Fix in WebDeviceOrientationController
https://bugs.webkit.org/show_bug.cgi?id=89337

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

Changing a local variable from a PassRefPtr to a RefPtr in order to be consistent with the style guide.

* src/WebDeviceOrientationController.cpp:
(WebKit::WebDeviceOrientationController::didChangeDeviceOrientation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, skip one more failing test.
ossy@webkit.org [Tue, 19 Jun 2012 15:17:46 +0000 (15:17 +0000)]
[Qt] Unreviewed gardening, skip one more failing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120715 268f45cc-cd09-0410-ab3c-d52691b4dbfc