Travis Reitter [Thu, 7 Feb 2013 05:33:24 +0000 (21:33 -0800)]
Port folks to libgee 0.8.
Added hash_static and equal_static to AbstractFieldDetails.
Use AbstractFieldDetails hash_static and equal_static where needed.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=673918
Travis Reitter [Fri, 8 Feb 2013 17:28:22 +0000 (09:28 -0800)]
eds test: Ensure the source is declared enabled
This seems to fix the problem with create-remove-stores from failing
sporadically. And it matches all the sample sources used in e-d-s itself.
I also added a trailing \n to match them as well (though it doesn't seem to
have any obvious effect).
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=693435
Philip Withnall [Wed, 6 Feb 2013 17:21:53 +0000 (17:21 +0000)]
individual-aggregator: Expand documentation on linking/unlinking API
Philip Withnall [Tue, 5 Feb 2013 23:00:09 +0000 (23:00 +0000)]
individual-aggregator: Add some documentation on linking/unlinking API
Aurimas Černius [Sat, 26 Jan 2013 18:06:56 +0000 (20:06 +0200)]
Updated Lithuanian translation
Gheyret Kenji [Sat, 26 Jan 2013 01:11:32 +0000 (10:11 +0900)]
Updated Uyghur translation
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
Gheyret Kenji [Sat, 26 Jan 2013 01:09:06 +0000 (10:09 +0900)]
Updated Uyghur translation
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
Gheyret Kenji [Sat, 26 Jan 2013 01:06:46 +0000 (10:06 +0900)]
Updated Uyghur translation
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
Nuno Araujo [Mon, 21 Jan 2013 12:00:41 +0000 (13:00 +0100)]
build: Don't use make functions for defining TESTS
Usage of 'make' functions in the definition of TESTS special variable
can lead to the creation of a corrupt Makefile.in, thus a corrupt Makefile.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=692122
Gheyret Kenji [Sun, 20 Jan 2013 02:49:25 +0000 (11:49 +0900)]
Uyghur translation added
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
Мирослав Николић [Fri, 18 Jan 2013 10:41:46 +0000 (11:41 +0100)]
Updated Serbian translation
Daiki Ueno [Thu, 17 Jan 2013 06:02:36 +0000 (15:02 +0900)]
Don't rebuild docs on every "make" run.
Create timestamp files to avoid redundant valadoc invocation.
https://bugzilla.gnome.org/show_bug.cgi?id=691923
Travis Reitter [Mon, 7 Jan 2013 06:27:27 +0000 (22:27 -0800)]
Bug 691382 — Restore tests disabled by bug #668415 (which has been fixed)
This ports the store-removed test to the current EDS introspection bindings
and removes the change-primary-store test on the basis that we don't really
support clients changing the primary store.
In the future, we may want to add a test to ensure we cope with the primary
store disappearing, but that's a different case.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=691382
Philip Withnall [Sun, 30 Dec 2012 18:53:08 +0000 (18:53 +0000)]
Bug 686695 — support nickname in add_persona_from_details
Support nicknames in add_persona_from_details() in the EDS backend. This
adds a test case (which passes).
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=686695
Alexander Shopov [Wed, 9 Jan 2013 05:10:55 +0000 (07:10 +0200)]
Updated Bulgarian translation
Dušan Kazik [Tue, 8 Jan 2013 20:53:20 +0000 (21:53 +0100)]
Updated slovak translation
Travis Reitter [Sat, 5 Jan 2013 02:02:15 +0000 (18:02 -0800)]
Bug 691167 — Build failure: key-file tests built before dependencies
This fixes a regression from
96c51fe585b which built the key-file tests
before the libraries they depended upon (breaking the build).
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=691167
Travis Reitter [Sun, 6 Jan 2013 01:11:42 +0000 (17:11 -0800)]
Bug 690876 — eds: fix various test failures
Note bug fixed by the last several commits
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=690876
Travis Reitter [Fri, 4 Jan 2013 23:15:57 +0000 (15:15 -0800)]
eds test: don't assume Individuals remain after changing a linkable property
Travis Reitter [Fri, 4 Jan 2013 06:23:04 +0000 (22:23 -0800)]
eds test: create a new address book for each test to avoid inheriting state
This fixes a bug where the second anti-linking test would fail if it ran
after the first.
Travis Reitter [Fri, 4 Jan 2013 05:55:19 +0000 (21:55 -0800)]
eds test: ensure basic anti-link removal works
Travis Reitter [Thu, 3 Jan 2013 17:42:57 +0000 (09:42 -0800)]
eds test: add basic anti-linking test
Travis Reitter [Thu, 3 Jan 2013 00:42:38 +0000 (16:42 -0800)]
eds test: remove unnecessarily-strict test for extra Individual add/remove
Ideally, we should be able to fulfill this test, but it's probably not worth
the extra code complexity.
Travis Reitter [Sun, 30 Dec 2012 20:17:21 +0000 (12:17 -0800)]
eds test: support setting email addresses in test backend
Travis Reitter [Sun, 30 Dec 2012 20:10:47 +0000 (12:10 -0800)]
eds test: rename _parse_addrs to _parse_im_addrs for specificity.
Travis Reitter [Sun, 30 Dec 2012 20:08:49 +0000 (12:08 -0800)]
eds test: ensure changes to linkable properties aggregate Personas together
Travis Reitter [Sun, 30 Dec 2012 02:43:22 +0000 (18:43 -0800)]
eds test: create a new address book for each test to avoid inheriting state
This fixes a bug where the web services linking test would fail if it ran
after the im address linking test.
Travis Reitter [Fri, 28 Dec 2012 17:31:57 +0000 (09:31 -0800)]
eds test: add test for specific behavior of linkable properties
This splits out a subtle and complicated linkable-properties bug discovered
by the set-emails test where changing the emails (which happen to be a
linkable property in the EDS backend) causes an unnecessary Edsf.Persona
creation and removal cycle.
The set-* tests are meant to confirm that reading and writing the given
property works, so seperating this should let us simplify those tests
slightly yet focus on the secondary details we care about in a specific test
case.
Philip Withnall [Thu, 3 Jan 2013 11:18:35 +0000 (11:18 +0000)]
HACKING: Update documentation for running single tests
Philip Withnall [Thu, 3 Jan 2013 11:04:11 +0000 (11:04 +0000)]
build: Rewrite valgrind.mk to use GNU Make conditionals
This means we’re not overwriting rules and potentially changing their
prerequisites. Incorrectly overwriting check-* rules was causing tests to
be run twice in the tests/folks directory.
See: https://bugzilla.gnome.org/show_bug.cgi?id=690990
Philip Withnall [Thu, 3 Jan 2013 10:40:04 +0000 (10:40 +0000)]
build: Fix cleaning of .stamp files in EDS tests directory
Philip Withnall [Thu, 3 Jan 2013 10:35:03 +0000 (10:35 +0000)]
build: Tidy up test Makefiles a little
Guillaume Desmottes [Wed, 2 Jan 2013 09:33:59 +0000 (10:33 +0100)]
HACKING: document how to run a single test
https://bugzilla.gnome.org/show_bug.cgi?id=690990
Philip Withnall [Wed, 2 Jan 2013 16:01:18 +0000 (16:01 +0000)]
build: Update valgrind.mk to match automake-generated ‘check’ rule
The dependencies and chained rule were wrong. Not that it seems to
make much difference.
Philip Withnall [Wed, 2 Jan 2013 15:35:02 +0000 (15:35 +0000)]
Bug 690989 — "warning: copying delegates is discouraged"
Fix a warning introduced by commit
7088fbafafd3e75f02266aa8b093d69660311b36.
Whoops.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=690989
Philip Withnall [Tue, 1 Jan 2013 17:45:22 +0000 (17:45 +0000)]
build: Add a missing bracket in configure.ac
Balázs Úr [Mon, 31 Dec 2012 17:59:21 +0000 (18:59 +0100)]
Updated Hungarian translation
Philip Withnall [Sun, 30 Dec 2012 22:41:59 +0000 (22:41 +0000)]
telepathy: Call continuations in idle callbacks rather than directly
The continuations will proceed to a g_simple_async_result_complete() call,
rather than a g_simple_async_result_complete_in_idle() call as I expected
(and didn’t check). This could result in the first continuation executing
a lot of code and starving the other continuations (and the original
prepare() call). By delaying the continuations to the idle queue, the
original prepare() call is guaranteed to finish first. Then the
continuations can only starve each other.
See: https://bugzilla.gnome.org/show_bug.cgi?id=677633
Philip Withnall [Sun, 30 Dec 2012 00:52:36 +0000 (00:52 +0000)]
individual-aggregator: Fix some debug spew
Philip Withnall [Sun, 30 Dec 2012 00:48:38 +0000 (00:48 +0000)]
documentation: Document which yielding methods are safe to call concurrently
This is a follow-up commit to
ce55fa2bf2f5f8cf95532da585d835bafeeb3347.
I went through all methods in folks which yield to another async method,
and tried to work out whether the caller was safe to run multiple times
concurrently (e.g. begin a second asynchronous call to it between a previous
async call beginning and finishing).
I’ve marked all such methods as safe (or not safe) as appropriate. I
haven’t made any attempt to make the unsafe methods safe, except in one
case in backend-store.vala.
Guillaume Desmottes [Fri, 28 Dec 2012 14:11:25 +0000 (15:11 +0100)]
phone-details: get_normalised: keep the leading '+'
It's needed to be able to call phone numbers containing an international
prefix.
https://bugzilla.gnome.org/show_bug.cgi?id=685992
Yaron Shahrabani [Sat, 29 Dec 2012 09:39:26 +0000 (11:39 +0200)]
Updated Hebrew translation.
Philip Withnall [Fri, 28 Dec 2012 13:47:50 +0000 (13:47 +0000)]
telepathy: Yield subsequent Logger.prepare() calls if one is pending
If one PersonaStore began to prepare its Logger, then yielded on a D-Bus
call, another PersonaStore could begin to prepare its Logger and also
try to create a static D-Bus proxy (which is only supposed to be created
once). This is because the original async call hasn’t returned and set
Logger._logger by that point.
Fix this by keeping a queue of pending prepare() calls which is signalled
by the initial prepare() call once it finishes yielding.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=677633
Philip Withnall [Fri, 28 Dec 2012 13:12:54 +0000 (13:12 +0000)]
telepathy: Remove Logger.prepare() return value
It’s unused. It’s private. It’s a waste of code.
Philip Withnall [Fri, 28 Dec 2012 12:50:35 +0000 (12:50 +0000)]
telepathy: Fix bus watching by multiple Tpf.PersonaStore instances
The bus needs to be watched by all Tpf.PersonaStores which are connected to
the Logger instance, so that they all get the ‘invalidated’ signal.
Dimitris Spingos [Mon, 24 Dec 2012 15:07:45 +0000 (17:07 +0200)]
Updated Greek translation
Fran Diéguez [Sun, 23 Dec 2012 03:24:22 +0000 (04:24 +0100)]
Updated Galician translations
Travis Reitter [Tue, 18 Dec 2012 06:41:35 +0000 (22:41 -0800)]
eds test: Use the same birthday for the test individual and expected value.
Shantha kumar [Tue, 18 Dec 2012 09:57:27 +0000 (15:27 +0530)]
Tamil translation updated
Shantha kumar [Tue, 18 Dec 2012 09:51:48 +0000 (15:21 +0530)]
Tamil Translation updated
Daniel Mustieles [Sun, 16 Dec 2012 19:46:52 +0000 (20:46 +0100)]
Updated Spanish translation
Patrick Ohly [Fri, 7 Dec 2012 18:07:17 +0000 (19:07 +0100)]
folks.pc: remove telepathy-glib
Apps linking against just folks core libraries do not need
telepathy. Always including it as it was done before leads to a
folks.pc which is unusuable unless Telepathy is installed, which
partly defeats the purpose of --disable-telepathy-backend.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=689859
Patrick Ohly [Wed, 5 Dec 2012 14:57:21 +0000 (15:57 +0100)]
eds: handle removal of store without removal of personas
The assumption in the IndividualAggregator that all backends remove
their personas before removing a store did not hold for the EDS
backend when stores were removed via set_persona_stores() or
disable_store().
Fixing that in EDS is tricky, so better make the IndividualAggregator
more resilient and remove any remaining personas when the store gets
removed.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=689146
Takayuki KUSANO [Sat, 1 Dec 2012 13:52:39 +0000 (22:52 +0900)]
[l10n] Update Japanese translation
Dušan Kazik [Fri, 30 Nov 2012 22:23:40 +0000 (23:23 +0100)]
Added slovak translation
Krishnababu Krothapalli [Wed, 28 Nov 2012 10:23:29 +0000 (15:53 +0530)]
Updated Telugu Translations
Krishnababu Krothapalli [Wed, 28 Nov 2012 10:18:57 +0000 (15:48 +0530)]
Updated Telugu Translations
Piotr Drąg [Tue, 27 Nov 2012 16:09:20 +0000 (17:09 +0100)]
Updated Polish translation
Ani Peter [Tue, 27 Nov 2012 06:44:44 +0000 (12:14 +0530)]
Updated Malayalam translations
Patrick Ohly [Fri, 23 Nov 2012 09:08:31 +0000 (10:08 +0100)]
eds: remove urls
URLs which are represented by EContact fields cannot be removed. When
setting UrlFieldDetails, the _set_contact_urls method must remove
X-EVOLUTION-BLOG-URL, X-EVOLUTION-VIDEO-URL, FBURL and URL in addition
to X-URIS, which was already removed before setting the new set of
values.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=688923
Philip Withnall [Sat, 24 Nov 2012 13:01:23 +0000 (13:01 +0000)]
eds: Fix some syntax errors in documentation comments
Patrick Ohly [Fri, 23 Nov 2012 14:06:58 +0000 (15:06 +0100)]
individual: avoid updating in get
Properties with delayed loading always went through an update check
each time the property was read. This slowed down reading
unnecessarily, because constructing the value is costly and necessary
updates are already dealt with via notifications.
Fixed by introducing a new parameter "force_update" which is true
by default (= same behavior as before) and false when used inside
get().
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=688834
Philip Withnall [Sat, 24 Nov 2012 12:48:33 +0000 (12:48 +0000)]
individual-aggregator: Fix a typo in a documentation comment
Jeremy Whiting [Tue, 23 Oct 2012 01:09:08 +0000 (19:09 -0600)]
lsw: Add enable|disable_persona_store api to libsocialweb backend.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=686673
Rajesh Ranjan [Fri, 23 Nov 2012 08:22:38 +0000 (13:52 +0530)]
hindi translation update
Nilamdyuti Goswami [Thu, 22 Nov 2012 14:23:03 +0000 (19:53 +0530)]
Assamese translation updated
Runa Bhattacharjee [Wed, 21 Nov 2012 15:22:20 +0000 (20:52 +0530)]
Added Bengali India to the list of languages
Runa Bhattacharjee [Wed, 21 Nov 2012 15:22:09 +0000 (20:52 +0530)]
Added Bengali India Translation
ManojKumar Giri [Fri, 9 Nov 2012 12:34:25 +0000 (18:04 +0530)]
Updated Odia Translation with FUEL implementation.
ManojKumar Giri [Fri, 9 Nov 2012 12:28:57 +0000 (17:58 +0530)]
Added Odia language into the list.
ManojKumar Giri [Fri, 9 Nov 2012 12:28:29 +0000 (17:58 +0530)]
Updated Odia Translation with FUEL implementation.
Matej Urbančič [Tue, 6 Nov 2012 18:57:10 +0000 (19:57 +0100)]
Updated Slovenian translation
Jeremy Whiting [Tue, 6 Nov 2012 18:39:25 +0000 (11:39 -0700)]
Add bug fix to NEWS file.
Giovanni Campagna [Sat, 20 Oct 2012 14:34:04 +0000 (16:34 +0200)]
eds: expose Google system groups in the public API
This will allow gnome-contacts to change it directly (to switch a contact
from My Contacts to Other and back)
https://bugzilla.gnome.org/show_bug.cgi?id=687050
Jeremy Whiting [Mon, 29 Oct 2012 22:26:21 +0000 (16:26 -0600)]
eds: Put email_addresses_ro back into Edsf.Persona.
eds: Remove extra whitespace.
Jeremy Whiting [Mon, 29 Oct 2012 20:53:23 +0000 (14:53 -0600)]
From Patrick Ohly <patrick.ohly@intel.com>
Like instant messaging handles, email addresses can be assumed to be
unique for individuals. Therefore they can be used for linking by
default. This commit enables that in the EDS backend.
With email addresses being a linkable property, delaying loading of
them no longer makes sense because they will always be loaded.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=685401
Jeremy Whiting [Fri, 26 Oct 2012 20:21:09 +0000 (14:21 -0600)]
From Patrick Ohly <patrick.ohly@intel.com>
Reading converts from date-only to local time to UTC. Writing must do
the same conversion. Conversion from UTC to local time was missing,
therefore the date may have gotten shifted by a day (depending on the
local time zone).
This commit intentionally does not cache the local time zone (like
reading does), because this is a bit ugly and the assumption is that
writing occurs a lot less often than reading.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=686693
Jeremy Whiting [Fri, 26 Oct 2012 20:15:53 +0000 (14:15 -0600)]
Fix build broken by zeitgeist optional bugfix.
Jeremy Whiting [Fri, 26 Oct 2012 17:11:06 +0000 (11:11 -0600)]
Add fix of 686506 to NEWS
Jeremy Whiting [Tue, 23 Oct 2012 01:08:28 +0000 (19:08 -0600)]
tracker: Add enable|disable_persona_store implementation to tracker backend.
core: Remove trailing whitespace in folks/backend.vala
Matthias Clasen [Tue, 23 Oct 2012 16:22:12 +0000 (12:22 -0400)]
Make zeitgeist optional again
This commit makes folks build without zeitgeist again.
Philip Withnall [Sun, 21 Oct 2012 11:24:10 +0000 (12:24 +0100)]
Bug 685250 — make <test>.gdb deadlocks
Always set CHECK_VERBOSE when running tests under gdb so that output (from
gdb) isn’t redirected to a log file. Apparently, headless gdb is hard to
use.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=685250
Jeremy Whiting [Wed, 17 Oct 2012 22:17:00 +0000 (16:17 -0600)]
Add bugfix and new create|remove_address_book API to NEWS.
Jeremy Whiting [Mon, 15 Oct 2012 21:23:04 +0000 (15:23 -0600)]
eds: Add create_address_book and remove_address_book to Edsf.PersonaStore.
eds: Add create-remove-stores unit test.
Jeremy Whiting [Wed, 10 Oct 2012 22:29:48 +0000 (16:29 -0600)]
Add Ofono backend to NEWS file.
Jeremy Whiting [Fri, 28 Sep 2012 21:13:39 +0000 (15:13 -0600)]
ofono: Added new Ofono backend to read contacts from SIM cards.
Jeremy Whiting [Wed, 3 Oct 2012 21:15:21 +0000 (15:15 -0600)]
telepathy: Implement set_persona_stores backend method.
Jeremy Whiting [Tue, 2 Oct 2012 21:37:54 +0000 (15:37 -0600)]
eds: if set given to set_persona_stores is null, load any missing stores.
Jeremy Whiting [Sat, 29 Sep 2012 16:52:50 +0000 (10:52 -0600)]
Add new api to NEWS file.
Jeremy Whiting [Wed, 26 Sep 2012 21:35:54 +0000 (15:35 -0600)]
telepathy: Add enable_persona_store and disable_persona_store to telepathy backend.
telepathy: Add empty set_persona_stores to telepathy backend.
Jeremy Whiting [Wed, 26 Sep 2012 21:35:02 +0000 (15:35 -0600)]
keyfile: Add enable/disable_persona_store to keyfile backend.
keyfile: Add set_persona_stores to keyfile backend.
Jeremy Whiting [Mon, 24 Sep 2012 18:17:21 +0000 (12:17 -0600)]
eds: Add test for disabling and enabling persona stores.
Jeremy Whiting [Sat, 22 Sep 2012 00:21:05 +0000 (18:21 -0600)]
core: Add set_persona_stores method to Backend.
eds: Implement set_persona_stores in eds backend.
Jeremy Whiting [Thu, 20 Sep 2012 19:59:54 +0000 (13:59 -0600)]
core: Add disable_persona_store and enable_persona_store API to backend
eds: Implement new API in eds backend
Jeremy Whiting [Fri, 14 Sep 2012 21:34:08 +0000 (15:34 -0600)]
core: Add method to create IndividualAggregator passing in a BackendStore.
Alexander Shopov [Wed, 10 Oct 2012 07:01:46 +0000 (10:01 +0300)]
Updated Bulgarian translation
Philip Withnall [Thu, 4 Oct 2012 07:59:00 +0000 (08:59 +0100)]
Post-release version bump
Philip Withnall [Thu, 4 Oct 2012 07:55:47 +0000 (08:55 +0100)]
Release version 0.8.0
Philip Withnall [Thu, 4 Oct 2012 07:30:25 +0000 (08:30 +0100)]
core: Fix comparison of updated local IDs
We should be comparing a set of strings, not a set of AbstractFieldDetails.
This fixes a crash in the link-personas-via-local-ids Tracker test.
Philip Withnall [Wed, 3 Oct 2012 23:50:38 +0000 (00:50 +0100)]
tests: Fix creation/deletion of E.Sources in EDS test backend
The E.Sources for testing were being created by calling `cp` in the wrapper
script running around the entire test suite. However, each test case was
tearing down the E.Sources by deleting them. This meant that no E.Source
existed for anything except the first test case in a given test suite.
The fix is to move the file copying inside the test suite’s setup method.