nirajkr [Fri, 21 Mar 2014 08:00:46 +0000 (17:00 +0900)]
gengrid : Implementation for gengrid item focus support
Summary:
Implemented the following API to support gengrid item_focus
1. _elm_gengrid_focus_highlight_geometry_get
2. _elm_gengrid_focused_item_get
3. _item_focus_up
4. _item_focus_down
5. _item_focus_right
6. _item_focus_down
7. _item_focus_set_hook
8. _item_focus_get_hook
9. _item_focused
10. _item_unfocused
11. Changes in the smart_event, pan_calculation, smart_on_focus to support item focus
Reviewers: seoz, woohyun, singh.amitesh, raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D550
Carsten Haitzler (Rasterman) [Fri, 21 Mar 2014 03:20:43 +0000 (12:20 +0900)]
fix scrollbar to be clickable even if vieport is tiny compared to content
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 17:35:29 +0000 (02:35 +0900)]
test_dnd: Fixed memory leak. Free item's data on item deletion.
This fixes coverity CID 1193246: Resource leak (RESOURCE_LEAK).
Daniel Juyung Seo [Thu, 20 Mar 2014 17:33:22 +0000 (02:33 +0900)]
access: Fixed memory leak.
This fixes coverity CID 1193244: Resource leak (RESOURCE_LEAK).
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 15:55:31 +0000 (00:55 +0900)]
index: Set variable to NULL after free.
Then NULL check for this variable is not valid.
This fixes coverity CID 1193250: Use after free (USE_AFTER_FREE).
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 15:49:52 +0000 (00:49 +0900)]
atspi_object: Added missing comma.
This fixes coverity CID 1193238: Missing comma in a string array
initialization (MISSING_COMMA)
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 15:46:47 +0000 (00:46 +0900)]
diskselector: Compare correct variables.
It was comparing the same variable.
Fixed coverity CID 1193236: Pointless string comparison
(CONSTANT_EXPRESSION_RESULT)
@fix
Ryuan Choi [Thu, 20 Mar 2014 14:28:53 +0000 (23:28 +0900)]
test_web: Improve fullscreen test case.
Improved fullscreen api tests not to show other widgets when web page requires fullscreen.
Daniel Zaoui [Thu, 20 Mar 2014 13:17:55 +0000 (15:17 +0200)]
Eolian: Integration of Datetime
Daniel Zaoui [Thu, 20 Mar 2014 13:06:33 +0000 (15:06 +0200)]
Eolian: Integration of Ctx Popup
Daniel Zaoui [Thu, 20 Mar 2014 12:37:43 +0000 (14:37 +0200)]
Eolian: Integration of Conformant
Daniel Zaoui [Thu, 20 Mar 2014 12:29:12 +0000 (14:29 +0200)]
Eolian: Integration of Color Selector
Daniel Zaoui [Thu, 20 Mar 2014 09:11:48 +0000 (11:11 +0200)]
Eolian: Integration of Clock
Daniel Zaoui [Thu, 20 Mar 2014 08:27:21 +0000 (10:27 +0200)]
Eolian: Integration of Check
Daniel Zaoui [Thu, 20 Mar 2014 07:44:34 +0000 (09:44 +0200)]
Eolian: Integration of Calendar
Daniel Zaoui [Thu, 20 Mar 2014 06:40:43 +0000 (08:40 +0200)]
Eolian: Integration of Button
Daniel Zaoui [Thu, 20 Mar 2014 06:40:07 +0000 (08:40 +0200)]
Eolian: Integration of Bubble
Daniel Zaoui [Thu, 20 Mar 2014 05:58:37 +0000 (07:58 +0200)]
Eolian: Integration of Box
Bora Hwang [Thu, 20 Mar 2014 11:12:02 +0000 (20:12 +0900)]
clear up the documentation of tooltip
Summary: Since explanations of tooltip's APIs are scattered in header or source code, these needs to be cleared up.
Reviewers: seoz, Hermet, woohyun, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D644
Thiep Ha [Thu, 20 Mar 2014 10:33:42 +0000 (19:33 +0900)]
[Elm_Entry] Update selection handlers position and its visibility when scrolling
Summary:
Selection handlers' position are not updated when entry is scrolled.
You can check on elementary_test -> Entry 3 (or Entry 4 which is scrollable) -> Select some text -> Scroll entry and see.
This patch is submitted to fix this bug. It update selection handlers' position when entry is scrolled and hide them if needed.
@fix
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D640
Jaeun Choi [Thu, 20 Mar 2014 09:42:20 +0000 (18:42 +0900)]
config: add a field in key binding data structure
Summary:
This patch adds a field "no_string" in key binding data structure.
It is necessary for checking "string" field in evas key down event.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D641
Daniel Juyung Seo [Thu, 20 Mar 2014 05:54:38 +0000 (14:54 +0900)]
list: Focus a selected item.
Daniel Zaoui [Wed, 19 Mar 2014 13:27:27 +0000 (15:27 +0200)]
Eolian: Integration of Bg
Daniel Zaoui [Wed, 19 Mar 2014 13:07:26 +0000 (15:07 +0200)]
Eolian: Integration of Atspi Object
Daniel Zaoui [Wed, 19 Mar 2014 11:42:15 +0000 (13:42 +0200)]
Eolian: Integration of Atspi Window Interface
Daniel Zaoui [Wed, 19 Mar 2014 11:26:12 +0000 (13:26 +0200)]
Eolian: Integration of Atspi Component Interface
Daniel Zaoui [Wed, 19 Mar 2014 09:24:22 +0000 (11:24 +0200)]
Eolian: Integration of App Server View
Daniel Zaoui [Wed, 19 Mar 2014 09:01:17 +0000 (11:01 +0200)]
Eolian: Integration of App Server
Daniel Zaoui [Thu, 20 Mar 2014 05:12:16 +0000 (07:12 +0200)]
Fix logically dead code.
CID 1193237
Before Eolian, a Eina_List ** was used and checking ret value was
mandatory. Now that we have a normal Eina_List *, we don't need to check
that anymore.
WooHyun Jung [Thu, 20 Mar 2014 05:14:20 +0000 (14:14 +0900)]
elm_win: Fix wrong animation of focus highlight.
When focus is changed, focus highlight animation should be started
from the original position of focus highlight object. Not from the
previous focused object's position.
Daniel Juyung Seo [Thu, 20 Mar 2014 04:48:49 +0000 (13:48 +0900)]
list: better structure packing for list smart data.
WooHyun Jung [Thu, 20 Mar 2014 03:55:28 +0000 (12:55 +0900)]
elm_widget: Restore removed codes while eolian work.
Daniel Juyung Seo [Wed, 19 Mar 2014 19:08:52 +0000 (04:08 +0900)]
cnp: Fixed cnp build warning by adding ifdef to cnp_debug.
This looks better.
Special thanks to barbieri for the suggestion.
Daniel Juyung Seo [Wed, 19 Mar 2014 19:04:12 +0000 (04:04 +0900)]
elm_widget: Call widget APIs only for widgets.
'cur' object can be non-widget object when calling
elm_widget_focus_direction_get and elm_widget_parent_get.
Daniel Juyung Seo [Wed, 19 Mar 2014 19:02:08 +0000 (04:02 +0900)]
test_list: Added focus/selection API test for list focus test case.
Added two buttons.
1. focus 3rd list item by elm_object_item_focus_set() API after 1.5 seconds.
2. select 3rd list item by elm_list_item_selected_set() API after 1.5 seconds.
Daniel Juyung Seo [Wed, 19 Mar 2014 18:44:47 +0000 (03:44 +0900)]
test_list: Used frame for focus option box.
Daniel Juyung Seo [Wed, 19 Mar 2014 17:13:41 +0000 (02:13 +0900)]
toolbar: Fixed wrong parameter for elm_widget_sub_object_del.
Remove the icon from the sub object list for a widget not for an edje object.
Daniel Juyung Seo [Wed, 19 Mar 2014 17:13:03 +0000 (02:13 +0900)]
scroller: Fixed wrong widget call to non-widget object.
content can be a non-widget object.
Daniel Juyung Seo [Wed, 19 Mar 2014 17:10:08 +0000 (02:10 +0900)]
cnp: Fixed build warning.
elm_cnp.c: In function '_x11_dnd_leave':
elm_cnp.c:1547:69: warning: unused parameter 'ev' [-Wunused-parameter]
Tom Hacohen [Wed, 19 Mar 2014 09:43:07 +0000 (09:43 +0000)]
Eolian helper: Update to regenerate if generator is updated.
This is a sync from efl.git
6a66af39cb388c308fe585c8f6d41c032c747c67
Thiep Ha [Wed, 19 Mar 2014 06:59:13 +0000 (15:59 +0900)]
[Elm_Dnd] Fix type matching of drag and drop target objects in X11.
Summary:
Type matching for drag and drop targets does not consider drop target objects' types.
For example, we have drag object which provides image type and drop target object which only accepts text type.
For current code, in _x11_dnd_drop function, we only check savedtypes.types with _x11_atoms.
As result, we allows the image to be dropped into text. You can refer to the test in D617.
This path fixes this issue by matching drag object's type with drop targets' types to find suitable one.
@fix
Reviewers: raster, JackDanielZ, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D628
Daniel Zaoui [Wed, 19 Mar 2014 06:34:16 +0000 (08:34 +0200)]
Eolian: fix dependency for .eo.c/h files.
When Eolian generator is updated, the .eo.c/h files of Elementary must be
regenerated.
Daniel Zaoui [Tue, 18 Mar 2014 15:37:44 +0000 (17:37 +0200)]
Eolian: Integration of App Client View
Daniel Zaoui [Tue, 18 Mar 2014 14:40:24 +0000 (16:40 +0200)]
Eolian: Integration of App Client
Daniel Zaoui [Tue, 18 Mar 2014 14:13:12 +0000 (16:13 +0200)]
Eolian: Fix ctor/dtor generation
Daniel Zaoui [Tue, 18 Mar 2014 12:27:07 +0000 (14:27 +0200)]
Eolian: Integration of Actionslider
Daniel Zaoui [Tue, 18 Mar 2014 11:47:23 +0000 (13:47 +0200)]
Eolian: Integration of Access
Flavio Ceolin [Tue, 18 Mar 2014 20:37:31 +0000 (17:37 -0300)]
list: Avoiding the same item receive focus twice
When the item was activated by double click it received the focus twice
and the second is after had emitted the activated signal.
Flavio Ceolin [Tue, 18 Mar 2014 20:15:36 +0000 (17:15 -0300)]
list: Fixing the focus on keyboard movement
Problem introduced on: fb13ad2
Daniel Juyung Seo [Tue, 18 Mar 2014 15:48:07 +0000 (00:48 +0900)]
genlist: Fixed annoying autoscrolling bug in genlist item focus.
Now, genlist does not autoscroll to last focused/selected item when the genlist
is focused. It tries to find the nearest visible item instead of the
last focused/selected item.
Daniel Zaoui [Tue, 18 Mar 2014 11:59:21 +0000 (13:59 +0200)]
Accessibility: unref the object only if it exists.
If the type returned by evas_object_type_get is "", no object will be
created. There is no reason why unref would be invoked.
It removes all the bad prints in accessibility tests about obj_id NULL.
@fix
Daniel Juyung Seo [Tue, 18 Mar 2014 10:14:39 +0000 (19:14 +0900)]
list/genlist: Fixed Home and End key event handling routine.
Move focus and selection when Home or End key is pressed.
@fix
This needs a partial backport to elementary-1.9
Daniel Juyung Seo [Tue, 18 Mar 2014 10:04:56 +0000 (19:04 +0900)]
elm_widget: Removed unnecessary if statement.
Daniel Juyung Seo [Tue, 18 Mar 2014 10:02:04 +0000 (19:02 +0900)]
elm_widget: Call elm_widget functions only for widgets.
Daniel Juyung Seo [Tue, 18 Mar 2014 05:09:01 +0000 (14:09 +0900)]
Revert "genlist no longer scrolls crazily"
This reverts commit
7a653914ad048c00871d2ef71a56185e5a7fb1ca.
I will fix this in another way.
Daniel Juyung Seo [Tue, 18 Mar 2014 05:08:41 +0000 (14:08 +0900)]
Revert "genlist now uses uniform item showing behavior when selecting items with keyboard"
This reverts commit
85332555e8d3e5b981cde10ba9a1675ef6a4936e.
I will fix this in another way.
Carsten Haitzler (Rasterman) [Tue, 18 Mar 2014 08:22:04 +0000 (17:22 +0900)]
warning--
Subhransu Sekhar Mohanty [Tue, 18 Mar 2014 08:18:09 +0000 (17:18 +0900)]
elm_theme: Added a cache in elm_theme for styles that are failed to load.
Summary:
Currenlty loading a style that is not present in the system hits the worst case path in elm_theme as it searches through all hirarchy before
reporting that the style is not there. if those styles requested frequently it will be a overhead as it will goes through all the theme files again.
To avoid that I have added a cache which will keep track of the styles whose loading were not sucessfull so that for future request we can simply check the
cache before looking into the hirarchy of theme files.
Reviewers: seoz, raster
Reviewed By: raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D601
Carsten Haitzler (Rasterman) [Tue, 18 Mar 2014 06:33:07 +0000 (15:33 +0900)]
add soem more cb's for testign win state
Daniel Zaoui [Mon, 17 Mar 2014 14:48:52 +0000 (16:48 +0200)]
Eolian: Integration of Hover
Daniel Zaoui [Tue, 18 Mar 2014 07:01:28 +0000 (09:01 +0200)]
Eolian: Integration of Frame
Daniel Zaoui [Mon, 17 Mar 2014 13:52:41 +0000 (15:52 +0200)]
Eolian: Integration of Pan
Daniel Zaoui [Mon, 17 Mar 2014 11:44:40 +0000 (13:44 +0200)]
Eolian: Integration of Scrollable Interface
Daniel Zaoui [Tue, 18 Mar 2014 06:07:14 +0000 (08:07 +0200)]
Focus: fix segfault due to bad call to Eo function.
Due to Eolian auto-generation, legacy parameters are directly
transferred to Eo functions without conversion.
In this case, is_next was Eina_Bool in legacy and Eina_Bool * in Eo.
The logic code was expecting a pointer but was receiving a Eina_Bool.
The fix consists in giving the logic code the Eina_Bool instead of the
pointer.
@fix
Carsten Haitzler (Rasterman) [Tue, 18 Mar 2014 06:11:43 +0000 (15:11 +0900)]
test - elm win states - add more printfs of events on a window
Daniel Juyung Seo [Tue, 18 Mar 2014 05:08:08 +0000 (14:08 +0900)]
po: Updated po files.
Daniel Juyung Seo [Tue, 18 Mar 2014 04:16:42 +0000 (13:16 +0900)]
author: Added Subhransu to authors list.
Thanks for the contribution Subhransu.
Daniel Juyung Seo [Tue, 18 Mar 2014 00:50:31 +0000 (09:50 +0900)]
test_panel: Refactor the internals of panel test.
- Use elm_genlist_item_class_new/free.
- Use elm_app_data_dir_get() instead of predefined PACKAGE_DATA_DIR.
- Created more internal function for the readability.
- Added comments for panels.
- Moved codes around for a better readability.
- Removed unnecessary code.
Flavio Ceolin [Mon, 17 Mar 2014 19:55:08 +0000 (16:55 -0300)]
elm:list: Avoiding two items be focused at same action
On a list that have not received focus yet a mouse down gives the focus
for the list (that gives the focus for the first item) and the mouse
up the item is selected and receive the focus.
The problem: if the list is scrolled the focus given for the
first item makes the list scroll to the top and not for the item
selected by the user.
Mike Blumenkrantz [Mon, 17 Mar 2014 19:10:33 +0000 (15:10 -0400)]
+test for gengrid speed
this is a test for demonstrating the severity of T1068. scrolling and resizing the test cause very long ui blockages
Mike Blumenkrantz [Mon, 17 Mar 2014 18:55:39 +0000 (14:55 -0400)]
genlist now uses uniform item showing behavior when selecting items with keyboard
Ryuan Choi [Mon, 17 Mar 2014 17:40:31 +0000 (02:40 +0900)]
elm_web: Moved legacy APIs from elm_web_common.h to elm_web_legacy.h
elm_web_add and elm_web_zoom_mode_{get|set} are legacy APIs so they should be
in elm_web_legacy.h
Mike Blumenkrantz [Mon, 17 Mar 2014 17:25:06 +0000 (13:25 -0400)]
genlist no longer scrolls crazily
fix T1090
Daniel Zaoui [Sun, 16 Mar 2014 13:43:07 +0000 (15:43 +0200)]
Eolian: Integration of Layout
Daniel Zaoui [Sun, 16 Mar 2014 11:32:53 +0000 (13:32 +0200)]
Eolian: Integration of Container
Daniel Zaoui [Fri, 14 Mar 2014 09:13:29 +0000 (11:13 +0200)]
Eolian: Integration of Elm Widget
ChunEon Park [Sun, 16 Mar 2014 15:27:06 +0000 (00:27 +0900)]
entry - entry did word wrapping even the mode was ELM_WRAP_NONE.
The ELM_WRAP_NONE mode should not have word wrap textblock style.
@fix
Andy Williams [Fri, 14 Mar 2014 07:49:59 +0000 (07:49 +0000)]
panel: Update the panel test to layout over some content - a more realistic demonstration of the capabilities
davemds [Sat, 15 Mar 2014 21:38:12 +0000 (22:38 +0100)]
elm_list: check sd not being null before access its members.
If the list is deleted/recteated the _elm_list_item_focused/unfocused() is
called and the sd pointer is null.
This unbreak all my apps that use elm_list
Andy Williams [Fri, 14 Mar 2014 01:32:23 +0000 (01:32 +0000)]
naviframe: Fixing issue with over-generalisation of common code in change: Refactored item_push functionality in naviframe.
Daniel Juyung Seo [Sat, 15 Mar 2014 18:09:56 +0000 (03:09 +0900)]
segment_control, toolbar: Fixed broken scale of widget item.
@fix. This needs to be partially backported.
Daniel Juyung Seo [Sat, 15 Mar 2014 18:08:19 +0000 (03:08 +0900)]
entry: Use ELM_SAFE_FREE and fixed indentation.
Daniel Juyung Seo [Sat, 15 Mar 2014 17:39:09 +0000 (02:39 +0900)]
list: Reset prev_focused_item when prev_focused_item is deleted.
This is inspired by
a2c680d684601d8df725e8293616c880f07d3ca2.
nirajkr [Sat, 15 Mar 2014 17:35:10 +0000 (02:35 +0900)]
elm_genlist: Handle prev_focused_item if it get deleted
Summary:
Assign the prev_focused_item to NULL it get deleted
Reviewers: seoz, raster
Differential Revision: https://phab.enlightenment.org/D635
ChunEon Park [Sat, 15 Mar 2014 06:36:41 +0000 (15:36 +0900)]
entry - fixed calc issue of the wrap none mode.
This deferred recalc job is considered for wrap mode.
if the wrap mode is disabled, this job should be discarded.
since the wrap mode is enabled in default.
the job would be performed even the wrap mode was changed later.
@fix.
Carsten Haitzler (Rasterman) [Sat, 15 Mar 2014 03:01:56 +0000 (12:01 +0900)]
theme overlays - fix to prepend on overlay to be semantically consistent
@fix
Carsten Haitzler (Rasterman) [Sat, 15 Mar 2014 02:44:20 +0000 (11:44 +0900)]
formatting - remove space between return and ;
zmike [Fri, 14 Mar 2014 18:15:22 +0000 (14:15 -0400)]
gengrid clear should do nothing if there are no items
zmike [Fri, 14 Mar 2014 17:55:11 +0000 (13:55 -0400)]
genlist shouldn't try to focus an item when it has no items
Tom Hacohen [Thu, 13 Mar 2014 15:14:59 +0000 (15:14 +0000)]
Remove silencing of errors when called on non elm widgets.
There was code to silence errors. Removing that exposed a lot of errors.
I fixed them as well. In general, elm_widget functions should only be called
on elm_widgets...
More of commit
5ac398b156e8fb0aa44c6cfe8a2b113eb7229fbf
Tom Hacohen [Thu, 13 Mar 2014 13:24:08 +0000 (13:24 +0000)]
Remove silencing of errors when called on non elm widgets.
There was code to silence errors. Removing that exposed a lot of errors.
I fixed them as well. In general, elm_widget functions should only be called
on elm_widgets...
@fix.
Carsten Haitzler (Rasterman) [Thu, 13 Mar 2014 13:16:44 +0000 (22:16 +0900)]
theme - tasks - fix colorclass of selected text
Thiep Ha [Thu, 13 Mar 2014 13:08:08 +0000 (22:08 +0900)]
Test_dnd: Add more test for dnd
Summary:
There is no dnd test for format types except ELM_SEL_FORMAT_TARGETS.
This patch adds a test for other formats, so that we can test more about dnd.
Reviewers: JackDanielZ, seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D617
Tom Hacohen [Thu, 13 Mar 2014 10:09:51 +0000 (10:09 +0000)]
Eolian: Added a variable for the needed deps's Eolian flags.
Tom Hacohen [Thu, 13 Mar 2014 08:50:52 +0000 (08:50 +0000)]
Eolian: Fix building of .eo files.
It was incorrectly detected that this is an internal build, which caused issues.
Ryuan Choi [Wed, 12 Mar 2014 15:41:48 +0000 (00:41 +0900)]
elm_web2: Implemented to support HTML5 fullscreen API
test case : elementary_test -to webui
Tom Hacohen [Wed, 12 Mar 2014 14:17:26 +0000 (14:17 +0000)]
Ship missing headers, and remove wrong includes
elm_gen_common.h was not installed, but is needed by installed headers.
Remove dependencies on internal headers from shipped headers.
Guilherme Iscaro de Godoy [Wed, 12 Mar 2014 13:02:17 +0000 (10:02 -0300)]
Bug fix: Elm_List was not correctly setting the highlight theme for its items.
With the introduction of the patch
3628a8c4ea2485ee7ee5a81cfd4e0f0fe62b10d6,
it is possible to highlight focused Elm_List and Elm_Genlistenlist items.
However, this feature does not work correctly if one wants to create a custom
highlight theme for Elm_List items.
The whole problem was happening, because the function
_elm_widget_item_highlight_in_theme() was being called in a incorrect
location. This function must be called at _items_fix(), because
there the Elm_List already set the item theme and then it's possible
to check if the one wants a custom highlight or not.
Subhransu Sekhar Mohanty [Wed, 12 Mar 2014 10:13:26 +0000 (19:13 +0900)]
naviframe : Refactored item_push functionality in naviframe.
Summary:
Added item_push_helper function, so that both item_push as well as item_promote
will reuse the same functionality.
Reviewers: seoz, Hermet, Jaehyun
Differential Revision: https://phab.enlightenment.org/D627
Tom Hacohen [Wed, 12 Mar 2014 09:39:10 +0000 (09:39 +0000)]
Elm test dnd: Fixed substraction of void *.
This is not allowed. The pointers need to be cast to char * before doing
pointer arithmetics.