Kamil Dudka [Thu, 27 May 2010 21:45:18 +0000 (23:45 +0200)]
test313: a new test for CRL support
Kamil Dudka [Thu, 27 May 2010 21:39:54 +0000 (23:39 +0200)]
tests/certs: re-generated because of lost pass-phrase
Kamil Dudka [Thu, 27 May 2010 21:33:19 +0000 (23:33 +0200)]
tests/certs/scripts: generate also CRL
... and make it possible to do so without any user interaction
Howard Chu [Thu, 27 May 2010 20:37:00 +0000 (22:37 +0200)]
openldap: fix compiler warnings
Daniel Stenberg [Thu, 27 May 2010 19:03:46 +0000 (21:03 +0200)]
indent: some whitespace edits
Kamil Dudka [Thu, 27 May 2010 18:56:01 +0000 (20:56 +0200)]
wildcard.c: add missing include of "setup.h"
Tor Arntsen [Thu, 27 May 2010 18:20:08 +0000 (20:20 +0200)]
lib573: do not compare double for exact match
Pavel Raiskup [Thu, 13 May 2010 15:50:27 +0000 (17:50 +0200)]
wildcard.c: add missing include of "curl_memory.h"
Tor Arntsen [Thu, 27 May 2010 14:58:15 +0000 (16:58 +0200)]
setup_once: use enum type for 'bool' on non-C99 platforms
An enum will catch non-bool assignments to bool on platforms with
a strict compiler, e.g MIPSPro.
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
Kamil Dudka [Wed, 26 May 2010 09:12:26 +0000 (11:12 +0200)]
url.c: avoid implied cast to bool
Tor Arntsen [Thu, 27 May 2010 14:34:57 +0000 (16:34 +0200)]
curl_fnmatch: remove use of register keyword
Using the 'register' keyword rarely improves anything with modern
compilers and architectures.
Julien Chaffraix [Tue, 25 May 2010 13:43:41 +0000 (06:43 -0700)]
RTMP: Fix compiler warnings
Julien Chaffraix [Tue, 25 May 2010 13:53:48 +0000 (06:53 -0700)]
OOM fixes in http_negociate.c and lib/splay.c
Fix 2 OOM errors: a missing NULL-check in lib/http_negociate.c
and a potential NULL dereferencing in lib/splay.c
Howard Chu [Mon, 24 May 2010 22:44:42 +0000 (00:44 +0200)]
LDAP: properly implemented as a curl_handler
makes the LDAP code much cleaner, nicer and in general being a
better libcurl citizen. If a new enough OpenLDAP version is
detect, the new and shiny lib/openldap.c code is then used
instead of the old cruft
Code by Howard, minor cleanups by Daniel.
Tor Arntsen [Fri, 21 May 2010 14:21:44 +0000 (14:21 +0000)]
curl_fnmatch: Use int not bool when function returns int
bool in curl internals is unsigned char and should not be used
to receive return value from functions returning int - this fails
when using IBM VisualAge and Tru64 compilers.
Daniel Stenberg [Fri, 21 May 2010 21:29:52 +0000 (23:29 +0200)]
TFTP: send legal timeout value
Eric Mertens posted bug #3003705: when we made TFTP use the
correct timeout option when sent to the server (fixed May 18th
2010) it became obvious that libcurl used invalid timeout values
(300 by default while the RFC allows nothing above 255). While of
course it is obvious that as TFTP has worked thus far without
being able to set timeout at all, just removing the setting
wouldn't make any difference in behavior. I decided to still keep
it (but fix the problem) as it now actually allows for easier
(future) customization of the timeout.
(http://curl.haxx.se/bug/view.cgi?id=3003705)
Daniel Stenberg [Fri, 21 May 2010 21:07:59 +0000 (23:07 +0200)]
TFTP: don't ack if wrong block num is received
If an unexpected block number was received, break out of the
switch loop.
Daniel Stenberg [Fri, 21 May 2010 21:04:15 +0000 (23:04 +0200)]
TFTP: block id wrap bug fix
In a normal expression, doing [unsigned short] + 1 will not wrap
at 16 bits so the comparisons and outputs were done wrong. I
added a macro do make sure it gets done right.
Douglas Kilpatrick filed bug report #3004787 about it:
http://curl.haxx.se/bug/view.cgi?id=3004787
Ben Greear [Thu, 20 May 2010 18:15:52 +0000 (20:15 +0200)]
Fix build warnings.
Signed-off-by: Ben Greear <greearb@candelatech.com>
Ben Greear [Thu, 20 May 2010 18:15:51 +0000 (20:15 +0200)]
setopt: Fix setting of set.is_fwrite_set
Signed-off-by: Ben Greear <greearb@candelatech.com>
Tanguy Fautre [Thu, 20 May 2010 20:40:48 +0000 (22:40 +0200)]
build: allow curl to build with Microsoft VC10
By undefing a bunch of E* defines that VC10 has started to define
but that we redefine internally to their WSA* alternatives when
building for Windows.
Tor Arntsen [Thu, 20 May 2010 14:33:29 +0000 (16:33 +0200)]
Test 573: Use correct type for CURLINFO_CONNECT_TIME
curl_easy_getinfo() called with a pointer to long instead of double
would sigbus on RISC processors (e.g. MIPS) due to wrong alignment
of pointer address.
Tor Arntsen [Wed, 19 May 2010 14:26:08 +0000 (14:26 +0000)]
lib: Fix AIX build failure
Dan Fandrich [Wed, 19 May 2010 19:18:06 +0000 (12:18 -0700)]
Fixed some memory leaks in the POP3 torture tests
Dan Fandrich [Tue, 18 May 2010 21:44:19 +0000 (14:44 -0700)]
Fixed a memory leak in the SMTP torture tests
Daniel Stenberg [Tue, 18 May 2010 21:14:00 +0000 (23:14 +0200)]
TFTP: send timeout option correctly
Eric Mertens posted bug report #3003005 pointing out that the
libcurl TFTP code was not sending the timeout option properly to
the server, and suggested a fix.
(http://curl.haxx.se/bug/view.cgi?id=3003005)
Tor Arntsen [Sun, 16 May 2010 20:01:17 +0000 (22:01 +0200)]
lib: Change some CRLF line endings to LF
An update had added a couple of lines with DOS line endings,
and some compilers will choke on that (e.g. the Tru64 compiler).
Kamil Dudka [Sun, 16 May 2010 00:49:08 +0000 (02:49 +0200)]
ftp wildcard: a new option CURLOPT_FNMATCH_DATA
Howard Chu [Sat, 15 May 2010 20:13:17 +0000 (22:13 +0200)]
RMTP: the version code is now rtmp aware
Howard Chu [Sat, 15 May 2010 20:02:44 +0000 (22:02 +0200)]
RTMP: fix wrong #ifdef
Pavel Raiskup [Sat, 15 May 2010 19:58:50 +0000 (21:58 +0200)]
ftp wildcard: fix int32_t and size/group mixups
Dan Fandrich [Fri, 14 May 2010 21:42:58 +0000 (14:42 -0700)]
Fixed test 577 to work when --enable-hidden-symbols is configured
Daniel Stenberg [Fri, 14 May 2010 20:34:10 +0000 (22:34 +0200)]
OpenSSL: multi interface handshake could hang
John-Mark Bell filed bug #3000052 that identified a problem (with
an associated patch) with the OpenSSL handshake state machine
when the multi interface is used:
Performing an https request using a curl multi handle and using
select or epoll to wait for events results in a hang. It appears
that the cause is the fix for bug #2958179, which makes
ossl_connect_common unconditionally return from the step 2 loop
when fetching from a multi handle.
When ossl_connect_step2 has completed, it updates
connssl->connecting_state to ssl_connect_3. ossl_connect_common
will then return to the caller, as a multi handle is in
use. Eventually, the client code will call curl_multi_fdset to
obtain an updated fdset to select or epoll on. For https
requests, curl_multi_fdset will cause https_getsock to be called.
https_getsock will only return a socket handle if the
connecting_state is ssl_connect_2_reading or
ssl_connect_2_writing. Therefore, the client will never obtain a
valid fdset, and thus not drive the multi handle, resulting in a
hang.
(http://curl.haxx.se/bug/view.cgi?id=3000052)
Daniel Stenberg [Fri, 14 May 2010 20:19:08 +0000 (22:19 +0200)]
changelog: add link to bug report
Dan Fandrich [Fri, 14 May 2010 20:31:07 +0000 (13:31 -0700)]
Added directories.pm to the source tar ball
Daniel Stenberg [Fri, 14 May 2010 20:12:07 +0000 (22:12 +0200)]
follow redirect: ignore response-body on redirect even if compressed
Sebastian V reported bug #3000056 identifying a problem with
redirect following. It showed that when curl followed redirects
it didn't properly ignore the response body of the 30X response
if that response was using compressed Content-Encoding!
(http://curl.haxx.se/bug/view.cgi?id=3000056)
Daniel Stenberg [Fri, 14 May 2010 18:55:54 +0000 (20:55 +0200)]
version: we're now going for 7.21.0
Hoi-Ho Chan [Sun, 9 May 2010 17:44:32 +0000 (12:44 -0500)]
Remove support for BSD version of PolarSSL
"The BSD version of PolarSSL was made for migratory purposes only and is not
maintained. The GPL version of PolarSSL is actually the only actively
developed version, so I would be very reluctant to use the BSD version." /
Paul Bakker, PolarSSL hacker.
Signed-off-by: Hoi-Ho Chan <hoiho.chan@gmail.com>
Dan Fandrich [Thu, 13 May 2010 02:05:58 +0000 (19:05 -0700)]
Added Polar SSL and RTMP files to the non-autoconf build files
I didn't bother with a few that have little hope of running the required
dependent libraries.
Dan Fandrich [Thu, 13 May 2010 00:31:22 +0000 (17:31 -0700)]
Added the new ftp source files to the non-autoconf build files
Dan Fandrich [Wed, 12 May 2010 22:23:28 +0000 (15:23 -0700)]
Copy the license file so it's seen by the Android build system
Daniel Stenberg [Wed, 12 May 2010 22:07:37 +0000 (00:07 +0200)]
updated with symbols added in recent commits for 7.21.0
Daniel Stenberg [Wed, 12 May 2010 22:00:55 +0000 (00:00 +0200)]
changelogs: mention RTMP and the FTP wildcard support
Daniel Stenberg [Wed, 12 May 2010 21:59:11 +0000 (23:59 +0200)]
ftp wildcards: mention they're added in 7.21.0
Daniel Stenberg [Wed, 12 May 2010 21:32:42 +0000 (23:32 +0200)]
style: minor whitespace change
Daniel Stenberg [Wed, 12 May 2010 21:18:22 +0000 (23:18 +0200)]
syntax: cleanups
Pavel Raiskup [Wed, 12 May 2010 13:33:22 +0000 (15:33 +0200)]
FTP: WILDCARDMATCH/CHUNKING/FNMATCH added
Howard Chu [Wed, 12 May 2010 21:07:20 +0000 (23:07 +0200)]
RTMP: initial support added, powered by librtmp
librtmp is found at http://rtmpdump.mplayerhq.hu/
Howard Chu [Tue, 11 May 2010 20:48:38 +0000 (22:48 +0200)]
sendrecv: make them two pairs of send/recv to properly deal with FTPS
FTP(S) use two connections that can be set to different recv and
send functions independently, so by introducing recv+send pairs
in the same manner we already have sockets/connections we can
work with FTPS fine.
This commit fixes the FTPS regression introduced in change d64bd82.
Kamil Dudka [Tue, 11 May 2010 12:51:12 +0000 (14:51 +0200)]
changelog: fixed CRL support in libcurl-NSS
Kamil Dudka [Tue, 11 May 2010 12:39:08 +0000 (14:39 +0200)]
nss: make it possible to read ASCII and DER CRL
Kamil Dudka [Tue, 11 May 2010 12:10:27 +0000 (14:10 +0200)]
nss: add CRL to cache instead of read-only NSS db
Daniel Stenberg [Mon, 10 May 2010 15:25:49 +0000 (17:25 +0200)]
git: how to write a fine commit message
Daniel Stenberg [Sun, 9 May 2010 21:16:37 +0000 (23:16 +0200)]
findtool: file name as a full path requires a slash
Kalle Vahlman's patch applied a while ago broke how the findtool
function searches for tools, as it would always check if "$file"
was present first, which thus made the bad assumption that a file
in the current directory would be a match.
I noticed when it found 'libtool' in the current directory but
libtoolize is not there, which confused the script.
Hacki [Sat, 8 May 2010 03:38:42 +0000 (05:38 +0200)]
moved vars into conditional since seems that winsock implementation doesnt use them.
Daniel Stenberg [Fri, 7 May 2010 21:49:29 +0000 (23:49 +0200)]
multi interface: missed storing connection time
Dirk Manske reported a regression. When connecting with the multi
interface, there were situations where libcurl wouldn't store
connect time correctly as it used to (and is documented to) do.
Using his fine sample program we could repeat it, and I wrote up
test case 573 using that code. The problem does not easily show
itself using the local test suite though.
The fix, also as suggested by Dirk, is a bit on the ugly side as
it adds yet another call to Curl_verboseconnect() and setting the
TIMER_CONNECT time. That situation is subject for some closer
inspection in the future.
Daniel Stenberg [Fri, 7 May 2010 21:24:47 +0000 (23:24 +0200)]
verboseconnect: so the verbose checking within the function
As the function is used more than once and libcurl can be built
without it, do the conditional check within the verboseconnect()
function itself.
Daniel Stenberg [Fri, 7 May 2010 13:53:55 +0000 (15:53 +0200)]
changelogs: split the I/O handling
Howard Chu [Fri, 7 May 2010 13:05:34 +0000 (15:05 +0200)]
sendrecv: split the I/O handling into private handler
Howard Chu brought the bulk work of this patch that properly
moves out the sending and recving of data to the parts of the
code that are properly responsible for the various ways of doing
so.
Daniel Stenberg assisted with polishing a few bits and fixed some
minor flaws in the original patch.
Another upside of this patch is that we now abuse CURLcodes less
with the "magic" -1 return codes and instead use CURLE_AGAIN more
consistently.
Daniel Stenberg [Wed, 5 May 2010 20:36:15 +0000 (22:36 +0200)]
changelog: PolarSSL
Hoi-Ho Chan [Wed, 5 May 2010 20:30:46 +0000 (22:30 +0200)]
PolarSSL: initial support added
This is Hoi-Ho Chan's patch with some minor fixes by me. There
are some potential issues in this, but none worse than we can
sort out on the list and over time.
Daniel Stenberg [Thu, 29 Apr 2010 21:27:28 +0000 (23:27 +0200)]
TODO: we've done PRET already, consider HOST for the future
... and GnuTLS connects are non-blocking, TFTP is better
integrated as a "real" protocol and RTSP is supported.
Daniel Stenberg [Thu, 29 Apr 2010 21:23:42 +0000 (23:23 +0200)]
TODO: GnuTLS connects are now non-blocking
Since commit c288860 by Jerome Vouillon
Daniel Stenberg [Thu, 29 Apr 2010 17:19:08 +0000 (19:19 +0200)]
INTERNALS: tftp is decent now, ldap is not
It's not quite fair to list TFTP is a "crappy" member of the
libcurl family so I removed its mentioning.
Daniel Stenberg [Thu, 29 Apr 2010 07:40:48 +0000 (09:40 +0200)]
changelog: mention Ben Greear's telnet work
Ben Greear [Wed, 28 Apr 2010 22:49:04 +0000 (00:49 +0200)]
telnet: Allow programatic use of telnet.
The main change is to allow input from user-specified methods,
when they are specified with CURLOPT_READFUNCTION.
All calls to fflush(stdout) in telnet.c were removed, which makes
using 'curl telnet://foo.com' painful since prompts and other data
are not always returned to the user promptly. Use
'curl --no-buffer telnet://foo.com' instead. In general,
the user should have their CURLOPT_WRITEFUNCTION do a fflush
for interactive use.
Also fix assumption that reading from stdin never returns < 0.
Old code could crash in that case.
Call progress functions in telnet main loop.
Signed-off-by: Ben Greear <greearb@candelatech.com>
Daniel Stenberg [Tue, 27 Apr 2010 21:59:03 +0000 (23:59 +0200)]
test: enable valgrind for 604, seems to work
Paul Howarth [Tue, 27 Apr 2010 06:47:30 +0000 (08:47 +0200)]
add 1s post-command delay to tests 513 and 514
addressing http://curl.haxx.se/mail/lib-2009-12/0031.html
Kalle Vahlman [Thu, 10 Jan 2008 16:46:43 +0000 (18:46 +0200)]
Allow tools to be defined with full path in buildconf
This is required in Scratchbox where
LIBTOOL=/targets/links/arch_tools/bin/libtool
is set in the environment.
Daniel Stenberg [Mon, 26 Apr 2010 13:37:39 +0000 (15:37 +0200)]
progress callback: can be called more than once per sec
Daniel Stenberg [Sun, 25 Apr 2010 22:36:25 +0000 (00:36 +0200)]
SSH: init and cleanup libssh2 in global_init/cleanup
The necessary libssh2 functions require libssh2 1.2.5 or later.
Daniel Stenberg [Sun, 25 Apr 2010 21:24:05 +0000 (23:24 +0200)]
new configure option --enable-threaded-resolver
Daniel Stenberg [Sun, 25 Apr 2010 21:06:41 +0000 (23:06 +0200)]
configure: check for libssh2_init and libssh2_exit
Kamil Dudka [Sat, 24 Apr 2010 21:21:13 +0000 (23:21 +0200)]
nss: fix SSL handshake timeout underflow
Guenter Knauf [Sat, 24 Apr 2010 15:48:09 +0000 (17:48 +0200)]
encourage users to take latest lib dependencies.
Daniel Stenberg [Sat, 24 Apr 2010 10:40:00 +0000 (12:40 +0200)]
socks5: please static code analyzer
Make sure we don't call memcpy() if the argument is NULL even
though we also passed a zero length then, as the clang analyzer
whined and we want to limit warnings (even false positives) when
they're this easy to fix.
The change of (char) to (unsigned char) will fix long user names
and passwords on systems that have the char type signed by
default.
Daniel Stenberg [Sat, 24 Apr 2010 10:37:11 +0000 (12:37 +0200)]
gzip: Value stored to 'data' is never read
Daniel Stenberg [Sat, 24 Apr 2010 10:23:47 +0000 (12:23 +0200)]
RELEASE-NOTES: update top numbers
Daniel Stenberg [Sat, 24 Apr 2010 10:19:42 +0000 (12:19 +0200)]
changelog: added the --proto and -proto-redir options
Alex Bligh [Sat, 24 Apr 2010 10:16:48 +0000 (12:16 +0200)]
curl: added --proto and --proto-redir
--proto tells curl to use the listed protocols for its initial
retrieval
--proto-redir tells curl to use the listed protocols after a
redirect
Kamil Dudka [Sat, 24 Apr 2010 10:14:21 +0000 (12:14 +0200)]
test536: do not fail with threaded DNS resolver
Also tweaked comments in certain examples using curl_multi_fdset().
Daniel Stenberg [Wed, 21 Apr 2010 21:20:18 +0000 (23:20 +0200)]
curl: -O crash on windows
The -O option caused curl to crash on windows and DOS due to the
tool writing out of boundary memory.
Yang Tse [Tue, 20 Apr 2010 19:35:31 +0000 (21:35 +0200)]
hmac.c related compilation adjustment
Yang Tse [Tue, 20 Apr 2010 19:23:53 +0000 (21:23 +0200)]
hmac.c related compilation adjustment
monnerat [Tue, 20 Apr 2010 17:22:03 +0000 (19:22 +0200)]
Add compilation directives for hmac in Watcom,riscos and vc6 platform-specific makefiles.
Ruslan Gazizov [Tue, 20 Apr 2010 14:30:10 +0000 (16:30 +0200)]
replaced wsock32.lib usage with ws2_32.lib in MSVC makefiles
monnerat [Mon, 19 Apr 2010 15:37:51 +0000 (17:37 +0200)]
Merge branch 'master' of github.com:bagder/curl
monnerat [Mon, 19 Apr 2010 15:30:20 +0000 (17:30 +0200)]
Remove null-effect leftover code.
Daniel Stenberg [Mon, 19 Apr 2010 15:08:27 +0000 (17:08 +0200)]
changelog: -J/--remote-header-name strips CRLF
Daniel Stenberg [Mon, 19 Apr 2010 15:05:46 +0000 (17:05 +0200)]
parse_filename: strip trailing CRs and LFs
The feature that uses the file name given in a
Content-disposition: header didn't properly skip trailing
carriage returns and linefeed characters from the end of the file
name when it was given without quotes.
Daniel Stenberg [Mon, 19 Apr 2010 14:19:36 +0000 (16:19 +0200)]
Curl_HMAC_MD5: fix the array init to not warn with picky compilers
monnerat [Mon, 19 Apr 2010 12:09:45 +0000 (14:09 +0200)]
Fix GnuTLS compilation problem in md5.c
monnerat [Mon, 19 Apr 2010 10:44:17 +0000 (12:44 +0200)]
Fix compilation problem: declare Curl_HMAC_MD5 as extern in include file.
monnerat [Mon, 19 Apr 2010 09:17:46 +0000 (11:17 +0200)]
Merge branch 'master' of github.com:bagder/curl
monnerat [Mon, 19 Apr 2010 09:16:30 +0000 (11:16 +0200)]
Implement SMTP authentication
Daniel Stenberg [Sat, 17 Apr 2010 16:59:54 +0000 (18:59 +0200)]
parseconfig: Value stored to 'line' is never read
Make the function call with (void) as we don't care about the
return code.
Daniel Stenberg [Sat, 17 Apr 2010 16:57:39 +0000 (18:57 +0200)]
parsedate: Value stored to 'found' is never read
Daniel Stenberg [Sat, 17 Apr 2010 16:55:52 +0000 (18:55 +0200)]
check_gzip_header: Value stored to 'data' is never read
Daniel Stenberg [Fri, 16 Apr 2010 21:50:39 +0000 (23:50 +0200)]
dprintf_formatf: Value stored to 'left' is never read
Daniel Stenberg [Fri, 16 Apr 2010 21:49:03 +0000 (23:49 +0200)]
curl_version: remove superfluous assignments