profile/ivi/qtbase.git
12 years agoAlways relay configure notify events from XCB plugin.
Samuel Rødal [Fri, 26 Aug 2011 08:31:02 +0000 (10:31 +0200)]
Always relay configure notify events from XCB plugin.

QWindow no longer sets its geometry member in setGeometry(), so it needs
to happen through handleGeometryChange() from the platform plugin.

Change-Id: Ia22b788c65dba4fc4b1efed1965ccd9473f1f743
Reviewed-on: http://codereview.qt.nokia.com/3709
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agotest: removed obsolete tst_maketestselftest::tests_auto_pro
Rohan McGovern [Sun, 28 Aug 2011 23:24:37 +0000 (09:24 +1000)]
test: removed obsolete tst_maketestselftest::tests_auto_pro

This test attempted to ensure that tests/auto/auto.pro would only refer
to other .pro files, attempting to guarantee that the set of all tests
could be cleanly broken up.  The purpose of this was to enable CI
optimizations (e.g. running the autotests for different modules on
different machines in parallel).

This test is invalidated by pending commits which rearrange the
autotests, and we never made use of this property for optimization
anyway, so drop this part of the test.

Change-Id: I23e712fb8ec1dbe7ac65fe66015e1f060f3dcd41
Reviewed-on: http://codereview.qt.nokia.com/3681
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
12 years agoQWindow::mapToGlobal/mapFromGlobal and move()
Gunnar Sletta [Mon, 29 Aug 2011 06:26:37 +0000 (08:26 +0200)]
QWindow::mapToGlobal/mapFromGlobal and move()

Change-Id: If1909b9ce468a8708cb25d5a2fbe8ebd90bd958a
Reviewed-on: http://codereview.qt.nokia.com/3702
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agodirectfb: Follow coding standards, add hints of memleaks, remove vars
Holger Hans Peter Freyther [Wed, 24 Aug 2011 17:25:19 +0000 (01:25 +0800)]
directfb: Follow coding standards, add hints of memleaks, remove vars

Use m_ for all member variables, document some classes that appear
to lack proper destruction, remove unused variables from classes.

Change-Id: Icec451149fa5d562d8d5f54cbe9a1aa1518bfc48
Reviewed-on: http://codereview.qt.nokia.com/3667
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agodirectfb: Convert the directfb plugin, disable the OpenGL support
Holger Hans Peter Freyther [Wed, 24 Aug 2011 16:55:51 +0000 (00:55 +0800)]
directfb: Convert the directfb plugin, disable the OpenGL support

OpenGL was never tested and the platform integration has changed,
remove it from the build and re-enable it once one can test it.

Change-Id: I70d5b5b11de06e6e999d3aae44660f11d2dbc719
Reviewed-on: http://codereview.qt.nokia.com/3666
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoxcb: Disable GLX when xcb-xlib is not present due xlib usage
Holger Hans Peter Freyther [Wed, 24 Aug 2011 13:12:35 +0000 (21:12 +0800)]
xcb: Disable GLX when xcb-xlib is not present due xlib usage

The GLX and EGL code is using DISPLAY_FROM_XCB which requires
xlib support, disable GLX when when xlib is not present.

Change-Id: I55126e48e52390fdcfb1348a11fbf9628d32b13c
Reviewed-on: http://codereview.qt.nokia.com/3665
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoxcb: Be able to compile without xlib support
Holger Hans Peter Freyther [Wed, 24 Aug 2011 13:09:16 +0000 (21:09 +0800)]
xcb: Be able to compile without xlib support

Use XCB types for events instead of indirectly depending
on Xlib includes because of the GLX includes. Manually verified
the right values.

ButtonPressMask (1L<<2)
XCB_EVENT_MASK_BUTTON_PRESS = 4,

define ButtonReleaseMask (1L<<3)
XCB_EVENT_MASK_BUTTON_RELEASE = 8,

ButtonMotionMask (1L<<13)
XCB_EVENT_MASK_BUTTON_MOTION = 8192,

EnterWindowMask (1L<<4)
XCB_EVENT_MASK_ENTER_WINDOW = 16,

LeaveWindowMask (1L<<5)
XCB_EVENT_MASK_LEAVE_WINDOW = 32,

PointerMotionMask (1L<<6)
XCB_EVENT_MASK_POINTER_MOTION = 64,

GrabModeAsync 1
XCB_GRAB_MODE_ASYNC = 1

Change-Id: I1fade68947b1e2f39ca3514573c10fae7ee2dfb1
Reviewed-on: http://codereview.qt.nokia.com/3664
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoTemporarily disable printers on Windows, fix export.
Friedemann Kleint [Fri, 26 Aug 2011 09:46:28 +0000 (11:46 +0200)]
Temporarily disable printers on Windows, fix export.

Change-Id: I351692b53cf559cd3be64cec8907bd544ba41593
Reviewed-on: http://codereview.qt.nokia.com/3653
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oliver Wolff <oliver.wolff@nokia.com>
12 years agoIntroduce new test macro for GUI applications.
Friedemann Kleint [Thu, 25 Aug 2011 14:34:40 +0000 (16:34 +0200)]
Introduce new test macro for GUI applications.

Fixing linkage of the coreanimation examples on Windows.

Change-Id: Ic34cab329577b2ba430ca8a510b356c424d574af
Reviewed-on: http://codereview.qt.nokia.com/3605
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix some compiler warnings, shut up QIbusPlatformInputContext.
Friedemann Kleint [Fri, 26 Aug 2011 08:02:43 +0000 (10:02 +0200)]
Fix some compiler warnings, shut up QIbusPlatformInputContext.

Change-Id: Idadf40b2bbe53928d8577a099f38a2be0a2d6e16
Reviewed-on: http://codereview.qt.nokia.com/3640
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoIntroduce new platform capability ThreadedOpenGL.
Samuel Rødal [Thu, 25 Aug 2011 18:19:44 +0000 (20:19 +0200)]
Introduce new platform capability ThreadedOpenGL.

Lets the platform plugin advertise whether it's safe to use OpenGL from
a different thread. With XCB we only advertise this if we have a
reasonably new XCB libary, as older versions suffer from the
xcb_wait_for_reply() blocking bug, which cause GL rendering in a
separate to stall when using Mesa drivers.

Change-Id: I4829df7e583a1c8aed218ae13a159d21266cc594
Reviewed-on: http://codereview.qt.nokia.com/3613
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoMove XCB event reading to a separate thread.
Samuel Rødal [Thu, 25 Aug 2011 11:39:07 +0000 (13:39 +0200)]
Move XCB event reading to a separate thread.

Work-around for bug in XCB which causes a xcb_wait_for_reply to block
if xcb_poll_for_events() is called simultaneously from a different
thread. If the XCB version is too old this work-around causes even
more problems, so we kill two birds with one stone by only using the
work-around if the XCB version has the recent
xcb_poll_for_queue_event() function, which we also need to read
events from a separate thread with reasonable efficiency.

Change-Id: I8a899dad6ded381ce42cba0112e77da3c8aa6887
Reviewed-on: http://codereview.qt.nokia.com/3612
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoMoving relevant tests to corelib/codecs
Holger Ihrig [Wed, 24 Aug 2011 08:30:49 +0000 (10:30 +0200)]
Moving relevant tests to corelib/codecs

Task-number: QTBUG-21066

Change-Id: If33bda9622bbfdac2b72ec2bf8489b0f62bae6e2
Reviewed-on: http://codereview.qt.nokia.com/3469
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoFix building of examples.
Friedemann Kleint [Thu, 25 Aug 2011 13:53:04 +0000 (15:53 +0200)]
Fix building of examples.

Change-Id: Iebb56c81fd13deaa82d8883e3f1529f1a78ebea8
Reviewed-on: http://codereview.qt.nokia.com/3603
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix exports for widgets.
Friedemann Kleint [Thu, 25 Aug 2011 12:36:14 +0000 (14:36 +0200)]
Fix exports for widgets.

Change-Id: Id505aa13dfd3b34659961e44473abae99d18ee4c
Reviewed-on: http://codereview.qt.nokia.com/3597
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoFix compilation/use correct data type for qt_lastx,y.
Friedemann Kleint [Thu, 25 Aug 2011 12:19:58 +0000 (14:19 +0200)]
Fix compilation/use correct data type for qt_lastx,y.

Change-Id: I6fdc8dcfb19d7498a1eb8013f75113537ce7a213
Reviewed-on: http://codereview.qt.nokia.com/3594
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoMerge "Merge branch 'master' into refactor" into refactor
Gunnar Sletta [Thu, 25 Aug 2011 10:50:29 +0000 (12:50 +0200)]
Merge "Merge branch 'master' into refactor" into refactor

12 years agoMerge branch 'master' into refactor
Gunnar Sletta [Thu, 25 Aug 2011 08:11:49 +0000 (10:11 +0200)]
Merge branch 'master' into refactor

Conflicts:
src/gui/kernel/qapplication_qpa.cpp
src/gui/kernel/qcursor_qpa.cpp
src/gui/kernel/qwindowsysteminterface_qpa.cpp
src/gui/kernel/qwindowsysteminterface_qpa.h
src/gui/kernel/qwindowsysteminterface_qpa_p.h
src/gui/text/qtextcontrol.cpp
src/plugins/platforms/wayland/wayland.pro
src/widgets/accessible/qaccessible2.h
src/widgets/widgets/qwidgetlinecontrol_p.h

Change-Id: I5e6f4eb184159dccc67e8f13673edb884d179c74

12 years agoRemove debug output
Lars Knoll [Thu, 25 Aug 2011 07:28:01 +0000 (09:28 +0200)]
Remove debug output

Change-Id: I06ca78a2b4e9baf0088465890d404a477cfd4203
Reviewed-on: http://codereview.qt.nokia.com/3572
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoFix multithreaded GL rendering
Lars Knoll [Thu, 25 Aug 2011 07:27:13 +0000 (09:27 +0200)]
Fix multithreaded GL rendering

Call XInitThread() before any other call to Xlib.

Change-Id: I88d3a87bf31dab06b0a4c6a4cd1d32979cd70d4a
Reviewed-on: http://codereview.qt.nokia.com/3571
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoFix threaded rendering
Lars Knoll [Thu, 25 Aug 2011 07:28:19 +0000 (09:28 +0200)]
Fix threaded rendering

Call XInitThreads() before any other xlib call.

Change-Id: Ifa2cd4c3574ff024e733fbf51064699b2de0f8e6
Reviewed-on: http://codereview.qt.nokia.com/3573
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoFix the xlib backend for lighthouse
Lars Knoll [Wed, 24 Aug 2011 12:46:24 +0000 (14:46 +0200)]
Fix the xlib backend for lighthouse

Adapt the backend to the changes in lighthouse.

Change-Id: If2d795c901143a80eed4f23d14add6ab9f42750b
Reviewed-on: http://codereview.qt.nokia.com/3568
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
12 years agoSupport QRawFont from raw data with basic unix font db
Eskil Abrahamsen Blomfeldt [Wed, 24 Aug 2011 13:51:07 +0000 (15:51 +0200)]
Support QRawFont from raw data with basic unix font db

Add support for making a QFontEngine in QPA with the basic
unix font database. The code is copy-pasted from qrawfont_ft.cpp.

Task-number: QTBUG-20780

Change-Id: Id5492efe634fe90805fbca43356ec428d4d73117
Reviewed-on: http://codereview.qt.nokia.com/3511
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
12 years agotests: Remove `qtessellator' autotests
Sergio Ahumada [Wed, 24 Aug 2011 12:05:23 +0000 (14:05 +0200)]
tests: Remove `qtessellator' autotests

This autotest is not needed anymore since qtessellator was
removed by 78169e6b06db136037b70c99ca46b82d4c311c3e

Change-Id: I438e5bf2fd44da73461bb6fc311a6dce5573e467
Reviewed-on: http://codereview.qt.nokia.com/3496
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agotest: fix `tst_qpainter' compilation
Sergio Ahumada [Wed, 24 Aug 2011 12:55:55 +0000 (14:55 +0200)]
test: fix `tst_qpainter' compilation

Change-Id: Iea6fa5e1592e6227e10ea3768fe99aa14704dc48
Reviewed-on: http://codereview.qt.nokia.com/3505
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Holger Ihrig <holger.ihrig@nokia.com>
12 years agotest: fix tst_qabstractprintdialog compilation
Sergio Ahumada [Wed, 24 Aug 2011 09:30:24 +0000 (11:30 +0200)]
test: fix tst_qabstractprintdialog compilation

Change-Id: I0068ea79bbfd56fdd67e7841d6fcf873ec3ed28a
Reviewed-on: http://codereview.qt.nokia.com/3475
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoresize convenince function
Gunnar Sletta [Wed, 24 Aug 2011 07:05:05 +0000 (09:05 +0200)]
resize convenince function

Change-Id: I81b39912fbc76bb8532ff1d80ff25bce5e84f727
Reviewed-on: http://codereview.qt.nokia.com/3452
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoPreliminary change to get resizeEvents for QWindow::resize() calls
Gunnar Sletta [Wed, 24 Aug 2011 07:05:27 +0000 (09:05 +0200)]
Preliminary change to get resizeEvents for QWindow::resize() calls

Change-Id: I43e1d7fb98f1b20939dba8cdccffa4dcb99a7369
Reviewed-on: http://codereview.qt.nokia.com/3453
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoAdd Input context for Windows.
Friedemann Kleint [Wed, 24 Aug 2011 07:30:29 +0000 (09:30 +0200)]
Add Input context for Windows.

Change-Id: I20b97e863bf1198b9ad810bb5a25652327f626c9
Reviewed-on: http://codereview.qt.nokia.com/3463
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oliver Wolff <oliver.wolff@nokia.com>
12 years agoIf the EGL_PLATFORM is not set, then set it
Jørgen Lind [Wed, 24 Aug 2011 08:38:31 +0000 (10:38 +0200)]
If the EGL_PLATFORM is not set, then set it

Change-Id: I6c1b0ba757c64fc42faacd69d4e5d1df28faf7d1
Reviewed-on: http://codereview.qt.nokia.com/3472
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
12 years agoJust change includes to be have <> brackets instead of ""
Jørgen Lind [Fri, 12 Aug 2011 08:36:59 +0000 (10:36 +0200)]
Just change includes to be have <> brackets instead of ""

for QGenericFontDatabase

Change-Id: Iac61522194ab7aa3ea7359e51cc84952db8b90ae
Reviewed-on: http://codereview.qt.nokia.com/3471
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
12 years agoMoving Tests to new Autotest Structure
Holger Ihrig [Tue, 23 Aug 2011 10:48:34 +0000 (12:48 +0200)]
Moving Tests to new Autotest Structure

Bring new Structure for Autotests Corelib into place

Moving Corelib/Animation Tests

Added new Autotests to corelib/animation

Task-number: QTBUG-21066
Change-Id: I754bbcc2b0a512e6df4c0d768ae6ff9c261ff210
Reviewed-on: http://codereview.qt.nokia.com/3404
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
12 years agoFix fallbacksForFamily in QBasicUnixFontDatabase
Jiang Jiang [Fri, 5 Aug 2011 13:49:21 +0000 (15:49 +0200)]
Fix fallbacksForFamily in QBasicUnixFontDatabase

So that this function instead of the one in QPlatformFontDatabase
will be called.

Change-Id: Ifdb75ada27723c688e42067c7633b08391d66467
Reviewed-on: http://codereview.qt.nokia.com/2696
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/3461
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
12 years agoFix weight parsing in QBasicUnixFontDatabase
Jiang Jiang [Fri, 5 Aug 2011 08:59:34 +0000 (10:59 +0200)]
Fix weight parsing in QBasicUnixFontDatabase

First check the usWeightClass in OS/2 font table, then check
the weight byte in panose structure because Nokia Pure Text
fonts only have that set correctly.

Change-Id: Idce2626c8df17ce74ba78b317846cb42c3f1fe84
Reviewed-by: Jørgen Lind
Reviewed-on: http://codereview.qt.nokia.com/2682
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
Reviewed-on: http://codereview.qt.nokia.com/3460

12 years agoupdate .gitignore
Charles Yin [Tue, 23 Aug 2011 01:36:24 +0000 (11:36 +1000)]
update .gitignore

1. generated module def files
2. generated version headers
3. unit test executables

Change-Id: Ibce72e89882e646ff0a450d68031e8e3a5cea085
Reviewed-on: http://codereview.qt.nokia.com/3346
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Ling Hu <ling.hu@nokia.com>
12 years agoAdd operator== and operator!= to qsqlerror class
Antonis Tsiapaliokas [Mon, 15 Aug 2011 22:26:21 +0000 (01:26 +0300)]
Add operator== and operator!= to qsqlerror class

Merge-request: 44
Task-number: QTBUG-20543

Change-Id: I7b88985fe095ffd2e48ac05c82dc3f3a92dbb091
Reviewed-on: http://codereview.qt.nokia.com/3425
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoDo not expose text when echo mode is not Normal.
José Millán Soto [Sat, 4 Jun 2011 16:06:47 +0000 (18:06 +0200)]
Do not expose text when echo mode is not Normal.

Reviewed-by: Frederik Gladhorn
(cherry picked from commit 636b7088eb3740800f54a7c1634d3e041e688270)

Change-Id: I82b2e02af74dc43268d2b6613fe31e2875fd132f
Reviewed-on: http://codereview.qt.nokia.com/3038
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoCheck validator when changing text using accessibility functions.
José Millán Soto [Fri, 3 Jun 2011 18:44:37 +0000 (20:44 +0200)]
Check validator when changing text using accessibility functions.

Reviewed-by: Frederik Gladhorn
(cherry picked from commit 731d843b52b0a0bc387c50c2af37a71f87804f4d)

Change-Id: Ieef71cea5b44f288f2f95a0765ec0b3f6d47c042
Reviewed-on: http://codereview.qt.nokia.com/3037
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoImplemented QAccessibleTextEdit::attributes()
Frederik Gladhorn [Tue, 16 Aug 2011 13:19:09 +0000 (15:19 +0200)]
Implemented QAccessibleTextEdit::attributes()

Handling font properties and colors
Created test: tst_QAccessibility::textAttributes

Merge-request: 2626
Reviewed-by: Harald Fernengel <harald.fernengel@nokia.com>
(cherry picked from commit f1a6766432f66220275aa7902e4c2414a3069cd1)

Change-Id: I388bc660af20149934110d7894840eccecf81f2a
Reviewed-on: http://codereview.qt.nokia.com/3036
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoQFontEngine: Avoid nesting multi-fontengines.
Friedemann Kleint [Mon, 22 Aug 2011 12:53:59 +0000 (14:53 +0200)]
QFontEngine: Avoid nesting multi-fontengines.

In case the platform plugin returns an instance of QFontEngineMulti
(which happens on Windows).

Change-Id: I87470e47cfe113557313b7f6b3b09d1455af1c17
Reviewed-on: http://codereview.qt.nokia.com/3319
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agomake 'make install' install
Paul Olav Tvete [Fri, 19 Aug 2011 10:50:18 +0000 (12:50 +0200)]
make 'make install' install

Change-Id: I766e7917f6362b1f9cc26d18381e8d76eaf6ff83
Reviewed-on: http://codereview.qt.nokia.com/3261
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix input context header.
Friedemann Kleint [Tue, 23 Aug 2011 10:45:51 +0000 (12:45 +0200)]
Fix input context header.

Rubber-stamped-by: Lars Knoll <lars.knoll@nokia.com>
Change-Id: Ia5dfccfa53fea68889c312a645597aaf40ddc079
Reviewed-on: http://codereview.qt.nokia.com/3397
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoMac: Fix link error in printdialog.
Morten Sorvig [Fri, 19 Aug 2011 12:27:58 +0000 (14:27 +0200)]
Mac: Fix link error in printdialog.

Recompiling QtWidgets on Mac fails with:
"ld: duplicate symbol qInitResources_qprintdialog() in
.obj/debug-shared/qrc_qprintdialog.o and
.obj/debug-shared/qprintdialog_unix.o "

Ifdef out the include from qprintdialog_unix,
leaving us with one instance of the synbol.

Change-Id: I7e1f45de65020253e0cad4155fca94944e66c177
Reviewed-on: http://codereview.qt.nokia.com/3270
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
12 years agotest: really marked tst_qtcpsocket autotest as unstable
Rohan McGovern [Mon, 22 Aug 2011 23:18:12 +0000 (09:18 +1000)]
test: really marked tst_qtcpsocket autotest as unstable

15575fb280e1489157d0be44d00ab57aecc19320 edited the wrong .pro file :(

Task-number: QTBUG-21043
Change-Id: I7b52fb7ea8669856b359523b278142c763bfb978
Reviewed-on: http://codereview.qt.nokia.com/3341
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Keith Isdale <keith.isdale@nokia.com>
12 years agoAdd IAccessible2 table2 implementation.
Frederik Gladhorn [Mon, 27 Jun 2011 14:28:50 +0000 (16:28 +0200)]
Add IAccessible2 table2 implementation.

Implement the IAccessible table2 interface for itemviews.
This is simpler than what we have in complexwidgets.
For now it is only used on Linux.

The new table2 interface is ifdef'ed to only be used on X11.
Improve handling of accessible events and clean up.

There are two xfails for the Table and Tree where sibling
navigation is not implemented yet.

Reviewed-by: Gabi
(cherry picked from commit e797ba558dddd45522b5a317316e497e9efc44a8)
(cherry picked from commit eff5ecc5d8f65fa25d6cfd6ed96a9d2a00d0c663)
(cherry picked from commit d29876008fad400bca8d6b37e5d5f61dd1bcb39d)
(cherry picked from commit 2a326fdc8f8bf2bd2c5764394616100906d9db2d)
(cherry picked from commit 9b72e79e20d0d3560e0b064b8b0d75e35feb720e)
(cherry picked from commit 075b0f744363842ed4179c644d933d461389544f)

Change-Id: I654f74991830ae1fc7df7cc91d930390fb88b2a4
Reviewed-on: http://codereview.qt.nokia.com/3274
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoFixed empty if statement in QWindow.cpp
Olli Werwolff [Mon, 22 Aug 2011 06:18:22 +0000 (08:18 +0200)]
Fixed empty if statement in QWindow.cpp

Change-Id: Ib324eb30da1e16f01b9655ed293244fb50b621b8
Reviewed-on: http://codereview.qt.nokia.com/3289
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agotest: marked tst_qtcpsocket autotest as unstable
Rohan McGovern [Mon, 22 Aug 2011 01:44:47 +0000 (11:44 +1000)]
test: marked tst_qtcpsocket autotest as unstable

Task-number: QTBUG-21043
Change-Id: Idefb79bf64eb746e82ebf2980c628f2e37dcf6c3
Reviewed-on: http://codereview.qt.nokia.com/3279
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Keith Isdale <keith.isdale@nokia.com>
12 years agotest: Fix `tst_qfiledialog' in a namespaced build
Sergio Ahumada [Fri, 12 Aug 2011 22:18:18 +0000 (00:18 +0200)]
test: Fix `tst_qfiledialog' in a namespaced build

Reviewed-by: Pierre Rossi
(cherry picked from commit 3be7f871f07041477b5bca0182623b36afd2b3e6)

Change-Id: Ib24d837ef8f47435cc0a505233e77f1104537cae
Reviewed-on: http://codereview.qt.nokia.com/3263
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoMake the hellowindow example multi-threaded to stress the GL backend.
Samuel Rødal [Thu, 18 Aug 2011 08:50:18 +0000 (10:50 +0200)]
Make the hellowindow example multi-threaded to stress the GL backend.

Change-Id: I9e158c0889b050f9ed76ea21176102fc792eef83
Reviewed-on: http://codereview.qt.nokia.com/3150
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
12 years agoPrevent X errors being generated when setting 0 as width or height.
Samuel Rødal [Wed, 10 Aug 2011 08:02:22 +0000 (10:02 +0200)]
Prevent X errors being generated when setting 0 as width or height.

Change-Id: I38b12471f2c327952c4b5f6acb01c1f1ef53da28
Reviewed-on: http://codereview.qt.nokia.com/2823
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
12 years agoFix colormap exports/warning in qapplication_p.h
Friedemann Kleint [Fri, 19 Aug 2011 09:22:17 +0000 (11:22 +0200)]
Fix colormap exports/warning in qapplication_p.h

Change-Id: I294e19e7fdf6ab65b5f8ba09d14263487c85b866
Reviewed-on: http://codereview.qt.nokia.com/3256
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix comparison.
Friedemann Kleint [Fri, 19 Aug 2011 09:07:36 +0000 (11:07 +0200)]
Fix comparison.

Change-Id: Id90a49e57d25d12936678fecfa9c4e0c6dbe676b
Reviewed-on: http://codereview.qt.nokia.com/3255
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoQSurfaceFormat: Add missing 'profile' accessors, fix detaching.
Friedemann Kleint [Fri, 19 Aug 2011 08:04:51 +0000 (10:04 +0200)]
QSurfaceFormat: Add missing 'profile' accessors, fix detaching.

No longer initialize FormatOptions to SwapBehaviour::DoubleBuffer
in the constructor as it is a different enumeration.

Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Change-Id: Id69e0345d4395ee88532ac3ee0e89c35e6c5b083
Reviewed-on: http://codereview.qt.nokia.com/3254
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove qtessellator.* from QtGui
Lars Knoll [Fri, 19 Aug 2011 07:27:51 +0000 (09:27 +0200)]
Remove qtessellator.* from QtGui

It's now unused since the GL1 paintengine is gone.

Change-Id: I1415b725dc05aab920670976a8eb8c3145464297
Reviewed-on: http://codereview.qt.nokia.com/3246
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix build.
Friedemann Kleint [Fri, 19 Aug 2011 08:39:45 +0000 (10:39 +0200)]
Fix build.

- Introduced EXPORT definition for new QPrintSupport library.
- Fixed dependencies in src.pro
- Fixed some includes.

Change-Id: I9863233ca2767928b37cf3fd1fdec31351b5da6b
Reviewed-on: http://codereview.qt.nokia.com/3253
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoEnablers for using QGlyphRun in SceneGraph
Eskil Abrahamsen Blomfeldt [Wed, 1 Jun 2011 13:33:38 +0000 (15:33 +0200)]
Enablers for using QGlyphRun in SceneGraph

Several required fixes and changes to fix problems that arose
when porting SceneGraph's QSGTextInput and QSGTextEdit to
use QSGTextNode, especially related to having selections
on the text.

Also fixes crashes with the threaded renderer on Mac OS X
when using the TextEdit or TextInput elements.

Task-number: QTBUG-18019, QTBUG-20017
Change-Id: I67f24465352daa1d2cb12b6d2f378feb676c9804
Reviewed-on: http://codereview.qt.nokia.com/2864
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
12 years agoQColormap is gone from QtGui
Lars Knoll [Fri, 19 Aug 2011 07:25:54 +0000 (09:25 +0200)]
QColormap is gone from QtGui

Fixes compilion of Gui

Change-Id: I5b66b3d3817d8e54c990d761bb8e8b591fa0da63
Reviewed-on: http://codereview.qt.nokia.com/3245
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Type1 support
Lars Knoll [Tue, 16 Aug 2011 12:39:54 +0000 (14:39 +0200)]
Remove Type1 support

Type1 support was only required for postscript
generation. As we don't support this anymore, get
rid of this code.

Change-Id: Ifdc27ec563b5da8d94554f8b078bcd3ac079d201
Reviewed-on: http://codereview.qt.nokia.com/3214
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoRestore feature compatibility with QPrinter in QTextDocument::print
Lars Knoll [Thu, 18 Aug 2011 09:04:06 +0000 (11:04 +0200)]
Restore feature compatibility with QPrinter in QTextDocument::print

Add a margin method to QPagedPaintDevice. The other variables
required are stored in QPagedPaintDevicePrivate without a
public API for now. This needs cleaning up once we have a new
printing system.

Change-Id: Id3f2d7ac7f3cbce8619072a897d91f3a588add64
Reviewed-on: http://codereview.qt.nokia.com/3211
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoMove the printer support backend into it's own plugin
Lars Knoll [Wed, 17 Aug 2011 12:20:53 +0000 (14:20 +0200)]
Move the printer support backend into it's own plugin

QPlatformIntegration can't have a dependency onto printing
anymore now that printing lives in it's own library. Move
it into a plugin of it's own.

Change-Id: I3ec4b38f4336eb96d92ea799544d17af359c83e1
Reviewed-on: http://codereview.qt.nokia.com/3210
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoMove printing into it's own library
Lars Knoll [Tue, 16 Aug 2011 14:38:56 +0000 (16:38 +0200)]
Move printing into it's own library

Create a libQtPrintSupport library that contains our current
printing infrastructure. Long term this will get replaced
with a libQtPrint, as the current architecture is not
really maintainable.

Change-Id: I7362fff6786b58c5b4e9213c23eda36d15048aa2
Reviewed-on: http://codereview.qt.nokia.com/3209
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoDon't rely on QPrinter in widgets
Lars Knoll [Wed, 17 Aug 2011 13:44:59 +0000 (15:44 +0200)]
Don't rely on QPrinter in widgets

Use the QPagedPaintDevice instead for the current
print() methods. Like this we can move the whole
printing system into it's own library.

Change-Id: I5e23fb3a9304eb3d12aa54959893601566249e23
Reviewed-on: http://codereview.qt.nokia.com/3208
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoUse the paged paintdevice in the print() method of QTextDocument.
Lars Knoll [Tue, 16 Aug 2011 12:04:48 +0000 (14:04 +0200)]
Use the paged paintdevice in the print() method of QTextDocument.

This is required to be able to move the printing system into
it's own library.

Change-Id: If70a55be4c4413f9cd917a30d1b368f32c1145e4
Reviewed-on: http://codereview.qt.nokia.com/3207
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoIntroduce a paged paintdevice and use it
Lars Knoll [Wed, 17 Aug 2011 09:26:51 +0000 (11:26 +0200)]
Introduce a paged paintdevice and use it

Introduce a QPagedPaintDevice class that has a
newPage() method and page dimensions. QPdfWriter
and QPrinter inherit from it.
Add a bit of API to QPdfWriter.

Change-Id: Ibf23e7fe741f3a5ed854faf5d249a272acc75f35
Reviewed-on: http://codereview.qt.nokia.com/3206
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agomove printing related files into their own directory
Lars Knoll [Tue, 16 Aug 2011 11:53:57 +0000 (13:53 +0200)]
move printing related files into their own directory

This is done to prepare the next step where we move
printing into it's own module.

Change-Id: I95919c28079983e7c5e4ff23d223f8c062b8ac8c
Reviewed-on: http://codereview.qt.nokia.com/3205
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoPDF doesn't require the alpha paintengine
Lars Knoll [Tue, 16 Aug 2011 09:43:58 +0000 (11:43 +0200)]
PDF doesn't require the alpha paintengine

Remove the inheritance from the alpha paint engine
for the PDF generator. The alpha engine was only
required to support transparency on Postscript.

Change-Id: If09a00a3123f73e4c36f708651a3abae014187a3
Reviewed-on: http://codereview.qt.nokia.com/3204
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoMove the remaining QPrinter dependencies out of qpf.*
Lars Knoll [Tue, 16 Aug 2011 09:34:01 +0000 (11:34 +0200)]
Move the remaining QPrinter dependencies out of qpf.*

Change-Id: I4fd0158d65afad1bc67c52eff17ce2e12ff60641
Reviewed-on: http://codereview.qt.nokia.com/3203
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoRename QPdf(Base)Engine
Lars Knoll [Mon, 15 Aug 2011 11:44:46 +0000 (13:44 +0200)]
Rename QPdf(Base)Engine

Rename QPdfBaseEngine to QPdfEngine and QPdfEngine
to QPdfPrintEngine. This fit's better with the use cases.

Change-Id: Ic208b079581768a957f9fdcc333f0bf87f619d46
Reviewed-on: http://codereview.qt.nokia.com/3202
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoMove the PDF related functionality into QPdf
Lars Knoll [Fri, 12 Aug 2011 12:20:08 +0000 (14:20 +0200)]
Move the PDF related functionality into QPdf

Goal is to have all functionality related to PDF generation
in QPdf, and then separate out the parts related to
interfacing with the printing system into the pdf printengine.

Change-Id: I8c30cb65365c503945fc270fad5cbcaabe59495d
Reviewed-on: http://codereview.qt.nokia.com/3201
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agofirst version of a public API to generate PDFs
Lars Knoll [Fri, 12 Aug 2011 12:19:23 +0000 (14:19 +0200)]
first version of a public API to generate PDFs

The class is required to be able to move the printing
subsystem out into a module of it's own.

Change-Id: I80703b8a8725504c7e6884a34f76e0735efcf95a
Reviewed-on: http://codereview.qt.nokia.com/3200
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoMove QColorMap into QtWidgets
Lars Knoll [Tue, 16 Aug 2011 12:47:43 +0000 (14:47 +0200)]
Move QColorMap into QtWidgets

Remove the remaining dependency in qnativeimage
and move the whole class into QtGui for compatibility.

The class is not needed anymore since we're not going
to support 8bit/indexed displays going forward.

Change-Id: I7b5f1b2a5661db4ed77bb3801039114c7518512d
Reviewed-on: http://codereview.qt.nokia.com/3199
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoFixed broken lookup of fallback fonts on qpa
Rohan McGovern [Wed, 17 Aug 2011 04:47:42 +0000 (14:47 +1000)]
Fixed broken lookup of fallback fonts on qpa

Loading of fallback fonts from the font cache was broken.
While iterating through fallback fonts, we would incorrectly skip any
fonts which were already in the cache.  This would cause unstable lookup
results for some fonts, depending on the order in which fonts were
loaded during the current process.

Change-Id: I56a6a07e93196ed14f33f4cc181e41c5b8f19498
Reviewed-on: http://codereview.qt.nokia.com/3059
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoUse name for combobox on Unix.
Frederik Gladhorn [Thu, 30 Jun 2011 15:31:36 +0000 (17:31 +0200)]
Use name for combobox on Unix.

This is more conforming to the AT-SPI specs.
Also we have working relations for the label when a buddy is set.

Reviewed-by: Gabi
(cherry picked from commit 8be3168aa2f300f9a93a53b417704f3f10b1dc8b)

Change-Id: I1831d5063b003df2d209aba99d54558b6493a3e9
Reviewed-on: http://codereview.qt.nokia.com/3027
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoRename textBeforeOffsetFromString to start with q.
Frederik Gladhorn [Fri, 8 Jul 2011 08:22:39 +0000 (01:22 -0700)]
Rename textBeforeOffsetFromString to start with q.

Exported functions should start with q.

Reviewed-by: TrustMe
(cherry picked from commit 4fcb7c233c3c8d748d66bf698df059ad7546ae88)

Change-Id: Idc53d3ec49f73227a9fd12b6b88aade35c7cdf25
Reviewed-on: http://codereview.qt.nokia.com/3026
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoImplement text interface for QLineEdit.
Frederik Gladhorn [Tue, 5 Jul 2011 15:05:11 +0000 (17:05 +0200)]
Implement text interface for QLineEdit.

Add boundary helper functions to the QAccessibleTextInterface.
Move LineEdit over to use QTextBoundaryFinder.

Reviewed-by: Jan-Arve
(cherry picked from commit c1ec1a95806cda54d5b4e9f8ed159a611bd75964)

Change-Id: Ib93599c49110aab50debe1e3fb0073dd34071c87
Reviewed-on: http://codereview.qt.nokia.com/3025
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoFix compilation with thumb2.
Eike Ziller [Wed, 10 Aug 2011 07:38:37 +0000 (09:38 +0200)]
Fix compilation with thumb2.

Task-number: QTBUG-16402
Rubber-stamped-by: Thiago Macieira
(cherry picked from commit 6be1b235f7db38146f7080a4bfcfe3051ae54699)

Change-Id: I6f60f1d3079395e765a183961db5c8543cf58cdc
Reviewed-on: http://codereview.qt.nokia.com/3078
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eckhart Koppen <eckhart.koppen@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoFix bidi reordering of RTL text with embedded images
Eskil Abrahamsen Blomfeldt [Tue, 16 Aug 2011 08:52:29 +0000 (10:52 +0200)]
Fix bidi reordering of RTL text with embedded images

According to the UBA, the object replacement character should be
considered ON. There's no reason to special case its directionality, as
the bidi algorithm will already have given it an implicit
directionality.

Task-number: QTBUG-20910
Reviewed-by: Lars
(cherry picked from commit 2657bfa7c4de9f114331d1714a306b3999ae30d8)

Change-Id: I1c8e45d67ef44b1b6f96edb2f5074331b5422eb7
Reviewed-on: http://codereview.qt.nokia.com/2999
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
12 years agoMinor optimizations for QTextEngine
Ritt Konstantin [Wed, 13 Jul 2011 00:41:45 +0000 (04:41 +0400)]
Minor optimizations for QTextEngine

Optimize script assignment, skip calls to QUnicodeTables::script() for
the codepoints handled explicitly.
Make the helper functions of QTextEngine::elidedText() inlined

Merge-request: 1298
Reviewed-by: yoann
(cherry picked from commit 857202824e7d6083eeb87fc52d3770f8fd82b559)

Change-Id: I1afc6405a800dbc2b5f63a2f98c63e607e3ee255
Reviewed-on: http://codereview.qt.nokia.com/2998
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
12 years agoAdd DBus VirtualObject to handle multiple paths.
Frederik Gladhorn [Sun, 22 May 2011 19:36:10 +0000 (21:36 +0200)]
Add DBus VirtualObject to handle multiple paths.

When a virtual object is registered with the SubPath option
it will handle all dbus calls to itself and all child paths.
It needs to reimplement handleMessage for that purpose.

Introspection needs to be implemented manually in the introspect function.

Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
(cherry picked from commit b07919b3de8cff3e44b7271062372b14bcda5b83)
(cherry picked from commit 997c2dfed7a04da2fac577f1c29b89bda4939e2d)
(cherry picked from commit c676b7095d826dc2d006f52a4b234546af5e2137)

Change-Id: I003007604b286af8000959756ce9d25c17306f5b
Reviewed-on: http://codereview.qt.nokia.com/3051
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoUpdate changelog with Accessibility fixes.
Frederik Gladhorn [Tue, 16 Aug 2011 12:53:33 +0000 (14:53 +0200)]
Update changelog with Accessibility fixes.

(cherry picked from commit b955efd392d2c1ec82a043df7b364af71e464078)

Change-Id: I4a2c4f0abf5c9bef10fe0ce0f071473d9b3a3397
Reviewed-on: http://codereview.qt.nokia.com/3024
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoFix a11y crash: dock doesn't always have a widget.
Frederik Gladhorn [Tue, 28 Jun 2011 12:37:10 +0000 (14:37 +0200)]
Fix a11y crash: dock doesn't always have a widget.

Also return dock widget title.

Reviewed-by: Gabriel de Dietrich <gabriel.dietrich-de@nokia.com>
(cherry picked from commit 276d16583b80da2838f9af47e15fe3a83cdb0485)

Change-Id: I8d66bec4212cc2b1df8c9b041375d7455c6a76a3
Reviewed-on: http://codereview.qt.nokia.com/3023
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoFix typo in comment.
Frederik Gladhorn [Mon, 20 Jun 2011 12:29:16 +0000 (14:29 +0200)]
Fix typo in comment.

(cherry picked from commit f067c2b3016182862e82805b13c7944ebe8671a9)
Change-Id: Iac3673db666e53f5e1a20f95a59df15a6ad9c137
Reviewed-on: http://codereview.qt.nokia.com/3022
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoAvoid bogus accessibility focus events from menus.
Frederik Gladhorn [Sun, 5 Jun 2011 11:16:13 +0000 (04:16 -0700)]
Avoid bogus accessibility focus events from menus.

Do not send accessibility focus events when menus are involved.
There are focus events to preserve the old focus when showing a new popup window.

Reviewed-by: Jan-Arve
(cherry picked from commit 32079bb0b348ef5f7126e69be9bcfb249c1a6412)

Change-Id: Id4838a3aede1d60a1850385e97660d085f055d64
Reviewed-on: http://codereview.qt.nokia.com/3021
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoAdd Windows to the Lighthouse.
Friedemann Kleint [Wed, 17 Aug 2011 13:58:39 +0000 (15:58 +0200)]
Add Windows to the Lighthouse.

Add an initial Lighthouse plugin for the Windows operating system.

Change-Id: I6934562266e1aa0ac270bf6107df05a9e56ef82c
Reviewed-on: http://codereview.qt.nokia.com/3107
Reviewed-by: Oliver Wolff <oliver.wolff@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoEnable multisampling and swap interval by default on cocoa
Gunnar Sletta [Thu, 18 Aug 2011 06:23:15 +0000 (08:23 +0200)]
Enable multisampling and swap interval by default on cocoa

Change-Id: If3d1939e6196f5aa6654645d20dab7ad251046fa
Reviewed-on: http://codereview.qt.nokia.com/3138
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoSet the style mask manually.
Morten Sorvig [Mon, 15 Aug 2011 11:11:50 +0000 (13:11 +0200)]
Set the style mask manually.

Looks like the window flags conversion code from
Qt 4 is not working, set a style mask suitable
for qmlscene for now.

Change-Id: I5e672f586045a0f0403f6b75252f0029c8d8a205
Reviewed-on: http://codereview.qt.nokia.com/2956
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
12 years agoFix crash-on-exit in qmlscene.
Morten Sorvig [Mon, 15 Aug 2011 11:50:22 +0000 (13:50 +0200)]
Fix crash-on-exit in qmlscene.

Take control over NSWindow deletion to make sure
it's lifetime matches that of the QCocoaWindow.

Change-Id: Ia10006d814345356e6aebe7fa1f9a0e012535786
Reviewed-on: http://codereview.qt.nokia.com/2960
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
12 years agoCreate NSWindow subclass.
Morten Sorvig [Mon, 15 Aug 2011 11:09:18 +0000 (13:09 +0200)]
Create NSWindow subclass.

Allows us to override canBecomeKeyWindow etc.

Change-Id: Ia74006ac85acb98e8a0fe0a8cdc8e5e0b9aee5c4
Reviewed-on: http://codereview.qt.nokia.com/2955
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
12 years agoCocoa: Remove autorelease warnings from qmlscene.
Morten Sorvig [Fri, 12 Aug 2011 11:39:23 +0000 (13:39 +0200)]
Cocoa: Remove autorelease warnings from qmlscene.

The SG Canvas render thread was creating a
QCocoaGLContext without an autorelease pool in
place.

Change-Id: I08882f42efdf905107497e8be21f2a2d20c3c4cf
Reviewed-on: http://codereview.qt.nokia.com/2911
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
12 years agotest: marked tst_qfocusevent as insignificant on all platforms
Rohan McGovern [Thu, 18 Aug 2011 04:21:32 +0000 (14:21 +1000)]
test: marked tst_qfocusevent as insignificant on all platforms

This was known to be unstable on mac, but appears to be unstable on
Linux also.

Task-number: QTBUG-20987
Change-Id: I760533c32cf13d24f8428f120813eb590b202182
Reviewed-on: http://codereview.qt.nokia.com/3131
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed failure of tst_qstylesheetstyle on qpa
Rohan McGovern [Thu, 18 Aug 2011 00:33:57 +0000 (10:33 +1000)]
test: fixed failure of tst_qstylesheetstyle on qpa

Wait for window shown on _all_ platforms, not just X11.

QEXPECT_FAIL a test which relies on QCursor::setPos, which is currently
unimplemented for qpa (QTBUG-20753).

Change-Id: I72412476afc7e52ccb6cab4306ff791b7e7d8d93
Reviewed-on: http://codereview.qt.nokia.com/3118
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed tst_qeventloop and removed CONFIG+=insignificant_test
Rohan McGovern [Tue, 2 Aug 2011 02:05:21 +0000 (12:05 +1000)]
test: fixed tst_qeventloop and removed CONFIG+=insignificant_test

Throwing C++ exceptions through the event loop doesn't work if the Glib
event loop is used, so conditionally skip that part of the test.

Change-Id: Ic27ebf4eb75bd1cf7c7e35f371f29bcfc0e1844a
Reviewed-on: http://codereview.qt.nokia.com/2471
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
12 years agotest: skipped unstable portion of tst_qcssparser on qpa
Rohan McGovern [Thu, 18 Aug 2011 04:14:41 +0000 (14:14 +1000)]
test: skipped unstable portion of tst_qcssparser on qpa

This test unstably fails because font lookup is somewhat broken for qpa.

Task-number: QTBUG-20986
Change-Id: Id4ebd35e979d8837d32b58e5ed9c1df3ac15827a
Reviewed-on: http://codereview.qt.nokia.com/3130
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qrawfont as expected failure on qpa
Rohan McGovern [Wed, 17 Aug 2011 23:24:09 +0000 (09:24 +1000)]
test: mark tst_qrawfont as expected failure on qpa

The necessary font handling code for qrawfont currently seems to be
unimplemented for all qpa backends.

Task-number: QTBUG-20976
Change-Id: I2b5c511936892e2754c0ee809b7a558f44d1d132
Reviewed-on: http://codereview.qt.nokia.com/3116
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed XPASS from tst_qstatictext on qpa
Rohan McGovern [Wed, 17 Aug 2011 23:40:55 +0000 (09:40 +1000)]
test: fixed XPASS from tst_qstatictext on qpa

These tests were written to compare two different methods of drawing
text, to ensure the result was the same.  However, if _both_ methods
turned out to be complete no-ops, the test would unexpectedly pass, as
it never verified that anything was painted.  Add additional
verification steps and QEXPECT_FAIL them on qpa for now.

Task-number: QTBUG-20977

Change-Id: I1ce1b7c2bcd683fc9eeaeb8d1483268e56f5cf08
Reviewed-on: http://codereview.qt.nokia.com/3117
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qsystemtrayicon as expected failure for qpa
Rohan McGovern [Thu, 18 Aug 2011 00:53:22 +0000 (10:53 +1000)]
test: mark tst_qsystemtrayicon as expected failure for qpa

QSystemTrayIcon is unimplemented for qpa.

Task-number: QTBUG-20978
Change-Id: I63703b96e3d4572bae722120774de1565d475414
Reviewed-on: http://codereview.qt.nokia.com/3119
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: mark tst_qtextlayout as insignificant for qpa, xcb
Rohan McGovern [Thu, 18 Aug 2011 01:07:42 +0000 (11:07 +1000)]
test: mark tst_qtextlayout as insignificant for qpa, xcb

This autotest segfaults in this configuration.

Task-number: QTBUG-20979
Change-Id: I7f038416d9333b690695f48e4ad01d52767f45cd
Reviewed-on: http://codereview.qt.nokia.com/3120
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotests: disabled failing qsharedmemory, qsystemsemaphore tests
Rohan McGovern [Thu, 18 Aug 2011 01:16:54 +0000 (11:16 +1000)]
tests: disabled failing qsharedmemory, qsystemsemaphore tests

The `lackey' helper app was disabled by
ccd5228a9380fbfa308a57365e4075f90010da00, but the tests which depend on
it weren't disabled - so, of course, they fail.

None of these tests will work until the circular dependency is fixed
(the tests are in qtbase and they depend on qtscript which depends on
qtbase).

Change-Id: I8e41b4182f5ea57a71ec810a30a21ba1c7217db3
Reviewed-on: http://codereview.qt.nokia.com/3122
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: fixed failure of tst_qhostinfo
Rohan McGovern [Thu, 18 Aug 2011 02:53:08 +0000 (12:53 +1000)]
test: fixed failure of tst_qhostinfo

Doing an async exit of the test event loop is unsafe - it means that
a call to exitLoop may be left pending from one testfunction, causing
future testfunctions to fail.  This in fact was happening for the
multipleDifferentLookups testfunction, which was running the event loop
for two milliseconds at a time until a certain amount of lookups was
done.  It was common for the loop to timeout after the lookup had
completed but before the async exitLoop had been processed.

Make it simple, do a synchronous exitLoop.

Change-Id: I2ffe6989bddc091ddd42b218a75f7a8ff160cf53
Reviewed-on: http://codereview.qt.nokia.com/3124
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agotest: marked tst_macgui as insignificant
Rohan McGovern [Thu, 18 Aug 2011 04:03:19 +0000 (14:03 +1000)]
test: marked tst_macgui as insignificant

This autotest sometimes passes and sometimes fails, making its result
insignificant for the purpose of detecting regressions.

Task-number: QTBUG-20984
Change-Id: I1454649384b60501be0bec238dfb18cfc85d5f54
Reviewed-on: http://codereview.qt.nokia.com/3129
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>