Lucas De Marchi [Sat, 27 Nov 2010 19:38:59 +0000 (17:38 -0200)]
examples: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:58 +0000 (17:38 -0200)]
gisi: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:57 +0000 (17:38 -0200)]
unit: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Denis Kenzior [Mon, 29 Nov 2010 17:47:47 +0000 (11:47 -0600)]
isi: Get rid of a pointless check in cf driver
Lucas De Marchi [Sat, 27 Nov 2010 19:38:56 +0000 (17:38 -0200)]
drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
Lucas De Marchi [Sat, 27 Nov 2010 19:38:55 +0000 (17:38 -0200)]
coding-style: add rule about checking NULL pointer
Lucas De Marchi [Sat, 27 Nov 2010 19:22:55 +0000 (17:22 -0200)]
TODO: Mark CTM task as done
Lucas De Marchi [Sat, 27 Nov 2010 19:22:54 +0000 (17:22 -0200)]
phonesim: implement ctm atom
Denis Kenzior [Mon, 29 Nov 2010 13:51:53 +0000 (07:51 -0600)]
isi: Update radio-settings to use new API
Denis Kenzior [Mon, 29 Nov 2010 13:51:41 +0000 (07:51 -0600)]
radio-settings: Update API to use ofono_bool_t
Denis Kenzior [Sat, 27 Nov 2010 17:57:50 +0000 (11:57 -0600)]
atmodem: Forgot to reset sms data on remove
Rémi Denis-Courmont [Mon, 29 Nov 2010 08:29:02 +0000 (10:29 +0200)]
configure: do not hard-code the C run-time library name
Since oFono does (obviously) not use -nostdlib, this only broke support
for alternative C run-times.
Jeevaka Badrappan [Fri, 26 Nov 2010 06:23:31 +0000 (22:23 -0800)]
simutil: Add EFcfis and EFcphs-cff file Ids
Jeevaka Badrappan [Fri, 26 Nov 2010 21:21:06 +0000 (13:21 -0800)]
call-volume: Minor coding style fix
Jeevaka Badrappan [Fri, 26 Nov 2010 12:27:42 +0000 (04:27 -0800)]
audio-settings: Remove unwanted check
Jeevaka Badrappan [Fri, 26 Nov 2010 20:59:38 +0000 (12:59 -0800)]
call-volume: Remove extra line at EOF
Arun Ravindran [Fri, 26 Nov 2010 09:54:02 +0000 (11:54 +0200)]
doc: update cdma-voicecall-manager-api.txt
Yang Gu [Thu, 25 Nov 2010 12:29:00 +0000 (20:29 +0800)]
network: Use bit as size instead of byte
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
core: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isigen: Remove stray newlines in DBG
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
ste: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isi: Remove stray newlines in messages sent to log
Jeevaka Badrappan [Fri, 26 Nov 2010 14:59:32 +0000 (06:59 -0800)]
call-volume: Fix dbus error message type
Denis Kenzior [Fri, 26 Nov 2010 19:22:55 +0000 (13:22 -0600)]
build: Add forgotten test/test-tty
Lucas De Marchi [Thu, 25 Nov 2010 17:42:00 +0000 (15:42 -0200)]
test: add test/set-tty script
To enable/disable text-telephony support
Denis Kenzior [Fri, 26 Nov 2010 18:56:43 +0000 (12:56 -0600)]
ctm: Tweak documentation to reflect implementation
Denis Kenzior [Fri, 26 Nov 2010 18:55:50 +0000 (12:55 -0600)]
ctm: fix minor style issues
Lucas De Marchi [Thu, 25 Nov 2010 17:41:58 +0000 (15:41 -0200)]
ctm: add documentation for TextTelephony interface
Lucas De Marchi [Thu, 25 Nov 2010 17:41:57 +0000 (15:41 -0200)]
ctm: Add initial CTM atom implementation
Lucas De Marchi [Thu, 25 Nov 2010 17:41:56 +0000 (15:41 -0200)]
ctm: add public header
Denis Kenzior [Thu, 25 Nov 2010 23:58:37 +0000 (17:58 -0600)]
stkutil: Minor style fixes
Guillaume Lucas [Thu, 25 Nov 2010 16:15:04 +0000 (16:15 +0000)]
stkutil: Use sms_dcs_decode in decode_text
This is a much more pedantic version that can be used to
retrieve the text character set.
Andrzej Zaborowski [Tue, 23 Nov 2010 13:35:41 +0000 (14:35 +0100)]
stk: use bigger timeout in DisplayText
When the wait for user confirmation bit is set.
Jeevaka Badrappan [Wed, 24 Nov 2010 09:57:33 +0000 (01:57 -0800)]
call-forwarding: skip property change data and fax
Denis Kenzior [Wed, 24 Nov 2010 21:43:31 +0000 (15:43 -0600)]
doc: Add PropertyChanged signal to voicecall api
Denis Kenzior [Wed, 24 Nov 2010 21:43:17 +0000 (15:43 -0600)]
doc: Add GetProperties to CDMA voicecall api
Arun Ravindran [Wed, 24 Nov 2010 14:56:11 +0000 (16:56 +0200)]
doc: Update voicecallmanager-api.txt
Lucas De Marchi [Tue, 23 Nov 2010 18:04:14 +0000 (16:04 -0200)]
text-telephony: add new interface to feature map
Lucas De Marchi [Tue, 23 Nov 2010 18:04:13 +0000 (16:04 -0200)]
text-telephony: define new dbus interface
Aki Niemi [Wed, 24 Nov 2010 12:39:20 +0000 (14:39 +0200)]
TODO: Take ownership of neighbor cell atom task
Lucas De Marchi [Tue, 23 Nov 2010 18:08:35 +0000 (16:08 -0200)]
doc: update radio-settings-api with possible errors
When GetProperties() and SetProperty() are called, there are more errors
that might be returned. Add them in documentation.
Marcel Holtmann [Tue, 23 Nov 2010 13:55:57 +0000 (14:55 +0100)]
Release 0.36
Denis Kenzior [Tue, 23 Nov 2010 12:59:39 +0000 (06:59 -0600)]
doc: Add initial CDMA D-Bus API proposal
Rémi Denis-Courmont [Tue, 23 Nov 2010 12:40:38 +0000 (14:40 +0200)]
common: remove redundant predicate
If the first character is a plus sign, then it is not a nul, then
the string length is true anyway.
Gustavo F. Padovan [Fri, 19 Nov 2010 21:37:08 +0000 (19:37 -0200)]
dbus: Add __ofono_error_access_denied
Gustavo F. Padovan [Fri, 19 Nov 2010 21:37:07 +0000 (19:37 -0200)]
TODO: Add owner to implement the Lockdown property
Lucas De Marchi [Fri, 19 Nov 2010 14:46:00 +0000 (12:46 -0200)]
TODO: add owner to Frequency Band Selection task
Denis Kenzior [Tue, 23 Nov 2010 09:21:22 +0000 (03:21 -0600)]
gatchat: remove write watcher on a disconnect
There's a small probability that we call chat_wakeup_writer
just before the channel disonnects. When this happens the write
watcher still fires causing a potential crash.
Denis Kenzior [Tue, 23 Nov 2010 09:08:56 +0000 (03:08 -0600)]
stk: Minor style fix
Andrzej Zaborowski [Mon, 22 Nov 2010 04:43:01 +0000 (05:43 +0100)]
stk: Handle null Text field
Add a NULL check in dbus_apply_text_attributes because in some places
(like DisplayText handler) we call it without checking and we just check
the return value once.
Sjur Brændeland [Sun, 21 Nov 2010 20:55:15 +0000 (21:55 +0100)]
stemodem: Change use of types
Use the type __u32 for sequence counting rather than guint32,
and "void *" instead of gpointer.
Reduce the size of RTNL message buffer from 4096 to 1024,
as this should be sufficient to hold the NEWLINK message.
Denis Kenzior [Mon, 22 Nov 2010 22:48:45 +0000 (16:48 -0600)]
call-settings: Add support for +COLR in atmodem
Denis Kenzior [Mon, 22 Nov 2010 22:32:27 +0000 (16:32 -0600)]
call-settings: Fix style issues
Denis Kenzior [Mon, 22 Nov 2010 22:29:46 +0000 (16:29 -0600)]
call-settings: fix CLIR Invocation and Suppression
According to 22.030 the *31# version is used to suppress CLIR
and #31# version is used to invoke CLIR.
Denis Kenzior [Mon, 22 Nov 2010 16:13:34 +0000 (10:13 -0600)]
coding-style: Use stronger wording for rule M11
Denis Kenzior [Mon, 22 Nov 2010 15:56:22 +0000 (09:56 -0600)]
modem: Don't notify online watches the first time
We should not notify the online watches when we enter the OFFLINE state
for the first time. We should only do so when we go from ONLINE state
into the OFFLINE state.
Denis Kenzior [Mon, 22 Nov 2010 10:29:06 +0000 (04:29 -0600)]
modem: Miscellaneous style fixes
Andras Domokos [Mon, 15 Nov 2010 16:57:55 +0000 (18:57 +0200)]
modem: add modem online-offline watch
Pekka Pessi [Tue, 16 Nov 2010 17:05:23 +0000 (19:05 +0200)]
isi/voicecall: release COMING calls with BUSY cause
Very early incoming calls were not released with BUSY cause.
Denis Kenzior [Mon, 22 Nov 2010 11:20:28 +0000 (05:20 -0600)]
doc: Fixup the use of read-write to readwrite
Denis Kenzior [Mon, 22 Nov 2010 11:12:49 +0000 (05:12 -0600)]
AUTHORS: Mention George's contributions
George Matveev [Fri, 19 Nov 2010 09:18:05 +0000 (10:18 +0100)]
build: Update glib version in configure.ac
function g_mkstemp_full in src/storage.c
requires glib version 2.22 or higher
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
src: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
simutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
simfs: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
stkutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
smsutil: coding style fixes - rule M6
Jeevaka Badrappan [Fri, 19 Nov 2010 13:57:22 +0000 (05:57 -0800)]
util: coding style fixes - rule M6
Rémi Denis-Courmont [Thu, 18 Nov 2010 15:11:45 +0000 (17:11 +0200)]
doc: fix typos
Marcel Holtmann [Fri, 19 Nov 2010 10:40:31 +0000 (11:40 +0100)]
modem: Fix small coding style issue
Jeevaka Badrappan [Wed, 17 Nov 2010 15:32:43 +0000 (07:32 -0800)]
util: Remove extra tab
Denis Kenzior [Wed, 17 Nov 2010 14:26:26 +0000 (08:26 -0600)]
modem: Fix up doc typo
Sjur Brændeland [Wed, 17 Nov 2010 07:09:13 +0000 (08:09 +0100)]
TODO: Add Location Service (AGPS) task.
Sjur Brændeland [Wed, 17 Nov 2010 07:09:12 +0000 (08:09 +0100)]
coding-style: Add exception to rule M12
For external enums
Gustavo F. Padovan [Fri, 12 Nov 2010 19:56:10 +0000 (17:56 -0200)]
Simplify ofono_modem_set_powered() logic
Sjur Brændeland [Fri, 12 Nov 2010 15:02:38 +0000 (16:02 +0100)]
stemodem: Fix for error handling, memleak and changed some defines
* renamed MAX_LEN to IP_ADDR_LEN
* removed memory leak from unneeded strdup when parsing xml response.
* better handling of AT error responses
* reduced number of caif interfaces to 4
Marcel Holtmann [Sat, 13 Nov 2010 01:26:07 +0000 (10:26 +0900)]
stemodem: Fix various coding style and logic issues with RTNL support
Sjur Brændeland [Fri, 12 Nov 2010 10:41:30 +0000 (11:41 +0100)]
stemodem: Add RTNL functionality managing CAIF Network Interfaces.
Mika Liljeberg [Thu, 11 Nov 2010 15:50:00 +0000 (17:50 +0200)]
isigen: create four gprs contexts
Denis Kenzior [Thu, 11 Nov 2010 15:08:09 +0000 (09:08 -0600)]
isimodem: Get rid of whitespace corruption
Pekka Pessi [Thu, 11 Nov 2010 12:54:24 +0000 (14:54 +0200)]
monitor-ofono: monitor DisconnectReason
Aki Niemi [Thu, 11 Nov 2010 08:11:24 +0000 (10:11 +0200)]
isimodem: Fix style issues in gprs-context.c
Mika Liljeberg [Wed, 10 Nov 2010 12:22:30 +0000 (14:22 +0200)]
isimodem: revector GPRS context driver
Mika Liljeberg [Wed, 10 Nov 2010 12:22:29 +0000 (14:22 +0200)]
gisi: return NULL instead of asserting
Mika Liljeberg [Wed, 10 Nov 2010 12:22:28 +0000 (14:22 +0200)]
gisi: fix crash bug in g_isi_remove_subscription
John Mathew [Wed, 10 Nov 2010 16:09:49 +0000 (11:09 -0500)]
TODO: Assign Voicecall emergency property task
Denis Kenzior [Wed, 10 Nov 2010 15:17:19 +0000 (09:17 -0600)]
sms: Fix up comment style and wording
Denis Kenzior [Wed, 10 Nov 2010 15:15:51 +0000 (09:15 -0600)]
cbs: Minor style fixes
Andrzej Zaborowski [Wed, 10 Nov 2010 03:27:52 +0000 (04:27 +0100)]
cbs: CBS-PP download must be enabled in sst / est
Andrzej Zaborowski [Wed, 10 Nov 2010 03:27:51 +0000 (04:27 +0100)]
sms: SMS-PP download must be enabled in sst / est
Andrzej Zaborowski [Wed, 10 Nov 2010 03:27:50 +0000 (04:27 +0100)]
sim: Add sim_service_available()
This is meant to query EFsst or EFust.
The function is not public api because the service constants are in
src/simutil.h.
Marit Henriksen [Wed, 10 Nov 2010 11:35:45 +0000 (12:35 +0100)]
TODO: Check SIM pin status if sim_change_pin fails
Denis Kenzior [Tue, 9 Nov 2010 16:18:14 +0000 (10:18 -0600)]
build: Add reset-pin script
Pekka Pessi [Mon, 8 Nov 2010 20:28:33 +0000 (22:28 +0200)]
Add test/reset-pin
Andrzej Zaborowski [Sun, 7 Nov 2010 17:42:20 +0000 (18:42 +0100)]
TODO: Add async SMS acknowledgement task
Denis Kenzior [Mon, 8 Nov 2010 19:43:22 +0000 (13:43 -0600)]
TODO: Mark SMS-PP download task as done
Andrzej Zaborowski [Sun, 7 Nov 2010 17:42:19 +0000 (18:42 +0100)]
sms: Handle "USIM Download" SMS type.
Andrzej Zaborowski [Sun, 7 Nov 2010 17:42:18 +0000 (18:42 +0100)]
stk: API for SMS Point-to-Point download to UICC
The callback returns the TP-User-Data element content of the RP-ACK or
RP-ERROR message, returned by the UICC.
Lucas De Marchi [Mon, 8 Nov 2010 19:07:05 +0000 (17:07 -0200)]
TODO: add owner to TTY support
Gustavo F. Padovan [Mon, 8 Nov 2010 18:58:39 +0000 (16:58 -0200)]
TODO: Add owner to silent modem reset