profile/ivi/qtbase.git
13 years agoAdd a signal emitted callback to QAbstractDeclarativeData
Aaron Kennedy [Fri, 19 Aug 2011 12:05:50 +0000 (22:05 +1000)]
Add a signal emitted callback to QAbstractDeclarativeData

For property notify signals, QtDeclarative can manage connections
in a more special case - and more performant - way.  This patch
adds a callback hook so that QtDeclarative can intercept signals
being emitted by declarative objects.

Change-Id: I72554e80df0a4257da65d81cc1c5db88a11446a4
Reviewed-on: http://codereview.qt.nokia.com/3363
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoFix fontconfig configure test
Jiang Jiang [Mon, 29 Aug 2011 14:23:24 +0000 (16:23 +0200)]
Fix fontconfig configure test

It does not necessarily require X11.

Change-Id: Ie10f91b2052af21ea877d6c7d322fc43e84108cb
Reviewed-on: http://codereview.qt.nokia.com/3815
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agoAdd QtV8 library to QtBase
Kent Hansen [Tue, 16 Aug 2011 08:50:00 +0000 (10:50 +0200)]
Add QtV8 library to QtBase

This adds Aaron's copy of V8 to src/3rdparty/v8 (as a
git submodule), and builds it as a "normal" Qt library
(without any dependencies on Qt itself).

The library can be added to a project with

QT += v8-private

V8 API headers are available as private includes, e.g.

 #include <private/v8.h>

The API is private because we're exposing a third-party
API directly, and we don't want to (and cannot) make
source or binary compatibility guarantees for it.

Since we want the V8 public API headers to be private
headers in Qt, syncqt and sync.profile were extended to
understand a new configuration option, the
@allmoduleheadersprivate array, that tells syncqt whether
all the library headers should be treated as private even
though they don't follow the _p.h Qt convention.

The V8 project files, patches and autotests are copied
from the QtDeclarative repository. The next step after
this commit is to remove QtDeclarative's copy of V8 and
link with QtV8 instead.

Task-number: QTBUG-20963
Change-Id: Ib8820362cdbc8fa662a5e97db841656cf38d1b62
Reviewed-on: http://codereview.qt.nokia.com/3092
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoOptimized QMatrix4x4 by improving how 'flagBits' are used.
Kim Motoyoshi Kalland [Fri, 19 Aug 2011 13:00:41 +0000 (15:00 +0200)]
Optimized QMatrix4x4 by improving how 'flagBits' are used.

Change-Id: Ic417336489d334e25b547c719d457faf65307cac
Reviewed-on: http://codereview.qt.nokia.com/3670
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
13 years agoRemove the QTEST_NOEXITCODE define.
Jason McDonald [Mon, 29 Aug 2011 01:47:57 +0000 (11:47 +1000)]
Remove the QTEST_NOEXITCODE define.

Tests that are expected to return a non-zero exitcode should be marked
with "CONFIG+=insignificant_test" in their .pro file.

Change-Id: Iebb9c7129c08833ed517115f569086d6fcfe827b
Reviewed-on: http://codereview.qt.nokia.com/3689
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRename COMPARE_IMPL2 to TO_STRING_IMPL.
Jason McDonald [Fri, 26 Aug 2011 08:42:34 +0000 (18:42 +1000)]
Rename COMPARE_IMPL2 to TO_STRING_IMPL.

Change-Id: Idbc8c78815f9259c5ecc36fbb053d64f6802c66b
Reviewed-on: http://codereview.qt.nokia.com/3649
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove unused function
Jason McDonald [Fri, 26 Aug 2011 08:36:59 +0000 (18:36 +1000)]
Remove unused function

Change-Id: I04eea17a3674beb59c84e3992f9bb2754f7b3525
Reviewed-on: http://codereview.qt.nokia.com/3646
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove literal tabs
Jason McDonald [Fri, 26 Aug 2011 08:32:16 +0000 (18:32 +1000)]
Remove literal tabs

Change-Id: I06064f68a0ca23968cec30ccb063dadf2e67571b
Reviewed-on: http://codereview.qt.nokia.com/3645
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove default params from QTestData constructor
Jason McDonald [Fri, 26 Aug 2011 08:10:08 +0000 (18:10 +1000)]
Remove default params from QTestData constructor

The constructor asserts if either parameter is null, so having defaults
seems to be pointless.

Change-Id: I8cec52e17e5f94458e8d8323855eaed6433686e7
Reviewed-on: http://codereview.qt.nokia.com/3644
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove obsolete ifdef.
Jason McDonald [Fri, 26 Aug 2011 08:01:43 +0000 (18:01 +1000)]
Remove obsolete ifdef.

QTEST_EMBED is not defined in Qt itself, nor is it defined by any of the
CI builds for Qt's supported platforms.

Change-Id: I73a3979630130fc8f1ef99dcbc17b4d1875ba246
Reviewed-on: http://codereview.qt.nokia.com/3641
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove debugging printf.
Jason McDonald [Fri, 26 Aug 2011 07:49:56 +0000 (17:49 +1000)]
Remove debugging printf.

Change-Id: Ib5733e96d3a6cec956d2f4c326d7be42e813c440
Reviewed-on: http://codereview.qt.nokia.com/3639
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove obsolete autotest command-line flag.
Jason McDonald [Fri, 26 Aug 2011 07:43:55 +0000 (17:43 +1000)]
Remove obsolete autotest command-line flag.

The charting functionality was removed in Qt 4.6, though the
command-line option was retained to print a warning that the feature had
been removed.  Sufficient time has passed for this to be removed
completely.

Change-Id: I2adf2818c6a6e57e765104de97b28dbf6914e3fa
Reviewed-on: http://codereview.qt.nokia.com/3638
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoSend error messages to stderr rather than stdout
Jason McDonald [Fri, 26 Aug 2011 07:36:55 +0000 (17:36 +1000)]
Send error messages to stderr rather than stdout

The commit changes printf's that output error and warning messages to
send their text to the stderr stream.  Non-error output, such as that
produced by passing the -help option to a test, still goes to stdout.

Change-Id: Iea4d62451e3e7e84c654859cb09ea7e717511d13
Reviewed-on: http://codereview.qt.nokia.com/3636
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove unused members and methods from QTestLogger.
Jason McDonald [Wed, 24 Aug 2011 04:25:20 +0000 (14:25 +1000)]
Remove unused members and methods from QTestLogger.

QTestLogger was counting various test outputs, but was only using three
of the counters internally and the rest were not used at all.  This
commit removes the unused counters and all of the getter methods.

Change-Id: I447183dcaf3e6cc335bbf58656e25b1d32ba810a
Reviewed-on: http://codereview.qt.nokia.com/3437
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove unused methods from QTestLogger.
Jason McDonald [Wed, 24 Aug 2011 03:48:56 +0000 (13:48 +1000)]
Remove unused methods from QTestLogger.

The setLogFormat() and logFormat() methods are never called -- the log
format is set in the call to the constructor and it would not make sense
to change it during a test run.

Change-Id: I59256f17f28bbc72d86cabfb2a961d2faf0e2d52
Reviewed-on: http://codereview.qt.nokia.com/3435
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove QTestLog constructor/destructor definitions
Jason McDonald [Wed, 24 Aug 2011 07:58:31 +0000 (17:58 +1000)]
Remove QTestLog constructor/destructor definitions

QTestLog is an entirely static class and its constructor and destructor
are declared private to prevent accidental construction of an instance
of the class.  Therefore, the constructor and destructor do not need to
be defined.

Change-Id: I860f1344c5032091f5c641a20e1656bb52a6f07e
Reviewed-on: http://codereview.qt.nokia.com/3466
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoAdd missing assertions.
Jason McDonald [Wed, 24 Aug 2011 08:20:44 +0000 (18:20 +1000)]
Add missing assertions.

For both QTestLog::addFail() and QTestLog::addIgnoreMessage(), passing
a null message does not make sense and is therefore an error that
should be brought to the developer's attention.

Change-Id: Ib09ad90b70d74f7432c08708db8a70dee008cce4
Reviewed-on: http://codereview.qt.nokia.com/3470
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoBe more consistent when including private headers.
Jason McDonald [Wed, 24 Aug 2011 08:03:56 +0000 (18:03 +1000)]
Be more consistent when including private headers.

Change-Id: I0fdc014391ff34ba3be9501c2e73bd5357df1f5e
Reviewed-on: http://codereview.qt.nokia.com/3467
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove mode parameter from QTestLog::addSkip().
Jason McDonald [Thu, 25 Aug 2011 02:53:07 +0000 (12:53 +1000)]
Remove mode parameter from QTestLog::addSkip().

The mode parameter is never used by the logging code, so there's little
value in passing it there.

Change-Id: Ibe2cbe5eaf457a7e3ffd3aea3a4be7c8278c91b6
Reviewed-on: http://codereview.qt.nokia.com/3547
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoFix broken header file guard.
Jason McDonald [Wed, 24 Aug 2011 03:41:43 +0000 (13:41 +1000)]
Fix broken header file guard.

Change-Id: I6db5be5289b271be24a4a9d77c5f2a1e9f560d2d
Reviewed-on: http://codereview.qt.nokia.com/3434
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoFix typo in enum name.
Jason McDonald [Wed, 24 Aug 2011 05:23:07 +0000 (15:23 +1000)]
Fix typo in enum name.

Change-Id: I2eccbd3b9dd31aa5e869d622055f9235f90c0c03
Reviewed-on: http://codereview.qt.nokia.com/3445
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoFix minor formatting issues.
Jason McDonald [Thu, 25 Aug 2011 05:06:26 +0000 (15:06 +1000)]
Fix minor formatting issues.

Change-Id: I66767e906c54988ca0d0e2823b1a396993ba06f2
Reviewed-on: http://codereview.qt.nokia.com/3624
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove QTestFileLogger class.
Jason McDonald [Tue, 23 Aug 2011 08:35:27 +0000 (18:35 +1000)]
Remove QTestFileLogger class.

This class is not very useful -- it just creates a text file that
records each occasion that an autotest enters a test function as a
stop-gap solution for the fact that the newer XML logger produces no
output if the autotest fails to terminate gracefully.  Addressing
QTBUG-20615 will provide a better solution by allowing the user to get a
partial plain text test log in those circumstances.

Change-Id: I179bb98dbd696d0734cd3f12046e5c567def30cc
Reviewed-on: http://codereview.qt.nokia.com/3390
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove ability to change XML logger during a test.
Jason McDonald [Fri, 26 Aug 2011 01:44:17 +0000 (11:44 +1000)]
Remove ability to change XML logger during a test.

It doesn't make sense to change the logger associated with a streamer in
the middle of a test run, so only allow the logger to be set when
constructing a streamer.

Change-Id: I02661de2b6071c74d10bc854cbe436581978d2d9
Reviewed-on: http://codereview.qt.nokia.com/3622
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoEnable multiple instances of QAbstractTestLogger.
Jason McDonald [Thu, 25 Aug 2011 08:20:19 +0000 (18:20 +1000)]
Enable multiple instances of QAbstractTestLogger.

Previously QAbstractTestLogger used a global variable for the file
pointer to which it was writing test output.  This effectively meant
that only one instance of this or its derived classes could exist at any
time.

This commit moves the file pointer inside the class, so that multiple
loggers can exist at the same time.  This means that the outputString()
method can no longer be static, which in turn means that several
functions used by QPlainTestLogger need to move from the QTest namespace
into the class, and also that QTestBasicStreamer must hold a non-const
pointer to its associated logger instead of a const pointer.

Task-number: QTBUG-20615
Change-Id: If941f1f9399cf20fb93e3e87f3390bceeca1cbfc
Reviewed-on: http://codereview.qt.nokia.com/3576
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove color logging feature from qtestlib.
Jason McDonald [Wed, 24 Aug 2011 01:39:34 +0000 (11:39 +1000)]
Remove color logging feature from qtestlib.

This feature was undocumented and only worked if a secret environment
variable was set, the test output was going to a real console, and plain
text test results were being generated.  Including code in testlib for
fancy presentation of test results conflicts with testlib's stated goal
of being a lightweight framework where every feature contributes to
finding bugs, so this feature is being removed.  If fancy presentation
of test output is required, it should be achieved by post-processing the
test output outside of the test framework.

Change-Id: I872165c4d2c3d2498c3aa039070ecf319e237ca1
Reviewed-on: http://codereview.qt.nokia.com/3432
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove circular dependency in testlib logging code
Jason McDonald [Wed, 24 Aug 2011 07:14:21 +0000 (17:14 +1000)]
Remove circular dependency in testlib logging code

Pass the output file name from the QTestLog to the test logger when
commencing logging rather than having the logger call back into the
QTestLog.

Change-Id: Id484635f9fcfca08a66c92f3442887e9473b6f9b
Reviewed-on: http://codereview.qt.nokia.com/3454
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoRemove obsolete testlib files from .gitignore
Jason McDonald [Tue, 23 Aug 2011 05:56:33 +0000 (15:56 +1000)]
Remove obsolete testlib files from .gitignore

Change-Id: I8d0ff9cad1da7df3e5e0d18e8f19b17b468afc01
Reviewed-on: http://codereview.qt.nokia.com/3368
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoFix typo for ifdef QT_NO_ACCESSIBILITY
Frederik Gladhorn [Fri, 29 Jul 2011 21:43:01 +0000 (14:43 -0700)]
Fix typo for ifdef QT_NO_ACCESSIBILITY

Reviewed-by: TrustMe
(cherry picked from commit eaf3b5ff76e4866ef3597110c6e565305c3298ad)

Change-Id: I21df13a24fc5d339c5fcbf38f151c0339e1c87a9
Reviewed-on: http://codereview.qt.nokia.com/3042
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoCall QAccessible::updateAccessibility when a widget is deleted
José Millán Soto [Fri, 29 Jul 2011 17:35:54 +0000 (10:35 -0700)]
Call QAccessible::updateAccessibility when a widget is deleted

Merge-request: 1310
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
(cherry picked from commit df3f763920b1450733817596148e087d11c0c543)

Change-Id: I74fb08104c5dc527f9e9ac88776e4aa2623a3385
Reviewed-on: http://codereview.qt.nokia.com/3041
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoCall QAccessible::updateAccessibility when setText is called on QLabel
José Millán Soto [Thu, 14 Jul 2011 12:25:57 +0000 (14:25 +0200)]
Call QAccessible::updateAccessibility when setText is called on QLabel

The method is called when the text of a label is changed and setAccessibleName has
not been called on the label, as the text of the label acts as the accessible name
of the label.

Merge-request: 1301
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
(cherry picked from commit a1f2b68e97477440cf508e6d497eb5f5d9971971)

Change-Id: Ic10f75e72ac3faa84777c444177b287b720a1dc2
Reviewed-on: http://codereview.qt.nokia.com/3040
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoIncorrect property name in QAccessibleAbstractSpinBox::setCurrentValue
José Millán Soto [Sun, 12 Jun 2011 22:31:38 +0000 (00:31 +0200)]
Incorrect property name in QAccessibleAbstractSpinBox::setCurrentValue

Merge-request: 1263
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
(cherry picked from commit 031958c130904c16a4bafa5617aaa197469efa9e)

Change-Id: I0639f90271b80392e9bcf7f0e4ddaf0f3cd6b478
Reviewed-on: http://codereview.qt.nokia.com/3039
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoCheck if bridge plugin vector is still valid.
Frederik Gladhorn [Fri, 26 Aug 2011 08:33:20 +0000 (10:33 +0200)]
Check if bridge plugin vector is still valid.

Q_GLOBAL_STATIC may be destroyed and we still send
ObjectDestroyed notifications.
This only shows now that we actually send the Destroyed notifications.

Change-Id: I3057556cdc897dab6adfc3274e4abc68473ffa7f
Reviewed-on: http://codereview.qt.nokia.com/3657
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gabriel de Dietrich <gabriel.dietrich-de@nokia.com>
13 years agoFix crash when fallback font is not #0 in multi font engine
Eskil Abrahamsen Blomfeldt [Fri, 26 Aug 2011 06:07:20 +0000 (08:07 +0200)]
Fix crash when fallback font is not #0 in multi font engine

Easily reproducible by testing Chinese with the threaded
renderer. The multi engine would then have a list of engines
with a single item, but the glyphs might belong to e.g. engine
11. In that case, engine() would assert when it couldn't find
the engine if the layout had been done in a different thread.
We force the loading of the required engine if it's not already
loaded.

Note that this fix does not work on Mac, as loadEngine() will
crash there, so the layout has to be done in the same thread
as the rendering, since loading the engines is part of the
layout process.

Task-number: QTBUG-21112
Change-Id: I71cc396664e3b95fbb4815a90873457e1f89528e
Reviewed-on: http://codereview.qt.nokia.com/3631
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agooptimize parsing of templates like p{IsArabic}, etc
Ritt Konstantin [Fri, 15 Jul 2011 02:00:05 +0000 (06:00 +0400)]
optimize parsing of templates like p{IsArabic}, etc

use qBinaryFind() with a case-sensitive string comparison
instead of QHash. This also improves startup time and reduces
runtime memory consumption.

Change-Id: I5c5f7cae5e42acb3fa727acac19fe39c53310329
Reviewed-on: http://codereview.qt.nokia.com/3673
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agooptimize parsing of templates like p{L}, p{Lu}, etc
Ritt Konstantin [Fri, 15 Jul 2011 00:29:03 +0000 (04:29 +0400)]
optimize parsing of templates like p{L}, p{Lu}, etc

replacing the if-else trees with the switch statement
gives a 2x-3x parsing performance boost on parsing these
expressions.

Change-Id: Ia0e76ae4e1ab6930dbecf1d4a5232a4cc7198654
Reviewed-on: http://codereview.qt.nokia.com/3672
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agodon't build code related to CClass if QT_NO_REGEXP_CCLASS is defined
Ritt Konstantin [Fri, 15 Jul 2011 00:30:33 +0000 (04:30 +0400)]
don't build code related to CClass if QT_NO_REGEXP_CCLASS is defined

Change-Id: If86835b1065eeb95e0774f1b42870dcd5225da58
Reviewed-on: http://codereview.qt.nokia.com/3671
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoRemove duplicated code from QTestBasicStreamer.
Jason McDonald [Thu, 25 Aug 2011 06:21:36 +0000 (16:21 +1000)]
Remove duplicated code from QTestBasicStreamer.

Instead of using the file output functions inherited from
QAbstractTestLogger, QTestLogger relied on QTestBasicStreamer having a
copy of these functions.  This commit removes the copied functions from
QTestBasicStreamer and makes it and QTestLogger use the original
functions from QAbstractTestLogger.

Change-Id: Icac1ae9d85cd39efd4c67c79104404dd56766b17
Reviewed-on: http://codereview.qt.nokia.com/3565
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoDon't use the // operator, since some versions of Perl don't have it.
Michael Goddard [Wed, 24 Aug 2011 02:28:50 +0000 (12:28 +1000)]
Don't use the // operator, since some versions of Perl don't have it.

Could use || but it's only used for an if test anyway.

Change-Id: I97fe251ab4f27fb75981af12316aaf5da053d47a
Reviewed-on: http://codereview.qt.nokia.com/3431
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoFix justification of RTL text
Eskil Abrahamsen Blomfeldt [Wed, 24 Aug 2011 07:13:45 +0000 (09:13 +0200)]
Fix justification of RTL text

Since the trailing space is included in the QScriptLine, it may affect
the positions of preceding script items when the text is RTL. The best
solution for this would be to disregard the trailing space in the layout
process, or somehow make it have an advance of 0 so it doesn't affect
the layout. However, to minimize the impact of the change, and to be
consistent with previous work arounds such as
bf992df6434fc37715f728ca09601c5567dd83c9, we simply include the trailing
(visually leading) space in the justification pass for now.

Task-number: QTBUG-20920
Reviewed-by: Lars
(cherry picked from commit 1a8a36eb6b6df9e2550b5eaa4606f2d411fd4294)

Change-Id: I94972ebaea2e1bdb09950523c43844351b304abe
Reviewed-on: http://codereview.qt.nokia.com/3462
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoAdd constants to QAccessible::Event enum.
Frederik Gladhorn [Thu, 14 Jul 2011 08:57:02 +0000 (10:57 +0200)]
Add constants to QAccessible::Event enum.

Reviewed-by: Gabi
(cherry picked from commit 81036d4be6122dfcb55a4852bcc1037c7d8f7309)

Change-Id: Id818d9c9e53ece0c93b89649db5aa31d59920426
Reviewed-on: http://codereview.qt.nokia.com/3031
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agotest: marked tst_qfiledialog as insignificant for qpa, xcb
Rohan McGovern [Thu, 25 Aug 2011 08:04:23 +0000 (18:04 +1000)]
test: marked tst_qfiledialog as insignificant for qpa, xcb

This autotest sometimes passes and sometimes fails.

Task-number: QTBUG-21109
Change-Id: I160b43a1abd0de7350029f2eb758f177e880d38d
Reviewed-on: http://codereview.qt.nokia.com/3575
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: marked tst_qmenu as insignificant (for qpa, xcb)
Rohan McGovern [Thu, 25 Aug 2011 03:38:08 +0000 (13:38 +1000)]
test: marked tst_qmenu as insignificant (for qpa, xcb)

This autotest sometimes fails and sometimes passes.

Task-number: QTBUG-21100
Change-Id: I5b3a1cb9713cc12ead130b4c64a876397d61fe17
Reviewed-on: http://codereview.qt.nokia.com/3549
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: marked tst_qlistwidget as insignificant
Rohan McGovern [Thu, 25 Aug 2011 03:02:39 +0000 (13:02 +1000)]
test: marked tst_qlistwidget as insignificant

This test sometimes passes and sometimes fails.

Task-number: QTBUG-21098
Change-Id: Ic56e93d12a7b3fa2e9c135e25610bf1119fa636e
Reviewed-on: http://codereview.qt.nokia.com/3548
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
13 years agoMark QNetworkReply test as unstable
Eskil Abrahamsen Blomfeldt [Thu, 25 Aug 2011 10:42:44 +0000 (12:42 +0200)]
Mark QNetworkReply test as unstable

QTBUG-21102 is currently blocking integration of several commits.
Marking the test as unstable until the bug has been fixed.

Change-Id: I9b630767fd1aa4369564f5e90c63e850808385e1
Reviewed-on: http://codereview.qt.nokia.com/3584
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
13 years agoAdd a QApplication::queryKeyboardModifiers() method.
David Faure [Wed, 17 Aug 2011 11:14:57 +0000 (13:14 +0200)]
Add a QApplication::queryKeyboardModifiers() method.

QApplication::keyboardModifiers returns the keyboard modifiers
from the last keypress event in this process, as documented. However
there are use cases for querying keyboard modifiers as they currently are,
see QTBUG-11243.

Merge-request: 585
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
(cherry picked from commit 3b5354386225974ea6db78c12f32cb81e2d50104)

Change-Id: I9b4e54ac79fc225e3ed8d2bcaba953a6eb59f0d2
Reviewed-on: http://codereview.qt.nokia.com/3581
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoMake the DBus timeout configurable in QDBusAbstractInterface.
David Faure [Thu, 18 Aug 2011 15:48:35 +0000 (17:48 +0200)]
Make the DBus timeout configurable in QDBusAbstractInterface.

Merge-request: 1253
Reviewed-by: Thiago
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
(cherry picked from commit e58a402fbee2fc8af8cd651acafdc28525ed1314)

Change-Id: I4246047b149193e510f2984a0b1a1fae655b9a51
Reviewed-on: http://codereview.qt.nokia.com/3580
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoupdate .gitignore
Charles Yin [Tue, 23 Aug 2011 01:36:24 +0000 (11:36 +1000)]
update .gitignore

1. generated module def files
2. generated version headers
3. unit test executables

Change-Id: Ibce72e89882e646ff0a450d68031e8e3a5cea085
Reviewed-on: http://codereview.qt.nokia.com/3346
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Ling Hu <ling.hu@nokia.com>
13 years agoAdd operator== and operator!= to qsqlerror class
Antonis Tsiapaliokas [Mon, 15 Aug 2011 22:26:21 +0000 (01:26 +0300)]
Add operator== and operator!= to qsqlerror class

Merge-request: 44
Task-number: QTBUG-20543

Change-Id: I7b88985fe095ffd2e48ac05c82dc3f3a92dbb091
Reviewed-on: http://codereview.qt.nokia.com/3425
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoDo not expose text when echo mode is not Normal.
José Millán Soto [Sat, 4 Jun 2011 16:06:47 +0000 (18:06 +0200)]
Do not expose text when echo mode is not Normal.

Reviewed-by: Frederik Gladhorn
(cherry picked from commit 636b7088eb3740800f54a7c1634d3e041e688270)

Change-Id: I82b2e02af74dc43268d2b6613fe31e2875fd132f
Reviewed-on: http://codereview.qt.nokia.com/3038
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoCheck validator when changing text using accessibility functions.
José Millán Soto [Fri, 3 Jun 2011 18:44:37 +0000 (20:44 +0200)]
Check validator when changing text using accessibility functions.

Reviewed-by: Frederik Gladhorn
(cherry picked from commit 731d843b52b0a0bc387c50c2af37a71f87804f4d)

Change-Id: Ieef71cea5b44f288f2f95a0765ec0b3f6d47c042
Reviewed-on: http://codereview.qt.nokia.com/3037
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoImplemented QAccessibleTextEdit::attributes()
Frederik Gladhorn [Tue, 16 Aug 2011 13:19:09 +0000 (15:19 +0200)]
Implemented QAccessibleTextEdit::attributes()

Handling font properties and colors
Created test: tst_QAccessibility::textAttributes

Merge-request: 2626
Reviewed-by: Harald Fernengel <harald.fernengel@nokia.com>
(cherry picked from commit f1a6766432f66220275aa7902e4c2414a3069cd1)

Change-Id: I388bc660af20149934110d7894840eccecf81f2a
Reviewed-on: http://codereview.qt.nokia.com/3036
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agotest: really marked tst_qtcpsocket autotest as unstable
Rohan McGovern [Mon, 22 Aug 2011 23:18:12 +0000 (09:18 +1000)]
test: really marked tst_qtcpsocket autotest as unstable

15575fb280e1489157d0be44d00ab57aecc19320 edited the wrong .pro file :(

Task-number: QTBUG-21043
Change-Id: I7b52fb7ea8669856b359523b278142c763bfb978
Reviewed-on: http://codereview.qt.nokia.com/3341
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Keith Isdale <keith.isdale@nokia.com>
13 years agoAdd IAccessible2 table2 implementation.
Frederik Gladhorn [Mon, 27 Jun 2011 14:28:50 +0000 (16:28 +0200)]
Add IAccessible2 table2 implementation.

Implement the IAccessible table2 interface for itemviews.
This is simpler than what we have in complexwidgets.
For now it is only used on Linux.

The new table2 interface is ifdef'ed to only be used on X11.
Improve handling of accessible events and clean up.

There are two xfails for the Table and Tree where sibling
navigation is not implemented yet.

Reviewed-by: Gabi
(cherry picked from commit e797ba558dddd45522b5a317316e497e9efc44a8)
(cherry picked from commit eff5ecc5d8f65fa25d6cfd6ed96a9d2a00d0c663)
(cherry picked from commit d29876008fad400bca8d6b37e5d5f61dd1bcb39d)
(cherry picked from commit 2a326fdc8f8bf2bd2c5764394616100906d9db2d)
(cherry picked from commit 9b72e79e20d0d3560e0b064b8b0d75e35feb720e)
(cherry picked from commit 075b0f744363842ed4179c644d933d461389544f)

Change-Id: I654f74991830ae1fc7df7cc91d930390fb88b2a4
Reviewed-on: http://codereview.qt.nokia.com/3274
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agotest: marked tst_qtcpsocket autotest as unstable
Rohan McGovern [Mon, 22 Aug 2011 01:44:47 +0000 (11:44 +1000)]
test: marked tst_qtcpsocket autotest as unstable

Task-number: QTBUG-21043
Change-Id: Idefb79bf64eb746e82ebf2980c628f2e37dcf6c3
Reviewed-on: http://codereview.qt.nokia.com/3279
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Keith Isdale <keith.isdale@nokia.com>
13 years agotest: Fix `tst_qfiledialog' in a namespaced build
Sergio Ahumada [Fri, 12 Aug 2011 22:18:18 +0000 (00:18 +0200)]
test: Fix `tst_qfiledialog' in a namespaced build

Reviewed-by: Pierre Rossi
(cherry picked from commit 3be7f871f07041477b5bca0182623b36afd2b3e6)

Change-Id: Ib24d837ef8f47435cc0a505233e77f1104537cae
Reviewed-on: http://codereview.qt.nokia.com/3263
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoEnablers for using QGlyphRun in SceneGraph
Eskil Abrahamsen Blomfeldt [Wed, 1 Jun 2011 13:33:38 +0000 (15:33 +0200)]
Enablers for using QGlyphRun in SceneGraph

Several required fixes and changes to fix problems that arose
when porting SceneGraph's QSGTextInput and QSGTextEdit to
use QSGTextNode, especially related to having selections
on the text.

Also fixes crashes with the threaded renderer on Mac OS X
when using the TextEdit or TextInput elements.

Task-number: QTBUG-18019, QTBUG-20017
Change-Id: I67f24465352daa1d2cb12b6d2f378feb676c9804
Reviewed-on: http://codereview.qt.nokia.com/2864
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
13 years agoFixed broken lookup of fallback fonts on qpa
Rohan McGovern [Wed, 17 Aug 2011 04:47:42 +0000 (14:47 +1000)]
Fixed broken lookup of fallback fonts on qpa

Loading of fallback fonts from the font cache was broken.
While iterating through fallback fonts, we would incorrectly skip any
fonts which were already in the cache.  This would cause unstable lookup
results for some fonts, depending on the order in which fonts were
loaded during the current process.

Change-Id: I56a6a07e93196ed14f33f4cc181e41c5b8f19498
Reviewed-on: http://codereview.qt.nokia.com/3059
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
13 years agoUse name for combobox on Unix.
Frederik Gladhorn [Thu, 30 Jun 2011 15:31:36 +0000 (17:31 +0200)]
Use name for combobox on Unix.

This is more conforming to the AT-SPI specs.
Also we have working relations for the label when a buddy is set.

Reviewed-by: Gabi
(cherry picked from commit 8be3168aa2f300f9a93a53b417704f3f10b1dc8b)

Change-Id: I1831d5063b003df2d209aba99d54558b6493a3e9
Reviewed-on: http://codereview.qt.nokia.com/3027
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoRename textBeforeOffsetFromString to start with q.
Frederik Gladhorn [Fri, 8 Jul 2011 08:22:39 +0000 (01:22 -0700)]
Rename textBeforeOffsetFromString to start with q.

Exported functions should start with q.

Reviewed-by: TrustMe
(cherry picked from commit 4fcb7c233c3c8d748d66bf698df059ad7546ae88)

Change-Id: Idc53d3ec49f73227a9fd12b6b88aade35c7cdf25
Reviewed-on: http://codereview.qt.nokia.com/3026
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoImplement text interface for QLineEdit.
Frederik Gladhorn [Tue, 5 Jul 2011 15:05:11 +0000 (17:05 +0200)]
Implement text interface for QLineEdit.

Add boundary helper functions to the QAccessibleTextInterface.
Move LineEdit over to use QTextBoundaryFinder.

Reviewed-by: Jan-Arve
(cherry picked from commit c1ec1a95806cda54d5b4e9f8ed159a611bd75964)

Change-Id: Ib93599c49110aab50debe1e3fb0073dd34071c87
Reviewed-on: http://codereview.qt.nokia.com/3025
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoFix compilation with thumb2.
Eike Ziller [Wed, 10 Aug 2011 07:38:37 +0000 (09:38 +0200)]
Fix compilation with thumb2.

Task-number: QTBUG-16402
Rubber-stamped-by: Thiago Macieira
(cherry picked from commit 6be1b235f7db38146f7080a4bfcfe3051ae54699)

Change-Id: I6f60f1d3079395e765a183961db5c8543cf58cdc
Reviewed-on: http://codereview.qt.nokia.com/3078
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eckhart Koppen <eckhart.koppen@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
13 years agoFix bidi reordering of RTL text with embedded images
Eskil Abrahamsen Blomfeldt [Tue, 16 Aug 2011 08:52:29 +0000 (10:52 +0200)]
Fix bidi reordering of RTL text with embedded images

According to the UBA, the object replacement character should be
considered ON. There's no reason to special case its directionality, as
the bidi algorithm will already have given it an implicit
directionality.

Task-number: QTBUG-20910
Reviewed-by: Lars
(cherry picked from commit 2657bfa7c4de9f114331d1714a306b3999ae30d8)

Change-Id: I1c8e45d67ef44b1b6f96edb2f5074331b5422eb7
Reviewed-on: http://codereview.qt.nokia.com/2999
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
13 years agoMinor optimizations for QTextEngine
Ritt Konstantin [Wed, 13 Jul 2011 00:41:45 +0000 (04:41 +0400)]
Minor optimizations for QTextEngine

Optimize script assignment, skip calls to QUnicodeTables::script() for
the codepoints handled explicitly.
Make the helper functions of QTextEngine::elidedText() inlined

Merge-request: 1298
Reviewed-by: yoann
(cherry picked from commit 857202824e7d6083eeb87fc52d3770f8fd82b559)

Change-Id: I1afc6405a800dbc2b5f63a2f98c63e607e3ee255
Reviewed-on: http://codereview.qt.nokia.com/2998
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
13 years agoAdd DBus VirtualObject to handle multiple paths.
Frederik Gladhorn [Sun, 22 May 2011 19:36:10 +0000 (21:36 +0200)]
Add DBus VirtualObject to handle multiple paths.

When a virtual object is registered with the SubPath option
it will handle all dbus calls to itself and all child paths.
It needs to reimplement handleMessage for that purpose.

Introspection needs to be implemented manually in the introspect function.

Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
(cherry picked from commit b07919b3de8cff3e44b7271062372b14bcda5b83)
(cherry picked from commit 997c2dfed7a04da2fac577f1c29b89bda4939e2d)
(cherry picked from commit c676b7095d826dc2d006f52a4b234546af5e2137)

Change-Id: I003007604b286af8000959756ce9d25c17306f5b
Reviewed-on: http://codereview.qt.nokia.com/3051
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoUpdate changelog with Accessibility fixes.
Frederik Gladhorn [Tue, 16 Aug 2011 12:53:33 +0000 (14:53 +0200)]
Update changelog with Accessibility fixes.

(cherry picked from commit b955efd392d2c1ec82a043df7b364af71e464078)

Change-Id: I4a2c4f0abf5c9bef10fe0ce0f071473d9b3a3397
Reviewed-on: http://codereview.qt.nokia.com/3024
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoFix a11y crash: dock doesn't always have a widget.
Frederik Gladhorn [Tue, 28 Jun 2011 12:37:10 +0000 (14:37 +0200)]
Fix a11y crash: dock doesn't always have a widget.

Also return dock widget title.

Reviewed-by: Gabriel de Dietrich <gabriel.dietrich-de@nokia.com>
(cherry picked from commit 276d16583b80da2838f9af47e15fe3a83cdb0485)

Change-Id: I8d66bec4212cc2b1df8c9b041375d7455c6a76a3
Reviewed-on: http://codereview.qt.nokia.com/3023
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoFix typo in comment.
Frederik Gladhorn [Mon, 20 Jun 2011 12:29:16 +0000 (14:29 +0200)]
Fix typo in comment.

(cherry picked from commit f067c2b3016182862e82805b13c7944ebe8671a9)
Change-Id: Iac3673db666e53f5e1a20f95a59df15a6ad9c137
Reviewed-on: http://codereview.qt.nokia.com/3022
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoAvoid bogus accessibility focus events from menus.
Frederik Gladhorn [Sun, 5 Jun 2011 11:16:13 +0000 (04:16 -0700)]
Avoid bogus accessibility focus events from menus.

Do not send accessibility focus events when menus are involved.
There are focus events to preserve the old focus when showing a new popup window.

Reviewed-by: Jan-Arve
(cherry picked from commit 32079bb0b348ef5f7126e69be9bcfb249c1a6412)

Change-Id: Id4838a3aede1d60a1850385e97660d085f055d64
Reviewed-on: http://codereview.qt.nokia.com/3021
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agotest: marked tst_qfocusevent as insignificant on all platforms
Rohan McGovern [Thu, 18 Aug 2011 04:21:32 +0000 (14:21 +1000)]
test: marked tst_qfocusevent as insignificant on all platforms

This was known to be unstable on mac, but appears to be unstable on
Linux also.

Task-number: QTBUG-20987
Change-Id: I760533c32cf13d24f8428f120813eb590b202182
Reviewed-on: http://codereview.qt.nokia.com/3131
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed failure of tst_qstylesheetstyle on qpa
Rohan McGovern [Thu, 18 Aug 2011 00:33:57 +0000 (10:33 +1000)]
test: fixed failure of tst_qstylesheetstyle on qpa

Wait for window shown on _all_ platforms, not just X11.

QEXPECT_FAIL a test which relies on QCursor::setPos, which is currently
unimplemented for qpa (QTBUG-20753).

Change-Id: I72412476afc7e52ccb6cab4306ff791b7e7d8d93
Reviewed-on: http://codereview.qt.nokia.com/3118
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed tst_qeventloop and removed CONFIG+=insignificant_test
Rohan McGovern [Tue, 2 Aug 2011 02:05:21 +0000 (12:05 +1000)]
test: fixed tst_qeventloop and removed CONFIG+=insignificant_test

Throwing C++ exceptions through the event loop doesn't work if the Glib
event loop is used, so conditionally skip that part of the test.

Change-Id: Ic27ebf4eb75bd1cf7c7e35f371f29bcfc0e1844a
Reviewed-on: http://codereview.qt.nokia.com/2471
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
13 years agotest: skipped unstable portion of tst_qcssparser on qpa
Rohan McGovern [Thu, 18 Aug 2011 04:14:41 +0000 (14:14 +1000)]
test: skipped unstable portion of tst_qcssparser on qpa

This test unstably fails because font lookup is somewhat broken for qpa.

Task-number: QTBUG-20986
Change-Id: Id4ebd35e979d8837d32b58e5ed9c1df3ac15827a
Reviewed-on: http://codereview.qt.nokia.com/3130
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: mark tst_qrawfont as expected failure on qpa
Rohan McGovern [Wed, 17 Aug 2011 23:24:09 +0000 (09:24 +1000)]
test: mark tst_qrawfont as expected failure on qpa

The necessary font handling code for qrawfont currently seems to be
unimplemented for all qpa backends.

Task-number: QTBUG-20976
Change-Id: I2b5c511936892e2754c0ee809b7a558f44d1d132
Reviewed-on: http://codereview.qt.nokia.com/3116
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed XPASS from tst_qstatictext on qpa
Rohan McGovern [Wed, 17 Aug 2011 23:40:55 +0000 (09:40 +1000)]
test: fixed XPASS from tst_qstatictext on qpa

These tests were written to compare two different methods of drawing
text, to ensure the result was the same.  However, if _both_ methods
turned out to be complete no-ops, the test would unexpectedly pass, as
it never verified that anything was painted.  Add additional
verification steps and QEXPECT_FAIL them on qpa for now.

Task-number: QTBUG-20977

Change-Id: I1ce1b7c2bcd683fc9eeaeb8d1483268e56f5cf08
Reviewed-on: http://codereview.qt.nokia.com/3117
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: mark tst_qsystemtrayicon as expected failure for qpa
Rohan McGovern [Thu, 18 Aug 2011 00:53:22 +0000 (10:53 +1000)]
test: mark tst_qsystemtrayicon as expected failure for qpa

QSystemTrayIcon is unimplemented for qpa.

Task-number: QTBUG-20978
Change-Id: I63703b96e3d4572bae722120774de1565d475414
Reviewed-on: http://codereview.qt.nokia.com/3119
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: mark tst_qtextlayout as insignificant for qpa, xcb
Rohan McGovern [Thu, 18 Aug 2011 01:07:42 +0000 (11:07 +1000)]
test: mark tst_qtextlayout as insignificant for qpa, xcb

This autotest segfaults in this configuration.

Task-number: QTBUG-20979
Change-Id: I7f038416d9333b690695f48e4ad01d52767f45cd
Reviewed-on: http://codereview.qt.nokia.com/3120
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotests: disabled failing qsharedmemory, qsystemsemaphore tests
Rohan McGovern [Thu, 18 Aug 2011 01:16:54 +0000 (11:16 +1000)]
tests: disabled failing qsharedmemory, qsystemsemaphore tests

The `lackey' helper app was disabled by
ccd5228a9380fbfa308a57365e4075f90010da00, but the tests which depend on
it weren't disabled - so, of course, they fail.

None of these tests will work until the circular dependency is fixed
(the tests are in qtbase and they depend on qtscript which depends on
qtbase).

Change-Id: I8e41b4182f5ea57a71ec810a30a21ba1c7217db3
Reviewed-on: http://codereview.qt.nokia.com/3122
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed failure of tst_qhostinfo
Rohan McGovern [Thu, 18 Aug 2011 02:53:08 +0000 (12:53 +1000)]
test: fixed failure of tst_qhostinfo

Doing an async exit of the test event loop is unsafe - it means that
a call to exitLoop may be left pending from one testfunction, causing
future testfunctions to fail.  This in fact was happening for the
multipleDifferentLookups testfunction, which was running the event loop
for two milliseconds at a time until a certain amount of lookups was
done.  It was common for the loop to timeout after the lookup had
completed but before the async exitLoop had been processed.

Make it simple, do a synchronous exitLoop.

Change-Id: I2ffe6989bddc091ddd42b218a75f7a8ff160cf53
Reviewed-on: http://codereview.qt.nokia.com/3124
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: marked tst_macgui as insignificant
Rohan McGovern [Thu, 18 Aug 2011 04:03:19 +0000 (14:03 +1000)]
test: marked tst_macgui as insignificant

This autotest sometimes passes and sometimes fails, making its result
insignificant for the purpose of detecting regressions.

Task-number: QTBUG-20984
Change-Id: I1454649384b60501be0bec238dfb18cfc85d5f54
Reviewed-on: http://codereview.qt.nokia.com/3129
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: mark tst_qcombobox as expected failure for qpa
Rohan McGovern [Thu, 18 Aug 2011 03:51:55 +0000 (13:51 +1000)]
test: mark tst_qcombobox as expected failure for qpa

This test fails on qpa because it uses QCursor::setPos, which is
unimplemented.

Task-number: QTBUG-20753
Change-Id: I8b77261e9ddfa8f57cebdbd83c93a367a8cf8bea
Reviewed-on: http://codereview.qt.nokia.com/3128
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotests: mark expected failures in qsslsocket_onDemandCertificates
Rohan McGovern [Thu, 18 Aug 2011 03:47:38 +0000 (13:47 +1000)]
tests: mark expected failures in qsslsocket_onDemandCertificates

Task-number: QTBUG-20983
Change-Id: I5db2a92352037721802c127f2b47b52a514e0bfc
Reviewed-on: http://codereview.qt.nokia.com/3127
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: marked tst_qhttpnetworkconnection as insignificant
Rohan McGovern [Thu, 18 Aug 2011 03:07:12 +0000 (13:07 +1000)]
test: marked tst_qhttpnetworkconnection as insignificant

This test crashes sometimes (but not always), making its result
insignificant for the purpose of detecting regressions.

Task-number: QTBUG-20981
Change-Id: I65e9c449ef342fad17be2364964774f229970aaa
Reviewed-on: http://codereview.qt.nokia.com/3125
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: marked tst_qsocketnotifier failures as expected
Rohan McGovern [Thu, 18 Aug 2011 03:26:41 +0000 (13:26 +1000)]
test: marked tst_qsocketnotifier failures as expected

Task-number: QTBUG-20982
Change-Id: Ie53ea9733dc357176ec829d3df971760c49afdbd
Reviewed-on: http://codereview.qt.nokia.com/3126
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoStabilize autotests using QTest::qWaitForWindowShown on non-X11.
Rohan McGovern [Wed, 17 Aug 2011 05:40:46 +0000 (15:40 +1000)]
Stabilize autotests using QTest::qWaitForWindowShown on non-X11.

X11 is currently the only platform with a "real" implementation of
QTest::qWaitForWindowShown.  All others merely process events for some
fixed interval, and assume that this is sufficient for the window to be
placed.  In practice, the current interval is too short for slower
machines.

Change-Id: I956cd747d0b30577f5072a9a08da88dabc76906c
Reviewed-on: http://codereview.qt.nokia.com/3060
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
13 years agotest: mark tst_qwindowsurface as expected failure on qpa
Rohan McGovern [Thu, 18 Aug 2011 01:30:32 +0000 (11:30 +1000)]
test: mark tst_qwindowsurface as expected failure on qpa

This test fails on qpa because QPixmap::grabWindow is not implemented
for that platform.

Task-number: QTBUG-20863
Change-Id: I19afdac231922113c1b491dee27c2ea91e121b85
Reviewed-on: http://codereview.qt.nokia.com/3123
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: fixed failure of tst_qgridlayout on small screens for non-QWS
Rohan McGovern [Wed, 17 Aug 2011 05:43:36 +0000 (15:43 +1000)]
test: fixed failure of tst_qgridlayout on small screens for non-QWS

This test will fail if the window manager doesn't give the widget the
geometry it requested.  The test was verifying this precondition, but
only on QWS.  It doesn't make sense to limit this check to QWS,
as  other platforms can have small screens too.

Change-Id: I3fec905c28ac2f85ebfd621f84f2269a673e318e
Reviewed-on: http://codereview.qt.nokia.com/3061
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agotest: mark qlistview as insignificant for qpa, xcb
Rohan McGovern [Wed, 17 Aug 2011 06:12:56 +0000 (16:12 +1000)]
test: mark qlistview as insignificant for qpa, xcb

The test fails on some qpa, xcb configurations, but not others.
The difference between the passing and failing configurations is
unknown.

Task-number: QTBUG-20956
Change-Id: I0dc7c3e598ce1116ef5f2280d9285dda82f14f10
Reviewed-on: http://codereview.qt.nokia.com/3064
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoWhen asking for relations, don't crash on children that don't return an interface.
Frederik Gladhorn [Wed, 18 May 2011 16:20:38 +0000 (18:20 +0200)]
When asking for relations, don't crash on children that don't return an interface.

Reviewed-by: Jan-Arve
(cherry picked from commit a816cb0d26ebcef54e9e61c72455509edf6c44b9)

Change-Id: I8fed57eb0dfd5b67dee440b19c0ad5b9d7b3ae2d
Reviewed-on: http://codereview.qt.nokia.com/3020
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoReport an error when the version header can't be written
Lincoln Ramsay [Tue, 9 Aug 2011 05:44:41 +0000 (15:44 +1000)]
Report an error when the version header can't be written

If sync.profile points to a location that does not exist in the
%modules section, the version header cannot be written.

Report the error clearly so this problem can be identified.

Change-Id: Ib681087f46362487ffb621221d33cf9b7e54df2f
Reviewed-on: http://codereview.qt.nokia.com/2761
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
13 years agotest: skip tst_QMenu::pushButtonPopulateOnAboutToShow() for picky WM
Rohan McGovern [Fri, 12 Aug 2011 04:00:38 +0000 (14:00 +1000)]
test: skip tst_QMenu::pushButtonPopulateOnAboutToShow() for picky WM

We are trying to test the case of having a widget right next to the edge
of the screen, but the window manager is likely to forbid this geometry
in many cases.  When this happens, we can't continue the test.

Change-Id: I6bce2263bdf444221c5303e83d70a254bbb9194c
Reviewed-on: http://codereview.qt.nokia.com/2892
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoRemove more inconsistencies with invisible.
Frederik Gladhorn [Wed, 18 May 2011 19:46:26 +0000 (21:46 +0200)]
Remove more inconsistencies with invisible.

Visible status should not influence child count and
other properties.

Reviewed-by: Jan-Arve
(cherry picked from commit b6a6953d21a95c402e8a5010c1ea5131509eeea3)

Change-Id: I854349bfe48ab3d81bb9eee284965461b1e66aef
Reviewed-on: http://codereview.qt.nokia.com/3019
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoQAccessibleToolButton::text should return accessibleName if set.
Frederik Gladhorn [Thu, 5 May 2011 16:51:59 +0000 (18:51 +0200)]
QAccessibleToolButton::text should return accessibleName if set.

This was most likely a copy and paste error.

Reviewed-by: Denis Dzyubenko
(cherry picked from commit e29ef45e404dbe888c0848eb28317a10b2aff768)

Change-Id: I55dec5b9d101f9015f97cf453dc804d3cc22db8d
Reviewed-on: http://codereview.qt.nokia.com/3018
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoRemove stray semicolon.
Frederik Gladhorn [Thu, 5 May 2011 16:50:35 +0000 (18:50 +0200)]
Remove stray semicolon.

Reviewed-by: TrustMe
(cherry picked from commit f045367df74fbb5befeef81afa9102d0a6e59d54)

Change-Id: Idcdb0115606447d74a49f2dd1101ad0ad7745db0
Reviewed-on: http://codereview.qt.nokia.com/3017
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoChanging cursor position in all boundaries
José Millán Soto [Mon, 6 Jun 2011 13:03:09 +0000 (15:03 +0200)]
Changing cursor position in all boundaries

Merge-request: 1242
Reviewed-by: Harald Fernengel <harald.fernengel@nokia.com>
(cherry picked from commit 97c59df43d821e8e1784749e72f8ee7f90d46da2)

Change-Id: Iccb872281a443e57ff3e492911490a8d7495bbdc
Reviewed-on: http://codereview.qt.nokia.com/3004
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoConfigure: Set separate_debug_info for all modules
Kai Koehne [Mon, 15 Aug 2011 13:36:08 +0000 (15:36 +0200)]
Configure: Set separate_debug_info for all modules

separate_debug_info was previously stored in .qmake.cache, and
therefore only affected qtbase. Store it as a QT_CONFIG setting instead,
and add it to CONFIG for all Qt plugins and modules.

Change-Id: I940c8cb30f1c42c85f4d0342e6a482f20677ff04
Reviewed-on: http://codereview.qt.nokia.com/2975
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
13 years agoHTTP internals: send password even if no username is set
Robert Hogan [Mon, 15 Aug 2011 08:43:43 +0000 (10:43 +0200)]
HTTP internals: send password even if no username is set

Setting only a password (no username) for HTTP requests does not
result in the password being sent.
Only cancel authentication if neither a username nor a password is set.
Requiring a username was preventing user-less logins.

Merge-request: 1250
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Task-number: QTBUG-15566
(cherry picked from commit 6057909d2b73c2c3aa01a0e9216714ef07fb652f)

Change-Id: I23a52362e3e8cf114219accca2b548ceb9dccff7
Reviewed-on: http://codereview.qt.nokia.com/2940
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
13 years agoMake QThread::sleep/msleep/usleep public.
David Faure [Mon, 15 Aug 2011 11:43:45 +0000 (13:43 +0200)]
Make QThread::sleep/msleep/usleep public.

Merge-request: 43
Reviewed-by: olivier
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: Ic5e3ce8f49daf83665865f89fa9fd3488cc5b349
Reviewed-on: http://codereview.qt.nokia.com/2959
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoAdd flag for non-recursive lookup of child qobject(s)
David Faure [Mon, 15 Aug 2011 11:24:23 +0000 (13:24 +0200)]
Add flag for non-recursive lookup of child qobject(s)

Merge-request: 40
Reviewed-by: olivier
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
Change-Id: I1194ba0d8bba92ece3132171e230cece341ec127
Reviewed-on: http://codereview.qt.nokia.com/2957
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
13 years agoFocusScope's focusItem must always be a descendent
Alan Alpert [Mon, 15 Aug 2011 03:44:44 +0000 (13:44 +1000)]
FocusScope's focusItem must always be a descendent

Task-number: QTBUG-20699
Reviewed-by: Michael Brasser
Change-Id: Iaaaabaabaabaabaabaaaaaffaaaeaaaaaaaacaaa
(cherry picked from commit 0ee51351894296df7328f206e444ece262692f3f)
Reviewed-on: http://codereview.qt.nokia.com/2931
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>