Jean-Philippe Andre [Thu, 28 Sep 2017 06:43:28 +0000 (15:43 +0900)]
eo: Allow efl_reuse to be called with a parent
If an object still has a parent inside the del intercept, we shouldn't
reset the "parent_sunk" flag. This would indeed break logic as
parent_sunk == false implies that a parent was never set, which means
the parent must be null. Right now this case isn't used but it can be
imagined with caches of evas objects (they should remain parented to
their evas).
@fix
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 06:23:05 +0000 (15:23 +0900)]
ecore wl2 - fix null checing of drag offer - coverity
fix CID 1378629
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 04:58:08 +0000 (13:58 +0900)]
ecore evas - wayland - avoid divide by 0 if height is 0
fixes CID 1379247
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 04:39:35 +0000 (13:39 +0900)]
elm widget - fix possible null ptr access found by coverity
_propagate_event_legacy checked event_flags ptr for null then just
derefs it anyway... so check everywhere. fixes CID 1379920
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 03:29:46 +0000 (12:29 +0900)]
efl ui focus - fix coverity complaints about derfer before null check
indeed there was a child cnull check after dereferencing the child...
so check completely. fix CID 1379925
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 03:17:44 +0000 (12:17 +0900)]
efl ui win - quieten coverity complaint about dead code
the count ?: 1 check is pointless as count is already checked above.
make it clearer that it's > 0 and remove the ? check. silence for
coverity CID 1380542
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 03:08:16 +0000 (12:08 +0900)]
efl ui text - remove logically dead code
it is indeed pointless code. fix coverity CID 1380544
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 02:30:28 +0000 (11:30 +0900)]
edje - fix check return of _edje_fetch
fixes CID 1381326
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 00:16:02 +0000 (09:16 +0900)]
efl ui text - fix resource leak of strbuf and pointless buffer code
edje_object_part_text_style_user_push() doesnt need you to
stringshare_add a string... some other code did it because it "gets"
the string from an obj that might free/delete the string on push etc.
or before so it keeps a copy but then it stringshare_del's it
anyway... the _textpath_ellipsis_set() code creates a trsbuf that
wasn't freed if enabled was false and it never stringshare_del'd the
string is stringshare_added... all of this was pointless code anyway.
you could just pass the constant string directly.
fixes CID 1380543
Carsten Haitzler (Rasterman) [Thu, 28 Sep 2017 00:08:44 +0000 (09:08 +0900)]
evas font loading - fix possible divide by 0 when font size is 0
fix coverity CID 1381446
Jean-Philippe Andre [Thu, 28 Sep 2017 03:25:19 +0000 (12:25 +0900)]
eo: Fix unnecessary ERR logs with eo_debug
efl_data_scope_safe_get() is often used to assert that an object is of a
certain type, but assuming it may be NULL or not of the required type.
This means that encountering an invalid type is an error handled by the
caller (we return NULL), and shouldn't print out extra ERR() logs.
This fixes issues with E run under eo_debug. E's code was safe as it's
using evas_object_smart_data_get() and verifies whether the returned
value is NULL (which is expected for a rectangle, for instance).
@fix
Jean-Philippe Andre [Thu, 28 Sep 2017 02:57:51 +0000 (11:57 +0900)]
tests: Fix leak of input event & devices
After the previous patch, the caller of efl_input_dup() clearly owns the
reference on the returned object, which means she must absolutely delete
or unref if manually.
Note that the previous patch changed the bug from use of invalid eo
pointer to leaking of objects. But the only way to support bindings with
something like dup() is to ensure we give a ref to the caller, and thus
the parent should be null.
Note: eo_debug was used extensively to reach this point.
Jean-Philippe Andre [Thu, 28 Sep 2017 02:27:56 +0000 (11:27 +0900)]
evas: Fix dangling references with input devices
This solves issues with efl_input_dup() which didn't properly give a
reference to the caller, resulting in dangling eo ids.
Note: This may trigger leaks (instead of invalid refs), but this now
actually reflects the meaning of @owned. This should work with bindings
and C API users should know to call efl_unref().
This patch is the reason for the previous improvements on eo_debug.
@fix
Jean-Philippe Andre [Thu, 28 Sep 2017 01:25:18 +0000 (10:25 +0900)]
eo_debug: Also print out the current backtrace
We can't use EINA_LOG_BACKTRACE=1 for that as eo_lifecycle itself prints
out ERR messages for its backtrace dump.
Jean-Philippe Andre [Wed, 27 Sep 2017 05:14:58 +0000 (14:14 +0900)]
eo_debug: Enable logging of all ref/unref
This is done via the syntax (not documented yet):
EO_LIFECYCLE_DEBUG=N:<class names>
Where N is:
1. new/free
2. new/free/ref/unref
3. new/free/ref/unref/reuse
@feature
jiin.moon [Wed, 27 Sep 2017 08:28:59 +0000 (17:28 +0900)]
evas : Improve the performance by reusing map surface
Summary:
If object just has update of map point without other changes included child,
the map surface can be reused.
Reviewers: jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D5181
Jean-Philippe Andre [Wed, 27 Sep 2017 02:46:52 +0000 (11:46 +0900)]
tests: Improve test case for win/evas event refeed
Amitesh Singh [Thu, 28 Sep 2017 03:19:37 +0000 (12:19 +0900)]
intv slider: use scope_get instead in finalize()
Cedric BAIL [Wed, 27 Sep 2017 23:32:58 +0000 (16:32 -0700)]
eio: convert Efl.Io.Manager.stat() to return Eina_Future.
Cedric BAIL [Wed, 27 Sep 2017 23:30:31 +0000 (16:30 -0700)]
eina: add an helper to setup Eina_Value structure description.
This is particularly useful on system like Windows who doesn't allow
setting pointer at compile time in static const structure.
jiin.moon [Wed, 27 Sep 2017 18:51:44 +0000 (11:51 -0700)]
emile: unmap the memory for image file after decode.
Summary:
In case of emile, unmap the memory of the image file when the image file is closing.
But closing of image file happen when the image is flushed from the cache, so the
mapped memory of image file remain for long period of time with no benefit (If it is
in cache, it won't get decoded again). So I think we don't need to keep the mapped
memory of image file.
Test Plan: self
Reviewers: cedric, jpeg, jypark
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D5210
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 26 Sep 2017 22:21:12 +0000 (15:21 -0700)]
elementary: avoid segfault when getting focus due to an infinite recursion.
This was two line switched and setting the callbacks on the wrong object.
Cedric BAIL [Tue, 26 Sep 2017 18:13:06 +0000 (11:13 -0700)]
ecore: we can actually inherit from Efl.Object, just not in the first position.
Vincent Torri [Sat, 23 Sep 2017 16:02:44 +0000 (18:02 +0200)]
eina: remove EFL_HAVE_WIN32_THREADS define as it is unused since winpthread is used
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 26 Sep 2017 17:09:59 +0000 (10:09 -0700)]
elementary: remove useless fprintf.
Cedric BAIL [Tue, 26 Sep 2017 17:09:37 +0000 (10:09 -0700)]
elementary: actually implement the terminate event.
Cedric BAIL [Tue, 26 Sep 2017 17:08:01 +0000 (10:08 -0700)]
ecore: we need a different event for tracking the lifecycle of the main loop.
If the main loop is destroyed a lot of companion information might already
have been so relying on EFL_EVENT_DEL might be way to late in the shutdown
process. terminate will be triggered as soon as the process of shutting down
is started, so all the data are still valid and have not been destroyed yet.
Cedric BAIL [Tue, 26 Sep 2017 17:07:29 +0000 (10:07 -0700)]
elementary: don't crash if API is called after shutdown.
Cedric BAIL [Tue, 26 Sep 2017 16:56:06 +0000 (09:56 -0700)]
elementary: restore input propagation and destroy array properly.
Derek Foreman [Tue, 26 Sep 2017 16:39:19 +0000 (11:39 -0500)]
efl_wl: Stop queuing buffer release events
This was an optimization that caused more pain than benefit in the
long term. Weston no longer does it, so we're just following suit.
Jean-Philippe Andre [Tue, 26 Sep 2017 10:44:36 +0000 (19:44 +0900)]
examples: Fix C++ bg example
This is not nice yet... part API needs to be improved in C++.
Jean-Philippe Andre [Tue, 26 Sep 2017 10:33:56 +0000 (19:33 +0900)]
elm: win part EO files are public
Jean-Philippe Andre [Tue, 26 Sep 2017 09:54:43 +0000 (18:54 +0900)]
Youngbok Shin [Tue, 26 Sep 2017 11:33:10 +0000 (14:33 +0300)]
evas textblock: use main font's ascent/descent as minimum value
Summary:
The patch will adjust ascent/descent with considering main font's ascent/descent
as minimum value. Actually, this patch re-apply D5217 with resolving linegap issue
on the _layout_format_ascent_descent_adjust() function.
@fix
Test Plan: Put a text which will load smaller font. And put a text which will load primary font.
Reviewers: raster, cedric, herdsman, jpeg
Differential Revision: https://phab.enlightenment.org/D5227
Jean-Philippe Andre [Tue, 26 Sep 2017 09:12:42 +0000 (18:12 +0900)]
win: Remove invalid callbacks
Faulty commit (guess who?):
596dba5fe5fa8b4101f50bbed66c29c791a2572f
See also
d567faa7787afb3d478f1c857cb28ab4fa0e5fc3
Finally make check works again. That was... a painful lot of patches to
fix.
Jean-Philippe Andre [Tue, 26 Sep 2017 09:11:38 +0000 (18:11 +0900)]
Revert "Fix infinite recursion for legacy + efl ui win events"
This reverts commit
d567faa7787afb3d478f1c857cb28ab4fa0e5fc3.
This is not trying to fix the root cause for the infinite loop.
Jean-Philippe Andre [Tue, 26 Sep 2017 08:56:56 +0000 (17:56 +0900)]
elm: Fix shutdown of atspi (unregister handlers)
@fix
Jean-Philippe Andre [Tue, 26 Sep 2017 08:18:02 +0000 (17:18 +0900)]
ecore: Reset do_quit when ecore shuts down
After ecore_shutdown the main loop is dead, so the flag do_quit can be
safely reset to 0. This will fix issues with cycles of
elm_init/shutdown. This fixes:
CK_FORK=no tests/elementary/elm_suite elm_win
This patch relies on a few of the previous patches which ensure that
ecore is well shut down.
@fix
Jean-Philippe Andre [Tue, 26 Sep 2017 08:14:19 +0000 (17:14 +0900)]
elm: Delete atspi root object on shutdown
Ugly implementation but this will do.
@fix
Jean-Philippe Andre [Tue, 26 Sep 2017 08:00:27 +0000 (17:00 +0900)]
eo: Fix crashes with call cache after init cycle
It's not enough to check the init generation count, if the cache data is
not reset properly.
This patch adds safety in two ways:
1. Actually reset the op call cache when we detect a new generation
2. Verify that we don't return NULL function pointer
The 1st point is absolutely necessary, 2nd is optional (extra cost of
one if()).
@fix
Jean-Philippe Andre [Tue, 26 Sep 2017 07:32:29 +0000 (16:32 +0900)]
ecore_ipc: Unregister log domain on shutdown
An old comment mentioned that this was explicitely not unregistered, but
I believe the comment isn't valid since ecore_event_type_flush() was
introduced.
Jean-Philippe Andre [Tue, 26 Sep 2017 07:21:27 +0000 (16:21 +0900)]
elm: Fix elm_shutdown
ecore could not shut down properly in an elm_init()/elm_shutdown()
cycle, with 7 remaining references, all because of a typo.
This should help @cedric as well
Jean-Philippe Andre [Tue, 26 Sep 2017 06:00:53 +0000 (15:00 +0900)]
win: Avoid calling same function twice on shutdown
This avoids calling:
ecore_evas_callback_delete_request_set
ecore_evas_callback_resize_set
twice when deleting a window. Also adds safety over sd->ee.
Jean-Philippe Andre [Tue, 26 Sep 2017 05:26:56 +0000 (14:26 +0900)]
evas: Fix shutdown of async cmd cache
The incomplete reset (array to NULL but max not reset) triggers errors
in evas_thread_queue_append() where eina_inarray_grow() returns NULL.
This shows up in:
CK_FORK=no elm_suite
@fix
Jean-Philippe Andre [Tue, 26 Sep 2017 05:09:14 +0000 (14:09 +0900)]
elm: Properly unregister providers on shutdown
This should fix some errors in make check with CK_FORK=no
Test:
<efl/build>/src$ CK_FORK=no ./tests/elementary/elm_suite elm_config
@fix
Jean-Philippe Andre [Tue, 26 Sep 2017 03:20:43 +0000 (12:20 +0900)]
win: Avoid safety ERR in efreet
This is an error happening in make check. Annoying but mostly harmless.
Jean-Philippe Andre [Tue, 26 Sep 2017 03:13:24 +0000 (12:13 +0900)]
elm: Fix module load with ELM_RUN_IN_TREE
Somehow I was seeing a ton of errors with "prefs_iface" not found in
make check. This code could not have worked since the merge of
elementary in EFL tree...
@fix
Sungtaek Hong [Tue, 26 Sep 2017 02:46:11 +0000 (11:46 +0900)]
elm_bg: rename elm_bg to Efl.Ui.Bg
Summary:
elm_bg was supposed to be used only in legacy,
but since we need a common object to be used as a background of widgets,
it is now renamed as efl_ui_bg and supports EO APIs.
Reviewers: cedric, jpeg, woohyun
Differential Revision: https://phab.enlightenment.org/D5147
Jean-Philippe Andre [Mon, 25 Sep 2017 09:47:49 +0000 (18:47 +0900)]
input: Move pointer props to Canvas
efl_input_pointer_position is defined by two classes... bad!
Fixes T6066
Lukasz Stanislawski [Mon, 25 Sep 2017 08:15:44 +0000 (17:15 +0900)]
elm: rename Elm.Interface.Atspi.Text => Efl.Access.Text
Reviewers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5167
Jean-Philippe Andre [Mon, 25 Sep 2017 07:12:28 +0000 (16:12 +0900)]
widget: Fix translation of default text parts
Note: fileselector uses this translation API
Ref T5363
Jean-Philippe Andre [Mon, 25 Sep 2017 06:47:03 +0000 (15:47 +0900)]
widget: Remove domain_part_text_translatable from EO
This removes the last remaining legacy-style part API from Widget.
I think this is redundant with the property "translatable_text"
introduced in Efl.Ui.Translatable.
Ref T5363
Jean-Philippe Andre [Mon, 25 Sep 2017 06:33:31 +0000 (15:33 +0900)]
widget: Implement translation API in layout
This moves the API entry points from Widget to Layout parts. I don't
think the other widgets support translation, but that is easy to fix.
The actual code implementation remains in elm_widget.c.
Legacy-only widgets are covered by Part_Legacy, while all EO widgets
that have text inherit from Layout (except Win but I don't think the
window title was translatable in legacy).
This removes 2/3 remaining part APIs from Widget.
Ref T5363
Jean-Philippe Andre [Fri, 22 Sep 2017 06:13:16 +0000 (15:13 +0900)]
elm: Introduce interface Efl.Ui.Translatable
This will be used to replace the part translation API in Elm.Widget. It
should work for both parts and non-parts (ie. the main text of a button,
for instance).
For now I'm taking the following approach:
- All efl_text_set/get strings are untranslatable, i.e. get() returns
the visible string, set replaces and can not be translated.
- translatable_text_set/get needs to be used to enable automatic
translation, which in turns calls efl_text_set to modify the visible
string. Thus, translatable applications will have to use
efl_ui_translatable_text_set a lot more than efl_text_set, unless
they translate strings application-side.
Note that some other frameworks take a simpler approach equivalent to
calling efl_text_set() with an already translated text. This prevents
runtime language changes of the application, unless the application
handles them specifically.
Jean-Philippe Andre [Fri, 22 Sep 2017 04:38:59 +0000 (13:38 +0900)]
widget: Add tiny doc for Efl.Ui.Widget.Part
Daniel Hirt [Tue, 26 Sep 2017 07:38:46 +0000 (10:38 +0300)]
Evas textblock: fix ascent/descent calc
This is a follow-up to
4d4401f3a60024a0762393c3984065b73927eb86.
The format line adjustment (e.g. linegap) should calculate the current
item's ascent/descent, and then update c->ascent/c->descent.
Otherwise we accumulate calculations like linegap values
ref D5217
Carsten Haitzler (Rasterman) [Tue, 26 Sep 2017 07:15:07 +0000 (16:15 +0900)]
Fix infinite recursion for legacy + efl ui win events
Daniel Zaoui [Tue, 26 Sep 2017 06:49:58 +0000 (09:49 +0300)]
Fix crash when an application wants to get the popup item class
Since elm_popup_item.eo.h is only included in elc_popup.h, the EAPI is
not well defined, resulting in a crash when, in a simple C file, the
item class is tried to be accessed.
By including the H file in elc_popup_eo.h, we make it public (as the
other item classes) and solve the EAPI issue.
Thanks @jpeg for helping me to solve this issue.
Youngbok Shin [Mon, 25 Sep 2017 09:35:23 +0000 (18:35 +0900)]
evas textblock: use primary font's size as minimum size of a line
Summary:
Textblock uses ascent, descent from primary font when there is no text.
If a text is set which need other font, Textblock uses ascent, descent from
actually loaded font. If loaded font has smaller size, text cursor and text
looks jerky in elm_entry. At least, primary font's size should be respected
as minimum size of a line for avoiding this issue.
In addition, the patch will allow negative line gap values.
@fix
Test Plan:
Put your hamburger(🍔) in Ecrire. And put an english character.
(Put a text which will load smaller font. And put a text which will load primary font.)
Reviewers: raster, cedric, herdsman, jpeg, woohyun
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D5217
Youngbok Shin [Mon, 25 Sep 2017 09:34:22 +0000 (18:34 +0900)]
evas: Add scale feature for embedded bitmap fonts.
Summary:
When evas selects a strike of embedded bitmap font,
calculate ratio and use it for scaling embedded bitmap.
@feature
Reviewers: jpeg, tasn, woohyun, raster, herdsman
Reviewed By: raster
Subscribers: charlesmilette, Francesco149, cedric
Differential Revision: https://phab.enlightenment.org/D2713
Felipe Magno de Almeida [Tue, 26 Sep 2017 00:57:25 +0000 (21:57 -0300)]
eolian-cxx: Fix compilation errors with new any_value_ptr and mstring types
Cedric BAIL [Mon, 25 Sep 2017 22:52:36 +0000 (15:52 -0700)]
elementary: migrate elementary_config to use the new macro with lifecycle support.
Cedric BAIL [Mon, 25 Sep 2017 22:51:19 +0000 (15:51 -0700)]
elementary: provide a new initialization macro that support lifecycle.
EFL_MAIN_EX require efl_main, efl_resume, efl_pause and efl_terminate
to be working. Quicklaunch support added too.
Cedric BAIL [Mon, 25 Sep 2017 22:48:53 +0000 (15:48 -0700)]
elementary: provide and implement lifecycle event on the window.
pause event means that the window is not visible anymore to any user.
resume is triggered when the window became visible again or just
became visible again.
Cedric BAIL [Mon, 25 Sep 2017 22:47:00 +0000 (15:47 -0700)]
ecore: start adding life cycle support to Efl.Loop.
pause event is triggered when no more windows are visible to any user.
resume event is triggered when a window make the application visible
for the first time to the user after a pause or when starting the application.
Daniel Hirt [Mon, 25 Sep 2017 09:49:11 +0000 (12:49 +0300)]
Ui text: use proper Efl.Text API to set text
Fixes error message during initialization.
Daniel Hirt [Mon, 25 Sep 2017 09:45:12 +0000 (12:45 +0300)]
Canvas text: don't generate legacy for new api
This is part of the new Canvas.Text.
Daniel Hirt [Mon, 25 Sep 2017 09:39:42 +0000 (12:39 +0300)]
Ui text: use eina_value_get and not eina_value_pget
CID 1381328
Daniel Hirt [Mon, 25 Sep 2017 09:36:14 +0000 (12:36 +0300)]
Canvas text: use eina_value_set and not eina_value_pset
CID 1381327
Carsten Haitzler (Rasterman) [Mon, 25 Sep 2017 09:21:58 +0000 (18:21 +0900)]
elm hoversel - fix alignment in ephoto
fixes T6078
@fix
Jean-Philippe Andre [Mon, 25 Sep 2017 05:02:43 +0000 (14:02 +0900)]
inwin: Fix oopsie in previous commit
Bad push! >_<
Jean-Philippe Andre [Mon, 25 Sep 2017 02:29:24 +0000 (11:29 +0900)]
inwin: Fix inwin (default content set/get/unset)
Thanks @JackDanielZ for the report!
This makes efl_content_set/get/unset APIs work on the inwin, even though
this is a legacy-only widget (at least right now).
Jean-Philippe Andre [Mon, 25 Sep 2017 02:19:49 +0000 (11:19 +0900)]
layout: Remove default content implementation
Legacy API is supposed to resolve the default content part name before
calling the EO API. Efl.Ui.Layout itself doesn't handle default content.
Jeeyong Um [Mon, 25 Sep 2017 00:24:16 +0000 (09:24 +0900)]
docs: eina_value: fix a typo
Marcel Hollerbach [Sat, 23 Sep 2017 20:23:50 +0000 (22:23 +0200)]
elm_hover: do not register itself
we are already registered as root in that manager
Marcel Hollerbach [Sat, 23 Sep 2017 19:53:26 +0000 (21:53 +0200)]
elm_widget: abort is probebly a bit too much
Carsten Haitzler (Rasterman) [Sat, 23 Sep 2017 13:44:17 +0000 (22:44 +0900)]
ecore exe - add an "isolate io"f lag for sending io to /dev/null
this is useful for security to disallow child processes access to
stdio/err of the parent process.
@feature
Cedric Bail [Fri, 22 Sep 2017 21:55:55 +0000 (14:55 -0700)]
ecore: force initialization of Efl.Io.Closer.Fd.
This will prevent closing magically fd 0 when the object is not
initialized yet.
Cedric Bail [Fri, 22 Sep 2017 21:37:25 +0000 (14:37 -0700)]
ecore_evas: skip deleted Ecore_Evas while searching for a general animator source.
Daniel Kolesa [Fri, 22 Sep 2017 20:50:50 +0000 (22:50 +0200)]
eolian cxx: rename generic_value to any_value
Daniel Kolesa [Fri, 22 Sep 2017 18:58:36 +0000 (20:58 +0200)]
eolian: add tests for builtin queries
Daniel Kolesa [Fri, 22 Sep 2017 18:47:39 +0000 (20:47 +0200)]
elua: bind new eolian type builtin API
Daniel Kolesa [Fri, 22 Sep 2017 18:38:17 +0000 (20:38 +0200)]
eolian: add a way to query the builtin type of a type
Daniel Kolesa [Fri, 22 Sep 2017 18:25:31 +0000 (20:25 +0200)]
eolian: add any_value_ptr
Because pointer Eina_Values and value Eina_Values have slightly
different semantics (when it comes to resource management) it's
better to split them.
Daniel Kolesa [Fri, 22 Sep 2017 18:16:06 +0000 (20:16 +0200)]
eolian: rename generic_value to any_value
Daniel Kolesa [Fri, 22 Sep 2017 16:08:36 +0000 (18:08 +0200)]
eolian: remove leftover code
Daniel Kolesa [Fri, 22 Sep 2017 16:01:15 +0000 (18:01 +0200)]
eolian: remove static_array and terminated_array
These types are of questionable value and the API was not entirely
thought out - remove for now, and if a legitimate use is found
later, they may be readded (with a better API), but typically it
seems best to redesign the bad APIs around safe containers...
Daniel Kolesa [Fri, 22 Sep 2017 15:46:02 +0000 (17:46 +0200)]
eolian: merge REGULAR and COMPLEX types
Daniel Kolesa [Fri, 22 Sep 2017 15:10:42 +0000 (17:10 +0200)]
eolian: add mstring
This is a new type representing a mutable string (no const).
Regular strings cannot be made mutable with @owned because
they might be hidden behind typedefs.
Daniel Kolesa [Fri, 22 Sep 2017 14:08:56 +0000 (16:08 +0200)]
eo: make more freefuncs implicit
Mike Blumenkrantz [Fri, 22 Sep 2017 13:54:37 +0000 (09:54 -0400)]
ecore-x: reject successive MappingNotify events if they are identical
in some cases loading an xmodmap on enlightenment startup can trigger an infinite
number of identical events which hard locks the xserver for a very, very long time
@fix
Vincent 'vtorri' Torri [Fri, 22 Sep 2017 10:06:10 +0000 (05:06 -0500)]
EFL For WIN32: Replace HAVE_EVIL define with _WIN32
Lauro Moura [Fri, 22 Sep 2017 07:57:06 +0000 (09:57 +0200)]
ecore: Avoid using newer check.h functions.
Summary:
The ptr_null/nonnull were added in the 0.11 version of libcheck. The
required version in configure.ac is 0.9.10 (some distros still use this
old one).
Reviewers: felipealmeida, stefan_schmidt
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5220
Andy Williams [Thu, 21 Sep 2017 11:24:51 +0000 (12:24 +0100)]
elm_code: respect event hold for key_down
Jean-Philippe Andre [Thu, 21 Sep 2017 03:25:02 +0000 (12:25 +0900)]
layout: Fix slider label using proper part type
This relies on the new edje API that gives us the exact type of a part.
This fixes the shortcomings of edje_edit_part_type_get() and returns a
proper Text part type for efl_part(slider, "elm.units.max").
See previous commits:
"edje: Add part_type_get API"
"elm: Split off text and content for efl_part"
Jean-Philippe Andre [Thu, 21 Sep 2017 03:23:29 +0000 (12:23 +0900)]
edje: Add part_type_get API
For now I made this EO-only but this definitely could be expose in
legacy API as well.
This simply gives exact information about the type of part, after doing
a recursive search. Edit Edit doesn't do a recursive search, only a
direct one, which can yield invalid results (eg. RECT or NONE instead of
TEXT in case of "elm.units.max" for a slider).
@feature
Jean-Philippe Andre [Wed, 20 Sep 2017 09:05:03 +0000 (18:05 +0900)]
hover: Fix hover parts usage
The string comparison was invalid for full part names. It worked with
the aliases, by chance, not by design.
This got broken by
eee60abbcf but using full part names from the
application side was already broken before that.
@fix
Jean-Philippe Andre [Wed, 20 Sep 2017 06:44:37 +0000 (15:44 +0900)]
elm: Remove eo.h header from Makefile
Fixes make distcheck
Jean-Philippe Andre [Wed, 20 Sep 2017 06:16:12 +0000 (15:16 +0900)]
elm: Resolve part alias in legacy APIs only
This fixes make check.
Jean-Philippe Andre [Wed, 20 Sep 2017 02:16:17 +0000 (11:16 +0900)]
elm: Remove range "span_size" API in EO
Reasons:
- This API has been confused with the min size of the widget, resulting
in badly laid out applications.
- The EO API was not very nice (Range is about numbers, the Gfx size
hint in a part is really ugly).
While I understand the value of this API and how it can be used in
scalable applications, it is in fact not absolutely necessary.
Alternatively to that span size, the widget min size can already be
defined from the application side, or the widget can simply be expanded
to fill in its parent.
This can obviously be reinstated later if the need arises for EO. For
now, keep this feature as legacy-only.