platform/upstream/libSkiaSharp.git
10 years agoARM Skia NEON patches - 21 - new NEON S32_D565_Opaque
commit-bot@chromium.org [Fri, 20 Sep 2013 15:38:49 +0000 (15:38 +0000)]
ARM Skia NEON patches - 21 - new NEON S32_D565_Opaque

BlitRow565: NEON version of S32_D565_Opaque

Here's a new implementation of S32_D565_Opaque in NEON. It
improves dramatically the speed compared to S32A_D565_Opaque.

Here are the benchmark results (speedup vs. existing NEON):

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | +130%     | +139%      |
+-------+-----------+------------+
| 2     | +65,2%    | +51%       |
+-------+-----------+------------+
| 4     | -25,5%    | +10,2%     |
+-------+-----------+------------+
| 8     | +63,8%    | +32,1%     |
+-------+-----------+------------+
| 16    | +110%     | +49,2%     |
+-------+-----------+------------+
| 64    | +153%     | +123,5%    |
+-------+-----------+------------+
| 256   | +151%     | +144,7%    |
+-------+-----------+------------+
| 1024  | +272%     | +157,2%    |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22351006

git-svn-id: http://skia.googlecode.com/svn/trunk@11415 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd sk_calloc. Remove SkMemory_stdlib, which seems unused.
mtklein@google.com [Fri, 20 Sep 2013 14:31:45 +0000 (14:31 +0000)]
Add sk_calloc.  Remove SkMemory_stdlib, which seems unused.

I'm seeing basically no difference between malloc + bzero and calloc on my desktop, but on a Galaxy Nexus calloc is never slower, and significantly faster once the allocation size becomes large, both for allocation and for _reading_.

BUG=skia:1662
R=reed@google.com

Review URL: https://codereview.chromium.org/24251008

git-svn-id: http://skia.googlecode.com/svn/trunk@11414 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 20 Sep 2013 07:01:33 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11411 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoYet more testimagefilters and imagefilterscropped rebaselines.
senorblanco@chromium.org [Fri, 20 Sep 2013 01:57:40 +0000 (01:57 +0000)]
Yet more testimagefilters and imagefilterscropped rebaselines.

TBR=bungeman

Review URL: https://codereview.chromium.org/24244007

git-svn-id: http://skia.googlecode.com/svn/trunk@11410 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agosilence the error test to be a better citizen
commit-bot@chromium.org [Thu, 19 Sep 2013 22:11:38 +0000 (22:11 +0000)]
silence the error test to be a better citizen

BUG=
R=caryclark@google.com, bsalomon@google.com, tfarina@chromium.org, mtklein@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/23481012

git-svn-id: http://skia.googlecode.com/svn/trunk@11409 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix for SampleFilterFuzz compiler warning/error
robertphillips@google.com [Thu, 19 Sep 2013 22:02:37 +0000 (22:02 +0000)]
Fix for SampleFilterFuzz compiler warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@11408 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert ignore-failures changes from r11395, since the tests have been rebaselined.
senorblanco@chromium.org [Thu, 19 Sep 2013 21:25:48 +0000 (21:25 +0000)]
Revert ignore-failures changes from r11395, since the tests have been rebaselined.

TBR=epoger

Review URL: https://codereview.chromium.org/23440054

git-svn-id: http://skia.googlecode.com/svn/trunk@11407 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore testimagefilters and imagefilterscropped rebaselines.
senorblanco@chromium.org [Thu, 19 Sep 2013 21:06:10 +0000 (21:06 +0000)]
More testimagefilters and imagefilterscropped rebaselines.

TBR=bungeman

Review URL: https://codereview.chromium.org/23503079

git-svn-id: http://skia.googlecode.com/svn/trunk@11406 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd an even more convenient way to declare tests, with example.
mtklein@google.com [Thu, 19 Sep 2013 20:56:46 +0000 (20:56 +0000)]
Add an even more convenient way to declare tests, with example.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23828008

git-svn-id: http://skia.googlecode.com/svn/trunk@11405 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline done for gradient tests, stop ignoring the diffs
edisonn@google.com [Thu, 19 Sep 2013 20:52:37 +0000 (20:52 +0000)]
rebaseline done for gradient tests, stop ignoring the diffs

Review URL: https://codereview.chromium.org/24269009

git-svn-id: http://skia.googlecode.com/svn/trunk@11404 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline gradients (change the size so it does not chop the drawing)
edisonn@google.com [Thu, 19 Sep 2013 20:52:04 +0000 (20:52 +0000)]
rebaseline gradients (change the size so it does not chop the drawing)

BUG=

Review URL: https://codereview.chromium.org/23803012

git-svn-id: http://skia.googlecode.com/svn/trunk@11403 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline pdf expectations (part 2)
edisonn@google.com [Thu, 19 Sep 2013 20:35:50 +0000 (20:35 +0000)]
rebaseline pdf expectations (part 2)

BUG=

Review URL: https://codereview.chromium.org/24072010

git-svn-id: http://skia.googlecode.com/svn/trunk@11402 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for imagefilterscropped, testimagefilters GMs.
senorblanco@chromium.org [Thu, 19 Sep 2013 20:19:43 +0000 (20:19 +0000)]
New baselines for imagefilterscropped, testimagefilters GMs.

TBR=bungeman

Review URL: https://codereview.chromium.org/23855010

git-svn-id: http://skia.googlecode.com/svn/trunk@11401 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed warnings as error
sugoi@google.com [Thu, 19 Sep 2013 19:51:27 +0000 (19:51 +0000)]
Fixed warnings as error

BUG=
R=edisonn@google.com, rmistry@google.com

Review URL: https://codereview.chromium.org/24246006

git-svn-id: http://skia.googlecode.com/svn/trunk@11398 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline pdf expected results (caused by not writing a bad pdf object if the featur...
edisonn@google.com [Thu, 19 Sep 2013 19:19:18 +0000 (19:19 +0000)]
rebaseline pdf expected results (caused by not writing a bad pdf object if the feature is NYI)

BUG=

Review URL: https://codereview.chromium.org/24144007

git-svn-id: http://skia.googlecode.com/svn/trunk@11397 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline tilemodes_npot on IMG devices
bsalomon@google.com [Thu, 19 Sep 2013 19:01:45 +0000 (19:01 +0000)]
Rebaseline tilemodes_npot on IMG devices

git-svn-id: http://skia.googlecode.com/svn/trunk@11396 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoI'm investigating how to make the IPC transfer a bit more secure on the
commit-bot@chromium.org [Thu, 19 Sep 2013 18:40:49 +0000 (18:40 +0000)]
I'm investigating how to make the IPC transfer a bit more secure on the
skia side by adding some safety checks. This cl is about brainstorming
and proposing possible solutions for type checking at different stages.

BUG=
R=senorblanco@google.com, sugoi@google.com, scroggo@google.com, reed@android.com, senorblanco@chromium.org, mtklein@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22799007

git-svn-id: http://skia.googlecode.com/svn/trunk@11395 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd new entry point that supports fallback font selection based on language.
djsollen@google.com [Thu, 19 Sep 2013 18:22:30 +0000 (18:22 +0000)]
Add new entry point that supports fallback font selection based on language.

BUG= chromium:287995
R=reed@google.com, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/23819067

git-svn-id: http://skia.googlecode.com/svn/trunk@11394 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoexpand alias fontname test
reed@google.com [Thu, 19 Sep 2013 18:06:03 +0000 (18:06 +0000)]
expand alias fontname test

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/24198004

git-svn-id: http://skia.googlecode.com/svn/trunk@11393 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake gradients gm view size larger, as it is choping from the pained canvas.
edisonn@google.com [Thu, 19 Sep 2013 17:55:49 +0000 (17:55 +0000)]
make gradients gm view size larger, as it is choping from the pained canvas.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23851037

git-svn-id: http://skia.googlecode.com/svn/trunk@11392 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWhitespace change to trigger buildbots
epoger@google.com [Thu, 19 Sep 2013 17:51:14 +0000 (17:51 +0000)]
Whitespace change to trigger buildbots

git-svn-id: http://skia.googlecode.com/svn/trunk@11391 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd expectations/gm/ignored-tests.txt to temporarily ignore failures
epoger@google.com [Thu, 19 Sep 2013 17:41:41 +0000 (17:41 +0000)]
Add expectations/gm/ignored-tests.txt to temporarily ignore failures
BUG=skia:1600
TBR=bsalomon
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/23531070

git-svn-id: http://skia.googlecode.com/svn/trunk@11390 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agopdf: report NYI features, and fail gracefully when something is not supported in...
edisonn@google.com [Thu, 19 Sep 2013 17:36:47 +0000 (17:36 +0000)]
pdf: report NYI features, and fail gracefully when something is not supported in pdf.

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/23654036

git-svn-id: http://skia.googlecode.com/svn/trunk@11388 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement crop rect support for the merge image filter.
senorblanco@chromium.org [Thu, 19 Sep 2013 17:26:47 +0000 (17:26 +0000)]
Implement crop rect support for the merge image filter.

Note: this will require rebaselining of the imagefilterscropped and testimagefilters GMs.

R=reed@google.com

Review URL: https://codereview.chromium.org/23600047

git-svn-id: http://skia.googlecode.com/svn/trunk@11387 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoOne more try at fixing warnings
jvanverth@google.com [Thu, 19 Sep 2013 17:21:39 +0000 (17:21 +0000)]
One more try at fixing warnings

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/24276003

git-svn-id: http://skia.googlecode.com/svn/trunk@11386 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReenable GrAAHairlinePathRenderer assert w/ fix
robertphillips@google.com [Thu, 19 Sep 2013 16:36:43 +0000 (16:36 +0000)]
Reenable GrAAHairlinePathRenderer assert w/ fix

https://codereview.chromium.org/24269004/

git-svn-id: http://skia.googlecode.com/svn/trunk@11385 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoType warning fix for: Add string art GM and sample.
jvanverth@google.com [Thu, 19 Sep 2013 16:32:49 +0000 (16:32 +0000)]
Type warning fix for: Add string art GM and sample.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/24258003

git-svn-id: http://skia.googlecode.com/svn/trunk@11384 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd string art GM and sample.
jvanverth@google.com [Thu, 19 Sep 2013 15:32:22 +0000 (15:32 +0000)]
Add string art GM and sample.

BUG=279014
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23609037

git-svn-id: http://skia.googlecode.com/svn/trunk@11383 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix build warning for unused function
djsollen@google.com [Thu, 19 Sep 2013 14:40:42 +0000 (14:40 +0000)]
fix build warning for unused function

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/24240008

git-svn-id: http://skia.googlecode.com/svn/trunk@11382 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove 2 unused defines USE_CHROMIUM_SKIA and SK_BUILD_FOR_CHROMIUM
djsollen@google.com [Thu, 19 Sep 2013 14:29:12 +0000 (14:29 +0000)]
Remove 2 unused defines USE_CHROMIUM_SKIA and SK_BUILD_FOR_CHROMIUM

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23618057

git-svn-id: http://skia.googlecode.com/svn/trunk@11381 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDisable broken test on Android
djsollen@google.com [Thu, 19 Sep 2013 12:55:26 +0000 (12:55 +0000)]
Disable broken test on Android

R=caryclark@google.com

Review URL: https://codereview.chromium.org/23484057

git-svn-id: http://skia.googlecode.com/svn/trunk@11380 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate Android's FontHost to return NULL if familyName does not match
djsollen@google.com [Thu, 19 Sep 2013 12:08:40 +0000 (12:08 +0000)]
Update Android's FontHost to return NULL if familyName does not match

R=scroggo@google.com, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/23601041

git-svn-id: http://skia.googlecode.com/svn/trunk@11377 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFourth round of GPU hairline rebaselines
robertphillips@google.com [Thu, 19 Sep 2013 12:04:59 +0000 (12:04 +0000)]
Fourth round of GPU hairline rebaselines

https://codereview.chromium.org/23452046/

git-svn-id: http://skia.googlecode.com/svn/trunk@11376 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 19 Sep 2013 07:25:55 +0000 (07:25 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11375 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogm: add --ignoreTests flag
epoger@google.com [Thu, 19 Sep 2013 06:18:27 +0000 (06:18 +0000)]
gm: add --ignoreTests flag
BUG=skia:1600
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23526065

git-svn-id: http://skia.googlecode.com/svn/trunk@11374 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorevert temporary r11371
epoger@google.com [Thu, 19 Sep 2013 06:09:32 +0000 (06:09 +0000)]
revert temporary r11371
BUG=skia:1641

Review URL: https://codereview.chromium.org/24256003

git-svn-id: http://skia.googlecode.com/svn/trunk@11373 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agodisable some poppler tests due to flakiness (see bug)
epoger@google.com [Thu, 19 Sep 2013 06:04:26 +0000 (06:04 +0000)]
disable some poppler tests due to flakiness (see bug)
BUG=skia:1643
(SkipBuildbotRuns)

TBR=edisonn

Review URL: https://codereview.chromium.org/24258002

git-svn-id: http://skia.googlecode.com/svn/trunk@11372 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
epoger@google.com [Thu, 19 Sep 2013 05:25:17 +0000 (05:25 +0000)]
gm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
BUG=skia:1641

Review URL: https://codereview.chromium.org/24153020

git-svn-id: http://skia.googlecode.com/svn/trunk@11371 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThird round of GPU hairline rebaselines
robertphillips@google.com [Thu, 19 Sep 2013 02:20:46 +0000 (02:20 +0000)]
Third round of GPU hairline rebaselines

https://codereview.chromium.org/24240003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11370 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTemporarily disable assert in GrAAHairlinePathRenderer.cpp
robertphillips@google.com [Thu, 19 Sep 2013 01:07:14 +0000 (01:07 +0000)]
Temporarily disable assert in GrAAHairlinePathRenderer.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@11369 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSecond round of GPU hairline rebaselines
robertphillips@google.com [Thu, 19 Sep 2013 00:32:30 +0000 (00:32 +0000)]
Second round of GPU hairline rebaselines

https://codereview.chromium.org/24243002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11368 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFirst round of GPU hairline capping image rebaselines
robertphillips@google.com [Thu, 19 Sep 2013 00:02:06 +0000 (00:02 +0000)]
First round of GPU hairline capping image rebaselines

https://codereview.chromium.org/24238002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11367 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't reuse scratch textures update
robertphillips@google.com [Wed, 18 Sep 2013 22:33:57 +0000 (22:33 +0000)]
Don't reuse scratch textures update

https://codereview.chromium.org/23609026/

git-svn-id: http://skia.googlecode.com/svn/trunk@11366 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago"Fix" for hairline corner bugs
robertphillips@google.com [Wed, 18 Sep 2013 22:14:49 +0000 (22:14 +0000)]
"Fix" for hairline corner bugs

https://codereview.chromium.org/23708036/

git-svn-id: http://skia.googlecode.com/svn/trunk@11365 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix fontconfig backend to only cache new fonts if their outName was unique
reed@google.com [Wed, 18 Sep 2013 20:32:25 +0000 (20:32 +0000)]
fix fontconfig backend to only cache new fonts if their outName was unique

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23710072

git-svn-id: http://skia.googlecode.com/svn/trunk@11364 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix printing of error messages in canvasstatetest.
commit-bot@chromium.org [Wed, 18 Sep 2013 20:15:12 +0000 (20:15 +0000)]
fix printing of error messages in canvasstatetest.

R=scroggo@google.com, caryclark@google.com

Author: djsollen@google.com

Review URL: https://chromiumcodereview.appspot.com/23477067

git-svn-id: http://skia.googlecode.com/svn/trunk@11363 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline tilemode GMs after min rescaled NPOT texture size removed.
bsalomon@google.com [Wed, 18 Sep 2013 20:14:46 +0000 (20:14 +0000)]
Rebaseline tilemode GMs after min rescaled NPOT texture size removed.

R=epoger@google.com

Review URL: https://codereview.chromium.org/23796012

git-svn-id: http://skia.googlecode.com/svn/trunk@11362 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agopdf: write only ToUnicode mappings needed by the font, trimming anything out of ...
edisonn@google.com [Wed, 18 Sep 2013 19:29:08 +0000 (19:29 +0000)]
pdf: write only ToUnicode mappings needed by the font, trimming anything out of [firstChar, lastChar] interval.

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/23519006

git-svn-id: http://skia.googlecode.com/svn/trunk@11360 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark morphology test as ignore-failure for poppler.
senorblanco@chromium.org [Wed, 18 Sep 2013 19:20:48 +0000 (19:20 +0000)]
Mark morphology test as ignore-failure for poppler.

R=epoger@google.com

Review URL: https://codereview.chromium.org/23672045

git-svn-id: http://skia.googlecode.com/svn/trunk@11359 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd an option to rebaseline.py to mark tests as ignore-failure.
senorblanco@chromium.org [Wed, 18 Sep 2013 19:14:43 +0000 (19:14 +0000)]
Add an option to rebaseline.py to mark tests as ignore-failure.

R=epoger@google.com, epoger

Review URL: https://codereview.chromium.org/24195018

git-svn-id: http://skia.googlecode.com/svn/trunk@11358 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agocleanup XML_Parser after reading android config files.
djsollen@google.com [Wed, 18 Sep 2013 18:59:29 +0000 (18:59 +0000)]
cleanup XML_Parser after reading android config files.

This CL is based on one submitted for AOSP review...
 Fix memory leak in parseConfigFile()
 Need to call XML_ParserFree() on parsers created by XML_ParserCreate()
Signed-off-by: Carton He <carton.he@marvell.com>
 https://android-review.googlesource.com/#/c/65690/1

R=mtklein@google.com

Review URL: https://codereview.chromium.org/24171003

git-svn-id: http://skia.googlecode.com/svn/trunk@11357 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAttempt to remove 64 bit min size for NPOT resized texture.
commit-bot@chromium.org [Wed, 18 Sep 2013 18:52:16 +0000 (18:52 +0000)]
Attempt to remove 64 bit min size for NPOT resized texture.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/24123003

git-svn-id: http://skia.googlecode.com/svn/trunk@11356 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd getFloat/setFloat funcs to SkMatrix44
commit-bot@chromium.org [Wed, 18 Sep 2013 18:52:09 +0000 (18:52 +0000)]
Add getFloat/setFloat funcs to SkMatrix44

These match the existing getDouble/setDouble functions.

R=reed@google.com, tomhudson@chromium.org

Author: enne@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23757031

git-svn-id: http://skia.googlecode.com/svn/trunk@11355 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoYou get a rebaseline, and *you* get a rebaseline - everybody gets a lumamode rebaseline!
fmalita@google.com [Wed, 18 Sep 2013 18:36:28 +0000 (18:36 +0000)]
You get a rebaseline, and *you* get a rebaseline - everybody gets a lumamode rebaseline!

TBR=epoger

Review URL: https://codereview.chromium.org/24153015

git-svn-id: http://skia.googlecode.com/svn/trunk@11354 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agowhitespace change to trigger bots.
edisonn@google.com [Wed, 18 Sep 2013 17:52:56 +0000 (17:52 +0000)]
whitespace change to trigger bots.

Review URL: https://codereview.chromium.org/23902041

git-svn-id: http://skia.googlecode.com/svn/trunk@11353 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline msaa4 images for scaled_tilemodes_npot on Galaxy Nexus. Images are known...
bsalomon@google.com [Wed, 18 Sep 2013 16:39:46 +0000 (16:39 +0000)]
Rebaseline msaa4 images for scaled_tilemodes_npot on Galaxy Nexus. Images are known to be bad.

R=epoger@google.com
BUG=sk1656

Review URL: https://codereview.chromium.org/23452042

git-svn-id: http://skia.googlecode.com/svn/trunk@11352 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline N10 hairmodes with bug note
bsalomon@google.com [Wed, 18 Sep 2013 16:31:37 +0000 (16:31 +0000)]
Rebaseline N10 hairmodes with bug note

BUG=1655

R=epoger@google.com,jvanverth@google.com

Review URL: https://codereview.chromium.org/23619078

git-svn-id: http://skia.googlecode.com/svn/trunk@11351 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline N7 images. This bot was down for a long time. Many GM tests themselves...
bsalomon@google.com [Wed, 18 Sep 2013 16:24:58 +0000 (16:24 +0000)]
Rebaseline N7 images. This bot was down for a long time. Many GM tests themselves changed and all 2 and 3 color gradients on the GPU changed while it was down.

R=epoger@google.com

Review URL: https://codereview.chromium.org/23452041

git-svn-id: http://skia.googlecode.com/svn/trunk@11350 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline: perspective gradients in pdf
edisonn@google.com [Wed, 18 Sep 2013 16:10:54 +0000 (16:10 +0000)]
rebaseline: perspective gradients in pdf

BUG=

Review URL: https://codereview.chromium.org/23437045

git-svn-id: http://skia.googlecode.com/svn/trunk@11349 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline: gradients in pdf
edisonn@google.com [Wed, 18 Sep 2013 15:51:47 +0000 (15:51 +0000)]
rebaseline: gradients in pdf

BUG=

Review URL: https://codereview.chromium.org/23875042

git-svn-id: http://skia.googlecode.com/svn/trunk@11348 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline.py: make builder names copy-pastable from --help output
epoger@google.com [Wed, 18 Sep 2013 14:58:47 +0000 (14:58 +0000)]
rebaseline.py: make builder names copy-pastable from --help output
BUG=skia:1653
(SkipBuildbotRuns)

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23514068

git-svn-id: http://skia.googlecode.com/svn/trunk@11347 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline tilemode npot images on SGX GPUs
bsalomon@google.com [Wed, 18 Sep 2013 13:55:34 +0000 (13:55 +0000)]
Rebaseline tilemode npot images on SGX GPUs

R=epoger@google.com

Review URL: https://codereview.chromium.org/23431033

git-svn-id: http://skia.googlecode.com/svn/trunk@11346 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline these tests: radial_gradient2 lumamode morphology imageblur imagemagnifier...
bsalomon@google.com [Wed, 18 Sep 2013 13:42:34 +0000 (13:42 +0000)]
Rebaseline these tests: radial_gradient2 lumamode morphology imageblur imagemagnifier gradients

on all Mac 10.6 builders

R=epoger@google.com

Review URL: https://codereview.chromium.org/23606037

git-svn-id: http://skia.googlecode.com/svn/trunk@11345 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEven more GM:lumamode rebaselines.
fmalita@google.com [Wed, 18 Sep 2013 13:33:08 +0000 (13:33 +0000)]
Even more GM:lumamode rebaselines.

TBR=epoger

Review URL: https://codereview.chromium.org/23437042

git-svn-id: http://skia.googlecode.com/svn/trunk@11344 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r11342 (Add infrastructure for testing the debugger code) due to build breakages
robertphillips@google.com [Wed, 18 Sep 2013 13:28:10 +0000 (13:28 +0000)]
Revert r11342 (Add infrastructure for testing the debugger code) due to build breakages

git-svn-id: http://skia.googlecode.com/svn/trunk@11343 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd infrastructure for testing the debugger code.
commit-bot@chromium.org [Wed, 18 Sep 2013 13:01:17 +0000 (13:01 +0000)]
Add infrastructure for testing the debugger code.

This creates the necessarily files and GYP targets to start adding tests
for the debugger code. There is currently one test added, more will be added
once the infrastructure is in place.

BUG=
R=mtklein@google.com

Author: dsinclair@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23589007

git-svn-id: http://skia.googlecode.com/svn/trunk@11342 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReplace uses of GrNoncopyable by SkNoncopyable.
commit-bot@chromium.org [Wed, 18 Sep 2013 13:00:55 +0000 (13:00 +0000)]
Replace uses of GrNoncopyable by SkNoncopyable.

BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23483042

git-svn-id: http://skia.googlecode.com/svn/trunk@11341 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix to allow ovals GM to finish on N7
commit-bot@chromium.org [Wed, 18 Sep 2013 13:00:28 +0000 (13:00 +0000)]
Fix to allow ovals GM to finish on N7

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23477079

git-svn-id: http://skia.googlecode.com/svn/trunk@11340 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoARM Skia NEON patches - 23 - S32_D565_Opaque_Dither cleanup/bugfix/speed
commit-bot@chromium.org [Wed, 18 Sep 2013 13:00:21 +0000 (13:00 +0000)]
ARM Skia NEON patches - 23 - S32_D565_Opaque_Dither cleanup/bugfix/speed

BlitRow565: S32_D565_Opaque_Dither: cleaning / bugfix

This patch brings a little code cleaning (spaces/comments) and a little
speed improvement (by using post-incrementation in the asm) but more
importantly it fixes a bug on Linux. The new code now supports ARGB
as well as ABGR.

I removed the comment as I have confirmed with benchmarks that this
code bring a *massive* (3x-7x) speedup compared to the C code.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22269003

git-svn-id: http://skia.googlecode.com/svn/trunk@11339 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix Mac 10.6 DeviceLooperTest build error (this time with feeling)
robertphillips@google.com [Wed, 18 Sep 2013 12:51:50 +0000 (12:51 +0000)]
Fix Mac 10.6 DeviceLooperTest build error (this time with feeling)

git-svn-id: http://skia.googlecode.com/svn/trunk@11338 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix for Mac10.6 compiler error on tests\DeviceLooperTest.cpp
robertphillips@google.com [Wed, 18 Sep 2013 12:06:02 +0000 (12:06 +0000)]
Fix for Mac10.6 compiler error on tests\DeviceLooperTest.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@11337 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 18 Sep 2013 07:01:33 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11336 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore GM:lumamode rebaselines.
fmalita@google.com [Tue, 17 Sep 2013 20:33:52 +0000 (20:33 +0000)]
More GM:lumamode rebaselines.

TBR=epoger

Review URL: https://codereview.chromium.org/23875037

git-svn-id: http://skia.googlecode.com/svn/trunk@11334 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoYet more morphology rebaselines.
senorblanco@chromium.org [Tue, 17 Sep 2013 20:22:27 +0000 (20:22 +0000)]
Yet more morphology rebaselines.

TBR=epoger

Review URL: https://codereview.chromium.org/23441075

git-svn-id: http://skia.googlecode.com/svn/trunk@11333 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd missing file
reed@google.com [Tue, 17 Sep 2013 20:14:52 +0000 (20:14 +0000)]
add missing file

git-svn-id: http://skia.googlecode.com/svn/trunk@11332 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoupdate devicelooper to skip internal tiles that are empty, and unittests
reed@google.com [Tue, 17 Sep 2013 20:03:43 +0000 (20:03 +0000)]
update devicelooper to skip internal tiles that are empty, and unittests

BUG=

Review URL: https://codereview.chromium.org/23463040

git-svn-id: http://skia.googlecode.com/svn/trunk@11331 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd Clock Sample.
jvanverth@google.com [Tue, 17 Sep 2013 19:52:05 +0000 (19:52 +0000)]
Add Clock Sample.

There are two possible rendering methods: paths (default) or primitives.
At the moment the rrect primitive only supports axis-aligned rrects for
GPU acceleration, so that will not be a win on GPU.

R=reed@google.com

Review URL: https://codereview.chromium.org/23876008

git-svn-id: http://skia.googlecode.com/svn/trunk@11330 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago1) Don't allocate 100,000 ints when we only need 1,000.
mtklein@google.com [Tue, 17 Sep 2013 19:37:34 +0000 (19:37 +0000)]
1) Don't allocate 100,000 ints when we only need 1,000.
2) Don't sort past the end of the array when using SkTQSort.
3) Don't allocate any arrays until we need them (in onDraw).

Also, propagate the constant N everywhere through the bench.

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23890033

git-svn-id: http://skia.googlecode.com/svn/trunk@11329 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoalso limit loops-per-canvas in picture_record_dictionaries, which has the same proble...
mtklein@google.com [Tue, 17 Sep 2013 18:58:53 +0000 (18:58 +0000)]
also limit loops-per-canvas in picture_record_dictionaries, which has the same problem as unique_paint

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23513065

git-svn-id: http://skia.googlecode.com/svn/trunk@11327 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore morphology GM rebaselines.
senorblanco@chromium.org [Tue, 17 Sep 2013 18:07:47 +0000 (18:07 +0000)]
More morphology GM rebaselines.

TBR=epoger

Review URL: https://codereview.chromium.org/23460047

git-svn-id: http://skia.googlecode.com/svn/trunk@11325 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSplits bench_expectations into per-bot files in preparation for growth.
bensong@google.com [Tue, 17 Sep 2013 17:21:02 +0000 (17:21 +0000)]
Splits bench_expectations into per-bot files in preparation for growth.
Next steps are switching bots to using per-bot expectations, and deleting the existing bench_expectations.txt.
Review URL: https://codereview.chromium.org/24075008

git-svn-id: http://skia.googlecode.com/svn/trunk@11323 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agopdf: ifgnore shader colors applied for 0 range.
edisonn@google.com [Tue, 17 Sep 2013 17:17:47 +0000 (17:17 +0000)]
pdf: ifgnore shader colors applied for 0 range.

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/23654044

git-svn-id: http://skia.googlecode.com/svn/trunk@11322 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoswitch to a new canvas every once in a while in picture_record_unique
mtklein@google.com [Tue, 17 Sep 2013 17:14:25 +0000 (17:14 +0000)]
switch to a new canvas every once in a while in picture_record_unique

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23995020

git-svn-id: http://skia.googlecode.com/svn/trunk@11321 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix broken build due to coloremoji gm.
djsollen@google.com [Tue, 17 Sep 2013 16:17:52 +0000 (16:17 +0000)]
fix broken build due to coloremoji gm.

 - fix SkIntToScalar warnings on windows
 - disable the test on Android until freetype changes are submitted

Review URL: https://codereview.chromium.org/23952005

git-svn-id: http://skia.googlecode.com/svn/trunk@11319 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a test for color bitmap fonts.
djsollen@google.com [Tue, 17 Sep 2013 15:30:21 +0000 (15:30 +0000)]
Add a test for color bitmap fonts.

This CL also includes a sample font from https://code.google.com/p/color-emoji/

R=reed@google.com

Review URL: https://codereview.chromium.org/24181002

git-svn-id: http://skia.googlecode.com/svn/trunk@11317 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline morphology GM after https://skia.googlesource.com/skia.git/+/3b64f20423a2b...
senorblanco@chromium.org [Tue, 17 Sep 2013 15:14:46 +0000 (15:14 +0000)]
Rebaseline morphology GM after https://skia.googlesource.com/skia.git/+/3b64f20423a2bfc454cd569594d78f4169756764

TBR=epoger

Review URL: https://codereview.chromium.org/23600064

git-svn-id: http://skia.googlecode.com/svn/trunk@11315 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline lumamode GM after dce12a8a79f6094bc17eab15ce4d05ba9c99b814
fmalita@google.com [Tue, 17 Sep 2013 14:38:04 +0000 (14:38 +0000)]
Rebaseline lumamode GM after dce12a8a79f6094bc17eab15ce4d05ba9c99b814

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/23526054

git-svn-id: http://skia.googlecode.com/svn/trunk@11314 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement crop rect for the dilate and erode (morphology) filters. This provoked...
senorblanco@chromium.org [Tue, 17 Sep 2013 13:41:43 +0000 (13:41 +0000)]
Implement crop rect for the dilate and erode (morphology) filters. This provoked some cleanup on the GPU side: apply_morphology() now deals with SkBitmaps, rather than GrTextures. There's still a clear opportunity for more refactoring between the two filters.

Note: this adds some test cases to the morphology GM, so it will require a rebaseline.

R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23892011

git-svn-id: http://skia.googlecode.com/svn/trunk@11313 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago[External patch] Source-over support for SkLumaXfermode.
fmalita@google.com [Tue, 17 Sep 2013 13:09:16 +0000 (13:09 +0000)]
[External patch] Source-over support for SkLumaXfermode.

This is a patch by Andrei Parvu <parvu@adobe.com> (Adobe CLA signer).

Original CL/review: https://codereview.chromium.org/24078006/

GM:lumamode will need rebaselining after landing this.

---

  In order to use CSS luminance masking, we need to be able to create an
  instance of SkLumaXfermode which can receive a kSrcOver mode, and applies
  that mode after converting the source using the luminance-to-alpha
  coefficients.

BUG=289420
R=reed@google.com

Review URL: https://codereview.chromium.org/23710053

git-svn-id: http://skia.googlecode.com/svn/trunk@11312 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBaby step in making SkGpuDevice no longer derive from SkBitmapDevice
robertphillips@google.com [Tue, 17 Sep 2013 12:26:23 +0000 (12:26 +0000)]
Baby step in making SkGpuDevice no longer derive from SkBitmapDevice

https://codereview.chromium.org/23641008/

git-svn-id: http://skia.googlecode.com/svn/trunk@11311 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofinish rebaselining?
mtklein@google.com [Tue, 17 Sep 2013 11:43:44 +0000 (11:43 +0000)]
finish rebaselining?

BUG=

Review URL: https://codereview.chromium.org/23724037

git-svn-id: http://skia.googlecode.com/svn/trunk@11310 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 17 Sep 2013 07:01:20 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11309 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline some more: imageblur, imagemagnification, and yet more gradient_radial2
mtklein@google.com [Mon, 16 Sep 2013 21:33:10 +0000 (21:33 +0000)]
rebaseline some more: imageblur, imagemagnification, and yet more gradient_radial2

BUG=

Review URL: https://codereview.chromium.org/23686019

git-svn-id: http://skia.googlecode.com/svn/trunk@11308 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoHave GMs read the GrContext via a setter/getter rather than a global.
mtklein@google.com [Mon, 16 Sep 2013 20:42:15 +0000 (20:42 +0000)]
Have GMs read the GrContext via a setter/getter rather than a global.

GetGr's current global state makes things rather tricky to run GPU GMs in
parallel (DM).  This API change will let me feed the right GrContext to the
right GM in DM.

I'm not planning on changing the status quo in GM-the-tool: the new getters and
setters still just return the same global.

BUG=skia:1590
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/23567032

git-svn-id: http://skia.googlecode.com/svn/trunk@11306 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEnable msaa4 on Nexus 4 in bench_pictures
borenet@google.com [Mon, 16 Sep 2013 20:39:23 +0000 (20:39 +0000)]
Enable msaa4 on Nexus 4 in bench_pictures

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23496059

git-svn-id: http://skia.googlecode.com/svn/trunk@11305 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoHave multiple plotmgrs, one for each mask format.
jvanverth@google.com [Mon, 16 Sep 2013 20:28:37 +0000 (20:28 +0000)]
Have multiple plotmgrs, one for each mask format.
Only flush/purge those strikes that match our format.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24047005

git-svn-id: http://skia.googlecode.com/svn/trunk@11303 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't declare displayCache variable if PROGRAM_CACHE_STATS not defined.
jvanverth@google.com [Mon, 16 Sep 2013 20:00:46 +0000 (20:00 +0000)]
Don't declare displayCache variable if PROGRAM_CACHE_STATS not defined.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23757053

git-svn-id: http://skia.googlecode.com/svn/trunk@11301 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoOnly display program cache info if RTConf flag is set.
jvanverth@google.com [Mon, 16 Sep 2013 19:40:31 +0000 (19:40 +0000)]
Only display program cache info if RTConf flag is set.

Addresses: https://code.google.com/p/skia/issues/detail?id=1615

R=caryclark@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/23947006

git-svn-id: http://skia.googlecode.com/svn/trunk@11300 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaselines for imageblur, imagemagnifier, and still some for gradient_radial2
mtklein@google.com [Mon, 16 Sep 2013 19:37:25 +0000 (19:37 +0000)]
rebaselines for imageblur, imagemagnifier, and still some for gradient_radial2

BUG=

Review URL: https://codereview.chromium.org/23710057

git-svn-id: http://skia.googlecode.com/svn/trunk@11299 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow use of "--config defaults" in bench, like GM
borenet@google.com [Mon, 16 Sep 2013 19:12:19 +0000 (19:12 +0000)]
Allow use of "--config defaults" in bench, like GM

R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/23855006

git-svn-id: http://skia.googlecode.com/svn/trunk@11298 2bbb7eff-a529-9590-31e7-b0007b416f81