Konstantin Seurer [Sun, 7 Aug 2022 18:13:10 +0000 (20:13 +0200)]
lavapipe: Remove st_shader_stage_to_ptarget
Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17930>
Pierre-Eric Pelloux-Prayer [Mon, 8 Aug 2022 15:12:14 +0000 (17:12 +0200)]
nir: add a nir_opt_if_options enum
And don't enable nir_opt_if_optimize_phi_true_false on radeonsi with
LLVM 14 because it crashes Blender.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6976
Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Acked-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17949>
Gert Wollny [Wed, 10 Aug 2022 08:27:33 +0000 (10:27 +0200)]
llvmpipe: Double number of SSBOs
llvmpipe doesn't define atomics, and therefore, gallium uses half of the
available SSBOs as atomic buffers. When virgl runs with llvmpipe as GLES
host we also report no atomic buffers to the guest so as to lower
atomics to SSBOs to work around ARB_shader_counter_ops not being
available on GLES. With the current value of 16 SSBOs in llvmpipe, only
eight SSBOs and eight atomic shader buffers are reported and with
virglrenderer not reporting atomics these numbers will be reduced to
four, being below the required minimum for ARB_compute_shaders.
By doubling the number of available SSBOs in llvmpipe, this limitation
is worked around and using llvmpipe as GLES host for virgl in the CI
allows testing ARB_compute_shaders and ARB_shader_counter_ops properly.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17979>
Rhys Perry [Tue, 9 Aug 2022 10:42:10 +0000 (11:42 +0100)]
aco: fix hash statistic
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Fixes:
897561b7b98 ("aco: add aco_postprocess_shader() helper")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17954>
Gert Wollny [Wed, 10 Aug 2022 10:29:05 +0000 (12:29 +0200)]
radeonsi-raven/ci: Move spec@arb_timer_query@timestamp-get to flakes
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17982>
Friedrich Vock [Tue, 14 Jun 2022 10:01:10 +0000 (12:01 +0200)]
amd/common: move ac_memory_ops_per_clock into ac_gpu_info.h
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17973>
Erik Faye-Lund [Mon, 8 Aug 2022 14:10:54 +0000 (16:10 +0200)]
zink: do not use VK_FORMAT_D32_SFLOAT_S8_UINT without checking
Without this, we might end up trying to use VK_FORMAT_D32_SFLOAT_S8_UINT
even when it's not supported...
Cc: mesa-stable
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17953>
Erik Faye-Lund [Tue, 9 Aug 2022 10:23:26 +0000 (12:23 +0200)]
zink: add have_D32_SFLOAT_S8_UINT boolean
This will be reused in the following commit.
Cc: mesa-stable
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17953>
Samuel Pitoiset [Tue, 9 Aug 2022 08:53:02 +0000 (10:53 +0200)]
radv: fix cleaning the meta query state if an error occured
It's already correctly cleaned in radv_device_init_meta().
This fixes a recent regression with
dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.
Fixes:
1a95d43e550 ("radv: Simplify the meta init fail path")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17952>
Samuel Pitoiset [Tue, 9 Aug 2022 07:42:51 +0000 (09:42 +0200)]
radv: respect the render area for depth/stencil resolves
Subpass resolves don't necessarily start from 0,0.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17950>
Charmaine Lee [Wed, 3 Aug 2022 18:40:32 +0000 (11:40 -0700)]
svga: fix mksstats build
Trivial.
Fixes:
ed77ac1eef7 ("svga: add a helper function for common shader creation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17971>
Yonggang Luo [Thu, 4 Aug 2022 19:59:37 +0000 (03:59 +0800)]
ci/windows: Setup proper MESA_IMAGE_TAG for Windows build/test image
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17600>
Jesse Natalie [Mon, 18 Jul 2022 16:44:38 +0000 (09:44 -0700)]
ci/windows: Install Graphics-Tools package on the base image
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17600>
Yonggang Luo [Sat, 30 Jul 2022 09:59:33 +0000 (17:59 +0800)]
egl/x11: implement ANGLE_sync_control_rate
Implement EGL_ANGLE_sync_control_rate for running Chromium Linux on Wayland with EGL backend.
Chromium works with this patch using(with videos playing smoothly):
/usr/bin/google-chrome-stable --use-gl=egl --enable-features=VaapiVideoDecoder --ignore-gpu-blocklist
Closes #2930
Signed-off-by: KJ Liew <liewkj@yahoo.com>
Signed-off-by: Térence Clastres <t.clastres@gmail.com>
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17815>
Yonggang Luo [Thu, 4 Aug 2022 16:00:08 +0000 (00:00 +0800)]
egl/x11: Split declaration of dri2_format_for_depth into header platform_x11.h
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17815>
Yonggang Luo [Sat, 30 Jul 2022 09:28:54 +0000 (17:28 +0800)]
egl: wire up ANGLE_sync_control_rate
Add eglGetMscRateANGLE prototype into generate file
Signed-off-by: KJ Liew <liewkj@yahoo.com>
Signed-off-by: Térence Clastres <t.clastres@gmail.com>
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17815>
Yonggang Luo [Sat, 30 Jul 2022 09:44:16 +0000 (17:44 +0800)]
egl: Remove eglextchromium.h and import eglext_angle.h
The upstream eglextchromium.h in https://chromium.googlesource.com/chromium/src/+/refs/heads/master/ui/gl/EGL/eglextchromium.h
are broken, so remove it and using eglext_angle.h instead.
By running "python bin/khronos-update.py egl" to update EGL files,
then discard changes other than eglext_angle.h
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17815>
Jesse Natalie [Tue, 9 Aug 2022 17:00:36 +0000 (10:00 -0700)]
ci/windows: Windows runner is back online
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17962>
Iván Briano [Tue, 9 Aug 2022 18:41:31 +0000 (11:41 -0700)]
anv: emit scissors when the pipeline changes
With the switch to common dynamic state tracking, something got lost
that made the scissors not always be emitted when they are not dynamic
and the pipeline is marked dirty.
Since both viewport and scissors make use of each other to calculate
their values, just stick the scissor emit in the same if block as
viewport for now.
I'd rather have them decoupled, and at least the Vulkan CTS didn't
complain when I tried it, but I don't know what other effects that
may have, especially when it comes to the guardband.
Fixes a bunch of tests under
dEQP-VK.pipeline.*.multisample.misc.*
Fixes:
7d25c04236b ("anv: Switch to using common dynamic state tracking")
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17964>
David Heidelberg [Tue, 9 Aug 2022 19:33:43 +0000 (21:33 +0200)]
ci/lavapipe: wine flakes, switch to manual for now
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7030
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17965>
Marek Olšák [Sun, 17 Jul 2022 16:21:17 +0000 (12:21 -0400)]
gallium/u_blitter: make the bilinear filter for MSAA resolving conformant
This implements the bilinear filter exactly like OpenGL.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Sun, 17 Jul 2022 12:25:23 +0000 (08:25 -0400)]
gallium/u_blitter: make nearest filtering emulation using TXF conformant
This is required by glBlitFramebuffer.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Mon, 18 Jul 2022 12:04:00 +0000 (08:04 -0400)]
gallium/u_blitter: clean up IMMs in util_make_fs_blit_msaa_gen
Always declare IMM[0].
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Sat, 23 Jul 2022 17:20:44 +0000 (13:20 -0400)]
gallium/u_blitter: treat Z scaling as scaled blits
Hopefully this didn't break anything.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Wed, 3 Aug 2022 14:54:03 +0000 (10:54 -0400)]
gallium/u_blitter: fix the has_txf support condition
GLSL 1.30 has it too.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Sun, 17 Jul 2022 12:06:14 +0000 (08:06 -0400)]
gallium/u_blitter: remove unused code for integer MSAA resolve
GL doesn't have it.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Wed, 3 Aug 2022 21:19:42 +0000 (17:19 -0400)]
gallivm: initialize texture_unit_offset in emit_size_query
this fixes a crash, suggested by Dave Airlie
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Wed, 3 Aug 2022 18:03:07 +0000 (14:03 -0400)]
gallivm: fix TXQ crash with MSAA samplers
suggested by Dave Airlie
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Marek Olšák [Wed, 3 Aug 2022 14:49:51 +0000 (10:49 -0400)]
ttn: set the correct sampler declaration type in the presense of txs and lod
We used the result type of lod and txs for sampler declarations,
which broke following instructions that are not lod and txs.
Use the sampler type from TGSI if it's present, not the result type
of lod and txs.
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17692>
Emma Anholt [Mon, 8 Aug 2022 00:18:31 +0000 (17:18 -0700)]
ci/tu+zink: Re-enable the traces that were asserting about UBWC compatibility.
The tu and zink fixes have made them work now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17900>
Emma Anholt [Thu, 4 Aug 2022 22:33:35 +0000 (15:33 -0700)]
tu: Use the format list to decide whether we can do UBWC with MUTABLE.
The goal here is to allow zink and ANGLE to switch sRGB on and off, but
keep UBWC enabled for most textures.
This doesn't quite work yet for zink on gbm, where zink asks the device if
it supports a UBWC-modifier image with unorm+sRGB mutable formats (yes),
but then doesn't pass the unorm+sRGB format list to vkImageCreate(), which
then asserts because it couldn't make a general
VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT UBWC image.
The format list here comes from Danylo's testing in
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17278#note_1447812
Reduces frame times in Genshin Impact GLES AoV 2.02063% +/- 0.207575% (n=5)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17900>
Emma Anholt [Fri, 5 Aug 2022 03:28:40 +0000 (20:28 -0700)]
tu: Treat viewFormatCount==0 as no format list.
"If viewFormatCount is zero, pViewFormats is ignored and the image is
created as if the VkImageFormatListCreateInfo structure were not included
in the pNext chain of VkImageCreateInfo."
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17900>
Emma Anholt [Fri, 5 Aug 2022 03:21:20 +0000 (20:21 -0700)]
tu: Move the vkCreateImage format list checks to helper functions.
Mixing up the two checks made them both harder to read.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17900>
Emma Anholt [Mon, 8 Aug 2022 00:10:40 +0000 (17:10 -0700)]
zink: Make sure that we keep the existing ici pNext chain on inserts.
For external image imports, we'd lose the mutable image format list,
causing turnip to get angry that we try to do UBWC despite not having a
UBWC-compatible format list.
Cc: mesa-stable
Fixes:
28ee911ad671 ("zink: handle mutable swapchain images with dmabuf")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17900>
Yonggang Luo [Sun, 12 Jun 2022 02:02:23 +0000 (10:02 +0800)]
c11: Fixes the declaration of timespec_get in time.h for macOS
../src/util/tests/timespec_test.cpp:327:4: error: use of undeclared identifier 'timespec_get'; did you mean 'timespec_eq'?
timespec_get(&a, TIME_UTC);
^~~~~~~~~~~~
timespec_eq
../src/util/timespec.h:299:1: note: 'timespec_eq' declared here
timespec_eq(const struct timespec *a, const struct timespec *b)
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16995>
Yonggang Luo [Sun, 7 Aug 2022 05:21:26 +0000 (13:21 +0800)]
util: open_memstream also support on MacOS
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16995>
Yonggang Luo [Sat, 6 Aug 2022 17:26:10 +0000 (01:26 +0800)]
microsoft/clc: Fixes compiling errors with clang/mingw64 in clc/clc_compiler_test.cpp
clc_compiler_test.cpp:1322:67: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list
log(0.0f) / log(2), log(1.0f) / log(2), log(2.0f) / log(2), log(3.0f) / log(2)
clc_compiler_test.cpp:2306:25: error: non-constant-expression cannot be narrowed from type 'std::vector<unsigned int>::size_type' (aka 'unsigned long long') to 'unsigned int' in initializer list
CompileArgs args = { inout.size(), 1, 1 };
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17926>
Yonggang Luo [Sun, 7 Aug 2022 17:57:34 +0000 (01:57 +0800)]
meson: clc compiler test only works on win32
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17934>
Samuel Pitoiset [Mon, 8 Aug 2022 13:18:18 +0000 (15:18 +0200)]
radv: fix gathering XFB info if there is dead outputs
The driver should still gather XFB info even if all XFB outputs are
dead, otherwise the pipeline can't find the streamout shader.
RADV should use vk_spirv_to_nir() at some point to reduce code
duplication during SPIRV->NIR compilation.
This fixes new dEQP-VK.transform_feedback.simple.*.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17939>
Tomeu Vizoso [Mon, 8 Aug 2022 08:59:56 +0000 (10:59 +0200)]
radv/ci: Put one more board to run the CTS on Stoney Ridge
These jobs were taking more than 20 minutes to run, slowing the pipeline
down.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17935>
Tomeu Vizoso [Mon, 8 Aug 2022 08:57:38 +0000 (10:57 +0200)]
radeonsi/ci: Move libva and piglit jobs to Raven Ridge boards
As we have some free, and then we can reassign two Stoney Ridge boards
to reduce the duration for some jobs that are taking too long currently.
Also, these machines are much faster so we are able to run all of the
Piglit tests and a bigger portion of the VA tests.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17935>
Pierre-Eric Pelloux-Prayer [Fri, 5 Aug 2022 09:44:21 +0000 (11:44 +0200)]
radeonsi: print radeon_bo_flag when AMD_DEBUG=vm is used
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11449>
Pierre-Eric Pelloux-Prayer [Fri, 5 Aug 2022 09:41:55 +0000 (11:41 +0200)]
radeonsi: allocate BIND_RENDER_TARGET as tmz instead of SCANOUT
Using AMD_DEBUG=tmz to enable tmz without the application asking
for it is useful for testing. Since SCANOUT isn't set on Wayland,
use RENDER_TARGET instead as a heuristic to try to allocate color
framebuffer as tmz.
With this change we can enable tmz in x11 and wayland.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11449>
Pierre-Eric Pelloux-Prayer [Fri, 25 Jun 2021 15:35:12 +0000 (17:35 +0200)]
amdgpu/bo: update uses_secure_bos when importing buffers
Fixes:
90b98c06493 ("amd/tmz: move uses_secure_bos to radeon_winsys")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11449>
Pierre-Eric Pelloux-Prayer [Tue, 2 Aug 2022 09:54:13 +0000 (11:54 +0200)]
gallium/dri2: make protected buffer checks opt-in
This check is an infinite source of issues when testing protected
content, so make it opt-in (eg for developers of applications dealing
with protected content buffers).
On AMD and Intel importing a protected buffer as non-protected will cause
the display to be incorrect (= garbage).
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11449>
Jesse Natalie [Tue, 9 Aug 2022 13:57:35 +0000 (06:57 -0700)]
ci/windows: Disable Windows builds while the runner is offline again
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17958>
David Heidelberg [Sat, 2 Jul 2022 18:56:17 +0000 (20:56 +0200)]
docs/ci: show how to run traces locally
Newcomers may want to test traces locally and understand how the replay
works.
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17347>
Martin Roukala (né Peres) [Mon, 8 Aug 2022 07:18:07 +0000 (10:18 +0300)]
radv/ci: bump the console activity timeout of VanGogh to 3 minutes
It seems like VKCTS's startup time is close to the current console
activity timeout (2 minutes...) on the Steam Deck, leading to spurious
timeouts...
Let's bump the timeout by 50%!
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829>
Martin Roukala (né Peres) [Mon, 1 Aug 2022 07:59:11 +0000 (10:59 +0300)]
radv/ci: skip host_write_transfer_src.1048576 on renoir
The test can take a little longer than 60s, which leads to spurious
timeouts and thus unstable CI pipelines.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829>
Martin Roukala (né Peres) [Mon, 1 Aug 2022 07:27:57 +0000 (10:27 +0300)]
radv/ci: add more tests to the flake list of vega10
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829>
Martin Roukala (né Peres) [Mon, 1 Aug 2022 07:17:43 +0000 (10:17 +0300)]
radv/ci: move some tests from the vega10 fail to its flake list
v2:
- Move the other 2 `sample_texture` tests to the flake list (Ishi)
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829>
Martin Roukala (né Peres) [Mon, 1 Aug 2022 06:41:12 +0000 (09:41 +0300)]
radv/ci: document a recent regression
This regression may have been introduced by mesa/mesa!17652 or
mesa/mesa!17625.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829>
Rob Clark [Mon, 8 Aug 2022 19:01:58 +0000 (12:01 -0700)]
freedreno: Cap reported video memory by VA size
Don't report that we have more video memory than the GPU's virtual
address space size.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17947>
Rob Clark [Mon, 8 Aug 2022 19:01:37 +0000 (12:01 -0700)]
freedreno/drm: Add FD_VA_SIZE param
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17947>
Jesse Natalie [Fri, 22 Jul 2022 22:48:24 +0000 (15:48 -0700)]
dzn: Use D3D12 constants instead of naked numbers for device limits
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17915>
Jesse Natalie [Fri, 22 Jul 2022 22:48:03 +0000 (15:48 -0700)]
dzn: Disable extensions that require multi-view
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17915>
Erik Faye-Lund [Thu, 4 Aug 2022 09:04:57 +0000 (11:04 +0200)]
docs: fixup link to virgl docs
Fixes:
6897266ce01 ("docs: import virgl docs")
Acked-by: Chia-I Wu <olvaffe@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17881>
Caleb Cornett [Thu, 4 Aug 2022 22:33:18 +0000 (18:33 -0400)]
wgl: Release the context before deleting it in wglDeleteContext
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17848>
Caleb Cornett [Tue, 2 Aug 2022 01:47:37 +0000 (21:47 -0400)]
wgl: Always release local references in stw_make_current_by_handles
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17848>
Caleb Cornett [Tue, 2 Aug 2022 01:44:47 +0000 (21:44 -0400)]
wgl: Homogenize read framebuffer reference counting logic
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17848>
Marek Olšák [Mon, 8 Aug 2022 07:27:28 +0000 (03:27 -0400)]
radeonsi: use do..while loops and other cosmetic changes in display list path
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933>
Marek Olšák [Mon, 8 Aug 2022 06:52:20 +0000 (02:52 -0400)]
radeonsi: use si_cp_dma_prefetch_inline for prefetching VBO descriptors
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933>
Marek Olšák [Sat, 6 Aug 2022 13:55:51 +0000 (09:55 -0400)]
radeonsi: remove temporary si_context::vb_descriptor_user_sgprs
We were writing descriptors into si_context and then copying them into
the command buffer. Just write them into the command buffer directly.
Also set the pointer to VBO descriptors right after them.
When we start a new command buffer or we finish blitting, we no longer
restore precomputed VBO descriptors. Instead, we just reupload them again.
It's a compromise to have the common path simpler and faster (maybe).
This removes a lot of stuff. Now the VBO descriptor upload path looks
very similar to the display list path.
There was an accidental hidden optimization that is now documented as
"last_const_upload_buffer".
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933>
Marek Olšák [Sat, 6 Aug 2022 13:08:37 +0000 (09:08 -0400)]
radeonsi: remove vb_descriptors_gpu_list only used for debugging
While this is nice to have, it doesn't include VBO descriptors in user
SGPRs, and we need to remove it, so that we can simplify the VBO code.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933>
Marek Olšák [Mon, 8 Aug 2022 07:56:02 +0000 (03:56 -0400)]
radeonsi: add vertex buffers into the BO list in set_vertex_buffers
This is more straightforward. Also, radeon_add_to_buffer_list makes
writing VBO descriptors into the command buffer slower after that code
is reordered in following commits. This seems to be the only way that
isn't slower.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933>
Marek Olšák [Mon, 8 Aug 2022 07:32:00 +0000 (03:32 -0400)]
radeonsi: merge both fail paths in si_set_vb_descriptor
I removed the assertion because apps are allowed to set an offset greater
than the size.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933>
Connor Abbott [Mon, 8 Aug 2022 13:52:49 +0000 (15:52 +0200)]
tu: Fix sysmem depth attachment clear flushing
We can't invalidate CCU if there is any dirty data that hasn't been
flushed yet. In the case where we clear depth, we know that the depth
attachment itself isn't dirty but there may be dirty data from other
renderpasses. Therefore we need to flush before invalidating depth.
Fixes: 487aa80 ("tu: Rewrite flushing to use barriers")
Closes: #6987
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17940>
Pierre-Eric Pelloux-Prayer [Mon, 1 Aug 2022 09:00:41 +0000 (11:00 +0200)]
docs: document DRI_PRIME
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298>
Pierre-Eric Pelloux-Prayer [Wed, 29 Jun 2022 08:33:59 +0000 (10:33 +0200)]
vulkan/device_select: allow DRI_PRIME=vendor_id:device_id
To match the GL side.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298>
Pierre-Eric Pelloux-Prayer [Wed, 29 Jun 2022 08:30:58 +0000 (10:30 +0200)]
vulkan/device_select: print the dri_prime warning only if needed
The next commit will allow a different DRI_PRIME syntax, so move
this printf in the right if block.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298>
Pierre-Eric Pelloux-Prayer [Wed, 29 Jun 2022 08:21:24 +0000 (10:21 +0200)]
loader: allow DRI_PRIME=vendor_id:device_id syntax
This syntax allows to select a specific GPU without depending on
the pci bus information.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298>
Pierre-Eric Pelloux-Prayer [Wed, 29 Jun 2022 08:03:16 +0000 (10:03 +0200)]
loader: don't return empty string in loader_get_dri_config_device_id
The caller expects a NULL return value if the option isn't set.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298>
Jesse Natalie [Mon, 8 Aug 2022 15:09:39 +0000 (08:09 -0700)]
ci/windows: Re-enable Windows runners
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17942>
Samuel Pitoiset [Tue, 31 May 2022 07:29:30 +0000 (09:29 +0200)]
radv: simplify radv_bind_dynamic_state() slightly
This adds RADV_CMP_COPY to compact copies. Based on ANV.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649>
Samuel Pitoiset [Tue, 31 May 2022 07:13:12 +0000 (09:13 +0200)]
radv: remove unused states parameter from some radv_emit_XXX() helpers
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649>
Samuel Pitoiset [Mon, 30 May 2022 20:55:49 +0000 (22:55 +0200)]
radv: simplify saving/restoring all dynamic states
Instead of copying every field individually, just use a whole memcpy.
This could be optimized but that's not the point here.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649>
Samuel Pitoiset [Tue, 31 May 2022 06:47:19 +0000 (08:47 +0200)]
radv: remove RADV_META_SAVE_SAMPLE_LOCATIONS
We already save/restore all other dynamic states unconditionally, it's
not really useful to make an exception for sample locations.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649>
Rhys Perry [Wed, 13 Jul 2022 18:37:27 +0000 (19:37 +0100)]
aco: improve VcmpxPermlaneHazard workaround
According to LLVM, we only need to care about VOPC which writes exec.
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697>
Rhys Perry [Thu, 21 Jul 2022 18:59:54 +0000 (19:59 +0100)]
aco: only add vscnt wait when visiting VMEM/DS
This prevents issues where we insert a s_waitcnt_vscnt(0) at the start of
a block or very end of the shader because we're joining two blocks (for
example, one with has_VMEM=true and the other with
has_branch_after_DS=true).
fossil-db (navi10):
Totals from 2441 (1.51% of 161220) affected shaders:
Instrs: 1383964 -> 1384094 (+0.01%); split: -0.07%, +0.08%
CodeSize: 7438212 -> 7438760 (+0.01%); split: -0.05%, +0.06%
Latency:
13780665 ->
13679664 (-0.73%); split: -1.53%, +0.80%
InvThroughput: 2950835 -> 2921511 (-0.99%); split: -1.06%, +0.07%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697>
Rhys Perry [Thu, 21 Jul 2022 18:24:46 +0000 (19:24 +0100)]
aco: set has_VMEM,has_DS=false after a branch
fossil-db (navi10):
Totals from 161 (0.10% of 161220) affected shaders:
Instrs: 206726 -> 207179 (+0.22%); split: -0.02%, +0.24%
CodeSize: 1114152 -> 1116032 (+0.17%); split: -0.01%, +0.18%
Latency: 2119380 -> 2147403 (+1.32%); split: -0.16%, +1.48%
InvThroughput: 462960 -> 461922 (-0.22%); split: -0.42%, +0.19%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697>
Rhys Perry [Thu, 21 Jul 2022 18:23:38 +0000 (19:23 +0100)]
aco: fix LdsBranchVmemWARHazard with 2+ branch chains
For example, "DS -> branch -> VMEM -> branch -> DS".
fossil-db (navi10):
Totals from 639 (0.40% of 161220) affected shaders:
Instrs: 629090 -> 628254 (-0.13%); split: -0.19%, +0.06%
CodeSize: 3410164 -> 3406748 (-0.10%); split: -0.14%, +0.04%
Latency: 7834755 -> 7821011 (-0.18%); split: -0.70%, +0.52%
InvThroughput: 1369698 -> 1374495 (+0.35%); split: -0.12%, +0.47%
A lot of the fossil-db changes are noise.
threekingdoms.
8db138826c386a62.1.foz/
0b222ed175eebad0 is an example of a
shader that actually has this issue.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Fixes:
c037ba1bb7a ("aco/gfx10: Mitigate LdsBranchVmemWARHazard.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697>
Jonathan [Sun, 24 Jul 2022 15:48:46 +0000 (17:48 +0200)]
gallium/u_threaded: buffer subdata merging (v2)
In a scenario where a sequence of calls happens like:
* subdata(buffer_a, offset=0, size=64)
* subdata(buffer_a, offset=64, size=64)
* subdata(buffer_a, offset=128, size=64)
* subdata(buffer_a, offset=192, size=64)
and the buffer can't be directly mapped (e.g., because it has bindings), the
subdata calls will now be merged together into one larger subdata call.
This achieves a 3x perf gain in
KHR-GL46.CommonBugs.CommonBug_SparseBuffersWithCopyOps on radeonsi
Before:
real 0m1,923s
user 0m1,017s
sys 0m0,051s
After:
real 0m0,686s
user 0m0,502s
sys 0m0,071s
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17741>
Danylo Piliaiev [Fri, 5 Aug 2022 12:49:49 +0000 (15:49 +0300)]
tu: Flush depth on depth img transition from undef layout
Same logic as in tu_subpass_barrier.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17911>
Timur Kristóf [Sun, 7 Aug 2022 10:23:10 +0000 (12:23 +0200)]
ac/nir/cull: Fix typo in bounding box culling.
Bounding box culling is only viable when the W of all
vertices are positive. Always accept triangles whose any
W is negative.
Fixes:
0d527bb1aa720bf8e5735afdf8e9b70772e1ec23
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7018
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17929>
Samuel Pitoiset [Tue, 19 Jul 2022 12:36:28 +0000 (14:36 +0200)]
radv: use ref counting for VS prologs and PS epilogs
With GPL, it will be possible to create VS prologs and PS epilogs
from libraries, so reference counting is useful here too.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17628>
Samuel Pitoiset [Tue, 19 Jul 2022 12:26:20 +0000 (14:26 +0200)]
radv: rework shaders ref counting
Introduce helpers like for descriptor set layouts. This will also
help graphics pipeline libraries.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-By: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17628>
Guilherme Gallo [Tue, 19 Jul 2022 21:35:29 +0000 (18:35 -0300)]
ci/radeonsi: Add zork jobs and rules
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Fri, 29 Jul 2022 12:10:46 +0000 (09:10 -0300)]
ci/radeonsi: skqp: Add fail test files for raven
Lots of models are missing.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Tue, 2 Aug 2022 23:38:30 +0000 (20:38 -0300)]
ci/freedreno: skqp: run with new tests files
Settings as flakes tests that passed in the exhaustive run, to keep the
same state as it was before
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Tue, 2 Aug 2022 22:39:31 +0000 (19:39 -0300)]
ci/skqp: Add gitlab sections for uncluttering
skqp output is verbose, as we are running multiple backends at the same
job, normally the trace will surpass the Gitlab UI line limit.
This commit wraps every skqp execution in a Gitlab section and removes
some `set -xtrace` from skqp-runner.sh for a cleaner output.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Tue, 2 Aug 2022 22:24:28 +0000 (19:24 -0300)]
ci/skqp: Remove .baremetal-skqp-test in favor of .skqp-test
Both hidden jobs has the same content, let's reuse it.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Tue, 2 Aug 2022 20:35:56 +0000 (17:35 -0300)]
ci/skqp: Supress irrelevant shellcheck warnings
To fix some warnings, one should write a much complex bash code, such as
SC2086, so prefer to be simple and functional.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Mon, 1 Aug 2022 03:17:45 +0000 (00:17 -0300)]
ci/skqp: Put generated tests files in artifacts
Showing the resulting test file can help the developer to debug skqp
runs by coping this file locally.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Wed, 27 Jul 2022 01:18:29 +0000 (22:18 -0300)]
ci/skqp: Use SKQP_BIN_DIR instead of hardcoded /skqp dir
This will make skqp-runner.sh more generic, making it easier to test
locally.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Wed, 27 Jul 2022 01:09:44 +0000 (22:09 -0300)]
ci/skqp: Add support for commenting tests files
The files are now separated in three: crashes, fails and flakes.
They should be located inside $INSTALL folder at:
- $GPU_VERSION_$SKQP_BACKEND_rendertests-$MODE.txt
- $GPU_VERSION_unittests-$MODE.txt
Where:
- $MODES can be crashes, fails, and flakes
- $SKQP_BACKEND can be gl, gles and vk
crashes and flakes removes tests from skqp, so they will not be run.
As skqp does not have support for flaky test detection, let's not run
them.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Wed, 20 Jul 2022 02:48:34 +0000 (23:48 -0300)]
ci/skqp: Build list_gpu_unit_tests and list_gms
These binaries are used to generate a list of tests that can be run in a
target device and are useful for testing new devices
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Wed, 20 Jul 2022 02:47:44 +0000 (23:47 -0300)]
ci/skqp: Fix Nima-Cpp fetching error
Nima-Cpp is not available anymore inside googlesource, revert to github
one
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Tue, 2 Aug 2022 20:14:06 +0000 (17:14 -0300)]
ci/skqp: Fix paths in skqp-runner
Default results directory was fixed via $PWD variable, but it is safer
to use the same as init-stage2.sh uses: $CI_PROJECT_DIR to indicate the
results folder.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Wed, 20 Jul 2022 01:13:20 +0000 (22:13 -0300)]
ci/skqp: Show reports on crashes
Some skqp tests may crash the entire job run, assure that the reports
will be showed to the user after the test started to run.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>
Guilherme Gallo [Wed, 20 Jul 2022 00:41:55 +0000 (21:41 -0300)]
ci/skqp: Add an option to run all tests
When the skqp is introduced to a new driver, the best practice is to
run all available tests from skqp and classifying the
failing/crashing/flaking ones.
The default behavior of skqp is to run the tests from the commit where
the skqp built, which may not be adequate for the target driver.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835>