platform/upstream/libSkiaSharp.git
10 years agoPrefer to recycle non-RT scratch textures that don't have pending IO
bsalomon [Thu, 16 Oct 2014 02:04:14 +0000 (19:04 -0700)]
Prefer to recycle non-RT scratch textures that don't have pending IO

BUG=skia:2889

Review URL: https://codereview.chromium.org/650283002

10 years agoLast round of effect->processor (for now)
bsalomon [Thu, 16 Oct 2014 01:34:46 +0000 (18:34 -0700)]
Last round of effect->processor (for now)

R=joshualitt@google.com

Review URL: https://codereview.chromium.org/659803005

10 years agowebtry: Forgot onr log.Fatal.
Thiago Farina [Wed, 15 Oct 2014 22:20:27 +0000 (19:20 -0300)]
webtry: Forgot onr log.Fatal.

Update it to use glog variant.

BUG=skia:2980
TEST=go build webtry.go
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/659813003

10 years agowebtry: Switch from Go's log package to golang/glog.
tfarina [Wed, 15 Oct 2014 21:59:33 +0000 (14:59 -0700)]
webtry: Switch from Go's log package to golang/glog.

BUG=skia:2980
TEST=go get -d && go build webtry.go
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/655323002

10 years agoTreat (private, internal) grid bounds as doubly-inclusive in SkTileGrid.
mtklein [Wed, 15 Oct 2014 21:20:00 +0000 (14:20 -0700)]
Treat (private, internal) grid bounds as doubly-inclusive in SkTileGrid.

The net effect is that two "+1" instructions are removed from insert().
search() nets no change: two +1 removed, two +1 added.

When vectorized, this removes the need to add in userToGrid() at all and
so the need to read an awkward {0, 0, 1, 1} constant from memory.  Mostly
the benefit is less vector code to look at and think about.

BUG=skia:

Review URL: https://codereview.chromium.org/659823004

10 years agoDon't use 'defined' in macro expansion.
bungeman [Wed, 15 Oct 2014 20:53:54 +0000 (13:53 -0700)]
Don't use 'defined' in macro expansion.

A careful reading of the preprocessor specification indicates that
any use of the 'defined' operator outside the form of 'defined X' or
'defined ( X )' directly in the constant expression of a '#if' or
'#elif' may cause undefined behavior.

In particular, msvc is very unpredictable. The 'defined X' and
'defined ( X )' forms behave differently when created from marco
expansion, with 'defined ( X )' generally evaluating to '0L'. The
'defined X' form generally behaves more the way one would expect,
but still has a number of quirks which should simply be considered
undefined behavior.

BUG=chromium:419245

Review URL: https://codereview.chromium.org/657183002

10 years agoMove willUseInputColor check to computeInvariantOutput
egdaniel [Wed, 15 Oct 2014 20:49:02 +0000 (13:49 -0700)]
Move willUseInputColor check to computeInvariantOutput

BUG=skia:

Review URL: https://codereview.chromium.org/656503002

10 years agowebtry: Check the result of os.Chdir().
tfarina [Wed, 15 Oct 2014 20:48:47 +0000 (13:48 -0700)]
webtry: Check the result of os.Chdir().

As mentioned in http://golang.org/doc/effective_go.html#blank_assign,
errors are provided for a reason, so always check them.

The documentation for this function is available at
http://golang.org/pkg/os/#Chdir.

BUG=None
TEST=None
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/651343002

10 years agoAdds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
cdalton [Wed, 15 Oct 2014 20:43:48 +0000 (13:43 -0700)]
Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
all its commands interleaved in contiguous memory. GrTRecorder also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().

Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e

Review URL: https://codereview.chromium.org/628453002

10 years agoRemove unused NeedsDeepCopy.
scroggo [Wed, 15 Oct 2014 20:43:36 +0000 (13:43 -0700)]
Remove unused NeedsDeepCopy.

It was used to check to see if an SkPaint had mutable fields on it.
Now that all the fields are immutable, this function is no longer
used. Remove it.

BUG=skia:2097

Review URL: https://codereview.chromium.org/661543002

10 years agoRevert of JPEG YUV Decoding (patchset #5 id:180001 of https://codereview.chromium...
rmistry [Wed, 15 Oct 2014 20:15:58 +0000 (13:15 -0700)]
Revert of JPEG YUV Decoding (patchset #5 id:180001 of https://codereview.chromium.org/399683007/)

Reason for revert:
Caused many test bots to go red:
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/22/steps/dm/logs/stdio
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Link-HD4000-x86_64-Debug/builds/168/steps/dm/logs/stdio
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/38/steps/dm/logs/stdio

Original issue's description:
> JPEG YUV Decoding
>
> Enabling JPEG YUV Decoding in Skia
>
> BUG=skia:3005, skia:1674
>
> Committed: https://skia.googlesource.com/skia/+/8e6c3b93a39e19111662a760ede97df55e51d39f

TBR=reed@google.com,scroggo@google.com,sugoi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3005, skia:1674

Review URL: https://codereview.chromium.org/656163002

10 years agoWhitespace change to confirm Google Storage uploads are working
rmistry [Wed, 15 Oct 2014 18:58:48 +0000 (11:58 -0700)]
Whitespace change to confirm Google Storage uploads are working

BUG=skia:
TBR=
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/657083004

10 years agoMore effect->processor cleanup
bsalomon [Wed, 15 Oct 2014 18:25:21 +0000 (11:25 -0700)]
More effect->processor cleanup

R=joshualitt@google.com

Review URL: https://codereview.chromium.org/660563003

10 years agoSome cleanup in processor header files.
bsalomon [Wed, 15 Oct 2014 18:05:26 +0000 (11:05 -0700)]
Some cleanup in processor header files.

R=joshualitt@google.com

Review URL: https://codereview.chromium.org/659803004

10 years agoJPEG YUV Decoding
sugoi [Wed, 15 Oct 2014 18:04:17 +0000 (11:04 -0700)]
JPEG YUV Decoding

Enabling JPEG YUV Decoding in Skia

BUG=skia:3005, skia:1674

Review URL: https://codereview.chromium.org/399683007

10 years agoSplit GrFragmentProcessor into its own header
bsalomon [Wed, 15 Oct 2014 17:50:36 +0000 (10:50 -0700)]
Split GrFragmentProcessor into its own header

Review URL: https://codereview.chromium.org/660573002

10 years agoupdate dox for bounds in supersampler
reed [Wed, 15 Oct 2014 16:00:27 +0000 (09:00 -0700)]
update dox for bounds in supersampler

BUG=skia:
TBR=caryclark@google.com
NOTRY=True

Review URL: https://codereview.chromium.org/657793003

10 years agointeresct path bounds with clip bounds before initializing supersampler
reed [Wed, 15 Oct 2014 15:52:00 +0000 (08:52 -0700)]
interesct path bounds with clip bounds before initializing supersampler

BUG=skia:

Review URL: https://codereview.chromium.org/656473004

10 years agoPush isEqual/onIsEqual down from GrProcessor to subclasses.
bsalomon [Wed, 15 Oct 2014 15:19:04 +0000 (08:19 -0700)]
Push isEqual/onIsEqual down from GrProcessor to subclasses.

R=joshualitt@google.com

Review URL: https://codereview.chromium.org/654273002

10 years agoadd tests for large cordinates bounds when building aaclip
reed [Wed, 15 Oct 2014 14:05:09 +0000 (07:05 -0700)]
add tests for large cordinates bounds when building aaclip

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/658753002

10 years agobug_chomper: Consolidate public flag in a single place.
tfarina [Wed, 15 Oct 2014 03:14:03 +0000 (20:14 -0700)]
bug_chomper: Consolidate public flag in a single place.

BUG=None
TEST=./run_server.sh --help and ./run_server.sh -public
R=borenet@google.com

Review URL: https://codereview.chromium.org/649303003

10 years agoRevert of Create a single command buffer for GrInOrderDrawBuffer (patchset #17 id...
mtklein [Tue, 14 Oct 2014 21:29:30 +0000 (14:29 -0700)]
Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset #17 id:1240001 of https://codereview.chromium.org/628453002/)

Reason for revert:
Leaking memory:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/9/steps/gm/logs/stdio

Original issue's description:
> Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
> all its commands interleaved in contiguous memory. GrTRecorder also
> supports extra data associated with objects, so we can store arrays
> inline without having to call malloc().
>
> Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e

TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/654863003

10 years agoChanged "Profile" to "Cube" in ColorCube
sugoi [Tue, 14 Oct 2014 20:15:58 +0000 (13:15 -0700)]
Changed "Profile" to "Cube" in ColorCube

A few references to "profile" still existed in SkColorCubeFilter, so I removed them.

BUG=skia:

Review URL: https://codereview.chromium.org/651303002

10 years agoIgnore ubuntu nvprmsaa4/mixed_xfermodes GM result.
Brian Salomon [Tue, 14 Oct 2014 20:12:23 +0000 (16:12 -0400)]
Ignore ubuntu nvprmsaa4/mixed_xfermodes GM result.

BUG=skia:2443

Review URL: https://codereview.chromium.org/653153003

10 years agoRebaseline mixedxfermodes on ubuntu/nvprmsaa4
Brian Salomon [Tue, 14 Oct 2014 19:52:46 +0000 (15:52 -0400)]
Rebaseline mixedxfermodes on ubuntu/nvprmsaa4

TBR=

Review URL: https://codereview.chromium.org/657603005

10 years agoOnly use sized format on IMG/ES3 for single channel.
bsalomon [Tue, 14 Oct 2014 19:29:17 +0000 (12:29 -0700)]
Only use sized format on IMG/ES3 for single channel.

BUG=skia:2922

Review URL: https://codereview.chromium.org/638293004

10 years agoAdds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
cdalton [Tue, 14 Oct 2014 18:53:04 +0000 (11:53 -0700)]
Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
all its commands interleaved in contiguous memory. GrTRecorder also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().

Review URL: https://codereview.chromium.org/628453002

10 years agoRemove uses of GrAutoScratchTexture.
bsalomon [Tue, 14 Oct 2014 18:47:22 +0000 (11:47 -0700)]
Remove uses of GrAutoScratchTexture.

Rename GrContext::lockAndRefScratchTexture to refScratchTexture.

GrSurface::writePixels returns bool instead of void.

BUG=skia:2889

Review URL: https://codereview.chromium.org/638403003

10 years agoFlush text contexts before drawing text as path
bsalomon [Tue, 14 Oct 2014 17:52:00 +0000 (10:52 -0700)]
Flush text contexts before drawing text as path

BUG=416289

Review URL: https://codereview.chromium.org/636233008

10 years agowebtry: Simplify template construction.
tfarina [Tue, 14 Oct 2014 16:39:02 +0000 (09:39 -0700)]
webtry: Simplify template construction.

text/template and html/template both have a helper function called
"Must" that according to the docs in http://golang.org/pkg/text/template/#Must
and http://golang.org/pkg/html/template/#Must, wraps a call to a function
returning (*Template, error) and panics if the error is non-nil.

So we don't need to that ourselves. Which is a good thing and makes code
cleaner.

BUG=None
TEST=None
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/642243004

10 years agocreate and modify matrices in lua
reed [Tue, 14 Oct 2014 16:34:52 +0000 (09:34 -0700)]
create and modify matrices in lua

BUG=skia:

Review URL: https://codereview.chromium.org/651823004

10 years agoChange GrTextContext fallbacks to be a linked list chain.
jvanverth [Tue, 14 Oct 2014 15:45:50 +0000 (08:45 -0700)]
Change GrTextContext fallbacks to be a linked list chain.

Preliminary work for getting color emoji working with
distance field text.

BUG=skia:2887

Review URL: https://codereview.chromium.org/650273003

10 years agoUse GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure of FP...
bsalomon [Tue, 14 Oct 2014 15:40:57 +0000 (08:40 -0700)]
Use GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure of FP creation in SkImageFilter

BUG=skia:2922

Review URL: https://codereview.chromium.org/656853002

10 years agonanobench: flush after recording every Nth data point.
mtklein [Tue, 14 Oct 2014 15:40:43 +0000 (08:40 -0700)]
nanobench: flush after recording every Nth data point.

Got to keep our precious data in event of a crash.

With --flushEvery 10 I'm not seeing this cost any wall time.

BUG=skia:

Review URL: https://codereview.chromium.org/653083003

10 years agoadd gamma value to deviceproperties
reed [Tue, 14 Oct 2014 15:26:33 +0000 (08:26 -0700)]
add gamma value to deviceproperties

BUG=skia:

Review URL: https://codereview.chromium.org/652273002

10 years agoAdjust skimage expectations for Android reference device
borenet [Tue, 14 Oct 2014 15:05:59 +0000 (08:05 -0700)]
Adjust skimage expectations for Android reference device

BUG=skia:3012

Review URL: https://codereview.chromium.org/650223004

10 years agoAdd GrLayerCache::writeLayersToDisk
robertphillips [Tue, 14 Oct 2014 14:07:59 +0000 (07:07 -0700)]
Add GrLayerCache::writeLayersToDisk

I'm tired of readding this capability whenever I need to debug.

Review URL: https://codereview.chromium.org/654653006

10 years agoTrack if all stages modulate inputColor in computeInvariantOutput
egdaniel [Tue, 14 Oct 2014 13:48:46 +0000 (06:48 -0700)]
Track if all stages modulate inputColor in computeInvariantOutput

BUG=skia:

Review URL: https://codereview.chromium.org/647863002

10 years agoFix links to skia-buildbot code in preparation for deletion
borenet [Tue, 14 Oct 2014 11:44:44 +0000 (04:44 -0700)]
Fix links to skia-buildbot code in preparation for deletion

BUG=skia:761

Review URL: https://codereview.chromium.org/655643002

10 years agoparse outline to generate slides
reed [Tue, 14 Oct 2014 02:43:17 +0000 (19:43 -0700)]
parse outline to generate slides

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/643113005

10 years agoRe-land ganesh checkbox. I needed to increase the size of the address
Greg Humphreys [Tue, 14 Oct 2014 01:52:05 +0000 (21:52 -0400)]
Re-land ganesh checkbox. I needed to increase the size of the address
space available to a fiddle because linking against libGL causes the
amount of memory used by a process to bloat to over 100M.  Yikes.

BUG=skia:

Review URL: https://codereview.chromium.org/638003008

10 years agoRevert of add ganesh checkbox to skfiddle interface (patchset #6 id:270001 of https...
humper [Mon, 13 Oct 2014 23:05:05 +0000 (16:05 -0700)]
Revert of add ganesh checkbox to skfiddle interface (patchset #6 id:270001 of https://codereview.chromium.org/649313002/)

Reason for revert:
adding -Dskia_mesa=1 broke production; don't yet know why and don't want to leave things in a broken state.

Original issue's description:
> add ganesh checkbox to skfiddle interface
>
> BUG=skia:
> R=mtklein@google.com, tfarina@chromium.org
>
> Committed: https://skia.googlesource.com/skia/+/ccb54895c614632fd01d22b64ab614921f980eb1

TBR=tfarina@chromium.org,jcgregorio@google.com,mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/655633003

10 years agoadd ganesh checkbox to skfiddle interface
Greg Humphreys [Mon, 13 Oct 2014 22:12:33 +0000 (18:12 -0400)]
add ganesh checkbox to skfiddle interface

BUG=skia:
R=mtklein@google.com, tfarina@chromium.org

Review URL: https://codereview.chromium.org/649313002

10 years agoRevert of No threadsafe statics. (patchset #1 id:1 of https://codereview.chromium...
mtklein [Mon, 13 Oct 2014 21:50:41 +0000 (14:50 -0700)]
Revert of No threadsafe statics. (patchset #1 id:1 of https://codereview.chromium.org/654663002/)

Reason for revert:
Want to think about how to do this only to skialib and not to tools (gms, tests, etc.)

Original issue's description:
> No threadsafe statics.
>
> Chrome disables these for speed and code size, so we need
> to disable them to make sure our code is safe when used
> this way.
>
>     int foo() {
>         static int32_t atomic_thing;
>         return sk_atomic_inc(&atomic_thing);
>     }
>
> is not safe in Chrome.  Making the static global is:
>
>     static int32_t atomic_thing;
>     int foo() {
>         return sk_atomic_inc(&atomic_thing);
>     }
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221

TBR=bungeman@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/649343003

10 years agoRevert of Create a single command buffer for GrInOrderDrawBuffer (patchset #14 id...
mtklein [Mon, 13 Oct 2014 21:00:42 +0000 (14:00 -0700)]
Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset #14 id:1050001 of https://codereview.chromium.org/628453002/)

Reason for revert:
New test failing on Android: http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus7-Tegra3-Arm7-Release/builds/89/steps/dm/logs/stdio

Original issue's description:
> Adds a GrTBaseList class that GrInOrderDrawBuffer uses to allocate
> all its commands interleaved in contiguous memory. GrTBaseList also
> supports extra data associated with objects, so we can store arrays
> inline without having to call malloc().
>
> Committed: https://skia.googlesource.com/skia/+/47c844aaba81e5a29c773b660e1d6062c766d253

TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/652843002

10 years agoLink to skiadocs site, since that is the canonical location for documentation.
Thiago Farina [Mon, 13 Oct 2014 20:56:30 +0000 (17:56 -0300)]
Link to skiadocs site, since that is the canonical location for documentation.

BUG=None
TEST=None
R=borenet@google.com, rmistry@google.com

Review URL: https://codereview.chromium.org/646853002

10 years agoexperimental parser
reed [Mon, 13 Oct 2014 20:53:48 +0000 (13:53 -0700)]
experimental parser

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/651023002

10 years agoFix reference to non-existant 'tests' target.
Thiago Farina [Mon, 13 Oct 2014 20:51:57 +0000 (17:51 -0300)]
Fix reference to non-existant 'tests' target.

This target was previously folded into dm. Do not advertise it anymore.

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/646843002

10 years agoRequire SK_DECLARE_STATIC_LAZY_PTR is used in global scope.
mtklein [Mon, 13 Oct 2014 20:17:56 +0000 (13:17 -0700)]
Require SK_DECLARE_STATIC_LAZY_PTR is used in global scope.

Function- or method- local scope isn't threadsafe; the pointer is generally
zero-initialized on first use in function scope (i.e. lazily... we have to go
deeper), but for globals we can be pretty sure the linker will do that for us.

BUG=skia:

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/651723003

10 years agoArchive svndiff script.
tfarina [Mon, 13 Oct 2014 19:58:33 +0000 (12:58 -0700)]
Archive svndiff script.

Nobody is using this script anymore, so to prevent more changes to it,
let's remove it now.

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/646043002

10 years agoCreate helper functions to use in computeInvariantOutput calls
egdaniel [Mon, 13 Oct 2014 19:53:46 +0000 (12:53 -0700)]
Create helper functions to use in computeInvariantOutput calls

BUG=skia:

Review URL: https://codereview.chromium.org/643743003

10 years agoNo threadsafe statics.
mtklein [Mon, 13 Oct 2014 19:53:27 +0000 (12:53 -0700)]
No threadsafe statics.

Chrome disables these for speed and code size, so we need
to disable them to make sure our code is safe when used
this way.

    int foo() {
        static int32_t atomic_thing;
        return sk_atomic_inc(&atomic_thing);
    }

is not safe in Chrome.  Making the static global is:

    static int32_t atomic_thing;
    int foo() {
        return sk_atomic_inc(&atomic_thing);
    }

BUG=skia:

Review URL: https://codereview.chromium.org/654663002

10 years agoFix race in supports_simd().
mtklein [Mon, 13 Oct 2014 19:48:16 +0000 (12:48 -0700)]
Fix race in supports_simd().

Local statics are not thread safe in Chrome.  Use an SkLazyPtr instead.

See https://code.google.com/p/chromium/issues/detail?id=418041

BUG=418041

Review URL: https://codereview.chromium.org/655573002

10 years agoEnable color emoji GM on Android
jvanverth [Mon, 13 Oct 2014 19:48:10 +0000 (12:48 -0700)]
Enable color emoji GM on Android

BUG=skia:2887

Review URL: https://codereview.chromium.org/656433002

10 years agoAdds a GrTBaseList class that GrInOrderDrawBuffer uses to allocate
cdalton [Mon, 13 Oct 2014 19:43:10 +0000 (12:43 -0700)]
Adds a GrTBaseList class that GrInOrderDrawBuffer uses to allocate
all its commands interleaved in contiguous memory. GrTBaseList also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().

Review URL: https://codereview.chromium.org/628453002

10 years agobug_chomper: Make server's port configurable.
tfarina [Mon, 13 Oct 2014 19:43:01 +0000 (12:43 -0700)]
bug_chomper: Make server's port configurable.

Make 'port' a flag so you can change it from the command line, making the
server more flexible and allowing us to change in which port it listen
to requests.

$ ./run_server.sh --port :8002

BUG=None
TEST=see above
R=borenet@google.com

Review URL: https://codereview.chromium.org/649663003

10 years agoadd pictures to lua
reed [Mon, 13 Oct 2014 19:38:04 +0000 (12:38 -0700)]
add pictures to lua

BUG=skia:

Review URL: https://codereview.chromium.org/650263002

10 years agoFix webtry setup once instructions in README doc.
tfarina [Mon, 13 Oct 2014 19:37:52 +0000 (12:37 -0700)]
Fix webtry setup once instructions in README doc.

BUG=None
TEST=NOne
R=humper@google.com
TBR=humper@google.com

Review URL: https://codereview.chromium.org/648563003

10 years agoDevirtualize read/write pixels on surface.
bsalomon [Mon, 13 Oct 2014 19:32:55 +0000 (12:32 -0700)]
Devirtualize read/write pixels on surface.

Consolidate read/write funcs in context.

Remove support for reading pixels from a surface that's not a target. It's currently broken and neither used nor tested.

Review URL: https://codereview.chromium.org/648863002

10 years agoAllow GCC to build Skia on Mac.
mtklein [Mon, 13 Oct 2014 19:32:34 +0000 (12:32 -0700)]
Allow GCC to build Skia on Mac.

GCC doesn't understand -fasm-blocks or -mpascal-strings, but we don't care
about them.

While looking around in Gyp, I noticed a better way to disable warnings about
offsetof so that it doesn't tell us "disabling this warning makes no sense in C"
for every C source file we compile.

BUG=skia:

Review URL: https://codereview.chromium.org/650553002

10 years agoadd support for skfiddle width/height options
Greg Humphreys [Mon, 13 Oct 2014 17:58:09 +0000 (13:58 -0400)]
add support for skfiddle width/height options

BUG=skia:
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/656463002

10 years agoWhitespace change to trigger builds
borenet [Mon, 13 Oct 2014 16:52:20 +0000 (09:52 -0700)]
Whitespace change to trigger builds

BUG=skia:761
TBR=rmistry
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/621353002

10 years agoWhitespace change to test the CQ's new trybots
rmistry [Mon, 13 Oct 2014 13:02:28 +0000 (06:02 -0700)]
Whitespace change to test the CQ's new trybots

BUG=skia:2973
TBR=
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/654463003

10 years agoadd fade_slide transition to lua slides
reed [Mon, 13 Oct 2014 02:05:52 +0000 (19:05 -0700)]
add fade_slide transition to lua slides

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/646613004

10 years agoadd canvas:clear to lua
reed [Sun, 12 Oct 2014 19:18:40 +0000 (12:18 -0700)]
add canvas:clear to lua

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/648083002

10 years agoadd surfaces to lua
reed [Sun, 12 Oct 2014 17:36:47 +0000 (10:36 -0700)]
add surfaces to lua

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/649973002

10 years agoFix leak in GLPrograms test.
bsalomon [Sun, 12 Oct 2014 12:40:00 +0000 (05:40 -0700)]
Fix leak in GLPrograms test.

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/648063002

10 years agoadd key handlers to lua
reed [Sat, 11 Oct 2014 20:13:11 +0000 (13:13 -0700)]
add key handlers to lua

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/652473002

10 years agoallow for lua click handlers
reed [Sat, 11 Oct 2014 18:28:07 +0000 (11:28 -0700)]
allow for lua click handlers

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/649013002

10 years agomove test for lua into separate resource file
reed [Sat, 11 Oct 2014 03:31:24 +0000 (20:31 -0700)]
move test for lua into separate resource file

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/645283002

10 years agobug_chomper: Use parenthesized declaration style for const and vars.
tfarina [Sat, 11 Oct 2014 01:40:45 +0000 (18:40 -0700)]
bug_chomper: Use parenthesized declaration style for const and vars.

It seems cleaner that way and nicer to read, also avoids repeating
'const' and 'var' everytime you have to add more items.

BUG=None
TEST=./run_server.sh
R=borenet@google.com

Review URL: https://codereview.chromium.org/645803003

10 years agoOpt state takes a GP instead of a GeometryStage
joshualitt [Sat, 11 Oct 2014 00:47:00 +0000 (17:47 -0700)]
Opt state takes a GP instead of a GeometryStage

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/71856d520461ae025a0332aa0ce9735a096d9baf

Review URL: https://codereview.chromium.org/637003003

10 years agoadd drawImageRect to lua, update sample
reed [Fri, 10 Oct 2014 22:28:19 +0000 (15:28 -0700)]
add drawImageRect to lua, update sample

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/642353005

10 years agoRevert of Opt state takes a GP instead of a GeometryStage (patchset #18 id:1500001...
joshualitt [Fri, 10 Oct 2014 21:11:59 +0000 (14:11 -0700)]
Revert of Opt state takes a GP instead of a GeometryStage (patchset #18 id:1500001 of https://codereview.chromium.org/637003003/)

Reason for revert:
Revert because this may be causing a break in a chrome gpu test

Original issue's description:
> Opt state takes a GP instead of a GeometryStage
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/71856d520461ae025a0332aa0ce9735a096d9baf

TBR=bsalomon@google.com,egdaniel@google.com,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/647183002

10 years agoRemove empty recordy.gypi file.
tfarina [Fri, 10 Oct 2014 20:34:25 +0000 (13:34 -0700)]
Remove empty recordy.gypi file.

Fixes the TODO in that file.

BUG=None
TEST=None
R=mtklein@google.com

Review URL: https://codereview.chromium.org/643543002

10 years agoUpdate coloremoji expectations
jvanverth [Fri, 10 Oct 2014 19:58:46 +0000 (12:58 -0700)]
Update coloremoji expectations

TBR=reed@google.com
BUG=skia:2887

Review URL: https://codereview.chromium.org/649753003

10 years agoFix bug in GrCachedLayer reuse
robertphillips [Fri, 10 Oct 2014 18:38:29 +0000 (11:38 -0700)]
Fix bug in GrCachedLayer reuse

In the new MultiPictureDraw tests a single hoisted layer is reused multiple times. The previous plot locking scheme allowed GrCachedLayer objects to be aggressively deleted prematurely leaving the reusing GrHoistedLayer objects with dangling pointers.

This CL changes adds a new pseudo-ref to GrCachedLayer. (It can't be a real ref since the cached layers aren't deleted when it goes to 0).

NOTRY=true

Committed: https://skia.googlesource.com/skia/+/5c481666c9678f43e039ad605457be3854cf8de3

Review URL: https://codereview.chromium.org/640323002

10 years agoFix color emoji.
jvanverth [Fri, 10 Oct 2014 18:36:12 +0000 (11:36 -0700)]
Fix color emoji.

Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

Review URL: https://codereview.chromium.org/636183005

10 years agoOpt state takes a GP instead of a GeometryStage
joshualitt [Fri, 10 Oct 2014 16:56:55 +0000 (09:56 -0700)]
Opt state takes a GP instead of a GeometryStage

BUG=skia:

Review URL: https://codereview.chromium.org/637003003

10 years agodetect --loops is < 0 and interpret that as running forever (mostly)
reed [Fri, 10 Oct 2014 16:09:52 +0000 (09:09 -0700)]
detect --loops is < 0 and interpret that as running forever (mostly)

BUG=skia:

Review URL: https://codereview.chromium.org/643143002

10 years agoRevert of Fix color emoji. (patchset #11 id:320001 of https://codereview.chromium...
jvanverth [Fri, 10 Oct 2014 15:52:03 +0000 (08:52 -0700)]
Revert of Fix color emoji. (patchset #11 id:320001 of https://codereview.chromium.org/636183005/)

Reason for revert:
Crashing the Windows bots.

Original issue's description:
> Fix color emoji.
>
> Removes the GrMaskFormat and single atlas in GrTextStrike.
> Replaces it by storing the GrMaskFormat in each GrGlyph, and
> doing a lookup for the correct atlas based on that.
>
> Disables color glyph rendering in GrDistanceFieldTextContext
> for now.
>
> BUG=skia:2887
>
> Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

TBR=robertphillips@google.com,bungeman@google.com,reed@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2887

Review URL: https://codereview.chromium.org/640413004

10 years agoFix color emoji.
jvanverth [Fri, 10 Oct 2014 15:21:29 +0000 (08:21 -0700)]
Fix color emoji.

Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Review URL: https://codereview.chromium.org/636183005

10 years agoIgnore complexclip_path_aa on Win7-HD2000 for the moment.
jvanverth [Fri, 10 Oct 2014 14:14:55 +0000 (07:14 -0700)]
Ignore complexclip_path_aa on Win7-HD2000 for the moment.

TBR=reed@google.com
BUG=skia:3006

Review URL: https://codereview.chromium.org/643103002

10 years agoupdating expectations
joshualitt [Fri, 10 Oct 2014 13:48:48 +0000 (06:48 -0700)]
updating expectations

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/646963002

10 years agoTurn SkCanvasStateUtils into a class with static functions.
tfarina [Fri, 10 Oct 2014 13:19:09 +0000 (06:19 -0700)]
Turn SkCanvasStateUtils into a class with static functions.

That simplifies the way to declare it a friend, as needed in SkCanvas.

BUG=skia:2914
TEST=make most
R=reed@google.com

Review URL: https://codereview.chromium.org/645773002

10 years agofaster SkRect::sort
reed [Fri, 10 Oct 2014 12:50:15 +0000 (05:50 -0700)]
faster SkRect::sort

BUG=skia:

Review URL: https://codereview.chromium.org/646863002

10 years agoAdd template.cpp to gitignore.
tfarina [Fri, 10 Oct 2014 12:20:51 +0000 (05:20 -0700)]
Add template.cpp to gitignore.

It is generated experimental/webtry/build script, not checked-in the
source tree.

BUG=None
TEST=git status do not show it anymore as untracked file.
R=humper@google.com

Review URL: https://codereview.chromium.org/647633002

10 years agoUpdate SKP version to 122
borenet [Fri, 10 Oct 2014 04:26:14 +0000 (21:26 -0700)]
Update SKP version to 122

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/647663002

10 years agoUse the function recently added to common in svndiff.py
Thiago Farina [Fri, 10 Oct 2014 03:25:29 +0000 (00:25 -0300)]
Use the function recently added to common in svndiff.py

GetModifiedFiles() function was added to common repo in
https://skia.googlesource.com/common/+/af1de867422c42855ae54ed3838c62ea445ea6b4

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/634313006

10 years agoUse BBH reserve hook to preallocate space for tiles.
mtklein [Fri, 10 Oct 2014 01:22:41 +0000 (18:22 -0700)]
Use BBH reserve hook to preallocate space for tiles.

Before getting too far into changing how SkTileGrid stores its tiles, I figured I'd
better see how much I can tweak out the existing format.  Cleverly, that way
any improvements I make by changing the format will look that much less
impressive.

This CL looks like it will be a 5-15% win in time spent recording, with no effect
on playback.

This CL also shrinks the tiles to fit exactly when we're done inserting,
using newly added SkTDArray::shrinkToFit().  It's quite cheap to run (maybe
taking back 1-2% from those 5-15% wins), and means we'll lug around about 15%
fewer bytes in the tile grids.  Note though this strategy temporarily uses up to
30% more memory while building the tile grid.  For our largest SKPs, that's
maybe 75-100K extra.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/52455cbc02d7f480d988ae7cdacc11ad69078c2c

CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot

Review URL: https://codereview.chromium.org/639823005

10 years agoRemove unused SaveLayerInfo::fValid field
robertphillips [Thu, 9 Oct 2014 23:43:42 +0000 (16:43 -0700)]
Remove unused SaveLayerInfo::fValid field

Minor code cleanup

Review URL: https://codereview.chromium.org/643713002

10 years agoRefactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key
robertphillips [Thu, 9 Oct 2014 22:36:06 +0000 (15:36 -0700)]
Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key

NOTRY=true

Committed: https://skia.googlesource.com/skia/+/27415b71bd529456165945e19b5b7efbebf6fb51

Review URL: https://codereview.chromium.org/640373002

10 years agoFPs now use the correct builder types(just a rename)
joshualitt [Thu, 9 Oct 2014 22:04:05 +0000 (15:04 -0700)]
FPs now use the correct builder types(just a rename)

BUG=skia:

Review URL: https://codereview.chromium.org/648463003

10 years agocleanup and optimize rect intersect routines
reed [Thu, 9 Oct 2014 21:29:01 +0000 (14:29 -0700)]
cleanup and optimize rect intersect routines

BUG=skia:

Review URL: https://codereview.chromium.org/640723004

10 years agoRevert of Use BBH reserve hook to preallocate space for tiles. (patchset #2 id:80001...
mtklein [Thu, 9 Oct 2014 20:55:20 +0000 (13:55 -0700)]
Revert of Use BBH reserve hook to preallocate space for tiles. (patchset #2 id:80001 of https://codereview.chromium.org/639823005/)

Reason for revert:
failed assertion "fXTiles * fYTiles != 0"

Original issue's description:
> Use BBH reserve hook to preallocate space for tiles.
>
> Before getting too far into changing how SkTileGrid stores its tiles, I figured I'd
> better see how much I can tweak out the existing format.  Cleverly, that way
> any improvements I make by changing the format will look that much less
> impressive.
>
> This CL looks like it will be a 5-15% win in time spent recording, with no effect
> on playback.
>
> This CL also shrinks the tiles to fit exactly when we're done inserting,
> using newly added SkTDArray::shrinkToFit().  It's quite cheap to run (maybe
> taking back 1-2% from those 5-15% wins), and means we'll lug around about 15%
> fewer bytes in the tile grids.  Note though this strategy temporarily uses up to
> 30% more memory while building the tile grid.  For our largest SKPs, that's
> maybe 75-100K extra.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/52455cbc02d7f480d988ae7cdacc11ad69078c2c

TBR=reed@google.com,robertphillips@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/642933002

10 years agoStore color and coverage stages in a single array in GrOptDrawState.
egdaniel [Thu, 9 Oct 2014 20:47:05 +0000 (13:47 -0700)]
Store color and coverage stages in a single array in GrOptDrawState.

BUG=skia:

Review URL: https://codereview.chromium.org/641223002

10 years agoForce linking of static member variables for GLPrograms
joshualitt [Thu, 9 Oct 2014 20:12:35 +0000 (13:12 -0700)]
Force linking of static member variables for GLPrograms

BUG=skia:

Review URL: https://codereview.chromium.org/614163002

10 years agoRevert of Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache...
robertphillips [Thu, 9 Oct 2014 19:47:08 +0000 (12:47 -0700)]
Revert of Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key (patchset #1 id:1 of https://codereview.chromium.org/640373002/)

Reason for revert:
Failing unit tests

Original issue's description:
> Refactor GrLayerHoister::FindLayersToHoist to prep for adding clip to cache key
>
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/27415b71bd529456165945e19b5b7efbebf6fb51

TBR=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/644823003

10 years agoRevert of Fix bug in plot locking system (patchset #3 id:80001 of https://codereview...
robertphillips [Thu, 9 Oct 2014 19:47:01 +0000 (12:47 -0700)]
Revert of Fix bug in plot locking system (patchset #3 id:80001 of https://codereview.chromium.org/640323002/)

Reason for revert:
Failing unit tests

Original issue's description:
> Fix bug in plot locking system
>
> In the new MultiPictureDraw tests a single hoisted layer is reused multiple times. The previous plot locking scheme allowed GrCachedLayer objects to be aggressively deleted prematurely leaving the reusing GrHoistedLayer objects with dangling pointers.
>
> This CL changes the plot locking system to add a pseudo-ref for each GrHoistedLayer.
>
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/5c481666c9678f43e039ad605457be3854cf8de3

TBR=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/643673004

10 years agoUpdate expectations for distance field path rendering.
jvanverth [Thu, 9 Oct 2014 19:37:35 +0000 (12:37 -0700)]
Update expectations for distance field path rendering.

TBR=reed@google.com

Review URL: https://codereview.chromium.org/641203002