From: Youngwoo Cho <young222.cho@samsung.com>
Date: Tue, 23 Jan 2024 09:44:36 +0000 (+0900)
Subject: Fix coverity issues
X-Git-Tag: accepted/tizen/8.0/unified/20240131.175832^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Ftizen_8.0;p=platform%2Fcore%2Fmultimedia%2Fesplusplayer.git

Fix coverity issues

- MISSING_LOCK

Change-Id: I84fc258facaac6e6c3fff29d403938b58c687422
Signed-off-by: Youngwoo Cho <young222.cho@samsung.com>
(cherry picked from commit 553306804cf44220f9124f4a82f0061ea904c000)
---

diff --git a/src/esplusplayer/src/esplayer.cpp b/src/esplusplayer/src/esplayer.cpp
index cf41e57..5ac49bb 100644
--- a/src/esplusplayer/src/esplayer.cpp
+++ b/src/esplusplayer/src/esplayer.cpp
@@ -367,15 +367,15 @@ bool EsPlayer::Close() {
     Stop();
   }
   auto op = [this]() noexcept {
-    if (is_msg_task_stop_ == false) {
-      {
-        std::unique_lock<std::mutex> msg_mutex(msg_task_mutex_);
+    {
+      std::unique_lock<std::mutex> msg_mutex(msg_task_mutex_);
+      if (is_msg_task_stop_ == false) {
         is_msg_task_stop_ = true;
+        msg_mutex.unlock();
+        msg_task_cv_.notify_one();
+        if (msg_handler_task_.valid()) msg_handler_task_.wait();
       }
-      msg_task_cv_.notify_one();
-      if (msg_handler_task_.valid()) msg_handler_task_.wait();
     }
-
     if (trackrenderer_) trackrenderer_.reset();
     ResetContextForClose_();
     LOG_LEAVE_P(this);
@@ -1359,6 +1359,8 @@ void EsPlayer::ResetContextForClose_() {
   is_resource_conflicted_ = false;
   app_info_ = PlayerAppInfo();
   src_queue_size_ = SrcQueueSize();
+
+  std::lock_guard<std::mutex> msg_mutex(msg_task_mutex_);
   is_msg_task_stop_ = false;
 }