From: Donghak PARK <donghak.park@samsung.com>
Date: Wed, 20 Sep 2023 10:37:39 +0000 (+0900)
Subject: [Coverity] Fix Coverity issue
X-Git-Tag: accepted/tizen/unified/20230925.160804^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Ftizen_8.0;p=platform%2Fcore%2Fml%2Fnntrainer.git

[Coverity] Fix Coverity issue

For fix uninitialzed output_axis set default output_axis as 3
- in tensor.h file

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
---

diff --git a/nntrainer/tensor/blas_neon.cpp b/nntrainer/tensor/blas_neon.cpp
index 1af46a7d..62e8edd5 100644
--- a/nntrainer/tensor/blas_neon.cpp
+++ b/nntrainer/tensor/blas_neon.cpp
@@ -12,6 +12,7 @@
  */
 
 #include <blas_neon.h>
+#include <memory>
 #include <nntrainer_error.h>
 #include <nntrainer_log.h>
 
@@ -145,10 +146,6 @@ void sgemv_transpose_neon(const float *A, const float *X, float *Y,
   if (cols % 16 == 0) {
     unsigned int n = cols / 16;
     bool *initialized = (bool *)malloc(sizeof(bool) * n);
-    if (initialized == nullptr) {
-      ml_loge("failed to malloc");
-      return;
-    }
 
     unsigned int step;
     for (unsigned int i = 0; i < cols / 16; ++i) {
@@ -246,7 +243,7 @@ void sgemv_transpose_neon(const float *A, const float *X, float *Y,
     return;
   } else if (cols % 4 == 0) {
     unsigned int n = cols / 4;
-    bool *initialized = (bool *)malloc(sizeof(bool) * n);
+    auto initialized = std::make_unique<bool[]>(n);
     if (initialized == nullptr) {
       ml_loge("Error : Memory allocation failed");
       return;
@@ -281,7 +278,6 @@ void sgemv_transpose_neon(const float *A, const float *X, float *Y,
         vst1q_f32(&y[0], y0_3);
       }
     }
-    free(initialized);
   }
 
   return;
diff --git a/nntrainer/tensor/tensor.h b/nntrainer/tensor/tensor.h
index 32cf041c..c1c5df66 100644
--- a/nntrainer/tensor/tensor.h
+++ b/nntrainer/tensor/tensor.h
@@ -98,6 +98,7 @@ public:
     name(name_),
     data(nullptr),
     offset(0),
+    output_axis(3),
     src_tensor() {}
 
   /**
@@ -231,7 +232,7 @@ public:
     offset = 0;
     contiguous = true;
     initializer = Initializer::NONE;
-
+    output_axis = 3;
     // if fm == Tformat::NCHW, then dim[0] == batch , dim[1] == channel, dim[2]
     // == height, dim[3] == width. and if fm == Tformat::NHWC, dim[0] == batch,
     // dim[1] == height, dim[2] == width, dim[3] == channel
@@ -392,6 +393,7 @@ public:
     offset = 0;
     contiguous = true;
     initializer = Initializer::NONE;
+    output_axis = 3;
 
     // if fm == Tformat::NCHW, then dim[0] == batch , dim[1] == channel, dim[2]
     // == height, dim[3] == width. and if fm == Tformat::NHWC, dim[0] == batch,